xref: /openbmc/linux/drivers/mfd/twl-core.c (revision 81d67439)
1 /*
2  * twl_core.c - driver for TWL4030/TWL5030/TWL60X0/TPS659x0 PM
3  * and audio CODEC devices
4  *
5  * Copyright (C) 2005-2006 Texas Instruments, Inc.
6  *
7  * Modifications to defer interrupt handling to a kernel thread:
8  * Copyright (C) 2006 MontaVista Software, Inc.
9  *
10  * Based on tlv320aic23.c:
11  * Copyright (c) by Kai Svahn <kai.svahn@nokia.com>
12  *
13  * Code cleanup and modifications to IRQ handler.
14  * by syed khasim <x0khasim@ti.com>
15  *
16  * This program is free software; you can redistribute it and/or modify
17  * it under the terms of the GNU General Public License as published by
18  * the Free Software Foundation; either version 2 of the License, or
19  * (at your option) any later version.
20  *
21  * This program is distributed in the hope that it will be useful,
22  * but WITHOUT ANY WARRANTY; without even the implied warranty of
23  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
24  * GNU General Public License for more details.
25  *
26  * You should have received a copy of the GNU General Public License
27  * along with this program; if not, write to the Free Software
28  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA
29  */
30 
31 #include <linux/init.h>
32 #include <linux/mutex.h>
33 #include <linux/platform_device.h>
34 #include <linux/clk.h>
35 #include <linux/err.h>
36 
37 #include <linux/regulator/machine.h>
38 
39 #include <linux/i2c.h>
40 #include <linux/i2c/twl.h>
41 
42 #if defined(CONFIG_ARCH_OMAP2) || defined(CONFIG_ARCH_OMAP3)
43 #include <plat/cpu.h>
44 #endif
45 
46 /*
47  * The TWL4030 "Triton 2" is one of a family of a multi-function "Power
48  * Management and System Companion Device" chips originally designed for
49  * use in OMAP2 and OMAP 3 based systems.  Its control interfaces use I2C,
50  * often at around 3 Mbit/sec, including for interrupt handling.
51  *
52  * This driver core provides genirq support for the interrupts emitted,
53  * by the various modules, and exports register access primitives.
54  *
55  * FIXME this driver currently requires use of the first interrupt line
56  * (and associated registers).
57  */
58 
59 #define DRIVER_NAME			"twl"
60 
61 #if defined(CONFIG_KEYBOARD_TWL4030) || defined(CONFIG_KEYBOARD_TWL4030_MODULE)
62 #define twl_has_keypad()	true
63 #else
64 #define twl_has_keypad()	false
65 #endif
66 
67 #if defined(CONFIG_GPIO_TWL4030) || defined(CONFIG_GPIO_TWL4030_MODULE)
68 #define twl_has_gpio()	true
69 #else
70 #define twl_has_gpio()	false
71 #endif
72 
73 #if defined(CONFIG_REGULATOR_TWL4030) \
74 	|| defined(CONFIG_REGULATOR_TWL4030_MODULE)
75 #define twl_has_regulator()	true
76 #else
77 #define twl_has_regulator()	false
78 #endif
79 
80 #if defined(CONFIG_TWL4030_MADC) || defined(CONFIG_TWL4030_MADC_MODULE)
81 #define twl_has_madc()	true
82 #else
83 #define twl_has_madc()	false
84 #endif
85 
86 #ifdef CONFIG_TWL4030_POWER
87 #define twl_has_power()        true
88 #else
89 #define twl_has_power()        false
90 #endif
91 
92 #if defined(CONFIG_RTC_DRV_TWL4030) || defined(CONFIG_RTC_DRV_TWL4030_MODULE)
93 #define twl_has_rtc()	true
94 #else
95 #define twl_has_rtc()	false
96 #endif
97 
98 #if defined(CONFIG_TWL4030_USB) || defined(CONFIG_TWL4030_USB_MODULE) ||\
99 	defined(CONFIG_TWL6030_USB) || defined(CONFIG_TWL6030_USB_MODULE)
100 #define twl_has_usb()	true
101 #else
102 #define twl_has_usb()	false
103 #endif
104 
105 #if defined(CONFIG_TWL4030_WATCHDOG) || \
106 	defined(CONFIG_TWL4030_WATCHDOG_MODULE)
107 #define twl_has_watchdog()        true
108 #else
109 #define twl_has_watchdog()        false
110 #endif
111 
112 #if defined(CONFIG_TWL4030_CODEC) || defined(CONFIG_TWL4030_CODEC_MODULE) ||\
113 	defined(CONFIG_SND_SOC_TWL6040) || defined(CONFIG_SND_SOC_TWL6040_MODULE)
114 #define twl_has_codec()	true
115 #else
116 #define twl_has_codec()	false
117 #endif
118 
119 #if defined(CONFIG_CHARGER_TWL4030) || defined(CONFIG_CHARGER_TWL4030_MODULE)
120 #define twl_has_bci()	true
121 #else
122 #define twl_has_bci()	false
123 #endif
124 
125 /* Triton Core internal information (BEGIN) */
126 
127 /* Last - for index max*/
128 #define TWL4030_MODULE_LAST		TWL4030_MODULE_SECURED_REG
129 
130 #define TWL_NUM_SLAVES		4
131 
132 #if defined(CONFIG_INPUT_TWL4030_PWRBUTTON) \
133 	|| defined(CONFIG_INPUT_TWL4030_PWRBUTTON_MODULE)
134 #define twl_has_pwrbutton()	true
135 #else
136 #define twl_has_pwrbutton()	false
137 #endif
138 
139 #define SUB_CHIP_ID0 0
140 #define SUB_CHIP_ID1 1
141 #define SUB_CHIP_ID2 2
142 #define SUB_CHIP_ID3 3
143 
144 #define TWL_MODULE_LAST TWL4030_MODULE_LAST
145 
146 /* Base Address defns for twl4030_map[] */
147 
148 /* subchip/slave 0 - USB ID */
149 #define TWL4030_BASEADD_USB		0x0000
150 
151 /* subchip/slave 1 - AUD ID */
152 #define TWL4030_BASEADD_AUDIO_VOICE	0x0000
153 #define TWL4030_BASEADD_GPIO		0x0098
154 #define TWL4030_BASEADD_INTBR		0x0085
155 #define TWL4030_BASEADD_PIH		0x0080
156 #define TWL4030_BASEADD_TEST		0x004C
157 
158 /* subchip/slave 2 - AUX ID */
159 #define TWL4030_BASEADD_INTERRUPTS	0x00B9
160 #define TWL4030_BASEADD_LED		0x00EE
161 #define TWL4030_BASEADD_MADC		0x0000
162 #define TWL4030_BASEADD_MAIN_CHARGE	0x0074
163 #define TWL4030_BASEADD_PRECHARGE	0x00AA
164 #define TWL4030_BASEADD_PWM0		0x00F8
165 #define TWL4030_BASEADD_PWM1		0x00FB
166 #define TWL4030_BASEADD_PWMA		0x00EF
167 #define TWL4030_BASEADD_PWMB		0x00F1
168 #define TWL4030_BASEADD_KEYPAD		0x00D2
169 
170 #define TWL5031_BASEADD_ACCESSORY	0x0074 /* Replaces Main Charge */
171 #define TWL5031_BASEADD_INTERRUPTS	0x00B9 /* Different than TWL4030's
172 						  one */
173 
174 /* subchip/slave 3 - POWER ID */
175 #define TWL4030_BASEADD_BACKUP		0x0014
176 #define TWL4030_BASEADD_INT		0x002E
177 #define TWL4030_BASEADD_PM_MASTER	0x0036
178 #define TWL4030_BASEADD_PM_RECEIVER	0x005B
179 #define TWL4030_BASEADD_RTC		0x001C
180 #define TWL4030_BASEADD_SECURED_REG	0x0000
181 
182 /* Triton Core internal information (END) */
183 
184 
185 /* subchip/slave 0 0x48 - POWER */
186 #define TWL6030_BASEADD_RTC		0x0000
187 #define TWL6030_BASEADD_MEM		0x0017
188 #define TWL6030_BASEADD_PM_MASTER	0x001F
189 #define TWL6030_BASEADD_PM_SLAVE_MISC	0x0030 /* PM_RECEIVER */
190 #define TWL6030_BASEADD_PM_MISC		0x00E2
191 #define TWL6030_BASEADD_PM_PUPD		0x00F0
192 
193 /* subchip/slave 1 0x49 - FEATURE */
194 #define TWL6030_BASEADD_USB		0x0000
195 #define TWL6030_BASEADD_GPADC_CTRL	0x002E
196 #define TWL6030_BASEADD_AUX		0x0090
197 #define TWL6030_BASEADD_PWM		0x00BA
198 #define TWL6030_BASEADD_GASGAUGE	0x00C0
199 #define TWL6030_BASEADD_PIH		0x00D0
200 #define TWL6030_BASEADD_CHARGER		0x00E0
201 #define TWL6025_BASEADD_CHARGER		0x00DA
202 
203 /* subchip/slave 2 0x4A - DFT */
204 #define TWL6030_BASEADD_DIEID		0x00C0
205 
206 /* subchip/slave 3 0x4B - AUDIO */
207 #define TWL6030_BASEADD_AUDIO		0x0000
208 #define TWL6030_BASEADD_RSV		0x0000
209 #define TWL6030_BASEADD_ZERO		0x0000
210 
211 /* Few power values */
212 #define R_CFG_BOOT			0x05
213 
214 /* some fields in R_CFG_BOOT */
215 #define HFCLK_FREQ_19p2_MHZ		(1 << 0)
216 #define HFCLK_FREQ_26_MHZ		(2 << 0)
217 #define HFCLK_FREQ_38p4_MHZ		(3 << 0)
218 #define HIGH_PERF_SQ			(1 << 3)
219 #define CK32K_LOWPWR_EN			(1 << 7)
220 
221 
222 /* chip-specific feature flags, for i2c_device_id.driver_data */
223 #define TWL4030_VAUX2		BIT(0)	/* pre-5030 voltage ranges */
224 #define TPS_SUBSET		BIT(1)	/* tps659[23]0 have fewer LDOs */
225 #define TWL5031			BIT(2)  /* twl5031 has different registers */
226 #define TWL6030_CLASS		BIT(3)	/* TWL6030 class */
227 
228 /*----------------------------------------------------------------------*/
229 
230 /* is driver active, bound to a chip? */
231 static bool inuse;
232 
233 /* TWL IDCODE Register value */
234 static u32 twl_idcode;
235 
236 static unsigned int twl_id;
237 unsigned int twl_rev(void)
238 {
239 	return twl_id;
240 }
241 EXPORT_SYMBOL(twl_rev);
242 
243 /* Structure for each TWL4030/TWL6030 Slave */
244 struct twl_client {
245 	struct i2c_client *client;
246 	u8 address;
247 
248 	/* max numb of i2c_msg required is for read =2 */
249 	struct i2c_msg xfer_msg[2];
250 
251 	/* To lock access to xfer_msg */
252 	struct mutex xfer_lock;
253 };
254 
255 static struct twl_client twl_modules[TWL_NUM_SLAVES];
256 
257 
258 /* mapping the module id to slave id and base address */
259 struct twl_mapping {
260 	unsigned char sid;	/* Slave ID */
261 	unsigned char base;	/* base address */
262 };
263 static struct twl_mapping *twl_map;
264 
265 static struct twl_mapping twl4030_map[TWL4030_MODULE_LAST + 1] = {
266 	/*
267 	 * NOTE:  don't change this table without updating the
268 	 * <linux/i2c/twl.h> defines for TWL4030_MODULE_*
269 	 * so they continue to match the order in this table.
270 	 */
271 
272 	{ 0, TWL4030_BASEADD_USB },
273 
274 	{ 1, TWL4030_BASEADD_AUDIO_VOICE },
275 	{ 1, TWL4030_BASEADD_GPIO },
276 	{ 1, TWL4030_BASEADD_INTBR },
277 	{ 1, TWL4030_BASEADD_PIH },
278 	{ 1, TWL4030_BASEADD_TEST },
279 
280 	{ 2, TWL4030_BASEADD_KEYPAD },
281 	{ 2, TWL4030_BASEADD_MADC },
282 	{ 2, TWL4030_BASEADD_INTERRUPTS },
283 	{ 2, TWL4030_BASEADD_LED },
284 	{ 2, TWL4030_BASEADD_MAIN_CHARGE },
285 	{ 2, TWL4030_BASEADD_PRECHARGE },
286 	{ 2, TWL4030_BASEADD_PWM0 },
287 	{ 2, TWL4030_BASEADD_PWM1 },
288 	{ 2, TWL4030_BASEADD_PWMA },
289 	{ 2, TWL4030_BASEADD_PWMB },
290 	{ 2, TWL5031_BASEADD_ACCESSORY },
291 	{ 2, TWL5031_BASEADD_INTERRUPTS },
292 
293 	{ 3, TWL4030_BASEADD_BACKUP },
294 	{ 3, TWL4030_BASEADD_INT },
295 	{ 3, TWL4030_BASEADD_PM_MASTER },
296 	{ 3, TWL4030_BASEADD_PM_RECEIVER },
297 	{ 3, TWL4030_BASEADD_RTC },
298 	{ 3, TWL4030_BASEADD_SECURED_REG },
299 };
300 
301 static struct twl_mapping twl6030_map[] = {
302 	/*
303 	 * NOTE:  don't change this table without updating the
304 	 * <linux/i2c/twl.h> defines for TWL4030_MODULE_*
305 	 * so they continue to match the order in this table.
306 	 */
307 	{ SUB_CHIP_ID1, TWL6030_BASEADD_USB },
308 	{ SUB_CHIP_ID3, TWL6030_BASEADD_AUDIO },
309 	{ SUB_CHIP_ID2, TWL6030_BASEADD_DIEID },
310 	{ SUB_CHIP_ID2, TWL6030_BASEADD_RSV },
311 	{ SUB_CHIP_ID1, TWL6030_BASEADD_PIH },
312 
313 	{ SUB_CHIP_ID2, TWL6030_BASEADD_RSV },
314 	{ SUB_CHIP_ID2, TWL6030_BASEADD_RSV },
315 	{ SUB_CHIP_ID1, TWL6030_BASEADD_GPADC_CTRL },
316 	{ SUB_CHIP_ID2, TWL6030_BASEADD_RSV },
317 	{ SUB_CHIP_ID2, TWL6030_BASEADD_RSV },
318 
319 	{ SUB_CHIP_ID1, TWL6030_BASEADD_CHARGER },
320 	{ SUB_CHIP_ID1, TWL6030_BASEADD_GASGAUGE },
321 	{ SUB_CHIP_ID1, TWL6030_BASEADD_PWM },
322 	{ SUB_CHIP_ID0, TWL6030_BASEADD_ZERO },
323 	{ SUB_CHIP_ID1, TWL6030_BASEADD_ZERO },
324 
325 	{ SUB_CHIP_ID2, TWL6030_BASEADD_ZERO },
326 	{ SUB_CHIP_ID2, TWL6030_BASEADD_ZERO },
327 	{ SUB_CHIP_ID2, TWL6030_BASEADD_RSV },
328 	{ SUB_CHIP_ID2, TWL6030_BASEADD_RSV },
329 	{ SUB_CHIP_ID2, TWL6030_BASEADD_RSV },
330 	{ SUB_CHIP_ID0, TWL6030_BASEADD_PM_MASTER },
331 	{ SUB_CHIP_ID0, TWL6030_BASEADD_PM_SLAVE_MISC },
332 
333 	{ SUB_CHIP_ID0, TWL6030_BASEADD_RTC },
334 	{ SUB_CHIP_ID0, TWL6030_BASEADD_MEM },
335 	{ SUB_CHIP_ID1, TWL6025_BASEADD_CHARGER },
336 };
337 
338 /*----------------------------------------------------------------------*/
339 
340 /* Exported Functions */
341 
342 /**
343  * twl_i2c_write - Writes a n bit register in TWL4030/TWL5030/TWL60X0
344  * @mod_no: module number
345  * @value: an array of num_bytes+1 containing data to write
346  * @reg: register address (just offset will do)
347  * @num_bytes: number of bytes to transfer
348  *
349  * IMPORTANT: for 'value' parameter: Allocate value num_bytes+1 and
350  * valid data starts at Offset 1.
351  *
352  * Returns the result of operation - 0 is success
353  */
354 int twl_i2c_write(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes)
355 {
356 	int ret;
357 	int sid;
358 	struct twl_client *twl;
359 	struct i2c_msg *msg;
360 
361 	if (unlikely(mod_no > TWL_MODULE_LAST)) {
362 		pr_err("%s: invalid module number %d\n", DRIVER_NAME, mod_no);
363 		return -EPERM;
364 	}
365 	sid = twl_map[mod_no].sid;
366 	twl = &twl_modules[sid];
367 
368 	if (unlikely(!inuse)) {
369 		pr_err("%s: client %d is not initialized\n", DRIVER_NAME, sid);
370 		return -EPERM;
371 	}
372 	mutex_lock(&twl->xfer_lock);
373 	/*
374 	 * [MSG1]: fill the register address data
375 	 * fill the data Tx buffer
376 	 */
377 	msg = &twl->xfer_msg[0];
378 	msg->addr = twl->address;
379 	msg->len = num_bytes + 1;
380 	msg->flags = 0;
381 	msg->buf = value;
382 	/* over write the first byte of buffer with the register address */
383 	*value = twl_map[mod_no].base + reg;
384 	ret = i2c_transfer(twl->client->adapter, twl->xfer_msg, 1);
385 	mutex_unlock(&twl->xfer_lock);
386 
387 	/* i2c_transfer returns number of messages transferred */
388 	if (ret != 1) {
389 		pr_err("%s: i2c_write failed to transfer all messages\n",
390 			DRIVER_NAME);
391 		if (ret < 0)
392 			return ret;
393 		else
394 			return -EIO;
395 	} else {
396 		return 0;
397 	}
398 }
399 EXPORT_SYMBOL(twl_i2c_write);
400 
401 /**
402  * twl_i2c_read - Reads a n bit register in TWL4030/TWL5030/TWL60X0
403  * @mod_no: module number
404  * @value: an array of num_bytes containing data to be read
405  * @reg: register address (just offset will do)
406  * @num_bytes: number of bytes to transfer
407  *
408  * Returns result of operation - num_bytes is success else failure.
409  */
410 int twl_i2c_read(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes)
411 {
412 	int ret;
413 	u8 val;
414 	int sid;
415 	struct twl_client *twl;
416 	struct i2c_msg *msg;
417 
418 	if (unlikely(mod_no > TWL_MODULE_LAST)) {
419 		pr_err("%s: invalid module number %d\n", DRIVER_NAME, mod_no);
420 		return -EPERM;
421 	}
422 	sid = twl_map[mod_no].sid;
423 	twl = &twl_modules[sid];
424 
425 	if (unlikely(!inuse)) {
426 		pr_err("%s: client %d is not initialized\n", DRIVER_NAME, sid);
427 		return -EPERM;
428 	}
429 	mutex_lock(&twl->xfer_lock);
430 	/* [MSG1] fill the register address data */
431 	msg = &twl->xfer_msg[0];
432 	msg->addr = twl->address;
433 	msg->len = 1;
434 	msg->flags = 0;	/* Read the register value */
435 	val = twl_map[mod_no].base + reg;
436 	msg->buf = &val;
437 	/* [MSG2] fill the data rx buffer */
438 	msg = &twl->xfer_msg[1];
439 	msg->addr = twl->address;
440 	msg->flags = I2C_M_RD;	/* Read the register value */
441 	msg->len = num_bytes;	/* only n bytes */
442 	msg->buf = value;
443 	ret = i2c_transfer(twl->client->adapter, twl->xfer_msg, 2);
444 	mutex_unlock(&twl->xfer_lock);
445 
446 	/* i2c_transfer returns number of messages transferred */
447 	if (ret != 2) {
448 		pr_err("%s: i2c_read failed to transfer all messages\n",
449 			DRIVER_NAME);
450 		if (ret < 0)
451 			return ret;
452 		else
453 			return -EIO;
454 	} else {
455 		return 0;
456 	}
457 }
458 EXPORT_SYMBOL(twl_i2c_read);
459 
460 /**
461  * twl_i2c_write_u8 - Writes a 8 bit register in TWL4030/TWL5030/TWL60X0
462  * @mod_no: module number
463  * @value: the value to be written 8 bit
464  * @reg: register address (just offset will do)
465  *
466  * Returns result of operation - 0 is success
467  */
468 int twl_i2c_write_u8(u8 mod_no, u8 value, u8 reg)
469 {
470 
471 	/* 2 bytes offset 1 contains the data offset 0 is used by i2c_write */
472 	u8 temp_buffer[2] = { 0 };
473 	/* offset 1 contains the data */
474 	temp_buffer[1] = value;
475 	return twl_i2c_write(mod_no, temp_buffer, reg, 1);
476 }
477 EXPORT_SYMBOL(twl_i2c_write_u8);
478 
479 /**
480  * twl_i2c_read_u8 - Reads a 8 bit register from TWL4030/TWL5030/TWL60X0
481  * @mod_no: module number
482  * @value: the value read 8 bit
483  * @reg: register address (just offset will do)
484  *
485  * Returns result of operation - 0 is success
486  */
487 int twl_i2c_read_u8(u8 mod_no, u8 *value, u8 reg)
488 {
489 	return twl_i2c_read(mod_no, value, reg, 1);
490 }
491 EXPORT_SYMBOL(twl_i2c_read_u8);
492 
493 /*----------------------------------------------------------------------*/
494 
495 /**
496  * twl_read_idcode_register - API to read the IDCODE register.
497  *
498  * Unlocks the IDCODE register and read the 32 bit value.
499  */
500 static int twl_read_idcode_register(void)
501 {
502 	int err;
503 
504 	err = twl_i2c_write_u8(TWL4030_MODULE_INTBR, TWL_EEPROM_R_UNLOCK,
505 						REG_UNLOCK_TEST_REG);
506 	if (err) {
507 		pr_err("TWL4030 Unable to unlock IDCODE registers -%d\n", err);
508 		goto fail;
509 	}
510 
511 	err = twl_i2c_read(TWL4030_MODULE_INTBR, (u8 *)(&twl_idcode),
512 						REG_IDCODE_7_0, 4);
513 	if (err) {
514 		pr_err("TWL4030: unable to read IDCODE -%d\n", err);
515 		goto fail;
516 	}
517 
518 	err = twl_i2c_write_u8(TWL4030_MODULE_INTBR, 0x0, REG_UNLOCK_TEST_REG);
519 	if (err)
520 		pr_err("TWL4030 Unable to relock IDCODE registers -%d\n", err);
521 fail:
522 	return err;
523 }
524 
525 /**
526  * twl_get_type - API to get TWL Si type.
527  *
528  * Api to get the TWL Si type from IDCODE value.
529  */
530 int twl_get_type(void)
531 {
532 	return TWL_SIL_TYPE(twl_idcode);
533 }
534 EXPORT_SYMBOL_GPL(twl_get_type);
535 
536 /**
537  * twl_get_version - API to get TWL Si version.
538  *
539  * Api to get the TWL Si version from IDCODE value.
540  */
541 int twl_get_version(void)
542 {
543 	return TWL_SIL_REV(twl_idcode);
544 }
545 EXPORT_SYMBOL_GPL(twl_get_version);
546 
547 static struct device *
548 add_numbered_child(unsigned chip, const char *name, int num,
549 		void *pdata, unsigned pdata_len,
550 		bool can_wakeup, int irq0, int irq1)
551 {
552 	struct platform_device	*pdev;
553 	struct twl_client	*twl = &twl_modules[chip];
554 	int			status;
555 
556 	pdev = platform_device_alloc(name, num);
557 	if (!pdev) {
558 		dev_dbg(&twl->client->dev, "can't alloc dev\n");
559 		status = -ENOMEM;
560 		goto err;
561 	}
562 
563 	device_init_wakeup(&pdev->dev, can_wakeup);
564 	pdev->dev.parent = &twl->client->dev;
565 
566 	if (pdata) {
567 		status = platform_device_add_data(pdev, pdata, pdata_len);
568 		if (status < 0) {
569 			dev_dbg(&pdev->dev, "can't add platform_data\n");
570 			goto err;
571 		}
572 	}
573 
574 	if (irq0) {
575 		struct resource r[2] = {
576 			{ .start = irq0, .flags = IORESOURCE_IRQ, },
577 			{ .start = irq1, .flags = IORESOURCE_IRQ, },
578 		};
579 
580 		status = platform_device_add_resources(pdev, r, irq1 ? 2 : 1);
581 		if (status < 0) {
582 			dev_dbg(&pdev->dev, "can't add irqs\n");
583 			goto err;
584 		}
585 	}
586 
587 	status = platform_device_add(pdev);
588 
589 err:
590 	if (status < 0) {
591 		platform_device_put(pdev);
592 		dev_err(&twl->client->dev, "can't add %s dev\n", name);
593 		return ERR_PTR(status);
594 	}
595 	return &pdev->dev;
596 }
597 
598 static inline struct device *add_child(unsigned chip, const char *name,
599 		void *pdata, unsigned pdata_len,
600 		bool can_wakeup, int irq0, int irq1)
601 {
602 	return add_numbered_child(chip, name, -1, pdata, pdata_len,
603 		can_wakeup, irq0, irq1);
604 }
605 
606 static struct device *
607 add_regulator_linked(int num, struct regulator_init_data *pdata,
608 		struct regulator_consumer_supply *consumers,
609 		unsigned num_consumers, unsigned long features)
610 {
611 	unsigned sub_chip_id;
612 	/* regulator framework demands init_data ... */
613 	if (!pdata)
614 		return NULL;
615 
616 	if (consumers) {
617 		pdata->consumer_supplies = consumers;
618 		pdata->num_consumer_supplies = num_consumers;
619 	}
620 
621 	pdata->driver_data = (void *)features;
622 
623 	/* NOTE:  we currently ignore regulator IRQs, e.g. for short circuits */
624 	sub_chip_id = twl_map[TWL_MODULE_PM_MASTER].sid;
625 	return add_numbered_child(sub_chip_id, "twl_reg", num,
626 		pdata, sizeof(*pdata), false, 0, 0);
627 }
628 
629 static struct device *
630 add_regulator(int num, struct regulator_init_data *pdata,
631 		unsigned long features)
632 {
633 	return add_regulator_linked(num, pdata, NULL, 0, features);
634 }
635 
636 /*
637  * NOTE:  We know the first 8 IRQs after pdata->base_irq are
638  * for the PIH, and the next are for the PWR_INT SIH, since
639  * that's how twl_init_irq() sets things up.
640  */
641 
642 static int
643 add_children(struct twl4030_platform_data *pdata, unsigned long features)
644 {
645 	struct device	*child;
646 	unsigned sub_chip_id;
647 
648 	if (twl_has_gpio() && pdata->gpio) {
649 		child = add_child(SUB_CHIP_ID1, "twl4030_gpio",
650 				pdata->gpio, sizeof(*pdata->gpio),
651 				false, pdata->irq_base + GPIO_INTR_OFFSET, 0);
652 		if (IS_ERR(child))
653 			return PTR_ERR(child);
654 	}
655 
656 	if (twl_has_keypad() && pdata->keypad) {
657 		child = add_child(SUB_CHIP_ID2, "twl4030_keypad",
658 				pdata->keypad, sizeof(*pdata->keypad),
659 				true, pdata->irq_base + KEYPAD_INTR_OFFSET, 0);
660 		if (IS_ERR(child))
661 			return PTR_ERR(child);
662 	}
663 
664 	if (twl_has_madc() && pdata->madc) {
665 		child = add_child(2, "twl4030_madc",
666 				pdata->madc, sizeof(*pdata->madc),
667 				true, pdata->irq_base + MADC_INTR_OFFSET, 0);
668 		if (IS_ERR(child))
669 			return PTR_ERR(child);
670 	}
671 
672 	if (twl_has_rtc()) {
673 		/*
674 		 * REVISIT platform_data here currently might expose the
675 		 * "msecure" line ... but for now we just expect board
676 		 * setup to tell the chip "it's always ok to SET_TIME".
677 		 * Eventually, Linux might become more aware of such
678 		 * HW security concerns, and "least privilege".
679 		 */
680 		sub_chip_id = twl_map[TWL_MODULE_RTC].sid;
681 		child = add_child(sub_chip_id, "twl_rtc",
682 				NULL, 0,
683 				true, pdata->irq_base + RTC_INTR_OFFSET, 0);
684 		if (IS_ERR(child))
685 			return PTR_ERR(child);
686 	}
687 
688 	if (twl_has_usb() && pdata->usb && twl_class_is_4030()) {
689 
690 		static struct regulator_consumer_supply usb1v5 = {
691 			.supply =	"usb1v5",
692 		};
693 		static struct regulator_consumer_supply usb1v8 = {
694 			.supply =	"usb1v8",
695 		};
696 		static struct regulator_consumer_supply usb3v1 = {
697 			.supply =	"usb3v1",
698 		};
699 
700 	/* First add the regulators so that they can be used by transceiver */
701 		if (twl_has_regulator()) {
702 			/* this is a template that gets copied */
703 			struct regulator_init_data usb_fixed = {
704 				.constraints.valid_modes_mask =
705 					REGULATOR_MODE_NORMAL
706 					| REGULATOR_MODE_STANDBY,
707 				.constraints.valid_ops_mask =
708 					REGULATOR_CHANGE_MODE
709 					| REGULATOR_CHANGE_STATUS,
710 			};
711 
712 			child = add_regulator_linked(TWL4030_REG_VUSB1V5,
713 						      &usb_fixed, &usb1v5, 1,
714 						      features);
715 			if (IS_ERR(child))
716 				return PTR_ERR(child);
717 
718 			child = add_regulator_linked(TWL4030_REG_VUSB1V8,
719 						      &usb_fixed, &usb1v8, 1,
720 						      features);
721 			if (IS_ERR(child))
722 				return PTR_ERR(child);
723 
724 			child = add_regulator_linked(TWL4030_REG_VUSB3V1,
725 						      &usb_fixed, &usb3v1, 1,
726 						      features);
727 			if (IS_ERR(child))
728 				return PTR_ERR(child);
729 
730 		}
731 
732 		child = add_child(0, "twl4030_usb",
733 				pdata->usb, sizeof(*pdata->usb),
734 				true,
735 				/* irq0 = USB_PRES, irq1 = USB */
736 				pdata->irq_base + USB_PRES_INTR_OFFSET,
737 				pdata->irq_base + USB_INTR_OFFSET);
738 
739 		if (IS_ERR(child))
740 			return PTR_ERR(child);
741 
742 		/* we need to connect regulators to this transceiver */
743 		if (twl_has_regulator() && child) {
744 			usb1v5.dev = child;
745 			usb1v8.dev = child;
746 			usb3v1.dev = child;
747 		}
748 	}
749 	if (twl_has_usb() && pdata->usb && twl_class_is_6030()) {
750 
751 		static struct regulator_consumer_supply usb3v3;
752 		int regulator;
753 
754 		if (twl_has_regulator()) {
755 			/* this is a template that gets copied */
756 			struct regulator_init_data usb_fixed = {
757 				.constraints.valid_modes_mask =
758 					REGULATOR_MODE_NORMAL
759 					| REGULATOR_MODE_STANDBY,
760 				.constraints.valid_ops_mask =
761 					REGULATOR_CHANGE_MODE
762 					| REGULATOR_CHANGE_STATUS,
763 			};
764 
765 			if (features & TWL6025_SUBCLASS) {
766 				usb3v3.supply =	"ldousb";
767 				regulator = TWL6025_REG_LDOUSB;
768 			} else {
769 				usb3v3.supply = "vusb";
770 				regulator = TWL6030_REG_VUSB;
771 			}
772 			child = add_regulator_linked(regulator, &usb_fixed,
773 							&usb3v3, 1,
774 							features);
775 			if (IS_ERR(child))
776 				return PTR_ERR(child);
777 		}
778 
779 		pdata->usb->features = features;
780 
781 		child = add_child(0, "twl6030_usb",
782 			pdata->usb, sizeof(*pdata->usb),
783 			true,
784 			/* irq1 = VBUS_PRES, irq0 = USB ID */
785 			pdata->irq_base + USBOTG_INTR_OFFSET,
786 			pdata->irq_base + USB_PRES_INTR_OFFSET);
787 
788 		if (IS_ERR(child))
789 			return PTR_ERR(child);
790 		/* we need to connect regulators to this transceiver */
791 		if (twl_has_regulator() && child)
792 			usb3v3.dev = child;
793 	} else if (twl_has_regulator() && twl_class_is_6030()) {
794 		if (features & TWL6025_SUBCLASS)
795 			child = add_regulator(TWL6025_REG_LDOUSB,
796 						pdata->ldousb, features);
797 		else
798 			child = add_regulator(TWL6030_REG_VUSB,
799 						pdata->vusb, features);
800 
801 			if (IS_ERR(child))
802 					return PTR_ERR(child);
803 	}
804 
805 	if (twl_has_watchdog() && twl_class_is_4030()) {
806 		child = add_child(0, "twl4030_wdt", NULL, 0, false, 0, 0);
807 		if (IS_ERR(child))
808 			return PTR_ERR(child);
809 	}
810 
811 	if (twl_has_pwrbutton() && twl_class_is_4030()) {
812 		child = add_child(1, "twl4030_pwrbutton",
813 				NULL, 0, true, pdata->irq_base + 8 + 0, 0);
814 		if (IS_ERR(child))
815 			return PTR_ERR(child);
816 	}
817 
818 	if (twl_has_codec() && pdata->codec && twl_class_is_4030()) {
819 		sub_chip_id = twl_map[TWL_MODULE_AUDIO_VOICE].sid;
820 		child = add_child(sub_chip_id, "twl4030-audio",
821 				pdata->codec, sizeof(*pdata->codec),
822 				false, 0, 0);
823 		if (IS_ERR(child))
824 			return PTR_ERR(child);
825 	}
826 
827 	/* Phoenix codec driver is probed directly atm */
828 	if (twl_has_codec() && pdata->codec && twl_class_is_6030()) {
829 		sub_chip_id = twl_map[TWL_MODULE_AUDIO_VOICE].sid;
830 		child = add_child(sub_chip_id, "twl6040-codec",
831 				pdata->codec, sizeof(*pdata->codec),
832 				false, 0, 0);
833 		if (IS_ERR(child))
834 			return PTR_ERR(child);
835 	}
836 
837 	/* twl4030 regulators */
838 	if (twl_has_regulator() && twl_class_is_4030()) {
839 		child = add_regulator(TWL4030_REG_VPLL1, pdata->vpll1,
840 					features);
841 		if (IS_ERR(child))
842 			return PTR_ERR(child);
843 
844 		child = add_regulator(TWL4030_REG_VIO, pdata->vio,
845 					features);
846 		if (IS_ERR(child))
847 			return PTR_ERR(child);
848 
849 		child = add_regulator(TWL4030_REG_VDD1, pdata->vdd1,
850 					features);
851 		if (IS_ERR(child))
852 			return PTR_ERR(child);
853 
854 		child = add_regulator(TWL4030_REG_VDD2, pdata->vdd2,
855 					features);
856 		if (IS_ERR(child))
857 			return PTR_ERR(child);
858 
859 		child = add_regulator(TWL4030_REG_VMMC1, pdata->vmmc1,
860 					features);
861 		if (IS_ERR(child))
862 			return PTR_ERR(child);
863 
864 		child = add_regulator(TWL4030_REG_VDAC, pdata->vdac,
865 					features);
866 		if (IS_ERR(child))
867 			return PTR_ERR(child);
868 
869 		child = add_regulator((features & TWL4030_VAUX2)
870 					? TWL4030_REG_VAUX2_4030
871 					: TWL4030_REG_VAUX2,
872 				pdata->vaux2, features);
873 		if (IS_ERR(child))
874 			return PTR_ERR(child);
875 
876 		child = add_regulator(TWL4030_REG_VINTANA1, pdata->vintana1,
877 					features);
878 		if (IS_ERR(child))
879 			return PTR_ERR(child);
880 
881 		child = add_regulator(TWL4030_REG_VINTANA2, pdata->vintana2,
882 					features);
883 		if (IS_ERR(child))
884 			return PTR_ERR(child);
885 
886 		child = add_regulator(TWL4030_REG_VINTDIG, pdata->vintdig,
887 					features);
888 		if (IS_ERR(child))
889 			return PTR_ERR(child);
890 	}
891 
892 	/* maybe add LDOs that are omitted on cost-reduced parts */
893 	if (twl_has_regulator() && !(features & TPS_SUBSET)
894 	  && twl_class_is_4030()) {
895 		child = add_regulator(TWL4030_REG_VPLL2, pdata->vpll2,
896 					features);
897 		if (IS_ERR(child))
898 			return PTR_ERR(child);
899 
900 		child = add_regulator(TWL4030_REG_VMMC2, pdata->vmmc2,
901 					features);
902 		if (IS_ERR(child))
903 			return PTR_ERR(child);
904 
905 		child = add_regulator(TWL4030_REG_VSIM, pdata->vsim,
906 					features);
907 		if (IS_ERR(child))
908 			return PTR_ERR(child);
909 
910 		child = add_regulator(TWL4030_REG_VAUX1, pdata->vaux1,
911 					features);
912 		if (IS_ERR(child))
913 			return PTR_ERR(child);
914 
915 		child = add_regulator(TWL4030_REG_VAUX3, pdata->vaux3,
916 					features);
917 		if (IS_ERR(child))
918 			return PTR_ERR(child);
919 
920 		child = add_regulator(TWL4030_REG_VAUX4, pdata->vaux4,
921 					features);
922 		if (IS_ERR(child))
923 			return PTR_ERR(child);
924 	}
925 
926 	/* twl6030 regulators */
927 	if (twl_has_regulator() && twl_class_is_6030() &&
928 			!(features & TWL6025_SUBCLASS)) {
929 		child = add_regulator(TWL6030_REG_VMMC, pdata->vmmc,
930 					features);
931 		if (IS_ERR(child))
932 			return PTR_ERR(child);
933 
934 		child = add_regulator(TWL6030_REG_VPP, pdata->vpp,
935 					features);
936 		if (IS_ERR(child))
937 			return PTR_ERR(child);
938 
939 		child = add_regulator(TWL6030_REG_VUSIM, pdata->vusim,
940 					features);
941 		if (IS_ERR(child))
942 			return PTR_ERR(child);
943 
944 		child = add_regulator(TWL6030_REG_VCXIO, pdata->vcxio,
945 					features);
946 		if (IS_ERR(child))
947 			return PTR_ERR(child);
948 
949 		child = add_regulator(TWL6030_REG_VDAC, pdata->vdac,
950 					features);
951 		if (IS_ERR(child))
952 			return PTR_ERR(child);
953 
954 		child = add_regulator(TWL6030_REG_VAUX1_6030, pdata->vaux1,
955 					features);
956 		if (IS_ERR(child))
957 			return PTR_ERR(child);
958 
959 		child = add_regulator(TWL6030_REG_VAUX2_6030, pdata->vaux2,
960 					features);
961 		if (IS_ERR(child))
962 			return PTR_ERR(child);
963 
964 		child = add_regulator(TWL6030_REG_VAUX3_6030, pdata->vaux3,
965 					features);
966 		if (IS_ERR(child))
967 			return PTR_ERR(child);
968 
969 		child = add_regulator(TWL6030_REG_CLK32KG, pdata->clk32kg,
970 					features);
971 		if (IS_ERR(child))
972 			return PTR_ERR(child);
973 	}
974 
975 	/* 6030 and 6025 share this regulator */
976 	if (twl_has_regulator() && twl_class_is_6030()) {
977 		child = add_regulator(TWL6030_REG_VANA, pdata->vana,
978 					features);
979 		if (IS_ERR(child))
980 			return PTR_ERR(child);
981 	}
982 
983 	/* twl6025 regulators */
984 	if (twl_has_regulator() && twl_class_is_6030() &&
985 			(features & TWL6025_SUBCLASS)) {
986 		child = add_regulator(TWL6025_REG_LDO5, pdata->ldo5,
987 					features);
988 		if (IS_ERR(child))
989 			return PTR_ERR(child);
990 
991 		child = add_regulator(TWL6025_REG_LDO1, pdata->ldo1,
992 					features);
993 		if (IS_ERR(child))
994 			return PTR_ERR(child);
995 
996 		child = add_regulator(TWL6025_REG_LDO7, pdata->ldo7,
997 					features);
998 		if (IS_ERR(child))
999 			return PTR_ERR(child);
1000 
1001 		child = add_regulator(TWL6025_REG_LDO6, pdata->ldo6,
1002 					features);
1003 		if (IS_ERR(child))
1004 			return PTR_ERR(child);
1005 
1006 		child = add_regulator(TWL6025_REG_LDOLN, pdata->ldoln,
1007 					features);
1008 		if (IS_ERR(child))
1009 			return PTR_ERR(child);
1010 
1011 		child = add_regulator(TWL6025_REG_LDO2, pdata->ldo2,
1012 					features);
1013 		if (IS_ERR(child))
1014 			return PTR_ERR(child);
1015 
1016 		child = add_regulator(TWL6025_REG_LDO4, pdata->ldo4,
1017 					features);
1018 		if (IS_ERR(child))
1019 			return PTR_ERR(child);
1020 
1021 		child = add_regulator(TWL6025_REG_LDO3, pdata->ldo3,
1022 					features);
1023 		if (IS_ERR(child))
1024 			return PTR_ERR(child);
1025 
1026 		child = add_regulator(TWL6025_REG_SMPS3, pdata->smps3,
1027 					features);
1028 		if (IS_ERR(child))
1029 			return PTR_ERR(child);
1030 
1031 		child = add_regulator(TWL6025_REG_SMPS4, pdata->smps4,
1032 					features);
1033 		if (IS_ERR(child))
1034 			return PTR_ERR(child);
1035 
1036 		child = add_regulator(TWL6025_REG_VIO, pdata->vio6025,
1037 					features);
1038 		if (IS_ERR(child))
1039 			return PTR_ERR(child);
1040 
1041 	}
1042 
1043 	if (twl_has_bci() && pdata->bci &&
1044 			!(features & (TPS_SUBSET | TWL5031))) {
1045 		child = add_child(3, "twl4030_bci",
1046 				pdata->bci, sizeof(*pdata->bci), false,
1047 				/* irq0 = CHG_PRES, irq1 = BCI */
1048 				pdata->irq_base + BCI_PRES_INTR_OFFSET,
1049 				pdata->irq_base + BCI_INTR_OFFSET);
1050 		if (IS_ERR(child))
1051 			return PTR_ERR(child);
1052 	}
1053 
1054 	return 0;
1055 }
1056 
1057 /*----------------------------------------------------------------------*/
1058 
1059 /*
1060  * These three functions initialize the on-chip clock framework,
1061  * letting it generate the right frequencies for USB, MADC, and
1062  * other purposes.
1063  */
1064 static inline int __init protect_pm_master(void)
1065 {
1066 	int e = 0;
1067 
1068 	e = twl_i2c_write_u8(TWL4030_MODULE_PM_MASTER, 0,
1069 			TWL4030_PM_MASTER_PROTECT_KEY);
1070 	return e;
1071 }
1072 
1073 static inline int __init unprotect_pm_master(void)
1074 {
1075 	int e = 0;
1076 
1077 	e |= twl_i2c_write_u8(TWL4030_MODULE_PM_MASTER,
1078 			TWL4030_PM_MASTER_KEY_CFG1,
1079 			TWL4030_PM_MASTER_PROTECT_KEY);
1080 	e |= twl_i2c_write_u8(TWL4030_MODULE_PM_MASTER,
1081 			TWL4030_PM_MASTER_KEY_CFG2,
1082 			TWL4030_PM_MASTER_PROTECT_KEY);
1083 
1084 	return e;
1085 }
1086 
1087 static void clocks_init(struct device *dev,
1088 			struct twl4030_clock_init_data *clock)
1089 {
1090 	int e = 0;
1091 	struct clk *osc;
1092 	u32 rate;
1093 	u8 ctrl = HFCLK_FREQ_26_MHZ;
1094 
1095 #if defined(CONFIG_ARCH_OMAP2) || defined(CONFIG_ARCH_OMAP3)
1096 	if (cpu_is_omap2430())
1097 		osc = clk_get(dev, "osc_ck");
1098 	else
1099 		osc = clk_get(dev, "osc_sys_ck");
1100 
1101 	if (IS_ERR(osc)) {
1102 		printk(KERN_WARNING "Skipping twl internal clock init and "
1103 				"using bootloader value (unknown osc rate)\n");
1104 		return;
1105 	}
1106 
1107 	rate = clk_get_rate(osc);
1108 	clk_put(osc);
1109 
1110 #else
1111 	/* REVISIT for non-OMAP systems, pass the clock rate from
1112 	 * board init code, using platform_data.
1113 	 */
1114 	osc = ERR_PTR(-EIO);
1115 
1116 	printk(KERN_WARNING "Skipping twl internal clock init and "
1117 	       "using bootloader value (unknown osc rate)\n");
1118 
1119 	return;
1120 #endif
1121 
1122 	switch (rate) {
1123 	case 19200000:
1124 		ctrl = HFCLK_FREQ_19p2_MHZ;
1125 		break;
1126 	case 26000000:
1127 		ctrl = HFCLK_FREQ_26_MHZ;
1128 		break;
1129 	case 38400000:
1130 		ctrl = HFCLK_FREQ_38p4_MHZ;
1131 		break;
1132 	}
1133 
1134 	ctrl |= HIGH_PERF_SQ;
1135 	if (clock && clock->ck32k_lowpwr_enable)
1136 		ctrl |= CK32K_LOWPWR_EN;
1137 
1138 	e |= unprotect_pm_master();
1139 	/* effect->MADC+USB ck en */
1140 	e |= twl_i2c_write_u8(TWL_MODULE_PM_MASTER, ctrl, R_CFG_BOOT);
1141 	e |= protect_pm_master();
1142 
1143 	if (e < 0)
1144 		pr_err("%s: clock init err [%d]\n", DRIVER_NAME, e);
1145 }
1146 
1147 /*----------------------------------------------------------------------*/
1148 
1149 int twl4030_init_irq(int irq_num, unsigned irq_base, unsigned irq_end);
1150 int twl4030_exit_irq(void);
1151 int twl4030_init_chip_irq(const char *chip);
1152 int twl6030_init_irq(int irq_num, unsigned irq_base, unsigned irq_end);
1153 int twl6030_exit_irq(void);
1154 
1155 static int twl_remove(struct i2c_client *client)
1156 {
1157 	unsigned i;
1158 	int status;
1159 
1160 	if (twl_class_is_4030())
1161 		status = twl4030_exit_irq();
1162 	else
1163 		status = twl6030_exit_irq();
1164 
1165 	if (status < 0)
1166 		return status;
1167 
1168 	for (i = 0; i < TWL_NUM_SLAVES; i++) {
1169 		struct twl_client	*twl = &twl_modules[i];
1170 
1171 		if (twl->client && twl->client != client)
1172 			i2c_unregister_device(twl->client);
1173 		twl_modules[i].client = NULL;
1174 	}
1175 	inuse = false;
1176 	return 0;
1177 }
1178 
1179 /* NOTE:  this driver only handles a single twl4030/tps659x0 chip */
1180 static int __devinit
1181 twl_probe(struct i2c_client *client, const struct i2c_device_id *id)
1182 {
1183 	int				status;
1184 	unsigned			i;
1185 	struct twl4030_platform_data	*pdata = client->dev.platform_data;
1186 	u8 temp;
1187 	int ret = 0;
1188 
1189 	if (!pdata) {
1190 		dev_dbg(&client->dev, "no platform data?\n");
1191 		return -EINVAL;
1192 	}
1193 
1194 	if (i2c_check_functionality(client->adapter, I2C_FUNC_I2C) == 0) {
1195 		dev_dbg(&client->dev, "can't talk I2C?\n");
1196 		return -EIO;
1197 	}
1198 
1199 	if (inuse) {
1200 		dev_dbg(&client->dev, "driver is already in use\n");
1201 		return -EBUSY;
1202 	}
1203 
1204 	for (i = 0; i < TWL_NUM_SLAVES; i++) {
1205 		struct twl_client	*twl = &twl_modules[i];
1206 
1207 		twl->address = client->addr + i;
1208 		if (i == 0)
1209 			twl->client = client;
1210 		else {
1211 			twl->client = i2c_new_dummy(client->adapter,
1212 					twl->address);
1213 			if (!twl->client) {
1214 				dev_err(&client->dev,
1215 					"can't attach client %d\n", i);
1216 				status = -ENOMEM;
1217 				goto fail;
1218 			}
1219 		}
1220 		mutex_init(&twl->xfer_lock);
1221 	}
1222 	inuse = true;
1223 	if ((id->driver_data) & TWL6030_CLASS) {
1224 		twl_id = TWL6030_CLASS_ID;
1225 		twl_map = &twl6030_map[0];
1226 	} else {
1227 		twl_id = TWL4030_CLASS_ID;
1228 		twl_map = &twl4030_map[0];
1229 	}
1230 
1231 	/* setup clock framework */
1232 	clocks_init(&client->dev, pdata->clock);
1233 
1234 	/* read TWL IDCODE Register */
1235 	if (twl_id == TWL4030_CLASS_ID) {
1236 		ret = twl_read_idcode_register();
1237 		WARN(ret < 0, "Error: reading twl_idcode register value\n");
1238 	}
1239 
1240 	/* load power event scripts */
1241 	if (twl_has_power() && pdata->power)
1242 		twl4030_power_init(pdata->power);
1243 
1244 	/* Maybe init the T2 Interrupt subsystem */
1245 	if (client->irq
1246 			&& pdata->irq_base
1247 			&& pdata->irq_end > pdata->irq_base) {
1248 		if (twl_class_is_4030()) {
1249 			twl4030_init_chip_irq(id->name);
1250 			status = twl4030_init_irq(client->irq, pdata->irq_base,
1251 			pdata->irq_end);
1252 		} else {
1253 			status = twl6030_init_irq(client->irq, pdata->irq_base,
1254 			pdata->irq_end);
1255 		}
1256 
1257 		if (status < 0)
1258 			goto fail;
1259 	}
1260 
1261 	/* Disable TWL4030/TWL5030 I2C Pull-up on I2C1 and I2C4(SR) interface.
1262 	 * Program I2C_SCL_CTRL_PU(bit 0)=0, I2C_SDA_CTRL_PU (bit 2)=0,
1263 	 * SR_I2C_SCL_CTRL_PU(bit 4)=0 and SR_I2C_SDA_CTRL_PU(bit 6)=0.
1264 	 */
1265 
1266 	if (twl_class_is_4030()) {
1267 		twl_i2c_read_u8(TWL4030_MODULE_INTBR, &temp, REG_GPPUPDCTR1);
1268 		temp &= ~(SR_I2C_SDA_CTRL_PU | SR_I2C_SCL_CTRL_PU | \
1269 		I2C_SDA_CTRL_PU | I2C_SCL_CTRL_PU);
1270 		twl_i2c_write_u8(TWL4030_MODULE_INTBR, temp, REG_GPPUPDCTR1);
1271 	}
1272 
1273 	status = add_children(pdata, id->driver_data);
1274 fail:
1275 	if (status < 0)
1276 		twl_remove(client);
1277 	return status;
1278 }
1279 
1280 static const struct i2c_device_id twl_ids[] = {
1281 	{ "twl4030", TWL4030_VAUX2 },	/* "Triton 2" */
1282 	{ "twl5030", 0 },		/* T2 updated */
1283 	{ "twl5031", TWL5031 },		/* TWL5030 updated */
1284 	{ "tps65950", 0 },		/* catalog version of twl5030 */
1285 	{ "tps65930", TPS_SUBSET },	/* fewer LDOs and DACs; no charger */
1286 	{ "tps65920", TPS_SUBSET },	/* fewer LDOs; no codec or charger */
1287 	{ "twl6030", TWL6030_CLASS },	/* "Phoenix power chip" */
1288 	{ "twl6025", TWL6030_CLASS | TWL6025_SUBCLASS }, /* "Phoenix lite" */
1289 	{ /* end of list */ },
1290 };
1291 MODULE_DEVICE_TABLE(i2c, twl_ids);
1292 
1293 /* One Client Driver , 4 Clients */
1294 static struct i2c_driver twl_driver = {
1295 	.driver.name	= DRIVER_NAME,
1296 	.id_table	= twl_ids,
1297 	.probe		= twl_probe,
1298 	.remove		= twl_remove,
1299 };
1300 
1301 static int __init twl_init(void)
1302 {
1303 	return i2c_add_driver(&twl_driver);
1304 }
1305 subsys_initcall(twl_init);
1306 
1307 static void __exit twl_exit(void)
1308 {
1309 	i2c_del_driver(&twl_driver);
1310 }
1311 module_exit(twl_exit);
1312 
1313 MODULE_AUTHOR("Texas Instruments, Inc.");
1314 MODULE_DESCRIPTION("I2C Core interface for TWL");
1315 MODULE_LICENSE("GPL");
1316