1 // SPDX-License-Identifier: GPL-2.0-only
2 /*
3  * Hauppauge HD PVR USB driver - video 4 linux 2 interface
4  *
5  * Copyright (C) 2008      Janne Grunau (j@jannau.net)
6  */
7 
8 #include <linux/kernel.h>
9 #include <linux/errno.h>
10 #include <linux/init.h>
11 #include <linux/slab.h>
12 #include <linux/module.h>
13 #include <linux/uaccess.h>
14 #include <linux/usb.h>
15 #include <linux/mutex.h>
16 #include <linux/workqueue.h>
17 
18 #include <linux/videodev2.h>
19 #include <linux/v4l2-dv-timings.h>
20 #include <media/v4l2-dev.h>
21 #include <media/v4l2-common.h>
22 #include <media/v4l2-dv-timings.h>
23 #include <media/v4l2-ioctl.h>
24 #include <media/v4l2-event.h>
25 #include "hdpvr.h"
26 
27 #define BULK_URB_TIMEOUT   90 /* 0.09 seconds */
28 
29 #define print_buffer_status() { \
30 		v4l2_dbg(MSG_BUFFER, hdpvr_debug, &dev->v4l2_dev,	\
31 			 "%s:%d buffer stat: %d free, %d proc\n",	\
32 			 __func__, __LINE__,				\
33 			 list_size(&dev->free_buff_list),		\
34 			 list_size(&dev->rec_buff_list)); }
35 
36 static const struct v4l2_dv_timings hdpvr_dv_timings[] = {
37 	V4L2_DV_BT_CEA_720X480I59_94,
38 	V4L2_DV_BT_CEA_720X576I50,
39 	V4L2_DV_BT_CEA_720X480P59_94,
40 	V4L2_DV_BT_CEA_720X576P50,
41 	V4L2_DV_BT_CEA_1280X720P50,
42 	V4L2_DV_BT_CEA_1280X720P60,
43 	V4L2_DV_BT_CEA_1920X1080I50,
44 	V4L2_DV_BT_CEA_1920X1080I60,
45 };
46 
47 /* Use 480i59 as the default timings */
48 #define HDPVR_DEF_DV_TIMINGS_IDX (0)
49 
50 struct hdpvr_fh {
51 	struct v4l2_fh fh;
52 	bool legacy_mode;
53 };
54 
55 static uint list_size(struct list_head *list)
56 {
57 	struct list_head *tmp;
58 	uint count = 0;
59 
60 	list_for_each(tmp, list) {
61 		count++;
62 	}
63 
64 	return count;
65 }
66 
67 /*=========================================================================*/
68 /* urb callback */
69 static void hdpvr_read_bulk_callback(struct urb *urb)
70 {
71 	struct hdpvr_buffer *buf = (struct hdpvr_buffer *)urb->context;
72 	struct hdpvr_device *dev = buf->dev;
73 
74 	/* marking buffer as received and wake waiting */
75 	buf->status = BUFSTAT_READY;
76 	wake_up_interruptible(&dev->wait_data);
77 }
78 
79 /*=========================================================================*/
80 /* buffer bits */
81 
82 /* function expects dev->io_mutex to be hold by caller */
83 int hdpvr_cancel_queue(struct hdpvr_device *dev)
84 {
85 	struct hdpvr_buffer *buf;
86 
87 	list_for_each_entry(buf, &dev->rec_buff_list, buff_list) {
88 		usb_kill_urb(buf->urb);
89 		buf->status = BUFSTAT_AVAILABLE;
90 	}
91 
92 	list_splice_init(&dev->rec_buff_list, dev->free_buff_list.prev);
93 
94 	return 0;
95 }
96 
97 static int hdpvr_free_queue(struct list_head *q)
98 {
99 	struct list_head *tmp;
100 	struct list_head *p;
101 	struct hdpvr_buffer *buf;
102 	struct urb *urb;
103 
104 	for (p = q->next; p != q;) {
105 		buf = list_entry(p, struct hdpvr_buffer, buff_list);
106 
107 		urb = buf->urb;
108 		usb_free_coherent(urb->dev, urb->transfer_buffer_length,
109 				  urb->transfer_buffer, urb->transfer_dma);
110 		usb_free_urb(urb);
111 		tmp = p->next;
112 		list_del(p);
113 		kfree(buf);
114 		p = tmp;
115 	}
116 
117 	return 0;
118 }
119 
120 /* function expects dev->io_mutex to be hold by caller */
121 int hdpvr_free_buffers(struct hdpvr_device *dev)
122 {
123 	hdpvr_cancel_queue(dev);
124 
125 	hdpvr_free_queue(&dev->free_buff_list);
126 	hdpvr_free_queue(&dev->rec_buff_list);
127 
128 	return 0;
129 }
130 
131 /* function expects dev->io_mutex to be hold by caller */
132 int hdpvr_alloc_buffers(struct hdpvr_device *dev, uint count)
133 {
134 	uint i;
135 	int retval = -ENOMEM;
136 	u8 *mem;
137 	struct hdpvr_buffer *buf;
138 	struct urb *urb;
139 
140 	v4l2_dbg(MSG_INFO, hdpvr_debug, &dev->v4l2_dev,
141 		 "allocating %u buffers\n", count);
142 
143 	for (i = 0; i < count; i++) {
144 
145 		buf = kzalloc(sizeof(struct hdpvr_buffer), GFP_KERNEL);
146 		if (!buf) {
147 			v4l2_err(&dev->v4l2_dev, "cannot allocate buffer\n");
148 			goto exit;
149 		}
150 		buf->dev = dev;
151 
152 		urb = usb_alloc_urb(0, GFP_KERNEL);
153 		if (!urb)
154 			goto exit_urb;
155 		buf->urb = urb;
156 
157 		mem = usb_alloc_coherent(dev->udev, dev->bulk_in_size, GFP_KERNEL,
158 					 &urb->transfer_dma);
159 		if (!mem) {
160 			v4l2_err(&dev->v4l2_dev,
161 				 "cannot allocate usb transfer buffer\n");
162 			goto exit_urb_buffer;
163 		}
164 
165 		usb_fill_bulk_urb(buf->urb, dev->udev,
166 				  usb_rcvbulkpipe(dev->udev,
167 						  dev->bulk_in_endpointAddr),
168 				  mem, dev->bulk_in_size,
169 				  hdpvr_read_bulk_callback, buf);
170 
171 		buf->urb->transfer_flags |= URB_NO_TRANSFER_DMA_MAP;
172 		buf->status = BUFSTAT_AVAILABLE;
173 		list_add_tail(&buf->buff_list, &dev->free_buff_list);
174 	}
175 	return 0;
176 exit_urb_buffer:
177 	usb_free_urb(urb);
178 exit_urb:
179 	kfree(buf);
180 exit:
181 	hdpvr_free_buffers(dev);
182 	return retval;
183 }
184 
185 static int hdpvr_submit_buffers(struct hdpvr_device *dev)
186 {
187 	struct hdpvr_buffer *buf;
188 	struct urb *urb;
189 	int ret = 0, err_count = 0;
190 
191 	mutex_lock(&dev->io_mutex);
192 
193 	while (dev->status == STATUS_STREAMING &&
194 	       !list_empty(&dev->free_buff_list)) {
195 
196 		buf = list_entry(dev->free_buff_list.next, struct hdpvr_buffer,
197 				 buff_list);
198 		if (buf->status != BUFSTAT_AVAILABLE) {
199 			v4l2_err(&dev->v4l2_dev,
200 				 "buffer not marked as available\n");
201 			ret = -EFAULT;
202 			goto err;
203 		}
204 
205 		urb = buf->urb;
206 		urb->status = 0;
207 		urb->actual_length = 0;
208 		ret = usb_submit_urb(urb, GFP_KERNEL);
209 		if (ret) {
210 			v4l2_err(&dev->v4l2_dev,
211 				 "usb_submit_urb in %s returned %d\n",
212 				 __func__, ret);
213 			if (++err_count > 2)
214 				break;
215 			continue;
216 		}
217 		buf->status = BUFSTAT_INPROGRESS;
218 		list_move_tail(&buf->buff_list, &dev->rec_buff_list);
219 	}
220 err:
221 	print_buffer_status();
222 	mutex_unlock(&dev->io_mutex);
223 	return ret;
224 }
225 
226 static struct hdpvr_buffer *hdpvr_get_next_buffer(struct hdpvr_device *dev)
227 {
228 	struct hdpvr_buffer *buf;
229 
230 	mutex_lock(&dev->io_mutex);
231 
232 	if (list_empty(&dev->rec_buff_list)) {
233 		mutex_unlock(&dev->io_mutex);
234 		return NULL;
235 	}
236 
237 	buf = list_entry(dev->rec_buff_list.next, struct hdpvr_buffer,
238 			 buff_list);
239 	mutex_unlock(&dev->io_mutex);
240 
241 	return buf;
242 }
243 
244 static void hdpvr_transmit_buffers(struct work_struct *work)
245 {
246 	struct hdpvr_device *dev = container_of(work, struct hdpvr_device,
247 						worker);
248 
249 	while (dev->status == STATUS_STREAMING) {
250 
251 		if (hdpvr_submit_buffers(dev)) {
252 			v4l2_err(&dev->v4l2_dev, "couldn't submit buffers\n");
253 			goto error;
254 		}
255 		if (wait_event_interruptible(dev->wait_buffer,
256 				!list_empty(&dev->free_buff_list) ||
257 					     dev->status != STATUS_STREAMING))
258 			goto error;
259 	}
260 
261 	v4l2_dbg(MSG_INFO, hdpvr_debug, &dev->v4l2_dev,
262 		 "transmit worker exited\n");
263 	return;
264 error:
265 	v4l2_dbg(MSG_INFO, hdpvr_debug, &dev->v4l2_dev,
266 		 "transmit buffers errored\n");
267 	dev->status = STATUS_ERROR;
268 }
269 
270 /* function expects dev->io_mutex to be hold by caller */
271 static int hdpvr_start_streaming(struct hdpvr_device *dev)
272 {
273 	int ret;
274 	struct hdpvr_video_info vidinf;
275 
276 	if (dev->status == STATUS_STREAMING)
277 		return 0;
278 	if (dev->status != STATUS_IDLE)
279 		return -EAGAIN;
280 
281 	ret = get_video_info(dev, &vidinf);
282 	if (ret < 0)
283 		return ret;
284 
285 	if (!vidinf.valid) {
286 		msleep(250);
287 		v4l2_dbg(MSG_INFO, hdpvr_debug, &dev->v4l2_dev,
288 				"no video signal at input %d\n", dev->options.video_input);
289 		return -EAGAIN;
290 	}
291 
292 	v4l2_dbg(MSG_BUFFER, hdpvr_debug, &dev->v4l2_dev,
293 			"video signal: %dx%d@%dhz\n", vidinf.width,
294 			vidinf.height, vidinf.fps);
295 
296 	/* start streaming 2 request */
297 	ret = usb_control_msg(dev->udev,
298 			usb_sndctrlpipe(dev->udev, 0),
299 			0xb8, 0x38, 0x1, 0, NULL, 0, 8000);
300 	v4l2_dbg(MSG_BUFFER, hdpvr_debug, &dev->v4l2_dev,
301 			"encoder start control request returned %d\n", ret);
302 	if (ret < 0)
303 		return ret;
304 
305 	ret = hdpvr_config_call(dev, CTRL_START_STREAMING_VALUE, 0x00);
306 	if (ret)
307 		return ret;
308 
309 	dev->status = STATUS_STREAMING;
310 
311 	INIT_WORK(&dev->worker, hdpvr_transmit_buffers);
312 	schedule_work(&dev->worker);
313 
314 	v4l2_dbg(MSG_BUFFER, hdpvr_debug, &dev->v4l2_dev,
315 			"streaming started\n");
316 
317 	return 0;
318 }
319 
320 
321 /* function expects dev->io_mutex to be hold by caller */
322 static int hdpvr_stop_streaming(struct hdpvr_device *dev)
323 {
324 	int actual_length;
325 	uint c = 0;
326 	u8 *buf;
327 
328 	if (dev->status == STATUS_IDLE)
329 		return 0;
330 	else if (dev->status != STATUS_STREAMING)
331 		return -EAGAIN;
332 
333 	buf = kmalloc(dev->bulk_in_size, GFP_KERNEL);
334 	if (!buf)
335 		v4l2_err(&dev->v4l2_dev, "failed to allocate temporary buffer for emptying the internal device buffer. Next capture start will be slow\n");
336 
337 	dev->status = STATUS_SHUTTING_DOWN;
338 	hdpvr_config_call(dev, CTRL_STOP_STREAMING_VALUE, 0x00);
339 	mutex_unlock(&dev->io_mutex);
340 
341 	wake_up_interruptible(&dev->wait_buffer);
342 	msleep(50);
343 
344 	flush_work(&dev->worker);
345 
346 	mutex_lock(&dev->io_mutex);
347 	/* kill the still outstanding urbs */
348 	hdpvr_cancel_queue(dev);
349 
350 	/* emptying the device buffer beforeshutting it down */
351 	while (buf && ++c < 500 &&
352 	       !usb_bulk_msg(dev->udev,
353 			     usb_rcvbulkpipe(dev->udev,
354 					     dev->bulk_in_endpointAddr),
355 			     buf, dev->bulk_in_size, &actual_length,
356 			     BULK_URB_TIMEOUT)) {
357 		v4l2_dbg(MSG_BUFFER, hdpvr_debug, &dev->v4l2_dev,
358 			 "%2d: got %d bytes\n", c, actual_length);
359 	}
360 	kfree(buf);
361 	v4l2_dbg(MSG_BUFFER, hdpvr_debug, &dev->v4l2_dev,
362 		 "used %d urbs to empty device buffers\n", c-1);
363 	msleep(10);
364 
365 	dev->status = STATUS_IDLE;
366 
367 	return 0;
368 }
369 
370 
371 /*=======================================================================*/
372 /*
373  * video 4 linux 2 file operations
374  */
375 
376 static int hdpvr_open(struct file *file)
377 {
378 	struct hdpvr_fh *fh = kzalloc(sizeof(*fh), GFP_KERNEL);
379 
380 	if (fh == NULL)
381 		return -ENOMEM;
382 	fh->legacy_mode = true;
383 	v4l2_fh_init(&fh->fh, video_devdata(file));
384 	v4l2_fh_add(&fh->fh);
385 	file->private_data = fh;
386 	return 0;
387 }
388 
389 static int hdpvr_release(struct file *file)
390 {
391 	struct hdpvr_device *dev = video_drvdata(file);
392 
393 	mutex_lock(&dev->io_mutex);
394 	if (file->private_data == dev->owner) {
395 		hdpvr_stop_streaming(dev);
396 		dev->owner = NULL;
397 	}
398 	mutex_unlock(&dev->io_mutex);
399 
400 	return v4l2_fh_release(file);
401 }
402 
403 /*
404  * hdpvr_v4l2_read()
405  * will allocate buffers when called for the first time
406  */
407 static ssize_t hdpvr_read(struct file *file, char __user *buffer, size_t count,
408 			  loff_t *pos)
409 {
410 	struct hdpvr_device *dev = video_drvdata(file);
411 	struct hdpvr_buffer *buf = NULL;
412 	struct urb *urb;
413 	unsigned int ret = 0;
414 	int rem, cnt;
415 
416 	if (*pos)
417 		return -ESPIPE;
418 
419 	mutex_lock(&dev->io_mutex);
420 	if (dev->status == STATUS_IDLE) {
421 		if (hdpvr_start_streaming(dev)) {
422 			v4l2_dbg(MSG_INFO, hdpvr_debug, &dev->v4l2_dev,
423 				 "start_streaming failed\n");
424 			ret = -EIO;
425 			msleep(200);
426 			dev->status = STATUS_IDLE;
427 			mutex_unlock(&dev->io_mutex);
428 			goto err;
429 		}
430 		dev->owner = file->private_data;
431 		print_buffer_status();
432 	}
433 	mutex_unlock(&dev->io_mutex);
434 
435 	/* wait for the first buffer */
436 	if (!(file->f_flags & O_NONBLOCK)) {
437 		if (wait_event_interruptible(dev->wait_data,
438 					     hdpvr_get_next_buffer(dev)))
439 			return -ERESTARTSYS;
440 	}
441 
442 	buf = hdpvr_get_next_buffer(dev);
443 
444 	while (count > 0 && buf) {
445 
446 		if (buf->status != BUFSTAT_READY &&
447 		    dev->status != STATUS_DISCONNECTED) {
448 			int err;
449 			/* return nonblocking */
450 			if (file->f_flags & O_NONBLOCK) {
451 				if (!ret)
452 					ret = -EAGAIN;
453 				goto err;
454 			}
455 
456 			err = wait_event_interruptible_timeout(dev->wait_data,
457 				buf->status == BUFSTAT_READY,
458 				msecs_to_jiffies(1000));
459 			if (err < 0) {
460 				ret = err;
461 				goto err;
462 			}
463 			if (!err) {
464 				v4l2_dbg(MSG_INFO, hdpvr_debug, &dev->v4l2_dev,
465 					"timeout: restart streaming\n");
466 				hdpvr_stop_streaming(dev);
467 				msecs_to_jiffies(4000);
468 				err = hdpvr_start_streaming(dev);
469 				if (err) {
470 					ret = err;
471 					goto err;
472 				}
473 			}
474 		}
475 
476 		if (buf->status != BUFSTAT_READY)
477 			break;
478 
479 		/* set remaining bytes to copy */
480 		urb = buf->urb;
481 		rem = urb->actual_length - buf->pos;
482 		cnt = rem > count ? count : rem;
483 
484 		if (copy_to_user(buffer, urb->transfer_buffer + buf->pos,
485 				 cnt)) {
486 			v4l2_err(&dev->v4l2_dev, "read: copy_to_user failed\n");
487 			if (!ret)
488 				ret = -EFAULT;
489 			goto err;
490 		}
491 
492 		buf->pos += cnt;
493 		count -= cnt;
494 		buffer += cnt;
495 		ret += cnt;
496 
497 		/* finished, take next buffer */
498 		if (buf->pos == urb->actual_length) {
499 			mutex_lock(&dev->io_mutex);
500 			buf->pos = 0;
501 			buf->status = BUFSTAT_AVAILABLE;
502 
503 			list_move_tail(&buf->buff_list, &dev->free_buff_list);
504 
505 			print_buffer_status();
506 
507 			mutex_unlock(&dev->io_mutex);
508 
509 			wake_up_interruptible(&dev->wait_buffer);
510 
511 			buf = hdpvr_get_next_buffer(dev);
512 		}
513 	}
514 err:
515 	if (!ret && !buf)
516 		ret = -EAGAIN;
517 	return ret;
518 }
519 
520 static __poll_t hdpvr_poll(struct file *filp, poll_table *wait)
521 {
522 	__poll_t req_events = poll_requested_events(wait);
523 	struct hdpvr_buffer *buf = NULL;
524 	struct hdpvr_device *dev = video_drvdata(filp);
525 	__poll_t mask = v4l2_ctrl_poll(filp, wait);
526 
527 	if (!(req_events & (EPOLLIN | EPOLLRDNORM)))
528 		return mask;
529 
530 	mutex_lock(&dev->io_mutex);
531 
532 	if (dev->status == STATUS_IDLE) {
533 		if (hdpvr_start_streaming(dev)) {
534 			v4l2_dbg(MSG_BUFFER, hdpvr_debug, &dev->v4l2_dev,
535 				 "start_streaming failed\n");
536 			dev->status = STATUS_IDLE;
537 		} else {
538 			dev->owner = filp->private_data;
539 		}
540 
541 		print_buffer_status();
542 	}
543 	mutex_unlock(&dev->io_mutex);
544 
545 	buf = hdpvr_get_next_buffer(dev);
546 	/* only wait if no data is available */
547 	if (!buf || buf->status != BUFSTAT_READY) {
548 		poll_wait(filp, &dev->wait_data, wait);
549 		buf = hdpvr_get_next_buffer(dev);
550 	}
551 	if (buf && buf->status == BUFSTAT_READY)
552 		mask |= EPOLLIN | EPOLLRDNORM;
553 
554 	return mask;
555 }
556 
557 
558 static const struct v4l2_file_operations hdpvr_fops = {
559 	.owner		= THIS_MODULE,
560 	.open		= hdpvr_open,
561 	.release	= hdpvr_release,
562 	.read		= hdpvr_read,
563 	.poll		= hdpvr_poll,
564 	.unlocked_ioctl	= video_ioctl2,
565 };
566 
567 /*=======================================================================*/
568 /*
569  * V4L2 ioctl handling
570  */
571 
572 static int vidioc_querycap(struct file *file, void  *priv,
573 			   struct v4l2_capability *cap)
574 {
575 	struct hdpvr_device *dev = video_drvdata(file);
576 
577 	strscpy(cap->driver, "hdpvr", sizeof(cap->driver));
578 	strscpy(cap->card, "Hauppauge HD PVR", sizeof(cap->card));
579 	usb_make_path(dev->udev, cap->bus_info, sizeof(cap->bus_info));
580 	cap->device_caps = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_AUDIO |
581 			    V4L2_CAP_READWRITE;
582 	cap->capabilities = cap->device_caps | V4L2_CAP_DEVICE_CAPS;
583 	return 0;
584 }
585 
586 static int vidioc_s_std(struct file *file, void *_fh,
587 			v4l2_std_id std)
588 {
589 	struct hdpvr_device *dev = video_drvdata(file);
590 	struct hdpvr_fh *fh = _fh;
591 	u8 std_type = 1;
592 
593 	if (!fh->legacy_mode && dev->options.video_input == HDPVR_COMPONENT)
594 		return -ENODATA;
595 	if (dev->status != STATUS_IDLE)
596 		return -EBUSY;
597 	if (std & V4L2_STD_525_60)
598 		std_type = 0;
599 	dev->cur_std = std;
600 	dev->width = 720;
601 	dev->height = std_type ? 576 : 480;
602 
603 	return hdpvr_config_call(dev, CTRL_VIDEO_STD_TYPE, std_type);
604 }
605 
606 static int vidioc_g_std(struct file *file, void *_fh,
607 			v4l2_std_id *std)
608 {
609 	struct hdpvr_device *dev = video_drvdata(file);
610 	struct hdpvr_fh *fh = _fh;
611 
612 	if (!fh->legacy_mode && dev->options.video_input == HDPVR_COMPONENT)
613 		return -ENODATA;
614 	*std = dev->cur_std;
615 	return 0;
616 }
617 
618 static int vidioc_querystd(struct file *file, void *_fh, v4l2_std_id *a)
619 {
620 	struct hdpvr_device *dev = video_drvdata(file);
621 	struct hdpvr_video_info vid_info;
622 	struct hdpvr_fh *fh = _fh;
623 	int ret;
624 
625 	*a = V4L2_STD_UNKNOWN;
626 	if (dev->options.video_input == HDPVR_COMPONENT)
627 		return fh->legacy_mode ? 0 : -ENODATA;
628 	ret = get_video_info(dev, &vid_info);
629 	if (vid_info.valid && vid_info.width == 720 &&
630 	    (vid_info.height == 480 || vid_info.height == 576)) {
631 		*a = (vid_info.height == 480) ?
632 			V4L2_STD_525_60 : V4L2_STD_625_50;
633 	}
634 	return ret;
635 }
636 
637 static int vidioc_s_dv_timings(struct file *file, void *_fh,
638 				    struct v4l2_dv_timings *timings)
639 {
640 	struct hdpvr_device *dev = video_drvdata(file);
641 	struct hdpvr_fh *fh = _fh;
642 	int i;
643 
644 	fh->legacy_mode = false;
645 	if (dev->options.video_input)
646 		return -ENODATA;
647 	if (dev->status != STATUS_IDLE)
648 		return -EBUSY;
649 	for (i = 0; i < ARRAY_SIZE(hdpvr_dv_timings); i++)
650 		if (v4l2_match_dv_timings(timings, hdpvr_dv_timings + i, 0, false))
651 			break;
652 	if (i == ARRAY_SIZE(hdpvr_dv_timings))
653 		return -EINVAL;
654 	dev->cur_dv_timings = hdpvr_dv_timings[i];
655 	dev->width = hdpvr_dv_timings[i].bt.width;
656 	dev->height = hdpvr_dv_timings[i].bt.height;
657 	return 0;
658 }
659 
660 static int vidioc_g_dv_timings(struct file *file, void *_fh,
661 				    struct v4l2_dv_timings *timings)
662 {
663 	struct hdpvr_device *dev = video_drvdata(file);
664 	struct hdpvr_fh *fh = _fh;
665 
666 	fh->legacy_mode = false;
667 	if (dev->options.video_input)
668 		return -ENODATA;
669 	*timings = dev->cur_dv_timings;
670 	return 0;
671 }
672 
673 static int vidioc_query_dv_timings(struct file *file, void *_fh,
674 				    struct v4l2_dv_timings *timings)
675 {
676 	struct hdpvr_device *dev = video_drvdata(file);
677 	struct hdpvr_fh *fh = _fh;
678 	struct hdpvr_video_info vid_info;
679 	bool interlaced;
680 	int ret = 0;
681 	int i;
682 
683 	fh->legacy_mode = false;
684 	if (dev->options.video_input)
685 		return -ENODATA;
686 	ret = get_video_info(dev, &vid_info);
687 	if (ret)
688 		return ret;
689 	if (!vid_info.valid)
690 		return -ENOLCK;
691 	interlaced = vid_info.fps <= 30;
692 	for (i = 0; i < ARRAY_SIZE(hdpvr_dv_timings); i++) {
693 		const struct v4l2_bt_timings *bt = &hdpvr_dv_timings[i].bt;
694 		unsigned hsize;
695 		unsigned vsize;
696 		unsigned fps;
697 
698 		hsize = V4L2_DV_BT_FRAME_WIDTH(bt);
699 		vsize = V4L2_DV_BT_FRAME_HEIGHT(bt);
700 		fps = (unsigned)bt->pixelclock / (hsize * vsize);
701 		if (bt->width != vid_info.width ||
702 		    bt->height != vid_info.height ||
703 		    bt->interlaced != interlaced ||
704 		    (fps != vid_info.fps && fps + 1 != vid_info.fps))
705 			continue;
706 		*timings = hdpvr_dv_timings[i];
707 		break;
708 	}
709 	if (i == ARRAY_SIZE(hdpvr_dv_timings))
710 		ret = -ERANGE;
711 
712 	return ret;
713 }
714 
715 static int vidioc_enum_dv_timings(struct file *file, void *_fh,
716 				    struct v4l2_enum_dv_timings *timings)
717 {
718 	struct hdpvr_device *dev = video_drvdata(file);
719 	struct hdpvr_fh *fh = _fh;
720 
721 	fh->legacy_mode = false;
722 	memset(timings->reserved, 0, sizeof(timings->reserved));
723 	if (dev->options.video_input)
724 		return -ENODATA;
725 	if (timings->index >= ARRAY_SIZE(hdpvr_dv_timings))
726 		return -EINVAL;
727 	timings->timings = hdpvr_dv_timings[timings->index];
728 	return 0;
729 }
730 
731 static int vidioc_dv_timings_cap(struct file *file, void *_fh,
732 				    struct v4l2_dv_timings_cap *cap)
733 {
734 	struct hdpvr_device *dev = video_drvdata(file);
735 	struct hdpvr_fh *fh = _fh;
736 
737 	fh->legacy_mode = false;
738 	if (dev->options.video_input)
739 		return -ENODATA;
740 	cap->type = V4L2_DV_BT_656_1120;
741 	cap->bt.min_width = 720;
742 	cap->bt.max_width = 1920;
743 	cap->bt.min_height = 480;
744 	cap->bt.max_height = 1080;
745 	cap->bt.min_pixelclock = 27000000;
746 	cap->bt.max_pixelclock = 74250000;
747 	cap->bt.standards = V4L2_DV_BT_STD_CEA861;
748 	cap->bt.capabilities = V4L2_DV_BT_CAP_INTERLACED | V4L2_DV_BT_CAP_PROGRESSIVE;
749 	return 0;
750 }
751 
752 static const char *iname[] = {
753 	[HDPVR_COMPONENT] = "Component",
754 	[HDPVR_SVIDEO]    = "S-Video",
755 	[HDPVR_COMPOSITE] = "Composite",
756 };
757 
758 static int vidioc_enum_input(struct file *file, void *_fh, struct v4l2_input *i)
759 {
760 	unsigned int n;
761 
762 	n = i->index;
763 	if (n >= HDPVR_VIDEO_INPUTS)
764 		return -EINVAL;
765 
766 	i->type = V4L2_INPUT_TYPE_CAMERA;
767 
768 	strscpy(i->name, iname[n], sizeof(i->name));
769 
770 	i->audioset = 1<<HDPVR_RCA_FRONT | 1<<HDPVR_RCA_BACK | 1<<HDPVR_SPDIF;
771 
772 	i->capabilities = n ? V4L2_IN_CAP_STD : V4L2_IN_CAP_DV_TIMINGS;
773 	i->std = n ? V4L2_STD_ALL : 0;
774 
775 	return 0;
776 }
777 
778 static int vidioc_s_input(struct file *file, void *_fh,
779 			  unsigned int index)
780 {
781 	struct hdpvr_device *dev = video_drvdata(file);
782 	int retval;
783 
784 	if (index >= HDPVR_VIDEO_INPUTS)
785 		return -EINVAL;
786 
787 	if (dev->status != STATUS_IDLE)
788 		return -EBUSY;
789 
790 	retval = hdpvr_config_call(dev, CTRL_VIDEO_INPUT_VALUE, index+1);
791 	if (!retval) {
792 		dev->options.video_input = index;
793 		/*
794 		 * Unfortunately gstreamer calls ENUMSTD and bails out if it
795 		 * won't find any formats, even though component input is
796 		 * selected. This means that we have to leave tvnorms at
797 		 * V4L2_STD_ALL. We cannot use the 'legacy' trick since
798 		 * tvnorms is set at the device node level and not at the
799 		 * filehandle level.
800 		 *
801 		 * Comment this out for now, but if the legacy mode can be
802 		 * removed in the future, then this code should be enabled
803 		 * again.
804 		dev->video_dev.tvnorms =
805 			(index != HDPVR_COMPONENT) ? V4L2_STD_ALL : 0;
806 		 */
807 	}
808 
809 	return retval;
810 }
811 
812 static int vidioc_g_input(struct file *file, void *private_data,
813 			  unsigned int *index)
814 {
815 	struct hdpvr_device *dev = video_drvdata(file);
816 
817 	*index = dev->options.video_input;
818 	return 0;
819 }
820 
821 
822 static const char *audio_iname[] = {
823 	[HDPVR_RCA_FRONT] = "RCA front",
824 	[HDPVR_RCA_BACK]  = "RCA back",
825 	[HDPVR_SPDIF]     = "SPDIF",
826 };
827 
828 static int vidioc_enumaudio(struct file *file, void *priv,
829 				struct v4l2_audio *audio)
830 {
831 	unsigned int n;
832 
833 	n = audio->index;
834 	if (n >= HDPVR_AUDIO_INPUTS)
835 		return -EINVAL;
836 
837 	audio->capability = V4L2_AUDCAP_STEREO;
838 
839 	strscpy(audio->name, audio_iname[n], sizeof(audio->name));
840 
841 	return 0;
842 }
843 
844 static int vidioc_s_audio(struct file *file, void *private_data,
845 			  const struct v4l2_audio *audio)
846 {
847 	struct hdpvr_device *dev = video_drvdata(file);
848 	int retval;
849 
850 	if (audio->index >= HDPVR_AUDIO_INPUTS)
851 		return -EINVAL;
852 
853 	if (dev->status != STATUS_IDLE)
854 		return -EBUSY;
855 
856 	retval = hdpvr_set_audio(dev, audio->index+1, dev->options.audio_codec);
857 	if (!retval)
858 		dev->options.audio_input = audio->index;
859 
860 	return retval;
861 }
862 
863 static int vidioc_g_audio(struct file *file, void *private_data,
864 			  struct v4l2_audio *audio)
865 {
866 	struct hdpvr_device *dev = video_drvdata(file);
867 
868 	audio->index = dev->options.audio_input;
869 	audio->capability = V4L2_AUDCAP_STEREO;
870 	strscpy(audio->name, audio_iname[audio->index], sizeof(audio->name));
871 	return 0;
872 }
873 
874 static int hdpvr_try_ctrl(struct v4l2_ctrl *ctrl)
875 {
876 	struct hdpvr_device *dev =
877 		container_of(ctrl->handler, struct hdpvr_device, hdl);
878 
879 	switch (ctrl->id) {
880 	case V4L2_CID_MPEG_VIDEO_BITRATE_MODE:
881 		if (ctrl->val == V4L2_MPEG_VIDEO_BITRATE_MODE_VBR &&
882 		    dev->video_bitrate->val >= dev->video_bitrate_peak->val)
883 			dev->video_bitrate_peak->val =
884 					dev->video_bitrate->val + 100000;
885 		break;
886 	}
887 	return 0;
888 }
889 
890 static int hdpvr_s_ctrl(struct v4l2_ctrl *ctrl)
891 {
892 	struct hdpvr_device *dev =
893 		container_of(ctrl->handler, struct hdpvr_device, hdl);
894 	struct hdpvr_options *opt = &dev->options;
895 	int ret = -EINVAL;
896 
897 	switch (ctrl->id) {
898 	case V4L2_CID_BRIGHTNESS:
899 		ret = hdpvr_config_call(dev, CTRL_BRIGHTNESS, ctrl->val);
900 		if (ret)
901 			break;
902 		dev->options.brightness = ctrl->val;
903 		return 0;
904 	case V4L2_CID_CONTRAST:
905 		ret = hdpvr_config_call(dev, CTRL_CONTRAST, ctrl->val);
906 		if (ret)
907 			break;
908 		dev->options.contrast = ctrl->val;
909 		return 0;
910 	case V4L2_CID_SATURATION:
911 		ret = hdpvr_config_call(dev, CTRL_SATURATION, ctrl->val);
912 		if (ret)
913 			break;
914 		dev->options.saturation = ctrl->val;
915 		return 0;
916 	case V4L2_CID_HUE:
917 		ret = hdpvr_config_call(dev, CTRL_HUE, ctrl->val);
918 		if (ret)
919 			break;
920 		dev->options.hue = ctrl->val;
921 		return 0;
922 	case V4L2_CID_SHARPNESS:
923 		ret = hdpvr_config_call(dev, CTRL_SHARPNESS, ctrl->val);
924 		if (ret)
925 			break;
926 		dev->options.sharpness = ctrl->val;
927 		return 0;
928 	case V4L2_CID_MPEG_AUDIO_ENCODING:
929 		if (dev->flags & HDPVR_FLAG_AC3_CAP) {
930 			opt->audio_codec = ctrl->val;
931 			return hdpvr_set_audio(dev, opt->audio_input + 1,
932 					      opt->audio_codec);
933 		}
934 		return 0;
935 	case V4L2_CID_MPEG_VIDEO_ENCODING:
936 		return 0;
937 /*	case V4L2_CID_MPEG_VIDEO_B_FRAMES: */
938 /*		if (ctrl->value == 0 && !(opt->gop_mode & 0x2)) { */
939 /*			opt->gop_mode |= 0x2; */
940 /*			hdpvr_config_call(dev, CTRL_GOP_MODE_VALUE, */
941 /*					  opt->gop_mode); */
942 /*		} */
943 /*		if (ctrl->value == 128 && opt->gop_mode & 0x2) { */
944 /*			opt->gop_mode &= ~0x2; */
945 /*			hdpvr_config_call(dev, CTRL_GOP_MODE_VALUE, */
946 /*					  opt->gop_mode); */
947 /*		} */
948 /*		break; */
949 	case V4L2_CID_MPEG_VIDEO_BITRATE_MODE: {
950 		uint peak_bitrate = dev->video_bitrate_peak->val / 100000;
951 		uint bitrate = dev->video_bitrate->val / 100000;
952 
953 		if (ctrl->is_new) {
954 			if (ctrl->val == V4L2_MPEG_VIDEO_BITRATE_MODE_CBR)
955 				opt->bitrate_mode = HDPVR_CONSTANT;
956 			else
957 				opt->bitrate_mode = HDPVR_VARIABLE_AVERAGE;
958 			hdpvr_config_call(dev, CTRL_BITRATE_MODE_VALUE,
959 					  opt->bitrate_mode);
960 			v4l2_ctrl_activate(dev->video_bitrate_peak,
961 				ctrl->val != V4L2_MPEG_VIDEO_BITRATE_MODE_CBR);
962 		}
963 
964 		if (dev->video_bitrate_peak->is_new ||
965 		    dev->video_bitrate->is_new) {
966 			opt->bitrate = bitrate;
967 			opt->peak_bitrate = peak_bitrate;
968 			hdpvr_set_bitrate(dev);
969 		}
970 		return 0;
971 	}
972 	case V4L2_CID_MPEG_STREAM_TYPE:
973 		return 0;
974 	default:
975 		break;
976 	}
977 	return ret;
978 }
979 
980 static int vidioc_enum_fmt_vid_cap(struct file *file, void *private_data,
981 				    struct v4l2_fmtdesc *f)
982 {
983 	if (f->index != 0)
984 		return -EINVAL;
985 
986 	f->flags = V4L2_FMT_FLAG_COMPRESSED;
987 	strscpy(f->description, "MPEG2-TS with AVC/AAC streams",
988 		sizeof(f->description));
989 	f->pixelformat = V4L2_PIX_FMT_MPEG;
990 
991 	return 0;
992 }
993 
994 static int vidioc_g_fmt_vid_cap(struct file *file, void *_fh,
995 				struct v4l2_format *f)
996 {
997 	struct hdpvr_device *dev = video_drvdata(file);
998 	struct hdpvr_fh *fh = _fh;
999 	int ret;
1000 
1001 	/*
1002 	 * The original driver would always returns the current detected
1003 	 * resolution as the format (and EFAULT if it couldn't be detected).
1004 	 * With the introduction of VIDIOC_QUERY_DV_TIMINGS there is now a
1005 	 * better way of doing this, but to stay compatible with existing
1006 	 * applications we assume legacy mode every time an application opens
1007 	 * the device. Only if one of the new DV_TIMINGS ioctls is called
1008 	 * will the filehandle go into 'normal' mode where g_fmt returns the
1009 	 * last set format.
1010 	 */
1011 	if (fh->legacy_mode) {
1012 		struct hdpvr_video_info vid_info;
1013 
1014 		ret = get_video_info(dev, &vid_info);
1015 		if (ret < 0)
1016 			return ret;
1017 		if (!vid_info.valid)
1018 			return -EFAULT;
1019 		f->fmt.pix.width = vid_info.width;
1020 		f->fmt.pix.height = vid_info.height;
1021 	} else {
1022 		f->fmt.pix.width = dev->width;
1023 		f->fmt.pix.height = dev->height;
1024 	}
1025 	f->fmt.pix.pixelformat	= V4L2_PIX_FMT_MPEG;
1026 	f->fmt.pix.sizeimage	= dev->bulk_in_size;
1027 	f->fmt.pix.bytesperline	= 0;
1028 	if (f->fmt.pix.width == 720) {
1029 		/* SDTV formats */
1030 		f->fmt.pix.colorspace = V4L2_COLORSPACE_SMPTE170M;
1031 		f->fmt.pix.field = V4L2_FIELD_INTERLACED;
1032 	} else {
1033 		/* HDTV formats */
1034 		f->fmt.pix.colorspace = V4L2_COLORSPACE_REC709;
1035 		f->fmt.pix.field = V4L2_FIELD_NONE;
1036 	}
1037 	return 0;
1038 }
1039 
1040 static int vidioc_encoder_cmd(struct file *filp, void *priv,
1041 			       struct v4l2_encoder_cmd *a)
1042 {
1043 	struct hdpvr_device *dev = video_drvdata(filp);
1044 	int res = 0;
1045 
1046 	mutex_lock(&dev->io_mutex);
1047 	a->flags = 0;
1048 
1049 	switch (a->cmd) {
1050 	case V4L2_ENC_CMD_START:
1051 		if (dev->owner && filp->private_data != dev->owner) {
1052 			res = -EBUSY;
1053 			break;
1054 		}
1055 		if (dev->status == STATUS_STREAMING)
1056 			break;
1057 		res = hdpvr_start_streaming(dev);
1058 		if (!res)
1059 			dev->owner = filp->private_data;
1060 		else
1061 			dev->status = STATUS_IDLE;
1062 		break;
1063 	case V4L2_ENC_CMD_STOP:
1064 		if (dev->owner && filp->private_data != dev->owner) {
1065 			res = -EBUSY;
1066 			break;
1067 		}
1068 		if (dev->status == STATUS_IDLE)
1069 			break;
1070 		res = hdpvr_stop_streaming(dev);
1071 		if (!res)
1072 			dev->owner = NULL;
1073 		break;
1074 	default:
1075 		v4l2_dbg(MSG_INFO, hdpvr_debug, &dev->v4l2_dev,
1076 			 "Unsupported encoder cmd %d\n", a->cmd);
1077 		res = -EINVAL;
1078 		break;
1079 	}
1080 
1081 	mutex_unlock(&dev->io_mutex);
1082 	return res;
1083 }
1084 
1085 static int vidioc_try_encoder_cmd(struct file *filp, void *priv,
1086 					struct v4l2_encoder_cmd *a)
1087 {
1088 	a->flags = 0;
1089 	switch (a->cmd) {
1090 	case V4L2_ENC_CMD_START:
1091 	case V4L2_ENC_CMD_STOP:
1092 		return 0;
1093 	default:
1094 		return -EINVAL;
1095 	}
1096 }
1097 
1098 static const struct v4l2_ioctl_ops hdpvr_ioctl_ops = {
1099 	.vidioc_querycap	= vidioc_querycap,
1100 	.vidioc_s_std		= vidioc_s_std,
1101 	.vidioc_g_std		= vidioc_g_std,
1102 	.vidioc_querystd	= vidioc_querystd,
1103 	.vidioc_s_dv_timings	= vidioc_s_dv_timings,
1104 	.vidioc_g_dv_timings	= vidioc_g_dv_timings,
1105 	.vidioc_query_dv_timings= vidioc_query_dv_timings,
1106 	.vidioc_enum_dv_timings	= vidioc_enum_dv_timings,
1107 	.vidioc_dv_timings_cap	= vidioc_dv_timings_cap,
1108 	.vidioc_enum_input	= vidioc_enum_input,
1109 	.vidioc_g_input		= vidioc_g_input,
1110 	.vidioc_s_input		= vidioc_s_input,
1111 	.vidioc_enumaudio	= vidioc_enumaudio,
1112 	.vidioc_g_audio		= vidioc_g_audio,
1113 	.vidioc_s_audio		= vidioc_s_audio,
1114 	.vidioc_enum_fmt_vid_cap= vidioc_enum_fmt_vid_cap,
1115 	.vidioc_g_fmt_vid_cap	= vidioc_g_fmt_vid_cap,
1116 	.vidioc_s_fmt_vid_cap	= vidioc_g_fmt_vid_cap,
1117 	.vidioc_try_fmt_vid_cap	= vidioc_g_fmt_vid_cap,
1118 	.vidioc_encoder_cmd	= vidioc_encoder_cmd,
1119 	.vidioc_try_encoder_cmd	= vidioc_try_encoder_cmd,
1120 	.vidioc_log_status	= v4l2_ctrl_log_status,
1121 	.vidioc_subscribe_event = v4l2_ctrl_subscribe_event,
1122 	.vidioc_unsubscribe_event = v4l2_event_unsubscribe,
1123 };
1124 
1125 static void hdpvr_device_release(struct video_device *vdev)
1126 {
1127 	struct hdpvr_device *dev = video_get_drvdata(vdev);
1128 
1129 	hdpvr_delete(dev);
1130 	mutex_lock(&dev->io_mutex);
1131 	flush_work(&dev->worker);
1132 	mutex_unlock(&dev->io_mutex);
1133 
1134 	v4l2_device_unregister(&dev->v4l2_dev);
1135 	v4l2_ctrl_handler_free(&dev->hdl);
1136 
1137 	/* deregister I2C adapter */
1138 #if IS_ENABLED(CONFIG_I2C)
1139 	mutex_lock(&dev->i2c_mutex);
1140 	i2c_del_adapter(&dev->i2c_adapter);
1141 	mutex_unlock(&dev->i2c_mutex);
1142 #endif /* CONFIG_I2C */
1143 
1144 	kfree(dev->usbc_buf);
1145 	kfree(dev);
1146 }
1147 
1148 static const struct video_device hdpvr_video_template = {
1149 	.fops			= &hdpvr_fops,
1150 	.release		= hdpvr_device_release,
1151 	.ioctl_ops		= &hdpvr_ioctl_ops,
1152 	.tvnorms		= V4L2_STD_ALL,
1153 };
1154 
1155 static const struct v4l2_ctrl_ops hdpvr_ctrl_ops = {
1156 	.try_ctrl = hdpvr_try_ctrl,
1157 	.s_ctrl = hdpvr_s_ctrl,
1158 };
1159 
1160 int hdpvr_register_videodev(struct hdpvr_device *dev, struct device *parent,
1161 			    int devnum)
1162 {
1163 	struct v4l2_ctrl_handler *hdl = &dev->hdl;
1164 	bool ac3 = dev->flags & HDPVR_FLAG_AC3_CAP;
1165 	int res;
1166 
1167 	dev->cur_std = V4L2_STD_525_60;
1168 	dev->width = 720;
1169 	dev->height = 480;
1170 	dev->cur_dv_timings = hdpvr_dv_timings[HDPVR_DEF_DV_TIMINGS_IDX];
1171 	v4l2_ctrl_handler_init(hdl, 11);
1172 	if (dev->fw_ver > 0x15) {
1173 		v4l2_ctrl_new_std(hdl, &hdpvr_ctrl_ops,
1174 			V4L2_CID_BRIGHTNESS, 0x0, 0xff, 1, 0x80);
1175 		v4l2_ctrl_new_std(hdl, &hdpvr_ctrl_ops,
1176 			V4L2_CID_CONTRAST, 0x0, 0xff, 1, 0x40);
1177 		v4l2_ctrl_new_std(hdl, &hdpvr_ctrl_ops,
1178 			V4L2_CID_SATURATION, 0x0, 0xff, 1, 0x40);
1179 		v4l2_ctrl_new_std(hdl, &hdpvr_ctrl_ops,
1180 			V4L2_CID_HUE, 0x0, 0x1e, 1, 0xf);
1181 		v4l2_ctrl_new_std(hdl, &hdpvr_ctrl_ops,
1182 			V4L2_CID_SHARPNESS, 0x0, 0xff, 1, 0x80);
1183 	} else {
1184 		v4l2_ctrl_new_std(hdl, &hdpvr_ctrl_ops,
1185 			V4L2_CID_BRIGHTNESS, 0x0, 0xff, 1, 0x86);
1186 		v4l2_ctrl_new_std(hdl, &hdpvr_ctrl_ops,
1187 			V4L2_CID_CONTRAST, 0x0, 0xff, 1, 0x80);
1188 		v4l2_ctrl_new_std(hdl, &hdpvr_ctrl_ops,
1189 			V4L2_CID_SATURATION, 0x0, 0xff, 1, 0x80);
1190 		v4l2_ctrl_new_std(hdl, &hdpvr_ctrl_ops,
1191 			V4L2_CID_HUE, 0x0, 0xff, 1, 0x80);
1192 		v4l2_ctrl_new_std(hdl, &hdpvr_ctrl_ops,
1193 			V4L2_CID_SHARPNESS, 0x0, 0xff, 1, 0x80);
1194 	}
1195 
1196 	v4l2_ctrl_new_std_menu(hdl, &hdpvr_ctrl_ops,
1197 		V4L2_CID_MPEG_STREAM_TYPE,
1198 		V4L2_MPEG_STREAM_TYPE_MPEG2_TS,
1199 		0x1, V4L2_MPEG_STREAM_TYPE_MPEG2_TS);
1200 	v4l2_ctrl_new_std_menu(hdl, &hdpvr_ctrl_ops,
1201 		V4L2_CID_MPEG_AUDIO_ENCODING,
1202 		ac3 ? V4L2_MPEG_AUDIO_ENCODING_AC3 : V4L2_MPEG_AUDIO_ENCODING_AAC,
1203 		0x7, ac3 ? dev->options.audio_codec : V4L2_MPEG_AUDIO_ENCODING_AAC);
1204 	v4l2_ctrl_new_std_menu(hdl, &hdpvr_ctrl_ops,
1205 		V4L2_CID_MPEG_VIDEO_ENCODING,
1206 		V4L2_MPEG_VIDEO_ENCODING_MPEG_4_AVC, 0x3,
1207 		V4L2_MPEG_VIDEO_ENCODING_MPEG_4_AVC);
1208 
1209 	dev->video_mode = v4l2_ctrl_new_std_menu(hdl, &hdpvr_ctrl_ops,
1210 		V4L2_CID_MPEG_VIDEO_BITRATE_MODE,
1211 		V4L2_MPEG_VIDEO_BITRATE_MODE_CBR, 0,
1212 		V4L2_MPEG_VIDEO_BITRATE_MODE_CBR);
1213 
1214 	dev->video_bitrate = v4l2_ctrl_new_std(hdl, &hdpvr_ctrl_ops,
1215 		V4L2_CID_MPEG_VIDEO_BITRATE,
1216 		1000000, 13500000, 100000, 6500000);
1217 	dev->video_bitrate_peak = v4l2_ctrl_new_std(hdl, &hdpvr_ctrl_ops,
1218 		V4L2_CID_MPEG_VIDEO_BITRATE_PEAK,
1219 		1100000, 20200000, 100000, 9000000);
1220 	dev->v4l2_dev.ctrl_handler = hdl;
1221 	if (hdl->error) {
1222 		res = hdl->error;
1223 		v4l2_err(&dev->v4l2_dev, "Could not register controls\n");
1224 		goto error;
1225 	}
1226 	v4l2_ctrl_cluster(3, &dev->video_mode);
1227 	res = v4l2_ctrl_handler_setup(hdl);
1228 	if (res < 0) {
1229 		v4l2_err(&dev->v4l2_dev, "Could not setup controls\n");
1230 		goto error;
1231 	}
1232 
1233 	/* setup and register video device */
1234 	dev->video_dev = hdpvr_video_template;
1235 	strscpy(dev->video_dev.name, "Hauppauge HD PVR",
1236 		sizeof(dev->video_dev.name));
1237 	dev->video_dev.v4l2_dev = &dev->v4l2_dev;
1238 	video_set_drvdata(&dev->video_dev, dev);
1239 
1240 	res = video_register_device(&dev->video_dev, VFL_TYPE_GRABBER, devnum);
1241 	if (res < 0) {
1242 		v4l2_err(&dev->v4l2_dev, "video_device registration failed\n");
1243 		goto error;
1244 	}
1245 
1246 	return 0;
1247 error:
1248 	v4l2_ctrl_handler_free(hdl);
1249 	return res;
1250 }
1251