1 // SPDX-License-Identifier: GPL-2.0+ 2 /* 3 * Driver for Renesas R-Car VIN 4 * 5 * Copyright (C) 2016 Renesas Electronics Corp. 6 * Copyright (C) 2011-2013 Renesas Solutions Corp. 7 * Copyright (C) 2013 Cogent Embedded, Inc., <source@cogentembedded.com> 8 * Copyright (C) 2008 Magnus Damm 9 * 10 * Based on the soc-camera rcar_vin driver 11 */ 12 13 #include <linux/delay.h> 14 #include <linux/interrupt.h> 15 #include <linux/pm_runtime.h> 16 17 #include <media/videobuf2-dma-contig.h> 18 19 #include "rcar-vin.h" 20 21 /* ----------------------------------------------------------------------------- 22 * HW Functions 23 */ 24 25 /* Register offsets for R-Car VIN */ 26 #define VNMC_REG 0x00 /* Video n Main Control Register */ 27 #define VNMS_REG 0x04 /* Video n Module Status Register */ 28 #define VNFC_REG 0x08 /* Video n Frame Capture Register */ 29 #define VNSLPRC_REG 0x0C /* Video n Start Line Pre-Clip Register */ 30 #define VNELPRC_REG 0x10 /* Video n End Line Pre-Clip Register */ 31 #define VNSPPRC_REG 0x14 /* Video n Start Pixel Pre-Clip Register */ 32 #define VNEPPRC_REG 0x18 /* Video n End Pixel Pre-Clip Register */ 33 #define VNIS_REG 0x2C /* Video n Image Stride Register */ 34 #define VNMB_REG(m) (0x30 + ((m) << 2)) /* Video n Memory Base m Register */ 35 #define VNIE_REG 0x40 /* Video n Interrupt Enable Register */ 36 #define VNINTS_REG 0x44 /* Video n Interrupt Status Register */ 37 #define VNSI_REG 0x48 /* Video n Scanline Interrupt Register */ 38 #define VNMTC_REG 0x4C /* Video n Memory Transfer Control Register */ 39 #define VNDMR_REG 0x58 /* Video n Data Mode Register */ 40 #define VNDMR2_REG 0x5C /* Video n Data Mode Register 2 */ 41 #define VNUVAOF_REG 0x60 /* Video n UV Address Offset Register */ 42 43 /* Register offsets specific for Gen2 */ 44 #define VNSLPOC_REG 0x1C /* Video n Start Line Post-Clip Register */ 45 #define VNELPOC_REG 0x20 /* Video n End Line Post-Clip Register */ 46 #define VNSPPOC_REG 0x24 /* Video n Start Pixel Post-Clip Register */ 47 #define VNEPPOC_REG 0x28 /* Video n End Pixel Post-Clip Register */ 48 #define VNYS_REG 0x50 /* Video n Y Scale Register */ 49 #define VNXS_REG 0x54 /* Video n X Scale Register */ 50 #define VNC1A_REG 0x80 /* Video n Coefficient Set C1A Register */ 51 #define VNC1B_REG 0x84 /* Video n Coefficient Set C1B Register */ 52 #define VNC1C_REG 0x88 /* Video n Coefficient Set C1C Register */ 53 #define VNC2A_REG 0x90 /* Video n Coefficient Set C2A Register */ 54 #define VNC2B_REG 0x94 /* Video n Coefficient Set C2B Register */ 55 #define VNC2C_REG 0x98 /* Video n Coefficient Set C2C Register */ 56 #define VNC3A_REG 0xA0 /* Video n Coefficient Set C3A Register */ 57 #define VNC3B_REG 0xA4 /* Video n Coefficient Set C3B Register */ 58 #define VNC3C_REG 0xA8 /* Video n Coefficient Set C3C Register */ 59 #define VNC4A_REG 0xB0 /* Video n Coefficient Set C4A Register */ 60 #define VNC4B_REG 0xB4 /* Video n Coefficient Set C4B Register */ 61 #define VNC4C_REG 0xB8 /* Video n Coefficient Set C4C Register */ 62 #define VNC5A_REG 0xC0 /* Video n Coefficient Set C5A Register */ 63 #define VNC5B_REG 0xC4 /* Video n Coefficient Set C5B Register */ 64 #define VNC5C_REG 0xC8 /* Video n Coefficient Set C5C Register */ 65 #define VNC6A_REG 0xD0 /* Video n Coefficient Set C6A Register */ 66 #define VNC6B_REG 0xD4 /* Video n Coefficient Set C6B Register */ 67 #define VNC6C_REG 0xD8 /* Video n Coefficient Set C6C Register */ 68 #define VNC7A_REG 0xE0 /* Video n Coefficient Set C7A Register */ 69 #define VNC7B_REG 0xE4 /* Video n Coefficient Set C7B Register */ 70 #define VNC7C_REG 0xE8 /* Video n Coefficient Set C7C Register */ 71 #define VNC8A_REG 0xF0 /* Video n Coefficient Set C8A Register */ 72 #define VNC8B_REG 0xF4 /* Video n Coefficient Set C8B Register */ 73 #define VNC8C_REG 0xF8 /* Video n Coefficient Set C8C Register */ 74 75 /* Register offsets specific for Gen3 */ 76 #define VNCSI_IFMD_REG 0x20 /* Video n CSI2 Interface Mode Register */ 77 #define VNUDS_CTRL_REG 0x80 /* Video n scaling control register */ 78 #define VNUDS_SCALE_REG 0x84 /* Video n scaling factor register */ 79 #define VNUDS_PASS_BWIDTH_REG 0x90 /* Video n passband register */ 80 #define VNUDS_CLIP_SIZE_REG 0xa4 /* Video n UDS output size clipping reg */ 81 82 /* Register bit fields for R-Car VIN */ 83 /* Video n Main Control Register bits */ 84 #define VNMC_INF_MASK (7 << 16) 85 #define VNMC_DPINE (1 << 27) /* Gen3 specific */ 86 #define VNMC_SCLE (1 << 26) /* Gen3 specific */ 87 #define VNMC_FOC (1 << 21) 88 #define VNMC_YCAL (1 << 19) 89 #define VNMC_INF_YUV8_BT656 (0 << 16) 90 #define VNMC_INF_YUV8_BT601 (1 << 16) 91 #define VNMC_INF_YUV10_BT656 (2 << 16) 92 #define VNMC_INF_YUV10_BT601 (3 << 16) 93 #define VNMC_INF_RAW8 (4 << 16) 94 #define VNMC_INF_YUV16 (5 << 16) 95 #define VNMC_INF_RGB888 (6 << 16) 96 #define VNMC_INF_RGB666 (7 << 16) 97 #define VNMC_VUP (1 << 10) 98 #define VNMC_IM_ODD (0 << 3) 99 #define VNMC_IM_ODD_EVEN (1 << 3) 100 #define VNMC_IM_EVEN (2 << 3) 101 #define VNMC_IM_FULL (3 << 3) 102 #define VNMC_BPS (1 << 1) 103 #define VNMC_ME (1 << 0) 104 105 /* Video n Module Status Register bits */ 106 #define VNMS_FBS_MASK (3 << 3) 107 #define VNMS_FBS_SHIFT 3 108 #define VNMS_FS (1 << 2) 109 #define VNMS_AV (1 << 1) 110 #define VNMS_CA (1 << 0) 111 112 /* Video n Frame Capture Register bits */ 113 #define VNFC_C_FRAME (1 << 1) 114 #define VNFC_S_FRAME (1 << 0) 115 116 /* Video n Interrupt Enable Register bits */ 117 #define VNIE_FIE (1 << 4) 118 #define VNIE_EFE (1 << 1) 119 120 /* Video n Interrupt Status Register bits */ 121 #define VNINTS_FIS (1 << 4) 122 123 /* Video n Data Mode Register bits */ 124 #define VNDMR_A8BIT(n) (((n) & 0xff) << 24) 125 #define VNDMR_A8BIT_MASK (0xff << 24) 126 #define VNDMR_YMODE_Y8 (1 << 12) 127 #define VNDMR_EXRGB (1 << 8) 128 #define VNDMR_BPSM (1 << 4) 129 #define VNDMR_ABIT (1 << 2) 130 #define VNDMR_DTMD_YCSEP (1 << 1) 131 #define VNDMR_DTMD_ARGB (1 << 0) 132 #define VNDMR_DTMD_YCSEP_420 (3 << 0) 133 134 /* Video n Data Mode Register 2 bits */ 135 #define VNDMR2_VPS (1 << 30) 136 #define VNDMR2_HPS (1 << 29) 137 #define VNDMR2_CES (1 << 28) 138 #define VNDMR2_YDS (1 << 22) 139 #define VNDMR2_FTEV (1 << 17) 140 #define VNDMR2_VLV(n) ((n & 0xf) << 12) 141 142 /* Video n CSI2 Interface Mode Register (Gen3) */ 143 #define VNCSI_IFMD_DES1 (1 << 26) 144 #define VNCSI_IFMD_DES0 (1 << 25) 145 #define VNCSI_IFMD_CSI_CHSEL(n) (((n) & 0xf) << 0) 146 147 /* Video n scaling control register (Gen3) */ 148 #define VNUDS_CTRL_AMD (1 << 30) 149 150 struct rvin_buffer { 151 struct vb2_v4l2_buffer vb; 152 struct list_head list; 153 }; 154 155 #define to_buf_list(vb2_buffer) (&container_of(vb2_buffer, \ 156 struct rvin_buffer, \ 157 vb)->list) 158 159 static void rvin_write(struct rvin_dev *vin, u32 value, u32 offset) 160 { 161 iowrite32(value, vin->base + offset); 162 } 163 164 static u32 rvin_read(struct rvin_dev *vin, u32 offset) 165 { 166 return ioread32(vin->base + offset); 167 } 168 169 /* ----------------------------------------------------------------------------- 170 * Crop and Scaling 171 */ 172 173 static bool rvin_scaler_needed(const struct rvin_dev *vin) 174 { 175 return !(vin->crop.width == vin->format.width && 176 vin->compose.width == vin->format.width && 177 vin->crop.height == vin->format.height && 178 vin->compose.height == vin->format.height); 179 } 180 181 struct vin_coeff { 182 unsigned short xs_value; 183 u32 coeff_set[24]; 184 }; 185 186 static const struct vin_coeff vin_coeff_set[] = { 187 { 0x0000, { 188 0x00000000, 0x00000000, 0x00000000, 189 0x00000000, 0x00000000, 0x00000000, 190 0x00000000, 0x00000000, 0x00000000, 191 0x00000000, 0x00000000, 0x00000000, 192 0x00000000, 0x00000000, 0x00000000, 193 0x00000000, 0x00000000, 0x00000000, 194 0x00000000, 0x00000000, 0x00000000, 195 0x00000000, 0x00000000, 0x00000000 }, 196 }, 197 { 0x1000, { 198 0x000fa400, 0x000fa400, 0x09625902, 199 0x000003f8, 0x00000403, 0x3de0d9f0, 200 0x001fffed, 0x00000804, 0x3cc1f9c3, 201 0x001003de, 0x00000c01, 0x3cb34d7f, 202 0x002003d2, 0x00000c00, 0x3d24a92d, 203 0x00200bca, 0x00000bff, 0x3df600d2, 204 0x002013cc, 0x000007ff, 0x3ed70c7e, 205 0x00100fde, 0x00000000, 0x3f87c036 }, 206 }, 207 { 0x1200, { 208 0x002ffff1, 0x002ffff1, 0x02a0a9c8, 209 0x002003e7, 0x001ffffa, 0x000185bc, 210 0x002007dc, 0x000003ff, 0x3e52859c, 211 0x00200bd4, 0x00000002, 0x3d53996b, 212 0x00100fd0, 0x00000403, 0x3d04ad2d, 213 0x00000bd5, 0x00000403, 0x3d35ace7, 214 0x3ff003e4, 0x00000801, 0x3dc674a1, 215 0x3fffe800, 0x00000800, 0x3e76f461 }, 216 }, 217 { 0x1400, { 218 0x00100be3, 0x00100be3, 0x04d1359a, 219 0x00000fdb, 0x002003ed, 0x0211fd93, 220 0x00000fd6, 0x002003f4, 0x0002d97b, 221 0x000007d6, 0x002ffffb, 0x3e93b956, 222 0x3ff003da, 0x001003ff, 0x3db49926, 223 0x3fffefe9, 0x00100001, 0x3d655cee, 224 0x3fffd400, 0x00000003, 0x3d65f4b6, 225 0x000fb421, 0x00000402, 0x3dc6547e }, 226 }, 227 { 0x1600, { 228 0x00000bdd, 0x00000bdd, 0x06519578, 229 0x3ff007da, 0x00000be3, 0x03c24973, 230 0x3ff003d9, 0x00000be9, 0x01b30d5f, 231 0x3ffff7df, 0x001003f1, 0x0003c542, 232 0x000fdfec, 0x001003f7, 0x3ec4711d, 233 0x000fc400, 0x002ffffd, 0x3df504f1, 234 0x001fa81a, 0x002ffc00, 0x3d957cc2, 235 0x002f8c3c, 0x00100000, 0x3db5c891 }, 236 }, 237 { 0x1800, { 238 0x3ff003dc, 0x3ff003dc, 0x0791e558, 239 0x000ff7dd, 0x3ff007de, 0x05328554, 240 0x000fe7e3, 0x3ff00be2, 0x03232546, 241 0x000fd7ee, 0x000007e9, 0x0143bd30, 242 0x001fb800, 0x000007ee, 0x00044511, 243 0x002fa015, 0x000007f4, 0x3ef4bcee, 244 0x002f8832, 0x001003f9, 0x3e4514c7, 245 0x001f7853, 0x001003fd, 0x3de54c9f }, 246 }, 247 { 0x1a00, { 248 0x000fefe0, 0x000fefe0, 0x08721d3c, 249 0x001fdbe7, 0x000ffbde, 0x0652a139, 250 0x001fcbf0, 0x000003df, 0x0463292e, 251 0x002fb3ff, 0x3ff007e3, 0x0293a91d, 252 0x002f9c12, 0x3ff00be7, 0x01241905, 253 0x001f8c29, 0x000007ed, 0x3fe470eb, 254 0x000f7c46, 0x000007f2, 0x3f04b8ca, 255 0x3fef7865, 0x000007f6, 0x3e74e4a8 }, 256 }, 257 { 0x1c00, { 258 0x001fd3e9, 0x001fd3e9, 0x08f23d26, 259 0x002fbff3, 0x001fe3e4, 0x0712ad23, 260 0x002fa800, 0x000ff3e0, 0x05631d1b, 261 0x001f9810, 0x000ffbe1, 0x03b3890d, 262 0x000f8c23, 0x000003e3, 0x0233e8fa, 263 0x3fef843b, 0x000003e7, 0x00f430e4, 264 0x3fbf8456, 0x3ff00bea, 0x00046cc8, 265 0x3f8f8c72, 0x3ff00bef, 0x3f3490ac }, 266 }, 267 { 0x1e00, { 268 0x001fbbf4, 0x001fbbf4, 0x09425112, 269 0x001fa800, 0x002fc7ed, 0x0792b110, 270 0x000f980e, 0x001fdbe6, 0x0613110a, 271 0x3fff8c20, 0x001fe7e3, 0x04a368fd, 272 0x3fcf8c33, 0x000ff7e2, 0x0343b8ed, 273 0x3f9f8c4a, 0x000fffe3, 0x0203f8da, 274 0x3f5f9c61, 0x000003e6, 0x00e428c5, 275 0x3f1fb07b, 0x000003eb, 0x3fe440af }, 276 }, 277 { 0x2000, { 278 0x000fa400, 0x000fa400, 0x09625902, 279 0x3fff980c, 0x001fb7f5, 0x0812b0ff, 280 0x3fdf901c, 0x001fc7ed, 0x06b2fcfa, 281 0x3faf902d, 0x001fd3e8, 0x055348f1, 282 0x3f7f983f, 0x001fe3e5, 0x04038ce3, 283 0x3f3fa454, 0x001fefe3, 0x02e3c8d1, 284 0x3f0fb86a, 0x001ff7e4, 0x01c3e8c0, 285 0x3ecfd880, 0x000fffe6, 0x00c404ac }, 286 }, 287 { 0x2200, { 288 0x3fdf9c0b, 0x3fdf9c0b, 0x09725cf4, 289 0x3fbf9818, 0x3fffa400, 0x0842a8f1, 290 0x3f8f9827, 0x000fb3f7, 0x0702f0ec, 291 0x3f5fa037, 0x000fc3ef, 0x05d330e4, 292 0x3f2fac49, 0x001fcfea, 0x04a364d9, 293 0x3effc05c, 0x001fdbe7, 0x038394ca, 294 0x3ecfdc6f, 0x001fe7e6, 0x0273b0bb, 295 0x3ea00083, 0x001fefe6, 0x0183c0a9 }, 296 }, 297 { 0x2400, { 298 0x3f9fa014, 0x3f9fa014, 0x098260e6, 299 0x3f7f9c23, 0x3fcf9c0a, 0x08629ce5, 300 0x3f4fa431, 0x3fefa400, 0x0742d8e1, 301 0x3f1fb440, 0x3fffb3f8, 0x062310d9, 302 0x3eefc850, 0x000fbbf2, 0x050340d0, 303 0x3ecfe062, 0x000fcbec, 0x041364c2, 304 0x3ea00073, 0x001fd3ea, 0x03037cb5, 305 0x3e902086, 0x001fdfe8, 0x022388a5 }, 306 }, 307 { 0x2600, { 308 0x3f5fa81e, 0x3f5fa81e, 0x096258da, 309 0x3f3fac2b, 0x3f8fa412, 0x088290d8, 310 0x3f0fbc38, 0x3fafa408, 0x0772c8d5, 311 0x3eefcc47, 0x3fcfa800, 0x0672f4ce, 312 0x3ecfe456, 0x3fefaffa, 0x05531cc6, 313 0x3eb00066, 0x3fffbbf3, 0x047334bb, 314 0x3ea01c77, 0x000fc7ee, 0x039348ae, 315 0x3ea04486, 0x000fd3eb, 0x02b350a1 }, 316 }, 317 { 0x2800, { 318 0x3f2fb426, 0x3f2fb426, 0x094250ce, 319 0x3f0fc032, 0x3f4fac1b, 0x086284cd, 320 0x3eefd040, 0x3f7fa811, 0x0782acc9, 321 0x3ecfe84c, 0x3f9fa807, 0x06a2d8c4, 322 0x3eb0005b, 0x3fbfac00, 0x05b2f4bc, 323 0x3eb0186a, 0x3fdfb3fa, 0x04c308b4, 324 0x3eb04077, 0x3fefbbf4, 0x03f31ca8, 325 0x3ec06884, 0x000fbff2, 0x03031c9e }, 326 }, 327 { 0x2a00, { 328 0x3f0fc42d, 0x3f0fc42d, 0x090240c4, 329 0x3eefd439, 0x3f2fb822, 0x08526cc2, 330 0x3edfe845, 0x3f4fb018, 0x078294bf, 331 0x3ec00051, 0x3f6fac0f, 0x06b2b4bb, 332 0x3ec0185f, 0x3f8fac07, 0x05e2ccb4, 333 0x3ec0386b, 0x3fafac00, 0x0502e8ac, 334 0x3ed05c77, 0x3fcfb3fb, 0x0432f0a3, 335 0x3ef08482, 0x3fdfbbf6, 0x0372f898 }, 336 }, 337 { 0x2c00, { 338 0x3eefdc31, 0x3eefdc31, 0x08e238b8, 339 0x3edfec3d, 0x3f0fc828, 0x082258b9, 340 0x3ed00049, 0x3f1fc01e, 0x077278b6, 341 0x3ed01455, 0x3f3fb815, 0x06c294b2, 342 0x3ed03460, 0x3f5fb40d, 0x0602acac, 343 0x3ef0506c, 0x3f7fb006, 0x0542c0a4, 344 0x3f107476, 0x3f9fb400, 0x0472c89d, 345 0x3f309c80, 0x3fbfb7fc, 0x03b2cc94 }, 346 }, 347 { 0x2e00, { 348 0x3eefec37, 0x3eefec37, 0x088220b0, 349 0x3ee00041, 0x3effdc2d, 0x07f244ae, 350 0x3ee0144c, 0x3f0fd023, 0x07625cad, 351 0x3ef02c57, 0x3f1fc81a, 0x06c274a9, 352 0x3f004861, 0x3f3fbc13, 0x060288a6, 353 0x3f20686b, 0x3f5fb80c, 0x05529c9e, 354 0x3f408c74, 0x3f6fb805, 0x04b2ac96, 355 0x3f80ac7e, 0x3f8fb800, 0x0402ac8e }, 356 }, 357 { 0x3000, { 358 0x3ef0003a, 0x3ef0003a, 0x084210a6, 359 0x3ef01045, 0x3effec32, 0x07b228a7, 360 0x3f00284e, 0x3f0fdc29, 0x073244a4, 361 0x3f104058, 0x3f0fd420, 0x06a258a2, 362 0x3f305c62, 0x3f2fc818, 0x0612689d, 363 0x3f508069, 0x3f3fc011, 0x05728496, 364 0x3f80a072, 0x3f4fc00a, 0x04d28c90, 365 0x3fc0c07b, 0x3f6fbc04, 0x04429088 }, 366 }, 367 { 0x3200, { 368 0x3f00103e, 0x3f00103e, 0x07f1fc9e, 369 0x3f102447, 0x3f000035, 0x0782149d, 370 0x3f203c4f, 0x3f0ff02c, 0x07122c9c, 371 0x3f405458, 0x3f0fe424, 0x06924099, 372 0x3f607061, 0x3f1fd41d, 0x06024c97, 373 0x3f909068, 0x3f2fcc16, 0x05726490, 374 0x3fc0b070, 0x3f3fc80f, 0x04f26c8a, 375 0x0000d077, 0x3f4fc409, 0x04627484 }, 376 }, 377 { 0x3400, { 378 0x3f202040, 0x3f202040, 0x07a1e898, 379 0x3f303449, 0x3f100c38, 0x0741fc98, 380 0x3f504c50, 0x3f10002f, 0x06e21495, 381 0x3f706459, 0x3f1ff028, 0x06722492, 382 0x3fa08060, 0x3f1fe421, 0x05f2348f, 383 0x3fd09c67, 0x3f1fdc19, 0x05824c89, 384 0x0000bc6e, 0x3f2fd014, 0x04f25086, 385 0x0040dc74, 0x3f3fcc0d, 0x04825c7f }, 386 }, 387 { 0x3600, { 388 0x3f403042, 0x3f403042, 0x0761d890, 389 0x3f504848, 0x3f301c3b, 0x0701f090, 390 0x3f805c50, 0x3f200c33, 0x06a2008f, 391 0x3fa07458, 0x3f10002b, 0x06520c8d, 392 0x3fd0905e, 0x3f1ff424, 0x05e22089, 393 0x0000ac65, 0x3f1fe81d, 0x05823483, 394 0x0030cc6a, 0x3f2fdc18, 0x04f23c81, 395 0x0080e871, 0x3f2fd412, 0x0482407c }, 396 }, 397 { 0x3800, { 398 0x3f604043, 0x3f604043, 0x0721c88a, 399 0x3f80544a, 0x3f502c3c, 0x06d1d88a, 400 0x3fb06851, 0x3f301c35, 0x0681e889, 401 0x3fd08456, 0x3f30082f, 0x0611fc88, 402 0x00009c5d, 0x3f200027, 0x05d20884, 403 0x0030b863, 0x3f2ff421, 0x05621880, 404 0x0070d468, 0x3f2fe81b, 0x0502247c, 405 0x00c0ec6f, 0x3f2fe015, 0x04a22877 }, 406 }, 407 { 0x3a00, { 408 0x3f904c44, 0x3f904c44, 0x06e1b884, 409 0x3fb0604a, 0x3f70383e, 0x0691c885, 410 0x3fe07451, 0x3f502c36, 0x0661d483, 411 0x00009055, 0x3f401831, 0x0601ec81, 412 0x0030a85b, 0x3f300c2a, 0x05b1f480, 413 0x0070c061, 0x3f300024, 0x0562047a, 414 0x00b0d867, 0x3f3ff41e, 0x05020c77, 415 0x00f0f46b, 0x3f2fec19, 0x04a21474 }, 416 }, 417 { 0x3c00, { 418 0x3fb05c43, 0x3fb05c43, 0x06c1b07e, 419 0x3fe06c4b, 0x3f902c3f, 0x0681c081, 420 0x0000844f, 0x3f703838, 0x0631cc7d, 421 0x00309855, 0x3f602433, 0x05d1d47e, 422 0x0060b459, 0x3f50142e, 0x0581e47b, 423 0x00a0c85f, 0x3f400828, 0x0531f078, 424 0x00e0e064, 0x3f300021, 0x0501fc73, 425 0x00b0fc6a, 0x3f3ff41d, 0x04a20873 }, 426 }, 427 { 0x3e00, { 428 0x3fe06444, 0x3fe06444, 0x0681a07a, 429 0x00007849, 0x3fc0503f, 0x0641b07a, 430 0x0020904d, 0x3fa0403a, 0x05f1c07a, 431 0x0060a453, 0x3f803034, 0x05c1c878, 432 0x0090b858, 0x3f70202f, 0x0571d477, 433 0x00d0d05d, 0x3f501829, 0x0531e073, 434 0x0110e462, 0x3f500825, 0x04e1e471, 435 0x01510065, 0x3f40001f, 0x04a1f06d }, 436 }, 437 { 0x4000, { 438 0x00007044, 0x00007044, 0x06519476, 439 0x00208448, 0x3fe05c3f, 0x0621a476, 440 0x0050984d, 0x3fc04c3a, 0x05e1b075, 441 0x0080ac52, 0x3fa03c35, 0x05a1b875, 442 0x00c0c056, 0x3f803030, 0x0561c473, 443 0x0100d45b, 0x3f70202b, 0x0521d46f, 444 0x0140e860, 0x3f601427, 0x04d1d46e, 445 0x01810064, 0x3f500822, 0x0491dc6b }, 446 }, 447 { 0x5000, { 448 0x0110a442, 0x0110a442, 0x0551545e, 449 0x0140b045, 0x00e0983f, 0x0531585f, 450 0x0160c047, 0x00c08c3c, 0x0511645e, 451 0x0190cc4a, 0x00908039, 0x04f1685f, 452 0x01c0dc4c, 0x00707436, 0x04d1705e, 453 0x0200e850, 0x00506833, 0x04b1785b, 454 0x0230f453, 0x00305c30, 0x0491805a, 455 0x02710056, 0x0010542d, 0x04718059 }, 456 }, 457 { 0x6000, { 458 0x01c0bc40, 0x01c0bc40, 0x04c13052, 459 0x01e0c841, 0x01a0b43d, 0x04c13851, 460 0x0210cc44, 0x0180a83c, 0x04a13453, 461 0x0230d845, 0x0160a03a, 0x04913c52, 462 0x0260e047, 0x01409838, 0x04714052, 463 0x0280ec49, 0x01208c37, 0x04514c50, 464 0x02b0f44b, 0x01008435, 0x04414c50, 465 0x02d1004c, 0x00e07c33, 0x0431544f }, 466 }, 467 { 0x7000, { 468 0x0230c83e, 0x0230c83e, 0x04711c4c, 469 0x0250d03f, 0x0210c43c, 0x0471204b, 470 0x0270d840, 0x0200b83c, 0x0451244b, 471 0x0290dc42, 0x01e0b43a, 0x0441244c, 472 0x02b0e443, 0x01c0b038, 0x0441284b, 473 0x02d0ec44, 0x01b0a438, 0x0421304a, 474 0x02f0f445, 0x0190a036, 0x04213449, 475 0x0310f847, 0x01709c34, 0x04213848 }, 476 }, 477 { 0x8000, { 478 0x0280d03d, 0x0280d03d, 0x04310c48, 479 0x02a0d43e, 0x0270c83c, 0x04311047, 480 0x02b0dc3e, 0x0250c83a, 0x04311447, 481 0x02d0e040, 0x0240c03a, 0x04211446, 482 0x02e0e840, 0x0220bc39, 0x04111847, 483 0x0300e842, 0x0210b438, 0x04012445, 484 0x0310f043, 0x0200b037, 0x04012045, 485 0x0330f444, 0x01e0ac36, 0x03f12445 }, 486 }, 487 { 0xefff, { 488 0x0340dc3a, 0x0340dc3a, 0x03b0ec40, 489 0x0340e03a, 0x0330e039, 0x03c0f03e, 490 0x0350e03b, 0x0330dc39, 0x03c0ec3e, 491 0x0350e43a, 0x0320dc38, 0x03c0f43e, 492 0x0360e43b, 0x0320d839, 0x03b0f03e, 493 0x0360e83b, 0x0310d838, 0x03c0fc3b, 494 0x0370e83b, 0x0310d439, 0x03a0f83d, 495 0x0370e83c, 0x0300d438, 0x03b0fc3c }, 496 } 497 }; 498 499 static void rvin_set_coeff(struct rvin_dev *vin, unsigned short xs) 500 { 501 int i; 502 const struct vin_coeff *p_prev_set = NULL; 503 const struct vin_coeff *p_set = NULL; 504 505 /* Look for suitable coefficient values */ 506 for (i = 0; i < ARRAY_SIZE(vin_coeff_set); i++) { 507 p_prev_set = p_set; 508 p_set = &vin_coeff_set[i]; 509 510 if (xs < p_set->xs_value) 511 break; 512 } 513 514 /* Use previous value if its XS value is closer */ 515 if (p_prev_set && 516 xs - p_prev_set->xs_value < p_set->xs_value - xs) 517 p_set = p_prev_set; 518 519 /* Set coefficient registers */ 520 rvin_write(vin, p_set->coeff_set[0], VNC1A_REG); 521 rvin_write(vin, p_set->coeff_set[1], VNC1B_REG); 522 rvin_write(vin, p_set->coeff_set[2], VNC1C_REG); 523 524 rvin_write(vin, p_set->coeff_set[3], VNC2A_REG); 525 rvin_write(vin, p_set->coeff_set[4], VNC2B_REG); 526 rvin_write(vin, p_set->coeff_set[5], VNC2C_REG); 527 528 rvin_write(vin, p_set->coeff_set[6], VNC3A_REG); 529 rvin_write(vin, p_set->coeff_set[7], VNC3B_REG); 530 rvin_write(vin, p_set->coeff_set[8], VNC3C_REG); 531 532 rvin_write(vin, p_set->coeff_set[9], VNC4A_REG); 533 rvin_write(vin, p_set->coeff_set[10], VNC4B_REG); 534 rvin_write(vin, p_set->coeff_set[11], VNC4C_REG); 535 536 rvin_write(vin, p_set->coeff_set[12], VNC5A_REG); 537 rvin_write(vin, p_set->coeff_set[13], VNC5B_REG); 538 rvin_write(vin, p_set->coeff_set[14], VNC5C_REG); 539 540 rvin_write(vin, p_set->coeff_set[15], VNC6A_REG); 541 rvin_write(vin, p_set->coeff_set[16], VNC6B_REG); 542 rvin_write(vin, p_set->coeff_set[17], VNC6C_REG); 543 544 rvin_write(vin, p_set->coeff_set[18], VNC7A_REG); 545 rvin_write(vin, p_set->coeff_set[19], VNC7B_REG); 546 rvin_write(vin, p_set->coeff_set[20], VNC7C_REG); 547 548 rvin_write(vin, p_set->coeff_set[21], VNC8A_REG); 549 rvin_write(vin, p_set->coeff_set[22], VNC8B_REG); 550 rvin_write(vin, p_set->coeff_set[23], VNC8C_REG); 551 } 552 553 void rvin_scaler_gen2(struct rvin_dev *vin) 554 { 555 unsigned int crop_height; 556 u32 xs, ys; 557 558 /* Set scaling coefficient */ 559 crop_height = vin->crop.height; 560 if (V4L2_FIELD_HAS_BOTH(vin->format.field)) 561 crop_height *= 2; 562 563 ys = 0; 564 if (crop_height != vin->compose.height) 565 ys = (4096 * crop_height) / vin->compose.height; 566 rvin_write(vin, ys, VNYS_REG); 567 568 xs = 0; 569 if (vin->crop.width != vin->compose.width) 570 xs = (4096 * vin->crop.width) / vin->compose.width; 571 572 /* Horizontal upscaling is up to double size */ 573 if (xs > 0 && xs < 2048) 574 xs = 2048; 575 576 rvin_write(vin, xs, VNXS_REG); 577 578 /* Horizontal upscaling is done out by scaling down from double size */ 579 if (xs < 4096) 580 xs *= 2; 581 582 rvin_set_coeff(vin, xs); 583 584 /* Set Start/End Pixel/Line Post-Clip */ 585 rvin_write(vin, 0, VNSPPOC_REG); 586 rvin_write(vin, 0, VNSLPOC_REG); 587 rvin_write(vin, vin->format.width - 1, VNEPPOC_REG); 588 589 if (V4L2_FIELD_HAS_BOTH(vin->format.field)) 590 rvin_write(vin, vin->format.height / 2 - 1, VNELPOC_REG); 591 else 592 rvin_write(vin, vin->format.height - 1, VNELPOC_REG); 593 594 vin_dbg(vin, 595 "Pre-Clip: %ux%u@%u:%u YS: %d XS: %d Post-Clip: %ux%u@%u:%u\n", 596 vin->crop.width, vin->crop.height, vin->crop.left, 597 vin->crop.top, ys, xs, vin->format.width, vin->format.height, 598 0, 0); 599 } 600 601 static unsigned int rvin_uds_scale_ratio(unsigned int in, unsigned int out) 602 { 603 unsigned int ratio; 604 605 ratio = in * 4096 / out; 606 return ratio >= 0x10000 ? 0xffff : ratio; 607 } 608 609 static unsigned int rvin_uds_filter_width(unsigned int ratio) 610 { 611 if (ratio >= 0x1000) 612 return 64 * (ratio & 0xf000) / ratio; 613 614 return 64; 615 } 616 617 void rvin_scaler_gen3(struct rvin_dev *vin) 618 { 619 unsigned int ratio_h, ratio_v; 620 unsigned int bwidth_h, bwidth_v; 621 u32 vnmc, clip_size; 622 623 vnmc = rvin_read(vin, VNMC_REG); 624 625 /* Disable scaler if not needed. */ 626 if (!rvin_scaler_needed(vin)) { 627 rvin_write(vin, vnmc & ~VNMC_SCLE, VNMC_REG); 628 return; 629 } 630 631 ratio_h = rvin_uds_scale_ratio(vin->crop.width, vin->compose.width); 632 bwidth_h = rvin_uds_filter_width(ratio_h); 633 634 ratio_v = rvin_uds_scale_ratio(vin->crop.height, vin->compose.height); 635 bwidth_v = rvin_uds_filter_width(ratio_v); 636 637 clip_size = vin->compose.width << 16; 638 639 switch (vin->format.field) { 640 case V4L2_FIELD_INTERLACED_TB: 641 case V4L2_FIELD_INTERLACED_BT: 642 case V4L2_FIELD_INTERLACED: 643 case V4L2_FIELD_SEQ_TB: 644 case V4L2_FIELD_SEQ_BT: 645 clip_size |= vin->compose.height / 2; 646 break; 647 default: 648 clip_size |= vin->compose.height; 649 break; 650 } 651 652 rvin_write(vin, vnmc | VNMC_SCLE, VNMC_REG); 653 rvin_write(vin, VNUDS_CTRL_AMD, VNUDS_CTRL_REG); 654 rvin_write(vin, (ratio_h << 16) | ratio_v, VNUDS_SCALE_REG); 655 rvin_write(vin, (bwidth_h << 16) | bwidth_v, VNUDS_PASS_BWIDTH_REG); 656 rvin_write(vin, clip_size, VNUDS_CLIP_SIZE_REG); 657 658 vin_dbg(vin, "Pre-Clip: %ux%u@%u:%u Post-Clip: %ux%u@%u:%u\n", 659 vin->crop.width, vin->crop.height, vin->crop.left, 660 vin->crop.top, vin->compose.width, vin->compose.height, 661 vin->compose.left, vin->compose.top); 662 } 663 664 void rvin_crop_scale_comp(struct rvin_dev *vin) 665 { 666 const struct rvin_video_format *fmt; 667 u32 stride; 668 669 /* Set Start/End Pixel/Line Pre-Clip */ 670 rvin_write(vin, vin->crop.left, VNSPPRC_REG); 671 rvin_write(vin, vin->crop.left + vin->crop.width - 1, VNEPPRC_REG); 672 rvin_write(vin, vin->crop.top, VNSLPRC_REG); 673 rvin_write(vin, vin->crop.top + vin->crop.height - 1, VNELPRC_REG); 674 675 if (vin->scaler) 676 vin->scaler(vin); 677 678 fmt = rvin_format_from_pixel(vin, vin->format.pixelformat); 679 stride = vin->format.bytesperline / fmt->bpp; 680 681 /* For RAW8 format bpp is 1, but the hardware process RAW8 682 * format in 2 pixel unit hence configure VNIS_REG as stride / 2. 683 */ 684 switch (vin->format.pixelformat) { 685 case V4L2_PIX_FMT_SBGGR8: 686 case V4L2_PIX_FMT_SGBRG8: 687 case V4L2_PIX_FMT_SGRBG8: 688 case V4L2_PIX_FMT_SRGGB8: 689 case V4L2_PIX_FMT_GREY: 690 stride /= 2; 691 break; 692 default: 693 break; 694 } 695 696 rvin_write(vin, stride, VNIS_REG); 697 } 698 699 /* ----------------------------------------------------------------------------- 700 * Hardware setup 701 */ 702 703 static int rvin_setup(struct rvin_dev *vin) 704 { 705 u32 vnmc, dmr, dmr2, interrupts; 706 bool progressive = false, output_is_yuv = false, input_is_yuv = false; 707 708 switch (vin->format.field) { 709 case V4L2_FIELD_TOP: 710 vnmc = VNMC_IM_ODD; 711 break; 712 case V4L2_FIELD_BOTTOM: 713 vnmc = VNMC_IM_EVEN; 714 break; 715 case V4L2_FIELD_INTERLACED: 716 /* Default to TB */ 717 vnmc = VNMC_IM_FULL; 718 /* Use BT if video standard can be read and is 60 Hz format */ 719 if (!vin->info->use_mc && vin->std & V4L2_STD_525_60) 720 vnmc = VNMC_IM_FULL | VNMC_FOC; 721 break; 722 case V4L2_FIELD_INTERLACED_TB: 723 vnmc = VNMC_IM_FULL; 724 break; 725 case V4L2_FIELD_INTERLACED_BT: 726 vnmc = VNMC_IM_FULL | VNMC_FOC; 727 break; 728 case V4L2_FIELD_SEQ_TB: 729 case V4L2_FIELD_SEQ_BT: 730 case V4L2_FIELD_NONE: 731 case V4L2_FIELD_ALTERNATE: 732 vnmc = VNMC_IM_ODD_EVEN; 733 progressive = true; 734 break; 735 default: 736 vnmc = VNMC_IM_ODD; 737 break; 738 } 739 740 /* 741 * Input interface 742 */ 743 switch (vin->mbus_code) { 744 case MEDIA_BUS_FMT_YUYV8_1X16: 745 if (vin->is_csi) 746 /* YCbCr422 8-bit */ 747 vnmc |= VNMC_INF_YUV8_BT601; 748 else 749 /* BT.601/BT.1358 16bit YCbCr422 */ 750 vnmc |= VNMC_INF_YUV16; 751 input_is_yuv = true; 752 break; 753 case MEDIA_BUS_FMT_UYVY8_1X16: 754 if (vin->is_csi) 755 /* YCbCr422 8-bit */ 756 vnmc |= VNMC_INF_YUV8_BT601; 757 else 758 /* BT.601/BT.1358 16bit YCbCr422 */ 759 vnmc |= VNMC_INF_YUV16; 760 vnmc |= VNMC_YCAL; 761 input_is_yuv = true; 762 break; 763 case MEDIA_BUS_FMT_UYVY8_2X8: 764 /* BT.656 8bit YCbCr422 or BT.601 8bit YCbCr422 */ 765 if (!vin->is_csi && 766 vin->parallel.mbus_type == V4L2_MBUS_BT656) 767 vnmc |= VNMC_INF_YUV8_BT656; 768 else 769 vnmc |= VNMC_INF_YUV8_BT601; 770 771 input_is_yuv = true; 772 break; 773 case MEDIA_BUS_FMT_RGB888_1X24: 774 vnmc |= VNMC_INF_RGB888; 775 break; 776 case MEDIA_BUS_FMT_UYVY10_2X10: 777 /* BT.656 10bit YCbCr422 or BT.601 10bit YCbCr422 */ 778 if (!vin->is_csi && 779 vin->parallel.mbus_type == V4L2_MBUS_BT656) 780 vnmc |= VNMC_INF_YUV10_BT656; 781 else 782 vnmc |= VNMC_INF_YUV10_BT601; 783 784 input_is_yuv = true; 785 break; 786 case MEDIA_BUS_FMT_SBGGR8_1X8: 787 case MEDIA_BUS_FMT_SGBRG8_1X8: 788 case MEDIA_BUS_FMT_SGRBG8_1X8: 789 case MEDIA_BUS_FMT_SRGGB8_1X8: 790 case MEDIA_BUS_FMT_Y8_1X8: 791 vnmc |= VNMC_INF_RAW8; 792 break; 793 default: 794 break; 795 } 796 797 /* Make sure input interface and input format is valid. */ 798 if (vin->info->model == RCAR_GEN3) { 799 switch (vnmc & VNMC_INF_MASK) { 800 case VNMC_INF_YUV8_BT656: 801 case VNMC_INF_YUV10_BT656: 802 case VNMC_INF_YUV16: 803 case VNMC_INF_RGB666: 804 if (vin->is_csi) { 805 vin_err(vin, "Invalid setting in MIPI CSI2\n"); 806 return -EINVAL; 807 } 808 break; 809 case VNMC_INF_RAW8: 810 if (!vin->is_csi) { 811 vin_err(vin, "Invalid setting in Digital Pins\n"); 812 return -EINVAL; 813 } 814 break; 815 default: 816 break; 817 } 818 } 819 820 /* Enable VSYNC Field Toggle mode after one VSYNC input */ 821 if (vin->info->model == RCAR_GEN3) 822 dmr2 = VNDMR2_FTEV; 823 else 824 dmr2 = VNDMR2_FTEV | VNDMR2_VLV(1); 825 826 if (!vin->is_csi) { 827 /* Hsync Signal Polarity Select */ 828 if (!(vin->parallel.bus.flags & V4L2_MBUS_HSYNC_ACTIVE_LOW)) 829 dmr2 |= VNDMR2_HPS; 830 831 /* Vsync Signal Polarity Select */ 832 if (!(vin->parallel.bus.flags & V4L2_MBUS_VSYNC_ACTIVE_LOW)) 833 dmr2 |= VNDMR2_VPS; 834 835 /* Data Enable Polarity Select */ 836 if (vin->parallel.bus.flags & V4L2_MBUS_DATA_ENABLE_LOW) 837 dmr2 |= VNDMR2_CES; 838 839 switch (vin->mbus_code) { 840 case MEDIA_BUS_FMT_UYVY8_2X8: 841 if (vin->parallel.bus.bus_width == 8 && 842 vin->parallel.bus.data_shift == 8) 843 dmr2 |= VNDMR2_YDS; 844 break; 845 default: 846 break; 847 } 848 } 849 850 /* 851 * Output format 852 */ 853 switch (vin->format.pixelformat) { 854 case V4L2_PIX_FMT_NV12: 855 case V4L2_PIX_FMT_NV16: 856 rvin_write(vin, 857 ALIGN(vin->format.bytesperline * vin->format.height, 858 0x80), VNUVAOF_REG); 859 dmr = vin->format.pixelformat == V4L2_PIX_FMT_NV12 ? 860 VNDMR_DTMD_YCSEP_420 : VNDMR_DTMD_YCSEP; 861 output_is_yuv = true; 862 break; 863 case V4L2_PIX_FMT_YUYV: 864 dmr = VNDMR_BPSM; 865 output_is_yuv = true; 866 break; 867 case V4L2_PIX_FMT_UYVY: 868 dmr = 0; 869 output_is_yuv = true; 870 break; 871 case V4L2_PIX_FMT_XRGB555: 872 dmr = VNDMR_DTMD_ARGB; 873 break; 874 case V4L2_PIX_FMT_RGB565: 875 dmr = 0; 876 break; 877 case V4L2_PIX_FMT_XBGR32: 878 /* Note: not supported on M1 */ 879 dmr = VNDMR_EXRGB; 880 break; 881 case V4L2_PIX_FMT_ARGB555: 882 dmr = (vin->alpha ? VNDMR_ABIT : 0) | VNDMR_DTMD_ARGB; 883 break; 884 case V4L2_PIX_FMT_ABGR32: 885 dmr = VNDMR_A8BIT(vin->alpha) | VNDMR_EXRGB | VNDMR_DTMD_ARGB; 886 break; 887 case V4L2_PIX_FMT_SBGGR8: 888 case V4L2_PIX_FMT_SGBRG8: 889 case V4L2_PIX_FMT_SGRBG8: 890 case V4L2_PIX_FMT_SRGGB8: 891 dmr = 0; 892 break; 893 case V4L2_PIX_FMT_GREY: 894 if (input_is_yuv) { 895 dmr = VNDMR_DTMD_YCSEP | VNDMR_YMODE_Y8; 896 output_is_yuv = true; 897 } else { 898 dmr = 0; 899 } 900 break; 901 default: 902 vin_err(vin, "Invalid pixelformat (0x%x)\n", 903 vin->format.pixelformat); 904 return -EINVAL; 905 } 906 907 /* Always update on field change */ 908 vnmc |= VNMC_VUP; 909 910 if (!vin->info->use_isp) { 911 /* If input and output use the same colorspace, use bypass mode */ 912 if (input_is_yuv == output_is_yuv) 913 vnmc |= VNMC_BPS; 914 915 if (vin->info->model == RCAR_GEN3) { 916 /* Select between CSI-2 and parallel input */ 917 if (vin->is_csi) 918 vnmc &= ~VNMC_DPINE; 919 else 920 vnmc |= VNMC_DPINE; 921 } 922 } 923 924 /* Progressive or interlaced mode */ 925 interrupts = progressive ? VNIE_FIE : VNIE_EFE; 926 927 /* Ack interrupts */ 928 rvin_write(vin, interrupts, VNINTS_REG); 929 /* Enable interrupts */ 930 rvin_write(vin, interrupts, VNIE_REG); 931 /* Start capturing */ 932 rvin_write(vin, dmr, VNDMR_REG); 933 rvin_write(vin, dmr2, VNDMR2_REG); 934 935 /* Enable module */ 936 rvin_write(vin, vnmc | VNMC_ME, VNMC_REG); 937 938 return 0; 939 } 940 941 static void rvin_disable_interrupts(struct rvin_dev *vin) 942 { 943 rvin_write(vin, 0, VNIE_REG); 944 } 945 946 static u32 rvin_get_interrupt_status(struct rvin_dev *vin) 947 { 948 return rvin_read(vin, VNINTS_REG); 949 } 950 951 static void rvin_ack_interrupt(struct rvin_dev *vin) 952 { 953 rvin_write(vin, rvin_read(vin, VNINTS_REG), VNINTS_REG); 954 } 955 956 static bool rvin_capture_active(struct rvin_dev *vin) 957 { 958 return rvin_read(vin, VNMS_REG) & VNMS_CA; 959 } 960 961 static enum v4l2_field rvin_get_active_field(struct rvin_dev *vin, u32 vnms) 962 { 963 if (vin->format.field == V4L2_FIELD_ALTERNATE) { 964 /* If FS is set it is an Even field. */ 965 if (vnms & VNMS_FS) 966 return V4L2_FIELD_BOTTOM; 967 return V4L2_FIELD_TOP; 968 } 969 970 return vin->format.field; 971 } 972 973 static void rvin_set_slot_addr(struct rvin_dev *vin, int slot, dma_addr_t addr) 974 { 975 const struct rvin_video_format *fmt; 976 int offsetx, offsety; 977 dma_addr_t offset; 978 979 fmt = rvin_format_from_pixel(vin, vin->format.pixelformat); 980 981 /* 982 * There is no HW support for composition do the beast we can 983 * by modifying the buffer offset 984 */ 985 offsetx = vin->compose.left * fmt->bpp; 986 offsety = vin->compose.top * vin->format.bytesperline; 987 offset = addr + offsetx + offsety; 988 989 /* 990 * The address needs to be 128 bytes aligned. Driver should never accept 991 * settings that do not satisfy this in the first place... 992 */ 993 if (WARN_ON((offsetx | offsety | offset) & HW_BUFFER_MASK)) 994 return; 995 996 rvin_write(vin, offset, VNMB_REG(slot)); 997 } 998 999 /* 1000 * Moves a buffer from the queue to the HW slot. If no buffer is 1001 * available use the scratch buffer. The scratch buffer is never 1002 * returned to userspace, its only function is to enable the capture 1003 * loop to keep running. 1004 */ 1005 static void rvin_fill_hw_slot(struct rvin_dev *vin, int slot) 1006 { 1007 struct rvin_buffer *buf; 1008 struct vb2_v4l2_buffer *vbuf; 1009 dma_addr_t phys_addr; 1010 int prev; 1011 1012 /* A already populated slot shall never be overwritten. */ 1013 if (WARN_ON(vin->buf_hw[slot].buffer)) 1014 return; 1015 1016 prev = (slot == 0 ? HW_BUFFER_NUM : slot) - 1; 1017 1018 if (vin->buf_hw[prev].type == HALF_TOP) { 1019 vbuf = vin->buf_hw[prev].buffer; 1020 vin->buf_hw[slot].buffer = vbuf; 1021 vin->buf_hw[slot].type = HALF_BOTTOM; 1022 switch (vin->format.pixelformat) { 1023 case V4L2_PIX_FMT_NV12: 1024 case V4L2_PIX_FMT_NV16: 1025 phys_addr = vin->buf_hw[prev].phys + 1026 vin->format.sizeimage / 4; 1027 break; 1028 default: 1029 phys_addr = vin->buf_hw[prev].phys + 1030 vin->format.sizeimage / 2; 1031 break; 1032 } 1033 } else if ((vin->state != STOPPED && vin->state != RUNNING) || 1034 list_empty(&vin->buf_list)) { 1035 vin->buf_hw[slot].buffer = NULL; 1036 vin->buf_hw[slot].type = FULL; 1037 phys_addr = vin->scratch_phys; 1038 } else { 1039 /* Keep track of buffer we give to HW */ 1040 buf = list_entry(vin->buf_list.next, struct rvin_buffer, list); 1041 vbuf = &buf->vb; 1042 list_del_init(to_buf_list(vbuf)); 1043 vin->buf_hw[slot].buffer = vbuf; 1044 1045 vin->buf_hw[slot].type = 1046 V4L2_FIELD_IS_SEQUENTIAL(vin->format.field) ? 1047 HALF_TOP : FULL; 1048 1049 /* Setup DMA */ 1050 phys_addr = vb2_dma_contig_plane_dma_addr(&vbuf->vb2_buf, 0); 1051 } 1052 1053 vin_dbg(vin, "Filling HW slot: %d type: %d buffer: %p\n", 1054 slot, vin->buf_hw[slot].type, vin->buf_hw[slot].buffer); 1055 1056 vin->buf_hw[slot].phys = phys_addr; 1057 rvin_set_slot_addr(vin, slot, phys_addr); 1058 } 1059 1060 static int rvin_capture_start(struct rvin_dev *vin) 1061 { 1062 int slot, ret; 1063 1064 for (slot = 0; slot < HW_BUFFER_NUM; slot++) { 1065 vin->buf_hw[slot].buffer = NULL; 1066 vin->buf_hw[slot].type = FULL; 1067 } 1068 1069 for (slot = 0; slot < HW_BUFFER_NUM; slot++) 1070 rvin_fill_hw_slot(vin, slot); 1071 1072 ret = rvin_setup(vin); 1073 if (ret) 1074 return ret; 1075 1076 rvin_crop_scale_comp(vin); 1077 1078 vin_dbg(vin, "Starting to capture\n"); 1079 1080 /* Continuous Frame Capture Mode */ 1081 rvin_write(vin, VNFC_C_FRAME, VNFC_REG); 1082 1083 vin->state = STARTING; 1084 1085 return 0; 1086 } 1087 1088 static void rvin_capture_stop(struct rvin_dev *vin) 1089 { 1090 /* Set continuous & single transfer off */ 1091 rvin_write(vin, 0, VNFC_REG); 1092 1093 /* Disable module */ 1094 rvin_write(vin, rvin_read(vin, VNMC_REG) & ~VNMC_ME, VNMC_REG); 1095 } 1096 1097 /* ----------------------------------------------------------------------------- 1098 * DMA Functions 1099 */ 1100 1101 #define RVIN_TIMEOUT_MS 100 1102 #define RVIN_RETRIES 10 1103 1104 static irqreturn_t rvin_irq(int irq, void *data) 1105 { 1106 struct rvin_dev *vin = data; 1107 u32 int_status, vnms; 1108 int slot; 1109 unsigned int handled = 0; 1110 unsigned long flags; 1111 1112 spin_lock_irqsave(&vin->qlock, flags); 1113 1114 int_status = rvin_get_interrupt_status(vin); 1115 if (!int_status) 1116 goto done; 1117 1118 rvin_ack_interrupt(vin); 1119 handled = 1; 1120 1121 /* Nothing to do if nothing was captured. */ 1122 if (!(int_status & VNINTS_FIS)) 1123 goto done; 1124 1125 /* Nothing to do if capture status is 'STOPPED' */ 1126 if (vin->state == STOPPED) { 1127 vin_dbg(vin, "IRQ while state stopped\n"); 1128 goto done; 1129 } 1130 1131 /* Prepare for capture and update state */ 1132 vnms = rvin_read(vin, VNMS_REG); 1133 slot = (vnms & VNMS_FBS_MASK) >> VNMS_FBS_SHIFT; 1134 1135 /* 1136 * To hand buffers back in a known order to userspace start 1137 * to capture first from slot 0. 1138 */ 1139 if (vin->state == STARTING) { 1140 if (slot != 0) { 1141 vin_dbg(vin, "Starting sync slot: %d\n", slot); 1142 goto done; 1143 } 1144 1145 vin_dbg(vin, "Capture start synced!\n"); 1146 vin->state = RUNNING; 1147 } 1148 1149 /* Capture frame */ 1150 if (vin->buf_hw[slot].buffer) { 1151 /* 1152 * Nothing to do but refill the hardware slot if 1153 * capture only filled first half of vb2 buffer. 1154 */ 1155 if (vin->buf_hw[slot].type == HALF_TOP) { 1156 vin->buf_hw[slot].buffer = NULL; 1157 rvin_fill_hw_slot(vin, slot); 1158 goto done; 1159 } 1160 1161 vin->buf_hw[slot].buffer->field = 1162 rvin_get_active_field(vin, vnms); 1163 vin->buf_hw[slot].buffer->sequence = vin->sequence; 1164 vin->buf_hw[slot].buffer->vb2_buf.timestamp = ktime_get_ns(); 1165 vb2_buffer_done(&vin->buf_hw[slot].buffer->vb2_buf, 1166 VB2_BUF_STATE_DONE); 1167 vin->buf_hw[slot].buffer = NULL; 1168 } else { 1169 /* Scratch buffer was used, dropping frame. */ 1170 vin_dbg(vin, "Dropping frame %u\n", vin->sequence); 1171 } 1172 1173 vin->sequence++; 1174 1175 /* Prepare for next frame */ 1176 rvin_fill_hw_slot(vin, slot); 1177 done: 1178 spin_unlock_irqrestore(&vin->qlock, flags); 1179 1180 return IRQ_RETVAL(handled); 1181 } 1182 1183 static void return_unused_buffers(struct rvin_dev *vin, 1184 enum vb2_buffer_state state) 1185 { 1186 struct rvin_buffer *buf, *node; 1187 unsigned long flags; 1188 1189 spin_lock_irqsave(&vin->qlock, flags); 1190 1191 list_for_each_entry_safe(buf, node, &vin->buf_list, list) { 1192 vb2_buffer_done(&buf->vb.vb2_buf, state); 1193 list_del(&buf->list); 1194 } 1195 1196 spin_unlock_irqrestore(&vin->qlock, flags); 1197 } 1198 1199 static int rvin_queue_setup(struct vb2_queue *vq, unsigned int *nbuffers, 1200 unsigned int *nplanes, unsigned int sizes[], 1201 struct device *alloc_devs[]) 1202 1203 { 1204 struct rvin_dev *vin = vb2_get_drv_priv(vq); 1205 1206 /* Make sure the image size is large enough. */ 1207 if (*nplanes) 1208 return sizes[0] < vin->format.sizeimage ? -EINVAL : 0; 1209 1210 *nplanes = 1; 1211 sizes[0] = vin->format.sizeimage; 1212 1213 return 0; 1214 }; 1215 1216 static int rvin_buffer_prepare(struct vb2_buffer *vb) 1217 { 1218 struct rvin_dev *vin = vb2_get_drv_priv(vb->vb2_queue); 1219 unsigned long size = vin->format.sizeimage; 1220 1221 if (vb2_plane_size(vb, 0) < size) { 1222 vin_err(vin, "buffer too small (%lu < %lu)\n", 1223 vb2_plane_size(vb, 0), size); 1224 return -EINVAL; 1225 } 1226 1227 vb2_set_plane_payload(vb, 0, size); 1228 1229 return 0; 1230 } 1231 1232 static void rvin_buffer_queue(struct vb2_buffer *vb) 1233 { 1234 struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb); 1235 struct rvin_dev *vin = vb2_get_drv_priv(vb->vb2_queue); 1236 unsigned long flags; 1237 1238 spin_lock_irqsave(&vin->qlock, flags); 1239 1240 list_add_tail(to_buf_list(vbuf), &vin->buf_list); 1241 1242 spin_unlock_irqrestore(&vin->qlock, flags); 1243 } 1244 1245 static int rvin_mc_validate_format(struct rvin_dev *vin, struct v4l2_subdev *sd, 1246 struct media_pad *pad) 1247 { 1248 struct v4l2_subdev_format fmt = { 1249 .which = V4L2_SUBDEV_FORMAT_ACTIVE, 1250 }; 1251 1252 fmt.pad = pad->index; 1253 if (v4l2_subdev_call(sd, pad, get_fmt, NULL, &fmt)) 1254 return -EPIPE; 1255 1256 switch (fmt.format.code) { 1257 case MEDIA_BUS_FMT_YUYV8_1X16: 1258 case MEDIA_BUS_FMT_UYVY8_1X16: 1259 case MEDIA_BUS_FMT_UYVY8_2X8: 1260 case MEDIA_BUS_FMT_UYVY10_2X10: 1261 case MEDIA_BUS_FMT_RGB888_1X24: 1262 break; 1263 case MEDIA_BUS_FMT_SBGGR8_1X8: 1264 if (vin->format.pixelformat != V4L2_PIX_FMT_SBGGR8) 1265 return -EPIPE; 1266 break; 1267 case MEDIA_BUS_FMT_SGBRG8_1X8: 1268 if (vin->format.pixelformat != V4L2_PIX_FMT_SGBRG8) 1269 return -EPIPE; 1270 break; 1271 case MEDIA_BUS_FMT_SGRBG8_1X8: 1272 if (vin->format.pixelformat != V4L2_PIX_FMT_SGRBG8) 1273 return -EPIPE; 1274 break; 1275 case MEDIA_BUS_FMT_SRGGB8_1X8: 1276 if (vin->format.pixelformat != V4L2_PIX_FMT_SRGGB8) 1277 return -EPIPE; 1278 break; 1279 case MEDIA_BUS_FMT_Y8_1X8: 1280 if (vin->format.pixelformat != V4L2_PIX_FMT_GREY) 1281 return -EPIPE; 1282 break; 1283 default: 1284 return -EPIPE; 1285 } 1286 vin->mbus_code = fmt.format.code; 1287 1288 switch (fmt.format.field) { 1289 case V4L2_FIELD_TOP: 1290 case V4L2_FIELD_BOTTOM: 1291 case V4L2_FIELD_NONE: 1292 case V4L2_FIELD_INTERLACED_TB: 1293 case V4L2_FIELD_INTERLACED_BT: 1294 case V4L2_FIELD_INTERLACED: 1295 case V4L2_FIELD_SEQ_TB: 1296 case V4L2_FIELD_SEQ_BT: 1297 /* Supported natively */ 1298 break; 1299 case V4L2_FIELD_ALTERNATE: 1300 switch (vin->format.field) { 1301 case V4L2_FIELD_TOP: 1302 case V4L2_FIELD_BOTTOM: 1303 case V4L2_FIELD_NONE: 1304 case V4L2_FIELD_ALTERNATE: 1305 break; 1306 case V4L2_FIELD_INTERLACED_TB: 1307 case V4L2_FIELD_INTERLACED_BT: 1308 case V4L2_FIELD_INTERLACED: 1309 case V4L2_FIELD_SEQ_TB: 1310 case V4L2_FIELD_SEQ_BT: 1311 /* Use VIN hardware to combine the two fields */ 1312 fmt.format.height *= 2; 1313 break; 1314 default: 1315 return -EPIPE; 1316 } 1317 break; 1318 default: 1319 return -EPIPE; 1320 } 1321 1322 if (rvin_scaler_needed(vin)) { 1323 /* Gen3 can't scale NV12 */ 1324 if (vin->info->model == RCAR_GEN3 && 1325 vin->format.pixelformat == V4L2_PIX_FMT_NV12) 1326 return -EPIPE; 1327 1328 if (!vin->scaler) 1329 return -EPIPE; 1330 } else { 1331 if (vin->format.pixelformat == V4L2_PIX_FMT_NV12) { 1332 if (ALIGN(fmt.format.width, 32) != vin->format.width || 1333 ALIGN(fmt.format.height, 32) != vin->format.height) 1334 return -EPIPE; 1335 } else { 1336 if (fmt.format.width != vin->format.width || 1337 fmt.format.height != vin->format.height) 1338 return -EPIPE; 1339 } 1340 } 1341 1342 if (fmt.format.code != vin->mbus_code) 1343 return -EPIPE; 1344 1345 return 0; 1346 } 1347 1348 static int rvin_set_stream(struct rvin_dev *vin, int on) 1349 { 1350 struct v4l2_subdev *sd; 1351 struct media_pad *pad; 1352 int ret; 1353 1354 /* No media controller used, simply pass operation to subdevice. */ 1355 if (!vin->info->use_mc) { 1356 ret = v4l2_subdev_call(vin->parallel.subdev, video, s_stream, 1357 on); 1358 1359 return ret == -ENOIOCTLCMD ? 0 : ret; 1360 } 1361 1362 pad = media_pad_remote_pad_first(&vin->pad); 1363 if (!pad) 1364 return -EPIPE; 1365 1366 sd = media_entity_to_v4l2_subdev(pad->entity); 1367 1368 if (!on) { 1369 video_device_pipeline_stop(&vin->vdev); 1370 return v4l2_subdev_call(sd, video, s_stream, 0); 1371 } 1372 1373 ret = rvin_mc_validate_format(vin, sd, pad); 1374 if (ret) 1375 return ret; 1376 1377 ret = video_device_pipeline_alloc_start(&vin->vdev); 1378 if (ret) 1379 return ret; 1380 1381 ret = v4l2_subdev_call(sd, video, s_stream, 1); 1382 if (ret == -ENOIOCTLCMD) 1383 ret = 0; 1384 if (ret) 1385 video_device_pipeline_stop(&vin->vdev); 1386 1387 return ret; 1388 } 1389 1390 int rvin_start_streaming(struct rvin_dev *vin) 1391 { 1392 unsigned long flags; 1393 int ret; 1394 1395 ret = rvin_set_stream(vin, 1); 1396 if (ret) 1397 return ret; 1398 1399 spin_lock_irqsave(&vin->qlock, flags); 1400 1401 vin->sequence = 0; 1402 1403 ret = rvin_capture_start(vin); 1404 if (ret) 1405 rvin_set_stream(vin, 0); 1406 1407 spin_unlock_irqrestore(&vin->qlock, flags); 1408 1409 return ret; 1410 } 1411 1412 static int rvin_start_streaming_vq(struct vb2_queue *vq, unsigned int count) 1413 { 1414 struct rvin_dev *vin = vb2_get_drv_priv(vq); 1415 int ret = -ENOMEM; 1416 1417 /* Allocate scratch buffer. */ 1418 vin->scratch = dma_alloc_coherent(vin->dev, vin->format.sizeimage, 1419 &vin->scratch_phys, GFP_KERNEL); 1420 if (!vin->scratch) 1421 goto err_scratch; 1422 1423 ret = rvin_start_streaming(vin); 1424 if (ret) 1425 goto err_start; 1426 1427 return 0; 1428 err_start: 1429 dma_free_coherent(vin->dev, vin->format.sizeimage, vin->scratch, 1430 vin->scratch_phys); 1431 err_scratch: 1432 return_unused_buffers(vin, VB2_BUF_STATE_QUEUED); 1433 1434 return ret; 1435 } 1436 1437 void rvin_stop_streaming(struct rvin_dev *vin) 1438 { 1439 unsigned int i, retries; 1440 unsigned long flags; 1441 bool buffersFreed; 1442 1443 spin_lock_irqsave(&vin->qlock, flags); 1444 1445 if (vin->state == STOPPED) { 1446 spin_unlock_irqrestore(&vin->qlock, flags); 1447 return; 1448 } 1449 1450 vin->state = STOPPING; 1451 1452 /* Wait until only scratch buffer is used, max 3 interrupts. */ 1453 retries = 0; 1454 while (retries++ < RVIN_RETRIES) { 1455 buffersFreed = true; 1456 for (i = 0; i < HW_BUFFER_NUM; i++) 1457 if (vin->buf_hw[i].buffer) 1458 buffersFreed = false; 1459 1460 if (buffersFreed) 1461 break; 1462 1463 spin_unlock_irqrestore(&vin->qlock, flags); 1464 msleep(RVIN_TIMEOUT_MS); 1465 spin_lock_irqsave(&vin->qlock, flags); 1466 } 1467 1468 /* Wait for streaming to stop */ 1469 retries = 0; 1470 while (retries++ < RVIN_RETRIES) { 1471 1472 rvin_capture_stop(vin); 1473 1474 /* Check if HW is stopped */ 1475 if (!rvin_capture_active(vin)) { 1476 vin->state = STOPPED; 1477 break; 1478 } 1479 1480 spin_unlock_irqrestore(&vin->qlock, flags); 1481 msleep(RVIN_TIMEOUT_MS); 1482 spin_lock_irqsave(&vin->qlock, flags); 1483 } 1484 1485 if (!buffersFreed || vin->state != STOPPED) { 1486 /* 1487 * If this happens something have gone horribly wrong. 1488 * Set state to stopped to prevent the interrupt handler 1489 * to make things worse... 1490 */ 1491 vin_err(vin, "Failed stop HW, something is seriously broken\n"); 1492 vin->state = STOPPED; 1493 } 1494 1495 spin_unlock_irqrestore(&vin->qlock, flags); 1496 1497 /* If something went wrong, free buffers with an error. */ 1498 if (!buffersFreed) { 1499 return_unused_buffers(vin, VB2_BUF_STATE_ERROR); 1500 for (i = 0; i < HW_BUFFER_NUM; i++) { 1501 if (vin->buf_hw[i].buffer) 1502 vb2_buffer_done(&vin->buf_hw[i].buffer->vb2_buf, 1503 VB2_BUF_STATE_ERROR); 1504 } 1505 } 1506 1507 rvin_set_stream(vin, 0); 1508 1509 /* disable interrupts */ 1510 rvin_disable_interrupts(vin); 1511 } 1512 1513 static void rvin_stop_streaming_vq(struct vb2_queue *vq) 1514 { 1515 struct rvin_dev *vin = vb2_get_drv_priv(vq); 1516 1517 rvin_stop_streaming(vin); 1518 1519 /* Free scratch buffer. */ 1520 dma_free_coherent(vin->dev, vin->format.sizeimage, vin->scratch, 1521 vin->scratch_phys); 1522 1523 return_unused_buffers(vin, VB2_BUF_STATE_ERROR); 1524 } 1525 1526 static const struct vb2_ops rvin_qops = { 1527 .queue_setup = rvin_queue_setup, 1528 .buf_prepare = rvin_buffer_prepare, 1529 .buf_queue = rvin_buffer_queue, 1530 .start_streaming = rvin_start_streaming_vq, 1531 .stop_streaming = rvin_stop_streaming_vq, 1532 .wait_prepare = vb2_ops_wait_prepare, 1533 .wait_finish = vb2_ops_wait_finish, 1534 }; 1535 1536 void rvin_dma_unregister(struct rvin_dev *vin) 1537 { 1538 mutex_destroy(&vin->lock); 1539 1540 v4l2_device_unregister(&vin->v4l2_dev); 1541 } 1542 1543 int rvin_dma_register(struct rvin_dev *vin, int irq) 1544 { 1545 struct vb2_queue *q = &vin->queue; 1546 int i, ret; 1547 1548 /* Initialize the top-level structure */ 1549 ret = v4l2_device_register(vin->dev, &vin->v4l2_dev); 1550 if (ret) 1551 return ret; 1552 1553 mutex_init(&vin->lock); 1554 INIT_LIST_HEAD(&vin->buf_list); 1555 1556 spin_lock_init(&vin->qlock); 1557 1558 vin->state = STOPPED; 1559 1560 for (i = 0; i < HW_BUFFER_NUM; i++) 1561 vin->buf_hw[i].buffer = NULL; 1562 1563 /* buffer queue */ 1564 q->type = V4L2_BUF_TYPE_VIDEO_CAPTURE; 1565 q->io_modes = VB2_MMAP | VB2_READ | VB2_DMABUF; 1566 q->lock = &vin->lock; 1567 q->drv_priv = vin; 1568 q->buf_struct_size = sizeof(struct rvin_buffer); 1569 q->ops = &rvin_qops; 1570 q->mem_ops = &vb2_dma_contig_memops; 1571 q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; 1572 q->min_buffers_needed = 4; 1573 q->dev = vin->dev; 1574 1575 ret = vb2_queue_init(q); 1576 if (ret < 0) { 1577 vin_err(vin, "failed to initialize VB2 queue\n"); 1578 goto error; 1579 } 1580 1581 /* irq */ 1582 ret = devm_request_irq(vin->dev, irq, rvin_irq, IRQF_SHARED, 1583 KBUILD_MODNAME, vin); 1584 if (ret) { 1585 vin_err(vin, "failed to request irq\n"); 1586 goto error; 1587 } 1588 1589 return 0; 1590 error: 1591 rvin_dma_unregister(vin); 1592 1593 return ret; 1594 } 1595 1596 /* ----------------------------------------------------------------------------- 1597 * Gen3 CHSEL manipulation 1598 */ 1599 1600 /* 1601 * There is no need to have locking around changing the routing 1602 * as it's only possible to do so when no VIN in the group is 1603 * streaming so nothing can race with the VNMC register. 1604 */ 1605 int rvin_set_channel_routing(struct rvin_dev *vin, u8 chsel) 1606 { 1607 const struct rvin_group_route *route; 1608 u32 ifmd = 0; 1609 u32 vnmc; 1610 int ret; 1611 1612 ret = pm_runtime_resume_and_get(vin->dev); 1613 if (ret < 0) 1614 return ret; 1615 1616 /* Make register writes take effect immediately. */ 1617 vnmc = rvin_read(vin, VNMC_REG); 1618 rvin_write(vin, vnmc & ~VNMC_VUP, VNMC_REG); 1619 1620 /* 1621 * Set data expansion mode to "pad with 0s" by inspecting the routes 1622 * table to find out which bit fields are available in the IFMD 1623 * register. IFMD_DES1 controls data expansion mode for CSI20/21, 1624 * IFMD_DES0 controls data expansion mode for CSI40/41. 1625 */ 1626 for (route = vin->info->routes; route->chsel; route++) { 1627 if (route->csi == RVIN_CSI20 || route->csi == RVIN_CSI21) 1628 ifmd |= VNCSI_IFMD_DES1; 1629 else 1630 ifmd |= VNCSI_IFMD_DES0; 1631 1632 if (ifmd == (VNCSI_IFMD_DES0 | VNCSI_IFMD_DES1)) 1633 break; 1634 } 1635 1636 if (ifmd) { 1637 ifmd |= VNCSI_IFMD_CSI_CHSEL(chsel); 1638 rvin_write(vin, ifmd, VNCSI_IFMD_REG); 1639 } 1640 1641 vin_dbg(vin, "Set IFMD 0x%x\n", ifmd); 1642 1643 vin->chsel = chsel; 1644 1645 /* Restore VNMC. */ 1646 rvin_write(vin, vnmc, VNMC_REG); 1647 1648 pm_runtime_put(vin->dev); 1649 1650 return 0; 1651 } 1652 1653 void rvin_set_alpha(struct rvin_dev *vin, unsigned int alpha) 1654 { 1655 unsigned long flags; 1656 u32 dmr; 1657 1658 spin_lock_irqsave(&vin->qlock, flags); 1659 1660 vin->alpha = alpha; 1661 1662 if (vin->state == STOPPED) 1663 goto out; 1664 1665 switch (vin->format.pixelformat) { 1666 case V4L2_PIX_FMT_ARGB555: 1667 dmr = rvin_read(vin, VNDMR_REG) & ~VNDMR_ABIT; 1668 if (vin->alpha) 1669 dmr |= VNDMR_ABIT; 1670 break; 1671 case V4L2_PIX_FMT_ABGR32: 1672 dmr = rvin_read(vin, VNDMR_REG) & ~VNDMR_A8BIT_MASK; 1673 dmr |= VNDMR_A8BIT(vin->alpha); 1674 break; 1675 default: 1676 goto out; 1677 } 1678 1679 rvin_write(vin, dmr, VNDMR_REG); 1680 out: 1681 spin_unlock_irqrestore(&vin->qlock, flags); 1682 } 1683