1 // SPDX-License-Identifier: GPL-2.0
2 /*
3  * camss-vfe-170.c
4  *
5  * Qualcomm MSM Camera Subsystem - VFE (Video Front End) Module v170
6  *
7  * Copyright (C) 2020-2021 Linaro Ltd.
8  */
9 
10 #include <linux/delay.h>
11 #include <linux/interrupt.h>
12 #include <linux/io.h>
13 #include <linux/iopoll.h>
14 
15 #include "camss.h"
16 #include "camss-vfe.h"
17 
18 #define VFE_HW_VERSION				(0x000)
19 
20 #define VFE_GLOBAL_RESET_CMD			(0x018)
21 #define		GLOBAL_RESET_CMD_CORE		BIT(0)
22 #define		GLOBAL_RESET_CMD_CAMIF		BIT(1)
23 #define		GLOBAL_RESET_CMD_BUS		BIT(2)
24 #define		GLOBAL_RESET_CMD_BUS_BDG	BIT(3)
25 #define		GLOBAL_RESET_CMD_REGISTER	BIT(4)
26 #define		GLOBAL_RESET_CMD_PM		BIT(5)
27 #define		GLOBAL_RESET_CMD_BUS_MISR	BIT(6)
28 #define		GLOBAL_RESET_CMD_TESTGEN	BIT(7)
29 #define		GLOBAL_RESET_CMD_DSP		BIT(8)
30 #define		GLOBAL_RESET_CMD_IDLE_CGC	BIT(9)
31 #define		GLOBAL_RESET_CMD_RDI0		BIT(10)
32 #define		GLOBAL_RESET_CMD_RDI1		BIT(11)
33 #define		GLOBAL_RESET_CMD_RDI2		BIT(12)
34 #define		GLOBAL_RESET_CMD_RDI3		BIT(13)
35 #define		GLOBAL_RESET_CMD_VFE_DOMAIN	BIT(30)
36 #define		GLOBAL_RESET_CMD_RESET_BYPASS	BIT(31)
37 
38 #define VFE_CORE_CFG				(0x050)
39 #define		CFG_PIXEL_PATTERN_YCBYCR	(0x4)
40 #define		CFG_PIXEL_PATTERN_YCRYCB	(0x5)
41 #define		CFG_PIXEL_PATTERN_CBYCRY	(0x6)
42 #define		CFG_PIXEL_PATTERN_CRYCBY	(0x7)
43 #define		CFG_COMPOSITE_REG_UPDATE_EN	BIT(4)
44 
45 #define VFE_IRQ_CMD				(0x058)
46 #define		CMD_GLOBAL_CLEAR		BIT(0)
47 
48 #define VFE_IRQ_MASK_0					(0x05c)
49 #define		MASK_0_CAMIF_SOF			BIT(0)
50 #define		MASK_0_CAMIF_EOF			BIT(1)
51 #define		MASK_0_RDI_REG_UPDATE(n)		BIT((n) + 5)
52 #define		MASK_0_IMAGE_MASTER_n_PING_PONG(n)	BIT((n) + 8)
53 #define		MASK_0_IMAGE_COMPOSITE_DONE_n(n)	BIT((n) + 25)
54 #define		MASK_0_RESET_ACK			BIT(31)
55 
56 #define VFE_IRQ_MASK_1					(0x060)
57 #define		MASK_1_CAMIF_ERROR			BIT(0)
58 #define		MASK_1_VIOLATION			BIT(7)
59 #define		MASK_1_BUS_BDG_HALT_ACK			BIT(8)
60 #define		MASK_1_IMAGE_MASTER_n_BUS_OVERFLOW(n)	BIT((n) + 9)
61 #define		MASK_1_RDI_SOF(n)			BIT((n) + 29)
62 
63 #define VFE_IRQ_CLEAR_0					(0x064)
64 #define VFE_IRQ_CLEAR_1					(0x068)
65 
66 #define VFE_IRQ_STATUS_0				(0x06c)
67 #define		STATUS_0_CAMIF_SOF			BIT(0)
68 #define		STATUS_0_RDI_REG_UPDATE(n)		BIT((n) + 5)
69 #define		STATUS_0_IMAGE_MASTER_PING_PONG(n)	BIT((n) + 8)
70 #define		STATUS_0_IMAGE_COMPOSITE_DONE(n)	BIT((n) + 25)
71 #define		STATUS_0_RESET_ACK			BIT(31)
72 
73 #define VFE_IRQ_STATUS_1				(0x070)
74 #define		STATUS_1_VIOLATION			BIT(7)
75 #define		STATUS_1_BUS_BDG_HALT_ACK		BIT(8)
76 #define		STATUS_1_RDI_SOF(n)			BIT((n) + 27)
77 
78 #define VFE_VIOLATION_STATUS			(0x07c)
79 
80 #define VFE_CAMIF_CMD				(0x478)
81 #define		CMD_CLEAR_CAMIF_STATUS		BIT(2)
82 
83 #define VFE_CAMIF_CFG				(0x47c)
84 #define		CFG_VSYNC_SYNC_EDGE		(0)
85 #define			VSYNC_ACTIVE_HIGH	(0)
86 #define			VSYNC_ACTIVE_LOW	(1)
87 #define		CFG_HSYNC_SYNC_EDGE		(1)
88 #define			HSYNC_ACTIVE_HIGH	(0)
89 #define			HSYNC_ACTIVE_LOW	(1)
90 #define		CFG_VFE_SUBSAMPLE_ENABLE	BIT(4)
91 #define		CFG_BUS_SUBSAMPLE_ENABLE	BIT(5)
92 #define		CFG_VFE_OUTPUT_EN		BIT(6)
93 #define		CFG_BUS_OUTPUT_EN		BIT(7)
94 #define		CFG_BINNING_EN			BIT(9)
95 #define		CFG_FRAME_BASED_EN		BIT(10)
96 #define		CFG_RAW_CROP_EN			BIT(22)
97 
98 #define VFE_REG_UPDATE_CMD			(0x4ac)
99 #define		REG_UPDATE_RDI(n)		BIT(1 + (n))
100 
101 #define VFE_BUS_IRQ_MASK(n)		(0x2044 + (n) * 4)
102 #define VFE_BUS_IRQ_CLEAR(n)		(0x2050 + (n) * 4)
103 #define VFE_BUS_IRQ_STATUS(n)		(0x205c + (n) * 4)
104 #define		STATUS0_COMP_RESET_DONE		BIT(0)
105 #define		STATUS0_COMP_REG_UPDATE0_DONE	BIT(1)
106 #define		STATUS0_COMP_REG_UPDATE1_DONE	BIT(2)
107 #define		STATUS0_COMP_REG_UPDATE2_DONE	BIT(3)
108 #define		STATUS0_COMP_REG_UPDATE3_DONE	BIT(4)
109 #define		STATUS0_COMP_REG_UPDATE_DONE(n)	BIT((n) + 1)
110 #define		STATUS0_COMP0_BUF_DONE		BIT(5)
111 #define		STATUS0_COMP1_BUF_DONE		BIT(6)
112 #define		STATUS0_COMP2_BUF_DONE		BIT(7)
113 #define		STATUS0_COMP3_BUF_DONE		BIT(8)
114 #define		STATUS0_COMP4_BUF_DONE		BIT(9)
115 #define		STATUS0_COMP5_BUF_DONE		BIT(10)
116 #define		STATUS0_COMP_BUF_DONE(n)	BIT((n) + 5)
117 #define		STATUS0_COMP_ERROR		BIT(11)
118 #define		STATUS0_COMP_OVERWRITE		BIT(12)
119 #define		STATUS0_OVERFLOW		BIT(13)
120 #define		STATUS0_VIOLATION		BIT(14)
121 /* WM_CLIENT_BUF_DONE defined for buffers 0:19 */
122 #define		STATUS1_WM_CLIENT_BUF_DONE(n)		BIT(n)
123 #define		STATUS1_EARLY_DONE			BIT(24)
124 #define		STATUS2_DUAL_COMP0_BUF_DONE		BIT(0)
125 #define		STATUS2_DUAL_COMP1_BUF_DONE		BIT(1)
126 #define		STATUS2_DUAL_COMP2_BUF_DONE		BIT(2)
127 #define		STATUS2_DUAL_COMP3_BUF_DONE		BIT(3)
128 #define		STATUS2_DUAL_COMP4_BUF_DONE		BIT(4)
129 #define		STATUS2_DUAL_COMP5_BUF_DONE		BIT(5)
130 #define		STATUS2_DUAL_COMP_BUF_DONE(n)		BIT(n)
131 #define		STATUS2_DUAL_COMP_ERROR			BIT(6)
132 #define		STATUS2_DUAL_COMP_OVERWRITE		BIT(7)
133 
134 #define VFE_BUS_IRQ_CLEAR_GLOBAL		(0x2068)
135 
136 #define VFE_BUS_WM_DEBUG_STATUS_CFG		(0x226c)
137 #define		DEBUG_STATUS_CFG_STATUS0(n)	BIT(n)
138 #define		DEBUG_STATUS_CFG_STATUS1(n)	BIT(8 + (n))
139 
140 #define VFE_BUS_WM_ADDR_SYNC_FRAME_HEADER	(0x2080)
141 
142 #define VFE_BUS_WM_ADDR_SYNC_NO_SYNC		(0x2084)
143 #define		BUS_VER2_MAX_CLIENTS (24)
144 #define		WM_ADDR_NO_SYNC_DEFAULT_VAL \
145 				((1 << BUS_VER2_MAX_CLIENTS) - 1)
146 
147 #define VFE_BUS_WM_CGC_OVERRIDE			(0x200c)
148 #define		WM_CGC_OVERRIDE_ALL		(0xFFFFF)
149 
150 #define VFE_BUS_WM_TEST_BUS_CTRL		(0x211c)
151 
152 #define VFE_BUS_WM_STATUS0(n)			(0x2200 + (n) * 0x100)
153 #define VFE_BUS_WM_STATUS1(n)			(0x2204 + (n) * 0x100)
154 #define VFE_BUS_WM_CFG(n)			(0x2208 + (n) * 0x100)
155 #define		WM_CFG_EN			(0)
156 #define		WM_CFG_MODE			(1)
157 #define			MODE_QCOM_PLAIN	(0)
158 #define			MODE_MIPI_RAW	(1)
159 #define		WM_CFG_VIRTUALFRAME		(2)
160 #define VFE_BUS_WM_HEADER_ADDR(n)		(0x220c + (n) * 0x100)
161 #define VFE_BUS_WM_HEADER_CFG(n)		(0x2210 + (n) * 0x100)
162 #define VFE_BUS_WM_IMAGE_ADDR(n)		(0x2214 + (n) * 0x100)
163 #define VFE_BUS_WM_IMAGE_ADDR_OFFSET(n)		(0x2218 + (n) * 0x100)
164 #define VFE_BUS_WM_BUFFER_WIDTH_CFG(n)		(0x221c + (n) * 0x100)
165 #define		WM_BUFFER_DEFAULT_WIDTH		(0xFF01)
166 
167 #define VFE_BUS_WM_BUFFER_HEIGHT_CFG(n)		(0x2220 + (n) * 0x100)
168 #define VFE_BUS_WM_PACKER_CFG(n)		(0x2224 + (n) * 0x100)
169 
170 #define VFE_BUS_WM_STRIDE(n)			(0x2228 + (n) * 0x100)
171 #define		WM_STRIDE_DEFAULT_STRIDE	(0xFF01)
172 
173 #define VFE_BUS_WM_IRQ_SUBSAMPLE_PERIOD(n)	(0x2248 + (n) * 0x100)
174 #define VFE_BUS_WM_IRQ_SUBSAMPLE_PATTERN(n)	(0x224c + (n) * 0x100)
175 #define VFE_BUS_WM_FRAMEDROP_PERIOD(n)		(0x2250 + (n) * 0x100)
176 #define VFE_BUS_WM_FRAMEDROP_PATTERN(n)		(0x2254 + (n) * 0x100)
177 #define VFE_BUS_WM_FRAME_INC(n)			(0x2258 + (n) * 0x100)
178 #define VFE_BUS_WM_BURST_LIMIT(n)		(0x225c + (n) * 0x100)
179 
180 static u32 vfe_hw_version(struct vfe_device *vfe)
181 {
182 	u32 hw_version = readl_relaxed(vfe->base + VFE_HW_VERSION);
183 
184 	u32 gen = (hw_version >> 28) & 0xF;
185 	u32 rev = (hw_version >> 16) & 0xFFF;
186 	u32 step = hw_version & 0xFFFF;
187 
188 	dev_dbg(vfe->camss->dev, "VFE HW Version = %u.%u.%u\n",
189 		gen, rev, step);
190 
191 	return hw_version;
192 }
193 
194 static inline void vfe_reg_set(struct vfe_device *vfe, u32 reg, u32 set_bits)
195 {
196 	u32 bits = readl_relaxed(vfe->base + reg);
197 
198 	writel_relaxed(bits | set_bits, vfe->base + reg);
199 }
200 
201 static void vfe_global_reset(struct vfe_device *vfe)
202 {
203 	u32 reset_bits = GLOBAL_RESET_CMD_CORE		|
204 			 GLOBAL_RESET_CMD_CAMIF		|
205 			 GLOBAL_RESET_CMD_BUS		|
206 			 GLOBAL_RESET_CMD_BUS_BDG	|
207 			 GLOBAL_RESET_CMD_REGISTER	|
208 			 GLOBAL_RESET_CMD_TESTGEN	|
209 			 GLOBAL_RESET_CMD_DSP		|
210 			 GLOBAL_RESET_CMD_IDLE_CGC	|
211 			 GLOBAL_RESET_CMD_RDI0		|
212 			 GLOBAL_RESET_CMD_RDI1		|
213 			 GLOBAL_RESET_CMD_RDI2;
214 
215 	writel_relaxed(BIT(31), vfe->base + VFE_IRQ_MASK_0);
216 
217 	/* Make sure IRQ mask has been written before resetting */
218 	wmb();
219 
220 	writel_relaxed(reset_bits, vfe->base + VFE_GLOBAL_RESET_CMD);
221 }
222 
223 static void vfe_wm_start(struct vfe_device *vfe, u8 wm, struct vfe_line *line)
224 {
225 	u32 val;
226 
227 	/*Set Debug Registers*/
228 	val = DEBUG_STATUS_CFG_STATUS0(1) |
229 	      DEBUG_STATUS_CFG_STATUS0(7);
230 	writel_relaxed(val, vfe->base + VFE_BUS_WM_DEBUG_STATUS_CFG);
231 
232 	/* BUS_WM_INPUT_IF_ADDR_SYNC_FRAME_HEADER */
233 	writel_relaxed(0, vfe->base + VFE_BUS_WM_ADDR_SYNC_FRAME_HEADER);
234 
235 	/* no clock gating at bus input */
236 	val = WM_CGC_OVERRIDE_ALL;
237 	writel_relaxed(val, vfe->base + VFE_BUS_WM_CGC_OVERRIDE);
238 
239 	writel_relaxed(0x0, vfe->base + VFE_BUS_WM_TEST_BUS_CTRL);
240 
241 	/* if addr_no_sync has default value then config the addr no sync reg */
242 	val = WM_ADDR_NO_SYNC_DEFAULT_VAL;
243 	writel_relaxed(val, vfe->base + VFE_BUS_WM_ADDR_SYNC_NO_SYNC);
244 
245 	writel_relaxed(0xf, vfe->base + VFE_BUS_WM_BURST_LIMIT(wm));
246 
247 	val = WM_BUFFER_DEFAULT_WIDTH;
248 	writel_relaxed(val, vfe->base + VFE_BUS_WM_BUFFER_WIDTH_CFG(wm));
249 
250 	val = 0;
251 	writel_relaxed(val, vfe->base + VFE_BUS_WM_BUFFER_HEIGHT_CFG(wm));
252 
253 	val = 0;
254 	writel_relaxed(val, vfe->base + VFE_BUS_WM_PACKER_CFG(wm)); // XXX 1 for PLAIN8?
255 
256 	/* Configure stride for RDIs */
257 	val = WM_STRIDE_DEFAULT_STRIDE;
258 	writel_relaxed(val, vfe->base + VFE_BUS_WM_STRIDE(wm));
259 
260 	/* Enable WM */
261 	val = 1 << WM_CFG_EN |
262 	      MODE_MIPI_RAW << WM_CFG_MODE;
263 	writel_relaxed(val, vfe->base + VFE_BUS_WM_CFG(wm));
264 }
265 
266 static void vfe_wm_stop(struct vfe_device *vfe, u8 wm)
267 {
268 	/* Disable WM */
269 	writel_relaxed(0, vfe->base + VFE_BUS_WM_CFG(wm));
270 }
271 
272 static void vfe_wm_update(struct vfe_device *vfe, u8 wm, u32 addr,
273 			  struct vfe_line *line)
274 {
275 	struct v4l2_pix_format_mplane *pix =
276 		&line->video_out.active_fmt.fmt.pix_mp;
277 	u32 stride = pix->plane_fmt[0].bytesperline;
278 
279 	writel_relaxed(addr, vfe->base + VFE_BUS_WM_IMAGE_ADDR(wm));
280 	writel_relaxed(stride * pix->height, vfe->base + VFE_BUS_WM_FRAME_INC(wm));
281 }
282 
283 static void vfe_reg_update(struct vfe_device *vfe, enum vfe_line_id line_id)
284 {
285 	vfe->reg_update |= REG_UPDATE_RDI(line_id);
286 
287 	/* Enforce ordering between previous reg writes and reg update */
288 	wmb();
289 
290 	writel_relaxed(vfe->reg_update, vfe->base + VFE_REG_UPDATE_CMD);
291 
292 	/* Enforce ordering between reg update and subsequent reg writes */
293 	wmb();
294 }
295 
296 static inline void vfe_reg_update_clear(struct vfe_device *vfe,
297 					enum vfe_line_id line_id)
298 {
299 	vfe->reg_update &= ~REG_UPDATE_RDI(line_id);
300 }
301 
302 static void vfe_enable_irq_common(struct vfe_device *vfe)
303 {
304 	vfe_reg_set(vfe, VFE_IRQ_MASK_0, ~0u);
305 	vfe_reg_set(vfe, VFE_IRQ_MASK_1, ~0u);
306 
307 	writel_relaxed(~0u, vfe->base + VFE_BUS_IRQ_MASK(0));
308 	writel_relaxed(~0u, vfe->base + VFE_BUS_IRQ_MASK(1));
309 	writel_relaxed(~0u, vfe->base + VFE_BUS_IRQ_MASK(2));
310 }
311 
312 static void vfe_isr_halt_ack(struct vfe_device *vfe)
313 {
314 	complete(&vfe->halt_complete);
315 }
316 
317 static void vfe_isr_read(struct vfe_device *vfe, u32 *status0, u32 *status1)
318 {
319 	*status0 = readl_relaxed(vfe->base + VFE_IRQ_STATUS_0);
320 	*status1 = readl_relaxed(vfe->base + VFE_IRQ_STATUS_1);
321 
322 	writel_relaxed(*status0, vfe->base + VFE_IRQ_CLEAR_0);
323 	writel_relaxed(*status1, vfe->base + VFE_IRQ_CLEAR_1);
324 
325 	/* Enforce ordering between IRQ Clear and Global IRQ Clear */
326 	wmb();
327 	writel_relaxed(CMD_GLOBAL_CLEAR, vfe->base + VFE_IRQ_CMD);
328 }
329 
330 static void vfe_violation_read(struct vfe_device *vfe)
331 {
332 	u32 violation = readl_relaxed(vfe->base + VFE_VIOLATION_STATUS);
333 
334 	pr_err_ratelimited("VFE: violation = 0x%08x\n", violation);
335 }
336 
337 /*
338  * vfe_isr - VFE module interrupt handler
339  * @irq: Interrupt line
340  * @dev: VFE device
341  *
342  * Return IRQ_HANDLED on success
343  */
344 static irqreturn_t vfe_isr(int irq, void *dev)
345 {
346 	struct vfe_device *vfe = dev;
347 	u32 status0, status1, vfe_bus_status[3];
348 	int i, wm;
349 
350 	status0 = readl_relaxed(vfe->base + VFE_IRQ_STATUS_0);
351 	status1 = readl_relaxed(vfe->base + VFE_IRQ_STATUS_1);
352 
353 	writel_relaxed(status0, vfe->base + VFE_IRQ_CLEAR_0);
354 	writel_relaxed(status1, vfe->base + VFE_IRQ_CLEAR_1);
355 
356 	for (i = VFE_LINE_RDI0; i <= VFE_LINE_RDI2; i++) {
357 		vfe_bus_status[i] = readl_relaxed(vfe->base + VFE_BUS_IRQ_STATUS(i));
358 		writel_relaxed(vfe_bus_status[i], vfe->base + VFE_BUS_IRQ_CLEAR(i));
359 	}
360 
361 	/* Enforce ordering between IRQ reading and interpretation */
362 	wmb();
363 
364 	writel_relaxed(CMD_GLOBAL_CLEAR, vfe->base + VFE_IRQ_CMD);
365 	writel_relaxed(1, vfe->base + VFE_BUS_IRQ_CLEAR_GLOBAL);
366 
367 	if (status0 & STATUS_0_RESET_ACK)
368 		vfe->isr_ops.reset_ack(vfe);
369 
370 	for (i = VFE_LINE_RDI0; i <= VFE_LINE_RDI2; i++)
371 		if (status0 & STATUS_0_RDI_REG_UPDATE(i))
372 			vfe->isr_ops.reg_update(vfe, i);
373 
374 	for (i = VFE_LINE_RDI0; i <= VFE_LINE_RDI2; i++)
375 		if (status0 & STATUS_1_RDI_SOF(i))
376 			vfe->isr_ops.sof(vfe, i);
377 
378 	for (i = 0; i < MSM_VFE_COMPOSITE_IRQ_NUM; i++)
379 		if (vfe_bus_status[0] & STATUS0_COMP_BUF_DONE(i))
380 			vfe->isr_ops.comp_done(vfe, i);
381 
382 	for (wm = 0; wm < MSM_VFE_IMAGE_MASTERS_NUM; wm++)
383 		if (status0 & BIT(9))
384 			if (vfe_bus_status[1] & STATUS1_WM_CLIENT_BUF_DONE(wm))
385 				vfe->isr_ops.wm_done(vfe, wm);
386 
387 	return IRQ_HANDLED;
388 }
389 
390 /*
391  * vfe_halt - Trigger halt on VFE module and wait to complete
392  * @vfe: VFE device
393  *
394  * Return 0 on success or a negative error code otherwise
395  */
396 static int vfe_halt(struct vfe_device *vfe)
397 {
398 	unsigned long time;
399 
400 	reinit_completion(&vfe->halt_complete);
401 
402 	time = wait_for_completion_timeout(&vfe->halt_complete,
403 					   msecs_to_jiffies(VFE_HALT_TIMEOUT_MS));
404 	if (!time) {
405 		dev_err(vfe->camss->dev, "VFE halt timeout\n");
406 		return -EIO;
407 	}
408 
409 	return 0;
410 }
411 
412 static int vfe_get_output(struct vfe_line *line)
413 {
414 	struct vfe_device *vfe = to_vfe(line);
415 	struct vfe_output *output;
416 	unsigned long flags;
417 	int wm_idx;
418 
419 	spin_lock_irqsave(&vfe->output_lock, flags);
420 
421 	output = &line->output;
422 	if (output->state != VFE_OUTPUT_OFF) {
423 		dev_err(vfe->camss->dev, "Output is running\n");
424 		goto error;
425 	}
426 
427 	output->wm_num = 1;
428 
429 	wm_idx = vfe_reserve_wm(vfe, line->id);
430 	if (wm_idx < 0) {
431 		dev_err(vfe->camss->dev, "Can not reserve wm\n");
432 		goto error_get_wm;
433 	}
434 	output->wm_idx[0] = wm_idx;
435 
436 	output->drop_update_idx = 0;
437 
438 	spin_unlock_irqrestore(&vfe->output_lock, flags);
439 
440 	return 0;
441 
442 error_get_wm:
443 	vfe_release_wm(vfe, output->wm_idx[0]);
444 	output->state = VFE_OUTPUT_OFF;
445 error:
446 	spin_unlock_irqrestore(&vfe->output_lock, flags);
447 
448 	return -EINVAL;
449 }
450 
451 static int vfe_enable_output(struct vfe_line *line)
452 {
453 	struct vfe_device *vfe = to_vfe(line);
454 	struct vfe_output *output = &line->output;
455 	const struct vfe_hw_ops *ops = vfe->ops;
456 	struct media_entity *sensor;
457 	unsigned long flags;
458 	unsigned int frame_skip = 0;
459 	unsigned int i;
460 
461 	sensor = camss_find_sensor(&line->subdev.entity);
462 	if (sensor) {
463 		struct v4l2_subdev *subdev = media_entity_to_v4l2_subdev(sensor);
464 
465 		v4l2_subdev_call(subdev, sensor, g_skip_frames, &frame_skip);
466 		/* Max frame skip is 29 frames */
467 		if (frame_skip > VFE_FRAME_DROP_VAL - 1)
468 			frame_skip = VFE_FRAME_DROP_VAL - 1;
469 	}
470 
471 	spin_lock_irqsave(&vfe->output_lock, flags);
472 
473 	ops->reg_update_clear(vfe, line->id);
474 
475 	if (output->state != VFE_OUTPUT_OFF) {
476 		dev_err(vfe->camss->dev, "Output is not in reserved state %d\n",
477 			output->state);
478 		spin_unlock_irqrestore(&vfe->output_lock, flags);
479 		return -EINVAL;
480 	}
481 
482 	WARN_ON(output->gen2.active_num);
483 
484 	output->state = VFE_OUTPUT_ON;
485 
486 	output->sequence = 0;
487 	output->wait_reg_update = 0;
488 	reinit_completion(&output->reg_update);
489 
490 	vfe_wm_start(vfe, output->wm_idx[0], line);
491 
492 	for (i = 0; i < 2; i++) {
493 		output->buf[i] = vfe_buf_get_pending(output);
494 		if (!output->buf[i])
495 			break;
496 		output->gen2.active_num++;
497 		vfe_wm_update(vfe, output->wm_idx[0], output->buf[i]->addr[0], line);
498 	}
499 
500 	ops->reg_update(vfe, line->id);
501 
502 	spin_unlock_irqrestore(&vfe->output_lock, flags);
503 
504 	return 0;
505 }
506 
507 static int vfe_disable_output(struct vfe_line *line)
508 {
509 	struct vfe_device *vfe = to_vfe(line);
510 	struct vfe_output *output = &line->output;
511 	unsigned long flags;
512 	unsigned int i;
513 	bool done;
514 	int timeout = 0;
515 
516 	do {
517 		spin_lock_irqsave(&vfe->output_lock, flags);
518 		done = !output->gen2.active_num;
519 		spin_unlock_irqrestore(&vfe->output_lock, flags);
520 		usleep_range(10000, 20000);
521 
522 		if (timeout++ == 100) {
523 			dev_err(vfe->camss->dev, "VFE idle timeout - resetting\n");
524 			vfe_reset(vfe);
525 			output->gen2.active_num = 0;
526 			return 0;
527 		}
528 	} while (!done);
529 
530 	spin_lock_irqsave(&vfe->output_lock, flags);
531 	for (i = 0; i < output->wm_num; i++)
532 		vfe_wm_stop(vfe, output->wm_idx[i]);
533 	spin_unlock_irqrestore(&vfe->output_lock, flags);
534 
535 	return 0;
536 }
537 
538 /*
539  * vfe_enable - Enable streaming on VFE line
540  * @line: VFE line
541  *
542  * Return 0 on success or a negative error code otherwise
543  */
544 static int vfe_enable(struct vfe_line *line)
545 {
546 	struct vfe_device *vfe = to_vfe(line);
547 	int ret;
548 
549 	mutex_lock(&vfe->stream_lock);
550 
551 	if (!vfe->stream_count)
552 		vfe_enable_irq_common(vfe);
553 
554 	vfe->stream_count++;
555 
556 	mutex_unlock(&vfe->stream_lock);
557 
558 	ret = vfe_get_output(line);
559 	if (ret < 0)
560 		goto error_get_output;
561 
562 	ret = vfe_enable_output(line);
563 	if (ret < 0)
564 		goto error_enable_output;
565 
566 	vfe->was_streaming = 1;
567 
568 	return 0;
569 
570 error_enable_output:
571 	vfe_put_output(line);
572 
573 error_get_output:
574 	mutex_lock(&vfe->stream_lock);
575 
576 	vfe->stream_count--;
577 
578 	mutex_unlock(&vfe->stream_lock);
579 
580 	return ret;
581 }
582 
583 /*
584  * vfe_disable - Disable streaming on VFE line
585  * @line: VFE line
586  *
587  * Return 0 on success or a negative error code otherwise
588  */
589 static int vfe_disable(struct vfe_line *line)
590 {
591 	struct vfe_device *vfe = to_vfe(line);
592 
593 	vfe_disable_output(line);
594 
595 	vfe_put_output(line);
596 
597 	mutex_lock(&vfe->stream_lock);
598 
599 	vfe->stream_count--;
600 
601 	mutex_unlock(&vfe->stream_lock);
602 
603 	return 0;
604 }
605 
606 /*
607  * vfe_isr_sof - Process start of frame interrupt
608  * @vfe: VFE Device
609  * @line_id: VFE line
610  */
611 static void vfe_isr_sof(struct vfe_device *vfe, enum vfe_line_id line_id)
612 {
613 	/* nop */
614 }
615 
616 /*
617  * vfe_isr_reg_update - Process reg update interrupt
618  * @vfe: VFE Device
619  * @line_id: VFE line
620  */
621 static void vfe_isr_reg_update(struct vfe_device *vfe, enum vfe_line_id line_id)
622 {
623 	struct vfe_output *output;
624 	unsigned long flags;
625 
626 	spin_lock_irqsave(&vfe->output_lock, flags);
627 	vfe->ops->reg_update_clear(vfe, line_id);
628 
629 	output = &vfe->line[line_id].output;
630 
631 	if (output->wait_reg_update) {
632 		output->wait_reg_update = 0;
633 		complete(&output->reg_update);
634 	}
635 
636 	spin_unlock_irqrestore(&vfe->output_lock, flags);
637 }
638 
639 /*
640  * vfe_isr_wm_done - Process write master done interrupt
641  * @vfe: VFE Device
642  * @wm: Write master id
643  */
644 static void vfe_isr_wm_done(struct vfe_device *vfe, u8 wm)
645 {
646 	struct vfe_line *line = &vfe->line[vfe->wm_output_map[wm]];
647 	struct camss_buffer *ready_buf;
648 	struct vfe_output *output;
649 	unsigned long flags;
650 	u32 index;
651 	u64 ts = ktime_get_ns();
652 
653 	spin_lock_irqsave(&vfe->output_lock, flags);
654 
655 	if (vfe->wm_output_map[wm] == VFE_LINE_NONE) {
656 		dev_err_ratelimited(vfe->camss->dev,
657 				    "Received wm done for unmapped index\n");
658 		goto out_unlock;
659 	}
660 	output = &vfe->line[vfe->wm_output_map[wm]].output;
661 
662 	ready_buf = output->buf[0];
663 	if (!ready_buf) {
664 		dev_err_ratelimited(vfe->camss->dev,
665 				    "Missing ready buf %d!\n", output->state);
666 		goto out_unlock;
667 	}
668 
669 	ready_buf->vb.vb2_buf.timestamp = ts;
670 	ready_buf->vb.sequence = output->sequence++;
671 
672 	index = 0;
673 	output->buf[0] = output->buf[1];
674 	if (output->buf[0])
675 		index = 1;
676 
677 	output->buf[index] = vfe_buf_get_pending(output);
678 
679 	if (output->buf[index])
680 		vfe_wm_update(vfe, output->wm_idx[0], output->buf[index]->addr[0], line);
681 	else
682 		output->gen2.active_num--;
683 
684 	spin_unlock_irqrestore(&vfe->output_lock, flags);
685 
686 	vb2_buffer_done(&ready_buf->vb.vb2_buf, VB2_BUF_STATE_DONE);
687 
688 	return;
689 
690 out_unlock:
691 	spin_unlock_irqrestore(&vfe->output_lock, flags);
692 }
693 
694 /*
695  * vfe_pm_domain_off - Disable power domains specific to this VFE.
696  * @vfe: VFE Device
697  */
698 static void vfe_pm_domain_off(struct vfe_device *vfe)
699 {
700 	/* nop */
701 }
702 
703 /*
704  * vfe_pm_domain_on - Enable power domains specific to this VFE.
705  * @vfe: VFE Device
706  */
707 static int vfe_pm_domain_on(struct vfe_device *vfe)
708 {
709 	return 0;
710 }
711 
712 /*
713  * vfe_queue_buffer - Add empty buffer
714  * @vid: Video device structure
715  * @buf: Buffer to be enqueued
716  *
717  * Add an empty buffer - depending on the current number of buffers it will be
718  * put in pending buffer queue or directly given to the hardware to be filled.
719  *
720  * Return 0 on success or a negative error code otherwise
721  */
722 static int vfe_queue_buffer(struct camss_video *vid,
723 			    struct camss_buffer *buf)
724 {
725 	struct vfe_line *line = container_of(vid, struct vfe_line, video_out);
726 	struct vfe_device *vfe = to_vfe(line);
727 	struct vfe_output *output;
728 	unsigned long flags;
729 
730 	output = &line->output;
731 
732 	spin_lock_irqsave(&vfe->output_lock, flags);
733 
734 	if (output->state == VFE_OUTPUT_ON && output->gen2.active_num < 2) {
735 		output->buf[output->gen2.active_num++] = buf;
736 		vfe_wm_update(vfe, output->wm_idx[0], buf->addr[0], line);
737 	} else {
738 		vfe_buf_add_pending(output, buf);
739 	}
740 
741 	spin_unlock_irqrestore(&vfe->output_lock, flags);
742 
743 	return 0;
744 }
745 
746 static const struct vfe_isr_ops vfe_isr_ops_170 = {
747 	.reset_ack = vfe_isr_reset_ack,
748 	.halt_ack = vfe_isr_halt_ack,
749 	.reg_update = vfe_isr_reg_update,
750 	.sof = vfe_isr_sof,
751 	.comp_done = vfe_isr_comp_done,
752 	.wm_done = vfe_isr_wm_done,
753 };
754 
755 static const struct camss_video_ops vfe_video_ops_170 = {
756 	.queue_buffer = vfe_queue_buffer,
757 	.flush_buffers = vfe_flush_buffers,
758 };
759 
760 static void vfe_subdev_init(struct device *dev, struct vfe_device *vfe)
761 {
762 	vfe->isr_ops = vfe_isr_ops_170;
763 	vfe->video_ops = vfe_video_ops_170;
764 
765 	vfe->line_num = VFE_LINE_NUM_GEN2;
766 }
767 
768 const struct vfe_hw_ops vfe_ops_170 = {
769 	.global_reset = vfe_global_reset,
770 	.hw_version = vfe_hw_version,
771 	.isr_read = vfe_isr_read,
772 	.isr = vfe_isr,
773 	.pm_domain_off = vfe_pm_domain_off,
774 	.pm_domain_on = vfe_pm_domain_on,
775 	.reg_update_clear = vfe_reg_update_clear,
776 	.reg_update = vfe_reg_update,
777 	.subdev_init = vfe_subdev_init,
778 	.vfe_disable = vfe_disable,
779 	.vfe_enable = vfe_enable,
780 	.vfe_halt = vfe_halt,
781 	.violation_read = vfe_violation_read,
782 };
783