xref: /openbmc/linux/drivers/hwmon/lm63.c (revision 87c2ce3b)
1 /*
2  * lm63.c - driver for the National Semiconductor LM63 temperature sensor
3  *          with integrated fan control
4  * Copyright (C) 2004-2005  Jean Delvare <khali@linux-fr.org>
5  * Based on the lm90 driver.
6  *
7  * The LM63 is a sensor chip made by National Semiconductor. It measures
8  * two temperatures (its own and one external one) and the speed of one
9  * fan, those speed it can additionally control. Complete datasheet can be
10  * obtained from National's website at:
11  *   http://www.national.com/pf/LM/LM63.html
12  *
13  * The LM63 is basically an LM86 with fan speed monitoring and control
14  * capabilities added. It misses some of the LM86 features though:
15  *  - No low limit for local temperature.
16  *  - No critical limit for local temperature.
17  *  - Critical limit for remote temperature can be changed only once. We
18  *    will consider that the critical limit is read-only.
19  *
20  * The datasheet isn't very clear about what the tachometer reading is.
21  * I had a explanation from National Semiconductor though. The two lower
22  * bits of the read value have to be masked out. The value is still 16 bit
23  * in width.
24  *
25  * This program is free software; you can redistribute it and/or modify
26  * it under the terms of the GNU General Public License as published by
27  * the Free Software Foundation; either version 2 of the License, or
28  * (at your option) any later version.
29  *
30  * This program is distributed in the hope that it will be useful,
31  * but WITHOUT ANY WARRANTY; without even the implied warranty of
32  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
33  * GNU General Public License for more details.
34  *
35  * You should have received a copy of the GNU General Public License
36  * along with this program; if not, write to the Free Software
37  * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
38  */
39 
40 #include <linux/module.h>
41 #include <linux/init.h>
42 #include <linux/slab.h>
43 #include <linux/jiffies.h>
44 #include <linux/i2c.h>
45 #include <linux/hwmon-sysfs.h>
46 #include <linux/hwmon.h>
47 #include <linux/err.h>
48 
49 /*
50  * Addresses to scan
51  * Address is fully defined internally and cannot be changed.
52  */
53 
54 static unsigned short normal_i2c[] = { 0x4c, I2C_CLIENT_END };
55 
56 /*
57  * Insmod parameters
58  */
59 
60 I2C_CLIENT_INSMOD_1(lm63);
61 
62 /*
63  * The LM63 registers
64  */
65 
66 #define LM63_REG_CONFIG1		0x03
67 #define LM63_REG_CONFIG2		0xBF
68 #define LM63_REG_CONFIG_FAN		0x4A
69 
70 #define LM63_REG_TACH_COUNT_MSB		0x47
71 #define LM63_REG_TACH_COUNT_LSB		0x46
72 #define LM63_REG_TACH_LIMIT_MSB		0x49
73 #define LM63_REG_TACH_LIMIT_LSB		0x48
74 
75 #define LM63_REG_PWM_VALUE		0x4C
76 #define LM63_REG_PWM_FREQ		0x4D
77 
78 #define LM63_REG_LOCAL_TEMP		0x00
79 #define LM63_REG_LOCAL_HIGH		0x05
80 
81 #define LM63_REG_REMOTE_TEMP_MSB	0x01
82 #define LM63_REG_REMOTE_TEMP_LSB	0x10
83 #define LM63_REG_REMOTE_OFFSET_MSB	0x11
84 #define LM63_REG_REMOTE_OFFSET_LSB	0x12
85 #define LM63_REG_REMOTE_HIGH_MSB	0x07
86 #define LM63_REG_REMOTE_HIGH_LSB	0x13
87 #define LM63_REG_REMOTE_LOW_MSB		0x08
88 #define LM63_REG_REMOTE_LOW_LSB		0x14
89 #define LM63_REG_REMOTE_TCRIT		0x19
90 #define LM63_REG_REMOTE_TCRIT_HYST	0x21
91 
92 #define LM63_REG_ALERT_STATUS		0x02
93 #define LM63_REG_ALERT_MASK		0x16
94 
95 #define LM63_REG_MAN_ID			0xFE
96 #define LM63_REG_CHIP_ID		0xFF
97 
98 /*
99  * Conversions and various macros
100  * For tachometer counts, the LM63 uses 16-bit values.
101  * For local temperature and high limit, remote critical limit and hysteresis
102  * value, it uses signed 8-bit values with LSB = 1 degree Celsius.
103  * For remote temperature, low and high limits, it uses signed 11-bit values
104  * with LSB = 0.125 degree Celsius, left-justified in 16-bit registers.
105  */
106 
107 #define FAN_FROM_REG(reg)	((reg) == 0xFFFC || (reg) == 0 ? 0 : \
108 				 5400000 / (reg))
109 #define FAN_TO_REG(val)		((val) <= 82 ? 0xFFFC : \
110 				 (5400000 / (val)) & 0xFFFC)
111 #define TEMP8_FROM_REG(reg)	((reg) * 1000)
112 #define TEMP8_TO_REG(val)	((val) <= -128000 ? -128 : \
113 				 (val) >= 127000 ? 127 : \
114 				 (val) < 0 ? ((val) - 500) / 1000 : \
115 				 ((val) + 500) / 1000)
116 #define TEMP11_FROM_REG(reg)	((reg) / 32 * 125)
117 #define TEMP11_TO_REG(val)	((val) <= -128000 ? 0x8000 : \
118 				 (val) >= 127875 ? 0x7FE0 : \
119 				 (val) < 0 ? ((val) - 62) / 125 * 32 : \
120 				 ((val) + 62) / 125 * 32)
121 #define HYST_TO_REG(val)	((val) <= 0 ? 0 : \
122 				 (val) >= 127000 ? 127 : \
123 				 ((val) + 500) / 1000)
124 
125 /*
126  * Functions declaration
127  */
128 
129 static int lm63_attach_adapter(struct i2c_adapter *adapter);
130 static int lm63_detach_client(struct i2c_client *client);
131 
132 static struct lm63_data *lm63_update_device(struct device *dev);
133 
134 static int lm63_detect(struct i2c_adapter *adapter, int address, int kind);
135 static void lm63_init_client(struct i2c_client *client);
136 
137 /*
138  * Driver data (common to all clients)
139  */
140 
141 static struct i2c_driver lm63_driver = {
142 	.driver = {
143 		.name	= "lm63",
144 	},
145 	.attach_adapter	= lm63_attach_adapter,
146 	.detach_client	= lm63_detach_client,
147 };
148 
149 /*
150  * Client data (each client gets its own)
151  */
152 
153 struct lm63_data {
154 	struct i2c_client client;
155 	struct class_device *class_dev;
156 	struct semaphore update_lock;
157 	char valid; /* zero until following fields are valid */
158 	unsigned long last_updated; /* in jiffies */
159 
160 	/* registers values */
161 	u8 config, config_fan;
162 	u16 fan[2];	/* 0: input
163 			   1: low limit */
164 	u8 pwm1_freq;
165 	u8 pwm1_value;
166 	s8 temp8[3];	/* 0: local input
167 			   1: local high limit
168 			   2: remote critical limit */
169 	s16 temp11[3];	/* 0: remote input
170 			   1: remote low limit
171 			   2: remote high limit */
172 	u8 temp2_crit_hyst;
173 	u8 alarms;
174 };
175 
176 /*
177  * Sysfs callback functions and files
178  */
179 
180 static ssize_t show_fan(struct device *dev, struct device_attribute *devattr,
181 			char *buf)
182 {
183 	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
184 	struct lm63_data *data = lm63_update_device(dev);
185 	return sprintf(buf, "%d\n", FAN_FROM_REG(data->fan[attr->index]));
186 }
187 
188 static ssize_t set_fan(struct device *dev, struct device_attribute *dummy,
189 		       const char *buf, size_t count)
190 {
191 	struct i2c_client *client = to_i2c_client(dev);
192 	struct lm63_data *data = i2c_get_clientdata(client);
193 	unsigned long val = simple_strtoul(buf, NULL, 10);
194 
195 	down(&data->update_lock);
196 	data->fan[1] = FAN_TO_REG(val);
197 	i2c_smbus_write_byte_data(client, LM63_REG_TACH_LIMIT_LSB,
198 				  data->fan[1] & 0xFF);
199 	i2c_smbus_write_byte_data(client, LM63_REG_TACH_LIMIT_MSB,
200 				  data->fan[1] >> 8);
201 	up(&data->update_lock);
202 	return count;
203 }
204 
205 static ssize_t show_pwm1(struct device *dev, struct device_attribute *dummy,
206 			 char *buf)
207 {
208 	struct lm63_data *data = lm63_update_device(dev);
209 	return sprintf(buf, "%d\n", data->pwm1_value >= 2 * data->pwm1_freq ?
210 		       255 : (data->pwm1_value * 255 + data->pwm1_freq) /
211 		       (2 * data->pwm1_freq));
212 }
213 
214 static ssize_t set_pwm1(struct device *dev, struct device_attribute *dummy,
215 			const char *buf, size_t count)
216 {
217 	struct i2c_client *client = to_i2c_client(dev);
218 	struct lm63_data *data = i2c_get_clientdata(client);
219 	unsigned long val;
220 
221 	if (!(data->config_fan & 0x20)) /* register is read-only */
222 		return -EPERM;
223 
224 	val = simple_strtoul(buf, NULL, 10);
225 	down(&data->update_lock);
226 	data->pwm1_value = val <= 0 ? 0 :
227 			   val >= 255 ? 2 * data->pwm1_freq :
228 			   (val * data->pwm1_freq * 2 + 127) / 255;
229 	i2c_smbus_write_byte_data(client, LM63_REG_PWM_VALUE, data->pwm1_value);
230 	up(&data->update_lock);
231 	return count;
232 }
233 
234 static ssize_t show_pwm1_enable(struct device *dev, struct device_attribute *dummy,
235 				char *buf)
236 {
237 	struct lm63_data *data = lm63_update_device(dev);
238 	return sprintf(buf, "%d\n", data->config_fan & 0x20 ? 1 : 2);
239 }
240 
241 static ssize_t show_temp8(struct device *dev, struct device_attribute *devattr,
242 			  char *buf)
243 {
244 	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
245 	struct lm63_data *data = lm63_update_device(dev);
246 	return sprintf(buf, "%d\n", TEMP8_FROM_REG(data->temp8[attr->index]));
247 }
248 
249 static ssize_t set_temp8(struct device *dev, struct device_attribute *dummy,
250 			 const char *buf, size_t count)
251 {
252 	struct i2c_client *client = to_i2c_client(dev);
253 	struct lm63_data *data = i2c_get_clientdata(client);
254 	long val = simple_strtol(buf, NULL, 10);
255 
256 	down(&data->update_lock);
257 	data->temp8[1] = TEMP8_TO_REG(val);
258 	i2c_smbus_write_byte_data(client, LM63_REG_LOCAL_HIGH, data->temp8[1]);
259 	up(&data->update_lock);
260 	return count;
261 }
262 
263 static ssize_t show_temp11(struct device *dev, struct device_attribute *devattr,
264 			   char *buf)
265 {
266 	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
267 	struct lm63_data *data = lm63_update_device(dev);
268 	return sprintf(buf, "%d\n", TEMP11_FROM_REG(data->temp11[attr->index]));
269 }
270 
271 static ssize_t set_temp11(struct device *dev, struct device_attribute *devattr,
272 			  const char *buf, size_t count)
273 {
274 	static const u8 reg[4] = {
275 		LM63_REG_REMOTE_LOW_MSB,
276 		LM63_REG_REMOTE_LOW_LSB,
277 		LM63_REG_REMOTE_HIGH_MSB,
278 		LM63_REG_REMOTE_HIGH_LSB,
279 	};
280 
281 	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
282 	struct i2c_client *client = to_i2c_client(dev);
283 	struct lm63_data *data = i2c_get_clientdata(client);
284 	long val = simple_strtol(buf, NULL, 10);
285 	int nr = attr->index;
286 
287 	down(&data->update_lock);
288 	data->temp11[nr] = TEMP11_TO_REG(val);
289 	i2c_smbus_write_byte_data(client, reg[(nr - 1) * 2],
290 				  data->temp11[nr] >> 8);
291 	i2c_smbus_write_byte_data(client, reg[(nr - 1) * 2 + 1],
292 				  data->temp11[nr] & 0xff);
293 	up(&data->update_lock);
294 	return count;
295 }
296 
297 /* Hysteresis register holds a relative value, while we want to present
298    an absolute to user-space */
299 static ssize_t show_temp2_crit_hyst(struct device *dev, struct device_attribute *dummy,
300 				    char *buf)
301 {
302 	struct lm63_data *data = lm63_update_device(dev);
303 	return sprintf(buf, "%d\n", TEMP8_FROM_REG(data->temp8[2])
304 		       - TEMP8_FROM_REG(data->temp2_crit_hyst));
305 }
306 
307 /* And now the other way around, user-space provides an absolute
308    hysteresis value and we have to store a relative one */
309 static ssize_t set_temp2_crit_hyst(struct device *dev, struct device_attribute *dummy,
310 				   const char *buf, size_t count)
311 {
312 	struct i2c_client *client = to_i2c_client(dev);
313 	struct lm63_data *data = i2c_get_clientdata(client);
314 	long val = simple_strtol(buf, NULL, 10);
315 	long hyst;
316 
317 	down(&data->update_lock);
318 	hyst = TEMP8_FROM_REG(data->temp8[2]) - val;
319 	i2c_smbus_write_byte_data(client, LM63_REG_REMOTE_TCRIT_HYST,
320 				  HYST_TO_REG(hyst));
321 	up(&data->update_lock);
322 	return count;
323 }
324 
325 static ssize_t show_alarms(struct device *dev, struct device_attribute *dummy,
326 			   char *buf)
327 {
328 	struct lm63_data *data = lm63_update_device(dev);
329 	return sprintf(buf, "%u\n", data->alarms);
330 }
331 
332 static SENSOR_DEVICE_ATTR(fan1_input, S_IRUGO, show_fan, NULL, 0);
333 static SENSOR_DEVICE_ATTR(fan1_min, S_IWUSR | S_IRUGO, show_fan,
334 	set_fan, 1);
335 
336 static DEVICE_ATTR(pwm1, S_IWUSR | S_IRUGO, show_pwm1, set_pwm1);
337 static DEVICE_ATTR(pwm1_enable, S_IRUGO, show_pwm1_enable, NULL);
338 
339 static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, show_temp8, NULL, 0);
340 static SENSOR_DEVICE_ATTR(temp1_max, S_IWUSR | S_IRUGO, show_temp8,
341 	set_temp8, 1);
342 
343 static SENSOR_DEVICE_ATTR(temp2_input, S_IRUGO, show_temp11, NULL, 0);
344 static SENSOR_DEVICE_ATTR(temp2_min, S_IWUSR | S_IRUGO, show_temp11,
345 	set_temp11, 1);
346 static SENSOR_DEVICE_ATTR(temp2_max, S_IWUSR | S_IRUGO, show_temp11,
347 	set_temp11, 2);
348 static SENSOR_DEVICE_ATTR(temp2_crit, S_IRUGO, show_temp8, NULL, 2);
349 static DEVICE_ATTR(temp2_crit_hyst, S_IWUSR | S_IRUGO, show_temp2_crit_hyst,
350 	set_temp2_crit_hyst);
351 
352 static DEVICE_ATTR(alarms, S_IRUGO, show_alarms, NULL);
353 
354 /*
355  * Real code
356  */
357 
358 static int lm63_attach_adapter(struct i2c_adapter *adapter)
359 {
360 	if (!(adapter->class & I2C_CLASS_HWMON))
361 		return 0;
362 	return i2c_probe(adapter, &addr_data, lm63_detect);
363 }
364 
365 /*
366  * The following function does more than just detection. If detection
367  * succeeds, it also registers the new chip.
368  */
369 static int lm63_detect(struct i2c_adapter *adapter, int address, int kind)
370 {
371 	struct i2c_client *new_client;
372 	struct lm63_data *data;
373 	int err = 0;
374 
375 	if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
376 		goto exit;
377 
378 	if (!(data = kzalloc(sizeof(struct lm63_data), GFP_KERNEL))) {
379 		err = -ENOMEM;
380 		goto exit;
381 	}
382 
383 	/* The common I2C client data is placed right before the
384 	   LM63-specific data. */
385 	new_client = &data->client;
386 	i2c_set_clientdata(new_client, data);
387 	new_client->addr = address;
388 	new_client->adapter = adapter;
389 	new_client->driver = &lm63_driver;
390 	new_client->flags = 0;
391 
392 	/* Default to an LM63 if forced */
393 	if (kind == 0)
394 		kind = lm63;
395 
396 	if (kind < 0) { /* must identify */
397 		u8 man_id, chip_id, reg_config1, reg_config2;
398 		u8 reg_alert_status, reg_alert_mask;
399 
400 		man_id = i2c_smbus_read_byte_data(new_client,
401 			 LM63_REG_MAN_ID);
402 		chip_id = i2c_smbus_read_byte_data(new_client,
403 			  LM63_REG_CHIP_ID);
404 		reg_config1 = i2c_smbus_read_byte_data(new_client,
405 			      LM63_REG_CONFIG1);
406 		reg_config2 = i2c_smbus_read_byte_data(new_client,
407 			      LM63_REG_CONFIG2);
408 		reg_alert_status = i2c_smbus_read_byte_data(new_client,
409 				   LM63_REG_ALERT_STATUS);
410 		reg_alert_mask = i2c_smbus_read_byte_data(new_client,
411 				 LM63_REG_ALERT_MASK);
412 
413 		if (man_id == 0x01 /* National Semiconductor */
414 		 && chip_id == 0x41 /* LM63 */
415 		 && (reg_config1 & 0x18) == 0x00
416 		 && (reg_config2 & 0xF8) == 0x00
417 		 && (reg_alert_status & 0x20) == 0x00
418 		 && (reg_alert_mask & 0xA4) == 0xA4) {
419 			kind = lm63;
420 		} else { /* failed */
421 			dev_dbg(&adapter->dev, "Unsupported chip "
422 				"(man_id=0x%02X, chip_id=0x%02X).\n",
423 				man_id, chip_id);
424 			goto exit_free;
425 		}
426 	}
427 
428 	strlcpy(new_client->name, "lm63", I2C_NAME_SIZE);
429 	data->valid = 0;
430 	init_MUTEX(&data->update_lock);
431 
432 	/* Tell the I2C layer a new client has arrived */
433 	if ((err = i2c_attach_client(new_client)))
434 		goto exit_free;
435 
436 	/* Initialize the LM63 chip */
437 	lm63_init_client(new_client);
438 
439 	/* Register sysfs hooks */
440 	data->class_dev = hwmon_device_register(&new_client->dev);
441 	if (IS_ERR(data->class_dev)) {
442 		err = PTR_ERR(data->class_dev);
443 		goto exit_detach;
444 	}
445 
446 	if (data->config & 0x04) { /* tachometer enabled */
447 		device_create_file(&new_client->dev,
448 				   &sensor_dev_attr_fan1_input.dev_attr);
449 		device_create_file(&new_client->dev,
450 				   &sensor_dev_attr_fan1_min.dev_attr);
451 	}
452 	device_create_file(&new_client->dev, &dev_attr_pwm1);
453 	device_create_file(&new_client->dev, &dev_attr_pwm1_enable);
454 	device_create_file(&new_client->dev,
455 			   &sensor_dev_attr_temp1_input.dev_attr);
456 	device_create_file(&new_client->dev,
457 			   &sensor_dev_attr_temp2_input.dev_attr);
458 	device_create_file(&new_client->dev,
459 			   &sensor_dev_attr_temp2_min.dev_attr);
460 	device_create_file(&new_client->dev,
461 			   &sensor_dev_attr_temp1_max.dev_attr);
462 	device_create_file(&new_client->dev,
463 			   &sensor_dev_attr_temp2_max.dev_attr);
464 	device_create_file(&new_client->dev,
465 			   &sensor_dev_attr_temp2_crit.dev_attr);
466 	device_create_file(&new_client->dev, &dev_attr_temp2_crit_hyst);
467 	device_create_file(&new_client->dev, &dev_attr_alarms);
468 
469 	return 0;
470 
471 exit_detach:
472 	i2c_detach_client(new_client);
473 exit_free:
474 	kfree(data);
475 exit:
476 	return err;
477 }
478 
479 /* Idealy we shouldn't have to initialize anything, since the BIOS
480    should have taken care of everything */
481 static void lm63_init_client(struct i2c_client *client)
482 {
483 	struct lm63_data *data = i2c_get_clientdata(client);
484 
485 	data->config = i2c_smbus_read_byte_data(client, LM63_REG_CONFIG1);
486 	data->config_fan = i2c_smbus_read_byte_data(client,
487 						    LM63_REG_CONFIG_FAN);
488 
489 	/* Start converting if needed */
490 	if (data->config & 0x40) { /* standby */
491 		dev_dbg(&client->dev, "Switching to operational mode");
492 		data->config &= 0xA7;
493 		i2c_smbus_write_byte_data(client, LM63_REG_CONFIG1,
494 					  data->config);
495 	}
496 
497 	/* We may need pwm1_freq before ever updating the client data */
498 	data->pwm1_freq = i2c_smbus_read_byte_data(client, LM63_REG_PWM_FREQ);
499 	if (data->pwm1_freq == 0)
500 		data->pwm1_freq = 1;
501 
502 	/* Show some debug info about the LM63 configuration */
503 	dev_dbg(&client->dev, "Alert/tach pin configured for %s\n",
504 		(data->config & 0x04) ? "tachometer input" :
505 		"alert output");
506 	dev_dbg(&client->dev, "PWM clock %s kHz, output frequency %u Hz\n",
507 		(data->config_fan & 0x08) ? "1.4" : "360",
508 		((data->config_fan & 0x08) ? 700 : 180000) / data->pwm1_freq);
509 	dev_dbg(&client->dev, "PWM output active %s, %s mode\n",
510 		(data->config_fan & 0x10) ? "low" : "high",
511 		(data->config_fan & 0x20) ? "manual" : "auto");
512 }
513 
514 static int lm63_detach_client(struct i2c_client *client)
515 {
516 	struct lm63_data *data = i2c_get_clientdata(client);
517 	int err;
518 
519 	hwmon_device_unregister(data->class_dev);
520 
521 	if ((err = i2c_detach_client(client)))
522 		return err;
523 
524 	kfree(data);
525 	return 0;
526 }
527 
528 static struct lm63_data *lm63_update_device(struct device *dev)
529 {
530 	struct i2c_client *client = to_i2c_client(dev);
531 	struct lm63_data *data = i2c_get_clientdata(client);
532 
533 	down(&data->update_lock);
534 
535 	if (time_after(jiffies, data->last_updated + HZ) || !data->valid) {
536 		if (data->config & 0x04) { /* tachometer enabled  */
537 			/* order matters for fan1_input */
538 			data->fan[0] = i2c_smbus_read_byte_data(client,
539 				       LM63_REG_TACH_COUNT_LSB) & 0xFC;
540 			data->fan[0] |= i2c_smbus_read_byte_data(client,
541 					LM63_REG_TACH_COUNT_MSB) << 8;
542 			data->fan[1] = (i2c_smbus_read_byte_data(client,
543 					LM63_REG_TACH_LIMIT_LSB) & 0xFC)
544 				     | (i2c_smbus_read_byte_data(client,
545 					LM63_REG_TACH_LIMIT_MSB) << 8);
546 		}
547 
548 		data->pwm1_freq = i2c_smbus_read_byte_data(client,
549 				  LM63_REG_PWM_FREQ);
550 		if (data->pwm1_freq == 0)
551 			data->pwm1_freq = 1;
552 		data->pwm1_value = i2c_smbus_read_byte_data(client,
553 				   LM63_REG_PWM_VALUE);
554 
555 		data->temp8[0] = i2c_smbus_read_byte_data(client,
556 				 LM63_REG_LOCAL_TEMP);
557 		data->temp8[1] = i2c_smbus_read_byte_data(client,
558 				 LM63_REG_LOCAL_HIGH);
559 
560 		/* order matters for temp2_input */
561 		data->temp11[0] = i2c_smbus_read_byte_data(client,
562 				  LM63_REG_REMOTE_TEMP_MSB) << 8;
563 		data->temp11[0] |= i2c_smbus_read_byte_data(client,
564 				   LM63_REG_REMOTE_TEMP_LSB);
565 		data->temp11[1] = (i2c_smbus_read_byte_data(client,
566 				  LM63_REG_REMOTE_LOW_MSB) << 8)
567 				| i2c_smbus_read_byte_data(client,
568 				  LM63_REG_REMOTE_LOW_LSB);
569 		data->temp11[2] = (i2c_smbus_read_byte_data(client,
570 				  LM63_REG_REMOTE_HIGH_MSB) << 8)
571 				| i2c_smbus_read_byte_data(client,
572 				  LM63_REG_REMOTE_HIGH_LSB);
573 		data->temp8[2] = i2c_smbus_read_byte_data(client,
574 				 LM63_REG_REMOTE_TCRIT);
575 		data->temp2_crit_hyst = i2c_smbus_read_byte_data(client,
576 					LM63_REG_REMOTE_TCRIT_HYST);
577 
578 		data->alarms = i2c_smbus_read_byte_data(client,
579 			       LM63_REG_ALERT_STATUS) & 0x7F;
580 
581 		data->last_updated = jiffies;
582 		data->valid = 1;
583 	}
584 
585 	up(&data->update_lock);
586 
587 	return data;
588 }
589 
590 static int __init sensors_lm63_init(void)
591 {
592 	return i2c_add_driver(&lm63_driver);
593 }
594 
595 static void __exit sensors_lm63_exit(void)
596 {
597 	i2c_del_driver(&lm63_driver);
598 }
599 
600 MODULE_AUTHOR("Jean Delvare <khali@linux-fr.org>");
601 MODULE_DESCRIPTION("LM63 driver");
602 MODULE_LICENSE("GPL");
603 
604 module_init(sensors_lm63_init);
605 module_exit(sensors_lm63_exit);
606