xref: /openbmc/linux/drivers/hwmon/adt7411.c (revision 9e5e9b7a)
1d84ca5b3SWolfram Sang /*
2d84ca5b3SWolfram Sang  *  Driver for the ADT7411 (I2C/SPI 8 channel 10 bit ADC & temperature-sensor)
3d84ca5b3SWolfram Sang  *
4d84ca5b3SWolfram Sang  *  Copyright (C) 2008, 2010 Pengutronix
5d84ca5b3SWolfram Sang  *
6d84ca5b3SWolfram Sang  *  This program is free software; you can redistribute it and/or modify
7d84ca5b3SWolfram Sang  *  it under the terms of the GNU General Public License version 2 as
8d84ca5b3SWolfram Sang  *  published by the Free Software Foundation.
9d84ca5b3SWolfram Sang  *
10d84ca5b3SWolfram Sang  *  TODO: SPI, support for external temperature sensor
11d84ca5b3SWolfram Sang  *	  use power-down mode for suspend?, interrupt handling?
12d84ca5b3SWolfram Sang  */
13d84ca5b3SWolfram Sang 
14d84ca5b3SWolfram Sang #include <linux/kernel.h>
15d84ca5b3SWolfram Sang #include <linux/module.h>
16d84ca5b3SWolfram Sang #include <linux/init.h>
17d84ca5b3SWolfram Sang #include <linux/err.h>
18d84ca5b3SWolfram Sang #include <linux/mutex.h>
19d84ca5b3SWolfram Sang #include <linux/jiffies.h>
20d84ca5b3SWolfram Sang #include <linux/i2c.h>
21d84ca5b3SWolfram Sang #include <linux/hwmon.h>
22d84ca5b3SWolfram Sang #include <linux/hwmon-sysfs.h>
235a0e3ad6STejun Heo #include <linux/slab.h>
24d84ca5b3SWolfram Sang 
25d84ca5b3SWolfram Sang #define ADT7411_REG_INT_TEMP_VDD_LSB		0x03
26d84ca5b3SWolfram Sang #define ADT7411_REG_EXT_TEMP_AIN14_LSB		0x04
27d84ca5b3SWolfram Sang #define ADT7411_REG_VDD_MSB			0x06
28d84ca5b3SWolfram Sang #define ADT7411_REG_INT_TEMP_MSB		0x07
29d84ca5b3SWolfram Sang #define ADT7411_REG_EXT_TEMP_AIN1_MSB		0x08
30d84ca5b3SWolfram Sang 
31d84ca5b3SWolfram Sang #define ADT7411_REG_CFG1			0x18
32d84ca5b3SWolfram Sang #define ADT7411_CFG1_START_MONITOR		(1 << 0)
33d84ca5b3SWolfram Sang 
34d84ca5b3SWolfram Sang #define ADT7411_REG_CFG2			0x19
35d84ca5b3SWolfram Sang #define ADT7411_CFG2_DISABLE_AVG		(1 << 5)
36d84ca5b3SWolfram Sang 
37d84ca5b3SWolfram Sang #define ADT7411_REG_CFG3			0x1a
38d84ca5b3SWolfram Sang #define ADT7411_CFG3_ADC_CLK_225		(1 << 0)
39d84ca5b3SWolfram Sang #define ADT7411_CFG3_REF_VDD			(1 << 4)
40d84ca5b3SWolfram Sang 
41d84ca5b3SWolfram Sang #define ADT7411_REG_DEVICE_ID			0x4d
42d84ca5b3SWolfram Sang #define ADT7411_REG_MANUFACTURER_ID		0x4e
43d84ca5b3SWolfram Sang 
44d84ca5b3SWolfram Sang #define ADT7411_DEVICE_ID			0x2
45d84ca5b3SWolfram Sang #define ADT7411_MANUFACTURER_ID			0x41
46d84ca5b3SWolfram Sang 
47d84ca5b3SWolfram Sang static const unsigned short normal_i2c[] = { 0x48, 0x4a, 0x4b, I2C_CLIENT_END };
48d84ca5b3SWolfram Sang 
49d84ca5b3SWolfram Sang struct adt7411_data {
50d84ca5b3SWolfram Sang 	struct mutex device_lock;	/* for "atomic" device accesses */
5123244985SWolfram Sang 	struct mutex update_lock;
52d84ca5b3SWolfram Sang 	unsigned long next_update;
53d84ca5b3SWolfram Sang 	int vref_cached;
54d84ca5b3SWolfram Sang 	struct device *hwmon_dev;
55d84ca5b3SWolfram Sang };
56d84ca5b3SWolfram Sang 
57d84ca5b3SWolfram Sang /*
58d84ca5b3SWolfram Sang  * When reading a register containing (up to 4) lsb, all associated
59d84ca5b3SWolfram Sang  * msb-registers get locked by the hardware. After _one_ of those msb is read,
60d84ca5b3SWolfram Sang  * _all_ are unlocked. In order to use this locking correctly, reading lsb/msb
61d84ca5b3SWolfram Sang  * is protected here with a mutex, too.
62d84ca5b3SWolfram Sang  */
63d84ca5b3SWolfram Sang static int adt7411_read_10_bit(struct i2c_client *client, u8 lsb_reg,
64d84ca5b3SWolfram Sang 				u8 msb_reg, u8 lsb_shift)
65d84ca5b3SWolfram Sang {
66d84ca5b3SWolfram Sang 	struct adt7411_data *data = i2c_get_clientdata(client);
67d84ca5b3SWolfram Sang 	int val, tmp;
68d84ca5b3SWolfram Sang 
69d84ca5b3SWolfram Sang 	mutex_lock(&data->device_lock);
70d84ca5b3SWolfram Sang 
71d84ca5b3SWolfram Sang 	val = i2c_smbus_read_byte_data(client, lsb_reg);
72d84ca5b3SWolfram Sang 	if (val < 0)
73d84ca5b3SWolfram Sang 		goto exit_unlock;
74d84ca5b3SWolfram Sang 
75d84ca5b3SWolfram Sang 	tmp = (val >> lsb_shift) & 3;
76d84ca5b3SWolfram Sang 	val = i2c_smbus_read_byte_data(client, msb_reg);
77d84ca5b3SWolfram Sang 
78d84ca5b3SWolfram Sang 	if (val >= 0)
79d84ca5b3SWolfram Sang 		val = (val << 2) | tmp;
80d84ca5b3SWolfram Sang 
81d84ca5b3SWolfram Sang  exit_unlock:
82d84ca5b3SWolfram Sang 	mutex_unlock(&data->device_lock);
83d84ca5b3SWolfram Sang 
84d84ca5b3SWolfram Sang 	return val;
85d84ca5b3SWolfram Sang }
86d84ca5b3SWolfram Sang 
87d84ca5b3SWolfram Sang static int adt7411_modify_bit(struct i2c_client *client, u8 reg, u8 bit,
88d84ca5b3SWolfram Sang 				bool flag)
89d84ca5b3SWolfram Sang {
90d84ca5b3SWolfram Sang 	struct adt7411_data *data = i2c_get_clientdata(client);
91d84ca5b3SWolfram Sang 	int ret, val;
92d84ca5b3SWolfram Sang 
93d84ca5b3SWolfram Sang 	mutex_lock(&data->device_lock);
94d84ca5b3SWolfram Sang 
95d84ca5b3SWolfram Sang 	ret = i2c_smbus_read_byte_data(client, reg);
96d84ca5b3SWolfram Sang 	if (ret < 0)
97d84ca5b3SWolfram Sang 		goto exit_unlock;
98d84ca5b3SWolfram Sang 
99d84ca5b3SWolfram Sang 	if (flag)
100d84ca5b3SWolfram Sang 		val = ret | bit;
101d84ca5b3SWolfram Sang 	else
102d84ca5b3SWolfram Sang 		val = ret & ~bit;
103d84ca5b3SWolfram Sang 
104d84ca5b3SWolfram Sang 	ret = i2c_smbus_write_byte_data(client, reg, val);
105d84ca5b3SWolfram Sang 
106d84ca5b3SWolfram Sang  exit_unlock:
107d84ca5b3SWolfram Sang 	mutex_unlock(&data->device_lock);
108d84ca5b3SWolfram Sang 	return ret;
109d84ca5b3SWolfram Sang }
110d84ca5b3SWolfram Sang 
111d84ca5b3SWolfram Sang static ssize_t adt7411_show_vdd(struct device *dev,
112d84ca5b3SWolfram Sang 				struct device_attribute *attr, char *buf)
113d84ca5b3SWolfram Sang {
114d84ca5b3SWolfram Sang 	struct i2c_client *client = to_i2c_client(dev);
115d84ca5b3SWolfram Sang 	int ret = adt7411_read_10_bit(client, ADT7411_REG_INT_TEMP_VDD_LSB,
116d84ca5b3SWolfram Sang 			ADT7411_REG_VDD_MSB, 2);
117d84ca5b3SWolfram Sang 
118d84ca5b3SWolfram Sang 	return ret < 0 ? ret : sprintf(buf, "%u\n", ret * 7000 / 1024);
119d84ca5b3SWolfram Sang }
120d84ca5b3SWolfram Sang 
121d84ca5b3SWolfram Sang static ssize_t adt7411_show_temp(struct device *dev,
122d84ca5b3SWolfram Sang 			struct device_attribute *attr, char *buf)
123d84ca5b3SWolfram Sang {
124d84ca5b3SWolfram Sang 	struct i2c_client *client = to_i2c_client(dev);
125d84ca5b3SWolfram Sang 	int val = adt7411_read_10_bit(client, ADT7411_REG_INT_TEMP_VDD_LSB,
126d84ca5b3SWolfram Sang 			ADT7411_REG_INT_TEMP_MSB, 0);
127d84ca5b3SWolfram Sang 
128d84ca5b3SWolfram Sang 	if (val < 0)
129d84ca5b3SWolfram Sang 		return val;
130d84ca5b3SWolfram Sang 
131d84ca5b3SWolfram Sang 	val = val & 0x200 ? val - 0x400 : val; /* 10 bit signed */
132d84ca5b3SWolfram Sang 
133d84ca5b3SWolfram Sang 	return sprintf(buf, "%d\n", val * 250);
134d84ca5b3SWolfram Sang }
135d84ca5b3SWolfram Sang 
136d84ca5b3SWolfram Sang static ssize_t adt7411_show_input(struct device *dev,
137d84ca5b3SWolfram Sang 				  struct device_attribute *attr, char *buf)
138d84ca5b3SWolfram Sang {
139d84ca5b3SWolfram Sang 	int nr = to_sensor_dev_attr(attr)->index;
140d84ca5b3SWolfram Sang 	struct i2c_client *client = to_i2c_client(dev);
141d84ca5b3SWolfram Sang 	struct adt7411_data *data = i2c_get_clientdata(client);
142d84ca5b3SWolfram Sang 	int val;
143d84ca5b3SWolfram Sang 	u8 lsb_reg, lsb_shift;
144d84ca5b3SWolfram Sang 
14523244985SWolfram Sang 	mutex_lock(&data->update_lock);
146d84ca5b3SWolfram Sang 	if (time_after_eq(jiffies, data->next_update)) {
147d84ca5b3SWolfram Sang 		val = i2c_smbus_read_byte_data(client, ADT7411_REG_CFG3);
148d84ca5b3SWolfram Sang 		if (val < 0)
14923244985SWolfram Sang 			goto exit_unlock;
150d84ca5b3SWolfram Sang 
15123244985SWolfram Sang 		if (val & ADT7411_CFG3_REF_VDD) {
152d84ca5b3SWolfram Sang 			val = adt7411_read_10_bit(client,
153d84ca5b3SWolfram Sang 					ADT7411_REG_INT_TEMP_VDD_LSB,
154d84ca5b3SWolfram Sang 					ADT7411_REG_VDD_MSB, 2);
155d84ca5b3SWolfram Sang 			if (val < 0)
15623244985SWolfram Sang 				goto exit_unlock;
157d84ca5b3SWolfram Sang 
158d84ca5b3SWolfram Sang 			data->vref_cached = val * 7000 / 1024;
159d84ca5b3SWolfram Sang 		} else {
160d84ca5b3SWolfram Sang 			data->vref_cached = 2250;
161d84ca5b3SWolfram Sang 		}
162d84ca5b3SWolfram Sang 
163d84ca5b3SWolfram Sang 		data->next_update = jiffies + HZ;
164d84ca5b3SWolfram Sang 	}
165d84ca5b3SWolfram Sang 
166d84ca5b3SWolfram Sang 	lsb_reg = ADT7411_REG_EXT_TEMP_AIN14_LSB + (nr >> 2);
167d84ca5b3SWolfram Sang 	lsb_shift = 2 * (nr & 0x03);
168d84ca5b3SWolfram Sang 	val = adt7411_read_10_bit(client, lsb_reg,
169d84ca5b3SWolfram Sang 			ADT7411_REG_EXT_TEMP_AIN1_MSB + nr, lsb_shift);
17023244985SWolfram Sang 	if (val < 0)
17123244985SWolfram Sang 		goto exit_unlock;
172d84ca5b3SWolfram Sang 
17323244985SWolfram Sang 	val = sprintf(buf, "%u\n", val * data->vref_cached / 1024);
17423244985SWolfram Sang  exit_unlock:
17523244985SWolfram Sang 	mutex_unlock(&data->update_lock);
17623244985SWolfram Sang 	return val;
177d84ca5b3SWolfram Sang }
178d84ca5b3SWolfram Sang 
179d84ca5b3SWolfram Sang static ssize_t adt7411_show_bit(struct device *dev,
180d84ca5b3SWolfram Sang 				struct device_attribute *attr, char *buf)
181d84ca5b3SWolfram Sang {
182d84ca5b3SWolfram Sang 	struct sensor_device_attribute_2 *attr2 = to_sensor_dev_attr_2(attr);
183d84ca5b3SWolfram Sang 	struct i2c_client *client = to_i2c_client(dev);
184d84ca5b3SWolfram Sang 	int ret = i2c_smbus_read_byte_data(client, attr2->index);
185d84ca5b3SWolfram Sang 
186d84ca5b3SWolfram Sang 	return ret < 0 ? ret : sprintf(buf, "%u\n", !!(ret & attr2->nr));
187d84ca5b3SWolfram Sang }
188d84ca5b3SWolfram Sang 
189d84ca5b3SWolfram Sang static ssize_t adt7411_set_bit(struct device *dev,
190d84ca5b3SWolfram Sang 			       struct device_attribute *attr, const char *buf,
191d84ca5b3SWolfram Sang 			       size_t count)
192d84ca5b3SWolfram Sang {
193d84ca5b3SWolfram Sang 	struct sensor_device_attribute_2 *s_attr2 = to_sensor_dev_attr_2(attr);
194d84ca5b3SWolfram Sang 	struct i2c_client *client = to_i2c_client(dev);
195d84ca5b3SWolfram Sang 	struct adt7411_data *data = i2c_get_clientdata(client);
196d84ca5b3SWolfram Sang 	int ret;
197d84ca5b3SWolfram Sang 	unsigned long flag;
198d84ca5b3SWolfram Sang 
199179c4fdbSFrans Meulenbroeks 	ret = kstrtoul(buf, 0, &flag);
200d84ca5b3SWolfram Sang 	if (ret || flag > 1)
201d84ca5b3SWolfram Sang 		return -EINVAL;
202d84ca5b3SWolfram Sang 
203d84ca5b3SWolfram Sang 	ret = adt7411_modify_bit(client, s_attr2->index, s_attr2->nr, flag);
204d84ca5b3SWolfram Sang 
205d84ca5b3SWolfram Sang 	/* force update */
20623244985SWolfram Sang 	mutex_lock(&data->update_lock);
207d84ca5b3SWolfram Sang 	data->next_update = jiffies;
20823244985SWolfram Sang 	mutex_unlock(&data->update_lock);
209d84ca5b3SWolfram Sang 
210d84ca5b3SWolfram Sang 	return ret < 0 ? ret : count;
211d84ca5b3SWolfram Sang }
212d84ca5b3SWolfram Sang 
213d84ca5b3SWolfram Sang #define ADT7411_BIT_ATTR(__name, __reg, __bit) \
214d84ca5b3SWolfram Sang 	SENSOR_DEVICE_ATTR_2(__name, S_IRUGO | S_IWUSR, adt7411_show_bit, \
215d84ca5b3SWolfram Sang 	adt7411_set_bit, __bit, __reg)
216d84ca5b3SWolfram Sang 
217d84ca5b3SWolfram Sang static DEVICE_ATTR(temp1_input, S_IRUGO, adt7411_show_temp, NULL);
218d84ca5b3SWolfram Sang static DEVICE_ATTR(in0_input, S_IRUGO, adt7411_show_vdd, NULL);
219d84ca5b3SWolfram Sang static SENSOR_DEVICE_ATTR(in1_input, S_IRUGO, adt7411_show_input, NULL, 0);
220d84ca5b3SWolfram Sang static SENSOR_DEVICE_ATTR(in2_input, S_IRUGO, adt7411_show_input, NULL, 1);
221d84ca5b3SWolfram Sang static SENSOR_DEVICE_ATTR(in3_input, S_IRUGO, adt7411_show_input, NULL, 2);
222d84ca5b3SWolfram Sang static SENSOR_DEVICE_ATTR(in4_input, S_IRUGO, adt7411_show_input, NULL, 3);
223d84ca5b3SWolfram Sang static SENSOR_DEVICE_ATTR(in5_input, S_IRUGO, adt7411_show_input, NULL, 4);
224d84ca5b3SWolfram Sang static SENSOR_DEVICE_ATTR(in6_input, S_IRUGO, adt7411_show_input, NULL, 5);
225d84ca5b3SWolfram Sang static SENSOR_DEVICE_ATTR(in7_input, S_IRUGO, adt7411_show_input, NULL, 6);
226d84ca5b3SWolfram Sang static SENSOR_DEVICE_ATTR(in8_input, S_IRUGO, adt7411_show_input, NULL, 7);
227d84ca5b3SWolfram Sang static ADT7411_BIT_ATTR(no_average, ADT7411_REG_CFG2, ADT7411_CFG2_DISABLE_AVG);
228d84ca5b3SWolfram Sang static ADT7411_BIT_ATTR(fast_sampling, ADT7411_REG_CFG3, ADT7411_CFG3_ADC_CLK_225);
229d84ca5b3SWolfram Sang static ADT7411_BIT_ATTR(adc_ref_vdd, ADT7411_REG_CFG3, ADT7411_CFG3_REF_VDD);
230d84ca5b3SWolfram Sang 
231d84ca5b3SWolfram Sang static struct attribute *adt7411_attrs[] = {
232d84ca5b3SWolfram Sang 	&dev_attr_temp1_input.attr,
233d84ca5b3SWolfram Sang 	&dev_attr_in0_input.attr,
234d84ca5b3SWolfram Sang 	&sensor_dev_attr_in1_input.dev_attr.attr,
235d84ca5b3SWolfram Sang 	&sensor_dev_attr_in2_input.dev_attr.attr,
236d84ca5b3SWolfram Sang 	&sensor_dev_attr_in3_input.dev_attr.attr,
237d84ca5b3SWolfram Sang 	&sensor_dev_attr_in4_input.dev_attr.attr,
238d84ca5b3SWolfram Sang 	&sensor_dev_attr_in5_input.dev_attr.attr,
239d84ca5b3SWolfram Sang 	&sensor_dev_attr_in6_input.dev_attr.attr,
240d84ca5b3SWolfram Sang 	&sensor_dev_attr_in7_input.dev_attr.attr,
241d84ca5b3SWolfram Sang 	&sensor_dev_attr_in8_input.dev_attr.attr,
242d84ca5b3SWolfram Sang 	&sensor_dev_attr_no_average.dev_attr.attr,
243d84ca5b3SWolfram Sang 	&sensor_dev_attr_fast_sampling.dev_attr.attr,
244d84ca5b3SWolfram Sang 	&sensor_dev_attr_adc_ref_vdd.dev_attr.attr,
245d84ca5b3SWolfram Sang 	NULL
246d84ca5b3SWolfram Sang };
247d84ca5b3SWolfram Sang 
248d84ca5b3SWolfram Sang static const struct attribute_group adt7411_attr_grp = {
249d84ca5b3SWolfram Sang 	.attrs = adt7411_attrs,
250d84ca5b3SWolfram Sang };
251d84ca5b3SWolfram Sang 
252d84ca5b3SWolfram Sang static int adt7411_detect(struct i2c_client *client,
253d84ca5b3SWolfram Sang 			  struct i2c_board_info *info)
254d84ca5b3SWolfram Sang {
255d84ca5b3SWolfram Sang 	int val;
256d84ca5b3SWolfram Sang 
257d84ca5b3SWolfram Sang 	if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_BYTE_DATA))
258d84ca5b3SWolfram Sang 		return -ENODEV;
259d84ca5b3SWolfram Sang 
260d84ca5b3SWolfram Sang 	val = i2c_smbus_read_byte_data(client, ADT7411_REG_MANUFACTURER_ID);
261d84ca5b3SWolfram Sang 	if (val < 0 || val != ADT7411_MANUFACTURER_ID) {
262d84ca5b3SWolfram Sang 		dev_dbg(&client->dev, "Wrong manufacturer ID. Got %d, "
263d84ca5b3SWolfram Sang 			"expected %d\n", val, ADT7411_MANUFACTURER_ID);
264d84ca5b3SWolfram Sang 		return -ENODEV;
265d84ca5b3SWolfram Sang 	}
266d84ca5b3SWolfram Sang 
267d84ca5b3SWolfram Sang 	val = i2c_smbus_read_byte_data(client, ADT7411_REG_DEVICE_ID);
268d84ca5b3SWolfram Sang 	if (val < 0 || val != ADT7411_DEVICE_ID) {
269d84ca5b3SWolfram Sang 		dev_dbg(&client->dev, "Wrong device ID. Got %d, "
270d84ca5b3SWolfram Sang 			"expected %d\n", val, ADT7411_DEVICE_ID);
271d84ca5b3SWolfram Sang 		return -ENODEV;
272d84ca5b3SWolfram Sang 	}
273d84ca5b3SWolfram Sang 
274d84ca5b3SWolfram Sang 	strlcpy(info->type, "adt7411", I2C_NAME_SIZE);
275d84ca5b3SWolfram Sang 
276d84ca5b3SWolfram Sang 	return 0;
277d84ca5b3SWolfram Sang }
278d84ca5b3SWolfram Sang 
279d84ca5b3SWolfram Sang static int __devinit adt7411_probe(struct i2c_client *client,
280d84ca5b3SWolfram Sang 				   const struct i2c_device_id *id)
281d84ca5b3SWolfram Sang {
282d84ca5b3SWolfram Sang 	struct adt7411_data *data;
283d84ca5b3SWolfram Sang 	int ret;
284d84ca5b3SWolfram Sang 
28565ec17b0SGuenter Roeck 	data = devm_kzalloc(&client->dev, sizeof(*data), GFP_KERNEL);
286d84ca5b3SWolfram Sang 	if (!data)
287d84ca5b3SWolfram Sang 		return -ENOMEM;
288d84ca5b3SWolfram Sang 
289d84ca5b3SWolfram Sang 	i2c_set_clientdata(client, data);
290d84ca5b3SWolfram Sang 	mutex_init(&data->device_lock);
29123244985SWolfram Sang 	mutex_init(&data->update_lock);
292d84ca5b3SWolfram Sang 
293d84ca5b3SWolfram Sang 	ret = adt7411_modify_bit(client, ADT7411_REG_CFG1,
294d84ca5b3SWolfram Sang 				 ADT7411_CFG1_START_MONITOR, 1);
295d84ca5b3SWolfram Sang 	if (ret < 0)
29665ec17b0SGuenter Roeck 		return ret;
297d84ca5b3SWolfram Sang 
298d84ca5b3SWolfram Sang 	/* force update on first occasion */
299d84ca5b3SWolfram Sang 	data->next_update = jiffies;
300d84ca5b3SWolfram Sang 
301d84ca5b3SWolfram Sang 	ret = sysfs_create_group(&client->dev.kobj, &adt7411_attr_grp);
302d84ca5b3SWolfram Sang 	if (ret)
30365ec17b0SGuenter Roeck 		return ret;
304d84ca5b3SWolfram Sang 
305d84ca5b3SWolfram Sang 	data->hwmon_dev = hwmon_device_register(&client->dev);
306d84ca5b3SWolfram Sang 	if (IS_ERR(data->hwmon_dev)) {
307d84ca5b3SWolfram Sang 		ret = PTR_ERR(data->hwmon_dev);
308d84ca5b3SWolfram Sang 		goto exit_remove;
309d84ca5b3SWolfram Sang 	}
310d84ca5b3SWolfram Sang 
311d84ca5b3SWolfram Sang 	dev_info(&client->dev, "successfully registered\n");
312d84ca5b3SWolfram Sang 
313d84ca5b3SWolfram Sang 	return 0;
314d84ca5b3SWolfram Sang 
315d84ca5b3SWolfram Sang  exit_remove:
316d84ca5b3SWolfram Sang 	sysfs_remove_group(&client->dev.kobj, &adt7411_attr_grp);
317d84ca5b3SWolfram Sang 	return ret;
318d84ca5b3SWolfram Sang }
319d84ca5b3SWolfram Sang 
320d84ca5b3SWolfram Sang static int __devexit adt7411_remove(struct i2c_client *client)
321d84ca5b3SWolfram Sang {
322d84ca5b3SWolfram Sang 	struct adt7411_data *data = i2c_get_clientdata(client);
323d84ca5b3SWolfram Sang 
324d84ca5b3SWolfram Sang 	hwmon_device_unregister(data->hwmon_dev);
325d84ca5b3SWolfram Sang 	sysfs_remove_group(&client->dev.kobj, &adt7411_attr_grp);
326d84ca5b3SWolfram Sang 	return 0;
327d84ca5b3SWolfram Sang }
328d84ca5b3SWolfram Sang 
329d84ca5b3SWolfram Sang static const struct i2c_device_id adt7411_id[] = {
330d84ca5b3SWolfram Sang 	{ "adt7411", 0 },
331d84ca5b3SWolfram Sang 	{ }
332d84ca5b3SWolfram Sang };
333a7254d68Saxel lin MODULE_DEVICE_TABLE(i2c, adt7411_id);
334d84ca5b3SWolfram Sang 
335d84ca5b3SWolfram Sang static struct i2c_driver adt7411_driver = {
336d84ca5b3SWolfram Sang 	.driver		= {
337d84ca5b3SWolfram Sang 		.name		= "adt7411",
338d84ca5b3SWolfram Sang 	},
339d84ca5b3SWolfram Sang 	.probe  = adt7411_probe,
3409e5e9b7aSBill Pemberton 	.remove	= adt7411_remove,
341d84ca5b3SWolfram Sang 	.id_table = adt7411_id,
342d84ca5b3SWolfram Sang 	.detect = adt7411_detect,
343d84ca5b3SWolfram Sang 	.address_list = normal_i2c,
344d84ca5b3SWolfram Sang 	.class = I2C_CLASS_HWMON,
345d84ca5b3SWolfram Sang };
346d84ca5b3SWolfram Sang 
347f0967eeaSAxel Lin module_i2c_driver(adt7411_driver);
348d84ca5b3SWolfram Sang 
349d84ca5b3SWolfram Sang MODULE_AUTHOR("Sascha Hauer <s.hauer@pengutronix.de> and "
350d84ca5b3SWolfram Sang 	"Wolfram Sang <w.sang@pengutronix.de>");
351d84ca5b3SWolfram Sang MODULE_DESCRIPTION("ADT7411 driver");
352d84ca5b3SWolfram Sang MODULE_LICENSE("GPL v2");
353