1dff96888SDirk Hohndel (VMware) // SPDX-License-Identifier: GPL-2.0 OR MIT
2fb1d9738SJakob Bornecrantz /**************************************************************************
3fb1d9738SJakob Bornecrantz  *
46703e28fSZack Rusin  * Copyright 2009-2023 VMware, Inc., Palo Alto, CA., USA
5fb1d9738SJakob Bornecrantz  *
6fb1d9738SJakob Bornecrantz  * Permission is hereby granted, free of charge, to any person obtaining a
7fb1d9738SJakob Bornecrantz  * copy of this software and associated documentation files (the
8fb1d9738SJakob Bornecrantz  * "Software"), to deal in the Software without restriction, including
9fb1d9738SJakob Bornecrantz  * without limitation the rights to use, copy, modify, merge, publish,
10fb1d9738SJakob Bornecrantz  * distribute, sub license, and/or sell copies of the Software, and to
11fb1d9738SJakob Bornecrantz  * permit persons to whom the Software is furnished to do so, subject to
12fb1d9738SJakob Bornecrantz  * the following conditions:
13fb1d9738SJakob Bornecrantz  *
14fb1d9738SJakob Bornecrantz  * The above copyright notice and this permission notice (including the
15fb1d9738SJakob Bornecrantz  * next paragraph) shall be included in all copies or substantial portions
16fb1d9738SJakob Bornecrantz  * of the Software.
17fb1d9738SJakob Bornecrantz  *
18fb1d9738SJakob Bornecrantz  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
19fb1d9738SJakob Bornecrantz  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
20fb1d9738SJakob Bornecrantz  * FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL
21fb1d9738SJakob Bornecrantz  * THE COPYRIGHT HOLDERS, AUTHORS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM,
22fb1d9738SJakob Bornecrantz  * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
23fb1d9738SJakob Bornecrantz  * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
24fb1d9738SJakob Bornecrantz  * USE OR OTHER DEALINGS IN THE SOFTWARE.
25fb1d9738SJakob Bornecrantz  *
26fb1d9738SJakob Bornecrantz  **************************************************************************/
27fb1d9738SJakob Bornecrantz 
286703e28fSZack Rusin #include "vmwgfx_bo.h"
296703e28fSZack Rusin #include "vmwgfx_kms.h"
306703e28fSZack Rusin 
31d7721ca7SSinclair Yeh #include <drm/drm_atomic.h>
32d7721ca7SSinclair Yeh #include <drm/drm_atomic_helper.h>
33d5c1f011SSam Ravnborg #include <drm/drm_fourcc.h>
34fb1d9738SJakob Bornecrantz 
357a1c2f6cSThomas Hellstrom 
36fb1d9738SJakob Bornecrantz #define vmw_crtc_to_ldu(x) \
37fb1d9738SJakob Bornecrantz 	container_of(x, struct vmw_legacy_display_unit, base.crtc)
38fb1d9738SJakob Bornecrantz #define vmw_encoder_to_ldu(x) \
39fb1d9738SJakob Bornecrantz 	container_of(x, struct vmw_legacy_display_unit, base.encoder)
40fb1d9738SJakob Bornecrantz #define vmw_connector_to_ldu(x) \
41fb1d9738SJakob Bornecrantz 	container_of(x, struct vmw_legacy_display_unit, base.connector)
42fb1d9738SJakob Bornecrantz 
43fb1d9738SJakob Bornecrantz struct vmw_legacy_display {
44fb1d9738SJakob Bornecrantz 	struct list_head active;
45fb1d9738SJakob Bornecrantz 
46fb1d9738SJakob Bornecrantz 	unsigned num_active;
47d7e1958dSJakob Bornecrantz 	unsigned last_num_active;
48fb1d9738SJakob Bornecrantz 
49fb1d9738SJakob Bornecrantz 	struct vmw_framebuffer *fb;
50fb1d9738SJakob Bornecrantz };
51fb1d9738SJakob Bornecrantz 
5247c617bfSLee Jones /*
53fb1d9738SJakob Bornecrantz  * Display unit using the legacy register interface.
54fb1d9738SJakob Bornecrantz  */
55fb1d9738SJakob Bornecrantz struct vmw_legacy_display_unit {
56fb1d9738SJakob Bornecrantz 	struct vmw_display_unit base;
57fb1d9738SJakob Bornecrantz 
58fb1d9738SJakob Bornecrantz 	struct list_head active;
59fb1d9738SJakob Bornecrantz };
60fb1d9738SJakob Bornecrantz 
vmw_ldu_destroy(struct vmw_legacy_display_unit * ldu)61fb1d9738SJakob Bornecrantz static void vmw_ldu_destroy(struct vmw_legacy_display_unit *ldu)
62fb1d9738SJakob Bornecrantz {
63fb1d9738SJakob Bornecrantz 	list_del_init(&ldu->active);
64c8261a96SSinclair Yeh 	vmw_du_cleanup(&ldu->base);
65fb1d9738SJakob Bornecrantz 	kfree(ldu);
66fb1d9738SJakob Bornecrantz }
67fb1d9738SJakob Bornecrantz 
68fb1d9738SJakob Bornecrantz 
69fb1d9738SJakob Bornecrantz /*
70fb1d9738SJakob Bornecrantz  * Legacy Display Unit CRTC functions
71fb1d9738SJakob Bornecrantz  */
72fb1d9738SJakob Bornecrantz 
vmw_ldu_crtc_destroy(struct drm_crtc * crtc)73fb1d9738SJakob Bornecrantz static void vmw_ldu_crtc_destroy(struct drm_crtc *crtc)
74fb1d9738SJakob Bornecrantz {
75fb1d9738SJakob Bornecrantz 	vmw_ldu_destroy(vmw_crtc_to_ldu(crtc));
76fb1d9738SJakob Bornecrantz }
77fb1d9738SJakob Bornecrantz 
vmw_ldu_commit_list(struct vmw_private * dev_priv)78fb1d9738SJakob Bornecrantz static int vmw_ldu_commit_list(struct vmw_private *dev_priv)
79fb1d9738SJakob Bornecrantz {
80fb1d9738SJakob Bornecrantz 	struct vmw_legacy_display *lds = dev_priv->ldu_priv;
81fb1d9738SJakob Bornecrantz 	struct vmw_legacy_display_unit *entry;
82d7e1958dSJakob Bornecrantz 	struct drm_framebuffer *fb = NULL;
83d7e1958dSJakob Bornecrantz 	struct drm_crtc *crtc = NULL;
841d2c0c56SDan Carpenter 	int i;
85fb1d9738SJakob Bornecrantz 
86d7e1958dSJakob Bornecrantz 	/* If there is no display topology the host just assumes
87d7e1958dSJakob Bornecrantz 	 * that the guest will set the same layout as the host.
88d7e1958dSJakob Bornecrantz 	 */
89d7e1958dSJakob Bornecrantz 	if (!(dev_priv->capabilities & SVGA_CAP_DISPLAY_TOPOLOGY)) {
90d7e1958dSJakob Bornecrantz 		int w = 0, h = 0;
91d7e1958dSJakob Bornecrantz 		list_for_each_entry(entry, &lds->active, active) {
92d7e1958dSJakob Bornecrantz 			crtc = &entry->base.crtc;
93d7e1958dSJakob Bornecrantz 			w = max(w, crtc->x + crtc->mode.hdisplay);
94d7e1958dSJakob Bornecrantz 			h = max(h, crtc->y + crtc->mode.vdisplay);
95d7e1958dSJakob Bornecrantz 		}
96d7e1958dSJakob Bornecrantz 
97d7e1958dSJakob Bornecrantz 		if (crtc == NULL)
98d7e1958dSJakob Bornecrantz 			return 0;
991d2c0c56SDan Carpenter 		fb = crtc->primary->state->fb;
100d7e1958dSJakob Bornecrantz 
10101f2c773SVille Syrjälä 		return vmw_kms_write_svga(dev_priv, w, h, fb->pitches[0],
102272725c7SVille Syrjälä 					  fb->format->cpp[0] * 8,
103b00c600eSVille Syrjälä 					  fb->format->depth);
104d7e1958dSJakob Bornecrantz 	}
105d7e1958dSJakob Bornecrantz 
106d7e1958dSJakob Bornecrantz 	if (!list_empty(&lds->active)) {
107d7e1958dSJakob Bornecrantz 		entry = list_entry(lds->active.next, typeof(*entry), active);
108b0119cb9SSinclair Yeh 		fb = entry->base.crtc.primary->state->fb;
109d7e1958dSJakob Bornecrantz 
11001f2c773SVille Syrjälä 		vmw_kms_write_svga(dev_priv, fb->width, fb->height, fb->pitches[0],
111272725c7SVille Syrjälä 				   fb->format->cpp[0] * 8, fb->format->depth);
112d7e1958dSJakob Bornecrantz 	}
113d7e1958dSJakob Bornecrantz 
114259600d5SJakob Bornecrantz 	/* Make sure we always show something. */
115259600d5SJakob Bornecrantz 	vmw_write(dev_priv, SVGA_REG_NUM_GUEST_DISPLAYS,
116259600d5SJakob Bornecrantz 		  lds->num_active ? lds->num_active : 1);
117259600d5SJakob Bornecrantz 
118fb1d9738SJakob Bornecrantz 	i = 0;
119fb1d9738SJakob Bornecrantz 	list_for_each_entry(entry, &lds->active, active) {
120fb1d9738SJakob Bornecrantz 		crtc = &entry->base.crtc;
121fb1d9738SJakob Bornecrantz 
122fb1d9738SJakob Bornecrantz 		vmw_write(dev_priv, SVGA_REG_DISPLAY_ID, i);
123fb1d9738SJakob Bornecrantz 		vmw_write(dev_priv, SVGA_REG_DISPLAY_IS_PRIMARY, !i);
124fb1d9738SJakob Bornecrantz 		vmw_write(dev_priv, SVGA_REG_DISPLAY_POSITION_X, crtc->x);
125fb1d9738SJakob Bornecrantz 		vmw_write(dev_priv, SVGA_REG_DISPLAY_POSITION_Y, crtc->y);
126fb1d9738SJakob Bornecrantz 		vmw_write(dev_priv, SVGA_REG_DISPLAY_WIDTH, crtc->mode.hdisplay);
127fb1d9738SJakob Bornecrantz 		vmw_write(dev_priv, SVGA_REG_DISPLAY_HEIGHT, crtc->mode.vdisplay);
128fb1d9738SJakob Bornecrantz 
129fb1d9738SJakob Bornecrantz 		i++;
130fb1d9738SJakob Bornecrantz 	}
131fb1d9738SJakob Bornecrantz 
132d7e1958dSJakob Bornecrantz 	BUG_ON(i != lds->num_active);
133d7e1958dSJakob Bornecrantz 
134d7e1958dSJakob Bornecrantz 	lds->last_num_active = lds->num_active;
135d7e1958dSJakob Bornecrantz 
136fb1d9738SJakob Bornecrantz 	return 0;
137fb1d9738SJakob Bornecrantz }
138fb1d9738SJakob Bornecrantz 
1396703e28fSZack Rusin /*
1406703e28fSZack Rusin  * Pin the buffer in a location suitable for access by the
1416703e28fSZack Rusin  * display system.
1426703e28fSZack Rusin  */
vmw_ldu_fb_pin(struct vmw_framebuffer * vfb)1436703e28fSZack Rusin static int vmw_ldu_fb_pin(struct vmw_framebuffer *vfb)
1446703e28fSZack Rusin {
1456703e28fSZack Rusin 	struct vmw_private *dev_priv = vmw_priv(vfb->base.dev);
1466703e28fSZack Rusin 	struct vmw_bo *buf;
1476703e28fSZack Rusin 	int ret;
1486703e28fSZack Rusin 
1496703e28fSZack Rusin 	buf = vfb->bo ?  vmw_framebuffer_to_vfbd(&vfb->base)->buffer :
150668b2066SZack Rusin 		vmw_framebuffer_to_vfbs(&vfb->base)->surface->res.guest_memory_bo;
1516703e28fSZack Rusin 
1526703e28fSZack Rusin 	if (!buf)
1536703e28fSZack Rusin 		return 0;
1546703e28fSZack Rusin 	WARN_ON(dev_priv->active_display_unit != vmw_du_legacy);
1556703e28fSZack Rusin 
1566703e28fSZack Rusin 	if (dev_priv->active_display_unit == vmw_du_legacy) {
1576703e28fSZack Rusin 		vmw_overlay_pause_all(dev_priv);
1586703e28fSZack Rusin 		ret = vmw_bo_pin_in_start_of_vram(dev_priv, buf, false);
1596703e28fSZack Rusin 		vmw_overlay_resume_all(dev_priv);
1606703e28fSZack Rusin 	} else
1616703e28fSZack Rusin 		ret = -EINVAL;
1626703e28fSZack Rusin 
1636703e28fSZack Rusin 	return ret;
1646703e28fSZack Rusin }
1656703e28fSZack Rusin 
vmw_ldu_fb_unpin(struct vmw_framebuffer * vfb)1666703e28fSZack Rusin static int vmw_ldu_fb_unpin(struct vmw_framebuffer *vfb)
1676703e28fSZack Rusin {
1686703e28fSZack Rusin 	struct vmw_private *dev_priv = vmw_priv(vfb->base.dev);
1696703e28fSZack Rusin 	struct vmw_bo *buf;
1706703e28fSZack Rusin 
1716703e28fSZack Rusin 	buf = vfb->bo ?  vmw_framebuffer_to_vfbd(&vfb->base)->buffer :
172668b2066SZack Rusin 		vmw_framebuffer_to_vfbs(&vfb->base)->surface->res.guest_memory_bo;
1736703e28fSZack Rusin 
1746703e28fSZack Rusin 	if (WARN_ON(!buf))
1756703e28fSZack Rusin 		return 0;
1766703e28fSZack Rusin 
1776703e28fSZack Rusin 	return vmw_bo_unpin(dev_priv, buf, false);
1786703e28fSZack Rusin }
1796703e28fSZack Rusin 
vmw_ldu_del_active(struct vmw_private * vmw_priv,struct vmw_legacy_display_unit * ldu)180fb1d9738SJakob Bornecrantz static int vmw_ldu_del_active(struct vmw_private *vmw_priv,
181fb1d9738SJakob Bornecrantz 			      struct vmw_legacy_display_unit *ldu)
182fb1d9738SJakob Bornecrantz {
183fb1d9738SJakob Bornecrantz 	struct vmw_legacy_display *ld = vmw_priv->ldu_priv;
184fb1d9738SJakob Bornecrantz 	if (list_empty(&ldu->active))
185fb1d9738SJakob Bornecrantz 		return 0;
186fb1d9738SJakob Bornecrantz 
1876a591a96SJakob Bornecrantz 	/* Must init otherwise list_empty(&ldu->active) will not work. */
188fb1d9738SJakob Bornecrantz 	list_del_init(&ldu->active);
189fb1d9738SJakob Bornecrantz 	if (--(ld->num_active) == 0) {
190fb1d9738SJakob Bornecrantz 		BUG_ON(!ld->fb);
1916703e28fSZack Rusin 		WARN_ON(vmw_ldu_fb_unpin(ld->fb));
192fb1d9738SJakob Bornecrantz 		ld->fb = NULL;
193fb1d9738SJakob Bornecrantz 	}
194fb1d9738SJakob Bornecrantz 
195fb1d9738SJakob Bornecrantz 	return 0;
196fb1d9738SJakob Bornecrantz }
197fb1d9738SJakob Bornecrantz 
vmw_ldu_add_active(struct vmw_private * vmw_priv,struct vmw_legacy_display_unit * ldu,struct vmw_framebuffer * vfb)198fb1d9738SJakob Bornecrantz static int vmw_ldu_add_active(struct vmw_private *vmw_priv,
199fb1d9738SJakob Bornecrantz 			      struct vmw_legacy_display_unit *ldu,
200fb1d9738SJakob Bornecrantz 			      struct vmw_framebuffer *vfb)
201fb1d9738SJakob Bornecrantz {
202fb1d9738SJakob Bornecrantz 	struct vmw_legacy_display *ld = vmw_priv->ldu_priv;
203fb1d9738SJakob Bornecrantz 	struct vmw_legacy_display_unit *entry;
204fb1d9738SJakob Bornecrantz 	struct list_head *at;
205fb1d9738SJakob Bornecrantz 
20604e9e94dSJakob Bornecrantz 	BUG_ON(!ld->num_active && ld->fb);
20704e9e94dSJakob Bornecrantz 	if (vfb != ld->fb) {
2086703e28fSZack Rusin 		if (ld->fb)
2096703e28fSZack Rusin 			WARN_ON(vmw_ldu_fb_unpin(ld->fb));
21006ec4190SSinclair Yeh 		vmw_svga_enable(vmw_priv);
2116703e28fSZack Rusin 		WARN_ON(vmw_ldu_fb_pin(vfb));
21204e9e94dSJakob Bornecrantz 		ld->fb = vfb;
21304e9e94dSJakob Bornecrantz 	}
21404e9e94dSJakob Bornecrantz 
215fb1d9738SJakob Bornecrantz 	if (!list_empty(&ldu->active))
216fb1d9738SJakob Bornecrantz 		return 0;
217fb1d9738SJakob Bornecrantz 
218fb1d9738SJakob Bornecrantz 	at = &ld->active;
219fb1d9738SJakob Bornecrantz 	list_for_each_entry(entry, &ld->active, active) {
220bbfad336SJakob Bornecrantz 		if (entry->base.unit > ldu->base.unit)
221fb1d9738SJakob Bornecrantz 			break;
222fb1d9738SJakob Bornecrantz 
223fb1d9738SJakob Bornecrantz 		at = &entry->active;
224fb1d9738SJakob Bornecrantz 	}
225fb1d9738SJakob Bornecrantz 
226fb1d9738SJakob Bornecrantz 	list_add(&ldu->active, at);
22704e9e94dSJakob Bornecrantz 
22804e9e94dSJakob Bornecrantz 	ld->num_active++;
229fb1d9738SJakob Bornecrantz 
230fb1d9738SJakob Bornecrantz 	return 0;
231fb1d9738SJakob Bornecrantz }
232fb1d9738SJakob Bornecrantz 
23306ec4190SSinclair Yeh /**
23406ec4190SSinclair Yeh  * vmw_ldu_crtc_mode_set_nofb - Enable svga
23506ec4190SSinclair Yeh  *
23606ec4190SSinclair Yeh  * @crtc: CRTC associated with the new screen
23706ec4190SSinclair Yeh  *
23806ec4190SSinclair Yeh  * For LDU, just enable the svga
23906ec4190SSinclair Yeh  */
vmw_ldu_crtc_mode_set_nofb(struct drm_crtc * crtc)24006ec4190SSinclair Yeh static void vmw_ldu_crtc_mode_set_nofb(struct drm_crtc *crtc)
24106ec4190SSinclair Yeh {
24206ec4190SSinclair Yeh }
24306ec4190SSinclair Yeh 
24406ec4190SSinclair Yeh /**
2450b20a0f8SLaurent Pinchart  * vmw_ldu_crtc_atomic_enable - Noop
24606ec4190SSinclair Yeh  *
24706ec4190SSinclair Yeh  * @crtc: CRTC associated with the new screen
24847c617bfSLee Jones  * @state: Unused
24906ec4190SSinclair Yeh  *
25006ec4190SSinclair Yeh  * This is called after a mode set has been completed.  Here's
25106ec4190SSinclair Yeh  * usually a good place to call vmw_ldu_add_active/vmw_ldu_del_active
25206ec4190SSinclair Yeh  * but since for LDU the display plane is closely tied to the
25306ec4190SSinclair Yeh  * CRTC, it makes more sense to do those at plane update time.
25406ec4190SSinclair Yeh  */
vmw_ldu_crtc_atomic_enable(struct drm_crtc * crtc,struct drm_atomic_state * state)2550b20a0f8SLaurent Pinchart static void vmw_ldu_crtc_atomic_enable(struct drm_crtc *crtc,
256351f950dSMaxime Ripard 				       struct drm_atomic_state *state)
25706ec4190SSinclair Yeh {
25806ec4190SSinclair Yeh }
25906ec4190SSinclair Yeh 
26006ec4190SSinclair Yeh /**
26164581714SLaurent Pinchart  * vmw_ldu_crtc_atomic_disable - Turns off CRTC
26206ec4190SSinclair Yeh  *
26306ec4190SSinclair Yeh  * @crtc: CRTC to be turned off
26447c617bfSLee Jones  * @state: Unused
26506ec4190SSinclair Yeh  */
vmw_ldu_crtc_atomic_disable(struct drm_crtc * crtc,struct drm_atomic_state * state)26664581714SLaurent Pinchart static void vmw_ldu_crtc_atomic_disable(struct drm_crtc *crtc,
267351f950dSMaxime Ripard 					struct drm_atomic_state *state)
26806ec4190SSinclair Yeh {
26906ec4190SSinclair Yeh }
27006ec4190SSinclair Yeh 
271d7955fcfSVille Syrjälä static const struct drm_crtc_funcs vmw_legacy_crtc_funcs = {
272626ab771SJakob Bornecrantz 	.gamma_set = vmw_du_crtc_gamma_set,
273fb1d9738SJakob Bornecrantz 	.destroy = vmw_ldu_crtc_destroy,
2749c2542a4SSinclair Yeh 	.reset = vmw_du_crtc_reset,
2759c2542a4SSinclair Yeh 	.atomic_duplicate_state = vmw_du_crtc_duplicate_state,
2769c2542a4SSinclair Yeh 	.atomic_destroy_state = vmw_du_crtc_destroy_state,
277b4fa61baSDeepak Rawat 	.set_config = drm_atomic_helper_set_config,
278*a37a512dSMartin Krastev 	.page_flip = drm_atomic_helper_page_flip,
279fb1d9738SJakob Bornecrantz };
280fb1d9738SJakob Bornecrantz 
281626ab771SJakob Bornecrantz 
282fb1d9738SJakob Bornecrantz /*
283fb1d9738SJakob Bornecrantz  * Legacy Display Unit encoder functions
284fb1d9738SJakob Bornecrantz  */
285fb1d9738SJakob Bornecrantz 
vmw_ldu_encoder_destroy(struct drm_encoder * encoder)286fb1d9738SJakob Bornecrantz static void vmw_ldu_encoder_destroy(struct drm_encoder *encoder)
287fb1d9738SJakob Bornecrantz {
288fb1d9738SJakob Bornecrantz 	vmw_ldu_destroy(vmw_encoder_to_ldu(encoder));
289fb1d9738SJakob Bornecrantz }
290fb1d9738SJakob Bornecrantz 
291d7955fcfSVille Syrjälä static const struct drm_encoder_funcs vmw_legacy_encoder_funcs = {
292fb1d9738SJakob Bornecrantz 	.destroy = vmw_ldu_encoder_destroy,
293fb1d9738SJakob Bornecrantz };
294fb1d9738SJakob Bornecrantz 
295fb1d9738SJakob Bornecrantz /*
296fb1d9738SJakob Bornecrantz  * Legacy Display Unit connector functions
297fb1d9738SJakob Bornecrantz  */
298fb1d9738SJakob Bornecrantz 
vmw_ldu_connector_destroy(struct drm_connector * connector)299fb1d9738SJakob Bornecrantz static void vmw_ldu_connector_destroy(struct drm_connector *connector)
300fb1d9738SJakob Bornecrantz {
301fb1d9738SJakob Bornecrantz 	vmw_ldu_destroy(vmw_connector_to_ldu(connector));
302fb1d9738SJakob Bornecrantz }
303fb1d9738SJakob Bornecrantz 
304d7955fcfSVille Syrjälä static const struct drm_connector_funcs vmw_legacy_connector_funcs = {
305626ab771SJakob Bornecrantz 	.dpms = vmw_du_connector_dpms,
306626ab771SJakob Bornecrantz 	.detect = vmw_du_connector_detect,
307626ab771SJakob Bornecrantz 	.fill_modes = vmw_du_connector_fill_modes,
308fb1d9738SJakob Bornecrantz 	.destroy = vmw_ldu_connector_destroy,
309d7721ca7SSinclair Yeh 	.reset = vmw_du_connector_reset,
3108a510a5cSRob Clark 	.atomic_duplicate_state = vmw_du_connector_duplicate_state,
3118a510a5cSRob Clark 	.atomic_destroy_state = vmw_du_connector_destroy_state,
312fb1d9738SJakob Bornecrantz };
313fb1d9738SJakob Bornecrantz 
314d947d1b7SSinclair Yeh static const struct
315d947d1b7SSinclair Yeh drm_connector_helper_funcs vmw_ldu_connector_helper_funcs = {
316d947d1b7SSinclair Yeh };
317d947d1b7SSinclair Yeh 
318*a37a512dSMartin Krastev static int vmw_kms_ldu_do_bo_dirty(struct vmw_private *dev_priv,
319*a37a512dSMartin Krastev 				   struct vmw_framebuffer *framebuffer,
320*a37a512dSMartin Krastev 				   unsigned int flags, unsigned int color,
321*a37a512dSMartin Krastev 				   struct drm_mode_rect *clips,
322*a37a512dSMartin Krastev 				   unsigned int num_clips);
323*a37a512dSMartin Krastev 
32436cc79bcSSinclair Yeh /*
32536cc79bcSSinclair Yeh  * Legacy Display Plane Functions
32636cc79bcSSinclair Yeh  */
32736cc79bcSSinclair Yeh 
328060e2ad5SSinclair Yeh static void
vmw_ldu_primary_plane_atomic_update(struct drm_plane * plane,struct drm_atomic_state * state)329060e2ad5SSinclair Yeh vmw_ldu_primary_plane_atomic_update(struct drm_plane *plane,
330977697e2SMaxime Ripard 				    struct drm_atomic_state *state)
331060e2ad5SSinclair Yeh {
332977697e2SMaxime Ripard 	struct drm_plane_state *old_state = drm_atomic_get_old_plane_state(state,
333977697e2SMaxime Ripard 									   plane);
33437418bf1SMaxime Ripard 	struct drm_plane_state *new_state = drm_atomic_get_new_plane_state(state,
33537418bf1SMaxime Ripard 									   plane);
336e9cebe83SSinclair Yeh 	struct vmw_private *dev_priv;
337e9cebe83SSinclair Yeh 	struct vmw_legacy_display_unit *ldu;
338e9cebe83SSinclair Yeh 	struct vmw_framebuffer *vfb;
339e9cebe83SSinclair Yeh 	struct drm_framebuffer *fb;
340e05162c0SMaxime Ripard 	struct drm_crtc *crtc = new_state->crtc ?: old_state->crtc;
341e9cebe83SSinclair Yeh 
342e9cebe83SSinclair Yeh 	ldu = vmw_crtc_to_ldu(crtc);
343e9cebe83SSinclair Yeh 	dev_priv = vmw_priv(plane->dev);
344e05162c0SMaxime Ripard 	fb       = new_state->fb;
345e9cebe83SSinclair Yeh 
346e9cebe83SSinclair Yeh 	vfb = (fb) ? vmw_framebuffer_to_vfb(fb) : NULL;
347e9cebe83SSinclair Yeh 
348e9cebe83SSinclair Yeh 	if (vfb)
349e9cebe83SSinclair Yeh 		vmw_ldu_add_active(dev_priv, ldu, vfb);
350e9cebe83SSinclair Yeh 	else
351e9cebe83SSinclair Yeh 		vmw_ldu_del_active(dev_priv, ldu);
352e9cebe83SSinclair Yeh 
353e9cebe83SSinclair Yeh 	vmw_ldu_commit_list(dev_priv);
354*a37a512dSMartin Krastev 
355*a37a512dSMartin Krastev 	if (vfb && vmw_cmd_supported(dev_priv)) {
356*a37a512dSMartin Krastev 		struct drm_mode_rect fb_rect = {
357*a37a512dSMartin Krastev 			.x1 = 0,
358*a37a512dSMartin Krastev 			.y1 = 0,
359*a37a512dSMartin Krastev 			.x2 = vfb->base.width,
360*a37a512dSMartin Krastev 			.y2 = vfb->base.height
361*a37a512dSMartin Krastev 		};
362*a37a512dSMartin Krastev 		struct drm_mode_rect *damage_rects = drm_plane_get_damage_clips(new_state);
363*a37a512dSMartin Krastev 		u32 rect_count = drm_plane_get_damage_clips_count(new_state);
364*a37a512dSMartin Krastev 		int ret;
365*a37a512dSMartin Krastev 
366*a37a512dSMartin Krastev 		if (!damage_rects) {
367*a37a512dSMartin Krastev 			damage_rects = &fb_rect;
368*a37a512dSMartin Krastev 			rect_count = 1;
369060e2ad5SSinclair Yeh 		}
370060e2ad5SSinclair Yeh 
371*a37a512dSMartin Krastev 		ret = vmw_kms_ldu_do_bo_dirty(dev_priv, vfb, 0, 0, damage_rects, rect_count);
372*a37a512dSMartin Krastev 
373*a37a512dSMartin Krastev 		drm_WARN_ONCE(plane->dev, ret,
374*a37a512dSMartin Krastev 			"vmw_kms_ldu_do_bo_dirty failed with: ret=%d\n", ret);
375*a37a512dSMartin Krastev 
376*a37a512dSMartin Krastev 		vmw_cmd_flush(dev_priv, false);
377*a37a512dSMartin Krastev 	}
378*a37a512dSMartin Krastev }
379060e2ad5SSinclair Yeh 
38036cc79bcSSinclair Yeh static const struct drm_plane_funcs vmw_ldu_plane_funcs = {
381b0119cb9SSinclair Yeh 	.update_plane = drm_atomic_helper_update_plane,
382b0119cb9SSinclair Yeh 	.disable_plane = drm_atomic_helper_disable_plane,
38336cc79bcSSinclair Yeh 	.destroy = vmw_du_primary_plane_destroy,
384cc5ec459SSinclair Yeh 	.reset = vmw_du_plane_reset,
385cc5ec459SSinclair Yeh 	.atomic_duplicate_state = vmw_du_plane_duplicate_state,
386cc5ec459SSinclair Yeh 	.atomic_destroy_state = vmw_du_plane_destroy_state,
38736cc79bcSSinclair Yeh };
38836cc79bcSSinclair Yeh 
38936cc79bcSSinclair Yeh static const struct drm_plane_funcs vmw_ldu_cursor_funcs = {
390b0119cb9SSinclair Yeh 	.update_plane = drm_atomic_helper_update_plane,
391b0119cb9SSinclair Yeh 	.disable_plane = drm_atomic_helper_disable_plane,
39236cc79bcSSinclair Yeh 	.destroy = vmw_du_cursor_plane_destroy,
393cc5ec459SSinclair Yeh 	.reset = vmw_du_plane_reset,
394cc5ec459SSinclair Yeh 	.atomic_duplicate_state = vmw_du_plane_duplicate_state,
395cc5ec459SSinclair Yeh 	.atomic_destroy_state = vmw_du_plane_destroy_state,
39636cc79bcSSinclair Yeh };
39736cc79bcSSinclair Yeh 
39806ec4190SSinclair Yeh /*
39906ec4190SSinclair Yeh  * Atomic Helpers
40006ec4190SSinclair Yeh  */
401060e2ad5SSinclair Yeh static const struct
402060e2ad5SSinclair Yeh drm_plane_helper_funcs vmw_ldu_cursor_plane_helper_funcs = {
403060e2ad5SSinclair Yeh 	.atomic_check = vmw_du_cursor_plane_atomic_check,
404060e2ad5SSinclair Yeh 	.atomic_update = vmw_du_cursor_plane_atomic_update,
405060e2ad5SSinclair Yeh 	.prepare_fb = vmw_du_cursor_plane_prepare_fb,
406485d98d4SMartin Krastev 	.cleanup_fb = vmw_du_cursor_plane_cleanup_fb,
407060e2ad5SSinclair Yeh };
408060e2ad5SSinclair Yeh 
409060e2ad5SSinclair Yeh static const struct
410060e2ad5SSinclair Yeh drm_plane_helper_funcs vmw_ldu_primary_plane_helper_funcs = {
411060e2ad5SSinclair Yeh 	.atomic_check = vmw_du_primary_plane_atomic_check,
412060e2ad5SSinclair Yeh 	.atomic_update = vmw_ldu_primary_plane_atomic_update,
413060e2ad5SSinclair Yeh };
414060e2ad5SSinclair Yeh 
41506ec4190SSinclair Yeh static const struct drm_crtc_helper_funcs vmw_ldu_crtc_helper_funcs = {
41606ec4190SSinclair Yeh 	.mode_set_nofb = vmw_ldu_crtc_mode_set_nofb,
41706ec4190SSinclair Yeh 	.atomic_check = vmw_du_crtc_atomic_check,
41806ec4190SSinclair Yeh 	.atomic_begin = vmw_du_crtc_atomic_begin,
41906ec4190SSinclair Yeh 	.atomic_flush = vmw_du_crtc_atomic_flush,
4200b20a0f8SLaurent Pinchart 	.atomic_enable = vmw_ldu_crtc_atomic_enable,
42164581714SLaurent Pinchart 	.atomic_disable = vmw_ldu_crtc_atomic_disable,
42206ec4190SSinclair Yeh };
42306ec4190SSinclair Yeh 
42436cc79bcSSinclair Yeh 
vmw_ldu_init(struct vmw_private * dev_priv,unsigned unit)425fb1d9738SJakob Bornecrantz static int vmw_ldu_init(struct vmw_private *dev_priv, unsigned unit)
426fb1d9738SJakob Bornecrantz {
427fb1d9738SJakob Bornecrantz 	struct vmw_legacy_display_unit *ldu;
4289703bb32SZack Rusin 	struct drm_device *dev = &dev_priv->drm;
429fb1d9738SJakob Bornecrantz 	struct drm_connector *connector;
430fb1d9738SJakob Bornecrantz 	struct drm_encoder *encoder;
431485d98d4SMartin Krastev 	struct drm_plane *primary;
432485d98d4SMartin Krastev 	struct vmw_cursor_plane *cursor;
433fb1d9738SJakob Bornecrantz 	struct drm_crtc *crtc;
43436cc79bcSSinclair Yeh 	int ret;
435fb1d9738SJakob Bornecrantz 
436fb1d9738SJakob Bornecrantz 	ldu = kzalloc(sizeof(*ldu), GFP_KERNEL);
437fb1d9738SJakob Bornecrantz 	if (!ldu)
438fb1d9738SJakob Bornecrantz 		return -ENOMEM;
439fb1d9738SJakob Bornecrantz 
440bbfad336SJakob Bornecrantz 	ldu->base.unit = unit;
441fb1d9738SJakob Bornecrantz 	crtc = &ldu->base.crtc;
442fb1d9738SJakob Bornecrantz 	encoder = &ldu->base.encoder;
443fb1d9738SJakob Bornecrantz 	connector = &ldu->base.connector;
444cc5ec459SSinclair Yeh 	primary = &ldu->base.primary;
445cc5ec459SSinclair Yeh 	cursor = &ldu->base.cursor;
446fb1d9738SJakob Bornecrantz 
4471ae1ddd5SJakob Bornecrantz 	INIT_LIST_HEAD(&ldu->active);
4481ae1ddd5SJakob Bornecrantz 
449626ab771SJakob Bornecrantz 	ldu->base.pref_active = (unit == 0);
450eb4f923bSJakob Bornecrantz 	ldu->base.pref_width = dev_priv->initial_width;
451eb4f923bSJakob Bornecrantz 	ldu->base.pref_height = dev_priv->initial_height;
452626ab771SJakob Bornecrantz 	ldu->base.pref_mode = NULL;
4539c2542a4SSinclair Yeh 
4549c2542a4SSinclair Yeh 	/*
4559c2542a4SSinclair Yeh 	 * Remove this after enabling atomic because property values can
4569c2542a4SSinclair Yeh 	 * only exist in a state object
4579c2542a4SSinclair Yeh 	 */
4586987427aSThomas Hellstrom 	ldu->base.is_implicit = true;
459d8bd19d2SJakob Bornecrantz 
46036cc79bcSSinclair Yeh 	/* Initialize primary plane */
461485d98d4SMartin Krastev 	ret = drm_universal_plane_init(dev, primary,
46236cc79bcSSinclair Yeh 				       0, &vmw_ldu_plane_funcs,
46336cc79bcSSinclair Yeh 				       vmw_primary_plane_formats,
46436cc79bcSSinclair Yeh 				       ARRAY_SIZE(vmw_primary_plane_formats),
465e6fc3b68SBen Widawsky 				       NULL, DRM_PLANE_TYPE_PRIMARY, NULL);
46636cc79bcSSinclair Yeh 	if (ret) {
46736cc79bcSSinclair Yeh 		DRM_ERROR("Failed to initialize primary plane");
46836cc79bcSSinclair Yeh 		goto err_free;
46936cc79bcSSinclair Yeh 	}
47036cc79bcSSinclair Yeh 
471060e2ad5SSinclair Yeh 	drm_plane_helper_add(primary, &vmw_ldu_primary_plane_helper_funcs);
472060e2ad5SSinclair Yeh 
4732cd80dbdSZack Rusin 	/*
4742cd80dbdSZack Rusin 	 * We're going to be using traces and software cursors
4752cd80dbdSZack Rusin 	 */
4762cd80dbdSZack Rusin 	if (vmw_cmd_supported(dev_priv)) {
47736cc79bcSSinclair Yeh 		/* Initialize cursor plane */
478485d98d4SMartin Krastev 		ret = drm_universal_plane_init(dev, &cursor->base,
47936cc79bcSSinclair Yeh 					       0, &vmw_ldu_cursor_funcs,
48036cc79bcSSinclair Yeh 					       vmw_cursor_plane_formats,
48136cc79bcSSinclair Yeh 					       ARRAY_SIZE(vmw_cursor_plane_formats),
482e6fc3b68SBen Widawsky 					       NULL, DRM_PLANE_TYPE_CURSOR, NULL);
48336cc79bcSSinclair Yeh 		if (ret) {
48436cc79bcSSinclair Yeh 			DRM_ERROR("Failed to initialize cursor plane");
48536cc79bcSSinclair Yeh 			drm_plane_cleanup(&ldu->base.primary);
48636cc79bcSSinclair Yeh 			goto err_free;
48736cc79bcSSinclair Yeh 		}
48836cc79bcSSinclair Yeh 
489485d98d4SMartin Krastev 		drm_plane_helper_add(&cursor->base, &vmw_ldu_cursor_plane_helper_funcs);
4902cd80dbdSZack Rusin 	}
491060e2ad5SSinclair Yeh 
49236cc79bcSSinclair Yeh 	ret = drm_connector_init(dev, connector, &vmw_legacy_connector_funcs,
493305151e3SThomas Hellstrom 				 DRM_MODE_CONNECTOR_VIRTUAL);
49436cc79bcSSinclair Yeh 	if (ret) {
49536cc79bcSSinclair Yeh 		DRM_ERROR("Failed to initialize connector\n");
49636cc79bcSSinclair Yeh 		goto err_free;
49736cc79bcSSinclair Yeh 	}
498d947d1b7SSinclair Yeh 
499d947d1b7SSinclair Yeh 	drm_connector_helper_add(connector, &vmw_ldu_connector_helper_funcs);
500626ab771SJakob Bornecrantz 	connector->status = vmw_du_connector_detect(connector, true);
501fb1d9738SJakob Bornecrantz 
50236cc79bcSSinclair Yeh 	ret = drm_encoder_init(dev, encoder, &vmw_legacy_encoder_funcs,
50313a3d91fSVille Syrjälä 			       DRM_MODE_ENCODER_VIRTUAL, NULL);
50436cc79bcSSinclair Yeh 	if (ret) {
50536cc79bcSSinclair Yeh 		DRM_ERROR("Failed to initialize encoder\n");
50636cc79bcSSinclair Yeh 		goto err_free_connector;
50736cc79bcSSinclair Yeh 	}
50836cc79bcSSinclair Yeh 
509cde4c44dSDaniel Vetter 	(void) drm_connector_attach_encoder(connector, encoder);
510fb1d9738SJakob Bornecrantz 	encoder->possible_crtcs = (1 << unit);
511fb1d9738SJakob Bornecrantz 	encoder->possible_clones = 0;
512fb1d9738SJakob Bornecrantz 
51336cc79bcSSinclair Yeh 	ret = drm_connector_register(connector);
51436cc79bcSSinclair Yeh 	if (ret) {
51536cc79bcSSinclair Yeh 		DRM_ERROR("Failed to register connector\n");
51636cc79bcSSinclair Yeh 		goto err_free_encoder;
51736cc79bcSSinclair Yeh 	}
5186a0a7a9eSThomas Hellstrom 
519485d98d4SMartin Krastev 	ret = drm_crtc_init_with_planes(dev, crtc, primary,
520485d98d4SMartin Krastev 		      vmw_cmd_supported(dev_priv) ? &cursor->base : NULL,
52136cc79bcSSinclair Yeh 		      &vmw_legacy_crtc_funcs, NULL);
52236cc79bcSSinclair Yeh 	if (ret) {
52336cc79bcSSinclair Yeh 		DRM_ERROR("Failed to initialize CRTC\n");
52436cc79bcSSinclair Yeh 		goto err_free_unregister;
52536cc79bcSSinclair Yeh 	}
526fb1d9738SJakob Bornecrantz 
52706ec4190SSinclair Yeh 	drm_crtc_helper_add(crtc, &vmw_ldu_crtc_helper_funcs);
52806ec4190SSinclair Yeh 
529f01b7ba0SMichel Dänzer 	drm_mode_crtc_set_gamma_size(crtc, 256);
530f01b7ba0SMichel Dänzer 
531b8b163baSRob Clark 	drm_object_attach_property(&connector->base,
532578e609aSThomas Hellstrom 				   dev_priv->hotplug_mode_update_property, 1);
533578e609aSThomas Hellstrom 	drm_object_attach_property(&connector->base,
534578e609aSThomas Hellstrom 				   dev->mode_config.suggested_x_property, 0);
535578e609aSThomas Hellstrom 	drm_object_attach_property(&connector->base,
536578e609aSThomas Hellstrom 				   dev->mode_config.suggested_y_property, 0);
53776404ac0SThomas Hellstrom 	if (dev_priv->implicit_placement_property)
53876404ac0SThomas Hellstrom 		drm_object_attach_property
53976404ac0SThomas Hellstrom 			(&connector->base,
54076404ac0SThomas Hellstrom 			 dev_priv->implicit_placement_property,
54176404ac0SThomas Hellstrom 			 1);
542fb1d9738SJakob Bornecrantz 
543fb1d9738SJakob Bornecrantz 	return 0;
54436cc79bcSSinclair Yeh 
54536cc79bcSSinclair Yeh err_free_unregister:
54636cc79bcSSinclair Yeh 	drm_connector_unregister(connector);
54736cc79bcSSinclair Yeh err_free_encoder:
54836cc79bcSSinclair Yeh 	drm_encoder_cleanup(encoder);
54936cc79bcSSinclair Yeh err_free_connector:
55036cc79bcSSinclair Yeh 	drm_connector_cleanup(connector);
55136cc79bcSSinclair Yeh err_free:
55236cc79bcSSinclair Yeh 	kfree(ldu);
55336cc79bcSSinclair Yeh 	return ret;
554fb1d9738SJakob Bornecrantz }
555fb1d9738SJakob Bornecrantz 
vmw_kms_ldu_init_display(struct vmw_private * dev_priv)556c8261a96SSinclair Yeh int vmw_kms_ldu_init_display(struct vmw_private *dev_priv)
557fb1d9738SJakob Bornecrantz {
5589703bb32SZack Rusin 	struct drm_device *dev = &dev_priv->drm;
55974b5ea30SJakob Bornecrantz 	int i, ret;
560bb30d8d8SZack Rusin 	int num_display_units = (dev_priv->capabilities & SVGA_CAP_MULTIMON) ?
561bb30d8d8SZack Rusin 					VMWGFX_NUM_DISPLAY_UNITS : 1;
5627a1c2f6cSThomas Hellstrom 
5632b273544SZack Rusin 	if (unlikely(dev_priv->ldu_priv)) {
564fb1d9738SJakob Bornecrantz 		return -EINVAL;
565fb1d9738SJakob Bornecrantz 	}
566fb1d9738SJakob Bornecrantz 
56785b54e0cSJoe Perches 	dev_priv->ldu_priv = kmalloc(sizeof(*dev_priv->ldu_priv), GFP_KERNEL);
568fb1d9738SJakob Bornecrantz 	if (!dev_priv->ldu_priv)
569fb1d9738SJakob Bornecrantz 		return -ENOMEM;
570fb1d9738SJakob Bornecrantz 
571fb1d9738SJakob Bornecrantz 	INIT_LIST_HEAD(&dev_priv->ldu_priv->active);
572fb1d9738SJakob Bornecrantz 	dev_priv->ldu_priv->num_active = 0;
573d7e1958dSJakob Bornecrantz 	dev_priv->ldu_priv->last_num_active = 0;
574fb1d9738SJakob Bornecrantz 	dev_priv->ldu_priv->fb = NULL;
575fb1d9738SJakob Bornecrantz 
5769d9486e4SThomas Hellstrom 	vmw_kms_create_implicit_placement_property(dev_priv);
57776404ac0SThomas Hellstrom 
578bb30d8d8SZack Rusin 	for (i = 0; i < num_display_units; ++i) {
579bb30d8d8SZack Rusin 		ret = vmw_ldu_init(dev_priv, i);
580bb30d8d8SZack Rusin 		if (ret != 0)
581bb30d8d8SZack Rusin 			goto err_free;
582bb30d8d8SZack Rusin 	}
583fb1d9738SJakob Bornecrantz 
584c8261a96SSinclair Yeh 	dev_priv->active_display_unit = vmw_du_legacy;
585c8261a96SSinclair Yeh 
58698124337SRoland Scheidegger 	drm_mode_config_reset(dev);
58798124337SRoland Scheidegger 
58860a16a30SJakob Bornecrantz 	return 0;
58960a16a30SJakob Bornecrantz 
59060a16a30SJakob Bornecrantz err_free:
59160a16a30SJakob Bornecrantz 	kfree(dev_priv->ldu_priv);
59260a16a30SJakob Bornecrantz 	dev_priv->ldu_priv = NULL;
5937a1c2f6cSThomas Hellstrom 	return ret;
594fb1d9738SJakob Bornecrantz }
595fb1d9738SJakob Bornecrantz 
vmw_kms_ldu_close_display(struct vmw_private * dev_priv)596c8261a96SSinclair Yeh int vmw_kms_ldu_close_display(struct vmw_private *dev_priv)
597fb1d9738SJakob Bornecrantz {
598fb1d9738SJakob Bornecrantz 	if (!dev_priv->ldu_priv)
599fb1d9738SJakob Bornecrantz 		return -ENOSYS;
600fb1d9738SJakob Bornecrantz 
601fb1d9738SJakob Bornecrantz 	BUG_ON(!list_empty(&dev_priv->ldu_priv->active));
602fb1d9738SJakob Bornecrantz 
603fb1d9738SJakob Bornecrantz 	kfree(dev_priv->ldu_priv);
604fb1d9738SJakob Bornecrantz 
605fb1d9738SJakob Bornecrantz 	return 0;
606fb1d9738SJakob Bornecrantz }
607c8261a96SSinclair Yeh 
608c8261a96SSinclair Yeh 
vmw_kms_ldu_do_bo_dirty(struct vmw_private * dev_priv,struct vmw_framebuffer * framebuffer,unsigned int flags,unsigned int color,struct drm_mode_rect * clips,unsigned int num_clips)609*a37a512dSMartin Krastev static int vmw_kms_ldu_do_bo_dirty(struct vmw_private *dev_priv,
610c8261a96SSinclair Yeh 				   struct vmw_framebuffer *framebuffer,
611f1d34bfdSThomas Hellstrom 				   unsigned int flags, unsigned int color,
612*a37a512dSMartin Krastev 				   struct drm_mode_rect *clips,
613*a37a512dSMartin Krastev 				   unsigned int num_clips)
614c8261a96SSinclair Yeh {
615c8261a96SSinclair Yeh 	size_t fifo_size;
616c8261a96SSinclair Yeh 	int i;
617c8261a96SSinclair Yeh 
618c8261a96SSinclair Yeh 	struct {
619c8261a96SSinclair Yeh 		uint32_t header;
620c8261a96SSinclair Yeh 		SVGAFifoCmdUpdate body;
621c8261a96SSinclair Yeh 	} *cmd;
622c8261a96SSinclair Yeh 
623c8261a96SSinclair Yeh 	fifo_size = sizeof(*cmd) * num_clips;
6248426ed9cSZack Rusin 	cmd = VMW_CMD_RESERVE(dev_priv, fifo_size);
62511c45419SDeepak Rawat 	if (unlikely(cmd == NULL))
626c8261a96SSinclair Yeh 		return -ENOMEM;
627c8261a96SSinclair Yeh 
628c8261a96SSinclair Yeh 	memset(cmd, 0, fifo_size);
629*a37a512dSMartin Krastev 	for (i = 0; i < num_clips; i++, clips++) {
630b9eb1a61SThomas Hellstrom 		cmd[i].header = SVGA_CMD_UPDATE;
631b9eb1a61SThomas Hellstrom 		cmd[i].body.x = clips->x1;
632b9eb1a61SThomas Hellstrom 		cmd[i].body.y = clips->y1;
633b9eb1a61SThomas Hellstrom 		cmd[i].body.width = clips->x2 - clips->x1;
634b9eb1a61SThomas Hellstrom 		cmd[i].body.height = clips->y2 - clips->y1;
635c8261a96SSinclair Yeh 	}
636c8261a96SSinclair Yeh 
6378426ed9cSZack Rusin 	vmw_cmd_commit(dev_priv, fifo_size);
638c8261a96SSinclair Yeh 	return 0;
639c8261a96SSinclair Yeh }
640