xref: /openbmc/linux/drivers/gpu/drm/vc4/vc4_kms.c (revision 3454f01a)
1d2912cb1SThomas Gleixner // SPDX-License-Identifier: GPL-2.0-only
2c8b75bcaSEric Anholt /*
3c8b75bcaSEric Anholt  * Copyright (C) 2015 Broadcom
4c8b75bcaSEric Anholt  */
5c8b75bcaSEric Anholt 
6c8b75bcaSEric Anholt /**
7c8b75bcaSEric Anholt  * DOC: VC4 KMS
8c8b75bcaSEric Anholt  *
9c8b75bcaSEric Anholt  * This is the general code for implementing KMS mode setting that
10c8b75bcaSEric Anholt  * doesn't clearly associate with any of the other objects (plane,
11c8b75bcaSEric Anholt  * crtc, HDMI encoder).
12c8b75bcaSEric Anholt  */
13c8b75bcaSEric Anholt 
14d7d96c00SMaxime Ripard #include <linux/clk.h>
15d7d96c00SMaxime Ripard 
16b7e8e25bSMasahiro Yamada #include <drm/drm_atomic.h>
17b7e8e25bSMasahiro Yamada #include <drm/drm_atomic_helper.h>
18fd6d6d80SSam Ravnborg #include <drm/drm_crtc.h>
199762477cSNoralf Trønnes #include <drm/drm_gem_framebuffer_helper.h>
20fcd70cd3SDaniel Vetter #include <drm/drm_plane_helper.h>
21fcd70cd3SDaniel Vetter #include <drm/drm_probe_helper.h>
22fd6d6d80SSam Ravnborg #include <drm/drm_vblank.h>
23fd6d6d80SSam Ravnborg 
24c8b75bcaSEric Anholt #include "vc4_drv.h"
25766cc6b1SStefan Schake #include "vc4_regs.h"
26766cc6b1SStefan Schake 
27a9661f27SMaxime Ripard #define HVS_NUM_CHANNELS 3
28a9661f27SMaxime Ripard 
29766cc6b1SStefan Schake struct vc4_ctm_state {
30766cc6b1SStefan Schake 	struct drm_private_state base;
31766cc6b1SStefan Schake 	struct drm_color_ctm *ctm;
32766cc6b1SStefan Schake 	int fifo;
33766cc6b1SStefan Schake };
34766cc6b1SStefan Schake 
35220f125cSMaxime Ripard static struct vc4_ctm_state *
36220f125cSMaxime Ripard to_vc4_ctm_state(const struct drm_private_state *priv)
37766cc6b1SStefan Schake {
38766cc6b1SStefan Schake 	return container_of(priv, struct vc4_ctm_state, base);
39766cc6b1SStefan Schake }
40766cc6b1SStefan Schake 
41f2df84e0SMaxime Ripard struct vc4_hvs_state {
42f2df84e0SMaxime Ripard 	struct drm_private_state base;
4316e10105SMaxime Ripard 	unsigned long core_clock_rate;
449ec03d7fSMaxime Ripard 
459ec03d7fSMaxime Ripard 	struct {
469ec03d7fSMaxime Ripard 		unsigned in_use: 1;
4716e10105SMaxime Ripard 		unsigned long fifo_load;
489ec03d7fSMaxime Ripard 		struct drm_crtc_commit *pending_commit;
499ec03d7fSMaxime Ripard 	} fifo_state[HVS_NUM_CHANNELS];
50f2df84e0SMaxime Ripard };
51f2df84e0SMaxime Ripard 
52f2df84e0SMaxime Ripard static struct vc4_hvs_state *
53220f125cSMaxime Ripard to_vc4_hvs_state(const struct drm_private_state *priv)
54f2df84e0SMaxime Ripard {
55f2df84e0SMaxime Ripard 	return container_of(priv, struct vc4_hvs_state, base);
56f2df84e0SMaxime Ripard }
57f2df84e0SMaxime Ripard 
584686da83SBoris Brezillon struct vc4_load_tracker_state {
594686da83SBoris Brezillon 	struct drm_private_state base;
604686da83SBoris Brezillon 	u64 hvs_load;
614686da83SBoris Brezillon 	u64 membus_load;
624686da83SBoris Brezillon };
634686da83SBoris Brezillon 
644686da83SBoris Brezillon static struct vc4_load_tracker_state *
65220f125cSMaxime Ripard to_vc4_load_tracker_state(const struct drm_private_state *priv)
664686da83SBoris Brezillon {
674686da83SBoris Brezillon 	return container_of(priv, struct vc4_load_tracker_state, base);
684686da83SBoris Brezillon }
694686da83SBoris Brezillon 
70766cc6b1SStefan Schake static struct vc4_ctm_state *vc4_get_ctm_state(struct drm_atomic_state *state,
71766cc6b1SStefan Schake 					       struct drm_private_obj *manager)
72766cc6b1SStefan Schake {
73766cc6b1SStefan Schake 	struct drm_device *dev = state->dev;
7488e08589SMaxime Ripard 	struct vc4_dev *vc4 = to_vc4_dev(dev);
75766cc6b1SStefan Schake 	struct drm_private_state *priv_state;
76766cc6b1SStefan Schake 	int ret;
77766cc6b1SStefan Schake 
78766cc6b1SStefan Schake 	ret = drm_modeset_lock(&vc4->ctm_state_lock, state->acquire_ctx);
79766cc6b1SStefan Schake 	if (ret)
80766cc6b1SStefan Schake 		return ERR_PTR(ret);
81766cc6b1SStefan Schake 
82766cc6b1SStefan Schake 	priv_state = drm_atomic_get_private_obj_state(state, manager);
83766cc6b1SStefan Schake 	if (IS_ERR(priv_state))
84766cc6b1SStefan Schake 		return ERR_CAST(priv_state);
85766cc6b1SStefan Schake 
86766cc6b1SStefan Schake 	return to_vc4_ctm_state(priv_state);
87766cc6b1SStefan Schake }
88766cc6b1SStefan Schake 
89766cc6b1SStefan Schake static struct drm_private_state *
90766cc6b1SStefan Schake vc4_ctm_duplicate_state(struct drm_private_obj *obj)
91766cc6b1SStefan Schake {
92766cc6b1SStefan Schake 	struct vc4_ctm_state *state;
93766cc6b1SStefan Schake 
94766cc6b1SStefan Schake 	state = kmemdup(obj->state, sizeof(*state), GFP_KERNEL);
95766cc6b1SStefan Schake 	if (!state)
96766cc6b1SStefan Schake 		return NULL;
97766cc6b1SStefan Schake 
98766cc6b1SStefan Schake 	__drm_atomic_helper_private_obj_duplicate_state(obj, &state->base);
99766cc6b1SStefan Schake 
100766cc6b1SStefan Schake 	return &state->base;
101766cc6b1SStefan Schake }
102766cc6b1SStefan Schake 
103766cc6b1SStefan Schake static void vc4_ctm_destroy_state(struct drm_private_obj *obj,
104766cc6b1SStefan Schake 				  struct drm_private_state *state)
105766cc6b1SStefan Schake {
106766cc6b1SStefan Schake 	struct vc4_ctm_state *ctm_state = to_vc4_ctm_state(state);
107766cc6b1SStefan Schake 
108766cc6b1SStefan Schake 	kfree(ctm_state);
109766cc6b1SStefan Schake }
110766cc6b1SStefan Schake 
111766cc6b1SStefan Schake static const struct drm_private_state_funcs vc4_ctm_state_funcs = {
112766cc6b1SStefan Schake 	.atomic_duplicate_state = vc4_ctm_duplicate_state,
113766cc6b1SStefan Schake 	.atomic_destroy_state = vc4_ctm_destroy_state,
114766cc6b1SStefan Schake };
115766cc6b1SStefan Schake 
116dcda7c28SMaxime Ripard static void vc4_ctm_obj_fini(struct drm_device *dev, void *unused)
117dcda7c28SMaxime Ripard {
118dcda7c28SMaxime Ripard 	struct vc4_dev *vc4 = to_vc4_dev(dev);
119dcda7c28SMaxime Ripard 
120dcda7c28SMaxime Ripard 	drm_atomic_private_obj_fini(&vc4->ctm_manager);
121dcda7c28SMaxime Ripard }
122dcda7c28SMaxime Ripard 
123dcda7c28SMaxime Ripard static int vc4_ctm_obj_init(struct vc4_dev *vc4)
124dcda7c28SMaxime Ripard {
125dcda7c28SMaxime Ripard 	struct vc4_ctm_state *ctm_state;
126dcda7c28SMaxime Ripard 
127dcda7c28SMaxime Ripard 	drm_modeset_lock_init(&vc4->ctm_state_lock);
128dcda7c28SMaxime Ripard 
129dcda7c28SMaxime Ripard 	ctm_state = kzalloc(sizeof(*ctm_state), GFP_KERNEL);
130dcda7c28SMaxime Ripard 	if (!ctm_state)
131dcda7c28SMaxime Ripard 		return -ENOMEM;
132dcda7c28SMaxime Ripard 
133dcda7c28SMaxime Ripard 	drm_atomic_private_obj_init(&vc4->base, &vc4->ctm_manager, &ctm_state->base,
134dcda7c28SMaxime Ripard 				    &vc4_ctm_state_funcs);
135dcda7c28SMaxime Ripard 
1363c354ed1SMaxime Ripard 	return drmm_add_action_or_reset(&vc4->base, vc4_ctm_obj_fini, NULL);
137dcda7c28SMaxime Ripard }
138dcda7c28SMaxime Ripard 
139766cc6b1SStefan Schake /* Converts a DRM S31.32 value to the HW S0.9 format. */
140766cc6b1SStefan Schake static u16 vc4_ctm_s31_32_to_s0_9(u64 in)
141766cc6b1SStefan Schake {
142766cc6b1SStefan Schake 	u16 r;
143766cc6b1SStefan Schake 
144766cc6b1SStefan Schake 	/* Sign bit. */
145766cc6b1SStefan Schake 	r = in & BIT_ULL(63) ? BIT(9) : 0;
146766cc6b1SStefan Schake 
147766cc6b1SStefan Schake 	if ((in & GENMASK_ULL(62, 32)) > 0) {
148766cc6b1SStefan Schake 		/* We have zero integer bits so we can only saturate here. */
149766cc6b1SStefan Schake 		r |= GENMASK(8, 0);
150766cc6b1SStefan Schake 	} else {
151766cc6b1SStefan Schake 		/* Otherwise take the 9 most important fractional bits. */
152766cc6b1SStefan Schake 		r |= (in >> 23) & GENMASK(8, 0);
153766cc6b1SStefan Schake 	}
154766cc6b1SStefan Schake 
155766cc6b1SStefan Schake 	return r;
156766cc6b1SStefan Schake }
157766cc6b1SStefan Schake 
158766cc6b1SStefan Schake static void
159766cc6b1SStefan Schake vc4_ctm_commit(struct vc4_dev *vc4, struct drm_atomic_state *state)
160766cc6b1SStefan Schake {
161*3454f01aSMaxime Ripard 	struct vc4_hvs *hvs = vc4->hvs;
162766cc6b1SStefan Schake 	struct vc4_ctm_state *ctm_state = to_vc4_ctm_state(vc4->ctm_manager.state);
163766cc6b1SStefan Schake 	struct drm_color_ctm *ctm = ctm_state->ctm;
164766cc6b1SStefan Schake 
165766cc6b1SStefan Schake 	if (ctm_state->fifo) {
166766cc6b1SStefan Schake 		HVS_WRITE(SCALER_OLEDCOEF2,
167766cc6b1SStefan Schake 			  VC4_SET_FIELD(vc4_ctm_s31_32_to_s0_9(ctm->matrix[0]),
168766cc6b1SStefan Schake 					SCALER_OLEDCOEF2_R_TO_R) |
169766cc6b1SStefan Schake 			  VC4_SET_FIELD(vc4_ctm_s31_32_to_s0_9(ctm->matrix[3]),
170766cc6b1SStefan Schake 					SCALER_OLEDCOEF2_R_TO_G) |
171766cc6b1SStefan Schake 			  VC4_SET_FIELD(vc4_ctm_s31_32_to_s0_9(ctm->matrix[6]),
172766cc6b1SStefan Schake 					SCALER_OLEDCOEF2_R_TO_B));
173766cc6b1SStefan Schake 		HVS_WRITE(SCALER_OLEDCOEF1,
174766cc6b1SStefan Schake 			  VC4_SET_FIELD(vc4_ctm_s31_32_to_s0_9(ctm->matrix[1]),
175766cc6b1SStefan Schake 					SCALER_OLEDCOEF1_G_TO_R) |
176766cc6b1SStefan Schake 			  VC4_SET_FIELD(vc4_ctm_s31_32_to_s0_9(ctm->matrix[4]),
177766cc6b1SStefan Schake 					SCALER_OLEDCOEF1_G_TO_G) |
178766cc6b1SStefan Schake 			  VC4_SET_FIELD(vc4_ctm_s31_32_to_s0_9(ctm->matrix[7]),
179766cc6b1SStefan Schake 					SCALER_OLEDCOEF1_G_TO_B));
180766cc6b1SStefan Schake 		HVS_WRITE(SCALER_OLEDCOEF0,
181766cc6b1SStefan Schake 			  VC4_SET_FIELD(vc4_ctm_s31_32_to_s0_9(ctm->matrix[2]),
182766cc6b1SStefan Schake 					SCALER_OLEDCOEF0_B_TO_R) |
183766cc6b1SStefan Schake 			  VC4_SET_FIELD(vc4_ctm_s31_32_to_s0_9(ctm->matrix[5]),
184766cc6b1SStefan Schake 					SCALER_OLEDCOEF0_B_TO_G) |
185766cc6b1SStefan Schake 			  VC4_SET_FIELD(vc4_ctm_s31_32_to_s0_9(ctm->matrix[8]),
186766cc6b1SStefan Schake 					SCALER_OLEDCOEF0_B_TO_B));
187766cc6b1SStefan Schake 	}
188766cc6b1SStefan Schake 
189766cc6b1SStefan Schake 	HVS_WRITE(SCALER_OLEDOFFS,
190766cc6b1SStefan Schake 		  VC4_SET_FIELD(ctm_state->fifo, SCALER_OLEDOFFS_DISPFIFO));
191766cc6b1SStefan Schake }
192c8b75bcaSEric Anholt 
193f2df84e0SMaxime Ripard static struct vc4_hvs_state *
1949ec03d7fSMaxime Ripard vc4_hvs_get_new_global_state(struct drm_atomic_state *state)
1959ec03d7fSMaxime Ripard {
1969ec03d7fSMaxime Ripard 	struct vc4_dev *vc4 = to_vc4_dev(state->dev);
1979ec03d7fSMaxime Ripard 	struct drm_private_state *priv_state;
1989ec03d7fSMaxime Ripard 
1999ec03d7fSMaxime Ripard 	priv_state = drm_atomic_get_new_private_obj_state(state, &vc4->hvs_channels);
2009ec03d7fSMaxime Ripard 	if (IS_ERR(priv_state))
2019ec03d7fSMaxime Ripard 		return ERR_CAST(priv_state);
2029ec03d7fSMaxime Ripard 
2039ec03d7fSMaxime Ripard 	return to_vc4_hvs_state(priv_state);
2049ec03d7fSMaxime Ripard }
2059ec03d7fSMaxime Ripard 
2069ec03d7fSMaxime Ripard static struct vc4_hvs_state *
2079ec03d7fSMaxime Ripard vc4_hvs_get_old_global_state(struct drm_atomic_state *state)
2089ec03d7fSMaxime Ripard {
2099ec03d7fSMaxime Ripard 	struct vc4_dev *vc4 = to_vc4_dev(state->dev);
2109ec03d7fSMaxime Ripard 	struct drm_private_state *priv_state;
2119ec03d7fSMaxime Ripard 
2129ec03d7fSMaxime Ripard 	priv_state = drm_atomic_get_old_private_obj_state(state, &vc4->hvs_channels);
2139ec03d7fSMaxime Ripard 	if (IS_ERR(priv_state))
2149ec03d7fSMaxime Ripard 		return ERR_CAST(priv_state);
2159ec03d7fSMaxime Ripard 
2169ec03d7fSMaxime Ripard 	return to_vc4_hvs_state(priv_state);
2179ec03d7fSMaxime Ripard }
2189ec03d7fSMaxime Ripard 
2199ec03d7fSMaxime Ripard static struct vc4_hvs_state *
220f2df84e0SMaxime Ripard vc4_hvs_get_global_state(struct drm_atomic_state *state)
221f2df84e0SMaxime Ripard {
222f2df84e0SMaxime Ripard 	struct vc4_dev *vc4 = to_vc4_dev(state->dev);
223f2df84e0SMaxime Ripard 	struct drm_private_state *priv_state;
224f2df84e0SMaxime Ripard 
225f2df84e0SMaxime Ripard 	priv_state = drm_atomic_get_private_obj_state(state, &vc4->hvs_channels);
226f2df84e0SMaxime Ripard 	if (IS_ERR(priv_state))
227f2df84e0SMaxime Ripard 		return ERR_CAST(priv_state);
228f2df84e0SMaxime Ripard 
229f2df84e0SMaxime Ripard 	return to_vc4_hvs_state(priv_state);
230f2df84e0SMaxime Ripard }
231f2df84e0SMaxime Ripard 
23287ebcd42SMaxime Ripard static void vc4_hvs_pv_muxing_commit(struct vc4_dev *vc4,
23387ebcd42SMaxime Ripard 				     struct drm_atomic_state *state)
23487ebcd42SMaxime Ripard {
235*3454f01aSMaxime Ripard 	struct vc4_hvs *hvs = vc4->hvs;
23687ebcd42SMaxime Ripard 	struct drm_crtc_state *crtc_state;
23787ebcd42SMaxime Ripard 	struct drm_crtc *crtc;
23887ebcd42SMaxime Ripard 	unsigned int i;
23987ebcd42SMaxime Ripard 
24087ebcd42SMaxime Ripard 	for_each_new_crtc_in_state(state, crtc, crtc_state, i) {
241a16c6640SMaxime Ripard 		struct vc4_crtc *vc4_crtc = to_vc4_crtc(crtc);
24287ebcd42SMaxime Ripard 		struct vc4_crtc_state *vc4_state = to_vc4_crtc_state(crtc_state);
24387ebcd42SMaxime Ripard 		u32 dispctrl;
24487ebcd42SMaxime Ripard 		u32 dsp3_mux;
24587ebcd42SMaxime Ripard 
24687ebcd42SMaxime Ripard 		if (!crtc_state->active)
24787ebcd42SMaxime Ripard 			continue;
24887ebcd42SMaxime Ripard 
24987ebcd42SMaxime Ripard 		if (vc4_state->assigned_channel != 2)
25087ebcd42SMaxime Ripard 			continue;
25187ebcd42SMaxime Ripard 
25287ebcd42SMaxime Ripard 		/*
25387ebcd42SMaxime Ripard 		 * SCALER_DISPCTRL_DSP3 = X, where X < 2 means 'connect DSP3 to
25487ebcd42SMaxime Ripard 		 * FIFO X'.
25587ebcd42SMaxime Ripard 		 * SCALER_DISPCTRL_DSP3 = 3 means 'disable DSP 3'.
25687ebcd42SMaxime Ripard 		 *
25787ebcd42SMaxime Ripard 		 * DSP3 is connected to FIFO2 unless the transposer is
25887ebcd42SMaxime Ripard 		 * enabled. In this case, FIFO 2 is directly accessed by the
25987ebcd42SMaxime Ripard 		 * TXP IP, and we need to disable the FIFO2 -> pixelvalve1
26087ebcd42SMaxime Ripard 		 * route.
26187ebcd42SMaxime Ripard 		 */
262a16c6640SMaxime Ripard 		if (vc4_crtc->feeds_txp)
26387ebcd42SMaxime Ripard 			dsp3_mux = VC4_SET_FIELD(3, SCALER_DISPCTRL_DSP3_MUX);
26487ebcd42SMaxime Ripard 		else
26587ebcd42SMaxime Ripard 			dsp3_mux = VC4_SET_FIELD(2, SCALER_DISPCTRL_DSP3_MUX);
26687ebcd42SMaxime Ripard 
26787ebcd42SMaxime Ripard 		dispctrl = HVS_READ(SCALER_DISPCTRL) &
26887ebcd42SMaxime Ripard 			   ~SCALER_DISPCTRL_DSP3_MUX_MASK;
26987ebcd42SMaxime Ripard 		HVS_WRITE(SCALER_DISPCTRL, dispctrl | dsp3_mux);
27087ebcd42SMaxime Ripard 	}
27187ebcd42SMaxime Ripard }
27287ebcd42SMaxime Ripard 
27387ebcd42SMaxime Ripard static void vc5_hvs_pv_muxing_commit(struct vc4_dev *vc4,
27487ebcd42SMaxime Ripard 				     struct drm_atomic_state *state)
27587ebcd42SMaxime Ripard {
276*3454f01aSMaxime Ripard 	struct vc4_hvs *hvs = vc4->hvs;
27787ebcd42SMaxime Ripard 	struct drm_crtc_state *crtc_state;
27887ebcd42SMaxime Ripard 	struct drm_crtc *crtc;
2792820526dSMaxime Ripard 	unsigned char mux;
28087ebcd42SMaxime Ripard 	unsigned int i;
28187ebcd42SMaxime Ripard 	u32 reg;
28287ebcd42SMaxime Ripard 
28387ebcd42SMaxime Ripard 	for_each_new_crtc_in_state(state, crtc, crtc_state, i) {
28487ebcd42SMaxime Ripard 		struct vc4_crtc_state *vc4_state = to_vc4_crtc_state(crtc_state);
28587ebcd42SMaxime Ripard 		struct vc4_crtc *vc4_crtc = to_vc4_crtc(crtc);
28687ebcd42SMaxime Ripard 
2872820526dSMaxime Ripard 		if (!vc4_state->update_muxing)
28887ebcd42SMaxime Ripard 			continue;
28987ebcd42SMaxime Ripard 
29087ebcd42SMaxime Ripard 		switch (vc4_crtc->data->hvs_output) {
29187ebcd42SMaxime Ripard 		case 2:
2922820526dSMaxime Ripard 			mux = (vc4_state->assigned_channel == 2) ? 0 : 1;
2932820526dSMaxime Ripard 			reg = HVS_READ(SCALER_DISPECTRL);
2942820526dSMaxime Ripard 			HVS_WRITE(SCALER_DISPECTRL,
2952820526dSMaxime Ripard 				  (reg & ~SCALER_DISPECTRL_DSP2_MUX_MASK) |
2962820526dSMaxime Ripard 				  VC4_SET_FIELD(mux, SCALER_DISPECTRL_DSP2_MUX));
29787ebcd42SMaxime Ripard 			break;
29887ebcd42SMaxime Ripard 
29987ebcd42SMaxime Ripard 		case 3:
3002820526dSMaxime Ripard 			if (vc4_state->assigned_channel == VC4_HVS_CHANNEL_DISABLED)
3012820526dSMaxime Ripard 				mux = 3;
3022820526dSMaxime Ripard 			else
3032820526dSMaxime Ripard 				mux = vc4_state->assigned_channel;
3042820526dSMaxime Ripard 
3052820526dSMaxime Ripard 			reg = HVS_READ(SCALER_DISPCTRL);
3062820526dSMaxime Ripard 			HVS_WRITE(SCALER_DISPCTRL,
3072820526dSMaxime Ripard 				  (reg & ~SCALER_DISPCTRL_DSP3_MUX_MASK) |
3082820526dSMaxime Ripard 				  VC4_SET_FIELD(mux, SCALER_DISPCTRL_DSP3_MUX));
30987ebcd42SMaxime Ripard 			break;
31087ebcd42SMaxime Ripard 
31187ebcd42SMaxime Ripard 		case 4:
3122820526dSMaxime Ripard 			if (vc4_state->assigned_channel == VC4_HVS_CHANNEL_DISABLED)
3132820526dSMaxime Ripard 				mux = 3;
3142820526dSMaxime Ripard 			else
3152820526dSMaxime Ripard 				mux = vc4_state->assigned_channel;
3162820526dSMaxime Ripard 
3172820526dSMaxime Ripard 			reg = HVS_READ(SCALER_DISPEOLN);
3182820526dSMaxime Ripard 			HVS_WRITE(SCALER_DISPEOLN,
3192820526dSMaxime Ripard 				  (reg & ~SCALER_DISPEOLN_DSP4_MUX_MASK) |
3202820526dSMaxime Ripard 				  VC4_SET_FIELD(mux, SCALER_DISPEOLN_DSP4_MUX));
3212820526dSMaxime Ripard 
32287ebcd42SMaxime Ripard 			break;
32387ebcd42SMaxime Ripard 
32487ebcd42SMaxime Ripard 		case 5:
3252820526dSMaxime Ripard 			if (vc4_state->assigned_channel == VC4_HVS_CHANNEL_DISABLED)
3262820526dSMaxime Ripard 				mux = 3;
3272820526dSMaxime Ripard 			else
3282820526dSMaxime Ripard 				mux = vc4_state->assigned_channel;
3292820526dSMaxime Ripard 
3302820526dSMaxime Ripard 			reg = HVS_READ(SCALER_DISPDITHER);
3312820526dSMaxime Ripard 			HVS_WRITE(SCALER_DISPDITHER,
3322820526dSMaxime Ripard 				  (reg & ~SCALER_DISPDITHER_DSP5_MUX_MASK) |
3332820526dSMaxime Ripard 				  VC4_SET_FIELD(mux, SCALER_DISPDITHER_DSP5_MUX));
33487ebcd42SMaxime Ripard 			break;
33587ebcd42SMaxime Ripard 
33687ebcd42SMaxime Ripard 		default:
33787ebcd42SMaxime Ripard 			break;
33887ebcd42SMaxime Ripard 		}
33987ebcd42SMaxime Ripard 	}
34087ebcd42SMaxime Ripard }
34187ebcd42SMaxime Ripard 
342f3c420feSMaxime Ripard static void vc4_atomic_commit_tail(struct drm_atomic_state *state)
343b501baccSEric Anholt {
344b501baccSEric Anholt 	struct drm_device *dev = state->dev;
345b501baccSEric Anholt 	struct vc4_dev *vc4 = to_vc4_dev(dev);
346d7d96c00SMaxime Ripard 	struct vc4_hvs *hvs = vc4->hvs;
34759635667SMaxime Ripard 	struct drm_crtc_state *new_crtc_state;
34816e10105SMaxime Ripard 	struct vc4_hvs_state *new_hvs_state;
34959635667SMaxime Ripard 	struct drm_crtc *crtc;
3509ec03d7fSMaxime Ripard 	struct vc4_hvs_state *old_hvs_state;
3516052a311SMaxime Ripard 	unsigned int channel;
352531a1b62SBoris Brezillon 	int i;
353531a1b62SBoris Brezillon 
35416e10105SMaxime Ripard 	old_hvs_state = vc4_hvs_get_old_global_state(state);
35599b03ca6SDaniel Vetter 	if (WARN_ON(IS_ERR(old_hvs_state)))
35616e10105SMaxime Ripard 		return;
35716e10105SMaxime Ripard 
35816e10105SMaxime Ripard 	new_hvs_state = vc4_hvs_get_new_global_state(state);
35999b03ca6SDaniel Vetter 	if (WARN_ON(IS_ERR(new_hvs_state)))
36016e10105SMaxime Ripard 		return;
36116e10105SMaxime Ripard 
36259635667SMaxime Ripard 	for_each_new_crtc_in_state(state, crtc, new_crtc_state, i) {
36387ebcd42SMaxime Ripard 		struct vc4_crtc_state *vc4_crtc_state;
36459635667SMaxime Ripard 
36559635667SMaxime Ripard 		if (!new_crtc_state->commit)
366531a1b62SBoris Brezillon 			continue;
367531a1b62SBoris Brezillon 
36887ebcd42SMaxime Ripard 		vc4_crtc_state = to_vc4_crtc_state(new_crtc_state);
369*3454f01aSMaxime Ripard 		vc4_hvs_mask_underrun(hvs, vc4_crtc_state->assigned_channel);
370531a1b62SBoris Brezillon 	}
371b501baccSEric Anholt 
3726052a311SMaxime Ripard 	for (channel = 0; channel < HVS_NUM_CHANNELS; channel++) {
373049cfff8SMaxime Ripard 		struct drm_crtc_commit *commit;
374b99c2c95SMaxime Ripard 		int ret;
3759ec03d7fSMaxime Ripard 
3769ec03d7fSMaxime Ripard 		if (!old_hvs_state->fifo_state[channel].in_use)
3779ec03d7fSMaxime Ripard 			continue;
3789ec03d7fSMaxime Ripard 
379049cfff8SMaxime Ripard 		commit = old_hvs_state->fifo_state[channel].pending_commit;
380049cfff8SMaxime Ripard 		if (!commit)
381049cfff8SMaxime Ripard 			continue;
382049cfff8SMaxime Ripard 
383049cfff8SMaxime Ripard 		ret = drm_crtc_commit_wait(commit);
384b99c2c95SMaxime Ripard 		if (ret)
385b99c2c95SMaxime Ripard 			drm_err(dev, "Timed out waiting for commit\n");
386049cfff8SMaxime Ripard 
387049cfff8SMaxime Ripard 		drm_crtc_commit_put(commit);
388d134c5ffSMaxime Ripard 		old_hvs_state->fifo_state[channel].pending_commit = NULL;
3899ec03d7fSMaxime Ripard 	}
3909ec03d7fSMaxime Ripard 
391244a36e5SMaxime Ripard 	if (vc4->hvs->hvs5) {
392748acfc9SMaxime Ripard 		unsigned long state_rate = max(old_hvs_state->core_clock_rate,
393244a36e5SMaxime Ripard 					       new_hvs_state->core_clock_rate);
394748acfc9SMaxime Ripard 		unsigned long core_rate = max_t(unsigned long,
395748acfc9SMaxime Ripard 						500000000, state_rate);
396244a36e5SMaxime Ripard 
3975b6ef06eSMaxime Ripard 		drm_dbg(dev, "Raising the core clock at %lu Hz\n", core_rate);
3985b6ef06eSMaxime Ripard 
3995b6ef06eSMaxime Ripard 		/*
4005b6ef06eSMaxime Ripard 		 * Do a temporary request on the core clock during the
4015b6ef06eSMaxime Ripard 		 * modeset.
4025b6ef06eSMaxime Ripard 		 */
403244a36e5SMaxime Ripard 		clk_set_min_rate(hvs->core_clk, core_rate);
404244a36e5SMaxime Ripard 	}
4055b6ef06eSMaxime Ripard 
406b501baccSEric Anholt 	drm_atomic_helper_commit_modeset_disables(dev, state);
407b501baccSEric Anholt 
408766cc6b1SStefan Schake 	vc4_ctm_commit(vc4, state);
409766cc6b1SStefan Schake 
41087ebcd42SMaxime Ripard 	if (vc4->hvs->hvs5)
41187ebcd42SMaxime Ripard 		vc5_hvs_pv_muxing_commit(vc4, state);
41287ebcd42SMaxime Ripard 	else
41387ebcd42SMaxime Ripard 		vc4_hvs_pv_muxing_commit(vc4, state);
41487ebcd42SMaxime Ripard 
415d65661acSMaxime Ripard 	drm_atomic_helper_commit_planes(dev, state,
416d65661acSMaxime Ripard 					DRM_PLANE_COMMIT_ACTIVE_ONLY);
417b501baccSEric Anholt 
418b501baccSEric Anholt 	drm_atomic_helper_commit_modeset_enables(dev, state);
419b501baccSEric Anholt 
4201ebe99a7SBoris Brezillon 	drm_atomic_helper_fake_vblank(state);
4211ebe99a7SBoris Brezillon 
42234c8ea40SBoris Brezillon 	drm_atomic_helper_commit_hw_done(state);
42334c8ea40SBoris Brezillon 
424184d3cf4SBoris Brezillon 	drm_atomic_helper_wait_for_flip_done(dev, state);
425b501baccSEric Anholt 
426b501baccSEric Anholt 	drm_atomic_helper_cleanup_planes(dev, state);
427b501baccSEric Anholt 
42816e10105SMaxime Ripard 	if (vc4->hvs->hvs5) {
42916e10105SMaxime Ripard 		drm_dbg(dev, "Running the core clock at %lu Hz\n",
43016e10105SMaxime Ripard 			new_hvs_state->core_clock_rate);
43116e10105SMaxime Ripard 
4325b6ef06eSMaxime Ripard 		/*
4335b6ef06eSMaxime Ripard 		 * Request a clock rate based on the current HVS
4345b6ef06eSMaxime Ripard 		 * requirements.
4355b6ef06eSMaxime Ripard 		 */
43616e10105SMaxime Ripard 		clk_set_min_rate(hvs->core_clk, new_hvs_state->core_clock_rate);
43716e10105SMaxime Ripard 	}
438b501baccSEric Anholt }
439b501baccSEric Anholt 
4409ec03d7fSMaxime Ripard static int vc4_atomic_commit_setup(struct drm_atomic_state *state)
4419ec03d7fSMaxime Ripard {
4429ec03d7fSMaxime Ripard 	struct drm_crtc_state *crtc_state;
4439ec03d7fSMaxime Ripard 	struct vc4_hvs_state *hvs_state;
4449ec03d7fSMaxime Ripard 	struct drm_crtc *crtc;
4459ec03d7fSMaxime Ripard 	unsigned int i;
4469ec03d7fSMaxime Ripard 
4479ec03d7fSMaxime Ripard 	hvs_state = vc4_hvs_get_new_global_state(state);
448f9277679SMaxime Ripard 	if (WARN_ON(IS_ERR(hvs_state)))
449f9277679SMaxime Ripard 		return PTR_ERR(hvs_state);
4509ec03d7fSMaxime Ripard 
4519ec03d7fSMaxime Ripard 	for_each_new_crtc_in_state(state, crtc, crtc_state, i) {
4529ec03d7fSMaxime Ripard 		struct vc4_crtc_state *vc4_crtc_state =
4539ec03d7fSMaxime Ripard 			to_vc4_crtc_state(crtc_state);
4549ec03d7fSMaxime Ripard 		unsigned int channel =
4559ec03d7fSMaxime Ripard 			vc4_crtc_state->assigned_channel;
4569ec03d7fSMaxime Ripard 
4579ec03d7fSMaxime Ripard 		if (channel == VC4_HVS_CHANNEL_DISABLED)
4589ec03d7fSMaxime Ripard 			continue;
4599ec03d7fSMaxime Ripard 
4609ec03d7fSMaxime Ripard 		if (!hvs_state->fifo_state[channel].in_use)
4619ec03d7fSMaxime Ripard 			continue;
4629ec03d7fSMaxime Ripard 
4639ec03d7fSMaxime Ripard 		hvs_state->fifo_state[channel].pending_commit =
4649ec03d7fSMaxime Ripard 			drm_crtc_commit_get(crtc_state->commit);
4659ec03d7fSMaxime Ripard 	}
4669ec03d7fSMaxime Ripard 
4679ec03d7fSMaxime Ripard 	return 0;
4689ec03d7fSMaxime Ripard }
4699ec03d7fSMaxime Ripard 
47083753117SEric Anholt static struct drm_framebuffer *vc4_fb_create(struct drm_device *dev,
47183753117SEric Anholt 					     struct drm_file *file_priv,
47283753117SEric Anholt 					     const struct drm_mode_fb_cmd2 *mode_cmd)
47383753117SEric Anholt {
47483753117SEric Anholt 	struct drm_mode_fb_cmd2 mode_cmd_local;
47583753117SEric Anholt 
47683753117SEric Anholt 	/* If the user didn't specify a modifier, use the
47783753117SEric Anholt 	 * vc4_set_tiling_ioctl() state for the BO.
47883753117SEric Anholt 	 */
47983753117SEric Anholt 	if (!(mode_cmd->flags & DRM_MODE_FB_MODIFIERS)) {
48083753117SEric Anholt 		struct drm_gem_object *gem_obj;
48183753117SEric Anholt 		struct vc4_bo *bo;
48283753117SEric Anholt 
48383753117SEric Anholt 		gem_obj = drm_gem_object_lookup(file_priv,
48483753117SEric Anholt 						mode_cmd->handles[0]);
48583753117SEric Anholt 		if (!gem_obj) {
486fb95992aSEric Anholt 			DRM_DEBUG("Failed to look up GEM BO %d\n",
48783753117SEric Anholt 				  mode_cmd->handles[0]);
48883753117SEric Anholt 			return ERR_PTR(-ENOENT);
48983753117SEric Anholt 		}
49083753117SEric Anholt 		bo = to_vc4_bo(gem_obj);
49183753117SEric Anholt 
49283753117SEric Anholt 		mode_cmd_local = *mode_cmd;
49383753117SEric Anholt 
49483753117SEric Anholt 		if (bo->t_format) {
49583753117SEric Anholt 			mode_cmd_local.modifier[0] =
49683753117SEric Anholt 				DRM_FORMAT_MOD_BROADCOM_VC4_T_TILED;
49783753117SEric Anholt 		} else {
49883753117SEric Anholt 			mode_cmd_local.modifier[0] = DRM_FORMAT_MOD_NONE;
49983753117SEric Anholt 		}
50083753117SEric Anholt 
501f7a8cd30SEmil Velikov 		drm_gem_object_put(gem_obj);
50283753117SEric Anholt 
50383753117SEric Anholt 		mode_cmd = &mode_cmd_local;
50483753117SEric Anholt 	}
50583753117SEric Anholt 
5069762477cSNoralf Trønnes 	return drm_gem_fb_create(dev, file_priv, mode_cmd);
50783753117SEric Anholt }
50883753117SEric Anholt 
509766cc6b1SStefan Schake /* Our CTM has some peculiar limitations: we can only enable it for one CRTC
510766cc6b1SStefan Schake  * at a time and the HW only supports S0.9 scalars. To account for the latter,
511766cc6b1SStefan Schake  * we don't allow userland to set a CTM that we have no hope of approximating.
512766cc6b1SStefan Schake  */
513766cc6b1SStefan Schake static int
514766cc6b1SStefan Schake vc4_ctm_atomic_check(struct drm_device *dev, struct drm_atomic_state *state)
515766cc6b1SStefan Schake {
516766cc6b1SStefan Schake 	struct vc4_dev *vc4 = to_vc4_dev(dev);
517766cc6b1SStefan Schake 	struct vc4_ctm_state *ctm_state = NULL;
518766cc6b1SStefan Schake 	struct drm_crtc *crtc;
519766cc6b1SStefan Schake 	struct drm_crtc_state *old_crtc_state, *new_crtc_state;
520766cc6b1SStefan Schake 	struct drm_color_ctm *ctm;
521766cc6b1SStefan Schake 	int i;
522766cc6b1SStefan Schake 
523766cc6b1SStefan Schake 	for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) {
524766cc6b1SStefan Schake 		/* CTM is being disabled. */
525766cc6b1SStefan Schake 		if (!new_crtc_state->ctm && old_crtc_state->ctm) {
526766cc6b1SStefan Schake 			ctm_state = vc4_get_ctm_state(state, &vc4->ctm_manager);
527766cc6b1SStefan Schake 			if (IS_ERR(ctm_state))
528766cc6b1SStefan Schake 				return PTR_ERR(ctm_state);
529766cc6b1SStefan Schake 			ctm_state->fifo = 0;
530766cc6b1SStefan Schake 		}
531766cc6b1SStefan Schake 	}
532766cc6b1SStefan Schake 
533766cc6b1SStefan Schake 	for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) {
534766cc6b1SStefan Schake 		if (new_crtc_state->ctm == old_crtc_state->ctm)
535766cc6b1SStefan Schake 			continue;
536766cc6b1SStefan Schake 
537766cc6b1SStefan Schake 		if (!ctm_state) {
538766cc6b1SStefan Schake 			ctm_state = vc4_get_ctm_state(state, &vc4->ctm_manager);
539766cc6b1SStefan Schake 			if (IS_ERR(ctm_state))
540766cc6b1SStefan Schake 				return PTR_ERR(ctm_state);
541766cc6b1SStefan Schake 		}
542766cc6b1SStefan Schake 
543766cc6b1SStefan Schake 		/* CTM is being enabled or the matrix changed. */
544766cc6b1SStefan Schake 		if (new_crtc_state->ctm) {
54587ebcd42SMaxime Ripard 			struct vc4_crtc_state *vc4_crtc_state =
54687ebcd42SMaxime Ripard 				to_vc4_crtc_state(new_crtc_state);
54787ebcd42SMaxime Ripard 
548766cc6b1SStefan Schake 			/* fifo is 1-based since 0 disables CTM. */
54987ebcd42SMaxime Ripard 			int fifo = vc4_crtc_state->assigned_channel + 1;
550766cc6b1SStefan Schake 
551766cc6b1SStefan Schake 			/* Check userland isn't trying to turn on CTM for more
552766cc6b1SStefan Schake 			 * than one CRTC at a time.
553766cc6b1SStefan Schake 			 */
554766cc6b1SStefan Schake 			if (ctm_state->fifo && ctm_state->fifo != fifo) {
555766cc6b1SStefan Schake 				DRM_DEBUG_DRIVER("Too many CTM configured\n");
556766cc6b1SStefan Schake 				return -EINVAL;
557766cc6b1SStefan Schake 			}
558766cc6b1SStefan Schake 
559766cc6b1SStefan Schake 			/* Check we can approximate the specified CTM.
560766cc6b1SStefan Schake 			 * We disallow scalars |c| > 1.0 since the HW has
561766cc6b1SStefan Schake 			 * no integer bits.
562766cc6b1SStefan Schake 			 */
563766cc6b1SStefan Schake 			ctm = new_crtc_state->ctm->data;
564766cc6b1SStefan Schake 			for (i = 0; i < ARRAY_SIZE(ctm->matrix); i++) {
565766cc6b1SStefan Schake 				u64 val = ctm->matrix[i];
566766cc6b1SStefan Schake 
567766cc6b1SStefan Schake 				val &= ~BIT_ULL(63);
568766cc6b1SStefan Schake 				if (val > BIT_ULL(32))
569766cc6b1SStefan Schake 					return -EINVAL;
570766cc6b1SStefan Schake 			}
571766cc6b1SStefan Schake 
572766cc6b1SStefan Schake 			ctm_state->fifo = fifo;
573766cc6b1SStefan Schake 			ctm_state->ctm = ctm;
574766cc6b1SStefan Schake 		}
575766cc6b1SStefan Schake 	}
576766cc6b1SStefan Schake 
577766cc6b1SStefan Schake 	return 0;
578766cc6b1SStefan Schake }
579766cc6b1SStefan Schake 
5804686da83SBoris Brezillon static int vc4_load_tracker_atomic_check(struct drm_atomic_state *state)
5814686da83SBoris Brezillon {
5824686da83SBoris Brezillon 	struct drm_plane_state *old_plane_state, *new_plane_state;
5834686da83SBoris Brezillon 	struct vc4_dev *vc4 = to_vc4_dev(state->dev);
5844686da83SBoris Brezillon 	struct vc4_load_tracker_state *load_state;
5854686da83SBoris Brezillon 	struct drm_private_state *priv_state;
5864686da83SBoris Brezillon 	struct drm_plane *plane;
5874686da83SBoris Brezillon 	int i;
5884686da83SBoris Brezillon 
5894686da83SBoris Brezillon 	priv_state = drm_atomic_get_private_obj_state(state,
5904686da83SBoris Brezillon 						      &vc4->load_tracker);
5914686da83SBoris Brezillon 	if (IS_ERR(priv_state))
5924686da83SBoris Brezillon 		return PTR_ERR(priv_state);
5934686da83SBoris Brezillon 
5944686da83SBoris Brezillon 	load_state = to_vc4_load_tracker_state(priv_state);
5954686da83SBoris Brezillon 	for_each_oldnew_plane_in_state(state, plane, old_plane_state,
5964686da83SBoris Brezillon 				       new_plane_state, i) {
5974686da83SBoris Brezillon 		struct vc4_plane_state *vc4_plane_state;
5984686da83SBoris Brezillon 
5994686da83SBoris Brezillon 		if (old_plane_state->fb && old_plane_state->crtc) {
6004686da83SBoris Brezillon 			vc4_plane_state = to_vc4_plane_state(old_plane_state);
6014686da83SBoris Brezillon 			load_state->membus_load -= vc4_plane_state->membus_load;
6024686da83SBoris Brezillon 			load_state->hvs_load -= vc4_plane_state->hvs_load;
6034686da83SBoris Brezillon 		}
6044686da83SBoris Brezillon 
6054686da83SBoris Brezillon 		if (new_plane_state->fb && new_plane_state->crtc) {
6064686da83SBoris Brezillon 			vc4_plane_state = to_vc4_plane_state(new_plane_state);
6074686da83SBoris Brezillon 			load_state->membus_load += vc4_plane_state->membus_load;
6084686da83SBoris Brezillon 			load_state->hvs_load += vc4_plane_state->hvs_load;
6094686da83SBoris Brezillon 		}
6104686da83SBoris Brezillon 	}
6114686da83SBoris Brezillon 
6126b5c029dSPaul Kocialkowski 	/* Don't check the load when the tracker is disabled. */
6136b5c029dSPaul Kocialkowski 	if (!vc4->load_tracker_enabled)
6146b5c029dSPaul Kocialkowski 		return 0;
6156b5c029dSPaul Kocialkowski 
6164686da83SBoris Brezillon 	/* The absolute limit is 2Gbyte/sec, but let's take a margin to let
6174686da83SBoris Brezillon 	 * the system work when other blocks are accessing the memory.
6184686da83SBoris Brezillon 	 */
6194686da83SBoris Brezillon 	if (load_state->membus_load > SZ_1G + SZ_512M)
6204686da83SBoris Brezillon 		return -ENOSPC;
6214686da83SBoris Brezillon 
6224686da83SBoris Brezillon 	/* HVS clock is supposed to run @ 250Mhz, let's take a margin and
6234686da83SBoris Brezillon 	 * consider the maximum number of cycles is 240M.
6244686da83SBoris Brezillon 	 */
6254686da83SBoris Brezillon 	if (load_state->hvs_load > 240000000ULL)
6264686da83SBoris Brezillon 		return -ENOSPC;
6274686da83SBoris Brezillon 
6284686da83SBoris Brezillon 	return 0;
6294686da83SBoris Brezillon }
6304686da83SBoris Brezillon 
6314686da83SBoris Brezillon static struct drm_private_state *
6324686da83SBoris Brezillon vc4_load_tracker_duplicate_state(struct drm_private_obj *obj)
6334686da83SBoris Brezillon {
6344686da83SBoris Brezillon 	struct vc4_load_tracker_state *state;
6354686da83SBoris Brezillon 
6364686da83SBoris Brezillon 	state = kmemdup(obj->state, sizeof(*state), GFP_KERNEL);
6374686da83SBoris Brezillon 	if (!state)
6384686da83SBoris Brezillon 		return NULL;
6394686da83SBoris Brezillon 
6404686da83SBoris Brezillon 	__drm_atomic_helper_private_obj_duplicate_state(obj, &state->base);
6414686da83SBoris Brezillon 
6424686da83SBoris Brezillon 	return &state->base;
6434686da83SBoris Brezillon }
6444686da83SBoris Brezillon 
6454686da83SBoris Brezillon static void vc4_load_tracker_destroy_state(struct drm_private_obj *obj,
6464686da83SBoris Brezillon 					   struct drm_private_state *state)
6474686da83SBoris Brezillon {
6484686da83SBoris Brezillon 	struct vc4_load_tracker_state *load_state;
6494686da83SBoris Brezillon 
6504686da83SBoris Brezillon 	load_state = to_vc4_load_tracker_state(state);
6514686da83SBoris Brezillon 	kfree(load_state);
6524686da83SBoris Brezillon }
6534686da83SBoris Brezillon 
6544686da83SBoris Brezillon static const struct drm_private_state_funcs vc4_load_tracker_state_funcs = {
6554686da83SBoris Brezillon 	.atomic_duplicate_state = vc4_load_tracker_duplicate_state,
6564686da83SBoris Brezillon 	.atomic_destroy_state = vc4_load_tracker_destroy_state,
6574686da83SBoris Brezillon };
6584686da83SBoris Brezillon 
659dcda7c28SMaxime Ripard static void vc4_load_tracker_obj_fini(struct drm_device *dev, void *unused)
660dcda7c28SMaxime Ripard {
661dcda7c28SMaxime Ripard 	struct vc4_dev *vc4 = to_vc4_dev(dev);
662dcda7c28SMaxime Ripard 
663dcda7c28SMaxime Ripard 	drm_atomic_private_obj_fini(&vc4->load_tracker);
664dcda7c28SMaxime Ripard }
665dcda7c28SMaxime Ripard 
666dcda7c28SMaxime Ripard static int vc4_load_tracker_obj_init(struct vc4_dev *vc4)
667dcda7c28SMaxime Ripard {
668dcda7c28SMaxime Ripard 	struct vc4_load_tracker_state *load_state;
669dcda7c28SMaxime Ripard 
670dcda7c28SMaxime Ripard 	load_state = kzalloc(sizeof(*load_state), GFP_KERNEL);
671dcda7c28SMaxime Ripard 	if (!load_state)
672dcda7c28SMaxime Ripard 		return -ENOMEM;
673dcda7c28SMaxime Ripard 
674dcda7c28SMaxime Ripard 	drm_atomic_private_obj_init(&vc4->base, &vc4->load_tracker,
675dcda7c28SMaxime Ripard 				    &load_state->base,
676dcda7c28SMaxime Ripard 				    &vc4_load_tracker_state_funcs);
677dcda7c28SMaxime Ripard 
6783c354ed1SMaxime Ripard 	return drmm_add_action_or_reset(&vc4->base, vc4_load_tracker_obj_fini, NULL);
679dcda7c28SMaxime Ripard }
680dcda7c28SMaxime Ripard 
681f2df84e0SMaxime Ripard static struct drm_private_state *
682f2df84e0SMaxime Ripard vc4_hvs_channels_duplicate_state(struct drm_private_obj *obj)
683f2df84e0SMaxime Ripard {
684f2df84e0SMaxime Ripard 	struct vc4_hvs_state *old_state = to_vc4_hvs_state(obj->state);
685f2df84e0SMaxime Ripard 	struct vc4_hvs_state *state;
6869ec03d7fSMaxime Ripard 	unsigned int i;
687f2df84e0SMaxime Ripard 
688f2df84e0SMaxime Ripard 	state = kzalloc(sizeof(*state), GFP_KERNEL);
689f2df84e0SMaxime Ripard 	if (!state)
690f2df84e0SMaxime Ripard 		return NULL;
691f2df84e0SMaxime Ripard 
692f2df84e0SMaxime Ripard 	__drm_atomic_helper_private_obj_duplicate_state(obj, &state->base);
693f2df84e0SMaxime Ripard 
6949ec03d7fSMaxime Ripard 	for (i = 0; i < HVS_NUM_CHANNELS; i++) {
6959ec03d7fSMaxime Ripard 		state->fifo_state[i].in_use = old_state->fifo_state[i].in_use;
69616e10105SMaxime Ripard 		state->fifo_state[i].fifo_load = old_state->fifo_state[i].fifo_load;
6979ec03d7fSMaxime Ripard 	}
6989ec03d7fSMaxime Ripard 
69916e10105SMaxime Ripard 	state->core_clock_rate = old_state->core_clock_rate;
70016e10105SMaxime Ripard 
701f2df84e0SMaxime Ripard 	return &state->base;
702f2df84e0SMaxime Ripard }
703f2df84e0SMaxime Ripard 
704f2df84e0SMaxime Ripard static void vc4_hvs_channels_destroy_state(struct drm_private_obj *obj,
705f2df84e0SMaxime Ripard 					   struct drm_private_state *state)
706f2df84e0SMaxime Ripard {
707f2df84e0SMaxime Ripard 	struct vc4_hvs_state *hvs_state = to_vc4_hvs_state(state);
7089ec03d7fSMaxime Ripard 	unsigned int i;
7099ec03d7fSMaxime Ripard 
7109ec03d7fSMaxime Ripard 	for (i = 0; i < HVS_NUM_CHANNELS; i++) {
7119ec03d7fSMaxime Ripard 		if (!hvs_state->fifo_state[i].pending_commit)
7129ec03d7fSMaxime Ripard 			continue;
7139ec03d7fSMaxime Ripard 
7149ec03d7fSMaxime Ripard 		drm_crtc_commit_put(hvs_state->fifo_state[i].pending_commit);
7159ec03d7fSMaxime Ripard 	}
716f2df84e0SMaxime Ripard 
717f2df84e0SMaxime Ripard 	kfree(hvs_state);
718f2df84e0SMaxime Ripard }
719f2df84e0SMaxime Ripard 
72066bfe59dSMaxime Ripard static void vc4_hvs_channels_print_state(struct drm_printer *p,
72166bfe59dSMaxime Ripard 					 const struct drm_private_state *state)
72266bfe59dSMaxime Ripard {
72366bfe59dSMaxime Ripard 	struct vc4_hvs_state *hvs_state = to_vc4_hvs_state(state);
72466bfe59dSMaxime Ripard 	unsigned int i;
72566bfe59dSMaxime Ripard 
72666bfe59dSMaxime Ripard 	drm_printf(p, "HVS State\n");
72766bfe59dSMaxime Ripard 	drm_printf(p, "\tCore Clock Rate: %lu\n", hvs_state->core_clock_rate);
72866bfe59dSMaxime Ripard 
72966bfe59dSMaxime Ripard 	for (i = 0; i < HVS_NUM_CHANNELS; i++) {
73066bfe59dSMaxime Ripard 		drm_printf(p, "\tChannel %d\n", i);
73166bfe59dSMaxime Ripard 		drm_printf(p, "\t\tin use=%d\n", hvs_state->fifo_state[i].in_use);
73266bfe59dSMaxime Ripard 		drm_printf(p, "\t\tload=%lu\n", hvs_state->fifo_state[i].fifo_load);
73366bfe59dSMaxime Ripard 	}
73466bfe59dSMaxime Ripard }
73566bfe59dSMaxime Ripard 
736f2df84e0SMaxime Ripard static const struct drm_private_state_funcs vc4_hvs_state_funcs = {
737f2df84e0SMaxime Ripard 	.atomic_duplicate_state = vc4_hvs_channels_duplicate_state,
738f2df84e0SMaxime Ripard 	.atomic_destroy_state = vc4_hvs_channels_destroy_state,
73966bfe59dSMaxime Ripard 	.atomic_print_state = vc4_hvs_channels_print_state,
740f2df84e0SMaxime Ripard };
741f2df84e0SMaxime Ripard 
742f2df84e0SMaxime Ripard static void vc4_hvs_channels_obj_fini(struct drm_device *dev, void *unused)
743f2df84e0SMaxime Ripard {
744f2df84e0SMaxime Ripard 	struct vc4_dev *vc4 = to_vc4_dev(dev);
745f2df84e0SMaxime Ripard 
746f2df84e0SMaxime Ripard 	drm_atomic_private_obj_fini(&vc4->hvs_channels);
747f2df84e0SMaxime Ripard }
748f2df84e0SMaxime Ripard 
749f2df84e0SMaxime Ripard static int vc4_hvs_channels_obj_init(struct vc4_dev *vc4)
750f2df84e0SMaxime Ripard {
751f2df84e0SMaxime Ripard 	struct vc4_hvs_state *state;
752f2df84e0SMaxime Ripard 
753f2df84e0SMaxime Ripard 	state = kzalloc(sizeof(*state), GFP_KERNEL);
754f2df84e0SMaxime Ripard 	if (!state)
755f2df84e0SMaxime Ripard 		return -ENOMEM;
756f2df84e0SMaxime Ripard 
757f2df84e0SMaxime Ripard 	drm_atomic_private_obj_init(&vc4->base, &vc4->hvs_channels,
758f2df84e0SMaxime Ripard 				    &state->base,
759f2df84e0SMaxime Ripard 				    &vc4_hvs_state_funcs);
760f2df84e0SMaxime Ripard 
761f2df84e0SMaxime Ripard 	return drmm_add_action_or_reset(&vc4->base, vc4_hvs_channels_obj_fini, NULL);
762f2df84e0SMaxime Ripard }
763f2df84e0SMaxime Ripard 
764b5dbc4d3SMaxime Ripard /*
765b5dbc4d3SMaxime Ripard  * The BCM2711 HVS has up to 7 outputs connected to the pixelvalves and
766b5dbc4d3SMaxime Ripard  * the TXP (and therefore all the CRTCs found on that platform).
767b5dbc4d3SMaxime Ripard  *
768b5dbc4d3SMaxime Ripard  * The naive (and our initial) implementation would just iterate over
769b5dbc4d3SMaxime Ripard  * all the active CRTCs, try to find a suitable FIFO, and then remove it
770b5dbc4d3SMaxime Ripard  * from the pool of available FIFOs. However, there are a few corner
771b5dbc4d3SMaxime Ripard  * cases that need to be considered:
772b5dbc4d3SMaxime Ripard  *
773b5dbc4d3SMaxime Ripard  * - When running in a dual-display setup (so with two CRTCs involved),
774b5dbc4d3SMaxime Ripard  *   we can update the state of a single CRTC (for example by changing
775b5dbc4d3SMaxime Ripard  *   its mode using xrandr under X11) without affecting the other. In
776b5dbc4d3SMaxime Ripard  *   this case, the other CRTC wouldn't be in the state at all, so we
777b5dbc4d3SMaxime Ripard  *   need to consider all the running CRTCs in the DRM device to assign
778b5dbc4d3SMaxime Ripard  *   a FIFO, not just the one in the state.
779b5dbc4d3SMaxime Ripard  *
780f2df84e0SMaxime Ripard  * - To fix the above, we can't use drm_atomic_get_crtc_state on all
781f2df84e0SMaxime Ripard  *   enabled CRTCs to pull their CRTC state into the global state, since
782f2df84e0SMaxime Ripard  *   a page flip would start considering their vblank to complete. Since
783f2df84e0SMaxime Ripard  *   we don't have a guarantee that they are actually active, that
784f2df84e0SMaxime Ripard  *   vblank might never happen, and shouldn't even be considered if we
785f2df84e0SMaxime Ripard  *   want to do a page flip on a single CRTC. That can be tested by
786f2df84e0SMaxime Ripard  *   doing a modetest -v first on HDMI1 and then on HDMI0.
787f2df84e0SMaxime Ripard  *
788b5dbc4d3SMaxime Ripard  * - Since we need the pixelvalve to be disabled and enabled back when
789b5dbc4d3SMaxime Ripard  *   the FIFO is changed, we should keep the FIFO assigned for as long
790b5dbc4d3SMaxime Ripard  *   as the CRTC is enabled, only considering it free again once that
791b5dbc4d3SMaxime Ripard  *   CRTC has been disabled. This can be tested by booting X11 on a
792b5dbc4d3SMaxime Ripard  *   single display, and changing the resolution down and then back up.
793b5dbc4d3SMaxime Ripard  */
794a72b0458SMaxime Ripard static int vc4_pv_muxing_atomic_check(struct drm_device *dev,
795a72b0458SMaxime Ripard 				      struct drm_atomic_state *state)
796766cc6b1SStefan Schake {
797f2df84e0SMaxime Ripard 	struct vc4_hvs_state *hvs_new_state;
7988ba0b6d1SMaxime Ripard 	struct drm_crtc_state *old_crtc_state, *new_crtc_state;
79987ebcd42SMaxime Ripard 	struct drm_crtc *crtc;
80003b03efeSMaxime Ripard 	unsigned int unassigned_channels = 0;
801a72b0458SMaxime Ripard 	unsigned int i;
80287ebcd42SMaxime Ripard 
803f2df84e0SMaxime Ripard 	hvs_new_state = vc4_hvs_get_global_state(state);
804f9277679SMaxime Ripard 	if (IS_ERR(hvs_new_state))
805f9277679SMaxime Ripard 		return PTR_ERR(hvs_new_state);
806089d8341SMaxime Ripard 
80703b03efeSMaxime Ripard 	for (i = 0; i < ARRAY_SIZE(hvs_new_state->fifo_state); i++)
80803b03efeSMaxime Ripard 		if (!hvs_new_state->fifo_state[i].in_use)
80903b03efeSMaxime Ripard 			unassigned_channels |= BIT(i);
81003b03efeSMaxime Ripard 
8118ba0b6d1SMaxime Ripard 	for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) {
812f2df84e0SMaxime Ripard 		struct vc4_crtc_state *old_vc4_crtc_state =
813f2df84e0SMaxime Ripard 			to_vc4_crtc_state(old_crtc_state);
8148ba0b6d1SMaxime Ripard 		struct vc4_crtc_state *new_vc4_crtc_state =
8158ba0b6d1SMaxime Ripard 			to_vc4_crtc_state(new_crtc_state);
81687ebcd42SMaxime Ripard 		struct vc4_crtc *vc4_crtc = to_vc4_crtc(crtc);
81787ebcd42SMaxime Ripard 		unsigned int matching_channels;
818d62a8ed7SMaxime Ripard 		unsigned int channel;
81987ebcd42SMaxime Ripard 
8202820526dSMaxime Ripard 		/* Nothing to do here, let's skip it */
8212820526dSMaxime Ripard 		if (old_crtc_state->enable == new_crtc_state->enable)
8222820526dSMaxime Ripard 			continue;
8232820526dSMaxime Ripard 
8242820526dSMaxime Ripard 		/* Muxing will need to be modified, mark it as such */
8252820526dSMaxime Ripard 		new_vc4_crtc_state->update_muxing = true;
8262820526dSMaxime Ripard 
8272820526dSMaxime Ripard 		/* If we're disabling our CRTC, we put back our channel */
8282820526dSMaxime Ripard 		if (!new_crtc_state->enable) {
8299ec03d7fSMaxime Ripard 			channel = old_vc4_crtc_state->assigned_channel;
8309ec03d7fSMaxime Ripard 			hvs_new_state->fifo_state[channel].in_use = false;
8318ba0b6d1SMaxime Ripard 			new_vc4_crtc_state->assigned_channel = VC4_HVS_CHANNEL_DISABLED;
8322820526dSMaxime Ripard 			continue;
833f2df84e0SMaxime Ripard 		}
8348ba0b6d1SMaxime Ripard 
83587ebcd42SMaxime Ripard 		/*
83687ebcd42SMaxime Ripard 		 * The problem we have to solve here is that we have
83787ebcd42SMaxime Ripard 		 * up to 7 encoders, connected to up to 6 CRTCs.
83887ebcd42SMaxime Ripard 		 *
83987ebcd42SMaxime Ripard 		 * Those CRTCs, depending on the instance, can be
84087ebcd42SMaxime Ripard 		 * routed to 1, 2 or 3 HVS FIFOs, and we need to set
84187ebcd42SMaxime Ripard 		 * the change the muxing between FIFOs and outputs in
84287ebcd42SMaxime Ripard 		 * the HVS accordingly.
84387ebcd42SMaxime Ripard 		 *
84487ebcd42SMaxime Ripard 		 * It would be pretty hard to come up with an
84587ebcd42SMaxime Ripard 		 * algorithm that would generically solve
84687ebcd42SMaxime Ripard 		 * this. However, the current routing trees we support
84787ebcd42SMaxime Ripard 		 * allow us to simplify a bit the problem.
84887ebcd42SMaxime Ripard 		 *
84987ebcd42SMaxime Ripard 		 * Indeed, with the current supported layouts, if we
85087ebcd42SMaxime Ripard 		 * try to assign in the ascending crtc index order the
85187ebcd42SMaxime Ripard 		 * FIFOs, we can't fall into the situation where an
85287ebcd42SMaxime Ripard 		 * earlier CRTC that had multiple routes is assigned
85387ebcd42SMaxime Ripard 		 * one that was the only option for a later CRTC.
85487ebcd42SMaxime Ripard 		 *
85587ebcd42SMaxime Ripard 		 * If the layout changes and doesn't give us that in
85687ebcd42SMaxime Ripard 		 * the future, we will need to have something smarter,
85787ebcd42SMaxime Ripard 		 * but it works so far.
85887ebcd42SMaxime Ripard 		 */
85903b03efeSMaxime Ripard 		matching_channels = unassigned_channels & vc4_crtc->data->hvs_available_channels;
860d62a8ed7SMaxime Ripard 		if (!matching_channels)
861d62a8ed7SMaxime Ripard 			return -EINVAL;
86287ebcd42SMaxime Ripard 
863d62a8ed7SMaxime Ripard 		channel = ffs(matching_channels) - 1;
8648ba0b6d1SMaxime Ripard 		new_vc4_crtc_state->assigned_channel = channel;
86503b03efeSMaxime Ripard 		unassigned_channels &= ~BIT(channel);
8669ec03d7fSMaxime Ripard 		hvs_new_state->fifo_state[channel].in_use = true;
86787ebcd42SMaxime Ripard 	}
868766cc6b1SStefan Schake 
869a72b0458SMaxime Ripard 	return 0;
870a72b0458SMaxime Ripard }
871a72b0458SMaxime Ripard 
872a72b0458SMaxime Ripard static int
87316e10105SMaxime Ripard vc4_core_clock_atomic_check(struct drm_atomic_state *state)
87416e10105SMaxime Ripard {
87516e10105SMaxime Ripard 	struct vc4_dev *vc4 = to_vc4_dev(state->dev);
87616e10105SMaxime Ripard 	struct drm_private_state *priv_state;
87716e10105SMaxime Ripard 	struct vc4_hvs_state *hvs_new_state;
87816e10105SMaxime Ripard 	struct vc4_load_tracker_state *load_state;
87916e10105SMaxime Ripard 	struct drm_crtc_state *old_crtc_state, *new_crtc_state;
88016e10105SMaxime Ripard 	struct drm_crtc *crtc;
88116e10105SMaxime Ripard 	unsigned int num_outputs;
88216e10105SMaxime Ripard 	unsigned long pixel_rate;
88316e10105SMaxime Ripard 	unsigned long cob_rate;
88416e10105SMaxime Ripard 	unsigned int i;
88516e10105SMaxime Ripard 
88616e10105SMaxime Ripard 	priv_state = drm_atomic_get_private_obj_state(state,
88716e10105SMaxime Ripard 						      &vc4->load_tracker);
88816e10105SMaxime Ripard 	if (IS_ERR(priv_state))
88916e10105SMaxime Ripard 		return PTR_ERR(priv_state);
89016e10105SMaxime Ripard 
89116e10105SMaxime Ripard 	load_state = to_vc4_load_tracker_state(priv_state);
89216e10105SMaxime Ripard 
89316e10105SMaxime Ripard 	hvs_new_state = vc4_hvs_get_global_state(state);
89499b03ca6SDaniel Vetter 	if (IS_ERR(hvs_new_state))
89599b03ca6SDaniel Vetter 		return PTR_ERR(hvs_new_state);
89616e10105SMaxime Ripard 
89716e10105SMaxime Ripard 	for_each_oldnew_crtc_in_state(state, crtc,
89816e10105SMaxime Ripard 				      old_crtc_state,
89916e10105SMaxime Ripard 				      new_crtc_state,
90016e10105SMaxime Ripard 				      i) {
90116e10105SMaxime Ripard 		if (old_crtc_state->active) {
90216e10105SMaxime Ripard 			struct vc4_crtc_state *old_vc4_state =
90316e10105SMaxime Ripard 				to_vc4_crtc_state(old_crtc_state);
90416e10105SMaxime Ripard 			unsigned int channel = old_vc4_state->assigned_channel;
90516e10105SMaxime Ripard 
90616e10105SMaxime Ripard 			hvs_new_state->fifo_state[channel].fifo_load = 0;
90716e10105SMaxime Ripard 		}
90816e10105SMaxime Ripard 
90916e10105SMaxime Ripard 		if (new_crtc_state->active) {
91016e10105SMaxime Ripard 			struct vc4_crtc_state *new_vc4_state =
91116e10105SMaxime Ripard 				to_vc4_crtc_state(new_crtc_state);
91216e10105SMaxime Ripard 			unsigned int channel = new_vc4_state->assigned_channel;
91316e10105SMaxime Ripard 
91416e10105SMaxime Ripard 			hvs_new_state->fifo_state[channel].fifo_load =
91516e10105SMaxime Ripard 				new_vc4_state->hvs_load;
91616e10105SMaxime Ripard 		}
91716e10105SMaxime Ripard 	}
91816e10105SMaxime Ripard 
91916e10105SMaxime Ripard 	cob_rate = 0;
92016e10105SMaxime Ripard 	num_outputs = 0;
92116e10105SMaxime Ripard 	for (i = 0; i < HVS_NUM_CHANNELS; i++) {
92216e10105SMaxime Ripard 		if (!hvs_new_state->fifo_state[i].in_use)
92316e10105SMaxime Ripard 			continue;
92416e10105SMaxime Ripard 
92516e10105SMaxime Ripard 		num_outputs++;
92616e10105SMaxime Ripard 		cob_rate += hvs_new_state->fifo_state[i].fifo_load;
92716e10105SMaxime Ripard 	}
92816e10105SMaxime Ripard 
92916e10105SMaxime Ripard 	pixel_rate = load_state->hvs_load;
93016e10105SMaxime Ripard 	if (num_outputs > 1) {
93116e10105SMaxime Ripard 		pixel_rate = (pixel_rate * 40) / 100;
93216e10105SMaxime Ripard 	} else {
93316e10105SMaxime Ripard 		pixel_rate = (pixel_rate * 60) / 100;
93416e10105SMaxime Ripard 	}
93516e10105SMaxime Ripard 
93616e10105SMaxime Ripard 	hvs_new_state->core_clock_rate = max(cob_rate, pixel_rate);
93716e10105SMaxime Ripard 
93816e10105SMaxime Ripard 	return 0;
93916e10105SMaxime Ripard }
94016e10105SMaxime Ripard 
94116e10105SMaxime Ripard 
94216e10105SMaxime Ripard static int
943a72b0458SMaxime Ripard vc4_atomic_check(struct drm_device *dev, struct drm_atomic_state *state)
944a72b0458SMaxime Ripard {
945a72b0458SMaxime Ripard 	int ret;
946a72b0458SMaxime Ripard 
947a72b0458SMaxime Ripard 	ret = vc4_pv_muxing_atomic_check(dev, state);
948a72b0458SMaxime Ripard 	if (ret)
949a72b0458SMaxime Ripard 		return ret;
950a72b0458SMaxime Ripard 
951766cc6b1SStefan Schake 	ret = vc4_ctm_atomic_check(dev, state);
952766cc6b1SStefan Schake 	if (ret < 0)
953766cc6b1SStefan Schake 		return ret;
954766cc6b1SStefan Schake 
9554686da83SBoris Brezillon 	ret = drm_atomic_helper_check(dev, state);
9564686da83SBoris Brezillon 	if (ret)
9574686da83SBoris Brezillon 		return ret;
9584686da83SBoris Brezillon 
95916e10105SMaxime Ripard 	ret = vc4_load_tracker_atomic_check(state);
96016e10105SMaxime Ripard 	if (ret)
96116e10105SMaxime Ripard 		return ret;
96216e10105SMaxime Ripard 
96316e10105SMaxime Ripard 	return vc4_core_clock_atomic_check(state);
964766cc6b1SStefan Schake }
965766cc6b1SStefan Schake 
9669ec03d7fSMaxime Ripard static struct drm_mode_config_helper_funcs vc4_mode_config_helpers = {
9679ec03d7fSMaxime Ripard 	.atomic_commit_setup	= vc4_atomic_commit_setup,
968f3c420feSMaxime Ripard 	.atomic_commit_tail	= vc4_atomic_commit_tail,
9699ec03d7fSMaxime Ripard };
9709ec03d7fSMaxime Ripard 
971c8b75bcaSEric Anholt static const struct drm_mode_config_funcs vc4_mode_funcs = {
972766cc6b1SStefan Schake 	.atomic_check = vc4_atomic_check,
973f3c420feSMaxime Ripard 	.atomic_commit = drm_atomic_helper_commit,
97483753117SEric Anholt 	.fb_create = vc4_fb_create,
975c8b75bcaSEric Anholt };
976c8b75bcaSEric Anholt 
977c8b75bcaSEric Anholt int vc4_kms_load(struct drm_device *dev)
978c8b75bcaSEric Anholt {
97948666d56SDerek Foreman 	struct vc4_dev *vc4 = to_vc4_dev(dev);
980f437bc1eSMaxime Ripard 	bool is_vc5 = of_device_is_compatible(dev->dev->of_node,
981f437bc1eSMaxime Ripard 					      "brcm,bcm2711-vc5");
982c8b75bcaSEric Anholt 	int ret;
983c8b75bcaSEric Anholt 
9847f817159SMaxime Ripard 	/*
9857f817159SMaxime Ripard 	 * The limits enforced by the load tracker aren't relevant for
9867f817159SMaxime Ripard 	 * the BCM2711, but the load tracker computations are used for
9877f817159SMaxime Ripard 	 * the core clock rate calculation.
9887f817159SMaxime Ripard 	 */
989f437bc1eSMaxime Ripard 	if (!is_vc5) {
990f437bc1eSMaxime Ripard 		/* Start with the load tracker enabled. Can be
991f437bc1eSMaxime Ripard 		 * disabled through the debugfs load_tracker file.
9926b5c029dSPaul Kocialkowski 		 */
9936b5c029dSPaul Kocialkowski 		vc4->load_tracker_enabled = true;
994f437bc1eSMaxime Ripard 	}
9956b5c029dSPaul Kocialkowski 
9967d2818f5SMario Kleiner 	/* Set support for vblank irq fast disable, before drm_vblank_init() */
9977d2818f5SMario Kleiner 	dev->vblank_disable_immediate = true;
9987d2818f5SMario Kleiner 
999c8b75bcaSEric Anholt 	ret = drm_vblank_init(dev, dev->mode_config.num_crtc);
1000c8b75bcaSEric Anholt 	if (ret < 0) {
1001c8b75bcaSEric Anholt 		dev_err(dev->dev, "failed to initialize vblank\n");
1002c8b75bcaSEric Anholt 		return ret;
1003c8b75bcaSEric Anholt 	}
1004c8b75bcaSEric Anholt 
1005f437bc1eSMaxime Ripard 	if (is_vc5) {
1006f437bc1eSMaxime Ripard 		dev->mode_config.max_width = 7680;
1007f437bc1eSMaxime Ripard 		dev->mode_config.max_height = 7680;
1008f437bc1eSMaxime Ripard 	} else {
1009c8b75bcaSEric Anholt 		dev->mode_config.max_width = 2048;
1010c8b75bcaSEric Anholt 		dev->mode_config.max_height = 2048;
1011f437bc1eSMaxime Ripard 	}
1012f437bc1eSMaxime Ripard 
1013c8b75bcaSEric Anholt 	dev->mode_config.funcs = &vc4_mode_funcs;
10149ec03d7fSMaxime Ripard 	dev->mode_config.helper_private = &vc4_mode_config_helpers;
1015c8b75bcaSEric Anholt 	dev->mode_config.preferred_depth = 24;
1016b501baccSEric Anholt 	dev->mode_config.async_page_flip = true;
1017b501baccSEric Anholt 
1018dcda7c28SMaxime Ripard 	ret = vc4_ctm_obj_init(vc4);
1019dcda7c28SMaxime Ripard 	if (ret)
1020dcda7c28SMaxime Ripard 		return ret;
1021766cc6b1SStefan Schake 
1022dcda7c28SMaxime Ripard 	ret = vc4_load_tracker_obj_init(vc4);
1023dcda7c28SMaxime Ripard 	if (ret)
1024dcda7c28SMaxime Ripard 		return ret;
10254686da83SBoris Brezillon 
1026f2df84e0SMaxime Ripard 	ret = vc4_hvs_channels_obj_init(vc4);
1027f2df84e0SMaxime Ripard 	if (ret)
1028f2df84e0SMaxime Ripard 		return ret;
1029f2df84e0SMaxime Ripard 
1030c8b75bcaSEric Anholt 	drm_mode_config_reset(dev);
1031c8b75bcaSEric Anholt 
1032c8b75bcaSEric Anholt 	drm_kms_helper_poll_init(dev);
1033c8b75bcaSEric Anholt 
1034c8b75bcaSEric Anholt 	return 0;
1035c8b75bcaSEric Anholt }
1036