1 /*
2  * Copyright 2007-8 Advanced Micro Devices, Inc.
3  * Copyright 2008 Red Hat Inc.
4  *
5  * Permission is hereby granted, free of charge, to any person obtaining a
6  * copy of this software and associated documentation files (the "Software"),
7  * to deal in the Software without restriction, including without limitation
8  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
9  * and/or sell copies of the Software, and to permit persons to whom the
10  * Software is furnished to do so, subject to the following conditions:
11  *
12  * The above copyright notice and this permission notice shall be included in
13  * all copies or substantial portions of the Software.
14  *
15  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
18  * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
19  * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
20  * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
21  * OTHER DEALINGS IN THE SOFTWARE.
22  *
23  * Authors: Dave Airlie
24  *          Alex Deucher
25  */
26 #include <drm/drmP.h>
27 #include <drm/drm_edid.h>
28 #include <drm/drm_crtc_helper.h>
29 #include <drm/drm_fb_helper.h>
30 #include <drm/radeon_drm.h>
31 #include "radeon.h"
32 #include "atom.h"
33 
34 #include <linux/pm_runtime.h>
35 
36 void radeon_connector_hotplug(struct drm_connector *connector)
37 {
38 	struct drm_device *dev = connector->dev;
39 	struct radeon_device *rdev = dev->dev_private;
40 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
41 
42 	/* bail if the connector does not have hpd pin, e.g.,
43 	 * VGA, TV, etc.
44 	 */
45 	if (radeon_connector->hpd.hpd == RADEON_HPD_NONE)
46 		return;
47 
48 	radeon_hpd_set_polarity(rdev, radeon_connector->hpd.hpd);
49 
50 	/* if the connector is already off, don't turn it back on */
51 	/* FIXME: This access isn't protected by any locks. */
52 	if (connector->dpms != DRM_MODE_DPMS_ON)
53 		return;
54 
55 	/* just deal with DP (not eDP) here. */
56 	if (connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) {
57 		struct radeon_connector_atom_dig *dig_connector =
58 			radeon_connector->con_priv;
59 
60 		/* if existing sink type was not DP no need to retrain */
61 		if (dig_connector->dp_sink_type != CONNECTOR_OBJECT_ID_DISPLAYPORT)
62 			return;
63 
64 		/* first get sink type as it may be reset after (un)plug */
65 		dig_connector->dp_sink_type = radeon_dp_getsinktype(radeon_connector);
66 		/* don't do anything if sink is not display port, i.e.,
67 		 * passive dp->(dvi|hdmi) adaptor
68 		 */
69 		if (dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT) {
70 			int saved_dpms = connector->dpms;
71 			/* Only turn off the display if it's physically disconnected */
72 			if (!radeon_hpd_sense(rdev, radeon_connector->hpd.hpd)) {
73 				drm_helper_connector_dpms(connector, DRM_MODE_DPMS_OFF);
74 			} else if (radeon_dp_needs_link_train(radeon_connector)) {
75 				/* set it to OFF so that drm_helper_connector_dpms()
76 				 * won't return immediately since the current state
77 				 * is ON at this point.
78 				 */
79 				connector->dpms = DRM_MODE_DPMS_OFF;
80 				drm_helper_connector_dpms(connector, DRM_MODE_DPMS_ON);
81 			}
82 			connector->dpms = saved_dpms;
83 		}
84 	}
85 }
86 
87 static void radeon_property_change_mode(struct drm_encoder *encoder)
88 {
89 	struct drm_crtc *crtc = encoder->crtc;
90 
91 	if (crtc && crtc->enabled) {
92 		drm_crtc_helper_set_mode(crtc, &crtc->mode,
93 					 crtc->x, crtc->y, crtc->primary->fb);
94 	}
95 }
96 
97 int radeon_get_monitor_bpc(struct drm_connector *connector)
98 {
99 	struct drm_device *dev = connector->dev;
100 	struct radeon_device *rdev = dev->dev_private;
101 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
102 	struct radeon_connector_atom_dig *dig_connector;
103 	int bpc = 8;
104 	int mode_clock, max_tmds_clock;
105 
106 	switch (connector->connector_type) {
107 	case DRM_MODE_CONNECTOR_DVII:
108 	case DRM_MODE_CONNECTOR_HDMIB:
109 		if (radeon_connector->use_digital) {
110 			if (drm_detect_hdmi_monitor(radeon_connector->edid)) {
111 				if (connector->display_info.bpc)
112 					bpc = connector->display_info.bpc;
113 			}
114 		}
115 		break;
116 	case DRM_MODE_CONNECTOR_DVID:
117 	case DRM_MODE_CONNECTOR_HDMIA:
118 		if (drm_detect_hdmi_monitor(radeon_connector->edid)) {
119 			if (connector->display_info.bpc)
120 				bpc = connector->display_info.bpc;
121 		}
122 		break;
123 	case DRM_MODE_CONNECTOR_DisplayPort:
124 		dig_connector = radeon_connector->con_priv;
125 		if ((dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT) ||
126 		    (dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_eDP) ||
127 		    drm_detect_hdmi_monitor(radeon_connector->edid)) {
128 			if (connector->display_info.bpc)
129 				bpc = connector->display_info.bpc;
130 		}
131 		break;
132 	case DRM_MODE_CONNECTOR_eDP:
133 	case DRM_MODE_CONNECTOR_LVDS:
134 		if (connector->display_info.bpc)
135 			bpc = connector->display_info.bpc;
136 		else if (ASIC_IS_DCE41(rdev) || ASIC_IS_DCE5(rdev)) {
137 			struct drm_connector_helper_funcs *connector_funcs =
138 				connector->helper_private;
139 			struct drm_encoder *encoder = connector_funcs->best_encoder(connector);
140 			struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
141 			struct radeon_encoder_atom_dig *dig = radeon_encoder->enc_priv;
142 
143 			if (dig->lcd_misc & ATOM_PANEL_MISC_V13_6BIT_PER_COLOR)
144 				bpc = 6;
145 			else if (dig->lcd_misc & ATOM_PANEL_MISC_V13_8BIT_PER_COLOR)
146 				bpc = 8;
147 		}
148 		break;
149 	}
150 
151 	if (drm_detect_hdmi_monitor(radeon_connector->edid)) {
152 		/* hdmi deep color only implemented on DCE4+ */
153 		if ((bpc > 8) && !ASIC_IS_DCE4(rdev)) {
154 			DRM_DEBUG("%s: HDMI deep color %d bpc unsupported. Using 8 bpc.\n",
155 					  connector->name, bpc);
156 			bpc = 8;
157 		}
158 
159 		/*
160 		 * Pre DCE-8 hw can't handle > 12 bpc, and more than 12 bpc doesn't make
161 		 * much sense without support for > 12 bpc framebuffers. RGB 4:4:4 at
162 		 * 12 bpc is always supported on hdmi deep color sinks, as this is
163 		 * required by the HDMI-1.3 spec. Clamp to a safe 12 bpc maximum.
164 		 */
165 		if (bpc > 12) {
166 			DRM_DEBUG("%s: HDMI deep color %d bpc unsupported. Using 12 bpc.\n",
167 					  connector->name, bpc);
168 			bpc = 12;
169 		}
170 
171 		/* Any defined maximum tmds clock limit we must not exceed? */
172 		if (connector->max_tmds_clock > 0) {
173 			/* mode_clock is clock in kHz for mode to be modeset on this connector */
174 			mode_clock = radeon_connector->pixelclock_for_modeset;
175 
176 			/* Maximum allowable input clock in kHz */
177 			max_tmds_clock = connector->max_tmds_clock * 1000;
178 
179 			DRM_DEBUG("%s: hdmi mode dotclock %d kHz, max tmds input clock %d kHz.\n",
180 					  connector->name, mode_clock, max_tmds_clock);
181 
182 			/* Check if bpc is within clock limit. Try to degrade gracefully otherwise */
183 			if ((bpc == 12) && (mode_clock * 3/2 > max_tmds_clock)) {
184 				if ((connector->display_info.edid_hdmi_dc_modes & DRM_EDID_HDMI_DC_30) &&
185 					(mode_clock * 5/4 <= max_tmds_clock))
186 					bpc = 10;
187 				else
188 					bpc = 8;
189 
190 				DRM_DEBUG("%s: HDMI deep color 12 bpc exceeds max tmds clock. Using %d bpc.\n",
191 						  connector->name, bpc);
192 			}
193 
194 			if ((bpc == 10) && (mode_clock * 5/4 > max_tmds_clock)) {
195 				bpc = 8;
196 				DRM_DEBUG("%s: HDMI deep color 10 bpc exceeds max tmds clock. Using %d bpc.\n",
197 						  connector->name, bpc);
198 			}
199 		}
200 	}
201 
202 	DRM_DEBUG("%s: Display bpc=%d, returned bpc=%d\n",
203 			  connector->name, connector->display_info.bpc, bpc);
204 
205 	return bpc;
206 }
207 
208 static void
209 radeon_connector_update_scratch_regs(struct drm_connector *connector, enum drm_connector_status status)
210 {
211 	struct drm_device *dev = connector->dev;
212 	struct radeon_device *rdev = dev->dev_private;
213 	struct drm_encoder *best_encoder = NULL;
214 	struct drm_encoder *encoder = NULL;
215 	struct drm_connector_helper_funcs *connector_funcs = connector->helper_private;
216 	struct drm_mode_object *obj;
217 	bool connected;
218 	int i;
219 
220 	best_encoder = connector_funcs->best_encoder(connector);
221 
222 	for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
223 		if (connector->encoder_ids[i] == 0)
224 			break;
225 
226 		obj = drm_mode_object_find(connector->dev,
227 					   connector->encoder_ids[i],
228 					   DRM_MODE_OBJECT_ENCODER);
229 		if (!obj)
230 			continue;
231 
232 		encoder = obj_to_encoder(obj);
233 
234 		if ((encoder == best_encoder) && (status == connector_status_connected))
235 			connected = true;
236 		else
237 			connected = false;
238 
239 		if (rdev->is_atom_bios)
240 			radeon_atombios_connected_scratch_regs(connector, encoder, connected);
241 		else
242 			radeon_combios_connected_scratch_regs(connector, encoder, connected);
243 
244 	}
245 }
246 
247 static struct drm_encoder *radeon_find_encoder(struct drm_connector *connector, int encoder_type)
248 {
249 	struct drm_mode_object *obj;
250 	struct drm_encoder *encoder;
251 	int i;
252 
253 	for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
254 		if (connector->encoder_ids[i] == 0)
255 			break;
256 
257 		obj = drm_mode_object_find(connector->dev, connector->encoder_ids[i], DRM_MODE_OBJECT_ENCODER);
258 		if (!obj)
259 			continue;
260 
261 		encoder = obj_to_encoder(obj);
262 		if (encoder->encoder_type == encoder_type)
263 			return encoder;
264 	}
265 	return NULL;
266 }
267 
268 static struct drm_encoder *radeon_best_single_encoder(struct drm_connector *connector)
269 {
270 	int enc_id = connector->encoder_ids[0];
271 	struct drm_mode_object *obj;
272 	struct drm_encoder *encoder;
273 
274 	/* pick the encoder ids */
275 	if (enc_id) {
276 		obj = drm_mode_object_find(connector->dev, enc_id, DRM_MODE_OBJECT_ENCODER);
277 		if (!obj)
278 			return NULL;
279 		encoder = obj_to_encoder(obj);
280 		return encoder;
281 	}
282 	return NULL;
283 }
284 
285 /*
286  * radeon_connector_analog_encoder_conflict_solve
287  * - search for other connectors sharing this encoder
288  *   if priority is true, then set them disconnected if this is connected
289  *   if priority is false, set us disconnected if they are connected
290  */
291 static enum drm_connector_status
292 radeon_connector_analog_encoder_conflict_solve(struct drm_connector *connector,
293 					       struct drm_encoder *encoder,
294 					       enum drm_connector_status current_status,
295 					       bool priority)
296 {
297 	struct drm_device *dev = connector->dev;
298 	struct drm_connector *conflict;
299 	struct radeon_connector *radeon_conflict;
300 	int i;
301 
302 	list_for_each_entry(conflict, &dev->mode_config.connector_list, head) {
303 		if (conflict == connector)
304 			continue;
305 
306 		radeon_conflict = to_radeon_connector(conflict);
307 		for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
308 			if (conflict->encoder_ids[i] == 0)
309 				break;
310 
311 			/* if the IDs match */
312 			if (conflict->encoder_ids[i] == encoder->base.id) {
313 				if (conflict->status != connector_status_connected)
314 					continue;
315 
316 				if (radeon_conflict->use_digital)
317 					continue;
318 
319 				if (priority == true) {
320 					DRM_DEBUG_KMS("1: conflicting encoders switching off %s\n",
321 						      conflict->name);
322 					DRM_DEBUG_KMS("in favor of %s\n",
323 						      connector->name);
324 					conflict->status = connector_status_disconnected;
325 					radeon_connector_update_scratch_regs(conflict, connector_status_disconnected);
326 				} else {
327 					DRM_DEBUG_KMS("2: conflicting encoders switching off %s\n",
328 						      connector->name);
329 					DRM_DEBUG_KMS("in favor of %s\n",
330 						      conflict->name);
331 					current_status = connector_status_disconnected;
332 				}
333 				break;
334 			}
335 		}
336 	}
337 	return current_status;
338 
339 }
340 
341 static struct drm_display_mode *radeon_fp_native_mode(struct drm_encoder *encoder)
342 {
343 	struct drm_device *dev = encoder->dev;
344 	struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
345 	struct drm_display_mode *mode = NULL;
346 	struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
347 
348 	if (native_mode->hdisplay != 0 &&
349 	    native_mode->vdisplay != 0 &&
350 	    native_mode->clock != 0) {
351 		mode = drm_mode_duplicate(dev, native_mode);
352 		mode->type = DRM_MODE_TYPE_PREFERRED | DRM_MODE_TYPE_DRIVER;
353 		drm_mode_set_name(mode);
354 
355 		DRM_DEBUG_KMS("Adding native panel mode %s\n", mode->name);
356 	} else if (native_mode->hdisplay != 0 &&
357 		   native_mode->vdisplay != 0) {
358 		/* mac laptops without an edid */
359 		/* Note that this is not necessarily the exact panel mode,
360 		 * but an approximation based on the cvt formula.  For these
361 		 * systems we should ideally read the mode info out of the
362 		 * registers or add a mode table, but this works and is much
363 		 * simpler.
364 		 */
365 		mode = drm_cvt_mode(dev, native_mode->hdisplay, native_mode->vdisplay, 60, true, false, false);
366 		mode->type = DRM_MODE_TYPE_PREFERRED | DRM_MODE_TYPE_DRIVER;
367 		DRM_DEBUG_KMS("Adding cvt approximation of native panel mode %s\n", mode->name);
368 	}
369 	return mode;
370 }
371 
372 static void radeon_add_common_modes(struct drm_encoder *encoder, struct drm_connector *connector)
373 {
374 	struct drm_device *dev = encoder->dev;
375 	struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
376 	struct drm_display_mode *mode = NULL;
377 	struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
378 	int i;
379 	struct mode_size {
380 		int w;
381 		int h;
382 	} common_modes[17] = {
383 		{ 640,  480},
384 		{ 720,  480},
385 		{ 800,  600},
386 		{ 848,  480},
387 		{1024,  768},
388 		{1152,  768},
389 		{1280,  720},
390 		{1280,  800},
391 		{1280,  854},
392 		{1280,  960},
393 		{1280, 1024},
394 		{1440,  900},
395 		{1400, 1050},
396 		{1680, 1050},
397 		{1600, 1200},
398 		{1920, 1080},
399 		{1920, 1200}
400 	};
401 
402 	for (i = 0; i < 17; i++) {
403 		if (radeon_encoder->devices & (ATOM_DEVICE_TV_SUPPORT)) {
404 			if (common_modes[i].w > 1024 ||
405 			    common_modes[i].h > 768)
406 				continue;
407 		}
408 		if (radeon_encoder->devices & (ATOM_DEVICE_LCD_SUPPORT)) {
409 			if (common_modes[i].w > native_mode->hdisplay ||
410 			    common_modes[i].h > native_mode->vdisplay ||
411 			    (common_modes[i].w == native_mode->hdisplay &&
412 			     common_modes[i].h == native_mode->vdisplay))
413 				continue;
414 		}
415 		if (common_modes[i].w < 320 || common_modes[i].h < 200)
416 			continue;
417 
418 		mode = drm_cvt_mode(dev, common_modes[i].w, common_modes[i].h, 60, false, false, false);
419 		drm_mode_probed_add(connector, mode);
420 	}
421 }
422 
423 static int radeon_connector_set_property(struct drm_connector *connector, struct drm_property *property,
424 				  uint64_t val)
425 {
426 	struct drm_device *dev = connector->dev;
427 	struct radeon_device *rdev = dev->dev_private;
428 	struct drm_encoder *encoder;
429 	struct radeon_encoder *radeon_encoder;
430 
431 	if (property == rdev->mode_info.coherent_mode_property) {
432 		struct radeon_encoder_atom_dig *dig;
433 		bool new_coherent_mode;
434 
435 		/* need to find digital encoder on connector */
436 		encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
437 		if (!encoder)
438 			return 0;
439 
440 		radeon_encoder = to_radeon_encoder(encoder);
441 
442 		if (!radeon_encoder->enc_priv)
443 			return 0;
444 
445 		dig = radeon_encoder->enc_priv;
446 		new_coherent_mode = val ? true : false;
447 		if (dig->coherent_mode != new_coherent_mode) {
448 			dig->coherent_mode = new_coherent_mode;
449 			radeon_property_change_mode(&radeon_encoder->base);
450 		}
451 	}
452 
453 	if (property == rdev->mode_info.audio_property) {
454 		struct radeon_connector *radeon_connector = to_radeon_connector(connector);
455 		/* need to find digital encoder on connector */
456 		encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
457 		if (!encoder)
458 			return 0;
459 
460 		radeon_encoder = to_radeon_encoder(encoder);
461 
462 		if (radeon_connector->audio != val) {
463 			radeon_connector->audio = val;
464 			radeon_property_change_mode(&radeon_encoder->base);
465 		}
466 	}
467 
468 	if (property == rdev->mode_info.dither_property) {
469 		struct radeon_connector *radeon_connector = to_radeon_connector(connector);
470 		/* need to find digital encoder on connector */
471 		encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
472 		if (!encoder)
473 			return 0;
474 
475 		radeon_encoder = to_radeon_encoder(encoder);
476 
477 		if (radeon_connector->dither != val) {
478 			radeon_connector->dither = val;
479 			radeon_property_change_mode(&radeon_encoder->base);
480 		}
481 	}
482 
483 	if (property == rdev->mode_info.underscan_property) {
484 		/* need to find digital encoder on connector */
485 		encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
486 		if (!encoder)
487 			return 0;
488 
489 		radeon_encoder = to_radeon_encoder(encoder);
490 
491 		if (radeon_encoder->underscan_type != val) {
492 			radeon_encoder->underscan_type = val;
493 			radeon_property_change_mode(&radeon_encoder->base);
494 		}
495 	}
496 
497 	if (property == rdev->mode_info.underscan_hborder_property) {
498 		/* need to find digital encoder on connector */
499 		encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
500 		if (!encoder)
501 			return 0;
502 
503 		radeon_encoder = to_radeon_encoder(encoder);
504 
505 		if (radeon_encoder->underscan_hborder != val) {
506 			radeon_encoder->underscan_hborder = val;
507 			radeon_property_change_mode(&radeon_encoder->base);
508 		}
509 	}
510 
511 	if (property == rdev->mode_info.underscan_vborder_property) {
512 		/* need to find digital encoder on connector */
513 		encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
514 		if (!encoder)
515 			return 0;
516 
517 		radeon_encoder = to_radeon_encoder(encoder);
518 
519 		if (radeon_encoder->underscan_vborder != val) {
520 			radeon_encoder->underscan_vborder = val;
521 			radeon_property_change_mode(&radeon_encoder->base);
522 		}
523 	}
524 
525 	if (property == rdev->mode_info.tv_std_property) {
526 		encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TVDAC);
527 		if (!encoder) {
528 			encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_DAC);
529 		}
530 
531 		if (!encoder)
532 			return 0;
533 
534 		radeon_encoder = to_radeon_encoder(encoder);
535 		if (!radeon_encoder->enc_priv)
536 			return 0;
537 		if (ASIC_IS_AVIVO(rdev) || radeon_r4xx_atom) {
538 			struct radeon_encoder_atom_dac *dac_int;
539 			dac_int = radeon_encoder->enc_priv;
540 			dac_int->tv_std = val;
541 		} else {
542 			struct radeon_encoder_tv_dac *dac_int;
543 			dac_int = radeon_encoder->enc_priv;
544 			dac_int->tv_std = val;
545 		}
546 		radeon_property_change_mode(&radeon_encoder->base);
547 	}
548 
549 	if (property == rdev->mode_info.load_detect_property) {
550 		struct radeon_connector *radeon_connector =
551 			to_radeon_connector(connector);
552 
553 		if (val == 0)
554 			radeon_connector->dac_load_detect = false;
555 		else
556 			radeon_connector->dac_load_detect = true;
557 	}
558 
559 	if (property == rdev->mode_info.tmds_pll_property) {
560 		struct radeon_encoder_int_tmds *tmds = NULL;
561 		bool ret = false;
562 		/* need to find digital encoder on connector */
563 		encoder = radeon_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
564 		if (!encoder)
565 			return 0;
566 
567 		radeon_encoder = to_radeon_encoder(encoder);
568 
569 		tmds = radeon_encoder->enc_priv;
570 		if (!tmds)
571 			return 0;
572 
573 		if (val == 0) {
574 			if (rdev->is_atom_bios)
575 				ret = radeon_atombios_get_tmds_info(radeon_encoder, tmds);
576 			else
577 				ret = radeon_legacy_get_tmds_info_from_combios(radeon_encoder, tmds);
578 		}
579 		if (val == 1 || ret == false) {
580 			radeon_legacy_get_tmds_info_from_table(radeon_encoder, tmds);
581 		}
582 		radeon_property_change_mode(&radeon_encoder->base);
583 	}
584 
585 	return 0;
586 }
587 
588 static void radeon_fixup_lvds_native_mode(struct drm_encoder *encoder,
589 					  struct drm_connector *connector)
590 {
591 	struct radeon_encoder *radeon_encoder =	to_radeon_encoder(encoder);
592 	struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
593 	struct drm_display_mode *t, *mode;
594 
595 	/* If the EDID preferred mode doesn't match the native mode, use it */
596 	list_for_each_entry_safe(mode, t, &connector->probed_modes, head) {
597 		if (mode->type & DRM_MODE_TYPE_PREFERRED) {
598 			if (mode->hdisplay != native_mode->hdisplay ||
599 			    mode->vdisplay != native_mode->vdisplay)
600 				memcpy(native_mode, mode, sizeof(*mode));
601 		}
602 	}
603 
604 	/* Try to get native mode details from EDID if necessary */
605 	if (!native_mode->clock) {
606 		list_for_each_entry_safe(mode, t, &connector->probed_modes, head) {
607 			if (mode->hdisplay == native_mode->hdisplay &&
608 			    mode->vdisplay == native_mode->vdisplay) {
609 				*native_mode = *mode;
610 				drm_mode_set_crtcinfo(native_mode, CRTC_INTERLACE_HALVE_V);
611 				DRM_DEBUG_KMS("Determined LVDS native mode details from EDID\n");
612 				break;
613 			}
614 		}
615 	}
616 
617 	if (!native_mode->clock) {
618 		DRM_DEBUG_KMS("No LVDS native mode details, disabling RMX\n");
619 		radeon_encoder->rmx_type = RMX_OFF;
620 	}
621 }
622 
623 static int radeon_lvds_get_modes(struct drm_connector *connector)
624 {
625 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
626 	struct drm_encoder *encoder;
627 	int ret = 0;
628 	struct drm_display_mode *mode;
629 
630 	if (radeon_connector->ddc_bus) {
631 		ret = radeon_ddc_get_modes(radeon_connector);
632 		if (ret > 0) {
633 			encoder = radeon_best_single_encoder(connector);
634 			if (encoder) {
635 				radeon_fixup_lvds_native_mode(encoder, connector);
636 				/* add scaled modes */
637 				radeon_add_common_modes(encoder, connector);
638 			}
639 			return ret;
640 		}
641 	}
642 
643 	encoder = radeon_best_single_encoder(connector);
644 	if (!encoder)
645 		return 0;
646 
647 	/* we have no EDID modes */
648 	mode = radeon_fp_native_mode(encoder);
649 	if (mode) {
650 		ret = 1;
651 		drm_mode_probed_add(connector, mode);
652 		/* add the width/height from vbios tables if available */
653 		connector->display_info.width_mm = mode->width_mm;
654 		connector->display_info.height_mm = mode->height_mm;
655 		/* add scaled modes */
656 		radeon_add_common_modes(encoder, connector);
657 	}
658 
659 	return ret;
660 }
661 
662 static int radeon_lvds_mode_valid(struct drm_connector *connector,
663 				  struct drm_display_mode *mode)
664 {
665 	struct drm_encoder *encoder = radeon_best_single_encoder(connector);
666 
667 	if ((mode->hdisplay < 320) || (mode->vdisplay < 240))
668 		return MODE_PANEL;
669 
670 	if (encoder) {
671 		struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
672 		struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
673 
674 		/* AVIVO hardware supports downscaling modes larger than the panel
675 		 * to the panel size, but I'm not sure this is desirable.
676 		 */
677 		if ((mode->hdisplay > native_mode->hdisplay) ||
678 		    (mode->vdisplay > native_mode->vdisplay))
679 			return MODE_PANEL;
680 
681 		/* if scaling is disabled, block non-native modes */
682 		if (radeon_encoder->rmx_type == RMX_OFF) {
683 			if ((mode->hdisplay != native_mode->hdisplay) ||
684 			    (mode->vdisplay != native_mode->vdisplay))
685 				return MODE_PANEL;
686 		}
687 	}
688 
689 	return MODE_OK;
690 }
691 
692 static enum drm_connector_status
693 radeon_lvds_detect(struct drm_connector *connector, bool force)
694 {
695 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
696 	struct drm_encoder *encoder = radeon_best_single_encoder(connector);
697 	enum drm_connector_status ret = connector_status_disconnected;
698 	int r;
699 
700 	r = pm_runtime_get_sync(connector->dev->dev);
701 	if (r < 0)
702 		return connector_status_disconnected;
703 
704 	if (encoder) {
705 		struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
706 		struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
707 
708 		/* check if panel is valid */
709 		if (native_mode->hdisplay >= 320 && native_mode->vdisplay >= 240)
710 			ret = connector_status_connected;
711 
712 	}
713 
714 	/* check for edid as well */
715 	if (radeon_connector->edid)
716 		ret = connector_status_connected;
717 	else {
718 		if (radeon_connector->ddc_bus) {
719 			radeon_connector->edid = drm_get_edid(&radeon_connector->base,
720 							      &radeon_connector->ddc_bus->adapter);
721 			if (radeon_connector->edid)
722 				ret = connector_status_connected;
723 		}
724 	}
725 	/* check acpi lid status ??? */
726 
727 	radeon_connector_update_scratch_regs(connector, ret);
728 	pm_runtime_mark_last_busy(connector->dev->dev);
729 	pm_runtime_put_autosuspend(connector->dev->dev);
730 	return ret;
731 }
732 
733 static void radeon_connector_destroy(struct drm_connector *connector)
734 {
735 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
736 
737 	if (radeon_connector->edid)
738 		kfree(radeon_connector->edid);
739 	kfree(radeon_connector->con_priv);
740 	drm_sysfs_connector_remove(connector);
741 	drm_connector_cleanup(connector);
742 	kfree(connector);
743 }
744 
745 static int radeon_lvds_set_property(struct drm_connector *connector,
746 				    struct drm_property *property,
747 				    uint64_t value)
748 {
749 	struct drm_device *dev = connector->dev;
750 	struct radeon_encoder *radeon_encoder;
751 	enum radeon_rmx_type rmx_type;
752 
753 	DRM_DEBUG_KMS("\n");
754 	if (property != dev->mode_config.scaling_mode_property)
755 		return 0;
756 
757 	if (connector->encoder)
758 		radeon_encoder = to_radeon_encoder(connector->encoder);
759 	else {
760 		struct drm_connector_helper_funcs *connector_funcs = connector->helper_private;
761 		radeon_encoder = to_radeon_encoder(connector_funcs->best_encoder(connector));
762 	}
763 
764 	switch (value) {
765 	case DRM_MODE_SCALE_NONE: rmx_type = RMX_OFF; break;
766 	case DRM_MODE_SCALE_CENTER: rmx_type = RMX_CENTER; break;
767 	case DRM_MODE_SCALE_ASPECT: rmx_type = RMX_ASPECT; break;
768 	default:
769 	case DRM_MODE_SCALE_FULLSCREEN: rmx_type = RMX_FULL; break;
770 	}
771 	if (radeon_encoder->rmx_type == rmx_type)
772 		return 0;
773 
774 	radeon_encoder->rmx_type = rmx_type;
775 
776 	radeon_property_change_mode(&radeon_encoder->base);
777 	return 0;
778 }
779 
780 
781 static const struct drm_connector_helper_funcs radeon_lvds_connector_helper_funcs = {
782 	.get_modes = radeon_lvds_get_modes,
783 	.mode_valid = radeon_lvds_mode_valid,
784 	.best_encoder = radeon_best_single_encoder,
785 };
786 
787 static const struct drm_connector_funcs radeon_lvds_connector_funcs = {
788 	.dpms = drm_helper_connector_dpms,
789 	.detect = radeon_lvds_detect,
790 	.fill_modes = drm_helper_probe_single_connector_modes,
791 	.destroy = radeon_connector_destroy,
792 	.set_property = radeon_lvds_set_property,
793 };
794 
795 static int radeon_vga_get_modes(struct drm_connector *connector)
796 {
797 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
798 	int ret;
799 
800 	ret = radeon_ddc_get_modes(radeon_connector);
801 
802 	return ret;
803 }
804 
805 static int radeon_vga_mode_valid(struct drm_connector *connector,
806 				  struct drm_display_mode *mode)
807 {
808 	struct drm_device *dev = connector->dev;
809 	struct radeon_device *rdev = dev->dev_private;
810 
811 	/* XXX check mode bandwidth */
812 
813 	if ((mode->clock / 10) > rdev->clock.max_pixel_clock)
814 		return MODE_CLOCK_HIGH;
815 
816 	return MODE_OK;
817 }
818 
819 static enum drm_connector_status
820 radeon_vga_detect(struct drm_connector *connector, bool force)
821 {
822 	struct drm_device *dev = connector->dev;
823 	struct radeon_device *rdev = dev->dev_private;
824 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
825 	struct drm_encoder *encoder;
826 	struct drm_encoder_helper_funcs *encoder_funcs;
827 	bool dret = false;
828 	enum drm_connector_status ret = connector_status_disconnected;
829 	int r;
830 
831 	r = pm_runtime_get_sync(connector->dev->dev);
832 	if (r < 0)
833 		return connector_status_disconnected;
834 
835 	encoder = radeon_best_single_encoder(connector);
836 	if (!encoder)
837 		ret = connector_status_disconnected;
838 
839 	if (radeon_connector->ddc_bus)
840 		dret = radeon_ddc_probe(radeon_connector, false);
841 	if (dret) {
842 		radeon_connector->detected_by_load = false;
843 		if (radeon_connector->edid) {
844 			kfree(radeon_connector->edid);
845 			radeon_connector->edid = NULL;
846 		}
847 		radeon_connector->edid = drm_get_edid(&radeon_connector->base, &radeon_connector->ddc_bus->adapter);
848 
849 		if (!radeon_connector->edid) {
850 			DRM_ERROR("%s: probed a monitor but no|invalid EDID\n",
851 					connector->name);
852 			ret = connector_status_connected;
853 		} else {
854 			radeon_connector->use_digital = !!(radeon_connector->edid->input & DRM_EDID_INPUT_DIGITAL);
855 
856 			/* some oems have boards with separate digital and analog connectors
857 			 * with a shared ddc line (often vga + hdmi)
858 			 */
859 			if (radeon_connector->use_digital && radeon_connector->shared_ddc) {
860 				kfree(radeon_connector->edid);
861 				radeon_connector->edid = NULL;
862 				ret = connector_status_disconnected;
863 			} else
864 				ret = connector_status_connected;
865 		}
866 	} else {
867 
868 		/* if we aren't forcing don't do destructive polling */
869 		if (!force) {
870 			/* only return the previous status if we last
871 			 * detected a monitor via load.
872 			 */
873 			if (radeon_connector->detected_by_load)
874 				ret = connector->status;
875 			goto out;
876 		}
877 
878 		if (radeon_connector->dac_load_detect && encoder) {
879 			encoder_funcs = encoder->helper_private;
880 			ret = encoder_funcs->detect(encoder, connector);
881 			if (ret != connector_status_disconnected)
882 				radeon_connector->detected_by_load = true;
883 		}
884 	}
885 
886 	if (ret == connector_status_connected)
887 		ret = radeon_connector_analog_encoder_conflict_solve(connector, encoder, ret, true);
888 
889 	/* RN50 and some RV100 asics in servers often have a hardcoded EDID in the
890 	 * vbios to deal with KVMs. If we have one and are not able to detect a monitor
891 	 * by other means, assume the CRT is connected and use that EDID.
892 	 */
893 	if ((!rdev->is_atom_bios) &&
894 	    (ret == connector_status_disconnected) &&
895 	    rdev->mode_info.bios_hardcoded_edid_size) {
896 		ret = connector_status_connected;
897 	}
898 
899 	radeon_connector_update_scratch_regs(connector, ret);
900 
901 out:
902 	pm_runtime_mark_last_busy(connector->dev->dev);
903 	pm_runtime_put_autosuspend(connector->dev->dev);
904 
905 	return ret;
906 }
907 
908 static const struct drm_connector_helper_funcs radeon_vga_connector_helper_funcs = {
909 	.get_modes = radeon_vga_get_modes,
910 	.mode_valid = radeon_vga_mode_valid,
911 	.best_encoder = radeon_best_single_encoder,
912 };
913 
914 static const struct drm_connector_funcs radeon_vga_connector_funcs = {
915 	.dpms = drm_helper_connector_dpms,
916 	.detect = radeon_vga_detect,
917 	.fill_modes = drm_helper_probe_single_connector_modes,
918 	.destroy = radeon_connector_destroy,
919 	.set_property = radeon_connector_set_property,
920 };
921 
922 static int radeon_tv_get_modes(struct drm_connector *connector)
923 {
924 	struct drm_device *dev = connector->dev;
925 	struct radeon_device *rdev = dev->dev_private;
926 	struct drm_display_mode *tv_mode;
927 	struct drm_encoder *encoder;
928 
929 	encoder = radeon_best_single_encoder(connector);
930 	if (!encoder)
931 		return 0;
932 
933 	/* avivo chips can scale any mode */
934 	if (rdev->family >= CHIP_RS600)
935 		/* add scaled modes */
936 		radeon_add_common_modes(encoder, connector);
937 	else {
938 		/* only 800x600 is supported right now on pre-avivo chips */
939 		tv_mode = drm_cvt_mode(dev, 800, 600, 60, false, false, false);
940 		tv_mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
941 		drm_mode_probed_add(connector, tv_mode);
942 	}
943 	return 1;
944 }
945 
946 static int radeon_tv_mode_valid(struct drm_connector *connector,
947 				struct drm_display_mode *mode)
948 {
949 	if ((mode->hdisplay > 1024) || (mode->vdisplay > 768))
950 		return MODE_CLOCK_RANGE;
951 	return MODE_OK;
952 }
953 
954 static enum drm_connector_status
955 radeon_tv_detect(struct drm_connector *connector, bool force)
956 {
957 	struct drm_encoder *encoder;
958 	struct drm_encoder_helper_funcs *encoder_funcs;
959 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
960 	enum drm_connector_status ret = connector_status_disconnected;
961 	int r;
962 
963 	if (!radeon_connector->dac_load_detect)
964 		return ret;
965 
966 	r = pm_runtime_get_sync(connector->dev->dev);
967 	if (r < 0)
968 		return connector_status_disconnected;
969 
970 	encoder = radeon_best_single_encoder(connector);
971 	if (!encoder)
972 		ret = connector_status_disconnected;
973 	else {
974 		encoder_funcs = encoder->helper_private;
975 		ret = encoder_funcs->detect(encoder, connector);
976 	}
977 	if (ret == connector_status_connected)
978 		ret = radeon_connector_analog_encoder_conflict_solve(connector, encoder, ret, false);
979 	radeon_connector_update_scratch_regs(connector, ret);
980 	pm_runtime_mark_last_busy(connector->dev->dev);
981 	pm_runtime_put_autosuspend(connector->dev->dev);
982 	return ret;
983 }
984 
985 static const struct drm_connector_helper_funcs radeon_tv_connector_helper_funcs = {
986 	.get_modes = radeon_tv_get_modes,
987 	.mode_valid = radeon_tv_mode_valid,
988 	.best_encoder = radeon_best_single_encoder,
989 };
990 
991 static const struct drm_connector_funcs radeon_tv_connector_funcs = {
992 	.dpms = drm_helper_connector_dpms,
993 	.detect = radeon_tv_detect,
994 	.fill_modes = drm_helper_probe_single_connector_modes,
995 	.destroy = radeon_connector_destroy,
996 	.set_property = radeon_connector_set_property,
997 };
998 
999 static int radeon_dvi_get_modes(struct drm_connector *connector)
1000 {
1001 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1002 	int ret;
1003 
1004 	ret = radeon_ddc_get_modes(radeon_connector);
1005 	return ret;
1006 }
1007 
1008 static bool radeon_check_hpd_status_unchanged(struct drm_connector *connector)
1009 {
1010 	struct drm_device *dev = connector->dev;
1011 	struct radeon_device *rdev = dev->dev_private;
1012 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1013 	enum drm_connector_status status;
1014 
1015 	/* We only trust HPD on R600 and newer ASICS. */
1016 	if (rdev->family >= CHIP_R600
1017 	  && radeon_connector->hpd.hpd != RADEON_HPD_NONE) {
1018 		if (radeon_hpd_sense(rdev, radeon_connector->hpd.hpd))
1019 			status = connector_status_connected;
1020 		else
1021 			status = connector_status_disconnected;
1022 		if (connector->status == status)
1023 			return true;
1024 	}
1025 
1026 	return false;
1027 }
1028 
1029 /*
1030  * DVI is complicated
1031  * Do a DDC probe, if DDC probe passes, get the full EDID so
1032  * we can do analog/digital monitor detection at this point.
1033  * If the monitor is an analog monitor or we got no DDC,
1034  * we need to find the DAC encoder object for this connector.
1035  * If we got no DDC, we do load detection on the DAC encoder object.
1036  * If we got analog DDC or load detection passes on the DAC encoder
1037  * we have to check if this analog encoder is shared with anyone else (TV)
1038  * if its shared we have to set the other connector to disconnected.
1039  */
1040 static enum drm_connector_status
1041 radeon_dvi_detect(struct drm_connector *connector, bool force)
1042 {
1043 	struct drm_device *dev = connector->dev;
1044 	struct radeon_device *rdev = dev->dev_private;
1045 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1046 	struct drm_encoder *encoder = NULL;
1047 	struct drm_encoder_helper_funcs *encoder_funcs;
1048 	struct drm_mode_object *obj;
1049 	int i, r;
1050 	enum drm_connector_status ret = connector_status_disconnected;
1051 	bool dret = false, broken_edid = false;
1052 
1053 	r = pm_runtime_get_sync(connector->dev->dev);
1054 	if (r < 0)
1055 		return connector_status_disconnected;
1056 
1057 	if (!force && radeon_check_hpd_status_unchanged(connector)) {
1058 		ret = connector->status;
1059 		goto exit;
1060 	}
1061 
1062 	if (radeon_connector->ddc_bus)
1063 		dret = radeon_ddc_probe(radeon_connector, false);
1064 	if (dret) {
1065 		radeon_connector->detected_by_load = false;
1066 		if (radeon_connector->edid) {
1067 			kfree(radeon_connector->edid);
1068 			radeon_connector->edid = NULL;
1069 		}
1070 		radeon_connector->edid = drm_get_edid(&radeon_connector->base, &radeon_connector->ddc_bus->adapter);
1071 
1072 		if (!radeon_connector->edid) {
1073 			DRM_ERROR("%s: probed a monitor but no|invalid EDID\n",
1074 					connector->name);
1075 			/* rs690 seems to have a problem with connectors not existing and always
1076 			 * return a block of 0's. If we see this just stop polling on this output */
1077 			if ((rdev->family == CHIP_RS690 || rdev->family == CHIP_RS740) && radeon_connector->base.null_edid_counter) {
1078 				ret = connector_status_disconnected;
1079 				DRM_ERROR("%s: detected RS690 floating bus bug, stopping ddc detect\n",
1080 					  connector->name);
1081 				radeon_connector->ddc_bus = NULL;
1082 			} else {
1083 				ret = connector_status_connected;
1084 				broken_edid = true; /* defer use_digital to later */
1085 			}
1086 		} else {
1087 			radeon_connector->use_digital = !!(radeon_connector->edid->input & DRM_EDID_INPUT_DIGITAL);
1088 
1089 			/* some oems have boards with separate digital and analog connectors
1090 			 * with a shared ddc line (often vga + hdmi)
1091 			 */
1092 			if ((!radeon_connector->use_digital) && radeon_connector->shared_ddc) {
1093 				kfree(radeon_connector->edid);
1094 				radeon_connector->edid = NULL;
1095 				ret = connector_status_disconnected;
1096 			} else
1097 				ret = connector_status_connected;
1098 
1099 			/* This gets complicated.  We have boards with VGA + HDMI with a
1100 			 * shared DDC line and we have boards with DVI-D + HDMI with a shared
1101 			 * DDC line.  The latter is more complex because with DVI<->HDMI adapters
1102 			 * you don't really know what's connected to which port as both are digital.
1103 			 */
1104 			if (radeon_connector->shared_ddc && (ret == connector_status_connected)) {
1105 				struct drm_connector *list_connector;
1106 				struct radeon_connector *list_radeon_connector;
1107 				list_for_each_entry(list_connector, &dev->mode_config.connector_list, head) {
1108 					if (connector == list_connector)
1109 						continue;
1110 					list_radeon_connector = to_radeon_connector(list_connector);
1111 					if (list_radeon_connector->shared_ddc &&
1112 					    (list_radeon_connector->ddc_bus->rec.i2c_id ==
1113 					     radeon_connector->ddc_bus->rec.i2c_id)) {
1114 						/* cases where both connectors are digital */
1115 						if (list_connector->connector_type != DRM_MODE_CONNECTOR_VGA) {
1116 							/* hpd is our only option in this case */
1117 							if (!radeon_hpd_sense(rdev, radeon_connector->hpd.hpd)) {
1118 								kfree(radeon_connector->edid);
1119 								radeon_connector->edid = NULL;
1120 								ret = connector_status_disconnected;
1121 							}
1122 						}
1123 					}
1124 				}
1125 			}
1126 		}
1127 	}
1128 
1129 	if ((ret == connector_status_connected) && (radeon_connector->use_digital == true))
1130 		goto out;
1131 
1132 	/* DVI-D and HDMI-A are digital only */
1133 	if ((connector->connector_type == DRM_MODE_CONNECTOR_DVID) ||
1134 	    (connector->connector_type == DRM_MODE_CONNECTOR_HDMIA))
1135 		goto out;
1136 
1137 	/* if we aren't forcing don't do destructive polling */
1138 	if (!force) {
1139 		/* only return the previous status if we last
1140 		 * detected a monitor via load.
1141 		 */
1142 		if (radeon_connector->detected_by_load)
1143 			ret = connector->status;
1144 		goto out;
1145 	}
1146 
1147 	/* find analog encoder */
1148 	if (radeon_connector->dac_load_detect) {
1149 		for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
1150 			if (connector->encoder_ids[i] == 0)
1151 				break;
1152 
1153 			obj = drm_mode_object_find(connector->dev,
1154 						   connector->encoder_ids[i],
1155 						   DRM_MODE_OBJECT_ENCODER);
1156 			if (!obj)
1157 				continue;
1158 
1159 			encoder = obj_to_encoder(obj);
1160 
1161 			if (encoder->encoder_type != DRM_MODE_ENCODER_DAC &&
1162 			    encoder->encoder_type != DRM_MODE_ENCODER_TVDAC)
1163 				continue;
1164 
1165 			encoder_funcs = encoder->helper_private;
1166 			if (encoder_funcs->detect) {
1167 				if (!broken_edid) {
1168 					if (ret != connector_status_connected) {
1169 						/* deal with analog monitors without DDC */
1170 						ret = encoder_funcs->detect(encoder, connector);
1171 						if (ret == connector_status_connected) {
1172 							radeon_connector->use_digital = false;
1173 						}
1174 						if (ret != connector_status_disconnected)
1175 							radeon_connector->detected_by_load = true;
1176 					}
1177 				} else {
1178 					enum drm_connector_status lret;
1179 					/* assume digital unless load detected otherwise */
1180 					radeon_connector->use_digital = true;
1181 					lret = encoder_funcs->detect(encoder, connector);
1182 					DRM_DEBUG_KMS("load_detect %x returned: %x\n",encoder->encoder_type,lret);
1183 					if (lret == connector_status_connected)
1184 						radeon_connector->use_digital = false;
1185 				}
1186 				break;
1187 			}
1188 		}
1189 	}
1190 
1191 	if ((ret == connector_status_connected) && (radeon_connector->use_digital == false) &&
1192 	    encoder) {
1193 		ret = radeon_connector_analog_encoder_conflict_solve(connector, encoder, ret, true);
1194 	}
1195 
1196 	/* RN50 and some RV100 asics in servers often have a hardcoded EDID in the
1197 	 * vbios to deal with KVMs. If we have one and are not able to detect a monitor
1198 	 * by other means, assume the DFP is connected and use that EDID.  In most
1199 	 * cases the DVI port is actually a virtual KVM port connected to the service
1200 	 * processor.
1201 	 */
1202 out:
1203 	if ((!rdev->is_atom_bios) &&
1204 	    (ret == connector_status_disconnected) &&
1205 	    rdev->mode_info.bios_hardcoded_edid_size) {
1206 		radeon_connector->use_digital = true;
1207 		ret = connector_status_connected;
1208 	}
1209 
1210 	/* updated in get modes as well since we need to know if it's analog or digital */
1211 	radeon_connector_update_scratch_regs(connector, ret);
1212 
1213 exit:
1214 	pm_runtime_mark_last_busy(connector->dev->dev);
1215 	pm_runtime_put_autosuspend(connector->dev->dev);
1216 
1217 	return ret;
1218 }
1219 
1220 /* okay need to be smart in here about which encoder to pick */
1221 static struct drm_encoder *radeon_dvi_encoder(struct drm_connector *connector)
1222 {
1223 	int enc_id = connector->encoder_ids[0];
1224 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1225 	struct drm_mode_object *obj;
1226 	struct drm_encoder *encoder;
1227 	int i;
1228 	for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
1229 		if (connector->encoder_ids[i] == 0)
1230 			break;
1231 
1232 		obj = drm_mode_object_find(connector->dev, connector->encoder_ids[i], DRM_MODE_OBJECT_ENCODER);
1233 		if (!obj)
1234 			continue;
1235 
1236 		encoder = obj_to_encoder(obj);
1237 
1238 		if (radeon_connector->use_digital == true) {
1239 			if (encoder->encoder_type == DRM_MODE_ENCODER_TMDS)
1240 				return encoder;
1241 		} else {
1242 			if (encoder->encoder_type == DRM_MODE_ENCODER_DAC ||
1243 			    encoder->encoder_type == DRM_MODE_ENCODER_TVDAC)
1244 				return encoder;
1245 		}
1246 	}
1247 
1248 	/* see if we have a default encoder  TODO */
1249 
1250 	/* then check use digitial */
1251 	/* pick the first one */
1252 	if (enc_id) {
1253 		obj = drm_mode_object_find(connector->dev, enc_id, DRM_MODE_OBJECT_ENCODER);
1254 		if (!obj)
1255 			return NULL;
1256 		encoder = obj_to_encoder(obj);
1257 		return encoder;
1258 	}
1259 	return NULL;
1260 }
1261 
1262 static void radeon_dvi_force(struct drm_connector *connector)
1263 {
1264 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1265 	if (connector->force == DRM_FORCE_ON)
1266 		radeon_connector->use_digital = false;
1267 	if (connector->force == DRM_FORCE_ON_DIGITAL)
1268 		radeon_connector->use_digital = true;
1269 }
1270 
1271 static int radeon_dvi_mode_valid(struct drm_connector *connector,
1272 				  struct drm_display_mode *mode)
1273 {
1274 	struct drm_device *dev = connector->dev;
1275 	struct radeon_device *rdev = dev->dev_private;
1276 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1277 
1278 	/* XXX check mode bandwidth */
1279 
1280 	/* clocks over 135 MHz have heat issues with DVI on RV100 */
1281 	if (radeon_connector->use_digital &&
1282 	    (rdev->family == CHIP_RV100) &&
1283 	    (mode->clock > 135000))
1284 		return MODE_CLOCK_HIGH;
1285 
1286 	if (radeon_connector->use_digital && (mode->clock > 165000)) {
1287 		if ((radeon_connector->connector_object_id == CONNECTOR_OBJECT_ID_DUAL_LINK_DVI_I) ||
1288 		    (radeon_connector->connector_object_id == CONNECTOR_OBJECT_ID_DUAL_LINK_DVI_D) ||
1289 		    (radeon_connector->connector_object_id == CONNECTOR_OBJECT_ID_HDMI_TYPE_B))
1290 			return MODE_OK;
1291 		else if (ASIC_IS_DCE6(rdev) && drm_detect_hdmi_monitor(radeon_connector->edid)) {
1292 			/* HDMI 1.3+ supports max clock of 340 Mhz */
1293 			if (mode->clock > 340000)
1294 				return MODE_CLOCK_HIGH;
1295 			else
1296 				return MODE_OK;
1297 		} else {
1298 			return MODE_CLOCK_HIGH;
1299 		}
1300 	}
1301 
1302 	/* check against the max pixel clock */
1303 	if ((mode->clock / 10) > rdev->clock.max_pixel_clock)
1304 		return MODE_CLOCK_HIGH;
1305 
1306 	return MODE_OK;
1307 }
1308 
1309 static const struct drm_connector_helper_funcs radeon_dvi_connector_helper_funcs = {
1310 	.get_modes = radeon_dvi_get_modes,
1311 	.mode_valid = radeon_dvi_mode_valid,
1312 	.best_encoder = radeon_dvi_encoder,
1313 };
1314 
1315 static const struct drm_connector_funcs radeon_dvi_connector_funcs = {
1316 	.dpms = drm_helper_connector_dpms,
1317 	.detect = radeon_dvi_detect,
1318 	.fill_modes = drm_helper_probe_single_connector_modes,
1319 	.set_property = radeon_connector_set_property,
1320 	.destroy = radeon_connector_destroy,
1321 	.force = radeon_dvi_force,
1322 };
1323 
1324 static int radeon_dp_get_modes(struct drm_connector *connector)
1325 {
1326 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1327 	struct radeon_connector_atom_dig *radeon_dig_connector = radeon_connector->con_priv;
1328 	struct drm_encoder *encoder = radeon_best_single_encoder(connector);
1329 	int ret;
1330 
1331 	if ((connector->connector_type == DRM_MODE_CONNECTOR_eDP) ||
1332 	    (connector->connector_type == DRM_MODE_CONNECTOR_LVDS)) {
1333 		struct drm_display_mode *mode;
1334 
1335 		if (connector->connector_type == DRM_MODE_CONNECTOR_eDP) {
1336 			if (!radeon_dig_connector->edp_on)
1337 				atombios_set_edp_panel_power(connector,
1338 							     ATOM_TRANSMITTER_ACTION_POWER_ON);
1339 			ret = radeon_ddc_get_modes(radeon_connector);
1340 			if (!radeon_dig_connector->edp_on)
1341 				atombios_set_edp_panel_power(connector,
1342 							     ATOM_TRANSMITTER_ACTION_POWER_OFF);
1343 		} else {
1344 			/* need to setup ddc on the bridge */
1345 			if (radeon_connector_encoder_get_dp_bridge_encoder_id(connector) !=
1346 			    ENCODER_OBJECT_ID_NONE) {
1347 				if (encoder)
1348 					radeon_atom_ext_encoder_setup_ddc(encoder);
1349 			}
1350 			ret = radeon_ddc_get_modes(radeon_connector);
1351 		}
1352 
1353 		if (ret > 0) {
1354 			if (encoder) {
1355 				radeon_fixup_lvds_native_mode(encoder, connector);
1356 				/* add scaled modes */
1357 				radeon_add_common_modes(encoder, connector);
1358 			}
1359 			return ret;
1360 		}
1361 
1362 		if (!encoder)
1363 			return 0;
1364 
1365 		/* we have no EDID modes */
1366 		mode = radeon_fp_native_mode(encoder);
1367 		if (mode) {
1368 			ret = 1;
1369 			drm_mode_probed_add(connector, mode);
1370 			/* add the width/height from vbios tables if available */
1371 			connector->display_info.width_mm = mode->width_mm;
1372 			connector->display_info.height_mm = mode->height_mm;
1373 			/* add scaled modes */
1374 			radeon_add_common_modes(encoder, connector);
1375 		}
1376 	} else {
1377 		/* need to setup ddc on the bridge */
1378 		if (radeon_connector_encoder_get_dp_bridge_encoder_id(connector) !=
1379 			ENCODER_OBJECT_ID_NONE) {
1380 			if (encoder)
1381 				radeon_atom_ext_encoder_setup_ddc(encoder);
1382 		}
1383 		ret = radeon_ddc_get_modes(radeon_connector);
1384 	}
1385 
1386 	return ret;
1387 }
1388 
1389 u16 radeon_connector_encoder_get_dp_bridge_encoder_id(struct drm_connector *connector)
1390 {
1391 	struct drm_mode_object *obj;
1392 	struct drm_encoder *encoder;
1393 	struct radeon_encoder *radeon_encoder;
1394 	int i;
1395 
1396 	for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
1397 		if (connector->encoder_ids[i] == 0)
1398 			break;
1399 
1400 		obj = drm_mode_object_find(connector->dev, connector->encoder_ids[i], DRM_MODE_OBJECT_ENCODER);
1401 		if (!obj)
1402 			continue;
1403 
1404 		encoder = obj_to_encoder(obj);
1405 		radeon_encoder = to_radeon_encoder(encoder);
1406 
1407 		switch (radeon_encoder->encoder_id) {
1408 		case ENCODER_OBJECT_ID_TRAVIS:
1409 		case ENCODER_OBJECT_ID_NUTMEG:
1410 			return radeon_encoder->encoder_id;
1411 		default:
1412 			break;
1413 		}
1414 	}
1415 
1416 	return ENCODER_OBJECT_ID_NONE;
1417 }
1418 
1419 bool radeon_connector_encoder_is_hbr2(struct drm_connector *connector)
1420 {
1421 	struct drm_mode_object *obj;
1422 	struct drm_encoder *encoder;
1423 	struct radeon_encoder *radeon_encoder;
1424 	int i;
1425 	bool found = false;
1426 
1427 	for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
1428 		if (connector->encoder_ids[i] == 0)
1429 			break;
1430 
1431 		obj = drm_mode_object_find(connector->dev, connector->encoder_ids[i], DRM_MODE_OBJECT_ENCODER);
1432 		if (!obj)
1433 			continue;
1434 
1435 		encoder = obj_to_encoder(obj);
1436 		radeon_encoder = to_radeon_encoder(encoder);
1437 		if (radeon_encoder->caps & ATOM_ENCODER_CAP_RECORD_HBR2)
1438 			found = true;
1439 	}
1440 
1441 	return found;
1442 }
1443 
1444 bool radeon_connector_is_dp12_capable(struct drm_connector *connector)
1445 {
1446 	struct drm_device *dev = connector->dev;
1447 	struct radeon_device *rdev = dev->dev_private;
1448 
1449 	if (ASIC_IS_DCE5(rdev) &&
1450 	    (rdev->clock.default_dispclk >= 53900) &&
1451 	    radeon_connector_encoder_is_hbr2(connector)) {
1452 		return true;
1453 	}
1454 
1455 	return false;
1456 }
1457 
1458 static enum drm_connector_status
1459 radeon_dp_detect(struct drm_connector *connector, bool force)
1460 {
1461 	struct drm_device *dev = connector->dev;
1462 	struct radeon_device *rdev = dev->dev_private;
1463 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1464 	enum drm_connector_status ret = connector_status_disconnected;
1465 	struct radeon_connector_atom_dig *radeon_dig_connector = radeon_connector->con_priv;
1466 	struct drm_encoder *encoder = radeon_best_single_encoder(connector);
1467 	int r;
1468 
1469 	r = pm_runtime_get_sync(connector->dev->dev);
1470 	if (r < 0)
1471 		return connector_status_disconnected;
1472 
1473 	if (!force && radeon_check_hpd_status_unchanged(connector)) {
1474 		ret = connector->status;
1475 		goto out;
1476 	}
1477 
1478 	if (radeon_connector->edid) {
1479 		kfree(radeon_connector->edid);
1480 		radeon_connector->edid = NULL;
1481 	}
1482 
1483 	if ((connector->connector_type == DRM_MODE_CONNECTOR_eDP) ||
1484 	    (connector->connector_type == DRM_MODE_CONNECTOR_LVDS)) {
1485 		if (encoder) {
1486 			struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
1487 			struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
1488 
1489 			/* check if panel is valid */
1490 			if (native_mode->hdisplay >= 320 && native_mode->vdisplay >= 240)
1491 				ret = connector_status_connected;
1492 		}
1493 		/* eDP is always DP */
1494 		radeon_dig_connector->dp_sink_type = CONNECTOR_OBJECT_ID_DISPLAYPORT;
1495 		if (!radeon_dig_connector->edp_on)
1496 			atombios_set_edp_panel_power(connector,
1497 						     ATOM_TRANSMITTER_ACTION_POWER_ON);
1498 		if (radeon_dp_getdpcd(radeon_connector))
1499 			ret = connector_status_connected;
1500 		if (!radeon_dig_connector->edp_on)
1501 			atombios_set_edp_panel_power(connector,
1502 						     ATOM_TRANSMITTER_ACTION_POWER_OFF);
1503 	} else if (radeon_connector_encoder_get_dp_bridge_encoder_id(connector) !=
1504 		   ENCODER_OBJECT_ID_NONE) {
1505 		/* DP bridges are always DP */
1506 		radeon_dig_connector->dp_sink_type = CONNECTOR_OBJECT_ID_DISPLAYPORT;
1507 		/* get the DPCD from the bridge */
1508 		radeon_dp_getdpcd(radeon_connector);
1509 
1510 		if (encoder) {
1511 			/* setup ddc on the bridge */
1512 			radeon_atom_ext_encoder_setup_ddc(encoder);
1513 			/* bridge chips are always aux */
1514 			if (radeon_ddc_probe(radeon_connector, true)) /* try DDC */
1515 				ret = connector_status_connected;
1516 			else if (radeon_connector->dac_load_detect) { /* try load detection */
1517 				struct drm_encoder_helper_funcs *encoder_funcs = encoder->helper_private;
1518 				ret = encoder_funcs->detect(encoder, connector);
1519 			}
1520 		}
1521 	} else {
1522 		radeon_dig_connector->dp_sink_type = radeon_dp_getsinktype(radeon_connector);
1523 		if (radeon_hpd_sense(rdev, radeon_connector->hpd.hpd)) {
1524 			ret = connector_status_connected;
1525 			if (radeon_dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT)
1526 				radeon_dp_getdpcd(radeon_connector);
1527 		} else {
1528 			if (radeon_dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT) {
1529 				if (radeon_dp_getdpcd(radeon_connector))
1530 					ret = connector_status_connected;
1531 			} else {
1532 				/* try non-aux ddc (DP to DVI/HDMI/etc. adapter) */
1533 				if (radeon_ddc_probe(radeon_connector, false))
1534 					ret = connector_status_connected;
1535 			}
1536 		}
1537 	}
1538 
1539 	radeon_connector_update_scratch_regs(connector, ret);
1540 out:
1541 	pm_runtime_mark_last_busy(connector->dev->dev);
1542 	pm_runtime_put_autosuspend(connector->dev->dev);
1543 
1544 	return ret;
1545 }
1546 
1547 static int radeon_dp_mode_valid(struct drm_connector *connector,
1548 				  struct drm_display_mode *mode)
1549 {
1550 	struct drm_device *dev = connector->dev;
1551 	struct radeon_device *rdev = dev->dev_private;
1552 	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
1553 	struct radeon_connector_atom_dig *radeon_dig_connector = radeon_connector->con_priv;
1554 
1555 	/* XXX check mode bandwidth */
1556 
1557 	if ((connector->connector_type == DRM_MODE_CONNECTOR_eDP) ||
1558 	    (connector->connector_type == DRM_MODE_CONNECTOR_LVDS)) {
1559 		struct drm_encoder *encoder = radeon_best_single_encoder(connector);
1560 
1561 		if ((mode->hdisplay < 320) || (mode->vdisplay < 240))
1562 			return MODE_PANEL;
1563 
1564 		if (encoder) {
1565 			struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
1566 			struct drm_display_mode *native_mode = &radeon_encoder->native_mode;
1567 
1568 			/* AVIVO hardware supports downscaling modes larger than the panel
1569 			 * to the panel size, but I'm not sure this is desirable.
1570 			 */
1571 			if ((mode->hdisplay > native_mode->hdisplay) ||
1572 			    (mode->vdisplay > native_mode->vdisplay))
1573 				return MODE_PANEL;
1574 
1575 			/* if scaling is disabled, block non-native modes */
1576 			if (radeon_encoder->rmx_type == RMX_OFF) {
1577 				if ((mode->hdisplay != native_mode->hdisplay) ||
1578 				    (mode->vdisplay != native_mode->vdisplay))
1579 					return MODE_PANEL;
1580 			}
1581 		}
1582 	} else {
1583 		if ((radeon_dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT) ||
1584 		    (radeon_dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_eDP)) {
1585 			return radeon_dp_mode_valid_helper(connector, mode);
1586 		} else {
1587 			if (ASIC_IS_DCE6(rdev) && drm_detect_hdmi_monitor(radeon_connector->edid)) {
1588 				/* HDMI 1.3+ supports max clock of 340 Mhz */
1589 				if (mode->clock > 340000)
1590 					return MODE_CLOCK_HIGH;
1591 			} else {
1592 				if (mode->clock > 165000)
1593 					return MODE_CLOCK_HIGH;
1594 			}
1595 		}
1596 	}
1597 
1598 	return MODE_OK;
1599 }
1600 
1601 static const struct drm_connector_helper_funcs radeon_dp_connector_helper_funcs = {
1602 	.get_modes = radeon_dp_get_modes,
1603 	.mode_valid = radeon_dp_mode_valid,
1604 	.best_encoder = radeon_dvi_encoder,
1605 };
1606 
1607 static const struct drm_connector_funcs radeon_dp_connector_funcs = {
1608 	.dpms = drm_helper_connector_dpms,
1609 	.detect = radeon_dp_detect,
1610 	.fill_modes = drm_helper_probe_single_connector_modes,
1611 	.set_property = radeon_connector_set_property,
1612 	.destroy = radeon_connector_destroy,
1613 	.force = radeon_dvi_force,
1614 };
1615 
1616 static const struct drm_connector_funcs radeon_edp_connector_funcs = {
1617 	.dpms = drm_helper_connector_dpms,
1618 	.detect = radeon_dp_detect,
1619 	.fill_modes = drm_helper_probe_single_connector_modes,
1620 	.set_property = radeon_lvds_set_property,
1621 	.destroy = radeon_connector_destroy,
1622 	.force = radeon_dvi_force,
1623 };
1624 
1625 static const struct drm_connector_funcs radeon_lvds_bridge_connector_funcs = {
1626 	.dpms = drm_helper_connector_dpms,
1627 	.detect = radeon_dp_detect,
1628 	.fill_modes = drm_helper_probe_single_connector_modes,
1629 	.set_property = radeon_lvds_set_property,
1630 	.destroy = radeon_connector_destroy,
1631 	.force = radeon_dvi_force,
1632 };
1633 
1634 void
1635 radeon_add_atom_connector(struct drm_device *dev,
1636 			  uint32_t connector_id,
1637 			  uint32_t supported_device,
1638 			  int connector_type,
1639 			  struct radeon_i2c_bus_rec *i2c_bus,
1640 			  uint32_t igp_lane_info,
1641 			  uint16_t connector_object_id,
1642 			  struct radeon_hpd *hpd,
1643 			  struct radeon_router *router)
1644 {
1645 	struct radeon_device *rdev = dev->dev_private;
1646 	struct drm_connector *connector;
1647 	struct radeon_connector *radeon_connector;
1648 	struct radeon_connector_atom_dig *radeon_dig_connector;
1649 	struct drm_encoder *encoder;
1650 	struct radeon_encoder *radeon_encoder;
1651 	uint32_t subpixel_order = SubPixelNone;
1652 	bool shared_ddc = false;
1653 	bool is_dp_bridge = false;
1654 	bool has_aux = false;
1655 
1656 	if (connector_type == DRM_MODE_CONNECTOR_Unknown)
1657 		return;
1658 
1659 	/* if the user selected tv=0 don't try and add the connector */
1660 	if (((connector_type == DRM_MODE_CONNECTOR_SVIDEO) ||
1661 	     (connector_type == DRM_MODE_CONNECTOR_Composite) ||
1662 	     (connector_type == DRM_MODE_CONNECTOR_9PinDIN)) &&
1663 	    (radeon_tv == 0))
1664 		return;
1665 
1666 	/* see if we already added it */
1667 	list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
1668 		radeon_connector = to_radeon_connector(connector);
1669 		if (radeon_connector->connector_id == connector_id) {
1670 			radeon_connector->devices |= supported_device;
1671 			return;
1672 		}
1673 		if (radeon_connector->ddc_bus && i2c_bus->valid) {
1674 			if (radeon_connector->ddc_bus->rec.i2c_id == i2c_bus->i2c_id) {
1675 				radeon_connector->shared_ddc = true;
1676 				shared_ddc = true;
1677 			}
1678 			if (radeon_connector->router_bus && router->ddc_valid &&
1679 			    (radeon_connector->router.router_id == router->router_id)) {
1680 				radeon_connector->shared_ddc = false;
1681 				shared_ddc = false;
1682 			}
1683 		}
1684 	}
1685 
1686 	/* check if it's a dp bridge */
1687 	list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {
1688 		radeon_encoder = to_radeon_encoder(encoder);
1689 		if (radeon_encoder->devices & supported_device) {
1690 			switch (radeon_encoder->encoder_id) {
1691 			case ENCODER_OBJECT_ID_TRAVIS:
1692 			case ENCODER_OBJECT_ID_NUTMEG:
1693 				is_dp_bridge = true;
1694 				break;
1695 			default:
1696 				break;
1697 			}
1698 		}
1699 	}
1700 
1701 	radeon_connector = kzalloc(sizeof(struct radeon_connector), GFP_KERNEL);
1702 	if (!radeon_connector)
1703 		return;
1704 
1705 	connector = &radeon_connector->base;
1706 
1707 	radeon_connector->connector_id = connector_id;
1708 	radeon_connector->devices = supported_device;
1709 	radeon_connector->shared_ddc = shared_ddc;
1710 	radeon_connector->connector_object_id = connector_object_id;
1711 	radeon_connector->hpd = *hpd;
1712 
1713 	radeon_connector->router = *router;
1714 	if (router->ddc_valid || router->cd_valid) {
1715 		radeon_connector->router_bus = radeon_i2c_lookup(rdev, &router->i2c_info);
1716 		if (!radeon_connector->router_bus)
1717 			DRM_ERROR("Failed to assign router i2c bus! Check dmesg for i2c errors.\n");
1718 	}
1719 
1720 	if (is_dp_bridge) {
1721 		radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
1722 		if (!radeon_dig_connector)
1723 			goto failed;
1724 		radeon_dig_connector->igp_lane_info = igp_lane_info;
1725 		radeon_connector->con_priv = radeon_dig_connector;
1726 		if (i2c_bus->valid) {
1727 			radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
1728 			if (radeon_connector->ddc_bus)
1729 				has_aux = true;
1730 			else
1731 				DRM_ERROR("DP: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1732 		}
1733 		switch (connector_type) {
1734 		case DRM_MODE_CONNECTOR_VGA:
1735 		case DRM_MODE_CONNECTOR_DVIA:
1736 		default:
1737 			drm_connector_init(dev, &radeon_connector->base,
1738 					   &radeon_dp_connector_funcs, connector_type);
1739 			drm_connector_helper_add(&radeon_connector->base,
1740 						 &radeon_dp_connector_helper_funcs);
1741 			connector->interlace_allowed = true;
1742 			connector->doublescan_allowed = true;
1743 			radeon_connector->dac_load_detect = true;
1744 			drm_object_attach_property(&radeon_connector->base.base,
1745 						      rdev->mode_info.load_detect_property,
1746 						      1);
1747 			break;
1748 		case DRM_MODE_CONNECTOR_DVII:
1749 		case DRM_MODE_CONNECTOR_DVID:
1750 		case DRM_MODE_CONNECTOR_HDMIA:
1751 		case DRM_MODE_CONNECTOR_HDMIB:
1752 		case DRM_MODE_CONNECTOR_DisplayPort:
1753 			drm_connector_init(dev, &radeon_connector->base,
1754 					   &radeon_dp_connector_funcs, connector_type);
1755 			drm_connector_helper_add(&radeon_connector->base,
1756 						 &radeon_dp_connector_helper_funcs);
1757 			drm_object_attach_property(&radeon_connector->base.base,
1758 						      rdev->mode_info.underscan_property,
1759 						      UNDERSCAN_OFF);
1760 			drm_object_attach_property(&radeon_connector->base.base,
1761 						      rdev->mode_info.underscan_hborder_property,
1762 						      0);
1763 			drm_object_attach_property(&radeon_connector->base.base,
1764 						      rdev->mode_info.underscan_vborder_property,
1765 						      0);
1766 
1767 			drm_object_attach_property(&radeon_connector->base.base,
1768 						   rdev->mode_info.dither_property,
1769 						   RADEON_FMT_DITHER_DISABLE);
1770 
1771 			if (radeon_audio != 0)
1772 				drm_object_attach_property(&radeon_connector->base.base,
1773 							   rdev->mode_info.audio_property,
1774 							   RADEON_AUDIO_AUTO);
1775 
1776 			subpixel_order = SubPixelHorizontalRGB;
1777 			connector->interlace_allowed = true;
1778 			if (connector_type == DRM_MODE_CONNECTOR_HDMIB)
1779 				connector->doublescan_allowed = true;
1780 			else
1781 				connector->doublescan_allowed = false;
1782 			if (connector_type == DRM_MODE_CONNECTOR_DVII) {
1783 				radeon_connector->dac_load_detect = true;
1784 				drm_object_attach_property(&radeon_connector->base.base,
1785 							      rdev->mode_info.load_detect_property,
1786 							      1);
1787 			}
1788 			break;
1789 		case DRM_MODE_CONNECTOR_LVDS:
1790 		case DRM_MODE_CONNECTOR_eDP:
1791 			drm_connector_init(dev, &radeon_connector->base,
1792 					   &radeon_lvds_bridge_connector_funcs, connector_type);
1793 			drm_connector_helper_add(&radeon_connector->base,
1794 						 &radeon_dp_connector_helper_funcs);
1795 			drm_object_attach_property(&radeon_connector->base.base,
1796 						      dev->mode_config.scaling_mode_property,
1797 						      DRM_MODE_SCALE_FULLSCREEN);
1798 			subpixel_order = SubPixelHorizontalRGB;
1799 			connector->interlace_allowed = false;
1800 			connector->doublescan_allowed = false;
1801 			break;
1802 		}
1803 	} else {
1804 		switch (connector_type) {
1805 		case DRM_MODE_CONNECTOR_VGA:
1806 			drm_connector_init(dev, &radeon_connector->base, &radeon_vga_connector_funcs, connector_type);
1807 			drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
1808 			if (i2c_bus->valid) {
1809 				radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
1810 				if (!radeon_connector->ddc_bus)
1811 					DRM_ERROR("VGA: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1812 			}
1813 			radeon_connector->dac_load_detect = true;
1814 			drm_object_attach_property(&radeon_connector->base.base,
1815 						      rdev->mode_info.load_detect_property,
1816 						      1);
1817 			/* no HPD on analog connectors */
1818 			radeon_connector->hpd.hpd = RADEON_HPD_NONE;
1819 			connector->polled = DRM_CONNECTOR_POLL_CONNECT;
1820 			connector->interlace_allowed = true;
1821 			connector->doublescan_allowed = true;
1822 			break;
1823 		case DRM_MODE_CONNECTOR_DVIA:
1824 			drm_connector_init(dev, &radeon_connector->base, &radeon_vga_connector_funcs, connector_type);
1825 			drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
1826 			if (i2c_bus->valid) {
1827 				radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
1828 				if (!radeon_connector->ddc_bus)
1829 					DRM_ERROR("DVIA: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1830 			}
1831 			radeon_connector->dac_load_detect = true;
1832 			drm_object_attach_property(&radeon_connector->base.base,
1833 						      rdev->mode_info.load_detect_property,
1834 						      1);
1835 			/* no HPD on analog connectors */
1836 			radeon_connector->hpd.hpd = RADEON_HPD_NONE;
1837 			connector->interlace_allowed = true;
1838 			connector->doublescan_allowed = true;
1839 			break;
1840 		case DRM_MODE_CONNECTOR_DVII:
1841 		case DRM_MODE_CONNECTOR_DVID:
1842 			radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
1843 			if (!radeon_dig_connector)
1844 				goto failed;
1845 			radeon_dig_connector->igp_lane_info = igp_lane_info;
1846 			radeon_connector->con_priv = radeon_dig_connector;
1847 			drm_connector_init(dev, &radeon_connector->base, &radeon_dvi_connector_funcs, connector_type);
1848 			drm_connector_helper_add(&radeon_connector->base, &radeon_dvi_connector_helper_funcs);
1849 			if (i2c_bus->valid) {
1850 				radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
1851 				if (!radeon_connector->ddc_bus)
1852 					DRM_ERROR("DVI: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1853 			}
1854 			subpixel_order = SubPixelHorizontalRGB;
1855 			drm_object_attach_property(&radeon_connector->base.base,
1856 						      rdev->mode_info.coherent_mode_property,
1857 						      1);
1858 			if (ASIC_IS_AVIVO(rdev)) {
1859 				drm_object_attach_property(&radeon_connector->base.base,
1860 							      rdev->mode_info.underscan_property,
1861 							      UNDERSCAN_OFF);
1862 				drm_object_attach_property(&radeon_connector->base.base,
1863 							      rdev->mode_info.underscan_hborder_property,
1864 							      0);
1865 				drm_object_attach_property(&radeon_connector->base.base,
1866 							      rdev->mode_info.underscan_vborder_property,
1867 							      0);
1868 			}
1869 			if (ASIC_IS_DCE2(rdev) && (radeon_audio != 0)) {
1870 				drm_object_attach_property(&radeon_connector->base.base,
1871 							   rdev->mode_info.audio_property,
1872 							   RADEON_AUDIO_AUTO);
1873 			}
1874 			if (ASIC_IS_AVIVO(rdev)) {
1875 				drm_object_attach_property(&radeon_connector->base.base,
1876 							   rdev->mode_info.dither_property,
1877 							   RADEON_FMT_DITHER_DISABLE);
1878 			}
1879 			if (connector_type == DRM_MODE_CONNECTOR_DVII) {
1880 				radeon_connector->dac_load_detect = true;
1881 				drm_object_attach_property(&radeon_connector->base.base,
1882 							      rdev->mode_info.load_detect_property,
1883 							      1);
1884 			}
1885 			connector->interlace_allowed = true;
1886 			if (connector_type == DRM_MODE_CONNECTOR_DVII)
1887 				connector->doublescan_allowed = true;
1888 			else
1889 				connector->doublescan_allowed = false;
1890 			break;
1891 		case DRM_MODE_CONNECTOR_HDMIA:
1892 		case DRM_MODE_CONNECTOR_HDMIB:
1893 			radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
1894 			if (!radeon_dig_connector)
1895 				goto failed;
1896 			radeon_dig_connector->igp_lane_info = igp_lane_info;
1897 			radeon_connector->con_priv = radeon_dig_connector;
1898 			drm_connector_init(dev, &radeon_connector->base, &radeon_dvi_connector_funcs, connector_type);
1899 			drm_connector_helper_add(&radeon_connector->base, &radeon_dvi_connector_helper_funcs);
1900 			if (i2c_bus->valid) {
1901 				radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
1902 				if (!radeon_connector->ddc_bus)
1903 					DRM_ERROR("HDMI: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1904 			}
1905 			drm_object_attach_property(&radeon_connector->base.base,
1906 						      rdev->mode_info.coherent_mode_property,
1907 						      1);
1908 			if (ASIC_IS_AVIVO(rdev)) {
1909 				drm_object_attach_property(&radeon_connector->base.base,
1910 							      rdev->mode_info.underscan_property,
1911 							      UNDERSCAN_OFF);
1912 				drm_object_attach_property(&radeon_connector->base.base,
1913 							      rdev->mode_info.underscan_hborder_property,
1914 							      0);
1915 				drm_object_attach_property(&radeon_connector->base.base,
1916 							      rdev->mode_info.underscan_vborder_property,
1917 							      0);
1918 			}
1919 			if (ASIC_IS_DCE2(rdev) && (radeon_audio != 0)) {
1920 				drm_object_attach_property(&radeon_connector->base.base,
1921 							   rdev->mode_info.audio_property,
1922 							   RADEON_AUDIO_AUTO);
1923 			}
1924 			if (ASIC_IS_AVIVO(rdev)) {
1925 				drm_object_attach_property(&radeon_connector->base.base,
1926 							   rdev->mode_info.dither_property,
1927 							   RADEON_FMT_DITHER_DISABLE);
1928 			}
1929 			subpixel_order = SubPixelHorizontalRGB;
1930 			connector->interlace_allowed = true;
1931 			if (connector_type == DRM_MODE_CONNECTOR_HDMIB)
1932 				connector->doublescan_allowed = true;
1933 			else
1934 				connector->doublescan_allowed = false;
1935 			break;
1936 		case DRM_MODE_CONNECTOR_DisplayPort:
1937 			radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
1938 			if (!radeon_dig_connector)
1939 				goto failed;
1940 			radeon_dig_connector->igp_lane_info = igp_lane_info;
1941 			radeon_connector->con_priv = radeon_dig_connector;
1942 			drm_connector_init(dev, &radeon_connector->base, &radeon_dp_connector_funcs, connector_type);
1943 			drm_connector_helper_add(&radeon_connector->base, &radeon_dp_connector_helper_funcs);
1944 			if (i2c_bus->valid) {
1945 				radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
1946 				if (radeon_connector->ddc_bus)
1947 					has_aux = true;
1948 				else
1949 					DRM_ERROR("DP: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1950 			}
1951 			subpixel_order = SubPixelHorizontalRGB;
1952 			drm_object_attach_property(&radeon_connector->base.base,
1953 						      rdev->mode_info.coherent_mode_property,
1954 						      1);
1955 			if (ASIC_IS_AVIVO(rdev)) {
1956 				drm_object_attach_property(&radeon_connector->base.base,
1957 							      rdev->mode_info.underscan_property,
1958 							      UNDERSCAN_OFF);
1959 				drm_object_attach_property(&radeon_connector->base.base,
1960 							      rdev->mode_info.underscan_hborder_property,
1961 							      0);
1962 				drm_object_attach_property(&radeon_connector->base.base,
1963 							      rdev->mode_info.underscan_vborder_property,
1964 							      0);
1965 			}
1966 			if (ASIC_IS_DCE2(rdev) && (radeon_audio != 0)) {
1967 				drm_object_attach_property(&radeon_connector->base.base,
1968 							   rdev->mode_info.audio_property,
1969 							   RADEON_AUDIO_AUTO);
1970 			}
1971 			if (ASIC_IS_AVIVO(rdev)) {
1972 				drm_object_attach_property(&radeon_connector->base.base,
1973 							   rdev->mode_info.dither_property,
1974 							   RADEON_FMT_DITHER_DISABLE);
1975 
1976 			}
1977 			connector->interlace_allowed = true;
1978 			/* in theory with a DP to VGA converter... */
1979 			connector->doublescan_allowed = false;
1980 			break;
1981 		case DRM_MODE_CONNECTOR_eDP:
1982 			radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
1983 			if (!radeon_dig_connector)
1984 				goto failed;
1985 			radeon_dig_connector->igp_lane_info = igp_lane_info;
1986 			radeon_connector->con_priv = radeon_dig_connector;
1987 			drm_connector_init(dev, &radeon_connector->base, &radeon_edp_connector_funcs, connector_type);
1988 			drm_connector_helper_add(&radeon_connector->base, &radeon_dp_connector_helper_funcs);
1989 			if (i2c_bus->valid) {
1990 				radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
1991 				if (radeon_connector->ddc_bus)
1992 					has_aux = true;
1993 				else
1994 					DRM_ERROR("DP: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1995 			}
1996 			drm_object_attach_property(&radeon_connector->base.base,
1997 						      dev->mode_config.scaling_mode_property,
1998 						      DRM_MODE_SCALE_FULLSCREEN);
1999 			subpixel_order = SubPixelHorizontalRGB;
2000 			connector->interlace_allowed = false;
2001 			connector->doublescan_allowed = false;
2002 			break;
2003 		case DRM_MODE_CONNECTOR_SVIDEO:
2004 		case DRM_MODE_CONNECTOR_Composite:
2005 		case DRM_MODE_CONNECTOR_9PinDIN:
2006 			drm_connector_init(dev, &radeon_connector->base, &radeon_tv_connector_funcs, connector_type);
2007 			drm_connector_helper_add(&radeon_connector->base, &radeon_tv_connector_helper_funcs);
2008 			radeon_connector->dac_load_detect = true;
2009 			drm_object_attach_property(&radeon_connector->base.base,
2010 						      rdev->mode_info.load_detect_property,
2011 						      1);
2012 			drm_object_attach_property(&radeon_connector->base.base,
2013 						      rdev->mode_info.tv_std_property,
2014 						      radeon_atombios_get_tv_info(rdev));
2015 			/* no HPD on analog connectors */
2016 			radeon_connector->hpd.hpd = RADEON_HPD_NONE;
2017 			connector->interlace_allowed = false;
2018 			connector->doublescan_allowed = false;
2019 			break;
2020 		case DRM_MODE_CONNECTOR_LVDS:
2021 			radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
2022 			if (!radeon_dig_connector)
2023 				goto failed;
2024 			radeon_dig_connector->igp_lane_info = igp_lane_info;
2025 			radeon_connector->con_priv = radeon_dig_connector;
2026 			drm_connector_init(dev, &radeon_connector->base, &radeon_lvds_connector_funcs, connector_type);
2027 			drm_connector_helper_add(&radeon_connector->base, &radeon_lvds_connector_helper_funcs);
2028 			if (i2c_bus->valid) {
2029 				radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
2030 				if (!radeon_connector->ddc_bus)
2031 					DRM_ERROR("LVDS: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
2032 			}
2033 			drm_object_attach_property(&radeon_connector->base.base,
2034 						      dev->mode_config.scaling_mode_property,
2035 						      DRM_MODE_SCALE_FULLSCREEN);
2036 			subpixel_order = SubPixelHorizontalRGB;
2037 			connector->interlace_allowed = false;
2038 			connector->doublescan_allowed = false;
2039 			break;
2040 		}
2041 	}
2042 
2043 	if (radeon_connector->hpd.hpd == RADEON_HPD_NONE) {
2044 		if (i2c_bus->valid)
2045 			connector->polled = DRM_CONNECTOR_POLL_CONNECT;
2046 	} else
2047 		connector->polled = DRM_CONNECTOR_POLL_HPD;
2048 
2049 	connector->display_info.subpixel_order = subpixel_order;
2050 	drm_sysfs_connector_add(connector);
2051 
2052 	if (has_aux)
2053 		radeon_dp_aux_init(radeon_connector);
2054 
2055 	return;
2056 
2057 failed:
2058 	drm_connector_cleanup(connector);
2059 	kfree(connector);
2060 }
2061 
2062 void
2063 radeon_add_legacy_connector(struct drm_device *dev,
2064 			    uint32_t connector_id,
2065 			    uint32_t supported_device,
2066 			    int connector_type,
2067 			    struct radeon_i2c_bus_rec *i2c_bus,
2068 			    uint16_t connector_object_id,
2069 			    struct radeon_hpd *hpd)
2070 {
2071 	struct radeon_device *rdev = dev->dev_private;
2072 	struct drm_connector *connector;
2073 	struct radeon_connector *radeon_connector;
2074 	uint32_t subpixel_order = SubPixelNone;
2075 
2076 	if (connector_type == DRM_MODE_CONNECTOR_Unknown)
2077 		return;
2078 
2079 	/* if the user selected tv=0 don't try and add the connector */
2080 	if (((connector_type == DRM_MODE_CONNECTOR_SVIDEO) ||
2081 	     (connector_type == DRM_MODE_CONNECTOR_Composite) ||
2082 	     (connector_type == DRM_MODE_CONNECTOR_9PinDIN)) &&
2083 	    (radeon_tv == 0))
2084 		return;
2085 
2086 	/* see if we already added it */
2087 	list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
2088 		radeon_connector = to_radeon_connector(connector);
2089 		if (radeon_connector->connector_id == connector_id) {
2090 			radeon_connector->devices |= supported_device;
2091 			return;
2092 		}
2093 	}
2094 
2095 	radeon_connector = kzalloc(sizeof(struct radeon_connector), GFP_KERNEL);
2096 	if (!radeon_connector)
2097 		return;
2098 
2099 	connector = &radeon_connector->base;
2100 
2101 	radeon_connector->connector_id = connector_id;
2102 	radeon_connector->devices = supported_device;
2103 	radeon_connector->connector_object_id = connector_object_id;
2104 	radeon_connector->hpd = *hpd;
2105 
2106 	switch (connector_type) {
2107 	case DRM_MODE_CONNECTOR_VGA:
2108 		drm_connector_init(dev, &radeon_connector->base, &radeon_vga_connector_funcs, connector_type);
2109 		drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
2110 		if (i2c_bus->valid) {
2111 			radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
2112 			if (!radeon_connector->ddc_bus)
2113 				DRM_ERROR("VGA: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
2114 		}
2115 		radeon_connector->dac_load_detect = true;
2116 		drm_object_attach_property(&radeon_connector->base.base,
2117 					      rdev->mode_info.load_detect_property,
2118 					      1);
2119 		/* no HPD on analog connectors */
2120 		radeon_connector->hpd.hpd = RADEON_HPD_NONE;
2121 		connector->polled = DRM_CONNECTOR_POLL_CONNECT;
2122 		connector->interlace_allowed = true;
2123 		connector->doublescan_allowed = true;
2124 		break;
2125 	case DRM_MODE_CONNECTOR_DVIA:
2126 		drm_connector_init(dev, &radeon_connector->base, &radeon_vga_connector_funcs, connector_type);
2127 		drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
2128 		if (i2c_bus->valid) {
2129 			radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
2130 			if (!radeon_connector->ddc_bus)
2131 				DRM_ERROR("DVIA: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
2132 		}
2133 		radeon_connector->dac_load_detect = true;
2134 		drm_object_attach_property(&radeon_connector->base.base,
2135 					      rdev->mode_info.load_detect_property,
2136 					      1);
2137 		/* no HPD on analog connectors */
2138 		radeon_connector->hpd.hpd = RADEON_HPD_NONE;
2139 		connector->interlace_allowed = true;
2140 		connector->doublescan_allowed = true;
2141 		break;
2142 	case DRM_MODE_CONNECTOR_DVII:
2143 	case DRM_MODE_CONNECTOR_DVID:
2144 		drm_connector_init(dev, &radeon_connector->base, &radeon_dvi_connector_funcs, connector_type);
2145 		drm_connector_helper_add(&radeon_connector->base, &radeon_dvi_connector_helper_funcs);
2146 		if (i2c_bus->valid) {
2147 			radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
2148 			if (!radeon_connector->ddc_bus)
2149 				DRM_ERROR("DVI: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
2150 		}
2151 		if (connector_type == DRM_MODE_CONNECTOR_DVII) {
2152 			radeon_connector->dac_load_detect = true;
2153 			drm_object_attach_property(&radeon_connector->base.base,
2154 						      rdev->mode_info.load_detect_property,
2155 						      1);
2156 		}
2157 		subpixel_order = SubPixelHorizontalRGB;
2158 		connector->interlace_allowed = true;
2159 		if (connector_type == DRM_MODE_CONNECTOR_DVII)
2160 			connector->doublescan_allowed = true;
2161 		else
2162 			connector->doublescan_allowed = false;
2163 		break;
2164 	case DRM_MODE_CONNECTOR_SVIDEO:
2165 	case DRM_MODE_CONNECTOR_Composite:
2166 	case DRM_MODE_CONNECTOR_9PinDIN:
2167 		drm_connector_init(dev, &radeon_connector->base, &radeon_tv_connector_funcs, connector_type);
2168 		drm_connector_helper_add(&radeon_connector->base, &radeon_tv_connector_helper_funcs);
2169 		radeon_connector->dac_load_detect = true;
2170 		/* RS400,RC410,RS480 chipset seems to report a lot
2171 		 * of false positive on load detect, we haven't yet
2172 		 * found a way to make load detect reliable on those
2173 		 * chipset, thus just disable it for TV.
2174 		 */
2175 		if (rdev->family == CHIP_RS400 || rdev->family == CHIP_RS480)
2176 			radeon_connector->dac_load_detect = false;
2177 		drm_object_attach_property(&radeon_connector->base.base,
2178 					      rdev->mode_info.load_detect_property,
2179 					      radeon_connector->dac_load_detect);
2180 		drm_object_attach_property(&radeon_connector->base.base,
2181 					      rdev->mode_info.tv_std_property,
2182 					      radeon_combios_get_tv_info(rdev));
2183 		/* no HPD on analog connectors */
2184 		radeon_connector->hpd.hpd = RADEON_HPD_NONE;
2185 		connector->interlace_allowed = false;
2186 		connector->doublescan_allowed = false;
2187 		break;
2188 	case DRM_MODE_CONNECTOR_LVDS:
2189 		drm_connector_init(dev, &radeon_connector->base, &radeon_lvds_connector_funcs, connector_type);
2190 		drm_connector_helper_add(&radeon_connector->base, &radeon_lvds_connector_helper_funcs);
2191 		if (i2c_bus->valid) {
2192 			radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
2193 			if (!radeon_connector->ddc_bus)
2194 				DRM_ERROR("LVDS: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
2195 		}
2196 		drm_object_attach_property(&radeon_connector->base.base,
2197 					      dev->mode_config.scaling_mode_property,
2198 					      DRM_MODE_SCALE_FULLSCREEN);
2199 		subpixel_order = SubPixelHorizontalRGB;
2200 		connector->interlace_allowed = false;
2201 		connector->doublescan_allowed = false;
2202 		break;
2203 	}
2204 
2205 	if (radeon_connector->hpd.hpd == RADEON_HPD_NONE) {
2206 		if (i2c_bus->valid)
2207 			connector->polled = DRM_CONNECTOR_POLL_CONNECT;
2208 	} else
2209 		connector->polled = DRM_CONNECTOR_POLL_HPD;
2210 	connector->display_info.subpixel_order = subpixel_order;
2211 	drm_sysfs_connector_add(connector);
2212 }
2213