1caab277bSThomas Gleixner // SPDX-License-Identifier: GPL-2.0-only
28bb0daffSRob Clark /*
31b409fdaSAlexander A. Klimov  * Copyright (C) 2011 Texas Instruments Incorporated - https://www.ti.com/
48bb0daffSRob Clark  * Author: Rob Clark <rob.clark@linaro.org>
58bb0daffSRob Clark  */
68bb0daffSRob Clark 
7c423bc85STomi Valkeinen #include <drm/drm_atomic.h>
869a12263SLaurent Pinchart #include <drm/drm_atomic_helper.h>
9942d8344SDaniel Vetter #include <drm/drm_gem_atomic_helper.h>
10de8e4100SLaurent Pinchart #include <drm/drm_plane_helper.h>
1169a12263SLaurent Pinchart 
128bb0daffSRob Clark #include "omap_dmm_tiler.h"
132d278f54SLaurent Pinchart #include "omap_drv.h"
148bb0daffSRob Clark 
158bb0daffSRob Clark /*
168bb0daffSRob Clark  * plane funcs
178bb0daffSRob Clark  */
188bb0daffSRob Clark 
198bb0daffSRob Clark #define to_omap_plane(x) container_of(x, struct omap_plane, base)
208bb0daffSRob Clark 
218bb0daffSRob Clark struct omap_plane {
228bb0daffSRob Clark 	struct drm_plane base;
23694c99cfSJyri Sarha 	enum omap_plane_id id;
248bb0daffSRob Clark 	const char *name;
258bb0daffSRob Clark };
268bb0daffSRob Clark 
2711ffd031STomi Valkeinen static int omap_plane_prepare_fb(struct drm_plane *plane,
281832040dSChris Wilson 				 struct drm_plane_state *new_state)
2911ffd031STomi Valkeinen {
30844f9111SMaarten Lankhorst 	if (!new_state->fb)
31844f9111SMaarten Lankhorst 		return 0;
32844f9111SMaarten Lankhorst 
33942d8344SDaniel Vetter 	drm_gem_plane_helper_prepare_fb(plane, new_state);
34942d8344SDaniel Vetter 
35844f9111SMaarten Lankhorst 	return omap_framebuffer_pin(new_state->fb);
3611ffd031STomi Valkeinen }
3711ffd031STomi Valkeinen 
3811ffd031STomi Valkeinen static void omap_plane_cleanup_fb(struct drm_plane *plane,
391832040dSChris Wilson 				  struct drm_plane_state *old_state)
4011ffd031STomi Valkeinen {
41844f9111SMaarten Lankhorst 	if (old_state->fb)
42844f9111SMaarten Lankhorst 		omap_framebuffer_unpin(old_state->fb);
4311ffd031STomi Valkeinen }
4411ffd031STomi Valkeinen 
4511ffd031STomi Valkeinen static void omap_plane_atomic_update(struct drm_plane *plane,
46977697e2SMaxime Ripard 				     struct drm_atomic_state *state)
47afc34932SLaurent Pinchart {
489f759225STomi Valkeinen 	struct omap_drm_private *priv = plane->dev->dev_private;
49edc72557SLaurent Pinchart 	struct omap_plane *omap_plane = to_omap_plane(plane);
5037418bf1SMaxime Ripard 	struct drm_plane_state *new_state = drm_atomic_get_new_plane_state(state,
5137418bf1SMaxime Ripard 									   plane);
52fb730c9bSLaurent Pinchart 	struct omap_overlay_info info;
538bb0daffSRob Clark 	int ret;
548bb0daffSRob Clark 
5541016fe1SMaxime Ripard 	DBG("%s, crtc=%p fb=%p", omap_plane->name, new_state->crtc,
5641016fe1SMaxime Ripard 	    new_state->fb);
578bb0daffSRob Clark 
58fb730c9bSLaurent Pinchart 	memset(&info, 0, sizeof(info));
59517a8a95STomi Valkeinen 	info.rotation_type = OMAP_DSS_ROT_NONE;
600bd97c42STomi Valkeinen 	info.rotation = DRM_MODE_ROTATE_0;
6141016fe1SMaxime Ripard 	info.global_alpha = new_state->alpha >> 8;
6241016fe1SMaxime Ripard 	info.zorder = new_state->normalized_zpos;
6341016fe1SMaxime Ripard 	if (new_state->pixel_blend_mode == DRM_MODE_BLEND_PREMULTI)
643037e0c5SJean-Jacques Hiblot 		info.pre_mult_alpha = 1;
653037e0c5SJean-Jacques Hiblot 	else
663037e0c5SJean-Jacques Hiblot 		info.pre_mult_alpha = 0;
6741016fe1SMaxime Ripard 	info.color_encoding = new_state->color_encoding;
6841016fe1SMaxime Ripard 	info.color_range = new_state->color_range;
69fb730c9bSLaurent Pinchart 
708bb0daffSRob Clark 	/* update scanout: */
7141016fe1SMaxime Ripard 	omap_framebuffer_update_scanout(new_state->fb, new_state, &info);
728bb0daffSRob Clark 
73fb730c9bSLaurent Pinchart 	DBG("%dx%d -> %dx%d (%d)", info.width, info.height,
74fb730c9bSLaurent Pinchart 			info.out_width, info.out_height,
75fb730c9bSLaurent Pinchart 			info.screen_width);
76fb730c9bSLaurent Pinchart 	DBG("%d,%d %pad %pad", info.pos_x, info.pos_y,
77fb730c9bSLaurent Pinchart 			&info.paddr, &info.p_uv_addr);
788bb0daffSRob Clark 
798bb0daffSRob Clark 	/* and finally, update omapdss: */
80dac62bcaSTomi Valkeinen 	ret = dispc_ovl_setup(priv->dispc, omap_plane->id, &info,
8141016fe1SMaxime Ripard 			      omap_crtc_timings(new_state->crtc), false,
8241016fe1SMaxime Ripard 			      omap_crtc_channel(new_state->crtc));
83cfb73f20STomi Valkeinen 	if (ret) {
84cfb73f20STomi Valkeinen 		dev_err(plane->dev->dev, "Failed to setup plane %s\n",
85cfb73f20STomi Valkeinen 			omap_plane->name);
86dac62bcaSTomi Valkeinen 		dispc_ovl_enable(priv->dispc, omap_plane->id, false);
87d9157dfdSTomi Valkeinen 		return;
88794a65ffSTomi Valkeinen 	}
898bb0daffSRob Clark 
90dac62bcaSTomi Valkeinen 	dispc_ovl_enable(priv->dispc, omap_plane->id, true);
91de8e4100SLaurent Pinchart }
92de8e4100SLaurent Pinchart 
93de8e4100SLaurent Pinchart static void omap_plane_atomic_disable(struct drm_plane *plane,
94977697e2SMaxime Ripard 				      struct drm_atomic_state *state)
958bb0daffSRob Clark {
9637418bf1SMaxime Ripard 	struct drm_plane_state *new_state = drm_atomic_get_new_plane_state(state,
9737418bf1SMaxime Ripard 									   plane);
989f759225STomi Valkeinen 	struct omap_drm_private *priv = plane->dev->dev_private;
998bb0daffSRob Clark 	struct omap_plane *omap_plane = to_omap_plane(plane);
1002debab97SLaurent Pinchart 
101e05162c0SMaxime Ripard 	new_state->rotation = DRM_MODE_ROTATE_0;
102e05162c0SMaxime Ripard 	new_state->zpos = plane->type == DRM_PLANE_TYPE_PRIMARY ? 0 : omap_plane->id;
10382e58855SLaurent Pinchart 
104dac62bcaSTomi Valkeinen 	dispc_ovl_enable(priv->dispc, omap_plane->id, false);
1058bb0daffSRob Clark }
1068bb0daffSRob Clark 
107c21134b0SNeil Armstrong #define FRAC_16_16(mult, div)    (((mult) << 16) / (div))
108c21134b0SNeil Armstrong 
109c423bc85STomi Valkeinen static int omap_plane_atomic_check(struct drm_plane *plane,
1107c11b99aSMaxime Ripard 				   struct drm_atomic_state *state)
111c423bc85STomi Valkeinen {
1127c11b99aSMaxime Ripard 	struct drm_plane_state *new_plane_state = drm_atomic_get_new_plane_state(state,
1137c11b99aSMaxime Ripard 										 plane);
114*d484c20dSBenoit Parrot 	struct omap_drm_private *priv = plane->dev->dev_private;
115c423bc85STomi Valkeinen 	struct drm_crtc_state *crtc_state;
116*d484c20dSBenoit Parrot 	u32 max_width, max_height;
117*d484c20dSBenoit Parrot 	u16 width, height;
118c21134b0SNeil Armstrong 	int ret;
119c423bc85STomi Valkeinen 
120ba5c1649SMaxime Ripard 	if (!new_plane_state->fb)
121c423bc85STomi Valkeinen 		return 0;
122c423bc85STomi Valkeinen 
123*d484c20dSBenoit Parrot 	dispc_ovl_get_max_size(priv->dispc, &width, &height);
124*d484c20dSBenoit Parrot 	max_width = width << 16;
125*d484c20dSBenoit Parrot 	max_height = height << 16;
126*d484c20dSBenoit Parrot 
127ba5c1649SMaxime Ripard 	/* crtc should only be NULL when disabling (i.e., !new_plane_state->fb) */
128ba5c1649SMaxime Ripard 	if (WARN_ON(!new_plane_state->crtc))
12970dd2a62STomi Valkeinen 		return 0;
13070dd2a62STomi Valkeinen 
131dec92020SMaxime Ripard 	crtc_state = drm_atomic_get_existing_crtc_state(state,
132ba5c1649SMaxime Ripard 							new_plane_state->crtc);
13370dd2a62STomi Valkeinen 	/* we should have a crtc state if the plane is attached to a crtc */
13470dd2a62STomi Valkeinen 	if (WARN_ON(!crtc_state))
13570dd2a62STomi Valkeinen 		return 0;
136c423bc85STomi Valkeinen 
137aaf7642eSTomi Valkeinen 	if (!crtc_state->enable)
138aaf7642eSTomi Valkeinen 		return 0;
139aaf7642eSTomi Valkeinen 
140c21134b0SNeil Armstrong 	/*
141c21134b0SNeil Armstrong 	 * Note: these are just sanity checks to filter out totally bad scaling
142c21134b0SNeil Armstrong 	 * factors. The real limits must be calculated case by case, and
143c21134b0SNeil Armstrong 	 * unfortunately we currently do those checks only at the commit
144c21134b0SNeil Armstrong 	 * phase in dispc.
145c21134b0SNeil Armstrong 	 */
146c21134b0SNeil Armstrong 	ret = drm_atomic_helper_check_plane_state(new_plane_state, crtc_state,
147c21134b0SNeil Armstrong 						  FRAC_16_16(1, 8), FRAC_16_16(8, 1),
148c21134b0SNeil Armstrong 						  true, true);
149c21134b0SNeil Armstrong 	if (ret)
150c21134b0SNeil Armstrong 		return ret;
151c21134b0SNeil Armstrong 
152ba5c1649SMaxime Ripard 	if (new_plane_state->crtc_x < 0 || new_plane_state->crtc_y < 0)
153c423bc85STomi Valkeinen 		return -EINVAL;
154c423bc85STomi Valkeinen 
155ba5c1649SMaxime Ripard 	if (new_plane_state->crtc_x + new_plane_state->crtc_w > crtc_state->adjusted_mode.hdisplay)
156c423bc85STomi Valkeinen 		return -EINVAL;
157c423bc85STomi Valkeinen 
158ba5c1649SMaxime Ripard 	if (new_plane_state->crtc_y + new_plane_state->crtc_h > crtc_state->adjusted_mode.vdisplay)
159c423bc85STomi Valkeinen 		return -EINVAL;
160c423bc85STomi Valkeinen 
161*d484c20dSBenoit Parrot 	/* Make sure dimensions are within bounds. */
162*d484c20dSBenoit Parrot 	if (new_plane_state->src_h > max_height || new_plane_state->crtc_h > height)
163*d484c20dSBenoit Parrot 		return -EINVAL;
164*d484c20dSBenoit Parrot 
165*d484c20dSBenoit Parrot 	if (new_plane_state->src_w > max_width || new_plane_state->crtc_w > width)
166*d484c20dSBenoit Parrot 		return -EINVAL;
167*d484c20dSBenoit Parrot 
168ba5c1649SMaxime Ripard 	if (new_plane_state->rotation != DRM_MODE_ROTATE_0 &&
169ba5c1649SMaxime Ripard 	    !omap_framebuffer_supports_rotation(new_plane_state->fb))
170bfeece55STomi Valkeinen 		return -EINVAL;
171bfeece55STomi Valkeinen 
172c423bc85STomi Valkeinen 	return 0;
173c423bc85STomi Valkeinen }
174c423bc85STomi Valkeinen 
175de8e4100SLaurent Pinchart static const struct drm_plane_helper_funcs omap_plane_helper_funcs = {
176de8e4100SLaurent Pinchart 	.prepare_fb = omap_plane_prepare_fb,
177de8e4100SLaurent Pinchart 	.cleanup_fb = omap_plane_cleanup_fb,
178c423bc85STomi Valkeinen 	.atomic_check = omap_plane_atomic_check,
179de8e4100SLaurent Pinchart 	.atomic_update = omap_plane_atomic_update,
180de8e4100SLaurent Pinchart 	.atomic_disable = omap_plane_atomic_disable,
181de8e4100SLaurent Pinchart };
182de8e4100SLaurent Pinchart 
1838bb0daffSRob Clark static void omap_plane_destroy(struct drm_plane *plane)
1848bb0daffSRob Clark {
1858bb0daffSRob Clark 	struct omap_plane *omap_plane = to_omap_plane(plane);
1868bb0daffSRob Clark 
1878bb0daffSRob Clark 	DBG("%s", omap_plane->name);
1888bb0daffSRob Clark 
1898bb0daffSRob Clark 	drm_plane_cleanup(plane);
1908bb0daffSRob Clark 
1918bb0daffSRob Clark 	kfree(omap_plane);
1928bb0daffSRob Clark }
1938bb0daffSRob Clark 
1948bb0daffSRob Clark /* helper to install properties which are common to planes and crtcs */
1958bb0daffSRob Clark void omap_plane_install_properties(struct drm_plane *plane,
1968bb0daffSRob Clark 		struct drm_mode_object *obj)
1978bb0daffSRob Clark {
1988bb0daffSRob Clark 	struct drm_device *dev = plane->dev;
1998bb0daffSRob Clark 	struct omap_drm_private *priv = dev->dev_private;
2008bb0daffSRob Clark 
2018bb0daffSRob Clark 	if (priv->has_dmm) {
2020da88db1SVille Syrjälä 		if (!plane->rotation_property)
2030da88db1SVille Syrjälä 			drm_plane_create_rotation_property(plane,
204c2c446adSRobert Foss 							   DRM_MODE_ROTATE_0,
205c2c446adSRobert Foss 							   DRM_MODE_ROTATE_0 | DRM_MODE_ROTATE_90 |
206c2c446adSRobert Foss 							   DRM_MODE_ROTATE_180 | DRM_MODE_ROTATE_270 |
207c2c446adSRobert Foss 							   DRM_MODE_REFLECT_X | DRM_MODE_REFLECT_Y);
208e2cd09b2SLaurent Pinchart 
2090da88db1SVille Syrjälä 		/* Attach the rotation property also to the crtc object */
2100da88db1SVille Syrjälä 		if (plane->rotation_property && obj != &plane->base)
2110da88db1SVille Syrjälä 			drm_object_attach_property(obj, plane->rotation_property,
212c2c446adSRobert Foss 						   DRM_MODE_ROTATE_0);
2138bb0daffSRob Clark 	}
2148bb0daffSRob Clark 
215e2cd09b2SLaurent Pinchart 	drm_object_attach_property(obj, priv->zorder_prop, 0);
2168bb0daffSRob Clark }
2178bb0daffSRob Clark 
218e07323cfSTomi Valkeinen static void omap_plane_reset(struct drm_plane *plane)
219e07323cfSTomi Valkeinen {
220e07323cfSTomi Valkeinen 	struct omap_plane *omap_plane = to_omap_plane(plane);
221e07323cfSTomi Valkeinen 
222d980278bSLaurent Pinchart 	drm_atomic_helper_plane_reset(plane);
223d980278bSLaurent Pinchart 	if (!plane->state)
224e07323cfSTomi Valkeinen 		return;
225e07323cfSTomi Valkeinen 
226e07323cfSTomi Valkeinen 	/*
227ba527c13SLaurent Pinchart 	 * Set the zpos default depending on whether we are a primary or overlay
228e07323cfSTomi Valkeinen 	 * plane.
229e07323cfSTomi Valkeinen 	 */
230d980278bSLaurent Pinchart 	plane->state->zpos = plane->type == DRM_PLANE_TYPE_PRIMARY
231e07323cfSTomi Valkeinen 			   ? 0 : omap_plane->id;
23264ff1891SJyri Sarha 	plane->state->color_encoding = DRM_COLOR_YCBCR_BT601;
23364ff1891SJyri Sarha 	plane->state->color_range = DRM_COLOR_YCBCR_FULL_RANGE;
234e07323cfSTomi Valkeinen }
235e07323cfSTomi Valkeinen 
236afc34932SLaurent Pinchart static int omap_plane_atomic_set_property(struct drm_plane *plane,
237afc34932SLaurent Pinchart 					  struct drm_plane_state *state,
238afc34932SLaurent Pinchart 					  struct drm_property *property,
239dfe9cfccSLaurent Pinchart 					  u64 val)
240afc34932SLaurent Pinchart {
241afc34932SLaurent Pinchart 	struct omap_drm_private *priv = plane->dev->dev_private;
242afc34932SLaurent Pinchart 
243afc34932SLaurent Pinchart 	if (property == priv->zorder_prop)
244ba527c13SLaurent Pinchart 		state->zpos = val;
245afc34932SLaurent Pinchart 	else
246afc34932SLaurent Pinchart 		return -EINVAL;
247afc34932SLaurent Pinchart 
248a42133a7SLaurent Pinchart 	return 0;
249afc34932SLaurent Pinchart }
250a42133a7SLaurent Pinchart 
251afc34932SLaurent Pinchart static int omap_plane_atomic_get_property(struct drm_plane *plane,
252afc34932SLaurent Pinchart 					  const struct drm_plane_state *state,
253afc34932SLaurent Pinchart 					  struct drm_property *property,
254dfe9cfccSLaurent Pinchart 					  u64 *val)
255afc34932SLaurent Pinchart {
256afc34932SLaurent Pinchart 	struct omap_drm_private *priv = plane->dev->dev_private;
257a42133a7SLaurent Pinchart 
258afc34932SLaurent Pinchart 	if (property == priv->zorder_prop)
259ba527c13SLaurent Pinchart 		*val = state->zpos;
260afc34932SLaurent Pinchart 	else
261afc34932SLaurent Pinchart 		return -EINVAL;
262afc34932SLaurent Pinchart 
263afc34932SLaurent Pinchart 	return 0;
2648bb0daffSRob Clark }
2658bb0daffSRob Clark 
2668bb0daffSRob Clark static const struct drm_plane_funcs omap_plane_funcs = {
267cef77d40SLaurent Pinchart 	.update_plane = drm_atomic_helper_update_plane,
268cef77d40SLaurent Pinchart 	.disable_plane = drm_atomic_helper_disable_plane,
269afc34932SLaurent Pinchart 	.reset = omap_plane_reset,
2708bb0daffSRob Clark 	.destroy = omap_plane_destroy,
271d980278bSLaurent Pinchart 	.atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state,
272d980278bSLaurent Pinchart 	.atomic_destroy_state = drm_atomic_helper_plane_destroy_state,
273afc34932SLaurent Pinchart 	.atomic_set_property = omap_plane_atomic_set_property,
274afc34932SLaurent Pinchart 	.atomic_get_property = omap_plane_atomic_get_property,
2758bb0daffSRob Clark };
2768bb0daffSRob Clark 
27764ff1891SJyri Sarha static bool omap_plane_supports_yuv(struct drm_plane *plane)
27864ff1891SJyri Sarha {
27964ff1891SJyri Sarha 	struct omap_drm_private *priv = plane->dev->dev_private;
28064ff1891SJyri Sarha 	struct omap_plane *omap_plane = to_omap_plane(plane);
281dac62bcaSTomi Valkeinen 	const u32 *formats = dispc_ovl_get_color_modes(priv->dispc, omap_plane->id);
28264ff1891SJyri Sarha 	u32 i;
28364ff1891SJyri Sarha 
28464ff1891SJyri Sarha 	for (i = 0; formats[i]; i++)
28564ff1891SJyri Sarha 		if (formats[i] == DRM_FORMAT_YUYV ||
28664ff1891SJyri Sarha 		    formats[i] == DRM_FORMAT_UYVY ||
28764ff1891SJyri Sarha 		    formats[i] == DRM_FORMAT_NV12)
28864ff1891SJyri Sarha 			return true;
28964ff1891SJyri Sarha 
29064ff1891SJyri Sarha 	return false;
29164ff1891SJyri Sarha }
29264ff1891SJyri Sarha 
293e8e13b15SJyri Sarha static const char *plane_id_to_name[] = {
2948bb0daffSRob Clark 	[OMAP_DSS_GFX] = "gfx",
2958bb0daffSRob Clark 	[OMAP_DSS_VIDEO1] = "vid1",
2968bb0daffSRob Clark 	[OMAP_DSS_VIDEO2] = "vid2",
2978bb0daffSRob Clark 	[OMAP_DSS_VIDEO3] = "vid3",
2988bb0daffSRob Clark };
2998bb0daffSRob Clark 
300e8e13b15SJyri Sarha static const enum omap_plane_id plane_idx_to_id[] = {
301e8e13b15SJyri Sarha 	OMAP_DSS_GFX,
302e8e13b15SJyri Sarha 	OMAP_DSS_VIDEO1,
303e8e13b15SJyri Sarha 	OMAP_DSS_VIDEO2,
304e8e13b15SJyri Sarha 	OMAP_DSS_VIDEO3,
305e8e13b15SJyri Sarha };
306e8e13b15SJyri Sarha 
3078bb0daffSRob Clark /* initialize plane */
3088bb0daffSRob Clark struct drm_plane *omap_plane_init(struct drm_device *dev,
309e8e13b15SJyri Sarha 		int idx, enum drm_plane_type type,
310e43f2c33STomi Valkeinen 		u32 possible_crtcs)
3118bb0daffSRob Clark {
3129f759225STomi Valkeinen 	struct omap_drm_private *priv = dev->dev_private;
313dac62bcaSTomi Valkeinen 	unsigned int num_planes = dispc_get_num_ovls(priv->dispc);
314ef6b0e02SLaurent Pinchart 	struct drm_plane *plane;
3158bb0daffSRob Clark 	struct omap_plane *omap_plane;
316e8e13b15SJyri Sarha 	enum omap_plane_id id;
317ef6b0e02SLaurent Pinchart 	int ret;
318eecad437STomi Valkeinen 	u32 nformats;
319eecad437STomi Valkeinen 	const u32 *formats;
3208bb0daffSRob Clark 
321e8e13b15SJyri Sarha 	if (WARN_ON(idx >= ARRAY_SIZE(plane_idx_to_id)))
322e8e13b15SJyri Sarha 		return ERR_PTR(-EINVAL);
323e8e13b15SJyri Sarha 
324e8e13b15SJyri Sarha 	id = plane_idx_to_id[idx];
325e8e13b15SJyri Sarha 
326e8e13b15SJyri Sarha 	DBG("%s: type=%d", plane_id_to_name[id], type);
3278bb0daffSRob Clark 
3288bb0daffSRob Clark 	omap_plane = kzalloc(sizeof(*omap_plane), GFP_KERNEL);
329fffddfd6SLinus Torvalds 	if (!omap_plane)
330fb9a35f8SLaurent Pinchart 		return ERR_PTR(-ENOMEM);
3318bb0daffSRob Clark 
332dac62bcaSTomi Valkeinen 	formats = dispc_ovl_get_color_modes(priv->dispc, id);
333eecad437STomi Valkeinen 	for (nformats = 0; formats[nformats]; ++nformats)
334eecad437STomi Valkeinen 		;
3358bb0daffSRob Clark 	omap_plane->id = id;
336e8e13b15SJyri Sarha 	omap_plane->name = plane_id_to_name[id];
3378bb0daffSRob Clark 
3388bb0daffSRob Clark 	plane = &omap_plane->base;
3398bb0daffSRob Clark 
340e43f2c33STomi Valkeinen 	ret = drm_universal_plane_init(dev, plane, possible_crtcs,
341eecad437STomi Valkeinen 				       &omap_plane_funcs, formats,
342e6fc3b68SBen Widawsky 				       nformats, NULL, type, NULL);
343ef6b0e02SLaurent Pinchart 	if (ret < 0)
344ef6b0e02SLaurent Pinchart 		goto error;
3458bb0daffSRob Clark 
346de8e4100SLaurent Pinchart 	drm_plane_helper_add(plane, &omap_plane_helper_funcs);
347de8e4100SLaurent Pinchart 
3488bb0daffSRob Clark 	omap_plane_install_properties(plane, &plane->base);
349dff6c246SLaurent Pinchart 	drm_plane_create_zpos_property(plane, 0, 0, num_planes - 1);
3503037e0c5SJean-Jacques Hiblot 	drm_plane_create_alpha_property(plane);
3513037e0c5SJean-Jacques Hiblot 	drm_plane_create_blend_mode_property(plane, BIT(DRM_MODE_BLEND_PREMULTI) |
3523037e0c5SJean-Jacques Hiblot 					     BIT(DRM_MODE_BLEND_COVERAGE));
3538bb0daffSRob Clark 
35464ff1891SJyri Sarha 	if (omap_plane_supports_yuv(plane))
35564ff1891SJyri Sarha 		drm_plane_create_color_properties(plane,
35664ff1891SJyri Sarha 						  BIT(DRM_COLOR_YCBCR_BT601) |
35764ff1891SJyri Sarha 						  BIT(DRM_COLOR_YCBCR_BT709),
35864ff1891SJyri Sarha 						  BIT(DRM_COLOR_YCBCR_FULL_RANGE) |
35964ff1891SJyri Sarha 						  BIT(DRM_COLOR_YCBCR_LIMITED_RANGE),
36064ff1891SJyri Sarha 						  DRM_COLOR_YCBCR_BT601,
36164ff1891SJyri Sarha 						  DRM_COLOR_YCBCR_FULL_RANGE);
36264ff1891SJyri Sarha 
3638bb0daffSRob Clark 	return plane;
364ef6b0e02SLaurent Pinchart 
365ef6b0e02SLaurent Pinchart error:
366e8e13b15SJyri Sarha 	dev_err(dev->dev, "%s(): could not create plane: %s\n",
367e8e13b15SJyri Sarha 		__func__, plane_id_to_name[id]);
368e8e13b15SJyri Sarha 
369ef6b0e02SLaurent Pinchart 	kfree(omap_plane);
370ef6b0e02SLaurent Pinchart 	return NULL;
3718bb0daffSRob Clark }
372