18bb0daffSRob Clark /*
28bb0daffSRob Clark  * drivers/gpu/drm/omapdrm/omap_plane.c
38bb0daffSRob Clark  *
48bb0daffSRob Clark  * Copyright (C) 2011 Texas Instruments
58bb0daffSRob Clark  * Author: Rob Clark <rob.clark@linaro.org>
68bb0daffSRob Clark  *
78bb0daffSRob Clark  * This program is free software; you can redistribute it and/or modify it
88bb0daffSRob Clark  * under the terms of the GNU General Public License version 2 as published by
98bb0daffSRob Clark  * the Free Software Foundation.
108bb0daffSRob Clark  *
118bb0daffSRob Clark  * This program is distributed in the hope that it will be useful, but WITHOUT
128bb0daffSRob Clark  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
138bb0daffSRob Clark  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
148bb0daffSRob Clark  * more details.
158bb0daffSRob Clark  *
168bb0daffSRob Clark  * You should have received a copy of the GNU General Public License along with
178bb0daffSRob Clark  * this program.  If not, see <http://www.gnu.org/licenses/>.
188bb0daffSRob Clark  */
198bb0daffSRob Clark 
20c423bc85STomi Valkeinen #include <drm/drm_atomic.h>
2169a12263SLaurent Pinchart #include <drm/drm_atomic_helper.h>
22de8e4100SLaurent Pinchart #include <drm/drm_plane_helper.h>
2369a12263SLaurent Pinchart 
248bb0daffSRob Clark #include "omap_dmm_tiler.h"
252d278f54SLaurent Pinchart #include "omap_drv.h"
268bb0daffSRob Clark 
278bb0daffSRob Clark /* some hackery because omapdss has an 'enum omap_plane' (which would be
288bb0daffSRob Clark  * better named omap_plane_id).. and compiler seems unhappy about having
298bb0daffSRob Clark  * both a 'struct omap_plane' and 'enum omap_plane'
308bb0daffSRob Clark  */
318bb0daffSRob Clark #define omap_plane _omap_plane
328bb0daffSRob Clark 
338bb0daffSRob Clark /*
348bb0daffSRob Clark  * plane funcs
358bb0daffSRob Clark  */
368bb0daffSRob Clark 
378bb0daffSRob Clark #define to_omap_plane(x) container_of(x, struct omap_plane, base)
388bb0daffSRob Clark 
398bb0daffSRob Clark struct omap_plane {
408bb0daffSRob Clark 	struct drm_plane base;
418bb0daffSRob Clark 	int id;  /* TODO rename omap_plane -> omap_plane_id in omapdss so I can use the enum */
428bb0daffSRob Clark 	const char *name;
438bb0daffSRob Clark 
448bb0daffSRob Clark 	uint32_t nformats;
458bb0daffSRob Clark 	uint32_t formats[32];
468bb0daffSRob Clark 
478bb0daffSRob Clark 	struct omap_drm_irq error_irq;
488bb0daffSRob Clark };
498bb0daffSRob Clark 
50afc34932SLaurent Pinchart struct omap_plane_state {
51afc34932SLaurent Pinchart 	struct drm_plane_state base;
52afc34932SLaurent Pinchart 
53afc34932SLaurent Pinchart 	unsigned int zorder;
54afc34932SLaurent Pinchart };
55afc34932SLaurent Pinchart 
56afc34932SLaurent Pinchart static inline struct omap_plane_state *
57afc34932SLaurent Pinchart to_omap_plane_state(struct drm_plane_state *state)
588bb0daffSRob Clark {
59afc34932SLaurent Pinchart 	return container_of(state, struct omap_plane_state, base);
60afc34932SLaurent Pinchart }
61afc34932SLaurent Pinchart 
6211ffd031STomi Valkeinen static int omap_plane_prepare_fb(struct drm_plane *plane,
6311ffd031STomi Valkeinen 				 struct drm_framebuffer *fb,
6411ffd031STomi Valkeinen 				 const struct drm_plane_state *new_state)
6511ffd031STomi Valkeinen {
6611ffd031STomi Valkeinen 	return omap_framebuffer_pin(fb);
6711ffd031STomi Valkeinen }
6811ffd031STomi Valkeinen 
6911ffd031STomi Valkeinen static void omap_plane_cleanup_fb(struct drm_plane *plane,
7011ffd031STomi Valkeinen 				  struct drm_framebuffer *fb,
7111ffd031STomi Valkeinen 				  const struct drm_plane_state *old_state)
7211ffd031STomi Valkeinen {
7311ffd031STomi Valkeinen 	omap_framebuffer_unpin(fb);
7411ffd031STomi Valkeinen }
7511ffd031STomi Valkeinen 
7611ffd031STomi Valkeinen static void omap_plane_atomic_update(struct drm_plane *plane,
7711ffd031STomi Valkeinen 				     struct drm_plane_state *old_state)
78afc34932SLaurent Pinchart {
79edc72557SLaurent Pinchart 	struct omap_plane *omap_plane = to_omap_plane(plane);
80edc72557SLaurent Pinchart 	struct drm_plane_state *state = plane->state;
81afc34932SLaurent Pinchart 	struct omap_plane_state *omap_state = to_omap_plane_state(state);
82fb730c9bSLaurent Pinchart 	struct omap_overlay_info info;
83fb730c9bSLaurent Pinchart 	struct omap_drm_window win;
848bb0daffSRob Clark 	int ret;
858bb0daffSRob Clark 
86edc72557SLaurent Pinchart 	DBG("%s, crtc=%p fb=%p", omap_plane->name, state->crtc, state->fb);
878bb0daffSRob Clark 
88fb730c9bSLaurent Pinchart 	memset(&info, 0, sizeof(info));
89fb730c9bSLaurent Pinchart 	info.rotation_type = OMAP_DSS_ROT_DMA;
90fb730c9bSLaurent Pinchart 	info.rotation = OMAP_DSS_ROT_0;
91fb730c9bSLaurent Pinchart 	info.global_alpha = 0xff;
92fb730c9bSLaurent Pinchart 	info.mirror = 0;
93fb730c9bSLaurent Pinchart 	info.zorder = omap_state->zorder;
94fb730c9bSLaurent Pinchart 
95fb730c9bSLaurent Pinchart 	memset(&win, 0, sizeof(win));
96fb730c9bSLaurent Pinchart 	win.rotation = state->rotation;
97fb730c9bSLaurent Pinchart 	win.crtc_x = state->crtc_x;
98fb730c9bSLaurent Pinchart 	win.crtc_y = state->crtc_y;
99fb730c9bSLaurent Pinchart 	win.crtc_w = state->crtc_w;
100fb730c9bSLaurent Pinchart 	win.crtc_h = state->crtc_h;
101fb730c9bSLaurent Pinchart 
102fb730c9bSLaurent Pinchart 	/*
103fb730c9bSLaurent Pinchart 	 * src values are in Q16 fixed point, convert to integer.
104fb730c9bSLaurent Pinchart 	 * omap_framebuffer_update_scanout() takes adjusted src.
105fb730c9bSLaurent Pinchart 	 */
106fb730c9bSLaurent Pinchart 	win.src_x = state->src_x >> 16;
107fb730c9bSLaurent Pinchart 	win.src_y = state->src_y >> 16;
108fb730c9bSLaurent Pinchart 
109fb730c9bSLaurent Pinchart 	switch (state->rotation & 0xf) {
110fb730c9bSLaurent Pinchart 	case BIT(DRM_ROTATE_90):
111fb730c9bSLaurent Pinchart 	case BIT(DRM_ROTATE_270):
112fb730c9bSLaurent Pinchart 		win.src_w = state->src_h >> 16;
113fb730c9bSLaurent Pinchart 		win.src_h = state->src_w >> 16;
114fb730c9bSLaurent Pinchart 		break;
115fb730c9bSLaurent Pinchart 	default:
116fb730c9bSLaurent Pinchart 		win.src_w = state->src_w >> 16;
117fb730c9bSLaurent Pinchart 		win.src_h = state->src_h >> 16;
118fb730c9bSLaurent Pinchart 		break;
119fb730c9bSLaurent Pinchart 	}
120afc34932SLaurent Pinchart 
1218bb0daffSRob Clark 	/* update scanout: */
122fb730c9bSLaurent Pinchart 	omap_framebuffer_update_scanout(state->fb, &win, &info);
1238bb0daffSRob Clark 
124fb730c9bSLaurent Pinchart 	DBG("%dx%d -> %dx%d (%d)", info.width, info.height,
125fb730c9bSLaurent Pinchart 			info.out_width, info.out_height,
126fb730c9bSLaurent Pinchart 			info.screen_width);
127fb730c9bSLaurent Pinchart 	DBG("%d,%d %pad %pad", info.pos_x, info.pos_y,
128fb730c9bSLaurent Pinchart 			&info.paddr, &info.p_uv_addr);
1298bb0daffSRob Clark 
130a42133a7SLaurent Pinchart 	dispc_ovl_set_channel_out(omap_plane->id,
131afc34932SLaurent Pinchart 				  omap_crtc_channel(state->crtc));
1322dd3887bSTomi Valkeinen 
1338bb0daffSRob Clark 	/* and finally, update omapdss: */
134fb730c9bSLaurent Pinchart 	ret = dispc_ovl_setup(omap_plane->id, &info, false,
135afc34932SLaurent Pinchart 			      omap_crtc_timings(state->crtc), false);
136794a65ffSTomi Valkeinen 	if (WARN_ON(ret)) {
137794a65ffSTomi Valkeinen 		dispc_ovl_enable(omap_plane->id, false);
138d9157dfdSTomi Valkeinen 		return;
139794a65ffSTomi Valkeinen 	}
1408bb0daffSRob Clark 
1418bb0daffSRob Clark 	dispc_ovl_enable(omap_plane->id, true);
142de8e4100SLaurent Pinchart }
143de8e4100SLaurent Pinchart 
144de8e4100SLaurent Pinchart static void omap_plane_atomic_disable(struct drm_plane *plane,
145de8e4100SLaurent Pinchart 				      struct drm_plane_state *old_state)
1468bb0daffSRob Clark {
147afc34932SLaurent Pinchart 	struct omap_plane_state *omap_state = to_omap_plane_state(plane->state);
1488bb0daffSRob Clark 	struct omap_plane *omap_plane = to_omap_plane(plane);
1492debab97SLaurent Pinchart 
150afc34932SLaurent Pinchart 	plane->state->rotation = BIT(DRM_ROTATE_0);
151afc34932SLaurent Pinchart 	omap_state->zorder = plane->type == DRM_PLANE_TYPE_PRIMARY
15282e58855SLaurent Pinchart 			   ? 0 : omap_plane->id;
15382e58855SLaurent Pinchart 
15411ffd031STomi Valkeinen 	dispc_ovl_enable(omap_plane->id, false);
1558bb0daffSRob Clark }
1568bb0daffSRob Clark 
157c423bc85STomi Valkeinen static int omap_plane_atomic_check(struct drm_plane *plane,
158c423bc85STomi Valkeinen 				   struct drm_plane_state *state)
159c423bc85STomi Valkeinen {
160c423bc85STomi Valkeinen 	struct drm_crtc_state *crtc_state;
161c423bc85STomi Valkeinen 
162c423bc85STomi Valkeinen 	if (!state->crtc)
163c423bc85STomi Valkeinen 		return 0;
164c423bc85STomi Valkeinen 
165c423bc85STomi Valkeinen 	crtc_state = drm_atomic_get_crtc_state(state->state, state->crtc);
166c423bc85STomi Valkeinen 	if (IS_ERR(crtc_state))
167c423bc85STomi Valkeinen 		return PTR_ERR(crtc_state);
168c423bc85STomi Valkeinen 
169c423bc85STomi Valkeinen 	if (state->crtc_x < 0 || state->crtc_y < 0)
170c423bc85STomi Valkeinen 		return -EINVAL;
171c423bc85STomi Valkeinen 
172c423bc85STomi Valkeinen 	if (state->crtc_x + state->crtc_w > crtc_state->adjusted_mode.hdisplay)
173c423bc85STomi Valkeinen 		return -EINVAL;
174c423bc85STomi Valkeinen 
175c423bc85STomi Valkeinen 	if (state->crtc_y + state->crtc_h > crtc_state->adjusted_mode.vdisplay)
176c423bc85STomi Valkeinen 		return -EINVAL;
177c423bc85STomi Valkeinen 
178c423bc85STomi Valkeinen 	return 0;
179c423bc85STomi Valkeinen }
180c423bc85STomi Valkeinen 
181de8e4100SLaurent Pinchart static const struct drm_plane_helper_funcs omap_plane_helper_funcs = {
182de8e4100SLaurent Pinchart 	.prepare_fb = omap_plane_prepare_fb,
183de8e4100SLaurent Pinchart 	.cleanup_fb = omap_plane_cleanup_fb,
184c423bc85STomi Valkeinen 	.atomic_check = omap_plane_atomic_check,
185de8e4100SLaurent Pinchart 	.atomic_update = omap_plane_atomic_update,
186de8e4100SLaurent Pinchart 	.atomic_disable = omap_plane_atomic_disable,
187de8e4100SLaurent Pinchart };
188de8e4100SLaurent Pinchart 
189afc34932SLaurent Pinchart static void omap_plane_reset(struct drm_plane *plane)
190afc34932SLaurent Pinchart {
191afc34932SLaurent Pinchart 	struct omap_plane *omap_plane = to_omap_plane(plane);
192afc34932SLaurent Pinchart 	struct omap_plane_state *omap_state;
193afc34932SLaurent Pinchart 
194afc34932SLaurent Pinchart 	if (plane->state && plane->state->fb)
195afc34932SLaurent Pinchart 		drm_framebuffer_unreference(plane->state->fb);
196afc34932SLaurent Pinchart 
197afc34932SLaurent Pinchart 	kfree(plane->state);
198afc34932SLaurent Pinchart 	plane->state = NULL;
199afc34932SLaurent Pinchart 
200afc34932SLaurent Pinchart 	omap_state = kzalloc(sizeof(*omap_state), GFP_KERNEL);
201afc34932SLaurent Pinchart 	if (omap_state == NULL)
202afc34932SLaurent Pinchart 		return;
203afc34932SLaurent Pinchart 
204afc34932SLaurent Pinchart 	/*
205afc34932SLaurent Pinchart 	 * Set defaults depending on whether we are a primary or overlay
206afc34932SLaurent Pinchart 	 * plane.
207afc34932SLaurent Pinchart 	 */
208afc34932SLaurent Pinchart 	omap_state->zorder = plane->type == DRM_PLANE_TYPE_PRIMARY
209afc34932SLaurent Pinchart 			   ? 0 : omap_plane->id;
210afc34932SLaurent Pinchart 	omap_state->base.rotation = BIT(DRM_ROTATE_0);
211afc34932SLaurent Pinchart 
212afc34932SLaurent Pinchart 	plane->state = &omap_state->base;
213afc34932SLaurent Pinchart 	plane->state->plane = plane;
214afc34932SLaurent Pinchart }
215afc34932SLaurent Pinchart 
2168bb0daffSRob Clark static void omap_plane_destroy(struct drm_plane *plane)
2178bb0daffSRob Clark {
2188bb0daffSRob Clark 	struct omap_plane *omap_plane = to_omap_plane(plane);
2198bb0daffSRob Clark 
2208bb0daffSRob Clark 	DBG("%s", omap_plane->name);
2218bb0daffSRob Clark 
2228bb0daffSRob Clark 	omap_irq_unregister(plane->dev, &omap_plane->error_irq);
2238bb0daffSRob Clark 
2248bb0daffSRob Clark 	drm_plane_cleanup(plane);
2258bb0daffSRob Clark 
2268bb0daffSRob Clark 	kfree(omap_plane);
2278bb0daffSRob Clark }
2288bb0daffSRob Clark 
2298bb0daffSRob Clark /* helper to install properties which are common to planes and crtcs */
2308bb0daffSRob Clark void omap_plane_install_properties(struct drm_plane *plane,
2318bb0daffSRob Clark 		struct drm_mode_object *obj)
2328bb0daffSRob Clark {
2338bb0daffSRob Clark 	struct drm_device *dev = plane->dev;
2348bb0daffSRob Clark 	struct omap_drm_private *priv = dev->dev_private;
2358bb0daffSRob Clark 
2368bb0daffSRob Clark 	if (priv->has_dmm) {
237e2cd09b2SLaurent Pinchart 		struct drm_property *prop = dev->mode_config.rotation_property;
238e2cd09b2SLaurent Pinchart 
2398bb0daffSRob Clark 		drm_object_attach_property(obj, prop, 0);
2408bb0daffSRob Clark 	}
2418bb0daffSRob Clark 
242e2cd09b2SLaurent Pinchart 	drm_object_attach_property(obj, priv->zorder_prop, 0);
2438bb0daffSRob Clark }
2448bb0daffSRob Clark 
245afc34932SLaurent Pinchart static struct drm_plane_state *
246afc34932SLaurent Pinchart omap_plane_atomic_duplicate_state(struct drm_plane *plane)
2478bb0daffSRob Clark {
248afc34932SLaurent Pinchart 	struct omap_plane_state *state;
249afc34932SLaurent Pinchart 	struct omap_plane_state *copy;
2508bb0daffSRob Clark 
251afc34932SLaurent Pinchart 	if (WARN_ON(!plane->state))
252afc34932SLaurent Pinchart 		return NULL;
253afc34932SLaurent Pinchart 
254afc34932SLaurent Pinchart 	state = to_omap_plane_state(plane->state);
255afc34932SLaurent Pinchart 	copy = kmemdup(state, sizeof(*state), GFP_KERNEL);
256afc34932SLaurent Pinchart 	if (copy == NULL)
257afc34932SLaurent Pinchart 		return NULL;
258afc34932SLaurent Pinchart 
259afc34932SLaurent Pinchart 	__drm_atomic_helper_plane_duplicate_state(plane, &copy->base);
260afc34932SLaurent Pinchart 
261afc34932SLaurent Pinchart 	return &copy->base;
2628bb0daffSRob Clark }
2638bb0daffSRob Clark 
264afc34932SLaurent Pinchart static void omap_plane_atomic_destroy_state(struct drm_plane *plane,
265afc34932SLaurent Pinchart 					    struct drm_plane_state *state)
266afc34932SLaurent Pinchart {
267afc34932SLaurent Pinchart 	__drm_atomic_helper_plane_destroy_state(plane, state);
268afc34932SLaurent Pinchart 	kfree(to_omap_plane_state(state));
269afc34932SLaurent Pinchart }
270afc34932SLaurent Pinchart 
271afc34932SLaurent Pinchart static int omap_plane_atomic_set_property(struct drm_plane *plane,
272afc34932SLaurent Pinchart 					  struct drm_plane_state *state,
273afc34932SLaurent Pinchart 					  struct drm_property *property,
274afc34932SLaurent Pinchart 					  uint64_t val)
275afc34932SLaurent Pinchart {
276afc34932SLaurent Pinchart 	struct omap_drm_private *priv = plane->dev->dev_private;
277afc34932SLaurent Pinchart 	struct omap_plane_state *omap_state = to_omap_plane_state(state);
278afc34932SLaurent Pinchart 
279afc34932SLaurent Pinchart 	if (property == priv->zorder_prop)
280afc34932SLaurent Pinchart 		omap_state->zorder = val;
281afc34932SLaurent Pinchart 	else
282afc34932SLaurent Pinchart 		return -EINVAL;
283afc34932SLaurent Pinchart 
284a42133a7SLaurent Pinchart 	return 0;
285afc34932SLaurent Pinchart }
286a42133a7SLaurent Pinchart 
287afc34932SLaurent Pinchart static int omap_plane_atomic_get_property(struct drm_plane *plane,
288afc34932SLaurent Pinchart 					  const struct drm_plane_state *state,
289afc34932SLaurent Pinchart 					  struct drm_property *property,
290afc34932SLaurent Pinchart 					  uint64_t *val)
291afc34932SLaurent Pinchart {
292afc34932SLaurent Pinchart 	struct omap_drm_private *priv = plane->dev->dev_private;
293afc34932SLaurent Pinchart 	const struct omap_plane_state *omap_state =
294afc34932SLaurent Pinchart 		container_of(state, const struct omap_plane_state, base);
295a42133a7SLaurent Pinchart 
296afc34932SLaurent Pinchart 	if (property == priv->zorder_prop)
297afc34932SLaurent Pinchart 		*val = omap_state->zorder;
298afc34932SLaurent Pinchart 	else
299afc34932SLaurent Pinchart 		return -EINVAL;
300afc34932SLaurent Pinchart 
301afc34932SLaurent Pinchart 	return 0;
3028bb0daffSRob Clark }
3038bb0daffSRob Clark 
3048bb0daffSRob Clark static const struct drm_plane_funcs omap_plane_funcs = {
305cef77d40SLaurent Pinchart 	.update_plane = drm_atomic_helper_update_plane,
306cef77d40SLaurent Pinchart 	.disable_plane = drm_atomic_helper_disable_plane,
307afc34932SLaurent Pinchart 	.reset = omap_plane_reset,
3088bb0daffSRob Clark 	.destroy = omap_plane_destroy,
309afc34932SLaurent Pinchart 	.set_property = drm_atomic_helper_plane_set_property,
310afc34932SLaurent Pinchart 	.atomic_duplicate_state = omap_plane_atomic_duplicate_state,
311afc34932SLaurent Pinchart 	.atomic_destroy_state = omap_plane_atomic_destroy_state,
312afc34932SLaurent Pinchart 	.atomic_set_property = omap_plane_atomic_set_property,
313afc34932SLaurent Pinchart 	.atomic_get_property = omap_plane_atomic_get_property,
3148bb0daffSRob Clark };
3158bb0daffSRob Clark 
3168bb0daffSRob Clark static void omap_plane_error_irq(struct omap_drm_irq *irq, uint32_t irqstatus)
3178bb0daffSRob Clark {
3188bb0daffSRob Clark 	struct omap_plane *omap_plane =
3198bb0daffSRob Clark 			container_of(irq, struct omap_plane, error_irq);
3203b143fc8STomi Valkeinen 	DRM_ERROR_RATELIMITED("%s: errors: %08x\n", omap_plane->name,
3213b143fc8STomi Valkeinen 		irqstatus);
3228bb0daffSRob Clark }
3238bb0daffSRob Clark 
3248bb0daffSRob Clark static const char *plane_names[] = {
3258bb0daffSRob Clark 	[OMAP_DSS_GFX] = "gfx",
3268bb0daffSRob Clark 	[OMAP_DSS_VIDEO1] = "vid1",
3278bb0daffSRob Clark 	[OMAP_DSS_VIDEO2] = "vid2",
3288bb0daffSRob Clark 	[OMAP_DSS_VIDEO3] = "vid3",
3298bb0daffSRob Clark };
3308bb0daffSRob Clark 
3318bb0daffSRob Clark static const uint32_t error_irqs[] = {
3328bb0daffSRob Clark 	[OMAP_DSS_GFX] = DISPC_IRQ_GFX_FIFO_UNDERFLOW,
3338bb0daffSRob Clark 	[OMAP_DSS_VIDEO1] = DISPC_IRQ_VID1_FIFO_UNDERFLOW,
3348bb0daffSRob Clark 	[OMAP_DSS_VIDEO2] = DISPC_IRQ_VID2_FIFO_UNDERFLOW,
3358bb0daffSRob Clark 	[OMAP_DSS_VIDEO3] = DISPC_IRQ_VID3_FIFO_UNDERFLOW,
3368bb0daffSRob Clark };
3378bb0daffSRob Clark 
3388bb0daffSRob Clark /* initialize plane */
3398bb0daffSRob Clark struct drm_plane *omap_plane_init(struct drm_device *dev,
340ef6b0e02SLaurent Pinchart 		int id, enum drm_plane_type type)
3418bb0daffSRob Clark {
3428bb0daffSRob Clark 	struct omap_drm_private *priv = dev->dev_private;
343ef6b0e02SLaurent Pinchart 	struct drm_plane *plane;
3448bb0daffSRob Clark 	struct omap_plane *omap_plane;
345ef6b0e02SLaurent Pinchart 	int ret;
3468bb0daffSRob Clark 
347ef6b0e02SLaurent Pinchart 	DBG("%s: type=%d", plane_names[id], type);
3488bb0daffSRob Clark 
3498bb0daffSRob Clark 	omap_plane = kzalloc(sizeof(*omap_plane), GFP_KERNEL);
350fffddfd6SLinus Torvalds 	if (!omap_plane)
351fb9a35f8SLaurent Pinchart 		return ERR_PTR(-ENOMEM);
3528bb0daffSRob Clark 
3538bb0daffSRob Clark 	omap_plane->nformats = omap_framebuffer_get_formats(
3548bb0daffSRob Clark 			omap_plane->formats, ARRAY_SIZE(omap_plane->formats),
3558bb0daffSRob Clark 			dss_feat_get_supported_color_modes(id));
3568bb0daffSRob Clark 	omap_plane->id = id;
3578bb0daffSRob Clark 	omap_plane->name = plane_names[id];
3588bb0daffSRob Clark 
3598bb0daffSRob Clark 	plane = &omap_plane->base;
3608bb0daffSRob Clark 
3618bb0daffSRob Clark 	omap_plane->error_irq.irqmask = error_irqs[id];
3628bb0daffSRob Clark 	omap_plane->error_irq.irq = omap_plane_error_irq;
3638bb0daffSRob Clark 	omap_irq_register(dev, &omap_plane->error_irq);
3648bb0daffSRob Clark 
365ef6b0e02SLaurent Pinchart 	ret = drm_universal_plane_init(dev, plane, (1 << priv->num_crtcs) - 1,
366ef6b0e02SLaurent Pinchart 				       &omap_plane_funcs, omap_plane->formats,
367ef6b0e02SLaurent Pinchart 				       omap_plane->nformats, type);
368ef6b0e02SLaurent Pinchart 	if (ret < 0)
369ef6b0e02SLaurent Pinchart 		goto error;
3708bb0daffSRob Clark 
371de8e4100SLaurent Pinchart 	drm_plane_helper_add(plane, &omap_plane_helper_funcs);
372de8e4100SLaurent Pinchart 
3738bb0daffSRob Clark 	omap_plane_install_properties(plane, &plane->base);
3748bb0daffSRob Clark 
3758bb0daffSRob Clark 	return plane;
376ef6b0e02SLaurent Pinchart 
377ef6b0e02SLaurent Pinchart error:
378ef6b0e02SLaurent Pinchart 	omap_irq_unregister(plane->dev, &omap_plane->error_irq);
379ef6b0e02SLaurent Pinchart 	kfree(omap_plane);
380ef6b0e02SLaurent Pinchart 	return NULL;
3818bb0daffSRob Clark }
382