18bb0daffSRob Clark /* 28bb0daffSRob Clark * drivers/gpu/drm/omapdrm/omap_plane.c 38bb0daffSRob Clark * 48bb0daffSRob Clark * Copyright (C) 2011 Texas Instruments 58bb0daffSRob Clark * Author: Rob Clark <rob.clark@linaro.org> 68bb0daffSRob Clark * 78bb0daffSRob Clark * This program is free software; you can redistribute it and/or modify it 88bb0daffSRob Clark * under the terms of the GNU General Public License version 2 as published by 98bb0daffSRob Clark * the Free Software Foundation. 108bb0daffSRob Clark * 118bb0daffSRob Clark * This program is distributed in the hope that it will be useful, but WITHOUT 128bb0daffSRob Clark * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or 138bb0daffSRob Clark * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for 148bb0daffSRob Clark * more details. 158bb0daffSRob Clark * 168bb0daffSRob Clark * You should have received a copy of the GNU General Public License along with 178bb0daffSRob Clark * this program. If not, see <http://www.gnu.org/licenses/>. 188bb0daffSRob Clark */ 198bb0daffSRob Clark 20c423bc85STomi Valkeinen #include <drm/drm_atomic.h> 2169a12263SLaurent Pinchart #include <drm/drm_atomic_helper.h> 22de8e4100SLaurent Pinchart #include <drm/drm_plane_helper.h> 2369a12263SLaurent Pinchart 248bb0daffSRob Clark #include "omap_dmm_tiler.h" 252d278f54SLaurent Pinchart #include "omap_drv.h" 268bb0daffSRob Clark 278bb0daffSRob Clark /* some hackery because omapdss has an 'enum omap_plane' (which would be 288bb0daffSRob Clark * better named omap_plane_id).. and compiler seems unhappy about having 298bb0daffSRob Clark * both a 'struct omap_plane' and 'enum omap_plane' 308bb0daffSRob Clark */ 318bb0daffSRob Clark #define omap_plane _omap_plane 328bb0daffSRob Clark 338bb0daffSRob Clark /* 348bb0daffSRob Clark * plane funcs 358bb0daffSRob Clark */ 368bb0daffSRob Clark 378bb0daffSRob Clark #define to_omap_plane(x) container_of(x, struct omap_plane, base) 388bb0daffSRob Clark 398bb0daffSRob Clark struct omap_plane { 408bb0daffSRob Clark struct drm_plane base; 418bb0daffSRob Clark int id; /* TODO rename omap_plane -> omap_plane_id in omapdss so I can use the enum */ 428bb0daffSRob Clark const char *name; 438bb0daffSRob Clark 448bb0daffSRob Clark uint32_t nformats; 458bb0daffSRob Clark uint32_t formats[32]; 468bb0daffSRob Clark 478bb0daffSRob Clark struct omap_drm_irq error_irq; 488bb0daffSRob Clark }; 498bb0daffSRob Clark 50afc34932SLaurent Pinchart struct omap_plane_state { 51afc34932SLaurent Pinchart struct drm_plane_state base; 52afc34932SLaurent Pinchart 53afc34932SLaurent Pinchart unsigned int zorder; 54afc34932SLaurent Pinchart }; 55afc34932SLaurent Pinchart 56afc34932SLaurent Pinchart static inline struct omap_plane_state * 57afc34932SLaurent Pinchart to_omap_plane_state(struct drm_plane_state *state) 588bb0daffSRob Clark { 59afc34932SLaurent Pinchart return container_of(state, struct omap_plane_state, base); 60afc34932SLaurent Pinchart } 61afc34932SLaurent Pinchart 6211ffd031STomi Valkeinen static int omap_plane_prepare_fb(struct drm_plane *plane, 631832040dSChris Wilson struct drm_plane_state *new_state) 6411ffd031STomi Valkeinen { 65844f9111SMaarten Lankhorst if (!new_state->fb) 66844f9111SMaarten Lankhorst return 0; 67844f9111SMaarten Lankhorst 68844f9111SMaarten Lankhorst return omap_framebuffer_pin(new_state->fb); 6911ffd031STomi Valkeinen } 7011ffd031STomi Valkeinen 7111ffd031STomi Valkeinen static void omap_plane_cleanup_fb(struct drm_plane *plane, 721832040dSChris Wilson struct drm_plane_state *old_state) 7311ffd031STomi Valkeinen { 74844f9111SMaarten Lankhorst if (old_state->fb) 75844f9111SMaarten Lankhorst omap_framebuffer_unpin(old_state->fb); 7611ffd031STomi Valkeinen } 7711ffd031STomi Valkeinen 7811ffd031STomi Valkeinen static void omap_plane_atomic_update(struct drm_plane *plane, 7911ffd031STomi Valkeinen struct drm_plane_state *old_state) 80afc34932SLaurent Pinchart { 81edc72557SLaurent Pinchart struct omap_plane *omap_plane = to_omap_plane(plane); 82edc72557SLaurent Pinchart struct drm_plane_state *state = plane->state; 83afc34932SLaurent Pinchart struct omap_plane_state *omap_state = to_omap_plane_state(state); 84fb730c9bSLaurent Pinchart struct omap_overlay_info info; 85fb730c9bSLaurent Pinchart struct omap_drm_window win; 868bb0daffSRob Clark int ret; 878bb0daffSRob Clark 88edc72557SLaurent Pinchart DBG("%s, crtc=%p fb=%p", omap_plane->name, state->crtc, state->fb); 898bb0daffSRob Clark 90fb730c9bSLaurent Pinchart memset(&info, 0, sizeof(info)); 91fb730c9bSLaurent Pinchart info.rotation_type = OMAP_DSS_ROT_DMA; 92fb730c9bSLaurent Pinchart info.rotation = OMAP_DSS_ROT_0; 93fb730c9bSLaurent Pinchart info.global_alpha = 0xff; 94fb730c9bSLaurent Pinchart info.mirror = 0; 95fb730c9bSLaurent Pinchart info.zorder = omap_state->zorder; 96fb730c9bSLaurent Pinchart 97fb730c9bSLaurent Pinchart memset(&win, 0, sizeof(win)); 98fb730c9bSLaurent Pinchart win.rotation = state->rotation; 99fb730c9bSLaurent Pinchart win.crtc_x = state->crtc_x; 100fb730c9bSLaurent Pinchart win.crtc_y = state->crtc_y; 101fb730c9bSLaurent Pinchart win.crtc_w = state->crtc_w; 102fb730c9bSLaurent Pinchart win.crtc_h = state->crtc_h; 103fb730c9bSLaurent Pinchart 104fb730c9bSLaurent Pinchart /* 105fb730c9bSLaurent Pinchart * src values are in Q16 fixed point, convert to integer. 106fb730c9bSLaurent Pinchart * omap_framebuffer_update_scanout() takes adjusted src. 107fb730c9bSLaurent Pinchart */ 108fb730c9bSLaurent Pinchart win.src_x = state->src_x >> 16; 109fb730c9bSLaurent Pinchart win.src_y = state->src_y >> 16; 110fb730c9bSLaurent Pinchart 11114152c8dSJoonas Lahtinen switch (state->rotation & DRM_ROTATE_MASK) { 11231ad61e4SJoonas Lahtinen case DRM_ROTATE_90: 11331ad61e4SJoonas Lahtinen case DRM_ROTATE_270: 114fb730c9bSLaurent Pinchart win.src_w = state->src_h >> 16; 115fb730c9bSLaurent Pinchart win.src_h = state->src_w >> 16; 116fb730c9bSLaurent Pinchart break; 117fb730c9bSLaurent Pinchart default: 118fb730c9bSLaurent Pinchart win.src_w = state->src_w >> 16; 119fb730c9bSLaurent Pinchart win.src_h = state->src_h >> 16; 120fb730c9bSLaurent Pinchart break; 121fb730c9bSLaurent Pinchart } 122afc34932SLaurent Pinchart 1238bb0daffSRob Clark /* update scanout: */ 124fb730c9bSLaurent Pinchart omap_framebuffer_update_scanout(state->fb, &win, &info); 1258bb0daffSRob Clark 126fb730c9bSLaurent Pinchart DBG("%dx%d -> %dx%d (%d)", info.width, info.height, 127fb730c9bSLaurent Pinchart info.out_width, info.out_height, 128fb730c9bSLaurent Pinchart info.screen_width); 129fb730c9bSLaurent Pinchart DBG("%d,%d %pad %pad", info.pos_x, info.pos_y, 130fb730c9bSLaurent Pinchart &info.paddr, &info.p_uv_addr); 1318bb0daffSRob Clark 132a42133a7SLaurent Pinchart dispc_ovl_set_channel_out(omap_plane->id, 133afc34932SLaurent Pinchart omap_crtc_channel(state->crtc)); 1342dd3887bSTomi Valkeinen 1358bb0daffSRob Clark /* and finally, update omapdss: */ 136fb730c9bSLaurent Pinchart ret = dispc_ovl_setup(omap_plane->id, &info, false, 137afc34932SLaurent Pinchart omap_crtc_timings(state->crtc), false); 138794a65ffSTomi Valkeinen if (WARN_ON(ret)) { 139794a65ffSTomi Valkeinen dispc_ovl_enable(omap_plane->id, false); 140d9157dfdSTomi Valkeinen return; 141794a65ffSTomi Valkeinen } 1428bb0daffSRob Clark 1438bb0daffSRob Clark dispc_ovl_enable(omap_plane->id, true); 144de8e4100SLaurent Pinchart } 145de8e4100SLaurent Pinchart 146de8e4100SLaurent Pinchart static void omap_plane_atomic_disable(struct drm_plane *plane, 147de8e4100SLaurent Pinchart struct drm_plane_state *old_state) 1488bb0daffSRob Clark { 149afc34932SLaurent Pinchart struct omap_plane_state *omap_state = to_omap_plane_state(plane->state); 1508bb0daffSRob Clark struct omap_plane *omap_plane = to_omap_plane(plane); 1512debab97SLaurent Pinchart 15231ad61e4SJoonas Lahtinen plane->state->rotation = DRM_ROTATE_0; 153afc34932SLaurent Pinchart omap_state->zorder = plane->type == DRM_PLANE_TYPE_PRIMARY 15482e58855SLaurent Pinchart ? 0 : omap_plane->id; 15582e58855SLaurent Pinchart 15611ffd031STomi Valkeinen dispc_ovl_enable(omap_plane->id, false); 1578bb0daffSRob Clark } 1588bb0daffSRob Clark 159c423bc85STomi Valkeinen static int omap_plane_atomic_check(struct drm_plane *plane, 160c423bc85STomi Valkeinen struct drm_plane_state *state) 161c423bc85STomi Valkeinen { 162c423bc85STomi Valkeinen struct drm_crtc_state *crtc_state; 163c423bc85STomi Valkeinen 164c423bc85STomi Valkeinen if (!state->crtc) 165c423bc85STomi Valkeinen return 0; 166c423bc85STomi Valkeinen 167c423bc85STomi Valkeinen crtc_state = drm_atomic_get_crtc_state(state->state, state->crtc); 168c423bc85STomi Valkeinen if (IS_ERR(crtc_state)) 169c423bc85STomi Valkeinen return PTR_ERR(crtc_state); 170c423bc85STomi Valkeinen 171c423bc85STomi Valkeinen if (state->crtc_x < 0 || state->crtc_y < 0) 172c423bc85STomi Valkeinen return -EINVAL; 173c423bc85STomi Valkeinen 174c423bc85STomi Valkeinen if (state->crtc_x + state->crtc_w > crtc_state->adjusted_mode.hdisplay) 175c423bc85STomi Valkeinen return -EINVAL; 176c423bc85STomi Valkeinen 177c423bc85STomi Valkeinen if (state->crtc_y + state->crtc_h > crtc_state->adjusted_mode.vdisplay) 178c423bc85STomi Valkeinen return -EINVAL; 179c423bc85STomi Valkeinen 180bfeece55STomi Valkeinen if (state->fb) { 18131ad61e4SJoonas Lahtinen if (state->rotation != DRM_ROTATE_0 && 182bfeece55STomi Valkeinen !omap_framebuffer_supports_rotation(state->fb)) 183bfeece55STomi Valkeinen return -EINVAL; 184bfeece55STomi Valkeinen } 185bfeece55STomi Valkeinen 186c423bc85STomi Valkeinen return 0; 187c423bc85STomi Valkeinen } 188c423bc85STomi Valkeinen 189de8e4100SLaurent Pinchart static const struct drm_plane_helper_funcs omap_plane_helper_funcs = { 190de8e4100SLaurent Pinchart .prepare_fb = omap_plane_prepare_fb, 191de8e4100SLaurent Pinchart .cleanup_fb = omap_plane_cleanup_fb, 192c423bc85STomi Valkeinen .atomic_check = omap_plane_atomic_check, 193de8e4100SLaurent Pinchart .atomic_update = omap_plane_atomic_update, 194de8e4100SLaurent Pinchart .atomic_disable = omap_plane_atomic_disable, 195de8e4100SLaurent Pinchart }; 196de8e4100SLaurent Pinchart 1978bb0daffSRob Clark static void omap_plane_destroy(struct drm_plane *plane) 1988bb0daffSRob Clark { 1998bb0daffSRob Clark struct omap_plane *omap_plane = to_omap_plane(plane); 2008bb0daffSRob Clark 2018bb0daffSRob Clark DBG("%s", omap_plane->name); 2028bb0daffSRob Clark 2038bb0daffSRob Clark omap_irq_unregister(plane->dev, &omap_plane->error_irq); 2048bb0daffSRob Clark 2058bb0daffSRob Clark drm_plane_cleanup(plane); 2068bb0daffSRob Clark 2078bb0daffSRob Clark kfree(omap_plane); 2088bb0daffSRob Clark } 2098bb0daffSRob Clark 2108bb0daffSRob Clark /* helper to install properties which are common to planes and crtcs */ 2118bb0daffSRob Clark void omap_plane_install_properties(struct drm_plane *plane, 2128bb0daffSRob Clark struct drm_mode_object *obj) 2138bb0daffSRob Clark { 2148bb0daffSRob Clark struct drm_device *dev = plane->dev; 2158bb0daffSRob Clark struct omap_drm_private *priv = dev->dev_private; 2168bb0daffSRob Clark 2178bb0daffSRob Clark if (priv->has_dmm) { 218e2cd09b2SLaurent Pinchart struct drm_property *prop = dev->mode_config.rotation_property; 219e2cd09b2SLaurent Pinchart 2208bb0daffSRob Clark drm_object_attach_property(obj, prop, 0); 2218bb0daffSRob Clark } 2228bb0daffSRob Clark 223e2cd09b2SLaurent Pinchart drm_object_attach_property(obj, priv->zorder_prop, 0); 2248bb0daffSRob Clark } 2258bb0daffSRob Clark 226afc34932SLaurent Pinchart static struct drm_plane_state * 227afc34932SLaurent Pinchart omap_plane_atomic_duplicate_state(struct drm_plane *plane) 2288bb0daffSRob Clark { 229afc34932SLaurent Pinchart struct omap_plane_state *state; 230afc34932SLaurent Pinchart struct omap_plane_state *copy; 2318bb0daffSRob Clark 232afc34932SLaurent Pinchart if (WARN_ON(!plane->state)) 233afc34932SLaurent Pinchart return NULL; 234afc34932SLaurent Pinchart 235afc34932SLaurent Pinchart state = to_omap_plane_state(plane->state); 236afc34932SLaurent Pinchart copy = kmemdup(state, sizeof(*state), GFP_KERNEL); 237afc34932SLaurent Pinchart if (copy == NULL) 238afc34932SLaurent Pinchart return NULL; 239afc34932SLaurent Pinchart 240afc34932SLaurent Pinchart __drm_atomic_helper_plane_duplicate_state(plane, ©->base); 241afc34932SLaurent Pinchart 242afc34932SLaurent Pinchart return ©->base; 2438bb0daffSRob Clark } 2448bb0daffSRob Clark 245afc34932SLaurent Pinchart static void omap_plane_atomic_destroy_state(struct drm_plane *plane, 246afc34932SLaurent Pinchart struct drm_plane_state *state) 247afc34932SLaurent Pinchart { 2482f701695SDaniel Vetter __drm_atomic_helper_plane_destroy_state(state); 249afc34932SLaurent Pinchart kfree(to_omap_plane_state(state)); 250afc34932SLaurent Pinchart } 251afc34932SLaurent Pinchart 252e07323cfSTomi Valkeinen static void omap_plane_reset(struct drm_plane *plane) 253e07323cfSTomi Valkeinen { 254e07323cfSTomi Valkeinen struct omap_plane *omap_plane = to_omap_plane(plane); 255e07323cfSTomi Valkeinen struct omap_plane_state *omap_state; 256e07323cfSTomi Valkeinen 257f8ef29eeSLaurent Pinchart if (plane->state) { 258f8ef29eeSLaurent Pinchart omap_plane_atomic_destroy_state(plane, plane->state); 259e07323cfSTomi Valkeinen plane->state = NULL; 260f8ef29eeSLaurent Pinchart } 261e07323cfSTomi Valkeinen 262e07323cfSTomi Valkeinen omap_state = kzalloc(sizeof(*omap_state), GFP_KERNEL); 263e07323cfSTomi Valkeinen if (omap_state == NULL) 264e07323cfSTomi Valkeinen return; 265e07323cfSTomi Valkeinen 266e07323cfSTomi Valkeinen /* 267e07323cfSTomi Valkeinen * Set defaults depending on whether we are a primary or overlay 268e07323cfSTomi Valkeinen * plane. 269e07323cfSTomi Valkeinen */ 270e07323cfSTomi Valkeinen omap_state->zorder = plane->type == DRM_PLANE_TYPE_PRIMARY 271e07323cfSTomi Valkeinen ? 0 : omap_plane->id; 27231ad61e4SJoonas Lahtinen omap_state->base.rotation = DRM_ROTATE_0; 273e07323cfSTomi Valkeinen 274e07323cfSTomi Valkeinen plane->state = &omap_state->base; 275e07323cfSTomi Valkeinen plane->state->plane = plane; 276e07323cfSTomi Valkeinen } 277e07323cfSTomi Valkeinen 278afc34932SLaurent Pinchart static int omap_plane_atomic_set_property(struct drm_plane *plane, 279afc34932SLaurent Pinchart struct drm_plane_state *state, 280afc34932SLaurent Pinchart struct drm_property *property, 281afc34932SLaurent Pinchart uint64_t val) 282afc34932SLaurent Pinchart { 283afc34932SLaurent Pinchart struct omap_drm_private *priv = plane->dev->dev_private; 284afc34932SLaurent Pinchart struct omap_plane_state *omap_state = to_omap_plane_state(state); 285afc34932SLaurent Pinchart 286afc34932SLaurent Pinchart if (property == priv->zorder_prop) 287afc34932SLaurent Pinchart omap_state->zorder = val; 288afc34932SLaurent Pinchart else 289afc34932SLaurent Pinchart return -EINVAL; 290afc34932SLaurent Pinchart 291a42133a7SLaurent Pinchart return 0; 292afc34932SLaurent Pinchart } 293a42133a7SLaurent Pinchart 294afc34932SLaurent Pinchart static int omap_plane_atomic_get_property(struct drm_plane *plane, 295afc34932SLaurent Pinchart const struct drm_plane_state *state, 296afc34932SLaurent Pinchart struct drm_property *property, 297afc34932SLaurent Pinchart uint64_t *val) 298afc34932SLaurent Pinchart { 299afc34932SLaurent Pinchart struct omap_drm_private *priv = plane->dev->dev_private; 300afc34932SLaurent Pinchart const struct omap_plane_state *omap_state = 301afc34932SLaurent Pinchart container_of(state, const struct omap_plane_state, base); 302a42133a7SLaurent Pinchart 303afc34932SLaurent Pinchart if (property == priv->zorder_prop) 304afc34932SLaurent Pinchart *val = omap_state->zorder; 305afc34932SLaurent Pinchart else 306afc34932SLaurent Pinchart return -EINVAL; 307afc34932SLaurent Pinchart 308afc34932SLaurent Pinchart return 0; 3098bb0daffSRob Clark } 3108bb0daffSRob Clark 3118bb0daffSRob Clark static const struct drm_plane_funcs omap_plane_funcs = { 312cef77d40SLaurent Pinchart .update_plane = drm_atomic_helper_update_plane, 313cef77d40SLaurent Pinchart .disable_plane = drm_atomic_helper_disable_plane, 314afc34932SLaurent Pinchart .reset = omap_plane_reset, 3158bb0daffSRob Clark .destroy = omap_plane_destroy, 316afc34932SLaurent Pinchart .set_property = drm_atomic_helper_plane_set_property, 317afc34932SLaurent Pinchart .atomic_duplicate_state = omap_plane_atomic_duplicate_state, 318afc34932SLaurent Pinchart .atomic_destroy_state = omap_plane_atomic_destroy_state, 319afc34932SLaurent Pinchart .atomic_set_property = omap_plane_atomic_set_property, 320afc34932SLaurent Pinchart .atomic_get_property = omap_plane_atomic_get_property, 3218bb0daffSRob Clark }; 3228bb0daffSRob Clark 3238bb0daffSRob Clark static void omap_plane_error_irq(struct omap_drm_irq *irq, uint32_t irqstatus) 3248bb0daffSRob Clark { 3258bb0daffSRob Clark struct omap_plane *omap_plane = 3268bb0daffSRob Clark container_of(irq, struct omap_plane, error_irq); 3273b143fc8STomi Valkeinen DRM_ERROR_RATELIMITED("%s: errors: %08x\n", omap_plane->name, 3283b143fc8STomi Valkeinen irqstatus); 3298bb0daffSRob Clark } 3308bb0daffSRob Clark 3318bb0daffSRob Clark static const char *plane_names[] = { 3328bb0daffSRob Clark [OMAP_DSS_GFX] = "gfx", 3338bb0daffSRob Clark [OMAP_DSS_VIDEO1] = "vid1", 3348bb0daffSRob Clark [OMAP_DSS_VIDEO2] = "vid2", 3358bb0daffSRob Clark [OMAP_DSS_VIDEO3] = "vid3", 3368bb0daffSRob Clark }; 3378bb0daffSRob Clark 3388bb0daffSRob Clark static const uint32_t error_irqs[] = { 3398bb0daffSRob Clark [OMAP_DSS_GFX] = DISPC_IRQ_GFX_FIFO_UNDERFLOW, 3408bb0daffSRob Clark [OMAP_DSS_VIDEO1] = DISPC_IRQ_VID1_FIFO_UNDERFLOW, 3418bb0daffSRob Clark [OMAP_DSS_VIDEO2] = DISPC_IRQ_VID2_FIFO_UNDERFLOW, 3428bb0daffSRob Clark [OMAP_DSS_VIDEO3] = DISPC_IRQ_VID3_FIFO_UNDERFLOW, 3438bb0daffSRob Clark }; 3448bb0daffSRob Clark 3458bb0daffSRob Clark /* initialize plane */ 3468bb0daffSRob Clark struct drm_plane *omap_plane_init(struct drm_device *dev, 347ef6b0e02SLaurent Pinchart int id, enum drm_plane_type type) 3488bb0daffSRob Clark { 3498bb0daffSRob Clark struct omap_drm_private *priv = dev->dev_private; 350ef6b0e02SLaurent Pinchart struct drm_plane *plane; 3518bb0daffSRob Clark struct omap_plane *omap_plane; 352ef6b0e02SLaurent Pinchart int ret; 3538bb0daffSRob Clark 354ef6b0e02SLaurent Pinchart DBG("%s: type=%d", plane_names[id], type); 3558bb0daffSRob Clark 3568bb0daffSRob Clark omap_plane = kzalloc(sizeof(*omap_plane), GFP_KERNEL); 357fffddfd6SLinus Torvalds if (!omap_plane) 358fb9a35f8SLaurent Pinchart return ERR_PTR(-ENOMEM); 3598bb0daffSRob Clark 3608bb0daffSRob Clark omap_plane->nformats = omap_framebuffer_get_formats( 3618bb0daffSRob Clark omap_plane->formats, ARRAY_SIZE(omap_plane->formats), 3628bb0daffSRob Clark dss_feat_get_supported_color_modes(id)); 3638bb0daffSRob Clark omap_plane->id = id; 3648bb0daffSRob Clark omap_plane->name = plane_names[id]; 3658bb0daffSRob Clark 3668bb0daffSRob Clark plane = &omap_plane->base; 3678bb0daffSRob Clark 3688bb0daffSRob Clark omap_plane->error_irq.irqmask = error_irqs[id]; 3698bb0daffSRob Clark omap_plane->error_irq.irq = omap_plane_error_irq; 3708bb0daffSRob Clark omap_irq_register(dev, &omap_plane->error_irq); 3718bb0daffSRob Clark 372ef6b0e02SLaurent Pinchart ret = drm_universal_plane_init(dev, plane, (1 << priv->num_crtcs) - 1, 373ef6b0e02SLaurent Pinchart &omap_plane_funcs, omap_plane->formats, 374b0b3b795SVille Syrjälä omap_plane->nformats, type, NULL); 375ef6b0e02SLaurent Pinchart if (ret < 0) 376ef6b0e02SLaurent Pinchart goto error; 3778bb0daffSRob Clark 378de8e4100SLaurent Pinchart drm_plane_helper_add(plane, &omap_plane_helper_funcs); 379de8e4100SLaurent Pinchart 3808bb0daffSRob Clark omap_plane_install_properties(plane, &plane->base); 3818bb0daffSRob Clark 3828bb0daffSRob Clark return plane; 383ef6b0e02SLaurent Pinchart 384ef6b0e02SLaurent Pinchart error: 385ef6b0e02SLaurent Pinchart omap_irq_unregister(plane->dev, &omap_plane->error_irq); 386ef6b0e02SLaurent Pinchart kfree(omap_plane); 387ef6b0e02SLaurent Pinchart return NULL; 3888bb0daffSRob Clark } 389