1 /*
2  * Copyright (c) 2015 MediaTek Inc.
3  *
4  * This program is free software; you can redistribute it and/or modify
5  * it under the terms of the GNU General Public License version 2 as
6  * published by the Free Software Foundation.
7  *
8  * This program is distributed in the hope that it will be useful,
9  * but WITHOUT ANY WARRANTY; without even the implied warranty of
10  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11  * GNU General Public License for more details.
12  */
13 
14 #include <asm/barrier.h>
15 #include <drm/drmP.h>
16 #include <drm/drm_atomic_helper.h>
17 #include <drm/drm_crtc_helper.h>
18 #include <drm/drm_plane_helper.h>
19 #include <linux/clk.h>
20 #include <linux/pm_runtime.h>
21 #include <soc/mediatek/smi.h>
22 
23 #include "mtk_drm_drv.h"
24 #include "mtk_drm_crtc.h"
25 #include "mtk_drm_ddp.h"
26 #include "mtk_drm_ddp_comp.h"
27 #include "mtk_drm_gem.h"
28 #include "mtk_drm_plane.h"
29 
30 /**
31  * struct mtk_drm_crtc - MediaTek specific crtc structure.
32  * @base: crtc object.
33  * @enabled: records whether crtc_enable succeeded
34  * @planes: array of 4 drm_plane structures, one for each overlay plane
35  * @pending_planes: whether any plane has pending changes to be applied
36  * @config_regs: memory mapped mmsys configuration register space
37  * @mutex: handle to one of the ten disp_mutex streams
38  * @ddp_comp_nr: number of components in ddp_comp
39  * @ddp_comp: array of pointers the mtk_ddp_comp structures used by this crtc
40  */
41 struct mtk_drm_crtc {
42 	struct drm_crtc			base;
43 	bool				enabled;
44 
45 	bool				pending_needs_vblank;
46 	struct drm_pending_vblank_event	*event;
47 
48 	struct drm_plane		planes[OVL_LAYER_NR];
49 	bool				pending_planes;
50 
51 	void __iomem			*config_regs;
52 	struct mtk_disp_mutex		*mutex;
53 	unsigned int			ddp_comp_nr;
54 	struct mtk_ddp_comp		**ddp_comp;
55 };
56 
57 struct mtk_crtc_state {
58 	struct drm_crtc_state		base;
59 
60 	bool				pending_config;
61 	unsigned int			pending_width;
62 	unsigned int			pending_height;
63 	unsigned int			pending_vrefresh;
64 };
65 
66 static inline struct mtk_drm_crtc *to_mtk_crtc(struct drm_crtc *c)
67 {
68 	return container_of(c, struct mtk_drm_crtc, base);
69 }
70 
71 static inline struct mtk_crtc_state *to_mtk_crtc_state(struct drm_crtc_state *s)
72 {
73 	return container_of(s, struct mtk_crtc_state, base);
74 }
75 
76 static void mtk_drm_crtc_finish_page_flip(struct mtk_drm_crtc *mtk_crtc)
77 {
78 	struct drm_crtc *crtc = &mtk_crtc->base;
79 	unsigned long flags;
80 
81 	spin_lock_irqsave(&crtc->dev->event_lock, flags);
82 	drm_crtc_send_vblank_event(crtc, mtk_crtc->event);
83 	drm_crtc_vblank_put(crtc);
84 	mtk_crtc->event = NULL;
85 	spin_unlock_irqrestore(&crtc->dev->event_lock, flags);
86 }
87 
88 static void mtk_drm_finish_page_flip(struct mtk_drm_crtc *mtk_crtc)
89 {
90 	drm_crtc_handle_vblank(&mtk_crtc->base);
91 	if (mtk_crtc->pending_needs_vblank) {
92 		mtk_drm_crtc_finish_page_flip(mtk_crtc);
93 		mtk_crtc->pending_needs_vblank = false;
94 	}
95 }
96 
97 static void mtk_drm_crtc_destroy(struct drm_crtc *crtc)
98 {
99 	struct mtk_drm_crtc *mtk_crtc = to_mtk_crtc(crtc);
100 	int i;
101 
102 	for (i = 0; i < mtk_crtc->ddp_comp_nr; i++)
103 		clk_unprepare(mtk_crtc->ddp_comp[i]->clk);
104 
105 	mtk_disp_mutex_put(mtk_crtc->mutex);
106 
107 	drm_crtc_cleanup(crtc);
108 }
109 
110 static void mtk_drm_crtc_reset(struct drm_crtc *crtc)
111 {
112 	struct mtk_crtc_state *state;
113 
114 	if (crtc->state) {
115 		__drm_atomic_helper_crtc_destroy_state(crtc->state);
116 
117 		state = to_mtk_crtc_state(crtc->state);
118 		memset(state, 0, sizeof(*state));
119 	} else {
120 		state = kzalloc(sizeof(*state), GFP_KERNEL);
121 		if (!state)
122 			return;
123 		crtc->state = &state->base;
124 	}
125 
126 	state->base.crtc = crtc;
127 }
128 
129 static struct drm_crtc_state *mtk_drm_crtc_duplicate_state(struct drm_crtc *crtc)
130 {
131 	struct mtk_crtc_state *state;
132 
133 	state = kzalloc(sizeof(*state), GFP_KERNEL);
134 	if (!state)
135 		return NULL;
136 
137 	__drm_atomic_helper_crtc_duplicate_state(crtc, &state->base);
138 
139 	WARN_ON(state->base.crtc != crtc);
140 	state->base.crtc = crtc;
141 
142 	return &state->base;
143 }
144 
145 static void mtk_drm_crtc_destroy_state(struct drm_crtc *crtc,
146 				       struct drm_crtc_state *state)
147 {
148 	__drm_atomic_helper_crtc_destroy_state(state);
149 	kfree(to_mtk_crtc_state(state));
150 }
151 
152 static bool mtk_drm_crtc_mode_fixup(struct drm_crtc *crtc,
153 				    const struct drm_display_mode *mode,
154 				    struct drm_display_mode *adjusted_mode)
155 {
156 	/* Nothing to do here, but this callback is mandatory. */
157 	return true;
158 }
159 
160 static void mtk_drm_crtc_mode_set_nofb(struct drm_crtc *crtc)
161 {
162 	struct mtk_crtc_state *state = to_mtk_crtc_state(crtc->state);
163 
164 	state->pending_width = crtc->mode.hdisplay;
165 	state->pending_height = crtc->mode.vdisplay;
166 	state->pending_vrefresh = crtc->mode.vrefresh;
167 	wmb();	/* Make sure the above parameters are set before update */
168 	state->pending_config = true;
169 }
170 
171 static int mtk_drm_crtc_enable_vblank(struct drm_crtc *crtc)
172 {
173 	struct mtk_drm_crtc *mtk_crtc = to_mtk_crtc(crtc);
174 	struct mtk_ddp_comp *ovl = mtk_crtc->ddp_comp[0];
175 
176 	mtk_ddp_comp_enable_vblank(ovl, &mtk_crtc->base);
177 
178 	return 0;
179 }
180 
181 static void mtk_drm_crtc_disable_vblank(struct drm_crtc *crtc)
182 {
183 	struct mtk_drm_crtc *mtk_crtc = to_mtk_crtc(crtc);
184 	struct mtk_ddp_comp *ovl = mtk_crtc->ddp_comp[0];
185 
186 	mtk_ddp_comp_disable_vblank(ovl);
187 }
188 
189 static int mtk_crtc_ddp_clk_enable(struct mtk_drm_crtc *mtk_crtc)
190 {
191 	int ret;
192 	int i;
193 
194 	DRM_DEBUG_DRIVER("%s\n", __func__);
195 	for (i = 0; i < mtk_crtc->ddp_comp_nr; i++) {
196 		ret = clk_enable(mtk_crtc->ddp_comp[i]->clk);
197 		if (ret) {
198 			DRM_ERROR("Failed to enable clock %d: %d\n", i, ret);
199 			goto err;
200 		}
201 	}
202 
203 	return 0;
204 err:
205 	while (--i >= 0)
206 		clk_disable(mtk_crtc->ddp_comp[i]->clk);
207 	return ret;
208 }
209 
210 static void mtk_crtc_ddp_clk_disable(struct mtk_drm_crtc *mtk_crtc)
211 {
212 	int i;
213 
214 	DRM_DEBUG_DRIVER("%s\n", __func__);
215 	for (i = 0; i < mtk_crtc->ddp_comp_nr; i++)
216 		clk_disable(mtk_crtc->ddp_comp[i]->clk);
217 }
218 
219 static int mtk_crtc_ddp_hw_init(struct mtk_drm_crtc *mtk_crtc)
220 {
221 	struct drm_crtc *crtc = &mtk_crtc->base;
222 	struct drm_connector *connector;
223 	struct drm_encoder *encoder;
224 	unsigned int width, height, vrefresh, bpc = MTK_MAX_BPC;
225 	int ret;
226 	int i;
227 
228 	DRM_DEBUG_DRIVER("%s\n", __func__);
229 	if (WARN_ON(!crtc->state))
230 		return -EINVAL;
231 
232 	width = crtc->state->adjusted_mode.hdisplay;
233 	height = crtc->state->adjusted_mode.vdisplay;
234 	vrefresh = crtc->state->adjusted_mode.vrefresh;
235 
236 	drm_for_each_encoder(encoder, crtc->dev) {
237 		if (encoder->crtc != crtc)
238 			continue;
239 
240 		drm_for_each_connector(connector, crtc->dev) {
241 			if (connector->encoder != encoder)
242 				continue;
243 			if (connector->display_info.bpc != 0 &&
244 			    bpc > connector->display_info.bpc)
245 				bpc = connector->display_info.bpc;
246 		}
247 	}
248 
249 	ret = pm_runtime_get_sync(crtc->dev->dev);
250 	if (ret < 0) {
251 		DRM_ERROR("Failed to enable power domain: %d\n", ret);
252 		return ret;
253 	}
254 
255 	ret = mtk_disp_mutex_prepare(mtk_crtc->mutex);
256 	if (ret < 0) {
257 		DRM_ERROR("Failed to enable mutex clock: %d\n", ret);
258 		goto err_pm_runtime_put;
259 	}
260 
261 	ret = mtk_crtc_ddp_clk_enable(mtk_crtc);
262 	if (ret < 0) {
263 		DRM_ERROR("Failed to enable component clocks: %d\n", ret);
264 		goto err_mutex_unprepare;
265 	}
266 
267 	DRM_DEBUG_DRIVER("mediatek_ddp_ddp_path_setup\n");
268 	for (i = 0; i < mtk_crtc->ddp_comp_nr - 1; i++) {
269 		mtk_ddp_add_comp_to_path(mtk_crtc->config_regs,
270 					 mtk_crtc->ddp_comp[i]->id,
271 					 mtk_crtc->ddp_comp[i + 1]->id);
272 		mtk_disp_mutex_add_comp(mtk_crtc->mutex,
273 					mtk_crtc->ddp_comp[i]->id);
274 	}
275 	mtk_disp_mutex_add_comp(mtk_crtc->mutex, mtk_crtc->ddp_comp[i]->id);
276 	mtk_disp_mutex_enable(mtk_crtc->mutex);
277 
278 	for (i = 0; i < mtk_crtc->ddp_comp_nr; i++) {
279 		struct mtk_ddp_comp *comp = mtk_crtc->ddp_comp[i];
280 
281 		mtk_ddp_comp_config(comp, width, height, vrefresh, bpc);
282 		mtk_ddp_comp_start(comp);
283 	}
284 
285 	/* Initially configure all planes */
286 	for (i = 0; i < OVL_LAYER_NR; i++) {
287 		struct drm_plane *plane = &mtk_crtc->planes[i];
288 		struct mtk_plane_state *plane_state;
289 
290 		plane_state = to_mtk_plane_state(plane->state);
291 		mtk_ddp_comp_layer_config(mtk_crtc->ddp_comp[0], i,
292 					  plane_state);
293 	}
294 
295 	return 0;
296 
297 err_mutex_unprepare:
298 	mtk_disp_mutex_unprepare(mtk_crtc->mutex);
299 err_pm_runtime_put:
300 	pm_runtime_put(crtc->dev->dev);
301 	return ret;
302 }
303 
304 static void mtk_crtc_ddp_hw_fini(struct mtk_drm_crtc *mtk_crtc)
305 {
306 	struct drm_device *drm = mtk_crtc->base.dev;
307 	int i;
308 
309 	DRM_DEBUG_DRIVER("%s\n", __func__);
310 	for (i = 0; i < mtk_crtc->ddp_comp_nr; i++)
311 		mtk_ddp_comp_stop(mtk_crtc->ddp_comp[i]);
312 	for (i = 0; i < mtk_crtc->ddp_comp_nr; i++)
313 		mtk_disp_mutex_remove_comp(mtk_crtc->mutex,
314 					   mtk_crtc->ddp_comp[i]->id);
315 	mtk_disp_mutex_disable(mtk_crtc->mutex);
316 	for (i = 0; i < mtk_crtc->ddp_comp_nr - 1; i++) {
317 		mtk_ddp_remove_comp_from_path(mtk_crtc->config_regs,
318 					      mtk_crtc->ddp_comp[i]->id,
319 					      mtk_crtc->ddp_comp[i + 1]->id);
320 		mtk_disp_mutex_remove_comp(mtk_crtc->mutex,
321 					   mtk_crtc->ddp_comp[i]->id);
322 	}
323 	mtk_disp_mutex_remove_comp(mtk_crtc->mutex, mtk_crtc->ddp_comp[i]->id);
324 	mtk_crtc_ddp_clk_disable(mtk_crtc);
325 	mtk_disp_mutex_unprepare(mtk_crtc->mutex);
326 
327 	pm_runtime_put(drm->dev);
328 }
329 
330 static void mtk_crtc_ddp_config(struct drm_crtc *crtc)
331 {
332 	struct mtk_drm_crtc *mtk_crtc = to_mtk_crtc(crtc);
333 	struct mtk_crtc_state *state = to_mtk_crtc_state(mtk_crtc->base.state);
334 	struct mtk_ddp_comp *ovl = mtk_crtc->ddp_comp[0];
335 	unsigned int i;
336 
337 	/*
338 	 * TODO: instead of updating the registers here, we should prepare
339 	 * working registers in atomic_commit and let the hardware command
340 	 * queue update module registers on vblank.
341 	 */
342 	if (state->pending_config) {
343 		mtk_ddp_comp_config(ovl, state->pending_width,
344 				    state->pending_height,
345 				    state->pending_vrefresh, 0);
346 
347 		state->pending_config = false;
348 	}
349 
350 	if (mtk_crtc->pending_planes) {
351 		for (i = 0; i < OVL_LAYER_NR; i++) {
352 			struct drm_plane *plane = &mtk_crtc->planes[i];
353 			struct mtk_plane_state *plane_state;
354 
355 			plane_state = to_mtk_plane_state(plane->state);
356 
357 			if (plane_state->pending.config) {
358 				mtk_ddp_comp_layer_config(ovl, i, plane_state);
359 				plane_state->pending.config = false;
360 			}
361 		}
362 		mtk_crtc->pending_planes = false;
363 	}
364 }
365 
366 static void mtk_drm_crtc_enable(struct drm_crtc *crtc)
367 {
368 	struct mtk_drm_crtc *mtk_crtc = to_mtk_crtc(crtc);
369 	struct mtk_ddp_comp *ovl = mtk_crtc->ddp_comp[0];
370 	int ret;
371 
372 	DRM_DEBUG_DRIVER("%s %d\n", __func__, crtc->base.id);
373 
374 	ret = mtk_smi_larb_get(ovl->larb_dev);
375 	if (ret) {
376 		DRM_ERROR("Failed to get larb: %d\n", ret);
377 		return;
378 	}
379 
380 	ret = mtk_crtc_ddp_hw_init(mtk_crtc);
381 	if (ret) {
382 		mtk_smi_larb_put(ovl->larb_dev);
383 		return;
384 	}
385 
386 	drm_crtc_vblank_on(crtc);
387 	mtk_crtc->enabled = true;
388 }
389 
390 static void mtk_drm_crtc_disable(struct drm_crtc *crtc)
391 {
392 	struct mtk_drm_crtc *mtk_crtc = to_mtk_crtc(crtc);
393 	struct mtk_ddp_comp *ovl = mtk_crtc->ddp_comp[0];
394 	int i;
395 
396 	DRM_DEBUG_DRIVER("%s %d\n", __func__, crtc->base.id);
397 	if (!mtk_crtc->enabled)
398 		return;
399 
400 	/* Set all pending plane state to disabled */
401 	for (i = 0; i < OVL_LAYER_NR; i++) {
402 		struct drm_plane *plane = &mtk_crtc->planes[i];
403 		struct mtk_plane_state *plane_state;
404 
405 		plane_state = to_mtk_plane_state(plane->state);
406 		plane_state->pending.enable = false;
407 		plane_state->pending.config = true;
408 	}
409 	mtk_crtc->pending_planes = true;
410 
411 	/* Wait for planes to be disabled */
412 	drm_crtc_wait_one_vblank(crtc);
413 
414 	drm_crtc_vblank_off(crtc);
415 	mtk_crtc_ddp_hw_fini(mtk_crtc);
416 	mtk_smi_larb_put(ovl->larb_dev);
417 
418 	mtk_crtc->enabled = false;
419 }
420 
421 static void mtk_drm_crtc_atomic_begin(struct drm_crtc *crtc,
422 				      struct drm_crtc_state *old_crtc_state)
423 {
424 	struct mtk_crtc_state *state = to_mtk_crtc_state(crtc->state);
425 	struct mtk_drm_crtc *mtk_crtc = to_mtk_crtc(crtc);
426 
427 	if (mtk_crtc->event && state->base.event)
428 		DRM_ERROR("new event while there is still a pending event\n");
429 
430 	if (state->base.event) {
431 		state->base.event->pipe = drm_crtc_index(crtc);
432 		WARN_ON(drm_crtc_vblank_get(crtc) != 0);
433 		mtk_crtc->event = state->base.event;
434 		state->base.event = NULL;
435 	}
436 }
437 
438 static void mtk_drm_crtc_atomic_flush(struct drm_crtc *crtc,
439 				      struct drm_crtc_state *old_crtc_state)
440 {
441 	struct mtk_drm_crtc *mtk_crtc = to_mtk_crtc(crtc);
442 	struct mtk_drm_private *priv = crtc->dev->dev_private;
443 	unsigned int pending_planes = 0;
444 	int i;
445 
446 	if (mtk_crtc->event)
447 		mtk_crtc->pending_needs_vblank = true;
448 	for (i = 0; i < OVL_LAYER_NR; i++) {
449 		struct drm_plane *plane = &mtk_crtc->planes[i];
450 		struct mtk_plane_state *plane_state;
451 
452 		plane_state = to_mtk_plane_state(plane->state);
453 		if (plane_state->pending.dirty) {
454 			plane_state->pending.config = true;
455 			plane_state->pending.dirty = false;
456 			pending_planes |= BIT(i);
457 		}
458 	}
459 	if (pending_planes)
460 		mtk_crtc->pending_planes = true;
461 	if (crtc->state->color_mgmt_changed)
462 		for (i = 0; i < mtk_crtc->ddp_comp_nr; i++)
463 			mtk_ddp_gamma_set(mtk_crtc->ddp_comp[i], crtc->state);
464 
465 	if (priv->data->shadow_register) {
466 		mtk_disp_mutex_acquire(mtk_crtc->mutex);
467 		mtk_crtc_ddp_config(crtc);
468 		mtk_disp_mutex_release(mtk_crtc->mutex);
469 	}
470 }
471 
472 static const struct drm_crtc_funcs mtk_crtc_funcs = {
473 	.set_config		= drm_atomic_helper_set_config,
474 	.page_flip		= drm_atomic_helper_page_flip,
475 	.destroy		= mtk_drm_crtc_destroy,
476 	.reset			= mtk_drm_crtc_reset,
477 	.atomic_duplicate_state	= mtk_drm_crtc_duplicate_state,
478 	.atomic_destroy_state	= mtk_drm_crtc_destroy_state,
479 	.gamma_set		= drm_atomic_helper_legacy_gamma_set,
480 	.enable_vblank		= mtk_drm_crtc_enable_vblank,
481 	.disable_vblank		= mtk_drm_crtc_disable_vblank,
482 };
483 
484 static const struct drm_crtc_helper_funcs mtk_crtc_helper_funcs = {
485 	.mode_fixup	= mtk_drm_crtc_mode_fixup,
486 	.mode_set_nofb	= mtk_drm_crtc_mode_set_nofb,
487 	.enable		= mtk_drm_crtc_enable,
488 	.disable	= mtk_drm_crtc_disable,
489 	.atomic_begin	= mtk_drm_crtc_atomic_begin,
490 	.atomic_flush	= mtk_drm_crtc_atomic_flush,
491 };
492 
493 static int mtk_drm_crtc_init(struct drm_device *drm,
494 			     struct mtk_drm_crtc *mtk_crtc,
495 			     struct drm_plane *primary,
496 			     struct drm_plane *cursor, unsigned int pipe)
497 {
498 	int ret;
499 
500 	ret = drm_crtc_init_with_planes(drm, &mtk_crtc->base, primary, cursor,
501 					&mtk_crtc_funcs, NULL);
502 	if (ret)
503 		goto err_cleanup_crtc;
504 
505 	drm_crtc_helper_add(&mtk_crtc->base, &mtk_crtc_helper_funcs);
506 
507 	return 0;
508 
509 err_cleanup_crtc:
510 	drm_crtc_cleanup(&mtk_crtc->base);
511 	return ret;
512 }
513 
514 void mtk_crtc_ddp_irq(struct drm_crtc *crtc, struct mtk_ddp_comp *ovl)
515 {
516 	struct mtk_drm_crtc *mtk_crtc = to_mtk_crtc(crtc);
517 	struct mtk_drm_private *priv = crtc->dev->dev_private;
518 
519 	if (!priv->data->shadow_register)
520 		mtk_crtc_ddp_config(crtc);
521 
522 	mtk_drm_finish_page_flip(mtk_crtc);
523 }
524 
525 int mtk_drm_crtc_create(struct drm_device *drm_dev,
526 			const enum mtk_ddp_comp_id *path, unsigned int path_len)
527 {
528 	struct mtk_drm_private *priv = drm_dev->dev_private;
529 	struct device *dev = drm_dev->dev;
530 	struct mtk_drm_crtc *mtk_crtc;
531 	enum drm_plane_type type;
532 	unsigned int zpos;
533 	int pipe = priv->num_pipes;
534 	int ret;
535 	int i;
536 
537 	for (i = 0; i < path_len; i++) {
538 		enum mtk_ddp_comp_id comp_id = path[i];
539 		struct device_node *node;
540 
541 		node = priv->comp_node[comp_id];
542 		if (!node) {
543 			dev_info(dev,
544 				 "Not creating crtc %d because component %d is disabled or missing\n",
545 				 pipe, comp_id);
546 			return 0;
547 		}
548 	}
549 
550 	mtk_crtc = devm_kzalloc(dev, sizeof(*mtk_crtc), GFP_KERNEL);
551 	if (!mtk_crtc)
552 		return -ENOMEM;
553 
554 	mtk_crtc->config_regs = priv->config_regs;
555 	mtk_crtc->ddp_comp_nr = path_len;
556 	mtk_crtc->ddp_comp = devm_kmalloc_array(dev, mtk_crtc->ddp_comp_nr,
557 						sizeof(*mtk_crtc->ddp_comp),
558 						GFP_KERNEL);
559 
560 	mtk_crtc->mutex = mtk_disp_mutex_get(priv->mutex_dev, pipe);
561 	if (IS_ERR(mtk_crtc->mutex)) {
562 		ret = PTR_ERR(mtk_crtc->mutex);
563 		dev_err(dev, "Failed to get mutex: %d\n", ret);
564 		return ret;
565 	}
566 
567 	for (i = 0; i < mtk_crtc->ddp_comp_nr; i++) {
568 		enum mtk_ddp_comp_id comp_id = path[i];
569 		struct mtk_ddp_comp *comp;
570 		struct device_node *node;
571 
572 		node = priv->comp_node[comp_id];
573 		comp = priv->ddp_comp[comp_id];
574 		if (!comp) {
575 			dev_err(dev, "Component %s not initialized\n",
576 				node->full_name);
577 			ret = -ENODEV;
578 			goto unprepare;
579 		}
580 
581 		ret = clk_prepare(comp->clk);
582 		if (ret) {
583 			dev_err(dev,
584 				"Failed to prepare clock for component %s: %d\n",
585 				node->full_name, ret);
586 			goto unprepare;
587 		}
588 
589 		mtk_crtc->ddp_comp[i] = comp;
590 	}
591 
592 	for (zpos = 0; zpos < OVL_LAYER_NR; zpos++) {
593 		type = (zpos == 0) ? DRM_PLANE_TYPE_PRIMARY :
594 				(zpos == 1) ? DRM_PLANE_TYPE_CURSOR :
595 						DRM_PLANE_TYPE_OVERLAY;
596 		ret = mtk_plane_init(drm_dev, &mtk_crtc->planes[zpos],
597 				     BIT(pipe), type);
598 		if (ret)
599 			goto unprepare;
600 	}
601 
602 	ret = mtk_drm_crtc_init(drm_dev, mtk_crtc, &mtk_crtc->planes[0],
603 				&mtk_crtc->planes[1], pipe);
604 	if (ret < 0)
605 		goto unprepare;
606 	drm_mode_crtc_set_gamma_size(&mtk_crtc->base, MTK_LUT_SIZE);
607 	drm_crtc_enable_color_mgmt(&mtk_crtc->base, 0, false, MTK_LUT_SIZE);
608 	priv->num_pipes++;
609 
610 	return 0;
611 
612 unprepare:
613 	while (--i >= 0)
614 		clk_unprepare(mtk_crtc->ddp_comp[i]->clk);
615 
616 	return ret;
617 }
618