1 // SPDX-License-Identifier: MIT
2 /*
3  * Copyright © 2016-2019 Intel Corporation
4  */
5 
6 #include <linux/bitfield.h>
7 #include <linux/firmware.h>
8 #include <linux/highmem.h>
9 
10 #include <drm/drm_cache.h>
11 #include <drm/drm_print.h>
12 
13 #include "gem/i915_gem_lmem.h"
14 #include "intel_uc_fw.h"
15 #include "intel_uc_fw_abi.h"
16 #include "i915_drv.h"
17 #include "i915_reg.h"
18 
19 static inline struct intel_gt *
20 ____uc_fw_to_gt(struct intel_uc_fw *uc_fw, enum intel_uc_fw_type type)
21 {
22 	if (type == INTEL_UC_FW_TYPE_GUC)
23 		return container_of(uc_fw, struct intel_gt, uc.guc.fw);
24 
25 	GEM_BUG_ON(type != INTEL_UC_FW_TYPE_HUC);
26 	return container_of(uc_fw, struct intel_gt, uc.huc.fw);
27 }
28 
29 static inline struct intel_gt *__uc_fw_to_gt(struct intel_uc_fw *uc_fw)
30 {
31 	GEM_BUG_ON(uc_fw->status == INTEL_UC_FIRMWARE_UNINITIALIZED);
32 	return ____uc_fw_to_gt(uc_fw, uc_fw->type);
33 }
34 
35 #ifdef CONFIG_DRM_I915_DEBUG_GUC
36 void intel_uc_fw_change_status(struct intel_uc_fw *uc_fw,
37 			       enum intel_uc_fw_status status)
38 {
39 	uc_fw->__status =  status;
40 	drm_dbg(&__uc_fw_to_gt(uc_fw)->i915->drm,
41 		"%s firmware -> %s\n",
42 		intel_uc_fw_type_repr(uc_fw->type),
43 		status == INTEL_UC_FIRMWARE_SELECTED ?
44 		uc_fw->file_selected.path : intel_uc_fw_status_repr(status));
45 }
46 #endif
47 
48 /*
49  * List of required GuC and HuC binaries per-platform.
50  * Must be ordered based on platform + revid, from newer to older.
51  *
52  * Note that RKL and ADL-S have the same GuC/HuC device ID's and use the same
53  * firmware as TGL.
54  *
55  * Version numbers:
56  * Originally, the driver required an exact match major/minor/patch furmware
57  * file and only supported that one version for any given platform. However,
58  * the new direction from upstream is to be backwards compatible with all
59  * prior releases and to be as flexible as possible as to what firmware is
60  * loaded.
61  *
62  * For GuC, the major version number signifies a backwards breaking API change.
63  * So, new format GuC firmware files are labelled by their major version only.
64  * For HuC, there is no KMD interaction, hence no version matching requirement.
65  * So, new format HuC firmware files have no version number at all.
66  *
67  * All of which means that the table below must keep all old format files with
68  * full three point version number. But newer files have reduced requirements.
69  * Having said that, the driver still needs to track the minor version number
70  * for GuC at least. As it is useful to report to the user that they are not
71  * running with a recent enough version for all KMD supported features,
72  * security fixes, etc. to be enabled.
73  */
74 #define INTEL_GUC_FIRMWARE_DEFS(fw_def, guc_maj, guc_mmp) \
75 	fw_def(DG2,          0, guc_maj(dg2,  70, 5)) \
76 	fw_def(ALDERLAKE_P,  0, guc_maj(adlp, 70, 5)) \
77 	fw_def(ALDERLAKE_P,  0, guc_mmp(adlp, 70, 1, 1)) \
78 	fw_def(ALDERLAKE_P,  0, guc_mmp(adlp, 69, 0, 3)) \
79 	fw_def(ALDERLAKE_S,  0, guc_maj(tgl,  70, 5)) \
80 	fw_def(ALDERLAKE_S,  0, guc_mmp(tgl,  70, 1, 1)) \
81 	fw_def(ALDERLAKE_S,  0, guc_mmp(tgl,  69, 0, 3)) \
82 	fw_def(DG1,          0, guc_maj(dg1,  70, 5)) \
83 	fw_def(ROCKETLAKE,   0, guc_mmp(tgl,  70, 1, 1)) \
84 	fw_def(TIGERLAKE,    0, guc_mmp(tgl,  70, 1, 1)) \
85 	fw_def(JASPERLAKE,   0, guc_mmp(ehl,  70, 1, 1)) \
86 	fw_def(ELKHARTLAKE,  0, guc_mmp(ehl,  70, 1, 1)) \
87 	fw_def(ICELAKE,      0, guc_mmp(icl,  70, 1, 1)) \
88 	fw_def(COMETLAKE,    5, guc_mmp(cml,  70, 1, 1)) \
89 	fw_def(COMETLAKE,    0, guc_mmp(kbl,  70, 1, 1)) \
90 	fw_def(COFFEELAKE,   0, guc_mmp(kbl,  70, 1, 1)) \
91 	fw_def(GEMINILAKE,   0, guc_mmp(glk,  70, 1, 1)) \
92 	fw_def(KABYLAKE,     0, guc_mmp(kbl,  70, 1, 1)) \
93 	fw_def(BROXTON,      0, guc_mmp(bxt,  70, 1, 1)) \
94 	fw_def(SKYLAKE,      0, guc_mmp(skl,  70, 1, 1))
95 
96 #define INTEL_HUC_FIRMWARE_DEFS(fw_def, huc_raw, huc_mmp, huc_gsc) \
97 	fw_def(DG2,          0, huc_gsc(dg2)) \
98 	fw_def(ALDERLAKE_P,  0, huc_raw(tgl)) \
99 	fw_def(ALDERLAKE_P,  0, huc_mmp(tgl,  7, 9, 3)) \
100 	fw_def(ALDERLAKE_S,  0, huc_raw(tgl)) \
101 	fw_def(ALDERLAKE_S,  0, huc_mmp(tgl,  7, 9, 3)) \
102 	fw_def(DG1,          0, huc_raw(dg1)) \
103 	fw_def(ROCKETLAKE,   0, huc_mmp(tgl,  7, 9, 3)) \
104 	fw_def(TIGERLAKE,    0, huc_mmp(tgl,  7, 9, 3)) \
105 	fw_def(JASPERLAKE,   0, huc_mmp(ehl,  9, 0, 0)) \
106 	fw_def(ELKHARTLAKE,  0, huc_mmp(ehl,  9, 0, 0)) \
107 	fw_def(ICELAKE,      0, huc_mmp(icl,  9, 0, 0)) \
108 	fw_def(COMETLAKE,    5, huc_mmp(cml,  4, 0, 0)) \
109 	fw_def(COMETLAKE,    0, huc_mmp(kbl,  4, 0, 0)) \
110 	fw_def(COFFEELAKE,   0, huc_mmp(kbl,  4, 0, 0)) \
111 	fw_def(GEMINILAKE,   0, huc_mmp(glk,  4, 0, 0)) \
112 	fw_def(KABYLAKE,     0, huc_mmp(kbl,  4, 0, 0)) \
113 	fw_def(BROXTON,      0, huc_mmp(bxt,  2, 0, 0)) \
114 	fw_def(SKYLAKE,      0, huc_mmp(skl,  2, 0, 0))
115 
116 /*
117  * Set of macros for producing a list of filenames from the above table.
118  */
119 #define __MAKE_UC_FW_PATH_BLANK(prefix_, name_) \
120 	"i915/" \
121 	__stringify(prefix_) name_ ".bin"
122 
123 #define __MAKE_UC_FW_PATH_MAJOR(prefix_, name_, major_) \
124 	"i915/" \
125 	__stringify(prefix_) name_ \
126 	__stringify(major_) ".bin"
127 
128 #define __MAKE_UC_FW_PATH_MMP(prefix_, name_, major_, minor_, patch_) \
129 	"i915/" \
130 	__stringify(prefix_) name_ \
131 	__stringify(major_) "." \
132 	__stringify(minor_) "." \
133 	__stringify(patch_) ".bin"
134 
135 /* Minor for internal driver use, not part of file name */
136 #define MAKE_GUC_FW_PATH_MAJOR(prefix_, major_, minor_) \
137 	__MAKE_UC_FW_PATH_MAJOR(prefix_, "_guc_", major_)
138 
139 #define MAKE_GUC_FW_PATH_MMP(prefix_, major_, minor_, patch_) \
140 	__MAKE_UC_FW_PATH_MMP(prefix_, "_guc_", major_, minor_, patch_)
141 
142 #define MAKE_HUC_FW_PATH_BLANK(prefix_) \
143 	__MAKE_UC_FW_PATH_BLANK(prefix_, "_huc")
144 
145 #define MAKE_HUC_FW_PATH_GSC(prefix_) \
146 	__MAKE_UC_FW_PATH_BLANK(prefix_, "_huc_gsc")
147 
148 #define MAKE_HUC_FW_PATH_MMP(prefix_, major_, minor_, patch_) \
149 	__MAKE_UC_FW_PATH_MMP(prefix_, "_huc_", major_, minor_, patch_)
150 
151 /*
152  * All blobs need to be declared via MODULE_FIRMWARE().
153  * This first expansion of the table macros is solely to provide
154  * that declaration.
155  */
156 #define INTEL_UC_MODULE_FW(platform_, revid_, uc_) \
157 	MODULE_FIRMWARE(uc_);
158 
159 INTEL_GUC_FIRMWARE_DEFS(INTEL_UC_MODULE_FW, MAKE_GUC_FW_PATH_MAJOR, MAKE_GUC_FW_PATH_MMP)
160 INTEL_HUC_FIRMWARE_DEFS(INTEL_UC_MODULE_FW, MAKE_HUC_FW_PATH_BLANK, MAKE_HUC_FW_PATH_MMP, MAKE_HUC_FW_PATH_GSC)
161 
162 /*
163  * The next expansion of the table macros (in __uc_fw_auto_select below) provides
164  * actual data structures with both the filename and the version information.
165  * These structure arrays are then iterated over to the list of suitable files
166  * for the current platform and to then attempt to load those files, in the order
167  * listed, until one is successfully found.
168  */
169 struct __packed uc_fw_blob {
170 	const char *path;
171 	bool legacy;
172 	u8 major;
173 	u8 minor;
174 	u8 patch;
175 	bool loaded_via_gsc;
176 };
177 
178 #define UC_FW_BLOB_BASE(major_, minor_, patch_, path_) \
179 	.major = major_, \
180 	.minor = minor_, \
181 	.patch = patch_, \
182 	.path = path_,
183 
184 #define UC_FW_BLOB_NEW(major_, minor_, patch_, gsc_, path_) \
185 	{ UC_FW_BLOB_BASE(major_, minor_, patch_, path_) \
186 	  .legacy = false, .loaded_via_gsc = gsc_ }
187 
188 #define UC_FW_BLOB_OLD(major_, minor_, patch_, path_) \
189 	{ UC_FW_BLOB_BASE(major_, minor_, patch_, path_) \
190 	  .legacy = true }
191 
192 #define GUC_FW_BLOB(prefix_, major_, minor_) \
193 	UC_FW_BLOB_NEW(major_, minor_, 0, false, \
194 		       MAKE_GUC_FW_PATH_MAJOR(prefix_, major_, minor_))
195 
196 #define GUC_FW_BLOB_MMP(prefix_, major_, minor_, patch_) \
197 	UC_FW_BLOB_OLD(major_, minor_, patch_, \
198 		       MAKE_GUC_FW_PATH_MMP(prefix_, major_, minor_, patch_))
199 
200 #define HUC_FW_BLOB(prefix_) \
201 	UC_FW_BLOB_NEW(0, 0, 0, false, MAKE_HUC_FW_PATH_BLANK(prefix_))
202 
203 #define HUC_FW_BLOB_MMP(prefix_, major_, minor_, patch_) \
204 	UC_FW_BLOB_OLD(major_, minor_, patch_, \
205 		       MAKE_HUC_FW_PATH_MMP(prefix_, major_, minor_, patch_))
206 
207 #define HUC_FW_BLOB_GSC(prefix_) \
208 	UC_FW_BLOB_NEW(0, 0, 0, true, MAKE_HUC_FW_PATH_GSC(prefix_))
209 
210 struct __packed uc_fw_platform_requirement {
211 	enum intel_platform p;
212 	u8 rev; /* first platform rev using this FW */
213 	const struct uc_fw_blob blob;
214 };
215 
216 #define MAKE_FW_LIST(platform_, revid_, uc_) \
217 { \
218 	.p = INTEL_##platform_, \
219 	.rev = revid_, \
220 	.blob = uc_, \
221 },
222 
223 struct fw_blobs_by_type {
224 	const struct uc_fw_platform_requirement *blobs;
225 	u32 count;
226 };
227 
228 static void
229 __uc_fw_auto_select(struct drm_i915_private *i915, struct intel_uc_fw *uc_fw)
230 {
231 	static const struct uc_fw_platform_requirement blobs_guc[] = {
232 		INTEL_GUC_FIRMWARE_DEFS(MAKE_FW_LIST, GUC_FW_BLOB, GUC_FW_BLOB_MMP)
233 	};
234 	static const struct uc_fw_platform_requirement blobs_huc[] = {
235 		INTEL_HUC_FIRMWARE_DEFS(MAKE_FW_LIST, HUC_FW_BLOB, HUC_FW_BLOB_MMP, HUC_FW_BLOB_GSC)
236 	};
237 	static const struct fw_blobs_by_type blobs_all[INTEL_UC_FW_NUM_TYPES] = {
238 		[INTEL_UC_FW_TYPE_GUC] = { blobs_guc, ARRAY_SIZE(blobs_guc) },
239 		[INTEL_UC_FW_TYPE_HUC] = { blobs_huc, ARRAY_SIZE(blobs_huc) },
240 	};
241 	static bool verified;
242 	const struct uc_fw_platform_requirement *fw_blobs;
243 	enum intel_platform p = INTEL_INFO(i915)->platform;
244 	u32 fw_count;
245 	u8 rev = INTEL_REVID(i915);
246 	int i;
247 	bool found;
248 
249 	/*
250 	 * The only difference between the ADL GuC FWs is the HWConfig support.
251 	 * ADL-N does not support HWConfig, so we should use the same binary as
252 	 * ADL-S, otherwise the GuC might attempt to fetch a config table that
253 	 * does not exist.
254 	 */
255 	if (IS_ADLP_N(i915))
256 		p = INTEL_ALDERLAKE_S;
257 
258 	GEM_BUG_ON(uc_fw->type >= ARRAY_SIZE(blobs_all));
259 	fw_blobs = blobs_all[uc_fw->type].blobs;
260 	fw_count = blobs_all[uc_fw->type].count;
261 
262 	found = false;
263 	for (i = 0; i < fw_count && p <= fw_blobs[i].p; i++) {
264 		const struct uc_fw_blob *blob = &fw_blobs[i].blob;
265 
266 		if (p != fw_blobs[i].p)
267 			continue;
268 
269 		if (rev < fw_blobs[i].rev)
270 			continue;
271 
272 		if (uc_fw->file_selected.path) {
273 			if (uc_fw->file_selected.path == blob->path)
274 				uc_fw->file_selected.path = NULL;
275 
276 			continue;
277 		}
278 
279 		uc_fw->file_selected.path = blob->path;
280 		uc_fw->file_wanted.path = blob->path;
281 		uc_fw->file_wanted.major_ver = blob->major;
282 		uc_fw->file_wanted.minor_ver = blob->minor;
283 		uc_fw->loaded_via_gsc = blob->loaded_via_gsc;
284 		found = true;
285 		break;
286 	}
287 
288 	if (!found && uc_fw->file_selected.path) {
289 		/* Failed to find a match for the last attempt?! */
290 		uc_fw->file_selected.path = NULL;
291 	}
292 
293 	/* make sure the list is ordered as expected */
294 	if (IS_ENABLED(CONFIG_DRM_I915_SELFTEST) && !verified) {
295 		verified = true;
296 
297 		for (i = 1; i < fw_count; i++) {
298 			/* Next platform is good: */
299 			if (fw_blobs[i].p < fw_blobs[i - 1].p)
300 				continue;
301 
302 			/* Next platform revision is good: */
303 			if (fw_blobs[i].p == fw_blobs[i - 1].p &&
304 			    fw_blobs[i].rev < fw_blobs[i - 1].rev)
305 				continue;
306 
307 			/* Platform/revision must be in order: */
308 			if (fw_blobs[i].p != fw_blobs[i - 1].p ||
309 			    fw_blobs[i].rev != fw_blobs[i - 1].rev)
310 				goto bad;
311 
312 			/* Next major version is good: */
313 			if (fw_blobs[i].blob.major < fw_blobs[i - 1].blob.major)
314 				continue;
315 
316 			/* New must be before legacy: */
317 			if (!fw_blobs[i].blob.legacy && fw_blobs[i - 1].blob.legacy)
318 				goto bad;
319 
320 			/* New to legacy also means 0.0 to X.Y (HuC), or X.0 to X.Y (GuC) */
321 			if (fw_blobs[i].blob.legacy && !fw_blobs[i - 1].blob.legacy) {
322 				if (!fw_blobs[i - 1].blob.major)
323 					continue;
324 
325 				if (fw_blobs[i].blob.major == fw_blobs[i - 1].blob.major)
326 					continue;
327 			}
328 
329 			/* Major versions must be in order: */
330 			if (fw_blobs[i].blob.major != fw_blobs[i - 1].blob.major)
331 				goto bad;
332 
333 			/* Next minor version is good: */
334 			if (fw_blobs[i].blob.minor < fw_blobs[i - 1].blob.minor)
335 				continue;
336 
337 			/* Minor versions must be in order: */
338 			if (fw_blobs[i].blob.minor != fw_blobs[i - 1].blob.minor)
339 				goto bad;
340 
341 			/* Patch versions must be in order: */
342 			if (fw_blobs[i].blob.patch <= fw_blobs[i - 1].blob.patch)
343 				continue;
344 
345 bad:
346 			drm_err(&i915->drm, "Invalid FW blob order: %s r%u %s%d.%d.%d comes before %s r%u %s%d.%d.%d\n",
347 				intel_platform_name(fw_blobs[i - 1].p), fw_blobs[i - 1].rev,
348 				fw_blobs[i - 1].blob.legacy ? "L" : "v",
349 				fw_blobs[i - 1].blob.major,
350 				fw_blobs[i - 1].blob.minor,
351 				fw_blobs[i - 1].blob.patch,
352 				intel_platform_name(fw_blobs[i].p), fw_blobs[i].rev,
353 				fw_blobs[i].blob.legacy ? "L" : "v",
354 				fw_blobs[i].blob.major,
355 				fw_blobs[i].blob.minor,
356 				fw_blobs[i].blob.patch);
357 
358 			uc_fw->file_selected.path = NULL;
359 		}
360 	}
361 }
362 
363 static const char *__override_guc_firmware_path(struct drm_i915_private *i915)
364 {
365 	if (i915->params.enable_guc & ENABLE_GUC_MASK)
366 		return i915->params.guc_firmware_path;
367 	return "";
368 }
369 
370 static const char *__override_huc_firmware_path(struct drm_i915_private *i915)
371 {
372 	if (i915->params.enable_guc & ENABLE_GUC_LOAD_HUC)
373 		return i915->params.huc_firmware_path;
374 	return "";
375 }
376 
377 static void __uc_fw_user_override(struct drm_i915_private *i915, struct intel_uc_fw *uc_fw)
378 {
379 	const char *path = NULL;
380 
381 	switch (uc_fw->type) {
382 	case INTEL_UC_FW_TYPE_GUC:
383 		path = __override_guc_firmware_path(i915);
384 		break;
385 	case INTEL_UC_FW_TYPE_HUC:
386 		path = __override_huc_firmware_path(i915);
387 		break;
388 	}
389 
390 	if (unlikely(path)) {
391 		uc_fw->file_selected.path = path;
392 		uc_fw->user_overridden = true;
393 	}
394 }
395 
396 /**
397  * intel_uc_fw_init_early - initialize the uC object and select the firmware
398  * @uc_fw: uC firmware
399  * @type: type of uC
400  *
401  * Initialize the state of our uC object and relevant tracking and select the
402  * firmware to fetch and load.
403  */
404 void intel_uc_fw_init_early(struct intel_uc_fw *uc_fw,
405 			    enum intel_uc_fw_type type)
406 {
407 	struct drm_i915_private *i915 = ____uc_fw_to_gt(uc_fw, type)->i915;
408 
409 	/*
410 	 * we use FIRMWARE_UNINITIALIZED to detect checks against uc_fw->status
411 	 * before we're looked at the HW caps to see if we have uc support
412 	 */
413 	BUILD_BUG_ON(INTEL_UC_FIRMWARE_UNINITIALIZED);
414 	GEM_BUG_ON(uc_fw->status);
415 	GEM_BUG_ON(uc_fw->file_selected.path);
416 
417 	uc_fw->type = type;
418 
419 	if (HAS_GT_UC(i915)) {
420 		__uc_fw_auto_select(i915, uc_fw);
421 		__uc_fw_user_override(i915, uc_fw);
422 	}
423 
424 	intel_uc_fw_change_status(uc_fw, uc_fw->file_selected.path ? *uc_fw->file_selected.path ?
425 				  INTEL_UC_FIRMWARE_SELECTED :
426 				  INTEL_UC_FIRMWARE_DISABLED :
427 				  INTEL_UC_FIRMWARE_NOT_SUPPORTED);
428 }
429 
430 static void __force_fw_fetch_failures(struct intel_uc_fw *uc_fw, int e)
431 {
432 	struct drm_i915_private *i915 = __uc_fw_to_gt(uc_fw)->i915;
433 	bool user = e == -EINVAL;
434 
435 	if (i915_inject_probe_error(i915, e)) {
436 		/* non-existing blob */
437 		uc_fw->file_selected.path = "<invalid>";
438 		uc_fw->user_overridden = user;
439 	} else if (i915_inject_probe_error(i915, e)) {
440 		/* require next major version */
441 		uc_fw->file_wanted.major_ver += 1;
442 		uc_fw->file_wanted.minor_ver = 0;
443 		uc_fw->user_overridden = user;
444 	} else if (i915_inject_probe_error(i915, e)) {
445 		/* require next minor version */
446 		uc_fw->file_wanted.minor_ver += 1;
447 		uc_fw->user_overridden = user;
448 	} else if (uc_fw->file_wanted.major_ver &&
449 		   i915_inject_probe_error(i915, e)) {
450 		/* require prev major version */
451 		uc_fw->file_wanted.major_ver -= 1;
452 		uc_fw->file_wanted.minor_ver = 0;
453 		uc_fw->user_overridden = user;
454 	} else if (uc_fw->file_wanted.minor_ver &&
455 		   i915_inject_probe_error(i915, e)) {
456 		/* require prev minor version - hey, this should work! */
457 		uc_fw->file_wanted.minor_ver -= 1;
458 		uc_fw->user_overridden = user;
459 	} else if (user && i915_inject_probe_error(i915, e)) {
460 		/* officially unsupported platform */
461 		uc_fw->file_wanted.major_ver = 0;
462 		uc_fw->file_wanted.minor_ver = 0;
463 		uc_fw->user_overridden = true;
464 	}
465 }
466 
467 static int check_gsc_manifest(const struct firmware *fw,
468 			      struct intel_uc_fw *uc_fw)
469 {
470 	u32 *dw = (u32 *)fw->data;
471 	u32 version_hi = dw[HUC_GSC_VERSION_HI_DW];
472 	u32 version_lo = dw[HUC_GSC_VERSION_LO_DW];
473 
474 	uc_fw->file_selected.major_ver = FIELD_GET(HUC_GSC_MAJOR_VER_HI_MASK, version_hi);
475 	uc_fw->file_selected.minor_ver = FIELD_GET(HUC_GSC_MINOR_VER_HI_MASK, version_hi);
476 	uc_fw->file_selected.patch_ver = FIELD_GET(HUC_GSC_PATCH_VER_LO_MASK, version_lo);
477 
478 	return 0;
479 }
480 
481 static int check_ccs_header(struct intel_gt *gt,
482 			    const struct firmware *fw,
483 			    struct intel_uc_fw *uc_fw)
484 {
485 	struct drm_i915_private *i915 = gt->i915;
486 	struct uc_css_header *css;
487 	size_t size;
488 
489 	/* Check the size of the blob before examining buffer contents */
490 	if (unlikely(fw->size < sizeof(struct uc_css_header))) {
491 		drm_warn(&i915->drm, "%s firmware %s: invalid size: %zu < %zu\n",
492 			 intel_uc_fw_type_repr(uc_fw->type), uc_fw->file_selected.path,
493 			 fw->size, sizeof(struct uc_css_header));
494 		return -ENODATA;
495 	}
496 
497 	css = (struct uc_css_header *)fw->data;
498 
499 	/* Check integrity of size values inside CSS header */
500 	size = (css->header_size_dw - css->key_size_dw - css->modulus_size_dw -
501 		css->exponent_size_dw) * sizeof(u32);
502 	if (unlikely(size != sizeof(struct uc_css_header))) {
503 		drm_warn(&i915->drm,
504 			 "%s firmware %s: unexpected header size: %zu != %zu\n",
505 			 intel_uc_fw_type_repr(uc_fw->type), uc_fw->file_selected.path,
506 			 fw->size, sizeof(struct uc_css_header));
507 		return -EPROTO;
508 	}
509 
510 	/* uCode size must calculated from other sizes */
511 	uc_fw->ucode_size = (css->size_dw - css->header_size_dw) * sizeof(u32);
512 
513 	/* now RSA */
514 	uc_fw->rsa_size = css->key_size_dw * sizeof(u32);
515 
516 	/* At least, it should have header, uCode and RSA. Size of all three. */
517 	size = sizeof(struct uc_css_header) + uc_fw->ucode_size + uc_fw->rsa_size;
518 	if (unlikely(fw->size < size)) {
519 		drm_warn(&i915->drm, "%s firmware %s: invalid size: %zu < %zu\n",
520 			 intel_uc_fw_type_repr(uc_fw->type), uc_fw->file_selected.path,
521 			 fw->size, size);
522 		return -ENOEXEC;
523 	}
524 
525 	/* Sanity check whether this fw is not larger than whole WOPCM memory */
526 	size = __intel_uc_fw_get_upload_size(uc_fw);
527 	if (unlikely(size >= gt->wopcm.size)) {
528 		drm_warn(&i915->drm, "%s firmware %s: invalid size: %zu > %zu\n",
529 			 intel_uc_fw_type_repr(uc_fw->type), uc_fw->file_selected.path,
530 			 size, (size_t)gt->wopcm.size);
531 		return -E2BIG;
532 	}
533 
534 	/* Get version numbers from the CSS header */
535 	uc_fw->file_selected.major_ver = FIELD_GET(CSS_SW_VERSION_UC_MAJOR,
536 						   css->sw_version);
537 	uc_fw->file_selected.minor_ver = FIELD_GET(CSS_SW_VERSION_UC_MINOR,
538 						   css->sw_version);
539 	uc_fw->file_selected.patch_ver = FIELD_GET(CSS_SW_VERSION_UC_PATCH,
540 						   css->sw_version);
541 
542 	if (uc_fw->type == INTEL_UC_FW_TYPE_GUC)
543 		uc_fw->private_data_size = css->private_data_size;
544 
545 	return 0;
546 }
547 
548 /**
549  * intel_uc_fw_fetch - fetch uC firmware
550  * @uc_fw: uC firmware
551  *
552  * Fetch uC firmware into GEM obj.
553  *
554  * Return: 0 on success, a negative errno code on failure.
555  */
556 int intel_uc_fw_fetch(struct intel_uc_fw *uc_fw)
557 {
558 	struct intel_gt *gt = __uc_fw_to_gt(uc_fw);
559 	struct drm_i915_private *i915 = gt->i915;
560 	struct intel_uc_fw_file file_ideal;
561 	struct device *dev = i915->drm.dev;
562 	struct drm_i915_gem_object *obj;
563 	const struct firmware *fw = NULL;
564 	bool old_ver = false;
565 	int err;
566 
567 	GEM_BUG_ON(!gt->wopcm.size);
568 	GEM_BUG_ON(!intel_uc_fw_is_enabled(uc_fw));
569 
570 	err = i915_inject_probe_error(i915, -ENXIO);
571 	if (err)
572 		goto fail;
573 
574 	__force_fw_fetch_failures(uc_fw, -EINVAL);
575 	__force_fw_fetch_failures(uc_fw, -ESTALE);
576 
577 	err = firmware_request_nowarn(&fw, uc_fw->file_selected.path, dev);
578 	memcpy(&file_ideal, &uc_fw->file_wanted, sizeof(file_ideal));
579 
580 	if (!err && fw->size > INTEL_UC_RSVD_GGTT_PER_FW) {
581 		drm_err(&i915->drm,
582 			"%s firmware %s: size (%zuKB) exceeds max supported size (%uKB)\n",
583 			intel_uc_fw_type_repr(uc_fw->type), uc_fw->file_selected.path,
584 			fw->size / SZ_1K, INTEL_UC_RSVD_GGTT_PER_FW / SZ_1K);
585 
586 		/* try to find another blob to load */
587 		release_firmware(fw);
588 		err = -ENOENT;
589 	}
590 
591 	/* Any error is terminal if overriding. Don't bother searching for older versions */
592 	if (err && intel_uc_fw_is_overridden(uc_fw))
593 		goto fail;
594 
595 	while (err == -ENOENT) {
596 		old_ver = true;
597 
598 		__uc_fw_auto_select(i915, uc_fw);
599 		if (!uc_fw->file_selected.path) {
600 			/*
601 			 * No more options! But set the path back to something
602 			 * valid just in case it gets dereferenced.
603 			 */
604 			uc_fw->file_selected.path = file_ideal.path;
605 
606 			/* Also, preserve the version that was really wanted */
607 			memcpy(&uc_fw->file_wanted, &file_ideal, sizeof(uc_fw->file_wanted));
608 			break;
609 		}
610 
611 		err = firmware_request_nowarn(&fw, uc_fw->file_selected.path, dev);
612 	}
613 
614 	if (err)
615 		goto fail;
616 
617 	if (uc_fw->loaded_via_gsc)
618 		err = check_gsc_manifest(fw, uc_fw);
619 	else
620 		err = check_ccs_header(gt, fw, uc_fw);
621 	if (err)
622 		goto fail;
623 
624 	if (uc_fw->file_wanted.major_ver) {
625 		/* Check the file's major version was as it claimed */
626 		if (uc_fw->file_selected.major_ver != uc_fw->file_wanted.major_ver) {
627 			drm_notice(&i915->drm, "%s firmware %s: unexpected version: %u.%u != %u.%u\n",
628 				   intel_uc_fw_type_repr(uc_fw->type), uc_fw->file_selected.path,
629 				   uc_fw->file_selected.major_ver, uc_fw->file_selected.minor_ver,
630 				   uc_fw->file_wanted.major_ver, uc_fw->file_wanted.minor_ver);
631 			if (!intel_uc_fw_is_overridden(uc_fw)) {
632 				err = -ENOEXEC;
633 				goto fail;
634 			}
635 		} else {
636 			if (uc_fw->file_selected.minor_ver < uc_fw->file_wanted.minor_ver)
637 				old_ver = true;
638 		}
639 	}
640 
641 	if (old_ver) {
642 		/* Preserve the version that was really wanted */
643 		memcpy(&uc_fw->file_wanted, &file_ideal, sizeof(uc_fw->file_wanted));
644 
645 		drm_notice(&i915->drm,
646 			   "%s firmware %s (%d.%d) is recommended, but only %s (%d.%d) was found\n",
647 			   intel_uc_fw_type_repr(uc_fw->type),
648 			   uc_fw->file_wanted.path,
649 			   uc_fw->file_wanted.major_ver, uc_fw->file_wanted.minor_ver,
650 			   uc_fw->file_selected.path,
651 			   uc_fw->file_selected.major_ver, uc_fw->file_selected.minor_ver);
652 		drm_info(&i915->drm,
653 			 "Consider updating your linux-firmware pkg or downloading from %s\n",
654 			 INTEL_UC_FIRMWARE_URL);
655 	}
656 
657 	if (HAS_LMEM(i915)) {
658 		obj = i915_gem_object_create_lmem_from_data(i915, fw->data, fw->size);
659 		if (!IS_ERR(obj))
660 			obj->flags |= I915_BO_ALLOC_PM_EARLY;
661 	} else {
662 		obj = i915_gem_object_create_shmem_from_data(i915, fw->data, fw->size);
663 	}
664 
665 	if (IS_ERR(obj)) {
666 		err = PTR_ERR(obj);
667 		goto fail;
668 	}
669 
670 	uc_fw->obj = obj;
671 	uc_fw->size = fw->size;
672 	intel_uc_fw_change_status(uc_fw, INTEL_UC_FIRMWARE_AVAILABLE);
673 
674 	release_firmware(fw);
675 	return 0;
676 
677 fail:
678 	intel_uc_fw_change_status(uc_fw, err == -ENOENT ?
679 				  INTEL_UC_FIRMWARE_MISSING :
680 				  INTEL_UC_FIRMWARE_ERROR);
681 
682 	i915_probe_error(i915, "%s firmware %s: fetch failed with error %d\n",
683 			 intel_uc_fw_type_repr(uc_fw->type), uc_fw->file_selected.path, err);
684 	drm_info(&i915->drm, "%s firmware(s) can be downloaded from %s\n",
685 		 intel_uc_fw_type_repr(uc_fw->type), INTEL_UC_FIRMWARE_URL);
686 
687 	release_firmware(fw);		/* OK even if fw is NULL */
688 	return err;
689 }
690 
691 static u32 uc_fw_ggtt_offset(struct intel_uc_fw *uc_fw)
692 {
693 	struct intel_gt *gt = __uc_fw_to_gt(uc_fw);
694 	struct i915_ggtt *ggtt = gt->ggtt;
695 	struct drm_mm_node *node = &ggtt->uc_fw;
696 	u32 offset = uc_fw->type * INTEL_UC_RSVD_GGTT_PER_FW;
697 
698 	/*
699 	 * The media GT shares the GGTT with the root GT, which means that
700 	 * we need to use different offsets for the binaries on the media GT.
701 	 * To keep the math simple, we use 8MB for the root tile and 8MB for
702 	 * the media one. This will need to be updated if we ever have more
703 	 * than 1 media GT.
704 	 */
705 	BUILD_BUG_ON(INTEL_UC_FW_NUM_TYPES * INTEL_UC_RSVD_GGTT_PER_FW > SZ_8M);
706 	GEM_BUG_ON(gt->type == GT_MEDIA && gt->info.id > 1);
707 	if (gt->type == GT_MEDIA)
708 		offset += SZ_8M;
709 
710 	GEM_BUG_ON(!drm_mm_node_allocated(node));
711 	GEM_BUG_ON(upper_32_bits(node->start));
712 	GEM_BUG_ON(upper_32_bits(node->start + node->size - 1));
713 	GEM_BUG_ON(offset + uc_fw->obj->base.size > node->size);
714 	GEM_BUG_ON(uc_fw->obj->base.size > INTEL_UC_RSVD_GGTT_PER_FW);
715 
716 	return lower_32_bits(node->start + offset);
717 }
718 
719 static void uc_fw_bind_ggtt(struct intel_uc_fw *uc_fw)
720 {
721 	struct drm_i915_gem_object *obj = uc_fw->obj;
722 	struct i915_ggtt *ggtt = __uc_fw_to_gt(uc_fw)->ggtt;
723 	struct i915_vma_resource *dummy = &uc_fw->dummy;
724 	u32 pte_flags = 0;
725 
726 	dummy->start = uc_fw_ggtt_offset(uc_fw);
727 	dummy->node_size = obj->base.size;
728 	dummy->bi.pages = obj->mm.pages;
729 
730 	GEM_BUG_ON(!i915_gem_object_has_pinned_pages(obj));
731 
732 	/* uc_fw->obj cache domains were not controlled across suspend */
733 	if (i915_gem_object_has_struct_page(obj))
734 		drm_clflush_sg(dummy->bi.pages);
735 
736 	if (i915_gem_object_is_lmem(obj))
737 		pte_flags |= PTE_LM;
738 
739 	if (ggtt->vm.raw_insert_entries)
740 		ggtt->vm.raw_insert_entries(&ggtt->vm, dummy, I915_CACHE_NONE, pte_flags);
741 	else
742 		ggtt->vm.insert_entries(&ggtt->vm, dummy, I915_CACHE_NONE, pte_flags);
743 }
744 
745 static void uc_fw_unbind_ggtt(struct intel_uc_fw *uc_fw)
746 {
747 	struct drm_i915_gem_object *obj = uc_fw->obj;
748 	struct i915_ggtt *ggtt = __uc_fw_to_gt(uc_fw)->ggtt;
749 	u64 start = uc_fw_ggtt_offset(uc_fw);
750 
751 	ggtt->vm.clear_range(&ggtt->vm, start, obj->base.size);
752 }
753 
754 static int uc_fw_xfer(struct intel_uc_fw *uc_fw, u32 dst_offset, u32 dma_flags)
755 {
756 	struct intel_gt *gt = __uc_fw_to_gt(uc_fw);
757 	struct intel_uncore *uncore = gt->uncore;
758 	u64 offset;
759 	int ret;
760 
761 	ret = i915_inject_probe_error(gt->i915, -ETIMEDOUT);
762 	if (ret)
763 		return ret;
764 
765 	intel_uncore_forcewake_get(uncore, FORCEWAKE_ALL);
766 
767 	/* Set the source address for the uCode */
768 	offset = uc_fw_ggtt_offset(uc_fw);
769 	GEM_BUG_ON(upper_32_bits(offset) & 0xFFFF0000);
770 	intel_uncore_write_fw(uncore, DMA_ADDR_0_LOW, lower_32_bits(offset));
771 	intel_uncore_write_fw(uncore, DMA_ADDR_0_HIGH, upper_32_bits(offset));
772 
773 	/* Set the DMA destination */
774 	intel_uncore_write_fw(uncore, DMA_ADDR_1_LOW, dst_offset);
775 	intel_uncore_write_fw(uncore, DMA_ADDR_1_HIGH, DMA_ADDRESS_SPACE_WOPCM);
776 
777 	/*
778 	 * Set the transfer size. The header plus uCode will be copied to WOPCM
779 	 * via DMA, excluding any other components
780 	 */
781 	intel_uncore_write_fw(uncore, DMA_COPY_SIZE,
782 			      sizeof(struct uc_css_header) + uc_fw->ucode_size);
783 
784 	/* Start the DMA */
785 	intel_uncore_write_fw(uncore, DMA_CTRL,
786 			      _MASKED_BIT_ENABLE(dma_flags | START_DMA));
787 
788 	/* Wait for DMA to finish */
789 	ret = intel_wait_for_register_fw(uncore, DMA_CTRL, START_DMA, 0, 100);
790 	if (ret)
791 		drm_err(&gt->i915->drm, "DMA for %s fw failed, DMA_CTRL=%u\n",
792 			intel_uc_fw_type_repr(uc_fw->type),
793 			intel_uncore_read_fw(uncore, DMA_CTRL));
794 
795 	/* Disable the bits once DMA is over */
796 	intel_uncore_write_fw(uncore, DMA_CTRL, _MASKED_BIT_DISABLE(dma_flags));
797 
798 	intel_uncore_forcewake_put(uncore, FORCEWAKE_ALL);
799 
800 	return ret;
801 }
802 
803 /**
804  * intel_uc_fw_upload - load uC firmware using custom loader
805  * @uc_fw: uC firmware
806  * @dst_offset: destination offset
807  * @dma_flags: flags for flags for dma ctrl
808  *
809  * Loads uC firmware and updates internal flags.
810  *
811  * Return: 0 on success, non-zero on failure.
812  */
813 int intel_uc_fw_upload(struct intel_uc_fw *uc_fw, u32 dst_offset, u32 dma_flags)
814 {
815 	struct intel_gt *gt = __uc_fw_to_gt(uc_fw);
816 	int err;
817 
818 	/* make sure the status was cleared the last time we reset the uc */
819 	GEM_BUG_ON(intel_uc_fw_is_loaded(uc_fw));
820 
821 	err = i915_inject_probe_error(gt->i915, -ENOEXEC);
822 	if (err)
823 		return err;
824 
825 	if (!intel_uc_fw_is_loadable(uc_fw))
826 		return -ENOEXEC;
827 
828 	/* Call custom loader */
829 	uc_fw_bind_ggtt(uc_fw);
830 	err = uc_fw_xfer(uc_fw, dst_offset, dma_flags);
831 	uc_fw_unbind_ggtt(uc_fw);
832 	if (err)
833 		goto fail;
834 
835 	intel_uc_fw_change_status(uc_fw, INTEL_UC_FIRMWARE_TRANSFERRED);
836 	return 0;
837 
838 fail:
839 	i915_probe_error(gt->i915, "Failed to load %s firmware %s (%d)\n",
840 			 intel_uc_fw_type_repr(uc_fw->type), uc_fw->file_selected.path,
841 			 err);
842 	intel_uc_fw_change_status(uc_fw, INTEL_UC_FIRMWARE_LOAD_FAIL);
843 	return err;
844 }
845 
846 static inline bool uc_fw_need_rsa_in_memory(struct intel_uc_fw *uc_fw)
847 {
848 	/*
849 	 * The HW reads the GuC RSA from memory if the key size is > 256 bytes,
850 	 * while it reads it from the 64 RSA registers if it is smaller.
851 	 * The HuC RSA is always read from memory.
852 	 */
853 	return uc_fw->type == INTEL_UC_FW_TYPE_HUC || uc_fw->rsa_size > 256;
854 }
855 
856 static int uc_fw_rsa_data_create(struct intel_uc_fw *uc_fw)
857 {
858 	struct intel_gt *gt = __uc_fw_to_gt(uc_fw);
859 	struct i915_vma *vma;
860 	size_t copied;
861 	void *vaddr;
862 	int err;
863 
864 	err = i915_inject_probe_error(gt->i915, -ENXIO);
865 	if (err)
866 		return err;
867 
868 	if (!uc_fw_need_rsa_in_memory(uc_fw))
869 		return 0;
870 
871 	/*
872 	 * uC firmwares will sit above GUC_GGTT_TOP and will not map through
873 	 * GGTT. Unfortunately, this means that the GuC HW cannot perform the uC
874 	 * authentication from memory, as the RSA offset now falls within the
875 	 * GuC inaccessible range. We resort to perma-pinning an additional vma
876 	 * within the accessible range that only contains the RSA signature.
877 	 * The GuC HW can use this extra pinning to perform the authentication
878 	 * since its GGTT offset will be GuC accessible.
879 	 */
880 	GEM_BUG_ON(uc_fw->rsa_size > PAGE_SIZE);
881 	vma = intel_guc_allocate_vma(&gt->uc.guc, PAGE_SIZE);
882 	if (IS_ERR(vma))
883 		return PTR_ERR(vma);
884 
885 	vaddr = i915_gem_object_pin_map_unlocked(vma->obj,
886 						 i915_coherent_map_type(gt->i915, vma->obj, true));
887 	if (IS_ERR(vaddr)) {
888 		i915_vma_unpin_and_release(&vma, 0);
889 		err = PTR_ERR(vaddr);
890 		goto unpin_out;
891 	}
892 
893 	copied = intel_uc_fw_copy_rsa(uc_fw, vaddr, vma->size);
894 	i915_gem_object_unpin_map(vma->obj);
895 
896 	if (copied < uc_fw->rsa_size) {
897 		err = -ENOMEM;
898 		goto unpin_out;
899 	}
900 
901 	uc_fw->rsa_data = vma;
902 
903 	return 0;
904 
905 unpin_out:
906 	i915_vma_unpin_and_release(&vma, 0);
907 	return err;
908 }
909 
910 static void uc_fw_rsa_data_destroy(struct intel_uc_fw *uc_fw)
911 {
912 	i915_vma_unpin_and_release(&uc_fw->rsa_data, 0);
913 }
914 
915 int intel_uc_fw_init(struct intel_uc_fw *uc_fw)
916 {
917 	int err;
918 
919 	/* this should happen before the load! */
920 	GEM_BUG_ON(intel_uc_fw_is_loaded(uc_fw));
921 
922 	if (!intel_uc_fw_is_available(uc_fw))
923 		return -ENOEXEC;
924 
925 	err = i915_gem_object_pin_pages_unlocked(uc_fw->obj);
926 	if (err) {
927 		DRM_DEBUG_DRIVER("%s fw pin-pages err=%d\n",
928 				 intel_uc_fw_type_repr(uc_fw->type), err);
929 		goto out;
930 	}
931 
932 	err = uc_fw_rsa_data_create(uc_fw);
933 	if (err) {
934 		DRM_DEBUG_DRIVER("%s fw rsa data creation failed, err=%d\n",
935 				 intel_uc_fw_type_repr(uc_fw->type), err);
936 		goto out_unpin;
937 	}
938 
939 	return 0;
940 
941 out_unpin:
942 	i915_gem_object_unpin_pages(uc_fw->obj);
943 out:
944 	return err;
945 }
946 
947 void intel_uc_fw_fini(struct intel_uc_fw *uc_fw)
948 {
949 	uc_fw_rsa_data_destroy(uc_fw);
950 
951 	if (i915_gem_object_has_pinned_pages(uc_fw->obj))
952 		i915_gem_object_unpin_pages(uc_fw->obj);
953 
954 	intel_uc_fw_change_status(uc_fw, INTEL_UC_FIRMWARE_AVAILABLE);
955 }
956 
957 /**
958  * intel_uc_fw_cleanup_fetch - cleanup uC firmware
959  * @uc_fw: uC firmware
960  *
961  * Cleans up uC firmware by releasing the firmware GEM obj.
962  */
963 void intel_uc_fw_cleanup_fetch(struct intel_uc_fw *uc_fw)
964 {
965 	if (!intel_uc_fw_is_available(uc_fw))
966 		return;
967 
968 	i915_gem_object_put(fetch_and_zero(&uc_fw->obj));
969 
970 	intel_uc_fw_change_status(uc_fw, INTEL_UC_FIRMWARE_SELECTED);
971 }
972 
973 /**
974  * intel_uc_fw_copy_rsa - copy fw RSA to buffer
975  *
976  * @uc_fw: uC firmware
977  * @dst: dst buffer
978  * @max_len: max number of bytes to copy
979  *
980  * Return: number of copied bytes.
981  */
982 size_t intel_uc_fw_copy_rsa(struct intel_uc_fw *uc_fw, void *dst, u32 max_len)
983 {
984 	struct intel_memory_region *mr = uc_fw->obj->mm.region;
985 	u32 size = min_t(u32, uc_fw->rsa_size, max_len);
986 	u32 offset = sizeof(struct uc_css_header) + uc_fw->ucode_size;
987 	struct sgt_iter iter;
988 	size_t count = 0;
989 	int idx;
990 
991 	/* Called during reset handling, must be atomic [no fs_reclaim] */
992 	GEM_BUG_ON(!intel_uc_fw_is_available(uc_fw));
993 
994 	idx = offset >> PAGE_SHIFT;
995 	offset = offset_in_page(offset);
996 	if (i915_gem_object_has_struct_page(uc_fw->obj)) {
997 		struct page *page;
998 
999 		for_each_sgt_page(page, iter, uc_fw->obj->mm.pages) {
1000 			u32 len = min_t(u32, size, PAGE_SIZE - offset);
1001 			void *vaddr;
1002 
1003 			if (idx > 0) {
1004 				idx--;
1005 				continue;
1006 			}
1007 
1008 			vaddr = kmap_atomic(page);
1009 			memcpy(dst, vaddr + offset, len);
1010 			kunmap_atomic(vaddr);
1011 
1012 			offset = 0;
1013 			dst += len;
1014 			size -= len;
1015 			count += len;
1016 			if (!size)
1017 				break;
1018 		}
1019 	} else {
1020 		dma_addr_t addr;
1021 
1022 		for_each_sgt_daddr(addr, iter, uc_fw->obj->mm.pages) {
1023 			u32 len = min_t(u32, size, PAGE_SIZE - offset);
1024 			void __iomem *vaddr;
1025 
1026 			if (idx > 0) {
1027 				idx--;
1028 				continue;
1029 			}
1030 
1031 			vaddr = io_mapping_map_atomic_wc(&mr->iomap,
1032 							 addr - mr->region.start);
1033 			memcpy_fromio(dst, vaddr + offset, len);
1034 			io_mapping_unmap_atomic(vaddr);
1035 
1036 			offset = 0;
1037 			dst += len;
1038 			size -= len;
1039 			count += len;
1040 			if (!size)
1041 				break;
1042 		}
1043 	}
1044 
1045 	return count;
1046 }
1047 
1048 /**
1049  * intel_uc_fw_dump - dump information about uC firmware
1050  * @uc_fw: uC firmware
1051  * @p: the &drm_printer
1052  *
1053  * Pretty printer for uC firmware.
1054  */
1055 void intel_uc_fw_dump(const struct intel_uc_fw *uc_fw, struct drm_printer *p)
1056 {
1057 	u32 ver_sel, ver_want;
1058 
1059 	drm_printf(p, "%s firmware: %s\n",
1060 		   intel_uc_fw_type_repr(uc_fw->type), uc_fw->file_selected.path);
1061 	if (uc_fw->file_selected.path != uc_fw->file_wanted.path)
1062 		drm_printf(p, "%s firmware wanted: %s\n",
1063 			   intel_uc_fw_type_repr(uc_fw->type), uc_fw->file_wanted.path);
1064 	drm_printf(p, "\tstatus: %s\n",
1065 		   intel_uc_fw_status_repr(uc_fw->status));
1066 	ver_sel = MAKE_UC_VER(uc_fw->file_selected.major_ver,
1067 			      uc_fw->file_selected.minor_ver,
1068 			      uc_fw->file_selected.patch_ver);
1069 	ver_want = MAKE_UC_VER(uc_fw->file_wanted.major_ver,
1070 			       uc_fw->file_wanted.minor_ver,
1071 			       uc_fw->file_wanted.patch_ver);
1072 	if (ver_sel < ver_want)
1073 		drm_printf(p, "\tversion: wanted %u.%u.%u, found %u.%u.%u\n",
1074 			   uc_fw->file_wanted.major_ver,
1075 			   uc_fw->file_wanted.minor_ver,
1076 			   uc_fw->file_wanted.patch_ver,
1077 			   uc_fw->file_selected.major_ver,
1078 			   uc_fw->file_selected.minor_ver,
1079 			   uc_fw->file_selected.patch_ver);
1080 	else
1081 		drm_printf(p, "\tversion: found %u.%u.%u\n",
1082 			   uc_fw->file_selected.major_ver,
1083 			   uc_fw->file_selected.minor_ver,
1084 			   uc_fw->file_selected.patch_ver);
1085 	drm_printf(p, "\tuCode: %u bytes\n", uc_fw->ucode_size);
1086 	drm_printf(p, "\tRSA: %u bytes\n", uc_fw->rsa_size);
1087 }
1088