1 /* exynos_drm_vidi.c 2 * 3 * Copyright (C) 2012 Samsung Electronics Co.Ltd 4 * Authors: 5 * Inki Dae <inki.dae@samsung.com> 6 * 7 * This program is free software; you can redistribute it and/or modify it 8 * under the terms of the GNU General Public License as published by the 9 * Free Software Foundation; either version 2 of the License, or (at your 10 * option) any later version. 11 * 12 */ 13 #include <drm/drmP.h> 14 15 #include <linux/kernel.h> 16 #include <linux/platform_device.h> 17 18 #include <drm/exynos_drm.h> 19 20 #include <drm/drm_edid.h> 21 #include <drm/drm_crtc_helper.h> 22 23 #include "exynos_drm_drv.h" 24 #include "exynos_drm_crtc.h" 25 #include "exynos_drm_encoder.h" 26 #include "exynos_drm_vidi.h" 27 28 /* vidi has totally three virtual windows. */ 29 #define WINDOWS_NR 3 30 31 #define get_vidi_mgr(dev) platform_get_drvdata(to_platform_device(dev)) 32 #define ctx_from_connector(c) container_of(c, struct vidi_context, \ 33 connector) 34 35 struct vidi_win_data { 36 unsigned int offset_x; 37 unsigned int offset_y; 38 unsigned int ovl_width; 39 unsigned int ovl_height; 40 unsigned int fb_width; 41 unsigned int fb_height; 42 unsigned int bpp; 43 dma_addr_t dma_addr; 44 unsigned int buf_offsize; 45 unsigned int line_size; /* bytes */ 46 bool enabled; 47 }; 48 49 struct vidi_context { 50 struct drm_device *drm_dev; 51 struct drm_crtc *crtc; 52 struct drm_encoder *encoder; 53 struct drm_connector connector; 54 struct exynos_drm_subdrv subdrv; 55 struct vidi_win_data win_data[WINDOWS_NR]; 56 struct edid *raw_edid; 57 unsigned int clkdiv; 58 unsigned int default_win; 59 unsigned long irq_flags; 60 unsigned int connected; 61 bool vblank_on; 62 bool suspended; 63 bool direct_vblank; 64 struct work_struct work; 65 struct mutex lock; 66 int pipe; 67 }; 68 69 static const char fake_edid_info[] = { 70 0x00, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0x00, 0x4c, 0x2d, 0x05, 0x05, 71 0x00, 0x00, 0x00, 0x00, 0x30, 0x12, 0x01, 0x03, 0x80, 0x10, 0x09, 0x78, 72 0x0a, 0xee, 0x91, 0xa3, 0x54, 0x4c, 0x99, 0x26, 0x0f, 0x50, 0x54, 0xbd, 73 0xee, 0x00, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 74 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x66, 0x21, 0x50, 0xb0, 0x51, 0x00, 75 0x1b, 0x30, 0x40, 0x70, 0x36, 0x00, 0xa0, 0x5a, 0x00, 0x00, 0x00, 0x1e, 76 0x01, 0x1d, 0x00, 0x72, 0x51, 0xd0, 0x1e, 0x20, 0x6e, 0x28, 0x55, 0x00, 77 0xa0, 0x5a, 0x00, 0x00, 0x00, 0x1e, 0x00, 0x00, 0x00, 0xfd, 0x00, 0x18, 78 0x4b, 0x1a, 0x44, 0x17, 0x00, 0x0a, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 79 0x00, 0x00, 0x00, 0xfc, 0x00, 0x53, 0x41, 0x4d, 0x53, 0x55, 0x4e, 0x47, 80 0x0a, 0x20, 0x20, 0x20, 0x20, 0x20, 0x01, 0xbc, 0x02, 0x03, 0x1e, 0xf1, 81 0x46, 0x84, 0x05, 0x03, 0x10, 0x20, 0x22, 0x23, 0x09, 0x07, 0x07, 0x83, 82 0x01, 0x00, 0x00, 0xe2, 0x00, 0x0f, 0x67, 0x03, 0x0c, 0x00, 0x10, 0x00, 83 0xb8, 0x2d, 0x01, 0x1d, 0x80, 0x18, 0x71, 0x1c, 0x16, 0x20, 0x58, 0x2c, 84 0x25, 0x00, 0xa0, 0x5a, 0x00, 0x00, 0x00, 0x9e, 0x8c, 0x0a, 0xd0, 0x8a, 85 0x20, 0xe0, 0x2d, 0x10, 0x10, 0x3e, 0x96, 0x00, 0xa0, 0x5a, 0x00, 0x00, 86 0x00, 0x18, 0x02, 0x3a, 0x80, 0x18, 0x71, 0x38, 0x2d, 0x40, 0x58, 0x2c, 87 0x45, 0x00, 0xa0, 0x5a, 0x00, 0x00, 0x00, 0x1e, 0x00, 0x00, 0x00, 0x00, 88 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 89 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 90 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 91 0x00, 0x00, 0x00, 0x06 92 }; 93 94 static void vidi_apply(struct exynos_drm_manager *mgr) 95 { 96 struct vidi_context *ctx = mgr->ctx; 97 struct exynos_drm_manager_ops *mgr_ops = mgr->ops; 98 struct vidi_win_data *win_data; 99 int i; 100 101 for (i = 0; i < WINDOWS_NR; i++) { 102 win_data = &ctx->win_data[i]; 103 if (win_data->enabled && (mgr_ops && mgr_ops->win_commit)) 104 mgr_ops->win_commit(mgr, i); 105 } 106 107 if (mgr_ops && mgr_ops->commit) 108 mgr_ops->commit(mgr); 109 } 110 111 static void vidi_commit(struct exynos_drm_manager *mgr) 112 { 113 struct vidi_context *ctx = mgr->ctx; 114 115 if (ctx->suspended) 116 return; 117 } 118 119 static int vidi_enable_vblank(struct exynos_drm_manager *mgr) 120 { 121 struct vidi_context *ctx = mgr->ctx; 122 123 if (ctx->suspended) 124 return -EPERM; 125 126 if (!test_and_set_bit(0, &ctx->irq_flags)) 127 ctx->vblank_on = true; 128 129 ctx->direct_vblank = true; 130 131 /* 132 * in case of page flip request, vidi_finish_pageflip function 133 * will not be called because direct_vblank is true and then 134 * that function will be called by manager_ops->win_commit callback 135 */ 136 schedule_work(&ctx->work); 137 138 return 0; 139 } 140 141 static void vidi_disable_vblank(struct exynos_drm_manager *mgr) 142 { 143 struct vidi_context *ctx = mgr->ctx; 144 145 if (ctx->suspended) 146 return; 147 148 if (test_and_clear_bit(0, &ctx->irq_flags)) 149 ctx->vblank_on = false; 150 } 151 152 static void vidi_win_mode_set(struct exynos_drm_manager *mgr, 153 struct exynos_drm_overlay *overlay) 154 { 155 struct vidi_context *ctx = mgr->ctx; 156 struct vidi_win_data *win_data; 157 int win; 158 unsigned long offset; 159 160 if (!overlay) { 161 DRM_ERROR("overlay is NULL\n"); 162 return; 163 } 164 165 win = overlay->zpos; 166 if (win == DEFAULT_ZPOS) 167 win = ctx->default_win; 168 169 if (win < 0 || win >= WINDOWS_NR) 170 return; 171 172 offset = overlay->fb_x * (overlay->bpp >> 3); 173 offset += overlay->fb_y * overlay->pitch; 174 175 DRM_DEBUG_KMS("offset = 0x%lx, pitch = %x\n", offset, overlay->pitch); 176 177 win_data = &ctx->win_data[win]; 178 179 win_data->offset_x = overlay->crtc_x; 180 win_data->offset_y = overlay->crtc_y; 181 win_data->ovl_width = overlay->crtc_width; 182 win_data->ovl_height = overlay->crtc_height; 183 win_data->fb_width = overlay->fb_width; 184 win_data->fb_height = overlay->fb_height; 185 win_data->dma_addr = overlay->dma_addr[0] + offset; 186 win_data->bpp = overlay->bpp; 187 win_data->buf_offsize = (overlay->fb_width - overlay->crtc_width) * 188 (overlay->bpp >> 3); 189 win_data->line_size = overlay->crtc_width * (overlay->bpp >> 3); 190 191 /* 192 * some parts of win_data should be transferred to user side 193 * through specific ioctl. 194 */ 195 196 DRM_DEBUG_KMS("offset_x = %d, offset_y = %d\n", 197 win_data->offset_x, win_data->offset_y); 198 DRM_DEBUG_KMS("ovl_width = %d, ovl_height = %d\n", 199 win_data->ovl_width, win_data->ovl_height); 200 DRM_DEBUG_KMS("paddr = 0x%lx\n", (unsigned long)win_data->dma_addr); 201 DRM_DEBUG_KMS("fb_width = %d, crtc_width = %d\n", 202 overlay->fb_width, overlay->crtc_width); 203 } 204 205 static void vidi_win_commit(struct exynos_drm_manager *mgr, int zpos) 206 { 207 struct vidi_context *ctx = mgr->ctx; 208 struct vidi_win_data *win_data; 209 int win = zpos; 210 211 if (ctx->suspended) 212 return; 213 214 if (win == DEFAULT_ZPOS) 215 win = ctx->default_win; 216 217 if (win < 0 || win >= WINDOWS_NR) 218 return; 219 220 win_data = &ctx->win_data[win]; 221 222 win_data->enabled = true; 223 224 DRM_DEBUG_KMS("dma_addr = %pad\n", &win_data->dma_addr); 225 226 if (ctx->vblank_on) 227 schedule_work(&ctx->work); 228 } 229 230 static void vidi_win_disable(struct exynos_drm_manager *mgr, int zpos) 231 { 232 struct vidi_context *ctx = mgr->ctx; 233 struct vidi_win_data *win_data; 234 int win = zpos; 235 236 if (win == DEFAULT_ZPOS) 237 win = ctx->default_win; 238 239 if (win < 0 || win >= WINDOWS_NR) 240 return; 241 242 win_data = &ctx->win_data[win]; 243 win_data->enabled = false; 244 245 /* TODO. */ 246 } 247 248 static int vidi_power_on(struct exynos_drm_manager *mgr, bool enable) 249 { 250 struct vidi_context *ctx = mgr->ctx; 251 252 DRM_DEBUG_KMS("%s\n", __FILE__); 253 254 if (enable != false && enable != true) 255 return -EINVAL; 256 257 if (enable) { 258 ctx->suspended = false; 259 260 /* if vblank was enabled status, enable it again. */ 261 if (test_and_clear_bit(0, &ctx->irq_flags)) 262 vidi_enable_vblank(mgr); 263 264 vidi_apply(mgr); 265 } else { 266 ctx->suspended = true; 267 } 268 269 return 0; 270 } 271 272 static void vidi_dpms(struct exynos_drm_manager *mgr, int mode) 273 { 274 struct vidi_context *ctx = mgr->ctx; 275 276 DRM_DEBUG_KMS("%d\n", mode); 277 278 mutex_lock(&ctx->lock); 279 280 switch (mode) { 281 case DRM_MODE_DPMS_ON: 282 vidi_power_on(mgr, true); 283 break; 284 case DRM_MODE_DPMS_STANDBY: 285 case DRM_MODE_DPMS_SUSPEND: 286 case DRM_MODE_DPMS_OFF: 287 vidi_power_on(mgr, false); 288 break; 289 default: 290 DRM_DEBUG_KMS("unspecified mode %d\n", mode); 291 break; 292 } 293 294 mutex_unlock(&ctx->lock); 295 } 296 297 static int vidi_mgr_initialize(struct exynos_drm_manager *mgr, 298 struct drm_device *drm_dev) 299 { 300 struct vidi_context *ctx = mgr->ctx; 301 struct exynos_drm_private *priv = drm_dev->dev_private; 302 303 mgr->drm_dev = ctx->drm_dev = drm_dev; 304 mgr->pipe = ctx->pipe = priv->pipe++; 305 306 /* 307 * enable drm irq mode. 308 * - with irq_enabled = 1, we can use the vblank feature. 309 * 310 * P.S. note that we wouldn't use drm irq handler but 311 * just specific driver own one instead because 312 * drm framework supports only one irq handler. 313 */ 314 drm_dev->irq_enabled = 1; 315 316 /* 317 * with vblank_disable_allowed = 1, vblank interrupt will be disabled 318 * by drm timer once a current process gives up ownership of 319 * vblank event.(after drm_vblank_put function is called) 320 */ 321 drm_dev->vblank_disable_allowed = 1; 322 323 return 0; 324 } 325 326 static struct exynos_drm_manager_ops vidi_manager_ops = { 327 .dpms = vidi_dpms, 328 .commit = vidi_commit, 329 .enable_vblank = vidi_enable_vblank, 330 .disable_vblank = vidi_disable_vblank, 331 .win_mode_set = vidi_win_mode_set, 332 .win_commit = vidi_win_commit, 333 .win_disable = vidi_win_disable, 334 }; 335 336 static struct exynos_drm_manager vidi_manager = { 337 .type = EXYNOS_DISPLAY_TYPE_VIDI, 338 .ops = &vidi_manager_ops, 339 }; 340 341 static void vidi_fake_vblank_handler(struct work_struct *work) 342 { 343 struct vidi_context *ctx = container_of(work, struct vidi_context, 344 work); 345 346 if (ctx->pipe < 0) 347 return; 348 349 /* refresh rate is about 50Hz. */ 350 usleep_range(16000, 20000); 351 352 mutex_lock(&ctx->lock); 353 354 if (ctx->direct_vblank) { 355 drm_handle_vblank(ctx->drm_dev, ctx->pipe); 356 ctx->direct_vblank = false; 357 mutex_unlock(&ctx->lock); 358 return; 359 } 360 361 mutex_unlock(&ctx->lock); 362 363 exynos_drm_crtc_finish_pageflip(ctx->drm_dev, ctx->pipe); 364 } 365 366 static int vidi_show_connection(struct device *dev, 367 struct device_attribute *attr, char *buf) 368 { 369 int rc; 370 struct exynos_drm_manager *mgr = get_vidi_mgr(dev); 371 struct vidi_context *ctx = mgr->ctx; 372 373 mutex_lock(&ctx->lock); 374 375 rc = sprintf(buf, "%d\n", ctx->connected); 376 377 mutex_unlock(&ctx->lock); 378 379 return rc; 380 } 381 382 static int vidi_store_connection(struct device *dev, 383 struct device_attribute *attr, 384 const char *buf, size_t len) 385 { 386 struct exynos_drm_manager *mgr = get_vidi_mgr(dev); 387 struct vidi_context *ctx = mgr->ctx; 388 int ret; 389 390 ret = kstrtoint(buf, 0, &ctx->connected); 391 if (ret) 392 return ret; 393 394 if (ctx->connected > 1) 395 return -EINVAL; 396 397 /* use fake edid data for test. */ 398 if (!ctx->raw_edid) 399 ctx->raw_edid = (struct edid *)fake_edid_info; 400 401 /* if raw_edid isn't same as fake data then it can't be tested. */ 402 if (ctx->raw_edid != (struct edid *)fake_edid_info) { 403 DRM_DEBUG_KMS("edid data is not fake data.\n"); 404 return -EINVAL; 405 } 406 407 DRM_DEBUG_KMS("requested connection.\n"); 408 409 drm_helper_hpd_irq_event(ctx->drm_dev); 410 411 return len; 412 } 413 414 static DEVICE_ATTR(connection, 0644, vidi_show_connection, 415 vidi_store_connection); 416 417 int vidi_connection_ioctl(struct drm_device *drm_dev, void *data, 418 struct drm_file *file_priv) 419 { 420 struct vidi_context *ctx = NULL; 421 struct drm_encoder *encoder; 422 struct exynos_drm_display *display; 423 struct drm_exynos_vidi_connection *vidi = data; 424 425 if (!vidi) { 426 DRM_DEBUG_KMS("user data for vidi is null.\n"); 427 return -EINVAL; 428 } 429 430 if (vidi->connection > 1) { 431 DRM_DEBUG_KMS("connection should be 0 or 1.\n"); 432 return -EINVAL; 433 } 434 435 list_for_each_entry(encoder, &drm_dev->mode_config.encoder_list, 436 head) { 437 display = exynos_drm_get_display(encoder); 438 439 if (display->type == EXYNOS_DISPLAY_TYPE_VIDI) { 440 ctx = display->ctx; 441 break; 442 } 443 } 444 445 if (!ctx) { 446 DRM_DEBUG_KMS("not found virtual device type encoder.\n"); 447 return -EINVAL; 448 } 449 450 if (ctx->connected == vidi->connection) { 451 DRM_DEBUG_KMS("same connection request.\n"); 452 return -EINVAL; 453 } 454 455 if (vidi->connection) { 456 struct edid *raw_edid = (struct edid *)(uint32_t)vidi->edid; 457 if (!drm_edid_is_valid(raw_edid)) { 458 DRM_DEBUG_KMS("edid data is invalid.\n"); 459 return -EINVAL; 460 } 461 ctx->raw_edid = drm_edid_duplicate(raw_edid); 462 if (!ctx->raw_edid) { 463 DRM_DEBUG_KMS("failed to allocate raw_edid.\n"); 464 return -ENOMEM; 465 } 466 } else { 467 /* 468 * with connection = 0, free raw_edid 469 * only if raw edid data isn't same as fake data. 470 */ 471 if (ctx->raw_edid && ctx->raw_edid != 472 (struct edid *)fake_edid_info) { 473 kfree(ctx->raw_edid); 474 ctx->raw_edid = NULL; 475 } 476 } 477 478 ctx->connected = vidi->connection; 479 drm_helper_hpd_irq_event(ctx->drm_dev); 480 481 return 0; 482 } 483 484 static enum drm_connector_status vidi_detect(struct drm_connector *connector, 485 bool force) 486 { 487 struct vidi_context *ctx = ctx_from_connector(connector); 488 489 /* 490 * connection request would come from user side 491 * to do hotplug through specific ioctl. 492 */ 493 return ctx->connected ? connector_status_connected : 494 connector_status_disconnected; 495 } 496 497 static void vidi_connector_destroy(struct drm_connector *connector) 498 { 499 } 500 501 static struct drm_connector_funcs vidi_connector_funcs = { 502 .dpms = drm_helper_connector_dpms, 503 .fill_modes = drm_helper_probe_single_connector_modes, 504 .detect = vidi_detect, 505 .destroy = vidi_connector_destroy, 506 }; 507 508 static int vidi_get_modes(struct drm_connector *connector) 509 { 510 struct vidi_context *ctx = ctx_from_connector(connector); 511 struct edid *edid; 512 int edid_len; 513 514 /* 515 * the edid data comes from user side and it would be set 516 * to ctx->raw_edid through specific ioctl. 517 */ 518 if (!ctx->raw_edid) { 519 DRM_DEBUG_KMS("raw_edid is null.\n"); 520 return -EFAULT; 521 } 522 523 edid_len = (1 + ctx->raw_edid->extensions) * EDID_LENGTH; 524 edid = kmemdup(ctx->raw_edid, edid_len, GFP_KERNEL); 525 if (!edid) { 526 DRM_DEBUG_KMS("failed to allocate edid\n"); 527 return -ENOMEM; 528 } 529 530 drm_mode_connector_update_edid_property(connector, edid); 531 532 return drm_add_edid_modes(connector, edid); 533 } 534 535 static struct drm_encoder *vidi_best_encoder(struct drm_connector *connector) 536 { 537 struct vidi_context *ctx = ctx_from_connector(connector); 538 539 return ctx->encoder; 540 } 541 542 static struct drm_connector_helper_funcs vidi_connector_helper_funcs = { 543 .get_modes = vidi_get_modes, 544 .best_encoder = vidi_best_encoder, 545 }; 546 547 static int vidi_create_connector(struct exynos_drm_display *display, 548 struct drm_encoder *encoder) 549 { 550 struct vidi_context *ctx = display->ctx; 551 struct drm_connector *connector = &ctx->connector; 552 int ret; 553 554 ctx->encoder = encoder; 555 connector->polled = DRM_CONNECTOR_POLL_HPD; 556 557 ret = drm_connector_init(ctx->drm_dev, connector, 558 &vidi_connector_funcs, DRM_MODE_CONNECTOR_VIRTUAL); 559 if (ret) { 560 DRM_ERROR("Failed to initialize connector with drm\n"); 561 return ret; 562 } 563 564 drm_connector_helper_add(connector, &vidi_connector_helper_funcs); 565 drm_sysfs_connector_add(connector); 566 drm_mode_connector_attach_encoder(connector, encoder); 567 568 return 0; 569 } 570 571 572 static struct exynos_drm_display_ops vidi_display_ops = { 573 .create_connector = vidi_create_connector, 574 }; 575 576 static struct exynos_drm_display vidi_display = { 577 .type = EXYNOS_DISPLAY_TYPE_VIDI, 578 .ops = &vidi_display_ops, 579 }; 580 581 static int vidi_subdrv_probe(struct drm_device *drm_dev, struct device *dev) 582 { 583 struct exynos_drm_manager *mgr = get_vidi_mgr(dev); 584 struct vidi_context *ctx = mgr->ctx; 585 struct drm_crtc *crtc = ctx->crtc; 586 int ret; 587 588 vidi_mgr_initialize(mgr, drm_dev); 589 590 ret = exynos_drm_crtc_create(&vidi_manager); 591 if (ret) { 592 DRM_ERROR("failed to create crtc.\n"); 593 return ret; 594 } 595 596 ret = exynos_drm_create_enc_conn(drm_dev, &vidi_display); 597 if (ret) { 598 crtc->funcs->destroy(crtc); 599 DRM_ERROR("failed to create encoder and connector.\n"); 600 return ret; 601 } 602 603 return 0; 604 } 605 606 static int vidi_probe(struct platform_device *pdev) 607 { 608 struct exynos_drm_subdrv *subdrv; 609 struct vidi_context *ctx; 610 int ret; 611 612 ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx), GFP_KERNEL); 613 if (!ctx) 614 return -ENOMEM; 615 616 ctx->default_win = 0; 617 618 INIT_WORK(&ctx->work, vidi_fake_vblank_handler); 619 620 vidi_manager.ctx = ctx; 621 vidi_display.ctx = ctx; 622 623 mutex_init(&ctx->lock); 624 625 platform_set_drvdata(pdev, &vidi_manager); 626 627 subdrv = &ctx->subdrv; 628 subdrv->dev = &pdev->dev; 629 subdrv->probe = vidi_subdrv_probe; 630 631 ret = exynos_drm_subdrv_register(subdrv); 632 if (ret < 0) { 633 dev_err(&pdev->dev, "failed to register drm vidi device\n"); 634 return ret; 635 } 636 637 ret = device_create_file(&pdev->dev, &dev_attr_connection); 638 if (ret < 0) { 639 exynos_drm_subdrv_unregister(subdrv); 640 DRM_INFO("failed to create connection sysfs.\n"); 641 } 642 643 return 0; 644 } 645 646 static int vidi_remove(struct platform_device *pdev) 647 { 648 struct exynos_drm_manager *mgr = platform_get_drvdata(pdev); 649 struct vidi_context *ctx = mgr->ctx; 650 struct drm_encoder *encoder = ctx->encoder; 651 struct drm_crtc *crtc = mgr->crtc; 652 653 if (ctx->raw_edid != (struct edid *)fake_edid_info) { 654 kfree(ctx->raw_edid); 655 ctx->raw_edid = NULL; 656 657 return -EINVAL; 658 } 659 660 crtc->funcs->destroy(crtc); 661 encoder->funcs->destroy(encoder); 662 drm_connector_cleanup(&ctx->connector); 663 664 return 0; 665 } 666 667 struct platform_driver vidi_driver = { 668 .probe = vidi_probe, 669 .remove = vidi_remove, 670 .driver = { 671 .name = "exynos-drm-vidi", 672 .owner = THIS_MODULE, 673 }, 674 }; 675 676 int exynos_drm_probe_vidi(void) 677 { 678 struct platform_device *pdev; 679 int ret; 680 681 pdev = platform_device_register_simple("exynos-drm-vidi", -1, NULL, 0); 682 if (IS_ERR(pdev)) 683 return PTR_ERR(pdev); 684 685 ret = platform_driver_register(&vidi_driver); 686 if (ret) { 687 platform_device_unregister(pdev); 688 return ret; 689 } 690 691 return ret; 692 } 693 694 void exynos_drm_remove_vidi(void) 695 { 696 struct vidi_context *ctx = vidi_manager.ctx; 697 struct exynos_drm_subdrv *subdrv = &ctx->subdrv; 698 struct platform_device *pdev = to_platform_device(subdrv->dev); 699 700 platform_driver_unregister(&vidi_driver); 701 platform_device_unregister(pdev); 702 } 703