1 // SPDX-License-Identifier: GPL-2.0
2 /*
3  * Copyright (C) 2015-2018 Etnaviv Project
4  */
5 
6 #include <linux/component.h>
7 #include <linux/dma-mapping.h>
8 #include <linux/module.h>
9 #include <linux/of_platform.h>
10 #include <linux/uaccess.h>
11 
12 #include <drm/drm_debugfs.h>
13 #include <drm/drm_drv.h>
14 #include <drm/drm_file.h>
15 #include <drm/drm_ioctl.h>
16 #include <drm/drm_of.h>
17 #include <drm/drm_prime.h>
18 
19 #include "etnaviv_cmdbuf.h"
20 #include "etnaviv_drv.h"
21 #include "etnaviv_gpu.h"
22 #include "etnaviv_gem.h"
23 #include "etnaviv_mmu.h"
24 #include "etnaviv_perfmon.h"
25 
26 /*
27  * DRM operations:
28  */
29 
30 
31 static void load_gpu(struct drm_device *dev)
32 {
33 	struct etnaviv_drm_private *priv = dev->dev_private;
34 	unsigned int i;
35 
36 	for (i = 0; i < ETNA_MAX_PIPES; i++) {
37 		struct etnaviv_gpu *g = priv->gpu[i];
38 
39 		if (g) {
40 			int ret;
41 
42 			ret = etnaviv_gpu_init(g);
43 			if (ret)
44 				priv->gpu[i] = NULL;
45 		}
46 	}
47 }
48 
49 static int etnaviv_open(struct drm_device *dev, struct drm_file *file)
50 {
51 	struct etnaviv_drm_private *priv = dev->dev_private;
52 	struct etnaviv_file_private *ctx;
53 	int ret, i;
54 
55 	ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
56 	if (!ctx)
57 		return -ENOMEM;
58 
59 	ctx->mmu = etnaviv_iommu_context_init(priv->mmu_global,
60 					      priv->cmdbuf_suballoc);
61 	if (!ctx->mmu) {
62 		ret = -ENOMEM;
63 		goto out_free;
64 	}
65 
66 	for (i = 0; i < ETNA_MAX_PIPES; i++) {
67 		struct etnaviv_gpu *gpu = priv->gpu[i];
68 		struct drm_gpu_scheduler *sched;
69 
70 		if (gpu) {
71 			sched = &gpu->sched;
72 			drm_sched_entity_init(&ctx->sched_entity[i],
73 					      DRM_SCHED_PRIORITY_NORMAL, &sched,
74 					      1, NULL);
75 			}
76 	}
77 
78 	file->driver_priv = ctx;
79 
80 	return 0;
81 
82 out_free:
83 	kfree(ctx);
84 	return ret;
85 }
86 
87 static void etnaviv_postclose(struct drm_device *dev, struct drm_file *file)
88 {
89 	struct etnaviv_drm_private *priv = dev->dev_private;
90 	struct etnaviv_file_private *ctx = file->driver_priv;
91 	unsigned int i;
92 
93 	for (i = 0; i < ETNA_MAX_PIPES; i++) {
94 		struct etnaviv_gpu *gpu = priv->gpu[i];
95 
96 		if (gpu)
97 			drm_sched_entity_destroy(&ctx->sched_entity[i]);
98 	}
99 
100 	etnaviv_iommu_context_put(ctx->mmu);
101 
102 	kfree(ctx);
103 }
104 
105 /*
106  * DRM debugfs:
107  */
108 
109 #ifdef CONFIG_DEBUG_FS
110 static int etnaviv_gem_show(struct drm_device *dev, struct seq_file *m)
111 {
112 	struct etnaviv_drm_private *priv = dev->dev_private;
113 
114 	etnaviv_gem_describe_objects(priv, m);
115 
116 	return 0;
117 }
118 
119 static int etnaviv_mm_show(struct drm_device *dev, struct seq_file *m)
120 {
121 	struct drm_printer p = drm_seq_file_printer(m);
122 
123 	read_lock(&dev->vma_offset_manager->vm_lock);
124 	drm_mm_print(&dev->vma_offset_manager->vm_addr_space_mm, &p);
125 	read_unlock(&dev->vma_offset_manager->vm_lock);
126 
127 	return 0;
128 }
129 
130 static int etnaviv_mmu_show(struct etnaviv_gpu *gpu, struct seq_file *m)
131 {
132 	struct drm_printer p = drm_seq_file_printer(m);
133 	struct etnaviv_iommu_context *mmu_context;
134 
135 	seq_printf(m, "Active Objects (%s):\n", dev_name(gpu->dev));
136 
137 	/*
138 	 * Lock the GPU to avoid a MMU context switch just now and elevate
139 	 * the refcount of the current context to avoid it disappearing from
140 	 * under our feet.
141 	 */
142 	mutex_lock(&gpu->lock);
143 	mmu_context = gpu->mmu_context;
144 	if (mmu_context)
145 		etnaviv_iommu_context_get(mmu_context);
146 	mutex_unlock(&gpu->lock);
147 
148 	if (!mmu_context)
149 		return 0;
150 
151 	mutex_lock(&mmu_context->lock);
152 	drm_mm_print(&mmu_context->mm, &p);
153 	mutex_unlock(&mmu_context->lock);
154 
155 	etnaviv_iommu_context_put(mmu_context);
156 
157 	return 0;
158 }
159 
160 static void etnaviv_buffer_dump(struct etnaviv_gpu *gpu, struct seq_file *m)
161 {
162 	struct etnaviv_cmdbuf *buf = &gpu->buffer;
163 	u32 size = buf->size;
164 	u32 *ptr = buf->vaddr;
165 	u32 i;
166 
167 	seq_printf(m, "virt %p - phys 0x%llx - free 0x%08x\n",
168 			buf->vaddr, (u64)etnaviv_cmdbuf_get_pa(buf),
169 			size - buf->user_size);
170 
171 	for (i = 0; i < size / 4; i++) {
172 		if (i && !(i % 4))
173 			seq_puts(m, "\n");
174 		if (i % 4 == 0)
175 			seq_printf(m, "\t0x%p: ", ptr + i);
176 		seq_printf(m, "%08x ", *(ptr + i));
177 	}
178 	seq_puts(m, "\n");
179 }
180 
181 static int etnaviv_ring_show(struct etnaviv_gpu *gpu, struct seq_file *m)
182 {
183 	seq_printf(m, "Ring Buffer (%s): ", dev_name(gpu->dev));
184 
185 	mutex_lock(&gpu->lock);
186 	etnaviv_buffer_dump(gpu, m);
187 	mutex_unlock(&gpu->lock);
188 
189 	return 0;
190 }
191 
192 static int show_unlocked(struct seq_file *m, void *arg)
193 {
194 	struct drm_info_node *node = (struct drm_info_node *) m->private;
195 	struct drm_device *dev = node->minor->dev;
196 	int (*show)(struct drm_device *dev, struct seq_file *m) =
197 			node->info_ent->data;
198 
199 	return show(dev, m);
200 }
201 
202 static int show_each_gpu(struct seq_file *m, void *arg)
203 {
204 	struct drm_info_node *node = (struct drm_info_node *) m->private;
205 	struct drm_device *dev = node->minor->dev;
206 	struct etnaviv_drm_private *priv = dev->dev_private;
207 	struct etnaviv_gpu *gpu;
208 	int (*show)(struct etnaviv_gpu *gpu, struct seq_file *m) =
209 			node->info_ent->data;
210 	unsigned int i;
211 	int ret = 0;
212 
213 	for (i = 0; i < ETNA_MAX_PIPES; i++) {
214 		gpu = priv->gpu[i];
215 		if (!gpu)
216 			continue;
217 
218 		ret = show(gpu, m);
219 		if (ret < 0)
220 			break;
221 	}
222 
223 	return ret;
224 }
225 
226 static struct drm_info_list etnaviv_debugfs_list[] = {
227 		{"gpu", show_each_gpu, 0, etnaviv_gpu_debugfs},
228 		{"gem", show_unlocked, 0, etnaviv_gem_show},
229 		{ "mm", show_unlocked, 0, etnaviv_mm_show },
230 		{"mmu", show_each_gpu, 0, etnaviv_mmu_show},
231 		{"ring", show_each_gpu, 0, etnaviv_ring_show},
232 };
233 
234 static void etnaviv_debugfs_init(struct drm_minor *minor)
235 {
236 	drm_debugfs_create_files(etnaviv_debugfs_list,
237 				 ARRAY_SIZE(etnaviv_debugfs_list),
238 				 minor->debugfs_root, minor);
239 }
240 #endif
241 
242 /*
243  * DRM ioctls:
244  */
245 
246 static int etnaviv_ioctl_get_param(struct drm_device *dev, void *data,
247 		struct drm_file *file)
248 {
249 	struct etnaviv_drm_private *priv = dev->dev_private;
250 	struct drm_etnaviv_param *args = data;
251 	struct etnaviv_gpu *gpu;
252 
253 	if (args->pipe >= ETNA_MAX_PIPES)
254 		return -EINVAL;
255 
256 	gpu = priv->gpu[args->pipe];
257 	if (!gpu)
258 		return -ENXIO;
259 
260 	return etnaviv_gpu_get_param(gpu, args->param, &args->value);
261 }
262 
263 static int etnaviv_ioctl_gem_new(struct drm_device *dev, void *data,
264 		struct drm_file *file)
265 {
266 	struct drm_etnaviv_gem_new *args = data;
267 
268 	if (args->flags & ~(ETNA_BO_CACHED | ETNA_BO_WC | ETNA_BO_UNCACHED |
269 			    ETNA_BO_FORCE_MMU))
270 		return -EINVAL;
271 
272 	return etnaviv_gem_new_handle(dev, file, args->size,
273 			args->flags, &args->handle);
274 }
275 
276 static int etnaviv_ioctl_gem_cpu_prep(struct drm_device *dev, void *data,
277 		struct drm_file *file)
278 {
279 	struct drm_etnaviv_gem_cpu_prep *args = data;
280 	struct drm_gem_object *obj;
281 	int ret;
282 
283 	if (args->op & ~(ETNA_PREP_READ | ETNA_PREP_WRITE | ETNA_PREP_NOSYNC))
284 		return -EINVAL;
285 
286 	obj = drm_gem_object_lookup(file, args->handle);
287 	if (!obj)
288 		return -ENOENT;
289 
290 	ret = etnaviv_gem_cpu_prep(obj, args->op, &args->timeout);
291 
292 	drm_gem_object_put(obj);
293 
294 	return ret;
295 }
296 
297 static int etnaviv_ioctl_gem_cpu_fini(struct drm_device *dev, void *data,
298 		struct drm_file *file)
299 {
300 	struct drm_etnaviv_gem_cpu_fini *args = data;
301 	struct drm_gem_object *obj;
302 	int ret;
303 
304 	if (args->flags)
305 		return -EINVAL;
306 
307 	obj = drm_gem_object_lookup(file, args->handle);
308 	if (!obj)
309 		return -ENOENT;
310 
311 	ret = etnaviv_gem_cpu_fini(obj);
312 
313 	drm_gem_object_put(obj);
314 
315 	return ret;
316 }
317 
318 static int etnaviv_ioctl_gem_info(struct drm_device *dev, void *data,
319 		struct drm_file *file)
320 {
321 	struct drm_etnaviv_gem_info *args = data;
322 	struct drm_gem_object *obj;
323 	int ret;
324 
325 	if (args->pad)
326 		return -EINVAL;
327 
328 	obj = drm_gem_object_lookup(file, args->handle);
329 	if (!obj)
330 		return -ENOENT;
331 
332 	ret = etnaviv_gem_mmap_offset(obj, &args->offset);
333 	drm_gem_object_put(obj);
334 
335 	return ret;
336 }
337 
338 static int etnaviv_ioctl_wait_fence(struct drm_device *dev, void *data,
339 		struct drm_file *file)
340 {
341 	struct drm_etnaviv_wait_fence *args = data;
342 	struct etnaviv_drm_private *priv = dev->dev_private;
343 	struct drm_etnaviv_timespec *timeout = &args->timeout;
344 	struct etnaviv_gpu *gpu;
345 
346 	if (args->flags & ~(ETNA_WAIT_NONBLOCK))
347 		return -EINVAL;
348 
349 	if (args->pipe >= ETNA_MAX_PIPES)
350 		return -EINVAL;
351 
352 	gpu = priv->gpu[args->pipe];
353 	if (!gpu)
354 		return -ENXIO;
355 
356 	if (args->flags & ETNA_WAIT_NONBLOCK)
357 		timeout = NULL;
358 
359 	return etnaviv_gpu_wait_fence_interruptible(gpu, args->fence,
360 						    timeout);
361 }
362 
363 static int etnaviv_ioctl_gem_userptr(struct drm_device *dev, void *data,
364 	struct drm_file *file)
365 {
366 	struct drm_etnaviv_gem_userptr *args = data;
367 
368 	if (args->flags & ~(ETNA_USERPTR_READ|ETNA_USERPTR_WRITE) ||
369 	    args->flags == 0)
370 		return -EINVAL;
371 
372 	if (offset_in_page(args->user_ptr | args->user_size) ||
373 	    (uintptr_t)args->user_ptr != args->user_ptr ||
374 	    (u32)args->user_size != args->user_size ||
375 	    args->user_ptr & ~PAGE_MASK)
376 		return -EINVAL;
377 
378 	if (!access_ok((void __user *)(unsigned long)args->user_ptr,
379 		       args->user_size))
380 		return -EFAULT;
381 
382 	return etnaviv_gem_new_userptr(dev, file, args->user_ptr,
383 				       args->user_size, args->flags,
384 				       &args->handle);
385 }
386 
387 static int etnaviv_ioctl_gem_wait(struct drm_device *dev, void *data,
388 	struct drm_file *file)
389 {
390 	struct etnaviv_drm_private *priv = dev->dev_private;
391 	struct drm_etnaviv_gem_wait *args = data;
392 	struct drm_etnaviv_timespec *timeout = &args->timeout;
393 	struct drm_gem_object *obj;
394 	struct etnaviv_gpu *gpu;
395 	int ret;
396 
397 	if (args->flags & ~(ETNA_WAIT_NONBLOCK))
398 		return -EINVAL;
399 
400 	if (args->pipe >= ETNA_MAX_PIPES)
401 		return -EINVAL;
402 
403 	gpu = priv->gpu[args->pipe];
404 	if (!gpu)
405 		return -ENXIO;
406 
407 	obj = drm_gem_object_lookup(file, args->handle);
408 	if (!obj)
409 		return -ENOENT;
410 
411 	if (args->flags & ETNA_WAIT_NONBLOCK)
412 		timeout = NULL;
413 
414 	ret = etnaviv_gem_wait_bo(gpu, obj, timeout);
415 
416 	drm_gem_object_put(obj);
417 
418 	return ret;
419 }
420 
421 static int etnaviv_ioctl_pm_query_dom(struct drm_device *dev, void *data,
422 	struct drm_file *file)
423 {
424 	struct etnaviv_drm_private *priv = dev->dev_private;
425 	struct drm_etnaviv_pm_domain *args = data;
426 	struct etnaviv_gpu *gpu;
427 
428 	if (args->pipe >= ETNA_MAX_PIPES)
429 		return -EINVAL;
430 
431 	gpu = priv->gpu[args->pipe];
432 	if (!gpu)
433 		return -ENXIO;
434 
435 	return etnaviv_pm_query_dom(gpu, args);
436 }
437 
438 static int etnaviv_ioctl_pm_query_sig(struct drm_device *dev, void *data,
439 	struct drm_file *file)
440 {
441 	struct etnaviv_drm_private *priv = dev->dev_private;
442 	struct drm_etnaviv_pm_signal *args = data;
443 	struct etnaviv_gpu *gpu;
444 
445 	if (args->pipe >= ETNA_MAX_PIPES)
446 		return -EINVAL;
447 
448 	gpu = priv->gpu[args->pipe];
449 	if (!gpu)
450 		return -ENXIO;
451 
452 	return etnaviv_pm_query_sig(gpu, args);
453 }
454 
455 static const struct drm_ioctl_desc etnaviv_ioctls[] = {
456 #define ETNA_IOCTL(n, func, flags) \
457 	DRM_IOCTL_DEF_DRV(ETNAVIV_##n, etnaviv_ioctl_##func, flags)
458 	ETNA_IOCTL(GET_PARAM,    get_param,    DRM_RENDER_ALLOW),
459 	ETNA_IOCTL(GEM_NEW,      gem_new,      DRM_RENDER_ALLOW),
460 	ETNA_IOCTL(GEM_INFO,     gem_info,     DRM_RENDER_ALLOW),
461 	ETNA_IOCTL(GEM_CPU_PREP, gem_cpu_prep, DRM_RENDER_ALLOW),
462 	ETNA_IOCTL(GEM_CPU_FINI, gem_cpu_fini, DRM_RENDER_ALLOW),
463 	ETNA_IOCTL(GEM_SUBMIT,   gem_submit,   DRM_RENDER_ALLOW),
464 	ETNA_IOCTL(WAIT_FENCE,   wait_fence,   DRM_RENDER_ALLOW),
465 	ETNA_IOCTL(GEM_USERPTR,  gem_userptr,  DRM_RENDER_ALLOW),
466 	ETNA_IOCTL(GEM_WAIT,     gem_wait,     DRM_RENDER_ALLOW),
467 	ETNA_IOCTL(PM_QUERY_DOM, pm_query_dom, DRM_RENDER_ALLOW),
468 	ETNA_IOCTL(PM_QUERY_SIG, pm_query_sig, DRM_RENDER_ALLOW),
469 };
470 
471 static const struct file_operations fops = {
472 	.owner              = THIS_MODULE,
473 	.open               = drm_open,
474 	.release            = drm_release,
475 	.unlocked_ioctl     = drm_ioctl,
476 	.compat_ioctl       = drm_compat_ioctl,
477 	.poll               = drm_poll,
478 	.read               = drm_read,
479 	.llseek             = no_llseek,
480 	.mmap               = etnaviv_gem_mmap,
481 };
482 
483 static const struct drm_driver etnaviv_drm_driver = {
484 	.driver_features    = DRIVER_GEM | DRIVER_RENDER,
485 	.open               = etnaviv_open,
486 	.postclose           = etnaviv_postclose,
487 	.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
488 	.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
489 	.gem_prime_import_sg_table = etnaviv_gem_prime_import_sg_table,
490 	.gem_prime_mmap     = etnaviv_gem_prime_mmap,
491 #ifdef CONFIG_DEBUG_FS
492 	.debugfs_init       = etnaviv_debugfs_init,
493 #endif
494 	.ioctls             = etnaviv_ioctls,
495 	.num_ioctls         = DRM_ETNAVIV_NUM_IOCTLS,
496 	.fops               = &fops,
497 	.name               = "etnaviv",
498 	.desc               = "etnaviv DRM",
499 	.date               = "20151214",
500 	.major              = 1,
501 	.minor              = 3,
502 };
503 
504 /*
505  * Platform driver:
506  */
507 static int etnaviv_bind(struct device *dev)
508 {
509 	struct etnaviv_drm_private *priv;
510 	struct drm_device *drm;
511 	int ret;
512 
513 	drm = drm_dev_alloc(&etnaviv_drm_driver, dev);
514 	if (IS_ERR(drm))
515 		return PTR_ERR(drm);
516 
517 	priv = kzalloc(sizeof(*priv), GFP_KERNEL);
518 	if (!priv) {
519 		dev_err(dev, "failed to allocate private data\n");
520 		ret = -ENOMEM;
521 		goto out_put;
522 	}
523 	drm->dev_private = priv;
524 
525 	dev->dma_parms = &priv->dma_parms;
526 	dma_set_max_seg_size(dev, SZ_2G);
527 
528 	mutex_init(&priv->gem_lock);
529 	INIT_LIST_HEAD(&priv->gem_list);
530 	priv->num_gpus = 0;
531 	priv->shm_gfp_mask = GFP_HIGHUSER | __GFP_RETRY_MAYFAIL | __GFP_NOWARN;
532 
533 	priv->cmdbuf_suballoc = etnaviv_cmdbuf_suballoc_new(drm->dev);
534 	if (IS_ERR(priv->cmdbuf_suballoc)) {
535 		dev_err(drm->dev, "Failed to create cmdbuf suballocator\n");
536 		ret = PTR_ERR(priv->cmdbuf_suballoc);
537 		goto out_free_priv;
538 	}
539 
540 	dev_set_drvdata(dev, drm);
541 
542 	ret = component_bind_all(dev, drm);
543 	if (ret < 0)
544 		goto out_destroy_suballoc;
545 
546 	load_gpu(drm);
547 
548 	ret = drm_dev_register(drm, 0);
549 	if (ret)
550 		goto out_unbind;
551 
552 	return 0;
553 
554 out_unbind:
555 	component_unbind_all(dev, drm);
556 out_destroy_suballoc:
557 	etnaviv_cmdbuf_suballoc_destroy(priv->cmdbuf_suballoc);
558 out_free_priv:
559 	kfree(priv);
560 out_put:
561 	drm_dev_put(drm);
562 
563 	return ret;
564 }
565 
566 static void etnaviv_unbind(struct device *dev)
567 {
568 	struct drm_device *drm = dev_get_drvdata(dev);
569 	struct etnaviv_drm_private *priv = drm->dev_private;
570 
571 	drm_dev_unregister(drm);
572 
573 	component_unbind_all(dev, drm);
574 
575 	dev->dma_parms = NULL;
576 
577 	etnaviv_cmdbuf_suballoc_destroy(priv->cmdbuf_suballoc);
578 
579 	drm->dev_private = NULL;
580 	kfree(priv);
581 
582 	drm_dev_put(drm);
583 }
584 
585 static const struct component_master_ops etnaviv_master_ops = {
586 	.bind = etnaviv_bind,
587 	.unbind = etnaviv_unbind,
588 };
589 
590 static int compare_of(struct device *dev, void *data)
591 {
592 	struct device_node *np = data;
593 
594 	return dev->of_node == np;
595 }
596 
597 static int compare_str(struct device *dev, void *data)
598 {
599 	return !strcmp(dev_name(dev), data);
600 }
601 
602 static int etnaviv_pdev_probe(struct platform_device *pdev)
603 {
604 	struct device *dev = &pdev->dev;
605 	struct component_match *match = NULL;
606 
607 	if (!dev->platform_data) {
608 		struct device_node *core_node;
609 
610 		for_each_compatible_node(core_node, NULL, "vivante,gc") {
611 			if (!of_device_is_available(core_node))
612 				continue;
613 
614 			drm_of_component_match_add(&pdev->dev, &match,
615 						   compare_of, core_node);
616 		}
617 	} else {
618 		char **names = dev->platform_data;
619 		unsigned i;
620 
621 		for (i = 0; names[i]; i++)
622 			component_match_add(dev, &match, compare_str, names[i]);
623 	}
624 
625 	return component_master_add_with_match(dev, &etnaviv_master_ops, match);
626 }
627 
628 static int etnaviv_pdev_remove(struct platform_device *pdev)
629 {
630 	component_master_del(&pdev->dev, &etnaviv_master_ops);
631 
632 	return 0;
633 }
634 
635 static struct platform_driver etnaviv_platform_driver = {
636 	.probe      = etnaviv_pdev_probe,
637 	.remove     = etnaviv_pdev_remove,
638 	.driver     = {
639 		.name   = "etnaviv",
640 	},
641 };
642 
643 static struct platform_device *etnaviv_drm;
644 
645 static int __init etnaviv_init(void)
646 {
647 	struct platform_device *pdev;
648 	int ret;
649 	struct device_node *np;
650 
651 	etnaviv_validate_init();
652 
653 	ret = platform_driver_register(&etnaviv_gpu_driver);
654 	if (ret != 0)
655 		return ret;
656 
657 	ret = platform_driver_register(&etnaviv_platform_driver);
658 	if (ret != 0)
659 		goto unregister_gpu_driver;
660 
661 	/*
662 	 * If the DT contains at least one available GPU device, instantiate
663 	 * the DRM platform device.
664 	 */
665 	for_each_compatible_node(np, NULL, "vivante,gc") {
666 		if (!of_device_is_available(np))
667 			continue;
668 
669 		pdev = platform_device_alloc("etnaviv", -1);
670 		if (!pdev) {
671 			ret = -ENOMEM;
672 			of_node_put(np);
673 			goto unregister_platform_driver;
674 		}
675 		pdev->dev.coherent_dma_mask = DMA_BIT_MASK(40);
676 		pdev->dev.dma_mask = &pdev->dev.coherent_dma_mask;
677 
678 		/*
679 		 * Apply the same DMA configuration to the virtual etnaviv
680 		 * device as the GPU we found. This assumes that all Vivante
681 		 * GPUs in the system share the same DMA constraints.
682 		 */
683 		of_dma_configure(&pdev->dev, np, true);
684 
685 		ret = platform_device_add(pdev);
686 		if (ret) {
687 			platform_device_put(pdev);
688 			of_node_put(np);
689 			goto unregister_platform_driver;
690 		}
691 
692 		etnaviv_drm = pdev;
693 		of_node_put(np);
694 		break;
695 	}
696 
697 	return 0;
698 
699 unregister_platform_driver:
700 	platform_driver_unregister(&etnaviv_platform_driver);
701 unregister_gpu_driver:
702 	platform_driver_unregister(&etnaviv_gpu_driver);
703 	return ret;
704 }
705 module_init(etnaviv_init);
706 
707 static void __exit etnaviv_exit(void)
708 {
709 	platform_device_unregister(etnaviv_drm);
710 	platform_driver_unregister(&etnaviv_platform_driver);
711 	platform_driver_unregister(&etnaviv_gpu_driver);
712 }
713 module_exit(etnaviv_exit);
714 
715 MODULE_AUTHOR("Christian Gmeiner <christian.gmeiner@gmail.com>");
716 MODULE_AUTHOR("Russell King <rmk+kernel@armlinux.org.uk>");
717 MODULE_AUTHOR("Lucas Stach <l.stach@pengutronix.de>");
718 MODULE_DESCRIPTION("etnaviv DRM Driver");
719 MODULE_LICENSE("GPL v2");
720 MODULE_ALIAS("platform:etnaviv");
721