xref: /openbmc/linux/drivers/gpu/drm/drm_atomic.c (revision d35ac6ac)
1 /*
2  * Copyright (C) 2014 Red Hat
3  * Copyright (C) 2014 Intel Corp.
4  * Copyright (c) 2020-2021, The Linux Foundation. All rights reserved.
5  *
6  * Permission is hereby granted, free of charge, to any person obtaining a
7  * copy of this software and associated documentation files (the "Software"),
8  * to deal in the Software without restriction, including without limitation
9  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
10  * and/or sell copies of the Software, and to permit persons to whom the
11  * Software is furnished to do so, subject to the following conditions:
12  *
13  * The above copyright notice and this permission notice shall be included in
14  * all copies or substantial portions of the Software.
15  *
16  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
19  * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
20  * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
21  * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
22  * OTHER DEALINGS IN THE SOFTWARE.
23  *
24  * Authors:
25  * Rob Clark <robdclark@gmail.com>
26  * Daniel Vetter <daniel.vetter@ffwll.ch>
27  */
28 
29 
30 #include <linux/sync_file.h>
31 
32 #include <drm/drm_atomic.h>
33 #include <drm/drm_atomic_uapi.h>
34 #include <drm/drm_blend.h>
35 #include <drm/drm_bridge.h>
36 #include <drm/drm_debugfs.h>
37 #include <drm/drm_device.h>
38 #include <drm/drm_drv.h>
39 #include <drm/drm_file.h>
40 #include <drm/drm_fourcc.h>
41 #include <drm/drm_framebuffer.h>
42 #include <drm/drm_mode.h>
43 #include <drm/drm_print.h>
44 #include <drm/drm_writeback.h>
45 
46 #include "drm_crtc_internal.h"
47 #include "drm_internal.h"
48 
49 void __drm_crtc_commit_free(struct kref *kref)
50 {
51 	struct drm_crtc_commit *commit =
52 		container_of(kref, struct drm_crtc_commit, ref);
53 
54 	kfree(commit);
55 }
56 EXPORT_SYMBOL(__drm_crtc_commit_free);
57 
58 /**
59  * drm_crtc_commit_wait - Waits for a commit to complete
60  * @commit: &drm_crtc_commit to wait for
61  *
62  * Waits for a given &drm_crtc_commit to be programmed into the
63  * hardware and flipped to.
64  *
65  * Returns:
66  *
67  * 0 on success, a negative error code otherwise.
68  */
69 int drm_crtc_commit_wait(struct drm_crtc_commit *commit)
70 {
71 	unsigned long timeout = 10 * HZ;
72 	int ret;
73 
74 	if (!commit)
75 		return 0;
76 
77 	ret = wait_for_completion_timeout(&commit->hw_done, timeout);
78 	if (!ret) {
79 		drm_err(commit->crtc->dev, "hw_done timed out\n");
80 		return -ETIMEDOUT;
81 	}
82 
83 	/*
84 	 * Currently no support for overwriting flips, hence
85 	 * stall for previous one to execute completely.
86 	 */
87 	ret = wait_for_completion_timeout(&commit->flip_done, timeout);
88 	if (!ret) {
89 		drm_err(commit->crtc->dev, "flip_done timed out\n");
90 		return -ETIMEDOUT;
91 	}
92 
93 	return 0;
94 }
95 EXPORT_SYMBOL(drm_crtc_commit_wait);
96 
97 /**
98  * drm_atomic_state_default_release -
99  * release memory initialized by drm_atomic_state_init
100  * @state: atomic state
101  *
102  * Free all the memory allocated by drm_atomic_state_init.
103  * This should only be used by drivers which are still subclassing
104  * &drm_atomic_state and haven't switched to &drm_private_state yet.
105  */
106 void drm_atomic_state_default_release(struct drm_atomic_state *state)
107 {
108 	kfree(state->connectors);
109 	kfree(state->crtcs);
110 	kfree(state->planes);
111 	kfree(state->private_objs);
112 }
113 EXPORT_SYMBOL(drm_atomic_state_default_release);
114 
115 /**
116  * drm_atomic_state_init - init new atomic state
117  * @dev: DRM device
118  * @state: atomic state
119  *
120  * Default implementation for filling in a new atomic state.
121  * This should only be used by drivers which are still subclassing
122  * &drm_atomic_state and haven't switched to &drm_private_state yet.
123  */
124 int
125 drm_atomic_state_init(struct drm_device *dev, struct drm_atomic_state *state)
126 {
127 	kref_init(&state->ref);
128 
129 	/* TODO legacy paths should maybe do a better job about
130 	 * setting this appropriately?
131 	 */
132 	state->allow_modeset = true;
133 
134 	state->crtcs = kcalloc(dev->mode_config.num_crtc,
135 			       sizeof(*state->crtcs), GFP_KERNEL);
136 	if (!state->crtcs)
137 		goto fail;
138 	state->planes = kcalloc(dev->mode_config.num_total_plane,
139 				sizeof(*state->planes), GFP_KERNEL);
140 	if (!state->planes)
141 		goto fail;
142 
143 	state->dev = dev;
144 
145 	drm_dbg_atomic(dev, "Allocated atomic state %p\n", state);
146 
147 	return 0;
148 fail:
149 	drm_atomic_state_default_release(state);
150 	return -ENOMEM;
151 }
152 EXPORT_SYMBOL(drm_atomic_state_init);
153 
154 /**
155  * drm_atomic_state_alloc - allocate atomic state
156  * @dev: DRM device
157  *
158  * This allocates an empty atomic state to track updates.
159  */
160 struct drm_atomic_state *
161 drm_atomic_state_alloc(struct drm_device *dev)
162 {
163 	struct drm_mode_config *config = &dev->mode_config;
164 
165 	if (!config->funcs->atomic_state_alloc) {
166 		struct drm_atomic_state *state;
167 
168 		state = kzalloc(sizeof(*state), GFP_KERNEL);
169 		if (!state)
170 			return NULL;
171 		if (drm_atomic_state_init(dev, state) < 0) {
172 			kfree(state);
173 			return NULL;
174 		}
175 		return state;
176 	}
177 
178 	return config->funcs->atomic_state_alloc(dev);
179 }
180 EXPORT_SYMBOL(drm_atomic_state_alloc);
181 
182 /**
183  * drm_atomic_state_default_clear - clear base atomic state
184  * @state: atomic state
185  *
186  * Default implementation for clearing atomic state.
187  * This should only be used by drivers which are still subclassing
188  * &drm_atomic_state and haven't switched to &drm_private_state yet.
189  */
190 void drm_atomic_state_default_clear(struct drm_atomic_state *state)
191 {
192 	struct drm_device *dev = state->dev;
193 	struct drm_mode_config *config = &dev->mode_config;
194 	int i;
195 
196 	drm_dbg_atomic(dev, "Clearing atomic state %p\n", state);
197 
198 	for (i = 0; i < state->num_connector; i++) {
199 		struct drm_connector *connector = state->connectors[i].ptr;
200 
201 		if (!connector)
202 			continue;
203 
204 		connector->funcs->atomic_destroy_state(connector,
205 						       state->connectors[i].state);
206 		state->connectors[i].ptr = NULL;
207 		state->connectors[i].state = NULL;
208 		state->connectors[i].old_state = NULL;
209 		state->connectors[i].new_state = NULL;
210 		drm_connector_put(connector);
211 	}
212 
213 	for (i = 0; i < config->num_crtc; i++) {
214 		struct drm_crtc *crtc = state->crtcs[i].ptr;
215 
216 		if (!crtc)
217 			continue;
218 
219 		crtc->funcs->atomic_destroy_state(crtc,
220 						  state->crtcs[i].state);
221 
222 		state->crtcs[i].ptr = NULL;
223 		state->crtcs[i].state = NULL;
224 		state->crtcs[i].old_state = NULL;
225 		state->crtcs[i].new_state = NULL;
226 
227 		if (state->crtcs[i].commit) {
228 			drm_crtc_commit_put(state->crtcs[i].commit);
229 			state->crtcs[i].commit = NULL;
230 		}
231 	}
232 
233 	for (i = 0; i < config->num_total_plane; i++) {
234 		struct drm_plane *plane = state->planes[i].ptr;
235 
236 		if (!plane)
237 			continue;
238 
239 		plane->funcs->atomic_destroy_state(plane,
240 						   state->planes[i].state);
241 		state->planes[i].ptr = NULL;
242 		state->planes[i].state = NULL;
243 		state->planes[i].old_state = NULL;
244 		state->planes[i].new_state = NULL;
245 	}
246 
247 	for (i = 0; i < state->num_private_objs; i++) {
248 		struct drm_private_obj *obj = state->private_objs[i].ptr;
249 
250 		obj->funcs->atomic_destroy_state(obj,
251 						 state->private_objs[i].state);
252 		state->private_objs[i].ptr = NULL;
253 		state->private_objs[i].state = NULL;
254 		state->private_objs[i].old_state = NULL;
255 		state->private_objs[i].new_state = NULL;
256 	}
257 	state->num_private_objs = 0;
258 
259 	if (state->fake_commit) {
260 		drm_crtc_commit_put(state->fake_commit);
261 		state->fake_commit = NULL;
262 	}
263 }
264 EXPORT_SYMBOL(drm_atomic_state_default_clear);
265 
266 /**
267  * drm_atomic_state_clear - clear state object
268  * @state: atomic state
269  *
270  * When the w/w mutex algorithm detects a deadlock we need to back off and drop
271  * all locks. So someone else could sneak in and change the current modeset
272  * configuration. Which means that all the state assembled in @state is no
273  * longer an atomic update to the current state, but to some arbitrary earlier
274  * state. Which could break assumptions the driver's
275  * &drm_mode_config_funcs.atomic_check likely relies on.
276  *
277  * Hence we must clear all cached state and completely start over, using this
278  * function.
279  */
280 void drm_atomic_state_clear(struct drm_atomic_state *state)
281 {
282 	struct drm_device *dev = state->dev;
283 	struct drm_mode_config *config = &dev->mode_config;
284 
285 	if (config->funcs->atomic_state_clear)
286 		config->funcs->atomic_state_clear(state);
287 	else
288 		drm_atomic_state_default_clear(state);
289 }
290 EXPORT_SYMBOL(drm_atomic_state_clear);
291 
292 /**
293  * __drm_atomic_state_free - free all memory for an atomic state
294  * @ref: This atomic state to deallocate
295  *
296  * This frees all memory associated with an atomic state, including all the
297  * per-object state for planes, CRTCs and connectors.
298  */
299 void __drm_atomic_state_free(struct kref *ref)
300 {
301 	struct drm_atomic_state *state = container_of(ref, typeof(*state), ref);
302 	struct drm_mode_config *config = &state->dev->mode_config;
303 
304 	drm_atomic_state_clear(state);
305 
306 	drm_dbg_atomic(state->dev, "Freeing atomic state %p\n", state);
307 
308 	if (config->funcs->atomic_state_free) {
309 		config->funcs->atomic_state_free(state);
310 	} else {
311 		drm_atomic_state_default_release(state);
312 		kfree(state);
313 	}
314 }
315 EXPORT_SYMBOL(__drm_atomic_state_free);
316 
317 /**
318  * drm_atomic_get_crtc_state - get CRTC state
319  * @state: global atomic state object
320  * @crtc: CRTC to get state object for
321  *
322  * This function returns the CRTC state for the given CRTC, allocating it if
323  * needed. It will also grab the relevant CRTC lock to make sure that the state
324  * is consistent.
325  *
326  * WARNING: Drivers may only add new CRTC states to a @state if
327  * drm_atomic_state.allow_modeset is set, or if it's a driver-internal commit
328  * not created by userspace through an IOCTL call.
329  *
330  * Returns:
331  *
332  * Either the allocated state or the error code encoded into the pointer. When
333  * the error is EDEADLK then the w/w mutex code has detected a deadlock and the
334  * entire atomic sequence must be restarted. All other errors are fatal.
335  */
336 struct drm_crtc_state *
337 drm_atomic_get_crtc_state(struct drm_atomic_state *state,
338 			  struct drm_crtc *crtc)
339 {
340 	int ret, index = drm_crtc_index(crtc);
341 	struct drm_crtc_state *crtc_state;
342 
343 	WARN_ON(!state->acquire_ctx);
344 
345 	crtc_state = drm_atomic_get_existing_crtc_state(state, crtc);
346 	if (crtc_state)
347 		return crtc_state;
348 
349 	ret = drm_modeset_lock(&crtc->mutex, state->acquire_ctx);
350 	if (ret)
351 		return ERR_PTR(ret);
352 
353 	crtc_state = crtc->funcs->atomic_duplicate_state(crtc);
354 	if (!crtc_state)
355 		return ERR_PTR(-ENOMEM);
356 
357 	state->crtcs[index].state = crtc_state;
358 	state->crtcs[index].old_state = crtc->state;
359 	state->crtcs[index].new_state = crtc_state;
360 	state->crtcs[index].ptr = crtc;
361 	crtc_state->state = state;
362 
363 	drm_dbg_atomic(state->dev, "Added [CRTC:%d:%s] %p state to %p\n",
364 		       crtc->base.id, crtc->name, crtc_state, state);
365 
366 	return crtc_state;
367 }
368 EXPORT_SYMBOL(drm_atomic_get_crtc_state);
369 
370 static int drm_atomic_crtc_check(const struct drm_crtc_state *old_crtc_state,
371 				 const struct drm_crtc_state *new_crtc_state)
372 {
373 	struct drm_crtc *crtc = new_crtc_state->crtc;
374 
375 	/* NOTE: we explicitly don't enforce constraints such as primary
376 	 * layer covering entire screen, since that is something we want
377 	 * to allow (on hw that supports it).  For hw that does not, it
378 	 * should be checked in driver's crtc->atomic_check() vfunc.
379 	 *
380 	 * TODO: Add generic modeset state checks once we support those.
381 	 */
382 
383 	if (new_crtc_state->active && !new_crtc_state->enable) {
384 		drm_dbg_atomic(crtc->dev,
385 			       "[CRTC:%d:%s] active without enabled\n",
386 			       crtc->base.id, crtc->name);
387 		return -EINVAL;
388 	}
389 
390 	/* The state->enable vs. state->mode_blob checks can be WARN_ON,
391 	 * as this is a kernel-internal detail that userspace should never
392 	 * be able to trigger.
393 	 */
394 	if (drm_core_check_feature(crtc->dev, DRIVER_ATOMIC) &&
395 	    WARN_ON(new_crtc_state->enable && !new_crtc_state->mode_blob)) {
396 		drm_dbg_atomic(crtc->dev,
397 			       "[CRTC:%d:%s] enabled without mode blob\n",
398 			       crtc->base.id, crtc->name);
399 		return -EINVAL;
400 	}
401 
402 	if (drm_core_check_feature(crtc->dev, DRIVER_ATOMIC) &&
403 	    WARN_ON(!new_crtc_state->enable && new_crtc_state->mode_blob)) {
404 		drm_dbg_atomic(crtc->dev,
405 			       "[CRTC:%d:%s] disabled with mode blob\n",
406 			       crtc->base.id, crtc->name);
407 		return -EINVAL;
408 	}
409 
410 	/*
411 	 * Reject event generation for when a CRTC is off and stays off.
412 	 * It wouldn't be hard to implement this, but userspace has a track
413 	 * record of happily burning through 100% cpu (or worse, crash) when the
414 	 * display pipe is suspended. To avoid all that fun just reject updates
415 	 * that ask for events since likely that indicates a bug in the
416 	 * compositor's drawing loop. This is consistent with the vblank IOCTL
417 	 * and legacy page_flip IOCTL which also reject service on a disabled
418 	 * pipe.
419 	 */
420 	if (new_crtc_state->event &&
421 	    !new_crtc_state->active && !old_crtc_state->active) {
422 		drm_dbg_atomic(crtc->dev,
423 			       "[CRTC:%d:%s] requesting event but off\n",
424 			       crtc->base.id, crtc->name);
425 		return -EINVAL;
426 	}
427 
428 	return 0;
429 }
430 
431 static void drm_atomic_crtc_print_state(struct drm_printer *p,
432 		const struct drm_crtc_state *state)
433 {
434 	struct drm_crtc *crtc = state->crtc;
435 
436 	drm_printf(p, "crtc[%u]: %s\n", crtc->base.id, crtc->name);
437 	drm_printf(p, "\tenable=%d\n", state->enable);
438 	drm_printf(p, "\tactive=%d\n", state->active);
439 	drm_printf(p, "\tself_refresh_active=%d\n", state->self_refresh_active);
440 	drm_printf(p, "\tplanes_changed=%d\n", state->planes_changed);
441 	drm_printf(p, "\tmode_changed=%d\n", state->mode_changed);
442 	drm_printf(p, "\tactive_changed=%d\n", state->active_changed);
443 	drm_printf(p, "\tconnectors_changed=%d\n", state->connectors_changed);
444 	drm_printf(p, "\tcolor_mgmt_changed=%d\n", state->color_mgmt_changed);
445 	drm_printf(p, "\tplane_mask=%x\n", state->plane_mask);
446 	drm_printf(p, "\tconnector_mask=%x\n", state->connector_mask);
447 	drm_printf(p, "\tencoder_mask=%x\n", state->encoder_mask);
448 	drm_printf(p, "\tmode: " DRM_MODE_FMT "\n", DRM_MODE_ARG(&state->mode));
449 
450 	if (crtc->funcs->atomic_print_state)
451 		crtc->funcs->atomic_print_state(p, state);
452 }
453 
454 static int drm_atomic_connector_check(struct drm_connector *connector,
455 		struct drm_connector_state *state)
456 {
457 	struct drm_crtc_state *crtc_state;
458 	struct drm_writeback_job *writeback_job = state->writeback_job;
459 	const struct drm_display_info *info = &connector->display_info;
460 
461 	state->max_bpc = info->bpc ? info->bpc : 8;
462 	if (connector->max_bpc_property)
463 		state->max_bpc = min(state->max_bpc, state->max_requested_bpc);
464 
465 	if ((connector->connector_type != DRM_MODE_CONNECTOR_WRITEBACK) || !writeback_job)
466 		return 0;
467 
468 	if (writeback_job->fb && !state->crtc) {
469 		drm_dbg_atomic(connector->dev,
470 			       "[CONNECTOR:%d:%s] framebuffer without CRTC\n",
471 			       connector->base.id, connector->name);
472 		return -EINVAL;
473 	}
474 
475 	if (state->crtc)
476 		crtc_state = drm_atomic_get_existing_crtc_state(state->state,
477 								state->crtc);
478 
479 	if (writeback_job->fb && !crtc_state->active) {
480 		drm_dbg_atomic(connector->dev,
481 			       "[CONNECTOR:%d:%s] has framebuffer, but [CRTC:%d] is off\n",
482 			       connector->base.id, connector->name,
483 			       state->crtc->base.id);
484 		return -EINVAL;
485 	}
486 
487 	if (!writeback_job->fb) {
488 		if (writeback_job->out_fence) {
489 			drm_dbg_atomic(connector->dev,
490 				       "[CONNECTOR:%d:%s] requesting out-fence without framebuffer\n",
491 				       connector->base.id, connector->name);
492 			return -EINVAL;
493 		}
494 
495 		drm_writeback_cleanup_job(writeback_job);
496 		state->writeback_job = NULL;
497 	}
498 
499 	return 0;
500 }
501 
502 /**
503  * drm_atomic_get_plane_state - get plane state
504  * @state: global atomic state object
505  * @plane: plane to get state object for
506  *
507  * This function returns the plane state for the given plane, allocating it if
508  * needed. It will also grab the relevant plane lock to make sure that the state
509  * is consistent.
510  *
511  * Returns:
512  *
513  * Either the allocated state or the error code encoded into the pointer. When
514  * the error is EDEADLK then the w/w mutex code has detected a deadlock and the
515  * entire atomic sequence must be restarted. All other errors are fatal.
516  */
517 struct drm_plane_state *
518 drm_atomic_get_plane_state(struct drm_atomic_state *state,
519 			  struct drm_plane *plane)
520 {
521 	int ret, index = drm_plane_index(plane);
522 	struct drm_plane_state *plane_state;
523 
524 	WARN_ON(!state->acquire_ctx);
525 
526 	/* the legacy pointers should never be set */
527 	WARN_ON(plane->fb);
528 	WARN_ON(plane->old_fb);
529 	WARN_ON(plane->crtc);
530 
531 	plane_state = drm_atomic_get_existing_plane_state(state, plane);
532 	if (plane_state)
533 		return plane_state;
534 
535 	ret = drm_modeset_lock(&plane->mutex, state->acquire_ctx);
536 	if (ret)
537 		return ERR_PTR(ret);
538 
539 	plane_state = plane->funcs->atomic_duplicate_state(plane);
540 	if (!plane_state)
541 		return ERR_PTR(-ENOMEM);
542 
543 	state->planes[index].state = plane_state;
544 	state->planes[index].ptr = plane;
545 	state->planes[index].old_state = plane->state;
546 	state->planes[index].new_state = plane_state;
547 	plane_state->state = state;
548 
549 	drm_dbg_atomic(plane->dev, "Added [PLANE:%d:%s] %p state to %p\n",
550 		       plane->base.id, plane->name, plane_state, state);
551 
552 	if (plane_state->crtc) {
553 		struct drm_crtc_state *crtc_state;
554 
555 		crtc_state = drm_atomic_get_crtc_state(state,
556 						       plane_state->crtc);
557 		if (IS_ERR(crtc_state))
558 			return ERR_CAST(crtc_state);
559 	}
560 
561 	return plane_state;
562 }
563 EXPORT_SYMBOL(drm_atomic_get_plane_state);
564 
565 static bool
566 plane_switching_crtc(const struct drm_plane_state *old_plane_state,
567 		     const struct drm_plane_state *new_plane_state)
568 {
569 	if (!old_plane_state->crtc || !new_plane_state->crtc)
570 		return false;
571 
572 	if (old_plane_state->crtc == new_plane_state->crtc)
573 		return false;
574 
575 	/* This could be refined, but currently there's no helper or driver code
576 	 * to implement direct switching of active planes nor userspace to take
577 	 * advantage of more direct plane switching without the intermediate
578 	 * full OFF state.
579 	 */
580 	return true;
581 }
582 
583 /**
584  * drm_atomic_plane_check - check plane state
585  * @old_plane_state: old plane state to check
586  * @new_plane_state: new plane state to check
587  *
588  * Provides core sanity checks for plane state.
589  *
590  * RETURNS:
591  * Zero on success, error code on failure
592  */
593 static int drm_atomic_plane_check(const struct drm_plane_state *old_plane_state,
594 				  const struct drm_plane_state *new_plane_state)
595 {
596 	struct drm_plane *plane = new_plane_state->plane;
597 	struct drm_crtc *crtc = new_plane_state->crtc;
598 	const struct drm_framebuffer *fb = new_plane_state->fb;
599 	unsigned int fb_width, fb_height;
600 	struct drm_mode_rect *clips;
601 	uint32_t num_clips;
602 	int ret;
603 
604 	/* either *both* CRTC and FB must be set, or neither */
605 	if (crtc && !fb) {
606 		drm_dbg_atomic(plane->dev, "[PLANE:%d:%s] CRTC set but no FB\n",
607 			       plane->base.id, plane->name);
608 		return -EINVAL;
609 	} else if (fb && !crtc) {
610 		drm_dbg_atomic(plane->dev, "[PLANE:%d:%s] FB set but no CRTC\n",
611 			       plane->base.id, plane->name);
612 		return -EINVAL;
613 	}
614 
615 	/* if disabled, we don't care about the rest of the state: */
616 	if (!crtc)
617 		return 0;
618 
619 	/* Check whether this plane is usable on this CRTC */
620 	if (!(plane->possible_crtcs & drm_crtc_mask(crtc))) {
621 		drm_dbg_atomic(plane->dev,
622 			       "Invalid [CRTC:%d:%s] for [PLANE:%d:%s]\n",
623 			       crtc->base.id, crtc->name,
624 			       plane->base.id, plane->name);
625 		return -EINVAL;
626 	}
627 
628 	/* Check whether this plane supports the fb pixel format. */
629 	ret = drm_plane_check_pixel_format(plane, fb->format->format,
630 					   fb->modifier);
631 	if (ret) {
632 		drm_dbg_atomic(plane->dev,
633 			       "[PLANE:%d:%s] invalid pixel format %p4cc, modifier 0x%llx\n",
634 			       plane->base.id, plane->name,
635 			       &fb->format->format, fb->modifier);
636 		return ret;
637 	}
638 
639 	/* Give drivers some help against integer overflows */
640 	if (new_plane_state->crtc_w > INT_MAX ||
641 	    new_plane_state->crtc_x > INT_MAX - (int32_t) new_plane_state->crtc_w ||
642 	    new_plane_state->crtc_h > INT_MAX ||
643 	    new_plane_state->crtc_y > INT_MAX - (int32_t) new_plane_state->crtc_h) {
644 		drm_dbg_atomic(plane->dev,
645 			       "[PLANE:%d:%s] invalid CRTC coordinates %ux%u+%d+%d\n",
646 			       plane->base.id, plane->name,
647 			       new_plane_state->crtc_w, new_plane_state->crtc_h,
648 			       new_plane_state->crtc_x, new_plane_state->crtc_y);
649 		return -ERANGE;
650 	}
651 
652 	fb_width = fb->width << 16;
653 	fb_height = fb->height << 16;
654 
655 	/* Make sure source coordinates are inside the fb. */
656 	if (new_plane_state->src_w > fb_width ||
657 	    new_plane_state->src_x > fb_width - new_plane_state->src_w ||
658 	    new_plane_state->src_h > fb_height ||
659 	    new_plane_state->src_y > fb_height - new_plane_state->src_h) {
660 		drm_dbg_atomic(plane->dev,
661 			       "[PLANE:%d:%s] invalid source coordinates "
662 			       "%u.%06ux%u.%06u+%u.%06u+%u.%06u (fb %ux%u)\n",
663 			       plane->base.id, plane->name,
664 			       new_plane_state->src_w >> 16,
665 			       ((new_plane_state->src_w & 0xffff) * 15625) >> 10,
666 			       new_plane_state->src_h >> 16,
667 			       ((new_plane_state->src_h & 0xffff) * 15625) >> 10,
668 			       new_plane_state->src_x >> 16,
669 			       ((new_plane_state->src_x & 0xffff) * 15625) >> 10,
670 			       new_plane_state->src_y >> 16,
671 			       ((new_plane_state->src_y & 0xffff) * 15625) >> 10,
672 			       fb->width, fb->height);
673 		return -ENOSPC;
674 	}
675 
676 	clips = __drm_plane_get_damage_clips(new_plane_state);
677 	num_clips = drm_plane_get_damage_clips_count(new_plane_state);
678 
679 	/* Make sure damage clips are valid and inside the fb. */
680 	while (num_clips > 0) {
681 		if (clips->x1 >= clips->x2 ||
682 		    clips->y1 >= clips->y2 ||
683 		    clips->x1 < 0 ||
684 		    clips->y1 < 0 ||
685 		    clips->x2 > fb_width ||
686 		    clips->y2 > fb_height) {
687 			drm_dbg_atomic(plane->dev,
688 				       "[PLANE:%d:%s] invalid damage clip %d %d %d %d\n",
689 				       plane->base.id, plane->name, clips->x1,
690 				       clips->y1, clips->x2, clips->y2);
691 			return -EINVAL;
692 		}
693 		clips++;
694 		num_clips--;
695 	}
696 
697 	if (plane_switching_crtc(old_plane_state, new_plane_state)) {
698 		drm_dbg_atomic(plane->dev,
699 			       "[PLANE:%d:%s] switching CRTC directly\n",
700 			       plane->base.id, plane->name);
701 		return -EINVAL;
702 	}
703 
704 	return 0;
705 }
706 
707 static void drm_atomic_plane_print_state(struct drm_printer *p,
708 		const struct drm_plane_state *state)
709 {
710 	struct drm_plane *plane = state->plane;
711 	struct drm_rect src  = drm_plane_state_src(state);
712 	struct drm_rect dest = drm_plane_state_dest(state);
713 
714 	drm_printf(p, "plane[%u]: %s\n", plane->base.id, plane->name);
715 	drm_printf(p, "\tcrtc=%s\n", state->crtc ? state->crtc->name : "(null)");
716 	drm_printf(p, "\tfb=%u\n", state->fb ? state->fb->base.id : 0);
717 	if (state->fb)
718 		drm_framebuffer_print_info(p, 2, state->fb);
719 	drm_printf(p, "\tcrtc-pos=" DRM_RECT_FMT "\n", DRM_RECT_ARG(&dest));
720 	drm_printf(p, "\tsrc-pos=" DRM_RECT_FP_FMT "\n", DRM_RECT_FP_ARG(&src));
721 	drm_printf(p, "\trotation=%x\n", state->rotation);
722 	drm_printf(p, "\tnormalized-zpos=%x\n", state->normalized_zpos);
723 	drm_printf(p, "\tcolor-encoding=%s\n",
724 		   drm_get_color_encoding_name(state->color_encoding));
725 	drm_printf(p, "\tcolor-range=%s\n",
726 		   drm_get_color_range_name(state->color_range));
727 
728 	if (plane->funcs->atomic_print_state)
729 		plane->funcs->atomic_print_state(p, state);
730 }
731 
732 /**
733  * DOC: handling driver private state
734  *
735  * Very often the DRM objects exposed to userspace in the atomic modeset api
736  * (&drm_connector, &drm_crtc and &drm_plane) do not map neatly to the
737  * underlying hardware. Especially for any kind of shared resources (e.g. shared
738  * clocks, scaler units, bandwidth and fifo limits shared among a group of
739  * planes or CRTCs, and so on) it makes sense to model these as independent
740  * objects. Drivers then need to do similar state tracking and commit ordering for
741  * such private (since not exposed to userspace) objects as the atomic core and
742  * helpers already provide for connectors, planes and CRTCs.
743  *
744  * To make this easier on drivers the atomic core provides some support to track
745  * driver private state objects using struct &drm_private_obj, with the
746  * associated state struct &drm_private_state.
747  *
748  * Similar to userspace-exposed objects, private state structures can be
749  * acquired by calling drm_atomic_get_private_obj_state(). This also takes care
750  * of locking, hence drivers should not have a need to call drm_modeset_lock()
751  * directly. Sequence of the actual hardware state commit is not handled,
752  * drivers might need to keep track of struct drm_crtc_commit within subclassed
753  * structure of &drm_private_state as necessary, e.g. similar to
754  * &drm_plane_state.commit. See also &drm_atomic_state.fake_commit.
755  *
756  * All private state structures contained in a &drm_atomic_state update can be
757  * iterated using for_each_oldnew_private_obj_in_state(),
758  * for_each_new_private_obj_in_state() and for_each_old_private_obj_in_state().
759  * Drivers are recommended to wrap these for each type of driver private state
760  * object they have, filtering on &drm_private_obj.funcs using for_each_if(), at
761  * least if they want to iterate over all objects of a given type.
762  *
763  * An earlier way to handle driver private state was by subclassing struct
764  * &drm_atomic_state. But since that encourages non-standard ways to implement
765  * the check/commit split atomic requires (by using e.g. "check and rollback or
766  * commit instead" of "duplicate state, check, then either commit or release
767  * duplicated state) it is deprecated in favour of using &drm_private_state.
768  */
769 
770 /**
771  * drm_atomic_private_obj_init - initialize private object
772  * @dev: DRM device this object will be attached to
773  * @obj: private object
774  * @state: initial private object state
775  * @funcs: pointer to the struct of function pointers that identify the object
776  * type
777  *
778  * Initialize the private object, which can be embedded into any
779  * driver private object that needs its own atomic state.
780  */
781 void
782 drm_atomic_private_obj_init(struct drm_device *dev,
783 			    struct drm_private_obj *obj,
784 			    struct drm_private_state *state,
785 			    const struct drm_private_state_funcs *funcs)
786 {
787 	memset(obj, 0, sizeof(*obj));
788 
789 	drm_modeset_lock_init(&obj->lock);
790 
791 	obj->state = state;
792 	obj->funcs = funcs;
793 	list_add_tail(&obj->head, &dev->mode_config.privobj_list);
794 
795 	state->obj = obj;
796 }
797 EXPORT_SYMBOL(drm_atomic_private_obj_init);
798 
799 /**
800  * drm_atomic_private_obj_fini - finalize private object
801  * @obj: private object
802  *
803  * Finalize the private object.
804  */
805 void
806 drm_atomic_private_obj_fini(struct drm_private_obj *obj)
807 {
808 	list_del(&obj->head);
809 	obj->funcs->atomic_destroy_state(obj, obj->state);
810 	drm_modeset_lock_fini(&obj->lock);
811 }
812 EXPORT_SYMBOL(drm_atomic_private_obj_fini);
813 
814 /**
815  * drm_atomic_get_private_obj_state - get private object state
816  * @state: global atomic state
817  * @obj: private object to get the state for
818  *
819  * This function returns the private object state for the given private object,
820  * allocating the state if needed. It will also grab the relevant private
821  * object lock to make sure that the state is consistent.
822  *
823  * RETURNS:
824  *
825  * Either the allocated state or the error code encoded into a pointer.
826  */
827 struct drm_private_state *
828 drm_atomic_get_private_obj_state(struct drm_atomic_state *state,
829 				 struct drm_private_obj *obj)
830 {
831 	int index, num_objs, i, ret;
832 	size_t size;
833 	struct __drm_private_objs_state *arr;
834 	struct drm_private_state *obj_state;
835 
836 	for (i = 0; i < state->num_private_objs; i++)
837 		if (obj == state->private_objs[i].ptr)
838 			return state->private_objs[i].state;
839 
840 	ret = drm_modeset_lock(&obj->lock, state->acquire_ctx);
841 	if (ret)
842 		return ERR_PTR(ret);
843 
844 	num_objs = state->num_private_objs + 1;
845 	size = sizeof(*state->private_objs) * num_objs;
846 	arr = krealloc(state->private_objs, size, GFP_KERNEL);
847 	if (!arr)
848 		return ERR_PTR(-ENOMEM);
849 
850 	state->private_objs = arr;
851 	index = state->num_private_objs;
852 	memset(&state->private_objs[index], 0, sizeof(*state->private_objs));
853 
854 	obj_state = obj->funcs->atomic_duplicate_state(obj);
855 	if (!obj_state)
856 		return ERR_PTR(-ENOMEM);
857 
858 	state->private_objs[index].state = obj_state;
859 	state->private_objs[index].old_state = obj->state;
860 	state->private_objs[index].new_state = obj_state;
861 	state->private_objs[index].ptr = obj;
862 	obj_state->state = state;
863 
864 	state->num_private_objs = num_objs;
865 
866 	drm_dbg_atomic(state->dev,
867 		       "Added new private object %p state %p to %p\n",
868 		       obj, obj_state, state);
869 
870 	return obj_state;
871 }
872 EXPORT_SYMBOL(drm_atomic_get_private_obj_state);
873 
874 /**
875  * drm_atomic_get_old_private_obj_state
876  * @state: global atomic state object
877  * @obj: private_obj to grab
878  *
879  * This function returns the old private object state for the given private_obj,
880  * or NULL if the private_obj is not part of the global atomic state.
881  */
882 struct drm_private_state *
883 drm_atomic_get_old_private_obj_state(const struct drm_atomic_state *state,
884 				     struct drm_private_obj *obj)
885 {
886 	int i;
887 
888 	for (i = 0; i < state->num_private_objs; i++)
889 		if (obj == state->private_objs[i].ptr)
890 			return state->private_objs[i].old_state;
891 
892 	return NULL;
893 }
894 EXPORT_SYMBOL(drm_atomic_get_old_private_obj_state);
895 
896 /**
897  * drm_atomic_get_new_private_obj_state
898  * @state: global atomic state object
899  * @obj: private_obj to grab
900  *
901  * This function returns the new private object state for the given private_obj,
902  * or NULL if the private_obj is not part of the global atomic state.
903  */
904 struct drm_private_state *
905 drm_atomic_get_new_private_obj_state(const struct drm_atomic_state *state,
906 				     struct drm_private_obj *obj)
907 {
908 	int i;
909 
910 	for (i = 0; i < state->num_private_objs; i++)
911 		if (obj == state->private_objs[i].ptr)
912 			return state->private_objs[i].new_state;
913 
914 	return NULL;
915 }
916 EXPORT_SYMBOL(drm_atomic_get_new_private_obj_state);
917 
918 /**
919  * drm_atomic_get_old_connector_for_encoder - Get old connector for an encoder
920  * @state: Atomic state
921  * @encoder: The encoder to fetch the connector state for
922  *
923  * This function finds and returns the connector that was connected to @encoder
924  * as specified by the @state.
925  *
926  * If there is no connector in @state which previously had @encoder connected to
927  * it, this function will return NULL. While this may seem like an invalid use
928  * case, it is sometimes useful to differentiate commits which had no prior
929  * connectors attached to @encoder vs ones that did (and to inspect their
930  * state). This is especially true in enable hooks because the pipeline has
931  * changed.
932  *
933  * Returns: The old connector connected to @encoder, or NULL if the encoder is
934  * not connected.
935  */
936 struct drm_connector *
937 drm_atomic_get_old_connector_for_encoder(const struct drm_atomic_state *state,
938 					 struct drm_encoder *encoder)
939 {
940 	struct drm_connector_state *conn_state;
941 	struct drm_connector *connector;
942 	unsigned int i;
943 
944 	for_each_old_connector_in_state(state, connector, conn_state, i) {
945 		if (conn_state->best_encoder == encoder)
946 			return connector;
947 	}
948 
949 	return NULL;
950 }
951 EXPORT_SYMBOL(drm_atomic_get_old_connector_for_encoder);
952 
953 /**
954  * drm_atomic_get_new_connector_for_encoder - Get new connector for an encoder
955  * @state: Atomic state
956  * @encoder: The encoder to fetch the connector state for
957  *
958  * This function finds and returns the connector that will be connected to
959  * @encoder as specified by the @state.
960  *
961  * If there is no connector in @state which will have @encoder connected to it,
962  * this function will return NULL. While this may seem like an invalid use case,
963  * it is sometimes useful to differentiate commits which have no connectors
964  * attached to @encoder vs ones that do (and to inspect their state). This is
965  * especially true in disable hooks because the pipeline will change.
966  *
967  * Returns: The new connector connected to @encoder, or NULL if the encoder is
968  * not connected.
969  */
970 struct drm_connector *
971 drm_atomic_get_new_connector_for_encoder(const struct drm_atomic_state *state,
972 					 struct drm_encoder *encoder)
973 {
974 	struct drm_connector_state *conn_state;
975 	struct drm_connector *connector;
976 	unsigned int i;
977 
978 	for_each_new_connector_in_state(state, connector, conn_state, i) {
979 		if (conn_state->best_encoder == encoder)
980 			return connector;
981 	}
982 
983 	return NULL;
984 }
985 EXPORT_SYMBOL(drm_atomic_get_new_connector_for_encoder);
986 
987 /**
988  * drm_atomic_get_old_crtc_for_encoder - Get old crtc for an encoder
989  * @state: Atomic state
990  * @encoder: The encoder to fetch the crtc state for
991  *
992  * This function finds and returns the crtc that was connected to @encoder
993  * as specified by the @state.
994  *
995  * Returns: The old crtc connected to @encoder, or NULL if the encoder is
996  * not connected.
997  */
998 struct drm_crtc *
999 drm_atomic_get_old_crtc_for_encoder(struct drm_atomic_state *state,
1000 				    struct drm_encoder *encoder)
1001 {
1002 	struct drm_connector *connector;
1003 	struct drm_connector_state *conn_state;
1004 
1005 	connector = drm_atomic_get_old_connector_for_encoder(state, encoder);
1006 	if (!connector)
1007 		return NULL;
1008 
1009 	conn_state = drm_atomic_get_old_connector_state(state, connector);
1010 	if (!conn_state)
1011 		return NULL;
1012 
1013 	return conn_state->crtc;
1014 }
1015 EXPORT_SYMBOL(drm_atomic_get_old_crtc_for_encoder);
1016 
1017 /**
1018  * drm_atomic_get_new_crtc_for_encoder - Get new crtc for an encoder
1019  * @state: Atomic state
1020  * @encoder: The encoder to fetch the crtc state for
1021  *
1022  * This function finds and returns the crtc that will be connected to @encoder
1023  * as specified by the @state.
1024  *
1025  * Returns: The new crtc connected to @encoder, or NULL if the encoder is
1026  * not connected.
1027  */
1028 struct drm_crtc *
1029 drm_atomic_get_new_crtc_for_encoder(struct drm_atomic_state *state,
1030 				    struct drm_encoder *encoder)
1031 {
1032 	struct drm_connector *connector;
1033 	struct drm_connector_state *conn_state;
1034 
1035 	connector = drm_atomic_get_new_connector_for_encoder(state, encoder);
1036 	if (!connector)
1037 		return NULL;
1038 
1039 	conn_state = drm_atomic_get_new_connector_state(state, connector);
1040 	if (!conn_state)
1041 		return NULL;
1042 
1043 	return conn_state->crtc;
1044 }
1045 EXPORT_SYMBOL(drm_atomic_get_new_crtc_for_encoder);
1046 
1047 /**
1048  * drm_atomic_get_connector_state - get connector state
1049  * @state: global atomic state object
1050  * @connector: connector to get state object for
1051  *
1052  * This function returns the connector state for the given connector,
1053  * allocating it if needed. It will also grab the relevant connector lock to
1054  * make sure that the state is consistent.
1055  *
1056  * Returns:
1057  *
1058  * Either the allocated state or the error code encoded into the pointer. When
1059  * the error is EDEADLK then the w/w mutex code has detected a deadlock and the
1060  * entire atomic sequence must be restarted. All other errors are fatal.
1061  */
1062 struct drm_connector_state *
1063 drm_atomic_get_connector_state(struct drm_atomic_state *state,
1064 			  struct drm_connector *connector)
1065 {
1066 	int ret, index;
1067 	struct drm_mode_config *config = &connector->dev->mode_config;
1068 	struct drm_connector_state *connector_state;
1069 
1070 	WARN_ON(!state->acquire_ctx);
1071 
1072 	ret = drm_modeset_lock(&config->connection_mutex, state->acquire_ctx);
1073 	if (ret)
1074 		return ERR_PTR(ret);
1075 
1076 	index = drm_connector_index(connector);
1077 
1078 	if (index >= state->num_connector) {
1079 		struct __drm_connnectors_state *c;
1080 		int alloc = max(index + 1, config->num_connector);
1081 
1082 		c = krealloc_array(state->connectors, alloc,
1083 				   sizeof(*state->connectors), GFP_KERNEL);
1084 		if (!c)
1085 			return ERR_PTR(-ENOMEM);
1086 
1087 		state->connectors = c;
1088 		memset(&state->connectors[state->num_connector], 0,
1089 		       sizeof(*state->connectors) * (alloc - state->num_connector));
1090 
1091 		state->num_connector = alloc;
1092 	}
1093 
1094 	if (state->connectors[index].state)
1095 		return state->connectors[index].state;
1096 
1097 	connector_state = connector->funcs->atomic_duplicate_state(connector);
1098 	if (!connector_state)
1099 		return ERR_PTR(-ENOMEM);
1100 
1101 	drm_connector_get(connector);
1102 	state->connectors[index].state = connector_state;
1103 	state->connectors[index].old_state = connector->state;
1104 	state->connectors[index].new_state = connector_state;
1105 	state->connectors[index].ptr = connector;
1106 	connector_state->state = state;
1107 
1108 	drm_dbg_atomic(connector->dev, "Added [CONNECTOR:%d:%s] %p state to %p\n",
1109 			 connector->base.id, connector->name,
1110 			 connector_state, state);
1111 
1112 	if (connector_state->crtc) {
1113 		struct drm_crtc_state *crtc_state;
1114 
1115 		crtc_state = drm_atomic_get_crtc_state(state,
1116 						       connector_state->crtc);
1117 		if (IS_ERR(crtc_state))
1118 			return ERR_CAST(crtc_state);
1119 	}
1120 
1121 	return connector_state;
1122 }
1123 EXPORT_SYMBOL(drm_atomic_get_connector_state);
1124 
1125 static void drm_atomic_connector_print_state(struct drm_printer *p,
1126 		const struct drm_connector_state *state)
1127 {
1128 	struct drm_connector *connector = state->connector;
1129 
1130 	drm_printf(p, "connector[%u]: %s\n", connector->base.id, connector->name);
1131 	drm_printf(p, "\tcrtc=%s\n", state->crtc ? state->crtc->name : "(null)");
1132 	drm_printf(p, "\tself_refresh_aware=%d\n", state->self_refresh_aware);
1133 	drm_printf(p, "\tmax_requested_bpc=%d\n", state->max_requested_bpc);
1134 	drm_printf(p, "\tcolorspace=%s\n", drm_get_colorspace_name(state->colorspace));
1135 
1136 	if (connector->connector_type == DRM_MODE_CONNECTOR_WRITEBACK)
1137 		if (state->writeback_job && state->writeback_job->fb)
1138 			drm_printf(p, "\tfb=%d\n", state->writeback_job->fb->base.id);
1139 
1140 	if (connector->funcs->atomic_print_state)
1141 		connector->funcs->atomic_print_state(p, state);
1142 }
1143 
1144 /**
1145  * drm_atomic_get_bridge_state - get bridge state
1146  * @state: global atomic state object
1147  * @bridge: bridge to get state object for
1148  *
1149  * This function returns the bridge state for the given bridge, allocating it
1150  * if needed. It will also grab the relevant bridge lock to make sure that the
1151  * state is consistent.
1152  *
1153  * Returns:
1154  *
1155  * Either the allocated state or the error code encoded into the pointer. When
1156  * the error is EDEADLK then the w/w mutex code has detected a deadlock and the
1157  * entire atomic sequence must be restarted.
1158  */
1159 struct drm_bridge_state *
1160 drm_atomic_get_bridge_state(struct drm_atomic_state *state,
1161 			    struct drm_bridge *bridge)
1162 {
1163 	struct drm_private_state *obj_state;
1164 
1165 	obj_state = drm_atomic_get_private_obj_state(state, &bridge->base);
1166 	if (IS_ERR(obj_state))
1167 		return ERR_CAST(obj_state);
1168 
1169 	return drm_priv_to_bridge_state(obj_state);
1170 }
1171 EXPORT_SYMBOL(drm_atomic_get_bridge_state);
1172 
1173 /**
1174  * drm_atomic_get_old_bridge_state - get old bridge state, if it exists
1175  * @state: global atomic state object
1176  * @bridge: bridge to grab
1177  *
1178  * This function returns the old bridge state for the given bridge, or NULL if
1179  * the bridge is not part of the global atomic state.
1180  */
1181 struct drm_bridge_state *
1182 drm_atomic_get_old_bridge_state(const struct drm_atomic_state *state,
1183 				struct drm_bridge *bridge)
1184 {
1185 	struct drm_private_state *obj_state;
1186 
1187 	obj_state = drm_atomic_get_old_private_obj_state(state, &bridge->base);
1188 	if (!obj_state)
1189 		return NULL;
1190 
1191 	return drm_priv_to_bridge_state(obj_state);
1192 }
1193 EXPORT_SYMBOL(drm_atomic_get_old_bridge_state);
1194 
1195 /**
1196  * drm_atomic_get_new_bridge_state - get new bridge state, if it exists
1197  * @state: global atomic state object
1198  * @bridge: bridge to grab
1199  *
1200  * This function returns the new bridge state for the given bridge, or NULL if
1201  * the bridge is not part of the global atomic state.
1202  */
1203 struct drm_bridge_state *
1204 drm_atomic_get_new_bridge_state(const struct drm_atomic_state *state,
1205 				struct drm_bridge *bridge)
1206 {
1207 	struct drm_private_state *obj_state;
1208 
1209 	obj_state = drm_atomic_get_new_private_obj_state(state, &bridge->base);
1210 	if (!obj_state)
1211 		return NULL;
1212 
1213 	return drm_priv_to_bridge_state(obj_state);
1214 }
1215 EXPORT_SYMBOL(drm_atomic_get_new_bridge_state);
1216 
1217 /**
1218  * drm_atomic_add_encoder_bridges - add bridges attached to an encoder
1219  * @state: atomic state
1220  * @encoder: DRM encoder
1221  *
1222  * This function adds all bridges attached to @encoder. This is needed to add
1223  * bridge states to @state and make them available when
1224  * &drm_bridge_funcs.atomic_check(), &drm_bridge_funcs.atomic_pre_enable(),
1225  * &drm_bridge_funcs.atomic_enable(),
1226  * &drm_bridge_funcs.atomic_disable_post_disable() are called.
1227  *
1228  * Returns:
1229  * 0 on success or can fail with -EDEADLK or -ENOMEM. When the error is EDEADLK
1230  * then the w/w mutex code has detected a deadlock and the entire atomic
1231  * sequence must be restarted. All other errors are fatal.
1232  */
1233 int
1234 drm_atomic_add_encoder_bridges(struct drm_atomic_state *state,
1235 			       struct drm_encoder *encoder)
1236 {
1237 	struct drm_bridge_state *bridge_state;
1238 	struct drm_bridge *bridge;
1239 
1240 	if (!encoder)
1241 		return 0;
1242 
1243 	drm_dbg_atomic(encoder->dev,
1244 		       "Adding all bridges for [encoder:%d:%s] to %p\n",
1245 		       encoder->base.id, encoder->name, state);
1246 
1247 	drm_for_each_bridge_in_chain(encoder, bridge) {
1248 		/* Skip bridges that don't implement the atomic state hooks. */
1249 		if (!bridge->funcs->atomic_duplicate_state)
1250 			continue;
1251 
1252 		bridge_state = drm_atomic_get_bridge_state(state, bridge);
1253 		if (IS_ERR(bridge_state))
1254 			return PTR_ERR(bridge_state);
1255 	}
1256 
1257 	return 0;
1258 }
1259 EXPORT_SYMBOL(drm_atomic_add_encoder_bridges);
1260 
1261 /**
1262  * drm_atomic_add_affected_connectors - add connectors for CRTC
1263  * @state: atomic state
1264  * @crtc: DRM CRTC
1265  *
1266  * This function walks the current configuration and adds all connectors
1267  * currently using @crtc to the atomic configuration @state. Note that this
1268  * function must acquire the connection mutex. This can potentially cause
1269  * unneeded serialization if the update is just for the planes on one CRTC. Hence
1270  * drivers and helpers should only call this when really needed (e.g. when a
1271  * full modeset needs to happen due to some change).
1272  *
1273  * Returns:
1274  * 0 on success or can fail with -EDEADLK or -ENOMEM. When the error is EDEADLK
1275  * then the w/w mutex code has detected a deadlock and the entire atomic
1276  * sequence must be restarted. All other errors are fatal.
1277  */
1278 int
1279 drm_atomic_add_affected_connectors(struct drm_atomic_state *state,
1280 				   struct drm_crtc *crtc)
1281 {
1282 	struct drm_mode_config *config = &state->dev->mode_config;
1283 	struct drm_connector *connector;
1284 	struct drm_connector_state *conn_state;
1285 	struct drm_connector_list_iter conn_iter;
1286 	struct drm_crtc_state *crtc_state;
1287 	int ret;
1288 
1289 	crtc_state = drm_atomic_get_crtc_state(state, crtc);
1290 	if (IS_ERR(crtc_state))
1291 		return PTR_ERR(crtc_state);
1292 
1293 	ret = drm_modeset_lock(&config->connection_mutex, state->acquire_ctx);
1294 	if (ret)
1295 		return ret;
1296 
1297 	drm_dbg_atomic(crtc->dev,
1298 		       "Adding all current connectors for [CRTC:%d:%s] to %p\n",
1299 		       crtc->base.id, crtc->name, state);
1300 
1301 	/*
1302 	 * Changed connectors are already in @state, so only need to look
1303 	 * at the connector_mask in crtc_state.
1304 	 */
1305 	drm_connector_list_iter_begin(state->dev, &conn_iter);
1306 	drm_for_each_connector_iter(connector, &conn_iter) {
1307 		if (!(crtc_state->connector_mask & drm_connector_mask(connector)))
1308 			continue;
1309 
1310 		conn_state = drm_atomic_get_connector_state(state, connector);
1311 		if (IS_ERR(conn_state)) {
1312 			drm_connector_list_iter_end(&conn_iter);
1313 			return PTR_ERR(conn_state);
1314 		}
1315 	}
1316 	drm_connector_list_iter_end(&conn_iter);
1317 
1318 	return 0;
1319 }
1320 EXPORT_SYMBOL(drm_atomic_add_affected_connectors);
1321 
1322 /**
1323  * drm_atomic_add_affected_planes - add planes for CRTC
1324  * @state: atomic state
1325  * @crtc: DRM CRTC
1326  *
1327  * This function walks the current configuration and adds all planes
1328  * currently used by @crtc to the atomic configuration @state. This is useful
1329  * when an atomic commit also needs to check all currently enabled plane on
1330  * @crtc, e.g. when changing the mode. It's also useful when re-enabling a CRTC
1331  * to avoid special code to force-enable all planes.
1332  *
1333  * Since acquiring a plane state will always also acquire the w/w mutex of the
1334  * current CRTC for that plane (if there is any) adding all the plane states for
1335  * a CRTC will not reduce parallelism of atomic updates.
1336  *
1337  * Returns:
1338  * 0 on success or can fail with -EDEADLK or -ENOMEM. When the error is EDEADLK
1339  * then the w/w mutex code has detected a deadlock and the entire atomic
1340  * sequence must be restarted. All other errors are fatal.
1341  */
1342 int
1343 drm_atomic_add_affected_planes(struct drm_atomic_state *state,
1344 			       struct drm_crtc *crtc)
1345 {
1346 	const struct drm_crtc_state *old_crtc_state =
1347 		drm_atomic_get_old_crtc_state(state, crtc);
1348 	struct drm_plane *plane;
1349 
1350 	WARN_ON(!drm_atomic_get_new_crtc_state(state, crtc));
1351 
1352 	drm_dbg_atomic(crtc->dev,
1353 		       "Adding all current planes for [CRTC:%d:%s] to %p\n",
1354 		       crtc->base.id, crtc->name, state);
1355 
1356 	drm_for_each_plane_mask(plane, state->dev, old_crtc_state->plane_mask) {
1357 		struct drm_plane_state *plane_state =
1358 			drm_atomic_get_plane_state(state, plane);
1359 
1360 		if (IS_ERR(plane_state))
1361 			return PTR_ERR(plane_state);
1362 	}
1363 	return 0;
1364 }
1365 EXPORT_SYMBOL(drm_atomic_add_affected_planes);
1366 
1367 /**
1368  * drm_atomic_check_only - check whether a given config would work
1369  * @state: atomic configuration to check
1370  *
1371  * Note that this function can return -EDEADLK if the driver needed to acquire
1372  * more locks but encountered a deadlock. The caller must then do the usual w/w
1373  * backoff dance and restart. All other errors are fatal.
1374  *
1375  * Returns:
1376  * 0 on success, negative error code on failure.
1377  */
1378 int drm_atomic_check_only(struct drm_atomic_state *state)
1379 {
1380 	struct drm_device *dev = state->dev;
1381 	struct drm_mode_config *config = &dev->mode_config;
1382 	struct drm_plane *plane;
1383 	struct drm_plane_state *old_plane_state;
1384 	struct drm_plane_state *new_plane_state;
1385 	struct drm_crtc *crtc;
1386 	struct drm_crtc_state *old_crtc_state;
1387 	struct drm_crtc_state *new_crtc_state;
1388 	struct drm_connector *conn;
1389 	struct drm_connector_state *conn_state;
1390 	unsigned int requested_crtc = 0;
1391 	unsigned int affected_crtc = 0;
1392 	int i, ret = 0;
1393 
1394 	drm_dbg_atomic(dev, "checking %p\n", state);
1395 
1396 	for_each_new_crtc_in_state(state, crtc, new_crtc_state, i) {
1397 		if (new_crtc_state->enable)
1398 			requested_crtc |= drm_crtc_mask(crtc);
1399 	}
1400 
1401 	for_each_oldnew_plane_in_state(state, plane, old_plane_state, new_plane_state, i) {
1402 		ret = drm_atomic_plane_check(old_plane_state, new_plane_state);
1403 		if (ret) {
1404 			drm_dbg_atomic(dev, "[PLANE:%d:%s] atomic core check failed\n",
1405 				       plane->base.id, plane->name);
1406 			return ret;
1407 		}
1408 	}
1409 
1410 	for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) {
1411 		ret = drm_atomic_crtc_check(old_crtc_state, new_crtc_state);
1412 		if (ret) {
1413 			drm_dbg_atomic(dev, "[CRTC:%d:%s] atomic core check failed\n",
1414 				       crtc->base.id, crtc->name);
1415 			return ret;
1416 		}
1417 	}
1418 
1419 	for_each_new_connector_in_state(state, conn, conn_state, i) {
1420 		ret = drm_atomic_connector_check(conn, conn_state);
1421 		if (ret) {
1422 			drm_dbg_atomic(dev, "[CONNECTOR:%d:%s] atomic core check failed\n",
1423 				       conn->base.id, conn->name);
1424 			return ret;
1425 		}
1426 	}
1427 
1428 	if (config->funcs->atomic_check) {
1429 		ret = config->funcs->atomic_check(state->dev, state);
1430 
1431 		if (ret) {
1432 			drm_dbg_atomic(dev, "atomic driver check for %p failed: %d\n",
1433 				       state, ret);
1434 			return ret;
1435 		}
1436 	}
1437 
1438 	if (!state->allow_modeset) {
1439 		for_each_new_crtc_in_state(state, crtc, new_crtc_state, i) {
1440 			if (drm_atomic_crtc_needs_modeset(new_crtc_state)) {
1441 				drm_dbg_atomic(dev, "[CRTC:%d:%s] requires full modeset\n",
1442 					       crtc->base.id, crtc->name);
1443 				return -EINVAL;
1444 			}
1445 		}
1446 	}
1447 
1448 	for_each_new_crtc_in_state(state, crtc, new_crtc_state, i) {
1449 		if (new_crtc_state->enable)
1450 			affected_crtc |= drm_crtc_mask(crtc);
1451 	}
1452 
1453 	/*
1454 	 * For commits that allow modesets drivers can add other CRTCs to the
1455 	 * atomic commit, e.g. when they need to reallocate global resources.
1456 	 * This can cause spurious EBUSY, which robs compositors of a very
1457 	 * effective sanity check for their drawing loop. Therefor only allow
1458 	 * drivers to add unrelated CRTC states for modeset commits.
1459 	 *
1460 	 * FIXME: Should add affected_crtc mask to the ATOMIC IOCTL as an output
1461 	 * so compositors know what's going on.
1462 	 */
1463 	if (affected_crtc != requested_crtc) {
1464 		drm_dbg_atomic(dev,
1465 			       "driver added CRTC to commit: requested 0x%x, affected 0x%0x\n",
1466 			       requested_crtc, affected_crtc);
1467 		WARN(!state->allow_modeset, "adding CRTC not allowed without modesets: requested 0x%x, affected 0x%0x\n",
1468 		     requested_crtc, affected_crtc);
1469 	}
1470 
1471 	return 0;
1472 }
1473 EXPORT_SYMBOL(drm_atomic_check_only);
1474 
1475 /**
1476  * drm_atomic_commit - commit configuration atomically
1477  * @state: atomic configuration to check
1478  *
1479  * Note that this function can return -EDEADLK if the driver needed to acquire
1480  * more locks but encountered a deadlock. The caller must then do the usual w/w
1481  * backoff dance and restart. All other errors are fatal.
1482  *
1483  * This function will take its own reference on @state.
1484  * Callers should always release their reference with drm_atomic_state_put().
1485  *
1486  * Returns:
1487  * 0 on success, negative error code on failure.
1488  */
1489 int drm_atomic_commit(struct drm_atomic_state *state)
1490 {
1491 	struct drm_mode_config *config = &state->dev->mode_config;
1492 	struct drm_printer p = drm_info_printer(state->dev->dev);
1493 	int ret;
1494 
1495 	if (drm_debug_enabled(DRM_UT_STATE))
1496 		drm_atomic_print_new_state(state, &p);
1497 
1498 	ret = drm_atomic_check_only(state);
1499 	if (ret)
1500 		return ret;
1501 
1502 	drm_dbg_atomic(state->dev, "committing %p\n", state);
1503 
1504 	return config->funcs->atomic_commit(state->dev, state, false);
1505 }
1506 EXPORT_SYMBOL(drm_atomic_commit);
1507 
1508 /**
1509  * drm_atomic_nonblocking_commit - atomic nonblocking commit
1510  * @state: atomic configuration to check
1511  *
1512  * Note that this function can return -EDEADLK if the driver needed to acquire
1513  * more locks but encountered a deadlock. The caller must then do the usual w/w
1514  * backoff dance and restart. All other errors are fatal.
1515  *
1516  * This function will take its own reference on @state.
1517  * Callers should always release their reference with drm_atomic_state_put().
1518  *
1519  * Returns:
1520  * 0 on success, negative error code on failure.
1521  */
1522 int drm_atomic_nonblocking_commit(struct drm_atomic_state *state)
1523 {
1524 	struct drm_mode_config *config = &state->dev->mode_config;
1525 	int ret;
1526 
1527 	ret = drm_atomic_check_only(state);
1528 	if (ret)
1529 		return ret;
1530 
1531 	drm_dbg_atomic(state->dev, "committing %p nonblocking\n", state);
1532 
1533 	return config->funcs->atomic_commit(state->dev, state, true);
1534 }
1535 EXPORT_SYMBOL(drm_atomic_nonblocking_commit);
1536 
1537 /* just used from drm-client and atomic-helper: */
1538 int __drm_atomic_helper_disable_plane(struct drm_plane *plane,
1539 				      struct drm_plane_state *plane_state)
1540 {
1541 	int ret;
1542 
1543 	ret = drm_atomic_set_crtc_for_plane(plane_state, NULL);
1544 	if (ret != 0)
1545 		return ret;
1546 
1547 	drm_atomic_set_fb_for_plane(plane_state, NULL);
1548 	plane_state->crtc_x = 0;
1549 	plane_state->crtc_y = 0;
1550 	plane_state->crtc_w = 0;
1551 	plane_state->crtc_h = 0;
1552 	plane_state->src_x = 0;
1553 	plane_state->src_y = 0;
1554 	plane_state->src_w = 0;
1555 	plane_state->src_h = 0;
1556 
1557 	return 0;
1558 }
1559 EXPORT_SYMBOL(__drm_atomic_helper_disable_plane);
1560 
1561 static int update_output_state(struct drm_atomic_state *state,
1562 			       struct drm_mode_set *set)
1563 {
1564 	struct drm_device *dev = set->crtc->dev;
1565 	struct drm_crtc *crtc;
1566 	struct drm_crtc_state *new_crtc_state;
1567 	struct drm_connector *connector;
1568 	struct drm_connector_state *new_conn_state;
1569 	int ret, i;
1570 
1571 	ret = drm_modeset_lock(&dev->mode_config.connection_mutex,
1572 			       state->acquire_ctx);
1573 	if (ret)
1574 		return ret;
1575 
1576 	/* First disable all connectors on the target crtc. */
1577 	ret = drm_atomic_add_affected_connectors(state, set->crtc);
1578 	if (ret)
1579 		return ret;
1580 
1581 	for_each_new_connector_in_state(state, connector, new_conn_state, i) {
1582 		if (new_conn_state->crtc == set->crtc) {
1583 			ret = drm_atomic_set_crtc_for_connector(new_conn_state,
1584 								NULL);
1585 			if (ret)
1586 				return ret;
1587 
1588 			/* Make sure legacy setCrtc always re-trains */
1589 			new_conn_state->link_status = DRM_LINK_STATUS_GOOD;
1590 		}
1591 	}
1592 
1593 	/* Then set all connectors from set->connectors on the target crtc */
1594 	for (i = 0; i < set->num_connectors; i++) {
1595 		new_conn_state = drm_atomic_get_connector_state(state,
1596 								set->connectors[i]);
1597 		if (IS_ERR(new_conn_state))
1598 			return PTR_ERR(new_conn_state);
1599 
1600 		ret = drm_atomic_set_crtc_for_connector(new_conn_state,
1601 							set->crtc);
1602 		if (ret)
1603 			return ret;
1604 	}
1605 
1606 	for_each_new_crtc_in_state(state, crtc, new_crtc_state, i) {
1607 		/*
1608 		 * Don't update ->enable for the CRTC in the set_config request,
1609 		 * since a mismatch would indicate a bug in the upper layers.
1610 		 * The actual modeset code later on will catch any
1611 		 * inconsistencies here.
1612 		 */
1613 		if (crtc == set->crtc)
1614 			continue;
1615 
1616 		if (!new_crtc_state->connector_mask) {
1617 			ret = drm_atomic_set_mode_prop_for_crtc(new_crtc_state,
1618 								NULL);
1619 			if (ret < 0)
1620 				return ret;
1621 
1622 			new_crtc_state->active = false;
1623 		}
1624 	}
1625 
1626 	return 0;
1627 }
1628 
1629 /* just used from drm-client and atomic-helper: */
1630 int __drm_atomic_helper_set_config(struct drm_mode_set *set,
1631 				   struct drm_atomic_state *state)
1632 {
1633 	struct drm_crtc_state *crtc_state;
1634 	struct drm_plane_state *primary_state;
1635 	struct drm_crtc *crtc = set->crtc;
1636 	int hdisplay, vdisplay;
1637 	int ret;
1638 
1639 	crtc_state = drm_atomic_get_crtc_state(state, crtc);
1640 	if (IS_ERR(crtc_state))
1641 		return PTR_ERR(crtc_state);
1642 
1643 	primary_state = drm_atomic_get_plane_state(state, crtc->primary);
1644 	if (IS_ERR(primary_state))
1645 		return PTR_ERR(primary_state);
1646 
1647 	if (!set->mode) {
1648 		WARN_ON(set->fb);
1649 		WARN_ON(set->num_connectors);
1650 
1651 		ret = drm_atomic_set_mode_for_crtc(crtc_state, NULL);
1652 		if (ret != 0)
1653 			return ret;
1654 
1655 		crtc_state->active = false;
1656 
1657 		ret = drm_atomic_set_crtc_for_plane(primary_state, NULL);
1658 		if (ret != 0)
1659 			return ret;
1660 
1661 		drm_atomic_set_fb_for_plane(primary_state, NULL);
1662 
1663 		goto commit;
1664 	}
1665 
1666 	WARN_ON(!set->fb);
1667 	WARN_ON(!set->num_connectors);
1668 
1669 	ret = drm_atomic_set_mode_for_crtc(crtc_state, set->mode);
1670 	if (ret != 0)
1671 		return ret;
1672 
1673 	crtc_state->active = true;
1674 
1675 	ret = drm_atomic_set_crtc_for_plane(primary_state, crtc);
1676 	if (ret != 0)
1677 		return ret;
1678 
1679 	drm_mode_get_hv_timing(set->mode, &hdisplay, &vdisplay);
1680 
1681 	drm_atomic_set_fb_for_plane(primary_state, set->fb);
1682 	primary_state->crtc_x = 0;
1683 	primary_state->crtc_y = 0;
1684 	primary_state->crtc_w = hdisplay;
1685 	primary_state->crtc_h = vdisplay;
1686 	primary_state->src_x = set->x << 16;
1687 	primary_state->src_y = set->y << 16;
1688 	if (drm_rotation_90_or_270(primary_state->rotation)) {
1689 		primary_state->src_w = vdisplay << 16;
1690 		primary_state->src_h = hdisplay << 16;
1691 	} else {
1692 		primary_state->src_w = hdisplay << 16;
1693 		primary_state->src_h = vdisplay << 16;
1694 	}
1695 
1696 commit:
1697 	ret = update_output_state(state, set);
1698 	if (ret)
1699 		return ret;
1700 
1701 	return 0;
1702 }
1703 EXPORT_SYMBOL(__drm_atomic_helper_set_config);
1704 
1705 static void drm_atomic_private_obj_print_state(struct drm_printer *p,
1706 					       const struct drm_private_state *state)
1707 {
1708 	struct drm_private_obj *obj = state->obj;
1709 
1710 	if (obj->funcs->atomic_print_state)
1711 		obj->funcs->atomic_print_state(p, state);
1712 }
1713 
1714 /**
1715  * drm_atomic_print_new_state - prints drm atomic state
1716  * @state: atomic configuration to check
1717  * @p: drm printer
1718  *
1719  * This functions prints the drm atomic state snapshot using the drm printer
1720  * which is passed to it. This snapshot can be used for debugging purposes.
1721  *
1722  * Note that this function looks into the new state objects and hence its not
1723  * safe to be used after the call to drm_atomic_helper_commit_hw_done().
1724  */
1725 void drm_atomic_print_new_state(const struct drm_atomic_state *state,
1726 		struct drm_printer *p)
1727 {
1728 	struct drm_plane *plane;
1729 	struct drm_plane_state *plane_state;
1730 	struct drm_crtc *crtc;
1731 	struct drm_crtc_state *crtc_state;
1732 	struct drm_connector *connector;
1733 	struct drm_connector_state *connector_state;
1734 	struct drm_private_obj *obj;
1735 	struct drm_private_state *obj_state;
1736 	int i;
1737 
1738 	if (!p) {
1739 		drm_err(state->dev, "invalid drm printer\n");
1740 		return;
1741 	}
1742 
1743 	drm_dbg_atomic(state->dev, "checking %p\n", state);
1744 
1745 	for_each_new_plane_in_state(state, plane, plane_state, i)
1746 		drm_atomic_plane_print_state(p, plane_state);
1747 
1748 	for_each_new_crtc_in_state(state, crtc, crtc_state, i)
1749 		drm_atomic_crtc_print_state(p, crtc_state);
1750 
1751 	for_each_new_connector_in_state(state, connector, connector_state, i)
1752 		drm_atomic_connector_print_state(p, connector_state);
1753 
1754 	for_each_new_private_obj_in_state(state, obj, obj_state, i)
1755 		drm_atomic_private_obj_print_state(p, obj_state);
1756 }
1757 EXPORT_SYMBOL(drm_atomic_print_new_state);
1758 
1759 static void __drm_state_dump(struct drm_device *dev, struct drm_printer *p,
1760 			     bool take_locks)
1761 {
1762 	struct drm_mode_config *config = &dev->mode_config;
1763 	struct drm_plane *plane;
1764 	struct drm_crtc *crtc;
1765 	struct drm_connector *connector;
1766 	struct drm_connector_list_iter conn_iter;
1767 
1768 	if (!drm_drv_uses_atomic_modeset(dev))
1769 		return;
1770 
1771 	list_for_each_entry(plane, &config->plane_list, head) {
1772 		if (take_locks)
1773 			drm_modeset_lock(&plane->mutex, NULL);
1774 		drm_atomic_plane_print_state(p, plane->state);
1775 		if (take_locks)
1776 			drm_modeset_unlock(&plane->mutex);
1777 	}
1778 
1779 	list_for_each_entry(crtc, &config->crtc_list, head) {
1780 		if (take_locks)
1781 			drm_modeset_lock(&crtc->mutex, NULL);
1782 		drm_atomic_crtc_print_state(p, crtc->state);
1783 		if (take_locks)
1784 			drm_modeset_unlock(&crtc->mutex);
1785 	}
1786 
1787 	drm_connector_list_iter_begin(dev, &conn_iter);
1788 	if (take_locks)
1789 		drm_modeset_lock(&dev->mode_config.connection_mutex, NULL);
1790 	drm_for_each_connector_iter(connector, &conn_iter)
1791 		drm_atomic_connector_print_state(p, connector->state);
1792 	if (take_locks)
1793 		drm_modeset_unlock(&dev->mode_config.connection_mutex);
1794 	drm_connector_list_iter_end(&conn_iter);
1795 }
1796 
1797 /**
1798  * drm_state_dump - dump entire device atomic state
1799  * @dev: the drm device
1800  * @p: where to print the state to
1801  *
1802  * Just for debugging.  Drivers might want an option to dump state
1803  * to dmesg in case of error irq's.  (Hint, you probably want to
1804  * ratelimit this!)
1805  *
1806  * The caller must wrap this drm_modeset_lock_all_ctx() and
1807  * drm_modeset_drop_locks(). If this is called from error irq handler, it should
1808  * not be enabled by default - if you are debugging errors you might
1809  * not care that this is racey, but calling this without all modeset locks held
1810  * is inherently unsafe.
1811  */
1812 void drm_state_dump(struct drm_device *dev, struct drm_printer *p)
1813 {
1814 	__drm_state_dump(dev, p, false);
1815 }
1816 EXPORT_SYMBOL(drm_state_dump);
1817 
1818 #ifdef CONFIG_DEBUG_FS
1819 static int drm_state_info(struct seq_file *m, void *data)
1820 {
1821 	struct drm_debugfs_entry *entry = m->private;
1822 	struct drm_device *dev = entry->dev;
1823 	struct drm_printer p = drm_seq_file_printer(m);
1824 
1825 	__drm_state_dump(dev, &p, true);
1826 
1827 	return 0;
1828 }
1829 
1830 /* any use in debugfs files to dump individual planes/crtc/etc? */
1831 static const struct drm_debugfs_info drm_atomic_debugfs_list[] = {
1832 	{"state", drm_state_info, 0},
1833 };
1834 
1835 void drm_atomic_debugfs_init(struct drm_minor *minor)
1836 {
1837 	drm_debugfs_add_files(minor->dev, drm_atomic_debugfs_list,
1838 			      ARRAY_SIZE(drm_atomic_debugfs_list));
1839 }
1840 #endif
1841