1 /*
2  * Copyright 2012-2021 Advanced Micro Devices, Inc.
3  *
4  * Permission is hereby granted, free of charge, to any person obtaining a
5  * copy of this software and associated documentation files (the "Software"),
6  * to deal in the Software without restriction, including without limitation
7  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
8  * and/or sell copies of the Software, and to permit persons to whom the
9  * Software is furnished to do so, subject to the following conditions:
10  *
11  * The above copyright notice and this permission notice shall be included in
12  * all copies or substantial portions of the Software.
13  *
14  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
15  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
16  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
17  * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
18  * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
19  * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
20  * OTHER DEALINGS IN THE SOFTWARE.
21  *
22  * Authors: AMD
23  *
24  */
25 
26 #include "dcn20_hubp.h"
27 
28 #include "dm_services.h"
29 #include "dce_calcs.h"
30 #include "reg_helper.h"
31 #include "basics/conversion.h"
32 
33 #define DC_LOGGER_INIT(logger)
34 
35 #define REG(reg)\
36 	hubp2->hubp_regs->reg
37 
38 #define CTX \
39 	hubp2->base.ctx
40 
41 #undef FN
42 #define FN(reg_name, field_name) \
43 	hubp2->hubp_shift->field_name, hubp2->hubp_mask->field_name
44 
45 void hubp2_set_vm_system_aperture_settings(struct hubp *hubp,
46 		struct vm_system_aperture_param *apt)
47 {
48 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
49 
50 	PHYSICAL_ADDRESS_LOC mc_vm_apt_default;
51 	PHYSICAL_ADDRESS_LOC mc_vm_apt_low;
52 	PHYSICAL_ADDRESS_LOC mc_vm_apt_high;
53 
54 	// The format of default addr is 48:12 of the 48 bit addr
55 	mc_vm_apt_default.quad_part = apt->sys_default.quad_part >> 12;
56 
57 	// The format of high/low are 48:18 of the 48 bit addr
58 	mc_vm_apt_low.quad_part = apt->sys_low.quad_part >> 18;
59 	mc_vm_apt_high.quad_part = apt->sys_high.quad_part >> 18;
60 
61 	REG_UPDATE_2(DCN_VM_SYSTEM_APERTURE_DEFAULT_ADDR_MSB,
62 		DCN_VM_SYSTEM_APERTURE_DEFAULT_SYSTEM, 1, /* 1 = system physical memory */
63 		DCN_VM_SYSTEM_APERTURE_DEFAULT_ADDR_MSB, mc_vm_apt_default.high_part);
64 
65 	REG_SET(DCN_VM_SYSTEM_APERTURE_DEFAULT_ADDR_LSB, 0,
66 			DCN_VM_SYSTEM_APERTURE_DEFAULT_ADDR_LSB, mc_vm_apt_default.low_part);
67 
68 	REG_SET(DCN_VM_SYSTEM_APERTURE_LOW_ADDR, 0,
69 			MC_VM_SYSTEM_APERTURE_LOW_ADDR, mc_vm_apt_low.quad_part);
70 
71 	REG_SET(DCN_VM_SYSTEM_APERTURE_HIGH_ADDR, 0,
72 			MC_VM_SYSTEM_APERTURE_HIGH_ADDR, mc_vm_apt_high.quad_part);
73 
74 	REG_SET_2(DCN_VM_MX_L1_TLB_CNTL, 0,
75 			ENABLE_L1_TLB, 1,
76 			SYSTEM_ACCESS_MODE, 0x3);
77 }
78 
79 void hubp2_program_deadline(
80 		struct hubp *hubp,
81 		struct _vcs_dpi_display_dlg_regs_st *dlg_attr,
82 		struct _vcs_dpi_display_ttu_regs_st *ttu_attr)
83 {
84 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
85 
86 	/* DLG - Per hubp */
87 	REG_SET_2(BLANK_OFFSET_0, 0,
88 		REFCYC_H_BLANK_END, dlg_attr->refcyc_h_blank_end,
89 		DLG_V_BLANK_END, dlg_attr->dlg_vblank_end);
90 
91 	REG_SET(BLANK_OFFSET_1, 0,
92 		MIN_DST_Y_NEXT_START, dlg_attr->min_dst_y_next_start);
93 
94 	REG_SET(DST_DIMENSIONS, 0,
95 		REFCYC_PER_HTOTAL, dlg_attr->refcyc_per_htotal);
96 
97 	REG_SET_2(DST_AFTER_SCALER, 0,
98 		REFCYC_X_AFTER_SCALER, dlg_attr->refcyc_x_after_scaler,
99 		DST_Y_AFTER_SCALER, dlg_attr->dst_y_after_scaler);
100 
101 	REG_SET(REF_FREQ_TO_PIX_FREQ, 0,
102 		REF_FREQ_TO_PIX_FREQ, dlg_attr->ref_freq_to_pix_freq);
103 
104 	/* DLG - Per luma/chroma */
105 	REG_SET(VBLANK_PARAMETERS_1, 0,
106 		REFCYC_PER_PTE_GROUP_VBLANK_L, dlg_attr->refcyc_per_pte_group_vblank_l);
107 
108 	if (REG(NOM_PARAMETERS_0))
109 		REG_SET(NOM_PARAMETERS_0, 0,
110 			DST_Y_PER_PTE_ROW_NOM_L, dlg_attr->dst_y_per_pte_row_nom_l);
111 
112 	if (REG(NOM_PARAMETERS_1))
113 		REG_SET(NOM_PARAMETERS_1, 0,
114 			REFCYC_PER_PTE_GROUP_NOM_L, dlg_attr->refcyc_per_pte_group_nom_l);
115 
116 	REG_SET(NOM_PARAMETERS_4, 0,
117 		DST_Y_PER_META_ROW_NOM_L, dlg_attr->dst_y_per_meta_row_nom_l);
118 
119 	REG_SET(NOM_PARAMETERS_5, 0,
120 		REFCYC_PER_META_CHUNK_NOM_L, dlg_attr->refcyc_per_meta_chunk_nom_l);
121 
122 	REG_SET_2(PER_LINE_DELIVERY, 0,
123 		REFCYC_PER_LINE_DELIVERY_L, dlg_attr->refcyc_per_line_delivery_l,
124 		REFCYC_PER_LINE_DELIVERY_C, dlg_attr->refcyc_per_line_delivery_c);
125 
126 	REG_SET(VBLANK_PARAMETERS_2, 0,
127 		REFCYC_PER_PTE_GROUP_VBLANK_C, dlg_attr->refcyc_per_pte_group_vblank_c);
128 
129 	if (REG(NOM_PARAMETERS_2))
130 		REG_SET(NOM_PARAMETERS_2, 0,
131 			DST_Y_PER_PTE_ROW_NOM_C, dlg_attr->dst_y_per_pte_row_nom_c);
132 
133 	if (REG(NOM_PARAMETERS_3))
134 		REG_SET(NOM_PARAMETERS_3, 0,
135 			REFCYC_PER_PTE_GROUP_NOM_C, dlg_attr->refcyc_per_pte_group_nom_c);
136 
137 	REG_SET(NOM_PARAMETERS_6, 0,
138 		DST_Y_PER_META_ROW_NOM_C, dlg_attr->dst_y_per_meta_row_nom_c);
139 
140 	REG_SET(NOM_PARAMETERS_7, 0,
141 		REFCYC_PER_META_CHUNK_NOM_C, dlg_attr->refcyc_per_meta_chunk_nom_c);
142 
143 	/* TTU - per hubp */
144 	REG_SET_2(DCN_TTU_QOS_WM, 0,
145 		QoS_LEVEL_LOW_WM, ttu_attr->qos_level_low_wm,
146 		QoS_LEVEL_HIGH_WM, ttu_attr->qos_level_high_wm);
147 
148 	/* TTU - per luma/chroma */
149 	/* Assumed surf0 is luma and 1 is chroma */
150 
151 	REG_SET_3(DCN_SURF0_TTU_CNTL0, 0,
152 		REFCYC_PER_REQ_DELIVERY, ttu_attr->refcyc_per_req_delivery_l,
153 		QoS_LEVEL_FIXED, ttu_attr->qos_level_fixed_l,
154 		QoS_RAMP_DISABLE, ttu_attr->qos_ramp_disable_l);
155 
156 	REG_SET_3(DCN_SURF1_TTU_CNTL0, 0,
157 		REFCYC_PER_REQ_DELIVERY, ttu_attr->refcyc_per_req_delivery_c,
158 		QoS_LEVEL_FIXED, ttu_attr->qos_level_fixed_c,
159 		QoS_RAMP_DISABLE, ttu_attr->qos_ramp_disable_c);
160 
161 	REG_SET_3(DCN_CUR0_TTU_CNTL0, 0,
162 		REFCYC_PER_REQ_DELIVERY, ttu_attr->refcyc_per_req_delivery_cur0,
163 		QoS_LEVEL_FIXED, ttu_attr->qos_level_fixed_cur0,
164 		QoS_RAMP_DISABLE, ttu_attr->qos_ramp_disable_cur0);
165 
166 	REG_SET(FLIP_PARAMETERS_1, 0,
167 		REFCYC_PER_PTE_GROUP_FLIP_L, dlg_attr->refcyc_per_pte_group_flip_l);
168 }
169 
170 void hubp2_vready_at_or_After_vsync(struct hubp *hubp,
171 		struct _vcs_dpi_display_pipe_dest_params_st *pipe_dest)
172 {
173 	uint32_t value = 0;
174 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
175 	/* disable_dlg_test_mode Set 9th bit to 1 to disable "dv" mode */
176 	REG_WRITE(HUBPREQ_DEBUG_DB, 1 << 8);
177 	/*
178 	if (VSTARTUP_START - (VREADY_OFFSET+VUPDATE_WIDTH+VUPDATE_OFFSET)/htotal)
179 	<= OTG_V_BLANK_END
180 		Set HUBP_VREADY_AT_OR_AFTER_VSYNC = 1
181 	else
182 		Set HUBP_VREADY_AT_OR_AFTER_VSYNC = 0
183 	*/
184 	if (pipe_dest->htotal != 0) {
185 		if ((pipe_dest->vstartup_start - (pipe_dest->vready_offset+pipe_dest->vupdate_width
186 			+ pipe_dest->vupdate_offset) / pipe_dest->htotal) <= pipe_dest->vblank_end) {
187 			value = 1;
188 		} else
189 			value = 0;
190 	}
191 
192 	REG_UPDATE(DCHUBP_CNTL, HUBP_VREADY_AT_OR_AFTER_VSYNC, value);
193 }
194 
195 void hubp2_program_requestor(
196 		struct hubp *hubp,
197 		struct _vcs_dpi_display_rq_regs_st *rq_regs)
198 {
199 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
200 
201 	REG_UPDATE(HUBPRET_CONTROL,
202 			DET_BUF_PLANE1_BASE_ADDRESS, rq_regs->plane1_base_address);
203 	REG_SET_4(DCN_EXPANSION_MODE, 0,
204 			DRQ_EXPANSION_MODE, rq_regs->drq_expansion_mode,
205 			PRQ_EXPANSION_MODE, rq_regs->prq_expansion_mode,
206 			MRQ_EXPANSION_MODE, rq_regs->mrq_expansion_mode,
207 			CRQ_EXPANSION_MODE, rq_regs->crq_expansion_mode);
208 	REG_SET_8(DCHUBP_REQ_SIZE_CONFIG, 0,
209 		CHUNK_SIZE, rq_regs->rq_regs_l.chunk_size,
210 		MIN_CHUNK_SIZE, rq_regs->rq_regs_l.min_chunk_size,
211 		META_CHUNK_SIZE, rq_regs->rq_regs_l.meta_chunk_size,
212 		MIN_META_CHUNK_SIZE, rq_regs->rq_regs_l.min_meta_chunk_size,
213 		DPTE_GROUP_SIZE, rq_regs->rq_regs_l.dpte_group_size,
214 		MPTE_GROUP_SIZE, rq_regs->rq_regs_l.mpte_group_size,
215 		SWATH_HEIGHT, rq_regs->rq_regs_l.swath_height,
216 		PTE_ROW_HEIGHT_LINEAR, rq_regs->rq_regs_l.pte_row_height_linear);
217 	REG_SET_8(DCHUBP_REQ_SIZE_CONFIG_C, 0,
218 		CHUNK_SIZE_C, rq_regs->rq_regs_c.chunk_size,
219 		MIN_CHUNK_SIZE_C, rq_regs->rq_regs_c.min_chunk_size,
220 		META_CHUNK_SIZE_C, rq_regs->rq_regs_c.meta_chunk_size,
221 		MIN_META_CHUNK_SIZE_C, rq_regs->rq_regs_c.min_meta_chunk_size,
222 		DPTE_GROUP_SIZE_C, rq_regs->rq_regs_c.dpte_group_size,
223 		MPTE_GROUP_SIZE_C, rq_regs->rq_regs_c.mpte_group_size,
224 		SWATH_HEIGHT_C, rq_regs->rq_regs_c.swath_height,
225 		PTE_ROW_HEIGHT_LINEAR_C, rq_regs->rq_regs_c.pte_row_height_linear);
226 }
227 
228 static void hubp2_setup(
229 		struct hubp *hubp,
230 		struct _vcs_dpi_display_dlg_regs_st *dlg_attr,
231 		struct _vcs_dpi_display_ttu_regs_st *ttu_attr,
232 		struct _vcs_dpi_display_rq_regs_st *rq_regs,
233 		struct _vcs_dpi_display_pipe_dest_params_st *pipe_dest)
234 {
235 	/* otg is locked when this func is called. Register are double buffered.
236 	 * disable the requestors is not needed
237 	 */
238 
239 	hubp2_vready_at_or_After_vsync(hubp, pipe_dest);
240 	hubp2_program_requestor(hubp, rq_regs);
241 	hubp2_program_deadline(hubp, dlg_attr, ttu_attr);
242 
243 }
244 
245 void hubp2_setup_interdependent(
246 		struct hubp *hubp,
247 		struct _vcs_dpi_display_dlg_regs_st *dlg_attr,
248 		struct _vcs_dpi_display_ttu_regs_st *ttu_attr)
249 {
250 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
251 
252 	REG_SET_2(PREFETCH_SETTINGS, 0,
253 			DST_Y_PREFETCH, dlg_attr->dst_y_prefetch,
254 			VRATIO_PREFETCH, dlg_attr->vratio_prefetch);
255 
256 	REG_SET(PREFETCH_SETTINGS_C, 0,
257 			VRATIO_PREFETCH_C, dlg_attr->vratio_prefetch_c);
258 
259 	REG_SET_2(VBLANK_PARAMETERS_0, 0,
260 		DST_Y_PER_VM_VBLANK, dlg_attr->dst_y_per_vm_vblank,
261 		DST_Y_PER_ROW_VBLANK, dlg_attr->dst_y_per_row_vblank);
262 
263 	REG_SET_2(FLIP_PARAMETERS_0, 0,
264 		DST_Y_PER_VM_FLIP, dlg_attr->dst_y_per_vm_flip,
265 		DST_Y_PER_ROW_FLIP, dlg_attr->dst_y_per_row_flip);
266 
267 	REG_SET(VBLANK_PARAMETERS_3, 0,
268 		REFCYC_PER_META_CHUNK_VBLANK_L, dlg_attr->refcyc_per_meta_chunk_vblank_l);
269 
270 	REG_SET(VBLANK_PARAMETERS_4, 0,
271 		REFCYC_PER_META_CHUNK_VBLANK_C, dlg_attr->refcyc_per_meta_chunk_vblank_c);
272 
273 	REG_SET(FLIP_PARAMETERS_2, 0,
274 		REFCYC_PER_META_CHUNK_FLIP_L, dlg_attr->refcyc_per_meta_chunk_flip_l);
275 
276 	REG_SET_2(PER_LINE_DELIVERY_PRE, 0,
277 		REFCYC_PER_LINE_DELIVERY_PRE_L, dlg_attr->refcyc_per_line_delivery_pre_l,
278 		REFCYC_PER_LINE_DELIVERY_PRE_C, dlg_attr->refcyc_per_line_delivery_pre_c);
279 
280 	REG_SET(DCN_SURF0_TTU_CNTL1, 0,
281 		REFCYC_PER_REQ_DELIVERY_PRE,
282 		ttu_attr->refcyc_per_req_delivery_pre_l);
283 	REG_SET(DCN_SURF1_TTU_CNTL1, 0,
284 		REFCYC_PER_REQ_DELIVERY_PRE,
285 		ttu_attr->refcyc_per_req_delivery_pre_c);
286 	REG_SET(DCN_CUR0_TTU_CNTL1, 0,
287 		REFCYC_PER_REQ_DELIVERY_PRE, ttu_attr->refcyc_per_req_delivery_pre_cur0);
288 	REG_SET(DCN_CUR1_TTU_CNTL1, 0,
289 		REFCYC_PER_REQ_DELIVERY_PRE, ttu_attr->refcyc_per_req_delivery_pre_cur1);
290 
291 	REG_SET_2(DCN_GLOBAL_TTU_CNTL, 0,
292 		MIN_TTU_VBLANK, ttu_attr->min_ttu_vblank,
293 		QoS_LEVEL_FLIP, ttu_attr->qos_level_flip);
294 }
295 
296 /* DCN2 (GFX10), the following GFX fields are deprecated. They can be set but they will not be used:
297  *	NUM_BANKS
298  *	NUM_SE
299  *	NUM_RB_PER_SE
300  *	RB_ALIGNED
301  * Other things can be defaulted, since they never change:
302  *	PIPE_ALIGNED = 0
303  *	META_LINEAR = 0
304  * In GFX10, only these apply:
305  *	PIPE_INTERLEAVE
306  *	NUM_PIPES
307  *	MAX_COMPRESSED_FRAGS
308  *	SW_MODE
309  */
310 static void hubp2_program_tiling(
311 	struct dcn20_hubp *hubp2,
312 	const union dc_tiling_info *info,
313 	const enum surface_pixel_format pixel_format)
314 {
315 	REG_UPDATE_3(DCSURF_ADDR_CONFIG,
316 			NUM_PIPES, log_2(info->gfx9.num_pipes),
317 			PIPE_INTERLEAVE, info->gfx9.pipe_interleave,
318 			MAX_COMPRESSED_FRAGS, log_2(info->gfx9.max_compressed_frags));
319 
320 	REG_UPDATE_4(DCSURF_TILING_CONFIG,
321 			SW_MODE, info->gfx9.swizzle,
322 			META_LINEAR, 0,
323 			RB_ALIGNED, 0,
324 			PIPE_ALIGNED, 0);
325 }
326 
327 void hubp2_program_size(
328 	struct hubp *hubp,
329 	enum surface_pixel_format format,
330 	const struct plane_size *plane_size,
331 	struct dc_plane_dcc_param *dcc)
332 {
333 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
334 	uint32_t pitch, meta_pitch, pitch_c, meta_pitch_c;
335 	bool use_pitch_c = false;
336 
337 	/* Program data and meta surface pitch (calculation from addrlib)
338 	 * 444 or 420 luma
339 	 */
340 	use_pitch_c = format >= SURFACE_PIXEL_FORMAT_VIDEO_BEGIN
341 		&& format < SURFACE_PIXEL_FORMAT_SUBSAMPLE_END;
342 	use_pitch_c = use_pitch_c
343 		|| (format == SURFACE_PIXEL_FORMAT_GRPH_RGBE_ALPHA);
344 	if (use_pitch_c) {
345 		ASSERT(plane_size->chroma_pitch != 0);
346 		/* Chroma pitch zero can cause system hang! */
347 
348 		pitch = plane_size->surface_pitch - 1;
349 		meta_pitch = dcc->meta_pitch - 1;
350 		pitch_c = plane_size->chroma_pitch - 1;
351 		meta_pitch_c = dcc->meta_pitch_c - 1;
352 	} else {
353 		pitch = plane_size->surface_pitch - 1;
354 		meta_pitch = dcc->meta_pitch - 1;
355 		pitch_c = 0;
356 		meta_pitch_c = 0;
357 	}
358 
359 	if (!dcc->enable) {
360 		meta_pitch = 0;
361 		meta_pitch_c = 0;
362 	}
363 
364 	REG_UPDATE_2(DCSURF_SURFACE_PITCH,
365 			PITCH, pitch, META_PITCH, meta_pitch);
366 
367 	use_pitch_c = format >= SURFACE_PIXEL_FORMAT_VIDEO_BEGIN;
368 	use_pitch_c = use_pitch_c
369 		|| (format == SURFACE_PIXEL_FORMAT_GRPH_RGBE_ALPHA);
370 	if (use_pitch_c)
371 		REG_UPDATE_2(DCSURF_SURFACE_PITCH_C,
372 			PITCH_C, pitch_c, META_PITCH_C, meta_pitch_c);
373 }
374 
375 void hubp2_program_rotation(
376 	struct hubp *hubp,
377 	enum dc_rotation_angle rotation,
378 	bool horizontal_mirror)
379 {
380 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
381 	uint32_t mirror;
382 
383 
384 	if (horizontal_mirror)
385 		mirror = 1;
386 	else
387 		mirror = 0;
388 
389 	/* Program rotation angle and horz mirror - no mirror */
390 	if (rotation == ROTATION_ANGLE_0)
391 		REG_UPDATE_2(DCSURF_SURFACE_CONFIG,
392 				ROTATION_ANGLE, 0,
393 				H_MIRROR_EN, mirror);
394 	else if (rotation == ROTATION_ANGLE_90)
395 		REG_UPDATE_2(DCSURF_SURFACE_CONFIG,
396 				ROTATION_ANGLE, 1,
397 				H_MIRROR_EN, mirror);
398 	else if (rotation == ROTATION_ANGLE_180)
399 		REG_UPDATE_2(DCSURF_SURFACE_CONFIG,
400 				ROTATION_ANGLE, 2,
401 				H_MIRROR_EN, mirror);
402 	else if (rotation == ROTATION_ANGLE_270)
403 		REG_UPDATE_2(DCSURF_SURFACE_CONFIG,
404 				ROTATION_ANGLE, 3,
405 				H_MIRROR_EN, mirror);
406 }
407 
408 void hubp2_dcc_control(struct hubp *hubp, bool enable,
409 		enum hubp_ind_block_size independent_64b_blks)
410 {
411 	uint32_t dcc_en = enable ? 1 : 0;
412 	uint32_t dcc_ind_64b_blk = independent_64b_blks ? 1 : 0;
413 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
414 
415 	REG_UPDATE_4(DCSURF_SURFACE_CONTROL,
416 			PRIMARY_SURFACE_DCC_EN, dcc_en,
417 			PRIMARY_SURFACE_DCC_IND_64B_BLK, dcc_ind_64b_blk,
418 			SECONDARY_SURFACE_DCC_EN, dcc_en,
419 			SECONDARY_SURFACE_DCC_IND_64B_BLK, dcc_ind_64b_blk);
420 }
421 
422 void hubp2_program_pixel_format(
423 	struct hubp *hubp,
424 	enum surface_pixel_format format)
425 {
426 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
427 	uint32_t red_bar = 3;
428 	uint32_t blue_bar = 2;
429 
430 	/* swap for ABGR format */
431 	if (format == SURFACE_PIXEL_FORMAT_GRPH_ABGR8888
432 			|| format == SURFACE_PIXEL_FORMAT_GRPH_ABGR2101010
433 			|| format == SURFACE_PIXEL_FORMAT_GRPH_ABGR2101010_XR_BIAS
434 			|| format == SURFACE_PIXEL_FORMAT_GRPH_ABGR16161616F) {
435 		red_bar = 2;
436 		blue_bar = 3;
437 	}
438 
439 	REG_UPDATE_2(HUBPRET_CONTROL,
440 			CROSSBAR_SRC_CB_B, blue_bar,
441 			CROSSBAR_SRC_CR_R, red_bar);
442 
443 	/* Mapping is same as ipp programming (cnvc) */
444 
445 	switch (format)	{
446 	case SURFACE_PIXEL_FORMAT_GRPH_ARGB1555:
447 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
448 				SURFACE_PIXEL_FORMAT, 1);
449 		break;
450 	case SURFACE_PIXEL_FORMAT_GRPH_RGB565:
451 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
452 				SURFACE_PIXEL_FORMAT, 3);
453 		break;
454 	case SURFACE_PIXEL_FORMAT_GRPH_ARGB8888:
455 	case SURFACE_PIXEL_FORMAT_GRPH_ABGR8888:
456 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
457 				SURFACE_PIXEL_FORMAT, 8);
458 		break;
459 	case SURFACE_PIXEL_FORMAT_GRPH_ARGB2101010:
460 	case SURFACE_PIXEL_FORMAT_GRPH_ABGR2101010:
461 	case SURFACE_PIXEL_FORMAT_GRPH_ABGR2101010_XR_BIAS:
462 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
463 				SURFACE_PIXEL_FORMAT, 10);
464 		break;
465 	case SURFACE_PIXEL_FORMAT_GRPH_ARGB16161616:
466 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
467 				SURFACE_PIXEL_FORMAT, 22);
468 		break;
469 	case SURFACE_PIXEL_FORMAT_GRPH_ARGB16161616F:
470 	case SURFACE_PIXEL_FORMAT_GRPH_ABGR16161616F:/*we use crossbar already*/
471 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
472 				SURFACE_PIXEL_FORMAT, 24);
473 		break;
474 
475 	case SURFACE_PIXEL_FORMAT_VIDEO_420_YCbCr:
476 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
477 				SURFACE_PIXEL_FORMAT, 65);
478 		break;
479 	case SURFACE_PIXEL_FORMAT_VIDEO_420_YCrCb:
480 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
481 				SURFACE_PIXEL_FORMAT, 64);
482 		break;
483 	case SURFACE_PIXEL_FORMAT_VIDEO_420_10bpc_YCbCr:
484 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
485 				SURFACE_PIXEL_FORMAT, 67);
486 		break;
487 	case SURFACE_PIXEL_FORMAT_VIDEO_420_10bpc_YCrCb:
488 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
489 				SURFACE_PIXEL_FORMAT, 66);
490 		break;
491 	case SURFACE_PIXEL_FORMAT_VIDEO_AYCrCb8888:
492 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
493 				SURFACE_PIXEL_FORMAT, 12);
494 		break;
495 	case SURFACE_PIXEL_FORMAT_GRPH_RGB111110_FIX:
496 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
497 				SURFACE_PIXEL_FORMAT, 112);
498 		break;
499 	case SURFACE_PIXEL_FORMAT_GRPH_BGR101111_FIX:
500 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
501 				SURFACE_PIXEL_FORMAT, 113);
502 		break;
503 	case SURFACE_PIXEL_FORMAT_VIDEO_ACrYCb2101010:
504 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
505 				SURFACE_PIXEL_FORMAT, 114);
506 		break;
507 	case SURFACE_PIXEL_FORMAT_GRPH_RGB111110_FLOAT:
508 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
509 				SURFACE_PIXEL_FORMAT, 118);
510 		break;
511 	case SURFACE_PIXEL_FORMAT_GRPH_BGR101111_FLOAT:
512 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
513 				SURFACE_PIXEL_FORMAT, 119);
514 		break;
515 	case SURFACE_PIXEL_FORMAT_GRPH_RGBE:
516 		REG_UPDATE_2(DCSURF_SURFACE_CONFIG,
517 				SURFACE_PIXEL_FORMAT, 116,
518 				ALPHA_PLANE_EN, 0);
519 		break;
520 	case SURFACE_PIXEL_FORMAT_GRPH_RGBE_ALPHA:
521 		REG_UPDATE_2(DCSURF_SURFACE_CONFIG,
522 				SURFACE_PIXEL_FORMAT, 116,
523 				ALPHA_PLANE_EN, 1);
524 		break;
525 	default:
526 		BREAK_TO_DEBUGGER();
527 		break;
528 	}
529 
530 	/* don't see the need of program the xbar in DCN 1.0 */
531 }
532 
533 void hubp2_program_surface_config(
534 	struct hubp *hubp,
535 	enum surface_pixel_format format,
536 	union dc_tiling_info *tiling_info,
537 	struct plane_size *plane_size,
538 	enum dc_rotation_angle rotation,
539 	struct dc_plane_dcc_param *dcc,
540 	bool horizontal_mirror,
541 	unsigned int compat_level)
542 {
543 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
544 
545 	hubp2_dcc_control(hubp, dcc->enable, dcc->independent_64b_blks);
546 	hubp2_program_tiling(hubp2, tiling_info, format);
547 	hubp2_program_size(hubp, format, plane_size, dcc);
548 	hubp2_program_rotation(hubp, rotation, horizontal_mirror);
549 	hubp2_program_pixel_format(hubp, format);
550 }
551 
552 enum cursor_lines_per_chunk hubp2_get_lines_per_chunk(
553 	unsigned int cursor_width,
554 	enum dc_cursor_color_format cursor_mode)
555 {
556 	enum cursor_lines_per_chunk line_per_chunk = CURSOR_LINE_PER_CHUNK_16;
557 
558 	if (cursor_mode == CURSOR_MODE_MONO)
559 		line_per_chunk = CURSOR_LINE_PER_CHUNK_16;
560 	else if (cursor_mode == CURSOR_MODE_COLOR_1BIT_AND ||
561 		 cursor_mode == CURSOR_MODE_COLOR_PRE_MULTIPLIED_ALPHA ||
562 		 cursor_mode == CURSOR_MODE_COLOR_UN_PRE_MULTIPLIED_ALPHA) {
563 		if (cursor_width >= 1   && cursor_width <= 32)
564 			line_per_chunk = CURSOR_LINE_PER_CHUNK_16;
565 		else if (cursor_width >= 33  && cursor_width <= 64)
566 			line_per_chunk = CURSOR_LINE_PER_CHUNK_8;
567 		else if (cursor_width >= 65  && cursor_width <= 128)
568 			line_per_chunk = CURSOR_LINE_PER_CHUNK_4;
569 		else if (cursor_width >= 129 && cursor_width <= 256)
570 			line_per_chunk = CURSOR_LINE_PER_CHUNK_2;
571 	} else if (cursor_mode == CURSOR_MODE_COLOR_64BIT_FP_PRE_MULTIPLIED ||
572 		   cursor_mode == CURSOR_MODE_COLOR_64BIT_FP_UN_PRE_MULTIPLIED) {
573 		if (cursor_width >= 1   && cursor_width <= 16)
574 			line_per_chunk = CURSOR_LINE_PER_CHUNK_16;
575 		else if (cursor_width >= 17  && cursor_width <= 32)
576 			line_per_chunk = CURSOR_LINE_PER_CHUNK_8;
577 		else if (cursor_width >= 33  && cursor_width <= 64)
578 			line_per_chunk = CURSOR_LINE_PER_CHUNK_4;
579 		else if (cursor_width >= 65 && cursor_width <= 128)
580 			line_per_chunk = CURSOR_LINE_PER_CHUNK_2;
581 		else if (cursor_width >= 129 && cursor_width <= 256)
582 			line_per_chunk = CURSOR_LINE_PER_CHUNK_1;
583 	}
584 
585 	return line_per_chunk;
586 }
587 
588 void hubp2_cursor_set_attributes(
589 		struct hubp *hubp,
590 		const struct dc_cursor_attributes *attr)
591 {
592 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
593 	enum cursor_pitch hw_pitch = hubp1_get_cursor_pitch(attr->pitch);
594 	enum cursor_lines_per_chunk lpc = hubp2_get_lines_per_chunk(
595 			attr->width, attr->color_format);
596 
597 	hubp->curs_attr = *attr;
598 
599 	REG_UPDATE(CURSOR_SURFACE_ADDRESS_HIGH,
600 			CURSOR_SURFACE_ADDRESS_HIGH, attr->address.high_part);
601 	REG_UPDATE(CURSOR_SURFACE_ADDRESS,
602 			CURSOR_SURFACE_ADDRESS, attr->address.low_part);
603 
604 	REG_UPDATE_2(CURSOR_SIZE,
605 			CURSOR_WIDTH, attr->width,
606 			CURSOR_HEIGHT, attr->height);
607 
608 	REG_UPDATE_4(CURSOR_CONTROL,
609 			CURSOR_MODE, attr->color_format,
610 			CURSOR_2X_MAGNIFY, attr->attribute_flags.bits.ENABLE_MAGNIFICATION,
611 			CURSOR_PITCH, hw_pitch,
612 			CURSOR_LINES_PER_CHUNK, lpc);
613 
614 	REG_SET_2(CURSOR_SETTINGS, 0,
615 			/* no shift of the cursor HDL schedule */
616 			CURSOR0_DST_Y_OFFSET, 0,
617 			 /* used to shift the cursor chunk request deadline */
618 			CURSOR0_CHUNK_HDL_ADJUST, 3);
619 }
620 
621 void hubp2_dmdata_set_attributes(
622 		struct hubp *hubp,
623 		const struct dc_dmdata_attributes *attr)
624 {
625 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
626 
627 	if (attr->dmdata_mode == DMDATA_HW_MODE) {
628 		/* set to HW mode */
629 		REG_UPDATE(DMDATA_CNTL,
630 				DMDATA_MODE, 1);
631 
632 		/* for DMDATA flip, need to use SURFACE_UPDATE_LOCK */
633 		REG_UPDATE(DCSURF_FLIP_CONTROL, SURFACE_UPDATE_LOCK, 1);
634 
635 		/* toggle DMDATA_UPDATED and set repeat and size */
636 		REG_UPDATE(DMDATA_CNTL,
637 				DMDATA_UPDATED, 0);
638 		REG_UPDATE_3(DMDATA_CNTL,
639 				DMDATA_UPDATED, 1,
640 				DMDATA_REPEAT, attr->dmdata_repeat,
641 				DMDATA_SIZE, attr->dmdata_size);
642 
643 		/* set DMDATA address */
644 		REG_WRITE(DMDATA_ADDRESS_LOW, attr->address.low_part);
645 		REG_UPDATE(DMDATA_ADDRESS_HIGH,
646 				DMDATA_ADDRESS_HIGH, attr->address.high_part);
647 
648 		REG_UPDATE(DCSURF_FLIP_CONTROL, SURFACE_UPDATE_LOCK, 0);
649 
650 	} else {
651 		/* set to SW mode before loading data */
652 		REG_SET(DMDATA_CNTL, 0,
653 				DMDATA_MODE, 0);
654 		/* toggle DMDATA_SW_UPDATED to start loading sequence */
655 		REG_UPDATE(DMDATA_SW_CNTL,
656 				DMDATA_SW_UPDATED, 0);
657 		REG_UPDATE_3(DMDATA_SW_CNTL,
658 				DMDATA_SW_UPDATED, 1,
659 				DMDATA_SW_REPEAT, attr->dmdata_repeat,
660 				DMDATA_SW_SIZE, attr->dmdata_size);
661 		/* load data into hubp dmdata buffer */
662 		hubp2_dmdata_load(hubp, attr->dmdata_size, attr->dmdata_sw_data);
663 	}
664 
665 	/* Note that DL_DELTA must be programmed if we want to use TTU mode */
666 	REG_SET_3(DMDATA_QOS_CNTL, 0,
667 			DMDATA_QOS_MODE, attr->dmdata_qos_mode,
668 			DMDATA_QOS_LEVEL, attr->dmdata_qos_level,
669 			DMDATA_DL_DELTA, attr->dmdata_dl_delta);
670 }
671 
672 void hubp2_dmdata_load(
673 		struct hubp *hubp,
674 		uint32_t dmdata_sw_size,
675 		const uint32_t *dmdata_sw_data)
676 {
677 	int i;
678 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
679 
680 	/* load dmdata into HUBP buffer in SW mode */
681 	for (i = 0; i < dmdata_sw_size / 4; i++)
682 		REG_WRITE(DMDATA_SW_DATA, dmdata_sw_data[i]);
683 }
684 
685 bool hubp2_dmdata_status_done(struct hubp *hubp)
686 {
687 	uint32_t status;
688 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
689 
690 	REG_GET(DMDATA_STATUS, DMDATA_DONE, &status);
691 	return (status == 1);
692 }
693 
694 bool hubp2_program_surface_flip_and_addr(
695 	struct hubp *hubp,
696 	const struct dc_plane_address *address,
697 	bool flip_immediate)
698 {
699 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
700 
701 	//program flip type
702 	REG_UPDATE(DCSURF_FLIP_CONTROL,
703 			SURFACE_FLIP_TYPE, flip_immediate);
704 
705 	// Program VMID reg
706 	REG_UPDATE(VMID_SETTINGS_0,
707 			VMID, address->vmid);
708 
709 	if (address->type == PLN_ADDR_TYPE_GRPH_STEREO) {
710 		REG_UPDATE(DCSURF_FLIP_CONTROL, SURFACE_FLIP_MODE_FOR_STEREOSYNC, 0x1);
711 		REG_UPDATE(DCSURF_FLIP_CONTROL, SURFACE_FLIP_IN_STEREOSYNC, 0x1);
712 
713 	} else {
714 		// turn off stereo if not in stereo
715 		REG_UPDATE(DCSURF_FLIP_CONTROL, SURFACE_FLIP_MODE_FOR_STEREOSYNC, 0x0);
716 		REG_UPDATE(DCSURF_FLIP_CONTROL, SURFACE_FLIP_IN_STEREOSYNC, 0x0);
717 	}
718 
719 
720 
721 	/* HW automatically latch rest of address register on write to
722 	 * DCSURF_PRIMARY_SURFACE_ADDRESS if SURFACE_UPDATE_LOCK is not used
723 	 *
724 	 * program high first and then the low addr, order matters!
725 	 */
726 	switch (address->type) {
727 	case PLN_ADDR_TYPE_GRAPHICS:
728 		/* DCN1.0 does not support const color
729 		 * TODO: program DCHUBBUB_RET_PATH_DCC_CFGx_0/1
730 		 * base on address->grph.dcc_const_color
731 		 * x = 0, 2, 4, 6 for pipe 0, 1, 2, 3 for rgb and luma
732 		 * x = 1, 3, 5, 7 for pipe 0, 1, 2, 3 for chroma
733 		 */
734 
735 		if (address->grph.addr.quad_part == 0)
736 			break;
737 
738 		REG_UPDATE_2(DCSURF_SURFACE_CONTROL,
739 				PRIMARY_SURFACE_TMZ, address->tmz_surface,
740 				PRIMARY_META_SURFACE_TMZ, address->tmz_surface);
741 
742 		if (address->grph.meta_addr.quad_part != 0) {
743 			REG_SET(DCSURF_PRIMARY_META_SURFACE_ADDRESS_HIGH, 0,
744 					PRIMARY_META_SURFACE_ADDRESS_HIGH,
745 					address->grph.meta_addr.high_part);
746 
747 			REG_SET(DCSURF_PRIMARY_META_SURFACE_ADDRESS, 0,
748 					PRIMARY_META_SURFACE_ADDRESS,
749 					address->grph.meta_addr.low_part);
750 		}
751 
752 		REG_SET(DCSURF_PRIMARY_SURFACE_ADDRESS_HIGH, 0,
753 				PRIMARY_SURFACE_ADDRESS_HIGH,
754 				address->grph.addr.high_part);
755 
756 		REG_SET(DCSURF_PRIMARY_SURFACE_ADDRESS, 0,
757 				PRIMARY_SURFACE_ADDRESS,
758 				address->grph.addr.low_part);
759 		break;
760 	case PLN_ADDR_TYPE_VIDEO_PROGRESSIVE:
761 		if (address->video_progressive.luma_addr.quad_part == 0
762 				|| address->video_progressive.chroma_addr.quad_part == 0)
763 			break;
764 
765 		REG_UPDATE_4(DCSURF_SURFACE_CONTROL,
766 				PRIMARY_SURFACE_TMZ, address->tmz_surface,
767 				PRIMARY_SURFACE_TMZ_C, address->tmz_surface,
768 				PRIMARY_META_SURFACE_TMZ, address->tmz_surface,
769 				PRIMARY_META_SURFACE_TMZ_C, address->tmz_surface);
770 
771 		if (address->video_progressive.luma_meta_addr.quad_part != 0) {
772 			REG_SET(DCSURF_PRIMARY_META_SURFACE_ADDRESS_HIGH_C, 0,
773 					PRIMARY_META_SURFACE_ADDRESS_HIGH_C,
774 					address->video_progressive.chroma_meta_addr.high_part);
775 
776 			REG_SET(DCSURF_PRIMARY_META_SURFACE_ADDRESS_C, 0,
777 					PRIMARY_META_SURFACE_ADDRESS_C,
778 					address->video_progressive.chroma_meta_addr.low_part);
779 
780 			REG_SET(DCSURF_PRIMARY_META_SURFACE_ADDRESS_HIGH, 0,
781 					PRIMARY_META_SURFACE_ADDRESS_HIGH,
782 					address->video_progressive.luma_meta_addr.high_part);
783 
784 			REG_SET(DCSURF_PRIMARY_META_SURFACE_ADDRESS, 0,
785 					PRIMARY_META_SURFACE_ADDRESS,
786 					address->video_progressive.luma_meta_addr.low_part);
787 		}
788 
789 		REG_SET(DCSURF_PRIMARY_SURFACE_ADDRESS_HIGH_C, 0,
790 				PRIMARY_SURFACE_ADDRESS_HIGH_C,
791 				address->video_progressive.chroma_addr.high_part);
792 
793 		REG_SET(DCSURF_PRIMARY_SURFACE_ADDRESS_C, 0,
794 				PRIMARY_SURFACE_ADDRESS_C,
795 				address->video_progressive.chroma_addr.low_part);
796 
797 		REG_SET(DCSURF_PRIMARY_SURFACE_ADDRESS_HIGH, 0,
798 				PRIMARY_SURFACE_ADDRESS_HIGH,
799 				address->video_progressive.luma_addr.high_part);
800 
801 		REG_SET(DCSURF_PRIMARY_SURFACE_ADDRESS, 0,
802 				PRIMARY_SURFACE_ADDRESS,
803 				address->video_progressive.luma_addr.low_part);
804 		break;
805 	case PLN_ADDR_TYPE_GRPH_STEREO:
806 		if (address->grph_stereo.left_addr.quad_part == 0)
807 			break;
808 		if (address->grph_stereo.right_addr.quad_part == 0)
809 			break;
810 
811 		REG_UPDATE_8(DCSURF_SURFACE_CONTROL,
812 				PRIMARY_SURFACE_TMZ, address->tmz_surface,
813 				PRIMARY_SURFACE_TMZ_C, address->tmz_surface,
814 				PRIMARY_META_SURFACE_TMZ, address->tmz_surface,
815 				PRIMARY_META_SURFACE_TMZ_C, address->tmz_surface,
816 				SECONDARY_SURFACE_TMZ, address->tmz_surface,
817 				SECONDARY_SURFACE_TMZ_C, address->tmz_surface,
818 				SECONDARY_META_SURFACE_TMZ, address->tmz_surface,
819 				SECONDARY_META_SURFACE_TMZ_C, address->tmz_surface);
820 
821 		if (address->grph_stereo.right_meta_addr.quad_part != 0) {
822 
823 			REG_SET(DCSURF_SECONDARY_META_SURFACE_ADDRESS_HIGH, 0,
824 					SECONDARY_META_SURFACE_ADDRESS_HIGH,
825 					address->grph_stereo.right_meta_addr.high_part);
826 
827 			REG_SET(DCSURF_SECONDARY_META_SURFACE_ADDRESS, 0,
828 					SECONDARY_META_SURFACE_ADDRESS,
829 					address->grph_stereo.right_meta_addr.low_part);
830 		}
831 		if (address->grph_stereo.left_meta_addr.quad_part != 0) {
832 
833 			REG_SET(DCSURF_PRIMARY_META_SURFACE_ADDRESS_HIGH, 0,
834 					PRIMARY_META_SURFACE_ADDRESS_HIGH,
835 					address->grph_stereo.left_meta_addr.high_part);
836 
837 			REG_SET(DCSURF_PRIMARY_META_SURFACE_ADDRESS, 0,
838 					PRIMARY_META_SURFACE_ADDRESS,
839 					address->grph_stereo.left_meta_addr.low_part);
840 		}
841 
842 		REG_SET(DCSURF_SECONDARY_SURFACE_ADDRESS_HIGH, 0,
843 				SECONDARY_SURFACE_ADDRESS_HIGH,
844 				address->grph_stereo.right_addr.high_part);
845 
846 		REG_SET(DCSURF_SECONDARY_SURFACE_ADDRESS, 0,
847 				SECONDARY_SURFACE_ADDRESS,
848 				address->grph_stereo.right_addr.low_part);
849 
850 		REG_SET(DCSURF_PRIMARY_SURFACE_ADDRESS_HIGH, 0,
851 				PRIMARY_SURFACE_ADDRESS_HIGH,
852 				address->grph_stereo.left_addr.high_part);
853 
854 		REG_SET(DCSURF_PRIMARY_SURFACE_ADDRESS, 0,
855 				PRIMARY_SURFACE_ADDRESS,
856 				address->grph_stereo.left_addr.low_part);
857 		break;
858 	default:
859 		BREAK_TO_DEBUGGER();
860 		break;
861 	}
862 
863 	hubp->request_address = *address;
864 
865 	return true;
866 }
867 
868 void hubp2_enable_triplebuffer(
869 	struct hubp *hubp,
870 	bool enable)
871 {
872 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
873 	uint32_t triple_buffer_en = 0;
874 	bool tri_buffer_en;
875 
876 	REG_GET(DCSURF_FLIP_CONTROL2, SURFACE_TRIPLE_BUFFER_ENABLE, &triple_buffer_en);
877 	tri_buffer_en = (triple_buffer_en == 1);
878 	if (tri_buffer_en != enable) {
879 		REG_UPDATE(DCSURF_FLIP_CONTROL2,
880 			SURFACE_TRIPLE_BUFFER_ENABLE, enable ? DC_TRIPLEBUFFER_ENABLE : DC_TRIPLEBUFFER_DISABLE);
881 	}
882 }
883 
884 bool hubp2_is_triplebuffer_enabled(
885 	struct hubp *hubp)
886 {
887 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
888 	uint32_t triple_buffer_en = 0;
889 
890 	REG_GET(DCSURF_FLIP_CONTROL2, SURFACE_TRIPLE_BUFFER_ENABLE, &triple_buffer_en);
891 
892 	return (bool)triple_buffer_en;
893 }
894 
895 void hubp2_set_flip_control_surface_gsl(struct hubp *hubp, bool enable)
896 {
897 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
898 
899 	REG_UPDATE(DCSURF_FLIP_CONTROL2, SURFACE_GSL_ENABLE, enable ? 1 : 0);
900 }
901 
902 bool hubp2_is_flip_pending(struct hubp *hubp)
903 {
904 	uint32_t flip_pending = 0;
905 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
906 	struct dc_plane_address earliest_inuse_address;
907 
908 	if (hubp && hubp->power_gated)
909 		return false;
910 
911 	REG_GET(DCSURF_FLIP_CONTROL,
912 			SURFACE_FLIP_PENDING, &flip_pending);
913 
914 	REG_GET(DCSURF_SURFACE_EARLIEST_INUSE,
915 			SURFACE_EARLIEST_INUSE_ADDRESS, &earliest_inuse_address.grph.addr.low_part);
916 
917 	REG_GET(DCSURF_SURFACE_EARLIEST_INUSE_HIGH,
918 			SURFACE_EARLIEST_INUSE_ADDRESS_HIGH, &earliest_inuse_address.grph.addr.high_part);
919 
920 	if (flip_pending)
921 		return true;
922 
923 	if (earliest_inuse_address.grph.addr.quad_part != hubp->request_address.grph.addr.quad_part)
924 		return true;
925 
926 	return false;
927 }
928 
929 void hubp2_set_blank(struct hubp *hubp, bool blank)
930 {
931 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
932 	uint32_t blank_en = blank ? 1 : 0;
933 
934 	REG_UPDATE_2(DCHUBP_CNTL,
935 			HUBP_BLANK_EN, blank_en,
936 			HUBP_TTU_DISABLE, blank_en);
937 
938 	if (blank) {
939 		uint32_t reg_val = REG_READ(DCHUBP_CNTL);
940 
941 		if (reg_val) {
942 			/* init sequence workaround: in case HUBP is
943 			 * power gated, this wait would timeout.
944 			 *
945 			 * we just wrote reg_val to non-0, if it stay 0
946 			 * it means HUBP is gated
947 			 */
948 			REG_WAIT(DCHUBP_CNTL,
949 					HUBP_NO_OUTSTANDING_REQ, 1,
950 					1, 200);
951 		}
952 
953 		hubp->mpcc_id = 0xf;
954 		hubp->opp_id = OPP_ID_INVALID;
955 	}
956 }
957 
958 void hubp2_cursor_set_position(
959 		struct hubp *hubp,
960 		const struct dc_cursor_position *pos,
961 		const struct dc_cursor_mi_param *param)
962 {
963 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
964 	int src_x_offset = pos->x - pos->x_hotspot - param->viewport.x;
965 	int src_y_offset = pos->y - pos->y_hotspot - param->viewport.y;
966 	int x_hotspot = pos->x_hotspot;
967 	int y_hotspot = pos->y_hotspot;
968 	int cursor_height = (int)hubp->curs_attr.height;
969 	int cursor_width = (int)hubp->curs_attr.width;
970 	uint32_t dst_x_offset;
971 	uint32_t cur_en = pos->enable ? 1 : 0;
972 
973 	/*
974 	 * Guard aganst cursor_set_position() from being called with invalid
975 	 * attributes
976 	 *
977 	 * TODO: Look at combining cursor_set_position() and
978 	 * cursor_set_attributes() into cursor_update()
979 	 */
980 	if (hubp->curs_attr.address.quad_part == 0)
981 		return;
982 
983 	// Rotated cursor width/height and hotspots tweaks for offset calculation
984 	if (param->rotation == ROTATION_ANGLE_90 || param->rotation == ROTATION_ANGLE_270) {
985 		swap(cursor_height, cursor_width);
986 		if (param->rotation == ROTATION_ANGLE_90) {
987 			src_x_offset = pos->x - pos->y_hotspot - param->viewport.x;
988 			src_y_offset = pos->y - pos->x_hotspot - param->viewport.y;
989 		}
990 	} else if (param->rotation == ROTATION_ANGLE_180) {
991 		src_x_offset = pos->x - param->viewport.x;
992 		src_y_offset = pos->y - param->viewport.y;
993 	}
994 
995 	if (param->mirror) {
996 		x_hotspot = param->viewport.width - x_hotspot;
997 		src_x_offset = param->viewport.x + param->viewport.width - src_x_offset;
998 	}
999 
1000 	dst_x_offset = (src_x_offset >= 0) ? src_x_offset : 0;
1001 	dst_x_offset *= param->ref_clk_khz;
1002 	dst_x_offset /= param->pixel_clk_khz;
1003 
1004 	ASSERT(param->h_scale_ratio.value);
1005 
1006 	if (param->h_scale_ratio.value)
1007 		dst_x_offset = dc_fixpt_floor(dc_fixpt_div(
1008 				dc_fixpt_from_int(dst_x_offset),
1009 				param->h_scale_ratio));
1010 
1011 	if (src_x_offset >= (int)param->viewport.width)
1012 		cur_en = 0;  /* not visible beyond right edge*/
1013 
1014 	if (src_x_offset + cursor_width <= 0)
1015 		cur_en = 0;  /* not visible beyond left edge*/
1016 
1017 	if (src_y_offset >= (int)param->viewport.height)
1018 		cur_en = 0;  /* not visible beyond bottom edge*/
1019 
1020 	if (src_y_offset + cursor_height <= 0)
1021 		cur_en = 0;  /* not visible beyond top edge*/
1022 
1023 	if (cur_en && REG_READ(CURSOR_SURFACE_ADDRESS) == 0)
1024 		hubp->funcs->set_cursor_attributes(hubp, &hubp->curs_attr);
1025 
1026 	REG_UPDATE(CURSOR_CONTROL,
1027 			CURSOR_ENABLE, cur_en);
1028 
1029 	REG_SET_2(CURSOR_POSITION, 0,
1030 			CURSOR_X_POSITION, pos->x,
1031 			CURSOR_Y_POSITION, pos->y);
1032 
1033 	REG_SET_2(CURSOR_HOT_SPOT, 0,
1034 			CURSOR_HOT_SPOT_X, x_hotspot,
1035 			CURSOR_HOT_SPOT_Y, y_hotspot);
1036 
1037 	REG_SET(CURSOR_DST_OFFSET, 0,
1038 			CURSOR_DST_X_OFFSET, dst_x_offset);
1039 	/* TODO Handle surface pixel formats other than 4:4:4 */
1040 }
1041 
1042 void hubp2_clk_cntl(struct hubp *hubp, bool enable)
1043 {
1044 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
1045 	uint32_t clk_enable = enable ? 1 : 0;
1046 
1047 	REG_UPDATE(HUBP_CLK_CNTL, HUBP_CLOCK_ENABLE, clk_enable);
1048 }
1049 
1050 void hubp2_vtg_sel(struct hubp *hubp, uint32_t otg_inst)
1051 {
1052 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
1053 
1054 	REG_UPDATE(DCHUBP_CNTL, HUBP_VTG_SEL, otg_inst);
1055 }
1056 
1057 void hubp2_clear_underflow(struct hubp *hubp)
1058 {
1059 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
1060 
1061 	REG_UPDATE(DCHUBP_CNTL, HUBP_UNDERFLOW_CLEAR, 1);
1062 }
1063 
1064 void hubp2_read_state_common(struct hubp *hubp)
1065 {
1066 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
1067 	struct dcn_hubp_state *s = &hubp2->state;
1068 	struct _vcs_dpi_display_dlg_regs_st *dlg_attr = &s->dlg_attr;
1069 	struct _vcs_dpi_display_ttu_regs_st *ttu_attr = &s->ttu_attr;
1070 	struct _vcs_dpi_display_rq_regs_st *rq_regs = &s->rq_regs;
1071 
1072 	/* Requester */
1073 	REG_GET(HUBPRET_CONTROL,
1074 			DET_BUF_PLANE1_BASE_ADDRESS, &rq_regs->plane1_base_address);
1075 	REG_GET_4(DCN_EXPANSION_MODE,
1076 			DRQ_EXPANSION_MODE, &rq_regs->drq_expansion_mode,
1077 			PRQ_EXPANSION_MODE, &rq_regs->prq_expansion_mode,
1078 			MRQ_EXPANSION_MODE, &rq_regs->mrq_expansion_mode,
1079 			CRQ_EXPANSION_MODE, &rq_regs->crq_expansion_mode);
1080 
1081 	/* DLG - Per hubp */
1082 	REG_GET_2(BLANK_OFFSET_0,
1083 		REFCYC_H_BLANK_END, &dlg_attr->refcyc_h_blank_end,
1084 		DLG_V_BLANK_END, &dlg_attr->dlg_vblank_end);
1085 
1086 	REG_GET(BLANK_OFFSET_1,
1087 		MIN_DST_Y_NEXT_START, &dlg_attr->min_dst_y_next_start);
1088 
1089 	REG_GET(DST_DIMENSIONS,
1090 		REFCYC_PER_HTOTAL, &dlg_attr->refcyc_per_htotal);
1091 
1092 	REG_GET_2(DST_AFTER_SCALER,
1093 		REFCYC_X_AFTER_SCALER, &dlg_attr->refcyc_x_after_scaler,
1094 		DST_Y_AFTER_SCALER, &dlg_attr->dst_y_after_scaler);
1095 
1096 	if (REG(PREFETCH_SETTINS))
1097 		REG_GET_2(PREFETCH_SETTINS,
1098 			DST_Y_PREFETCH, &dlg_attr->dst_y_prefetch,
1099 			VRATIO_PREFETCH, &dlg_attr->vratio_prefetch);
1100 	else
1101 		REG_GET_2(PREFETCH_SETTINGS,
1102 			DST_Y_PREFETCH, &dlg_attr->dst_y_prefetch,
1103 			VRATIO_PREFETCH, &dlg_attr->vratio_prefetch);
1104 
1105 	REG_GET_2(VBLANK_PARAMETERS_0,
1106 		DST_Y_PER_VM_VBLANK, &dlg_attr->dst_y_per_vm_vblank,
1107 		DST_Y_PER_ROW_VBLANK, &dlg_attr->dst_y_per_row_vblank);
1108 
1109 	REG_GET(REF_FREQ_TO_PIX_FREQ,
1110 		REF_FREQ_TO_PIX_FREQ, &dlg_attr->ref_freq_to_pix_freq);
1111 
1112 	/* DLG - Per luma/chroma */
1113 	REG_GET(VBLANK_PARAMETERS_1,
1114 		REFCYC_PER_PTE_GROUP_VBLANK_L, &dlg_attr->refcyc_per_pte_group_vblank_l);
1115 
1116 	REG_GET(VBLANK_PARAMETERS_3,
1117 		REFCYC_PER_META_CHUNK_VBLANK_L, &dlg_attr->refcyc_per_meta_chunk_vblank_l);
1118 
1119 	if (REG(NOM_PARAMETERS_0))
1120 		REG_GET(NOM_PARAMETERS_0,
1121 			DST_Y_PER_PTE_ROW_NOM_L, &dlg_attr->dst_y_per_pte_row_nom_l);
1122 
1123 	if (REG(NOM_PARAMETERS_1))
1124 		REG_GET(NOM_PARAMETERS_1,
1125 			REFCYC_PER_PTE_GROUP_NOM_L, &dlg_attr->refcyc_per_pte_group_nom_l);
1126 
1127 	REG_GET(NOM_PARAMETERS_4,
1128 		DST_Y_PER_META_ROW_NOM_L, &dlg_attr->dst_y_per_meta_row_nom_l);
1129 
1130 	REG_GET(NOM_PARAMETERS_5,
1131 		REFCYC_PER_META_CHUNK_NOM_L, &dlg_attr->refcyc_per_meta_chunk_nom_l);
1132 
1133 	REG_GET_2(PER_LINE_DELIVERY_PRE,
1134 		REFCYC_PER_LINE_DELIVERY_PRE_L, &dlg_attr->refcyc_per_line_delivery_pre_l,
1135 		REFCYC_PER_LINE_DELIVERY_PRE_C, &dlg_attr->refcyc_per_line_delivery_pre_c);
1136 
1137 	REG_GET_2(PER_LINE_DELIVERY,
1138 		REFCYC_PER_LINE_DELIVERY_L, &dlg_attr->refcyc_per_line_delivery_l,
1139 		REFCYC_PER_LINE_DELIVERY_C, &dlg_attr->refcyc_per_line_delivery_c);
1140 
1141 	if (REG(PREFETCH_SETTINS_C))
1142 		REG_GET(PREFETCH_SETTINS_C,
1143 			VRATIO_PREFETCH_C, &dlg_attr->vratio_prefetch_c);
1144 	else
1145 		REG_GET(PREFETCH_SETTINGS_C,
1146 			VRATIO_PREFETCH_C, &dlg_attr->vratio_prefetch_c);
1147 
1148 	REG_GET(VBLANK_PARAMETERS_2,
1149 		REFCYC_PER_PTE_GROUP_VBLANK_C, &dlg_attr->refcyc_per_pte_group_vblank_c);
1150 
1151 	REG_GET(VBLANK_PARAMETERS_4,
1152 		REFCYC_PER_META_CHUNK_VBLANK_C, &dlg_attr->refcyc_per_meta_chunk_vblank_c);
1153 
1154 	if (REG(NOM_PARAMETERS_2))
1155 		REG_GET(NOM_PARAMETERS_2,
1156 			DST_Y_PER_PTE_ROW_NOM_C, &dlg_attr->dst_y_per_pte_row_nom_c);
1157 
1158 	if (REG(NOM_PARAMETERS_3))
1159 		REG_GET(NOM_PARAMETERS_3,
1160 			REFCYC_PER_PTE_GROUP_NOM_C, &dlg_attr->refcyc_per_pte_group_nom_c);
1161 
1162 	REG_GET(NOM_PARAMETERS_6,
1163 		DST_Y_PER_META_ROW_NOM_C, &dlg_attr->dst_y_per_meta_row_nom_c);
1164 
1165 	REG_GET(NOM_PARAMETERS_7,
1166 		REFCYC_PER_META_CHUNK_NOM_C, &dlg_attr->refcyc_per_meta_chunk_nom_c);
1167 
1168 	/* TTU - per hubp */
1169 	REG_GET_2(DCN_TTU_QOS_WM,
1170 		QoS_LEVEL_LOW_WM, &ttu_attr->qos_level_low_wm,
1171 		QoS_LEVEL_HIGH_WM, &ttu_attr->qos_level_high_wm);
1172 
1173 	REG_GET_2(DCN_GLOBAL_TTU_CNTL,
1174 		MIN_TTU_VBLANK, &ttu_attr->min_ttu_vblank,
1175 		QoS_LEVEL_FLIP, &ttu_attr->qos_level_flip);
1176 
1177 	/* TTU - per luma/chroma */
1178 	/* Assumed surf0 is luma and 1 is chroma */
1179 
1180 	REG_GET_3(DCN_SURF0_TTU_CNTL0,
1181 		REFCYC_PER_REQ_DELIVERY, &ttu_attr->refcyc_per_req_delivery_l,
1182 		QoS_LEVEL_FIXED, &ttu_attr->qos_level_fixed_l,
1183 		QoS_RAMP_DISABLE, &ttu_attr->qos_ramp_disable_l);
1184 
1185 	REG_GET(DCN_SURF0_TTU_CNTL1,
1186 		REFCYC_PER_REQ_DELIVERY_PRE,
1187 		&ttu_attr->refcyc_per_req_delivery_pre_l);
1188 
1189 	REG_GET_3(DCN_SURF1_TTU_CNTL0,
1190 		REFCYC_PER_REQ_DELIVERY, &ttu_attr->refcyc_per_req_delivery_c,
1191 		QoS_LEVEL_FIXED, &ttu_attr->qos_level_fixed_c,
1192 		QoS_RAMP_DISABLE, &ttu_attr->qos_ramp_disable_c);
1193 
1194 	REG_GET(DCN_SURF1_TTU_CNTL1,
1195 		REFCYC_PER_REQ_DELIVERY_PRE,
1196 		&ttu_attr->refcyc_per_req_delivery_pre_c);
1197 
1198 	/* Rest of hubp */
1199 	REG_GET(DCSURF_SURFACE_CONFIG,
1200 			SURFACE_PIXEL_FORMAT, &s->pixel_format);
1201 
1202 	REG_GET(DCSURF_SURFACE_EARLIEST_INUSE_HIGH,
1203 			SURFACE_EARLIEST_INUSE_ADDRESS_HIGH, &s->inuse_addr_hi);
1204 
1205 	REG_GET(DCSURF_SURFACE_EARLIEST_INUSE,
1206 			SURFACE_EARLIEST_INUSE_ADDRESS, &s->inuse_addr_lo);
1207 
1208 	REG_GET_2(DCSURF_PRI_VIEWPORT_DIMENSION,
1209 			PRI_VIEWPORT_WIDTH, &s->viewport_width,
1210 			PRI_VIEWPORT_HEIGHT, &s->viewport_height);
1211 
1212 	REG_GET_2(DCSURF_SURFACE_CONFIG,
1213 			ROTATION_ANGLE, &s->rotation_angle,
1214 			H_MIRROR_EN, &s->h_mirror_en);
1215 
1216 	REG_GET(DCSURF_TILING_CONFIG,
1217 			SW_MODE, &s->sw_mode);
1218 
1219 	REG_GET(DCSURF_SURFACE_CONTROL,
1220 			PRIMARY_SURFACE_DCC_EN, &s->dcc_en);
1221 
1222 	REG_GET_3(DCHUBP_CNTL,
1223 			HUBP_BLANK_EN, &s->blank_en,
1224 			HUBP_TTU_DISABLE, &s->ttu_disable,
1225 			HUBP_UNDERFLOW_STATUS, &s->underflow_status);
1226 
1227 	REG_GET(HUBP_CLK_CNTL,
1228 			HUBP_CLOCK_ENABLE, &s->clock_en);
1229 
1230 	REG_GET(DCN_GLOBAL_TTU_CNTL,
1231 			MIN_TTU_VBLANK, &s->min_ttu_vblank);
1232 
1233 	REG_GET_2(DCN_TTU_QOS_WM,
1234 			QoS_LEVEL_LOW_WM, &s->qos_level_low_wm,
1235 			QoS_LEVEL_HIGH_WM, &s->qos_level_high_wm);
1236 
1237 }
1238 
1239 void hubp2_read_state(struct hubp *hubp)
1240 {
1241 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
1242 	struct dcn_hubp_state *s = &hubp2->state;
1243 	struct _vcs_dpi_display_rq_regs_st *rq_regs = &s->rq_regs;
1244 
1245 	hubp2_read_state_common(hubp);
1246 
1247 	REG_GET_8(DCHUBP_REQ_SIZE_CONFIG,
1248 		CHUNK_SIZE, &rq_regs->rq_regs_l.chunk_size,
1249 		MIN_CHUNK_SIZE, &rq_regs->rq_regs_l.min_chunk_size,
1250 		META_CHUNK_SIZE, &rq_regs->rq_regs_l.meta_chunk_size,
1251 		MIN_META_CHUNK_SIZE, &rq_regs->rq_regs_l.min_meta_chunk_size,
1252 		DPTE_GROUP_SIZE, &rq_regs->rq_regs_l.dpte_group_size,
1253 		MPTE_GROUP_SIZE, &rq_regs->rq_regs_l.mpte_group_size,
1254 		SWATH_HEIGHT, &rq_regs->rq_regs_l.swath_height,
1255 		PTE_ROW_HEIGHT_LINEAR, &rq_regs->rq_regs_l.pte_row_height_linear);
1256 
1257 	REG_GET_8(DCHUBP_REQ_SIZE_CONFIG_C,
1258 		CHUNK_SIZE_C, &rq_regs->rq_regs_c.chunk_size,
1259 		MIN_CHUNK_SIZE_C, &rq_regs->rq_regs_c.min_chunk_size,
1260 		META_CHUNK_SIZE_C, &rq_regs->rq_regs_c.meta_chunk_size,
1261 		MIN_META_CHUNK_SIZE_C, &rq_regs->rq_regs_c.min_meta_chunk_size,
1262 		DPTE_GROUP_SIZE_C, &rq_regs->rq_regs_c.dpte_group_size,
1263 		MPTE_GROUP_SIZE_C, &rq_regs->rq_regs_c.mpte_group_size,
1264 		SWATH_HEIGHT_C, &rq_regs->rq_regs_c.swath_height,
1265 		PTE_ROW_HEIGHT_LINEAR_C, &rq_regs->rq_regs_c.pte_row_height_linear);
1266 
1267 }
1268 
1269 void hubp2_validate_dml_output(struct hubp *hubp,
1270 		struct dc_context *ctx,
1271 		struct _vcs_dpi_display_rq_regs_st *dml_rq_regs,
1272 		struct _vcs_dpi_display_dlg_regs_st *dml_dlg_attr,
1273 		struct _vcs_dpi_display_ttu_regs_st *dml_ttu_attr)
1274 {
1275 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
1276 	struct _vcs_dpi_display_rq_regs_st rq_regs = {0};
1277 	struct _vcs_dpi_display_dlg_regs_st dlg_attr = {0};
1278 	struct _vcs_dpi_display_ttu_regs_st ttu_attr = {0};
1279 	DC_LOGGER_INIT(ctx->logger);
1280 	DC_LOG_DEBUG("DML Validation | Running Validation");
1281 
1282 	/* Requestor Regs */
1283 	REG_GET(HUBPRET_CONTROL,
1284 		DET_BUF_PLANE1_BASE_ADDRESS, &rq_regs.plane1_base_address);
1285 	REG_GET_4(DCN_EXPANSION_MODE,
1286 		DRQ_EXPANSION_MODE, &rq_regs.drq_expansion_mode,
1287 		PRQ_EXPANSION_MODE, &rq_regs.prq_expansion_mode,
1288 		MRQ_EXPANSION_MODE, &rq_regs.mrq_expansion_mode,
1289 		CRQ_EXPANSION_MODE, &rq_regs.crq_expansion_mode);
1290 	REG_GET_8(DCHUBP_REQ_SIZE_CONFIG,
1291 		CHUNK_SIZE, &rq_regs.rq_regs_l.chunk_size,
1292 		MIN_CHUNK_SIZE, &rq_regs.rq_regs_l.min_chunk_size,
1293 		META_CHUNK_SIZE, &rq_regs.rq_regs_l.meta_chunk_size,
1294 		MIN_META_CHUNK_SIZE, &rq_regs.rq_regs_l.min_meta_chunk_size,
1295 		DPTE_GROUP_SIZE, &rq_regs.rq_regs_l.dpte_group_size,
1296 		MPTE_GROUP_SIZE, &rq_regs.rq_regs_l.mpte_group_size,
1297 		SWATH_HEIGHT, &rq_regs.rq_regs_l.swath_height,
1298 		PTE_ROW_HEIGHT_LINEAR, &rq_regs.rq_regs_l.pte_row_height_linear);
1299 	REG_GET_8(DCHUBP_REQ_SIZE_CONFIG_C,
1300 		CHUNK_SIZE_C, &rq_regs.rq_regs_c.chunk_size,
1301 		MIN_CHUNK_SIZE_C, &rq_regs.rq_regs_c.min_chunk_size,
1302 		META_CHUNK_SIZE_C, &rq_regs.rq_regs_c.meta_chunk_size,
1303 		MIN_META_CHUNK_SIZE_C, &rq_regs.rq_regs_c.min_meta_chunk_size,
1304 		DPTE_GROUP_SIZE_C, &rq_regs.rq_regs_c.dpte_group_size,
1305 		MPTE_GROUP_SIZE_C, &rq_regs.rq_regs_c.mpte_group_size,
1306 		SWATH_HEIGHT_C, &rq_regs.rq_regs_c.swath_height,
1307 		PTE_ROW_HEIGHT_LINEAR_C, &rq_regs.rq_regs_c.pte_row_height_linear);
1308 
1309 	if (rq_regs.plane1_base_address != dml_rq_regs->plane1_base_address)
1310 		DC_LOG_DEBUG("DML Validation | HUBPRET_CONTROL:DET_BUF_PLANE1_BASE_ADDRESS - Expected: %u  Actual: %u\n",
1311 				dml_rq_regs->plane1_base_address, rq_regs.plane1_base_address);
1312 	if (rq_regs.drq_expansion_mode != dml_rq_regs->drq_expansion_mode)
1313 		DC_LOG_DEBUG("DML Validation | DCN_EXPANSION_MODE:DRQ_EXPANSION_MODE - Expected: %u  Actual: %u\n",
1314 				dml_rq_regs->drq_expansion_mode, rq_regs.drq_expansion_mode);
1315 	if (rq_regs.prq_expansion_mode != dml_rq_regs->prq_expansion_mode)
1316 		DC_LOG_DEBUG("DML Validation | DCN_EXPANSION_MODE:MRQ_EXPANSION_MODE - Expected: %u  Actual: %u\n",
1317 				dml_rq_regs->prq_expansion_mode, rq_regs.prq_expansion_mode);
1318 	if (rq_regs.mrq_expansion_mode != dml_rq_regs->mrq_expansion_mode)
1319 		DC_LOG_DEBUG("DML Validation | DCN_EXPANSION_MODE:DET_BUF_PLANE1_BASE_ADDRESS - Expected: %u  Actual: %u\n",
1320 				dml_rq_regs->mrq_expansion_mode, rq_regs.mrq_expansion_mode);
1321 	if (rq_regs.crq_expansion_mode != dml_rq_regs->crq_expansion_mode)
1322 		DC_LOG_DEBUG("DML Validation | DCN_EXPANSION_MODE:CRQ_EXPANSION_MODE - Expected: %u  Actual: %u\n",
1323 				dml_rq_regs->crq_expansion_mode, rq_regs.crq_expansion_mode);
1324 
1325 	if (rq_regs.rq_regs_l.chunk_size != dml_rq_regs->rq_regs_l.chunk_size)
1326 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG_C:CHUNK_SIZE - Expected: %u  Actual: %u\n",
1327 				dml_rq_regs->rq_regs_l.chunk_size, rq_regs.rq_regs_l.chunk_size);
1328 	if (rq_regs.rq_regs_l.min_chunk_size != dml_rq_regs->rq_regs_l.min_chunk_size)
1329 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG_C:MIN_CHUNK_SIZE - Expected: %u  Actual: %u\n",
1330 				dml_rq_regs->rq_regs_l.min_chunk_size, rq_regs.rq_regs_l.min_chunk_size);
1331 	if (rq_regs.rq_regs_l.meta_chunk_size != dml_rq_regs->rq_regs_l.meta_chunk_size)
1332 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG_C:META_CHUNK_SIZE - Expected: %u  Actual: %u\n",
1333 				dml_rq_regs->rq_regs_l.meta_chunk_size, rq_regs.rq_regs_l.meta_chunk_size);
1334 	if (rq_regs.rq_regs_l.min_meta_chunk_size != dml_rq_regs->rq_regs_l.min_meta_chunk_size)
1335 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG_C:MIN_META_CHUNK_SIZE - Expected: %u  Actual: %u\n",
1336 				dml_rq_regs->rq_regs_l.min_meta_chunk_size, rq_regs.rq_regs_l.min_meta_chunk_size);
1337 	if (rq_regs.rq_regs_l.dpte_group_size != dml_rq_regs->rq_regs_l.dpte_group_size)
1338 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG_C:DPTE_GROUP_SIZE - Expected: %u  Actual: %u\n",
1339 				dml_rq_regs->rq_regs_l.dpte_group_size, rq_regs.rq_regs_l.dpte_group_size);
1340 	if (rq_regs.rq_regs_l.mpte_group_size != dml_rq_regs->rq_regs_l.mpte_group_size)
1341 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG_C:MPTE_GROUP_SIZE - Expected: %u  Actual: %u\n",
1342 				dml_rq_regs->rq_regs_l.mpte_group_size, rq_regs.rq_regs_l.mpte_group_size);
1343 	if (rq_regs.rq_regs_l.swath_height != dml_rq_regs->rq_regs_l.swath_height)
1344 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG_C:SWATH_HEIGHT - Expected: %u  Actual: %u\n",
1345 				dml_rq_regs->rq_regs_l.swath_height, rq_regs.rq_regs_l.swath_height);
1346 	if (rq_regs.rq_regs_l.pte_row_height_linear != dml_rq_regs->rq_regs_l.pte_row_height_linear)
1347 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG_C:PTE_ROW_HEIGHT_LINEAR - Expected: %u  Actual: %u\n",
1348 				dml_rq_regs->rq_regs_l.pte_row_height_linear, rq_regs.rq_regs_l.pte_row_height_linear);
1349 
1350 	if (rq_regs.rq_regs_c.chunk_size != dml_rq_regs->rq_regs_c.chunk_size)
1351 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG:CHUNK_SIZE_C - Expected: %u  Actual: %u\n",
1352 				dml_rq_regs->rq_regs_c.chunk_size, rq_regs.rq_regs_c.chunk_size);
1353 	if (rq_regs.rq_regs_c.min_chunk_size != dml_rq_regs->rq_regs_c.min_chunk_size)
1354 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG:MIN_CHUNK_SIZE_C - Expected: %u  Actual: %u\n",
1355 				dml_rq_regs->rq_regs_c.min_chunk_size, rq_regs.rq_regs_c.min_chunk_size);
1356 	if (rq_regs.rq_regs_c.meta_chunk_size != dml_rq_regs->rq_regs_c.meta_chunk_size)
1357 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG:META_CHUNK_SIZE_C - Expected: %u  Actual: %u\n",
1358 				dml_rq_regs->rq_regs_c.meta_chunk_size, rq_regs.rq_regs_c.meta_chunk_size);
1359 	if (rq_regs.rq_regs_c.min_meta_chunk_size != dml_rq_regs->rq_regs_c.min_meta_chunk_size)
1360 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG:MIN_META_CHUNK_SIZE_C - Expected: %u  Actual: %u\n",
1361 				dml_rq_regs->rq_regs_c.min_meta_chunk_size, rq_regs.rq_regs_c.min_meta_chunk_size);
1362 	if (rq_regs.rq_regs_c.dpte_group_size != dml_rq_regs->rq_regs_c.dpte_group_size)
1363 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG:DPTE_GROUP_SIZE_C - Expected: %u  Actual: %u\n",
1364 				dml_rq_regs->rq_regs_c.dpte_group_size, rq_regs.rq_regs_c.dpte_group_size);
1365 	if (rq_regs.rq_regs_c.mpte_group_size != dml_rq_regs->rq_regs_c.mpte_group_size)
1366 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG:MPTE_GROUP_SIZE_C - Expected: %u  Actual: %u\n",
1367 				dml_rq_regs->rq_regs_c.mpte_group_size, rq_regs.rq_regs_c.mpte_group_size);
1368 	if (rq_regs.rq_regs_c.swath_height != dml_rq_regs->rq_regs_c.swath_height)
1369 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG:SWATH_HEIGHT_C - Expected: %u  Actual: %u\n",
1370 				dml_rq_regs->rq_regs_c.swath_height, rq_regs.rq_regs_c.swath_height);
1371 	if (rq_regs.rq_regs_c.pte_row_height_linear != dml_rq_regs->rq_regs_c.pte_row_height_linear)
1372 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG:PTE_ROW_HEIGHT_LINEAR_C - Expected: %u  Actual: %u\n",
1373 				dml_rq_regs->rq_regs_c.pte_row_height_linear, rq_regs.rq_regs_c.pte_row_height_linear);
1374 
1375 	/* DLG - Per hubp */
1376 	REG_GET_2(BLANK_OFFSET_0,
1377 		REFCYC_H_BLANK_END, &dlg_attr.refcyc_h_blank_end,
1378 		DLG_V_BLANK_END, &dlg_attr.dlg_vblank_end);
1379 	REG_GET(BLANK_OFFSET_1,
1380 		MIN_DST_Y_NEXT_START, &dlg_attr.min_dst_y_next_start);
1381 	REG_GET(DST_DIMENSIONS,
1382 		REFCYC_PER_HTOTAL, &dlg_attr.refcyc_per_htotal);
1383 	REG_GET_2(DST_AFTER_SCALER,
1384 		REFCYC_X_AFTER_SCALER, &dlg_attr.refcyc_x_after_scaler,
1385 		DST_Y_AFTER_SCALER, &dlg_attr.dst_y_after_scaler);
1386 	REG_GET(REF_FREQ_TO_PIX_FREQ,
1387 		REF_FREQ_TO_PIX_FREQ, &dlg_attr.ref_freq_to_pix_freq);
1388 
1389 	if (dlg_attr.refcyc_h_blank_end != dml_dlg_attr->refcyc_h_blank_end)
1390 		DC_LOG_DEBUG("DML Validation | BLANK_OFFSET_0:REFCYC_H_BLANK_END - Expected: %u  Actual: %u\n",
1391 				dml_dlg_attr->refcyc_h_blank_end, dlg_attr.refcyc_h_blank_end);
1392 	if (dlg_attr.dlg_vblank_end != dml_dlg_attr->dlg_vblank_end)
1393 		DC_LOG_DEBUG("DML Validation | BLANK_OFFSET_0:DLG_V_BLANK_END - Expected: %u  Actual: %u\n",
1394 				dml_dlg_attr->dlg_vblank_end, dlg_attr.dlg_vblank_end);
1395 	if (dlg_attr.min_dst_y_next_start != dml_dlg_attr->min_dst_y_next_start)
1396 		DC_LOG_DEBUG("DML Validation | BLANK_OFFSET_1:MIN_DST_Y_NEXT_START - Expected: %u  Actual: %u\n",
1397 				dml_dlg_attr->min_dst_y_next_start, dlg_attr.min_dst_y_next_start);
1398 	if (dlg_attr.refcyc_per_htotal != dml_dlg_attr->refcyc_per_htotal)
1399 		DC_LOG_DEBUG("DML Validation | DST_DIMENSIONS:REFCYC_PER_HTOTAL - Expected: %u  Actual: %u\n",
1400 				dml_dlg_attr->refcyc_per_htotal, dlg_attr.refcyc_per_htotal);
1401 	if (dlg_attr.refcyc_x_after_scaler != dml_dlg_attr->refcyc_x_after_scaler)
1402 		DC_LOG_DEBUG("DML Validation | DST_AFTER_SCALER:REFCYC_X_AFTER_SCALER - Expected: %u  Actual: %u\n",
1403 				dml_dlg_attr->refcyc_x_after_scaler, dlg_attr.refcyc_x_after_scaler);
1404 	if (dlg_attr.dst_y_after_scaler != dml_dlg_attr->dst_y_after_scaler)
1405 		DC_LOG_DEBUG("DML Validation | DST_AFTER_SCALER:DST_Y_AFTER_SCALER - Expected: %u  Actual: %u\n",
1406 				dml_dlg_attr->dst_y_after_scaler, dlg_attr.dst_y_after_scaler);
1407 	if (dlg_attr.ref_freq_to_pix_freq != dml_dlg_attr->ref_freq_to_pix_freq)
1408 		DC_LOG_DEBUG("DML Validation | REF_FREQ_TO_PIX_FREQ:REF_FREQ_TO_PIX_FREQ - Expected: %u  Actual: %u\n",
1409 				dml_dlg_attr->ref_freq_to_pix_freq, dlg_attr.ref_freq_to_pix_freq);
1410 
1411 	/* DLG - Per luma/chroma */
1412 	REG_GET(VBLANK_PARAMETERS_1,
1413 		REFCYC_PER_PTE_GROUP_VBLANK_L, &dlg_attr.refcyc_per_pte_group_vblank_l);
1414 	if (REG(NOM_PARAMETERS_0))
1415 		REG_GET(NOM_PARAMETERS_0,
1416 			DST_Y_PER_PTE_ROW_NOM_L, &dlg_attr.dst_y_per_pte_row_nom_l);
1417 	if (REG(NOM_PARAMETERS_1))
1418 		REG_GET(NOM_PARAMETERS_1,
1419 			REFCYC_PER_PTE_GROUP_NOM_L, &dlg_attr.refcyc_per_pte_group_nom_l);
1420 	REG_GET(NOM_PARAMETERS_4,
1421 		DST_Y_PER_META_ROW_NOM_L, &dlg_attr.dst_y_per_meta_row_nom_l);
1422 	REG_GET(NOM_PARAMETERS_5,
1423 		REFCYC_PER_META_CHUNK_NOM_L, &dlg_attr.refcyc_per_meta_chunk_nom_l);
1424 	REG_GET_2(PER_LINE_DELIVERY,
1425 		REFCYC_PER_LINE_DELIVERY_L, &dlg_attr.refcyc_per_line_delivery_l,
1426 		REFCYC_PER_LINE_DELIVERY_C, &dlg_attr.refcyc_per_line_delivery_c);
1427 	REG_GET_2(PER_LINE_DELIVERY_PRE,
1428 		REFCYC_PER_LINE_DELIVERY_PRE_L, &dlg_attr.refcyc_per_line_delivery_pre_l,
1429 		REFCYC_PER_LINE_DELIVERY_PRE_C, &dlg_attr.refcyc_per_line_delivery_pre_c);
1430 	REG_GET(VBLANK_PARAMETERS_2,
1431 		REFCYC_PER_PTE_GROUP_VBLANK_C, &dlg_attr.refcyc_per_pte_group_vblank_c);
1432 	if (REG(NOM_PARAMETERS_2))
1433 		REG_GET(NOM_PARAMETERS_2,
1434 			DST_Y_PER_PTE_ROW_NOM_C, &dlg_attr.dst_y_per_pte_row_nom_c);
1435 	if (REG(NOM_PARAMETERS_3))
1436 		REG_GET(NOM_PARAMETERS_3,
1437 			REFCYC_PER_PTE_GROUP_NOM_C, &dlg_attr.refcyc_per_pte_group_nom_c);
1438 	REG_GET(NOM_PARAMETERS_6,
1439 		DST_Y_PER_META_ROW_NOM_C, &dlg_attr.dst_y_per_meta_row_nom_c);
1440 	REG_GET(NOM_PARAMETERS_7,
1441 		REFCYC_PER_META_CHUNK_NOM_C, &dlg_attr.refcyc_per_meta_chunk_nom_c);
1442 	REG_GET(VBLANK_PARAMETERS_3,
1443 			REFCYC_PER_META_CHUNK_VBLANK_L, &dlg_attr.refcyc_per_meta_chunk_vblank_l);
1444 	REG_GET(VBLANK_PARAMETERS_4,
1445 			REFCYC_PER_META_CHUNK_VBLANK_C, &dlg_attr.refcyc_per_meta_chunk_vblank_c);
1446 
1447 	if (dlg_attr.refcyc_per_pte_group_vblank_l != dml_dlg_attr->refcyc_per_pte_group_vblank_l)
1448 		DC_LOG_DEBUG("DML Validation | VBLANK_PARAMETERS_1:REFCYC_PER_PTE_GROUP_VBLANK_L - Expected: %u  Actual: %u\n",
1449 				dml_dlg_attr->refcyc_per_pte_group_vblank_l, dlg_attr.refcyc_per_pte_group_vblank_l);
1450 	if (dlg_attr.dst_y_per_pte_row_nom_l != dml_dlg_attr->dst_y_per_pte_row_nom_l)
1451 		DC_LOG_DEBUG("DML Validation | NOM_PARAMETERS_0:DST_Y_PER_PTE_ROW_NOM_L - Expected: %u  Actual: %u\n",
1452 				dml_dlg_attr->dst_y_per_pte_row_nom_l, dlg_attr.dst_y_per_pte_row_nom_l);
1453 	if (dlg_attr.refcyc_per_pte_group_nom_l != dml_dlg_attr->refcyc_per_pte_group_nom_l)
1454 		DC_LOG_DEBUG("DML Validation | NOM_PARAMETERS_1:REFCYC_PER_PTE_GROUP_NOM_L - Expected: %u  Actual: %u\n",
1455 				dml_dlg_attr->refcyc_per_pte_group_nom_l, dlg_attr.refcyc_per_pte_group_nom_l);
1456 	if (dlg_attr.dst_y_per_meta_row_nom_l != dml_dlg_attr->dst_y_per_meta_row_nom_l)
1457 		DC_LOG_DEBUG("DML Validation | NOM_PARAMETERS_4:DST_Y_PER_META_ROW_NOM_L - Expected: %u  Actual: %u\n",
1458 				dml_dlg_attr->dst_y_per_meta_row_nom_l, dlg_attr.dst_y_per_meta_row_nom_l);
1459 	if (dlg_attr.refcyc_per_meta_chunk_nom_l != dml_dlg_attr->refcyc_per_meta_chunk_nom_l)
1460 		DC_LOG_DEBUG("DML Validation | NOM_PARAMETERS_5:REFCYC_PER_META_CHUNK_NOM_L - Expected: %u  Actual: %u\n",
1461 				dml_dlg_attr->refcyc_per_meta_chunk_nom_l, dlg_attr.refcyc_per_meta_chunk_nom_l);
1462 	if (dlg_attr.refcyc_per_line_delivery_l != dml_dlg_attr->refcyc_per_line_delivery_l)
1463 		DC_LOG_DEBUG("DML Validation | PER_LINE_DELIVERY:REFCYC_PER_LINE_DELIVERY_L - Expected: %u  Actual: %u\n",
1464 				dml_dlg_attr->refcyc_per_line_delivery_l, dlg_attr.refcyc_per_line_delivery_l);
1465 	if (dlg_attr.refcyc_per_line_delivery_c != dml_dlg_attr->refcyc_per_line_delivery_c)
1466 		DC_LOG_DEBUG("DML Validation | PER_LINE_DELIVERY:REFCYC_PER_LINE_DELIVERY_C - Expected: %u  Actual: %u\n",
1467 				dml_dlg_attr->refcyc_per_line_delivery_c, dlg_attr.refcyc_per_line_delivery_c);
1468 	if (dlg_attr.refcyc_per_pte_group_vblank_c != dml_dlg_attr->refcyc_per_pte_group_vblank_c)
1469 		DC_LOG_DEBUG("DML Validation | VBLANK_PARAMETERS_2:REFCYC_PER_PTE_GROUP_VBLANK_C - Expected: %u  Actual: %u\n",
1470 				dml_dlg_attr->refcyc_per_pte_group_vblank_c, dlg_attr.refcyc_per_pte_group_vblank_c);
1471 	if (dlg_attr.dst_y_per_pte_row_nom_c != dml_dlg_attr->dst_y_per_pte_row_nom_c)
1472 		DC_LOG_DEBUG("DML Validation | NOM_PARAMETERS_2:DST_Y_PER_PTE_ROW_NOM_C - Expected: %u  Actual: %u\n",
1473 				dml_dlg_attr->dst_y_per_pte_row_nom_c, dlg_attr.dst_y_per_pte_row_nom_c);
1474 	if (dlg_attr.refcyc_per_pte_group_nom_c != dml_dlg_attr->refcyc_per_pte_group_nom_c)
1475 		DC_LOG_DEBUG("DML Validation | NOM_PARAMETERS_3:REFCYC_PER_PTE_GROUP_NOM_C - Expected: %u  Actual: %u\n",
1476 				dml_dlg_attr->refcyc_per_pte_group_nom_c, dlg_attr.refcyc_per_pte_group_nom_c);
1477 	if (dlg_attr.dst_y_per_meta_row_nom_c != dml_dlg_attr->dst_y_per_meta_row_nom_c)
1478 		DC_LOG_DEBUG("DML Validation | NOM_PARAMETERS_6:DST_Y_PER_META_ROW_NOM_C - Expected: %u  Actual: %u\n",
1479 				dml_dlg_attr->dst_y_per_meta_row_nom_c, dlg_attr.dst_y_per_meta_row_nom_c);
1480 	if (dlg_attr.refcyc_per_meta_chunk_nom_c != dml_dlg_attr->refcyc_per_meta_chunk_nom_c)
1481 		DC_LOG_DEBUG("DML Validation | NOM_PARAMETERS_7:REFCYC_PER_META_CHUNK_NOM_C - Expected: %u  Actual: %u\n",
1482 				dml_dlg_attr->refcyc_per_meta_chunk_nom_c, dlg_attr.refcyc_per_meta_chunk_nom_c);
1483 	if (dlg_attr.refcyc_per_line_delivery_pre_l != dml_dlg_attr->refcyc_per_line_delivery_pre_l)
1484 		DC_LOG_DEBUG("DML Validation | PER_LINE_DELIVERY_PRE:REFCYC_PER_LINE_DELIVERY_PRE_L - Expected: %u  Actual: %u\n",
1485 				dml_dlg_attr->refcyc_per_line_delivery_pre_l, dlg_attr.refcyc_per_line_delivery_pre_l);
1486 	if (dlg_attr.refcyc_per_line_delivery_pre_c != dml_dlg_attr->refcyc_per_line_delivery_pre_c)
1487 		DC_LOG_DEBUG("DML Validation | PER_LINE_DELIVERY_PRE:REFCYC_PER_LINE_DELIVERY_PRE_C - Expected: %u  Actual: %u\n",
1488 				dml_dlg_attr->refcyc_per_line_delivery_pre_c, dlg_attr.refcyc_per_line_delivery_pre_c);
1489 	if (dlg_attr.refcyc_per_meta_chunk_vblank_l != dml_dlg_attr->refcyc_per_meta_chunk_vblank_l)
1490 		DC_LOG_DEBUG("DML Validation | VBLANK_PARAMETERS_3:REFCYC_PER_META_CHUNK_VBLANK_L - Expected: %u  Actual: %u\n",
1491 				dml_dlg_attr->refcyc_per_meta_chunk_vblank_l, dlg_attr.refcyc_per_meta_chunk_vblank_l);
1492 	if (dlg_attr.refcyc_per_meta_chunk_vblank_c != dml_dlg_attr->refcyc_per_meta_chunk_vblank_c)
1493 		DC_LOG_DEBUG("DML Validation | VBLANK_PARAMETERS_4:REFCYC_PER_META_CHUNK_VBLANK_C - Expected: %u  Actual: %u\n",
1494 				dml_dlg_attr->refcyc_per_meta_chunk_vblank_c, dlg_attr.refcyc_per_meta_chunk_vblank_c);
1495 
1496 	/* TTU - per hubp */
1497 	REG_GET_2(DCN_TTU_QOS_WM,
1498 		QoS_LEVEL_LOW_WM, &ttu_attr.qos_level_low_wm,
1499 		QoS_LEVEL_HIGH_WM, &ttu_attr.qos_level_high_wm);
1500 
1501 	if (ttu_attr.qos_level_low_wm != dml_ttu_attr->qos_level_low_wm)
1502 		DC_LOG_DEBUG("DML Validation | DCN_TTU_QOS_WM:QoS_LEVEL_LOW_WM - Expected: %u  Actual: %u\n",
1503 				dml_ttu_attr->qos_level_low_wm, ttu_attr.qos_level_low_wm);
1504 	if (ttu_attr.qos_level_high_wm != dml_ttu_attr->qos_level_high_wm)
1505 		DC_LOG_DEBUG("DML Validation | DCN_TTU_QOS_WM:QoS_LEVEL_HIGH_WM - Expected: %u  Actual: %u\n",
1506 				dml_ttu_attr->qos_level_high_wm, ttu_attr.qos_level_high_wm);
1507 
1508 	/* TTU - per luma/chroma */
1509 	/* Assumed surf0 is luma and 1 is chroma */
1510 	REG_GET_3(DCN_SURF0_TTU_CNTL0,
1511 		REFCYC_PER_REQ_DELIVERY, &ttu_attr.refcyc_per_req_delivery_l,
1512 		QoS_LEVEL_FIXED, &ttu_attr.qos_level_fixed_l,
1513 		QoS_RAMP_DISABLE, &ttu_attr.qos_ramp_disable_l);
1514 	REG_GET_3(DCN_SURF1_TTU_CNTL0,
1515 		REFCYC_PER_REQ_DELIVERY, &ttu_attr.refcyc_per_req_delivery_c,
1516 		QoS_LEVEL_FIXED, &ttu_attr.qos_level_fixed_c,
1517 		QoS_RAMP_DISABLE, &ttu_attr.qos_ramp_disable_c);
1518 	REG_GET_3(DCN_CUR0_TTU_CNTL0,
1519 		REFCYC_PER_REQ_DELIVERY, &ttu_attr.refcyc_per_req_delivery_cur0,
1520 		QoS_LEVEL_FIXED, &ttu_attr.qos_level_fixed_cur0,
1521 		QoS_RAMP_DISABLE, &ttu_attr.qos_ramp_disable_cur0);
1522 	REG_GET(FLIP_PARAMETERS_1,
1523 		REFCYC_PER_PTE_GROUP_FLIP_L, &dlg_attr.refcyc_per_pte_group_flip_l);
1524 	REG_GET(DCN_CUR0_TTU_CNTL1,
1525 			REFCYC_PER_REQ_DELIVERY_PRE, &ttu_attr.refcyc_per_req_delivery_pre_cur0);
1526 	REG_GET(DCN_CUR1_TTU_CNTL1,
1527 			REFCYC_PER_REQ_DELIVERY_PRE, &ttu_attr.refcyc_per_req_delivery_pre_cur1);
1528 	REG_GET(DCN_SURF0_TTU_CNTL1,
1529 			REFCYC_PER_REQ_DELIVERY_PRE, &ttu_attr.refcyc_per_req_delivery_pre_l);
1530 	REG_GET(DCN_SURF1_TTU_CNTL1,
1531 			REFCYC_PER_REQ_DELIVERY_PRE, &ttu_attr.refcyc_per_req_delivery_pre_c);
1532 
1533 	if (ttu_attr.refcyc_per_req_delivery_l != dml_ttu_attr->refcyc_per_req_delivery_l)
1534 		DC_LOG_DEBUG("DML Validation | DCN_SURF0_TTU_CNTL0:REFCYC_PER_REQ_DELIVERY - Expected: %u  Actual: %u\n",
1535 				dml_ttu_attr->refcyc_per_req_delivery_l, ttu_attr.refcyc_per_req_delivery_l);
1536 	if (ttu_attr.qos_level_fixed_l != dml_ttu_attr->qos_level_fixed_l)
1537 		DC_LOG_DEBUG("DML Validation | DCN_SURF0_TTU_CNTL0:QoS_LEVEL_FIXED - Expected: %u  Actual: %u\n",
1538 				dml_ttu_attr->qos_level_fixed_l, ttu_attr.qos_level_fixed_l);
1539 	if (ttu_attr.qos_ramp_disable_l != dml_ttu_attr->qos_ramp_disable_l)
1540 		DC_LOG_DEBUG("DML Validation | DCN_SURF0_TTU_CNTL0:QoS_RAMP_DISABLE - Expected: %u  Actual: %u\n",
1541 				dml_ttu_attr->qos_ramp_disable_l, ttu_attr.qos_ramp_disable_l);
1542 	if (ttu_attr.refcyc_per_req_delivery_c != dml_ttu_attr->refcyc_per_req_delivery_c)
1543 		DC_LOG_DEBUG("DML Validation | DCN_SURF1_TTU_CNTL0:REFCYC_PER_REQ_DELIVERY - Expected: %u  Actual: %u\n",
1544 				dml_ttu_attr->refcyc_per_req_delivery_c, ttu_attr.refcyc_per_req_delivery_c);
1545 	if (ttu_attr.qos_level_fixed_c != dml_ttu_attr->qos_level_fixed_c)
1546 		DC_LOG_DEBUG("DML Validation | DCN_SURF1_TTU_CNTL0:QoS_LEVEL_FIXED - Expected: %u  Actual: %u\n",
1547 				dml_ttu_attr->qos_level_fixed_c, ttu_attr.qos_level_fixed_c);
1548 	if (ttu_attr.qos_ramp_disable_c != dml_ttu_attr->qos_ramp_disable_c)
1549 		DC_LOG_DEBUG("DML Validation | DCN_SURF1_TTU_CNTL0:QoS_RAMP_DISABLE - Expected: %u  Actual: %u\n",
1550 				dml_ttu_attr->qos_ramp_disable_c, ttu_attr.qos_ramp_disable_c);
1551 	if (ttu_attr.refcyc_per_req_delivery_cur0 != dml_ttu_attr->refcyc_per_req_delivery_cur0)
1552 		DC_LOG_DEBUG("DML Validation | DCN_CUR0_TTU_CNTL0:REFCYC_PER_REQ_DELIVERY - Expected: %u  Actual: %u\n",
1553 				dml_ttu_attr->refcyc_per_req_delivery_cur0, ttu_attr.refcyc_per_req_delivery_cur0);
1554 	if (ttu_attr.qos_level_fixed_cur0 != dml_ttu_attr->qos_level_fixed_cur0)
1555 		DC_LOG_DEBUG("DML Validation | DCN_CUR0_TTU_CNTL0:QoS_LEVEL_FIXED - Expected: %u  Actual: %u\n",
1556 				dml_ttu_attr->qos_level_fixed_cur0, ttu_attr.qos_level_fixed_cur0);
1557 	if (ttu_attr.qos_ramp_disable_cur0 != dml_ttu_attr->qos_ramp_disable_cur0)
1558 		DC_LOG_DEBUG("DML Validation | DCN_CUR0_TTU_CNTL0:QoS_RAMP_DISABLE - Expected: %u  Actual: %u\n",
1559 				dml_ttu_attr->qos_ramp_disable_cur0, ttu_attr.qos_ramp_disable_cur0);
1560 	if (dlg_attr.refcyc_per_pte_group_flip_l != dml_dlg_attr->refcyc_per_pte_group_flip_l)
1561 		DC_LOG_DEBUG("DML Validation | FLIP_PARAMETERS_1:REFCYC_PER_PTE_GROUP_FLIP_L - Expected: %u  Actual: %u\n",
1562 				dml_dlg_attr->refcyc_per_pte_group_flip_l, dlg_attr.refcyc_per_pte_group_flip_l);
1563 	if (ttu_attr.refcyc_per_req_delivery_pre_cur0 != dml_ttu_attr->refcyc_per_req_delivery_pre_cur0)
1564 		DC_LOG_DEBUG("DML Validation | DCN_CUR0_TTU_CNTL1:REFCYC_PER_REQ_DELIVERY_PRE - Expected: %u  Actual: %u\n",
1565 				dml_ttu_attr->refcyc_per_req_delivery_pre_cur0, ttu_attr.refcyc_per_req_delivery_pre_cur0);
1566 	if (ttu_attr.refcyc_per_req_delivery_pre_cur1 != dml_ttu_attr->refcyc_per_req_delivery_pre_cur1)
1567 		DC_LOG_DEBUG("DML Validation | DCN_CUR1_TTU_CNTL1:REFCYC_PER_REQ_DELIVERY_PRE - Expected: %u  Actual: %u\n",
1568 				dml_ttu_attr->refcyc_per_req_delivery_pre_cur1, ttu_attr.refcyc_per_req_delivery_pre_cur1);
1569 	if (ttu_attr.refcyc_per_req_delivery_pre_l != dml_ttu_attr->refcyc_per_req_delivery_pre_l)
1570 		DC_LOG_DEBUG("DML Validation | DCN_SURF0_TTU_CNTL1:REFCYC_PER_REQ_DELIVERY_PRE - Expected: %u  Actual: %u\n",
1571 				dml_ttu_attr->refcyc_per_req_delivery_pre_l, ttu_attr.refcyc_per_req_delivery_pre_l);
1572 	if (ttu_attr.refcyc_per_req_delivery_pre_c != dml_ttu_attr->refcyc_per_req_delivery_pre_c)
1573 		DC_LOG_DEBUG("DML Validation | DCN_SURF1_TTU_CNTL1:REFCYC_PER_REQ_DELIVERY_PRE - Expected: %u  Actual: %u\n",
1574 				dml_ttu_attr->refcyc_per_req_delivery_pre_c, ttu_attr.refcyc_per_req_delivery_pre_c);
1575 }
1576 
1577 static struct hubp_funcs dcn20_hubp_funcs = {
1578 	.hubp_enable_tripleBuffer = hubp2_enable_triplebuffer,
1579 	.hubp_is_triplebuffer_enabled = hubp2_is_triplebuffer_enabled,
1580 	.hubp_program_surface_flip_and_addr = hubp2_program_surface_flip_and_addr,
1581 	.hubp_program_surface_config = hubp2_program_surface_config,
1582 	.hubp_is_flip_pending = hubp2_is_flip_pending,
1583 	.hubp_setup = hubp2_setup,
1584 	.hubp_setup_interdependent = hubp2_setup_interdependent,
1585 	.hubp_set_vm_system_aperture_settings = hubp2_set_vm_system_aperture_settings,
1586 	.set_blank = hubp2_set_blank,
1587 	.dcc_control = hubp2_dcc_control,
1588 	.mem_program_viewport = min_set_viewport,
1589 	.set_cursor_attributes	= hubp2_cursor_set_attributes,
1590 	.set_cursor_position	= hubp2_cursor_set_position,
1591 	.hubp_clk_cntl = hubp2_clk_cntl,
1592 	.hubp_vtg_sel = hubp2_vtg_sel,
1593 	.dmdata_set_attributes = hubp2_dmdata_set_attributes,
1594 	.dmdata_load = hubp2_dmdata_load,
1595 	.dmdata_status_done = hubp2_dmdata_status_done,
1596 	.hubp_read_state = hubp2_read_state,
1597 	.hubp_clear_underflow = hubp2_clear_underflow,
1598 	.hubp_set_flip_control_surface_gsl = hubp2_set_flip_control_surface_gsl,
1599 	.hubp_init = hubp1_init,
1600 	.validate_dml_output = hubp2_validate_dml_output,
1601 	.hubp_in_blank = hubp1_in_blank,
1602 	.hubp_soft_reset = hubp1_soft_reset,
1603 	.hubp_set_flip_int = hubp1_set_flip_int,
1604 };
1605 
1606 
1607 bool hubp2_construct(
1608 	struct dcn20_hubp *hubp2,
1609 	struct dc_context *ctx,
1610 	uint32_t inst,
1611 	const struct dcn_hubp2_registers *hubp_regs,
1612 	const struct dcn_hubp2_shift *hubp_shift,
1613 	const struct dcn_hubp2_mask *hubp_mask)
1614 {
1615 	hubp2->base.funcs = &dcn20_hubp_funcs;
1616 	hubp2->base.ctx = ctx;
1617 	hubp2->hubp_regs = hubp_regs;
1618 	hubp2->hubp_shift = hubp_shift;
1619 	hubp2->hubp_mask = hubp_mask;
1620 	hubp2->base.inst = inst;
1621 	hubp2->base.opp_id = OPP_ID_INVALID;
1622 	hubp2->base.mpcc_id = 0xf;
1623 
1624 	return true;
1625 }
1626