1 /*
2  * Copyright 2012-17 Advanced Micro Devices, Inc.
3  *
4  * Permission is hereby granted, free of charge, to any person obtaining a
5  * copy of this software and associated documentation files (the "Software"),
6  * to deal in the Software without restriction, including without limitation
7  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
8  * and/or sell copies of the Software, and to permit persons to whom the
9  * Software is furnished to do so, subject to the following conditions:
10  *
11  * The above copyright notice and this permission notice shall be included in
12  * all copies or substantial portions of the Software.
13  *
14  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
15  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
16  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
17  * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
18  * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
19  * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
20  * OTHER DEALINGS IN THE SOFTWARE.
21  *
22  * Authors: AMD
23  *
24  */
25 
26 #include "dcn20_hubp.h"
27 
28 #include "dm_services.h"
29 #include "dce_calcs.h"
30 #include "reg_helper.h"
31 #include "basics/conversion.h"
32 
33 #define DC_LOGGER_INIT(logger)
34 
35 #define REG(reg)\
36 	hubp2->hubp_regs->reg
37 
38 #define CTX \
39 	hubp2->base.ctx
40 
41 #undef FN
42 #define FN(reg_name, field_name) \
43 	hubp2->hubp_shift->field_name, hubp2->hubp_mask->field_name
44 
45 void hubp2_set_vm_system_aperture_settings(struct hubp *hubp,
46 		struct vm_system_aperture_param *apt)
47 {
48 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
49 
50 	PHYSICAL_ADDRESS_LOC mc_vm_apt_default;
51 	PHYSICAL_ADDRESS_LOC mc_vm_apt_low;
52 	PHYSICAL_ADDRESS_LOC mc_vm_apt_high;
53 
54 	// The format of default addr is 48:12 of the 48 bit addr
55 	mc_vm_apt_default.quad_part = apt->sys_default.quad_part >> 12;
56 
57 	// The format of high/low are 48:18 of the 48 bit addr
58 	mc_vm_apt_low.quad_part = apt->sys_low.quad_part >> 18;
59 	mc_vm_apt_high.quad_part = apt->sys_high.quad_part >> 18;
60 
61 	REG_UPDATE_2(DCN_VM_SYSTEM_APERTURE_DEFAULT_ADDR_MSB,
62 		DCN_VM_SYSTEM_APERTURE_DEFAULT_SYSTEM, 1, /* 1 = system physical memory */
63 		DCN_VM_SYSTEM_APERTURE_DEFAULT_ADDR_MSB, mc_vm_apt_default.high_part);
64 
65 	REG_SET(DCN_VM_SYSTEM_APERTURE_DEFAULT_ADDR_LSB, 0,
66 			DCN_VM_SYSTEM_APERTURE_DEFAULT_ADDR_LSB, mc_vm_apt_default.low_part);
67 
68 	REG_SET(DCN_VM_SYSTEM_APERTURE_LOW_ADDR, 0,
69 			MC_VM_SYSTEM_APERTURE_LOW_ADDR, mc_vm_apt_low.quad_part);
70 
71 	REG_SET(DCN_VM_SYSTEM_APERTURE_HIGH_ADDR, 0,
72 			MC_VM_SYSTEM_APERTURE_HIGH_ADDR, mc_vm_apt_high.quad_part);
73 
74 	REG_SET_2(DCN_VM_MX_L1_TLB_CNTL, 0,
75 			ENABLE_L1_TLB, 1,
76 			SYSTEM_ACCESS_MODE, 0x3);
77 }
78 
79 void hubp2_program_deadline(
80 		struct hubp *hubp,
81 		struct _vcs_dpi_display_dlg_regs_st *dlg_attr,
82 		struct _vcs_dpi_display_ttu_regs_st *ttu_attr)
83 {
84 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
85 
86 	/* DLG - Per hubp */
87 	REG_SET_2(BLANK_OFFSET_0, 0,
88 		REFCYC_H_BLANK_END, dlg_attr->refcyc_h_blank_end,
89 		DLG_V_BLANK_END, dlg_attr->dlg_vblank_end);
90 
91 	REG_SET(BLANK_OFFSET_1, 0,
92 		MIN_DST_Y_NEXT_START, dlg_attr->min_dst_y_next_start);
93 
94 	REG_SET(DST_DIMENSIONS, 0,
95 		REFCYC_PER_HTOTAL, dlg_attr->refcyc_per_htotal);
96 
97 	REG_SET_2(DST_AFTER_SCALER, 0,
98 		REFCYC_X_AFTER_SCALER, dlg_attr->refcyc_x_after_scaler,
99 		DST_Y_AFTER_SCALER, dlg_attr->dst_y_after_scaler);
100 
101 	REG_SET(REF_FREQ_TO_PIX_FREQ, 0,
102 		REF_FREQ_TO_PIX_FREQ, dlg_attr->ref_freq_to_pix_freq);
103 
104 	/* DLG - Per luma/chroma */
105 	REG_SET(VBLANK_PARAMETERS_1, 0,
106 		REFCYC_PER_PTE_GROUP_VBLANK_L, dlg_attr->refcyc_per_pte_group_vblank_l);
107 
108 	if (REG(NOM_PARAMETERS_0))
109 		REG_SET(NOM_PARAMETERS_0, 0,
110 			DST_Y_PER_PTE_ROW_NOM_L, dlg_attr->dst_y_per_pte_row_nom_l);
111 
112 	if (REG(NOM_PARAMETERS_1))
113 		REG_SET(NOM_PARAMETERS_1, 0,
114 			REFCYC_PER_PTE_GROUP_NOM_L, dlg_attr->refcyc_per_pte_group_nom_l);
115 
116 	REG_SET(NOM_PARAMETERS_4, 0,
117 		DST_Y_PER_META_ROW_NOM_L, dlg_attr->dst_y_per_meta_row_nom_l);
118 
119 	REG_SET(NOM_PARAMETERS_5, 0,
120 		REFCYC_PER_META_CHUNK_NOM_L, dlg_attr->refcyc_per_meta_chunk_nom_l);
121 
122 	REG_SET_2(PER_LINE_DELIVERY, 0,
123 		REFCYC_PER_LINE_DELIVERY_L, dlg_attr->refcyc_per_line_delivery_l,
124 		REFCYC_PER_LINE_DELIVERY_C, dlg_attr->refcyc_per_line_delivery_c);
125 
126 	REG_SET(VBLANK_PARAMETERS_2, 0,
127 		REFCYC_PER_PTE_GROUP_VBLANK_C, dlg_attr->refcyc_per_pte_group_vblank_c);
128 
129 	if (REG(NOM_PARAMETERS_2))
130 		REG_SET(NOM_PARAMETERS_2, 0,
131 			DST_Y_PER_PTE_ROW_NOM_C, dlg_attr->dst_y_per_pte_row_nom_c);
132 
133 	if (REG(NOM_PARAMETERS_3))
134 		REG_SET(NOM_PARAMETERS_3, 0,
135 			REFCYC_PER_PTE_GROUP_NOM_C, dlg_attr->refcyc_per_pte_group_nom_c);
136 
137 	REG_SET(NOM_PARAMETERS_6, 0,
138 		DST_Y_PER_META_ROW_NOM_C, dlg_attr->dst_y_per_meta_row_nom_c);
139 
140 	REG_SET(NOM_PARAMETERS_7, 0,
141 		REFCYC_PER_META_CHUNK_NOM_C, dlg_attr->refcyc_per_meta_chunk_nom_c);
142 
143 	/* TTU - per hubp */
144 	REG_SET_2(DCN_TTU_QOS_WM, 0,
145 		QoS_LEVEL_LOW_WM, ttu_attr->qos_level_low_wm,
146 		QoS_LEVEL_HIGH_WM, ttu_attr->qos_level_high_wm);
147 
148 	/* TTU - per luma/chroma */
149 	/* Assumed surf0 is luma and 1 is chroma */
150 
151 	REG_SET_3(DCN_SURF0_TTU_CNTL0, 0,
152 		REFCYC_PER_REQ_DELIVERY, ttu_attr->refcyc_per_req_delivery_l,
153 		QoS_LEVEL_FIXED, ttu_attr->qos_level_fixed_l,
154 		QoS_RAMP_DISABLE, ttu_attr->qos_ramp_disable_l);
155 
156 	REG_SET_3(DCN_SURF1_TTU_CNTL0, 0,
157 		REFCYC_PER_REQ_DELIVERY, ttu_attr->refcyc_per_req_delivery_c,
158 		QoS_LEVEL_FIXED, ttu_attr->qos_level_fixed_c,
159 		QoS_RAMP_DISABLE, ttu_attr->qos_ramp_disable_c);
160 
161 	REG_SET_3(DCN_CUR0_TTU_CNTL0, 0,
162 		REFCYC_PER_REQ_DELIVERY, ttu_attr->refcyc_per_req_delivery_cur0,
163 		QoS_LEVEL_FIXED, ttu_attr->qos_level_fixed_cur0,
164 		QoS_RAMP_DISABLE, ttu_attr->qos_ramp_disable_cur0);
165 
166 	REG_SET(FLIP_PARAMETERS_1, 0,
167 		REFCYC_PER_PTE_GROUP_FLIP_L, dlg_attr->refcyc_per_pte_group_flip_l);
168 }
169 
170 void hubp2_vready_at_or_After_vsync(struct hubp *hubp,
171 		struct _vcs_dpi_display_pipe_dest_params_st *pipe_dest)
172 {
173 	uint32_t value = 0;
174 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
175 	/* disable_dlg_test_mode Set 9th bit to 1 to disable "dv" mode */
176 	REG_WRITE(HUBPREQ_DEBUG_DB, 1 << 8);
177 	/*
178 	if (VSTARTUP_START - (VREADY_OFFSET+VUPDATE_WIDTH+VUPDATE_OFFSET)/htotal)
179 	<= OTG_V_BLANK_END
180 		Set HUBP_VREADY_AT_OR_AFTER_VSYNC = 1
181 	else
182 		Set HUBP_VREADY_AT_OR_AFTER_VSYNC = 0
183 	*/
184 	if ((pipe_dest->vstartup_start - (pipe_dest->vready_offset+pipe_dest->vupdate_width
185 		+ pipe_dest->vupdate_offset) / pipe_dest->htotal) <= pipe_dest->vblank_end) {
186 		value = 1;
187 	} else
188 		value = 0;
189 	REG_UPDATE(DCHUBP_CNTL, HUBP_VREADY_AT_OR_AFTER_VSYNC, value);
190 }
191 
192 void hubp2_program_requestor(
193 		struct hubp *hubp,
194 		struct _vcs_dpi_display_rq_regs_st *rq_regs)
195 {
196 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
197 
198 	REG_UPDATE(HUBPRET_CONTROL,
199 			DET_BUF_PLANE1_BASE_ADDRESS, rq_regs->plane1_base_address);
200 	REG_SET_4(DCN_EXPANSION_MODE, 0,
201 			DRQ_EXPANSION_MODE, rq_regs->drq_expansion_mode,
202 			PRQ_EXPANSION_MODE, rq_regs->prq_expansion_mode,
203 			MRQ_EXPANSION_MODE, rq_regs->mrq_expansion_mode,
204 			CRQ_EXPANSION_MODE, rq_regs->crq_expansion_mode);
205 	REG_SET_8(DCHUBP_REQ_SIZE_CONFIG, 0,
206 		CHUNK_SIZE, rq_regs->rq_regs_l.chunk_size,
207 		MIN_CHUNK_SIZE, rq_regs->rq_regs_l.min_chunk_size,
208 		META_CHUNK_SIZE, rq_regs->rq_regs_l.meta_chunk_size,
209 		MIN_META_CHUNK_SIZE, rq_regs->rq_regs_l.min_meta_chunk_size,
210 		DPTE_GROUP_SIZE, rq_regs->rq_regs_l.dpte_group_size,
211 		MPTE_GROUP_SIZE, rq_regs->rq_regs_l.mpte_group_size,
212 		SWATH_HEIGHT, rq_regs->rq_regs_l.swath_height,
213 		PTE_ROW_HEIGHT_LINEAR, rq_regs->rq_regs_l.pte_row_height_linear);
214 	REG_SET_8(DCHUBP_REQ_SIZE_CONFIG_C, 0,
215 		CHUNK_SIZE_C, rq_regs->rq_regs_c.chunk_size,
216 		MIN_CHUNK_SIZE_C, rq_regs->rq_regs_c.min_chunk_size,
217 		META_CHUNK_SIZE_C, rq_regs->rq_regs_c.meta_chunk_size,
218 		MIN_META_CHUNK_SIZE_C, rq_regs->rq_regs_c.min_meta_chunk_size,
219 		DPTE_GROUP_SIZE_C, rq_regs->rq_regs_c.dpte_group_size,
220 		MPTE_GROUP_SIZE_C, rq_regs->rq_regs_c.mpte_group_size,
221 		SWATH_HEIGHT_C, rq_regs->rq_regs_c.swath_height,
222 		PTE_ROW_HEIGHT_LINEAR_C, rq_regs->rq_regs_c.pte_row_height_linear);
223 }
224 
225 static void hubp2_setup(
226 		struct hubp *hubp,
227 		struct _vcs_dpi_display_dlg_regs_st *dlg_attr,
228 		struct _vcs_dpi_display_ttu_regs_st *ttu_attr,
229 		struct _vcs_dpi_display_rq_regs_st *rq_regs,
230 		struct _vcs_dpi_display_pipe_dest_params_st *pipe_dest)
231 {
232 	/* otg is locked when this func is called. Register are double buffered.
233 	 * disable the requestors is not needed
234 	 */
235 
236 	hubp2_vready_at_or_After_vsync(hubp, pipe_dest);
237 	hubp2_program_requestor(hubp, rq_regs);
238 	hubp2_program_deadline(hubp, dlg_attr, ttu_attr);
239 
240 }
241 
242 void hubp2_setup_interdependent(
243 		struct hubp *hubp,
244 		struct _vcs_dpi_display_dlg_regs_st *dlg_attr,
245 		struct _vcs_dpi_display_ttu_regs_st *ttu_attr)
246 {
247 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
248 
249 	REG_SET_2(PREFETCH_SETTINGS, 0,
250 			DST_Y_PREFETCH, dlg_attr->dst_y_prefetch,
251 			VRATIO_PREFETCH, dlg_attr->vratio_prefetch);
252 
253 	REG_SET(PREFETCH_SETTINGS_C, 0,
254 			VRATIO_PREFETCH_C, dlg_attr->vratio_prefetch_c);
255 
256 	REG_SET_2(VBLANK_PARAMETERS_0, 0,
257 		DST_Y_PER_VM_VBLANK, dlg_attr->dst_y_per_vm_vblank,
258 		DST_Y_PER_ROW_VBLANK, dlg_attr->dst_y_per_row_vblank);
259 
260 	REG_SET_2(FLIP_PARAMETERS_0, 0,
261 		DST_Y_PER_VM_FLIP, dlg_attr->dst_y_per_vm_flip,
262 		DST_Y_PER_ROW_FLIP, dlg_attr->dst_y_per_row_flip);
263 
264 	REG_SET(VBLANK_PARAMETERS_3, 0,
265 		REFCYC_PER_META_CHUNK_VBLANK_L, dlg_attr->refcyc_per_meta_chunk_vblank_l);
266 
267 	REG_SET(VBLANK_PARAMETERS_4, 0,
268 		REFCYC_PER_META_CHUNK_VBLANK_C, dlg_attr->refcyc_per_meta_chunk_vblank_c);
269 
270 	REG_SET(FLIP_PARAMETERS_2, 0,
271 		REFCYC_PER_META_CHUNK_FLIP_L, dlg_attr->refcyc_per_meta_chunk_flip_l);
272 
273 	REG_SET_2(PER_LINE_DELIVERY_PRE, 0,
274 		REFCYC_PER_LINE_DELIVERY_PRE_L, dlg_attr->refcyc_per_line_delivery_pre_l,
275 		REFCYC_PER_LINE_DELIVERY_PRE_C, dlg_attr->refcyc_per_line_delivery_pre_c);
276 
277 	REG_SET(DCN_SURF0_TTU_CNTL1, 0,
278 		REFCYC_PER_REQ_DELIVERY_PRE,
279 		ttu_attr->refcyc_per_req_delivery_pre_l);
280 	REG_SET(DCN_SURF1_TTU_CNTL1, 0,
281 		REFCYC_PER_REQ_DELIVERY_PRE,
282 		ttu_attr->refcyc_per_req_delivery_pre_c);
283 	REG_SET(DCN_CUR0_TTU_CNTL1, 0,
284 		REFCYC_PER_REQ_DELIVERY_PRE, ttu_attr->refcyc_per_req_delivery_pre_cur0);
285 	REG_SET(DCN_CUR1_TTU_CNTL1, 0,
286 		REFCYC_PER_REQ_DELIVERY_PRE, ttu_attr->refcyc_per_req_delivery_pre_cur1);
287 
288 	REG_SET_2(DCN_GLOBAL_TTU_CNTL, 0,
289 		MIN_TTU_VBLANK, ttu_attr->min_ttu_vblank,
290 		QoS_LEVEL_FLIP, ttu_attr->qos_level_flip);
291 }
292 
293 /* DCN2 (GFX10), the following GFX fields are deprecated. They can be set but they will not be used:
294  *	NUM_BANKS
295  *	NUM_SE
296  *	NUM_RB_PER_SE
297  *	RB_ALIGNED
298  * Other things can be defaulted, since they never change:
299  *	PIPE_ALIGNED = 0
300  *	META_LINEAR = 0
301  * In GFX10, only these apply:
302  *	PIPE_INTERLEAVE
303  *	NUM_PIPES
304  *	MAX_COMPRESSED_FRAGS
305  *	SW_MODE
306  */
307 static void hubp2_program_tiling(
308 	struct dcn20_hubp *hubp2,
309 	const union dc_tiling_info *info,
310 	const enum surface_pixel_format pixel_format)
311 {
312 	REG_UPDATE_3(DCSURF_ADDR_CONFIG,
313 			NUM_PIPES, log_2(info->gfx9.num_pipes),
314 			PIPE_INTERLEAVE, info->gfx9.pipe_interleave,
315 			MAX_COMPRESSED_FRAGS, log_2(info->gfx9.max_compressed_frags));
316 
317 	REG_UPDATE_4(DCSURF_TILING_CONFIG,
318 			SW_MODE, info->gfx9.swizzle,
319 			META_LINEAR, 0,
320 			RB_ALIGNED, 0,
321 			PIPE_ALIGNED, 0);
322 }
323 
324 void hubp2_program_size(
325 	struct hubp *hubp,
326 	enum surface_pixel_format format,
327 	const struct plane_size *plane_size,
328 	struct dc_plane_dcc_param *dcc)
329 {
330 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
331 	uint32_t pitch, meta_pitch, pitch_c, meta_pitch_c;
332 	bool use_pitch_c = false;
333 
334 	/* Program data and meta surface pitch (calculation from addrlib)
335 	 * 444 or 420 luma
336 	 */
337 	use_pitch_c = format >= SURFACE_PIXEL_FORMAT_VIDEO_BEGIN
338 		&& format < SURFACE_PIXEL_FORMAT_SUBSAMPLE_END;
339 	if (use_pitch_c) {
340 		ASSERT(plane_size->chroma_pitch != 0);
341 		/* Chroma pitch zero can cause system hang! */
342 
343 		pitch = plane_size->surface_pitch - 1;
344 		meta_pitch = dcc->meta_pitch - 1;
345 		pitch_c = plane_size->chroma_pitch - 1;
346 		meta_pitch_c = dcc->meta_pitch_c - 1;
347 	} else {
348 		pitch = plane_size->surface_pitch - 1;
349 		meta_pitch = dcc->meta_pitch - 1;
350 		pitch_c = 0;
351 		meta_pitch_c = 0;
352 	}
353 
354 	if (!dcc->enable) {
355 		meta_pitch = 0;
356 		meta_pitch_c = 0;
357 	}
358 
359 	REG_UPDATE_2(DCSURF_SURFACE_PITCH,
360 			PITCH, pitch, META_PITCH, meta_pitch);
361 
362 	use_pitch_c = format >= SURFACE_PIXEL_FORMAT_VIDEO_BEGIN;
363 	if (use_pitch_c)
364 		REG_UPDATE_2(DCSURF_SURFACE_PITCH_C,
365 			PITCH_C, pitch_c, META_PITCH_C, meta_pitch_c);
366 }
367 
368 void hubp2_program_rotation(
369 	struct hubp *hubp,
370 	enum dc_rotation_angle rotation,
371 	bool horizontal_mirror)
372 {
373 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
374 	uint32_t mirror;
375 
376 
377 	if (horizontal_mirror)
378 		mirror = 1;
379 	else
380 		mirror = 0;
381 
382 	/* Program rotation angle and horz mirror - no mirror */
383 	if (rotation == ROTATION_ANGLE_0)
384 		REG_UPDATE_2(DCSURF_SURFACE_CONFIG,
385 				ROTATION_ANGLE, 0,
386 				H_MIRROR_EN, mirror);
387 	else if (rotation == ROTATION_ANGLE_90)
388 		REG_UPDATE_2(DCSURF_SURFACE_CONFIG,
389 				ROTATION_ANGLE, 1,
390 				H_MIRROR_EN, mirror);
391 	else if (rotation == ROTATION_ANGLE_180)
392 		REG_UPDATE_2(DCSURF_SURFACE_CONFIG,
393 				ROTATION_ANGLE, 2,
394 				H_MIRROR_EN, mirror);
395 	else if (rotation == ROTATION_ANGLE_270)
396 		REG_UPDATE_2(DCSURF_SURFACE_CONFIG,
397 				ROTATION_ANGLE, 3,
398 				H_MIRROR_EN, mirror);
399 }
400 
401 void hubp2_dcc_control(struct hubp *hubp, bool enable,
402 		enum hubp_ind_block_size independent_64b_blks)
403 {
404 	uint32_t dcc_en = enable ? 1 : 0;
405 	uint32_t dcc_ind_64b_blk = independent_64b_blks ? 1 : 0;
406 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
407 
408 	REG_UPDATE_4(DCSURF_SURFACE_CONTROL,
409 			PRIMARY_SURFACE_DCC_EN, dcc_en,
410 			PRIMARY_SURFACE_DCC_IND_64B_BLK, dcc_ind_64b_blk,
411 			SECONDARY_SURFACE_DCC_EN, dcc_en,
412 			SECONDARY_SURFACE_DCC_IND_64B_BLK, dcc_ind_64b_blk);
413 }
414 
415 void hubp2_program_pixel_format(
416 	struct hubp *hubp,
417 	enum surface_pixel_format format)
418 {
419 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
420 	uint32_t red_bar = 3;
421 	uint32_t blue_bar = 2;
422 
423 	/* swap for ABGR format */
424 	if (format == SURFACE_PIXEL_FORMAT_GRPH_ABGR8888
425 			|| format == SURFACE_PIXEL_FORMAT_GRPH_ABGR2101010
426 			|| format == SURFACE_PIXEL_FORMAT_GRPH_ABGR2101010_XR_BIAS
427 			|| format == SURFACE_PIXEL_FORMAT_GRPH_ABGR16161616F) {
428 		red_bar = 2;
429 		blue_bar = 3;
430 	}
431 
432 	REG_UPDATE_2(HUBPRET_CONTROL,
433 			CROSSBAR_SRC_CB_B, blue_bar,
434 			CROSSBAR_SRC_CR_R, red_bar);
435 
436 	/* Mapping is same as ipp programming (cnvc) */
437 
438 	switch (format)	{
439 	case SURFACE_PIXEL_FORMAT_GRPH_ARGB1555:
440 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
441 				SURFACE_PIXEL_FORMAT, 1);
442 		break;
443 	case SURFACE_PIXEL_FORMAT_GRPH_RGB565:
444 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
445 				SURFACE_PIXEL_FORMAT, 3);
446 		break;
447 	case SURFACE_PIXEL_FORMAT_GRPH_ARGB8888:
448 	case SURFACE_PIXEL_FORMAT_GRPH_ABGR8888:
449 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
450 				SURFACE_PIXEL_FORMAT, 8);
451 		break;
452 	case SURFACE_PIXEL_FORMAT_GRPH_ARGB2101010:
453 	case SURFACE_PIXEL_FORMAT_GRPH_ABGR2101010:
454 	case SURFACE_PIXEL_FORMAT_GRPH_ABGR2101010_XR_BIAS:
455 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
456 				SURFACE_PIXEL_FORMAT, 10);
457 		break;
458 	case SURFACE_PIXEL_FORMAT_GRPH_ARGB16161616:
459 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
460 				SURFACE_PIXEL_FORMAT, 22);
461 		break;
462 	case SURFACE_PIXEL_FORMAT_GRPH_ARGB16161616F:
463 	case SURFACE_PIXEL_FORMAT_GRPH_ABGR16161616F:/*we use crossbar already*/
464 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
465 				SURFACE_PIXEL_FORMAT, 24);
466 		break;
467 
468 	case SURFACE_PIXEL_FORMAT_VIDEO_420_YCbCr:
469 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
470 				SURFACE_PIXEL_FORMAT, 65);
471 		break;
472 	case SURFACE_PIXEL_FORMAT_VIDEO_420_YCrCb:
473 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
474 				SURFACE_PIXEL_FORMAT, 64);
475 		break;
476 	case SURFACE_PIXEL_FORMAT_VIDEO_420_10bpc_YCbCr:
477 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
478 				SURFACE_PIXEL_FORMAT, 67);
479 		break;
480 	case SURFACE_PIXEL_FORMAT_VIDEO_420_10bpc_YCrCb:
481 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
482 				SURFACE_PIXEL_FORMAT, 66);
483 		break;
484 	case SURFACE_PIXEL_FORMAT_VIDEO_AYCrCb8888:
485 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
486 				SURFACE_PIXEL_FORMAT, 12);
487 		break;
488 	case SURFACE_PIXEL_FORMAT_GRPH_RGB111110_FIX:
489 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
490 				SURFACE_PIXEL_FORMAT, 112);
491 		break;
492 	case SURFACE_PIXEL_FORMAT_GRPH_BGR101111_FIX:
493 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
494 				SURFACE_PIXEL_FORMAT, 113);
495 		break;
496 	case SURFACE_PIXEL_FORMAT_VIDEO_ACrYCb2101010:
497 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
498 				SURFACE_PIXEL_FORMAT, 114);
499 		break;
500 	case SURFACE_PIXEL_FORMAT_GRPH_RGB111110_FLOAT:
501 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
502 				SURFACE_PIXEL_FORMAT, 118);
503 		break;
504 	case SURFACE_PIXEL_FORMAT_GRPH_BGR101111_FLOAT:
505 		REG_UPDATE(DCSURF_SURFACE_CONFIG,
506 				SURFACE_PIXEL_FORMAT, 119);
507 		break;
508 	default:
509 		BREAK_TO_DEBUGGER();
510 		break;
511 	}
512 
513 	/* don't see the need of program the xbar in DCN 1.0 */
514 }
515 
516 void hubp2_program_surface_config(
517 	struct hubp *hubp,
518 	enum surface_pixel_format format,
519 	union dc_tiling_info *tiling_info,
520 	struct plane_size *plane_size,
521 	enum dc_rotation_angle rotation,
522 	struct dc_plane_dcc_param *dcc,
523 	bool horizontal_mirror,
524 	unsigned int compat_level)
525 {
526 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
527 
528 	hubp2_dcc_control(hubp, dcc->enable, dcc->independent_64b_blks);
529 	hubp2_program_tiling(hubp2, tiling_info, format);
530 	hubp2_program_size(hubp, format, plane_size, dcc);
531 	hubp2_program_rotation(hubp, rotation, horizontal_mirror);
532 	hubp2_program_pixel_format(hubp, format);
533 }
534 
535 enum cursor_lines_per_chunk hubp2_get_lines_per_chunk(
536 	unsigned int cursor_width,
537 	enum dc_cursor_color_format cursor_mode)
538 {
539 	enum cursor_lines_per_chunk line_per_chunk = CURSOR_LINE_PER_CHUNK_16;
540 
541 	if (cursor_mode == CURSOR_MODE_MONO)
542 		line_per_chunk = CURSOR_LINE_PER_CHUNK_16;
543 	else if (cursor_mode == CURSOR_MODE_COLOR_1BIT_AND ||
544 		 cursor_mode == CURSOR_MODE_COLOR_PRE_MULTIPLIED_ALPHA ||
545 		 cursor_mode == CURSOR_MODE_COLOR_UN_PRE_MULTIPLIED_ALPHA) {
546 		if (cursor_width >= 1   && cursor_width <= 32)
547 			line_per_chunk = CURSOR_LINE_PER_CHUNK_16;
548 		else if (cursor_width >= 33  && cursor_width <= 64)
549 			line_per_chunk = CURSOR_LINE_PER_CHUNK_8;
550 		else if (cursor_width >= 65  && cursor_width <= 128)
551 			line_per_chunk = CURSOR_LINE_PER_CHUNK_4;
552 		else if (cursor_width >= 129 && cursor_width <= 256)
553 			line_per_chunk = CURSOR_LINE_PER_CHUNK_2;
554 	} else if (cursor_mode == CURSOR_MODE_COLOR_64BIT_FP_PRE_MULTIPLIED ||
555 		   cursor_mode == CURSOR_MODE_COLOR_64BIT_FP_UN_PRE_MULTIPLIED) {
556 		if (cursor_width >= 1   && cursor_width <= 16)
557 			line_per_chunk = CURSOR_LINE_PER_CHUNK_16;
558 		else if (cursor_width >= 17  && cursor_width <= 32)
559 			line_per_chunk = CURSOR_LINE_PER_CHUNK_8;
560 		else if (cursor_width >= 33  && cursor_width <= 64)
561 			line_per_chunk = CURSOR_LINE_PER_CHUNK_4;
562 		else if (cursor_width >= 65 && cursor_width <= 128)
563 			line_per_chunk = CURSOR_LINE_PER_CHUNK_2;
564 		else if (cursor_width >= 129 && cursor_width <= 256)
565 			line_per_chunk = CURSOR_LINE_PER_CHUNK_1;
566 	}
567 
568 	return line_per_chunk;
569 }
570 
571 void hubp2_cursor_set_attributes(
572 		struct hubp *hubp,
573 		const struct dc_cursor_attributes *attr)
574 {
575 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
576 	enum cursor_pitch hw_pitch = hubp1_get_cursor_pitch(attr->pitch);
577 	enum cursor_lines_per_chunk lpc = hubp2_get_lines_per_chunk(
578 			attr->width, attr->color_format);
579 
580 	hubp->curs_attr = *attr;
581 
582 	REG_UPDATE(CURSOR_SURFACE_ADDRESS_HIGH,
583 			CURSOR_SURFACE_ADDRESS_HIGH, attr->address.high_part);
584 	REG_UPDATE(CURSOR_SURFACE_ADDRESS,
585 			CURSOR_SURFACE_ADDRESS, attr->address.low_part);
586 
587 	REG_UPDATE_2(CURSOR_SIZE,
588 			CURSOR_WIDTH, attr->width,
589 			CURSOR_HEIGHT, attr->height);
590 
591 	REG_UPDATE_4(CURSOR_CONTROL,
592 			CURSOR_MODE, attr->color_format,
593 			CURSOR_2X_MAGNIFY, attr->attribute_flags.bits.ENABLE_MAGNIFICATION,
594 			CURSOR_PITCH, hw_pitch,
595 			CURSOR_LINES_PER_CHUNK, lpc);
596 
597 	REG_SET_2(CURSOR_SETTINGS, 0,
598 			/* no shift of the cursor HDL schedule */
599 			CURSOR0_DST_Y_OFFSET, 0,
600 			 /* used to shift the cursor chunk request deadline */
601 			CURSOR0_CHUNK_HDL_ADJUST, 3);
602 }
603 
604 void hubp2_dmdata_set_attributes(
605 		struct hubp *hubp,
606 		const struct dc_dmdata_attributes *attr)
607 {
608 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
609 
610 	if (attr->dmdata_mode == DMDATA_HW_MODE) {
611 		/* set to HW mode */
612 		REG_UPDATE(DMDATA_CNTL,
613 				DMDATA_MODE, 1);
614 
615 		/* for DMDATA flip, need to use SURFACE_UPDATE_LOCK */
616 		REG_UPDATE(DCSURF_FLIP_CONTROL, SURFACE_UPDATE_LOCK, 1);
617 
618 		/* toggle DMDATA_UPDATED and set repeat and size */
619 		REG_UPDATE(DMDATA_CNTL,
620 				DMDATA_UPDATED, 0);
621 		REG_UPDATE_3(DMDATA_CNTL,
622 				DMDATA_UPDATED, 1,
623 				DMDATA_REPEAT, attr->dmdata_repeat,
624 				DMDATA_SIZE, attr->dmdata_size);
625 
626 		/* set DMDATA address */
627 		REG_WRITE(DMDATA_ADDRESS_LOW, attr->address.low_part);
628 		REG_UPDATE(DMDATA_ADDRESS_HIGH,
629 				DMDATA_ADDRESS_HIGH, attr->address.high_part);
630 
631 		REG_UPDATE(DCSURF_FLIP_CONTROL, SURFACE_UPDATE_LOCK, 0);
632 
633 	} else {
634 		/* set to SW mode before loading data */
635 		REG_SET(DMDATA_CNTL, 0,
636 				DMDATA_MODE, 0);
637 		/* toggle DMDATA_SW_UPDATED to start loading sequence */
638 		REG_UPDATE(DMDATA_SW_CNTL,
639 				DMDATA_SW_UPDATED, 0);
640 		REG_UPDATE_3(DMDATA_SW_CNTL,
641 				DMDATA_SW_UPDATED, 1,
642 				DMDATA_SW_REPEAT, attr->dmdata_repeat,
643 				DMDATA_SW_SIZE, attr->dmdata_size);
644 		/* load data into hubp dmdata buffer */
645 		hubp2_dmdata_load(hubp, attr->dmdata_size, attr->dmdata_sw_data);
646 	}
647 
648 	/* Note that DL_DELTA must be programmed if we want to use TTU mode */
649 	REG_SET_3(DMDATA_QOS_CNTL, 0,
650 			DMDATA_QOS_MODE, attr->dmdata_qos_mode,
651 			DMDATA_QOS_LEVEL, attr->dmdata_qos_level,
652 			DMDATA_DL_DELTA, attr->dmdata_dl_delta);
653 }
654 
655 void hubp2_dmdata_load(
656 		struct hubp *hubp,
657 		uint32_t dmdata_sw_size,
658 		const uint32_t *dmdata_sw_data)
659 {
660 	int i;
661 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
662 
663 	/* load dmdata into HUBP buffer in SW mode */
664 	for (i = 0; i < dmdata_sw_size / 4; i++)
665 		REG_WRITE(DMDATA_SW_DATA, dmdata_sw_data[i]);
666 }
667 
668 bool hubp2_dmdata_status_done(struct hubp *hubp)
669 {
670 	uint32_t status;
671 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
672 
673 	REG_GET(DMDATA_STATUS, DMDATA_DONE, &status);
674 	return (status == 1);
675 }
676 
677 bool hubp2_program_surface_flip_and_addr(
678 	struct hubp *hubp,
679 	const struct dc_plane_address *address,
680 	bool flip_immediate)
681 {
682 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
683 
684 	//program flip type
685 	REG_UPDATE(DCSURF_FLIP_CONTROL,
686 			SURFACE_FLIP_TYPE, flip_immediate);
687 
688 	// Program VMID reg
689 	REG_UPDATE(VMID_SETTINGS_0,
690 			VMID, address->vmid);
691 
692 	if (address->type == PLN_ADDR_TYPE_GRPH_STEREO) {
693 		REG_UPDATE(DCSURF_FLIP_CONTROL, SURFACE_FLIP_MODE_FOR_STEREOSYNC, 0x1);
694 		REG_UPDATE(DCSURF_FLIP_CONTROL, SURFACE_FLIP_IN_STEREOSYNC, 0x1);
695 
696 	} else {
697 		// turn off stereo if not in stereo
698 		REG_UPDATE(DCSURF_FLIP_CONTROL, SURFACE_FLIP_MODE_FOR_STEREOSYNC, 0x0);
699 		REG_UPDATE(DCSURF_FLIP_CONTROL, SURFACE_FLIP_IN_STEREOSYNC, 0x0);
700 	}
701 
702 
703 
704 	/* HW automatically latch rest of address register on write to
705 	 * DCSURF_PRIMARY_SURFACE_ADDRESS if SURFACE_UPDATE_LOCK is not used
706 	 *
707 	 * program high first and then the low addr, order matters!
708 	 */
709 	switch (address->type) {
710 	case PLN_ADDR_TYPE_GRAPHICS:
711 		/* DCN1.0 does not support const color
712 		 * TODO: program DCHUBBUB_RET_PATH_DCC_CFGx_0/1
713 		 * base on address->grph.dcc_const_color
714 		 * x = 0, 2, 4, 6 for pipe 0, 1, 2, 3 for rgb and luma
715 		 * x = 1, 3, 5, 7 for pipe 0, 1, 2, 3 for chroma
716 		 */
717 
718 		if (address->grph.addr.quad_part == 0)
719 			break;
720 
721 		REG_UPDATE_2(DCSURF_SURFACE_CONTROL,
722 				PRIMARY_SURFACE_TMZ, address->tmz_surface,
723 				PRIMARY_META_SURFACE_TMZ, address->tmz_surface);
724 
725 		if (address->grph.meta_addr.quad_part != 0) {
726 			REG_SET(DCSURF_PRIMARY_META_SURFACE_ADDRESS_HIGH, 0,
727 					PRIMARY_META_SURFACE_ADDRESS_HIGH,
728 					address->grph.meta_addr.high_part);
729 
730 			REG_SET(DCSURF_PRIMARY_META_SURFACE_ADDRESS, 0,
731 					PRIMARY_META_SURFACE_ADDRESS,
732 					address->grph.meta_addr.low_part);
733 		}
734 
735 		REG_SET(DCSURF_PRIMARY_SURFACE_ADDRESS_HIGH, 0,
736 				PRIMARY_SURFACE_ADDRESS_HIGH,
737 				address->grph.addr.high_part);
738 
739 		REG_SET(DCSURF_PRIMARY_SURFACE_ADDRESS, 0,
740 				PRIMARY_SURFACE_ADDRESS,
741 				address->grph.addr.low_part);
742 		break;
743 	case PLN_ADDR_TYPE_VIDEO_PROGRESSIVE:
744 		if (address->video_progressive.luma_addr.quad_part == 0
745 				|| address->video_progressive.chroma_addr.quad_part == 0)
746 			break;
747 
748 		REG_UPDATE_4(DCSURF_SURFACE_CONTROL,
749 				PRIMARY_SURFACE_TMZ, address->tmz_surface,
750 				PRIMARY_SURFACE_TMZ_C, address->tmz_surface,
751 				PRIMARY_META_SURFACE_TMZ, address->tmz_surface,
752 				PRIMARY_META_SURFACE_TMZ_C, address->tmz_surface);
753 
754 		if (address->video_progressive.luma_meta_addr.quad_part != 0) {
755 			REG_SET(DCSURF_PRIMARY_META_SURFACE_ADDRESS_HIGH_C, 0,
756 					PRIMARY_META_SURFACE_ADDRESS_HIGH_C,
757 					address->video_progressive.chroma_meta_addr.high_part);
758 
759 			REG_SET(DCSURF_PRIMARY_META_SURFACE_ADDRESS_C, 0,
760 					PRIMARY_META_SURFACE_ADDRESS_C,
761 					address->video_progressive.chroma_meta_addr.low_part);
762 
763 			REG_SET(DCSURF_PRIMARY_META_SURFACE_ADDRESS_HIGH, 0,
764 					PRIMARY_META_SURFACE_ADDRESS_HIGH,
765 					address->video_progressive.luma_meta_addr.high_part);
766 
767 			REG_SET(DCSURF_PRIMARY_META_SURFACE_ADDRESS, 0,
768 					PRIMARY_META_SURFACE_ADDRESS,
769 					address->video_progressive.luma_meta_addr.low_part);
770 		}
771 
772 		REG_SET(DCSURF_PRIMARY_SURFACE_ADDRESS_HIGH_C, 0,
773 				PRIMARY_SURFACE_ADDRESS_HIGH_C,
774 				address->video_progressive.chroma_addr.high_part);
775 
776 		REG_SET(DCSURF_PRIMARY_SURFACE_ADDRESS_C, 0,
777 				PRIMARY_SURFACE_ADDRESS_C,
778 				address->video_progressive.chroma_addr.low_part);
779 
780 		REG_SET(DCSURF_PRIMARY_SURFACE_ADDRESS_HIGH, 0,
781 				PRIMARY_SURFACE_ADDRESS_HIGH,
782 				address->video_progressive.luma_addr.high_part);
783 
784 		REG_SET(DCSURF_PRIMARY_SURFACE_ADDRESS, 0,
785 				PRIMARY_SURFACE_ADDRESS,
786 				address->video_progressive.luma_addr.low_part);
787 		break;
788 	case PLN_ADDR_TYPE_GRPH_STEREO:
789 		if (address->grph_stereo.left_addr.quad_part == 0)
790 			break;
791 		if (address->grph_stereo.right_addr.quad_part == 0)
792 			break;
793 
794 		REG_UPDATE_8(DCSURF_SURFACE_CONTROL,
795 				PRIMARY_SURFACE_TMZ, address->tmz_surface,
796 				PRIMARY_SURFACE_TMZ_C, address->tmz_surface,
797 				PRIMARY_META_SURFACE_TMZ, address->tmz_surface,
798 				PRIMARY_META_SURFACE_TMZ_C, address->tmz_surface,
799 				SECONDARY_SURFACE_TMZ, address->tmz_surface,
800 				SECONDARY_SURFACE_TMZ_C, address->tmz_surface,
801 				SECONDARY_META_SURFACE_TMZ, address->tmz_surface,
802 				SECONDARY_META_SURFACE_TMZ_C, address->tmz_surface);
803 
804 		if (address->grph_stereo.right_meta_addr.quad_part != 0) {
805 
806 			REG_SET(DCSURF_SECONDARY_META_SURFACE_ADDRESS_HIGH, 0,
807 					SECONDARY_META_SURFACE_ADDRESS_HIGH,
808 					address->grph_stereo.right_meta_addr.high_part);
809 
810 			REG_SET(DCSURF_SECONDARY_META_SURFACE_ADDRESS, 0,
811 					SECONDARY_META_SURFACE_ADDRESS,
812 					address->grph_stereo.right_meta_addr.low_part);
813 		}
814 		if (address->grph_stereo.left_meta_addr.quad_part != 0) {
815 
816 			REG_SET(DCSURF_PRIMARY_META_SURFACE_ADDRESS_HIGH, 0,
817 					PRIMARY_META_SURFACE_ADDRESS_HIGH,
818 					address->grph_stereo.left_meta_addr.high_part);
819 
820 			REG_SET(DCSURF_PRIMARY_META_SURFACE_ADDRESS, 0,
821 					PRIMARY_META_SURFACE_ADDRESS,
822 					address->grph_stereo.left_meta_addr.low_part);
823 		}
824 
825 		REG_SET(DCSURF_SECONDARY_SURFACE_ADDRESS_HIGH, 0,
826 				SECONDARY_SURFACE_ADDRESS_HIGH,
827 				address->grph_stereo.right_addr.high_part);
828 
829 		REG_SET(DCSURF_SECONDARY_SURFACE_ADDRESS, 0,
830 				SECONDARY_SURFACE_ADDRESS,
831 				address->grph_stereo.right_addr.low_part);
832 
833 		REG_SET(DCSURF_PRIMARY_SURFACE_ADDRESS_HIGH, 0,
834 				PRIMARY_SURFACE_ADDRESS_HIGH,
835 				address->grph_stereo.left_addr.high_part);
836 
837 		REG_SET(DCSURF_PRIMARY_SURFACE_ADDRESS, 0,
838 				PRIMARY_SURFACE_ADDRESS,
839 				address->grph_stereo.left_addr.low_part);
840 		break;
841 	default:
842 		BREAK_TO_DEBUGGER();
843 		break;
844 	}
845 
846 	hubp->request_address = *address;
847 
848 	return true;
849 }
850 
851 void hubp2_enable_triplebuffer(
852 	struct hubp *hubp,
853 	bool enable)
854 {
855 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
856 	uint32_t triple_buffer_en = 0;
857 	bool tri_buffer_en;
858 
859 	REG_GET(DCSURF_FLIP_CONTROL2, SURFACE_TRIPLE_BUFFER_ENABLE, &triple_buffer_en);
860 	tri_buffer_en = (triple_buffer_en == 1);
861 	if (tri_buffer_en != enable) {
862 		REG_UPDATE(DCSURF_FLIP_CONTROL2,
863 			SURFACE_TRIPLE_BUFFER_ENABLE, enable ? DC_TRIPLEBUFFER_ENABLE : DC_TRIPLEBUFFER_DISABLE);
864 	}
865 }
866 
867 bool hubp2_is_triplebuffer_enabled(
868 	struct hubp *hubp)
869 {
870 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
871 	uint32_t triple_buffer_en = 0;
872 
873 	REG_GET(DCSURF_FLIP_CONTROL2, SURFACE_TRIPLE_BUFFER_ENABLE, &triple_buffer_en);
874 
875 	return (bool)triple_buffer_en;
876 }
877 
878 void hubp2_set_flip_control_surface_gsl(struct hubp *hubp, bool enable)
879 {
880 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
881 
882 	REG_UPDATE(DCSURF_FLIP_CONTROL2, SURFACE_GSL_ENABLE, enable ? 1 : 0);
883 }
884 
885 bool hubp2_is_flip_pending(struct hubp *hubp)
886 {
887 	uint32_t flip_pending = 0;
888 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
889 	struct dc_plane_address earliest_inuse_address;
890 
891 	REG_GET(DCSURF_FLIP_CONTROL,
892 			SURFACE_FLIP_PENDING, &flip_pending);
893 
894 	REG_GET(DCSURF_SURFACE_EARLIEST_INUSE,
895 			SURFACE_EARLIEST_INUSE_ADDRESS, &earliest_inuse_address.grph.addr.low_part);
896 
897 	REG_GET(DCSURF_SURFACE_EARLIEST_INUSE_HIGH,
898 			SURFACE_EARLIEST_INUSE_ADDRESS_HIGH, &earliest_inuse_address.grph.addr.high_part);
899 
900 	if (flip_pending)
901 		return true;
902 
903 	if (earliest_inuse_address.grph.addr.quad_part != hubp->request_address.grph.addr.quad_part)
904 		return true;
905 
906 	return false;
907 }
908 
909 void hubp2_set_blank(struct hubp *hubp, bool blank)
910 {
911 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
912 	uint32_t blank_en = blank ? 1 : 0;
913 
914 	REG_UPDATE_2(DCHUBP_CNTL,
915 			HUBP_BLANK_EN, blank_en,
916 			HUBP_TTU_DISABLE, blank_en);
917 
918 	if (blank) {
919 		uint32_t reg_val = REG_READ(DCHUBP_CNTL);
920 
921 		if (reg_val) {
922 			/* init sequence workaround: in case HUBP is
923 			 * power gated, this wait would timeout.
924 			 *
925 			 * we just wrote reg_val to non-0, if it stay 0
926 			 * it means HUBP is gated
927 			 */
928 			REG_WAIT(DCHUBP_CNTL,
929 					HUBP_NO_OUTSTANDING_REQ, 1,
930 					1, 200);
931 		}
932 
933 		hubp->mpcc_id = 0xf;
934 		hubp->opp_id = OPP_ID_INVALID;
935 	}
936 }
937 
938 void hubp2_cursor_set_position(
939 		struct hubp *hubp,
940 		const struct dc_cursor_position *pos,
941 		const struct dc_cursor_mi_param *param)
942 {
943 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
944 	int src_x_offset = pos->x - pos->x_hotspot - param->viewport.x;
945 	int src_y_offset = pos->y - pos->y_hotspot - param->viewport.y;
946 	int x_hotspot = pos->x_hotspot;
947 	int y_hotspot = pos->y_hotspot;
948 	int cursor_height = (int)hubp->curs_attr.height;
949 	int cursor_width = (int)hubp->curs_attr.width;
950 	uint32_t dst_x_offset;
951 	uint32_t cur_en = pos->enable ? 1 : 0;
952 
953 	/*
954 	 * Guard aganst cursor_set_position() from being called with invalid
955 	 * attributes
956 	 *
957 	 * TODO: Look at combining cursor_set_position() and
958 	 * cursor_set_attributes() into cursor_update()
959 	 */
960 	if (hubp->curs_attr.address.quad_part == 0)
961 		return;
962 
963 	// Rotated cursor width/height and hotspots tweaks for offset calculation
964 	if (param->rotation == ROTATION_ANGLE_90 || param->rotation == ROTATION_ANGLE_270) {
965 		swap(cursor_height, cursor_width);
966 		if (param->rotation == ROTATION_ANGLE_90) {
967 			src_x_offset = pos->x - pos->y_hotspot - param->viewport.x;
968 			src_y_offset = pos->y - pos->x_hotspot - param->viewport.y;
969 		}
970 	} else if (param->rotation == ROTATION_ANGLE_180) {
971 		src_x_offset = pos->x - param->viewport.x;
972 		src_y_offset = pos->y - param->viewport.y;
973 	}
974 
975 	if (param->mirror) {
976 		x_hotspot = param->viewport.width - x_hotspot;
977 		src_x_offset = param->viewport.x + param->viewport.width - src_x_offset;
978 	}
979 
980 	dst_x_offset = (src_x_offset >= 0) ? src_x_offset : 0;
981 	dst_x_offset *= param->ref_clk_khz;
982 	dst_x_offset /= param->pixel_clk_khz;
983 
984 	ASSERT(param->h_scale_ratio.value);
985 
986 	if (param->h_scale_ratio.value)
987 		dst_x_offset = dc_fixpt_floor(dc_fixpt_div(
988 				dc_fixpt_from_int(dst_x_offset),
989 				param->h_scale_ratio));
990 
991 	if (src_x_offset >= (int)param->viewport.width)
992 		cur_en = 0;  /* not visible beyond right edge*/
993 
994 	if (src_x_offset + cursor_width <= 0)
995 		cur_en = 0;  /* not visible beyond left edge*/
996 
997 	if (src_y_offset >= (int)param->viewport.height)
998 		cur_en = 0;  /* not visible beyond bottom edge*/
999 
1000 	if (src_y_offset + cursor_height <= 0)
1001 		cur_en = 0;  /* not visible beyond top edge*/
1002 
1003 	if (cur_en && REG_READ(CURSOR_SURFACE_ADDRESS) == 0)
1004 		hubp->funcs->set_cursor_attributes(hubp, &hubp->curs_attr);
1005 
1006 	REG_UPDATE(CURSOR_CONTROL,
1007 			CURSOR_ENABLE, cur_en);
1008 
1009 	REG_SET_2(CURSOR_POSITION, 0,
1010 			CURSOR_X_POSITION, pos->x,
1011 			CURSOR_Y_POSITION, pos->y);
1012 
1013 	REG_SET_2(CURSOR_HOT_SPOT, 0,
1014 			CURSOR_HOT_SPOT_X, x_hotspot,
1015 			CURSOR_HOT_SPOT_Y, y_hotspot);
1016 
1017 	REG_SET(CURSOR_DST_OFFSET, 0,
1018 			CURSOR_DST_X_OFFSET, dst_x_offset);
1019 	/* TODO Handle surface pixel formats other than 4:4:4 */
1020 }
1021 
1022 void hubp2_clk_cntl(struct hubp *hubp, bool enable)
1023 {
1024 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
1025 	uint32_t clk_enable = enable ? 1 : 0;
1026 
1027 	REG_UPDATE(HUBP_CLK_CNTL, HUBP_CLOCK_ENABLE, clk_enable);
1028 }
1029 
1030 void hubp2_vtg_sel(struct hubp *hubp, uint32_t otg_inst)
1031 {
1032 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
1033 
1034 	REG_UPDATE(DCHUBP_CNTL, HUBP_VTG_SEL, otg_inst);
1035 }
1036 
1037 void hubp2_clear_underflow(struct hubp *hubp)
1038 {
1039 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
1040 
1041 	REG_UPDATE(DCHUBP_CNTL, HUBP_UNDERFLOW_CLEAR, 1);
1042 }
1043 
1044 void hubp2_read_state_common(struct hubp *hubp)
1045 {
1046 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
1047 	struct dcn_hubp_state *s = &hubp2->state;
1048 	struct _vcs_dpi_display_dlg_regs_st *dlg_attr = &s->dlg_attr;
1049 	struct _vcs_dpi_display_ttu_regs_st *ttu_attr = &s->ttu_attr;
1050 	struct _vcs_dpi_display_rq_regs_st *rq_regs = &s->rq_regs;
1051 
1052 	/* Requester */
1053 	REG_GET(HUBPRET_CONTROL,
1054 			DET_BUF_PLANE1_BASE_ADDRESS, &rq_regs->plane1_base_address);
1055 	REG_GET_4(DCN_EXPANSION_MODE,
1056 			DRQ_EXPANSION_MODE, &rq_regs->drq_expansion_mode,
1057 			PRQ_EXPANSION_MODE, &rq_regs->prq_expansion_mode,
1058 			MRQ_EXPANSION_MODE, &rq_regs->mrq_expansion_mode,
1059 			CRQ_EXPANSION_MODE, &rq_regs->crq_expansion_mode);
1060 
1061 	/* DLG - Per hubp */
1062 	REG_GET_2(BLANK_OFFSET_0,
1063 		REFCYC_H_BLANK_END, &dlg_attr->refcyc_h_blank_end,
1064 		DLG_V_BLANK_END, &dlg_attr->dlg_vblank_end);
1065 
1066 	REG_GET(BLANK_OFFSET_1,
1067 		MIN_DST_Y_NEXT_START, &dlg_attr->min_dst_y_next_start);
1068 
1069 	REG_GET(DST_DIMENSIONS,
1070 		REFCYC_PER_HTOTAL, &dlg_attr->refcyc_per_htotal);
1071 
1072 	REG_GET_2(DST_AFTER_SCALER,
1073 		REFCYC_X_AFTER_SCALER, &dlg_attr->refcyc_x_after_scaler,
1074 		DST_Y_AFTER_SCALER, &dlg_attr->dst_y_after_scaler);
1075 
1076 	if (REG(PREFETCH_SETTINS))
1077 		REG_GET_2(PREFETCH_SETTINS,
1078 			DST_Y_PREFETCH, &dlg_attr->dst_y_prefetch,
1079 			VRATIO_PREFETCH, &dlg_attr->vratio_prefetch);
1080 	else
1081 		REG_GET_2(PREFETCH_SETTINGS,
1082 			DST_Y_PREFETCH, &dlg_attr->dst_y_prefetch,
1083 			VRATIO_PREFETCH, &dlg_attr->vratio_prefetch);
1084 
1085 	REG_GET_2(VBLANK_PARAMETERS_0,
1086 		DST_Y_PER_VM_VBLANK, &dlg_attr->dst_y_per_vm_vblank,
1087 		DST_Y_PER_ROW_VBLANK, &dlg_attr->dst_y_per_row_vblank);
1088 
1089 	REG_GET(REF_FREQ_TO_PIX_FREQ,
1090 		REF_FREQ_TO_PIX_FREQ, &dlg_attr->ref_freq_to_pix_freq);
1091 
1092 	/* DLG - Per luma/chroma */
1093 	REG_GET(VBLANK_PARAMETERS_1,
1094 		REFCYC_PER_PTE_GROUP_VBLANK_L, &dlg_attr->refcyc_per_pte_group_vblank_l);
1095 
1096 	REG_GET(VBLANK_PARAMETERS_3,
1097 		REFCYC_PER_META_CHUNK_VBLANK_L, &dlg_attr->refcyc_per_meta_chunk_vblank_l);
1098 
1099 	if (REG(NOM_PARAMETERS_0))
1100 		REG_GET(NOM_PARAMETERS_0,
1101 			DST_Y_PER_PTE_ROW_NOM_L, &dlg_attr->dst_y_per_pte_row_nom_l);
1102 
1103 	if (REG(NOM_PARAMETERS_1))
1104 		REG_GET(NOM_PARAMETERS_1,
1105 			REFCYC_PER_PTE_GROUP_NOM_L, &dlg_attr->refcyc_per_pte_group_nom_l);
1106 
1107 	REG_GET(NOM_PARAMETERS_4,
1108 		DST_Y_PER_META_ROW_NOM_L, &dlg_attr->dst_y_per_meta_row_nom_l);
1109 
1110 	REG_GET(NOM_PARAMETERS_5,
1111 		REFCYC_PER_META_CHUNK_NOM_L, &dlg_attr->refcyc_per_meta_chunk_nom_l);
1112 
1113 	REG_GET_2(PER_LINE_DELIVERY_PRE,
1114 		REFCYC_PER_LINE_DELIVERY_PRE_L, &dlg_attr->refcyc_per_line_delivery_pre_l,
1115 		REFCYC_PER_LINE_DELIVERY_PRE_C, &dlg_attr->refcyc_per_line_delivery_pre_c);
1116 
1117 	REG_GET_2(PER_LINE_DELIVERY,
1118 		REFCYC_PER_LINE_DELIVERY_L, &dlg_attr->refcyc_per_line_delivery_l,
1119 		REFCYC_PER_LINE_DELIVERY_C, &dlg_attr->refcyc_per_line_delivery_c);
1120 
1121 	if (REG(PREFETCH_SETTINS_C))
1122 		REG_GET(PREFETCH_SETTINS_C,
1123 			VRATIO_PREFETCH_C, &dlg_attr->vratio_prefetch_c);
1124 	else
1125 		REG_GET(PREFETCH_SETTINGS_C,
1126 			VRATIO_PREFETCH_C, &dlg_attr->vratio_prefetch_c);
1127 
1128 	REG_GET(VBLANK_PARAMETERS_2,
1129 		REFCYC_PER_PTE_GROUP_VBLANK_C, &dlg_attr->refcyc_per_pte_group_vblank_c);
1130 
1131 	REG_GET(VBLANK_PARAMETERS_4,
1132 		REFCYC_PER_META_CHUNK_VBLANK_C, &dlg_attr->refcyc_per_meta_chunk_vblank_c);
1133 
1134 	if (REG(NOM_PARAMETERS_2))
1135 		REG_GET(NOM_PARAMETERS_2,
1136 			DST_Y_PER_PTE_ROW_NOM_C, &dlg_attr->dst_y_per_pte_row_nom_c);
1137 
1138 	if (REG(NOM_PARAMETERS_3))
1139 		REG_GET(NOM_PARAMETERS_3,
1140 			REFCYC_PER_PTE_GROUP_NOM_C, &dlg_attr->refcyc_per_pte_group_nom_c);
1141 
1142 	REG_GET(NOM_PARAMETERS_6,
1143 		DST_Y_PER_META_ROW_NOM_C, &dlg_attr->dst_y_per_meta_row_nom_c);
1144 
1145 	REG_GET(NOM_PARAMETERS_7,
1146 		REFCYC_PER_META_CHUNK_NOM_C, &dlg_attr->refcyc_per_meta_chunk_nom_c);
1147 
1148 	/* TTU - per hubp */
1149 	REG_GET_2(DCN_TTU_QOS_WM,
1150 		QoS_LEVEL_LOW_WM, &ttu_attr->qos_level_low_wm,
1151 		QoS_LEVEL_HIGH_WM, &ttu_attr->qos_level_high_wm);
1152 
1153 	REG_GET_2(DCN_GLOBAL_TTU_CNTL,
1154 		MIN_TTU_VBLANK, &ttu_attr->min_ttu_vblank,
1155 		QoS_LEVEL_FLIP, &ttu_attr->qos_level_flip);
1156 
1157 	/* TTU - per luma/chroma */
1158 	/* Assumed surf0 is luma and 1 is chroma */
1159 
1160 	REG_GET_3(DCN_SURF0_TTU_CNTL0,
1161 		REFCYC_PER_REQ_DELIVERY, &ttu_attr->refcyc_per_req_delivery_l,
1162 		QoS_LEVEL_FIXED, &ttu_attr->qos_level_fixed_l,
1163 		QoS_RAMP_DISABLE, &ttu_attr->qos_ramp_disable_l);
1164 
1165 	REG_GET(DCN_SURF0_TTU_CNTL1,
1166 		REFCYC_PER_REQ_DELIVERY_PRE,
1167 		&ttu_attr->refcyc_per_req_delivery_pre_l);
1168 
1169 	REG_GET_3(DCN_SURF1_TTU_CNTL0,
1170 		REFCYC_PER_REQ_DELIVERY, &ttu_attr->refcyc_per_req_delivery_c,
1171 		QoS_LEVEL_FIXED, &ttu_attr->qos_level_fixed_c,
1172 		QoS_RAMP_DISABLE, &ttu_attr->qos_ramp_disable_c);
1173 
1174 	REG_GET(DCN_SURF1_TTU_CNTL1,
1175 		REFCYC_PER_REQ_DELIVERY_PRE,
1176 		&ttu_attr->refcyc_per_req_delivery_pre_c);
1177 
1178 	/* Rest of hubp */
1179 	REG_GET(DCSURF_SURFACE_CONFIG,
1180 			SURFACE_PIXEL_FORMAT, &s->pixel_format);
1181 
1182 	REG_GET(DCSURF_SURFACE_EARLIEST_INUSE_HIGH,
1183 			SURFACE_EARLIEST_INUSE_ADDRESS_HIGH, &s->inuse_addr_hi);
1184 
1185 	REG_GET(DCSURF_SURFACE_EARLIEST_INUSE,
1186 			SURFACE_EARLIEST_INUSE_ADDRESS, &s->inuse_addr_lo);
1187 
1188 	REG_GET_2(DCSURF_PRI_VIEWPORT_DIMENSION,
1189 			PRI_VIEWPORT_WIDTH, &s->viewport_width,
1190 			PRI_VIEWPORT_HEIGHT, &s->viewport_height);
1191 
1192 	REG_GET_2(DCSURF_SURFACE_CONFIG,
1193 			ROTATION_ANGLE, &s->rotation_angle,
1194 			H_MIRROR_EN, &s->h_mirror_en);
1195 
1196 	REG_GET(DCSURF_TILING_CONFIG,
1197 			SW_MODE, &s->sw_mode);
1198 
1199 	REG_GET(DCSURF_SURFACE_CONTROL,
1200 			PRIMARY_SURFACE_DCC_EN, &s->dcc_en);
1201 
1202 	REG_GET_3(DCHUBP_CNTL,
1203 			HUBP_BLANK_EN, &s->blank_en,
1204 			HUBP_TTU_DISABLE, &s->ttu_disable,
1205 			HUBP_UNDERFLOW_STATUS, &s->underflow_status);
1206 
1207 	REG_GET(HUBP_CLK_CNTL,
1208 			HUBP_CLOCK_ENABLE, &s->clock_en);
1209 
1210 	REG_GET(DCN_GLOBAL_TTU_CNTL,
1211 			MIN_TTU_VBLANK, &s->min_ttu_vblank);
1212 
1213 	REG_GET_2(DCN_TTU_QOS_WM,
1214 			QoS_LEVEL_LOW_WM, &s->qos_level_low_wm,
1215 			QoS_LEVEL_HIGH_WM, &s->qos_level_high_wm);
1216 
1217 }
1218 
1219 void hubp2_read_state(struct hubp *hubp)
1220 {
1221 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
1222 	struct dcn_hubp_state *s = &hubp2->state;
1223 	struct _vcs_dpi_display_rq_regs_st *rq_regs = &s->rq_regs;
1224 
1225 	hubp2_read_state_common(hubp);
1226 
1227 	REG_GET_8(DCHUBP_REQ_SIZE_CONFIG,
1228 		CHUNK_SIZE, &rq_regs->rq_regs_l.chunk_size,
1229 		MIN_CHUNK_SIZE, &rq_regs->rq_regs_l.min_chunk_size,
1230 		META_CHUNK_SIZE, &rq_regs->rq_regs_l.meta_chunk_size,
1231 		MIN_META_CHUNK_SIZE, &rq_regs->rq_regs_l.min_meta_chunk_size,
1232 		DPTE_GROUP_SIZE, &rq_regs->rq_regs_l.dpte_group_size,
1233 		MPTE_GROUP_SIZE, &rq_regs->rq_regs_l.mpte_group_size,
1234 		SWATH_HEIGHT, &rq_regs->rq_regs_l.swath_height,
1235 		PTE_ROW_HEIGHT_LINEAR, &rq_regs->rq_regs_l.pte_row_height_linear);
1236 
1237 	REG_GET_8(DCHUBP_REQ_SIZE_CONFIG_C,
1238 		CHUNK_SIZE_C, &rq_regs->rq_regs_c.chunk_size,
1239 		MIN_CHUNK_SIZE_C, &rq_regs->rq_regs_c.min_chunk_size,
1240 		META_CHUNK_SIZE_C, &rq_regs->rq_regs_c.meta_chunk_size,
1241 		MIN_META_CHUNK_SIZE_C, &rq_regs->rq_regs_c.min_meta_chunk_size,
1242 		DPTE_GROUP_SIZE_C, &rq_regs->rq_regs_c.dpte_group_size,
1243 		MPTE_GROUP_SIZE_C, &rq_regs->rq_regs_c.mpte_group_size,
1244 		SWATH_HEIGHT_C, &rq_regs->rq_regs_c.swath_height,
1245 		PTE_ROW_HEIGHT_LINEAR_C, &rq_regs->rq_regs_c.pte_row_height_linear);
1246 
1247 }
1248 
1249 void hubp2_validate_dml_output(struct hubp *hubp,
1250 		struct dc_context *ctx,
1251 		struct _vcs_dpi_display_rq_regs_st *dml_rq_regs,
1252 		struct _vcs_dpi_display_dlg_regs_st *dml_dlg_attr,
1253 		struct _vcs_dpi_display_ttu_regs_st *dml_ttu_attr)
1254 {
1255 	struct dcn20_hubp *hubp2 = TO_DCN20_HUBP(hubp);
1256 	struct _vcs_dpi_display_rq_regs_st rq_regs = {0};
1257 	struct _vcs_dpi_display_dlg_regs_st dlg_attr = {0};
1258 	struct _vcs_dpi_display_ttu_regs_st ttu_attr = {0};
1259 	DC_LOGGER_INIT(ctx->logger);
1260 	DC_LOG_DEBUG("DML Validation | Running Validation");
1261 
1262 	/* Requestor Regs */
1263 	REG_GET(HUBPRET_CONTROL,
1264 		DET_BUF_PLANE1_BASE_ADDRESS, &rq_regs.plane1_base_address);
1265 	REG_GET_4(DCN_EXPANSION_MODE,
1266 		DRQ_EXPANSION_MODE, &rq_regs.drq_expansion_mode,
1267 		PRQ_EXPANSION_MODE, &rq_regs.prq_expansion_mode,
1268 		MRQ_EXPANSION_MODE, &rq_regs.mrq_expansion_mode,
1269 		CRQ_EXPANSION_MODE, &rq_regs.crq_expansion_mode);
1270 	REG_GET_8(DCHUBP_REQ_SIZE_CONFIG,
1271 		CHUNK_SIZE, &rq_regs.rq_regs_l.chunk_size,
1272 		MIN_CHUNK_SIZE, &rq_regs.rq_regs_l.min_chunk_size,
1273 		META_CHUNK_SIZE, &rq_regs.rq_regs_l.meta_chunk_size,
1274 		MIN_META_CHUNK_SIZE, &rq_regs.rq_regs_l.min_meta_chunk_size,
1275 		DPTE_GROUP_SIZE, &rq_regs.rq_regs_l.dpte_group_size,
1276 		MPTE_GROUP_SIZE, &rq_regs.rq_regs_l.mpte_group_size,
1277 		SWATH_HEIGHT, &rq_regs.rq_regs_l.swath_height,
1278 		PTE_ROW_HEIGHT_LINEAR, &rq_regs.rq_regs_l.pte_row_height_linear);
1279 	REG_GET_8(DCHUBP_REQ_SIZE_CONFIG_C,
1280 		CHUNK_SIZE_C, &rq_regs.rq_regs_c.chunk_size,
1281 		MIN_CHUNK_SIZE_C, &rq_regs.rq_regs_c.min_chunk_size,
1282 		META_CHUNK_SIZE_C, &rq_regs.rq_regs_c.meta_chunk_size,
1283 		MIN_META_CHUNK_SIZE_C, &rq_regs.rq_regs_c.min_meta_chunk_size,
1284 		DPTE_GROUP_SIZE_C, &rq_regs.rq_regs_c.dpte_group_size,
1285 		MPTE_GROUP_SIZE_C, &rq_regs.rq_regs_c.mpte_group_size,
1286 		SWATH_HEIGHT_C, &rq_regs.rq_regs_c.swath_height,
1287 		PTE_ROW_HEIGHT_LINEAR_C, &rq_regs.rq_regs_c.pte_row_height_linear);
1288 
1289 	if (rq_regs.plane1_base_address != dml_rq_regs->plane1_base_address)
1290 		DC_LOG_DEBUG("DML Validation | HUBPRET_CONTROL:DET_BUF_PLANE1_BASE_ADDRESS - Expected: %u  Actual: %u\n",
1291 				dml_rq_regs->plane1_base_address, rq_regs.plane1_base_address);
1292 	if (rq_regs.drq_expansion_mode != dml_rq_regs->drq_expansion_mode)
1293 		DC_LOG_DEBUG("DML Validation | DCN_EXPANSION_MODE:DRQ_EXPANSION_MODE - Expected: %u  Actual: %u\n",
1294 				dml_rq_regs->drq_expansion_mode, rq_regs.drq_expansion_mode);
1295 	if (rq_regs.prq_expansion_mode != dml_rq_regs->prq_expansion_mode)
1296 		DC_LOG_DEBUG("DML Validation | DCN_EXPANSION_MODE:MRQ_EXPANSION_MODE - Expected: %u  Actual: %u\n",
1297 				dml_rq_regs->prq_expansion_mode, rq_regs.prq_expansion_mode);
1298 	if (rq_regs.mrq_expansion_mode != dml_rq_regs->mrq_expansion_mode)
1299 		DC_LOG_DEBUG("DML Validation | DCN_EXPANSION_MODE:DET_BUF_PLANE1_BASE_ADDRESS - Expected: %u  Actual: %u\n",
1300 				dml_rq_regs->mrq_expansion_mode, rq_regs.mrq_expansion_mode);
1301 	if (rq_regs.crq_expansion_mode != dml_rq_regs->crq_expansion_mode)
1302 		DC_LOG_DEBUG("DML Validation | DCN_EXPANSION_MODE:CRQ_EXPANSION_MODE - Expected: %u  Actual: %u\n",
1303 				dml_rq_regs->crq_expansion_mode, rq_regs.crq_expansion_mode);
1304 
1305 	if (rq_regs.rq_regs_l.chunk_size != dml_rq_regs->rq_regs_l.chunk_size)
1306 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG_C:CHUNK_SIZE - Expected: %u  Actual: %u\n",
1307 				dml_rq_regs->rq_regs_l.chunk_size, rq_regs.rq_regs_l.chunk_size);
1308 	if (rq_regs.rq_regs_l.min_chunk_size != dml_rq_regs->rq_regs_l.min_chunk_size)
1309 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG_C:MIN_CHUNK_SIZE - Expected: %u  Actual: %u\n",
1310 				dml_rq_regs->rq_regs_l.min_chunk_size, rq_regs.rq_regs_l.min_chunk_size);
1311 	if (rq_regs.rq_regs_l.meta_chunk_size != dml_rq_regs->rq_regs_l.meta_chunk_size)
1312 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG_C:META_CHUNK_SIZE - Expected: %u  Actual: %u\n",
1313 				dml_rq_regs->rq_regs_l.meta_chunk_size, rq_regs.rq_regs_l.meta_chunk_size);
1314 	if (rq_regs.rq_regs_l.min_meta_chunk_size != dml_rq_regs->rq_regs_l.min_meta_chunk_size)
1315 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG_C:MIN_META_CHUNK_SIZE - Expected: %u  Actual: %u\n",
1316 				dml_rq_regs->rq_regs_l.min_meta_chunk_size, rq_regs.rq_regs_l.min_meta_chunk_size);
1317 	if (rq_regs.rq_regs_l.dpte_group_size != dml_rq_regs->rq_regs_l.dpte_group_size)
1318 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG_C:DPTE_GROUP_SIZE - Expected: %u  Actual: %u\n",
1319 				dml_rq_regs->rq_regs_l.dpte_group_size, rq_regs.rq_regs_l.dpte_group_size);
1320 	if (rq_regs.rq_regs_l.mpte_group_size != dml_rq_regs->rq_regs_l.mpte_group_size)
1321 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG_C:MPTE_GROUP_SIZE - Expected: %u  Actual: %u\n",
1322 				dml_rq_regs->rq_regs_l.mpte_group_size, rq_regs.rq_regs_l.mpte_group_size);
1323 	if (rq_regs.rq_regs_l.swath_height != dml_rq_regs->rq_regs_l.swath_height)
1324 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG_C:SWATH_HEIGHT - Expected: %u  Actual: %u\n",
1325 				dml_rq_regs->rq_regs_l.swath_height, rq_regs.rq_regs_l.swath_height);
1326 	if (rq_regs.rq_regs_l.pte_row_height_linear != dml_rq_regs->rq_regs_l.pte_row_height_linear)
1327 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG_C:PTE_ROW_HEIGHT_LINEAR - Expected: %u  Actual: %u\n",
1328 				dml_rq_regs->rq_regs_l.pte_row_height_linear, rq_regs.rq_regs_l.pte_row_height_linear);
1329 
1330 	if (rq_regs.rq_regs_c.chunk_size != dml_rq_regs->rq_regs_c.chunk_size)
1331 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG:CHUNK_SIZE_C - Expected: %u  Actual: %u\n",
1332 				dml_rq_regs->rq_regs_c.chunk_size, rq_regs.rq_regs_c.chunk_size);
1333 	if (rq_regs.rq_regs_c.min_chunk_size != dml_rq_regs->rq_regs_c.min_chunk_size)
1334 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG:MIN_CHUNK_SIZE_C - Expected: %u  Actual: %u\n",
1335 				dml_rq_regs->rq_regs_c.min_chunk_size, rq_regs.rq_regs_c.min_chunk_size);
1336 	if (rq_regs.rq_regs_c.meta_chunk_size != dml_rq_regs->rq_regs_c.meta_chunk_size)
1337 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG:META_CHUNK_SIZE_C - Expected: %u  Actual: %u\n",
1338 				dml_rq_regs->rq_regs_c.meta_chunk_size, rq_regs.rq_regs_c.meta_chunk_size);
1339 	if (rq_regs.rq_regs_c.min_meta_chunk_size != dml_rq_regs->rq_regs_c.min_meta_chunk_size)
1340 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG:MIN_META_CHUNK_SIZE_C - Expected: %u  Actual: %u\n",
1341 				dml_rq_regs->rq_regs_c.min_meta_chunk_size, rq_regs.rq_regs_c.min_meta_chunk_size);
1342 	if (rq_regs.rq_regs_c.dpte_group_size != dml_rq_regs->rq_regs_c.dpte_group_size)
1343 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG:DPTE_GROUP_SIZE_C - Expected: %u  Actual: %u\n",
1344 				dml_rq_regs->rq_regs_c.dpte_group_size, rq_regs.rq_regs_c.dpte_group_size);
1345 	if (rq_regs.rq_regs_c.mpte_group_size != dml_rq_regs->rq_regs_c.mpte_group_size)
1346 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG:MPTE_GROUP_SIZE_C - Expected: %u  Actual: %u\n",
1347 				dml_rq_regs->rq_regs_c.mpte_group_size, rq_regs.rq_regs_c.mpte_group_size);
1348 	if (rq_regs.rq_regs_c.swath_height != dml_rq_regs->rq_regs_c.swath_height)
1349 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG:SWATH_HEIGHT_C - Expected: %u  Actual: %u\n",
1350 				dml_rq_regs->rq_regs_c.swath_height, rq_regs.rq_regs_c.swath_height);
1351 	if (rq_regs.rq_regs_c.pte_row_height_linear != dml_rq_regs->rq_regs_c.pte_row_height_linear)
1352 		DC_LOG_DEBUG("DML Validation | DCHUBP_REQ_SIZE_CONFIG:PTE_ROW_HEIGHT_LINEAR_C - Expected: %u  Actual: %u\n",
1353 				dml_rq_regs->rq_regs_c.pte_row_height_linear, rq_regs.rq_regs_c.pte_row_height_linear);
1354 
1355 	/* DLG - Per hubp */
1356 	REG_GET_2(BLANK_OFFSET_0,
1357 		REFCYC_H_BLANK_END, &dlg_attr.refcyc_h_blank_end,
1358 		DLG_V_BLANK_END, &dlg_attr.dlg_vblank_end);
1359 	REG_GET(BLANK_OFFSET_1,
1360 		MIN_DST_Y_NEXT_START, &dlg_attr.min_dst_y_next_start);
1361 	REG_GET(DST_DIMENSIONS,
1362 		REFCYC_PER_HTOTAL, &dlg_attr.refcyc_per_htotal);
1363 	REG_GET_2(DST_AFTER_SCALER,
1364 		REFCYC_X_AFTER_SCALER, &dlg_attr.refcyc_x_after_scaler,
1365 		DST_Y_AFTER_SCALER, &dlg_attr.dst_y_after_scaler);
1366 	REG_GET(REF_FREQ_TO_PIX_FREQ,
1367 		REF_FREQ_TO_PIX_FREQ, &dlg_attr.ref_freq_to_pix_freq);
1368 
1369 	if (dlg_attr.refcyc_h_blank_end != dml_dlg_attr->refcyc_h_blank_end)
1370 		DC_LOG_DEBUG("DML Validation | BLANK_OFFSET_0:REFCYC_H_BLANK_END - Expected: %u  Actual: %u\n",
1371 				dml_dlg_attr->refcyc_h_blank_end, dlg_attr.refcyc_h_blank_end);
1372 	if (dlg_attr.dlg_vblank_end != dml_dlg_attr->dlg_vblank_end)
1373 		DC_LOG_DEBUG("DML Validation | BLANK_OFFSET_0:DLG_V_BLANK_END - Expected: %u  Actual: %u\n",
1374 				dml_dlg_attr->dlg_vblank_end, dlg_attr.dlg_vblank_end);
1375 	if (dlg_attr.min_dst_y_next_start != dml_dlg_attr->min_dst_y_next_start)
1376 		DC_LOG_DEBUG("DML Validation | BLANK_OFFSET_1:MIN_DST_Y_NEXT_START - Expected: %u  Actual: %u\n",
1377 				dml_dlg_attr->min_dst_y_next_start, dlg_attr.min_dst_y_next_start);
1378 	if (dlg_attr.refcyc_per_htotal != dml_dlg_attr->refcyc_per_htotal)
1379 		DC_LOG_DEBUG("DML Validation | DST_DIMENSIONS:REFCYC_PER_HTOTAL - Expected: %u  Actual: %u\n",
1380 				dml_dlg_attr->refcyc_per_htotal, dlg_attr.refcyc_per_htotal);
1381 	if (dlg_attr.refcyc_x_after_scaler != dml_dlg_attr->refcyc_x_after_scaler)
1382 		DC_LOG_DEBUG("DML Validation | DST_AFTER_SCALER:REFCYC_X_AFTER_SCALER - Expected: %u  Actual: %u\n",
1383 				dml_dlg_attr->refcyc_x_after_scaler, dlg_attr.refcyc_x_after_scaler);
1384 	if (dlg_attr.dst_y_after_scaler != dml_dlg_attr->dst_y_after_scaler)
1385 		DC_LOG_DEBUG("DML Validation | DST_AFTER_SCALER:DST_Y_AFTER_SCALER - Expected: %u  Actual: %u\n",
1386 				dml_dlg_attr->dst_y_after_scaler, dlg_attr.dst_y_after_scaler);
1387 	if (dlg_attr.ref_freq_to_pix_freq != dml_dlg_attr->ref_freq_to_pix_freq)
1388 		DC_LOG_DEBUG("DML Validation | REF_FREQ_TO_PIX_FREQ:REF_FREQ_TO_PIX_FREQ - Expected: %u  Actual: %u\n",
1389 				dml_dlg_attr->ref_freq_to_pix_freq, dlg_attr.ref_freq_to_pix_freq);
1390 
1391 	/* DLG - Per luma/chroma */
1392 	REG_GET(VBLANK_PARAMETERS_1,
1393 		REFCYC_PER_PTE_GROUP_VBLANK_L, &dlg_attr.refcyc_per_pte_group_vblank_l);
1394 	if (REG(NOM_PARAMETERS_0))
1395 		REG_GET(NOM_PARAMETERS_0,
1396 			DST_Y_PER_PTE_ROW_NOM_L, &dlg_attr.dst_y_per_pte_row_nom_l);
1397 	if (REG(NOM_PARAMETERS_1))
1398 		REG_GET(NOM_PARAMETERS_1,
1399 			REFCYC_PER_PTE_GROUP_NOM_L, &dlg_attr.refcyc_per_pte_group_nom_l);
1400 	REG_GET(NOM_PARAMETERS_4,
1401 		DST_Y_PER_META_ROW_NOM_L, &dlg_attr.dst_y_per_meta_row_nom_l);
1402 	REG_GET(NOM_PARAMETERS_5,
1403 		REFCYC_PER_META_CHUNK_NOM_L, &dlg_attr.refcyc_per_meta_chunk_nom_l);
1404 	REG_GET_2(PER_LINE_DELIVERY,
1405 		REFCYC_PER_LINE_DELIVERY_L, &dlg_attr.refcyc_per_line_delivery_l,
1406 		REFCYC_PER_LINE_DELIVERY_C, &dlg_attr.refcyc_per_line_delivery_c);
1407 	REG_GET_2(PER_LINE_DELIVERY_PRE,
1408 		REFCYC_PER_LINE_DELIVERY_PRE_L, &dlg_attr.refcyc_per_line_delivery_pre_l,
1409 		REFCYC_PER_LINE_DELIVERY_PRE_C, &dlg_attr.refcyc_per_line_delivery_pre_c);
1410 	REG_GET(VBLANK_PARAMETERS_2,
1411 		REFCYC_PER_PTE_GROUP_VBLANK_C, &dlg_attr.refcyc_per_pte_group_vblank_c);
1412 	if (REG(NOM_PARAMETERS_2))
1413 		REG_GET(NOM_PARAMETERS_2,
1414 			DST_Y_PER_PTE_ROW_NOM_C, &dlg_attr.dst_y_per_pte_row_nom_c);
1415 	if (REG(NOM_PARAMETERS_3))
1416 		REG_GET(NOM_PARAMETERS_3,
1417 			REFCYC_PER_PTE_GROUP_NOM_C, &dlg_attr.refcyc_per_pte_group_nom_c);
1418 	REG_GET(NOM_PARAMETERS_6,
1419 		DST_Y_PER_META_ROW_NOM_C, &dlg_attr.dst_y_per_meta_row_nom_c);
1420 	REG_GET(NOM_PARAMETERS_7,
1421 		REFCYC_PER_META_CHUNK_NOM_C, &dlg_attr.refcyc_per_meta_chunk_nom_c);
1422 	REG_GET(VBLANK_PARAMETERS_3,
1423 			REFCYC_PER_META_CHUNK_VBLANK_L, &dlg_attr.refcyc_per_meta_chunk_vblank_l);
1424 	REG_GET(VBLANK_PARAMETERS_4,
1425 			REFCYC_PER_META_CHUNK_VBLANK_C, &dlg_attr.refcyc_per_meta_chunk_vblank_c);
1426 
1427 	if (dlg_attr.refcyc_per_pte_group_vblank_l != dml_dlg_attr->refcyc_per_pte_group_vblank_l)
1428 		DC_LOG_DEBUG("DML Validation | VBLANK_PARAMETERS_1:REFCYC_PER_PTE_GROUP_VBLANK_L - Expected: %u  Actual: %u\n",
1429 				dml_dlg_attr->refcyc_per_pte_group_vblank_l, dlg_attr.refcyc_per_pte_group_vblank_l);
1430 	if (dlg_attr.dst_y_per_pte_row_nom_l != dml_dlg_attr->dst_y_per_pte_row_nom_l)
1431 		DC_LOG_DEBUG("DML Validation | NOM_PARAMETERS_0:DST_Y_PER_PTE_ROW_NOM_L - Expected: %u  Actual: %u\n",
1432 				dml_dlg_attr->dst_y_per_pte_row_nom_l, dlg_attr.dst_y_per_pte_row_nom_l);
1433 	if (dlg_attr.refcyc_per_pte_group_nom_l != dml_dlg_attr->refcyc_per_pte_group_nom_l)
1434 		DC_LOG_DEBUG("DML Validation | NOM_PARAMETERS_1:REFCYC_PER_PTE_GROUP_NOM_L - Expected: %u  Actual: %u\n",
1435 				dml_dlg_attr->refcyc_per_pte_group_nom_l, dlg_attr.refcyc_per_pte_group_nom_l);
1436 	if (dlg_attr.dst_y_per_meta_row_nom_l != dml_dlg_attr->dst_y_per_meta_row_nom_l)
1437 		DC_LOG_DEBUG("DML Validation | NOM_PARAMETERS_4:DST_Y_PER_META_ROW_NOM_L - Expected: %u  Actual: %u\n",
1438 				dml_dlg_attr->dst_y_per_meta_row_nom_l, dlg_attr.dst_y_per_meta_row_nom_l);
1439 	if (dlg_attr.refcyc_per_meta_chunk_nom_l != dml_dlg_attr->refcyc_per_meta_chunk_nom_l)
1440 		DC_LOG_DEBUG("DML Validation | NOM_PARAMETERS_5:REFCYC_PER_META_CHUNK_NOM_L - Expected: %u  Actual: %u\n",
1441 				dml_dlg_attr->refcyc_per_meta_chunk_nom_l, dlg_attr.refcyc_per_meta_chunk_nom_l);
1442 	if (dlg_attr.refcyc_per_line_delivery_l != dml_dlg_attr->refcyc_per_line_delivery_l)
1443 		DC_LOG_DEBUG("DML Validation | PER_LINE_DELIVERY:REFCYC_PER_LINE_DELIVERY_L - Expected: %u  Actual: %u\n",
1444 				dml_dlg_attr->refcyc_per_line_delivery_l, dlg_attr.refcyc_per_line_delivery_l);
1445 	if (dlg_attr.refcyc_per_line_delivery_c != dml_dlg_attr->refcyc_per_line_delivery_c)
1446 		DC_LOG_DEBUG("DML Validation | PER_LINE_DELIVERY:REFCYC_PER_LINE_DELIVERY_C - Expected: %u  Actual: %u\n",
1447 				dml_dlg_attr->refcyc_per_line_delivery_c, dlg_attr.refcyc_per_line_delivery_c);
1448 	if (dlg_attr.refcyc_per_pte_group_vblank_c != dml_dlg_attr->refcyc_per_pte_group_vblank_c)
1449 		DC_LOG_DEBUG("DML Validation | VBLANK_PARAMETERS_2:REFCYC_PER_PTE_GROUP_VBLANK_C - Expected: %u  Actual: %u\n",
1450 				dml_dlg_attr->refcyc_per_pte_group_vblank_c, dlg_attr.refcyc_per_pte_group_vblank_c);
1451 	if (dlg_attr.dst_y_per_pte_row_nom_c != dml_dlg_attr->dst_y_per_pte_row_nom_c)
1452 		DC_LOG_DEBUG("DML Validation | NOM_PARAMETERS_2:DST_Y_PER_PTE_ROW_NOM_C - Expected: %u  Actual: %u\n",
1453 				dml_dlg_attr->dst_y_per_pte_row_nom_c, dlg_attr.dst_y_per_pte_row_nom_c);
1454 	if (dlg_attr.refcyc_per_pte_group_nom_c != dml_dlg_attr->refcyc_per_pte_group_nom_c)
1455 		DC_LOG_DEBUG("DML Validation | NOM_PARAMETERS_3:REFCYC_PER_PTE_GROUP_NOM_C - Expected: %u  Actual: %u\n",
1456 				dml_dlg_attr->refcyc_per_pte_group_nom_c, dlg_attr.refcyc_per_pte_group_nom_c);
1457 	if (dlg_attr.dst_y_per_meta_row_nom_c != dml_dlg_attr->dst_y_per_meta_row_nom_c)
1458 		DC_LOG_DEBUG("DML Validation | NOM_PARAMETERS_6:DST_Y_PER_META_ROW_NOM_C - Expected: %u  Actual: %u\n",
1459 				dml_dlg_attr->dst_y_per_meta_row_nom_c, dlg_attr.dst_y_per_meta_row_nom_c);
1460 	if (dlg_attr.refcyc_per_meta_chunk_nom_c != dml_dlg_attr->refcyc_per_meta_chunk_nom_c)
1461 		DC_LOG_DEBUG("DML Validation | NOM_PARAMETERS_7:REFCYC_PER_META_CHUNK_NOM_C - Expected: %u  Actual: %u\n",
1462 				dml_dlg_attr->refcyc_per_meta_chunk_nom_c, dlg_attr.refcyc_per_meta_chunk_nom_c);
1463 	if (dlg_attr.refcyc_per_line_delivery_pre_l != dml_dlg_attr->refcyc_per_line_delivery_pre_l)
1464 		DC_LOG_DEBUG("DML Validation | PER_LINE_DELIVERY_PRE:REFCYC_PER_LINE_DELIVERY_PRE_L - Expected: %u  Actual: %u\n",
1465 				dml_dlg_attr->refcyc_per_line_delivery_pre_l, dlg_attr.refcyc_per_line_delivery_pre_l);
1466 	if (dlg_attr.refcyc_per_line_delivery_pre_c != dml_dlg_attr->refcyc_per_line_delivery_pre_c)
1467 		DC_LOG_DEBUG("DML Validation | PER_LINE_DELIVERY_PRE:REFCYC_PER_LINE_DELIVERY_PRE_C - Expected: %u  Actual: %u\n",
1468 				dml_dlg_attr->refcyc_per_line_delivery_pre_c, dlg_attr.refcyc_per_line_delivery_pre_c);
1469 	if (dlg_attr.refcyc_per_meta_chunk_vblank_l != dml_dlg_attr->refcyc_per_meta_chunk_vblank_l)
1470 		DC_LOG_DEBUG("DML Validation | VBLANK_PARAMETERS_3:REFCYC_PER_META_CHUNK_VBLANK_L - Expected: %u  Actual: %u\n",
1471 				dml_dlg_attr->refcyc_per_meta_chunk_vblank_l, dlg_attr.refcyc_per_meta_chunk_vblank_l);
1472 	if (dlg_attr.refcyc_per_meta_chunk_vblank_c != dml_dlg_attr->refcyc_per_meta_chunk_vblank_c)
1473 		DC_LOG_DEBUG("DML Validation | VBLANK_PARAMETERS_4:REFCYC_PER_META_CHUNK_VBLANK_C - Expected: %u  Actual: %u\n",
1474 				dml_dlg_attr->refcyc_per_meta_chunk_vblank_c, dlg_attr.refcyc_per_meta_chunk_vblank_c);
1475 
1476 	/* TTU - per hubp */
1477 	REG_GET_2(DCN_TTU_QOS_WM,
1478 		QoS_LEVEL_LOW_WM, &ttu_attr.qos_level_low_wm,
1479 		QoS_LEVEL_HIGH_WM, &ttu_attr.qos_level_high_wm);
1480 
1481 	if (ttu_attr.qos_level_low_wm != dml_ttu_attr->qos_level_low_wm)
1482 		DC_LOG_DEBUG("DML Validation | DCN_TTU_QOS_WM:QoS_LEVEL_LOW_WM - Expected: %u  Actual: %u\n",
1483 				dml_ttu_attr->qos_level_low_wm, ttu_attr.qos_level_low_wm);
1484 	if (ttu_attr.qos_level_high_wm != dml_ttu_attr->qos_level_high_wm)
1485 		DC_LOG_DEBUG("DML Validation | DCN_TTU_QOS_WM:QoS_LEVEL_HIGH_WM - Expected: %u  Actual: %u\n",
1486 				dml_ttu_attr->qos_level_high_wm, ttu_attr.qos_level_high_wm);
1487 
1488 	/* TTU - per luma/chroma */
1489 	/* Assumed surf0 is luma and 1 is chroma */
1490 	REG_GET_3(DCN_SURF0_TTU_CNTL0,
1491 		REFCYC_PER_REQ_DELIVERY, &ttu_attr.refcyc_per_req_delivery_l,
1492 		QoS_LEVEL_FIXED, &ttu_attr.qos_level_fixed_l,
1493 		QoS_RAMP_DISABLE, &ttu_attr.qos_ramp_disable_l);
1494 	REG_GET_3(DCN_SURF1_TTU_CNTL0,
1495 		REFCYC_PER_REQ_DELIVERY, &ttu_attr.refcyc_per_req_delivery_c,
1496 		QoS_LEVEL_FIXED, &ttu_attr.qos_level_fixed_c,
1497 		QoS_RAMP_DISABLE, &ttu_attr.qos_ramp_disable_c);
1498 	REG_GET_3(DCN_CUR0_TTU_CNTL0,
1499 		REFCYC_PER_REQ_DELIVERY, &ttu_attr.refcyc_per_req_delivery_cur0,
1500 		QoS_LEVEL_FIXED, &ttu_attr.qos_level_fixed_cur0,
1501 		QoS_RAMP_DISABLE, &ttu_attr.qos_ramp_disable_cur0);
1502 	REG_GET(FLIP_PARAMETERS_1,
1503 		REFCYC_PER_PTE_GROUP_FLIP_L, &dlg_attr.refcyc_per_pte_group_flip_l);
1504 	REG_GET(DCN_CUR0_TTU_CNTL1,
1505 			REFCYC_PER_REQ_DELIVERY_PRE, &ttu_attr.refcyc_per_req_delivery_pre_cur0);
1506 	REG_GET(DCN_CUR1_TTU_CNTL1,
1507 			REFCYC_PER_REQ_DELIVERY_PRE, &ttu_attr.refcyc_per_req_delivery_pre_cur1);
1508 	REG_GET(DCN_SURF0_TTU_CNTL1,
1509 			REFCYC_PER_REQ_DELIVERY_PRE, &ttu_attr.refcyc_per_req_delivery_pre_l);
1510 	REG_GET(DCN_SURF1_TTU_CNTL1,
1511 			REFCYC_PER_REQ_DELIVERY_PRE, &ttu_attr.refcyc_per_req_delivery_pre_c);
1512 
1513 	if (ttu_attr.refcyc_per_req_delivery_l != dml_ttu_attr->refcyc_per_req_delivery_l)
1514 		DC_LOG_DEBUG("DML Validation | DCN_SURF0_TTU_CNTL0:REFCYC_PER_REQ_DELIVERY - Expected: %u  Actual: %u\n",
1515 				dml_ttu_attr->refcyc_per_req_delivery_l, ttu_attr.refcyc_per_req_delivery_l);
1516 	if (ttu_attr.qos_level_fixed_l != dml_ttu_attr->qos_level_fixed_l)
1517 		DC_LOG_DEBUG("DML Validation | DCN_SURF0_TTU_CNTL0:QoS_LEVEL_FIXED - Expected: %u  Actual: %u\n",
1518 				dml_ttu_attr->qos_level_fixed_l, ttu_attr.qos_level_fixed_l);
1519 	if (ttu_attr.qos_ramp_disable_l != dml_ttu_attr->qos_ramp_disable_l)
1520 		DC_LOG_DEBUG("DML Validation | DCN_SURF0_TTU_CNTL0:QoS_RAMP_DISABLE - Expected: %u  Actual: %u\n",
1521 				dml_ttu_attr->qos_ramp_disable_l, ttu_attr.qos_ramp_disable_l);
1522 	if (ttu_attr.refcyc_per_req_delivery_c != dml_ttu_attr->refcyc_per_req_delivery_c)
1523 		DC_LOG_DEBUG("DML Validation | DCN_SURF1_TTU_CNTL0:REFCYC_PER_REQ_DELIVERY - Expected: %u  Actual: %u\n",
1524 				dml_ttu_attr->refcyc_per_req_delivery_c, ttu_attr.refcyc_per_req_delivery_c);
1525 	if (ttu_attr.qos_level_fixed_c != dml_ttu_attr->qos_level_fixed_c)
1526 		DC_LOG_DEBUG("DML Validation | DCN_SURF1_TTU_CNTL0:QoS_LEVEL_FIXED - Expected: %u  Actual: %u\n",
1527 				dml_ttu_attr->qos_level_fixed_c, ttu_attr.qos_level_fixed_c);
1528 	if (ttu_attr.qos_ramp_disable_c != dml_ttu_attr->qos_ramp_disable_c)
1529 		DC_LOG_DEBUG("DML Validation | DCN_SURF1_TTU_CNTL0:QoS_RAMP_DISABLE - Expected: %u  Actual: %u\n",
1530 				dml_ttu_attr->qos_ramp_disable_c, ttu_attr.qos_ramp_disable_c);
1531 	if (ttu_attr.refcyc_per_req_delivery_cur0 != dml_ttu_attr->refcyc_per_req_delivery_cur0)
1532 		DC_LOG_DEBUG("DML Validation | DCN_CUR0_TTU_CNTL0:REFCYC_PER_REQ_DELIVERY - Expected: %u  Actual: %u\n",
1533 				dml_ttu_attr->refcyc_per_req_delivery_cur0, ttu_attr.refcyc_per_req_delivery_cur0);
1534 	if (ttu_attr.qos_level_fixed_cur0 != dml_ttu_attr->qos_level_fixed_cur0)
1535 		DC_LOG_DEBUG("DML Validation | DCN_CUR0_TTU_CNTL0:QoS_LEVEL_FIXED - Expected: %u  Actual: %u\n",
1536 				dml_ttu_attr->qos_level_fixed_cur0, ttu_attr.qos_level_fixed_cur0);
1537 	if (ttu_attr.qos_ramp_disable_cur0 != dml_ttu_attr->qos_ramp_disable_cur0)
1538 		DC_LOG_DEBUG("DML Validation | DCN_CUR0_TTU_CNTL0:QoS_RAMP_DISABLE - Expected: %u  Actual: %u\n",
1539 				dml_ttu_attr->qos_ramp_disable_cur0, ttu_attr.qos_ramp_disable_cur0);
1540 	if (dlg_attr.refcyc_per_pte_group_flip_l != dml_dlg_attr->refcyc_per_pte_group_flip_l)
1541 		DC_LOG_DEBUG("DML Validation | FLIP_PARAMETERS_1:REFCYC_PER_PTE_GROUP_FLIP_L - Expected: %u  Actual: %u\n",
1542 				dml_dlg_attr->refcyc_per_pte_group_flip_l, dlg_attr.refcyc_per_pte_group_flip_l);
1543 	if (ttu_attr.refcyc_per_req_delivery_pre_cur0 != dml_ttu_attr->refcyc_per_req_delivery_pre_cur0)
1544 		DC_LOG_DEBUG("DML Validation | DCN_CUR0_TTU_CNTL1:REFCYC_PER_REQ_DELIVERY_PRE - Expected: %u  Actual: %u\n",
1545 				dml_ttu_attr->refcyc_per_req_delivery_pre_cur0, ttu_attr.refcyc_per_req_delivery_pre_cur0);
1546 	if (ttu_attr.refcyc_per_req_delivery_pre_cur1 != dml_ttu_attr->refcyc_per_req_delivery_pre_cur1)
1547 		DC_LOG_DEBUG("DML Validation | DCN_CUR1_TTU_CNTL1:REFCYC_PER_REQ_DELIVERY_PRE - Expected: %u  Actual: %u\n",
1548 				dml_ttu_attr->refcyc_per_req_delivery_pre_cur1, ttu_attr.refcyc_per_req_delivery_pre_cur1);
1549 	if (ttu_attr.refcyc_per_req_delivery_pre_l != dml_ttu_attr->refcyc_per_req_delivery_pre_l)
1550 		DC_LOG_DEBUG("DML Validation | DCN_SURF0_TTU_CNTL1:REFCYC_PER_REQ_DELIVERY_PRE - Expected: %u  Actual: %u\n",
1551 				dml_ttu_attr->refcyc_per_req_delivery_pre_l, ttu_attr.refcyc_per_req_delivery_pre_l);
1552 	if (ttu_attr.refcyc_per_req_delivery_pre_c != dml_ttu_attr->refcyc_per_req_delivery_pre_c)
1553 		DC_LOG_DEBUG("DML Validation | DCN_SURF1_TTU_CNTL1:REFCYC_PER_REQ_DELIVERY_PRE - Expected: %u  Actual: %u\n",
1554 				dml_ttu_attr->refcyc_per_req_delivery_pre_c, ttu_attr.refcyc_per_req_delivery_pre_c);
1555 }
1556 
1557 static struct hubp_funcs dcn20_hubp_funcs = {
1558 	.hubp_enable_tripleBuffer = hubp2_enable_triplebuffer,
1559 	.hubp_is_triplebuffer_enabled = hubp2_is_triplebuffer_enabled,
1560 	.hubp_program_surface_flip_and_addr = hubp2_program_surface_flip_and_addr,
1561 	.hubp_program_surface_config = hubp2_program_surface_config,
1562 	.hubp_is_flip_pending = hubp2_is_flip_pending,
1563 	.hubp_setup = hubp2_setup,
1564 	.hubp_setup_interdependent = hubp2_setup_interdependent,
1565 	.hubp_set_vm_system_aperture_settings = hubp2_set_vm_system_aperture_settings,
1566 	.set_blank = hubp2_set_blank,
1567 	.dcc_control = hubp2_dcc_control,
1568 	.mem_program_viewport = min_set_viewport,
1569 	.set_cursor_attributes	= hubp2_cursor_set_attributes,
1570 	.set_cursor_position	= hubp2_cursor_set_position,
1571 	.hubp_clk_cntl = hubp2_clk_cntl,
1572 	.hubp_vtg_sel = hubp2_vtg_sel,
1573 	.dmdata_set_attributes = hubp2_dmdata_set_attributes,
1574 	.dmdata_load = hubp2_dmdata_load,
1575 	.dmdata_status_done = hubp2_dmdata_status_done,
1576 	.hubp_read_state = hubp2_read_state,
1577 	.hubp_clear_underflow = hubp2_clear_underflow,
1578 	.hubp_set_flip_control_surface_gsl = hubp2_set_flip_control_surface_gsl,
1579 	.hubp_init = hubp1_init,
1580 	.validate_dml_output = hubp2_validate_dml_output,
1581 };
1582 
1583 
1584 bool hubp2_construct(
1585 	struct dcn20_hubp *hubp2,
1586 	struct dc_context *ctx,
1587 	uint32_t inst,
1588 	const struct dcn_hubp2_registers *hubp_regs,
1589 	const struct dcn_hubp2_shift *hubp_shift,
1590 	const struct dcn_hubp2_mask *hubp_mask)
1591 {
1592 	hubp2->base.funcs = &dcn20_hubp_funcs;
1593 	hubp2->base.ctx = ctx;
1594 	hubp2->hubp_regs = hubp_regs;
1595 	hubp2->hubp_shift = hubp_shift;
1596 	hubp2->hubp_mask = hubp_mask;
1597 	hubp2->base.inst = inst;
1598 	hubp2->base.opp_id = OPP_ID_INVALID;
1599 	hubp2->base.mpcc_id = 0xf;
1600 
1601 	return true;
1602 }
1603