14a488a7aSOded Gabbay /* 24a488a7aSOded Gabbay * Copyright 2014 Advanced Micro Devices, Inc. 34a488a7aSOded Gabbay * 44a488a7aSOded Gabbay * Permission is hereby granted, free of charge, to any person obtaining a 54a488a7aSOded Gabbay * copy of this software and associated documentation files (the "Software"), 64a488a7aSOded Gabbay * to deal in the Software without restriction, including without limitation 74a488a7aSOded Gabbay * the rights to use, copy, modify, merge, publish, distribute, sublicense, 84a488a7aSOded Gabbay * and/or sell copies of the Software, and to permit persons to whom the 94a488a7aSOded Gabbay * Software is furnished to do so, subject to the following conditions: 104a488a7aSOded Gabbay * 114a488a7aSOded Gabbay * The above copyright notice and this permission notice shall be included in 124a488a7aSOded Gabbay * all copies or substantial portions of the Software. 134a488a7aSOded Gabbay * 144a488a7aSOded Gabbay * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR 154a488a7aSOded Gabbay * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, 164a488a7aSOded Gabbay * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL 174a488a7aSOded Gabbay * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR 184a488a7aSOded Gabbay * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, 194a488a7aSOded Gabbay * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR 204a488a7aSOded Gabbay * OTHER DEALINGS IN THE SOFTWARE. 214a488a7aSOded Gabbay */ 224a488a7aSOded Gabbay 234a488a7aSOded Gabbay #ifndef KFD_PRIV_H_INCLUDED 244a488a7aSOded Gabbay #define KFD_PRIV_H_INCLUDED 254a488a7aSOded Gabbay 264a488a7aSOded Gabbay #include <linux/hashtable.h> 274a488a7aSOded Gabbay #include <linux/mmu_notifier.h> 284a488a7aSOded Gabbay #include <linux/mutex.h> 294a488a7aSOded Gabbay #include <linux/types.h> 304a488a7aSOded Gabbay #include <linux/atomic.h> 314a488a7aSOded Gabbay #include <linux/workqueue.h> 324a488a7aSOded Gabbay #include <linux/spinlock.h> 3319f6d2a6SOded Gabbay #include <linux/kfd_ioctl.h> 344a488a7aSOded Gabbay #include <kgd_kfd_interface.h> 354a488a7aSOded Gabbay 365b5c4e40SEvgeny Pinchuk #define KFD_SYSFS_FILE_MODE 0444 375b5c4e40SEvgeny Pinchuk 38f3a39818SAndrew Lewycky #define KFD_MMAP_DOORBELL_MASK 0x8000000000000 39f3a39818SAndrew Lewycky #define KFD_MMAP_EVENTS_MASK 0x4000000000000 40f3a39818SAndrew Lewycky 41ed6e6a34SBen Goz /* 42ed6e6a34SBen Goz * When working with cp scheduler we should assign the HIQ manually or via 43ed6e6a34SBen Goz * the radeon driver to a fixed hqd slot, here are the fixed HIQ hqd slot 44ed6e6a34SBen Goz * definitions for Kaveri. In Kaveri only the first ME queues participates 45ed6e6a34SBen Goz * in the cp scheduling taking that in mind we set the HIQ slot in the 46ed6e6a34SBen Goz * second ME. 47ed6e6a34SBen Goz */ 48ed6e6a34SBen Goz #define KFD_CIK_HIQ_PIPE 4 49ed6e6a34SBen Goz #define KFD_CIK_HIQ_QUEUE 0 50ed6e6a34SBen Goz 515b5c4e40SEvgeny Pinchuk /* GPU ID hash width in bits */ 525b5c4e40SEvgeny Pinchuk #define KFD_GPU_ID_HASH_WIDTH 16 535b5c4e40SEvgeny Pinchuk 545b5c4e40SEvgeny Pinchuk /* Macro for allocating structures */ 555b5c4e40SEvgeny Pinchuk #define kfd_alloc_struct(ptr_to_struct) \ 565b5c4e40SEvgeny Pinchuk ((typeof(ptr_to_struct)) kzalloc(sizeof(*ptr_to_struct), GFP_KERNEL)) 575b5c4e40SEvgeny Pinchuk 5819f6d2a6SOded Gabbay #define KFD_MAX_NUM_OF_PROCESSES 512 59b8cbab04SOded Gabbay #define KFD_MAX_NUM_OF_QUEUES_PER_PROCESS 1024 6019f6d2a6SOded Gabbay 6119f6d2a6SOded Gabbay /* 62b8cbab04SOded Gabbay * Kernel module parameter to specify maximum number of supported queues per 63b8cbab04SOded Gabbay * device 6419f6d2a6SOded Gabbay */ 65b8cbab04SOded Gabbay extern int max_num_of_queues_per_device; 6619f6d2a6SOded Gabbay 67b8cbab04SOded Gabbay #define KFD_MAX_NUM_OF_QUEUES_PER_DEVICE_DEFAULT 4096 68b8cbab04SOded Gabbay #define KFD_MAX_NUM_OF_QUEUES_PER_DEVICE \ 69b8cbab04SOded Gabbay (KFD_MAX_NUM_OF_PROCESSES * \ 70b8cbab04SOded Gabbay KFD_MAX_NUM_OF_QUEUES_PER_PROCESS) 7119f6d2a6SOded Gabbay 72ed6e6a34SBen Goz #define KFD_KERNEL_QUEUE_SIZE 2048 73ed6e6a34SBen Goz 7431c21fecSBen Goz /* Kernel module parameter to specify the scheduling policy */ 7531c21fecSBen Goz extern int sched_policy; 7631c21fecSBen Goz 7731c21fecSBen Goz /** 7831c21fecSBen Goz * enum kfd_sched_policy 7931c21fecSBen Goz * 8031c21fecSBen Goz * @KFD_SCHED_POLICY_HWS: H/W scheduling policy known as command processor (cp) 8131c21fecSBen Goz * scheduling. In this scheduling mode we're using the firmware code to 8231c21fecSBen Goz * schedule the user mode queues and kernel queues such as HIQ and DIQ. 8331c21fecSBen Goz * the HIQ queue is used as a special queue that dispatches the configuration 8431c21fecSBen Goz * to the cp and the user mode queues list that are currently running. 8531c21fecSBen Goz * the DIQ queue is a debugging queue that dispatches debugging commands to the 8631c21fecSBen Goz * firmware. 8731c21fecSBen Goz * in this scheduling mode user mode queues over subscription feature is 8831c21fecSBen Goz * enabled. 8931c21fecSBen Goz * 9031c21fecSBen Goz * @KFD_SCHED_POLICY_HWS_NO_OVERSUBSCRIPTION: The same as above but the over 9131c21fecSBen Goz * subscription feature disabled. 9231c21fecSBen Goz * 9331c21fecSBen Goz * @KFD_SCHED_POLICY_NO_HWS: no H/W scheduling policy is a mode which directly 9431c21fecSBen Goz * set the command processor registers and sets the queues "manually". This 9531c21fecSBen Goz * mode is used *ONLY* for debugging proposes. 9631c21fecSBen Goz * 9731c21fecSBen Goz */ 9831c21fecSBen Goz enum kfd_sched_policy { 9931c21fecSBen Goz KFD_SCHED_POLICY_HWS = 0, 10031c21fecSBen Goz KFD_SCHED_POLICY_HWS_NO_OVERSUBSCRIPTION, 10131c21fecSBen Goz KFD_SCHED_POLICY_NO_HWS 10231c21fecSBen Goz }; 10331c21fecSBen Goz 104ed6e6a34SBen Goz enum cache_policy { 105ed6e6a34SBen Goz cache_policy_coherent, 106ed6e6a34SBen Goz cache_policy_noncoherent 107ed6e6a34SBen Goz }; 108ed6e6a34SBen Goz 1090da7558cSBen Goz enum asic_family_type { 1100da7558cSBen Goz CHIP_KAVERI = 0, 1110da7558cSBen Goz CHIP_CARRIZO 1120da7558cSBen Goz }; 1130da7558cSBen Goz 114f3a39818SAndrew Lewycky struct kfd_event_interrupt_class { 115f3a39818SAndrew Lewycky bool (*interrupt_isr)(struct kfd_dev *dev, 116f3a39818SAndrew Lewycky const uint32_t *ih_ring_entry); 117f3a39818SAndrew Lewycky void (*interrupt_wq)(struct kfd_dev *dev, 118f3a39818SAndrew Lewycky const uint32_t *ih_ring_entry); 119f3a39818SAndrew Lewycky }; 120f3a39818SAndrew Lewycky 1214a488a7aSOded Gabbay struct kfd_device_info { 1220da7558cSBen Goz unsigned int asic_family; 123f3a39818SAndrew Lewycky const struct kfd_event_interrupt_class *event_interrupt_class; 1244a488a7aSOded Gabbay unsigned int max_pasid_bits; 1254a488a7aSOded Gabbay size_t ih_ring_entry_size; 126f7c826adSAlexey Skidanov uint8_t num_of_watch_points; 12719f6d2a6SOded Gabbay uint16_t mqd_size_aligned; 1284a488a7aSOded Gabbay }; 1294a488a7aSOded Gabbay 13036b5c08fSOded Gabbay struct kfd_mem_obj { 13136b5c08fSOded Gabbay uint32_t range_start; 13236b5c08fSOded Gabbay uint32_t range_end; 13336b5c08fSOded Gabbay uint64_t gpu_addr; 13436b5c08fSOded Gabbay uint32_t *cpu_ptr; 13536b5c08fSOded Gabbay }; 13636b5c08fSOded Gabbay 1374a488a7aSOded Gabbay struct kfd_dev { 1384a488a7aSOded Gabbay struct kgd_dev *kgd; 1394a488a7aSOded Gabbay 1404a488a7aSOded Gabbay const struct kfd_device_info *device_info; 1414a488a7aSOded Gabbay struct pci_dev *pdev; 1424a488a7aSOded Gabbay 1434a488a7aSOded Gabbay unsigned int id; /* topology stub index */ 1444a488a7aSOded Gabbay 14519f6d2a6SOded Gabbay phys_addr_t doorbell_base; /* Start of actual doorbells used by 14619f6d2a6SOded Gabbay * KFD. It is aligned for mapping 14719f6d2a6SOded Gabbay * into user mode 14819f6d2a6SOded Gabbay */ 14919f6d2a6SOded Gabbay size_t doorbell_id_offset; /* Doorbell offset (from KFD doorbell 15019f6d2a6SOded Gabbay * to HW doorbell, GFX reserved some 15119f6d2a6SOded Gabbay * at the start) 15219f6d2a6SOded Gabbay */ 15319f6d2a6SOded Gabbay size_t doorbell_process_limit; /* Number of processes we have doorbell 15419f6d2a6SOded Gabbay * space for. 15519f6d2a6SOded Gabbay */ 15619f6d2a6SOded Gabbay u32 __iomem *doorbell_kernel_ptr; /* This is a pointer for a doorbells 15719f6d2a6SOded Gabbay * page used by kernel queue 15819f6d2a6SOded Gabbay */ 15919f6d2a6SOded Gabbay 1604a488a7aSOded Gabbay struct kgd2kfd_shared_resources shared_resources; 1614a488a7aSOded Gabbay 162cea405b1SXihan Zhang const struct kfd2kgd_calls *kfd2kgd; 163cea405b1SXihan Zhang struct mutex doorbell_mutex; 164cea405b1SXihan Zhang unsigned long doorbell_available_index[DIV_ROUND_UP( 165cea405b1SXihan Zhang KFD_MAX_NUM_OF_QUEUES_PER_PROCESS, BITS_PER_LONG)]; 166cea405b1SXihan Zhang 16736b5c08fSOded Gabbay void *gtt_mem; 16836b5c08fSOded Gabbay uint64_t gtt_start_gpu_addr; 16936b5c08fSOded Gabbay void *gtt_start_cpu_ptr; 17036b5c08fSOded Gabbay void *gtt_sa_bitmap; 17136b5c08fSOded Gabbay struct mutex gtt_sa_lock; 17236b5c08fSOded Gabbay unsigned int gtt_sa_chunk_size; 17336b5c08fSOded Gabbay unsigned int gtt_sa_num_of_chunks; 17436b5c08fSOded Gabbay 1752249d558SAndrew Lewycky /* Interrupts */ 1762249d558SAndrew Lewycky void *interrupt_ring; 1772249d558SAndrew Lewycky size_t interrupt_ring_size; 1782249d558SAndrew Lewycky atomic_t interrupt_ring_rptr; 1792249d558SAndrew Lewycky atomic_t interrupt_ring_wptr; 1802249d558SAndrew Lewycky struct work_struct interrupt_work; 1812249d558SAndrew Lewycky spinlock_t interrupt_lock; 1822249d558SAndrew Lewycky 183ed6e6a34SBen Goz /* QCM Device instance */ 184ed6e6a34SBen Goz struct device_queue_manager *dqm; 1854a488a7aSOded Gabbay 186ed6e6a34SBen Goz bool init_complete; 1872249d558SAndrew Lewycky /* 1882249d558SAndrew Lewycky * Interrupts of interest to KFD are copied 1892249d558SAndrew Lewycky * from the HW ring into a SW ring. 1902249d558SAndrew Lewycky */ 1912249d558SAndrew Lewycky bool interrupts_active; 1924a488a7aSOded Gabbay }; 1934a488a7aSOded Gabbay 1944a488a7aSOded Gabbay /* KGD2KFD callbacks */ 1954a488a7aSOded Gabbay void kgd2kfd_exit(void); 196cea405b1SXihan Zhang struct kfd_dev *kgd2kfd_probe(struct kgd_dev *kgd, 197cea405b1SXihan Zhang struct pci_dev *pdev, const struct kfd2kgd_calls *f2g); 1984a488a7aSOded Gabbay bool kgd2kfd_device_init(struct kfd_dev *kfd, 1994a488a7aSOded Gabbay const struct kgd2kfd_shared_resources *gpu_resources); 2004a488a7aSOded Gabbay void kgd2kfd_device_exit(struct kfd_dev *kfd); 2014a488a7aSOded Gabbay 20219f6d2a6SOded Gabbay enum kfd_mempool { 20319f6d2a6SOded Gabbay KFD_MEMPOOL_SYSTEM_CACHEABLE = 1, 20419f6d2a6SOded Gabbay KFD_MEMPOOL_SYSTEM_WRITECOMBINE = 2, 20519f6d2a6SOded Gabbay KFD_MEMPOOL_FRAMEBUFFER = 3, 20619f6d2a6SOded Gabbay }; 20719f6d2a6SOded Gabbay 2084a488a7aSOded Gabbay /* Character device interface */ 2094a488a7aSOded Gabbay int kfd_chardev_init(void); 2104a488a7aSOded Gabbay void kfd_chardev_exit(void); 2114a488a7aSOded Gabbay struct device *kfd_chardev(void); 2124a488a7aSOded Gabbay 213241f24f8SBen Goz /** 214241f24f8SBen Goz * enum kfd_preempt_type_filter 215241f24f8SBen Goz * 216241f24f8SBen Goz * @KFD_PREEMPT_TYPE_FILTER_SINGLE_QUEUE: Preempts single queue. 217241f24f8SBen Goz * 218241f24f8SBen Goz * @KFD_PRERMPT_TYPE_FILTER_ALL_QUEUES: Preempts all queues in the 219241f24f8SBen Goz * running queues list. 220241f24f8SBen Goz * 221241f24f8SBen Goz * @KFD_PRERMPT_TYPE_FILTER_BY_PASID: Preempts queues that belongs to 222241f24f8SBen Goz * specific process. 223241f24f8SBen Goz * 224241f24f8SBen Goz */ 225241f24f8SBen Goz enum kfd_preempt_type_filter { 226241f24f8SBen Goz KFD_PREEMPT_TYPE_FILTER_SINGLE_QUEUE, 227241f24f8SBen Goz KFD_PREEMPT_TYPE_FILTER_ALL_QUEUES, 228241f24f8SBen Goz KFD_PREEMPT_TYPE_FILTER_BY_PASID 229241f24f8SBen Goz }; 23019f6d2a6SOded Gabbay 2316e99df57SBen Goz enum kfd_preempt_type { 2326e99df57SBen Goz KFD_PREEMPT_TYPE_WAVEFRONT, 2336e99df57SBen Goz KFD_PREEMPT_TYPE_WAVEFRONT_RESET 2346e99df57SBen Goz }; 2356e99df57SBen Goz 236ed8aab45SBen Goz /** 237ed8aab45SBen Goz * enum kfd_queue_type 238ed8aab45SBen Goz * 239ed8aab45SBen Goz * @KFD_QUEUE_TYPE_COMPUTE: Regular user mode queue type. 240ed8aab45SBen Goz * 241ed8aab45SBen Goz * @KFD_QUEUE_TYPE_SDMA: Sdma user mode queue type. 242ed8aab45SBen Goz * 243ed8aab45SBen Goz * @KFD_QUEUE_TYPE_HIQ: HIQ queue type. 244ed8aab45SBen Goz * 245ed8aab45SBen Goz * @KFD_QUEUE_TYPE_DIQ: DIQ queue type. 246ed8aab45SBen Goz */ 247ed8aab45SBen Goz enum kfd_queue_type { 248ed8aab45SBen Goz KFD_QUEUE_TYPE_COMPUTE, 249ed8aab45SBen Goz KFD_QUEUE_TYPE_SDMA, 250ed8aab45SBen Goz KFD_QUEUE_TYPE_HIQ, 251ed8aab45SBen Goz KFD_QUEUE_TYPE_DIQ 252ed8aab45SBen Goz }; 253ed8aab45SBen Goz 2546e99df57SBen Goz enum kfd_queue_format { 2556e99df57SBen Goz KFD_QUEUE_FORMAT_PM4, 2566e99df57SBen Goz KFD_QUEUE_FORMAT_AQL 2576e99df57SBen Goz }; 2586e99df57SBen Goz 259ed8aab45SBen Goz /** 260ed8aab45SBen Goz * struct queue_properties 261ed8aab45SBen Goz * 262ed8aab45SBen Goz * @type: The queue type. 263ed8aab45SBen Goz * 264ed8aab45SBen Goz * @queue_id: Queue identifier. 265ed8aab45SBen Goz * 266ed8aab45SBen Goz * @queue_address: Queue ring buffer address. 267ed8aab45SBen Goz * 268ed8aab45SBen Goz * @queue_size: Queue ring buffer size. 269ed8aab45SBen Goz * 270ed8aab45SBen Goz * @priority: Defines the queue priority relative to other queues in the 271ed8aab45SBen Goz * process. 272ed8aab45SBen Goz * This is just an indication and HW scheduling may override the priority as 273ed8aab45SBen Goz * necessary while keeping the relative prioritization. 274ed8aab45SBen Goz * the priority granularity is from 0 to f which f is the highest priority. 275ed8aab45SBen Goz * currently all queues are initialized with the highest priority. 276ed8aab45SBen Goz * 277ed8aab45SBen Goz * @queue_percent: This field is partially implemented and currently a zero in 278ed8aab45SBen Goz * this field defines that the queue is non active. 279ed8aab45SBen Goz * 280ed8aab45SBen Goz * @read_ptr: User space address which points to the number of dwords the 281ed8aab45SBen Goz * cp read from the ring buffer. This field updates automatically by the H/W. 282ed8aab45SBen Goz * 283ed8aab45SBen Goz * @write_ptr: Defines the number of dwords written to the ring buffer. 284ed8aab45SBen Goz * 285ed8aab45SBen Goz * @doorbell_ptr: This field aim is to notify the H/W of new packet written to 286ed8aab45SBen Goz * the queue ring buffer. This field should be similar to write_ptr and the user 287ed8aab45SBen Goz * should update this field after he updated the write_ptr. 288ed8aab45SBen Goz * 289ed8aab45SBen Goz * @doorbell_off: The doorbell offset in the doorbell pci-bar. 290ed8aab45SBen Goz * 291ed8aab45SBen Goz * @is_interop: Defines if this is a interop queue. Interop queue means that the 292ed8aab45SBen Goz * queue can access both graphics and compute resources. 293ed8aab45SBen Goz * 294ed8aab45SBen Goz * @is_active: Defines if the queue is active or not. 295ed8aab45SBen Goz * 296ed8aab45SBen Goz * @vmid: If the scheduling mode is no cp scheduling the field defines the vmid 297ed8aab45SBen Goz * of the queue. 298ed8aab45SBen Goz * 299ed8aab45SBen Goz * This structure represents the queue properties for each queue no matter if 300ed8aab45SBen Goz * it's user mode or kernel mode queue. 301ed8aab45SBen Goz * 302ed8aab45SBen Goz */ 303ed8aab45SBen Goz struct queue_properties { 304ed8aab45SBen Goz enum kfd_queue_type type; 3056e99df57SBen Goz enum kfd_queue_format format; 306ed8aab45SBen Goz unsigned int queue_id; 307ed8aab45SBen Goz uint64_t queue_address; 308ed8aab45SBen Goz uint64_t queue_size; 309ed8aab45SBen Goz uint32_t priority; 310ed8aab45SBen Goz uint32_t queue_percent; 311ed8aab45SBen Goz uint32_t *read_ptr; 312ed8aab45SBen Goz uint32_t *write_ptr; 3135cd78de5SOded Gabbay uint32_t __iomem *doorbell_ptr; 314ed8aab45SBen Goz uint32_t doorbell_off; 315ed8aab45SBen Goz bool is_interop; 316ed8aab45SBen Goz bool is_active; 317ed8aab45SBen Goz /* Not relevant for user mode queues in cp scheduling */ 318ed8aab45SBen Goz unsigned int vmid; 31977669eb8SBen Goz /* Relevant only for sdma queues*/ 32077669eb8SBen Goz uint32_t sdma_engine_id; 32177669eb8SBen Goz uint32_t sdma_queue_id; 32277669eb8SBen Goz uint32_t sdma_vm_addr; 323ff3d04a1SBen Goz /* Relevant only for VI */ 324ff3d04a1SBen Goz uint64_t eop_ring_buffer_address; 325ff3d04a1SBen Goz uint32_t eop_ring_buffer_size; 326ff3d04a1SBen Goz uint64_t ctx_save_restore_area_address; 327ff3d04a1SBen Goz uint32_t ctx_save_restore_area_size; 328ed8aab45SBen Goz }; 329ed8aab45SBen Goz 330ed8aab45SBen Goz /** 331ed8aab45SBen Goz * struct queue 332ed8aab45SBen Goz * 333ed8aab45SBen Goz * @list: Queue linked list. 334ed8aab45SBen Goz * 335ed8aab45SBen Goz * @mqd: The queue MQD. 336ed8aab45SBen Goz * 337ed8aab45SBen Goz * @mqd_mem_obj: The MQD local gpu memory object. 338ed8aab45SBen Goz * 339ed8aab45SBen Goz * @gart_mqd_addr: The MQD gart mc address. 340ed8aab45SBen Goz * 341ed8aab45SBen Goz * @properties: The queue properties. 342ed8aab45SBen Goz * 343ed8aab45SBen Goz * @mec: Used only in no cp scheduling mode and identifies to micro engine id 344ed8aab45SBen Goz * that the queue should be execute on. 345ed8aab45SBen Goz * 346ed8aab45SBen Goz * @pipe: Used only in no cp scheduling mode and identifies the queue's pipe id. 347ed8aab45SBen Goz * 348ed8aab45SBen Goz * @queue: Used only in no cp scheduliong mode and identifies the queue's slot. 349ed8aab45SBen Goz * 350ed8aab45SBen Goz * @process: The kfd process that created this queue. 351ed8aab45SBen Goz * 352ed8aab45SBen Goz * @device: The kfd device that created this queue. 353ed8aab45SBen Goz * 354ed8aab45SBen Goz * This structure represents user mode compute queues. 355ed8aab45SBen Goz * It contains all the necessary data to handle such queues. 356ed8aab45SBen Goz * 357ed8aab45SBen Goz */ 358ed8aab45SBen Goz 359ed8aab45SBen Goz struct queue { 360ed8aab45SBen Goz struct list_head list; 361ed8aab45SBen Goz void *mqd; 362ed8aab45SBen Goz struct kfd_mem_obj *mqd_mem_obj; 363ed8aab45SBen Goz uint64_t gart_mqd_addr; 364ed8aab45SBen Goz struct queue_properties properties; 365ed8aab45SBen Goz 366ed8aab45SBen Goz uint32_t mec; 367ed8aab45SBen Goz uint32_t pipe; 368ed8aab45SBen Goz uint32_t queue; 369ed8aab45SBen Goz 37077669eb8SBen Goz unsigned int sdma_id; 37177669eb8SBen Goz 372ed8aab45SBen Goz struct kfd_process *process; 373ed8aab45SBen Goz struct kfd_dev *device; 374ed8aab45SBen Goz }; 375ed8aab45SBen Goz 3766e99df57SBen Goz /* 3776e99df57SBen Goz * Please read the kfd_mqd_manager.h description. 3786e99df57SBen Goz */ 3796e99df57SBen Goz enum KFD_MQD_TYPE { 38085d258f9SBen Goz KFD_MQD_TYPE_COMPUTE = 0, /* for no cp scheduling */ 38185d258f9SBen Goz KFD_MQD_TYPE_HIQ, /* for hiq */ 38285d258f9SBen Goz KFD_MQD_TYPE_CP, /* for cp queues and diq */ 38385d258f9SBen Goz KFD_MQD_TYPE_SDMA, /* for sdma queues */ 3846e99df57SBen Goz KFD_MQD_TYPE_MAX 3856e99df57SBen Goz }; 3866e99df57SBen Goz 387241f24f8SBen Goz struct scheduling_resources { 388241f24f8SBen Goz unsigned int vmid_mask; 389241f24f8SBen Goz enum kfd_queue_type type; 390241f24f8SBen Goz uint64_t queue_mask; 391241f24f8SBen Goz uint64_t gws_mask; 392241f24f8SBen Goz uint32_t oac_mask; 393241f24f8SBen Goz uint32_t gds_heap_base; 394241f24f8SBen Goz uint32_t gds_heap_size; 395241f24f8SBen Goz }; 396241f24f8SBen Goz 397241f24f8SBen Goz struct process_queue_manager { 398241f24f8SBen Goz /* data */ 399241f24f8SBen Goz struct kfd_process *process; 400241f24f8SBen Goz unsigned int num_concurrent_processes; 401241f24f8SBen Goz struct list_head queues; 402241f24f8SBen Goz unsigned long *queue_slot_bitmap; 403241f24f8SBen Goz }; 404241f24f8SBen Goz 405241f24f8SBen Goz struct qcm_process_device { 406241f24f8SBen Goz /* The Device Queue Manager that owns this data */ 407241f24f8SBen Goz struct device_queue_manager *dqm; 408241f24f8SBen Goz struct process_queue_manager *pqm; 409241f24f8SBen Goz /* Queues list */ 410241f24f8SBen Goz struct list_head queues_list; 411241f24f8SBen Goz struct list_head priv_queue_list; 412241f24f8SBen Goz 413241f24f8SBen Goz unsigned int queue_count; 414241f24f8SBen Goz unsigned int vmid; 415241f24f8SBen Goz bool is_debug; 416241f24f8SBen Goz /* 417241f24f8SBen Goz * All the memory management data should be here too 418241f24f8SBen Goz */ 419241f24f8SBen Goz uint64_t gds_context_area; 420241f24f8SBen Goz uint32_t sh_mem_config; 421241f24f8SBen Goz uint32_t sh_mem_bases; 422241f24f8SBen Goz uint32_t sh_mem_ape1_base; 423241f24f8SBen Goz uint32_t sh_mem_ape1_limit; 424241f24f8SBen Goz uint32_t page_table_base; 425241f24f8SBen Goz uint32_t gds_size; 426241f24f8SBen Goz uint32_t num_gws; 427241f24f8SBen Goz uint32_t num_oac; 428241f24f8SBen Goz }; 429241f24f8SBen Goz 43019f6d2a6SOded Gabbay /* Data that is per-process-per device. */ 43119f6d2a6SOded Gabbay struct kfd_process_device { 43219f6d2a6SOded Gabbay /* 43319f6d2a6SOded Gabbay * List of all per-device data for a process. 43419f6d2a6SOded Gabbay * Starts from kfd_process.per_device_data. 43519f6d2a6SOded Gabbay */ 43619f6d2a6SOded Gabbay struct list_head per_device_list; 43719f6d2a6SOded Gabbay 43819f6d2a6SOded Gabbay /* The device that owns this data. */ 43919f6d2a6SOded Gabbay struct kfd_dev *dev; 44019f6d2a6SOded Gabbay 44119f6d2a6SOded Gabbay 44245102048SBen Goz /* per-process-per device QCM data structure */ 44345102048SBen Goz struct qcm_process_device qpd; 44445102048SBen Goz 44519f6d2a6SOded Gabbay /*Apertures*/ 44619f6d2a6SOded Gabbay uint64_t lds_base; 44719f6d2a6SOded Gabbay uint64_t lds_limit; 44819f6d2a6SOded Gabbay uint64_t gpuvm_base; 44919f6d2a6SOded Gabbay uint64_t gpuvm_limit; 45019f6d2a6SOded Gabbay uint64_t scratch_base; 45119f6d2a6SOded Gabbay uint64_t scratch_limit; 45219f6d2a6SOded Gabbay 45319f6d2a6SOded Gabbay /* Is this process/pasid bound to this device? (amd_iommu_bind_pasid) */ 45419f6d2a6SOded Gabbay bool bound; 45519f6d2a6SOded Gabbay }; 45619f6d2a6SOded Gabbay 45752a5fdceSAlexey Skidanov #define qpd_to_pdd(x) container_of(x, struct kfd_process_device, qpd) 45852a5fdceSAlexey Skidanov 4594a488a7aSOded Gabbay /* Process data */ 4604a488a7aSOded Gabbay struct kfd_process { 46119f6d2a6SOded Gabbay /* 46219f6d2a6SOded Gabbay * kfd_process are stored in an mm_struct*->kfd_process* 46319f6d2a6SOded Gabbay * hash table (kfd_processes in kfd_process.c) 46419f6d2a6SOded Gabbay */ 46519f6d2a6SOded Gabbay struct hlist_node kfd_processes; 46619f6d2a6SOded Gabbay 46719f6d2a6SOded Gabbay struct mm_struct *mm; 46819f6d2a6SOded Gabbay 46919f6d2a6SOded Gabbay struct mutex mutex; 47019f6d2a6SOded Gabbay 47119f6d2a6SOded Gabbay /* 47219f6d2a6SOded Gabbay * In any process, the thread that started main() is the lead 47319f6d2a6SOded Gabbay * thread and outlives the rest. 47419f6d2a6SOded Gabbay * It is here because amd_iommu_bind_pasid wants a task_struct. 47519f6d2a6SOded Gabbay */ 47619f6d2a6SOded Gabbay struct task_struct *lead_thread; 47719f6d2a6SOded Gabbay 47819f6d2a6SOded Gabbay /* We want to receive a notification when the mm_struct is destroyed */ 47919f6d2a6SOded Gabbay struct mmu_notifier mmu_notifier; 48019f6d2a6SOded Gabbay 48119f6d2a6SOded Gabbay /* Use for delayed freeing of kfd_process structure */ 48219f6d2a6SOded Gabbay struct rcu_head rcu; 48319f6d2a6SOded Gabbay 48419f6d2a6SOded Gabbay unsigned int pasid; 48519f6d2a6SOded Gabbay 48619f6d2a6SOded Gabbay /* 48719f6d2a6SOded Gabbay * List of kfd_process_device structures, 48819f6d2a6SOded Gabbay * one for each device the process is using. 48919f6d2a6SOded Gabbay */ 49019f6d2a6SOded Gabbay struct list_head per_device_data; 49119f6d2a6SOded Gabbay 49245102048SBen Goz struct process_queue_manager pqm; 49345102048SBen Goz 49419f6d2a6SOded Gabbay /* The process's queues. */ 49519f6d2a6SOded Gabbay size_t queue_array_size; 49619f6d2a6SOded Gabbay 49719f6d2a6SOded Gabbay /* Size is queue_array_size, up to MAX_PROCESS_QUEUES. */ 49819f6d2a6SOded Gabbay struct kfd_queue **queues; 49919f6d2a6SOded Gabbay 50019f6d2a6SOded Gabbay unsigned long allocated_queue_bitmap[DIV_ROUND_UP(KFD_MAX_NUM_OF_QUEUES_PER_PROCESS, BITS_PER_LONG)]; 50119f6d2a6SOded Gabbay 50219f6d2a6SOded Gabbay /*Is the user space process 32 bit?*/ 50319f6d2a6SOded Gabbay bool is_32bit_user_mode; 504f3a39818SAndrew Lewycky 505f3a39818SAndrew Lewycky /* Event-related data */ 506f3a39818SAndrew Lewycky struct mutex event_mutex; 507f3a39818SAndrew Lewycky /* All events in process hashed by ID, linked on kfd_event.events. */ 508f3a39818SAndrew Lewycky DECLARE_HASHTABLE(events, 4); 509f3a39818SAndrew Lewycky struct list_head signal_event_pages; /* struct slot_page_header. 510f3a39818SAndrew Lewycky event_pages */ 511f3a39818SAndrew Lewycky u32 next_nonsignal_event_id; 512f3a39818SAndrew Lewycky size_t signal_event_count; 5134a488a7aSOded Gabbay }; 5144a488a7aSOded Gabbay 51576baee6cSOded Gabbay /** 51676baee6cSOded Gabbay * Ioctl function type. 51776baee6cSOded Gabbay * 51876baee6cSOded Gabbay * \param filep pointer to file structure. 51976baee6cSOded Gabbay * \param p amdkfd process pointer. 52076baee6cSOded Gabbay * \param data pointer to arg that was copied from user. 52176baee6cSOded Gabbay */ 52276baee6cSOded Gabbay typedef int amdkfd_ioctl_t(struct file *filep, struct kfd_process *p, 52376baee6cSOded Gabbay void *data); 52476baee6cSOded Gabbay 52576baee6cSOded Gabbay struct amdkfd_ioctl_desc { 52676baee6cSOded Gabbay unsigned int cmd; 52776baee6cSOded Gabbay int flags; 52876baee6cSOded Gabbay amdkfd_ioctl_t *func; 52976baee6cSOded Gabbay unsigned int cmd_drv; 53076baee6cSOded Gabbay const char *name; 53176baee6cSOded Gabbay }; 53276baee6cSOded Gabbay 53319f6d2a6SOded Gabbay void kfd_process_create_wq(void); 53419f6d2a6SOded Gabbay void kfd_process_destroy_wq(void); 53519f6d2a6SOded Gabbay struct kfd_process *kfd_create_process(const struct task_struct *); 53619f6d2a6SOded Gabbay struct kfd_process *kfd_get_process(const struct task_struct *); 537f3a39818SAndrew Lewycky struct kfd_process *kfd_lookup_process_by_pasid(unsigned int pasid); 53819f6d2a6SOded Gabbay 53964c7f8cfSBen Goz struct kfd_process_device *kfd_bind_process_to_device(struct kfd_dev *dev, 54064c7f8cfSBen Goz struct kfd_process *p); 541b17f068aSOded Gabbay void kfd_unbind_process_from_device(struct kfd_dev *dev, unsigned int pasid); 54219f6d2a6SOded Gabbay struct kfd_process_device *kfd_get_process_device_data(struct kfd_dev *dev, 543093c7d8cSAlexey Skidanov struct kfd_process *p); 544093c7d8cSAlexey Skidanov struct kfd_process_device *kfd_create_process_device_data(struct kfd_dev *dev, 545093c7d8cSAlexey Skidanov struct kfd_process *p); 54619f6d2a6SOded Gabbay 547775921edSAlexey Skidanov /* Process device data iterator */ 548775921edSAlexey Skidanov struct kfd_process_device *kfd_get_first_process_device_data(struct kfd_process *p); 549775921edSAlexey Skidanov struct kfd_process_device *kfd_get_next_process_device_data(struct kfd_process *p, 550775921edSAlexey Skidanov struct kfd_process_device *pdd); 551775921edSAlexey Skidanov bool kfd_has_process_device_data(struct kfd_process *p); 552775921edSAlexey Skidanov 55319f6d2a6SOded Gabbay /* PASIDs */ 55419f6d2a6SOded Gabbay int kfd_pasid_init(void); 55519f6d2a6SOded Gabbay void kfd_pasid_exit(void); 55619f6d2a6SOded Gabbay bool kfd_set_pasid_limit(unsigned int new_limit); 55719f6d2a6SOded Gabbay unsigned int kfd_get_pasid_limit(void); 55819f6d2a6SOded Gabbay unsigned int kfd_pasid_alloc(void); 55919f6d2a6SOded Gabbay void kfd_pasid_free(unsigned int pasid); 56019f6d2a6SOded Gabbay 56119f6d2a6SOded Gabbay /* Doorbells */ 56219f6d2a6SOded Gabbay void kfd_doorbell_init(struct kfd_dev *kfd); 56319f6d2a6SOded Gabbay int kfd_doorbell_mmap(struct kfd_process *process, struct vm_area_struct *vma); 56419f6d2a6SOded Gabbay u32 __iomem *kfd_get_kernel_doorbell(struct kfd_dev *kfd, 56519f6d2a6SOded Gabbay unsigned int *doorbell_off); 56619f6d2a6SOded Gabbay void kfd_release_kernel_doorbell(struct kfd_dev *kfd, u32 __iomem *db_addr); 56719f6d2a6SOded Gabbay u32 read_kernel_doorbell(u32 __iomem *db); 56819f6d2a6SOded Gabbay void write_kernel_doorbell(u32 __iomem *db, u32 value); 56919f6d2a6SOded Gabbay unsigned int kfd_queue_id_to_doorbell(struct kfd_dev *kfd, 57019f6d2a6SOded Gabbay struct kfd_process *process, 57119f6d2a6SOded Gabbay unsigned int queue_id); 57219f6d2a6SOded Gabbay 5736e81090bSOded Gabbay /* GTT Sub-Allocator */ 5746e81090bSOded Gabbay 5756e81090bSOded Gabbay int kfd_gtt_sa_allocate(struct kfd_dev *kfd, unsigned int size, 5766e81090bSOded Gabbay struct kfd_mem_obj **mem_obj); 5776e81090bSOded Gabbay 5786e81090bSOded Gabbay int kfd_gtt_sa_free(struct kfd_dev *kfd, struct kfd_mem_obj *mem_obj); 5796e81090bSOded Gabbay 5804a488a7aSOded Gabbay extern struct device *kfd_device; 5814a488a7aSOded Gabbay 5825b5c4e40SEvgeny Pinchuk /* Topology */ 5835b5c4e40SEvgeny Pinchuk int kfd_topology_init(void); 5845b5c4e40SEvgeny Pinchuk void kfd_topology_shutdown(void); 5855b5c4e40SEvgeny Pinchuk int kfd_topology_add_device(struct kfd_dev *gpu); 5865b5c4e40SEvgeny Pinchuk int kfd_topology_remove_device(struct kfd_dev *gpu); 5875b5c4e40SEvgeny Pinchuk struct kfd_dev *kfd_device_by_id(uint32_t gpu_id); 5885b5c4e40SEvgeny Pinchuk struct kfd_dev *kfd_device_by_pci_dev(const struct pci_dev *pdev); 5895b5c4e40SEvgeny Pinchuk struct kfd_dev *kfd_topology_enum_kfd_devices(uint8_t idx); 5905b5c4e40SEvgeny Pinchuk 5914a488a7aSOded Gabbay /* Interrupts */ 5922249d558SAndrew Lewycky int kfd_interrupt_init(struct kfd_dev *dev); 5932249d558SAndrew Lewycky void kfd_interrupt_exit(struct kfd_dev *dev); 594b3f5e6b4SAndrew Lewycky void kgd2kfd_interrupt(struct kfd_dev *kfd, const void *ih_ring_entry); 5952249d558SAndrew Lewycky bool enqueue_ih_ring_entry(struct kfd_dev *kfd, const void *ih_ring_entry); 5962249d558SAndrew Lewycky bool interrupt_is_wanted(struct kfd_dev *dev, const uint32_t *ih_ring_entry); 5974a488a7aSOded Gabbay 5984a488a7aSOded Gabbay /* Power Management */ 599b3f5e6b4SAndrew Lewycky void kgd2kfd_suspend(struct kfd_dev *kfd); 600b3f5e6b4SAndrew Lewycky int kgd2kfd_resume(struct kfd_dev *kfd); 6014a488a7aSOded Gabbay 60219f6d2a6SOded Gabbay /* amdkfd Apertures */ 60319f6d2a6SOded Gabbay int kfd_init_apertures(struct kfd_process *process); 60419f6d2a6SOded Gabbay 605ed6e6a34SBen Goz /* Queue Context Management */ 606241f24f8SBen Goz inline uint32_t lower_32(uint64_t x); 607241f24f8SBen Goz inline uint32_t upper_32(uint64_t x); 60877669eb8SBen Goz struct cik_sdma_rlc_registers *get_sdma_mqd(void *mqd); 60977669eb8SBen Goz inline uint32_t get_sdma_base_addr(struct cik_sdma_rlc_registers *m); 610241f24f8SBen Goz 611ed6e6a34SBen Goz int init_queue(struct queue **q, struct queue_properties properties); 612ed6e6a34SBen Goz void uninit_queue(struct queue *q); 61345102048SBen Goz void print_queue_properties(struct queue_properties *q); 614ed6e6a34SBen Goz void print_queue(struct queue *q); 615ed6e6a34SBen Goz 61664c7f8cfSBen Goz struct mqd_manager *mqd_manager_init(enum KFD_MQD_TYPE type, 61764c7f8cfSBen Goz struct kfd_dev *dev); 6184b8f589bSBen Goz struct mqd_manager *mqd_manager_init_cik(enum KFD_MQD_TYPE type, 6194b8f589bSBen Goz struct kfd_dev *dev); 6204b8f589bSBen Goz struct mqd_manager *mqd_manager_init_vi(enum KFD_MQD_TYPE type, 6214b8f589bSBen Goz struct kfd_dev *dev); 62264c7f8cfSBen Goz struct device_queue_manager *device_queue_manager_init(struct kfd_dev *dev); 62364c7f8cfSBen Goz void device_queue_manager_uninit(struct device_queue_manager *dqm); 624241f24f8SBen Goz struct kernel_queue *kernel_queue_init(struct kfd_dev *dev, 625241f24f8SBen Goz enum kfd_queue_type type); 626241f24f8SBen Goz void kernel_queue_uninit(struct kernel_queue *kq); 627241f24f8SBen Goz 62845102048SBen Goz /* Process Queue Manager */ 62945102048SBen Goz struct process_queue_node { 63045102048SBen Goz struct queue *q; 63145102048SBen Goz struct kernel_queue *kq; 63245102048SBen Goz struct list_head process_queue_list; 63345102048SBen Goz }; 63445102048SBen Goz 63545102048SBen Goz int pqm_init(struct process_queue_manager *pqm, struct kfd_process *p); 63645102048SBen Goz void pqm_uninit(struct process_queue_manager *pqm); 63745102048SBen Goz int pqm_create_queue(struct process_queue_manager *pqm, 63845102048SBen Goz struct kfd_dev *dev, 63945102048SBen Goz struct file *f, 64045102048SBen Goz struct queue_properties *properties, 64145102048SBen Goz unsigned int flags, 64245102048SBen Goz enum kfd_queue_type type, 64345102048SBen Goz unsigned int *qid); 64445102048SBen Goz int pqm_destroy_queue(struct process_queue_manager *pqm, unsigned int qid); 64545102048SBen Goz int pqm_update_queue(struct process_queue_manager *pqm, unsigned int qid, 64645102048SBen Goz struct queue_properties *p); 64745102048SBen Goz 648ed6e6a34SBen Goz /* Packet Manager */ 649ed6e6a34SBen Goz 650241f24f8SBen Goz #define KFD_HIQ_TIMEOUT (500) 651241f24f8SBen Goz 65264c7f8cfSBen Goz #define KFD_FENCE_COMPLETED (100) 65364c7f8cfSBen Goz #define KFD_FENCE_INIT (10) 654241f24f8SBen Goz #define KFD_UNMAP_LATENCY (150) 655241f24f8SBen Goz 656ed6e6a34SBen Goz struct packet_manager { 657ed6e6a34SBen Goz struct device_queue_manager *dqm; 658ed6e6a34SBen Goz struct kernel_queue *priv_queue; 659ed6e6a34SBen Goz struct mutex lock; 660ed6e6a34SBen Goz bool allocated; 661ed6e6a34SBen Goz struct kfd_mem_obj *ib_buffer_obj; 662ed6e6a34SBen Goz }; 663ed6e6a34SBen Goz 66464c7f8cfSBen Goz int pm_init(struct packet_manager *pm, struct device_queue_manager *dqm); 66564c7f8cfSBen Goz void pm_uninit(struct packet_manager *pm); 66664c7f8cfSBen Goz int pm_send_set_resources(struct packet_manager *pm, 66764c7f8cfSBen Goz struct scheduling_resources *res); 66864c7f8cfSBen Goz int pm_send_runlist(struct packet_manager *pm, struct list_head *dqm_queues); 66964c7f8cfSBen Goz int pm_send_query_status(struct packet_manager *pm, uint64_t fence_address, 67064c7f8cfSBen Goz uint32_t fence_value); 67164c7f8cfSBen Goz 67264c7f8cfSBen Goz int pm_send_unmap_queue(struct packet_manager *pm, enum kfd_queue_type type, 67364c7f8cfSBen Goz enum kfd_preempt_type_filter mode, 67464c7f8cfSBen Goz uint32_t filter_param, bool reset, 67564c7f8cfSBen Goz unsigned int sdma_engine); 67664c7f8cfSBen Goz 677241f24f8SBen Goz void pm_release_ib(struct packet_manager *pm); 678241f24f8SBen Goz 67919f6d2a6SOded Gabbay uint64_t kfd_get_number_elems(struct kfd_dev *kfd); 68019f6d2a6SOded Gabbay phys_addr_t kfd_get_process_doorbells(struct kfd_dev *dev, 68119f6d2a6SOded Gabbay struct kfd_process *process); 68219f6d2a6SOded Gabbay 683f3a39818SAndrew Lewycky /* Events */ 684f3a39818SAndrew Lewycky extern const struct kfd_event_interrupt_class event_interrupt_class_cik; 685930c5ff4SAlexey Skidanov extern const struct kfd_device_global_init_class device_global_init_class_cik; 686f3a39818SAndrew Lewycky 687f3a39818SAndrew Lewycky enum kfd_event_wait_result { 688f3a39818SAndrew Lewycky KFD_WAIT_COMPLETE, 689f3a39818SAndrew Lewycky KFD_WAIT_TIMEOUT, 690f3a39818SAndrew Lewycky KFD_WAIT_ERROR 691f3a39818SAndrew Lewycky }; 692f3a39818SAndrew Lewycky 693f3a39818SAndrew Lewycky void kfd_event_init_process(struct kfd_process *p); 694f3a39818SAndrew Lewycky void kfd_event_free_process(struct kfd_process *p); 695f3a39818SAndrew Lewycky int kfd_event_mmap(struct kfd_process *process, struct vm_area_struct *vma); 696f3a39818SAndrew Lewycky int kfd_wait_on_events(struct kfd_process *p, 69759d3e8beSAlexey Skidanov uint32_t num_events, void __user *data, 698f3a39818SAndrew Lewycky bool all, uint32_t user_timeout_ms, 699f3a39818SAndrew Lewycky enum kfd_event_wait_result *wait_result); 700f3a39818SAndrew Lewycky void kfd_signal_event_interrupt(unsigned int pasid, uint32_t partial_id, 701f3a39818SAndrew Lewycky uint32_t valid_id_bits); 70259d3e8beSAlexey Skidanov void kfd_signal_iommu_event(struct kfd_dev *dev, 70359d3e8beSAlexey Skidanov unsigned int pasid, unsigned long address, 70459d3e8beSAlexey Skidanov bool is_write_requested, bool is_execute_requested); 705930c5ff4SAlexey Skidanov void kfd_signal_hw_exception_event(unsigned int pasid); 706f3a39818SAndrew Lewycky int kfd_set_event(struct kfd_process *p, uint32_t event_id); 707f3a39818SAndrew Lewycky int kfd_reset_event(struct kfd_process *p, uint32_t event_id); 708f3a39818SAndrew Lewycky int kfd_event_create(struct file *devkfd, struct kfd_process *p, 709f3a39818SAndrew Lewycky uint32_t event_type, bool auto_reset, uint32_t node_id, 710f3a39818SAndrew Lewycky uint32_t *event_id, uint32_t *event_trigger_data, 711f3a39818SAndrew Lewycky uint64_t *event_page_offset, uint32_t *event_slot_index); 712f3a39818SAndrew Lewycky int kfd_event_destroy(struct kfd_process *p, uint32_t event_id); 713f3a39818SAndrew Lewycky 7144a488a7aSOded Gabbay #endif 715