xref: /openbmc/linux/drivers/firmware/efi/libstub/gop.c (revision 4febfb8d)
14febfb8dSArd Biesheuvel // SPDX-License-Identifier: GPL-2.0
2fc372064SArd Biesheuvel /* -----------------------------------------------------------------------
3fc372064SArd Biesheuvel  *
4fc372064SArd Biesheuvel  *   Copyright 2011 Intel Corporation; author Matt Fleming
5fc372064SArd Biesheuvel  *
6fc372064SArd Biesheuvel  * ----------------------------------------------------------------------- */
7fc372064SArd Biesheuvel 
8fc372064SArd Biesheuvel #include <linux/efi.h>
9fc372064SArd Biesheuvel #include <linux/screen_info.h>
10fc372064SArd Biesheuvel #include <asm/efi.h>
11fc372064SArd Biesheuvel #include <asm/setup.h>
12fc372064SArd Biesheuvel 
13fc372064SArd Biesheuvel static void find_bits(unsigned long mask, u8 *pos, u8 *size)
14fc372064SArd Biesheuvel {
15fc372064SArd Biesheuvel 	u8 first, len;
16fc372064SArd Biesheuvel 
17fc372064SArd Biesheuvel 	first = 0;
18fc372064SArd Biesheuvel 	len = 0;
19fc372064SArd Biesheuvel 
20fc372064SArd Biesheuvel 	if (mask) {
21fc372064SArd Biesheuvel 		while (!(mask & 0x1)) {
22fc372064SArd Biesheuvel 			mask = mask >> 1;
23fc372064SArd Biesheuvel 			first++;
24fc372064SArd Biesheuvel 		}
25fc372064SArd Biesheuvel 
26fc372064SArd Biesheuvel 		while (mask & 0x1) {
27fc372064SArd Biesheuvel 			mask = mask >> 1;
28fc372064SArd Biesheuvel 			len++;
29fc372064SArd Biesheuvel 		}
30fc372064SArd Biesheuvel 	}
31fc372064SArd Biesheuvel 
32fc372064SArd Biesheuvel 	*pos = first;
33fc372064SArd Biesheuvel 	*size = len;
34fc372064SArd Biesheuvel }
35fc372064SArd Biesheuvel 
36fc372064SArd Biesheuvel static void
37fc372064SArd Biesheuvel setup_pixel_info(struct screen_info *si, u32 pixels_per_scan_line,
38fc372064SArd Biesheuvel 		 struct efi_pixel_bitmask pixel_info, int pixel_format)
39fc372064SArd Biesheuvel {
40fc372064SArd Biesheuvel 	if (pixel_format == PIXEL_RGB_RESERVED_8BIT_PER_COLOR) {
41fc372064SArd Biesheuvel 		si->lfb_depth = 32;
42fc372064SArd Biesheuvel 		si->lfb_linelength = pixels_per_scan_line * 4;
43fc372064SArd Biesheuvel 		si->red_size = 8;
44fc372064SArd Biesheuvel 		si->red_pos = 0;
45fc372064SArd Biesheuvel 		si->green_size = 8;
46fc372064SArd Biesheuvel 		si->green_pos = 8;
47fc372064SArd Biesheuvel 		si->blue_size = 8;
48fc372064SArd Biesheuvel 		si->blue_pos = 16;
49fc372064SArd Biesheuvel 		si->rsvd_size = 8;
50fc372064SArd Biesheuvel 		si->rsvd_pos = 24;
51fc372064SArd Biesheuvel 	} else if (pixel_format == PIXEL_BGR_RESERVED_8BIT_PER_COLOR) {
52fc372064SArd Biesheuvel 		si->lfb_depth = 32;
53fc372064SArd Biesheuvel 		si->lfb_linelength = pixels_per_scan_line * 4;
54fc372064SArd Biesheuvel 		si->red_size = 8;
55fc372064SArd Biesheuvel 		si->red_pos = 16;
56fc372064SArd Biesheuvel 		si->green_size = 8;
57fc372064SArd Biesheuvel 		si->green_pos = 8;
58fc372064SArd Biesheuvel 		si->blue_size = 8;
59fc372064SArd Biesheuvel 		si->blue_pos = 0;
60fc372064SArd Biesheuvel 		si->rsvd_size = 8;
61fc372064SArd Biesheuvel 		si->rsvd_pos = 24;
62fc372064SArd Biesheuvel 	} else if (pixel_format == PIXEL_BIT_MASK) {
63fc372064SArd Biesheuvel 		find_bits(pixel_info.red_mask, &si->red_pos, &si->red_size);
64fc372064SArd Biesheuvel 		find_bits(pixel_info.green_mask, &si->green_pos,
65fc372064SArd Biesheuvel 			  &si->green_size);
66fc372064SArd Biesheuvel 		find_bits(pixel_info.blue_mask, &si->blue_pos, &si->blue_size);
67fc372064SArd Biesheuvel 		find_bits(pixel_info.reserved_mask, &si->rsvd_pos,
68fc372064SArd Biesheuvel 			  &si->rsvd_size);
69fc372064SArd Biesheuvel 		si->lfb_depth = si->red_size + si->green_size +
70fc372064SArd Biesheuvel 			si->blue_size + si->rsvd_size;
71fc372064SArd Biesheuvel 		si->lfb_linelength = (pixels_per_scan_line * si->lfb_depth) / 8;
72fc372064SArd Biesheuvel 	} else {
73fc372064SArd Biesheuvel 		si->lfb_depth = 4;
74fc372064SArd Biesheuvel 		si->lfb_linelength = si->lfb_width / 2;
75fc372064SArd Biesheuvel 		si->red_size = 0;
76fc372064SArd Biesheuvel 		si->red_pos = 0;
77fc372064SArd Biesheuvel 		si->green_size = 0;
78fc372064SArd Biesheuvel 		si->green_pos = 0;
79fc372064SArd Biesheuvel 		si->blue_size = 0;
80fc372064SArd Biesheuvel 		si->blue_pos = 0;
81fc372064SArd Biesheuvel 		si->rsvd_size = 0;
82fc372064SArd Biesheuvel 		si->rsvd_pos = 0;
83fc372064SArd Biesheuvel 	}
84fc372064SArd Biesheuvel }
85fc372064SArd Biesheuvel 
86fc372064SArd Biesheuvel static efi_status_t
87fc372064SArd Biesheuvel __gop_query32(efi_system_table_t *sys_table_arg,
88fc372064SArd Biesheuvel 	      struct efi_graphics_output_protocol_32 *gop32,
89fc372064SArd Biesheuvel 	      struct efi_graphics_output_mode_info **info,
90fc372064SArd Biesheuvel 	      unsigned long *size, u64 *fb_base)
91fc372064SArd Biesheuvel {
92fc372064SArd Biesheuvel 	struct efi_graphics_output_protocol_mode_32 *mode;
93fc372064SArd Biesheuvel 	efi_graphics_output_protocol_query_mode query_mode;
94fc372064SArd Biesheuvel 	efi_status_t status;
95fc372064SArd Biesheuvel 	unsigned long m;
96fc372064SArd Biesheuvel 
97fc372064SArd Biesheuvel 	m = gop32->mode;
98fc372064SArd Biesheuvel 	mode = (struct efi_graphics_output_protocol_mode_32 *)m;
99fc372064SArd Biesheuvel 	query_mode = (void *)(unsigned long)gop32->query_mode;
100fc372064SArd Biesheuvel 
101fc372064SArd Biesheuvel 	status = __efi_call_early(query_mode, (void *)gop32, mode->mode, size,
102fc372064SArd Biesheuvel 				  info);
103fc372064SArd Biesheuvel 	if (status != EFI_SUCCESS)
104fc372064SArd Biesheuvel 		return status;
105fc372064SArd Biesheuvel 
106fc372064SArd Biesheuvel 	*fb_base = mode->frame_buffer_base;
107fc372064SArd Biesheuvel 	return status;
108fc372064SArd Biesheuvel }
109fc372064SArd Biesheuvel 
110fc372064SArd Biesheuvel static efi_status_t
111fc372064SArd Biesheuvel setup_gop32(efi_system_table_t *sys_table_arg, struct screen_info *si,
112fc372064SArd Biesheuvel             efi_guid_t *proto, unsigned long size, void **gop_handle)
113fc372064SArd Biesheuvel {
114fc372064SArd Biesheuvel 	struct efi_graphics_output_protocol_32 *gop32, *first_gop;
115fc372064SArd Biesheuvel 	unsigned long nr_gops;
116fc372064SArd Biesheuvel 	u16 width, height;
117fc372064SArd Biesheuvel 	u32 pixels_per_scan_line;
118fc372064SArd Biesheuvel 	u32 ext_lfb_base;
119fc372064SArd Biesheuvel 	u64 fb_base;
120fc372064SArd Biesheuvel 	struct efi_pixel_bitmask pixel_info;
121fc372064SArd Biesheuvel 	int pixel_format;
122fc372064SArd Biesheuvel 	efi_status_t status = EFI_NOT_FOUND;
123fc372064SArd Biesheuvel 	u32 *handles = (u32 *)(unsigned long)gop_handle;
124fc372064SArd Biesheuvel 	int i;
125fc372064SArd Biesheuvel 
126fc372064SArd Biesheuvel 	first_gop = NULL;
127fc372064SArd Biesheuvel 	gop32 = NULL;
128fc372064SArd Biesheuvel 
129fc372064SArd Biesheuvel 	nr_gops = size / sizeof(u32);
130fc372064SArd Biesheuvel 	for (i = 0; i < nr_gops; i++) {
131fc372064SArd Biesheuvel 		struct efi_graphics_output_mode_info *info = NULL;
132fc372064SArd Biesheuvel 		efi_guid_t conout_proto = EFI_CONSOLE_OUT_DEVICE_GUID;
133fc372064SArd Biesheuvel 		bool conout_found = false;
134fc372064SArd Biesheuvel 		void *dummy = NULL;
135fc372064SArd Biesheuvel 		efi_handle_t h = (efi_handle_t)(unsigned long)handles[i];
136fc372064SArd Biesheuvel 		u64 current_fb_base;
137fc372064SArd Biesheuvel 
138fc372064SArd Biesheuvel 		status = efi_call_early(handle_protocol, h,
139fc372064SArd Biesheuvel 					proto, (void **)&gop32);
140fc372064SArd Biesheuvel 		if (status != EFI_SUCCESS)
141fc372064SArd Biesheuvel 			continue;
142fc372064SArd Biesheuvel 
143fc372064SArd Biesheuvel 		status = efi_call_early(handle_protocol, h,
144fc372064SArd Biesheuvel 					&conout_proto, &dummy);
145fc372064SArd Biesheuvel 		if (status == EFI_SUCCESS)
146fc372064SArd Biesheuvel 			conout_found = true;
147fc372064SArd Biesheuvel 
148fc372064SArd Biesheuvel 		status = __gop_query32(sys_table_arg, gop32, &info, &size,
149fc372064SArd Biesheuvel 				       &current_fb_base);
150540f4c0eSCohen, Eugene 		if (status == EFI_SUCCESS && (!first_gop || conout_found) &&
151540f4c0eSCohen, Eugene 		    info->pixel_format != PIXEL_BLT_ONLY) {
152fc372064SArd Biesheuvel 			/*
153fc372064SArd Biesheuvel 			 * Systems that use the UEFI Console Splitter may
154fc372064SArd Biesheuvel 			 * provide multiple GOP devices, not all of which are
155fc372064SArd Biesheuvel 			 * backed by real hardware. The workaround is to search
156fc372064SArd Biesheuvel 			 * for a GOP implementing the ConOut protocol, and if
157fc372064SArd Biesheuvel 			 * one isn't found, to just fall back to the first GOP.
158fc372064SArd Biesheuvel 			 */
159fc372064SArd Biesheuvel 			width = info->horizontal_resolution;
160fc372064SArd Biesheuvel 			height = info->vertical_resolution;
161fc372064SArd Biesheuvel 			pixel_format = info->pixel_format;
162fc372064SArd Biesheuvel 			pixel_info = info->pixel_information;
163fc372064SArd Biesheuvel 			pixels_per_scan_line = info->pixels_per_scan_line;
164fc372064SArd Biesheuvel 			fb_base = current_fb_base;
165fc372064SArd Biesheuvel 
166fc372064SArd Biesheuvel 			/*
167fc372064SArd Biesheuvel 			 * Once we've found a GOP supporting ConOut,
168fc372064SArd Biesheuvel 			 * don't bother looking any further.
169fc372064SArd Biesheuvel 			 */
170fc372064SArd Biesheuvel 			first_gop = gop32;
171fc372064SArd Biesheuvel 			if (conout_found)
172fc372064SArd Biesheuvel 				break;
173fc372064SArd Biesheuvel 		}
174fc372064SArd Biesheuvel 	}
175fc372064SArd Biesheuvel 
176fc372064SArd Biesheuvel 	/* Did we find any GOPs? */
177fc372064SArd Biesheuvel 	if (!first_gop)
178fc372064SArd Biesheuvel 		goto out;
179fc372064SArd Biesheuvel 
180fc372064SArd Biesheuvel 	/* EFI framebuffer */
181fc372064SArd Biesheuvel 	si->orig_video_isVGA = VIDEO_TYPE_EFI;
182fc372064SArd Biesheuvel 
183fc372064SArd Biesheuvel 	si->lfb_width = width;
184fc372064SArd Biesheuvel 	si->lfb_height = height;
185fc372064SArd Biesheuvel 	si->lfb_base = fb_base;
186fc372064SArd Biesheuvel 
187fc372064SArd Biesheuvel 	ext_lfb_base = (u64)(unsigned long)fb_base >> 32;
188fc372064SArd Biesheuvel 	if (ext_lfb_base) {
189fc372064SArd Biesheuvel 		si->capabilities |= VIDEO_CAPABILITY_64BIT_BASE;
190fc372064SArd Biesheuvel 		si->ext_lfb_base = ext_lfb_base;
191fc372064SArd Biesheuvel 	}
192fc372064SArd Biesheuvel 
193fc372064SArd Biesheuvel 	si->pages = 1;
194fc372064SArd Biesheuvel 
195fc372064SArd Biesheuvel 	setup_pixel_info(si, pixels_per_scan_line, pixel_info, pixel_format);
196fc372064SArd Biesheuvel 
197fc372064SArd Biesheuvel 	si->lfb_size = si->lfb_linelength * si->lfb_height;
198fc372064SArd Biesheuvel 
199fc372064SArd Biesheuvel 	si->capabilities |= VIDEO_CAPABILITY_SKIP_QUIRKS;
200fc372064SArd Biesheuvel out:
201fc372064SArd Biesheuvel 	return status;
202fc372064SArd Biesheuvel }
203fc372064SArd Biesheuvel 
204fc372064SArd Biesheuvel static efi_status_t
205fc372064SArd Biesheuvel __gop_query64(efi_system_table_t *sys_table_arg,
206fc372064SArd Biesheuvel 	      struct efi_graphics_output_protocol_64 *gop64,
207fc372064SArd Biesheuvel 	      struct efi_graphics_output_mode_info **info,
208fc372064SArd Biesheuvel 	      unsigned long *size, u64 *fb_base)
209fc372064SArd Biesheuvel {
210fc372064SArd Biesheuvel 	struct efi_graphics_output_protocol_mode_64 *mode;
211fc372064SArd Biesheuvel 	efi_graphics_output_protocol_query_mode query_mode;
212fc372064SArd Biesheuvel 	efi_status_t status;
213fc372064SArd Biesheuvel 	unsigned long m;
214fc372064SArd Biesheuvel 
215fc372064SArd Biesheuvel 	m = gop64->mode;
216fc372064SArd Biesheuvel 	mode = (struct efi_graphics_output_protocol_mode_64 *)m;
217fc372064SArd Biesheuvel 	query_mode = (void *)(unsigned long)gop64->query_mode;
218fc372064SArd Biesheuvel 
219fc372064SArd Biesheuvel 	status = __efi_call_early(query_mode, (void *)gop64, mode->mode, size,
220fc372064SArd Biesheuvel 				  info);
221fc372064SArd Biesheuvel 	if (status != EFI_SUCCESS)
222fc372064SArd Biesheuvel 		return status;
223fc372064SArd Biesheuvel 
224fc372064SArd Biesheuvel 	*fb_base = mode->frame_buffer_base;
225fc372064SArd Biesheuvel 	return status;
226fc372064SArd Biesheuvel }
227fc372064SArd Biesheuvel 
228fc372064SArd Biesheuvel static efi_status_t
229fc372064SArd Biesheuvel setup_gop64(efi_system_table_t *sys_table_arg, struct screen_info *si,
230fc372064SArd Biesheuvel 	    efi_guid_t *proto, unsigned long size, void **gop_handle)
231fc372064SArd Biesheuvel {
232fc372064SArd Biesheuvel 	struct efi_graphics_output_protocol_64 *gop64, *first_gop;
233fc372064SArd Biesheuvel 	unsigned long nr_gops;
234fc372064SArd Biesheuvel 	u16 width, height;
235fc372064SArd Biesheuvel 	u32 pixels_per_scan_line;
236fc372064SArd Biesheuvel 	u32 ext_lfb_base;
237fc372064SArd Biesheuvel 	u64 fb_base;
238fc372064SArd Biesheuvel 	struct efi_pixel_bitmask pixel_info;
239fc372064SArd Biesheuvel 	int pixel_format;
240fc372064SArd Biesheuvel 	efi_status_t status = EFI_NOT_FOUND;
241fc372064SArd Biesheuvel 	u64 *handles = (u64 *)(unsigned long)gop_handle;
242fc372064SArd Biesheuvel 	int i;
243fc372064SArd Biesheuvel 
244fc372064SArd Biesheuvel 	first_gop = NULL;
245fc372064SArd Biesheuvel 	gop64 = NULL;
246fc372064SArd Biesheuvel 
247fc372064SArd Biesheuvel 	nr_gops = size / sizeof(u64);
248fc372064SArd Biesheuvel 	for (i = 0; i < nr_gops; i++) {
249fc372064SArd Biesheuvel 		struct efi_graphics_output_mode_info *info = NULL;
250fc372064SArd Biesheuvel 		efi_guid_t conout_proto = EFI_CONSOLE_OUT_DEVICE_GUID;
251fc372064SArd Biesheuvel 		bool conout_found = false;
252fc372064SArd Biesheuvel 		void *dummy = NULL;
253fc372064SArd Biesheuvel 		efi_handle_t h = (efi_handle_t)(unsigned long)handles[i];
254fc372064SArd Biesheuvel 		u64 current_fb_base;
255fc372064SArd Biesheuvel 
256fc372064SArd Biesheuvel 		status = efi_call_early(handle_protocol, h,
257fc372064SArd Biesheuvel 					proto, (void **)&gop64);
258fc372064SArd Biesheuvel 		if (status != EFI_SUCCESS)
259fc372064SArd Biesheuvel 			continue;
260fc372064SArd Biesheuvel 
261fc372064SArd Biesheuvel 		status = efi_call_early(handle_protocol, h,
262fc372064SArd Biesheuvel 					&conout_proto, &dummy);
263fc372064SArd Biesheuvel 		if (status == EFI_SUCCESS)
264fc372064SArd Biesheuvel 			conout_found = true;
265fc372064SArd Biesheuvel 
266fc372064SArd Biesheuvel 		status = __gop_query64(sys_table_arg, gop64, &info, &size,
267fc372064SArd Biesheuvel 				       &current_fb_base);
268540f4c0eSCohen, Eugene 		if (status == EFI_SUCCESS && (!first_gop || conout_found) &&
269540f4c0eSCohen, Eugene 		    info->pixel_format != PIXEL_BLT_ONLY) {
270fc372064SArd Biesheuvel 			/*
271fc372064SArd Biesheuvel 			 * Systems that use the UEFI Console Splitter may
272fc372064SArd Biesheuvel 			 * provide multiple GOP devices, not all of which are
273fc372064SArd Biesheuvel 			 * backed by real hardware. The workaround is to search
274fc372064SArd Biesheuvel 			 * for a GOP implementing the ConOut protocol, and if
275fc372064SArd Biesheuvel 			 * one isn't found, to just fall back to the first GOP.
276fc372064SArd Biesheuvel 			 */
277fc372064SArd Biesheuvel 			width = info->horizontal_resolution;
278fc372064SArd Biesheuvel 			height = info->vertical_resolution;
279fc372064SArd Biesheuvel 			pixel_format = info->pixel_format;
280fc372064SArd Biesheuvel 			pixel_info = info->pixel_information;
281fc372064SArd Biesheuvel 			pixels_per_scan_line = info->pixels_per_scan_line;
282fc372064SArd Biesheuvel 			fb_base = current_fb_base;
283fc372064SArd Biesheuvel 
284fc372064SArd Biesheuvel 			/*
285fc372064SArd Biesheuvel 			 * Once we've found a GOP supporting ConOut,
286fc372064SArd Biesheuvel 			 * don't bother looking any further.
287fc372064SArd Biesheuvel 			 */
288fc372064SArd Biesheuvel 			first_gop = gop64;
289fc372064SArd Biesheuvel 			if (conout_found)
290fc372064SArd Biesheuvel 				break;
291fc372064SArd Biesheuvel 		}
292fc372064SArd Biesheuvel 	}
293fc372064SArd Biesheuvel 
294fc372064SArd Biesheuvel 	/* Did we find any GOPs? */
295fc372064SArd Biesheuvel 	if (!first_gop)
296fc372064SArd Biesheuvel 		goto out;
297fc372064SArd Biesheuvel 
298fc372064SArd Biesheuvel 	/* EFI framebuffer */
299fc372064SArd Biesheuvel 	si->orig_video_isVGA = VIDEO_TYPE_EFI;
300fc372064SArd Biesheuvel 
301fc372064SArd Biesheuvel 	si->lfb_width = width;
302fc372064SArd Biesheuvel 	si->lfb_height = height;
303fc372064SArd Biesheuvel 	si->lfb_base = fb_base;
304fc372064SArd Biesheuvel 
305fc372064SArd Biesheuvel 	ext_lfb_base = (u64)(unsigned long)fb_base >> 32;
306fc372064SArd Biesheuvel 	if (ext_lfb_base) {
307fc372064SArd Biesheuvel 		si->capabilities |= VIDEO_CAPABILITY_64BIT_BASE;
308fc372064SArd Biesheuvel 		si->ext_lfb_base = ext_lfb_base;
309fc372064SArd Biesheuvel 	}
310fc372064SArd Biesheuvel 
311fc372064SArd Biesheuvel 	si->pages = 1;
312fc372064SArd Biesheuvel 
313fc372064SArd Biesheuvel 	setup_pixel_info(si, pixels_per_scan_line, pixel_info, pixel_format);
314fc372064SArd Biesheuvel 
315fc372064SArd Biesheuvel 	si->lfb_size = si->lfb_linelength * si->lfb_height;
316fc372064SArd Biesheuvel 
317fc372064SArd Biesheuvel 	si->capabilities |= VIDEO_CAPABILITY_SKIP_QUIRKS;
318fc372064SArd Biesheuvel out:
319fc372064SArd Biesheuvel 	return status;
320fc372064SArd Biesheuvel }
321fc372064SArd Biesheuvel 
322fc372064SArd Biesheuvel /*
323fc372064SArd Biesheuvel  * See if we have Graphics Output Protocol
324fc372064SArd Biesheuvel  */
325fc372064SArd Biesheuvel efi_status_t efi_setup_gop(efi_system_table_t *sys_table_arg,
326fc372064SArd Biesheuvel 			   struct screen_info *si, efi_guid_t *proto,
327fc372064SArd Biesheuvel 			   unsigned long size)
328fc372064SArd Biesheuvel {
329fc372064SArd Biesheuvel 	efi_status_t status;
330fc372064SArd Biesheuvel 	void **gop_handle = NULL;
331fc372064SArd Biesheuvel 
332fc372064SArd Biesheuvel 	status = efi_call_early(allocate_pool, EFI_LOADER_DATA,
333fc372064SArd Biesheuvel 				size, (void **)&gop_handle);
334fc372064SArd Biesheuvel 	if (status != EFI_SUCCESS)
335fc372064SArd Biesheuvel 		return status;
336fc372064SArd Biesheuvel 
337fc372064SArd Biesheuvel 	status = efi_call_early(locate_handle,
338fc372064SArd Biesheuvel 				EFI_LOCATE_BY_PROTOCOL,
339fc372064SArd Biesheuvel 				proto, NULL, &size, gop_handle);
340fc372064SArd Biesheuvel 	if (status != EFI_SUCCESS)
341fc372064SArd Biesheuvel 		goto free_handle;
342fc372064SArd Biesheuvel 
343fc372064SArd Biesheuvel 	if (efi_is_64bit()) {
344fc372064SArd Biesheuvel 		status = setup_gop64(sys_table_arg, si, proto, size,
345fc372064SArd Biesheuvel 				     gop_handle);
346fc372064SArd Biesheuvel 	} else {
347fc372064SArd Biesheuvel 		status = setup_gop32(sys_table_arg, si, proto, size,
348fc372064SArd Biesheuvel 				     gop_handle);
349fc372064SArd Biesheuvel 	}
350fc372064SArd Biesheuvel 
351fc372064SArd Biesheuvel free_handle:
352fc372064SArd Biesheuvel 	efi_call_early(free_pool, gop_handle);
353fc372064SArd Biesheuvel 	return status;
354fc372064SArd Biesheuvel }
355