xref: /openbmc/linux/drivers/base/dd.c (revision 3b27d139)
1 /*
2  * drivers/base/dd.c - The core device/driver interactions.
3  *
4  * This file contains the (sometimes tricky) code that controls the
5  * interactions between devices and drivers, which primarily includes
6  * driver binding and unbinding.
7  *
8  * All of this code used to exist in drivers/base/bus.c, but was
9  * relocated to here in the name of compartmentalization (since it wasn't
10  * strictly code just for the 'struct bus_type'.
11  *
12  * Copyright (c) 2002-5 Patrick Mochel
13  * Copyright (c) 2002-3 Open Source Development Labs
14  * Copyright (c) 2007-2009 Greg Kroah-Hartman <gregkh@suse.de>
15  * Copyright (c) 2007-2009 Novell Inc.
16  *
17  * This file is released under the GPLv2
18  */
19 
20 #include <linux/device.h>
21 #include <linux/delay.h>
22 #include <linux/module.h>
23 #include <linux/kthread.h>
24 #include <linux/wait.h>
25 #include <linux/async.h>
26 #include <linux/pm_runtime.h>
27 #include <linux/pinctrl/devinfo.h>
28 
29 #include "base.h"
30 #include "power/power.h"
31 
32 /*
33  * Deferred Probe infrastructure.
34  *
35  * Sometimes driver probe order matters, but the kernel doesn't always have
36  * dependency information which means some drivers will get probed before a
37  * resource it depends on is available.  For example, an SDHCI driver may
38  * first need a GPIO line from an i2c GPIO controller before it can be
39  * initialized.  If a required resource is not available yet, a driver can
40  * request probing to be deferred by returning -EPROBE_DEFER from its probe hook
41  *
42  * Deferred probe maintains two lists of devices, a pending list and an active
43  * list.  A driver returning -EPROBE_DEFER causes the device to be added to the
44  * pending list.  A successful driver probe will trigger moving all devices
45  * from the pending to the active list so that the workqueue will eventually
46  * retry them.
47  *
48  * The deferred_probe_mutex must be held any time the deferred_probe_*_list
49  * of the (struct device*)->p->deferred_probe pointers are manipulated
50  */
51 static DEFINE_MUTEX(deferred_probe_mutex);
52 static LIST_HEAD(deferred_probe_pending_list);
53 static LIST_HEAD(deferred_probe_active_list);
54 static struct workqueue_struct *deferred_wq;
55 static atomic_t deferred_trigger_count = ATOMIC_INIT(0);
56 
57 /*
58  * deferred_probe_work_func() - Retry probing devices in the active list.
59  */
60 static void deferred_probe_work_func(struct work_struct *work)
61 {
62 	struct device *dev;
63 	struct device_private *private;
64 	/*
65 	 * This block processes every device in the deferred 'active' list.
66 	 * Each device is removed from the active list and passed to
67 	 * bus_probe_device() to re-attempt the probe.  The loop continues
68 	 * until every device in the active list is removed and retried.
69 	 *
70 	 * Note: Once the device is removed from the list and the mutex is
71 	 * released, it is possible for the device get freed by another thread
72 	 * and cause a illegal pointer dereference.  This code uses
73 	 * get/put_device() to ensure the device structure cannot disappear
74 	 * from under our feet.
75 	 */
76 	mutex_lock(&deferred_probe_mutex);
77 	while (!list_empty(&deferred_probe_active_list)) {
78 		private = list_first_entry(&deferred_probe_active_list,
79 					typeof(*dev->p), deferred_probe);
80 		dev = private->device;
81 		list_del_init(&private->deferred_probe);
82 
83 		get_device(dev);
84 
85 		/*
86 		 * Drop the mutex while probing each device; the probe path may
87 		 * manipulate the deferred list
88 		 */
89 		mutex_unlock(&deferred_probe_mutex);
90 
91 		/*
92 		 * Force the device to the end of the dpm_list since
93 		 * the PM code assumes that the order we add things to
94 		 * the list is a good order for suspend but deferred
95 		 * probe makes that very unsafe.
96 		 */
97 		device_pm_lock();
98 		device_pm_move_last(dev);
99 		device_pm_unlock();
100 
101 		dev_dbg(dev, "Retrying from deferred list\n");
102 		bus_probe_device(dev);
103 
104 		mutex_lock(&deferred_probe_mutex);
105 
106 		put_device(dev);
107 	}
108 	mutex_unlock(&deferred_probe_mutex);
109 }
110 static DECLARE_WORK(deferred_probe_work, deferred_probe_work_func);
111 
112 static void driver_deferred_probe_add(struct device *dev)
113 {
114 	mutex_lock(&deferred_probe_mutex);
115 	if (list_empty(&dev->p->deferred_probe)) {
116 		dev_dbg(dev, "Added to deferred list\n");
117 		list_add_tail(&dev->p->deferred_probe, &deferred_probe_pending_list);
118 	}
119 	mutex_unlock(&deferred_probe_mutex);
120 }
121 
122 void driver_deferred_probe_del(struct device *dev)
123 {
124 	mutex_lock(&deferred_probe_mutex);
125 	if (!list_empty(&dev->p->deferred_probe)) {
126 		dev_dbg(dev, "Removed from deferred list\n");
127 		list_del_init(&dev->p->deferred_probe);
128 	}
129 	mutex_unlock(&deferred_probe_mutex);
130 }
131 
132 static bool driver_deferred_probe_enable = false;
133 /**
134  * driver_deferred_probe_trigger() - Kick off re-probing deferred devices
135  *
136  * This functions moves all devices from the pending list to the active
137  * list and schedules the deferred probe workqueue to process them.  It
138  * should be called anytime a driver is successfully bound to a device.
139  *
140  * Note, there is a race condition in multi-threaded probe. In the case where
141  * more than one device is probing at the same time, it is possible for one
142  * probe to complete successfully while another is about to defer. If the second
143  * depends on the first, then it will get put on the pending list after the
144  * trigger event has already occurred and will be stuck there.
145  *
146  * The atomic 'deferred_trigger_count' is used to determine if a successful
147  * trigger has occurred in the midst of probing a driver. If the trigger count
148  * changes in the midst of a probe, then deferred processing should be triggered
149  * again.
150  */
151 static void driver_deferred_probe_trigger(void)
152 {
153 	if (!driver_deferred_probe_enable)
154 		return;
155 
156 	/*
157 	 * A successful probe means that all the devices in the pending list
158 	 * should be triggered to be reprobed.  Move all the deferred devices
159 	 * into the active list so they can be retried by the workqueue
160 	 */
161 	mutex_lock(&deferred_probe_mutex);
162 	atomic_inc(&deferred_trigger_count);
163 	list_splice_tail_init(&deferred_probe_pending_list,
164 			      &deferred_probe_active_list);
165 	mutex_unlock(&deferred_probe_mutex);
166 
167 	/*
168 	 * Kick the re-probe thread.  It may already be scheduled, but it is
169 	 * safe to kick it again.
170 	 */
171 	queue_work(deferred_wq, &deferred_probe_work);
172 }
173 
174 /**
175  * deferred_probe_initcall() - Enable probing of deferred devices
176  *
177  * We don't want to get in the way when the bulk of drivers are getting probed.
178  * Instead, this initcall makes sure that deferred probing is delayed until
179  * late_initcall time.
180  */
181 static int deferred_probe_initcall(void)
182 {
183 	deferred_wq = create_singlethread_workqueue("deferwq");
184 	if (WARN_ON(!deferred_wq))
185 		return -ENOMEM;
186 
187 	driver_deferred_probe_enable = true;
188 	driver_deferred_probe_trigger();
189 	/* Sort as many dependencies as possible before exiting initcalls */
190 	flush_workqueue(deferred_wq);
191 	return 0;
192 }
193 late_initcall(deferred_probe_initcall);
194 
195 static void driver_bound(struct device *dev)
196 {
197 	if (klist_node_attached(&dev->p->knode_driver)) {
198 		printk(KERN_WARNING "%s: device %s already bound\n",
199 			__func__, kobject_name(&dev->kobj));
200 		return;
201 	}
202 
203 	pr_debug("driver: '%s': %s: bound to device '%s'\n", dev->driver->name,
204 		 __func__, dev_name(dev));
205 
206 	klist_add_tail(&dev->p->knode_driver, &dev->driver->p->klist_devices);
207 
208 	/*
209 	 * Make sure the device is no longer in one of the deferred lists and
210 	 * kick off retrying all pending devices
211 	 */
212 	driver_deferred_probe_del(dev);
213 	driver_deferred_probe_trigger();
214 
215 	if (dev->bus)
216 		blocking_notifier_call_chain(&dev->bus->p->bus_notifier,
217 					     BUS_NOTIFY_BOUND_DRIVER, dev);
218 }
219 
220 static int driver_sysfs_add(struct device *dev)
221 {
222 	int ret;
223 
224 	if (dev->bus)
225 		blocking_notifier_call_chain(&dev->bus->p->bus_notifier,
226 					     BUS_NOTIFY_BIND_DRIVER, dev);
227 
228 	ret = sysfs_create_link(&dev->driver->p->kobj, &dev->kobj,
229 			  kobject_name(&dev->kobj));
230 	if (ret == 0) {
231 		ret = sysfs_create_link(&dev->kobj, &dev->driver->p->kobj,
232 					"driver");
233 		if (ret)
234 			sysfs_remove_link(&dev->driver->p->kobj,
235 					kobject_name(&dev->kobj));
236 	}
237 	return ret;
238 }
239 
240 static void driver_sysfs_remove(struct device *dev)
241 {
242 	struct device_driver *drv = dev->driver;
243 
244 	if (drv) {
245 		sysfs_remove_link(&drv->p->kobj, kobject_name(&dev->kobj));
246 		sysfs_remove_link(&dev->kobj, "driver");
247 	}
248 }
249 
250 /**
251  * device_bind_driver - bind a driver to one device.
252  * @dev: device.
253  *
254  * Allow manual attachment of a driver to a device.
255  * Caller must have already set @dev->driver.
256  *
257  * Note that this does not modify the bus reference count
258  * nor take the bus's rwsem. Please verify those are accounted
259  * for before calling this. (It is ok to call with no other effort
260  * from a driver's probe() method.)
261  *
262  * This function must be called with the device lock held.
263  */
264 int device_bind_driver(struct device *dev)
265 {
266 	int ret;
267 
268 	ret = driver_sysfs_add(dev);
269 	if (!ret)
270 		driver_bound(dev);
271 	return ret;
272 }
273 EXPORT_SYMBOL_GPL(device_bind_driver);
274 
275 static atomic_t probe_count = ATOMIC_INIT(0);
276 static DECLARE_WAIT_QUEUE_HEAD(probe_waitqueue);
277 
278 static int really_probe(struct device *dev, struct device_driver *drv)
279 {
280 	int ret = 0;
281 	int local_trigger_count = atomic_read(&deferred_trigger_count);
282 
283 	atomic_inc(&probe_count);
284 	pr_debug("bus: '%s': %s: probing driver %s with device %s\n",
285 		 drv->bus->name, __func__, drv->name, dev_name(dev));
286 	WARN_ON(!list_empty(&dev->devres_head));
287 
288 	dev->driver = drv;
289 
290 	/* If using pinctrl, bind pins now before probing */
291 	ret = pinctrl_bind_pins(dev);
292 	if (ret)
293 		goto probe_failed;
294 
295 	if (driver_sysfs_add(dev)) {
296 		printk(KERN_ERR "%s: driver_sysfs_add(%s) failed\n",
297 			__func__, dev_name(dev));
298 		goto probe_failed;
299 	}
300 
301 	if (dev->pm_domain && dev->pm_domain->activate) {
302 		ret = dev->pm_domain->activate(dev);
303 		if (ret)
304 			goto probe_failed;
305 	}
306 
307 	/*
308 	 * Ensure devices are listed in devices_kset in correct order
309 	 * It's important to move Dev to the end of devices_kset before
310 	 * calling .probe, because it could be recursive and parent Dev
311 	 * should always go first
312 	 */
313 	devices_kset_move_last(dev);
314 
315 	if (dev->bus->probe) {
316 		ret = dev->bus->probe(dev);
317 		if (ret)
318 			goto probe_failed;
319 	} else if (drv->probe) {
320 		ret = drv->probe(dev);
321 		if (ret)
322 			goto probe_failed;
323 	}
324 
325 	if (dev->pm_domain && dev->pm_domain->sync)
326 		dev->pm_domain->sync(dev);
327 
328 	driver_bound(dev);
329 	ret = 1;
330 	pr_debug("bus: '%s': %s: bound device %s to driver %s\n",
331 		 drv->bus->name, __func__, dev_name(dev), drv->name);
332 	goto done;
333 
334 probe_failed:
335 	devres_release_all(dev);
336 	driver_sysfs_remove(dev);
337 	dev->driver = NULL;
338 	dev_set_drvdata(dev, NULL);
339 	if (dev->pm_domain && dev->pm_domain->dismiss)
340 		dev->pm_domain->dismiss(dev);
341 
342 	switch (ret) {
343 	case -EPROBE_DEFER:
344 		/* Driver requested deferred probing */
345 		dev_dbg(dev, "Driver %s requests probe deferral\n", drv->name);
346 		driver_deferred_probe_add(dev);
347 		/* Did a trigger occur while probing? Need to re-trigger if yes */
348 		if (local_trigger_count != atomic_read(&deferred_trigger_count))
349 			driver_deferred_probe_trigger();
350 		break;
351 	case -ENODEV:
352 	case -ENXIO:
353 		pr_debug("%s: probe of %s rejects match %d\n",
354 			 drv->name, dev_name(dev), ret);
355 		break;
356 	default:
357 		/* driver matched but the probe failed */
358 		printk(KERN_WARNING
359 		       "%s: probe of %s failed with error %d\n",
360 		       drv->name, dev_name(dev), ret);
361 	}
362 	/*
363 	 * Ignore errors returned by ->probe so that the next driver can try
364 	 * its luck.
365 	 */
366 	ret = 0;
367 done:
368 	atomic_dec(&probe_count);
369 	wake_up(&probe_waitqueue);
370 	return ret;
371 }
372 
373 /**
374  * driver_probe_done
375  * Determine if the probe sequence is finished or not.
376  *
377  * Should somehow figure out how to use a semaphore, not an atomic variable...
378  */
379 int driver_probe_done(void)
380 {
381 	pr_debug("%s: probe_count = %d\n", __func__,
382 		 atomic_read(&probe_count));
383 	if (atomic_read(&probe_count))
384 		return -EBUSY;
385 	return 0;
386 }
387 
388 /**
389  * wait_for_device_probe
390  * Wait for device probing to be completed.
391  */
392 void wait_for_device_probe(void)
393 {
394 	/* wait for the known devices to complete their probing */
395 	wait_event(probe_waitqueue, atomic_read(&probe_count) == 0);
396 	async_synchronize_full();
397 }
398 EXPORT_SYMBOL_GPL(wait_for_device_probe);
399 
400 /**
401  * driver_probe_device - attempt to bind device & driver together
402  * @drv: driver to bind a device to
403  * @dev: device to try to bind to the driver
404  *
405  * This function returns -ENODEV if the device is not registered,
406  * 1 if the device is bound successfully and 0 otherwise.
407  *
408  * This function must be called with @dev lock held.  When called for a
409  * USB interface, @dev->parent lock must be held as well.
410  */
411 int driver_probe_device(struct device_driver *drv, struct device *dev)
412 {
413 	int ret = 0;
414 
415 	if (!device_is_registered(dev))
416 		return -ENODEV;
417 
418 	pr_debug("bus: '%s': %s: matched device %s with driver %s\n",
419 		 drv->bus->name, __func__, dev_name(dev), drv->name);
420 
421 	pm_runtime_barrier(dev);
422 	ret = really_probe(dev, drv);
423 	pm_request_idle(dev);
424 
425 	return ret;
426 }
427 
428 bool driver_allows_async_probing(struct device_driver *drv)
429 {
430 	switch (drv->probe_type) {
431 	case PROBE_PREFER_ASYNCHRONOUS:
432 		return true;
433 
434 	case PROBE_FORCE_SYNCHRONOUS:
435 		return false;
436 
437 	default:
438 		if (module_requested_async_probing(drv->owner))
439 			return true;
440 
441 		return false;
442 	}
443 }
444 
445 struct device_attach_data {
446 	struct device *dev;
447 
448 	/*
449 	 * Indicates whether we are are considering asynchronous probing or
450 	 * not. Only initial binding after device or driver registration
451 	 * (including deferral processing) may be done asynchronously, the
452 	 * rest is always synchronous, as we expect it is being done by
453 	 * request from userspace.
454 	 */
455 	bool check_async;
456 
457 	/*
458 	 * Indicates if we are binding synchronous or asynchronous drivers.
459 	 * When asynchronous probing is enabled we'll execute 2 passes
460 	 * over drivers: first pass doing synchronous probing and second
461 	 * doing asynchronous probing (if synchronous did not succeed -
462 	 * most likely because there was no driver requiring synchronous
463 	 * probing - and we found asynchronous driver during first pass).
464 	 * The 2 passes are done because we can't shoot asynchronous
465 	 * probe for given device and driver from bus_for_each_drv() since
466 	 * driver pointer is not guaranteed to stay valid once
467 	 * bus_for_each_drv() iterates to the next driver on the bus.
468 	 */
469 	bool want_async;
470 
471 	/*
472 	 * We'll set have_async to 'true' if, while scanning for matching
473 	 * driver, we'll encounter one that requests asynchronous probing.
474 	 */
475 	bool have_async;
476 };
477 
478 static int __device_attach_driver(struct device_driver *drv, void *_data)
479 {
480 	struct device_attach_data *data = _data;
481 	struct device *dev = data->dev;
482 	bool async_allowed;
483 
484 	/*
485 	 * Check if device has already been claimed. This may
486 	 * happen with driver loading, device discovery/registration,
487 	 * and deferred probe processing happens all at once with
488 	 * multiple threads.
489 	 */
490 	if (dev->driver)
491 		return -EBUSY;
492 
493 	if (!driver_match_device(drv, dev))
494 		return 0;
495 
496 	async_allowed = driver_allows_async_probing(drv);
497 
498 	if (async_allowed)
499 		data->have_async = true;
500 
501 	if (data->check_async && async_allowed != data->want_async)
502 		return 0;
503 
504 	return driver_probe_device(drv, dev);
505 }
506 
507 static void __device_attach_async_helper(void *_dev, async_cookie_t cookie)
508 {
509 	struct device *dev = _dev;
510 	struct device_attach_data data = {
511 		.dev		= dev,
512 		.check_async	= true,
513 		.want_async	= true,
514 	};
515 
516 	device_lock(dev);
517 
518 	bus_for_each_drv(dev->bus, NULL, &data, __device_attach_driver);
519 	dev_dbg(dev, "async probe completed\n");
520 
521 	pm_request_idle(dev);
522 
523 	device_unlock(dev);
524 
525 	put_device(dev);
526 }
527 
528 static int __device_attach(struct device *dev, bool allow_async)
529 {
530 	int ret = 0;
531 
532 	device_lock(dev);
533 	if (dev->driver) {
534 		if (klist_node_attached(&dev->p->knode_driver)) {
535 			ret = 1;
536 			goto out_unlock;
537 		}
538 		ret = device_bind_driver(dev);
539 		if (ret == 0)
540 			ret = 1;
541 		else {
542 			dev->driver = NULL;
543 			ret = 0;
544 		}
545 	} else {
546 		struct device_attach_data data = {
547 			.dev = dev,
548 			.check_async = allow_async,
549 			.want_async = false,
550 		};
551 
552 		ret = bus_for_each_drv(dev->bus, NULL, &data,
553 					__device_attach_driver);
554 		if (!ret && allow_async && data.have_async) {
555 			/*
556 			 * If we could not find appropriate driver
557 			 * synchronously and we are allowed to do
558 			 * async probes and there are drivers that
559 			 * want to probe asynchronously, we'll
560 			 * try them.
561 			 */
562 			dev_dbg(dev, "scheduling asynchronous probe\n");
563 			get_device(dev);
564 			async_schedule(__device_attach_async_helper, dev);
565 		} else {
566 			pm_request_idle(dev);
567 		}
568 	}
569 out_unlock:
570 	device_unlock(dev);
571 	return ret;
572 }
573 
574 /**
575  * device_attach - try to attach device to a driver.
576  * @dev: device.
577  *
578  * Walk the list of drivers that the bus has and call
579  * driver_probe_device() for each pair. If a compatible
580  * pair is found, break out and return.
581  *
582  * Returns 1 if the device was bound to a driver;
583  * 0 if no matching driver was found;
584  * -ENODEV if the device is not registered.
585  *
586  * When called for a USB interface, @dev->parent lock must be held.
587  */
588 int device_attach(struct device *dev)
589 {
590 	return __device_attach(dev, false);
591 }
592 EXPORT_SYMBOL_GPL(device_attach);
593 
594 void device_initial_probe(struct device *dev)
595 {
596 	__device_attach(dev, true);
597 }
598 
599 static int __driver_attach(struct device *dev, void *data)
600 {
601 	struct device_driver *drv = data;
602 
603 	/*
604 	 * Lock device and try to bind to it. We drop the error
605 	 * here and always return 0, because we need to keep trying
606 	 * to bind to devices and some drivers will return an error
607 	 * simply if it didn't support the device.
608 	 *
609 	 * driver_probe_device() will spit a warning if there
610 	 * is an error.
611 	 */
612 
613 	if (!driver_match_device(drv, dev))
614 		return 0;
615 
616 	if (dev->parent)	/* Needed for USB */
617 		device_lock(dev->parent);
618 	device_lock(dev);
619 	if (!dev->driver)
620 		driver_probe_device(drv, dev);
621 	device_unlock(dev);
622 	if (dev->parent)
623 		device_unlock(dev->parent);
624 
625 	return 0;
626 }
627 
628 /**
629  * driver_attach - try to bind driver to devices.
630  * @drv: driver.
631  *
632  * Walk the list of devices that the bus has on it and try to
633  * match the driver with each one.  If driver_probe_device()
634  * returns 0 and the @dev->driver is set, we've found a
635  * compatible pair.
636  */
637 int driver_attach(struct device_driver *drv)
638 {
639 	return bus_for_each_dev(drv->bus, NULL, drv, __driver_attach);
640 }
641 EXPORT_SYMBOL_GPL(driver_attach);
642 
643 /*
644  * __device_release_driver() must be called with @dev lock held.
645  * When called for a USB interface, @dev->parent lock must be held as well.
646  */
647 static void __device_release_driver(struct device *dev)
648 {
649 	struct device_driver *drv;
650 
651 	drv = dev->driver;
652 	if (drv) {
653 		if (driver_allows_async_probing(drv))
654 			async_synchronize_full();
655 
656 		pm_runtime_get_sync(dev);
657 
658 		driver_sysfs_remove(dev);
659 
660 		if (dev->bus)
661 			blocking_notifier_call_chain(&dev->bus->p->bus_notifier,
662 						     BUS_NOTIFY_UNBIND_DRIVER,
663 						     dev);
664 
665 		pm_runtime_put_sync(dev);
666 
667 		if (dev->bus && dev->bus->remove)
668 			dev->bus->remove(dev);
669 		else if (drv->remove)
670 			drv->remove(dev);
671 		devres_release_all(dev);
672 		dev->driver = NULL;
673 		dev_set_drvdata(dev, NULL);
674 		if (dev->pm_domain && dev->pm_domain->dismiss)
675 			dev->pm_domain->dismiss(dev);
676 
677 		klist_remove(&dev->p->knode_driver);
678 		if (dev->bus)
679 			blocking_notifier_call_chain(&dev->bus->p->bus_notifier,
680 						     BUS_NOTIFY_UNBOUND_DRIVER,
681 						     dev);
682 
683 	}
684 }
685 
686 /**
687  * device_release_driver - manually detach device from driver.
688  * @dev: device.
689  *
690  * Manually detach device from driver.
691  * When called for a USB interface, @dev->parent lock must be held.
692  */
693 void device_release_driver(struct device *dev)
694 {
695 	/*
696 	 * If anyone calls device_release_driver() recursively from
697 	 * within their ->remove callback for the same device, they
698 	 * will deadlock right here.
699 	 */
700 	device_lock(dev);
701 	__device_release_driver(dev);
702 	device_unlock(dev);
703 }
704 EXPORT_SYMBOL_GPL(device_release_driver);
705 
706 /**
707  * driver_detach - detach driver from all devices it controls.
708  * @drv: driver.
709  */
710 void driver_detach(struct device_driver *drv)
711 {
712 	struct device_private *dev_prv;
713 	struct device *dev;
714 
715 	for (;;) {
716 		spin_lock(&drv->p->klist_devices.k_lock);
717 		if (list_empty(&drv->p->klist_devices.k_list)) {
718 			spin_unlock(&drv->p->klist_devices.k_lock);
719 			break;
720 		}
721 		dev_prv = list_entry(drv->p->klist_devices.k_list.prev,
722 				     struct device_private,
723 				     knode_driver.n_node);
724 		dev = dev_prv->device;
725 		get_device(dev);
726 		spin_unlock(&drv->p->klist_devices.k_lock);
727 
728 		if (dev->parent)	/* Needed for USB */
729 			device_lock(dev->parent);
730 		device_lock(dev);
731 		if (dev->driver == drv)
732 			__device_release_driver(dev);
733 		device_unlock(dev);
734 		if (dev->parent)
735 			device_unlock(dev->parent);
736 		put_device(dev);
737 	}
738 }
739