xref: /openbmc/linux/drivers/auxdisplay/lcd2s.c (revision def85dce)
18c9108d0SLars Poeschel // SPDX-License-Identifier: GPL-2.0
28c9108d0SLars Poeschel /*
3c726031aSAndy Shevchenko  *  Console driver for LCD2S 4x20 character displays connected through i2c.
4c726031aSAndy Shevchenko  *  The display also has a SPI interface, but the driver does not support
58c9108d0SLars Poeschel  *  this yet.
68c9108d0SLars Poeschel  *
7c726031aSAndy Shevchenko  *  This is a driver allowing you to use a LCD2S 4x20 from Modtronix
88c9108d0SLars Poeschel  *  engineering as auxdisplay character device.
98c9108d0SLars Poeschel  *
108c9108d0SLars Poeschel  *  (C) 2019 by Lemonage Software GmbH
118c9108d0SLars Poeschel  *  Author: Lars Pöschel <poeschel@lemonage.de>
128c9108d0SLars Poeschel  *  All rights reserved.
138c9108d0SLars Poeschel  */
148c9108d0SLars Poeschel #include <linux/kernel.h>
1544bb3f03SAndy Shevchenko #include <linux/mod_devicetable.h>
168c9108d0SLars Poeschel #include <linux/module.h>
1744bb3f03SAndy Shevchenko #include <linux/property.h>
188c9108d0SLars Poeschel #include <linux/slab.h>
198c9108d0SLars Poeschel #include <linux/i2c.h>
208c9108d0SLars Poeschel #include <linux/delay.h>
218c9108d0SLars Poeschel 
228c9108d0SLars Poeschel #include "charlcd.h"
238c9108d0SLars Poeschel 
248c9108d0SLars Poeschel #define LCD2S_CMD_CUR_MOVES_FWD		0x09
258c9108d0SLars Poeschel #define LCD2S_CMD_CUR_BLINK_OFF		0x10
268c9108d0SLars Poeschel #define LCD2S_CMD_CUR_UL_OFF		0x11
278c9108d0SLars Poeschel #define LCD2S_CMD_DISPLAY_OFF		0x12
288c9108d0SLars Poeschel #define LCD2S_CMD_CUR_BLINK_ON		0x18
298c9108d0SLars Poeschel #define LCD2S_CMD_CUR_UL_ON		0x19
308c9108d0SLars Poeschel #define LCD2S_CMD_DISPLAY_ON		0x1a
318c9108d0SLars Poeschel #define LCD2S_CMD_BACKLIGHT_OFF		0x20
328c9108d0SLars Poeschel #define LCD2S_CMD_BACKLIGHT_ON		0x28
338c9108d0SLars Poeschel #define LCD2S_CMD_WRITE			0x80
348c9108d0SLars Poeschel #define LCD2S_CMD_MOV_CUR_RIGHT		0x83
358c9108d0SLars Poeschel #define LCD2S_CMD_MOV_CUR_LEFT		0x84
368c9108d0SLars Poeschel #define LCD2S_CMD_SHIFT_RIGHT		0x85
378c9108d0SLars Poeschel #define LCD2S_CMD_SHIFT_LEFT		0x86
388c9108d0SLars Poeschel #define LCD2S_CMD_SHIFT_UP		0x87
398c9108d0SLars Poeschel #define LCD2S_CMD_SHIFT_DOWN		0x88
408c9108d0SLars Poeschel #define LCD2S_CMD_CUR_ADDR		0x89
418c9108d0SLars Poeschel #define LCD2S_CMD_CUR_POS		0x8a
428c9108d0SLars Poeschel #define LCD2S_CMD_CUR_RESET		0x8b
438c9108d0SLars Poeschel #define LCD2S_CMD_CLEAR			0x8c
448c9108d0SLars Poeschel #define LCD2S_CMD_DEF_CUSTOM_CHAR	0x92
458c9108d0SLars Poeschel #define LCD2S_CMD_READ_STATUS		0xd0
468c9108d0SLars Poeschel 
478c9108d0SLars Poeschel #define LCD2S_CHARACTER_SIZE		8
488c9108d0SLars Poeschel 
498c9108d0SLars Poeschel #define LCD2S_STATUS_BUF_MASK		0x7f
508c9108d0SLars Poeschel 
518c9108d0SLars Poeschel struct lcd2s_data {
528c9108d0SLars Poeschel 	struct i2c_client *i2c;
538c9108d0SLars Poeschel 	struct charlcd *charlcd;
548c9108d0SLars Poeschel };
558c9108d0SLars Poeschel 
lcd2s_wait_buf_free(const struct i2c_client * client,int count)568c9108d0SLars Poeschel static s32 lcd2s_wait_buf_free(const struct i2c_client *client, int count)
578c9108d0SLars Poeschel {
588c9108d0SLars Poeschel 	s32 status;
598c9108d0SLars Poeschel 
608c9108d0SLars Poeschel 	status = i2c_smbus_read_byte_data(client, LCD2S_CMD_READ_STATUS);
618c9108d0SLars Poeschel 	if (status < 0)
628c9108d0SLars Poeschel 		return status;
638c9108d0SLars Poeschel 
648c9108d0SLars Poeschel 	while ((status & LCD2S_STATUS_BUF_MASK) < count) {
658c9108d0SLars Poeschel 		mdelay(1);
668c9108d0SLars Poeschel 		status = i2c_smbus_read_byte_data(client,
678c9108d0SLars Poeschel 						  LCD2S_CMD_READ_STATUS);
688c9108d0SLars Poeschel 		if (status < 0)
698c9108d0SLars Poeschel 			return status;
708c9108d0SLars Poeschel 	}
718c9108d0SLars Poeschel 	return 0;
728c9108d0SLars Poeschel }
738c9108d0SLars Poeschel 
lcd2s_i2c_master_send(const struct i2c_client * client,const char * buf,int count)748c9108d0SLars Poeschel static int lcd2s_i2c_master_send(const struct i2c_client *client,
758c9108d0SLars Poeschel 				 const char *buf, int count)
768c9108d0SLars Poeschel {
778c9108d0SLars Poeschel 	s32 status;
788c9108d0SLars Poeschel 
798c9108d0SLars Poeschel 	status = lcd2s_wait_buf_free(client, count);
808c9108d0SLars Poeschel 	if (status < 0)
818c9108d0SLars Poeschel 		return status;
828c9108d0SLars Poeschel 
838c9108d0SLars Poeschel 	return i2c_master_send(client, buf, count);
848c9108d0SLars Poeschel }
858c9108d0SLars Poeschel 
lcd2s_i2c_smbus_write_byte(const struct i2c_client * client,u8 value)868c9108d0SLars Poeschel static int lcd2s_i2c_smbus_write_byte(const struct i2c_client *client, u8 value)
878c9108d0SLars Poeschel {
888c9108d0SLars Poeschel 	s32 status;
898c9108d0SLars Poeschel 
908c9108d0SLars Poeschel 	status = lcd2s_wait_buf_free(client, 1);
918c9108d0SLars Poeschel 	if (status < 0)
928c9108d0SLars Poeschel 		return status;
938c9108d0SLars Poeschel 
948c9108d0SLars Poeschel 	return i2c_smbus_write_byte(client, value);
958c9108d0SLars Poeschel }
968c9108d0SLars Poeschel 
lcd2s_print(struct charlcd * lcd,int c)978c9108d0SLars Poeschel static int lcd2s_print(struct charlcd *lcd, int c)
988c9108d0SLars Poeschel {
998c9108d0SLars Poeschel 	struct lcd2s_data *lcd2s = lcd->drvdata;
1008c9108d0SLars Poeschel 	u8 buf[2] = { LCD2S_CMD_WRITE, c };
1018c9108d0SLars Poeschel 
1028c9108d0SLars Poeschel 	lcd2s_i2c_master_send(lcd2s->i2c, buf, sizeof(buf));
1038c9108d0SLars Poeschel 	return 0;
1048c9108d0SLars Poeschel }
1058c9108d0SLars Poeschel 
lcd2s_gotoxy(struct charlcd * lcd,unsigned int x,unsigned int y)1068c9108d0SLars Poeschel static int lcd2s_gotoxy(struct charlcd *lcd, unsigned int x, unsigned int y)
1078c9108d0SLars Poeschel {
1088c9108d0SLars Poeschel 	struct lcd2s_data *lcd2s = lcd->drvdata;
10913de2349SAndy Shevchenko 	u8 buf[3] = { LCD2S_CMD_CUR_POS, y + 1, x + 1 };
1108c9108d0SLars Poeschel 
1118c9108d0SLars Poeschel 	lcd2s_i2c_master_send(lcd2s->i2c, buf, sizeof(buf));
1128c9108d0SLars Poeschel 
1138c9108d0SLars Poeschel 	return 0;
1148c9108d0SLars Poeschel }
1158c9108d0SLars Poeschel 
lcd2s_home(struct charlcd * lcd)1168c9108d0SLars Poeschel static int lcd2s_home(struct charlcd *lcd)
1178c9108d0SLars Poeschel {
1188c9108d0SLars Poeschel 	struct lcd2s_data *lcd2s = lcd->drvdata;
1198c9108d0SLars Poeschel 
1208c9108d0SLars Poeschel 	lcd2s_i2c_smbus_write_byte(lcd2s->i2c, LCD2S_CMD_CUR_RESET);
1218c9108d0SLars Poeschel 	return 0;
1228c9108d0SLars Poeschel }
1238c9108d0SLars Poeschel 
lcd2s_init_display(struct charlcd * lcd)1248c9108d0SLars Poeschel static int lcd2s_init_display(struct charlcd *lcd)
1258c9108d0SLars Poeschel {
1268c9108d0SLars Poeschel 	struct lcd2s_data *lcd2s = lcd->drvdata;
1278c9108d0SLars Poeschel 
1288c9108d0SLars Poeschel 	/* turn everything off, but display on */
1298c9108d0SLars Poeschel 	lcd2s_i2c_smbus_write_byte(lcd2s->i2c, LCD2S_CMD_DISPLAY_ON);
1308c9108d0SLars Poeschel 	lcd2s_i2c_smbus_write_byte(lcd2s->i2c, LCD2S_CMD_BACKLIGHT_OFF);
1318c9108d0SLars Poeschel 	lcd2s_i2c_smbus_write_byte(lcd2s->i2c, LCD2S_CMD_CUR_MOVES_FWD);
1328c9108d0SLars Poeschel 	lcd2s_i2c_smbus_write_byte(lcd2s->i2c, LCD2S_CMD_CUR_BLINK_OFF);
1338c9108d0SLars Poeschel 	lcd2s_i2c_smbus_write_byte(lcd2s->i2c, LCD2S_CMD_CUR_UL_OFF);
1348c9108d0SLars Poeschel 	lcd2s_i2c_smbus_write_byte(lcd2s->i2c, LCD2S_CMD_CLEAR);
1358c9108d0SLars Poeschel 
1368c9108d0SLars Poeschel 	return 0;
1378c9108d0SLars Poeschel }
1388c9108d0SLars Poeschel 
lcd2s_shift_cursor(struct charlcd * lcd,enum charlcd_shift_dir dir)1398c9108d0SLars Poeschel static int lcd2s_shift_cursor(struct charlcd *lcd, enum charlcd_shift_dir dir)
1408c9108d0SLars Poeschel {
1418c9108d0SLars Poeschel 	struct lcd2s_data *lcd2s = lcd->drvdata;
1428c9108d0SLars Poeschel 
1438c9108d0SLars Poeschel 	if (dir == CHARLCD_SHIFT_LEFT)
1448c9108d0SLars Poeschel 		lcd2s_i2c_smbus_write_byte(lcd2s->i2c, LCD2S_CMD_MOV_CUR_LEFT);
1458c9108d0SLars Poeschel 	else
1468c9108d0SLars Poeschel 		lcd2s_i2c_smbus_write_byte(lcd2s->i2c, LCD2S_CMD_MOV_CUR_RIGHT);
1478c9108d0SLars Poeschel 
1488c9108d0SLars Poeschel 	return 0;
1498c9108d0SLars Poeschel }
1508c9108d0SLars Poeschel 
lcd2s_shift_display(struct charlcd * lcd,enum charlcd_shift_dir dir)1518c9108d0SLars Poeschel static int lcd2s_shift_display(struct charlcd *lcd, enum charlcd_shift_dir dir)
1528c9108d0SLars Poeschel {
1538c9108d0SLars Poeschel 	struct lcd2s_data *lcd2s = lcd->drvdata;
1548c9108d0SLars Poeschel 
1558c9108d0SLars Poeschel 	if (dir == CHARLCD_SHIFT_LEFT)
1568c9108d0SLars Poeschel 		lcd2s_i2c_smbus_write_byte(lcd2s->i2c, LCD2S_CMD_SHIFT_LEFT);
1578c9108d0SLars Poeschel 	else
1588c9108d0SLars Poeschel 		lcd2s_i2c_smbus_write_byte(lcd2s->i2c, LCD2S_CMD_SHIFT_RIGHT);
1598c9108d0SLars Poeschel 
1608c9108d0SLars Poeschel 	return 0;
1618c9108d0SLars Poeschel }
1628c9108d0SLars Poeschel 
lcd2s_backlight(struct charlcd * lcd,enum charlcd_onoff on)1638c9108d0SLars Poeschel static void lcd2s_backlight(struct charlcd *lcd, enum charlcd_onoff on)
1648c9108d0SLars Poeschel {
1658c9108d0SLars Poeschel 	struct lcd2s_data *lcd2s = lcd->drvdata;
1668c9108d0SLars Poeschel 
1678c9108d0SLars Poeschel 	if (on)
1688c9108d0SLars Poeschel 		lcd2s_i2c_smbus_write_byte(lcd2s->i2c, LCD2S_CMD_BACKLIGHT_ON);
1698c9108d0SLars Poeschel 	else
1708c9108d0SLars Poeschel 		lcd2s_i2c_smbus_write_byte(lcd2s->i2c, LCD2S_CMD_BACKLIGHT_OFF);
1718c9108d0SLars Poeschel }
1728c9108d0SLars Poeschel 
lcd2s_display(struct charlcd * lcd,enum charlcd_onoff on)1738c9108d0SLars Poeschel static int lcd2s_display(struct charlcd *lcd, enum charlcd_onoff on)
1748c9108d0SLars Poeschel {
1758c9108d0SLars Poeschel 	struct lcd2s_data *lcd2s = lcd->drvdata;
1768c9108d0SLars Poeschel 
1778c9108d0SLars Poeschel 	if (on)
1788c9108d0SLars Poeschel 		lcd2s_i2c_smbus_write_byte(lcd2s->i2c, LCD2S_CMD_DISPLAY_ON);
1798c9108d0SLars Poeschel 	else
1808c9108d0SLars Poeschel 		lcd2s_i2c_smbus_write_byte(lcd2s->i2c, LCD2S_CMD_DISPLAY_OFF);
1818c9108d0SLars Poeschel 
1828c9108d0SLars Poeschel 	return 0;
1838c9108d0SLars Poeschel }
1848c9108d0SLars Poeschel 
lcd2s_cursor(struct charlcd * lcd,enum charlcd_onoff on)1858c9108d0SLars Poeschel static int lcd2s_cursor(struct charlcd *lcd, enum charlcd_onoff on)
1868c9108d0SLars Poeschel {
1878c9108d0SLars Poeschel 	struct lcd2s_data *lcd2s = lcd->drvdata;
1888c9108d0SLars Poeschel 
1898c9108d0SLars Poeschel 	if (on)
1908c9108d0SLars Poeschel 		lcd2s_i2c_smbus_write_byte(lcd2s->i2c, LCD2S_CMD_CUR_UL_ON);
1918c9108d0SLars Poeschel 	else
1928c9108d0SLars Poeschel 		lcd2s_i2c_smbus_write_byte(lcd2s->i2c, LCD2S_CMD_CUR_UL_OFF);
1938c9108d0SLars Poeschel 
1948c9108d0SLars Poeschel 	return 0;
1958c9108d0SLars Poeschel }
1968c9108d0SLars Poeschel 
lcd2s_blink(struct charlcd * lcd,enum charlcd_onoff on)1978c9108d0SLars Poeschel static int lcd2s_blink(struct charlcd *lcd, enum charlcd_onoff on)
1988c9108d0SLars Poeschel {
1998c9108d0SLars Poeschel 	struct lcd2s_data *lcd2s = lcd->drvdata;
2008c9108d0SLars Poeschel 
2018c9108d0SLars Poeschel 	if (on)
2028c9108d0SLars Poeschel 		lcd2s_i2c_smbus_write_byte(lcd2s->i2c, LCD2S_CMD_CUR_BLINK_ON);
2038c9108d0SLars Poeschel 	else
2048c9108d0SLars Poeschel 		lcd2s_i2c_smbus_write_byte(lcd2s->i2c, LCD2S_CMD_CUR_BLINK_OFF);
2058c9108d0SLars Poeschel 
2068c9108d0SLars Poeschel 	return 0;
2078c9108d0SLars Poeschel }
2088c9108d0SLars Poeschel 
lcd2s_fontsize(struct charlcd * lcd,enum charlcd_fontsize size)2098c9108d0SLars Poeschel static int lcd2s_fontsize(struct charlcd *lcd, enum charlcd_fontsize size)
2108c9108d0SLars Poeschel {
2118c9108d0SLars Poeschel 	return 0;
2128c9108d0SLars Poeschel }
2138c9108d0SLars Poeschel 
lcd2s_lines(struct charlcd * lcd,enum charlcd_lines lines)2148c9108d0SLars Poeschel static int lcd2s_lines(struct charlcd *lcd, enum charlcd_lines lines)
2158c9108d0SLars Poeschel {
2168c9108d0SLars Poeschel 	return 0;
2178c9108d0SLars Poeschel }
2188c9108d0SLars Poeschel 
219c726031aSAndy Shevchenko /*
220c726031aSAndy Shevchenko  * Generator: LGcxxxxx...xx; must have <c> between '0' and '7',
221c726031aSAndy Shevchenko  * representing the numerical ASCII code of the redefined character,
222c726031aSAndy Shevchenko  * and <xx...xx> a sequence of 16 hex digits representing 8 bytes
223c726031aSAndy Shevchenko  * for each character. Most LCDs will only use 5 lower bits of
224c726031aSAndy Shevchenko  * the 7 first bytes.
225c726031aSAndy Shevchenko  */
lcd2s_redefine_char(struct charlcd * lcd,char * esc)2268c9108d0SLars Poeschel static int lcd2s_redefine_char(struct charlcd *lcd, char *esc)
2278c9108d0SLars Poeschel {
2288c9108d0SLars Poeschel 	struct lcd2s_data *lcd2s = lcd->drvdata;
2298c9108d0SLars Poeschel 	u8 buf[LCD2S_CHARACTER_SIZE + 2] = { LCD2S_CMD_DEF_CUSTOM_CHAR };
2308c9108d0SLars Poeschel 	u8 value;
2318c9108d0SLars Poeschel 	int shift, i;
2328c9108d0SLars Poeschel 
2338c9108d0SLars Poeschel 	if (!strchr(esc, ';'))
2348c9108d0SLars Poeschel 		return 0;
2358c9108d0SLars Poeschel 
2368c9108d0SLars Poeschel 	esc++;
2378c9108d0SLars Poeschel 
2388c9108d0SLars Poeschel 	buf[1] = *(esc++) - '0';
2398c9108d0SLars Poeschel 	if (buf[1] > 7)
2408c9108d0SLars Poeschel 		return 1;
2418c9108d0SLars Poeschel 
2424424c35eSAndy Shevchenko 	i = 2;
2438c9108d0SLars Poeschel 	shift = 0;
2448c9108d0SLars Poeschel 	value = 0;
2458c9108d0SLars Poeschel 	while (*esc && i < LCD2S_CHARACTER_SIZE + 2) {
2468c9108d0SLars Poeschel 		int half;
2478c9108d0SLars Poeschel 
2488c9108d0SLars Poeschel 		shift ^= 4;
2498c9108d0SLars Poeschel 		half = hex_to_bin(*esc++);
2508c9108d0SLars Poeschel 		if (half < 0)
2518c9108d0SLars Poeschel 			continue;
2528c9108d0SLars Poeschel 
2538c9108d0SLars Poeschel 		value |= half << shift;
2548c9108d0SLars Poeschel 		if (shift == 0) {
2558c9108d0SLars Poeschel 			buf[i++] = value;
2568c9108d0SLars Poeschel 			value = 0;
2578c9108d0SLars Poeschel 		}
2588c9108d0SLars Poeschel 	}
2598c9108d0SLars Poeschel 
2608c9108d0SLars Poeschel 	lcd2s_i2c_master_send(lcd2s->i2c, buf, sizeof(buf));
2618c9108d0SLars Poeschel 	return 1;
2628c9108d0SLars Poeschel }
2638c9108d0SLars Poeschel 
lcd2s_clear_display(struct charlcd * lcd)2648c9108d0SLars Poeschel static int lcd2s_clear_display(struct charlcd *lcd)
2658c9108d0SLars Poeschel {
2668c9108d0SLars Poeschel 	struct lcd2s_data *lcd2s = lcd->drvdata;
2678c9108d0SLars Poeschel 
2688c9108d0SLars Poeschel 	/* This implicitly sets cursor to first row and column */
2698c9108d0SLars Poeschel 	lcd2s_i2c_smbus_write_byte(lcd2s->i2c, LCD2S_CMD_CLEAR);
2708c9108d0SLars Poeschel 	return 0;
2718c9108d0SLars Poeschel }
2728c9108d0SLars Poeschel 
2738c9108d0SLars Poeschel static const struct charlcd_ops lcd2s_ops = {
2748c9108d0SLars Poeschel 	.print		= lcd2s_print,
2758c9108d0SLars Poeschel 	.backlight	= lcd2s_backlight,
2768c9108d0SLars Poeschel 	.gotoxy		= lcd2s_gotoxy,
2778c9108d0SLars Poeschel 	.home		= lcd2s_home,
2788c9108d0SLars Poeschel 	.clear_display	= lcd2s_clear_display,
2798c9108d0SLars Poeschel 	.init_display	= lcd2s_init_display,
2808c9108d0SLars Poeschel 	.shift_cursor	= lcd2s_shift_cursor,
2818c9108d0SLars Poeschel 	.shift_display	= lcd2s_shift_display,
2828c9108d0SLars Poeschel 	.display	= lcd2s_display,
2838c9108d0SLars Poeschel 	.cursor		= lcd2s_cursor,
2848c9108d0SLars Poeschel 	.blink		= lcd2s_blink,
2858c9108d0SLars Poeschel 	.fontsize	= lcd2s_fontsize,
2868c9108d0SLars Poeschel 	.lines		= lcd2s_lines,
2878c9108d0SLars Poeschel 	.redefine_char	= lcd2s_redefine_char,
2888c9108d0SLars Poeschel };
2898c9108d0SLars Poeschel 
lcd2s_i2c_probe(struct i2c_client * i2c)2908fefb313SAndy Shevchenko static int lcd2s_i2c_probe(struct i2c_client *i2c)
2918c9108d0SLars Poeschel {
2928c9108d0SLars Poeschel 	struct charlcd *lcd;
2938c9108d0SLars Poeschel 	struct lcd2s_data *lcd2s;
2948c9108d0SLars Poeschel 	int err;
2958c9108d0SLars Poeschel 
2968c9108d0SLars Poeschel 	if (!i2c_check_functionality(i2c->adapter,
2978c9108d0SLars Poeschel 			I2C_FUNC_SMBUS_WRITE_BYTE_DATA |
2988c9108d0SLars Poeschel 			I2C_FUNC_SMBUS_WRITE_BLOCK_DATA))
2998c9108d0SLars Poeschel 		return -EIO;
3008c9108d0SLars Poeschel 
301898c0a15SAndy Shevchenko 	lcd2s = devm_kzalloc(&i2c->dev, sizeof(*lcd2s), GFP_KERNEL);
302898c0a15SAndy Shevchenko 	if (!lcd2s)
303898c0a15SAndy Shevchenko 		return -ENOMEM;
304898c0a15SAndy Shevchenko 
3058c9108d0SLars Poeschel 	/* Test, if the display is responding */
3068c9108d0SLars Poeschel 	err = lcd2s_i2c_smbus_write_byte(i2c, LCD2S_CMD_DISPLAY_OFF);
3078c9108d0SLars Poeschel 	if (err < 0)
3088c9108d0SLars Poeschel 		return err;
3098c9108d0SLars Poeschel 
3108c9108d0SLars Poeschel 	lcd = charlcd_alloc();
3118c9108d0SLars Poeschel 	if (!lcd)
3128c9108d0SLars Poeschel 		return -ENOMEM;
3138c9108d0SLars Poeschel 
3148c9108d0SLars Poeschel 	lcd->drvdata = lcd2s;
3158c9108d0SLars Poeschel 	lcd2s->i2c = i2c;
3168c9108d0SLars Poeschel 	lcd2s->charlcd = lcd;
3178c9108d0SLars Poeschel 
3188c9108d0SLars Poeschel 	/* Required properties */
3198c9108d0SLars Poeschel 	err = device_property_read_u32(&i2c->dev, "display-height-chars",
3208c9108d0SLars Poeschel 			&lcd->height);
3218c9108d0SLars Poeschel 	if (err)
322898c0a15SAndy Shevchenko 		goto fail1;
3238c9108d0SLars Poeschel 
3248c9108d0SLars Poeschel 	err = device_property_read_u32(&i2c->dev, "display-width-chars",
3258c9108d0SLars Poeschel 			&lcd->width);
3268c9108d0SLars Poeschel 	if (err)
327898c0a15SAndy Shevchenko 		goto fail1;
3288c9108d0SLars Poeschel 
3298c9108d0SLars Poeschel 	lcd->ops = &lcd2s_ops;
3308c9108d0SLars Poeschel 
3318c9108d0SLars Poeschel 	err = charlcd_register(lcd2s->charlcd);
3328c9108d0SLars Poeschel 	if (err)
333898c0a15SAndy Shevchenko 		goto fail1;
3348c9108d0SLars Poeschel 
3358c9108d0SLars Poeschel 	i2c_set_clientdata(i2c, lcd2s);
3368c9108d0SLars Poeschel 	return 0;
3378c9108d0SLars Poeschel 
3388c9108d0SLars Poeschel fail1:
3399ed331f8SAndy Shevchenko 	charlcd_free(lcd2s->charlcd);
3408c9108d0SLars Poeschel 	return err;
3418c9108d0SLars Poeschel }
3428c9108d0SLars Poeschel 
lcd2s_i2c_remove(struct i2c_client * i2c)343ed5c2f5fSUwe Kleine-König static void lcd2s_i2c_remove(struct i2c_client *i2c)
3448c9108d0SLars Poeschel {
3458c9108d0SLars Poeschel 	struct lcd2s_data *lcd2s = i2c_get_clientdata(i2c);
3468c9108d0SLars Poeschel 
3478c9108d0SLars Poeschel 	charlcd_unregister(lcd2s->charlcd);
3489ed331f8SAndy Shevchenko 	charlcd_free(lcd2s->charlcd);
3498c9108d0SLars Poeschel }
3508c9108d0SLars Poeschel 
3518c9108d0SLars Poeschel static const struct i2c_device_id lcd2s_i2c_id[] = {
3528c9108d0SLars Poeschel 	{ "lcd2s", 0 },
3538c9108d0SLars Poeschel 	{ }
3548c9108d0SLars Poeschel };
3558c9108d0SLars Poeschel MODULE_DEVICE_TABLE(i2c, lcd2s_i2c_id);
3568c9108d0SLars Poeschel 
3578c9108d0SLars Poeschel static const struct of_device_id lcd2s_of_table[] = {
3588c9108d0SLars Poeschel 	{ .compatible = "modtronix,lcd2s" },
3598c9108d0SLars Poeschel 	{ }
3608c9108d0SLars Poeschel };
3618c9108d0SLars Poeschel MODULE_DEVICE_TABLE(of, lcd2s_of_table);
3628c9108d0SLars Poeschel 
3638c9108d0SLars Poeschel static struct i2c_driver lcd2s_i2c_driver = {
3648c9108d0SLars Poeschel 	.driver = {
3658c9108d0SLars Poeschel 		.name = "lcd2s",
36644bb3f03SAndy Shevchenko 		.of_match_table = lcd2s_of_table,
3678c9108d0SLars Poeschel 	},
368*def85dceSUwe Kleine-König 	.probe = lcd2s_i2c_probe,
3698c9108d0SLars Poeschel 	.remove = lcd2s_i2c_remove,
3708c9108d0SLars Poeschel 	.id_table = lcd2s_i2c_id,
3718c9108d0SLars Poeschel };
372f15c3deaSAndy Shevchenko module_i2c_driver(lcd2s_i2c_driver);
3738c9108d0SLars Poeschel 
3748c9108d0SLars Poeschel MODULE_DESCRIPTION("LCD2S character display driver");
3758c9108d0SLars Poeschel MODULE_AUTHOR("Lars Poeschel");
3768c9108d0SLars Poeschel MODULE_LICENSE("GPL");
377