xref: /openbmc/linux/drivers/acpi/x86/utils.c (revision 93696d8f)
1 // SPDX-License-Identifier: GPL-2.0-only
2 /*
3  * X86 ACPI Utility Functions
4  *
5  * Copyright (C) 2017 Hans de Goede <hdegoede@redhat.com>
6  *
7  * Based on various non upstream patches to support the CHT Whiskey Cove PMIC:
8  * Copyright (C) 2013-2015 Intel Corporation. All rights reserved.
9  */
10 
11 #define pr_fmt(fmt) "ACPI: " fmt
12 
13 #include <linux/acpi.h>
14 #include <linux/dmi.h>
15 #include <linux/platform_device.h>
16 #include <asm/cpu_device_id.h>
17 #include <asm/intel-family.h>
18 #include "../internal.h"
19 
20 /*
21  * Some ACPI devices are hidden (status == 0x0) in recent BIOS-es because
22  * some recent Windows drivers bind to one device but poke at multiple
23  * devices at the same time, so the others get hidden.
24  *
25  * Some BIOS-es (temporarily) hide specific APCI devices to work around Windows
26  * driver bugs. We use DMI matching to match known cases of this.
27  *
28  * Likewise sometimes some not-actually present devices are sometimes
29  * reported as present, which may cause issues.
30  *
31  * We work around this by using the below quirk list to override the status
32  * reported by the _STA method with a fixed value (ACPI_STA_DEFAULT or 0).
33  * Note this MUST only be done for devices where this is safe.
34  *
35  * This status overriding is limited to specific CPU (SoC) models both to
36  * avoid potentially causing trouble on other models and because some HIDs
37  * are re-used on different SoCs for completely different devices.
38  */
39 struct override_status_id {
40 	struct acpi_device_id hid[2];
41 	struct x86_cpu_id cpu_ids[2];
42 	struct dmi_system_id dmi_ids[2]; /* Optional */
43 	const char *uid;
44 	const char *path;
45 	unsigned long long status;
46 };
47 
48 #define ENTRY(status, hid, uid, path, cpu_model, dmi...) {		\
49 	{ { hid, }, {} },						\
50 	{ X86_MATCH_INTEL_FAM6_MODEL(cpu_model, NULL), {} },		\
51 	{ { .matches = dmi }, {} },					\
52 	uid,								\
53 	path,								\
54 	status,								\
55 }
56 
57 #define PRESENT_ENTRY_HID(hid, uid, cpu_model, dmi...) \
58 	ENTRY(ACPI_STA_DEFAULT, hid, uid, NULL, cpu_model, dmi)
59 
60 #define NOT_PRESENT_ENTRY_HID(hid, uid, cpu_model, dmi...) \
61 	ENTRY(0, hid, uid, NULL, cpu_model, dmi)
62 
63 #define PRESENT_ENTRY_PATH(path, cpu_model, dmi...) \
64 	ENTRY(ACPI_STA_DEFAULT, "", NULL, path, cpu_model, dmi)
65 
66 #define NOT_PRESENT_ENTRY_PATH(path, cpu_model, dmi...) \
67 	ENTRY(0, "", NULL, path, cpu_model, dmi)
68 
69 static const struct override_status_id override_status_ids[] = {
70 	/*
71 	 * Bay / Cherry Trail PWM directly poked by GPU driver in win10,
72 	 * but Linux uses a separate PWM driver, harmless if not used.
73 	 */
74 	PRESENT_ENTRY_HID("80860F09", "1", ATOM_SILVERMONT, {}),
75 	PRESENT_ENTRY_HID("80862288", "1", ATOM_AIRMONT, {}),
76 
77 	/* The Xiaomi Mi Pad 2 uses PWM2 for touchkeys backlight control */
78 	PRESENT_ENTRY_HID("80862289", "2", ATOM_AIRMONT, {
79 		DMI_MATCH(DMI_SYS_VENDOR, "Xiaomi Inc"),
80 		DMI_MATCH(DMI_PRODUCT_NAME, "Mipad2"),
81 	      }),
82 
83 	/*
84 	 * The INT0002 device is necessary to clear wakeup interrupt sources
85 	 * on Cherry Trail devices, without it we get nobody cared IRQ msgs.
86 	 */
87 	PRESENT_ENTRY_HID("INT0002", "1", ATOM_AIRMONT, {}),
88 	/*
89 	 * On the Dell Venue 11 Pro 7130 and 7139, the DSDT hides
90 	 * the touchscreen ACPI device until a certain time
91 	 * after _SB.PCI0.GFX0.LCD.LCD1._ON gets called has passed
92 	 * *and* _STA has been called at least 3 times since.
93 	 */
94 	PRESENT_ENTRY_HID("SYNA7500", "1", HASWELL_L, {
95 		DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
96 		DMI_MATCH(DMI_PRODUCT_NAME, "Venue 11 Pro 7130"),
97 	      }),
98 	PRESENT_ENTRY_HID("SYNA7500", "1", HASWELL_L, {
99 		DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
100 		DMI_MATCH(DMI_PRODUCT_NAME, "Venue 11 Pro 7139"),
101 	      }),
102 
103 	/*
104 	 * The GPD win BIOS dated 20170221 has disabled the accelerometer, the
105 	 * drivers sometimes cause crashes under Windows and this is how the
106 	 * manufacturer has solved this :|  The DMI match may not seem unique,
107 	 * but it is. In the 67000+ DMI decode dumps from linux-hardware.org
108 	 * only 116 have board_vendor set to "AMI Corporation" and of those 116
109 	 * only the GPD win and pocket entries' board_name is "Default string".
110 	 *
111 	 * Unfortunately the GPD pocket also uses these strings and its BIOS
112 	 * was copy-pasted from the GPD win, so it has a disabled KIOX000A
113 	 * node which we should not enable, thus we also check the BIOS date.
114 	 */
115 	PRESENT_ENTRY_HID("KIOX000A", "1", ATOM_AIRMONT, {
116 		DMI_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
117 		DMI_MATCH(DMI_BOARD_NAME, "Default string"),
118 		DMI_MATCH(DMI_PRODUCT_NAME, "Default string"),
119 		DMI_MATCH(DMI_BIOS_DATE, "02/21/2017")
120 	      }),
121 	PRESENT_ENTRY_HID("KIOX000A", "1", ATOM_AIRMONT, {
122 		DMI_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
123 		DMI_MATCH(DMI_BOARD_NAME, "Default string"),
124 		DMI_MATCH(DMI_PRODUCT_NAME, "Default string"),
125 		DMI_MATCH(DMI_BIOS_DATE, "03/20/2017")
126 	      }),
127 	PRESENT_ENTRY_HID("KIOX000A", "1", ATOM_AIRMONT, {
128 		DMI_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
129 		DMI_MATCH(DMI_BOARD_NAME, "Default string"),
130 		DMI_MATCH(DMI_PRODUCT_NAME, "Default string"),
131 		DMI_MATCH(DMI_BIOS_DATE, "05/25/2017")
132 	      }),
133 
134 	/*
135 	 * The GPD win/pocket have a PCI wifi card, but its DSDT has the SDIO
136 	 * mmc controller enabled and that has a child-device which _PS3
137 	 * method sets a GPIO causing the PCI wifi card to turn off.
138 	 * See above remark about uniqueness of the DMI match.
139 	 */
140 	NOT_PRESENT_ENTRY_PATH("\\_SB_.PCI0.SDHB.BRC1", ATOM_AIRMONT, {
141 		DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
142 		DMI_EXACT_MATCH(DMI_BOARD_NAME, "Default string"),
143 		DMI_EXACT_MATCH(DMI_BOARD_SERIAL, "Default string"),
144 		DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"),
145 	      }),
146 
147 	/*
148 	 * The LSM303D on the Lenovo Yoga Tablet 2 series is present
149 	 * as both ACCL0001 and MAGN0001. As we can only ever register an
150 	 * i2c client for one of them, ignore MAGN0001.
151 	 */
152 	NOT_PRESENT_ENTRY_HID("MAGN0001", "1", ATOM_SILVERMONT, {
153 		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
154 		DMI_MATCH(DMI_PRODUCT_FAMILY, "YOGATablet2"),
155 	      }),
156 };
157 
158 bool acpi_device_override_status(struct acpi_device *adev, unsigned long long *status)
159 {
160 	bool ret = false;
161 	unsigned int i;
162 
163 	for (i = 0; i < ARRAY_SIZE(override_status_ids); i++) {
164 		if (!x86_match_cpu(override_status_ids[i].cpu_ids))
165 			continue;
166 
167 		if (override_status_ids[i].dmi_ids[0].matches[0].slot &&
168 		    !dmi_check_system(override_status_ids[i].dmi_ids))
169 			continue;
170 
171 		if (override_status_ids[i].path) {
172 			struct acpi_buffer path = { ACPI_ALLOCATE_BUFFER, NULL };
173 			bool match;
174 
175 			if (acpi_get_name(adev->handle, ACPI_FULL_PATHNAME, &path))
176 				continue;
177 
178 			match = strcmp((char *)path.pointer, override_status_ids[i].path) == 0;
179 			kfree(path.pointer);
180 
181 			if (!match)
182 				continue;
183 		} else {
184 			if (acpi_match_device_ids(adev, override_status_ids[i].hid))
185 				continue;
186 
187 			if (!adev->pnp.unique_id ||
188 			    strcmp(adev->pnp.unique_id, override_status_ids[i].uid))
189 				continue;
190 		}
191 
192 		*status = override_status_ids[i].status;
193 		ret = true;
194 		break;
195 	}
196 
197 	return ret;
198 }
199 
200 /*
201  * AMD systems from Renoir onwards *require* that the NVME controller
202  * is put into D3 over a Modern Standby / suspend-to-idle cycle.
203  *
204  * This is "typically" accomplished using the `StorageD3Enable`
205  * property in the _DSD that is checked via the `acpi_storage_d3` function
206  * but some OEM systems still don't have it in their BIOS.
207  *
208  * The Microsoft documentation for StorageD3Enable mentioned that Windows has
209  * a hardcoded allowlist for D3 support as well as a registry key to override
210  * the BIOS, which has been used for these cases.
211  *
212  * This allows quirking on Linux in a similar fashion.
213  *
214  * Cezanne systems shouldn't *normally* need this as the BIOS includes
215  * StorageD3Enable.  But for two reasons we have added it.
216  * 1) The BIOS on a number of Dell systems have ambiguity
217  *    between the same value used for _ADR on ACPI nodes GPP1.DEV0 and GPP1.NVME.
218  *    GPP1.NVME is needed to get StorageD3Enable node set properly.
219  *    https://bugzilla.kernel.org/show_bug.cgi?id=216440
220  *    https://bugzilla.kernel.org/show_bug.cgi?id=216773
221  *    https://bugzilla.kernel.org/show_bug.cgi?id=217003
222  * 2) On at least one HP system StorageD3Enable is missing on the second NVME
223  *    disk in the system.
224  * 3) On at least one HP Rembrandt system StorageD3Enable is missing on the only
225  *    NVME device.
226  */
227 bool force_storage_d3(void)
228 {
229 	if (!cpu_feature_enabled(X86_FEATURE_ZEN))
230 		return false;
231 	return acpi_gbl_FADT.flags & ACPI_FADT_LOW_POWER_S0;
232 }
233 
234 /*
235  * x86 ACPI boards which ship with only Android as their factory image usually
236  * declare a whole bunch of bogus I2C devices in their ACPI tables and sometimes
237  * there are issues with serdev devices on these boards too, e.g. the resource
238  * points to the wrong serdev_controller.
239  *
240  * Instantiating I2C / serdev devs for these bogus devs causes various issues,
241  * e.g. GPIO/IRQ resource conflicts because sometimes drivers do bind to them.
242  * The Android x86 kernel fork shipped on these devices has some special code
243  * to remove the bogus I2C clients (and AFAICT serdevs are ignored completely).
244  *
245  * The acpi_quirk_skip_*_enumeration() functions below are used by the I2C or
246  * serdev code to skip instantiating any I2C or serdev devs on broken boards.
247  *
248  * In case of I2C an exception is made for HIDs on the i2c_acpi_known_good_ids
249  * list. These are known to always be correct (and in case of the audio-codecs
250  * the drivers heavily rely on the codec being enumerated through ACPI).
251  *
252  * Note these boards typically do actually have I2C and serdev devices,
253  * just different ones then the ones described in their DSDT. The devices
254  * which are actually present are manually instantiated by the
255  * drivers/platform/x86/x86-android-tablets.c kernel module.
256  */
257 #define ACPI_QUIRK_SKIP_I2C_CLIENTS				BIT(0)
258 #define ACPI_QUIRK_UART1_SKIP					BIT(1)
259 #define ACPI_QUIRK_UART1_TTY_UART2_SKIP				BIT(2)
260 #define ACPI_QUIRK_PNP_UART1_SKIP				BIT(3)
261 #define ACPI_QUIRK_SKIP_ACPI_AC_AND_BATTERY			BIT(4)
262 #define ACPI_QUIRK_USE_ACPI_AC_AND_BATTERY			BIT(5)
263 #define ACPI_QUIRK_SKIP_GPIO_EVENT_HANDLERS			BIT(6)
264 
265 static const struct dmi_system_id acpi_quirk_skip_dmi_ids[] = {
266 	/*
267 	 * 1. Devices with only the skip / don't-skip AC and battery quirks,
268 	 *    sorted alphabetically.
269 	 */
270 	{
271 		/* ECS EF20EA, AXP288 PMIC but uses separate fuel-gauge */
272 		.matches = {
273 			DMI_MATCH(DMI_PRODUCT_NAME, "EF20EA"),
274 		},
275 		.driver_data = (void *)ACPI_QUIRK_USE_ACPI_AC_AND_BATTERY
276 	},
277 	{
278 		/* Lenovo Ideapad Miix 320, AXP288 PMIC, separate fuel-gauge */
279 		.matches = {
280 			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
281 			DMI_MATCH(DMI_PRODUCT_NAME, "80XF"),
282 			DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),
283 		},
284 		.driver_data = (void *)ACPI_QUIRK_USE_ACPI_AC_AND_BATTERY
285 	},
286 
287 	/*
288 	 * 2. Devices which also have the skip i2c/serdev quirks and which
289 	 *    need the x86-android-tablets module to properly work.
290 	 */
291 #if IS_ENABLED(CONFIG_X86_ANDROID_TABLETS)
292 	{
293 		/* Acer Iconia One 7 B1-750 */
294 		.matches = {
295 			DMI_MATCH(DMI_SYS_VENDOR, "Insyde"),
296 			DMI_MATCH(DMI_PRODUCT_NAME, "VESPA2"),
297 		},
298 		.driver_data = (void *)(ACPI_QUIRK_SKIP_I2C_CLIENTS |
299 					ACPI_QUIRK_SKIP_ACPI_AC_AND_BATTERY |
300 					ACPI_QUIRK_SKIP_GPIO_EVENT_HANDLERS),
301 	},
302 	{
303 		.matches = {
304 			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
305 			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ME176C"),
306 		},
307 		.driver_data = (void *)(ACPI_QUIRK_SKIP_I2C_CLIENTS |
308 					ACPI_QUIRK_UART1_TTY_UART2_SKIP |
309 					ACPI_QUIRK_SKIP_ACPI_AC_AND_BATTERY |
310 					ACPI_QUIRK_SKIP_GPIO_EVENT_HANDLERS),
311 	},
312 	{
313 		/* Lenovo Yoga Book X90F/L */
314 		.matches = {
315 			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),
316 			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "CHERRYVIEW D1 PLATFORM"),
317 			DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "YETI-11"),
318 		},
319 		.driver_data = (void *)(ACPI_QUIRK_SKIP_I2C_CLIENTS |
320 					ACPI_QUIRK_UART1_SKIP |
321 					ACPI_QUIRK_SKIP_ACPI_AC_AND_BATTERY |
322 					ACPI_QUIRK_SKIP_GPIO_EVENT_HANDLERS),
323 	},
324 	{
325 		.matches = {
326 			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
327 			DMI_MATCH(DMI_PRODUCT_NAME, "TF103C"),
328 		},
329 		.driver_data = (void *)(ACPI_QUIRK_SKIP_I2C_CLIENTS |
330 					ACPI_QUIRK_SKIP_ACPI_AC_AND_BATTERY |
331 					ACPI_QUIRK_SKIP_GPIO_EVENT_HANDLERS),
332 	},
333 	{
334 		/* Lenovo Yoga Tablet 2 1050F/L */
335 		.matches = {
336 			DMI_MATCH(DMI_SYS_VENDOR, "Intel Corp."),
337 			DMI_MATCH(DMI_PRODUCT_NAME, "VALLEYVIEW C0 PLATFORM"),
338 			DMI_MATCH(DMI_BOARD_NAME, "BYT-T FFD8"),
339 			/* Partial match on beginning of BIOS version */
340 			DMI_MATCH(DMI_BIOS_VERSION, "BLADE_21"),
341 		},
342 		.driver_data = (void *)(ACPI_QUIRK_SKIP_I2C_CLIENTS |
343 					ACPI_QUIRK_PNP_UART1_SKIP |
344 					ACPI_QUIRK_SKIP_ACPI_AC_AND_BATTERY),
345 	},
346 	{
347 		/* Lenovo Yoga Tab 3 Pro X90F */
348 		.matches = {
349 			DMI_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),
350 			DMI_MATCH(DMI_PRODUCT_NAME, "CHERRYVIEW D1 PLATFORM"),
351 			DMI_MATCH(DMI_PRODUCT_VERSION, "Blade3-10A-001"),
352 		},
353 		.driver_data = (void *)(ACPI_QUIRK_SKIP_I2C_CLIENTS |
354 					ACPI_QUIRK_SKIP_ACPI_AC_AND_BATTERY),
355 	},
356 	{
357 		/* Medion Lifetab S10346 */
358 		.matches = {
359 			DMI_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
360 			DMI_MATCH(DMI_BOARD_NAME, "Aptio CRB"),
361 			/* Way too generic, also match on BIOS data */
362 			DMI_MATCH(DMI_BIOS_DATE, "10/22/2015"),
363 		},
364 		.driver_data = (void *)(ACPI_QUIRK_SKIP_I2C_CLIENTS |
365 					ACPI_QUIRK_SKIP_ACPI_AC_AND_BATTERY),
366 	},
367 	{
368 		/* Nextbook Ares 8 (BYT version)*/
369 		.matches = {
370 			DMI_MATCH(DMI_SYS_VENDOR, "Insyde"),
371 			DMI_MATCH(DMI_PRODUCT_NAME, "M890BAP"),
372 		},
373 		.driver_data = (void *)(ACPI_QUIRK_SKIP_I2C_CLIENTS |
374 					ACPI_QUIRK_SKIP_ACPI_AC_AND_BATTERY |
375 					ACPI_QUIRK_SKIP_GPIO_EVENT_HANDLERS),
376 	},
377 	{
378 		/* Nextbook Ares 8A (CHT version)*/
379 		.matches = {
380 			DMI_MATCH(DMI_SYS_VENDOR, "Insyde"),
381 			DMI_MATCH(DMI_PRODUCT_NAME, "CherryTrail"),
382 			DMI_MATCH(DMI_BIOS_VERSION, "M882"),
383 		},
384 		.driver_data = (void *)(ACPI_QUIRK_SKIP_I2C_CLIENTS |
385 					ACPI_QUIRK_SKIP_ACPI_AC_AND_BATTERY),
386 	},
387 	{
388 		/* Whitelabel (sold as various brands) TM800A550L */
389 		.matches = {
390 			DMI_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
391 			DMI_MATCH(DMI_BOARD_NAME, "Aptio CRB"),
392 			/* Above strings are too generic, also match on BIOS version */
393 			DMI_MATCH(DMI_BIOS_VERSION, "ZY-8-BI-PX4S70VTR400-X423B-005-D"),
394 		},
395 		.driver_data = (void *)(ACPI_QUIRK_SKIP_I2C_CLIENTS |
396 					ACPI_QUIRK_SKIP_ACPI_AC_AND_BATTERY),
397 	},
398 #endif
399 	{}
400 };
401 
402 #if IS_ENABLED(CONFIG_X86_ANDROID_TABLETS)
403 static const struct acpi_device_id i2c_acpi_known_good_ids[] = {
404 	{ "10EC5640", 0 }, /* RealTek ALC5640 audio codec */
405 	{ "10EC5651", 0 }, /* RealTek ALC5651 audio codec */
406 	{ "INT33F4", 0 },  /* X-Powers AXP288 PMIC */
407 	{ "INT33FD", 0 },  /* Intel Crystal Cove PMIC */
408 	{ "INT34D3", 0 },  /* Intel Whiskey Cove PMIC */
409 	{ "NPCE69A", 0 },  /* Asus Transformer keyboard dock */
410 	{}
411 };
412 
413 bool acpi_quirk_skip_i2c_client_enumeration(struct acpi_device *adev)
414 {
415 	const struct dmi_system_id *dmi_id;
416 	long quirks;
417 
418 	dmi_id = dmi_first_match(acpi_quirk_skip_dmi_ids);
419 	if (!dmi_id)
420 		return false;
421 
422 	quirks = (unsigned long)dmi_id->driver_data;
423 	if (!(quirks & ACPI_QUIRK_SKIP_I2C_CLIENTS))
424 		return false;
425 
426 	return acpi_match_device_ids(adev, i2c_acpi_known_good_ids);
427 }
428 EXPORT_SYMBOL_GPL(acpi_quirk_skip_i2c_client_enumeration);
429 
430 static int acpi_dmi_skip_serdev_enumeration(struct device *controller_parent, bool *skip)
431 {
432 	struct acpi_device *adev = ACPI_COMPANION(controller_parent);
433 	const struct dmi_system_id *dmi_id;
434 	long quirks = 0;
435 	u64 uid;
436 	int ret;
437 
438 	ret = acpi_dev_uid_to_integer(adev, &uid);
439 	if (ret)
440 		return 0;
441 
442 	dmi_id = dmi_first_match(acpi_quirk_skip_dmi_ids);
443 	if (dmi_id)
444 		quirks = (unsigned long)dmi_id->driver_data;
445 
446 	if (!dev_is_platform(controller_parent)) {
447 		/* PNP enumerated UARTs */
448 		if ((quirks & ACPI_QUIRK_PNP_UART1_SKIP) && uid == 1)
449 			*skip = true;
450 
451 		return 0;
452 	}
453 
454 	if ((quirks & ACPI_QUIRK_UART1_SKIP) && uid == 1)
455 		*skip = true;
456 
457 	if (quirks & ACPI_QUIRK_UART1_TTY_UART2_SKIP) {
458 		if (uid == 1)
459 			return -ENODEV; /* Create tty cdev instead of serdev */
460 
461 		if (uid == 2)
462 			*skip = true;
463 	}
464 
465 	return 0;
466 }
467 
468 bool acpi_quirk_skip_gpio_event_handlers(void)
469 {
470 	const struct dmi_system_id *dmi_id;
471 	long quirks;
472 
473 	dmi_id = dmi_first_match(acpi_quirk_skip_dmi_ids);
474 	if (!dmi_id)
475 		return false;
476 
477 	quirks = (unsigned long)dmi_id->driver_data;
478 	return (quirks & ACPI_QUIRK_SKIP_GPIO_EVENT_HANDLERS);
479 }
480 EXPORT_SYMBOL_GPL(acpi_quirk_skip_gpio_event_handlers);
481 #else
482 static int acpi_dmi_skip_serdev_enumeration(struct device *controller_parent, bool *skip)
483 {
484 	return 0;
485 }
486 #endif
487 
488 int acpi_quirk_skip_serdev_enumeration(struct device *controller_parent, bool *skip)
489 {
490 	*skip = false;
491 
492 	return acpi_dmi_skip_serdev_enumeration(controller_parent, skip);
493 }
494 EXPORT_SYMBOL_GPL(acpi_quirk_skip_serdev_enumeration);
495 
496 /* Lists of PMIC ACPI HIDs with an (often better) native charger driver */
497 static const struct {
498 	const char *hid;
499 	int hrv;
500 } acpi_skip_ac_and_battery_pmic_ids[] = {
501 	{ "INT33F4", -1 }, /* X-Powers AXP288 PMIC */
502 	{ "INT34D3",  3 }, /* Intel Cherrytrail Whiskey Cove PMIC */
503 };
504 
505 bool acpi_quirk_skip_acpi_ac_and_battery(void)
506 {
507 	const struct dmi_system_id *dmi_id;
508 	long quirks = 0;
509 	int i;
510 
511 	dmi_id = dmi_first_match(acpi_quirk_skip_dmi_ids);
512 	if (dmi_id)
513 		quirks = (unsigned long)dmi_id->driver_data;
514 
515 	if (quirks & ACPI_QUIRK_SKIP_ACPI_AC_AND_BATTERY)
516 		return true;
517 
518 	if (quirks & ACPI_QUIRK_USE_ACPI_AC_AND_BATTERY)
519 		return false;
520 
521 	for (i = 0; i < ARRAY_SIZE(acpi_skip_ac_and_battery_pmic_ids); i++) {
522 		if (acpi_dev_present(acpi_skip_ac_and_battery_pmic_ids[i].hid, "1",
523 				     acpi_skip_ac_and_battery_pmic_ids[i].hrv)) {
524 			pr_info_once("found native %s PMIC, skipping ACPI AC and battery devices\n",
525 				     acpi_skip_ac_and_battery_pmic_ids[i].hid);
526 			return true;
527 		}
528 	}
529 
530 	return false;
531 }
532 EXPORT_SYMBOL_GPL(acpi_quirk_skip_acpi_ac_and_battery);
533 
534 /* This section provides a workaround for a specific x86 system
535  * which requires disabling of mwait to work correctly.
536  */
537 static int __init acpi_proc_quirk_set_no_mwait(const struct dmi_system_id *id)
538 {
539 	pr_notice("%s detected - disabling mwait for CPU C-states\n",
540 		  id->ident);
541 	boot_option_idle_override = IDLE_NOMWAIT;
542 	return 0;
543 }
544 
545 static const struct dmi_system_id acpi_proc_quirk_mwait_dmi_table[] __initconst = {
546 	{
547 		.callback = acpi_proc_quirk_set_no_mwait,
548 		.ident = "Extensa 5220",
549 		.matches =  {
550 			DMI_MATCH(DMI_BIOS_VENDOR, "Phoenix Technologies LTD"),
551 			DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
552 			DMI_MATCH(DMI_PRODUCT_VERSION, "0100"),
553 			DMI_MATCH(DMI_BOARD_NAME, "Columbia"),
554 		},
555 		.driver_data = NULL,
556 	},
557 	{}
558 };
559 
560 void __init acpi_proc_quirk_mwait_check(void)
561 {
562 	/*
563 	 * Check whether the system is DMI table. If yes, OSPM
564 	 * should not use mwait for CPU-states.
565 	 */
566 	dmi_check_system(acpi_proc_quirk_mwait_dmi_table);
567 }
568