1# Changelog 2 3All notable changes to this project will be documented in this file. 4 5The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), 6and this project adheres to 7[Semantic Versioning](https://semver.org/spec/v2.0.0.html). 8 9Change categories: 10 11- Added 12- Changed 13- Deprecated 14- Removed 15- Fixed 16- Security 17 18## [Unreleased] 19 20### Added 21 221. oem: meta: Add decode_oem_meta_file_io_write_req() 232. oem: meta: Add decode_oem_meta_file_io_read_req() 243. oem: meta: Add encode_oem_meta_file_io_read_resp() 254. pdr: Add pldm_entity_association_pdr_remove_contained_entity() 265. pdr: Add pldm_pdr_remove_fru_record_set_by_rsi() 276. pldm_entity_association_tree_copy_root_check() 28 29### Changed 30 311. dsp: bios_table: Null check for pldm_bios_table_iter_is_end() 32 33 pldm_bios_table_iter_is_end() now returns true if the provided argument is 34 NULL. 35 362. ABI break for pldm_pdr_find_record() 37 38 Register assignment for function parameters was changed with the removal of 39 some asserts in related implementations. 40 413. ABI break for pldm_pdr_get_next_record() 42 43 Register assignment for function parameters was changed with the removal of 44 some asserts in related implementations. 45 46### Deprecated 47 481. oem: meta: Deprecate `decode_oem_meta_file_io_req()` 49 50 Users should switch to `decode_oem_meta_file_io_write_req()`. Modify this 51 function to make it safer. 52 53 Modification: 54 55 - The meaning of the returned result. 56 - Change parameters from individual pointers to a struct. 57 - Check the length provided in the message won't exceed the buffer. 58 592. pldm_entity_association_tree_copy_root() 60 61 The implementation allocates, but gives no indication to the caller if an 62 allocation (and hence the copy) has failed. Users should migrate to 63 pldm_entity_association_tree_copy_root_check(). 64 65### Removed 66 671. Deprecated functions with the `_check` suffix 68 69 - `get_fru_record_by_option_check()` 70 - `pldm_bios_table_append_pad_checksum_check()` 71 - `pldm_bios_table_attr_entry_enum_decode_def_num_check()` 72 - `pldm_bios_table_attr_entry_enum_decode_pv_hdls_check()` 73 - `pldm_bios_table_attr_entry_enum_decode_pv_num_check()` 74 - `pldm_bios_table_attr_entry_enum_encode_check()` 75 - `pldm_bios_table_attr_entry_integer_encode_check()` 76 - `pldm_bios_table_attr_entry_string_decode_def_string_length_check()` 77 - `pldm_bios_table_attr_entry_string_encode_check()` 78 - `pldm_bios_table_attr_value_entry_encode_enum_check()` 79 - `pldm_bios_table_attr_value_entry_encode_integer_check()` 80 - `pldm_bios_table_attr_value_entry_encode_string_check()` 81 - `pldm_bios_table_string_entry_decode_string_check()` 82 - `pldm_bios_table_string_entry_encode_check()` 83 - `pldm_entity_association_pdr_add_check()` 84 - `pldm_entity_association_pdr_add_from_node_check()` 85 - `pldm_pdr_add_check()` 86 - `pldm_pdr_add_fru_record_set_check()` 87 88### Fixed 89 901. dsp: bios_table: Null check for pldm_bios_table_iter_is_end() 91 92 Avoid a caller-controlled NULL pointer dereference in the library 93 implementation. 94 95## [0.9.1] - 2024-09-07 96 97### Changed 98 991. Moved evolutions intended for v0.9.0 into place 100 101 Evolutions for the release have been moved from `evolutions/current` to 102 `evolutions/v0.9.1`. Library users can apply them to migrate off of 103 deprecated APIs. 104 105## [0.9.0] - 2024-09-07 106 107### Added 108 1091. base: Define macros for reserved TIDs 1102. pdr: Add pldm_entity_association_pdr_add_contained_entity_to_remote_pdr() 1113. pdr: Add pldm_entity_association_pdr_create_new() 1124. platform: Define macros for the responded transferflags 1135. pdr: Add pldm_pdr_get_terminus_handle() API 1146. pdr: Add related decode_entity_auxiliary_names_pdr() APIs 1157. fw_update: Add encode req & decode resp for get_downstream_fw_params 1168. platform: Add decode_pldm_platform_cper_event() API 1179. decode_get_pdr_repository_info_resp_safe() 118 119 Replaces decode_get_pdr_repository_info_resp() as discussed in the 120 `Deprecated` section below 121 12210. decode_get_pdr_resp_safe() 123 124 Replaces decode_get_pdr_resp() as discussed in the `Deprecated` section 125 below 126 127### Changed 128 1291. pdr: Stabilise related decode_entity_auxiliary_names_pdr() APIs 1302. platform: Rework decode/encode_pldm_message_poll_event_data() APIs 1313. platform: Stabilise decode_pldm_message_poll_event_data() APIs 1324. ABI break for decode_sensor_op_data() 133 134 Applying LIBPLDM_CC_NONNULL to the internal msgbuf APIs caused 135 abi-compliance-checker to flag a change in the register containing the 136 parameter `previous_op_state`. 137 1385. platform: Stabilise decode_pldm_platform_cper_event() API 1396. oem: meta: Stabilise decode_oem_meta_file_io_write_req() API 1407. oem: meta: Stabilise decode_oem_meta_file_io_read_req() API 1418. oem: meta: Stabilise encode_oem_meta_file_io_read_resp() API 142 143### Deprecated 144 1451. Rename and deprecate functions with the `_check` suffix 146 147 All library function return values always need to be checked. The `_check` 148 suffix is redundant, so remove it. Migration to the non-deprecated 149 equivalents without the `_check` suffix can be performed using 150 `scripts/ apply-renames` and the [clang-rename][] configurations under 151 `evolutions/` 152 153 The deprecated functions: 154 155 - `get_fru_record_by_option_check()` 156 - `pldm_bios_table_append_pad_checksum_check()` 157 - `pldm_bios_table_attr_entry_enum_decode_def_num_check()` 158 - `pldm_bios_table_attr_entry_enum_decode_pv_hdls_check()` 159 - `pldm_bios_table_attr_entry_enum_decode_pv_num_check()` 160 - `pldm_bios_table_attr_entry_enum_encode_check()` 161 - `pldm_bios_table_attr_entry_integer_encode_check()` 162 - `pldm_bios_table_attr_entry_string_decode_def_string_length_check()` 163 - `pldm_bios_table_attr_entry_string_encode_check()` 164 - `pldm_bios_table_attr_value_entry_encode_enum_check()` 165 - `pldm_bios_table_attr_value_entry_encode_integer_check()` 166 - `pldm_bios_table_attr_value_entry_encode_string_check()` 167 - `pldm_bios_table_string_entry_decode_string_check()` 168 - `pldm_bios_table_string_entry_encode_check()` 169 - `pldm_entity_association_pdr_add_check()` 170 - `pldm_entity_association_pdr_add_from_node_check()` 171 - `pldm_pdr_add_check()` 172 - `pldm_pdr_add_fru_record_set_check()` 173 174[clang-rename]: https://clang.llvm.org/extra/clang-rename.html 175 1762. `decode_get_pdr_repository_info_resp()` 177 178 Users should move to `decode_get_pdr_repository_info_resp_safe()` which 179 eliminates the opportunity for buffer overruns when extracting objects from 180 the message. 181 1823. `decode_get_pdr_resp()` 183 184 Users should move to `decode_get_pdr_resp_safe()` which reduces the 185 invocation tedium and improves memory safety over `decode_get_pdr_resp()`. 186 187### Removed 188 1891. IBM OEM header compatibility symlinks. 190 191 Anyone left using the deprecated paths can migrate using the coccinelle patch 192 at `evolutions/current/oem-ibm-header-compat.cocci`. 193 194### Fixed 195 1961. requester: instance-id: Release read lock on conflict 197 198## [0.8.0] - 2024-05-23 199 200### Added 201 2021. base: Provide pldm_msg_hdr_correlate_response() 2032. transport: af-mctp: Add pldm_transport_af_mctp_bind() 2043. oem: ibm: Add chapdata file type support 2054. base: Added PLDM_SMBIOS & PLDM_RDE message types 2065. oem: meta: Add decode_oem_meta_file_io_req() 2076. state-set: Add all state set values to system power state enum as per DSP0249 2087. platform: Add alias members to the enum 209 pldm_pdr_repository_chg_event_change_record_event_data_operation. 210 211 enum constants with inconsistent names are deprecated with this change. 212 remove old inconsistent enum members after backward compatibility cleanup is 213 done 214 2158. oem-ibm: Alias `pldm_oem_ibm_fru_field_type` members as `PLDM_OEM_IBM_*` 2169. oem: ibm: Add Firmware Update Access Key(UAK) as a FRU field type 21710. platform: Add 3 PDR type enum for Redfish Device Enablement per 218 DSP0248_1.2.0 21911. state_set: Add CONNECTED and DISCONNECTED enum for Link State set 22012. entity: Add enum for Network Interface Connectors and Network Ports 221 Connection Types 22213. pdr: Add decode_numeric_effecter_pdr_data() 22314. oem: ibm: Support for the Real SAI entity id 22415. fw_update: Add encode req & decode resp for query_downstream_devices 22516. fw_update: Add encode req & decode resp for query_downstream_identifiers 22617. platform: Add support for GetStateEffecterStates command 227 228### Changed 229 2301. base: Stabilise pldm_msg_hdr_correlate_response() 2312. transport: af-mctp: Stabilise pldm_transport_af_mctp_bind() 2323. libpldm: Fix header use 2334. libpldm: More fixes for header use 2345. pdr: Stabilise pldm_pdr_find_last_in_range() API 2356. pdr: Stabilise pldm_entity_association_pdr_add_from_node_with_record_handle() 2367. oem: meta: stabilise decode_oem_meta_file_io_req() 2378. pdr: pldm_entity_association_tree_copy_root(): Document preconditions 238 239### Deprecated 240 2411. Deprecate `pldm_oem_ibm_fru_field_type` members that that are not prefixed 242 with `PLDM_OEM_IBM_` 243 244### Fixed 245 2461. libpldm: Rationalise the local and installed path of pldm.h 2472. pdr: Assign record_handle in entity_association_pdr_add_children() 2483. msgbuf: Require sensor data enum in pldm_msgbuf_extract_sensor_value() 2494. pdr: Remove redundant constant for minimum numeric sensor PDR length 2505. tests: oem: meta: Fix fileio use of msgbuf 251 252## [0.7.0] - 2023-08-29 253 254### Added 255 2561. state-set: Add new enum for Operational Fault Status enum 257 258### Changed 259 2601. transport: Match specified metadata in pldm_transport_send_recv_msg() 2612. transport: mctp-demux: Drop ABI annotation for internal symbols 2623. transport: Stabilise core transport and implementation APIs 263 264 This stabilisation covers the following headers and functions: 265 266 - libpldm/transport.h 267 268 - pldm_transport_poll() 269 - pldm_transport_send_msg() 270 - pldm_transport_recv_msg() 271 - pldm_transport_send_recv_msg() 272 273 - libpldm/transport/af-mctp.h 274 275 - pldm_transport_af_mctp_init() 276 - pldm_transport_af_mctp_destroy() 277 - pldm_transport_af_mctp_core() 278 - pldm_transport_af_mctp_init_pollfd() 279 - pldm_transport_af_mctp_map_tid() 280 - pldm_transport_af_mctp_unmap_tid() 281 282 - libpldm/transport/mctp-demux.h 283 - pldm_transport_mctp_demux_init() 284 - pldm_transport_mctp_demux_destroy() 285 - pldm_transport_mctp_demux_core() 286 - pldm_transport_mctp_demux_init_pollfd() 287 - pldm_transport_mctp_demux_map_tid() 288 - pldm_transport_mctp_demux_unmap_tid() 289 290### Deprecated 291 2921. All the existing "requester" APIs from `libpldm/pldm.h` (also known as 293 `libpldm/requester/pldm.h`): 294 295 - pldm_open() 296 - pldm_send_recv() 297 - pldm_send() 298 - pldm_recv() 299 - pldm_recv_any() 300 - pldm_close() 301 302 Users should migrate to the newer "transport" APIs instead. 303 304## Fixed 305 3061. tests: Exclude transport tests when build excludes testing ABIs 3072. abi: Capture deprecation of pldm_close() 308 309## [0.6.0] - 2023-08-22 310 311### Changed 312 3131. pdr: Avoid ID overflow in pldm_entity_association_tree_add_entity() 3142. meson: Apply `b_ndebug=if-release` by default 3153. pdr : Stabilize pldm_entity_association_tree_add_entity() 3164. pdr: Stabilise pldm_entity_association_tree_find_with_locality() 3175. pdr: Stabilize pldm_entity_node_get_remote_container_id() 3186. transport: af-mctp: Assign out-params on success in \*\_recv() 3197. transport: Generalise the pldm_transport_recv_msg() API 320 321### Removed 322 3231. pdr: Remove pldm_entity_association_pdr_add() 3242. state-set: Remove enum pldm_state_set_operational_fault_status_values 325 326### Fixed 327 3281. transport: register init_pollfd callback for af-mctp 3292. transport: fix init_pollfd function parameter 3303. transport: Fix doxygen and variables for send and recv functions 3314. transport: af-mctp: Ensure malloc() succeeds in \*\_recv() 332 333## [0.5.0] - 2023-08-09 334 335### Added 336 3371. pdr: Introduce pldm_entity_association_pdr_add_check() 338 339### Changed 340 3411. pdr: Allow record_handle to be NULL for pldm_pdr_add_check() 3422. transport: pldm_transport_poll(): Adjust return value semantics 3433. transport: free un-wanted responses in pldm_transport_send_recv_msg() 344 345### Deprecated 346 3471. state-set: Enum pldm_state_set_operational_fault_status_values 348 349 The enum operational_fault_status is defined with wrong members and will 350 eventually be replaced with the correct members. Any uses of 351 pldm_state_set_operational_fault_status_values members should move to 352 equivalent pldm_state_set_operational_stress_status_values members if needed. 353 3542. platform: Struct field name in fru_record_set PDR 355 356 References to entity_instance_num should be changed to entity_instance 357 3583. platform: Struct field name in numeric sensor value PDR 359 360 References to entity_instance_num should be changed to entity_instance 361 362### Removed 363 3641. bios_table: Remove pldm_bios_table_attr_entry_integer_encode_length() 3652. bios_table: Remove pldm_bios_table_attr_value_entry_encode_enum() 3663. bios_table: Remove pldm_bios_table_attr_value_entry_encode_string() 3674. bios_table: Remove pldm_bios_table_attr_value_entry_encode_integer() 3685. bios_table: Remove pldm_bios_table_append_pad_checksum() 3696. fru: Remove get_fru_record_by_option() 3707. pdr: Make is_present() static 3718. pdr: Remove pldm_pdr_add() 3729. pdr: Remove pldm_pdr_add_fru_record_set() 37310. pdr: Remove pldm_entity_association_pdr_add_from_node() 37411. pdr: Make find_entity_ref_in_tree() static 37512. pdr: Make entity_association_tree_find() static 376 377### Fixed 378 3791. requester: Fix response buffer cast in pldm_send_recv() 3802. pdr: Hoist record handle overflow test to avoid memory leak 3813. transport: Correct comparison in while loop condition 382 383## [0.4.0] - 2023-07-14 384 385### Added 386 3871. bios_table: Introduce pldm_bios_table_append_pad_checksum_check() 3882. fru: Introduce get_fru_record_by_option_check() 3893. pdr: Introduce pldm_entity_association_pdr_add_from_node_check() 3904. pdr: Introduce pldm_pdr_add_check() 3915. pdr: Introduce pldm_pdr_add_fru_record_set_check() 392 393### Changed 394 3951. requester: Mark pldm_close() as LIBPLDM_ABI_TESTING 3962. requester: Expose pldm_close() in header 3973. bios_table: pldm_bios_table_string_entry_encode_check(): Handle overflow 3984. bios_table: pldm_bios_table_iter_create(): Return NULL on failed alloc 3995. bios_table: pldm_bios_table_iter_next(): Invalid entry halts iteration 4006. pdr: pldm_pdr_init(): Return NULL on allocation failure 4017. pdr: pldm_pdr_destroy(): Exit early if repo is NULL 4028. pdr: Document preconditions for trivial accessor functions 403 404 A trivial accessor function is one that exposes properties of an object in a 405 way can't result in an error, beyond passing an invalid argument to the 406 function. For APIs meeting this definition we define a precondition that 407 struct pointers must point to valid objects to avoid polluting the function 408 prototypes. The following APIs now have this precondition explicitly defined: 409 410 - pldm_entity_extract() 411 - pldm_entity_get_parent() 412 - pldm_entity_is_exist_parent() 413 - pldm_entity_is_node_parent() 414 - pldm_is_current_parent_child 415 - pldm_is_empty_entity_assoc_tree() 416 - pldm_pdr_get_record_count() 417 - pldm_pdr_get_record_handle() 418 - pldm_pdr_get_repo_size() 419 - pldm_pdr_record_is_remote() 420 4219. pdr: pldm_entity_node_get_remote_container_id() is a trivial accessor 42210. pdr: pldm_pdr_fru_record_set_find_by_rsi(): Exit early on NULL arguments 42311. pdr: pldm_entity_association_tree_init(): Return NULL on failed alloc 42412. pdr: pldm_entity_association_tree_visit(): Document preconditions 42513. pdr: pldm_entity_association_tree_visit(): Exit early on failure 42614. pdr: pldm_entity_association_tree_destroy(): Exit early on bad argument 42715. pdr: pldm_entity_get_num_children(): Return zero for invalid arguments 42816. pdr: pldm_is_current_parent_child(): Return false for invalid arguments 42917. pdr: pldm_entity_association_pdr_add(): Exit early on bad arguments 43018. pdr: pldm_find_entity_ref_in_tree(): Exit early on bad arguments 43119. pdr: pldm_entity_association_tree_find(): Early exit on bad arguments 43220. pdr: pldm_entity_association_tree_destroy_root(): Exit early on bad arg 43321. pdr: pldm_entity_association_pdr_extract(): Early exit on bad arguments 43422. pdr: pldm_entity_association_pdr_extract(): Assign out params at exit 43523. pdr: pldm_entity_get_num_children(): Don't return invalid values 43624. libpldm: Lift or remove asserts where a subsequent check exists 437 438### Deprecated 439 4401. pldm_bios_table_attr_entry_integer_encode() 441 442 Migrate to pldm_bios_table_attr_entry_integer_encode_check() 443 4442. bios_table: Deprecate pldm_bios_table_attr_value_entry_encode_enum() 445 446 Migrate to pldm_bios_table_attr_value_entry_encode_enum_check() 447 4483. bios_table: Deprecate pldm_bios_table_attr_value_entry_encode_string() 449 450 Migrate to pldm_bios_table_attr_value_entry_encode_string_check() 451 4524. bios_table: Deprecate pldm_bios_table_attr_value_entry_encode_integer() 453 454 Migrate to pldm_bios_table_attr_value_entry_encode_integer_check() 455 4565. pdr: Deprecate is_present() 457 458 There should be no users of this symbol. If you are a user, you should figure 459 out how to stop, or get in touch. This symbol will be marked static the 460 release after deprecation. 461 4626. pdr: Deprecate find_entity_ref_in_tree() 463 464 There should be no users of this symbol. If you are a user, you should figure 465 out how to stop, or get in touch. This symbol will be marked static the 466 release after deprecation. 467 4687. pdr: Deprecate entity_association_tree_find() 469 470 There should be no users of this symbol. If you are a user, you should figure 471 out how to stop, or get in touch. This symbol will be marked static the 472 release after deprecation. 473 4748. bios_table: Stabilise pldm_bios_table_append_pad_checksum_check() 475 476 pldm_bios_table_append_pad_checksum() is deprecated by this change. Users of 477 pldm_bios_table_append_pad_checksum() should migrate to 478 pldm_bios_table_append_pad_checksum_check() 479 4809. fru: Stabilise get_fru_record_by_option_check() 481 482 get_fru_record_by_option() is deprecated by this change. Users of 483 get_fru_record_by_option() should migrate to get_fru_record_by_option_check() 484 48510. pdr: Stabilise pldm_entity_association_pdr_add_from_node_check() 486 487 pldm_entity_association_pdr_add_from_node() is deprecated by this change. 488 Users of pldm_entity_association_pdr_add_from_node() should migrate to 489 pldm_entity_association_pdr_add_from_node_check() 490 49111. pdr: Stabilise pldm_pdr_add_check() 492 493 pldm_pdr_add() is deprecated by this change. Users of pldm_pdr_add() should 494 migrate to pldm_pdr_add_check() 495 49612. pdr: Stabilise pldm_pdr_add_fru_record_set_check() 497 498 pldm_pdr_add_fru_record_set() is deprecated by this change. Users of 499 pldm_pdr_add_fru_record_set() should migrate to 500 pldm_pdr_add_fru_record_set_check() 501 502### Removed 503 5041. bios_table: Remove deprecated APIs sanitized by assert(): 505 506 - pldm_bios_table_string_entry_encode() 507 - pldm_bios_table_string_entry_decode_string() 508 - pldm_bios_table_attr_entry_enum_encode() 509 - pldm_bios_table_attr_entry_enum_decode_pv_num() 510 - pldm_bios_table_attr_entry_enum_decode_def_num() 511 - pldm_bios_table_attr_entry_enum_decode_pv_hdls() 512 - pldm_bios_table_attr_entry_string_encode() 513 - pldm_bios_table_attr_entry_string_decode_def_string_length() 514 515### Fixed 516 5171. pdr: Return success for pldm_pdr_find_child_container_id_range_exclude() API 5182. pdr: Rework pldm_pdr_find_container_id_range_exclude() API 5193. transport: mctp-demux: Don't test socket for non-zero value 5204. requester: Return PLDM_REQUESTER_OPEN_FAIL from pldm_open() on error 5215. pdr: pldm_pdr_fru_record_set_find_by_rsi(): Document reality of return 5226. transport: Fix possible NULL ptr deref in pldm_socket_sndbuf_init() 5237. abi: Update to remove pldm_close() from reference dumps 5248. bios_table: Annotate pldm_bios_table_attr_value_entry_encode_integer() 525 526## [0.3.0] - 2023-06-23 527 528### Added 529 5301. Add encode/decode pldmMessagePollEvent data 5312. README: Add a section on working with libpldm 5323. pdr: Introduce remote_container_id and associated APIs 5334. pdr: Add APIs for creating and locating remote PDRs 5345. pdr: Add pldm_pdr_find_last_in_range() 5356. pdr: Add pldm_entity_association_pdr_add_from_node_with_record_handle() 5367. pdr: Add pldm_pdr_find_container_id_range_exclude() 537 538### Changed 539 5401. include: Move installed transport.h under libpldm/ 5412. libpldm: Explicit deprecated, stable and testing ABI classes 5423. meson: Reduce strength of oem-ibm requirements from enabled to allowed 543 544 The `oem-ibm` feature is now enabled by the default meson configuration, for 545 CI purposes. `oem-ibm` is still disabled by default in the `libpldm` bitbake 546 recipe: 547 548 <https://github.com/openbmc/openbmc/blob/master/meta-phosphor/recipes-phosphor/libpldm/libpldm_git.bb#L10> 549 550 To disable `oem-ibm` in your development builds, pass `-Doem-ibm=disabled` 551 when invoking `meson setup` 552 5534. bios_table: Relax pldm_bios_table_string_entry_decode_string_check() 5545. bios_table: Relax pldm_bios_table_attr_entry_enum_decode_pv_hdls_check() 555 556### Deprecated 557 5581. bios_table: Deprecate APIs with arguments sanitized using assert() 559 560 C provides enough foot-guns without us encoding them into library APIs. 561 Specifically, deprecate the following in favour of their `*_check()` variants 562 which ensure assertions won't fail or otherwise invoke UB: 563 564 - pldm_bios_table_string_entry_encode() 565 - pldm_bios_table_string_entry_decode_string() 566 - pldm_bios_table_attr_entry_enum_encode() 567 - pldm_bios_table_attr_entry_enum_decode_pv_num() 568 - pldm_bios_table_attr_entry_enum_decode_def_num() 569 - pldm_bios_table_attr_entry_enum_decode_pv_hdls() 570 - pldm_bios_table_attr_entry_string_encode() 571 - pldm_bios_table_attr_entry_string_decode_def_string_length() 572 573### Removed 574 5751. libpldm: Remove the requester-api option 576 577### Fixed 578 5791. requester: Make pldm_open() return existing fd 5802. transport: Prevent sticking in waiting for response 5813. transport: Match on response in pldm_transport_send_recv_msg() 5824. requester: Add check before accessing hdr in pldm_recv() 5835. bios_table: pldm_bios_table_attr_entry_string_info_check() NULL deref 584