xref: /openbmc/bmcweb/features/redfish/include/utils/sw_utils.hpp (revision eddfc437edfc871b469199552bdeb0d65ee2dcf3)
1eee0013eSWilly Tu #pragma once
23ccb3adbSEd Tanous #include "async_resp.hpp"
33ccb3adbSEd Tanous #include "dbus_utility.hpp"
43ccb3adbSEd Tanous #include "error_messages.hpp"
53ccb3adbSEd Tanous #include "generated/enums/resource.hpp"
6*eddfc437SWilly Tu #include "http/utility.hpp"
73ccb3adbSEd Tanous #include "utils/dbus_utils.hpp"
83ccb3adbSEd Tanous 
9e99073f5SGeorge Liu #include <boost/system/error_code.hpp>
10eee0013eSWilly Tu #include <sdbusplus/asio/property.hpp>
11d1bde9e5SKrzysztof Grobelny #include <sdbusplus/unpack_properties.hpp>
12eee0013eSWilly Tu 
13eee0013eSWilly Tu #include <algorithm>
14e99073f5SGeorge Liu #include <array>
15eee0013eSWilly Tu #include <string>
16e99073f5SGeorge Liu #include <string_view>
17eee0013eSWilly Tu #include <vector>
18eee0013eSWilly Tu 
19eee0013eSWilly Tu namespace redfish
20eee0013eSWilly Tu {
21eee0013eSWilly Tu namespace sw_util
22eee0013eSWilly Tu {
23eee0013eSWilly Tu /* @brief String that indicates a bios software instance */
24eee0013eSWilly Tu constexpr const char* biosPurpose =
25eee0013eSWilly Tu     "xyz.openbmc_project.Software.Version.VersionPurpose.Host";
26eee0013eSWilly Tu 
27eee0013eSWilly Tu /* @brief String that indicates a BMC software instance */
28eee0013eSWilly Tu constexpr const char* bmcPurpose =
29eee0013eSWilly Tu     "xyz.openbmc_project.Software.Version.VersionPurpose.BMC";
30eee0013eSWilly Tu 
31eee0013eSWilly Tu /**
32eee0013eSWilly Tu  * @brief Populate the running software version and image links
33eee0013eSWilly Tu  *
34eee0013eSWilly Tu  * @param[i,o] aResp             Async response object
35eee0013eSWilly Tu  * @param[i]   swVersionPurpose  Indicates what target to look for
36eee0013eSWilly Tu  * @param[i]   activeVersionPropName  Index in aResp->res.jsonValue to write
37eee0013eSWilly Tu  * the running software version to
38eee0013eSWilly Tu  * @param[i]   populateLinkToImages  Populate aResp->res "Links"
39eee0013eSWilly Tu  * "ActiveSoftwareImage" with a link to the running software image and
40eee0013eSWilly Tu  * "SoftwareImages" with a link to the all its software images
41eee0013eSWilly Tu  *
42eee0013eSWilly Tu  * @return void
43eee0013eSWilly Tu  */
44eee0013eSWilly Tu inline void
45eee0013eSWilly Tu     populateSoftwareInformation(const std::shared_ptr<bmcweb::AsyncResp>& aResp,
46eee0013eSWilly Tu                                 const std::string& swVersionPurpose,
47eee0013eSWilly Tu                                 const std::string& activeVersionPropName,
48eee0013eSWilly Tu                                 const bool populateLinkToImages)
49eee0013eSWilly Tu {
50eee0013eSWilly Tu     // Used later to determine running (known on Redfish as active) Sw images
51c6830d5fSGunnar Mills     sdbusplus::asio::getProperty<std::vector<std::string>>(
52c6830d5fSGunnar Mills         *crow::connections::systemBus, "xyz.openbmc_project.ObjectMapper",
53eee0013eSWilly Tu         "/xyz/openbmc_project/software/functional",
54c6830d5fSGunnar Mills         "xyz.openbmc_project.Association", "endpoints",
55c6830d5fSGunnar Mills         [aResp, swVersionPurpose, activeVersionPropName,
56c6830d5fSGunnar Mills          populateLinkToImages](const boost::system::error_code ec,
57c6830d5fSGunnar Mills                                const std::vector<std::string>& functionalSw) {
58eee0013eSWilly Tu         BMCWEB_LOG_DEBUG << "populateSoftwareInformation enter";
59eee0013eSWilly Tu         if (ec)
60eee0013eSWilly Tu         {
61eee0013eSWilly Tu             BMCWEB_LOG_ERROR << "error_code = " << ec;
62eee0013eSWilly Tu             BMCWEB_LOG_ERROR << "error msg = " << ec.message();
63eee0013eSWilly Tu             messages::internalError(aResp->res);
64eee0013eSWilly Tu             return;
65eee0013eSWilly Tu         }
66eee0013eSWilly Tu 
67eee0013eSWilly Tu         if (functionalSw.empty())
68eee0013eSWilly Tu         {
69eee0013eSWilly Tu             // Could keep going and try to populate SoftwareImages but
70eee0013eSWilly Tu             // something is seriously wrong, so just fail
71eee0013eSWilly Tu             BMCWEB_LOG_ERROR << "Zero functional software in system";
72eee0013eSWilly Tu             messages::internalError(aResp->res);
73eee0013eSWilly Tu             return;
74eee0013eSWilly Tu         }
75eee0013eSWilly Tu 
76eee0013eSWilly Tu         std::vector<std::string> functionalSwIds;
77eee0013eSWilly Tu         // example functionalSw:
78eee0013eSWilly Tu         // v as 2 "/xyz/openbmc_project/software/ace821ef"
79eee0013eSWilly Tu         //        "/xyz/openbmc_project/software/230fb078"
80c6830d5fSGunnar Mills         for (const auto& sw : functionalSw)
81eee0013eSWilly Tu         {
82c6830d5fSGunnar Mills             sdbusplus::message::object_path path(sw);
83eee0013eSWilly Tu             std::string leaf = path.filename();
84eee0013eSWilly Tu             if (leaf.empty())
85eee0013eSWilly Tu             {
86eee0013eSWilly Tu                 continue;
87eee0013eSWilly Tu             }
88eee0013eSWilly Tu 
89eee0013eSWilly Tu             functionalSwIds.push_back(leaf);
90eee0013eSWilly Tu         }
91eee0013eSWilly Tu 
92e99073f5SGeorge Liu         constexpr std::array<std::string_view, 1> interfaces = {
93e99073f5SGeorge Liu             "xyz.openbmc_project.Software.Version"};
94e99073f5SGeorge Liu         dbus::utility::getSubTree(
95e99073f5SGeorge Liu             "/xyz/openbmc_project/software", 0, interfaces,
96eee0013eSWilly Tu             [aResp, swVersionPurpose, activeVersionPropName,
97eee0013eSWilly Tu              populateLinkToImages, functionalSwIds](
98e99073f5SGeorge Liu                 const boost::system::error_code& ec2,
99eee0013eSWilly Tu                 const dbus::utility::MapperGetSubTreeResponse& subtree) {
100eee0013eSWilly Tu             if (ec2)
101eee0013eSWilly Tu             {
102eee0013eSWilly Tu                 BMCWEB_LOG_ERROR << "error_code = " << ec2;
103eee0013eSWilly Tu                 BMCWEB_LOG_ERROR << "error msg = " << ec2.message();
104eee0013eSWilly Tu                 messages::internalError(aResp->res);
105eee0013eSWilly Tu                 return;
106eee0013eSWilly Tu             }
107eee0013eSWilly Tu 
108eee0013eSWilly Tu             BMCWEB_LOG_DEBUG << "Found " << subtree.size() << " images";
109eee0013eSWilly Tu 
110eee0013eSWilly Tu             for (const std::pair<std::string,
111eee0013eSWilly Tu                                  std::vector<std::pair<
112eee0013eSWilly Tu                                      std::string, std::vector<std::string>>>>&
113eee0013eSWilly Tu                      obj : subtree)
114eee0013eSWilly Tu             {
115eee0013eSWilly Tu 
116eee0013eSWilly Tu                 sdbusplus::message::object_path path(obj.first);
117eee0013eSWilly Tu                 std::string swId = path.filename();
118eee0013eSWilly Tu                 if (swId.empty())
119eee0013eSWilly Tu                 {
120eee0013eSWilly Tu                     messages::internalError(aResp->res);
121eee0013eSWilly Tu                     BMCWEB_LOG_ERROR << "Invalid software ID";
122eee0013eSWilly Tu 
123eee0013eSWilly Tu                     return;
124eee0013eSWilly Tu                 }
125eee0013eSWilly Tu 
126eee0013eSWilly Tu                 bool runningImage = false;
127eee0013eSWilly Tu                 // Look at Ids from
128eee0013eSWilly Tu                 // /xyz/openbmc_project/software/functional
129eee0013eSWilly Tu                 // to determine if this is a running image
130eee0013eSWilly Tu                 if (std::find(functionalSwIds.begin(), functionalSwIds.end(),
131eee0013eSWilly Tu                               swId) != functionalSwIds.end())
132eee0013eSWilly Tu                 {
133eee0013eSWilly Tu                     runningImage = true;
134eee0013eSWilly Tu                 }
135eee0013eSWilly Tu 
136eee0013eSWilly Tu                 // Now grab its version info
137d1bde9e5SKrzysztof Grobelny                 sdbusplus::asio::getAllProperties(
138d1bde9e5SKrzysztof Grobelny                     *crow::connections::systemBus, obj.second[0].first,
139d1bde9e5SKrzysztof Grobelny                     obj.first, "xyz.openbmc_project.Software.Version",
140eee0013eSWilly Tu                     [aResp, swId, runningImage, swVersionPurpose,
141eee0013eSWilly Tu                      activeVersionPropName, populateLinkToImages](
142eee0013eSWilly Tu                         const boost::system::error_code ec3,
143eee0013eSWilly Tu                         const dbus::utility::DBusPropertiesMap&
144eee0013eSWilly Tu                             propertiesList) {
145eee0013eSWilly Tu                     if (ec3)
146eee0013eSWilly Tu                     {
147eee0013eSWilly Tu                         BMCWEB_LOG_ERROR << "error_code = " << ec3;
148eee0013eSWilly Tu                         BMCWEB_LOG_ERROR << "error msg = " << ec3.message();
149eee0013eSWilly Tu                         // Have seen the code update app delete the D-Bus
150eee0013eSWilly Tu                         // object, during code update, between the call to
151eee0013eSWilly Tu                         // mapper and here. Just leave these properties off if
152eee0013eSWilly Tu                         // resource not found.
153eee0013eSWilly Tu                         if (ec3.value() == EBADR)
154eee0013eSWilly Tu                         {
155eee0013eSWilly Tu                             return;
156eee0013eSWilly Tu                         }
157eee0013eSWilly Tu                         messages::internalError(aResp->res);
158eee0013eSWilly Tu                         return;
159eee0013eSWilly Tu                     }
160eee0013eSWilly Tu                     // example propertiesList
161eee0013eSWilly Tu                     // a{sv} 2 "Version" s
162eee0013eSWilly Tu                     // "IBM-witherspoon-OP9-v2.0.10-2.22" "Purpose"
163eee0013eSWilly Tu                     // s
164eee0013eSWilly Tu                     // "xyz.openbmc_project.Software.Version.VersionPurpose.Host"
165d1bde9e5SKrzysztof Grobelny                     const std::string* version = nullptr;
166d1bde9e5SKrzysztof Grobelny                     const std::string* swInvPurpose = nullptr;
167d1bde9e5SKrzysztof Grobelny 
168d1bde9e5SKrzysztof Grobelny                     const bool success = sdbusplus::unpackPropertiesNoThrow(
169d1bde9e5SKrzysztof Grobelny                         dbus_utils::UnpackErrorPrinter(), propertiesList,
170d1bde9e5SKrzysztof Grobelny                         "Purpose", swInvPurpose, "Version", version);
171d1bde9e5SKrzysztof Grobelny 
172d1bde9e5SKrzysztof Grobelny                     if (!success)
173eee0013eSWilly Tu                     {
174eee0013eSWilly Tu                         messages::internalError(aResp->res);
175eee0013eSWilly Tu                         return;
176eee0013eSWilly Tu                     }
177eee0013eSWilly Tu 
178d1bde9e5SKrzysztof Grobelny                     if (version == nullptr || version->empty())
179eee0013eSWilly Tu                     {
180eee0013eSWilly Tu                         messages::internalError(aResp->res);
181eee0013eSWilly Tu                         return;
182eee0013eSWilly Tu                     }
183d1bde9e5SKrzysztof Grobelny                     if (swInvPurpose == nullptr ||
184d1bde9e5SKrzysztof Grobelny                         *swInvPurpose != swVersionPurpose)
185eee0013eSWilly Tu                     {
186eee0013eSWilly Tu                         // Not purpose we're looking for
187eee0013eSWilly Tu                         return;
188eee0013eSWilly Tu                     }
189eee0013eSWilly Tu 
190d1bde9e5SKrzysztof Grobelny                     BMCWEB_LOG_DEBUG << "Image ID: " << swId;
191d1bde9e5SKrzysztof Grobelny                     BMCWEB_LOG_DEBUG << "Running image: " << runningImage;
192d1bde9e5SKrzysztof Grobelny                     BMCWEB_LOG_DEBUG << "Image purpose: " << *swInvPurpose;
193d1bde9e5SKrzysztof Grobelny 
194eee0013eSWilly Tu                     if (populateLinkToImages)
195eee0013eSWilly Tu                     {
196eee0013eSWilly Tu                         nlohmann::json& softwareImageMembers =
197eee0013eSWilly Tu                             aResp->res.jsonValue["Links"]["SoftwareImages"];
198eee0013eSWilly Tu                         // Firmware images are at
199eee0013eSWilly Tu                         // /redfish/v1/UpdateService/FirmwareInventory/<Id>
200eee0013eSWilly Tu                         // e.g. .../FirmwareInventory/82d3ec86
201613dabeaSEd Tanous                         nlohmann::json::object_t member;
202*eddfc437SWilly Tu                         member["@odata.id"] = crow::utility::urlFromPieces(
203*eddfc437SWilly Tu                             "redfish", "v1", "UpdateService",
204*eddfc437SWilly Tu                             "FirmwareInventory", swId);
205613dabeaSEd Tanous                         softwareImageMembers.push_back(std::move(member));
206eee0013eSWilly Tu                         aResp->res
207eee0013eSWilly Tu                             .jsonValue["Links"]["SoftwareImages@odata.count"] =
208eee0013eSWilly Tu                             softwareImageMembers.size();
209eee0013eSWilly Tu 
210eee0013eSWilly Tu                         if (runningImage)
211eee0013eSWilly Tu                         {
212613dabeaSEd Tanous                             nlohmann::json::object_t runningMember;
213613dabeaSEd Tanous                             runningMember["@odata.id"] =
214*eddfc437SWilly Tu                                 crow::utility::urlFromPieces(
215*eddfc437SWilly Tu                                     "redfish", "v1", "UpdateService",
216*eddfc437SWilly Tu                                     "FirmwareInventory", swId);
217eee0013eSWilly Tu                             // Create the link to the running image
218eee0013eSWilly Tu                             aResp->res
219613dabeaSEd Tanous                                 .jsonValue["Links"]["ActiveSoftwareImage"] =
220613dabeaSEd Tanous                                 std::move(runningMember);
221eee0013eSWilly Tu                         }
222eee0013eSWilly Tu                     }
223eee0013eSWilly Tu                     if (!activeVersionPropName.empty() && runningImage)
224eee0013eSWilly Tu                     {
225d1bde9e5SKrzysztof Grobelny                         aResp->res.jsonValue[activeVersionPropName] = *version;
226eee0013eSWilly Tu                     }
227d1bde9e5SKrzysztof Grobelny                     });
228eee0013eSWilly Tu             }
229e99073f5SGeorge Liu             });
230eee0013eSWilly Tu         });
231eee0013eSWilly Tu }
232eee0013eSWilly Tu 
233eee0013eSWilly Tu /**
234eee0013eSWilly Tu  * @brief Translate input swState to Redfish state
235eee0013eSWilly Tu  *
236eee0013eSWilly Tu  * This function will return the corresponding Redfish state
237eee0013eSWilly Tu  *
238eee0013eSWilly Tu  * @param[i]   swState  The OpenBMC software state
239eee0013eSWilly Tu  *
240eee0013eSWilly Tu  * @return The corresponding Redfish state
241eee0013eSWilly Tu  */
2420ec8b83dSEd Tanous inline resource::State getRedfishSwState(const std::string& swState)
243eee0013eSWilly Tu {
244eee0013eSWilly Tu     if (swState == "xyz.openbmc_project.Software.Activation.Activations.Active")
245eee0013eSWilly Tu     {
2460ec8b83dSEd Tanous         return resource::State::Enabled;
247eee0013eSWilly Tu     }
248eee0013eSWilly Tu     if (swState == "xyz.openbmc_project.Software.Activation."
249eee0013eSWilly Tu                    "Activations.Activating")
250eee0013eSWilly Tu     {
2510ec8b83dSEd Tanous         return resource::State::Updating;
252eee0013eSWilly Tu     }
253eee0013eSWilly Tu     if (swState == "xyz.openbmc_project.Software.Activation."
254eee0013eSWilly Tu                    "Activations.StandbySpare")
255eee0013eSWilly Tu     {
2560ec8b83dSEd Tanous         return resource::State::StandbySpare;
257eee0013eSWilly Tu     }
258eee0013eSWilly Tu     BMCWEB_LOG_DEBUG << "Default sw state " << swState << " to Disabled";
2590ec8b83dSEd Tanous     return resource::State::Disabled;
260eee0013eSWilly Tu }
261eee0013eSWilly Tu 
262eee0013eSWilly Tu /**
263eee0013eSWilly Tu  * @brief Translate input swState to Redfish health state
264eee0013eSWilly Tu  *
265eee0013eSWilly Tu  * This function will return the corresponding Redfish health state
266eee0013eSWilly Tu  *
267eee0013eSWilly Tu  * @param[i]   swState  The OpenBMC software state
268eee0013eSWilly Tu  *
269eee0013eSWilly Tu  * @return The corresponding Redfish health state
270eee0013eSWilly Tu  */
271eee0013eSWilly Tu inline std::string getRedfishSwHealth(const std::string& swState)
272eee0013eSWilly Tu {
273eee0013eSWilly Tu     if ((swState ==
274eee0013eSWilly Tu          "xyz.openbmc_project.Software.Activation.Activations.Active") ||
275eee0013eSWilly Tu         (swState == "xyz.openbmc_project.Software.Activation.Activations."
276eee0013eSWilly Tu                     "Activating") ||
277eee0013eSWilly Tu         (swState ==
278eee0013eSWilly Tu          "xyz.openbmc_project.Software.Activation.Activations.Ready"))
279eee0013eSWilly Tu     {
280eee0013eSWilly Tu         return "OK";
281eee0013eSWilly Tu     }
282eee0013eSWilly Tu     BMCWEB_LOG_DEBUG << "Sw state " << swState << " to Warning";
283eee0013eSWilly Tu     return "Warning";
284eee0013eSWilly Tu }
285eee0013eSWilly Tu 
286eee0013eSWilly Tu /**
287eee0013eSWilly Tu  * @brief Put status of input swId into json response
288eee0013eSWilly Tu  *
289eee0013eSWilly Tu  * This function will put the appropriate Redfish state of the input
290eee0013eSWilly Tu  * software id to ["Status"]["State"] within the json response
291eee0013eSWilly Tu  *
292eee0013eSWilly Tu  * @param[i,o] aResp    Async response object
293eee0013eSWilly Tu  * @param[i]   swId     The software ID to get status for
294eee0013eSWilly Tu  * @param[i]   dbusSvc  The dbus service implementing the software object
295eee0013eSWilly Tu  *
296eee0013eSWilly Tu  * @return void
297eee0013eSWilly Tu  */
298eee0013eSWilly Tu inline void getSwStatus(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
299eee0013eSWilly Tu                         const std::shared_ptr<std::string>& swId,
300eee0013eSWilly Tu                         const std::string& dbusSvc)
301eee0013eSWilly Tu {
302eee0013eSWilly Tu     BMCWEB_LOG_DEBUG << "getSwStatus: swId " << *swId << " svc " << dbusSvc;
303eee0013eSWilly Tu 
304d1bde9e5SKrzysztof Grobelny     sdbusplus::asio::getAllProperties(
305d1bde9e5SKrzysztof Grobelny         *crow::connections::systemBus, dbusSvc,
306d1bde9e5SKrzysztof Grobelny         "/xyz/openbmc_project/software/" + *swId,
307d1bde9e5SKrzysztof Grobelny         "xyz.openbmc_project.Software.Activation",
308eee0013eSWilly Tu         [asyncResp,
309eee0013eSWilly Tu          swId](const boost::system::error_code errorCode,
310eee0013eSWilly Tu                const dbus::utility::DBusPropertiesMap& propertiesList) {
311eee0013eSWilly Tu         if (errorCode)
312eee0013eSWilly Tu         {
313eee0013eSWilly Tu             // not all swtypes are updateable, this is ok
314eee0013eSWilly Tu             asyncResp->res.jsonValue["Status"]["State"] = "Enabled";
315eee0013eSWilly Tu             return;
316eee0013eSWilly Tu         }
317d1bde9e5SKrzysztof Grobelny 
318eee0013eSWilly Tu         const std::string* swInvActivation = nullptr;
319d1bde9e5SKrzysztof Grobelny 
320d1bde9e5SKrzysztof Grobelny         const bool success = sdbusplus::unpackPropertiesNoThrow(
321d1bde9e5SKrzysztof Grobelny             dbus_utils::UnpackErrorPrinter(), propertiesList, "Activation",
322d1bde9e5SKrzysztof Grobelny             swInvActivation);
323d1bde9e5SKrzysztof Grobelny 
324d1bde9e5SKrzysztof Grobelny         if (!success)
325eee0013eSWilly Tu         {
326d1bde9e5SKrzysztof Grobelny             messages::internalError(asyncResp->res);
327d1bde9e5SKrzysztof Grobelny             return;
328eee0013eSWilly Tu         }
329eee0013eSWilly Tu 
330eee0013eSWilly Tu         if (swInvActivation == nullptr)
331eee0013eSWilly Tu         {
332eee0013eSWilly Tu             messages::internalError(asyncResp->res);
333eee0013eSWilly Tu             return;
334eee0013eSWilly Tu         }
335d1bde9e5SKrzysztof Grobelny 
336eee0013eSWilly Tu         BMCWEB_LOG_DEBUG << "getSwStatus: Activation " << *swInvActivation;
337eee0013eSWilly Tu         asyncResp->res.jsonValue["Status"]["State"] =
338eee0013eSWilly Tu             getRedfishSwState(*swInvActivation);
339eee0013eSWilly Tu         asyncResp->res.jsonValue["Status"]["Health"] =
340eee0013eSWilly Tu             getRedfishSwHealth(*swInvActivation);
341d1bde9e5SKrzysztof Grobelny         });
342eee0013eSWilly Tu }
343eee0013eSWilly Tu 
344eee0013eSWilly Tu /**
345eee0013eSWilly Tu  * @brief Updates programmable status of input swId into json response
346eee0013eSWilly Tu  *
347eee0013eSWilly Tu  * This function checks whether software inventory component
348eee0013eSWilly Tu  * can be programmable or not and fill's the "Updatable"
349eee0013eSWilly Tu  * Property.
350eee0013eSWilly Tu  *
351eee0013eSWilly Tu  * @param[i,o] asyncResp  Async response object
352eee0013eSWilly Tu  * @param[i]   swId       The software ID
353eee0013eSWilly Tu  */
354eee0013eSWilly Tu inline void
355eee0013eSWilly Tu     getSwUpdatableStatus(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
356eee0013eSWilly Tu                          const std::shared_ptr<std::string>& swId)
357eee0013eSWilly Tu {
358eee0013eSWilly Tu     sdbusplus::asio::getProperty<std::vector<std::string>>(
359eee0013eSWilly Tu         *crow::connections::systemBus, "xyz.openbmc_project.ObjectMapper",
360eee0013eSWilly Tu         "/xyz/openbmc_project/software/updateable",
361eee0013eSWilly Tu         "xyz.openbmc_project.Association", "endpoints",
362eee0013eSWilly Tu         [asyncResp, swId](const boost::system::error_code ec,
363eee0013eSWilly Tu                           const std::vector<std::string>& objPaths) {
364eee0013eSWilly Tu         if (ec)
365eee0013eSWilly Tu         {
366eee0013eSWilly Tu             BMCWEB_LOG_DEBUG << " error_code = " << ec
367eee0013eSWilly Tu                              << " error msg =  " << ec.message();
368eee0013eSWilly Tu             // System can exist with no updateable software,
369eee0013eSWilly Tu             // so don't throw error here.
370eee0013eSWilly Tu             return;
371eee0013eSWilly Tu         }
372eee0013eSWilly Tu         std::string reqSwObjPath = "/xyz/openbmc_project/software/" + *swId;
373eee0013eSWilly Tu 
374eee0013eSWilly Tu         if (std::find(objPaths.begin(), objPaths.end(), reqSwObjPath) !=
375eee0013eSWilly Tu             objPaths.end())
376eee0013eSWilly Tu         {
37783edb08fSGunnar Mills             asyncResp->res.jsonValue["Updateable"] = true;
378eee0013eSWilly Tu             return;
379eee0013eSWilly Tu         }
380eee0013eSWilly Tu         });
381eee0013eSWilly Tu }
382eee0013eSWilly Tu 
383eee0013eSWilly Tu } // namespace sw_util
384eee0013eSWilly Tu } // namespace redfish
385