xref: /openbmc/bmcweb/features/redfish/include/utils/query_param.hpp (revision 5c9fb2d6a1cddabc22af7603f11efd2850a05a80)
1f4c99e70SEd Tanous #pragma once
2d5c80ad9SNan Zhou #include "bmcweb_config.h"
3d5c80ad9SNan Zhou 
4f4c99e70SEd Tanous #include "app.hpp"
5f4c99e70SEd Tanous #include "async_resp.hpp"
6f4c99e70SEd Tanous #include "error_messages.hpp"
7f4c99e70SEd Tanous #include "http_request.hpp"
802cad96eSEd Tanous #include "http_response.hpp"
9d5c80ad9SNan Zhou #include "logging.hpp"
10f4c99e70SEd Tanous 
11d5c80ad9SNan Zhou #include <sys/types.h>
12d5c80ad9SNan Zhou 
13e155ab54SNan Zhou #include <boost/algorithm/string/classification.hpp>
14e155ab54SNan Zhou #include <boost/algorithm/string/split.hpp>
15d5c80ad9SNan Zhou #include <boost/beast/http/message.hpp> // IWYU pragma: keep
16d5c80ad9SNan Zhou #include <boost/beast/http/status.hpp>
17d5c80ad9SNan Zhou #include <boost/beast/http/verb.hpp>
18d5c80ad9SNan Zhou #include <boost/url/params_view.hpp>
19d5c80ad9SNan Zhou #include <boost/url/string.hpp>
20d5c80ad9SNan Zhou #include <nlohmann/json.hpp>
21d5c80ad9SNan Zhou 
22d5c80ad9SNan Zhou #include <algorithm>
23e155ab54SNan Zhou #include <array>
24e155ab54SNan Zhou #include <cctype>
257cf436c9SEd Tanous #include <charconv>
26827c4902SNan Zhou #include <compare>
27d5c80ad9SNan Zhou #include <cstdint>
28d5c80ad9SNan Zhou #include <functional>
29e155ab54SNan Zhou #include <iterator>
30d5c80ad9SNan Zhou #include <limits>
31d5c80ad9SNan Zhou #include <map>
32d5c80ad9SNan Zhou #include <memory>
33d5c80ad9SNan Zhou #include <optional>
34f4c99e70SEd Tanous #include <string>
35f4c99e70SEd Tanous #include <string_view>
36d5c80ad9SNan Zhou #include <system_error>
377cf436c9SEd Tanous #include <utility>
38f4c99e70SEd Tanous #include <vector>
39f4c99e70SEd Tanous 
40d5c80ad9SNan Zhou // IWYU pragma: no_include <boost/url/impl/params_view.hpp>
41d5c80ad9SNan Zhou // IWYU pragma: no_include <boost/beast/http/impl/message.hpp>
42d5c80ad9SNan Zhou // IWYU pragma: no_include <boost/intrusive/detail/list_iterator.hpp>
43e155ab54SNan Zhou // IWYU pragma: no_include <boost/algorithm/string/detail/classification.hpp>
44e155ab54SNan Zhou // IWYU pragma: no_include <boost/iterator/iterator_facade.hpp>
45e155ab54SNan Zhou // IWYU pragma: no_include <boost/type_index/type_index_facade.hpp>
46d5c80ad9SNan Zhou // IWYU pragma: no_include <stdint.h>
47d5c80ad9SNan Zhou 
48f4c99e70SEd Tanous namespace redfish
49f4c99e70SEd Tanous {
50f4c99e70SEd Tanous namespace query_param
51f4c99e70SEd Tanous {
52ce8ea743SJiaqing Zhao inline constexpr size_t maxEntriesPerPage = 1000;
53f4c99e70SEd Tanous 
547cf436c9SEd Tanous enum class ExpandType : uint8_t
557cf436c9SEd Tanous {
567cf436c9SEd Tanous     None,
577cf436c9SEd Tanous     Links,
587cf436c9SEd Tanous     NotLinks,
597cf436c9SEd Tanous     Both,
607cf436c9SEd Tanous };
617cf436c9SEd Tanous 
62827c4902SNan Zhou // A simple implementation of Trie to help |recursiveSelect|.
63827c4902SNan Zhou class SelectTrieNode
64827c4902SNan Zhou {
65827c4902SNan Zhou   public:
66827c4902SNan Zhou     SelectTrieNode() = default;
67827c4902SNan Zhou 
68827c4902SNan Zhou     const SelectTrieNode* find(const std::string& jsonKey) const
69827c4902SNan Zhou     {
70827c4902SNan Zhou         auto it = children.find(jsonKey);
71827c4902SNan Zhou         if (it == children.end())
72827c4902SNan Zhou         {
73827c4902SNan Zhou             return nullptr;
74827c4902SNan Zhou         }
75827c4902SNan Zhou         return &it->second;
76827c4902SNan Zhou     }
77827c4902SNan Zhou 
78827c4902SNan Zhou     // Creates a new node if the key doesn't exist, returns the reference to the
79827c4902SNan Zhou     // newly created node; otherwise, return the reference to the existing node
80827c4902SNan Zhou     SelectTrieNode* emplace(std::string_view jsonKey)
81827c4902SNan Zhou     {
82827c4902SNan Zhou         auto [it, _] = children.emplace(jsonKey, SelectTrieNode{});
83827c4902SNan Zhou         return &it->second;
84827c4902SNan Zhou     }
85827c4902SNan Zhou 
86827c4902SNan Zhou     bool empty() const
87827c4902SNan Zhou     {
88827c4902SNan Zhou         return children.empty();
89827c4902SNan Zhou     }
90827c4902SNan Zhou 
91827c4902SNan Zhou     void clear()
92827c4902SNan Zhou     {
93827c4902SNan Zhou         children.clear();
94827c4902SNan Zhou     }
95827c4902SNan Zhou 
96827c4902SNan Zhou     void setToSelected()
97827c4902SNan Zhou     {
98827c4902SNan Zhou         selected = true;
99827c4902SNan Zhou     }
100827c4902SNan Zhou 
101827c4902SNan Zhou     bool isSelected() const
102827c4902SNan Zhou     {
103827c4902SNan Zhou         return selected;
104827c4902SNan Zhou     }
105827c4902SNan Zhou 
106827c4902SNan Zhou   private:
107827c4902SNan Zhou     std::map<std::string, SelectTrieNode, std::less<>> children;
108827c4902SNan Zhou     bool selected = false;
109827c4902SNan Zhou };
110827c4902SNan Zhou 
111827c4902SNan Zhou // Validates the property in the $select parameter. Every character is among
112827c4902SNan Zhou // [a-zA-Z0-9#@_.] (taken from Redfish spec, section 9.6 Properties)
113827c4902SNan Zhou inline bool isSelectedPropertyAllowed(std::string_view property)
114827c4902SNan Zhou {
115827c4902SNan Zhou     // These a magic number, but with it it's less likely that this code
116827c4902SNan Zhou     // introduces CVE; e.g., too large properties crash the service.
117827c4902SNan Zhou     constexpr int maxPropertyLength = 60;
118827c4902SNan Zhou     if (property.empty() || property.size() > maxPropertyLength)
119827c4902SNan Zhou     {
120827c4902SNan Zhou         return false;
121827c4902SNan Zhou     }
122827c4902SNan Zhou     for (char ch : property)
123827c4902SNan Zhou     {
124827c4902SNan Zhou         if (std::isalnum(static_cast<unsigned char>(ch)) == 0 && ch != '#' &&
125827c4902SNan Zhou             ch != '@' && ch != '.')
126827c4902SNan Zhou         {
127827c4902SNan Zhou             return false;
128827c4902SNan Zhou         }
129827c4902SNan Zhou     }
130827c4902SNan Zhou     return true;
131827c4902SNan Zhou }
132827c4902SNan Zhou 
133827c4902SNan Zhou struct SelectTrie
134827c4902SNan Zhou {
135827c4902SNan Zhou     SelectTrie() = default;
136827c4902SNan Zhou 
137827c4902SNan Zhou     // Inserts a $select value; returns false if the nestedProperty is illegal.
138827c4902SNan Zhou     bool insertNode(std::string_view nestedProperty)
139827c4902SNan Zhou     {
140827c4902SNan Zhou         if (nestedProperty.empty())
141827c4902SNan Zhou         {
142827c4902SNan Zhou             return false;
143827c4902SNan Zhou         }
144827c4902SNan Zhou         SelectTrieNode* currNode = &root;
145827c4902SNan Zhou         size_t index = nestedProperty.find_first_of('/');
146827c4902SNan Zhou         while (!nestedProperty.empty())
147827c4902SNan Zhou         {
148827c4902SNan Zhou             std::string_view property = nestedProperty.substr(0, index);
149827c4902SNan Zhou             if (!isSelectedPropertyAllowed(property))
150827c4902SNan Zhou             {
151827c4902SNan Zhou                 return false;
152827c4902SNan Zhou             }
153827c4902SNan Zhou             currNode = currNode->emplace(property);
154827c4902SNan Zhou             if (index == std::string::npos)
155827c4902SNan Zhou             {
156827c4902SNan Zhou                 break;
157827c4902SNan Zhou             }
158827c4902SNan Zhou             nestedProperty.remove_prefix(index + 1);
159827c4902SNan Zhou             index = nestedProperty.find_first_of('/');
160827c4902SNan Zhou         }
161827c4902SNan Zhou         currNode->setToSelected();
162827c4902SNan Zhou         return true;
163827c4902SNan Zhou     }
164827c4902SNan Zhou 
165827c4902SNan Zhou     SelectTrieNode root;
166827c4902SNan Zhou };
167827c4902SNan Zhou 
168a6b9125fSNan Zhou // The struct stores the parsed query parameters of the default Redfish route.
169f4c99e70SEd Tanous struct Query
170f4c99e70SEd Tanous {
171a6b9125fSNan Zhou     // Only
172f4c99e70SEd Tanous     bool isOnly = false;
173a6b9125fSNan Zhou     // Expand
174a6b9125fSNan Zhou     uint8_t expandLevel = 0;
1757cf436c9SEd Tanous     ExpandType expandType = ExpandType::None;
176c937d2bfSEd Tanous 
177c937d2bfSEd Tanous     // Skip
1783648c8beSEd Tanous     std::optional<size_t> skip = std::nullopt;
179c937d2bfSEd Tanous 
180c937d2bfSEd Tanous     // Top
1813648c8beSEd Tanous     std::optional<size_t> top = std::nullopt;
182e155ab54SNan Zhou 
183e155ab54SNan Zhou     // Select
184827c4902SNan Zhou     SelectTrie selectTrie = {};
185f4c99e70SEd Tanous };
186f4c99e70SEd Tanous 
187a6b9125fSNan Zhou // The struct defines how resource handlers in redfish-core/lib/ can handle
188a6b9125fSNan Zhou // query parameters themselves, so that the default Redfish route will delegate
189a6b9125fSNan Zhou // the processing.
190a6b9125fSNan Zhou struct QueryCapabilities
191a6b9125fSNan Zhou {
192a6b9125fSNan Zhou     bool canDelegateOnly = false;
193c937d2bfSEd Tanous     bool canDelegateTop = false;
194c937d2bfSEd Tanous     bool canDelegateSkip = false;
195a6b9125fSNan Zhou     uint8_t canDelegateExpandLevel = 0;
196e155ab54SNan Zhou     bool canDelegateSelect = false;
197a6b9125fSNan Zhou };
198a6b9125fSNan Zhou 
199a6b9125fSNan Zhou // Delegates query parameters according to the given |queryCapabilities|
200a6b9125fSNan Zhou // This function doesn't check query parameter conflicts since the parse
201a6b9125fSNan Zhou // function will take care of it.
202a6b9125fSNan Zhou // Returns a delegated query object which can be used by individual resource
203a6b9125fSNan Zhou // handlers so that handlers don't need to query again.
204a6b9125fSNan Zhou inline Query delegate(const QueryCapabilities& queryCapabilities, Query& query)
205a6b9125fSNan Zhou {
206a6b9125fSNan Zhou     Query delegated;
207a6b9125fSNan Zhou     // delegate only
208a6b9125fSNan Zhou     if (query.isOnly && queryCapabilities.canDelegateOnly)
209a6b9125fSNan Zhou     {
210a6b9125fSNan Zhou         delegated.isOnly = true;
211a6b9125fSNan Zhou         query.isOnly = false;
212a6b9125fSNan Zhou     }
213a6b9125fSNan Zhou     // delegate expand as much as we can
214a6b9125fSNan Zhou     if (query.expandType != ExpandType::None)
215a6b9125fSNan Zhou     {
216a6b9125fSNan Zhou         delegated.expandType = query.expandType;
217a6b9125fSNan Zhou         if (query.expandLevel <= queryCapabilities.canDelegateExpandLevel)
218a6b9125fSNan Zhou         {
219a6b9125fSNan Zhou             query.expandType = ExpandType::None;
220a6b9125fSNan Zhou             delegated.expandLevel = query.expandLevel;
221a6b9125fSNan Zhou             query.expandLevel = 0;
222a6b9125fSNan Zhou         }
223a6b9125fSNan Zhou         else
224a6b9125fSNan Zhou         {
225a6b9125fSNan Zhou             query.expandLevel -= queryCapabilities.canDelegateExpandLevel;
226a6b9125fSNan Zhou             delegated.expandLevel = queryCapabilities.canDelegateExpandLevel;
227a6b9125fSNan Zhou         }
228a6b9125fSNan Zhou     }
229c937d2bfSEd Tanous 
230c937d2bfSEd Tanous     // delegate top
2313648c8beSEd Tanous     if (query.top && queryCapabilities.canDelegateTop)
232c937d2bfSEd Tanous     {
233c937d2bfSEd Tanous         delegated.top = query.top;
2343648c8beSEd Tanous         query.top = std::nullopt;
235c937d2bfSEd Tanous     }
236c937d2bfSEd Tanous 
237c937d2bfSEd Tanous     // delegate skip
2383648c8beSEd Tanous     if (query.skip && queryCapabilities.canDelegateSkip)
239c937d2bfSEd Tanous     {
240c937d2bfSEd Tanous         delegated.skip = query.skip;
241c937d2bfSEd Tanous         query.skip = 0;
242c937d2bfSEd Tanous     }
243e155ab54SNan Zhou 
244e155ab54SNan Zhou     // delegate select
245827c4902SNan Zhou     if (!query.selectTrie.root.empty() && queryCapabilities.canDelegateSelect)
246e155ab54SNan Zhou     {
247827c4902SNan Zhou         delegated.selectTrie = std::move(query.selectTrie);
248827c4902SNan Zhou         query.selectTrie.root.clear();
249e155ab54SNan Zhou     }
250a6b9125fSNan Zhou     return delegated;
251a6b9125fSNan Zhou }
252a6b9125fSNan Zhou 
2537cf436c9SEd Tanous inline bool getExpandType(std::string_view value, Query& query)
2547cf436c9SEd Tanous {
2557cf436c9SEd Tanous     if (value.empty())
2567cf436c9SEd Tanous     {
2577cf436c9SEd Tanous         return false;
2587cf436c9SEd Tanous     }
2597cf436c9SEd Tanous     switch (value[0])
2607cf436c9SEd Tanous     {
2617cf436c9SEd Tanous         case '*':
2627cf436c9SEd Tanous             query.expandType = ExpandType::Both;
2637cf436c9SEd Tanous             break;
2647cf436c9SEd Tanous         case '.':
2657cf436c9SEd Tanous             query.expandType = ExpandType::NotLinks;
2667cf436c9SEd Tanous             break;
2677cf436c9SEd Tanous         case '~':
2687cf436c9SEd Tanous             query.expandType = ExpandType::Links;
2697cf436c9SEd Tanous             break;
2707cf436c9SEd Tanous         default:
2717cf436c9SEd Tanous             return false;
2727cf436c9SEd Tanous 
2737cf436c9SEd Tanous             break;
2747cf436c9SEd Tanous     }
2757cf436c9SEd Tanous     value.remove_prefix(1);
2767cf436c9SEd Tanous     if (value.empty())
2777cf436c9SEd Tanous     {
2787cf436c9SEd Tanous         query.expandLevel = 1;
2797cf436c9SEd Tanous         return true;
2807cf436c9SEd Tanous     }
2817cf436c9SEd Tanous     constexpr std::string_view levels = "($levels=";
2827cf436c9SEd Tanous     if (!value.starts_with(levels))
2837cf436c9SEd Tanous     {
2847cf436c9SEd Tanous         return false;
2857cf436c9SEd Tanous     }
2867cf436c9SEd Tanous     value.remove_prefix(levels.size());
2877cf436c9SEd Tanous 
2887cf436c9SEd Tanous     auto it = std::from_chars(value.data(), value.data() + value.size(),
2897cf436c9SEd Tanous                               query.expandLevel);
2907cf436c9SEd Tanous     if (it.ec != std::errc())
2917cf436c9SEd Tanous     {
2927cf436c9SEd Tanous         return false;
2937cf436c9SEd Tanous     }
2947cf436c9SEd Tanous     value.remove_prefix(static_cast<size_t>(it.ptr - value.data()));
2957cf436c9SEd Tanous     return value == ")";
2967cf436c9SEd Tanous }
2977cf436c9SEd Tanous 
298c937d2bfSEd Tanous enum class QueryError
299c937d2bfSEd Tanous {
300c937d2bfSEd Tanous     Ok,
301c937d2bfSEd Tanous     OutOfRange,
302c937d2bfSEd Tanous     ValueFormat,
303c937d2bfSEd Tanous };
304c937d2bfSEd Tanous 
305c937d2bfSEd Tanous inline QueryError getNumericParam(std::string_view value, size_t& param)
306c937d2bfSEd Tanous {
307c937d2bfSEd Tanous     std::from_chars_result r =
308c937d2bfSEd Tanous         std::from_chars(value.data(), value.data() + value.size(), param);
309c937d2bfSEd Tanous 
310c937d2bfSEd Tanous     // If the number wasn't representable in the type, it's out of range
311c937d2bfSEd Tanous     if (r.ec == std::errc::result_out_of_range)
312c937d2bfSEd Tanous     {
313c937d2bfSEd Tanous         return QueryError::OutOfRange;
314c937d2bfSEd Tanous     }
315c937d2bfSEd Tanous     // All other errors are value format
316c937d2bfSEd Tanous     if (r.ec != std::errc())
317c937d2bfSEd Tanous     {
318c937d2bfSEd Tanous         return QueryError::ValueFormat;
319c937d2bfSEd Tanous     }
320c937d2bfSEd Tanous     return QueryError::Ok;
321c937d2bfSEd Tanous }
322c937d2bfSEd Tanous 
323c937d2bfSEd Tanous inline QueryError getSkipParam(std::string_view value, Query& query)
324c937d2bfSEd Tanous {
3253648c8beSEd Tanous     return getNumericParam(value, query.skip.emplace());
326c937d2bfSEd Tanous }
327c937d2bfSEd Tanous 
328c937d2bfSEd Tanous inline QueryError getTopParam(std::string_view value, Query& query)
329c937d2bfSEd Tanous {
3303648c8beSEd Tanous     QueryError ret = getNumericParam(value, query.top.emplace());
331c937d2bfSEd Tanous     if (ret != QueryError::Ok)
332c937d2bfSEd Tanous     {
333c937d2bfSEd Tanous         return ret;
334c937d2bfSEd Tanous     }
335c937d2bfSEd Tanous 
336c937d2bfSEd Tanous     // Range check for sanity.
337c937d2bfSEd Tanous     if (query.top > maxEntriesPerPage)
338c937d2bfSEd Tanous     {
339c937d2bfSEd Tanous         return QueryError::OutOfRange;
340c937d2bfSEd Tanous     }
341c937d2bfSEd Tanous 
342c937d2bfSEd Tanous     return QueryError::Ok;
343c937d2bfSEd Tanous }
344c937d2bfSEd Tanous 
345e155ab54SNan Zhou // Parses and validates the $select parameter.
346e155ab54SNan Zhou // As per OData URL Conventions and Redfish Spec, the $select values shall be
347e155ab54SNan Zhou // comma separated Resource Path
348e155ab54SNan Zhou // Ref:
349e155ab54SNan Zhou // 1. https://datatracker.ietf.org/doc/html/rfc3986#section-3.3
350e155ab54SNan Zhou // 2.
351e155ab54SNan Zhou // https://docs.oasis-open.org/odata/odata/v4.01/os/abnf/odata-abnf-construction-rules.txt
352e155ab54SNan Zhou inline bool getSelectParam(std::string_view value, Query& query)
353e155ab54SNan Zhou {
354e155ab54SNan Zhou     std::vector<std::string> properties;
355e155ab54SNan Zhou     boost::split(properties, value, boost::is_any_of(","));
356e155ab54SNan Zhou     if (properties.empty())
357e155ab54SNan Zhou     {
358e155ab54SNan Zhou         return false;
359e155ab54SNan Zhou     }
360e155ab54SNan Zhou     // These a magic number, but with it it's less likely that this code
361e155ab54SNan Zhou     // introduces CVE; e.g., too large properties crash the service.
362e155ab54SNan Zhou     constexpr int maxNumProperties = 10;
363e155ab54SNan Zhou     if (properties.size() > maxNumProperties)
364e155ab54SNan Zhou     {
365e155ab54SNan Zhou         return false;
366e155ab54SNan Zhou     }
367827c4902SNan Zhou     for (const auto& property : properties)
368e155ab54SNan Zhou     {
369827c4902SNan Zhou         if (!query.selectTrie.insertNode(property))
370e155ab54SNan Zhou         {
371e155ab54SNan Zhou             return false;
372e155ab54SNan Zhou         }
373e155ab54SNan Zhou     }
374e155ab54SNan Zhou     return true;
375e155ab54SNan Zhou }
376e155ab54SNan Zhou 
377f4c99e70SEd Tanous inline std::optional<Query>
378f4c99e70SEd Tanous     parseParameters(const boost::urls::params_view& urlParams,
379f4c99e70SEd Tanous                     crow::Response& res)
380f4c99e70SEd Tanous {
381f4c99e70SEd Tanous     Query ret;
382f4c99e70SEd Tanous     for (const boost::urls::params_view::value_type& it : urlParams)
383f4c99e70SEd Tanous     {
384f4c99e70SEd Tanous         std::string_view key(it.key.data(), it.key.size());
385f4c99e70SEd Tanous         std::string_view value(it.value.data(), it.value.size());
386f4c99e70SEd Tanous         if (key == "only")
387f4c99e70SEd Tanous         {
388f4c99e70SEd Tanous             if (!it.value.empty())
389f4c99e70SEd Tanous             {
390f4c99e70SEd Tanous                 messages::queryParameterValueFormatError(res, value, key);
391f4c99e70SEd Tanous                 return std::nullopt;
392f4c99e70SEd Tanous             }
393f4c99e70SEd Tanous             ret.isOnly = true;
394f4c99e70SEd Tanous         }
3955e52870bSEd Tanous         else if (key == "$expand" && bmcwebInsecureEnableQueryParams)
3967cf436c9SEd Tanous         {
3977cf436c9SEd Tanous             if (!getExpandType(value, ret))
3987cf436c9SEd Tanous             {
3997cf436c9SEd Tanous                 messages::queryParameterValueFormatError(res, value, key);
4007cf436c9SEd Tanous                 return std::nullopt;
401f4c99e70SEd Tanous             }
4027cf436c9SEd Tanous         }
403c937d2bfSEd Tanous         else if (key == "$top")
404c937d2bfSEd Tanous         {
405c937d2bfSEd Tanous             QueryError topRet = getTopParam(value, ret);
406c937d2bfSEd Tanous             if (topRet == QueryError::ValueFormat)
407c937d2bfSEd Tanous             {
408c937d2bfSEd Tanous                 messages::queryParameterValueFormatError(res, value, key);
409c937d2bfSEd Tanous                 return std::nullopt;
410c937d2bfSEd Tanous             }
411c937d2bfSEd Tanous             if (topRet == QueryError::OutOfRange)
412c937d2bfSEd Tanous             {
413c937d2bfSEd Tanous                 messages::queryParameterOutOfRange(
414c937d2bfSEd Tanous                     res, value, "$top",
415a926c53eSJiaqing Zhao                     "0-" + std::to_string(maxEntriesPerPage));
416c937d2bfSEd Tanous                 return std::nullopt;
417c937d2bfSEd Tanous             }
418c937d2bfSEd Tanous         }
419c937d2bfSEd Tanous         else if (key == "$skip")
420c937d2bfSEd Tanous         {
421c937d2bfSEd Tanous             QueryError topRet = getSkipParam(value, ret);
422c937d2bfSEd Tanous             if (topRet == QueryError::ValueFormat)
423c937d2bfSEd Tanous             {
424c937d2bfSEd Tanous                 messages::queryParameterValueFormatError(res, value, key);
425c937d2bfSEd Tanous                 return std::nullopt;
426c937d2bfSEd Tanous             }
427c937d2bfSEd Tanous             if (topRet == QueryError::OutOfRange)
428c937d2bfSEd Tanous             {
429c937d2bfSEd Tanous                 messages::queryParameterOutOfRange(
430c937d2bfSEd Tanous                     res, value, key,
431a926c53eSJiaqing Zhao                     "0-" + std::to_string(std::numeric_limits<size_t>::max()));
432c937d2bfSEd Tanous                 return std::nullopt;
433c937d2bfSEd Tanous             }
434c937d2bfSEd Tanous         }
435e155ab54SNan Zhou         else if (key == "$select" && bmcwebInsecureEnableQueryParams)
436e155ab54SNan Zhou         {
437e155ab54SNan Zhou             if (!getSelectParam(value, ret))
438e155ab54SNan Zhou             {
439e155ab54SNan Zhou                 messages::queryParameterValueFormatError(res, value, key);
440e155ab54SNan Zhou                 return std::nullopt;
441e155ab54SNan Zhou             }
442e155ab54SNan Zhou         }
4437cf436c9SEd Tanous         else
4447cf436c9SEd Tanous         {
4457cf436c9SEd Tanous             // Intentionally ignore other errors Redfish spec, 7.3.1
4467cf436c9SEd Tanous             if (key.starts_with("$"))
4477cf436c9SEd Tanous             {
4487cf436c9SEd Tanous                 // Services shall return... The HTTP 501 Not Implemented
4497cf436c9SEd Tanous                 // status code for any unsupported query parameters that
4507cf436c9SEd Tanous                 // start with $ .
4517cf436c9SEd Tanous                 messages::queryParameterValueFormatError(res, value, key);
4527cf436c9SEd Tanous                 res.result(boost::beast::http::status::not_implemented);
4537cf436c9SEd Tanous                 return std::nullopt;
4547cf436c9SEd Tanous             }
4557cf436c9SEd Tanous             // "Shall ignore unknown or unsupported query parameters that do
4567cf436c9SEd Tanous             // not begin with $ ."
4577cf436c9SEd Tanous         }
4587cf436c9SEd Tanous     }
4597cf436c9SEd Tanous 
460827c4902SNan Zhou     if (ret.expandType != ExpandType::None && !ret.selectTrie.root.empty())
461e155ab54SNan Zhou     {
462e155ab54SNan Zhou         messages::queryCombinationInvalid(res);
463e155ab54SNan Zhou         return std::nullopt;
464e155ab54SNan Zhou     }
465e155ab54SNan Zhou 
466f4c99e70SEd Tanous     return ret;
467f4c99e70SEd Tanous }
468f4c99e70SEd Tanous 
469f4c99e70SEd Tanous inline bool processOnly(crow::App& app, crow::Response& res,
470f4c99e70SEd Tanous                         std::function<void(crow::Response&)>& completionHandler)
471f4c99e70SEd Tanous {
472f4c99e70SEd Tanous     BMCWEB_LOG_DEBUG << "Processing only query param";
473f4c99e70SEd Tanous     auto itMembers = res.jsonValue.find("Members");
474f4c99e70SEd Tanous     if (itMembers == res.jsonValue.end())
475f4c99e70SEd Tanous     {
476f4c99e70SEd Tanous         messages::queryNotSupportedOnResource(res);
477f4c99e70SEd Tanous         completionHandler(res);
478f4c99e70SEd Tanous         return false;
479f4c99e70SEd Tanous     }
480f4c99e70SEd Tanous     auto itMemBegin = itMembers->begin();
481f4c99e70SEd Tanous     if (itMemBegin == itMembers->end() || itMembers->size() != 1)
482f4c99e70SEd Tanous     {
483f4c99e70SEd Tanous         BMCWEB_LOG_DEBUG << "Members contains " << itMembers->size()
484f4c99e70SEd Tanous                          << " element, returning full collection.";
485f4c99e70SEd Tanous         completionHandler(res);
486f4c99e70SEd Tanous         return false;
487f4c99e70SEd Tanous     }
488f4c99e70SEd Tanous 
489f4c99e70SEd Tanous     auto itUrl = itMemBegin->find("@odata.id");
490f4c99e70SEd Tanous     if (itUrl == itMemBegin->end())
491f4c99e70SEd Tanous     {
492f4c99e70SEd Tanous         BMCWEB_LOG_DEBUG << "No found odata.id";
493f4c99e70SEd Tanous         messages::internalError(res);
494f4c99e70SEd Tanous         completionHandler(res);
495f4c99e70SEd Tanous         return false;
496f4c99e70SEd Tanous     }
497f4c99e70SEd Tanous     const std::string* url = itUrl->get_ptr<const std::string*>();
498f4c99e70SEd Tanous     if (url == nullptr)
499f4c99e70SEd Tanous     {
500f4c99e70SEd Tanous         BMCWEB_LOG_DEBUG << "@odata.id wasn't a string????";
501f4c99e70SEd Tanous         messages::internalError(res);
502f4c99e70SEd Tanous         completionHandler(res);
503f4c99e70SEd Tanous         return false;
504f4c99e70SEd Tanous     }
505f4c99e70SEd Tanous     // TODO(Ed) copy request headers?
506f4c99e70SEd Tanous     // newReq.session = req.session;
507f4c99e70SEd Tanous     std::error_code ec;
508f4c99e70SEd Tanous     crow::Request newReq({boost::beast::http::verb::get, *url, 11}, ec);
509f4c99e70SEd Tanous     if (ec)
510f4c99e70SEd Tanous     {
511f4c99e70SEd Tanous         messages::internalError(res);
512f4c99e70SEd Tanous         completionHandler(res);
513f4c99e70SEd Tanous         return false;
514f4c99e70SEd Tanous     }
515f4c99e70SEd Tanous 
516f4c99e70SEd Tanous     auto asyncResp = std::make_shared<bmcweb::AsyncResp>();
517f4c99e70SEd Tanous     BMCWEB_LOG_DEBUG << "setting completion handler on " << &asyncResp->res;
518f4c99e70SEd Tanous     asyncResp->res.setCompleteRequestHandler(std::move(completionHandler));
519f4c99e70SEd Tanous     asyncResp->res.setIsAliveHelper(res.releaseIsAliveHelper());
520f4c99e70SEd Tanous     app.handle(newReq, asyncResp);
521f4c99e70SEd Tanous     return true;
522f4c99e70SEd Tanous }
523f4c99e70SEd Tanous 
5247cf436c9SEd Tanous struct ExpandNode
5257cf436c9SEd Tanous {
5267cf436c9SEd Tanous     nlohmann::json::json_pointer location;
5277cf436c9SEd Tanous     std::string uri;
5287cf436c9SEd Tanous 
5297cf436c9SEd Tanous     inline bool operator==(const ExpandNode& other) const
5307cf436c9SEd Tanous     {
5317cf436c9SEd Tanous         return location == other.location && uri == other.uri;
5327cf436c9SEd Tanous     }
5337cf436c9SEd Tanous };
5347cf436c9SEd Tanous 
5357cf436c9SEd Tanous // Walks a json object looking for Redfish NavigationReference entries that
5367cf436c9SEd Tanous // might need resolved.  It recursively walks the jsonResponse object, looking
5377cf436c9SEd Tanous // for links at every level, and returns a list (out) of locations within the
5387cf436c9SEd Tanous // tree that need to be expanded.  The current json pointer location p is passed
5397cf436c9SEd Tanous // in to reference the current node that's being expanded, so it can be combined
5407cf436c9SEd Tanous // with the keys from the jsonResponse object
5417cf436c9SEd Tanous inline void findNavigationReferencesRecursive(
5427cf436c9SEd Tanous     ExpandType eType, nlohmann::json& jsonResponse,
5437cf436c9SEd Tanous     const nlohmann::json::json_pointer& p, bool inLinks,
5447cf436c9SEd Tanous     std::vector<ExpandNode>& out)
5457cf436c9SEd Tanous {
5467cf436c9SEd Tanous     // If no expand is needed, return early
5477cf436c9SEd Tanous     if (eType == ExpandType::None)
5487cf436c9SEd Tanous     {
5497cf436c9SEd Tanous         return;
5507cf436c9SEd Tanous     }
5517cf436c9SEd Tanous     nlohmann::json::array_t* array =
5527cf436c9SEd Tanous         jsonResponse.get_ptr<nlohmann::json::array_t*>();
5537cf436c9SEd Tanous     if (array != nullptr)
5547cf436c9SEd Tanous     {
5557cf436c9SEd Tanous         size_t index = 0;
5567cf436c9SEd Tanous         // For arrays, walk every element in the array
5577cf436c9SEd Tanous         for (auto& element : *array)
5587cf436c9SEd Tanous         {
5597cf436c9SEd Tanous             nlohmann::json::json_pointer newPtr = p / index;
5607cf436c9SEd Tanous             BMCWEB_LOG_DEBUG << "Traversing response at " << newPtr.to_string();
5617cf436c9SEd Tanous             findNavigationReferencesRecursive(eType, element, newPtr, inLinks,
5627cf436c9SEd Tanous                                               out);
5637cf436c9SEd Tanous             index++;
5647cf436c9SEd Tanous         }
5657cf436c9SEd Tanous     }
5667cf436c9SEd Tanous     nlohmann::json::object_t* obj =
5677cf436c9SEd Tanous         jsonResponse.get_ptr<nlohmann::json::object_t*>();
5687cf436c9SEd Tanous     if (obj == nullptr)
5697cf436c9SEd Tanous     {
5707cf436c9SEd Tanous         return;
5717cf436c9SEd Tanous     }
5727cf436c9SEd Tanous     // Navigation References only ever have a single element
5737cf436c9SEd Tanous     if (obj->size() == 1)
5747cf436c9SEd Tanous     {
5757cf436c9SEd Tanous         if (obj->begin()->first == "@odata.id")
5767cf436c9SEd Tanous         {
5777cf436c9SEd Tanous             const std::string* uri =
5787cf436c9SEd Tanous                 obj->begin()->second.get_ptr<const std::string*>();
5797cf436c9SEd Tanous             if (uri != nullptr)
5807cf436c9SEd Tanous             {
5817cf436c9SEd Tanous                 BMCWEB_LOG_DEBUG << "Found element at " << p.to_string();
5827cf436c9SEd Tanous                 out.push_back({p, *uri});
5837cf436c9SEd Tanous             }
5847cf436c9SEd Tanous         }
5857cf436c9SEd Tanous     }
5867cf436c9SEd Tanous     // Loop the object and look for links
5877cf436c9SEd Tanous     for (auto& element : *obj)
5887cf436c9SEd Tanous     {
589e479ad58SNan Zhou         bool localInLinks = inLinks;
590e479ad58SNan Zhou         if (!localInLinks)
5917cf436c9SEd Tanous         {
5927cf436c9SEd Tanous             // Check if this is a links node
593e479ad58SNan Zhou             localInLinks = element.first == "Links";
5947cf436c9SEd Tanous         }
5957cf436c9SEd Tanous         // Only traverse the parts of the tree the user asked for
5967cf436c9SEd Tanous         // Per section 7.3 of the redfish specification
597e479ad58SNan Zhou         if (localInLinks && eType == ExpandType::NotLinks)
5987cf436c9SEd Tanous         {
5997cf436c9SEd Tanous             continue;
6007cf436c9SEd Tanous         }
601e479ad58SNan Zhou         if (!localInLinks && eType == ExpandType::Links)
6027cf436c9SEd Tanous         {
6037cf436c9SEd Tanous             continue;
6047cf436c9SEd Tanous         }
6057cf436c9SEd Tanous         nlohmann::json::json_pointer newPtr = p / element.first;
6067cf436c9SEd Tanous         BMCWEB_LOG_DEBUG << "Traversing response at " << newPtr;
6077cf436c9SEd Tanous 
6087cf436c9SEd Tanous         findNavigationReferencesRecursive(eType, element.second, newPtr,
609e479ad58SNan Zhou                                           localInLinks, out);
6107cf436c9SEd Tanous     }
6117cf436c9SEd Tanous }
6127cf436c9SEd Tanous 
6137cf436c9SEd Tanous inline std::vector<ExpandNode>
61472c3ae33SNan Zhou     findNavigationReferences(ExpandType eType, nlohmann::json& jsonResponse)
6157cf436c9SEd Tanous {
6167cf436c9SEd Tanous     std::vector<ExpandNode> ret;
61772c3ae33SNan Zhou     const nlohmann::json::json_pointer root = nlohmann::json::json_pointer("");
6187cf436c9SEd Tanous     findNavigationReferencesRecursive(eType, jsonResponse, root, false, ret);
6197cf436c9SEd Tanous     return ret;
6207cf436c9SEd Tanous }
6217cf436c9SEd Tanous 
62272c3ae33SNan Zhou // Formats a query parameter string for the sub-query.
623b66cf2a2SNan Zhou // Returns std::nullopt on failures.
62472c3ae33SNan Zhou // This function shall handle $select when it is added.
62572c3ae33SNan Zhou // There is no need to handle parameters that's not campatible with $expand,
62672c3ae33SNan Zhou // e.g., $only, since this function will only be called in side $expand handlers
627b66cf2a2SNan Zhou inline std::optional<std::string> formatQueryForExpand(const Query& query)
62872c3ae33SNan Zhou {
62972c3ae33SNan Zhou     // query.expandLevel<=1: no need to do subqueries
63072c3ae33SNan Zhou     if (query.expandLevel <= 1)
63172c3ae33SNan Zhou     {
632b66cf2a2SNan Zhou         return "";
63372c3ae33SNan Zhou     }
63472c3ae33SNan Zhou     std::string str = "?$expand=";
635b66cf2a2SNan Zhou     bool queryTypeExpected = false;
63672c3ae33SNan Zhou     switch (query.expandType)
63772c3ae33SNan Zhou     {
63872c3ae33SNan Zhou         case ExpandType::None:
639b66cf2a2SNan Zhou             return "";
64072c3ae33SNan Zhou         case ExpandType::Links:
641b66cf2a2SNan Zhou             queryTypeExpected = true;
64272c3ae33SNan Zhou             str += '~';
64372c3ae33SNan Zhou             break;
64472c3ae33SNan Zhou         case ExpandType::NotLinks:
645b66cf2a2SNan Zhou             queryTypeExpected = true;
64672c3ae33SNan Zhou             str += '.';
64772c3ae33SNan Zhou             break;
64872c3ae33SNan Zhou         case ExpandType::Both:
649b66cf2a2SNan Zhou             queryTypeExpected = true;
65072c3ae33SNan Zhou             str += '*';
65172c3ae33SNan Zhou             break;
652b66cf2a2SNan Zhou     }
653b66cf2a2SNan Zhou     if (!queryTypeExpected)
654b66cf2a2SNan Zhou     {
655b66cf2a2SNan Zhou         return std::nullopt;
65672c3ae33SNan Zhou     }
65772c3ae33SNan Zhou     str += "($levels=";
65872c3ae33SNan Zhou     str += std::to_string(query.expandLevel - 1);
65972c3ae33SNan Zhou     str += ')';
66072c3ae33SNan Zhou     return str;
66172c3ae33SNan Zhou }
66272c3ae33SNan Zhou 
6637cf436c9SEd Tanous class MultiAsyncResp : public std::enable_shared_from_this<MultiAsyncResp>
6647cf436c9SEd Tanous {
6657cf436c9SEd Tanous   public:
6667cf436c9SEd Tanous     // This object takes a single asyncResp object as the "final" one, then
6677cf436c9SEd Tanous     // allows callers to attach sub-responses within the json tree that need
6687cf436c9SEd Tanous     // to be executed and filled into their appropriate locations.  This
6697cf436c9SEd Tanous     // class manages the final "merge" of the json resources.
6708a592810SEd Tanous     MultiAsyncResp(crow::App& appIn,
6717cf436c9SEd Tanous                    std::shared_ptr<bmcweb::AsyncResp> finalResIn) :
6728a592810SEd Tanous         app(appIn),
6737cf436c9SEd Tanous         finalRes(std::move(finalResIn))
6747cf436c9SEd Tanous     {}
6757cf436c9SEd Tanous 
6767cf436c9SEd Tanous     void addAwaitingResponse(
67702cad96eSEd Tanous         const std::shared_ptr<bmcweb::AsyncResp>& res,
6787cf436c9SEd Tanous         const nlohmann::json::json_pointer& finalExpandLocation)
6797cf436c9SEd Tanous     {
6807cf436c9SEd Tanous         res->res.setCompleteRequestHandler(std::bind_front(
68172c3ae33SNan Zhou             placeResultStatic, shared_from_this(), finalExpandLocation));
6827cf436c9SEd Tanous     }
6837cf436c9SEd Tanous 
68472c3ae33SNan Zhou     void placeResult(const nlohmann::json::json_pointer& locationToPlace,
6857cf436c9SEd Tanous                      crow::Response& res)
6867cf436c9SEd Tanous     {
6877cf436c9SEd Tanous         nlohmann::json& finalObj = finalRes->res.jsonValue[locationToPlace];
6887cf436c9SEd Tanous         finalObj = std::move(res.jsonValue);
6897cf436c9SEd Tanous     }
6907cf436c9SEd Tanous 
69172c3ae33SNan Zhou     // Handles the very first level of Expand, and starts a chain of sub-queries
69272c3ae33SNan Zhou     // for deeper levels.
69372c3ae33SNan Zhou     void startQuery(const Query& query)
69472c3ae33SNan Zhou     {
69572c3ae33SNan Zhou         std::vector<ExpandNode> nodes =
69672c3ae33SNan Zhou             findNavigationReferences(query.expandType, finalRes->res.jsonValue);
6977cf436c9SEd Tanous         BMCWEB_LOG_DEBUG << nodes.size() << " nodes to traverse";
698b66cf2a2SNan Zhou         const std::optional<std::string> queryStr = formatQueryForExpand(query);
699b66cf2a2SNan Zhou         if (!queryStr)
700b66cf2a2SNan Zhou         {
701b66cf2a2SNan Zhou             messages::internalError(finalRes->res);
702b66cf2a2SNan Zhou             return;
703b66cf2a2SNan Zhou         }
7047cf436c9SEd Tanous         for (const ExpandNode& node : nodes)
7057cf436c9SEd Tanous         {
706b66cf2a2SNan Zhou             const std::string subQuery = node.uri + *queryStr;
70772c3ae33SNan Zhou             BMCWEB_LOG_DEBUG << "URL of subquery:  " << subQuery;
7087cf436c9SEd Tanous             std::error_code ec;
70972c3ae33SNan Zhou             crow::Request newReq({boost::beast::http::verb::get, subQuery, 11},
7107cf436c9SEd Tanous                                  ec);
7117cf436c9SEd Tanous             if (ec)
7127cf436c9SEd Tanous             {
71372c3ae33SNan Zhou                 messages::internalError(finalRes->res);
7147cf436c9SEd Tanous                 return;
7157cf436c9SEd Tanous             }
7167cf436c9SEd Tanous 
7177cf436c9SEd Tanous             auto asyncResp = std::make_shared<bmcweb::AsyncResp>();
7187cf436c9SEd Tanous             BMCWEB_LOG_DEBUG << "setting completion handler on "
7197cf436c9SEd Tanous                              << &asyncResp->res;
72072c3ae33SNan Zhou 
72172c3ae33SNan Zhou             addAwaitingResponse(asyncResp, node.location);
7227cf436c9SEd Tanous             app.handle(newReq, asyncResp);
7237cf436c9SEd Tanous         }
7247cf436c9SEd Tanous     }
7257cf436c9SEd Tanous 
7267cf436c9SEd Tanous   private:
72772c3ae33SNan Zhou     static void
72872c3ae33SNan Zhou         placeResultStatic(const std::shared_ptr<MultiAsyncResp>& multi,
7297cf436c9SEd Tanous                           const nlohmann::json::json_pointer& locationToPlace,
7307cf436c9SEd Tanous                           crow::Response& res)
7317cf436c9SEd Tanous     {
73272c3ae33SNan Zhou         multi->placeResult(locationToPlace, res);
7337cf436c9SEd Tanous     }
7347cf436c9SEd Tanous 
7357cf436c9SEd Tanous     crow::App& app;
7367cf436c9SEd Tanous     std::shared_ptr<bmcweb::AsyncResp> finalRes;
7377cf436c9SEd Tanous };
7387cf436c9SEd Tanous 
7392a68dc80SEd Tanous inline void processTopAndSkip(const Query& query, crow::Response& res)
7402a68dc80SEd Tanous {
7413648c8beSEd Tanous     if (!query.skip && !query.top)
7423648c8beSEd Tanous     {
7433648c8beSEd Tanous         // No work to do.
7443648c8beSEd Tanous         return;
7453648c8beSEd Tanous     }
7462a68dc80SEd Tanous     nlohmann::json::object_t* obj =
7472a68dc80SEd Tanous         res.jsonValue.get_ptr<nlohmann::json::object_t*>();
7482a68dc80SEd Tanous     if (obj == nullptr)
7492a68dc80SEd Tanous     {
7502a68dc80SEd Tanous         // Shouldn't be possible.  All responses should be objects.
7512a68dc80SEd Tanous         messages::internalError(res);
7522a68dc80SEd Tanous         return;
7532a68dc80SEd Tanous     }
7542a68dc80SEd Tanous 
7552a68dc80SEd Tanous     BMCWEB_LOG_DEBUG << "Handling top/skip";
7562a68dc80SEd Tanous     nlohmann::json::object_t::iterator members = obj->find("Members");
7572a68dc80SEd Tanous     if (members == obj->end())
7582a68dc80SEd Tanous     {
7592a68dc80SEd Tanous         // From the Redfish specification 7.3.1
7602a68dc80SEd Tanous         // ... the HTTP 400 Bad Request status code with the
7612a68dc80SEd Tanous         // QueryNotSupportedOnResource message from the Base Message Registry
7622a68dc80SEd Tanous         // for any supported query parameters that apply only to resource
7632a68dc80SEd Tanous         // collections but are used on singular resources.
7642a68dc80SEd Tanous         messages::queryNotSupportedOnResource(res);
7652a68dc80SEd Tanous         return;
7662a68dc80SEd Tanous     }
7672a68dc80SEd Tanous 
7682a68dc80SEd Tanous     nlohmann::json::array_t* arr =
7692a68dc80SEd Tanous         members->second.get_ptr<nlohmann::json::array_t*>();
7702a68dc80SEd Tanous     if (arr == nullptr)
7712a68dc80SEd Tanous     {
7722a68dc80SEd Tanous         messages::internalError(res);
7732a68dc80SEd Tanous         return;
7742a68dc80SEd Tanous     }
7752a68dc80SEd Tanous 
7763648c8beSEd Tanous     if (query.skip)
7773648c8beSEd Tanous     {
7783648c8beSEd Tanous         // Per section 7.3.1 of the Redfish specification, $skip is run before
7793648c8beSEd Tanous         // $top Can only skip as many values as we have
7803648c8beSEd Tanous         size_t skip = std::min(arr->size(), *query.skip);
7812a68dc80SEd Tanous         arr->erase(arr->begin(), arr->begin() + static_cast<ssize_t>(skip));
7823648c8beSEd Tanous     }
7833648c8beSEd Tanous     if (query.top)
7843648c8beSEd Tanous     {
7853648c8beSEd Tanous         size_t top = std::min(arr->size(), *query.top);
7862a68dc80SEd Tanous         arr->erase(arr->begin() + static_cast<ssize_t>(top), arr->end());
7872a68dc80SEd Tanous     }
7883648c8beSEd Tanous }
7892a68dc80SEd Tanous 
790827c4902SNan Zhou // Given a JSON subtree |currRoot|, this function erases leaves whose keys are
791827c4902SNan Zhou // not in the |currNode| Trie node.
792827c4902SNan Zhou inline void recursiveSelect(nlohmann::json& currRoot,
793827c4902SNan Zhou                             const SelectTrieNode& currNode)
794e155ab54SNan Zhou {
795e155ab54SNan Zhou     nlohmann::json::object_t* object =
796e155ab54SNan Zhou         currRoot.get_ptr<nlohmann::json::object_t*>();
797e155ab54SNan Zhou     if (object != nullptr)
798e155ab54SNan Zhou     {
799827c4902SNan Zhou         BMCWEB_LOG_DEBUG << "Current JSON is an object";
800e155ab54SNan Zhou         auto it = currRoot.begin();
801e155ab54SNan Zhou         while (it != currRoot.end())
802e155ab54SNan Zhou         {
803e155ab54SNan Zhou             auto nextIt = std::next(it);
804827c4902SNan Zhou             BMCWEB_LOG_DEBUG << "key=" << it.key();
805827c4902SNan Zhou             const SelectTrieNode* nextNode = currNode.find(it.key());
806*5c9fb2d6SNan Zhou             // Per the Redfish spec section 7.3.3, the service shall select
807*5c9fb2d6SNan Zhou             // certain properties as if $select was omitted. This applies to
808*5c9fb2d6SNan Zhou             // every TrieNode that contains leaves and the root.
809*5c9fb2d6SNan Zhou             constexpr std::array<std::string_view, 5> reservedProperties = {
810*5c9fb2d6SNan Zhou                 "@odata.id", "@odata.type", "@odata.context", "@odata.etag",
811*5c9fb2d6SNan Zhou                 "error"};
812*5c9fb2d6SNan Zhou             bool reserved =
813*5c9fb2d6SNan Zhou                 std::find(reservedProperties.begin(), reservedProperties.end(),
814*5c9fb2d6SNan Zhou                           it.key()) != reservedProperties.end();
815*5c9fb2d6SNan Zhou             if (reserved || (nextNode != nullptr && nextNode->isSelected()))
816e155ab54SNan Zhou             {
817e155ab54SNan Zhou                 it = nextIt;
818e155ab54SNan Zhou                 continue;
819e155ab54SNan Zhou             }
820827c4902SNan Zhou             if (nextNode != nullptr)
821e155ab54SNan Zhou             {
822827c4902SNan Zhou                 BMCWEB_LOG_DEBUG << "Recursively select: " << it.key();
823827c4902SNan Zhou                 recursiveSelect(*it, *nextNode);
824e155ab54SNan Zhou                 it = nextIt;
825e155ab54SNan Zhou                 continue;
826e155ab54SNan Zhou             }
827827c4902SNan Zhou             BMCWEB_LOG_DEBUG << it.key() << " is getting removed!";
828e155ab54SNan Zhou             it = currRoot.erase(it);
829e155ab54SNan Zhou         }
830e155ab54SNan Zhou     }
831*5c9fb2d6SNan Zhou     nlohmann::json::array_t* array =
832*5c9fb2d6SNan Zhou         currRoot.get_ptr<nlohmann::json::array_t*>();
833*5c9fb2d6SNan Zhou     if (array != nullptr)
834*5c9fb2d6SNan Zhou     {
835*5c9fb2d6SNan Zhou         BMCWEB_LOG_DEBUG << "Current JSON is an array";
836*5c9fb2d6SNan Zhou         // Array index is omitted, so reuse the same Trie node
837*5c9fb2d6SNan Zhou         for (nlohmann::json& nextRoot : *array)
838*5c9fb2d6SNan Zhou         {
839*5c9fb2d6SNan Zhou             recursiveSelect(nextRoot, currNode);
840*5c9fb2d6SNan Zhou         }
841*5c9fb2d6SNan Zhou     }
842e155ab54SNan Zhou }
843e155ab54SNan Zhou 
844e155ab54SNan Zhou // The current implementation of $select still has the following TODOs due to
845e155ab54SNan Zhou //  ambiguity and/or complexity.
846*5c9fb2d6SNan Zhou // 1. combined with $expand; https://github.com/DMTF/Redfish/issues/5058 was
847e155ab54SNan Zhou // created for clarification.
848*5c9fb2d6SNan Zhou // 2. respect the full odata spec; e.g., deduplication, namespace, star (*),
849e155ab54SNan Zhou // etc.
850e155ab54SNan Zhou inline void processSelect(crow::Response& intermediateResponse,
851827c4902SNan Zhou                           const SelectTrieNode& trieRoot)
852e155ab54SNan Zhou {
853e155ab54SNan Zhou     BMCWEB_LOG_DEBUG << "Process $select quary parameter";
854827c4902SNan Zhou     recursiveSelect(intermediateResponse.jsonValue, trieRoot);
855e155ab54SNan Zhou }
856e155ab54SNan Zhou 
8577cf436c9SEd Tanous inline void
858593f6449SNan Zhou     processAllParams(crow::App& app, const Query& query,
8597cf436c9SEd Tanous                      std::function<void(crow::Response&)>& completionHandler,
8607cf436c9SEd Tanous                      crow::Response& intermediateResponse)
861f4c99e70SEd Tanous {
862f4c99e70SEd Tanous     if (!completionHandler)
863f4c99e70SEd Tanous     {
864f4c99e70SEd Tanous         BMCWEB_LOG_DEBUG << "Function was invalid?";
865f4c99e70SEd Tanous         return;
866f4c99e70SEd Tanous     }
867f4c99e70SEd Tanous 
868f4c99e70SEd Tanous     BMCWEB_LOG_DEBUG << "Processing query params";
869f4c99e70SEd Tanous     // If the request failed, there's no reason to even try to run query
870f4c99e70SEd Tanous     // params.
871f4c99e70SEd Tanous     if (intermediateResponse.resultInt() < 200 ||
872f4c99e70SEd Tanous         intermediateResponse.resultInt() >= 400)
873f4c99e70SEd Tanous     {
874f4c99e70SEd Tanous         completionHandler(intermediateResponse);
875f4c99e70SEd Tanous         return;
876f4c99e70SEd Tanous     }
877f4c99e70SEd Tanous     if (query.isOnly)
878f4c99e70SEd Tanous     {
879f4c99e70SEd Tanous         processOnly(app, intermediateResponse, completionHandler);
880f4c99e70SEd Tanous         return;
881f4c99e70SEd Tanous     }
8822a68dc80SEd Tanous 
8833648c8beSEd Tanous     if (query.top || query.skip)
8842a68dc80SEd Tanous     {
8852a68dc80SEd Tanous         processTopAndSkip(query, intermediateResponse);
8862a68dc80SEd Tanous     }
8872a68dc80SEd Tanous 
8887cf436c9SEd Tanous     if (query.expandType != ExpandType::None)
8897cf436c9SEd Tanous     {
8907cf436c9SEd Tanous         BMCWEB_LOG_DEBUG << "Executing expand query";
89113548d85SEd Tanous         auto asyncResp = std::make_shared<bmcweb::AsyncResp>(
89213548d85SEd Tanous             std::move(intermediateResponse));
8937cf436c9SEd Tanous 
89413548d85SEd Tanous         asyncResp->res.setCompleteRequestHandler(std::move(completionHandler));
89513548d85SEd Tanous         auto multi = std::make_shared<MultiAsyncResp>(app, asyncResp);
89672c3ae33SNan Zhou         multi->startQuery(query);
8977cf436c9SEd Tanous         return;
8987cf436c9SEd Tanous     }
899e155ab54SNan Zhou 
900e155ab54SNan Zhou     // According to Redfish Spec Section 7.3.1, $select is the last parameter to
901e155ab54SNan Zhou     // to process
902827c4902SNan Zhou     if (!query.selectTrie.root.empty())
903e155ab54SNan Zhou     {
904827c4902SNan Zhou         processSelect(intermediateResponse, query.selectTrie.root);
905e155ab54SNan Zhou     }
906e155ab54SNan Zhou 
907f4c99e70SEd Tanous     completionHandler(intermediateResponse);
908f4c99e70SEd Tanous }
909f4c99e70SEd Tanous 
910f4c99e70SEd Tanous } // namespace query_param
911f4c99e70SEd Tanous } // namespace redfish
912