xref: /openbmc/linux/security/integrity/ima/ima_appraise.c (revision 4f2946aa0c45c78b4f4ef101bab9694e38c68db0)
1b886d83cSThomas Gleixner // SPDX-License-Identifier: GPL-2.0-only
22fe5d6deSMimi Zohar /*
32fe5d6deSMimi Zohar  * Copyright (C) 2011 IBM Corporation
42fe5d6deSMimi Zohar  *
52fe5d6deSMimi Zohar  * Author:
62fe5d6deSMimi Zohar  * Mimi Zohar <zohar@us.ibm.com>
72fe5d6deSMimi Zohar  */
8b000d5cbSArd Biesheuvel #include <linux/module.h>
9876979c9SPaul Gortmaker #include <linux/init.h>
102fe5d6deSMimi Zohar #include <linux/file.h>
112fe5d6deSMimi Zohar #include <linux/fs.h>
122fe5d6deSMimi Zohar #include <linux/xattr.h>
132fe5d6deSMimi Zohar #include <linux/magic.h>
142fe5d6deSMimi Zohar #include <linux/ima.h>
152fe5d6deSMimi Zohar #include <linux/evm.h>
16273df864SNayna Jain #include <keys/system_keyring.h>
172fe5d6deSMimi Zohar 
182fe5d6deSMimi Zohar #include "ima.h"
192fe5d6deSMimi Zohar 
20e1f5e01fSMimi Zohar #ifdef CONFIG_IMA_APPRAISE_BOOTPARAM
21b000d5cbSArd Biesheuvel static char *ima_appraise_cmdline_default __initdata;
22b000d5cbSArd Biesheuvel core_param(ima_appraise, ima_appraise_cmdline_default, charp, 0);
23b000d5cbSArd Biesheuvel 
24b000d5cbSArd Biesheuvel void __init ima_appraise_parse_cmdline(void)
25b000d5cbSArd Biesheuvel {
26b000d5cbSArd Biesheuvel 	const char *str = ima_appraise_cmdline_default;
27e4d7e2dfSBruno Meneguele 	bool sb_state = arch_ima_get_secureboot();
28e4d7e2dfSBruno Meneguele 	int appraisal_state = ima_appraise;
29311aa6aaSBruno Meneguele 
30b000d5cbSArd Biesheuvel 	if (!str)
31b000d5cbSArd Biesheuvel 		return;
32b000d5cbSArd Biesheuvel 
332fe5d6deSMimi Zohar 	if (strncmp(str, "off", 3) == 0)
34e4d7e2dfSBruno Meneguele 		appraisal_state = 0;
352faa6ef3SDmitry Kasatkin 	else if (strncmp(str, "log", 3) == 0)
36e4d7e2dfSBruno Meneguele 		appraisal_state = IMA_APPRAISE_LOG;
372fe5d6deSMimi Zohar 	else if (strncmp(str, "fix", 3) == 0)
38e4d7e2dfSBruno Meneguele 		appraisal_state = IMA_APPRAISE_FIX;
394afb28abSBruno Meneguele 	else if (strncmp(str, "enforce", 7) == 0)
40e4d7e2dfSBruno Meneguele 		appraisal_state = IMA_APPRAISE_ENFORCE;
417fe2bb7eSBruno Meneguele 	else
427fe2bb7eSBruno Meneguele 		pr_err("invalid \"%s\" appraise option", str);
43e4d7e2dfSBruno Meneguele 
44e4d7e2dfSBruno Meneguele 	/* If appraisal state was changed, but secure boot is enabled,
45e4d7e2dfSBruno Meneguele 	 * keep its default */
46e4d7e2dfSBruno Meneguele 	if (sb_state) {
47e4d7e2dfSBruno Meneguele 		if (!(appraisal_state & IMA_APPRAISE_ENFORCE))
48e4d7e2dfSBruno Meneguele 			pr_info("Secure boot enabled: ignoring ima_appraise=%s option",
49e4d7e2dfSBruno Meneguele 				str);
50e4d7e2dfSBruno Meneguele 	} else {
51e4d7e2dfSBruno Meneguele 		ima_appraise = appraisal_state;
52e4d7e2dfSBruno Meneguele 	}
532fe5d6deSMimi Zohar }
54b000d5cbSArd Biesheuvel #endif
552fe5d6deSMimi Zohar 
562fe5d6deSMimi Zohar /*
576f6723e2SMimi Zohar  * is_ima_appraise_enabled - return appraise status
586f6723e2SMimi Zohar  *
596f6723e2SMimi Zohar  * Only return enabled, if not in ima_appraise="fix" or "log" modes.
606f6723e2SMimi Zohar  */
616f6723e2SMimi Zohar bool is_ima_appraise_enabled(void)
626f6723e2SMimi Zohar {
63e5729f86SThiago Jung Bauermann 	return ima_appraise & IMA_APPRAISE_ENFORCE;
646f6723e2SMimi Zohar }
656f6723e2SMimi Zohar 
666f6723e2SMimi Zohar /*
672fe5d6deSMimi Zohar  * ima_must_appraise - set appraise flag
682fe5d6deSMimi Zohar  *
69da1b0029SMimi Zohar  * Return 1 to appraise or hash
702fe5d6deSMimi Zohar  */
71a2d2329eSChristian Brauner int ima_must_appraise(struct user_namespace *mnt_userns, struct inode *inode,
72a2d2329eSChristian Brauner 		      int mask, enum ima_hooks func)
732fe5d6deSMimi Zohar {
74d906c10dSMatthew Garrett 	u32 secid;
75d906c10dSMatthew Garrett 
7607f6a794SMimi Zohar 	if (!ima_appraise)
772fe5d6deSMimi Zohar 		return 0;
7807f6a794SMimi Zohar 
794ebd7651SPaul Moore 	security_task_getsecid_subj(current, &secid);
801624dc00STHOBY Simon 	return ima_match_policy(mnt_userns, inode, current_cred(), secid,
811624dc00STHOBY Simon 				func, mask, IMA_APPRAISE | IMA_HASH, NULL,
821624dc00STHOBY Simon 				NULL, NULL, NULL);
832fe5d6deSMimi Zohar }
842fe5d6deSMimi Zohar 
85def3e8b9SDmitry Kasatkin static int ima_fix_xattr(struct dentry *dentry,
862fe5d6deSMimi Zohar 			 struct integrity_iint_cache *iint)
872fe5d6deSMimi Zohar {
883ea7a560SDmitry Kasatkin 	int rc, offset;
893ea7a560SDmitry Kasatkin 	u8 algo = iint->ima_hash->algo;
903ea7a560SDmitry Kasatkin 
913ea7a560SDmitry Kasatkin 	if (algo <= HASH_ALGO_SHA1) {
923ea7a560SDmitry Kasatkin 		offset = 1;
933ea7a560SDmitry Kasatkin 		iint->ima_hash->xattr.sha1.type = IMA_XATTR_DIGEST;
943ea7a560SDmitry Kasatkin 	} else {
953ea7a560SDmitry Kasatkin 		offset = 0;
963ea7a560SDmitry Kasatkin 		iint->ima_hash->xattr.ng.type = IMA_XATTR_DIGEST_NG;
973ea7a560SDmitry Kasatkin 		iint->ima_hash->xattr.ng.algo = algo;
983ea7a560SDmitry Kasatkin 	}
99c7c7a1a1STycho Andersen 	rc = __vfs_setxattr_noperm(&init_user_ns, dentry, XATTR_NAME_IMA,
1003ea7a560SDmitry Kasatkin 				   &iint->ima_hash->xattr.data[offset],
1013ea7a560SDmitry Kasatkin 				   (sizeof(iint->ima_hash->xattr) - offset) +
1023ea7a560SDmitry Kasatkin 				   iint->ima_hash->length, 0);
1033ea7a560SDmitry Kasatkin 	return rc;
1042fe5d6deSMimi Zohar }
1052fe5d6deSMimi Zohar 
106d79d72e0SMimi Zohar /* Return specific func appraised cached result */
107d79d72e0SMimi Zohar enum integrity_status ima_get_cache_status(struct integrity_iint_cache *iint,
1084ad87a3dSMimi Zohar 					   enum ima_hooks func)
109d79d72e0SMimi Zohar {
110d79d72e0SMimi Zohar 	switch (func) {
111d79d72e0SMimi Zohar 	case MMAP_CHECK:
112d79d72e0SMimi Zohar 		return iint->ima_mmap_status;
113d79d72e0SMimi Zohar 	case BPRM_CHECK:
114d79d72e0SMimi Zohar 		return iint->ima_bprm_status;
115d906c10dSMatthew Garrett 	case CREDS_CHECK:
116d906c10dSMatthew Garrett 		return iint->ima_creds_status;
117d79d72e0SMimi Zohar 	case FILE_CHECK:
118c6af8efeSMimi Zohar 	case POST_SETATTR:
119d79d72e0SMimi Zohar 		return iint->ima_file_status;
120c6af8efeSMimi Zohar 	case MODULE_CHECK ... MAX_CHECK - 1:
121c6af8efeSMimi Zohar 	default:
122c6af8efeSMimi Zohar 		return iint->ima_read_status;
123d79d72e0SMimi Zohar 	}
124d79d72e0SMimi Zohar }
125d79d72e0SMimi Zohar 
126d79d72e0SMimi Zohar static void ima_set_cache_status(struct integrity_iint_cache *iint,
1274ad87a3dSMimi Zohar 				 enum ima_hooks func,
1284ad87a3dSMimi Zohar 				 enum integrity_status status)
129d79d72e0SMimi Zohar {
130d79d72e0SMimi Zohar 	switch (func) {
131d79d72e0SMimi Zohar 	case MMAP_CHECK:
132d79d72e0SMimi Zohar 		iint->ima_mmap_status = status;
133d79d72e0SMimi Zohar 		break;
134d79d72e0SMimi Zohar 	case BPRM_CHECK:
135d79d72e0SMimi Zohar 		iint->ima_bprm_status = status;
136d79d72e0SMimi Zohar 		break;
137d906c10dSMatthew Garrett 	case CREDS_CHECK:
138d906c10dSMatthew Garrett 		iint->ima_creds_status = status;
13909186e50SGustavo A. R. Silva 		break;
140d79d72e0SMimi Zohar 	case FILE_CHECK:
141c6af8efeSMimi Zohar 	case POST_SETATTR:
142d79d72e0SMimi Zohar 		iint->ima_file_status = status;
143c6af8efeSMimi Zohar 		break;
144c6af8efeSMimi Zohar 	case MODULE_CHECK ... MAX_CHECK - 1:
145c6af8efeSMimi Zohar 	default:
146c6af8efeSMimi Zohar 		iint->ima_read_status = status;
147c6af8efeSMimi Zohar 		break;
148d79d72e0SMimi Zohar 	}
149d79d72e0SMimi Zohar }
150d79d72e0SMimi Zohar 
1514ad87a3dSMimi Zohar static void ima_cache_flags(struct integrity_iint_cache *iint,
1524ad87a3dSMimi Zohar 			     enum ima_hooks func)
153d79d72e0SMimi Zohar {
154d79d72e0SMimi Zohar 	switch (func) {
155d79d72e0SMimi Zohar 	case MMAP_CHECK:
156d79d72e0SMimi Zohar 		iint->flags |= (IMA_MMAP_APPRAISED | IMA_APPRAISED);
157d79d72e0SMimi Zohar 		break;
158d79d72e0SMimi Zohar 	case BPRM_CHECK:
159d79d72e0SMimi Zohar 		iint->flags |= (IMA_BPRM_APPRAISED | IMA_APPRAISED);
160d79d72e0SMimi Zohar 		break;
161d906c10dSMatthew Garrett 	case CREDS_CHECK:
162d906c10dSMatthew Garrett 		iint->flags |= (IMA_CREDS_APPRAISED | IMA_APPRAISED);
163d906c10dSMatthew Garrett 		break;
164d79d72e0SMimi Zohar 	case FILE_CHECK:
165c6af8efeSMimi Zohar 	case POST_SETATTR:
166d79d72e0SMimi Zohar 		iint->flags |= (IMA_FILE_APPRAISED | IMA_APPRAISED);
167c6af8efeSMimi Zohar 		break;
168c6af8efeSMimi Zohar 	case MODULE_CHECK ... MAX_CHECK - 1:
169c6af8efeSMimi Zohar 	default:
170c6af8efeSMimi Zohar 		iint->flags |= (IMA_READ_APPRAISED | IMA_APPRAISED);
171c6af8efeSMimi Zohar 		break;
172d79d72e0SMimi Zohar 	}
173d79d72e0SMimi Zohar }
174d79d72e0SMimi Zohar 
17550f742ddSTHOBY Simon enum hash_algo ima_get_hash_algo(const struct evm_ima_xattr_data *xattr_value,
1761525b06dSDmitry Kasatkin 				 int xattr_len)
177d3634d0fSDmitry Kasatkin {
178d3634d0fSDmitry Kasatkin 	struct signature_v2_hdr *sig;
179b4bfec7fSSeth Forshee 	enum hash_algo ret;
180d3634d0fSDmitry Kasatkin 
1813ea7a560SDmitry Kasatkin 	if (!xattr_value || xattr_len < 2)
1821525b06dSDmitry Kasatkin 		/* return default hash algo */
1831525b06dSDmitry Kasatkin 		return ima_hash_algo;
184d3634d0fSDmitry Kasatkin 
1853ea7a560SDmitry Kasatkin 	switch (xattr_value->type) {
1863ea7a560SDmitry Kasatkin 	case EVM_IMA_XATTR_DIGSIG:
1873ea7a560SDmitry Kasatkin 		sig = (typeof(sig))xattr_value;
1883ea7a560SDmitry Kasatkin 		if (sig->version != 2 || xattr_len <= sizeof(*sig))
1891525b06dSDmitry Kasatkin 			return ima_hash_algo;
1901525b06dSDmitry Kasatkin 		return sig->hash_algo;
1913ea7a560SDmitry Kasatkin 		break;
1923ea7a560SDmitry Kasatkin 	case IMA_XATTR_DIGEST_NG:
193650b29dbSThiago Jung Bauermann 		/* first byte contains algorithm id */
194650b29dbSThiago Jung Bauermann 		ret = xattr_value->data[0];
195b4bfec7fSSeth Forshee 		if (ret < HASH_ALGO__LAST)
196b4bfec7fSSeth Forshee 			return ret;
1973ea7a560SDmitry Kasatkin 		break;
1983ea7a560SDmitry Kasatkin 	case IMA_XATTR_DIGEST:
1993ea7a560SDmitry Kasatkin 		/* this is for backward compatibility */
2003ea7a560SDmitry Kasatkin 		if (xattr_len == 21) {
2013ea7a560SDmitry Kasatkin 			unsigned int zero = 0;
202650b29dbSThiago Jung Bauermann 			if (!memcmp(&xattr_value->data[16], &zero, 4))
2031525b06dSDmitry Kasatkin 				return HASH_ALGO_MD5;
2043ea7a560SDmitry Kasatkin 			else
2051525b06dSDmitry Kasatkin 				return HASH_ALGO_SHA1;
2063ea7a560SDmitry Kasatkin 		} else if (xattr_len == 17)
2071525b06dSDmitry Kasatkin 			return HASH_ALGO_MD5;
2083ea7a560SDmitry Kasatkin 		break;
2093ea7a560SDmitry Kasatkin 	}
2101525b06dSDmitry Kasatkin 
2111525b06dSDmitry Kasatkin 	/* return default hash algo */
2121525b06dSDmitry Kasatkin 	return ima_hash_algo;
213d3634d0fSDmitry Kasatkin }
214d3634d0fSDmitry Kasatkin 
215d3634d0fSDmitry Kasatkin int ima_read_xattr(struct dentry *dentry,
216d3634d0fSDmitry Kasatkin 		   struct evm_ima_xattr_data **xattr_value)
217d3634d0fSDmitry Kasatkin {
2185d6c3191SAndreas Gruenbacher 	ssize_t ret;
219d3634d0fSDmitry Kasatkin 
220c7c7a1a1STycho Andersen 	ret = vfs_getxattr_alloc(&init_user_ns, dentry, XATTR_NAME_IMA,
221c7c7a1a1STycho Andersen 				 (char **)xattr_value, 0, GFP_NOFS);
2225d6c3191SAndreas Gruenbacher 	if (ret == -EOPNOTSUPP)
2235d6c3191SAndreas Gruenbacher 		ret = 0;
2245d6c3191SAndreas Gruenbacher 	return ret;
225d3634d0fSDmitry Kasatkin }
226d3634d0fSDmitry Kasatkin 
2272fe5d6deSMimi Zohar /*
228a5fbeb61SThiago Jung Bauermann  * xattr_verify - verify xattr digest or signature
229a5fbeb61SThiago Jung Bauermann  *
230a5fbeb61SThiago Jung Bauermann  * Verify whether the hash or signature matches the file contents.
231a5fbeb61SThiago Jung Bauermann  *
232a5fbeb61SThiago Jung Bauermann  * Return 0 on success, error code otherwise.
233a5fbeb61SThiago Jung Bauermann  */
234a5fbeb61SThiago Jung Bauermann static int xattr_verify(enum ima_hooks func, struct integrity_iint_cache *iint,
235a5fbeb61SThiago Jung Bauermann 			struct evm_ima_xattr_data *xattr_value, int xattr_len,
236a5fbeb61SThiago Jung Bauermann 			enum integrity_status *status, const char **cause)
237a5fbeb61SThiago Jung Bauermann {
238a5fbeb61SThiago Jung Bauermann 	int rc = -EINVAL, hash_start = 0;
239a5fbeb61SThiago Jung Bauermann 
240a5fbeb61SThiago Jung Bauermann 	switch (xattr_value->type) {
241a5fbeb61SThiago Jung Bauermann 	case IMA_XATTR_DIGEST_NG:
242a5fbeb61SThiago Jung Bauermann 		/* first byte contains algorithm id */
243a5fbeb61SThiago Jung Bauermann 		hash_start = 1;
244df561f66SGustavo A. R. Silva 		fallthrough;
245a5fbeb61SThiago Jung Bauermann 	case IMA_XATTR_DIGEST:
2467aa5783dSRoberto Sassu 		if (*status != INTEGRITY_PASS_IMMUTABLE) {
247a5fbeb61SThiago Jung Bauermann 			if (iint->flags & IMA_DIGSIG_REQUIRED) {
248a5fbeb61SThiago Jung Bauermann 				*cause = "IMA-signature-required";
249a5fbeb61SThiago Jung Bauermann 				*status = INTEGRITY_FAIL;
250a5fbeb61SThiago Jung Bauermann 				break;
251a5fbeb61SThiago Jung Bauermann 			}
252a5fbeb61SThiago Jung Bauermann 			clear_bit(IMA_DIGSIG, &iint->atomic_flags);
2537aa5783dSRoberto Sassu 		} else {
2547aa5783dSRoberto Sassu 			set_bit(IMA_DIGSIG, &iint->atomic_flags);
2557aa5783dSRoberto Sassu 		}
256a5fbeb61SThiago Jung Bauermann 		if (xattr_len - sizeof(xattr_value->type) - hash_start >=
257a5fbeb61SThiago Jung Bauermann 				iint->ima_hash->length)
258a5fbeb61SThiago Jung Bauermann 			/*
259a5fbeb61SThiago Jung Bauermann 			 * xattr length may be longer. md5 hash in previous
260a5fbeb61SThiago Jung Bauermann 			 * version occupied 20 bytes in xattr, instead of 16
261a5fbeb61SThiago Jung Bauermann 			 */
262a5fbeb61SThiago Jung Bauermann 			rc = memcmp(&xattr_value->data[hash_start],
263a5fbeb61SThiago Jung Bauermann 				    iint->ima_hash->digest,
264a5fbeb61SThiago Jung Bauermann 				    iint->ima_hash->length);
265a5fbeb61SThiago Jung Bauermann 		else
266a5fbeb61SThiago Jung Bauermann 			rc = -EINVAL;
267a5fbeb61SThiago Jung Bauermann 		if (rc) {
268a5fbeb61SThiago Jung Bauermann 			*cause = "invalid-hash";
269a5fbeb61SThiago Jung Bauermann 			*status = INTEGRITY_FAIL;
270a5fbeb61SThiago Jung Bauermann 			break;
271a5fbeb61SThiago Jung Bauermann 		}
272a5fbeb61SThiago Jung Bauermann 		*status = INTEGRITY_PASS;
273a5fbeb61SThiago Jung Bauermann 		break;
274a5fbeb61SThiago Jung Bauermann 	case EVM_IMA_XATTR_DIGSIG:
275a5fbeb61SThiago Jung Bauermann 		set_bit(IMA_DIGSIG, &iint->atomic_flags);
276a5fbeb61SThiago Jung Bauermann 		rc = integrity_digsig_verify(INTEGRITY_KEYRING_IMA,
277a5fbeb61SThiago Jung Bauermann 					     (const char *)xattr_value,
278a5fbeb61SThiago Jung Bauermann 					     xattr_len,
279a5fbeb61SThiago Jung Bauermann 					     iint->ima_hash->digest,
280a5fbeb61SThiago Jung Bauermann 					     iint->ima_hash->length);
281a5fbeb61SThiago Jung Bauermann 		if (rc == -EOPNOTSUPP) {
282a5fbeb61SThiago Jung Bauermann 			*status = INTEGRITY_UNKNOWN;
283a5fbeb61SThiago Jung Bauermann 			break;
284a5fbeb61SThiago Jung Bauermann 		}
285a5fbeb61SThiago Jung Bauermann 		if (IS_ENABLED(CONFIG_INTEGRITY_PLATFORM_KEYRING) && rc &&
286a5fbeb61SThiago Jung Bauermann 		    func == KEXEC_KERNEL_CHECK)
287a5fbeb61SThiago Jung Bauermann 			rc = integrity_digsig_verify(INTEGRITY_KEYRING_PLATFORM,
288a5fbeb61SThiago Jung Bauermann 						     (const char *)xattr_value,
289a5fbeb61SThiago Jung Bauermann 						     xattr_len,
290a5fbeb61SThiago Jung Bauermann 						     iint->ima_hash->digest,
291a5fbeb61SThiago Jung Bauermann 						     iint->ima_hash->length);
292a5fbeb61SThiago Jung Bauermann 		if (rc) {
293a5fbeb61SThiago Jung Bauermann 			*cause = "invalid-signature";
294a5fbeb61SThiago Jung Bauermann 			*status = INTEGRITY_FAIL;
295a5fbeb61SThiago Jung Bauermann 		} else {
296a5fbeb61SThiago Jung Bauermann 			*status = INTEGRITY_PASS;
297a5fbeb61SThiago Jung Bauermann 		}
298a5fbeb61SThiago Jung Bauermann 		break;
299a5fbeb61SThiago Jung Bauermann 	default:
300a5fbeb61SThiago Jung Bauermann 		*status = INTEGRITY_UNKNOWN;
301a5fbeb61SThiago Jung Bauermann 		*cause = "unknown-ima-data";
302a5fbeb61SThiago Jung Bauermann 		break;
303a5fbeb61SThiago Jung Bauermann 	}
304a5fbeb61SThiago Jung Bauermann 
305a5fbeb61SThiago Jung Bauermann 	return rc;
306a5fbeb61SThiago Jung Bauermann }
307a5fbeb61SThiago Jung Bauermann 
308a5fbeb61SThiago Jung Bauermann /*
30939b07096SThiago Jung Bauermann  * modsig_verify - verify modsig signature
31039b07096SThiago Jung Bauermann  *
31139b07096SThiago Jung Bauermann  * Verify whether the signature matches the file contents.
31239b07096SThiago Jung Bauermann  *
31339b07096SThiago Jung Bauermann  * Return 0 on success, error code otherwise.
31439b07096SThiago Jung Bauermann  */
31539b07096SThiago Jung Bauermann static int modsig_verify(enum ima_hooks func, const struct modsig *modsig,
31639b07096SThiago Jung Bauermann 			 enum integrity_status *status, const char **cause)
31739b07096SThiago Jung Bauermann {
31839b07096SThiago Jung Bauermann 	int rc;
31939b07096SThiago Jung Bauermann 
32039b07096SThiago Jung Bauermann 	rc = integrity_modsig_verify(INTEGRITY_KEYRING_IMA, modsig);
32139b07096SThiago Jung Bauermann 	if (IS_ENABLED(CONFIG_INTEGRITY_PLATFORM_KEYRING) && rc &&
32239b07096SThiago Jung Bauermann 	    func == KEXEC_KERNEL_CHECK)
32339b07096SThiago Jung Bauermann 		rc = integrity_modsig_verify(INTEGRITY_KEYRING_PLATFORM,
32439b07096SThiago Jung Bauermann 					     modsig);
32539b07096SThiago Jung Bauermann 	if (rc) {
32639b07096SThiago Jung Bauermann 		*cause = "invalid-signature";
32739b07096SThiago Jung Bauermann 		*status = INTEGRITY_FAIL;
32839b07096SThiago Jung Bauermann 	} else {
32939b07096SThiago Jung Bauermann 		*status = INTEGRITY_PASS;
33039b07096SThiago Jung Bauermann 	}
33139b07096SThiago Jung Bauermann 
33239b07096SThiago Jung Bauermann 	return rc;
33339b07096SThiago Jung Bauermann }
33439b07096SThiago Jung Bauermann 
33539b07096SThiago Jung Bauermann /*
336273df864SNayna Jain  * ima_check_blacklist - determine if the binary is blacklisted.
337273df864SNayna Jain  *
338273df864SNayna Jain  * Add the hash of the blacklisted binary to the measurement list, based
339273df864SNayna Jain  * on policy.
340273df864SNayna Jain  *
341273df864SNayna Jain  * Returns -EPERM if the hash is blacklisted.
342273df864SNayna Jain  */
343273df864SNayna Jain int ima_check_blacklist(struct integrity_iint_cache *iint,
344273df864SNayna Jain 			const struct modsig *modsig, int pcr)
345273df864SNayna Jain {
346273df864SNayna Jain 	enum hash_algo hash_algo;
347273df864SNayna Jain 	const u8 *digest = NULL;
348273df864SNayna Jain 	u32 digestsize = 0;
349273df864SNayna Jain 	int rc = 0;
350273df864SNayna Jain 
351273df864SNayna Jain 	if (!(iint->flags & IMA_CHECK_BLACKLIST))
352273df864SNayna Jain 		return 0;
353273df864SNayna Jain 
354273df864SNayna Jain 	if (iint->flags & IMA_MODSIG_ALLOWED && modsig) {
355273df864SNayna Jain 		ima_get_modsig_digest(modsig, &hash_algo, &digest, &digestsize);
356273df864SNayna Jain 
357273df864SNayna Jain 		rc = is_binary_blacklisted(digest, digestsize);
358273df864SNayna Jain 		if ((rc == -EPERM) && (iint->flags & IMA_MEASURE))
359a2d2329eSChristian Brauner 			process_buffer_measurement(&init_user_ns, NULL, digest, digestsize,
360273df864SNayna Jain 						   "blacklisted-hash", NONE,
361ca3c9bdbSRoberto Sassu 						   pcr, NULL, false, NULL, 0);
362273df864SNayna Jain 	}
363273df864SNayna Jain 
364273df864SNayna Jain 	return rc;
365273df864SNayna Jain }
366273df864SNayna Jain 
367273df864SNayna Jain /*
3682fe5d6deSMimi Zohar  * ima_appraise_measurement - appraise file measurement
3692fe5d6deSMimi Zohar  *
3702fe5d6deSMimi Zohar  * Call evm_verifyxattr() to verify the integrity of 'security.ima'.
3712fe5d6deSMimi Zohar  * Assuming success, compare the xattr hash with the collected measurement.
3722fe5d6deSMimi Zohar  *
3732fe5d6deSMimi Zohar  * Return 0 on success, error code otherwise
3742fe5d6deSMimi Zohar  */
3754ad87a3dSMimi Zohar int ima_appraise_measurement(enum ima_hooks func,
3764ad87a3dSMimi Zohar 			     struct integrity_iint_cache *iint,
377d3634d0fSDmitry Kasatkin 			     struct file *file, const unsigned char *filename,
378d3634d0fSDmitry Kasatkin 			     struct evm_ima_xattr_data *xattr_value,
37939b07096SThiago Jung Bauermann 			     int xattr_len, const struct modsig *modsig)
3802fe5d6deSMimi Zohar {
38152a13284SMimi Zohar 	static const char op[] = "appraise_data";
382f5e51fa3SThiago Jung Bauermann 	const char *cause = "unknown";
383e71b9dffSMiklos Szeredi 	struct dentry *dentry = file_dentry(file);
384c6f493d6SDavid Howells 	struct inode *inode = d_backing_inode(dentry);
3852fe5d6deSMimi Zohar 	enum integrity_status status = INTEGRITY_UNKNOWN;
386a5fbeb61SThiago Jung Bauermann 	int rc = xattr_len;
38739b07096SThiago Jung Bauermann 	bool try_modsig = iint->flags & IMA_MODSIG_ALLOWED && modsig;
3882fe5d6deSMimi Zohar 
38939b07096SThiago Jung Bauermann 	/* If not appraising a modsig, we need an xattr. */
39039b07096SThiago Jung Bauermann 	if (!(inode->i_opflags & IOP_XATTR) && !try_modsig)
3912fe5d6deSMimi Zohar 		return INTEGRITY_UNKNOWN;
3922fe5d6deSMimi Zohar 
39339b07096SThiago Jung Bauermann 	/* If reading the xattr failed and there's no modsig, error out. */
39439b07096SThiago Jung Bauermann 	if (rc <= 0 && !try_modsig) {
3952fe5d6deSMimi Zohar 		if (rc && rc != -ENODATA)
3962fe5d6deSMimi Zohar 			goto out;
3972fe5d6deSMimi Zohar 
398915d9d25SThiago Jung Bauermann 		cause = iint->flags & IMA_DIGSIG_REQUIRED ?
399915d9d25SThiago Jung Bauermann 				"IMA-signature-required" : "missing-hash";
400b151d6b0SDmitry Kasatkin 		status = INTEGRITY_NOLABEL;
4016035a27bSAl Viro 		if (file->f_mode & FMODE_CREATED)
402b151d6b0SDmitry Kasatkin 			iint->flags |= IMA_NEW_FILE;
4031ac202e9SDaniel Glöckner 		if ((iint->flags & IMA_NEW_FILE) &&
404b7e27bc1SMimi Zohar 		    (!(iint->flags & IMA_DIGSIG_REQUIRED) ||
405b7e27bc1SMimi Zohar 		     (inode->i_size == 0)))
406b151d6b0SDmitry Kasatkin 			status = INTEGRITY_PASS;
4072fe5d6deSMimi Zohar 		goto out;
4082fe5d6deSMimi Zohar 	}
4092fe5d6deSMimi Zohar 
4108606404fSDmitry Kasatkin 	status = evm_verifyxattr(dentry, XATTR_NAME_IMA, xattr_value, rc, iint);
411f5e51fa3SThiago Jung Bauermann 	switch (status) {
412f5e51fa3SThiago Jung Bauermann 	case INTEGRITY_PASS:
413f5e51fa3SThiago Jung Bauermann 	case INTEGRITY_PASS_IMMUTABLE:
414f5e51fa3SThiago Jung Bauermann 	case INTEGRITY_UNKNOWN:
415f5e51fa3SThiago Jung Bauermann 		break;
416f5e51fa3SThiago Jung Bauermann 	case INTEGRITY_NOXATTRS:	/* No EVM protected xattrs. */
41739b07096SThiago Jung Bauermann 		/* It's fine not to have xattrs when using a modsig. */
41839b07096SThiago Jung Bauermann 		if (try_modsig)
41939b07096SThiago Jung Bauermann 			break;
420df561f66SGustavo A. R. Silva 		fallthrough;
421f5e51fa3SThiago Jung Bauermann 	case INTEGRITY_NOLABEL:		/* No security.evm xattr. */
4222fe5d6deSMimi Zohar 		cause = "missing-HMAC";
423f5e51fa3SThiago Jung Bauermann 		goto out;
424cdef685bSRoberto Sassu 	case INTEGRITY_FAIL_IMMUTABLE:
4257aa5783dSRoberto Sassu 		set_bit(IMA_DIGSIG, &iint->atomic_flags);
42655748ac6SMimi Zohar 		cause = "invalid-fail-immutable";
42755748ac6SMimi Zohar 		goto out;
428f5e51fa3SThiago Jung Bauermann 	case INTEGRITY_FAIL:		/* Invalid HMAC/signature. */
4292fe5d6deSMimi Zohar 		cause = "invalid-HMAC";
4302fe5d6deSMimi Zohar 		goto out;
431f5e51fa3SThiago Jung Bauermann 	default:
432f5e51fa3SThiago Jung Bauermann 		WARN_ONCE(true, "Unexpected integrity status %d\n", status);
4332fe5d6deSMimi Zohar 	}
434f5e51fa3SThiago Jung Bauermann 
435a5fbeb61SThiago Jung Bauermann 	if (xattr_value)
436a5fbeb61SThiago Jung Bauermann 		rc = xattr_verify(func, iint, xattr_value, xattr_len, &status,
437a5fbeb61SThiago Jung Bauermann 				  &cause);
4388606404fSDmitry Kasatkin 
43939b07096SThiago Jung Bauermann 	/*
44039b07096SThiago Jung Bauermann 	 * If we have a modsig and either no imasig or the imasig's key isn't
44139b07096SThiago Jung Bauermann 	 * known, then try verifying the modsig.
44239b07096SThiago Jung Bauermann 	 */
44339b07096SThiago Jung Bauermann 	if (try_modsig &&
44439b07096SThiago Jung Bauermann 	    (!xattr_value || xattr_value->type == IMA_XATTR_DIGEST_NG ||
44539b07096SThiago Jung Bauermann 	     rc == -ENOKEY))
44639b07096SThiago Jung Bauermann 		rc = modsig_verify(func, modsig, &status, &cause);
44739b07096SThiago Jung Bauermann 
4482fe5d6deSMimi Zohar out:
44957b56ac6SMimi Zohar 	/*
45057b56ac6SMimi Zohar 	 * File signatures on some filesystems can not be properly verified.
4519e67028eSMimi Zohar 	 * When such filesystems are mounted by an untrusted mounter or on a
4529e67028eSMimi Zohar 	 * system not willing to accept such a risk, fail the file signature
4539e67028eSMimi Zohar 	 * verification.
45457b56ac6SMimi Zohar 	 */
4559e67028eSMimi Zohar 	if ((inode->i_sb->s_iflags & SB_I_IMA_UNVERIFIABLE_SIGNATURE) &&
4569e67028eSMimi Zohar 	    ((inode->i_sb->s_iflags & SB_I_UNTRUSTED_MOUNTER) ||
4579e67028eSMimi Zohar 	     (iint->flags & IMA_FAIL_UNVERIFIABLE_SIGS))) {
45857b56ac6SMimi Zohar 		status = INTEGRITY_FAIL;
45957b56ac6SMimi Zohar 		cause = "unverifiable-signature";
46057b56ac6SMimi Zohar 		integrity_audit_msg(AUDIT_INTEGRITY_DATA, inode, filename,
46157b56ac6SMimi Zohar 				    op, cause, rc, 0);
46257b56ac6SMimi Zohar 	} else if (status != INTEGRITY_PASS) {
463f5e51fa3SThiago Jung Bauermann 		/* Fix mode, but don't replace file signatures. */
46439b07096SThiago Jung Bauermann 		if ((ima_appraise & IMA_APPRAISE_FIX) && !try_modsig &&
4658606404fSDmitry Kasatkin 		    (!xattr_value ||
4668606404fSDmitry Kasatkin 		     xattr_value->type != EVM_IMA_XATTR_DIGSIG)) {
467def3e8b9SDmitry Kasatkin 			if (!ima_fix_xattr(dentry, iint))
4682fe5d6deSMimi Zohar 				status = INTEGRITY_PASS;
469f5e51fa3SThiago Jung Bauermann 		}
470f5e51fa3SThiago Jung Bauermann 
4717aa5783dSRoberto Sassu 		/*
4727aa5783dSRoberto Sassu 		 * Permit new files with file/EVM portable signatures, but
4737aa5783dSRoberto Sassu 		 * without data.
4747aa5783dSRoberto Sassu 		 */
475f5e51fa3SThiago Jung Bauermann 		if (inode->i_size == 0 && iint->flags & IMA_NEW_FILE &&
4767aa5783dSRoberto Sassu 		    test_bit(IMA_DIGSIG, &iint->atomic_flags)) {
47705d1a717SMimi Zohar 			status = INTEGRITY_PASS;
4782fe5d6deSMimi Zohar 		}
479f5e51fa3SThiago Jung Bauermann 
4802fe5d6deSMimi Zohar 		integrity_audit_msg(AUDIT_INTEGRITY_DATA, inode, filename,
4812fe5d6deSMimi Zohar 				    op, cause, rc, 0);
4828606404fSDmitry Kasatkin 	} else {
483d79d72e0SMimi Zohar 		ima_cache_flags(iint, func);
4842fe5d6deSMimi Zohar 	}
48557b56ac6SMimi Zohar 
486d79d72e0SMimi Zohar 	ima_set_cache_status(iint, func, status);
4872fe5d6deSMimi Zohar 	return status;
4882fe5d6deSMimi Zohar }
4892fe5d6deSMimi Zohar 
4902fe5d6deSMimi Zohar /*
4912fe5d6deSMimi Zohar  * ima_update_xattr - update 'security.ima' hash value
4922fe5d6deSMimi Zohar  */
4932fe5d6deSMimi Zohar void ima_update_xattr(struct integrity_iint_cache *iint, struct file *file)
4942fe5d6deSMimi Zohar {
495e71b9dffSMiklos Szeredi 	struct dentry *dentry = file_dentry(file);
4962fe5d6deSMimi Zohar 	int rc = 0;
4972fe5d6deSMimi Zohar 
4988606404fSDmitry Kasatkin 	/* do not collect and update hash for digital signatures */
4990d73a552SDmitry Kasatkin 	if (test_bit(IMA_DIGSIG, &iint->atomic_flags))
5008606404fSDmitry Kasatkin 		return;
5018606404fSDmitry Kasatkin 
502da1b0029SMimi Zohar 	if ((iint->ima_file_status != INTEGRITY_PASS) &&
503da1b0029SMimi Zohar 	    !(iint->flags & IMA_HASH))
504020aae3eSRoberto Sassu 		return;
505020aae3eSRoberto Sassu 
50615588227SThiago Jung Bauermann 	rc = ima_collect_measurement(iint, file, NULL, 0, ima_hash_algo, NULL);
5072fe5d6deSMimi Zohar 	if (rc < 0)
5082fe5d6deSMimi Zohar 		return;
5098606404fSDmitry Kasatkin 
5100d73a552SDmitry Kasatkin 	inode_lock(file_inode(file));
5112fe5d6deSMimi Zohar 	ima_fix_xattr(dentry, iint);
5120d73a552SDmitry Kasatkin 	inode_unlock(file_inode(file));
5132fe5d6deSMimi Zohar }
5142fe5d6deSMimi Zohar 
5152fe5d6deSMimi Zohar /**
5162fe5d6deSMimi Zohar  * ima_inode_post_setattr - reflect file metadata changes
517a2d2329eSChristian Brauner  * @mnt_userns:	user namespace of the mount the inode was found from
5182fe5d6deSMimi Zohar  * @dentry: pointer to the affected dentry
5192fe5d6deSMimi Zohar  *
5202fe5d6deSMimi Zohar  * Changes to a dentry's metadata might result in needing to appraise.
5212fe5d6deSMimi Zohar  *
5222fe5d6deSMimi Zohar  * This function is called from notify_change(), which expects the caller
5232fe5d6deSMimi Zohar  * to lock the inode's i_mutex.
5242fe5d6deSMimi Zohar  */
525a2d2329eSChristian Brauner void ima_inode_post_setattr(struct user_namespace *mnt_userns,
526a2d2329eSChristian Brauner 			    struct dentry *dentry)
5272fe5d6deSMimi Zohar {
528c6f493d6SDavid Howells 	struct inode *inode = d_backing_inode(dentry);
5292fe5d6deSMimi Zohar 	struct integrity_iint_cache *iint;
530da1b0029SMimi Zohar 	int action;
5312fe5d6deSMimi Zohar 
532a756024eSRoberto Sassu 	if (!(ima_policy_flag & IMA_APPRAISE) || !S_ISREG(inode->i_mode)
5335d6c3191SAndreas Gruenbacher 	    || !(inode->i_opflags & IOP_XATTR))
5342fe5d6deSMimi Zohar 		return;
5352fe5d6deSMimi Zohar 
536a2d2329eSChristian Brauner 	action = ima_must_appraise(mnt_userns, inode, MAY_ACCESS, POST_SETATTR);
5370d73a552SDmitry Kasatkin 	iint = integrity_iint_find(inode);
5380d73a552SDmitry Kasatkin 	if (iint) {
5390d73a552SDmitry Kasatkin 		set_bit(IMA_CHANGE_ATTR, &iint->atomic_flags);
540da1b0029SMimi Zohar 		if (!action)
5410d73a552SDmitry Kasatkin 			clear_bit(IMA_UPDATE_XATTR, &iint->atomic_flags);
5420d73a552SDmitry Kasatkin 	}
5432fe5d6deSMimi Zohar }
54442c63330SMimi Zohar 
54542c63330SMimi Zohar /*
54642c63330SMimi Zohar  * ima_protect_xattr - protect 'security.ima'
54742c63330SMimi Zohar  *
54842c63330SMimi Zohar  * Ensure that not just anyone can modify or remove 'security.ima'.
54942c63330SMimi Zohar  */
55042c63330SMimi Zohar static int ima_protect_xattr(struct dentry *dentry, const char *xattr_name,
55142c63330SMimi Zohar 			     const void *xattr_value, size_t xattr_value_len)
55242c63330SMimi Zohar {
55342c63330SMimi Zohar 	if (strcmp(xattr_name, XATTR_NAME_IMA) == 0) {
55442c63330SMimi Zohar 		if (!capable(CAP_SYS_ADMIN))
55542c63330SMimi Zohar 			return -EPERM;
55642c63330SMimi Zohar 		return 1;
55742c63330SMimi Zohar 	}
55842c63330SMimi Zohar 	return 0;
55942c63330SMimi Zohar }
56042c63330SMimi Zohar 
561060bdebfSMimi Zohar static void ima_reset_appraise_flags(struct inode *inode, int digsig)
56242c63330SMimi Zohar {
56342c63330SMimi Zohar 	struct integrity_iint_cache *iint;
56442c63330SMimi Zohar 
565a756024eSRoberto Sassu 	if (!(ima_policy_flag & IMA_APPRAISE) || !S_ISREG(inode->i_mode))
56642c63330SMimi Zohar 		return;
56742c63330SMimi Zohar 
56842c63330SMimi Zohar 	iint = integrity_iint_find(inode);
56942c63330SMimi Zohar 	if (!iint)
57042c63330SMimi Zohar 		return;
571a422638dSEric Richter 	iint->measured_pcrs = 0;
5720d73a552SDmitry Kasatkin 	set_bit(IMA_CHANGE_XATTR, &iint->atomic_flags);
573060bdebfSMimi Zohar 	if (digsig)
5740d73a552SDmitry Kasatkin 		set_bit(IMA_DIGSIG, &iint->atomic_flags);
5750d73a552SDmitry Kasatkin 	else
5760d73a552SDmitry Kasatkin 		clear_bit(IMA_DIGSIG, &iint->atomic_flags);
57742c63330SMimi Zohar }
57842c63330SMimi Zohar 
57950f742ddSTHOBY Simon /**
58050f742ddSTHOBY Simon  * validate_hash_algo() - Block setxattr with unsupported hash algorithms
58150f742ddSTHOBY Simon  * @dentry: object of the setxattr()
58250f742ddSTHOBY Simon  * @xattr_value: userland supplied xattr value
58350f742ddSTHOBY Simon  * @xattr_value_len: length of xattr_value
58450f742ddSTHOBY Simon  *
58550f742ddSTHOBY Simon  * The xattr value is mapped to its hash algorithm, and this algorithm
58650f742ddSTHOBY Simon  * must be built in the kernel for the setxattr to be allowed.
58750f742ddSTHOBY Simon  *
58850f742ddSTHOBY Simon  * Emit an audit message when the algorithm is invalid.
58950f742ddSTHOBY Simon  *
59050f742ddSTHOBY Simon  * Return: 0 on success, else an error.
59150f742ddSTHOBY Simon  */
59250f742ddSTHOBY Simon static int validate_hash_algo(struct dentry *dentry,
59350f742ddSTHOBY Simon 			      const struct evm_ima_xattr_data *xattr_value,
59450f742ddSTHOBY Simon 			      size_t xattr_value_len)
59550f742ddSTHOBY Simon {
59650f742ddSTHOBY Simon 	char *path = NULL, *pathbuf = NULL;
59750f742ddSTHOBY Simon 	enum hash_algo xattr_hash_algo;
598*4f2946aaSTHOBY Simon 	const char *errmsg = "unavailable-hash-algorithm";
599*4f2946aaSTHOBY Simon 	unsigned int allowed_hashes;
60050f742ddSTHOBY Simon 
60150f742ddSTHOBY Simon 	xattr_hash_algo = ima_get_hash_algo(xattr_value, xattr_value_len);
60250f742ddSTHOBY Simon 
603*4f2946aaSTHOBY Simon 	allowed_hashes = atomic_read(&ima_setxattr_allowed_hash_algorithms);
604*4f2946aaSTHOBY Simon 
605*4f2946aaSTHOBY Simon 	if (allowed_hashes) {
606*4f2946aaSTHOBY Simon 		/* success if the algorithm is allowed in the ima policy */
607*4f2946aaSTHOBY Simon 		if (allowed_hashes & (1U << xattr_hash_algo))
60850f742ddSTHOBY Simon 			return 0;
60950f742ddSTHOBY Simon 
610*4f2946aaSTHOBY Simon 		/*
611*4f2946aaSTHOBY Simon 		 * We use a different audit message when the hash algorithm
612*4f2946aaSTHOBY Simon 		 * is denied by a policy rule, instead of not being built
613*4f2946aaSTHOBY Simon 		 * in the kernel image
614*4f2946aaSTHOBY Simon 		 */
615*4f2946aaSTHOBY Simon 		errmsg = "denied-hash-algorithm";
616*4f2946aaSTHOBY Simon 	} else {
617*4f2946aaSTHOBY Simon 		if (likely(xattr_hash_algo == ima_hash_algo))
618*4f2946aaSTHOBY Simon 			return 0;
619*4f2946aaSTHOBY Simon 
620*4f2946aaSTHOBY Simon 		/* allow any xattr using an algorithm built in the kernel */
621*4f2946aaSTHOBY Simon 		if (crypto_has_alg(hash_algo_name[xattr_hash_algo], 0, 0))
622*4f2946aaSTHOBY Simon 			return 0;
623*4f2946aaSTHOBY Simon 	}
624*4f2946aaSTHOBY Simon 
62550f742ddSTHOBY Simon 	pathbuf = kmalloc(PATH_MAX, GFP_KERNEL);
62650f742ddSTHOBY Simon 	if (!pathbuf)
62750f742ddSTHOBY Simon 		return -EACCES;
62850f742ddSTHOBY Simon 
62950f742ddSTHOBY Simon 	path = dentry_path(dentry, pathbuf, PATH_MAX);
63050f742ddSTHOBY Simon 
63150f742ddSTHOBY Simon 	integrity_audit_msg(AUDIT_INTEGRITY_DATA, d_inode(dentry), path,
632*4f2946aaSTHOBY Simon 			    "set_data", errmsg, -EACCES, 0);
63350f742ddSTHOBY Simon 
63450f742ddSTHOBY Simon 	kfree(pathbuf);
63550f742ddSTHOBY Simon 
63650f742ddSTHOBY Simon 	return -EACCES;
63750f742ddSTHOBY Simon }
63850f742ddSTHOBY Simon 
63942c63330SMimi Zohar int ima_inode_setxattr(struct dentry *dentry, const char *xattr_name,
64042c63330SMimi Zohar 		       const void *xattr_value, size_t xattr_value_len)
64142c63330SMimi Zohar {
642060bdebfSMimi Zohar 	const struct evm_ima_xattr_data *xvalue = xattr_value;
643e3ccfe1aSRoberto Sassu 	int digsig = 0;
64442c63330SMimi Zohar 	int result;
64542c63330SMimi Zohar 
64642c63330SMimi Zohar 	result = ima_protect_xattr(dentry, xattr_name, xattr_value,
64742c63330SMimi Zohar 				   xattr_value_len);
64842c63330SMimi Zohar 	if (result == 1) {
649a48fda9dSDmitry Kasatkin 		if (!xattr_value_len || (xvalue->type >= IMA_XATTR_LAST))
650a48fda9dSDmitry Kasatkin 			return -EINVAL;
651e3ccfe1aSRoberto Sassu 		digsig = (xvalue->type == EVM_IMA_XATTR_DIGSIG);
6527aa5783dSRoberto Sassu 	} else if (!strcmp(xattr_name, XATTR_NAME_EVM) && xattr_value_len > 0) {
6537aa5783dSRoberto Sassu 		digsig = (xvalue->type == EVM_XATTR_PORTABLE_DIGSIG);
654e3ccfe1aSRoberto Sassu 	}
655e3ccfe1aSRoberto Sassu 	if (result == 1 || evm_revalidate_status(xattr_name)) {
65650f742ddSTHOBY Simon 		result = validate_hash_algo(dentry, xvalue, xattr_value_len);
65750f742ddSTHOBY Simon 		if (result)
65850f742ddSTHOBY Simon 			return result;
65950f742ddSTHOBY Simon 
660e3ccfe1aSRoberto Sassu 		ima_reset_appraise_flags(d_backing_inode(dentry), digsig);
66142c63330SMimi Zohar 	}
66242c63330SMimi Zohar 	return result;
66342c63330SMimi Zohar }
66442c63330SMimi Zohar 
66542c63330SMimi Zohar int ima_inode_removexattr(struct dentry *dentry, const char *xattr_name)
66642c63330SMimi Zohar {
66742c63330SMimi Zohar 	int result;
66842c63330SMimi Zohar 
66942c63330SMimi Zohar 	result = ima_protect_xattr(dentry, xattr_name, NULL, 0);
670e3ccfe1aSRoberto Sassu 	if (result == 1 || evm_revalidate_status(xattr_name)) {
671c6f493d6SDavid Howells 		ima_reset_appraise_flags(d_backing_inode(dentry), 0);
672e3ccfe1aSRoberto Sassu 		if (result == 1)
67342c63330SMimi Zohar 			result = 0;
67442c63330SMimi Zohar 	}
67542c63330SMimi Zohar 	return result;
67642c63330SMimi Zohar }
677