xref: /openbmc/linux/net/dsa/slave.c (revision cc1d5bda17c8eb4cd195f05a5558ed63df057fce)
191da11f8SLennert Buytenhek /*
291da11f8SLennert Buytenhek  * net/dsa/slave.c - Slave device handling
3e84665c9SLennert Buytenhek  * Copyright (c) 2008-2009 Marvell Semiconductor
491da11f8SLennert Buytenhek  *
591da11f8SLennert Buytenhek  * This program is free software; you can redistribute it and/or modify
691da11f8SLennert Buytenhek  * it under the terms of the GNU General Public License as published by
791da11f8SLennert Buytenhek  * the Free Software Foundation; either version 2 of the License, or
891da11f8SLennert Buytenhek  * (at your option) any later version.
991da11f8SLennert Buytenhek  */
1091da11f8SLennert Buytenhek 
1191da11f8SLennert Buytenhek #include <linux/list.h>
12df02c6ffSLennert Buytenhek #include <linux/etherdevice.h>
13b73adef6SFlorian Fainelli #include <linux/netdevice.h>
1491da11f8SLennert Buytenhek #include <linux/phy.h>
15a2820543SFlorian Fainelli #include <linux/phy_fixed.h>
16aab9c406SFlorian Fainelli #include <linux/phylink.h>
170d8bcdd3SFlorian Fainelli #include <linux/of_net.h>
180d8bcdd3SFlorian Fainelli #include <linux/of_mdio.h>
197f854420SAndrew Lunn #include <linux/mdio.h>
20b73adef6SFlorian Fainelli #include <net/rtnetlink.h>
21f50f2127SFlorian Fainelli #include <net/pkt_cls.h>
22f50f2127SFlorian Fainelli #include <net/tc_act/tc_mirred.h>
23b73adef6SFlorian Fainelli #include <linux/if_bridge.h>
2404ff53f9SFlorian Fainelli #include <linux/netpoll.h>
2590af1059SBrandon Streiff #include <linux/ptp_classify.h>
26ea5dd34bSVivien Didelot 
2791da11f8SLennert Buytenhek #include "dsa_priv.h"
2891da11f8SLennert Buytenhek 
29f50f2127SFlorian Fainelli static bool dsa_slave_dev_check(struct net_device *dev);
30f50f2127SFlorian Fainelli 
3191da11f8SLennert Buytenhek /* slave mii_bus handling ***************************************************/
3291da11f8SLennert Buytenhek static int dsa_slave_phy_read(struct mii_bus *bus, int addr, int reg)
3391da11f8SLennert Buytenhek {
3491da11f8SLennert Buytenhek 	struct dsa_switch *ds = bus->priv;
3591da11f8SLennert Buytenhek 
360d8bcdd3SFlorian Fainelli 	if (ds->phys_mii_mask & (1 << addr))
379d490b4eSVivien Didelot 		return ds->ops->phy_read(ds, addr, reg);
3891da11f8SLennert Buytenhek 
3991da11f8SLennert Buytenhek 	return 0xffff;
4091da11f8SLennert Buytenhek }
4191da11f8SLennert Buytenhek 
4291da11f8SLennert Buytenhek static int dsa_slave_phy_write(struct mii_bus *bus, int addr, int reg, u16 val)
4391da11f8SLennert Buytenhek {
4491da11f8SLennert Buytenhek 	struct dsa_switch *ds = bus->priv;
4591da11f8SLennert Buytenhek 
460d8bcdd3SFlorian Fainelli 	if (ds->phys_mii_mask & (1 << addr))
479d490b4eSVivien Didelot 		return ds->ops->phy_write(ds, addr, reg, val);
4891da11f8SLennert Buytenhek 
4991da11f8SLennert Buytenhek 	return 0;
5091da11f8SLennert Buytenhek }
5191da11f8SLennert Buytenhek 
5291da11f8SLennert Buytenhek void dsa_slave_mii_bus_init(struct dsa_switch *ds)
5391da11f8SLennert Buytenhek {
5491da11f8SLennert Buytenhek 	ds->slave_mii_bus->priv = (void *)ds;
5591da11f8SLennert Buytenhek 	ds->slave_mii_bus->name = "dsa slave smi";
5691da11f8SLennert Buytenhek 	ds->slave_mii_bus->read = dsa_slave_phy_read;
5791da11f8SLennert Buytenhek 	ds->slave_mii_bus->write = dsa_slave_phy_write;
580b7b498dSFlorian Fainelli 	snprintf(ds->slave_mii_bus->id, MII_BUS_ID_SIZE, "dsa-%d.%d",
5949463b7fSVivien Didelot 		 ds->dst->index, ds->index);
60c33063d6SAndrew Lunn 	ds->slave_mii_bus->parent = ds->dev;
6124df8986SVivien Didelot 	ds->slave_mii_bus->phy_mask = ~ds->phys_mii_mask;
6291da11f8SLennert Buytenhek }
6391da11f8SLennert Buytenhek 
6491da11f8SLennert Buytenhek 
6591da11f8SLennert Buytenhek /* slave device handling ****************************************************/
66abd2be00SNicolas Dichtel static int dsa_slave_get_iflink(const struct net_device *dev)
67c0840801SLennert Buytenhek {
68d0006b00SVivien Didelot 	return dsa_slave_to_master(dev)->ifindex;
69c0840801SLennert Buytenhek }
70c0840801SLennert Buytenhek 
7191da11f8SLennert Buytenhek static int dsa_slave_open(struct net_device *dev)
7291da11f8SLennert Buytenhek {
73d0006b00SVivien Didelot 	struct net_device *master = dsa_slave_to_master(dev);
74d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(dev);
75df02c6ffSLennert Buytenhek 	int err;
76df02c6ffSLennert Buytenhek 
77df02c6ffSLennert Buytenhek 	if (!(master->flags & IFF_UP))
78df02c6ffSLennert Buytenhek 		return -ENETDOWN;
79df02c6ffSLennert Buytenhek 
808feedbb4SJoe Perches 	if (!ether_addr_equal(dev->dev_addr, master->dev_addr)) {
81a748ee24SJiri Pirko 		err = dev_uc_add(master, dev->dev_addr);
82df02c6ffSLennert Buytenhek 		if (err < 0)
83df02c6ffSLennert Buytenhek 			goto out;
84df02c6ffSLennert Buytenhek 	}
85df02c6ffSLennert Buytenhek 
86df02c6ffSLennert Buytenhek 	if (dev->flags & IFF_ALLMULTI) {
87df02c6ffSLennert Buytenhek 		err = dev_set_allmulti(master, 1);
88df02c6ffSLennert Buytenhek 		if (err < 0)
89df02c6ffSLennert Buytenhek 			goto del_unicast;
90df02c6ffSLennert Buytenhek 	}
91df02c6ffSLennert Buytenhek 	if (dev->flags & IFF_PROMISC) {
92df02c6ffSLennert Buytenhek 		err = dev_set_promiscuity(master, 1);
93df02c6ffSLennert Buytenhek 		if (err < 0)
94df02c6ffSLennert Buytenhek 			goto clear_allmulti;
95df02c6ffSLennert Buytenhek 	}
96df02c6ffSLennert Buytenhek 
970115dcd1SVivien Didelot 	err = dsa_port_enable(dp, dev->phydev);
98b2f2af21SFlorian Fainelli 	if (err)
99b2f2af21SFlorian Fainelli 		goto clear_promisc;
100b73adef6SFlorian Fainelli 
101aab9c406SFlorian Fainelli 	phylink_start(dp->pl);
102f7f1de51SFlorian Fainelli 
10391da11f8SLennert Buytenhek 	return 0;
104df02c6ffSLennert Buytenhek 
105b2f2af21SFlorian Fainelli clear_promisc:
106b2f2af21SFlorian Fainelli 	if (dev->flags & IFF_PROMISC)
1074fdeddfeSGilad Ben-Yossef 		dev_set_promiscuity(master, -1);
108df02c6ffSLennert Buytenhek clear_allmulti:
109df02c6ffSLennert Buytenhek 	if (dev->flags & IFF_ALLMULTI)
110df02c6ffSLennert Buytenhek 		dev_set_allmulti(master, -1);
111df02c6ffSLennert Buytenhek del_unicast:
1128feedbb4SJoe Perches 	if (!ether_addr_equal(dev->dev_addr, master->dev_addr))
113a748ee24SJiri Pirko 		dev_uc_del(master, dev->dev_addr);
114df02c6ffSLennert Buytenhek out:
115df02c6ffSLennert Buytenhek 	return err;
11691da11f8SLennert Buytenhek }
11791da11f8SLennert Buytenhek 
11891da11f8SLennert Buytenhek static int dsa_slave_close(struct net_device *dev)
11991da11f8SLennert Buytenhek {
120d0006b00SVivien Didelot 	struct net_device *master = dsa_slave_to_master(dev);
121d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(dev);
122df02c6ffSLennert Buytenhek 
123aab9c406SFlorian Fainelli 	phylink_stop(dp->pl);
124f7f1de51SFlorian Fainelli 
1250115dcd1SVivien Didelot 	dsa_port_disable(dp, dev->phydev);
1266457edfeSVivien Didelot 
127df02c6ffSLennert Buytenhek 	dev_mc_unsync(master, dev);
128a748ee24SJiri Pirko 	dev_uc_unsync(master, dev);
129df02c6ffSLennert Buytenhek 	if (dev->flags & IFF_ALLMULTI)
130df02c6ffSLennert Buytenhek 		dev_set_allmulti(master, -1);
131df02c6ffSLennert Buytenhek 	if (dev->flags & IFF_PROMISC)
132df02c6ffSLennert Buytenhek 		dev_set_promiscuity(master, -1);
133df02c6ffSLennert Buytenhek 
1348feedbb4SJoe Perches 	if (!ether_addr_equal(dev->dev_addr, master->dev_addr))
135a748ee24SJiri Pirko 		dev_uc_del(master, dev->dev_addr);
136df02c6ffSLennert Buytenhek 
13791da11f8SLennert Buytenhek 	return 0;
13891da11f8SLennert Buytenhek }
13991da11f8SLennert Buytenhek 
14091da11f8SLennert Buytenhek static void dsa_slave_change_rx_flags(struct net_device *dev, int change)
14191da11f8SLennert Buytenhek {
142d0006b00SVivien Didelot 	struct net_device *master = dsa_slave_to_master(dev);
14317ab4f61SRundong Ge 	if (dev->flags & IFF_UP) {
14491da11f8SLennert Buytenhek 		if (change & IFF_ALLMULTI)
14517ab4f61SRundong Ge 			dev_set_allmulti(master,
14617ab4f61SRundong Ge 					 dev->flags & IFF_ALLMULTI ? 1 : -1);
14791da11f8SLennert Buytenhek 		if (change & IFF_PROMISC)
14817ab4f61SRundong Ge 			dev_set_promiscuity(master,
14917ab4f61SRundong Ge 					    dev->flags & IFF_PROMISC ? 1 : -1);
15017ab4f61SRundong Ge 	}
15191da11f8SLennert Buytenhek }
15291da11f8SLennert Buytenhek 
15391da11f8SLennert Buytenhek static void dsa_slave_set_rx_mode(struct net_device *dev)
15491da11f8SLennert Buytenhek {
155d0006b00SVivien Didelot 	struct net_device *master = dsa_slave_to_master(dev);
15691da11f8SLennert Buytenhek 
15791da11f8SLennert Buytenhek 	dev_mc_sync(master, dev);
158a748ee24SJiri Pirko 	dev_uc_sync(master, dev);
15991da11f8SLennert Buytenhek }
16091da11f8SLennert Buytenhek 
161df02c6ffSLennert Buytenhek static int dsa_slave_set_mac_address(struct net_device *dev, void *a)
16291da11f8SLennert Buytenhek {
163d0006b00SVivien Didelot 	struct net_device *master = dsa_slave_to_master(dev);
164df02c6ffSLennert Buytenhek 	struct sockaddr *addr = a;
165df02c6ffSLennert Buytenhek 	int err;
166df02c6ffSLennert Buytenhek 
167df02c6ffSLennert Buytenhek 	if (!is_valid_ether_addr(addr->sa_data))
168df02c6ffSLennert Buytenhek 		return -EADDRNOTAVAIL;
169df02c6ffSLennert Buytenhek 
170df02c6ffSLennert Buytenhek 	if (!(dev->flags & IFF_UP))
171df02c6ffSLennert Buytenhek 		goto out;
172df02c6ffSLennert Buytenhek 
1738feedbb4SJoe Perches 	if (!ether_addr_equal(addr->sa_data, master->dev_addr)) {
174a748ee24SJiri Pirko 		err = dev_uc_add(master, addr->sa_data);
175df02c6ffSLennert Buytenhek 		if (err < 0)
176df02c6ffSLennert Buytenhek 			return err;
177df02c6ffSLennert Buytenhek 	}
178df02c6ffSLennert Buytenhek 
1798feedbb4SJoe Perches 	if (!ether_addr_equal(dev->dev_addr, master->dev_addr))
180a748ee24SJiri Pirko 		dev_uc_del(master, dev->dev_addr);
181df02c6ffSLennert Buytenhek 
182df02c6ffSLennert Buytenhek out:
183d08f161aSJoe Perches 	ether_addr_copy(dev->dev_addr, addr->sa_data);
18491da11f8SLennert Buytenhek 
18591da11f8SLennert Buytenhek 	return 0;
18691da11f8SLennert Buytenhek }
18791da11f8SLennert Buytenhek 
1882bedde1aSArkadi Sharshevsky struct dsa_slave_dump_ctx {
1892bedde1aSArkadi Sharshevsky 	struct net_device *dev;
1902bedde1aSArkadi Sharshevsky 	struct sk_buff *skb;
1912bedde1aSArkadi Sharshevsky 	struct netlink_callback *cb;
1922bedde1aSArkadi Sharshevsky 	int idx;
1932bedde1aSArkadi Sharshevsky };
1942bedde1aSArkadi Sharshevsky 
1952bedde1aSArkadi Sharshevsky static int
1962bedde1aSArkadi Sharshevsky dsa_slave_port_fdb_do_dump(const unsigned char *addr, u16 vid,
1972bedde1aSArkadi Sharshevsky 			   bool is_static, void *data)
1982bedde1aSArkadi Sharshevsky {
1992bedde1aSArkadi Sharshevsky 	struct dsa_slave_dump_ctx *dump = data;
2002bedde1aSArkadi Sharshevsky 	u32 portid = NETLINK_CB(dump->cb->skb).portid;
2012bedde1aSArkadi Sharshevsky 	u32 seq = dump->cb->nlh->nlmsg_seq;
2022bedde1aSArkadi Sharshevsky 	struct nlmsghdr *nlh;
2032bedde1aSArkadi Sharshevsky 	struct ndmsg *ndm;
2042bedde1aSArkadi Sharshevsky 
2052bedde1aSArkadi Sharshevsky 	if (dump->idx < dump->cb->args[2])
2062bedde1aSArkadi Sharshevsky 		goto skip;
2072bedde1aSArkadi Sharshevsky 
2082bedde1aSArkadi Sharshevsky 	nlh = nlmsg_put(dump->skb, portid, seq, RTM_NEWNEIGH,
2092bedde1aSArkadi Sharshevsky 			sizeof(*ndm), NLM_F_MULTI);
2102bedde1aSArkadi Sharshevsky 	if (!nlh)
2112bedde1aSArkadi Sharshevsky 		return -EMSGSIZE;
2122bedde1aSArkadi Sharshevsky 
2132bedde1aSArkadi Sharshevsky 	ndm = nlmsg_data(nlh);
2142bedde1aSArkadi Sharshevsky 	ndm->ndm_family  = AF_BRIDGE;
2152bedde1aSArkadi Sharshevsky 	ndm->ndm_pad1    = 0;
2162bedde1aSArkadi Sharshevsky 	ndm->ndm_pad2    = 0;
2172bedde1aSArkadi Sharshevsky 	ndm->ndm_flags   = NTF_SELF;
2182bedde1aSArkadi Sharshevsky 	ndm->ndm_type    = 0;
2192bedde1aSArkadi Sharshevsky 	ndm->ndm_ifindex = dump->dev->ifindex;
2202bedde1aSArkadi Sharshevsky 	ndm->ndm_state   = is_static ? NUD_NOARP : NUD_REACHABLE;
2212bedde1aSArkadi Sharshevsky 
2222bedde1aSArkadi Sharshevsky 	if (nla_put(dump->skb, NDA_LLADDR, ETH_ALEN, addr))
2232bedde1aSArkadi Sharshevsky 		goto nla_put_failure;
2242bedde1aSArkadi Sharshevsky 
2252bedde1aSArkadi Sharshevsky 	if (vid && nla_put_u16(dump->skb, NDA_VLAN, vid))
2262bedde1aSArkadi Sharshevsky 		goto nla_put_failure;
2272bedde1aSArkadi Sharshevsky 
2282bedde1aSArkadi Sharshevsky 	nlmsg_end(dump->skb, nlh);
2292bedde1aSArkadi Sharshevsky 
2302bedde1aSArkadi Sharshevsky skip:
2312bedde1aSArkadi Sharshevsky 	dump->idx++;
2322bedde1aSArkadi Sharshevsky 	return 0;
2332bedde1aSArkadi Sharshevsky 
2342bedde1aSArkadi Sharshevsky nla_put_failure:
2352bedde1aSArkadi Sharshevsky 	nlmsg_cancel(dump->skb, nlh);
2362bedde1aSArkadi Sharshevsky 	return -EMSGSIZE;
2372bedde1aSArkadi Sharshevsky }
2382bedde1aSArkadi Sharshevsky 
2392bedde1aSArkadi Sharshevsky static int
2402bedde1aSArkadi Sharshevsky dsa_slave_fdb_dump(struct sk_buff *skb, struct netlink_callback *cb,
2412bedde1aSArkadi Sharshevsky 		   struct net_device *dev, struct net_device *filter_dev,
2422bedde1aSArkadi Sharshevsky 		   int *idx)
2432bedde1aSArkadi Sharshevsky {
244d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(dev);
2452bedde1aSArkadi Sharshevsky 	struct dsa_slave_dump_ctx dump = {
2462bedde1aSArkadi Sharshevsky 		.dev = dev,
2472bedde1aSArkadi Sharshevsky 		.skb = skb,
2482bedde1aSArkadi Sharshevsky 		.cb = cb,
2492bedde1aSArkadi Sharshevsky 		.idx = *idx,
2502bedde1aSArkadi Sharshevsky 	};
2512bedde1aSArkadi Sharshevsky 	int err;
2522bedde1aSArkadi Sharshevsky 
253de40fc5dSVivien Didelot 	err = dsa_port_fdb_dump(dp, dsa_slave_port_fdb_do_dump, &dump);
2542bedde1aSArkadi Sharshevsky 	*idx = dump.idx;
255de40fc5dSVivien Didelot 
2562bedde1aSArkadi Sharshevsky 	return err;
2572bedde1aSArkadi Sharshevsky }
2582bedde1aSArkadi Sharshevsky 
25991da11f8SLennert Buytenhek static int dsa_slave_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
26091da11f8SLennert Buytenhek {
2610336369dSBrandon Streiff 	struct dsa_slave_priv *p = netdev_priv(dev);
2620336369dSBrandon Streiff 	struct dsa_switch *ds = p->dp->ds;
2630336369dSBrandon Streiff 	int port = p->dp->index;
2640336369dSBrandon Streiff 
2650336369dSBrandon Streiff 	/* Pass through to switch driver if it supports timestamping */
2660336369dSBrandon Streiff 	switch (cmd) {
2670336369dSBrandon Streiff 	case SIOCGHWTSTAMP:
2680336369dSBrandon Streiff 		if (ds->ops->port_hwtstamp_get)
2690336369dSBrandon Streiff 			return ds->ops->port_hwtstamp_get(ds, port, ifr);
2700336369dSBrandon Streiff 		break;
2710336369dSBrandon Streiff 	case SIOCSHWTSTAMP:
2720336369dSBrandon Streiff 		if (ds->ops->port_hwtstamp_set)
2730336369dSBrandon Streiff 			return ds->ops->port_hwtstamp_set(ds, port, ifr);
2740336369dSBrandon Streiff 		break;
2750336369dSBrandon Streiff 	}
2760336369dSBrandon Streiff 
277aab9c406SFlorian Fainelli 	return phylink_mii_ioctl(p->dp->pl, ifr, cmd);
27891da11f8SLennert Buytenhek }
27991da11f8SLennert Buytenhek 
28035636062SScott Feldman static int dsa_slave_port_attr_set(struct net_device *dev,
281f7fadf30SJiri Pirko 				   const struct switchdev_attr *attr,
2827ea6eb3fSJiri Pirko 				   struct switchdev_trans *trans)
28335636062SScott Feldman {
284d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(dev);
285b8d866acSVivien Didelot 	int ret;
28635636062SScott Feldman 
28735636062SScott Feldman 	switch (attr->id) {
2881f868398SJiri Pirko 	case SWITCHDEV_ATTR_ID_PORT_STP_STATE:
289fd364541SVivien Didelot 		ret = dsa_port_set_state(dp, attr->u.stp_state, trans);
29035636062SScott Feldman 		break;
291fb2dabadSVivien Didelot 	case SWITCHDEV_ATTR_ID_BRIDGE_VLAN_FILTERING:
292c02c4175SVivien Didelot 		ret = dsa_port_vlan_filtering(dp, attr->u.vlan_filtering,
293c02c4175SVivien Didelot 					      trans);
294fb2dabadSVivien Didelot 		break;
29534a79f63SVivien Didelot 	case SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME:
296072bb190SVivien Didelot 		ret = dsa_port_ageing_time(dp, attr->u.ageing_time, trans);
29734a79f63SVivien Didelot 		break;
298ea87005aSFlorian Fainelli 	case SWITCHDEV_ATTR_ID_PORT_PRE_BRIDGE_FLAGS:
299ea87005aSFlorian Fainelli 		ret = dsa_port_pre_bridge_flags(dp, attr->u.brport_flags,
300ea87005aSFlorian Fainelli 						trans);
301ea87005aSFlorian Fainelli 		break;
30257652796SRussell King 	case SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS:
30357652796SRussell King 		ret = dsa_port_bridge_flags(dp, attr->u.brport_flags, trans);
30457652796SRussell King 		break;
30535636062SScott Feldman 	default:
30635636062SScott Feldman 		ret = -EOPNOTSUPP;
30735636062SScott Feldman 		break;
30835636062SScott Feldman 	}
30935636062SScott Feldman 
31035636062SScott Feldman 	return ret;
31135636062SScott Feldman }
31235636062SScott Feldman 
313ba14d9ebSVivien Didelot static int dsa_slave_port_obj_add(struct net_device *dev,
314648b4a99SJiri Pirko 				  const struct switchdev_obj *obj,
3157ea6eb3fSJiri Pirko 				  struct switchdev_trans *trans)
316ba14d9ebSVivien Didelot {
317d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(dev);
318ba14d9ebSVivien Didelot 	int err;
319ba14d9ebSVivien Didelot 
320ba14d9ebSVivien Didelot 	/* For the prepare phase, ensure the full set of changes is feasable in
321ba14d9ebSVivien Didelot 	 * one go in order to signal a failure properly. If an operation is not
322ba14d9ebSVivien Didelot 	 * supported, return -EOPNOTSUPP.
323ba14d9ebSVivien Didelot 	 */
324ba14d9ebSVivien Didelot 
3259e8f4a54SJiri Pirko 	switch (obj->id) {
3268df30255SVivien Didelot 	case SWITCHDEV_OBJ_ID_PORT_MDB:
327bcebb976SVivien Didelot 		err = dsa_port_mdb_add(dp, SWITCHDEV_OBJ_PORT_MDB(obj), trans);
3288df30255SVivien Didelot 		break;
3295f4dbc50SAndrew Lunn 	case SWITCHDEV_OBJ_ID_HOST_MDB:
3305f4dbc50SAndrew Lunn 		/* DSA can directly translate this to a normal MDB add,
3315f4dbc50SAndrew Lunn 		 * but on the CPU port.
3325f4dbc50SAndrew Lunn 		 */
3335f4dbc50SAndrew Lunn 		err = dsa_port_mdb_add(dp->cpu_dp, SWITCHDEV_OBJ_PORT_MDB(obj),
3345f4dbc50SAndrew Lunn 				       trans);
3355f4dbc50SAndrew Lunn 		break;
33657d80838SJiri Pirko 	case SWITCHDEV_OBJ_ID_PORT_VLAN:
33701676d12SVivien Didelot 		err = dsa_port_vlan_add(dp, SWITCHDEV_OBJ_PORT_VLAN(obj),
338648b4a99SJiri Pirko 					trans);
33911149536SVivien Didelot 		break;
340ba14d9ebSVivien Didelot 	default:
341ba14d9ebSVivien Didelot 		err = -EOPNOTSUPP;
342ba14d9ebSVivien Didelot 		break;
343ba14d9ebSVivien Didelot 	}
344ba14d9ebSVivien Didelot 
345ba14d9ebSVivien Didelot 	return err;
346ba14d9ebSVivien Didelot }
347ba14d9ebSVivien Didelot 
348ba14d9ebSVivien Didelot static int dsa_slave_port_obj_del(struct net_device *dev,
349648b4a99SJiri Pirko 				  const struct switchdev_obj *obj)
350ba14d9ebSVivien Didelot {
351d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(dev);
352ba14d9ebSVivien Didelot 	int err;
353ba14d9ebSVivien Didelot 
3549e8f4a54SJiri Pirko 	switch (obj->id) {
3558df30255SVivien Didelot 	case SWITCHDEV_OBJ_ID_PORT_MDB:
356bcebb976SVivien Didelot 		err = dsa_port_mdb_del(dp, SWITCHDEV_OBJ_PORT_MDB(obj));
3578df30255SVivien Didelot 		break;
3585f4dbc50SAndrew Lunn 	case SWITCHDEV_OBJ_ID_HOST_MDB:
3595f4dbc50SAndrew Lunn 		/* DSA can directly translate this to a normal MDB add,
3605f4dbc50SAndrew Lunn 		 * but on the CPU port.
3615f4dbc50SAndrew Lunn 		 */
3625f4dbc50SAndrew Lunn 		err = dsa_port_mdb_del(dp->cpu_dp, SWITCHDEV_OBJ_PORT_MDB(obj));
3635f4dbc50SAndrew Lunn 		break;
36457d80838SJiri Pirko 	case SWITCHDEV_OBJ_ID_PORT_VLAN:
36501676d12SVivien Didelot 		err = dsa_port_vlan_del(dp, SWITCHDEV_OBJ_PORT_VLAN(obj));
36611149536SVivien Didelot 		break;
367ba14d9ebSVivien Didelot 	default:
368ba14d9ebSVivien Didelot 		err = -EOPNOTSUPP;
369ba14d9ebSVivien Didelot 		break;
370ba14d9ebSVivien Didelot 	}
371ba14d9ebSVivien Didelot 
372ba14d9ebSVivien Didelot 	return err;
373ba14d9ebSVivien Didelot }
374ba14d9ebSVivien Didelot 
375929d6c14SFlorian Fainelli static int dsa_slave_get_port_parent_id(struct net_device *dev,
376929d6c14SFlorian Fainelli 					struct netdev_phys_item_id *ppid)
377b73adef6SFlorian Fainelli {
378d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(dev);
379d945097bSVivien Didelot 	struct dsa_switch *ds = dp->ds;
380a42c8e33SAndrew Lunn 	struct dsa_switch_tree *dst = ds->dst;
381b73adef6SFlorian Fainelli 
382929d6c14SFlorian Fainelli 	ppid->id_len = sizeof(dst->index);
383929d6c14SFlorian Fainelli 	memcpy(&ppid->id, &dst->index, ppid->id_len);
384929d6c14SFlorian Fainelli 
385929d6c14SFlorian Fainelli 	return 0;
386929d6c14SFlorian Fainelli }
387929d6c14SFlorian Fainelli 
3884fa7b718SVivien Didelot static inline netdev_tx_t dsa_slave_netpoll_send_skb(struct net_device *dev,
38904ff53f9SFlorian Fainelli 						     struct sk_buff *skb)
39004ff53f9SFlorian Fainelli {
39104ff53f9SFlorian Fainelli #ifdef CONFIG_NET_POLL_CONTROLLER
3924fa7b718SVivien Didelot 	struct dsa_slave_priv *p = netdev_priv(dev);
3934fa7b718SVivien Didelot 
39404ff53f9SFlorian Fainelli 	if (p->netpoll)
39504ff53f9SFlorian Fainelli 		netpoll_send_skb(p->netpoll, skb);
39604ff53f9SFlorian Fainelli #else
39704ff53f9SFlorian Fainelli 	BUG();
39804ff53f9SFlorian Fainelli #endif
39904ff53f9SFlorian Fainelli 	return NETDEV_TX_OK;
40004ff53f9SFlorian Fainelli }
40104ff53f9SFlorian Fainelli 
40290af1059SBrandon Streiff static void dsa_skb_tx_timestamp(struct dsa_slave_priv *p,
40390af1059SBrandon Streiff 				 struct sk_buff *skb)
40490af1059SBrandon Streiff {
40590af1059SBrandon Streiff 	struct dsa_switch *ds = p->dp->ds;
40690af1059SBrandon Streiff 	struct sk_buff *clone;
40790af1059SBrandon Streiff 	unsigned int type;
40890af1059SBrandon Streiff 
40990af1059SBrandon Streiff 	type = ptp_classify_raw(skb);
41090af1059SBrandon Streiff 	if (type == PTP_CLASS_NONE)
41190af1059SBrandon Streiff 		return;
41290af1059SBrandon Streiff 
41390af1059SBrandon Streiff 	if (!ds->ops->port_txtstamp)
41490af1059SBrandon Streiff 		return;
41590af1059SBrandon Streiff 
41690af1059SBrandon Streiff 	clone = skb_clone_sk(skb);
41790af1059SBrandon Streiff 	if (!clone)
41890af1059SBrandon Streiff 		return;
41990af1059SBrandon Streiff 
42090af1059SBrandon Streiff 	if (ds->ops->port_txtstamp(ds, p->dp->index, clone, type))
42190af1059SBrandon Streiff 		return;
42290af1059SBrandon Streiff 
42390af1059SBrandon Streiff 	kfree_skb(clone);
42490af1059SBrandon Streiff }
42590af1059SBrandon Streiff 
4263e8a72d1SFlorian Fainelli static netdev_tx_t dsa_slave_xmit(struct sk_buff *skb, struct net_device *dev)
4273e8a72d1SFlorian Fainelli {
4283e8a72d1SFlorian Fainelli 	struct dsa_slave_priv *p = netdev_priv(dev);
4295f6b4e14SFlorian Fainelli 	struct pcpu_sw_netstats *s;
4304ed70ce9SFlorian Fainelli 	struct sk_buff *nskb;
4313e8a72d1SFlorian Fainelli 
4325f6b4e14SFlorian Fainelli 	s = this_cpu_ptr(p->stats64);
4335f6b4e14SFlorian Fainelli 	u64_stats_update_begin(&s->syncp);
4345f6b4e14SFlorian Fainelli 	s->tx_packets++;
4355f6b4e14SFlorian Fainelli 	s->tx_bytes += skb->len;
4365f6b4e14SFlorian Fainelli 	u64_stats_update_end(&s->syncp);
4373e8a72d1SFlorian Fainelli 
43890af1059SBrandon Streiff 	/* Identify PTP protocol packets, clone them, and pass them to the
43990af1059SBrandon Streiff 	 * switch driver
44090af1059SBrandon Streiff 	 */
44190af1059SBrandon Streiff 	dsa_skb_tx_timestamp(p, skb);
44290af1059SBrandon Streiff 
443fe47d563SVivien Didelot 	/* Transmit function may have to reallocate the original SKB,
444fe47d563SVivien Didelot 	 * in which case it must have freed it. Only free it here on error.
445fe47d563SVivien Didelot 	 */
4464ed70ce9SFlorian Fainelli 	nskb = p->xmit(skb, dev);
447fe47d563SVivien Didelot 	if (!nskb) {
448fe47d563SVivien Didelot 		kfree_skb(skb);
4494ed70ce9SFlorian Fainelli 		return NETDEV_TX_OK;
450fe47d563SVivien Didelot 	}
4515aed85ceSFlorian Fainelli 
45204ff53f9SFlorian Fainelli 	/* SKB for netpoll still need to be mangled with the protocol-specific
45304ff53f9SFlorian Fainelli 	 * tag to be successfully transmitted
45404ff53f9SFlorian Fainelli 	 */
45504ff53f9SFlorian Fainelli 	if (unlikely(netpoll_tx_running(dev)))
4564fa7b718SVivien Didelot 		return dsa_slave_netpoll_send_skb(dev, nskb);
45704ff53f9SFlorian Fainelli 
4584ed70ce9SFlorian Fainelli 	/* Queue the SKB for transmission on the parent interface, but
4594ed70ce9SFlorian Fainelli 	 * do not modify its EtherType
4604ed70ce9SFlorian Fainelli 	 */
461d0006b00SVivien Didelot 	nskb->dev = dsa_slave_to_master(dev);
4624ed70ce9SFlorian Fainelli 	dev_queue_xmit(nskb);
4635aed85ceSFlorian Fainelli 
4645aed85ceSFlorian Fainelli 	return NETDEV_TX_OK;
4655aed85ceSFlorian Fainelli }
4665aed85ceSFlorian Fainelli 
46791da11f8SLennert Buytenhek /* ethtool operations *******************************************************/
46891da11f8SLennert Buytenhek 
46991da11f8SLennert Buytenhek static void dsa_slave_get_drvinfo(struct net_device *dev,
47091da11f8SLennert Buytenhek 				  struct ethtool_drvinfo *drvinfo)
47191da11f8SLennert Buytenhek {
4727826d43fSJiri Pirko 	strlcpy(drvinfo->driver, "dsa", sizeof(drvinfo->driver));
4737826d43fSJiri Pirko 	strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version));
4747826d43fSJiri Pirko 	strlcpy(drvinfo->bus_info, "platform", sizeof(drvinfo->bus_info));
47591da11f8SLennert Buytenhek }
47691da11f8SLennert Buytenhek 
4773d762a0fSGuenter Roeck static int dsa_slave_get_regs_len(struct net_device *dev)
4783d762a0fSGuenter Roeck {
479d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(dev);
480d945097bSVivien Didelot 	struct dsa_switch *ds = dp->ds;
4813d762a0fSGuenter Roeck 
4829d490b4eSVivien Didelot 	if (ds->ops->get_regs_len)
483d945097bSVivien Didelot 		return ds->ops->get_regs_len(ds, dp->index);
4843d762a0fSGuenter Roeck 
4853d762a0fSGuenter Roeck 	return -EOPNOTSUPP;
4863d762a0fSGuenter Roeck }
4873d762a0fSGuenter Roeck 
4883d762a0fSGuenter Roeck static void
4893d762a0fSGuenter Roeck dsa_slave_get_regs(struct net_device *dev, struct ethtool_regs *regs, void *_p)
4903d762a0fSGuenter Roeck {
491d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(dev);
492d945097bSVivien Didelot 	struct dsa_switch *ds = dp->ds;
4933d762a0fSGuenter Roeck 
4949d490b4eSVivien Didelot 	if (ds->ops->get_regs)
495d945097bSVivien Didelot 		ds->ops->get_regs(ds, dp->index, regs, _p);
4963d762a0fSGuenter Roeck }
4973d762a0fSGuenter Roeck 
498aab9c406SFlorian Fainelli static int dsa_slave_nway_reset(struct net_device *dev)
499aab9c406SFlorian Fainelli {
500aab9c406SFlorian Fainelli 	struct dsa_port *dp = dsa_slave_to_port(dev);
501aab9c406SFlorian Fainelli 
502aab9c406SFlorian Fainelli 	return phylink_ethtool_nway_reset(dp->pl);
503aab9c406SFlorian Fainelli }
504aab9c406SFlorian Fainelli 
5056793abb4SGuenter Roeck static int dsa_slave_get_eeprom_len(struct net_device *dev)
5066793abb4SGuenter Roeck {
507d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(dev);
508d945097bSVivien Didelot 	struct dsa_switch *ds = dp->ds;
5096793abb4SGuenter Roeck 
5100e576044SAndrew Lunn 	if (ds->cd && ds->cd->eeprom_len)
511ff04955cSAndrew Lunn 		return ds->cd->eeprom_len;
5126793abb4SGuenter Roeck 
5139d490b4eSVivien Didelot 	if (ds->ops->get_eeprom_len)
5149d490b4eSVivien Didelot 		return ds->ops->get_eeprom_len(ds);
5156793abb4SGuenter Roeck 
5166793abb4SGuenter Roeck 	return 0;
5176793abb4SGuenter Roeck }
5186793abb4SGuenter Roeck 
5196793abb4SGuenter Roeck static int dsa_slave_get_eeprom(struct net_device *dev,
5206793abb4SGuenter Roeck 				struct ethtool_eeprom *eeprom, u8 *data)
5216793abb4SGuenter Roeck {
522d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(dev);
523d945097bSVivien Didelot 	struct dsa_switch *ds = dp->ds;
5246793abb4SGuenter Roeck 
5259d490b4eSVivien Didelot 	if (ds->ops->get_eeprom)
5269d490b4eSVivien Didelot 		return ds->ops->get_eeprom(ds, eeprom, data);
5276793abb4SGuenter Roeck 
5286793abb4SGuenter Roeck 	return -EOPNOTSUPP;
5296793abb4SGuenter Roeck }
5306793abb4SGuenter Roeck 
5316793abb4SGuenter Roeck static int dsa_slave_set_eeprom(struct net_device *dev,
5326793abb4SGuenter Roeck 				struct ethtool_eeprom *eeprom, u8 *data)
5336793abb4SGuenter Roeck {
534d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(dev);
535d945097bSVivien Didelot 	struct dsa_switch *ds = dp->ds;
5366793abb4SGuenter Roeck 
5379d490b4eSVivien Didelot 	if (ds->ops->set_eeprom)
5389d490b4eSVivien Didelot 		return ds->ops->set_eeprom(ds, eeprom, data);
5396793abb4SGuenter Roeck 
5406793abb4SGuenter Roeck 	return -EOPNOTSUPP;
5416793abb4SGuenter Roeck }
5426793abb4SGuenter Roeck 
54391da11f8SLennert Buytenhek static void dsa_slave_get_strings(struct net_device *dev,
54491da11f8SLennert Buytenhek 				  uint32_t stringset, uint8_t *data)
54591da11f8SLennert Buytenhek {
546d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(dev);
547d945097bSVivien Didelot 	struct dsa_switch *ds = dp->ds;
54891da11f8SLennert Buytenhek 
54991da11f8SLennert Buytenhek 	if (stringset == ETH_SS_STATS) {
55091da11f8SLennert Buytenhek 		int len = ETH_GSTRING_LEN;
55191da11f8SLennert Buytenhek 
55291da11f8SLennert Buytenhek 		strncpy(data, "tx_packets", len);
55391da11f8SLennert Buytenhek 		strncpy(data + len, "tx_bytes", len);
55491da11f8SLennert Buytenhek 		strncpy(data + 2 * len, "rx_packets", len);
55591da11f8SLennert Buytenhek 		strncpy(data + 3 * len, "rx_bytes", len);
5569d490b4eSVivien Didelot 		if (ds->ops->get_strings)
55789f09048SFlorian Fainelli 			ds->ops->get_strings(ds, dp->index, stringset,
55889f09048SFlorian Fainelli 					     data + 4 * len);
55991da11f8SLennert Buytenhek 	}
56091da11f8SLennert Buytenhek }
56191da11f8SLennert Buytenhek 
56291da11f8SLennert Buytenhek static void dsa_slave_get_ethtool_stats(struct net_device *dev,
56391da11f8SLennert Buytenhek 					struct ethtool_stats *stats,
56491da11f8SLennert Buytenhek 					uint64_t *data)
56591da11f8SLennert Buytenhek {
566d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(dev);
56791da11f8SLennert Buytenhek 	struct dsa_slave_priv *p = netdev_priv(dev);
568d945097bSVivien Didelot 	struct dsa_switch *ds = dp->ds;
5695f6b4e14SFlorian Fainelli 	struct pcpu_sw_netstats *s;
570f613ed66SFlorian Fainelli 	unsigned int start;
5715f6b4e14SFlorian Fainelli 	int i;
57291da11f8SLennert Buytenhek 
5735f6b4e14SFlorian Fainelli 	for_each_possible_cpu(i) {
5745f6b4e14SFlorian Fainelli 		u64 tx_packets, tx_bytes, rx_packets, rx_bytes;
5755f6b4e14SFlorian Fainelli 
5765f6b4e14SFlorian Fainelli 		s = per_cpu_ptr(p->stats64, i);
577f613ed66SFlorian Fainelli 		do {
5785f6b4e14SFlorian Fainelli 			start = u64_stats_fetch_begin_irq(&s->syncp);
5795f6b4e14SFlorian Fainelli 			tx_packets = s->tx_packets;
5805f6b4e14SFlorian Fainelli 			tx_bytes = s->tx_bytes;
5815f6b4e14SFlorian Fainelli 			rx_packets = s->rx_packets;
5825f6b4e14SFlorian Fainelli 			rx_bytes = s->rx_bytes;
5835f6b4e14SFlorian Fainelli 		} while (u64_stats_fetch_retry_irq(&s->syncp, start));
5845f6b4e14SFlorian Fainelli 		data[0] += tx_packets;
5855f6b4e14SFlorian Fainelli 		data[1] += tx_bytes;
5865f6b4e14SFlorian Fainelli 		data[2] += rx_packets;
5875f6b4e14SFlorian Fainelli 		data[3] += rx_bytes;
5885f6b4e14SFlorian Fainelli 	}
5899d490b4eSVivien Didelot 	if (ds->ops->get_ethtool_stats)
590d945097bSVivien Didelot 		ds->ops->get_ethtool_stats(ds, dp->index, data + 4);
59191da11f8SLennert Buytenhek }
59291da11f8SLennert Buytenhek 
59391da11f8SLennert Buytenhek static int dsa_slave_get_sset_count(struct net_device *dev, int sset)
59491da11f8SLennert Buytenhek {
595d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(dev);
596d945097bSVivien Didelot 	struct dsa_switch *ds = dp->ds;
59791da11f8SLennert Buytenhek 
59891da11f8SLennert Buytenhek 	if (sset == ETH_SS_STATS) {
59991da11f8SLennert Buytenhek 		int count;
60091da11f8SLennert Buytenhek 
60191da11f8SLennert Buytenhek 		count = 4;
6029d490b4eSVivien Didelot 		if (ds->ops->get_sset_count)
60389f09048SFlorian Fainelli 			count += ds->ops->get_sset_count(ds, dp->index, sset);
60491da11f8SLennert Buytenhek 
60591da11f8SLennert Buytenhek 		return count;
60691da11f8SLennert Buytenhek 	}
60791da11f8SLennert Buytenhek 
60891da11f8SLennert Buytenhek 	return -EOPNOTSUPP;
60991da11f8SLennert Buytenhek }
61091da11f8SLennert Buytenhek 
61119e57c4eSFlorian Fainelli static void dsa_slave_get_wol(struct net_device *dev, struct ethtool_wolinfo *w)
61219e57c4eSFlorian Fainelli {
613d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(dev);
614d945097bSVivien Didelot 	struct dsa_switch *ds = dp->ds;
61519e57c4eSFlorian Fainelli 
616aab9c406SFlorian Fainelli 	phylink_ethtool_get_wol(dp->pl, w);
617aab9c406SFlorian Fainelli 
6189d490b4eSVivien Didelot 	if (ds->ops->get_wol)
619d945097bSVivien Didelot 		ds->ops->get_wol(ds, dp->index, w);
62019e57c4eSFlorian Fainelli }
62119e57c4eSFlorian Fainelli 
62219e57c4eSFlorian Fainelli static int dsa_slave_set_wol(struct net_device *dev, struct ethtool_wolinfo *w)
62319e57c4eSFlorian Fainelli {
624d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(dev);
625d945097bSVivien Didelot 	struct dsa_switch *ds = dp->ds;
62619e57c4eSFlorian Fainelli 	int ret = -EOPNOTSUPP;
62719e57c4eSFlorian Fainelli 
628aab9c406SFlorian Fainelli 	phylink_ethtool_set_wol(dp->pl, w);
629aab9c406SFlorian Fainelli 
6309d490b4eSVivien Didelot 	if (ds->ops->set_wol)
631d945097bSVivien Didelot 		ret = ds->ops->set_wol(ds, dp->index, w);
63219e57c4eSFlorian Fainelli 
63319e57c4eSFlorian Fainelli 	return ret;
63419e57c4eSFlorian Fainelli }
63519e57c4eSFlorian Fainelli 
6367905288fSFlorian Fainelli static int dsa_slave_set_eee(struct net_device *dev, struct ethtool_eee *e)
6377905288fSFlorian Fainelli {
638d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(dev);
639d945097bSVivien Didelot 	struct dsa_switch *ds = dp->ds;
6407905288fSFlorian Fainelli 	int ret;
6417905288fSFlorian Fainelli 
6427b9cc738SVivien Didelot 	/* Port's PHY and MAC both need to be EEE capable */
64300670cb8SDan Carpenter 	if (!dev->phydev || !dp->pl)
6447b9cc738SVivien Didelot 		return -ENODEV;
6457b9cc738SVivien Didelot 
64608f50061SVivien Didelot 	if (!ds->ops->set_mac_eee)
6477905288fSFlorian Fainelli 		return -EOPNOTSUPP;
6487905288fSFlorian Fainelli 
649d945097bSVivien Didelot 	ret = ds->ops->set_mac_eee(ds, dp->index, e);
6507905288fSFlorian Fainelli 	if (ret)
6517905288fSFlorian Fainelli 		return ret;
6527905288fSFlorian Fainelli 
653aab9c406SFlorian Fainelli 	return phylink_ethtool_set_eee(dp->pl, e);
6547905288fSFlorian Fainelli }
6557905288fSFlorian Fainelli 
6567905288fSFlorian Fainelli static int dsa_slave_get_eee(struct net_device *dev, struct ethtool_eee *e)
6577905288fSFlorian Fainelli {
658d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(dev);
659d945097bSVivien Didelot 	struct dsa_switch *ds = dp->ds;
6607905288fSFlorian Fainelli 	int ret;
6617905288fSFlorian Fainelli 
6627b9cc738SVivien Didelot 	/* Port's PHY and MAC both need to be EEE capable */
66300670cb8SDan Carpenter 	if (!dev->phydev || !dp->pl)
6647b9cc738SVivien Didelot 		return -ENODEV;
6657b9cc738SVivien Didelot 
66608f50061SVivien Didelot 	if (!ds->ops->get_mac_eee)
6677905288fSFlorian Fainelli 		return -EOPNOTSUPP;
6687905288fSFlorian Fainelli 
669d945097bSVivien Didelot 	ret = ds->ops->get_mac_eee(ds, dp->index, e);
6707905288fSFlorian Fainelli 	if (ret)
6717905288fSFlorian Fainelli 		return ret;
6727905288fSFlorian Fainelli 
673aab9c406SFlorian Fainelli 	return phylink_ethtool_get_eee(dp->pl, e);
674aab9c406SFlorian Fainelli }
675aab9c406SFlorian Fainelli 
676aab9c406SFlorian Fainelli static int dsa_slave_get_link_ksettings(struct net_device *dev,
677aab9c406SFlorian Fainelli 					struct ethtool_link_ksettings *cmd)
678aab9c406SFlorian Fainelli {
679aab9c406SFlorian Fainelli 	struct dsa_port *dp = dsa_slave_to_port(dev);
680aab9c406SFlorian Fainelli 
681aab9c406SFlorian Fainelli 	return phylink_ethtool_ksettings_get(dp->pl, cmd);
682aab9c406SFlorian Fainelli }
683aab9c406SFlorian Fainelli 
684aab9c406SFlorian Fainelli static int dsa_slave_set_link_ksettings(struct net_device *dev,
685aab9c406SFlorian Fainelli 					const struct ethtool_link_ksettings *cmd)
686aab9c406SFlorian Fainelli {
687aab9c406SFlorian Fainelli 	struct dsa_port *dp = dsa_slave_to_port(dev);
688aab9c406SFlorian Fainelli 
689aab9c406SFlorian Fainelli 	return phylink_ethtool_ksettings_set(dp->pl, cmd);
6907905288fSFlorian Fainelli }
6917905288fSFlorian Fainelli 
69204ff53f9SFlorian Fainelli #ifdef CONFIG_NET_POLL_CONTROLLER
69304ff53f9SFlorian Fainelli static int dsa_slave_netpoll_setup(struct net_device *dev,
69404ff53f9SFlorian Fainelli 				   struct netpoll_info *ni)
69504ff53f9SFlorian Fainelli {
696d0006b00SVivien Didelot 	struct net_device *master = dsa_slave_to_master(dev);
69704ff53f9SFlorian Fainelli 	struct dsa_slave_priv *p = netdev_priv(dev);
69804ff53f9SFlorian Fainelli 	struct netpoll *netpoll;
69904ff53f9SFlorian Fainelli 	int err = 0;
70004ff53f9SFlorian Fainelli 
70104ff53f9SFlorian Fainelli 	netpoll = kzalloc(sizeof(*netpoll), GFP_KERNEL);
70204ff53f9SFlorian Fainelli 	if (!netpoll)
70304ff53f9SFlorian Fainelli 		return -ENOMEM;
70404ff53f9SFlorian Fainelli 
70504ff53f9SFlorian Fainelli 	err = __netpoll_setup(netpoll, master);
70604ff53f9SFlorian Fainelli 	if (err) {
70704ff53f9SFlorian Fainelli 		kfree(netpoll);
70804ff53f9SFlorian Fainelli 		goto out;
70904ff53f9SFlorian Fainelli 	}
71004ff53f9SFlorian Fainelli 
71104ff53f9SFlorian Fainelli 	p->netpoll = netpoll;
71204ff53f9SFlorian Fainelli out:
71304ff53f9SFlorian Fainelli 	return err;
71404ff53f9SFlorian Fainelli }
71504ff53f9SFlorian Fainelli 
71604ff53f9SFlorian Fainelli static void dsa_slave_netpoll_cleanup(struct net_device *dev)
71704ff53f9SFlorian Fainelli {
71804ff53f9SFlorian Fainelli 	struct dsa_slave_priv *p = netdev_priv(dev);
71904ff53f9SFlorian Fainelli 	struct netpoll *netpoll = p->netpoll;
72004ff53f9SFlorian Fainelli 
72104ff53f9SFlorian Fainelli 	if (!netpoll)
72204ff53f9SFlorian Fainelli 		return;
72304ff53f9SFlorian Fainelli 
72404ff53f9SFlorian Fainelli 	p->netpoll = NULL;
72504ff53f9SFlorian Fainelli 
726c9fbd71fSDebabrata Banerjee 	__netpoll_free(netpoll);
72704ff53f9SFlorian Fainelli }
72804ff53f9SFlorian Fainelli 
72904ff53f9SFlorian Fainelli static void dsa_slave_poll_controller(struct net_device *dev)
73004ff53f9SFlorian Fainelli {
73104ff53f9SFlorian Fainelli }
73204ff53f9SFlorian Fainelli #endif
73304ff53f9SFlorian Fainelli 
73444bb765cSFlorian Fainelli static int dsa_slave_get_phys_port_name(struct net_device *dev,
73544bb765cSFlorian Fainelli 					char *name, size_t len)
73644bb765cSFlorian Fainelli {
737d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(dev);
73844bb765cSFlorian Fainelli 
739d945097bSVivien Didelot 	if (snprintf(name, len, "p%d", dp->index) >= len)
74044bb765cSFlorian Fainelli 		return -EINVAL;
7413a543ef4SFlorian Fainelli 
7423a543ef4SFlorian Fainelli 	return 0;
7433a543ef4SFlorian Fainelli }
7443a543ef4SFlorian Fainelli 
745f50f2127SFlorian Fainelli static struct dsa_mall_tc_entry *
7464fa7b718SVivien Didelot dsa_slave_mall_tc_entry_find(struct net_device *dev, unsigned long cookie)
747f50f2127SFlorian Fainelli {
7484fa7b718SVivien Didelot 	struct dsa_slave_priv *p = netdev_priv(dev);
749f50f2127SFlorian Fainelli 	struct dsa_mall_tc_entry *mall_tc_entry;
750f50f2127SFlorian Fainelli 
751f50f2127SFlorian Fainelli 	list_for_each_entry(mall_tc_entry, &p->mall_tc_list, list)
752f50f2127SFlorian Fainelli 		if (mall_tc_entry->cookie == cookie)
753f50f2127SFlorian Fainelli 			return mall_tc_entry;
754f50f2127SFlorian Fainelli 
755f50f2127SFlorian Fainelli 	return NULL;
756f50f2127SFlorian Fainelli }
757f50f2127SFlorian Fainelli 
758f50f2127SFlorian Fainelli static int dsa_slave_add_cls_matchall(struct net_device *dev,
759f50f2127SFlorian Fainelli 				      struct tc_cls_matchall_offload *cls,
760f50f2127SFlorian Fainelli 				      bool ingress)
761f50f2127SFlorian Fainelli {
762d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(dev);
763f50f2127SFlorian Fainelli 	struct dsa_slave_priv *p = netdev_priv(dev);
764f50f2127SFlorian Fainelli 	struct dsa_mall_tc_entry *mall_tc_entry;
7655fd9fc4eSJiri Pirko 	__be16 protocol = cls->common.protocol;
766d945097bSVivien Didelot 	struct dsa_switch *ds = dp->ds;
767f50f2127SFlorian Fainelli 	struct net_device *to_dev;
768f50f2127SFlorian Fainelli 	const struct tc_action *a;
769d945097bSVivien Didelot 	struct dsa_port *to_dp;
770f50f2127SFlorian Fainelli 	int err = -EOPNOTSUPP;
771f50f2127SFlorian Fainelli 
772f50f2127SFlorian Fainelli 	if (!ds->ops->port_mirror_add)
773f50f2127SFlorian Fainelli 		return err;
774f50f2127SFlorian Fainelli 
7753bcc0cecSJiri Pirko 	if (!tcf_exts_has_one_action(cls->exts))
776f50f2127SFlorian Fainelli 		return err;
777f50f2127SFlorian Fainelli 
778244cd96aSCong Wang 	a = tcf_exts_first_action(cls->exts);
779f50f2127SFlorian Fainelli 
780f50f2127SFlorian Fainelli 	if (is_tcf_mirred_egress_mirror(a) && protocol == htons(ETH_P_ALL)) {
781f50f2127SFlorian Fainelli 		struct dsa_mall_mirror_tc_entry *mirror;
782f50f2127SFlorian Fainelli 
7839f8a739eSCong Wang 		to_dev = tcf_mirred_dev(a);
784f50f2127SFlorian Fainelli 		if (!to_dev)
785f50f2127SFlorian Fainelli 			return -EINVAL;
786f50f2127SFlorian Fainelli 
787f50f2127SFlorian Fainelli 		if (!dsa_slave_dev_check(to_dev))
788f50f2127SFlorian Fainelli 			return -EOPNOTSUPP;
789f50f2127SFlorian Fainelli 
790f50f2127SFlorian Fainelli 		mall_tc_entry = kzalloc(sizeof(*mall_tc_entry), GFP_KERNEL);
791f50f2127SFlorian Fainelli 		if (!mall_tc_entry)
792f50f2127SFlorian Fainelli 			return -ENOMEM;
793f50f2127SFlorian Fainelli 
794f50f2127SFlorian Fainelli 		mall_tc_entry->cookie = cls->cookie;
795f50f2127SFlorian Fainelli 		mall_tc_entry->type = DSA_PORT_MALL_MIRROR;
796f50f2127SFlorian Fainelli 		mirror = &mall_tc_entry->mirror;
797f50f2127SFlorian Fainelli 
798d945097bSVivien Didelot 		to_dp = dsa_slave_to_port(to_dev);
799f50f2127SFlorian Fainelli 
800d945097bSVivien Didelot 		mirror->to_local_port = to_dp->index;
801f50f2127SFlorian Fainelli 		mirror->ingress = ingress;
802f50f2127SFlorian Fainelli 
803d945097bSVivien Didelot 		err = ds->ops->port_mirror_add(ds, dp->index, mirror, ingress);
804f50f2127SFlorian Fainelli 		if (err) {
805f50f2127SFlorian Fainelli 			kfree(mall_tc_entry);
806f50f2127SFlorian Fainelli 			return err;
807f50f2127SFlorian Fainelli 		}
808f50f2127SFlorian Fainelli 
809f50f2127SFlorian Fainelli 		list_add_tail(&mall_tc_entry->list, &p->mall_tc_list);
810f50f2127SFlorian Fainelli 	}
811f50f2127SFlorian Fainelli 
812f50f2127SFlorian Fainelli 	return 0;
813f50f2127SFlorian Fainelli }
814f50f2127SFlorian Fainelli 
815f50f2127SFlorian Fainelli static void dsa_slave_del_cls_matchall(struct net_device *dev,
816f50f2127SFlorian Fainelli 				       struct tc_cls_matchall_offload *cls)
817f50f2127SFlorian Fainelli {
818d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(dev);
819f50f2127SFlorian Fainelli 	struct dsa_mall_tc_entry *mall_tc_entry;
820d945097bSVivien Didelot 	struct dsa_switch *ds = dp->ds;
821f50f2127SFlorian Fainelli 
822f50f2127SFlorian Fainelli 	if (!ds->ops->port_mirror_del)
823f50f2127SFlorian Fainelli 		return;
824f50f2127SFlorian Fainelli 
8254fa7b718SVivien Didelot 	mall_tc_entry = dsa_slave_mall_tc_entry_find(dev, cls->cookie);
826f50f2127SFlorian Fainelli 	if (!mall_tc_entry)
827f50f2127SFlorian Fainelli 		return;
828f50f2127SFlorian Fainelli 
829f50f2127SFlorian Fainelli 	list_del(&mall_tc_entry->list);
830f50f2127SFlorian Fainelli 
831f50f2127SFlorian Fainelli 	switch (mall_tc_entry->type) {
832f50f2127SFlorian Fainelli 	case DSA_PORT_MALL_MIRROR:
833d945097bSVivien Didelot 		ds->ops->port_mirror_del(ds, dp->index, &mall_tc_entry->mirror);
834f50f2127SFlorian Fainelli 		break;
835f50f2127SFlorian Fainelli 	default:
836f50f2127SFlorian Fainelli 		WARN_ON(1);
837f50f2127SFlorian Fainelli 	}
838f50f2127SFlorian Fainelli 
839f50f2127SFlorian Fainelli 	kfree(mall_tc_entry);
840f50f2127SFlorian Fainelli }
841f50f2127SFlorian Fainelli 
8423fbae382SJiri Pirko static int dsa_slave_setup_tc_cls_matchall(struct net_device *dev,
8436b3eb752SJiri Pirko 					   struct tc_cls_matchall_offload *cls,
8446b3eb752SJiri Pirko 					   bool ingress)
845f50f2127SFlorian Fainelli {
8465fd9fc4eSJiri Pirko 	if (cls->common.chain_index)
847a5fcf8a6SJiri Pirko 		return -EOPNOTSUPP;
848f50f2127SFlorian Fainelli 
8493fbae382SJiri Pirko 	switch (cls->command) {
8503fbae382SJiri Pirko 	case TC_CLSMATCHALL_REPLACE:
8515fd9fc4eSJiri Pirko 		return dsa_slave_add_cls_matchall(dev, cls, ingress);
8523fbae382SJiri Pirko 	case TC_CLSMATCHALL_DESTROY:
8533fbae382SJiri Pirko 		dsa_slave_del_cls_matchall(dev, cls);
8543fbae382SJiri Pirko 		return 0;
8553fbae382SJiri Pirko 	default:
8563fbae382SJiri Pirko 		return -EOPNOTSUPP;
8573fbae382SJiri Pirko 	}
8583fbae382SJiri Pirko }
8593fbae382SJiri Pirko 
8606b3eb752SJiri Pirko static int dsa_slave_setup_tc_block_cb(enum tc_setup_type type, void *type_data,
8616b3eb752SJiri Pirko 				       void *cb_priv, bool ingress)
8626b3eb752SJiri Pirko {
8636b3eb752SJiri Pirko 	struct net_device *dev = cb_priv;
8646b3eb752SJiri Pirko 
86544ae12a7SJiri Pirko 	if (!tc_can_offload(dev))
86644ae12a7SJiri Pirko 		return -EOPNOTSUPP;
86744ae12a7SJiri Pirko 
8686b3eb752SJiri Pirko 	switch (type) {
8696b3eb752SJiri Pirko 	case TC_SETUP_CLSMATCHALL:
8706b3eb752SJiri Pirko 		return dsa_slave_setup_tc_cls_matchall(dev, type_data, ingress);
8716b3eb752SJiri Pirko 	default:
8726b3eb752SJiri Pirko 		return -EOPNOTSUPP;
8736b3eb752SJiri Pirko 	}
8746b3eb752SJiri Pirko }
8756b3eb752SJiri Pirko 
8766b3eb752SJiri Pirko static int dsa_slave_setup_tc_block_cb_ig(enum tc_setup_type type,
8776b3eb752SJiri Pirko 					  void *type_data, void *cb_priv)
8786b3eb752SJiri Pirko {
8796b3eb752SJiri Pirko 	return dsa_slave_setup_tc_block_cb(type, type_data, cb_priv, true);
8806b3eb752SJiri Pirko }
8816b3eb752SJiri Pirko 
8826b3eb752SJiri Pirko static int dsa_slave_setup_tc_block_cb_eg(enum tc_setup_type type,
8836b3eb752SJiri Pirko 					  void *type_data, void *cb_priv)
8846b3eb752SJiri Pirko {
8856b3eb752SJiri Pirko 	return dsa_slave_setup_tc_block_cb(type, type_data, cb_priv, false);
8866b3eb752SJiri Pirko }
8876b3eb752SJiri Pirko 
8886b3eb752SJiri Pirko static int dsa_slave_setup_tc_block(struct net_device *dev,
8896b3eb752SJiri Pirko 				    struct tc_block_offload *f)
8906b3eb752SJiri Pirko {
8916b3eb752SJiri Pirko 	tc_setup_cb_t *cb;
8926b3eb752SJiri Pirko 
8936b3eb752SJiri Pirko 	if (f->binder_type == TCF_BLOCK_BINDER_TYPE_CLSACT_INGRESS)
8946b3eb752SJiri Pirko 		cb = dsa_slave_setup_tc_block_cb_ig;
8956b3eb752SJiri Pirko 	else if (f->binder_type == TCF_BLOCK_BINDER_TYPE_CLSACT_EGRESS)
8966b3eb752SJiri Pirko 		cb = dsa_slave_setup_tc_block_cb_eg;
8976b3eb752SJiri Pirko 	else
8986b3eb752SJiri Pirko 		return -EOPNOTSUPP;
8996b3eb752SJiri Pirko 
9006b3eb752SJiri Pirko 	switch (f->command) {
9016b3eb752SJiri Pirko 	case TC_BLOCK_BIND:
90260513bd8SJohn Hurley 		return tcf_block_cb_register(f->block, cb, dev, dev, f->extack);
9036b3eb752SJiri Pirko 	case TC_BLOCK_UNBIND:
9046b3eb752SJiri Pirko 		tcf_block_cb_unregister(f->block, cb, dev);
9056b3eb752SJiri Pirko 		return 0;
9066b3eb752SJiri Pirko 	default:
9076b3eb752SJiri Pirko 		return -EOPNOTSUPP;
9086b3eb752SJiri Pirko 	}
9096b3eb752SJiri Pirko }
9106b3eb752SJiri Pirko 
9113fbae382SJiri Pirko static int dsa_slave_setup_tc(struct net_device *dev, enum tc_setup_type type,
912de4784caSJiri Pirko 			      void *type_data)
9133fbae382SJiri Pirko {
9142572ac53SJiri Pirko 	switch (type) {
9156b3eb752SJiri Pirko 	case TC_SETUP_BLOCK:
9166b3eb752SJiri Pirko 		return dsa_slave_setup_tc_block(dev, type_data);
917f50f2127SFlorian Fainelli 	default:
918a5fcf8a6SJiri Pirko 		return -EOPNOTSUPP;
919f50f2127SFlorian Fainelli 	}
920f50f2127SFlorian Fainelli }
921f50f2127SFlorian Fainelli 
922f613ed66SFlorian Fainelli static void dsa_slave_get_stats64(struct net_device *dev,
923f613ed66SFlorian Fainelli 				  struct rtnl_link_stats64 *stats)
924f613ed66SFlorian Fainelli {
925f613ed66SFlorian Fainelli 	struct dsa_slave_priv *p = netdev_priv(dev);
9265f6b4e14SFlorian Fainelli 	struct pcpu_sw_netstats *s;
927f613ed66SFlorian Fainelli 	unsigned int start;
9285f6b4e14SFlorian Fainelli 	int i;
929f613ed66SFlorian Fainelli 
930f613ed66SFlorian Fainelli 	netdev_stats_to_stats64(stats, &dev->stats);
9315f6b4e14SFlorian Fainelli 	for_each_possible_cpu(i) {
9325f6b4e14SFlorian Fainelli 		u64 tx_packets, tx_bytes, rx_packets, rx_bytes;
9335f6b4e14SFlorian Fainelli 
9345f6b4e14SFlorian Fainelli 		s = per_cpu_ptr(p->stats64, i);
935f613ed66SFlorian Fainelli 		do {
9365f6b4e14SFlorian Fainelli 			start = u64_stats_fetch_begin_irq(&s->syncp);
9375f6b4e14SFlorian Fainelli 			tx_packets = s->tx_packets;
9385f6b4e14SFlorian Fainelli 			tx_bytes = s->tx_bytes;
9395f6b4e14SFlorian Fainelli 			rx_packets = s->rx_packets;
9405f6b4e14SFlorian Fainelli 			rx_bytes = s->rx_bytes;
9415f6b4e14SFlorian Fainelli 		} while (u64_stats_fetch_retry_irq(&s->syncp, start));
9425f6b4e14SFlorian Fainelli 
9435f6b4e14SFlorian Fainelli 		stats->tx_packets += tx_packets;
9445f6b4e14SFlorian Fainelli 		stats->tx_bytes += tx_bytes;
9455f6b4e14SFlorian Fainelli 		stats->rx_packets += rx_packets;
9465f6b4e14SFlorian Fainelli 		stats->rx_bytes += rx_bytes;
9475f6b4e14SFlorian Fainelli 	}
948f613ed66SFlorian Fainelli }
949f613ed66SFlorian Fainelli 
950bf9f2648SFlorian Fainelli static int dsa_slave_get_rxnfc(struct net_device *dev,
951bf9f2648SFlorian Fainelli 			       struct ethtool_rxnfc *nfc, u32 *rule_locs)
952bf9f2648SFlorian Fainelli {
953d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(dev);
954d945097bSVivien Didelot 	struct dsa_switch *ds = dp->ds;
955bf9f2648SFlorian Fainelli 
956bf9f2648SFlorian Fainelli 	if (!ds->ops->get_rxnfc)
957bf9f2648SFlorian Fainelli 		return -EOPNOTSUPP;
958bf9f2648SFlorian Fainelli 
959d945097bSVivien Didelot 	return ds->ops->get_rxnfc(ds, dp->index, nfc, rule_locs);
960bf9f2648SFlorian Fainelli }
961bf9f2648SFlorian Fainelli 
962bf9f2648SFlorian Fainelli static int dsa_slave_set_rxnfc(struct net_device *dev,
963bf9f2648SFlorian Fainelli 			       struct ethtool_rxnfc *nfc)
964bf9f2648SFlorian Fainelli {
965d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(dev);
966d945097bSVivien Didelot 	struct dsa_switch *ds = dp->ds;
967bf9f2648SFlorian Fainelli 
968bf9f2648SFlorian Fainelli 	if (!ds->ops->set_rxnfc)
969bf9f2648SFlorian Fainelli 		return -EOPNOTSUPP;
970bf9f2648SFlorian Fainelli 
971d945097bSVivien Didelot 	return ds->ops->set_rxnfc(ds, dp->index, nfc);
972bf9f2648SFlorian Fainelli }
973bf9f2648SFlorian Fainelli 
9740336369dSBrandon Streiff static int dsa_slave_get_ts_info(struct net_device *dev,
9750336369dSBrandon Streiff 				 struct ethtool_ts_info *ts)
9760336369dSBrandon Streiff {
9770336369dSBrandon Streiff 	struct dsa_slave_priv *p = netdev_priv(dev);
9780336369dSBrandon Streiff 	struct dsa_switch *ds = p->dp->ds;
9790336369dSBrandon Streiff 
9800336369dSBrandon Streiff 	if (!ds->ops->get_ts_info)
9810336369dSBrandon Streiff 		return -EOPNOTSUPP;
9820336369dSBrandon Streiff 
9830336369dSBrandon Streiff 	return ds->ops->get_ts_info(ds, p->dp->index, ts);
9840336369dSBrandon Streiff }
9850336369dSBrandon Streiff 
98691da11f8SLennert Buytenhek static const struct ethtool_ops dsa_slave_ethtool_ops = {
98791da11f8SLennert Buytenhek 	.get_drvinfo		= dsa_slave_get_drvinfo,
9883d762a0fSGuenter Roeck 	.get_regs_len		= dsa_slave_get_regs_len,
9893d762a0fSGuenter Roeck 	.get_regs		= dsa_slave_get_regs,
990aab9c406SFlorian Fainelli 	.nway_reset		= dsa_slave_nway_reset,
991c4aef9fcSFlorian Fainelli 	.get_link		= ethtool_op_get_link,
9926793abb4SGuenter Roeck 	.get_eeprom_len		= dsa_slave_get_eeprom_len,
9936793abb4SGuenter Roeck 	.get_eeprom		= dsa_slave_get_eeprom,
9946793abb4SGuenter Roeck 	.set_eeprom		= dsa_slave_set_eeprom,
99591da11f8SLennert Buytenhek 	.get_strings		= dsa_slave_get_strings,
99691da11f8SLennert Buytenhek 	.get_ethtool_stats	= dsa_slave_get_ethtool_stats,
99791da11f8SLennert Buytenhek 	.get_sset_count		= dsa_slave_get_sset_count,
99819e57c4eSFlorian Fainelli 	.set_wol		= dsa_slave_set_wol,
99919e57c4eSFlorian Fainelli 	.get_wol		= dsa_slave_get_wol,
10007905288fSFlorian Fainelli 	.set_eee		= dsa_slave_set_eee,
10017905288fSFlorian Fainelli 	.get_eee		= dsa_slave_get_eee,
1002aab9c406SFlorian Fainelli 	.get_link_ksettings	= dsa_slave_get_link_ksettings,
1003aab9c406SFlorian Fainelli 	.set_link_ksettings	= dsa_slave_set_link_ksettings,
1004bf9f2648SFlorian Fainelli 	.get_rxnfc		= dsa_slave_get_rxnfc,
1005bf9f2648SFlorian Fainelli 	.set_rxnfc		= dsa_slave_set_rxnfc,
10060336369dSBrandon Streiff 	.get_ts_info		= dsa_slave_get_ts_info,
100791da11f8SLennert Buytenhek };
100891da11f8SLennert Buytenhek 
10092a93c1a3SFlorian Fainelli /* legacy way, bypassing the bridge *****************************************/
10102a93c1a3SFlorian Fainelli int dsa_legacy_fdb_add(struct ndmsg *ndm, struct nlattr *tb[],
10112a93c1a3SFlorian Fainelli 		       struct net_device *dev,
10122a93c1a3SFlorian Fainelli 		       const unsigned char *addr, u16 vid,
101387b0984eSPetr Machata 		       u16 flags,
101487b0984eSPetr Machata 		       struct netlink_ext_ack *extack)
10152a93c1a3SFlorian Fainelli {
10162a93c1a3SFlorian Fainelli 	struct dsa_port *dp = dsa_slave_to_port(dev);
10172a93c1a3SFlorian Fainelli 
10182a93c1a3SFlorian Fainelli 	return dsa_port_fdb_add(dp, addr, vid);
10192a93c1a3SFlorian Fainelli }
10202a93c1a3SFlorian Fainelli 
10212a93c1a3SFlorian Fainelli int dsa_legacy_fdb_del(struct ndmsg *ndm, struct nlattr *tb[],
10222a93c1a3SFlorian Fainelli 		       struct net_device *dev,
10232a93c1a3SFlorian Fainelli 		       const unsigned char *addr, u16 vid)
10242a93c1a3SFlorian Fainelli {
10252a93c1a3SFlorian Fainelli 	struct dsa_port *dp = dsa_slave_to_port(dev);
10262a93c1a3SFlorian Fainelli 
10272a93c1a3SFlorian Fainelli 	return dsa_port_fdb_del(dp, addr, vid);
10282a93c1a3SFlorian Fainelli }
10292a93c1a3SFlorian Fainelli 
10303e8a72d1SFlorian Fainelli static const struct net_device_ops dsa_slave_netdev_ops = {
1031d442ad4aSStephen Hemminger 	.ndo_open	 	= dsa_slave_open,
1032d442ad4aSStephen Hemminger 	.ndo_stop		= dsa_slave_close,
10333e8a72d1SFlorian Fainelli 	.ndo_start_xmit		= dsa_slave_xmit,
1034d442ad4aSStephen Hemminger 	.ndo_change_rx_flags	= dsa_slave_change_rx_flags,
1035d442ad4aSStephen Hemminger 	.ndo_set_rx_mode	= dsa_slave_set_rx_mode,
1036d442ad4aSStephen Hemminger 	.ndo_set_mac_address	= dsa_slave_set_mac_address,
103737b8da1aSArkadi Sharshevsky 	.ndo_fdb_add		= dsa_legacy_fdb_add,
103837b8da1aSArkadi Sharshevsky 	.ndo_fdb_del		= dsa_legacy_fdb_del,
10392bedde1aSArkadi Sharshevsky 	.ndo_fdb_dump		= dsa_slave_fdb_dump,
1040d442ad4aSStephen Hemminger 	.ndo_do_ioctl		= dsa_slave_ioctl,
1041abd2be00SNicolas Dichtel 	.ndo_get_iflink		= dsa_slave_get_iflink,
104204ff53f9SFlorian Fainelli #ifdef CONFIG_NET_POLL_CONTROLLER
104304ff53f9SFlorian Fainelli 	.ndo_netpoll_setup	= dsa_slave_netpoll_setup,
104404ff53f9SFlorian Fainelli 	.ndo_netpoll_cleanup	= dsa_slave_netpoll_cleanup,
104504ff53f9SFlorian Fainelli 	.ndo_poll_controller	= dsa_slave_poll_controller,
104604ff53f9SFlorian Fainelli #endif
104744bb765cSFlorian Fainelli 	.ndo_get_phys_port_name	= dsa_slave_get_phys_port_name,
1048f50f2127SFlorian Fainelli 	.ndo_setup_tc		= dsa_slave_setup_tc,
1049f613ed66SFlorian Fainelli 	.ndo_get_stats64	= dsa_slave_get_stats64,
1050929d6c14SFlorian Fainelli 	.ndo_get_port_parent_id	= dsa_slave_get_port_parent_id,
105198237d43SScott Feldman };
105298237d43SScott Feldman 
10539d47c0a2SJiri Pirko static const struct switchdev_ops dsa_slave_switchdev_ops = {
105435636062SScott Feldman 	.switchdev_port_attr_set	= dsa_slave_port_attr_set,
1055d442ad4aSStephen Hemminger };
105691da11f8SLennert Buytenhek 
1057f37db85dSFlorian Fainelli static struct device_type dsa_type = {
1058f37db85dSFlorian Fainelli 	.name	= "dsa",
1059f37db85dSFlorian Fainelli };
1060f37db85dSFlorian Fainelli 
1061aab9c406SFlorian Fainelli static void dsa_slave_phylink_validate(struct net_device *dev,
1062aab9c406SFlorian Fainelli 				       unsigned long *supported,
1063aab9c406SFlorian Fainelli 				       struct phylink_link_state *state)
10640d8bcdd3SFlorian Fainelli {
1065d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(dev);
1066d945097bSVivien Didelot 	struct dsa_switch *ds = dp->ds;
10670d8bcdd3SFlorian Fainelli 
1068aab9c406SFlorian Fainelli 	if (!ds->ops->phylink_validate)
1069aab9c406SFlorian Fainelli 		return;
1070aab9c406SFlorian Fainelli 
1071aab9c406SFlorian Fainelli 	ds->ops->phylink_validate(ds, dp->index, supported, state);
10720d8bcdd3SFlorian Fainelli }
10730d8bcdd3SFlorian Fainelli 
1074aab9c406SFlorian Fainelli static int dsa_slave_phylink_mac_link_state(struct net_device *dev,
1075aab9c406SFlorian Fainelli 					    struct phylink_link_state *state)
1076ce31b31cSFlorian Fainelli {
1077aab9c406SFlorian Fainelli 	struct dsa_port *dp = dsa_slave_to_port(dev);
1078aab9c406SFlorian Fainelli 	struct dsa_switch *ds = dp->ds;
1079ce31b31cSFlorian Fainelli 
1080aab9c406SFlorian Fainelli 	/* Only called for SGMII and 802.3z */
1081aab9c406SFlorian Fainelli 	if (!ds->ops->phylink_mac_link_state)
1082aab9c406SFlorian Fainelli 		return -EOPNOTSUPP;
1083aab9c406SFlorian Fainelli 
1084aab9c406SFlorian Fainelli 	return ds->ops->phylink_mac_link_state(ds, dp->index, state);
1085b71be352SAndrew Lunn }
1086ce31b31cSFlorian Fainelli 
1087aab9c406SFlorian Fainelli static void dsa_slave_phylink_mac_config(struct net_device *dev,
1088aab9c406SFlorian Fainelli 					 unsigned int mode,
1089aab9c406SFlorian Fainelli 					 const struct phylink_link_state *state)
1090aab9c406SFlorian Fainelli {
1091aab9c406SFlorian Fainelli 	struct dsa_port *dp = dsa_slave_to_port(dev);
1092aab9c406SFlorian Fainelli 	struct dsa_switch *ds = dp->ds;
1093aab9c406SFlorian Fainelli 
1094aab9c406SFlorian Fainelli 	if (!ds->ops->phylink_mac_config)
1095aab9c406SFlorian Fainelli 		return;
1096aab9c406SFlorian Fainelli 
1097aab9c406SFlorian Fainelli 	ds->ops->phylink_mac_config(ds, dp->index, mode, state);
1098aab9c406SFlorian Fainelli }
1099aab9c406SFlorian Fainelli 
1100aab9c406SFlorian Fainelli static void dsa_slave_phylink_mac_an_restart(struct net_device *dev)
1101aab9c406SFlorian Fainelli {
1102aab9c406SFlorian Fainelli 	struct dsa_port *dp = dsa_slave_to_port(dev);
1103aab9c406SFlorian Fainelli 	struct dsa_switch *ds = dp->ds;
1104aab9c406SFlorian Fainelli 
1105aab9c406SFlorian Fainelli 	if (!ds->ops->phylink_mac_an_restart)
1106aab9c406SFlorian Fainelli 		return;
1107aab9c406SFlorian Fainelli 
1108aab9c406SFlorian Fainelli 	ds->ops->phylink_mac_an_restart(ds, dp->index);
1109aab9c406SFlorian Fainelli }
1110aab9c406SFlorian Fainelli 
1111aab9c406SFlorian Fainelli static void dsa_slave_phylink_mac_link_down(struct net_device *dev,
1112aab9c406SFlorian Fainelli 					    unsigned int mode,
1113aab9c406SFlorian Fainelli 					    phy_interface_t interface)
1114aab9c406SFlorian Fainelli {
1115aab9c406SFlorian Fainelli 	struct dsa_port *dp = dsa_slave_to_port(dev);
1116aab9c406SFlorian Fainelli 	struct dsa_switch *ds = dp->ds;
1117aab9c406SFlorian Fainelli 
1118aab9c406SFlorian Fainelli 	if (!ds->ops->phylink_mac_link_down) {
1119aab9c406SFlorian Fainelli 		if (ds->ops->adjust_link && dev->phydev)
1120aab9c406SFlorian Fainelli 			ds->ops->adjust_link(ds, dp->index, dev->phydev);
1121aab9c406SFlorian Fainelli 		return;
1122aab9c406SFlorian Fainelli 	}
1123aab9c406SFlorian Fainelli 
1124aab9c406SFlorian Fainelli 	ds->ops->phylink_mac_link_down(ds, dp->index, mode, interface);
1125aab9c406SFlorian Fainelli }
1126aab9c406SFlorian Fainelli 
1127aab9c406SFlorian Fainelli static void dsa_slave_phylink_mac_link_up(struct net_device *dev,
1128aab9c406SFlorian Fainelli 					  unsigned int mode,
1129aab9c406SFlorian Fainelli 					  phy_interface_t interface,
1130aab9c406SFlorian Fainelli 					  struct phy_device *phydev)
1131aab9c406SFlorian Fainelli {
1132aab9c406SFlorian Fainelli 	struct dsa_port *dp = dsa_slave_to_port(dev);
1133aab9c406SFlorian Fainelli 	struct dsa_switch *ds = dp->ds;
1134aab9c406SFlorian Fainelli 
1135aab9c406SFlorian Fainelli 	if (!ds->ops->phylink_mac_link_up) {
1136aab9c406SFlorian Fainelli 		if (ds->ops->adjust_link && dev->phydev)
1137aab9c406SFlorian Fainelli 			ds->ops->adjust_link(ds, dp->index, dev->phydev);
1138aab9c406SFlorian Fainelli 		return;
1139aab9c406SFlorian Fainelli 	}
1140aab9c406SFlorian Fainelli 
1141aab9c406SFlorian Fainelli 	ds->ops->phylink_mac_link_up(ds, dp->index, mode, interface, phydev);
1142aab9c406SFlorian Fainelli }
1143aab9c406SFlorian Fainelli 
1144aab9c406SFlorian Fainelli static const struct phylink_mac_ops dsa_slave_phylink_mac_ops = {
1145aab9c406SFlorian Fainelli 	.validate = dsa_slave_phylink_validate,
1146aab9c406SFlorian Fainelli 	.mac_link_state = dsa_slave_phylink_mac_link_state,
1147aab9c406SFlorian Fainelli 	.mac_config = dsa_slave_phylink_mac_config,
1148aab9c406SFlorian Fainelli 	.mac_an_restart = dsa_slave_phylink_mac_an_restart,
1149aab9c406SFlorian Fainelli 	.mac_link_down = dsa_slave_phylink_mac_link_down,
1150aab9c406SFlorian Fainelli 	.mac_link_up = dsa_slave_phylink_mac_link_up,
1151aab9c406SFlorian Fainelli };
1152aab9c406SFlorian Fainelli 
1153aab9c406SFlorian Fainelli void dsa_port_phylink_mac_change(struct dsa_switch *ds, int port, bool up)
1154aab9c406SFlorian Fainelli {
1155aab9c406SFlorian Fainelli 	const struct dsa_port *dp = dsa_to_port(ds, port);
1156aab9c406SFlorian Fainelli 
1157aab9c406SFlorian Fainelli 	phylink_mac_change(dp->pl, up);
1158aab9c406SFlorian Fainelli }
1159aab9c406SFlorian Fainelli EXPORT_SYMBOL_GPL(dsa_port_phylink_mac_change);
1160aab9c406SFlorian Fainelli 
1161aab9c406SFlorian Fainelli static void dsa_slave_phylink_fixed_state(struct net_device *dev,
1162aab9c406SFlorian Fainelli 					  struct phylink_link_state *state)
1163aab9c406SFlorian Fainelli {
1164aab9c406SFlorian Fainelli 	struct dsa_port *dp = dsa_slave_to_port(dev);
1165aab9c406SFlorian Fainelli 	struct dsa_switch *ds = dp->ds;
1166aab9c406SFlorian Fainelli 
1167aab9c406SFlorian Fainelli 	/* No need to check that this operation is valid, the callback would
1168aab9c406SFlorian Fainelli 	 * not be called if it was not.
1169aab9c406SFlorian Fainelli 	 */
1170aab9c406SFlorian Fainelli 	ds->ops->phylink_fixed_state(ds, dp->index, state);
1171ce31b31cSFlorian Fainelli }
1172ce31b31cSFlorian Fainelli 
117391da11f8SLennert Buytenhek /* slave device setup *******************************************************/
11744fa7b718SVivien Didelot static int dsa_slave_phy_connect(struct net_device *slave_dev, int addr)
1175c305c165SFlorian Fainelli {
1176d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(slave_dev);
1177d945097bSVivien Didelot 	struct dsa_switch *ds = dp->ds;
1178c305c165SFlorian Fainelli 
11790115dcd1SVivien Didelot 	slave_dev->phydev = mdiobus_get_phy(ds->slave_mii_bus, addr);
11800115dcd1SVivien Didelot 	if (!slave_dev->phydev) {
1181d25b8e74SRussell King 		netdev_err(slave_dev, "no phy at %d\n", addr);
1182c305c165SFlorian Fainelli 		return -ENODEV;
1183d25b8e74SRussell King 	}
1184c305c165SFlorian Fainelli 
1185aab9c406SFlorian Fainelli 	return phylink_connect_phy(dp->pl, slave_dev->phydev);
1186c305c165SFlorian Fainelli }
1187c305c165SFlorian Fainelli 
11884fa7b718SVivien Didelot static int dsa_slave_phy_setup(struct net_device *slave_dev)
11890d8bcdd3SFlorian Fainelli {
1190d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(slave_dev);
1191d945097bSVivien Didelot 	struct device_node *port_dn = dp->dn;
1192d945097bSVivien Didelot 	struct dsa_switch *ds = dp->ds;
11936819563eSFlorian Fainelli 	u32 phy_flags = 0;
119419334920SGuenter Roeck 	int mode, ret;
11950d8bcdd3SFlorian Fainelli 
119619334920SGuenter Roeck 	mode = of_get_phy_mode(port_dn);
119719334920SGuenter Roeck 	if (mode < 0)
119819334920SGuenter Roeck 		mode = PHY_INTERFACE_MODE_NA;
11990d8bcdd3SFlorian Fainelli 
1200aab9c406SFlorian Fainelli 	dp->pl = phylink_create(slave_dev, of_fwnode_handle(port_dn), mode,
1201aab9c406SFlorian Fainelli 				&dsa_slave_phylink_mac_ops);
1202aab9c406SFlorian Fainelli 	if (IS_ERR(dp->pl)) {
1203aab9c406SFlorian Fainelli 		netdev_err(slave_dev,
1204aab9c406SFlorian Fainelli 			   "error creating PHYLINK: %ld\n", PTR_ERR(dp->pl));
1205aab9c406SFlorian Fainelli 		return PTR_ERR(dp->pl);
1206aab9c406SFlorian Fainelli 	}
1207aab9c406SFlorian Fainelli 
1208aab9c406SFlorian Fainelli 	/* Register only if the switch provides such a callback, since this
1209aab9c406SFlorian Fainelli 	 * callback takes precedence over polling the link GPIO in PHYLINK
1210aab9c406SFlorian Fainelli 	 * (see phylink_get_fixed_state).
12110d8bcdd3SFlorian Fainelli 	 */
1212aab9c406SFlorian Fainelli 	if (ds->ops->phylink_fixed_state)
1213aab9c406SFlorian Fainelli 		phylink_fixed_state_cb(dp->pl, dsa_slave_phylink_fixed_state);
12140d8bcdd3SFlorian Fainelli 
12159d490b4eSVivien Didelot 	if (ds->ops->get_phy_flags)
1216d945097bSVivien Didelot 		phy_flags = ds->ops->get_phy_flags(ds, dp->index);
12176819563eSFlorian Fainelli 
1218aab9c406SFlorian Fainelli 	ret = phylink_of_phy_connect(dp->pl, port_dn, phy_flags);
1219aab9c406SFlorian Fainelli 	if (ret == -ENODEV) {
1220aab9c406SFlorian Fainelli 		/* We could not connect to a designated PHY or SFP, so use the
1221aab9c406SFlorian Fainelli 		 * switch internal MDIO bus instead
12220d8bcdd3SFlorian Fainelli 		 */
1223d945097bSVivien Didelot 		ret = dsa_slave_phy_connect(slave_dev, dp->index);
1224d25b8e74SRussell King 		if (ret) {
1225aab9c406SFlorian Fainelli 			netdev_err(slave_dev,
1226aab9c406SFlorian Fainelli 				   "failed to connect to port %d: %d\n",
1227d945097bSVivien Didelot 				   dp->index, ret);
1228aab9c406SFlorian Fainelli 			phylink_destroy(dp->pl);
1229c305c165SFlorian Fainelli 			return ret;
1230d25b8e74SRussell King 		}
12310d8bcdd3SFlorian Fainelli 	}
12329697f1cdSFlorian Fainelli 
12339697f1cdSFlorian Fainelli 	return 0;
1234b31f65fbSAndrew Lunn }
12350d8bcdd3SFlorian Fainelli 
1236448b4482SAndrew Lunn static struct lock_class_key dsa_slave_netdev_xmit_lock_key;
1237448b4482SAndrew Lunn static void dsa_slave_set_lockdep_class_one(struct net_device *dev,
1238448b4482SAndrew Lunn 					    struct netdev_queue *txq,
1239448b4482SAndrew Lunn 					    void *_unused)
1240448b4482SAndrew Lunn {
1241448b4482SAndrew Lunn 	lockdep_set_class(&txq->_xmit_lock,
1242448b4482SAndrew Lunn 			  &dsa_slave_netdev_xmit_lock_key);
1243448b4482SAndrew Lunn }
1244448b4482SAndrew Lunn 
124524462549SFlorian Fainelli int dsa_slave_suspend(struct net_device *slave_dev)
124624462549SFlorian Fainelli {
1247aab9c406SFlorian Fainelli 	struct dsa_port *dp = dsa_slave_to_port(slave_dev);
124824462549SFlorian Fainelli 
1249a94c689eSFlorian Fainelli 	if (!netif_running(slave_dev))
1250a94c689eSFlorian Fainelli 		return 0;
1251a94c689eSFlorian Fainelli 
1252f154be24SFlorian Fainelli 	netif_device_detach(slave_dev);
1253f154be24SFlorian Fainelli 
1254aab9c406SFlorian Fainelli 	rtnl_lock();
1255aab9c406SFlorian Fainelli 	phylink_stop(dp->pl);
1256aab9c406SFlorian Fainelli 	rtnl_unlock();
125724462549SFlorian Fainelli 
125824462549SFlorian Fainelli 	return 0;
125924462549SFlorian Fainelli }
126024462549SFlorian Fainelli 
126124462549SFlorian Fainelli int dsa_slave_resume(struct net_device *slave_dev)
126224462549SFlorian Fainelli {
1263aab9c406SFlorian Fainelli 	struct dsa_port *dp = dsa_slave_to_port(slave_dev);
1264aab9c406SFlorian Fainelli 
1265a94c689eSFlorian Fainelli 	if (!netif_running(slave_dev))
1266a94c689eSFlorian Fainelli 		return 0;
1267a94c689eSFlorian Fainelli 
126824462549SFlorian Fainelli 	netif_device_attach(slave_dev);
126924462549SFlorian Fainelli 
1270aab9c406SFlorian Fainelli 	rtnl_lock();
1271aab9c406SFlorian Fainelli 	phylink_start(dp->pl);
1272aab9c406SFlorian Fainelli 	rtnl_unlock();
127324462549SFlorian Fainelli 
127424462549SFlorian Fainelli 	return 0;
127524462549SFlorian Fainelli }
127624462549SFlorian Fainelli 
12776158eaa7SVivien Didelot static void dsa_slave_notify(struct net_device *dev, unsigned long val)
12786158eaa7SVivien Didelot {
1279d0006b00SVivien Didelot 	struct net_device *master = dsa_slave_to_master(dev);
1280d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(dev);
12816158eaa7SVivien Didelot 	struct dsa_notifier_register_info rinfo = {
12826158eaa7SVivien Didelot 		.switch_number = dp->ds->index,
12836158eaa7SVivien Didelot 		.port_number = dp->index,
12846158eaa7SVivien Didelot 		.master = master,
12856158eaa7SVivien Didelot 		.info.dev = dev,
12866158eaa7SVivien Didelot 	};
12876158eaa7SVivien Didelot 
12886158eaa7SVivien Didelot 	call_dsa_notifiers(val, dev, &rinfo.info);
12896158eaa7SVivien Didelot }
12906158eaa7SVivien Didelot 
1291951259aaSVivien Didelot int dsa_slave_create(struct dsa_port *port)
129291da11f8SLennert Buytenhek {
129324a9332aSVivien Didelot 	const struct dsa_port *cpu_dp = port->cpu_dp;
1294f8b8b1cdSVivien Didelot 	struct net_device *master = cpu_dp->master;
12954cfbf09cSVivien Didelot 	struct dsa_switch *ds = port->ds;
1296951259aaSVivien Didelot 	const char *name = port->name;
129791da11f8SLennert Buytenhek 	struct net_device *slave_dev;
129891da11f8SLennert Buytenhek 	struct dsa_slave_priv *p;
129991da11f8SLennert Buytenhek 	int ret;
130091da11f8SLennert Buytenhek 
130155199df6SFlorian Fainelli 	if (!ds->num_tx_queues)
130255199df6SFlorian Fainelli 		ds->num_tx_queues = 1;
130355199df6SFlorian Fainelli 
130455199df6SFlorian Fainelli 	slave_dev = alloc_netdev_mqs(sizeof(struct dsa_slave_priv), name,
130555199df6SFlorian Fainelli 				     NET_NAME_UNKNOWN, ether_setup,
130655199df6SFlorian Fainelli 				     ds->num_tx_queues, 1);
130791da11f8SLennert Buytenhek 	if (slave_dev == NULL)
1308d87d6f44SGuenter Roeck 		return -ENOMEM;
130991da11f8SLennert Buytenhek 
1310f50f2127SFlorian Fainelli 	slave_dev->features = master->vlan_features | NETIF_F_HW_TC;
1311f50f2127SFlorian Fainelli 	slave_dev->hw_features |= NETIF_F_HW_TC;
13127ad24ea4SWilfried Klaebe 	slave_dev->ethtool_ops = &dsa_slave_ethtool_ops;
13132fcc8005SBjørn Mork 	eth_hw_addr_inherit(slave_dev, master);
13140a5f107bSPhil Sutter 	slave_dev->priv_flags |= IFF_NO_QUEUE;
13153e8a72d1SFlorian Fainelli 	slave_dev->netdev_ops = &dsa_slave_netdev_ops;
13169d47c0a2SJiri Pirko 	slave_dev->switchdev_ops = &dsa_slave_switchdev_ops;
13178b1efc0fSJarod Wilson 	slave_dev->min_mtu = 0;
13188b1efc0fSJarod Wilson 	slave_dev->max_mtu = ETH_MAX_MTU;
1319f37db85dSFlorian Fainelli 	SET_NETDEV_DEVTYPE(slave_dev, &dsa_type);
1320d442ad4aSStephen Hemminger 
1321448b4482SAndrew Lunn 	netdev_for_each_tx_queue(slave_dev, dsa_slave_set_lockdep_class_one,
1322448b4482SAndrew Lunn 				 NULL);
1323448b4482SAndrew Lunn 
13244cfbf09cSVivien Didelot 	SET_NETDEV_DEV(slave_dev, port->ds->dev);
13254cfbf09cSVivien Didelot 	slave_dev->dev.of_node = port->dn;
132691da11f8SLennert Buytenhek 	slave_dev->vlan_features = master->vlan_features;
132791da11f8SLennert Buytenhek 
132891da11f8SLennert Buytenhek 	p = netdev_priv(slave_dev);
13295f6b4e14SFlorian Fainelli 	p->stats64 = netdev_alloc_pcpu_stats(struct pcpu_sw_netstats);
13305f6b4e14SFlorian Fainelli 	if (!p->stats64) {
13315f6b4e14SFlorian Fainelli 		free_netdev(slave_dev);
13325f6b4e14SFlorian Fainelli 		return -ENOMEM;
13335f6b4e14SFlorian Fainelli 	}
13344cfbf09cSVivien Didelot 	p->dp = port;
1335f50f2127SFlorian Fainelli 	INIT_LIST_HEAD(&p->mall_tc_list);
133615240248SVivien Didelot 	p->xmit = cpu_dp->tag_ops->xmit;
1337f8b8b1cdSVivien Didelot 	port->slave = slave_dev;
133891da11f8SLennert Buytenhek 
133991da11f8SLennert Buytenhek 	netif_carrier_off(slave_dev);
134091da11f8SLennert Buytenhek 
13414fa7b718SVivien Didelot 	ret = dsa_slave_phy_setup(slave_dev);
13420071f56eSAndrew Lunn 	if (ret) {
13430071f56eSAndrew Lunn 		netdev_err(master, "error %d setting up slave phy\n", ret);
1344e804441cSFlorian Fainelli 		goto out_free;
1345e804441cSFlorian Fainelli 	}
1346e804441cSFlorian Fainelli 
13476158eaa7SVivien Didelot 	dsa_slave_notify(slave_dev, DSA_PORT_REGISTER);
134860724d4bSFlorian Fainelli 
1349e804441cSFlorian Fainelli 	ret = register_netdev(slave_dev);
1350e804441cSFlorian Fainelli 	if (ret) {
1351e804441cSFlorian Fainelli 		netdev_err(master, "error %d registering interface %s\n",
1352e804441cSFlorian Fainelli 			   ret, slave_dev->name);
1353e804441cSFlorian Fainelli 		goto out_phy;
13540071f56eSAndrew Lunn 	}
13550071f56eSAndrew Lunn 
1356d87d6f44SGuenter Roeck 	return 0;
1357e804441cSFlorian Fainelli 
1358e804441cSFlorian Fainelli out_phy:
1359aab9c406SFlorian Fainelli 	rtnl_lock();
1360aab9c406SFlorian Fainelli 	phylink_disconnect_phy(p->dp->pl);
1361aab9c406SFlorian Fainelli 	rtnl_unlock();
1362aab9c406SFlorian Fainelli 	phylink_destroy(p->dp->pl);
1363e804441cSFlorian Fainelli out_free:
1364e804441cSFlorian Fainelli 	free_percpu(p->stats64);
1365e804441cSFlorian Fainelli 	free_netdev(slave_dev);
1366f8b8b1cdSVivien Didelot 	port->slave = NULL;
1367e804441cSFlorian Fainelli 	return ret;
136891da11f8SLennert Buytenhek }
1369b73adef6SFlorian Fainelli 
1370cda5c15bSNeil Armstrong void dsa_slave_destroy(struct net_device *slave_dev)
1371cda5c15bSNeil Armstrong {
1372d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(slave_dev);
1373cda5c15bSNeil Armstrong 	struct dsa_slave_priv *p = netdev_priv(slave_dev);
1374cda5c15bSNeil Armstrong 
1375cda5c15bSNeil Armstrong 	netif_carrier_off(slave_dev);
1376aab9c406SFlorian Fainelli 	rtnl_lock();
1377aab9c406SFlorian Fainelli 	phylink_disconnect_phy(dp->pl);
1378aab9c406SFlorian Fainelli 	rtnl_unlock();
1379881eadabSJohan Hovold 
13806158eaa7SVivien Didelot 	dsa_slave_notify(slave_dev, DSA_PORT_UNREGISTER);
1381cda5c15bSNeil Armstrong 	unregister_netdev(slave_dev);
1382aab9c406SFlorian Fainelli 	phylink_destroy(dp->pl);
13835f6b4e14SFlorian Fainelli 	free_percpu(p->stats64);
1384cda5c15bSNeil Armstrong 	free_netdev(slave_dev);
1385cda5c15bSNeil Armstrong }
1386cda5c15bSNeil Armstrong 
1387b73adef6SFlorian Fainelli static bool dsa_slave_dev_check(struct net_device *dev)
1388b73adef6SFlorian Fainelli {
1389b73adef6SFlorian Fainelli 	return dev->netdev_ops == &dsa_slave_netdev_ops;
1390b73adef6SFlorian Fainelli }
1391b73adef6SFlorian Fainelli 
13928e92ab3aSVivien Didelot static int dsa_slave_changeupper(struct net_device *dev,
13938e92ab3aSVivien Didelot 				 struct netdev_notifier_changeupper_info *info)
1394b73adef6SFlorian Fainelli {
1395d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(dev);
13968e92ab3aSVivien Didelot 	int err = NOTIFY_DONE;
1397b73adef6SFlorian Fainelli 
13988e92ab3aSVivien Didelot 	if (netif_is_bridge_master(info->upper_dev)) {
13998e92ab3aSVivien Didelot 		if (info->linking) {
140017d7802bSVivien Didelot 			err = dsa_port_bridge_join(dp, info->upper_dev);
14018e92ab3aSVivien Didelot 			err = notifier_from_errno(err);
14028e92ab3aSVivien Didelot 		} else {
140317d7802bSVivien Didelot 			dsa_port_bridge_leave(dp, info->upper_dev);
14048e92ab3aSVivien Didelot 			err = NOTIFY_OK;
14058e92ab3aSVivien Didelot 		}
14066debb68aSVivien Didelot 	}
1407b73adef6SFlorian Fainelli 
14088e92ab3aSVivien Didelot 	return err;
1409b73adef6SFlorian Fainelli }
1410b73adef6SFlorian Fainelli 
1411*cc1d5bdaSFlorian Fainelli static int dsa_slave_upper_vlan_check(struct net_device *dev,
1412*cc1d5bdaSFlorian Fainelli 				      struct netdev_notifier_changeupper_info *
1413*cc1d5bdaSFlorian Fainelli 				      info)
1414*cc1d5bdaSFlorian Fainelli {
1415*cc1d5bdaSFlorian Fainelli 	struct netlink_ext_ack *ext_ack;
1416*cc1d5bdaSFlorian Fainelli 	struct net_device *slave;
1417*cc1d5bdaSFlorian Fainelli 	struct dsa_port *dp;
1418*cc1d5bdaSFlorian Fainelli 
1419*cc1d5bdaSFlorian Fainelli 	ext_ack = netdev_notifier_info_to_extack(&info->info);
1420*cc1d5bdaSFlorian Fainelli 
1421*cc1d5bdaSFlorian Fainelli 	if (!is_vlan_dev(dev))
1422*cc1d5bdaSFlorian Fainelli 		return NOTIFY_DONE;
1423*cc1d5bdaSFlorian Fainelli 
1424*cc1d5bdaSFlorian Fainelli 	slave = vlan_dev_real_dev(dev);
1425*cc1d5bdaSFlorian Fainelli 	if (!dsa_slave_dev_check(slave))
1426*cc1d5bdaSFlorian Fainelli 		return NOTIFY_DONE;
1427*cc1d5bdaSFlorian Fainelli 
1428*cc1d5bdaSFlorian Fainelli 	dp = dsa_slave_to_port(slave);
1429*cc1d5bdaSFlorian Fainelli 	if (!dp->bridge_dev)
1430*cc1d5bdaSFlorian Fainelli 		return NOTIFY_DONE;
1431*cc1d5bdaSFlorian Fainelli 
1432*cc1d5bdaSFlorian Fainelli 	/* Deny enslaving a VLAN device into a VLAN-aware bridge */
1433*cc1d5bdaSFlorian Fainelli 	if (br_vlan_enabled(dp->bridge_dev) &&
1434*cc1d5bdaSFlorian Fainelli 	    netif_is_bridge_master(info->upper_dev) && info->linking) {
1435*cc1d5bdaSFlorian Fainelli 		NL_SET_ERR_MSG_MOD(ext_ack,
1436*cc1d5bdaSFlorian Fainelli 				   "Cannot enslave VLAN device into VLAN aware bridge");
1437*cc1d5bdaSFlorian Fainelli 		return notifier_from_errno(-EINVAL);
1438*cc1d5bdaSFlorian Fainelli 	}
1439*cc1d5bdaSFlorian Fainelli 
1440*cc1d5bdaSFlorian Fainelli 	return NOTIFY_DONE;
1441*cc1d5bdaSFlorian Fainelli }
1442*cc1d5bdaSFlorian Fainelli 
144388e4f0caSVivien Didelot static int dsa_slave_netdevice_event(struct notifier_block *nb,
1444b73adef6SFlorian Fainelli 				     unsigned long event, void *ptr)
1445b73adef6SFlorian Fainelli {
14466debb68aSVivien Didelot 	struct net_device *dev = netdev_notifier_info_to_dev(ptr);
1447b73adef6SFlorian Fainelli 
1448*cc1d5bdaSFlorian Fainelli 	if (event == NETDEV_CHANGEUPPER) {
144953bade8aSFlorian Fainelli 		if (!dsa_slave_dev_check(dev))
1450*cc1d5bdaSFlorian Fainelli 			return dsa_slave_upper_vlan_check(dev, ptr);
14518e92ab3aSVivien Didelot 
14528e92ab3aSVivien Didelot 		return dsa_slave_changeupper(dev, ptr);
1453*cc1d5bdaSFlorian Fainelli 	}
1454b73adef6SFlorian Fainelli 
1455b73adef6SFlorian Fainelli 	return NOTIFY_DONE;
1456b73adef6SFlorian Fainelli }
145788e4f0caSVivien Didelot 
1458c9eb3e0fSArkadi Sharshevsky struct dsa_switchdev_event_work {
1459c9eb3e0fSArkadi Sharshevsky 	struct work_struct work;
1460c9eb3e0fSArkadi Sharshevsky 	struct switchdev_notifier_fdb_info fdb_info;
1461c9eb3e0fSArkadi Sharshevsky 	struct net_device *dev;
1462c9eb3e0fSArkadi Sharshevsky 	unsigned long event;
1463c9eb3e0fSArkadi Sharshevsky };
1464c9eb3e0fSArkadi Sharshevsky 
1465c9eb3e0fSArkadi Sharshevsky static void dsa_slave_switchdev_event_work(struct work_struct *work)
1466c9eb3e0fSArkadi Sharshevsky {
1467c9eb3e0fSArkadi Sharshevsky 	struct dsa_switchdev_event_work *switchdev_work =
1468c9eb3e0fSArkadi Sharshevsky 		container_of(work, struct dsa_switchdev_event_work, work);
1469c9eb3e0fSArkadi Sharshevsky 	struct net_device *dev = switchdev_work->dev;
1470c9eb3e0fSArkadi Sharshevsky 	struct switchdev_notifier_fdb_info *fdb_info;
1471d945097bSVivien Didelot 	struct dsa_port *dp = dsa_slave_to_port(dev);
1472c9eb3e0fSArkadi Sharshevsky 	int err;
1473c9eb3e0fSArkadi Sharshevsky 
1474c9eb3e0fSArkadi Sharshevsky 	rtnl_lock();
1475c9eb3e0fSArkadi Sharshevsky 	switch (switchdev_work->event) {
1476c9eb3e0fSArkadi Sharshevsky 	case SWITCHDEV_FDB_ADD_TO_DEVICE:
1477c9eb3e0fSArkadi Sharshevsky 		fdb_info = &switchdev_work->fdb_info;
1478a37fb855SVivien Didelot 		if (!fdb_info->added_by_user)
1479a37fb855SVivien Didelot 			break;
1480a37fb855SVivien Didelot 
1481d945097bSVivien Didelot 		err = dsa_port_fdb_add(dp, fdb_info->addr, fdb_info->vid);
1482c9eb3e0fSArkadi Sharshevsky 		if (err) {
1483c9eb3e0fSArkadi Sharshevsky 			netdev_dbg(dev, "fdb add failed err=%d\n", err);
1484c9eb3e0fSArkadi Sharshevsky 			break;
1485c9eb3e0fSArkadi Sharshevsky 		}
1486e9ba0fbcSIdo Schimmel 		fdb_info->offloaded = true;
1487c9eb3e0fSArkadi Sharshevsky 		call_switchdev_notifiers(SWITCHDEV_FDB_OFFLOADED, dev,
14886685987cSPetr Machata 					 &fdb_info->info, NULL);
1489c9eb3e0fSArkadi Sharshevsky 		break;
1490c9eb3e0fSArkadi Sharshevsky 
1491c9eb3e0fSArkadi Sharshevsky 	case SWITCHDEV_FDB_DEL_TO_DEVICE:
1492c9eb3e0fSArkadi Sharshevsky 		fdb_info = &switchdev_work->fdb_info;
1493a37fb855SVivien Didelot 		if (!fdb_info->added_by_user)
1494a37fb855SVivien Didelot 			break;
1495a37fb855SVivien Didelot 
1496d945097bSVivien Didelot 		err = dsa_port_fdb_del(dp, fdb_info->addr, fdb_info->vid);
1497c9eb3e0fSArkadi Sharshevsky 		if (err) {
1498c9eb3e0fSArkadi Sharshevsky 			netdev_dbg(dev, "fdb del failed err=%d\n", err);
1499c9eb3e0fSArkadi Sharshevsky 			dev_close(dev);
1500c9eb3e0fSArkadi Sharshevsky 		}
1501c9eb3e0fSArkadi Sharshevsky 		break;
1502c9eb3e0fSArkadi Sharshevsky 	}
1503c9eb3e0fSArkadi Sharshevsky 	rtnl_unlock();
1504c9eb3e0fSArkadi Sharshevsky 
1505c9eb3e0fSArkadi Sharshevsky 	kfree(switchdev_work->fdb_info.addr);
1506c9eb3e0fSArkadi Sharshevsky 	kfree(switchdev_work);
1507c9eb3e0fSArkadi Sharshevsky 	dev_put(dev);
1508c9eb3e0fSArkadi Sharshevsky }
1509c9eb3e0fSArkadi Sharshevsky 
1510c9eb3e0fSArkadi Sharshevsky static int
1511c9eb3e0fSArkadi Sharshevsky dsa_slave_switchdev_fdb_work_init(struct dsa_switchdev_event_work *
1512c9eb3e0fSArkadi Sharshevsky 				  switchdev_work,
1513c9eb3e0fSArkadi Sharshevsky 				  const struct switchdev_notifier_fdb_info *
1514c9eb3e0fSArkadi Sharshevsky 				  fdb_info)
1515c9eb3e0fSArkadi Sharshevsky {
1516c9eb3e0fSArkadi Sharshevsky 	memcpy(&switchdev_work->fdb_info, fdb_info,
1517c9eb3e0fSArkadi Sharshevsky 	       sizeof(switchdev_work->fdb_info));
1518c9eb3e0fSArkadi Sharshevsky 	switchdev_work->fdb_info.addr = kzalloc(ETH_ALEN, GFP_ATOMIC);
1519c9eb3e0fSArkadi Sharshevsky 	if (!switchdev_work->fdb_info.addr)
1520c9eb3e0fSArkadi Sharshevsky 		return -ENOMEM;
1521c9eb3e0fSArkadi Sharshevsky 	ether_addr_copy((u8 *)switchdev_work->fdb_info.addr,
1522c9eb3e0fSArkadi Sharshevsky 			fdb_info->addr);
1523c9eb3e0fSArkadi Sharshevsky 	return 0;
1524c9eb3e0fSArkadi Sharshevsky }
1525c9eb3e0fSArkadi Sharshevsky 
1526c9eb3e0fSArkadi Sharshevsky /* Called under rcu_read_lock() */
1527c9eb3e0fSArkadi Sharshevsky static int dsa_slave_switchdev_event(struct notifier_block *unused,
1528c9eb3e0fSArkadi Sharshevsky 				     unsigned long event, void *ptr)
1529c9eb3e0fSArkadi Sharshevsky {
1530c9eb3e0fSArkadi Sharshevsky 	struct net_device *dev = switchdev_notifier_info_to_dev(ptr);
1531c9eb3e0fSArkadi Sharshevsky 	struct dsa_switchdev_event_work *switchdev_work;
1532c9eb3e0fSArkadi Sharshevsky 
1533c9eb3e0fSArkadi Sharshevsky 	if (!dsa_slave_dev_check(dev))
1534c9eb3e0fSArkadi Sharshevsky 		return NOTIFY_DONE;
1535c9eb3e0fSArkadi Sharshevsky 
1536c9eb3e0fSArkadi Sharshevsky 	switchdev_work = kzalloc(sizeof(*switchdev_work), GFP_ATOMIC);
1537c9eb3e0fSArkadi Sharshevsky 	if (!switchdev_work)
1538c9eb3e0fSArkadi Sharshevsky 		return NOTIFY_BAD;
1539c9eb3e0fSArkadi Sharshevsky 
1540c9eb3e0fSArkadi Sharshevsky 	INIT_WORK(&switchdev_work->work,
1541c9eb3e0fSArkadi Sharshevsky 		  dsa_slave_switchdev_event_work);
1542c9eb3e0fSArkadi Sharshevsky 	switchdev_work->dev = dev;
1543c9eb3e0fSArkadi Sharshevsky 	switchdev_work->event = event;
1544c9eb3e0fSArkadi Sharshevsky 
1545c9eb3e0fSArkadi Sharshevsky 	switch (event) {
1546c9eb3e0fSArkadi Sharshevsky 	case SWITCHDEV_FDB_ADD_TO_DEVICE: /* fall through */
1547c9eb3e0fSArkadi Sharshevsky 	case SWITCHDEV_FDB_DEL_TO_DEVICE:
1548a37fb855SVivien Didelot 		if (dsa_slave_switchdev_fdb_work_init(switchdev_work, ptr))
1549c9eb3e0fSArkadi Sharshevsky 			goto err_fdb_work_init;
1550c9eb3e0fSArkadi Sharshevsky 		dev_hold(dev);
1551c9eb3e0fSArkadi Sharshevsky 		break;
1552c9eb3e0fSArkadi Sharshevsky 	default:
1553c9eb3e0fSArkadi Sharshevsky 		kfree(switchdev_work);
1554c9eb3e0fSArkadi Sharshevsky 		return NOTIFY_DONE;
1555c9eb3e0fSArkadi Sharshevsky 	}
1556c9eb3e0fSArkadi Sharshevsky 
1557c9eb3e0fSArkadi Sharshevsky 	dsa_schedule_work(&switchdev_work->work);
1558c9eb3e0fSArkadi Sharshevsky 	return NOTIFY_OK;
1559c9eb3e0fSArkadi Sharshevsky 
1560c9eb3e0fSArkadi Sharshevsky err_fdb_work_init:
1561c9eb3e0fSArkadi Sharshevsky 	kfree(switchdev_work);
1562c9eb3e0fSArkadi Sharshevsky 	return NOTIFY_BAD;
1563c9eb3e0fSArkadi Sharshevsky }
1564c9eb3e0fSArkadi Sharshevsky 
15652b239f67SPetr Machata static int
15662b239f67SPetr Machata dsa_slave_switchdev_port_obj_event(unsigned long event,
15672b239f67SPetr Machata 			struct net_device *netdev,
15682b239f67SPetr Machata 			struct switchdev_notifier_port_obj_info *port_obj_info)
15692b239f67SPetr Machata {
15702b239f67SPetr Machata 	int err = -EOPNOTSUPP;
15712b239f67SPetr Machata 
15722b239f67SPetr Machata 	switch (event) {
15732b239f67SPetr Machata 	case SWITCHDEV_PORT_OBJ_ADD:
15742b239f67SPetr Machata 		err = dsa_slave_port_obj_add(netdev, port_obj_info->obj,
15752b239f67SPetr Machata 					     port_obj_info->trans);
15762b239f67SPetr Machata 		break;
15772b239f67SPetr Machata 	case SWITCHDEV_PORT_OBJ_DEL:
15782b239f67SPetr Machata 		err = dsa_slave_port_obj_del(netdev, port_obj_info->obj);
15792b239f67SPetr Machata 		break;
15802b239f67SPetr Machata 	}
15812b239f67SPetr Machata 
15822b239f67SPetr Machata 	port_obj_info->handled = true;
15832b239f67SPetr Machata 	return notifier_from_errno(err);
15842b239f67SPetr Machata }
15852b239f67SPetr Machata 
15862b239f67SPetr Machata static int dsa_slave_switchdev_blocking_event(struct notifier_block *unused,
15872b239f67SPetr Machata 					      unsigned long event, void *ptr)
15882b239f67SPetr Machata {
15892b239f67SPetr Machata 	struct net_device *dev = switchdev_notifier_info_to_dev(ptr);
15902b239f67SPetr Machata 
15912b239f67SPetr Machata 	if (!dsa_slave_dev_check(dev))
15922b239f67SPetr Machata 		return NOTIFY_DONE;
15932b239f67SPetr Machata 
15942b239f67SPetr Machata 	switch (event) {
15952b239f67SPetr Machata 	case SWITCHDEV_PORT_OBJ_ADD: /* fall through */
15962b239f67SPetr Machata 	case SWITCHDEV_PORT_OBJ_DEL:
15972b239f67SPetr Machata 		return dsa_slave_switchdev_port_obj_event(event, dev, ptr);
15982b239f67SPetr Machata 	}
15992b239f67SPetr Machata 
16002b239f67SPetr Machata 	return NOTIFY_DONE;
16012b239f67SPetr Machata }
16022b239f67SPetr Machata 
160388e4f0caSVivien Didelot static struct notifier_block dsa_slave_nb __read_mostly = {
160488e4f0caSVivien Didelot 	.notifier_call  = dsa_slave_netdevice_event,
160588e4f0caSVivien Didelot };
160688e4f0caSVivien Didelot 
1607c9eb3e0fSArkadi Sharshevsky static struct notifier_block dsa_slave_switchdev_notifier = {
1608c9eb3e0fSArkadi Sharshevsky 	.notifier_call = dsa_slave_switchdev_event,
1609c9eb3e0fSArkadi Sharshevsky };
1610c9eb3e0fSArkadi Sharshevsky 
16112b239f67SPetr Machata static struct notifier_block dsa_slave_switchdev_blocking_notifier = {
16122b239f67SPetr Machata 	.notifier_call = dsa_slave_switchdev_blocking_event,
16132b239f67SPetr Machata };
16142b239f67SPetr Machata 
161588e4f0caSVivien Didelot int dsa_slave_register_notifier(void)
161688e4f0caSVivien Didelot {
16172b239f67SPetr Machata 	struct notifier_block *nb;
1618c9eb3e0fSArkadi Sharshevsky 	int err;
1619c9eb3e0fSArkadi Sharshevsky 
1620c9eb3e0fSArkadi Sharshevsky 	err = register_netdevice_notifier(&dsa_slave_nb);
1621c9eb3e0fSArkadi Sharshevsky 	if (err)
1622c9eb3e0fSArkadi Sharshevsky 		return err;
1623c9eb3e0fSArkadi Sharshevsky 
1624c9eb3e0fSArkadi Sharshevsky 	err = register_switchdev_notifier(&dsa_slave_switchdev_notifier);
1625c9eb3e0fSArkadi Sharshevsky 	if (err)
1626c9eb3e0fSArkadi Sharshevsky 		goto err_switchdev_nb;
1627c9eb3e0fSArkadi Sharshevsky 
16282b239f67SPetr Machata 	nb = &dsa_slave_switchdev_blocking_notifier;
16292b239f67SPetr Machata 	err = register_switchdev_blocking_notifier(nb);
16302b239f67SPetr Machata 	if (err)
16312b239f67SPetr Machata 		goto err_switchdev_blocking_nb;
16322b239f67SPetr Machata 
1633c9eb3e0fSArkadi Sharshevsky 	return 0;
1634c9eb3e0fSArkadi Sharshevsky 
16352b239f67SPetr Machata err_switchdev_blocking_nb:
16362b239f67SPetr Machata 	unregister_switchdev_notifier(&dsa_slave_switchdev_notifier);
1637c9eb3e0fSArkadi Sharshevsky err_switchdev_nb:
1638c9eb3e0fSArkadi Sharshevsky 	unregister_netdevice_notifier(&dsa_slave_nb);
1639c9eb3e0fSArkadi Sharshevsky 	return err;
164088e4f0caSVivien Didelot }
164188e4f0caSVivien Didelot 
164288e4f0caSVivien Didelot void dsa_slave_unregister_notifier(void)
164388e4f0caSVivien Didelot {
16442b239f67SPetr Machata 	struct notifier_block *nb;
164588e4f0caSVivien Didelot 	int err;
164688e4f0caSVivien Didelot 
16472b239f67SPetr Machata 	nb = &dsa_slave_switchdev_blocking_notifier;
16482b239f67SPetr Machata 	err = unregister_switchdev_blocking_notifier(nb);
16492b239f67SPetr Machata 	if (err)
16502b239f67SPetr Machata 		pr_err("DSA: failed to unregister switchdev blocking notifier (%d)\n", err);
16512b239f67SPetr Machata 
1652c9eb3e0fSArkadi Sharshevsky 	err = unregister_switchdev_notifier(&dsa_slave_switchdev_notifier);
1653c9eb3e0fSArkadi Sharshevsky 	if (err)
1654c9eb3e0fSArkadi Sharshevsky 		pr_err("DSA: failed to unregister switchdev notifier (%d)\n", err);
1655c9eb3e0fSArkadi Sharshevsky 
165688e4f0caSVivien Didelot 	err = unregister_netdevice_notifier(&dsa_slave_nb);
165788e4f0caSVivien Didelot 	if (err)
165888e4f0caSVivien Didelot 		pr_err("DSA: failed to unregister slave notifier (%d)\n", err);
165988e4f0caSVivien Didelot }
1660