xref: /openbmc/linux/net/dsa/master.c (revision 48e2331197b82c425e12ab728bb5332e49c78f63)
12874c5fdSThomas Gleixner // SPDX-License-Identifier: GPL-2.0-or-later
2f2f23566SVivien Didelot /*
3f2f23566SVivien Didelot  * Handling of a master device, switching frames via its switch fabric CPU port
4f2f23566SVivien Didelot  *
5f2f23566SVivien Didelot  * Copyright (c) 2017 Savoir-faire Linux Inc.
6f2f23566SVivien Didelot  *	Vivien Didelot <vivien.didelot@savoirfairelinux.com>
7f2f23566SVivien Didelot  */
8f2f23566SVivien Didelot 
9f2f23566SVivien Didelot #include "dsa_priv.h"
10f2f23566SVivien Didelot 
11*48e23311SVivien Didelot static int dsa_master_get_regs_len(struct net_device *dev)
12*48e23311SVivien Didelot {
13*48e23311SVivien Didelot 	struct dsa_port *cpu_dp = dev->dsa_ptr;
14*48e23311SVivien Didelot 	const struct ethtool_ops *ops = cpu_dp->orig_ethtool_ops;
15*48e23311SVivien Didelot 	struct dsa_switch *ds = cpu_dp->ds;
16*48e23311SVivien Didelot 	int port = cpu_dp->index;
17*48e23311SVivien Didelot 	int ret = 0;
18*48e23311SVivien Didelot 	int len;
19*48e23311SVivien Didelot 
20*48e23311SVivien Didelot 	if (ops->get_regs_len) {
21*48e23311SVivien Didelot 		len = ops->get_regs_len(dev);
22*48e23311SVivien Didelot 		if (len < 0)
23*48e23311SVivien Didelot 			return len;
24*48e23311SVivien Didelot 		ret += len;
25*48e23311SVivien Didelot 	}
26*48e23311SVivien Didelot 
27*48e23311SVivien Didelot 	ret += sizeof(struct ethtool_drvinfo);
28*48e23311SVivien Didelot 	ret += sizeof(struct ethtool_regs);
29*48e23311SVivien Didelot 
30*48e23311SVivien Didelot 	if (ds->ops->get_regs_len) {
31*48e23311SVivien Didelot 		len = ds->ops->get_regs_len(ds, port);
32*48e23311SVivien Didelot 		if (len < 0)
33*48e23311SVivien Didelot 			return len;
34*48e23311SVivien Didelot 		ret += len;
35*48e23311SVivien Didelot 	}
36*48e23311SVivien Didelot 
37*48e23311SVivien Didelot 	return ret;
38*48e23311SVivien Didelot }
39*48e23311SVivien Didelot 
40*48e23311SVivien Didelot static void dsa_master_get_regs(struct net_device *dev,
41*48e23311SVivien Didelot 				struct ethtool_regs *regs, void *data)
42*48e23311SVivien Didelot {
43*48e23311SVivien Didelot 	struct dsa_port *cpu_dp = dev->dsa_ptr;
44*48e23311SVivien Didelot 	const struct ethtool_ops *ops = cpu_dp->orig_ethtool_ops;
45*48e23311SVivien Didelot 	struct dsa_switch *ds = cpu_dp->ds;
46*48e23311SVivien Didelot 	struct ethtool_drvinfo *cpu_info;
47*48e23311SVivien Didelot 	struct ethtool_regs *cpu_regs;
48*48e23311SVivien Didelot 	int port = cpu_dp->index;
49*48e23311SVivien Didelot 	int len;
50*48e23311SVivien Didelot 
51*48e23311SVivien Didelot 	if (ops->get_regs_len && ops->get_regs) {
52*48e23311SVivien Didelot 		len = ops->get_regs_len(dev);
53*48e23311SVivien Didelot 		if (len < 0)
54*48e23311SVivien Didelot 			return;
55*48e23311SVivien Didelot 		regs->len = len;
56*48e23311SVivien Didelot 		ops->get_regs(dev, regs, data);
57*48e23311SVivien Didelot 		data += regs->len;
58*48e23311SVivien Didelot 	}
59*48e23311SVivien Didelot 
60*48e23311SVivien Didelot 	cpu_info = (struct ethtool_drvinfo *)data;
61*48e23311SVivien Didelot 	strlcpy(cpu_info->driver, "dsa", sizeof(cpu_info->driver));
62*48e23311SVivien Didelot 	data += sizeof(*cpu_info);
63*48e23311SVivien Didelot 	cpu_regs = (struct ethtool_regs *)data;
64*48e23311SVivien Didelot 	data += sizeof(*cpu_regs);
65*48e23311SVivien Didelot 
66*48e23311SVivien Didelot 	if (ds->ops->get_regs_len && ds->ops->get_regs) {
67*48e23311SVivien Didelot 		len = ds->ops->get_regs_len(ds, port);
68*48e23311SVivien Didelot 		if (len < 0)
69*48e23311SVivien Didelot 			return;
70*48e23311SVivien Didelot 		cpu_regs->len = len;
71*48e23311SVivien Didelot 		ds->ops->get_regs(ds, port, cpu_regs, data);
72*48e23311SVivien Didelot 	}
73*48e23311SVivien Didelot }
74*48e23311SVivien Didelot 
75f2f23566SVivien Didelot static void dsa_master_get_ethtool_stats(struct net_device *dev,
76f2f23566SVivien Didelot 					 struct ethtool_stats *stats,
77f2f23566SVivien Didelot 					 uint64_t *data)
78f2f23566SVivien Didelot {
792f657a60SVivien Didelot 	struct dsa_port *cpu_dp = dev->dsa_ptr;
807ec764eeSVivien Didelot 	const struct ethtool_ops *ops = cpu_dp->orig_ethtool_ops;
817ec764eeSVivien Didelot 	struct dsa_switch *ds = cpu_dp->ds;
827ec764eeSVivien Didelot 	int port = cpu_dp->index;
83f2f23566SVivien Didelot 	int count = 0;
84f2f23566SVivien Didelot 
851d1e79f1SFlorian Fainelli 	if (ops->get_sset_count && ops->get_ethtool_stats) {
86f2f23566SVivien Didelot 		count = ops->get_sset_count(dev, ETH_SS_STATS);
87f2f23566SVivien Didelot 		ops->get_ethtool_stats(dev, stats, data);
88f2f23566SVivien Didelot 	}
89f2f23566SVivien Didelot 
90f2f23566SVivien Didelot 	if (ds->ops->get_ethtool_stats)
917ec764eeSVivien Didelot 		ds->ops->get_ethtool_stats(ds, port, data + count);
92f2f23566SVivien Didelot }
93f2f23566SVivien Didelot 
94cf963573SFlorian Fainelli static void dsa_master_get_ethtool_phy_stats(struct net_device *dev,
95cf963573SFlorian Fainelli 					     struct ethtool_stats *stats,
96cf963573SFlorian Fainelli 					     uint64_t *data)
97cf963573SFlorian Fainelli {
98cf963573SFlorian Fainelli 	struct dsa_port *cpu_dp = dev->dsa_ptr;
99cf963573SFlorian Fainelli 	const struct ethtool_ops *ops = cpu_dp->orig_ethtool_ops;
100cf963573SFlorian Fainelli 	struct dsa_switch *ds = cpu_dp->ds;
101cf963573SFlorian Fainelli 	int port = cpu_dp->index;
102cf963573SFlorian Fainelli 	int count = 0;
103cf963573SFlorian Fainelli 
104cf963573SFlorian Fainelli 	if (dev->phydev && !ops->get_ethtool_phy_stats) {
105cf963573SFlorian Fainelli 		count = phy_ethtool_get_sset_count(dev->phydev);
106cf963573SFlorian Fainelli 		if (count >= 0)
107cf963573SFlorian Fainelli 			phy_ethtool_get_stats(dev->phydev, stats, data);
108cf963573SFlorian Fainelli 	} else if (ops->get_sset_count && ops->get_ethtool_phy_stats) {
109cf963573SFlorian Fainelli 		count = ops->get_sset_count(dev, ETH_SS_PHY_STATS);
110cf963573SFlorian Fainelli 		ops->get_ethtool_phy_stats(dev, stats, data);
111cf963573SFlorian Fainelli 	}
112cf963573SFlorian Fainelli 
113cf963573SFlorian Fainelli 	if (count < 0)
114cf963573SFlorian Fainelli 		count = 0;
115cf963573SFlorian Fainelli 
116cf963573SFlorian Fainelli 	if (ds->ops->get_ethtool_phy_stats)
117cf963573SFlorian Fainelli 		ds->ops->get_ethtool_phy_stats(ds, port, data + count);
118cf963573SFlorian Fainelli }
119cf963573SFlorian Fainelli 
120f2f23566SVivien Didelot static int dsa_master_get_sset_count(struct net_device *dev, int sset)
121f2f23566SVivien Didelot {
1222f657a60SVivien Didelot 	struct dsa_port *cpu_dp = dev->dsa_ptr;
1237ec764eeSVivien Didelot 	const struct ethtool_ops *ops = cpu_dp->orig_ethtool_ops;
1247ec764eeSVivien Didelot 	struct dsa_switch *ds = cpu_dp->ds;
125f2f23566SVivien Didelot 	int count = 0;
126f2f23566SVivien Didelot 
127cf963573SFlorian Fainelli 	if (sset == ETH_SS_PHY_STATS && dev->phydev &&
128cf963573SFlorian Fainelli 	    !ops->get_ethtool_phy_stats)
129cf963573SFlorian Fainelli 		count = phy_ethtool_get_sset_count(dev->phydev);
130cf963573SFlorian Fainelli 	else if (ops->get_sset_count)
13189f09048SFlorian Fainelli 		count = ops->get_sset_count(dev, sset);
132cf963573SFlorian Fainelli 
13389f09048SFlorian Fainelli 	if (count < 0)
13489f09048SFlorian Fainelli 		count = 0;
135f2f23566SVivien Didelot 
13689f09048SFlorian Fainelli 	if (ds->ops->get_sset_count)
13789f09048SFlorian Fainelli 		count += ds->ops->get_sset_count(ds, cpu_dp->index, sset);
138f2f23566SVivien Didelot 
139f2f23566SVivien Didelot 	return count;
140f2f23566SVivien Didelot }
141f2f23566SVivien Didelot 
142f2f23566SVivien Didelot static void dsa_master_get_strings(struct net_device *dev, uint32_t stringset,
143f2f23566SVivien Didelot 				   uint8_t *data)
144f2f23566SVivien Didelot {
1452f657a60SVivien Didelot 	struct dsa_port *cpu_dp = dev->dsa_ptr;
1467ec764eeSVivien Didelot 	const struct ethtool_ops *ops = cpu_dp->orig_ethtool_ops;
1477ec764eeSVivien Didelot 	struct dsa_switch *ds = cpu_dp->ds;
1487ec764eeSVivien Didelot 	int port = cpu_dp->index;
149f2f23566SVivien Didelot 	int len = ETH_GSTRING_LEN;
150f2f23566SVivien Didelot 	int mcount = 0, count;
151f2f23566SVivien Didelot 	unsigned int i;
152f2f23566SVivien Didelot 	uint8_t pfx[4];
153f2f23566SVivien Didelot 	uint8_t *ndata;
154f2f23566SVivien Didelot 
1557ec764eeSVivien Didelot 	snprintf(pfx, sizeof(pfx), "p%.2d", port);
156f2f23566SVivien Didelot 	/* We do not want to be NULL-terminated, since this is a prefix */
157f2f23566SVivien Didelot 	pfx[sizeof(pfx) - 1] = '_';
158f2f23566SVivien Didelot 
159cf963573SFlorian Fainelli 	if (stringset == ETH_SS_PHY_STATS && dev->phydev &&
160cf963573SFlorian Fainelli 	    !ops->get_ethtool_phy_stats) {
161cf963573SFlorian Fainelli 		mcount = phy_ethtool_get_sset_count(dev->phydev);
162cf963573SFlorian Fainelli 		if (mcount < 0)
163cf963573SFlorian Fainelli 			mcount = 0;
164cf963573SFlorian Fainelli 		else
165cf963573SFlorian Fainelli 			phy_ethtool_get_strings(dev->phydev, data);
166cf963573SFlorian Fainelli 	} else if (ops->get_sset_count && ops->get_strings) {
16789f09048SFlorian Fainelli 		mcount = ops->get_sset_count(dev, stringset);
16889f09048SFlorian Fainelli 		if (mcount < 0)
16989f09048SFlorian Fainelli 			mcount = 0;
170f2f23566SVivien Didelot 		ops->get_strings(dev, stringset, data);
171f2f23566SVivien Didelot 	}
172f2f23566SVivien Didelot 
17389f09048SFlorian Fainelli 	if (ds->ops->get_strings) {
174f2f23566SVivien Didelot 		ndata = data + mcount * len;
175f2f23566SVivien Didelot 		/* This function copies ETH_GSTRINGS_LEN bytes, we will mangle
176f2f23566SVivien Didelot 		 * the output after to prepend our CPU port prefix we
177f2f23566SVivien Didelot 		 * constructed earlier
178f2f23566SVivien Didelot 		 */
17989f09048SFlorian Fainelli 		ds->ops->get_strings(ds, port, stringset, ndata);
18089f09048SFlorian Fainelli 		count = ds->ops->get_sset_count(ds, port, stringset);
181f2f23566SVivien Didelot 		for (i = 0; i < count; i++) {
182f2f23566SVivien Didelot 			memmove(ndata + (i * len + sizeof(pfx)),
183f2f23566SVivien Didelot 				ndata + i * len, len - sizeof(pfx));
184f2f23566SVivien Didelot 			memcpy(ndata + i * len, pfx, sizeof(pfx));
185f2f23566SVivien Didelot 		}
186f2f23566SVivien Didelot 	}
187f2f23566SVivien Didelot }
188f2f23566SVivien Didelot 
189da7b9e9bSFlorian Fainelli static int dsa_master_get_phys_port_name(struct net_device *dev,
190da7b9e9bSFlorian Fainelli 					 char *name, size_t len)
191da7b9e9bSFlorian Fainelli {
192da7b9e9bSFlorian Fainelli 	struct dsa_port *cpu_dp = dev->dsa_ptr;
193da7b9e9bSFlorian Fainelli 
194da7b9e9bSFlorian Fainelli 	if (snprintf(name, len, "p%d", cpu_dp->index) >= len)
195da7b9e9bSFlorian Fainelli 		return -EINVAL;
196da7b9e9bSFlorian Fainelli 
197da7b9e9bSFlorian Fainelli 	return 0;
198da7b9e9bSFlorian Fainelli }
199da7b9e9bSFlorian Fainelli 
20017a22fcfSVivien Didelot static int dsa_master_ethtool_setup(struct net_device *dev)
201f2f23566SVivien Didelot {
2022f657a60SVivien Didelot 	struct dsa_port *cpu_dp = dev->dsa_ptr;
2037ec764eeSVivien Didelot 	struct dsa_switch *ds = cpu_dp->ds;
204f2f23566SVivien Didelot 	struct ethtool_ops *ops;
205f2f23566SVivien Didelot 
206f2f23566SVivien Didelot 	ops = devm_kzalloc(ds->dev, sizeof(*ops), GFP_KERNEL);
207f2f23566SVivien Didelot 	if (!ops)
208f2f23566SVivien Didelot 		return -ENOMEM;
209f2f23566SVivien Didelot 
2107ec764eeSVivien Didelot 	cpu_dp->orig_ethtool_ops = dev->ethtool_ops;
2117ec764eeSVivien Didelot 	if (cpu_dp->orig_ethtool_ops)
2127ec764eeSVivien Didelot 		memcpy(ops, cpu_dp->orig_ethtool_ops, sizeof(*ops));
213f2f23566SVivien Didelot 
214*48e23311SVivien Didelot 	ops->get_regs_len = dsa_master_get_regs_len;
215*48e23311SVivien Didelot 	ops->get_regs = dsa_master_get_regs;
216f2f23566SVivien Didelot 	ops->get_sset_count = dsa_master_get_sset_count;
217f2f23566SVivien Didelot 	ops->get_ethtool_stats = dsa_master_get_ethtool_stats;
218f2f23566SVivien Didelot 	ops->get_strings = dsa_master_get_strings;
219cf963573SFlorian Fainelli 	ops->get_ethtool_phy_stats = dsa_master_get_ethtool_phy_stats;
220f2f23566SVivien Didelot 
221f2f23566SVivien Didelot 	dev->ethtool_ops = ops;
222f2f23566SVivien Didelot 
223f2f23566SVivien Didelot 	return 0;
224f2f23566SVivien Didelot }
225f2f23566SVivien Didelot 
22617a22fcfSVivien Didelot static void dsa_master_ethtool_teardown(struct net_device *dev)
227f2f23566SVivien Didelot {
2282f657a60SVivien Didelot 	struct dsa_port *cpu_dp = dev->dsa_ptr;
229f2f23566SVivien Didelot 
2307ec764eeSVivien Didelot 	dev->ethtool_ops = cpu_dp->orig_ethtool_ops;
2317ec764eeSVivien Didelot 	cpu_dp->orig_ethtool_ops = NULL;
232f2f23566SVivien Didelot }
23317a22fcfSVivien Didelot 
234da7b9e9bSFlorian Fainelli static int dsa_master_ndo_setup(struct net_device *dev)
235da7b9e9bSFlorian Fainelli {
236da7b9e9bSFlorian Fainelli 	struct dsa_port *cpu_dp = dev->dsa_ptr;
237da7b9e9bSFlorian Fainelli 	struct dsa_switch *ds = cpu_dp->ds;
238da7b9e9bSFlorian Fainelli 	struct net_device_ops *ops;
239da7b9e9bSFlorian Fainelli 
240da7b9e9bSFlorian Fainelli 	if (dev->netdev_ops->ndo_get_phys_port_name)
241da7b9e9bSFlorian Fainelli 		return 0;
242da7b9e9bSFlorian Fainelli 
243da7b9e9bSFlorian Fainelli 	ops = devm_kzalloc(ds->dev, sizeof(*ops), GFP_KERNEL);
244da7b9e9bSFlorian Fainelli 	if (!ops)
245da7b9e9bSFlorian Fainelli 		return -ENOMEM;
246da7b9e9bSFlorian Fainelli 
247da7b9e9bSFlorian Fainelli 	cpu_dp->orig_ndo_ops = dev->netdev_ops;
248da7b9e9bSFlorian Fainelli 	if (cpu_dp->orig_ndo_ops)
249da7b9e9bSFlorian Fainelli 		memcpy(ops, cpu_dp->orig_ndo_ops, sizeof(*ops));
250da7b9e9bSFlorian Fainelli 
251da7b9e9bSFlorian Fainelli 	ops->ndo_get_phys_port_name = dsa_master_get_phys_port_name;
252da7b9e9bSFlorian Fainelli 
253da7b9e9bSFlorian Fainelli 	dev->netdev_ops  = ops;
254da7b9e9bSFlorian Fainelli 
255da7b9e9bSFlorian Fainelli 	return 0;
256da7b9e9bSFlorian Fainelli }
257da7b9e9bSFlorian Fainelli 
258da7b9e9bSFlorian Fainelli static void dsa_master_ndo_teardown(struct net_device *dev)
259da7b9e9bSFlorian Fainelli {
260da7b9e9bSFlorian Fainelli 	struct dsa_port *cpu_dp = dev->dsa_ptr;
261da7b9e9bSFlorian Fainelli 
262da7b9e9bSFlorian Fainelli 	dev->netdev_ops = cpu_dp->orig_ndo_ops;
263da7b9e9bSFlorian Fainelli 	cpu_dp->orig_ndo_ops = NULL;
264da7b9e9bSFlorian Fainelli }
265da7b9e9bSFlorian Fainelli 
266a3d7e01dSFlorian Fainelli static ssize_t tagging_show(struct device *d, struct device_attribute *attr,
267a3d7e01dSFlorian Fainelli 			    char *buf)
268a3d7e01dSFlorian Fainelli {
269a3d7e01dSFlorian Fainelli 	struct net_device *dev = to_net_dev(d);
270a3d7e01dSFlorian Fainelli 	struct dsa_port *cpu_dp = dev->dsa_ptr;
271a3d7e01dSFlorian Fainelli 
272a3d7e01dSFlorian Fainelli 	return sprintf(buf, "%s\n",
273a3d7e01dSFlorian Fainelli 		       dsa_tag_protocol_to_str(cpu_dp->tag_ops));
274a3d7e01dSFlorian Fainelli }
275a3d7e01dSFlorian Fainelli static DEVICE_ATTR_RO(tagging);
276a3d7e01dSFlorian Fainelli 
277a3d7e01dSFlorian Fainelli static struct attribute *dsa_slave_attrs[] = {
278a3d7e01dSFlorian Fainelli 	&dev_attr_tagging.attr,
279a3d7e01dSFlorian Fainelli 	NULL
280a3d7e01dSFlorian Fainelli };
281a3d7e01dSFlorian Fainelli 
282a3d7e01dSFlorian Fainelli static const struct attribute_group dsa_group = {
283a3d7e01dSFlorian Fainelli 	.name	= "dsa",
284a3d7e01dSFlorian Fainelli 	.attrs	= dsa_slave_attrs,
285a3d7e01dSFlorian Fainelli };
286a3d7e01dSFlorian Fainelli 
287a60956edSAndrew Lunn static void dsa_master_set_mtu(struct net_device *dev, struct dsa_port *cpu_dp)
288dc0fe7d4SAndrew Lunn {
289dc0fe7d4SAndrew Lunn 	unsigned int mtu = ETH_DATA_LEN + cpu_dp->tag_ops->overhead;
290dc0fe7d4SAndrew Lunn 	int err;
291dc0fe7d4SAndrew Lunn 
292dc0fe7d4SAndrew Lunn 	rtnl_lock();
293dc0fe7d4SAndrew Lunn 	if (mtu <= dev->max_mtu) {
294dc0fe7d4SAndrew Lunn 		err = dev_set_mtu(dev, mtu);
295dc0fe7d4SAndrew Lunn 		if (err)
296dc0fe7d4SAndrew Lunn 			netdev_dbg(dev, "Unable to set MTU to include for DSA overheads\n");
297dc0fe7d4SAndrew Lunn 	}
298dc0fe7d4SAndrew Lunn 	rtnl_unlock();
299dc0fe7d4SAndrew Lunn }
300dc0fe7d4SAndrew Lunn 
30191ba4795SAndrew Lunn static void dsa_master_reset_mtu(struct net_device *dev)
30291ba4795SAndrew Lunn {
30391ba4795SAndrew Lunn 	int err;
30491ba4795SAndrew Lunn 
30591ba4795SAndrew Lunn 	rtnl_lock();
30691ba4795SAndrew Lunn 	err = dev_set_mtu(dev, ETH_DATA_LEN);
30791ba4795SAndrew Lunn 	if (err)
30891ba4795SAndrew Lunn 		netdev_dbg(dev,
30991ba4795SAndrew Lunn 			   "Unable to reset MTU to exclude DSA overheads\n");
31091ba4795SAndrew Lunn 	rtnl_unlock();
31191ba4795SAndrew Lunn }
31291ba4795SAndrew Lunn 
313c8101f77SMarc Zyngier static struct lock_class_key dsa_master_addr_list_lock_key;
314c8101f77SMarc Zyngier 
31517a22fcfSVivien Didelot int dsa_master_setup(struct net_device *dev, struct dsa_port *cpu_dp)
31617a22fcfSVivien Didelot {
317a3d7e01dSFlorian Fainelli 	int ret;
318a3d7e01dSFlorian Fainelli 
319dc0fe7d4SAndrew Lunn 	dsa_master_set_mtu(dev,  cpu_dp);
320dc0fe7d4SAndrew Lunn 
32117a22fcfSVivien Didelot 	/* If we use a tagging format that doesn't have an ethertype
32217a22fcfSVivien Didelot 	 * field, make sure that all packets from this point on get
32317a22fcfSVivien Didelot 	 * sent to the tag format's receive function.
32417a22fcfSVivien Didelot 	 */
32517a22fcfSVivien Didelot 	wmb();
32617a22fcfSVivien Didelot 
32717a22fcfSVivien Didelot 	dev->dsa_ptr = cpu_dp;
328c8101f77SMarc Zyngier 	lockdep_set_class(&dev->addr_list_lock,
329c8101f77SMarc Zyngier 			  &dsa_master_addr_list_lock_key);
33017a22fcfSVivien Didelot 
331a3d7e01dSFlorian Fainelli 	ret = dsa_master_ethtool_setup(dev);
332a3d7e01dSFlorian Fainelli 	if (ret)
333a3d7e01dSFlorian Fainelli 		return ret;
334a3d7e01dSFlorian Fainelli 
335da7b9e9bSFlorian Fainelli 	ret = dsa_master_ndo_setup(dev);
336da7b9e9bSFlorian Fainelli 	if (ret)
337da7b9e9bSFlorian Fainelli 		goto out_err_ethtool_teardown;
338da7b9e9bSFlorian Fainelli 
339a3d7e01dSFlorian Fainelli 	ret = sysfs_create_group(&dev->dev.kobj, &dsa_group);
340a3d7e01dSFlorian Fainelli 	if (ret)
341da7b9e9bSFlorian Fainelli 		goto out_err_ndo_teardown;
342a3d7e01dSFlorian Fainelli 
343a3d7e01dSFlorian Fainelli 	return ret;
344da7b9e9bSFlorian Fainelli 
345da7b9e9bSFlorian Fainelli out_err_ndo_teardown:
346da7b9e9bSFlorian Fainelli 	dsa_master_ndo_teardown(dev);
347da7b9e9bSFlorian Fainelli out_err_ethtool_teardown:
348da7b9e9bSFlorian Fainelli 	dsa_master_ethtool_teardown(dev);
349da7b9e9bSFlorian Fainelli 	return ret;
35017a22fcfSVivien Didelot }
35117a22fcfSVivien Didelot 
35217a22fcfSVivien Didelot void dsa_master_teardown(struct net_device *dev)
35317a22fcfSVivien Didelot {
354a3d7e01dSFlorian Fainelli 	sysfs_remove_group(&dev->dev.kobj, &dsa_group);
355da7b9e9bSFlorian Fainelli 	dsa_master_ndo_teardown(dev);
35617a22fcfSVivien Didelot 	dsa_master_ethtool_teardown(dev);
35791ba4795SAndrew Lunn 	dsa_master_reset_mtu(dev);
35817a22fcfSVivien Didelot 
35917a22fcfSVivien Didelot 	dev->dsa_ptr = NULL;
36017a22fcfSVivien Didelot 
36117a22fcfSVivien Didelot 	/* If we used a tagging format that doesn't have an ethertype
36217a22fcfSVivien Didelot 	 * field, make sure that all packets from this point get sent
36317a22fcfSVivien Didelot 	 * without the tag and go through the regular receive path.
36417a22fcfSVivien Didelot 	 */
36517a22fcfSVivien Didelot 	wmb();
36617a22fcfSVivien Didelot }
367