xref: /openbmc/linux/net/bridge/br_sysfs_br.c (revision 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2)
1*1da177e4SLinus Torvalds /*
2*1da177e4SLinus Torvalds  *	Sysfs attributes of bridge ports
3*1da177e4SLinus Torvalds  *	Linux ethernet bridge
4*1da177e4SLinus Torvalds  *
5*1da177e4SLinus Torvalds  *	Authors:
6*1da177e4SLinus Torvalds  *	Stephen Hemminger		<shemminger@osdl.org>
7*1da177e4SLinus Torvalds  *
8*1da177e4SLinus Torvalds  *	This program is free software; you can redistribute it and/or
9*1da177e4SLinus Torvalds  *	modify it under the terms of the GNU General Public License
10*1da177e4SLinus Torvalds  *	as published by the Free Software Foundation; either version
11*1da177e4SLinus Torvalds  *	2 of the License, or (at your option) any later version.
12*1da177e4SLinus Torvalds  */
13*1da177e4SLinus Torvalds 
14*1da177e4SLinus Torvalds #include <linux/kernel.h>
15*1da177e4SLinus Torvalds #include <linux/netdevice.h>
16*1da177e4SLinus Torvalds #include <linux/if_bridge.h>
17*1da177e4SLinus Torvalds #include <linux/rtnetlink.h>
18*1da177e4SLinus Torvalds #include <linux/spinlock.h>
19*1da177e4SLinus Torvalds #include <linux/times.h>
20*1da177e4SLinus Torvalds 
21*1da177e4SLinus Torvalds #include "br_private.h"
22*1da177e4SLinus Torvalds 
23*1da177e4SLinus Torvalds #define to_class_dev(obj) container_of(obj,struct class_device,kobj)
24*1da177e4SLinus Torvalds #define to_net_dev(class) container_of(class, struct net_device, class_dev)
25*1da177e4SLinus Torvalds #define to_bridge(cd)	((struct net_bridge *)(to_net_dev(cd)->priv))
26*1da177e4SLinus Torvalds 
27*1da177e4SLinus Torvalds /*
28*1da177e4SLinus Torvalds  * Common code for storing bridge parameters.
29*1da177e4SLinus Torvalds  */
30*1da177e4SLinus Torvalds static ssize_t store_bridge_parm(struct class_device *cd,
31*1da177e4SLinus Torvalds 				 const char *buf, size_t len,
32*1da177e4SLinus Torvalds 				 void (*set)(struct net_bridge *, unsigned long))
33*1da177e4SLinus Torvalds {
34*1da177e4SLinus Torvalds 	struct net_bridge *br = to_bridge(cd);
35*1da177e4SLinus Torvalds 	char *endp;
36*1da177e4SLinus Torvalds 	unsigned long val;
37*1da177e4SLinus Torvalds 
38*1da177e4SLinus Torvalds 	if (!capable(CAP_NET_ADMIN))
39*1da177e4SLinus Torvalds 		return -EPERM;
40*1da177e4SLinus Torvalds 
41*1da177e4SLinus Torvalds 	val = simple_strtoul(buf, &endp, 0);
42*1da177e4SLinus Torvalds 	if (endp == buf)
43*1da177e4SLinus Torvalds 		return -EINVAL;
44*1da177e4SLinus Torvalds 
45*1da177e4SLinus Torvalds 	spin_lock_bh(&br->lock);
46*1da177e4SLinus Torvalds 	(*set)(br, val);
47*1da177e4SLinus Torvalds 	spin_unlock_bh(&br->lock);
48*1da177e4SLinus Torvalds 	return len;
49*1da177e4SLinus Torvalds }
50*1da177e4SLinus Torvalds 
51*1da177e4SLinus Torvalds 
52*1da177e4SLinus Torvalds static ssize_t show_forward_delay(struct class_device *cd, char *buf)
53*1da177e4SLinus Torvalds {
54*1da177e4SLinus Torvalds 	struct net_bridge *br = to_bridge(cd);
55*1da177e4SLinus Torvalds 	return sprintf(buf, "%lu\n", jiffies_to_clock_t(br->forward_delay));
56*1da177e4SLinus Torvalds }
57*1da177e4SLinus Torvalds 
58*1da177e4SLinus Torvalds static void set_forward_delay(struct net_bridge *br, unsigned long val)
59*1da177e4SLinus Torvalds {
60*1da177e4SLinus Torvalds 	unsigned long delay = clock_t_to_jiffies(val);
61*1da177e4SLinus Torvalds 	br->forward_delay = delay;
62*1da177e4SLinus Torvalds 	if (br_is_root_bridge(br))
63*1da177e4SLinus Torvalds 		br->bridge_forward_delay = delay;
64*1da177e4SLinus Torvalds }
65*1da177e4SLinus Torvalds 
66*1da177e4SLinus Torvalds static ssize_t store_forward_delay(struct class_device *cd, const char *buf,
67*1da177e4SLinus Torvalds 				   size_t len)
68*1da177e4SLinus Torvalds {
69*1da177e4SLinus Torvalds 	return store_bridge_parm(cd, buf, len, set_forward_delay);
70*1da177e4SLinus Torvalds }
71*1da177e4SLinus Torvalds static CLASS_DEVICE_ATTR(forward_delay, S_IRUGO | S_IWUSR,
72*1da177e4SLinus Torvalds 			 show_forward_delay, store_forward_delay);
73*1da177e4SLinus Torvalds 
74*1da177e4SLinus Torvalds static ssize_t show_hello_time(struct class_device *cd, char *buf)
75*1da177e4SLinus Torvalds {
76*1da177e4SLinus Torvalds 	return sprintf(buf, "%lu\n",
77*1da177e4SLinus Torvalds 		       jiffies_to_clock_t(to_bridge(cd)->hello_time));
78*1da177e4SLinus Torvalds }
79*1da177e4SLinus Torvalds 
80*1da177e4SLinus Torvalds static void set_hello_time(struct net_bridge *br, unsigned long val)
81*1da177e4SLinus Torvalds {
82*1da177e4SLinus Torvalds 	unsigned long t = clock_t_to_jiffies(val);
83*1da177e4SLinus Torvalds 	br->hello_time = t;
84*1da177e4SLinus Torvalds 	if (br_is_root_bridge(br))
85*1da177e4SLinus Torvalds 		br->bridge_hello_time = t;
86*1da177e4SLinus Torvalds }
87*1da177e4SLinus Torvalds 
88*1da177e4SLinus Torvalds static ssize_t store_hello_time(struct class_device *cd, const char *buf,
89*1da177e4SLinus Torvalds 				size_t len)
90*1da177e4SLinus Torvalds {
91*1da177e4SLinus Torvalds 	return store_bridge_parm(cd, buf, len, set_hello_time);
92*1da177e4SLinus Torvalds }
93*1da177e4SLinus Torvalds 
94*1da177e4SLinus Torvalds static CLASS_DEVICE_ATTR(hello_time, S_IRUGO | S_IWUSR, show_hello_time,
95*1da177e4SLinus Torvalds 			 store_hello_time);
96*1da177e4SLinus Torvalds 
97*1da177e4SLinus Torvalds static ssize_t show_max_age(struct class_device *cd, char *buf)
98*1da177e4SLinus Torvalds {
99*1da177e4SLinus Torvalds 	return sprintf(buf, "%lu\n",
100*1da177e4SLinus Torvalds 		       jiffies_to_clock_t(to_bridge(cd)->max_age));
101*1da177e4SLinus Torvalds }
102*1da177e4SLinus Torvalds 
103*1da177e4SLinus Torvalds static void set_max_age(struct net_bridge *br, unsigned long val)
104*1da177e4SLinus Torvalds {
105*1da177e4SLinus Torvalds 	unsigned long t = clock_t_to_jiffies(val);
106*1da177e4SLinus Torvalds 	br->max_age = t;
107*1da177e4SLinus Torvalds 	if (br_is_root_bridge(br))
108*1da177e4SLinus Torvalds 		br->bridge_max_age = t;
109*1da177e4SLinus Torvalds }
110*1da177e4SLinus Torvalds 
111*1da177e4SLinus Torvalds static ssize_t store_max_age(struct class_device *cd, const char *buf,
112*1da177e4SLinus Torvalds 				size_t len)
113*1da177e4SLinus Torvalds {
114*1da177e4SLinus Torvalds 	return store_bridge_parm(cd, buf, len, set_max_age);
115*1da177e4SLinus Torvalds }
116*1da177e4SLinus Torvalds 
117*1da177e4SLinus Torvalds static CLASS_DEVICE_ATTR(max_age, S_IRUGO | S_IWUSR, show_max_age,
118*1da177e4SLinus Torvalds 			 store_max_age);
119*1da177e4SLinus Torvalds 
120*1da177e4SLinus Torvalds static ssize_t show_ageing_time(struct class_device *cd, char *buf)
121*1da177e4SLinus Torvalds {
122*1da177e4SLinus Torvalds 	struct net_bridge *br = to_bridge(cd);
123*1da177e4SLinus Torvalds 	return sprintf(buf, "%lu\n", jiffies_to_clock_t(br->ageing_time));
124*1da177e4SLinus Torvalds }
125*1da177e4SLinus Torvalds 
126*1da177e4SLinus Torvalds static void set_ageing_time(struct net_bridge *br, unsigned long val)
127*1da177e4SLinus Torvalds {
128*1da177e4SLinus Torvalds 	br->ageing_time = clock_t_to_jiffies(val);
129*1da177e4SLinus Torvalds }
130*1da177e4SLinus Torvalds 
131*1da177e4SLinus Torvalds static ssize_t store_ageing_time(struct class_device *cd, const char *buf,
132*1da177e4SLinus Torvalds 				 size_t len)
133*1da177e4SLinus Torvalds {
134*1da177e4SLinus Torvalds 	return store_bridge_parm(cd, buf, len, set_ageing_time);
135*1da177e4SLinus Torvalds }
136*1da177e4SLinus Torvalds 
137*1da177e4SLinus Torvalds static CLASS_DEVICE_ATTR(ageing_time, S_IRUGO | S_IWUSR, show_ageing_time,
138*1da177e4SLinus Torvalds 			 store_ageing_time);
139*1da177e4SLinus Torvalds static ssize_t show_stp_state(struct class_device *cd, char *buf)
140*1da177e4SLinus Torvalds {
141*1da177e4SLinus Torvalds 	struct net_bridge *br = to_bridge(cd);
142*1da177e4SLinus Torvalds 	return sprintf(buf, "%d\n", br->stp_enabled);
143*1da177e4SLinus Torvalds }
144*1da177e4SLinus Torvalds 
145*1da177e4SLinus Torvalds static void set_stp_state(struct net_bridge *br, unsigned long val)
146*1da177e4SLinus Torvalds {
147*1da177e4SLinus Torvalds 	br->stp_enabled = val;
148*1da177e4SLinus Torvalds }
149*1da177e4SLinus Torvalds 
150*1da177e4SLinus Torvalds static ssize_t store_stp_state(struct class_device *cd,
151*1da177e4SLinus Torvalds 			       const char *buf, size_t len)
152*1da177e4SLinus Torvalds {
153*1da177e4SLinus Torvalds 	return store_bridge_parm(cd, buf, len, set_stp_state);
154*1da177e4SLinus Torvalds }
155*1da177e4SLinus Torvalds 
156*1da177e4SLinus Torvalds static CLASS_DEVICE_ATTR(stp_state, S_IRUGO | S_IWUSR, show_stp_state,
157*1da177e4SLinus Torvalds 			 store_stp_state);
158*1da177e4SLinus Torvalds 
159*1da177e4SLinus Torvalds static ssize_t show_priority(struct class_device *cd, char *buf)
160*1da177e4SLinus Torvalds {
161*1da177e4SLinus Torvalds 	struct net_bridge *br = to_bridge(cd);
162*1da177e4SLinus Torvalds 	return sprintf(buf, "%d\n",
163*1da177e4SLinus Torvalds 		       (br->bridge_id.prio[0] << 8) | br->bridge_id.prio[1]);
164*1da177e4SLinus Torvalds }
165*1da177e4SLinus Torvalds 
166*1da177e4SLinus Torvalds static void set_priority(struct net_bridge *br, unsigned long val)
167*1da177e4SLinus Torvalds {
168*1da177e4SLinus Torvalds 	br_stp_set_bridge_priority(br, (u16) val);
169*1da177e4SLinus Torvalds }
170*1da177e4SLinus Torvalds 
171*1da177e4SLinus Torvalds static ssize_t store_priority(struct class_device *cd,
172*1da177e4SLinus Torvalds 			       const char *buf, size_t len)
173*1da177e4SLinus Torvalds {
174*1da177e4SLinus Torvalds 	return store_bridge_parm(cd, buf, len, set_priority);
175*1da177e4SLinus Torvalds }
176*1da177e4SLinus Torvalds static CLASS_DEVICE_ATTR(priority, S_IRUGO | S_IWUSR, show_priority,
177*1da177e4SLinus Torvalds 			 store_priority);
178*1da177e4SLinus Torvalds 
179*1da177e4SLinus Torvalds static ssize_t show_root_id(struct class_device *cd, char *buf)
180*1da177e4SLinus Torvalds {
181*1da177e4SLinus Torvalds 	return br_show_bridge_id(buf, &to_bridge(cd)->designated_root);
182*1da177e4SLinus Torvalds }
183*1da177e4SLinus Torvalds static CLASS_DEVICE_ATTR(root_id, S_IRUGO, show_root_id, NULL);
184*1da177e4SLinus Torvalds 
185*1da177e4SLinus Torvalds static ssize_t show_bridge_id(struct class_device *cd, char *buf)
186*1da177e4SLinus Torvalds {
187*1da177e4SLinus Torvalds 	return br_show_bridge_id(buf, &to_bridge(cd)->bridge_id);
188*1da177e4SLinus Torvalds }
189*1da177e4SLinus Torvalds static CLASS_DEVICE_ATTR(bridge_id, S_IRUGO, show_bridge_id, NULL);
190*1da177e4SLinus Torvalds 
191*1da177e4SLinus Torvalds static ssize_t show_root_port(struct class_device *cd, char *buf)
192*1da177e4SLinus Torvalds {
193*1da177e4SLinus Torvalds 	return sprintf(buf, "%d\n", to_bridge(cd)->root_port);
194*1da177e4SLinus Torvalds }
195*1da177e4SLinus Torvalds static CLASS_DEVICE_ATTR(root_port, S_IRUGO, show_root_port, NULL);
196*1da177e4SLinus Torvalds 
197*1da177e4SLinus Torvalds static ssize_t show_root_path_cost(struct class_device *cd, char *buf)
198*1da177e4SLinus Torvalds {
199*1da177e4SLinus Torvalds 	return sprintf(buf, "%d\n", to_bridge(cd)->root_path_cost);
200*1da177e4SLinus Torvalds }
201*1da177e4SLinus Torvalds static CLASS_DEVICE_ATTR(root_path_cost, S_IRUGO, show_root_path_cost, NULL);
202*1da177e4SLinus Torvalds 
203*1da177e4SLinus Torvalds static ssize_t show_topology_change(struct class_device *cd, char *buf)
204*1da177e4SLinus Torvalds {
205*1da177e4SLinus Torvalds 	return sprintf(buf, "%d\n", to_bridge(cd)->topology_change);
206*1da177e4SLinus Torvalds }
207*1da177e4SLinus Torvalds static CLASS_DEVICE_ATTR(topology_change, S_IRUGO, show_topology_change, NULL);
208*1da177e4SLinus Torvalds 
209*1da177e4SLinus Torvalds static ssize_t show_topology_change_detected(struct class_device *cd, char *buf)
210*1da177e4SLinus Torvalds {
211*1da177e4SLinus Torvalds 	struct net_bridge *br = to_bridge(cd);
212*1da177e4SLinus Torvalds 	return sprintf(buf, "%d\n", br->topology_change_detected);
213*1da177e4SLinus Torvalds }
214*1da177e4SLinus Torvalds static CLASS_DEVICE_ATTR(topology_change_detected, S_IRUGO, show_topology_change_detected, NULL);
215*1da177e4SLinus Torvalds 
216*1da177e4SLinus Torvalds static ssize_t show_hello_timer(struct class_device *cd, char *buf)
217*1da177e4SLinus Torvalds {
218*1da177e4SLinus Torvalds 	struct net_bridge *br = to_bridge(cd);
219*1da177e4SLinus Torvalds 	return sprintf(buf, "%ld\n", br_timer_value(&br->hello_timer));
220*1da177e4SLinus Torvalds }
221*1da177e4SLinus Torvalds static CLASS_DEVICE_ATTR(hello_timer, S_IRUGO, show_hello_timer, NULL);
222*1da177e4SLinus Torvalds 
223*1da177e4SLinus Torvalds static ssize_t show_tcn_timer(struct class_device *cd, char *buf)
224*1da177e4SLinus Torvalds {
225*1da177e4SLinus Torvalds 	struct net_bridge *br = to_bridge(cd);
226*1da177e4SLinus Torvalds 	return sprintf(buf, "%ld\n", br_timer_value(&br->tcn_timer));
227*1da177e4SLinus Torvalds }
228*1da177e4SLinus Torvalds static CLASS_DEVICE_ATTR(tcn_timer, S_IRUGO, show_tcn_timer, NULL);
229*1da177e4SLinus Torvalds 
230*1da177e4SLinus Torvalds static ssize_t show_topology_change_timer(struct class_device *cd, char *buf)
231*1da177e4SLinus Torvalds {
232*1da177e4SLinus Torvalds 	struct net_bridge *br = to_bridge(cd);
233*1da177e4SLinus Torvalds 	return sprintf(buf, "%ld\n", br_timer_value(&br->topology_change_timer));
234*1da177e4SLinus Torvalds }
235*1da177e4SLinus Torvalds static CLASS_DEVICE_ATTR(topology_change_timer, S_IRUGO, show_topology_change_timer, NULL);
236*1da177e4SLinus Torvalds 
237*1da177e4SLinus Torvalds static ssize_t show_gc_timer(struct class_device *cd, char *buf)
238*1da177e4SLinus Torvalds {
239*1da177e4SLinus Torvalds 	struct net_bridge *br = to_bridge(cd);
240*1da177e4SLinus Torvalds 	return sprintf(buf, "%ld\n", br_timer_value(&br->gc_timer));
241*1da177e4SLinus Torvalds }
242*1da177e4SLinus Torvalds static CLASS_DEVICE_ATTR(gc_timer, S_IRUGO, show_gc_timer, NULL);
243*1da177e4SLinus Torvalds 
244*1da177e4SLinus Torvalds static struct attribute *bridge_attrs[] = {
245*1da177e4SLinus Torvalds 	&class_device_attr_forward_delay.attr,
246*1da177e4SLinus Torvalds 	&class_device_attr_hello_time.attr,
247*1da177e4SLinus Torvalds 	&class_device_attr_max_age.attr,
248*1da177e4SLinus Torvalds 	&class_device_attr_ageing_time.attr,
249*1da177e4SLinus Torvalds 	&class_device_attr_stp_state.attr,
250*1da177e4SLinus Torvalds 	&class_device_attr_priority.attr,
251*1da177e4SLinus Torvalds 	&class_device_attr_bridge_id.attr,
252*1da177e4SLinus Torvalds 	&class_device_attr_root_id.attr,
253*1da177e4SLinus Torvalds 	&class_device_attr_root_path_cost.attr,
254*1da177e4SLinus Torvalds 	&class_device_attr_root_port.attr,
255*1da177e4SLinus Torvalds 	&class_device_attr_topology_change.attr,
256*1da177e4SLinus Torvalds 	&class_device_attr_topology_change_detected.attr,
257*1da177e4SLinus Torvalds 	&class_device_attr_hello_timer.attr,
258*1da177e4SLinus Torvalds 	&class_device_attr_tcn_timer.attr,
259*1da177e4SLinus Torvalds 	&class_device_attr_topology_change_timer.attr,
260*1da177e4SLinus Torvalds 	&class_device_attr_gc_timer.attr,
261*1da177e4SLinus Torvalds 	NULL
262*1da177e4SLinus Torvalds };
263*1da177e4SLinus Torvalds 
264*1da177e4SLinus Torvalds static struct attribute_group bridge_group = {
265*1da177e4SLinus Torvalds 	.name = SYSFS_BRIDGE_ATTR,
266*1da177e4SLinus Torvalds 	.attrs = bridge_attrs,
267*1da177e4SLinus Torvalds };
268*1da177e4SLinus Torvalds 
269*1da177e4SLinus Torvalds /*
270*1da177e4SLinus Torvalds  * Export the forwarding information table as a binary file
271*1da177e4SLinus Torvalds  * The records are struct __fdb_entry.
272*1da177e4SLinus Torvalds  *
273*1da177e4SLinus Torvalds  * Returns the number of bytes read.
274*1da177e4SLinus Torvalds  */
275*1da177e4SLinus Torvalds static ssize_t brforward_read(struct kobject *kobj, char *buf,
276*1da177e4SLinus Torvalds 			   loff_t off, size_t count)
277*1da177e4SLinus Torvalds {
278*1da177e4SLinus Torvalds 	struct class_device *cdev = to_class_dev(kobj);
279*1da177e4SLinus Torvalds 	struct net_bridge *br = to_bridge(cdev);
280*1da177e4SLinus Torvalds 	int n;
281*1da177e4SLinus Torvalds 
282*1da177e4SLinus Torvalds 	/* must read whole records */
283*1da177e4SLinus Torvalds 	if (off % sizeof(struct __fdb_entry) != 0)
284*1da177e4SLinus Torvalds 		return -EINVAL;
285*1da177e4SLinus Torvalds 
286*1da177e4SLinus Torvalds 	n =  br_fdb_fillbuf(br, buf,
287*1da177e4SLinus Torvalds 			    count / sizeof(struct __fdb_entry),
288*1da177e4SLinus Torvalds 			    off / sizeof(struct __fdb_entry));
289*1da177e4SLinus Torvalds 
290*1da177e4SLinus Torvalds 	if (n > 0)
291*1da177e4SLinus Torvalds 		n *= sizeof(struct __fdb_entry);
292*1da177e4SLinus Torvalds 
293*1da177e4SLinus Torvalds 	return n;
294*1da177e4SLinus Torvalds }
295*1da177e4SLinus Torvalds 
296*1da177e4SLinus Torvalds static struct bin_attribute bridge_forward = {
297*1da177e4SLinus Torvalds 	.attr = { .name = SYSFS_BRIDGE_FDB,
298*1da177e4SLinus Torvalds 		  .mode = S_IRUGO,
299*1da177e4SLinus Torvalds 		  .owner = THIS_MODULE, },
300*1da177e4SLinus Torvalds 	.read = brforward_read,
301*1da177e4SLinus Torvalds };
302*1da177e4SLinus Torvalds 
303*1da177e4SLinus Torvalds /*
304*1da177e4SLinus Torvalds  * Add entries in sysfs onto the existing network class device
305*1da177e4SLinus Torvalds  * for the bridge.
306*1da177e4SLinus Torvalds  *   Adds a attribute group "bridge" containing tuning parameters.
307*1da177e4SLinus Torvalds  *   Binary attribute containing the forward table
308*1da177e4SLinus Torvalds  *   Sub directory to hold links to interfaces.
309*1da177e4SLinus Torvalds  *
310*1da177e4SLinus Torvalds  * Note: the ifobj exists only to be a subdirectory
311*1da177e4SLinus Torvalds  *   to hold links.  The ifobj exists in same data structure
312*1da177e4SLinus Torvalds  *   as it's parent the bridge so reference counting works.
313*1da177e4SLinus Torvalds  */
314*1da177e4SLinus Torvalds int br_sysfs_addbr(struct net_device *dev)
315*1da177e4SLinus Torvalds {
316*1da177e4SLinus Torvalds 	struct kobject *brobj = &dev->class_dev.kobj;
317*1da177e4SLinus Torvalds 	struct net_bridge *br = netdev_priv(dev);
318*1da177e4SLinus Torvalds 	int err;
319*1da177e4SLinus Torvalds 
320*1da177e4SLinus Torvalds 	err = sysfs_create_group(brobj, &bridge_group);
321*1da177e4SLinus Torvalds 	if (err) {
322*1da177e4SLinus Torvalds 		pr_info("%s: can't create group %s/%s\n",
323*1da177e4SLinus Torvalds 			__FUNCTION__, dev->name, bridge_group.name);
324*1da177e4SLinus Torvalds 		goto out1;
325*1da177e4SLinus Torvalds 	}
326*1da177e4SLinus Torvalds 
327*1da177e4SLinus Torvalds 	err = sysfs_create_bin_file(brobj, &bridge_forward);
328*1da177e4SLinus Torvalds 	if (err) {
329*1da177e4SLinus Torvalds 		pr_info("%s: can't create attribue file %s/%s\n",
330*1da177e4SLinus Torvalds 			__FUNCTION__, dev->name, bridge_forward.attr.name);
331*1da177e4SLinus Torvalds 		goto out2;
332*1da177e4SLinus Torvalds 	}
333*1da177e4SLinus Torvalds 
334*1da177e4SLinus Torvalds 
335*1da177e4SLinus Torvalds 	kobject_set_name(&br->ifobj, SYSFS_BRIDGE_PORT_SUBDIR);
336*1da177e4SLinus Torvalds 	br->ifobj.ktype = NULL;
337*1da177e4SLinus Torvalds 	br->ifobj.kset = NULL;
338*1da177e4SLinus Torvalds 	br->ifobj.parent = brobj;
339*1da177e4SLinus Torvalds 
340*1da177e4SLinus Torvalds 	err = kobject_register(&br->ifobj);
341*1da177e4SLinus Torvalds 	if (err) {
342*1da177e4SLinus Torvalds 		pr_info("%s: can't add kobject (directory) %s/%s\n",
343*1da177e4SLinus Torvalds 			__FUNCTION__, dev->name, br->ifobj.name);
344*1da177e4SLinus Torvalds 		goto out3;
345*1da177e4SLinus Torvalds 	}
346*1da177e4SLinus Torvalds 	return 0;
347*1da177e4SLinus Torvalds  out3:
348*1da177e4SLinus Torvalds 	sysfs_remove_bin_file(&dev->class_dev.kobj, &bridge_forward);
349*1da177e4SLinus Torvalds  out2:
350*1da177e4SLinus Torvalds 	sysfs_remove_group(&dev->class_dev.kobj, &bridge_group);
351*1da177e4SLinus Torvalds  out1:
352*1da177e4SLinus Torvalds 	return err;
353*1da177e4SLinus Torvalds 
354*1da177e4SLinus Torvalds }
355*1da177e4SLinus Torvalds 
356*1da177e4SLinus Torvalds void br_sysfs_delbr(struct net_device *dev)
357*1da177e4SLinus Torvalds {
358*1da177e4SLinus Torvalds 	struct kobject *kobj = &dev->class_dev.kobj;
359*1da177e4SLinus Torvalds 	struct net_bridge *br = netdev_priv(dev);
360*1da177e4SLinus Torvalds 
361*1da177e4SLinus Torvalds 	kobject_unregister(&br->ifobj);
362*1da177e4SLinus Torvalds 	sysfs_remove_bin_file(kobj, &bridge_forward);
363*1da177e4SLinus Torvalds 	sysfs_remove_group(kobj, &bridge_group);
364*1da177e4SLinus Torvalds }
365