1e9be9d5eSMiklos Szeredi /* 2e9be9d5eSMiklos Szeredi * 3e9be9d5eSMiklos Szeredi * Copyright (C) 2011 Novell Inc. 4e9be9d5eSMiklos Szeredi * 5e9be9d5eSMiklos Szeredi * This program is free software; you can redistribute it and/or modify it 6e9be9d5eSMiklos Szeredi * under the terms of the GNU General Public License version 2 as published by 7e9be9d5eSMiklos Szeredi * the Free Software Foundation. 8e9be9d5eSMiklos Szeredi */ 9e9be9d5eSMiklos Szeredi 10e9be9d5eSMiklos Szeredi #include <linux/fs.h> 11e9be9d5eSMiklos Szeredi #include <linux/slab.h> 125b825c3aSIngo Molnar #include <linux/cred.h> 13e9be9d5eSMiklos Szeredi #include <linux/xattr.h> 145201dc44SMiklos Szeredi #include <linux/posix_acl.h> 155f8415d6SAmir Goldstein #include <linux/ratelimit.h> 16e9be9d5eSMiklos Szeredi #include "overlayfs.h" 17e9be9d5eSMiklos Szeredi 18ba1e563cSChandan Rajendra 19ba1e563cSChandan Rajendra static dev_t ovl_get_pseudo_dev(struct dentry *dentry) 20ba1e563cSChandan Rajendra { 21ba1e563cSChandan Rajendra struct ovl_entry *oe = dentry->d_fsdata; 22ba1e563cSChandan Rajendra 23ba1e563cSChandan Rajendra return oe->lowerstack[0].layer->pseudo_dev; 24ba1e563cSChandan Rajendra } 25ba1e563cSChandan Rajendra 26e9be9d5eSMiklos Szeredi int ovl_setattr(struct dentry *dentry, struct iattr *attr) 27e9be9d5eSMiklos Szeredi { 28e9be9d5eSMiklos Szeredi int err; 29e9be9d5eSMiklos Szeredi struct dentry *upperdentry; 301175b6b8SVivek Goyal const struct cred *old_cred; 31e9be9d5eSMiklos Szeredi 32cf9a6784SMiklos Szeredi /* 33cf9a6784SMiklos Szeredi * Check for permissions before trying to copy-up. This is redundant 34cf9a6784SMiklos Szeredi * since it will be rechecked later by ->setattr() on upper dentry. But 35cf9a6784SMiklos Szeredi * without this, copy-up can be triggered by just about anybody. 36cf9a6784SMiklos Szeredi * 37cf9a6784SMiklos Szeredi * We don't initialize inode->size, which just means that 38cf9a6784SMiklos Szeredi * inode_newsize_ok() will always check against MAX_LFS_FILESIZE and not 39cf9a6784SMiklos Szeredi * check for a swapfile (which this won't be anyway). 40cf9a6784SMiklos Szeredi */ 4131051c85SJan Kara err = setattr_prepare(dentry, attr); 42cf9a6784SMiklos Szeredi if (err) 43cf9a6784SMiklos Szeredi return err; 44cf9a6784SMiklos Szeredi 45e9be9d5eSMiklos Szeredi err = ovl_want_write(dentry); 46e9be9d5eSMiklos Szeredi if (err) 47e9be9d5eSMiklos Szeredi goto out; 48e9be9d5eSMiklos Szeredi 49acff81ecSMiklos Szeredi err = ovl_copy_up(dentry); 50acff81ecSMiklos Szeredi if (!err) { 51e9be9d5eSMiklos Szeredi upperdentry = ovl_dentry_upper(dentry); 52acff81ecSMiklos Szeredi 53b99c2d91SMiklos Szeredi if (attr->ia_valid & (ATTR_KILL_SUID|ATTR_KILL_SGID)) 54b99c2d91SMiklos Szeredi attr->ia_valid &= ~ATTR_MODE; 55b99c2d91SMiklos Szeredi 565955102cSAl Viro inode_lock(upperdentry->d_inode); 571175b6b8SVivek Goyal old_cred = ovl_override_creds(dentry->d_sb); 58e9be9d5eSMiklos Szeredi err = notify_change(upperdentry, attr, NULL); 591175b6b8SVivek Goyal revert_creds(old_cred); 60b81de061SKonstantin Khlebnikov if (!err) 61b81de061SKonstantin Khlebnikov ovl_copyattr(upperdentry->d_inode, dentry->d_inode); 625955102cSAl Viro inode_unlock(upperdentry->d_inode); 63e9be9d5eSMiklos Szeredi } 64e9be9d5eSMiklos Szeredi ovl_drop_write(dentry); 65e9be9d5eSMiklos Szeredi out: 66e9be9d5eSMiklos Szeredi return err; 67e9be9d5eSMiklos Szeredi } 68e9be9d5eSMiklos Szeredi 695b712091SMiklos Szeredi int ovl_getattr(const struct path *path, struct kstat *stat, 70a528d35eSDavid Howells u32 request_mask, unsigned int flags) 71e9be9d5eSMiklos Szeredi { 72a528d35eSDavid Howells struct dentry *dentry = path->dentry; 7372b608f0SAmir Goldstein enum ovl_path_type type; 74e9be9d5eSMiklos Szeredi struct path realpath; 751175b6b8SVivek Goyal const struct cred *old_cred; 765b712091SMiklos Szeredi bool is_dir = S_ISDIR(dentry->d_inode->i_mode); 77a0c5ad30SAmir Goldstein bool samefs = ovl_same_sb(dentry->d_sb); 781175b6b8SVivek Goyal int err; 79e9be9d5eSMiklos Szeredi 8072b608f0SAmir Goldstein type = ovl_path_real(dentry, &realpath); 811175b6b8SVivek Goyal old_cred = ovl_override_creds(dentry->d_sb); 82a528d35eSDavid Howells err = vfs_getattr(&realpath, stat, request_mask, flags); 8372b608f0SAmir Goldstein if (err) 8472b608f0SAmir Goldstein goto out; 8572b608f0SAmir Goldstein 8672b608f0SAmir Goldstein /* 87a0c5ad30SAmir Goldstein * For non-dir or same fs, we use st_ino of the copy up origin, if we 88a0c5ad30SAmir Goldstein * know it. This guaranties constant st_dev/st_ino across copy up. 8972b608f0SAmir Goldstein * 9072b608f0SAmir Goldstein * If filesystem supports NFS export ops, this also guaranties 9172b608f0SAmir Goldstein * persistent st_ino across mount cycle. 9272b608f0SAmir Goldstein */ 93a0c5ad30SAmir Goldstein if (!is_dir || samefs) { 9472b608f0SAmir Goldstein if (OVL_TYPE_ORIGIN(type)) { 9572b608f0SAmir Goldstein struct kstat lowerstat; 965b712091SMiklos Szeredi u32 lowermask = STATX_INO | (!is_dir ? STATX_NLINK : 0); 9772b608f0SAmir Goldstein 9872b608f0SAmir Goldstein ovl_path_lower(dentry, &realpath); 9972b608f0SAmir Goldstein err = vfs_getattr(&realpath, &lowerstat, 1005b712091SMiklos Szeredi lowermask, flags); 10172b608f0SAmir Goldstein if (err) 10272b608f0SAmir Goldstein goto out; 10372b608f0SAmir Goldstein 10472b608f0SAmir Goldstein /* 105359f392cSAmir Goldstein * Lower hardlinks may be broken on copy up to different 10672b608f0SAmir Goldstein * upper files, so we cannot use the lower origin st_ino 10772b608f0SAmir Goldstein * for those different files, even for the same fs case. 108359f392cSAmir Goldstein * With inodes index enabled, it is safe to use st_ino 109359f392cSAmir Goldstein * of an indexed hardlinked origin. The index validates 110359f392cSAmir Goldstein * that the upper hardlink is not broken. 11172b608f0SAmir Goldstein */ 112359f392cSAmir Goldstein if (is_dir || lowerstat.nlink == 1 || 113359f392cSAmir Goldstein ovl_test_flag(OVL_INDEX, d_inode(dentry))) 11472b608f0SAmir Goldstein stat->ino = lowerstat.ino; 115a0c5ad30SAmir Goldstein 116a0c5ad30SAmir Goldstein if (samefs) 117a0c5ad30SAmir Goldstein WARN_ON_ONCE(stat->dev != lowerstat.dev); 118a0c5ad30SAmir Goldstein else 119a0c5ad30SAmir Goldstein stat->dev = ovl_get_pseudo_dev(dentry); 12072b608f0SAmir Goldstein } 121a0c5ad30SAmir Goldstein if (samefs) { 1225b712091SMiklos Szeredi /* 123a0c5ad30SAmir Goldstein * When all layers are on the same fs, all real inode 124a0c5ad30SAmir Goldstein * number are unique, so we use the overlay st_dev, 125a0c5ad30SAmir Goldstein * which is friendly to du -x. 126a0c5ad30SAmir Goldstein */ 127a0c5ad30SAmir Goldstein stat->dev = dentry->d_sb->s_dev; 128a0c5ad30SAmir Goldstein } else if (!OVL_TYPE_UPPER(type)) { 129a0c5ad30SAmir Goldstein /* 130a0c5ad30SAmir Goldstein * For non-samefs setup, to make sure that st_dev/st_ino 131a0c5ad30SAmir Goldstein * pair is unique across the system, we use a unique 132a0c5ad30SAmir Goldstein * anonymous st_dev for lower layer inode. 133a0c5ad30SAmir Goldstein */ 134a0c5ad30SAmir Goldstein stat->dev = ovl_get_pseudo_dev(dentry); 135a0c5ad30SAmir Goldstein } 136a0c5ad30SAmir Goldstein } else { 137a0c5ad30SAmir Goldstein /* 1385b712091SMiklos Szeredi * Always use the overlay st_dev for directories, so 'find 1395b712091SMiklos Szeredi * -xdev' will scan the entire overlay mount and won't cross the 1405b712091SMiklos Szeredi * overlay mount boundaries. 141a0c5ad30SAmir Goldstein * 142a0c5ad30SAmir Goldstein * If not all layers are on the same fs the pair {real st_ino; 143a0c5ad30SAmir Goldstein * overlay st_dev} is not unique, so use the non persistent 144a0c5ad30SAmir Goldstein * overlay st_ino for directories. 1455b712091SMiklos Szeredi */ 1465b712091SMiklos Szeredi stat->dev = dentry->d_sb->s_dev; 1475b712091SMiklos Szeredi stat->ino = dentry->d_inode->i_ino; 14872b608f0SAmir Goldstein } 1495b712091SMiklos Szeredi 1505b712091SMiklos Szeredi /* 1515b712091SMiklos Szeredi * It's probably not worth it to count subdirs to get the 1525b712091SMiklos Szeredi * correct link count. nlink=1 seems to pacify 'find' and 1535b712091SMiklos Szeredi * other utilities. 1545b712091SMiklos Szeredi */ 1555b712091SMiklos Szeredi if (is_dir && OVL_TYPE_MERGE(type)) 1565b712091SMiklos Szeredi stat->nlink = 1; 1575b712091SMiklos Szeredi 1585f8415d6SAmir Goldstein /* 1595f8415d6SAmir Goldstein * Return the overlay inode nlinks for indexed upper inodes. 1605f8415d6SAmir Goldstein * Overlay inode nlink counts the union of the upper hardlinks 1615f8415d6SAmir Goldstein * and non-covered lower hardlinks. It does not include the upper 1625f8415d6SAmir Goldstein * index hardlink. 1635f8415d6SAmir Goldstein */ 1645f8415d6SAmir Goldstein if (!is_dir && ovl_test_flag(OVL_INDEX, d_inode(dentry))) 1655f8415d6SAmir Goldstein stat->nlink = dentry->d_inode->i_nlink; 1665f8415d6SAmir Goldstein 16772b608f0SAmir Goldstein out: 1681175b6b8SVivek Goyal revert_creds(old_cred); 16972b608f0SAmir Goldstein 1701175b6b8SVivek Goyal return err; 171e9be9d5eSMiklos Szeredi } 172e9be9d5eSMiklos Szeredi 173e9be9d5eSMiklos Szeredi int ovl_permission(struct inode *inode, int mask) 174e9be9d5eSMiklos Szeredi { 17509d8b586SMiklos Szeredi struct inode *upperinode = ovl_inode_upper(inode); 17609d8b586SMiklos Szeredi struct inode *realinode = upperinode ?: ovl_inode_lower(inode); 177c0ca3d70SVivek Goyal const struct cred *old_cred; 178e9be9d5eSMiklos Szeredi int err; 179e9be9d5eSMiklos Szeredi 180e9be9d5eSMiklos Szeredi /* Careful in RCU walk mode */ 181e9be9d5eSMiklos Szeredi if (!realinode) { 182e9be9d5eSMiklos Szeredi WARN_ON(!(mask & MAY_NOT_BLOCK)); 183a999d7e1SMiklos Szeredi return -ECHILD; 184e9be9d5eSMiklos Szeredi } 185e9be9d5eSMiklos Szeredi 186c0ca3d70SVivek Goyal /* 187c0ca3d70SVivek Goyal * Check overlay inode with the creds of task and underlying inode 188c0ca3d70SVivek Goyal * with creds of mounter 189c0ca3d70SVivek Goyal */ 190c0ca3d70SVivek Goyal err = generic_permission(inode, mask); 191c0ca3d70SVivek Goyal if (err) 192c0ca3d70SVivek Goyal return err; 193c0ca3d70SVivek Goyal 194c0ca3d70SVivek Goyal old_cred = ovl_override_creds(inode->i_sb); 19509d8b586SMiklos Szeredi if (!upperinode && 19609d8b586SMiklos Szeredi !special_file(realinode->i_mode) && mask & MAY_WRITE) { 197754f8cb7SVivek Goyal mask &= ~(MAY_WRITE | MAY_APPEND); 198500cac3cSVivek Goyal /* Make sure mounter can read file for copy up later */ 199500cac3cSVivek Goyal mask |= MAY_READ; 200500cac3cSVivek Goyal } 2019c630ebeSMiklos Szeredi err = inode_permission(realinode, mask); 202c0ca3d70SVivek Goyal revert_creds(old_cred); 203c0ca3d70SVivek Goyal 204c0ca3d70SVivek Goyal return err; 205e9be9d5eSMiklos Szeredi } 206e9be9d5eSMiklos Szeredi 2076b255391SAl Viro static const char *ovl_get_link(struct dentry *dentry, 208fceef393SAl Viro struct inode *inode, 209fceef393SAl Viro struct delayed_call *done) 210e9be9d5eSMiklos Szeredi { 2111175b6b8SVivek Goyal const struct cred *old_cred; 2121175b6b8SVivek Goyal const char *p; 213e9be9d5eSMiklos Szeredi 2146b255391SAl Viro if (!dentry) 2156b255391SAl Viro return ERR_PTR(-ECHILD); 2166b255391SAl Viro 2171175b6b8SVivek Goyal old_cred = ovl_override_creds(dentry->d_sb); 2187764235bSMiklos Szeredi p = vfs_get_link(ovl_dentry_real(dentry), done); 2191175b6b8SVivek Goyal revert_creds(old_cred); 2201175b6b8SVivek Goyal return p; 221e9be9d5eSMiklos Szeredi } 222e9be9d5eSMiklos Szeredi 2230956254aSMiklos Szeredi bool ovl_is_private_xattr(const char *name) 224e9be9d5eSMiklos Szeredi { 225fe2b7595SAndreas Gruenbacher return strncmp(name, OVL_XATTR_PREFIX, 226fe2b7595SAndreas Gruenbacher sizeof(OVL_XATTR_PREFIX) - 1) == 0; 227e9be9d5eSMiklos Szeredi } 228e9be9d5eSMiklos Szeredi 2291d88f183SMiklos Szeredi int ovl_xattr_set(struct dentry *dentry, struct inode *inode, const char *name, 2301d88f183SMiklos Szeredi const void *value, size_t size, int flags) 231e9be9d5eSMiklos Szeredi { 232e9be9d5eSMiklos Szeredi int err; 2331d88f183SMiklos Szeredi struct dentry *upperdentry = ovl_i_dentry_upper(inode); 2341d88f183SMiklos Szeredi struct dentry *realdentry = upperdentry ?: ovl_dentry_lower(dentry); 2351175b6b8SVivek Goyal const struct cred *old_cred; 236e9be9d5eSMiklos Szeredi 237e9be9d5eSMiklos Szeredi err = ovl_want_write(dentry); 238e9be9d5eSMiklos Szeredi if (err) 239e9be9d5eSMiklos Szeredi goto out; 240e9be9d5eSMiklos Szeredi 2411d88f183SMiklos Szeredi if (!value && !upperdentry) { 2421d88f183SMiklos Szeredi err = vfs_getxattr(realdentry, name, NULL, 0); 2430e585cccSAndreas Gruenbacher if (err < 0) 2440e585cccSAndreas Gruenbacher goto out_drop_write; 2450e585cccSAndreas Gruenbacher } 2460e585cccSAndreas Gruenbacher 2471d88f183SMiklos Szeredi if (!upperdentry) { 248e9be9d5eSMiklos Szeredi err = ovl_copy_up(dentry); 249e9be9d5eSMiklos Szeredi if (err) 250e9be9d5eSMiklos Szeredi goto out_drop_write; 251e9be9d5eSMiklos Szeredi 2521d88f183SMiklos Szeredi realdentry = ovl_dentry_upper(dentry); 2531d88f183SMiklos Szeredi } 2540e585cccSAndreas Gruenbacher 2551175b6b8SVivek Goyal old_cred = ovl_override_creds(dentry->d_sb); 2560e585cccSAndreas Gruenbacher if (value) 2571d88f183SMiklos Szeredi err = vfs_setxattr(realdentry, name, value, size, flags); 2580e585cccSAndreas Gruenbacher else { 2590e585cccSAndreas Gruenbacher WARN_ON(flags != XATTR_REPLACE); 2601d88f183SMiklos Szeredi err = vfs_removexattr(realdentry, name); 2610e585cccSAndreas Gruenbacher } 2621175b6b8SVivek Goyal revert_creds(old_cred); 263e9be9d5eSMiklos Szeredi 264e9be9d5eSMiklos Szeredi out_drop_write: 265e9be9d5eSMiklos Szeredi ovl_drop_write(dentry); 266e9be9d5eSMiklos Szeredi out: 267e9be9d5eSMiklos Szeredi return err; 268e9be9d5eSMiklos Szeredi } 269e9be9d5eSMiklos Szeredi 2701d88f183SMiklos Szeredi int ovl_xattr_get(struct dentry *dentry, struct inode *inode, const char *name, 2710eb45fc3SAndreas Gruenbacher void *value, size_t size) 272e9be9d5eSMiklos Szeredi { 2731175b6b8SVivek Goyal ssize_t res; 2741175b6b8SVivek Goyal const struct cred *old_cred; 2751d88f183SMiklos Szeredi struct dentry *realdentry = 2761d88f183SMiklos Szeredi ovl_i_dentry_upper(inode) ?: ovl_dentry_lower(dentry); 27752148463SMiklos Szeredi 2781175b6b8SVivek Goyal old_cred = ovl_override_creds(dentry->d_sb); 2791175b6b8SVivek Goyal res = vfs_getxattr(realdentry, name, value, size); 2801175b6b8SVivek Goyal revert_creds(old_cred); 2811175b6b8SVivek Goyal return res; 282e9be9d5eSMiklos Szeredi } 283e9be9d5eSMiklos Szeredi 284a082c6f6SMiklos Szeredi static bool ovl_can_list(const char *s) 285a082c6f6SMiklos Szeredi { 286a082c6f6SMiklos Szeredi /* List all non-trusted xatts */ 287a082c6f6SMiklos Szeredi if (strncmp(s, XATTR_TRUSTED_PREFIX, XATTR_TRUSTED_PREFIX_LEN) != 0) 288a082c6f6SMiklos Szeredi return true; 289a082c6f6SMiklos Szeredi 290a082c6f6SMiklos Szeredi /* Never list trusted.overlay, list other trusted for superuser only */ 291a082c6f6SMiklos Szeredi return !ovl_is_private_xattr(s) && capable(CAP_SYS_ADMIN); 292a082c6f6SMiklos Szeredi } 293a082c6f6SMiklos Szeredi 294e9be9d5eSMiklos Szeredi ssize_t ovl_listxattr(struct dentry *dentry, char *list, size_t size) 295e9be9d5eSMiklos Szeredi { 296b581755bSMiklos Szeredi struct dentry *realdentry = ovl_dentry_real(dentry); 297e9be9d5eSMiklos Szeredi ssize_t res; 2987cb35119SMiklos Szeredi size_t len; 2997cb35119SMiklos Szeredi char *s; 3001175b6b8SVivek Goyal const struct cred *old_cred; 301e9be9d5eSMiklos Szeredi 3021175b6b8SVivek Goyal old_cred = ovl_override_creds(dentry->d_sb); 303b581755bSMiklos Szeredi res = vfs_listxattr(realdentry, list, size); 3041175b6b8SVivek Goyal revert_creds(old_cred); 305e9be9d5eSMiklos Szeredi if (res <= 0 || size == 0) 306e9be9d5eSMiklos Szeredi return res; 307e9be9d5eSMiklos Szeredi 308e9be9d5eSMiklos Szeredi /* filter out private xattrs */ 3097cb35119SMiklos Szeredi for (s = list, len = res; len;) { 3107cb35119SMiklos Szeredi size_t slen = strnlen(s, len) + 1; 311e9be9d5eSMiklos Szeredi 3127cb35119SMiklos Szeredi /* underlying fs providing us with an broken xattr list? */ 3137cb35119SMiklos Szeredi if (WARN_ON(slen > len)) 3147cb35119SMiklos Szeredi return -EIO; 315e9be9d5eSMiklos Szeredi 3167cb35119SMiklos Szeredi len -= slen; 317a082c6f6SMiklos Szeredi if (!ovl_can_list(s)) { 318e9be9d5eSMiklos Szeredi res -= slen; 3197cb35119SMiklos Szeredi memmove(s, s + slen, len); 320e9be9d5eSMiklos Szeredi } else { 3217cb35119SMiklos Szeredi s += slen; 322e9be9d5eSMiklos Szeredi } 323e9be9d5eSMiklos Szeredi } 324e9be9d5eSMiklos Szeredi 325e9be9d5eSMiklos Szeredi return res; 326e9be9d5eSMiklos Szeredi } 327e9be9d5eSMiklos Szeredi 32839a25b2bSVivek Goyal struct posix_acl *ovl_get_acl(struct inode *inode, int type) 32939a25b2bSVivek Goyal { 33009d8b586SMiklos Szeredi struct inode *realinode = ovl_inode_real(inode); 3311175b6b8SVivek Goyal const struct cred *old_cred; 3321175b6b8SVivek Goyal struct posix_acl *acl; 33339a25b2bSVivek Goyal 3345201dc44SMiklos Szeredi if (!IS_ENABLED(CONFIG_FS_POSIX_ACL) || !IS_POSIXACL(realinode)) 33539a25b2bSVivek Goyal return NULL; 33639a25b2bSVivek Goyal 3371175b6b8SVivek Goyal old_cred = ovl_override_creds(inode->i_sb); 3385201dc44SMiklos Szeredi acl = get_acl(realinode, type); 3391175b6b8SVivek Goyal revert_creds(old_cred); 3401175b6b8SVivek Goyal 3411175b6b8SVivek Goyal return acl; 34239a25b2bSVivek Goyal } 34339a25b2bSVivek Goyal 34459be0971SAmir Goldstein static bool ovl_open_need_copy_up(struct dentry *dentry, int flags) 345e9be9d5eSMiklos Szeredi { 34659be0971SAmir Goldstein if (ovl_dentry_upper(dentry) && 34759be0971SAmir Goldstein ovl_dentry_has_upper_alias(dentry)) 348e9be9d5eSMiklos Szeredi return false; 349e9be9d5eSMiklos Szeredi 35059be0971SAmir Goldstein if (special_file(d_inode(dentry)->i_mode)) 351e9be9d5eSMiklos Szeredi return false; 352e9be9d5eSMiklos Szeredi 353e9be9d5eSMiklos Szeredi if (!(OPEN_FMODE(flags) & FMODE_WRITE) && !(flags & O_TRUNC)) 354e9be9d5eSMiklos Szeredi return false; 355e9be9d5eSMiklos Szeredi 356e9be9d5eSMiklos Szeredi return true; 357e9be9d5eSMiklos Szeredi } 358e9be9d5eSMiklos Szeredi 3592d902671SMiklos Szeredi int ovl_open_maybe_copy_up(struct dentry *dentry, unsigned int file_flags) 360e9be9d5eSMiklos Szeredi { 3612d902671SMiklos Szeredi int err = 0; 362e9be9d5eSMiklos Szeredi 36359be0971SAmir Goldstein if (ovl_open_need_copy_up(dentry, file_flags)) { 364e9be9d5eSMiklos Szeredi err = ovl_want_write(dentry); 3652d902671SMiklos Szeredi if (!err) { 3669aba6521SAmir Goldstein err = ovl_copy_up_flags(dentry, file_flags); 367f25801eeSDavid Howells ovl_drop_write(dentry); 3682d902671SMiklos Szeredi } 369e9be9d5eSMiklos Szeredi } 370e9be9d5eSMiklos Szeredi 3712d902671SMiklos Szeredi return err; 372e9be9d5eSMiklos Szeredi } 373e9be9d5eSMiklos Szeredi 374d719e8f2SMiklos Szeredi int ovl_update_time(struct inode *inode, struct timespec *ts, int flags) 375d719e8f2SMiklos Szeredi { 376d719e8f2SMiklos Szeredi struct dentry *alias; 377d719e8f2SMiklos Szeredi struct path upperpath; 378d719e8f2SMiklos Szeredi 379d719e8f2SMiklos Szeredi if (!(flags & S_ATIME)) 380d719e8f2SMiklos Szeredi return 0; 381d719e8f2SMiklos Szeredi 382d719e8f2SMiklos Szeredi alias = d_find_any_alias(inode); 383d719e8f2SMiklos Szeredi if (!alias) 384d719e8f2SMiklos Szeredi return 0; 385d719e8f2SMiklos Szeredi 386d719e8f2SMiklos Szeredi ovl_path_upper(alias, &upperpath); 387d719e8f2SMiklos Szeredi if (upperpath.dentry) { 388d719e8f2SMiklos Szeredi touch_atime(&upperpath); 389d719e8f2SMiklos Szeredi inode->i_atime = d_inode(upperpath.dentry)->i_atime; 390d719e8f2SMiklos Szeredi } 391d719e8f2SMiklos Szeredi 392d719e8f2SMiklos Szeredi dput(alias); 393d719e8f2SMiklos Szeredi 394d719e8f2SMiklos Szeredi return 0; 395d719e8f2SMiklos Szeredi } 396d719e8f2SMiklos Szeredi 397e9be9d5eSMiklos Szeredi static const struct inode_operations ovl_file_inode_operations = { 398e9be9d5eSMiklos Szeredi .setattr = ovl_setattr, 399e9be9d5eSMiklos Szeredi .permission = ovl_permission, 400e9be9d5eSMiklos Szeredi .getattr = ovl_getattr, 401e9be9d5eSMiklos Szeredi .listxattr = ovl_listxattr, 40239a25b2bSVivek Goyal .get_acl = ovl_get_acl, 403d719e8f2SMiklos Szeredi .update_time = ovl_update_time, 404e9be9d5eSMiklos Szeredi }; 405e9be9d5eSMiklos Szeredi 406e9be9d5eSMiklos Szeredi static const struct inode_operations ovl_symlink_inode_operations = { 407e9be9d5eSMiklos Szeredi .setattr = ovl_setattr, 4086b255391SAl Viro .get_link = ovl_get_link, 409e9be9d5eSMiklos Szeredi .getattr = ovl_getattr, 410e9be9d5eSMiklos Szeredi .listxattr = ovl_listxattr, 411d719e8f2SMiklos Szeredi .update_time = ovl_update_time, 412e9be9d5eSMiklos Szeredi }; 413e9be9d5eSMiklos Szeredi 414b1eaa950SAmir Goldstein /* 415b1eaa950SAmir Goldstein * It is possible to stack overlayfs instance on top of another 416b1eaa950SAmir Goldstein * overlayfs instance as lower layer. We need to annonate the 417b1eaa950SAmir Goldstein * stackable i_mutex locks according to stack level of the super 418b1eaa950SAmir Goldstein * block instance. An overlayfs instance can never be in stack 419b1eaa950SAmir Goldstein * depth 0 (there is always a real fs below it). An overlayfs 420b1eaa950SAmir Goldstein * inode lock will use the lockdep annotaion ovl_i_mutex_key[depth]. 421b1eaa950SAmir Goldstein * 422b1eaa950SAmir Goldstein * For example, here is a snip from /proc/lockdep_chains after 423b1eaa950SAmir Goldstein * dir_iterate of nested overlayfs: 424b1eaa950SAmir Goldstein * 425b1eaa950SAmir Goldstein * [...] &ovl_i_mutex_dir_key[depth] (stack_depth=2) 426b1eaa950SAmir Goldstein * [...] &ovl_i_mutex_dir_key[depth]#2 (stack_depth=1) 427b1eaa950SAmir Goldstein * [...] &type->i_mutex_dir_key (stack_depth=0) 428b1eaa950SAmir Goldstein */ 429b1eaa950SAmir Goldstein #define OVL_MAX_NESTING FILESYSTEM_MAX_STACK_DEPTH 430b1eaa950SAmir Goldstein 431b1eaa950SAmir Goldstein static inline void ovl_lockdep_annotate_inode_mutex_key(struct inode *inode) 432b1eaa950SAmir Goldstein { 433b1eaa950SAmir Goldstein #ifdef CONFIG_LOCKDEP 434b1eaa950SAmir Goldstein static struct lock_class_key ovl_i_mutex_key[OVL_MAX_NESTING]; 435b1eaa950SAmir Goldstein static struct lock_class_key ovl_i_mutex_dir_key[OVL_MAX_NESTING]; 4364eae06deSAmir Goldstein static struct lock_class_key ovl_i_lock_key[OVL_MAX_NESTING]; 437b1eaa950SAmir Goldstein 438b1eaa950SAmir Goldstein int depth = inode->i_sb->s_stack_depth - 1; 439b1eaa950SAmir Goldstein 440b1eaa950SAmir Goldstein if (WARN_ON_ONCE(depth < 0 || depth >= OVL_MAX_NESTING)) 441b1eaa950SAmir Goldstein depth = 0; 442b1eaa950SAmir Goldstein 443b1eaa950SAmir Goldstein if (S_ISDIR(inode->i_mode)) 444b1eaa950SAmir Goldstein lockdep_set_class(&inode->i_rwsem, &ovl_i_mutex_dir_key[depth]); 445b1eaa950SAmir Goldstein else 446b1eaa950SAmir Goldstein lockdep_set_class(&inode->i_rwsem, &ovl_i_mutex_key[depth]); 4474eae06deSAmir Goldstein 4484eae06deSAmir Goldstein lockdep_set_class(&OVL_I(inode)->lock, &ovl_i_lock_key[depth]); 449b1eaa950SAmir Goldstein #endif 450b1eaa950SAmir Goldstein } 451b1eaa950SAmir Goldstein 452ca4c8a3aSMiklos Szeredi static void ovl_fill_inode(struct inode *inode, umode_t mode, dev_t rdev) 453e9be9d5eSMiklos Szeredi { 454e9be9d5eSMiklos Szeredi inode->i_ino = get_next_ino(); 455e9be9d5eSMiklos Szeredi inode->i_mode = mode; 456d719e8f2SMiklos Szeredi inode->i_flags |= S_NOCMTIME; 4572a3a2a3fSMiklos Szeredi #ifdef CONFIG_FS_POSIX_ACL 4582a3a2a3fSMiklos Szeredi inode->i_acl = inode->i_default_acl = ACL_DONT_CACHE; 4592a3a2a3fSMiklos Szeredi #endif 460e9be9d5eSMiklos Szeredi 461b1eaa950SAmir Goldstein ovl_lockdep_annotate_inode_mutex_key(inode); 462b1eaa950SAmir Goldstein 463ca4c8a3aSMiklos Szeredi switch (mode & S_IFMT) { 464ca4c8a3aSMiklos Szeredi case S_IFREG: 465ca4c8a3aSMiklos Szeredi inode->i_op = &ovl_file_inode_operations; 466ca4c8a3aSMiklos Szeredi break; 467ca4c8a3aSMiklos Szeredi 468e9be9d5eSMiklos Szeredi case S_IFDIR: 469e9be9d5eSMiklos Szeredi inode->i_op = &ovl_dir_inode_operations; 470e9be9d5eSMiklos Szeredi inode->i_fop = &ovl_dir_operations; 471e9be9d5eSMiklos Szeredi break; 472e9be9d5eSMiklos Szeredi 473e9be9d5eSMiklos Szeredi case S_IFLNK: 474e9be9d5eSMiklos Szeredi inode->i_op = &ovl_symlink_inode_operations; 475e9be9d5eSMiklos Szeredi break; 476e9be9d5eSMiklos Szeredi 47751f7e52dSMiklos Szeredi default: 478e9be9d5eSMiklos Szeredi inode->i_op = &ovl_file_inode_operations; 479ca4c8a3aSMiklos Szeredi init_special_inode(inode, mode, rdev); 480e9be9d5eSMiklos Szeredi break; 48151f7e52dSMiklos Szeredi } 48251f7e52dSMiklos Szeredi } 483e9be9d5eSMiklos Szeredi 4845f8415d6SAmir Goldstein /* 4855f8415d6SAmir Goldstein * With inodes index enabled, an overlay inode nlink counts the union of upper 4865f8415d6SAmir Goldstein * hardlinks and non-covered lower hardlinks. During the lifetime of a non-pure 4875f8415d6SAmir Goldstein * upper inode, the following nlink modifying operations can happen: 4885f8415d6SAmir Goldstein * 4895f8415d6SAmir Goldstein * 1. Lower hardlink copy up 4905f8415d6SAmir Goldstein * 2. Upper hardlink created, unlinked or renamed over 4915f8415d6SAmir Goldstein * 3. Lower hardlink whiteout or renamed over 4925f8415d6SAmir Goldstein * 4935f8415d6SAmir Goldstein * For the first, copy up case, the union nlink does not change, whether the 4945f8415d6SAmir Goldstein * operation succeeds or fails, but the upper inode nlink may change. 4955f8415d6SAmir Goldstein * Therefore, before copy up, we store the union nlink value relative to the 4965f8415d6SAmir Goldstein * lower inode nlink in the index inode xattr trusted.overlay.nlink. 4975f8415d6SAmir Goldstein * 4985f8415d6SAmir Goldstein * For the second, upper hardlink case, the union nlink should be incremented 4995f8415d6SAmir Goldstein * or decremented IFF the operation succeeds, aligned with nlink change of the 5005f8415d6SAmir Goldstein * upper inode. Therefore, before link/unlink/rename, we store the union nlink 5015f8415d6SAmir Goldstein * value relative to the upper inode nlink in the index inode. 5025f8415d6SAmir Goldstein * 5035f8415d6SAmir Goldstein * For the last, lower cover up case, we simplify things by preceding the 5045f8415d6SAmir Goldstein * whiteout or cover up with copy up. This makes sure that there is an index 5055f8415d6SAmir Goldstein * upper inode where the nlink xattr can be stored before the copied up upper 5065f8415d6SAmir Goldstein * entry is unlink. 5075f8415d6SAmir Goldstein */ 5085f8415d6SAmir Goldstein #define OVL_NLINK_ADD_UPPER (1 << 0) 5095f8415d6SAmir Goldstein 5105f8415d6SAmir Goldstein /* 5115f8415d6SAmir Goldstein * On-disk format for indexed nlink: 5125f8415d6SAmir Goldstein * 5135f8415d6SAmir Goldstein * nlink relative to the upper inode - "U[+-]NUM" 5145f8415d6SAmir Goldstein * nlink relative to the lower inode - "L[+-]NUM" 5155f8415d6SAmir Goldstein */ 5165f8415d6SAmir Goldstein 5175f8415d6SAmir Goldstein static int ovl_set_nlink_common(struct dentry *dentry, 5185f8415d6SAmir Goldstein struct dentry *realdentry, const char *format) 5195f8415d6SAmir Goldstein { 5205f8415d6SAmir Goldstein struct inode *inode = d_inode(dentry); 5215f8415d6SAmir Goldstein struct inode *realinode = d_inode(realdentry); 5225f8415d6SAmir Goldstein char buf[13]; 5235f8415d6SAmir Goldstein int len; 5245f8415d6SAmir Goldstein 5255f8415d6SAmir Goldstein len = snprintf(buf, sizeof(buf), format, 5265f8415d6SAmir Goldstein (int) (inode->i_nlink - realinode->i_nlink)); 5275f8415d6SAmir Goldstein 5286787341aSMiklos Szeredi if (WARN_ON(len >= sizeof(buf))) 5296787341aSMiklos Szeredi return -EIO; 5306787341aSMiklos Szeredi 5315f8415d6SAmir Goldstein return ovl_do_setxattr(ovl_dentry_upper(dentry), 5325f8415d6SAmir Goldstein OVL_XATTR_NLINK, buf, len, 0); 5335f8415d6SAmir Goldstein } 5345f8415d6SAmir Goldstein 5355f8415d6SAmir Goldstein int ovl_set_nlink_upper(struct dentry *dentry) 5365f8415d6SAmir Goldstein { 5375f8415d6SAmir Goldstein return ovl_set_nlink_common(dentry, ovl_dentry_upper(dentry), "U%+i"); 5385f8415d6SAmir Goldstein } 5395f8415d6SAmir Goldstein 5405f8415d6SAmir Goldstein int ovl_set_nlink_lower(struct dentry *dentry) 5415f8415d6SAmir Goldstein { 5425f8415d6SAmir Goldstein return ovl_set_nlink_common(dentry, ovl_dentry_lower(dentry), "L%+i"); 5435f8415d6SAmir Goldstein } 5445f8415d6SAmir Goldstein 545caf70cb2SAmir Goldstein unsigned int ovl_get_nlink(struct dentry *lowerdentry, 5465f8415d6SAmir Goldstein struct dentry *upperdentry, 5475f8415d6SAmir Goldstein unsigned int fallback) 5485f8415d6SAmir Goldstein { 5495f8415d6SAmir Goldstein int nlink_diff; 5505f8415d6SAmir Goldstein int nlink; 5515f8415d6SAmir Goldstein char buf[13]; 5525f8415d6SAmir Goldstein int err; 5535f8415d6SAmir Goldstein 5545f8415d6SAmir Goldstein if (!lowerdentry || !upperdentry || d_inode(lowerdentry)->i_nlink == 1) 5555f8415d6SAmir Goldstein return fallback; 5565f8415d6SAmir Goldstein 5575f8415d6SAmir Goldstein err = vfs_getxattr(upperdentry, OVL_XATTR_NLINK, &buf, sizeof(buf) - 1); 5585f8415d6SAmir Goldstein if (err < 0) 5595f8415d6SAmir Goldstein goto fail; 5605f8415d6SAmir Goldstein 5615f8415d6SAmir Goldstein buf[err] = '\0'; 5625f8415d6SAmir Goldstein if ((buf[0] != 'L' && buf[0] != 'U') || 5635f8415d6SAmir Goldstein (buf[1] != '+' && buf[1] != '-')) 5645f8415d6SAmir Goldstein goto fail; 5655f8415d6SAmir Goldstein 5665f8415d6SAmir Goldstein err = kstrtoint(buf + 1, 10, &nlink_diff); 5675f8415d6SAmir Goldstein if (err < 0) 5685f8415d6SAmir Goldstein goto fail; 5695f8415d6SAmir Goldstein 5705f8415d6SAmir Goldstein nlink = d_inode(buf[0] == 'L' ? lowerdentry : upperdentry)->i_nlink; 5715f8415d6SAmir Goldstein nlink += nlink_diff; 5725f8415d6SAmir Goldstein 5735f8415d6SAmir Goldstein if (nlink <= 0) 5745f8415d6SAmir Goldstein goto fail; 5755f8415d6SAmir Goldstein 5765f8415d6SAmir Goldstein return nlink; 5775f8415d6SAmir Goldstein 5785f8415d6SAmir Goldstein fail: 5795f8415d6SAmir Goldstein pr_warn_ratelimited("overlayfs: failed to get index nlink (%pd2, err=%i)\n", 5805f8415d6SAmir Goldstein upperdentry, err); 5815f8415d6SAmir Goldstein return fallback; 5825f8415d6SAmir Goldstein } 5835f8415d6SAmir Goldstein 584ca4c8a3aSMiklos Szeredi struct inode *ovl_new_inode(struct super_block *sb, umode_t mode, dev_t rdev) 58551f7e52dSMiklos Szeredi { 58651f7e52dSMiklos Szeredi struct inode *inode; 58751f7e52dSMiklos Szeredi 58851f7e52dSMiklos Szeredi inode = new_inode(sb); 58951f7e52dSMiklos Szeredi if (inode) 590ca4c8a3aSMiklos Szeredi ovl_fill_inode(inode, mode, rdev); 59151f7e52dSMiklos Szeredi 59251f7e52dSMiklos Szeredi return inode; 59351f7e52dSMiklos Szeredi } 59451f7e52dSMiklos Szeredi 59551f7e52dSMiklos Szeredi static int ovl_inode_test(struct inode *inode, void *data) 59651f7e52dSMiklos Szeredi { 59725b7713aSMiklos Szeredi return inode->i_private == data; 59851f7e52dSMiklos Szeredi } 59951f7e52dSMiklos Szeredi 60051f7e52dSMiklos Szeredi static int ovl_inode_set(struct inode *inode, void *data) 60151f7e52dSMiklos Szeredi { 60225b7713aSMiklos Szeredi inode->i_private = data; 60351f7e52dSMiklos Szeredi return 0; 60451f7e52dSMiklos Szeredi } 60551f7e52dSMiklos Szeredi 606b9ac5c27SMiklos Szeredi static bool ovl_verify_inode(struct inode *inode, struct dentry *lowerdentry, 607b9ac5c27SMiklos Szeredi struct dentry *upperdentry) 608b9ac5c27SMiklos Szeredi { 609*31747edaSAmir Goldstein if (S_ISDIR(inode->i_mode)) { 610*31747edaSAmir Goldstein /* Real lower dir moved to upper layer under us? */ 611*31747edaSAmir Goldstein if (!lowerdentry && ovl_inode_lower(inode)) 612*31747edaSAmir Goldstein return false; 613*31747edaSAmir Goldstein 614*31747edaSAmir Goldstein /* Lookup of an uncovered redirect origin? */ 615*31747edaSAmir Goldstein if (!upperdentry && ovl_inode_upper(inode)) 616*31747edaSAmir Goldstein return false; 617*31747edaSAmir Goldstein } 618*31747edaSAmir Goldstein 619939ae4efSAmir Goldstein /* 620939ae4efSAmir Goldstein * Allow non-NULL lower inode in ovl_inode even if lowerdentry is NULL. 621939ae4efSAmir Goldstein * This happens when finding a copied up overlay inode for a renamed 622939ae4efSAmir Goldstein * or hardlinked overlay dentry and lower dentry cannot be followed 623939ae4efSAmir Goldstein * by origin because lower fs does not support file handles. 624939ae4efSAmir Goldstein */ 625939ae4efSAmir Goldstein if (lowerdentry && ovl_inode_lower(inode) != d_inode(lowerdentry)) 626b9ac5c27SMiklos Szeredi return false; 627b9ac5c27SMiklos Szeredi 628b9ac5c27SMiklos Szeredi /* 629b9ac5c27SMiklos Szeredi * Allow non-NULL __upperdentry in inode even if upperdentry is NULL. 630b9ac5c27SMiklos Szeredi * This happens when finding a lower alias for a copied up hard link. 631b9ac5c27SMiklos Szeredi */ 632b9ac5c27SMiklos Szeredi if (upperdentry && ovl_inode_upper(inode) != d_inode(upperdentry)) 633b9ac5c27SMiklos Szeredi return false; 634b9ac5c27SMiklos Szeredi 635b9ac5c27SMiklos Szeredi return true; 636b9ac5c27SMiklos Szeredi } 637b9ac5c27SMiklos Szeredi 6386eaf0111SAmir Goldstein struct inode *ovl_get_inode(struct dentry *dentry, struct dentry *upperdentry, 6396eaf0111SAmir Goldstein struct dentry *index) 64051f7e52dSMiklos Szeredi { 64109d8b586SMiklos Szeredi struct dentry *lowerdentry = ovl_dentry_lower(dentry); 64209d8b586SMiklos Szeredi struct inode *realinode = upperdentry ? d_inode(upperdentry) : NULL; 64351f7e52dSMiklos Szeredi struct inode *inode; 6446eaf0111SAmir Goldstein /* Already indexed or could be indexed on copy up? */ 6456eaf0111SAmir Goldstein bool indexed = (index || (ovl_indexdir(dentry->d_sb) && !upperdentry)); 646*31747edaSAmir Goldstein struct dentry *origin = indexed ? lowerdentry : NULL; 647*31747edaSAmir Goldstein bool is_dir; 6486eaf0111SAmir Goldstein 6496eaf0111SAmir Goldstein if (WARN_ON(upperdentry && indexed && !lowerdentry)) 6506eaf0111SAmir Goldstein return ERR_PTR(-EIO); 65151f7e52dSMiklos Szeredi 65209d8b586SMiklos Szeredi if (!realinode) 65309d8b586SMiklos Szeredi realinode = d_inode(lowerdentry); 65409d8b586SMiklos Szeredi 6556eaf0111SAmir Goldstein /* 656*31747edaSAmir Goldstein * Copy up origin (lower) may exist for non-indexed non-dir upper, but 657*31747edaSAmir Goldstein * we must not use lower as hash key in that case. 658*31747edaSAmir Goldstein * Hash non-dir that is or could be indexed by origin inode. 659*31747edaSAmir Goldstein * Hash dir that is or could be merged by origin inode. 660*31747edaSAmir Goldstein * Hash pure upper and non-indexed non-dir by upper inode. 6616eaf0111SAmir Goldstein */ 662*31747edaSAmir Goldstein is_dir = S_ISDIR(realinode->i_mode); 663*31747edaSAmir Goldstein if (is_dir) 664*31747edaSAmir Goldstein origin = lowerdentry; 665*31747edaSAmir Goldstein 666*31747edaSAmir Goldstein if (upperdentry || origin) { 667*31747edaSAmir Goldstein struct inode *key = d_inode(origin ?: upperdentry); 668*31747edaSAmir Goldstein unsigned int nlink = is_dir ? 1 : realinode->i_nlink; 669b9ac5c27SMiklos Szeredi 670b9ac5c27SMiklos Szeredi inode = iget5_locked(dentry->d_sb, (unsigned long) key, 671b9ac5c27SMiklos Szeredi ovl_inode_test, ovl_inode_set, key); 67209d8b586SMiklos Szeredi if (!inode) 673b9ac5c27SMiklos Szeredi goto out_nomem; 67409d8b586SMiklos Szeredi if (!(inode->i_state & I_NEW)) { 675b9ac5c27SMiklos Szeredi /* 676b9ac5c27SMiklos Szeredi * Verify that the underlying files stored in the inode 677b9ac5c27SMiklos Szeredi * match those in the dentry. 678b9ac5c27SMiklos Szeredi */ 679b9ac5c27SMiklos Szeredi if (!ovl_verify_inode(inode, lowerdentry, upperdentry)) { 680b9ac5c27SMiklos Szeredi iput(inode); 681b9ac5c27SMiklos Szeredi inode = ERR_PTR(-ESTALE); 682b9ac5c27SMiklos Szeredi goto out; 683b9ac5c27SMiklos Szeredi } 684b9ac5c27SMiklos Szeredi 68509d8b586SMiklos Szeredi dput(upperdentry); 68609d8b586SMiklos Szeredi goto out; 68709d8b586SMiklos Szeredi } 688e9be9d5eSMiklos Szeredi 689*31747edaSAmir Goldstein /* Recalculate nlink for non-dir due to indexing */ 690*31747edaSAmir Goldstein if (!is_dir) 691*31747edaSAmir Goldstein nlink = ovl_get_nlink(lowerdentry, upperdentry, nlink); 6925f8415d6SAmir Goldstein set_nlink(inode, nlink); 693e6d2ebddSMiklos Szeredi } else { 694e6d2ebddSMiklos Szeredi inode = new_inode(dentry->d_sb); 695e6d2ebddSMiklos Szeredi if (!inode) 696b9ac5c27SMiklos Szeredi goto out_nomem; 697e6d2ebddSMiklos Szeredi } 698e6d2ebddSMiklos Szeredi ovl_fill_inode(inode, realinode->i_mode, realinode->i_rdev); 69909d8b586SMiklos Szeredi ovl_inode_init(inode, upperdentry, lowerdentry); 70013c72075SMiklos Szeredi 70113c72075SMiklos Szeredi if (upperdentry && ovl_is_impuredir(upperdentry)) 70213c72075SMiklos Szeredi ovl_set_flag(OVL_IMPURE, inode); 70313c72075SMiklos Szeredi 704b79e05aaSAmir Goldstein /* Check for non-merge dir that may have whiteouts */ 705*31747edaSAmir Goldstein if (is_dir) { 706b79e05aaSAmir Goldstein struct ovl_entry *oe = dentry->d_fsdata; 707b79e05aaSAmir Goldstein 708b79e05aaSAmir Goldstein if (((upperdentry && lowerdentry) || oe->numlower > 1) || 709b79e05aaSAmir Goldstein ovl_check_origin_xattr(upperdentry ?: lowerdentry)) { 710b79e05aaSAmir Goldstein ovl_set_flag(OVL_WHITEOUTS, inode); 711b79e05aaSAmir Goldstein } 712b79e05aaSAmir Goldstein } 713b79e05aaSAmir Goldstein 714e6d2ebddSMiklos Szeredi if (inode->i_state & I_NEW) 715e6d2ebddSMiklos Szeredi unlock_new_inode(inode); 716e6d2ebddSMiklos Szeredi out: 717e9be9d5eSMiklos Szeredi return inode; 718b9ac5c27SMiklos Szeredi 719b9ac5c27SMiklos Szeredi out_nomem: 720b9ac5c27SMiklos Szeredi inode = ERR_PTR(-ENOMEM); 721b9ac5c27SMiklos Szeredi goto out; 722e9be9d5eSMiklos Szeredi } 723