1d2912cb1SThomas Gleixner // SPDX-License-Identifier: GPL-2.0-only 2e9be9d5eSMiklos Szeredi /* 3e9be9d5eSMiklos Szeredi * 4e9be9d5eSMiklos Szeredi * Copyright (C) 2011 Novell Inc. 5e9be9d5eSMiklos Szeredi */ 6e9be9d5eSMiklos Szeredi 7e9be9d5eSMiklos Szeredi #include <linux/fs.h> 8e9be9d5eSMiklos Szeredi #include <linux/slab.h> 95b825c3aSIngo Molnar #include <linux/cred.h> 10e9be9d5eSMiklos Szeredi #include <linux/xattr.h> 115201dc44SMiklos Szeredi #include <linux/posix_acl.h> 125f8415d6SAmir Goldstein #include <linux/ratelimit.h> 1310c5db28SChristoph Hellwig #include <linux/fiemap.h> 1466dbfabfSMiklos Szeredi #include <linux/fileattr.h> 1566dbfabfSMiklos Szeredi #include <linux/security.h> 16332f606bSMiklos Szeredi #include <linux/namei.h> 176c0a8bfbSChristian Brauner #include <linux/posix_acl.h> 186c0a8bfbSChristian Brauner #include <linux/posix_acl_xattr.h> 19e9be9d5eSMiklos Szeredi #include "overlayfs.h" 20e9be9d5eSMiklos Szeredi 21ba1e563cSChandan Rajendra 22c1632a0fSChristian Brauner int ovl_setattr(struct mnt_idmap *idmap, struct dentry *dentry, 23549c7297SChristian Brauner struct iattr *attr) 24e9be9d5eSMiklos Szeredi { 25e9be9d5eSMiklos Szeredi int err; 26a15506eaSChristian Brauner struct ovl_fs *ofs = OVL_FS(dentry->d_sb); 27997336f2SVivek Goyal bool full_copy_up = false; 28e9be9d5eSMiklos Szeredi struct dentry *upperdentry; 291175b6b8SVivek Goyal const struct cred *old_cred; 30e9be9d5eSMiklos Szeredi 31c1632a0fSChristian Brauner err = setattr_prepare(&nop_mnt_idmap, dentry, attr); 32cf9a6784SMiklos Szeredi if (err) 33cf9a6784SMiklos Szeredi return err; 34cf9a6784SMiklos Szeredi 35e9be9d5eSMiklos Szeredi err = ovl_want_write(dentry); 36e9be9d5eSMiklos Szeredi if (err) 37e9be9d5eSMiklos Szeredi goto out; 38e9be9d5eSMiklos Szeredi 395812160eSMiklos Szeredi if (attr->ia_valid & ATTR_SIZE) { 40997336f2SVivek Goyal /* Truncate should trigger data copy up as well */ 41997336f2SVivek Goyal full_copy_up = true; 425812160eSMiklos Szeredi } 435812160eSMiklos Szeredi 44997336f2SVivek Goyal if (!full_copy_up) 45acff81ecSMiklos Szeredi err = ovl_copy_up(dentry); 46997336f2SVivek Goyal else 47997336f2SVivek Goyal err = ovl_copy_up_with_data(dentry); 48acff81ecSMiklos Szeredi if (!err) { 495812160eSMiklos Szeredi struct inode *winode = NULL; 505812160eSMiklos Szeredi 51e9be9d5eSMiklos Szeredi upperdentry = ovl_dentry_upper(dentry); 52acff81ecSMiklos Szeredi 535812160eSMiklos Szeredi if (attr->ia_valid & ATTR_SIZE) { 545812160eSMiklos Szeredi winode = d_inode(upperdentry); 555812160eSMiklos Szeredi err = get_write_access(winode); 565812160eSMiklos Szeredi if (err) 575812160eSMiklos Szeredi goto out_drop_write; 585812160eSMiklos Szeredi } 595812160eSMiklos Szeredi 60b99c2d91SMiklos Szeredi if (attr->ia_valid & (ATTR_KILL_SUID|ATTR_KILL_SGID)) 61b99c2d91SMiklos Szeredi attr->ia_valid &= ~ATTR_MODE; 62b99c2d91SMiklos Szeredi 63e67f0216SVivek Goyal /* 6415fd2ea9SVivek Goyal * We might have to translate ovl file into real file object 6515fd2ea9SVivek Goyal * once use cases emerge. For now, simply don't let underlying 6615fd2ea9SVivek Goyal * filesystem rely on attr->ia_file 67e67f0216SVivek Goyal */ 68e67f0216SVivek Goyal attr->ia_valid &= ~ATTR_FILE; 69e67f0216SVivek Goyal 7015fd2ea9SVivek Goyal /* 7115fd2ea9SVivek Goyal * If open(O_TRUNC) is done, VFS calls ->setattr with ATTR_OPEN 7215fd2ea9SVivek Goyal * set. Overlayfs does not pass O_TRUNC flag to underlying 7315fd2ea9SVivek Goyal * filesystem during open -> do not pass ATTR_OPEN. This 7415fd2ea9SVivek Goyal * disables optimization in fuse which assumes open(O_TRUNC) 7515fd2ea9SVivek Goyal * already set file size to 0. But we never passed O_TRUNC to 7615fd2ea9SVivek Goyal * fuse. So by clearing ATTR_OPEN, fuse will be forced to send 7715fd2ea9SVivek Goyal * setattr request to server. 7815fd2ea9SVivek Goyal */ 7915fd2ea9SVivek Goyal attr->ia_valid &= ~ATTR_OPEN; 8015fd2ea9SVivek Goyal 815955102cSAl Viro inode_lock(upperdentry->d_inode); 821175b6b8SVivek Goyal old_cred = ovl_override_creds(dentry->d_sb); 83a15506eaSChristian Brauner err = ovl_do_notify_change(ofs, upperdentry, attr); 841175b6b8SVivek Goyal revert_creds(old_cred); 85b81de061SKonstantin Khlebnikov if (!err) 862878dffcSChristian Brauner ovl_copyattr(dentry->d_inode); 875955102cSAl Viro inode_unlock(upperdentry->d_inode); 885812160eSMiklos Szeredi 895812160eSMiklos Szeredi if (winode) 905812160eSMiklos Szeredi put_write_access(winode); 91e9be9d5eSMiklos Szeredi } 925812160eSMiklos Szeredi out_drop_write: 93e9be9d5eSMiklos Szeredi ovl_drop_write(dentry); 94e9be9d5eSMiklos Szeredi out: 95e9be9d5eSMiklos Szeredi return err; 96e9be9d5eSMiklos Szeredi } 97e9be9d5eSMiklos Szeredi 98c68e7ec5Syoungjun static void ovl_map_dev_ino(struct dentry *dentry, struct kstat *stat, int fsid) 99da309e8cSAmir Goldstein { 1000f831ec8SAmir Goldstein bool samefs = ovl_same_fs(dentry->d_sb); 101e487d889SAmir Goldstein unsigned int xinobits = ovl_xino_bits(dentry->d_sb); 102dfe51d47SAmir Goldstein unsigned int xinoshift = 64 - xinobits; 103da309e8cSAmir Goldstein 104da309e8cSAmir Goldstein if (samefs) { 105da309e8cSAmir Goldstein /* 106da309e8cSAmir Goldstein * When all layers are on the same fs, all real inode 107da309e8cSAmir Goldstein * number are unique, so we use the overlay st_dev, 108da309e8cSAmir Goldstein * which is friendly to du -x. 109da309e8cSAmir Goldstein */ 110da309e8cSAmir Goldstein stat->dev = dentry->d_sb->s_dev; 111c68e7ec5Syoungjun return; 112e487d889SAmir Goldstein } else if (xinobits) { 113e487d889SAmir Goldstein /* 114e487d889SAmir Goldstein * All inode numbers of underlying fs should not be using the 115e487d889SAmir Goldstein * high xinobits, so we use high xinobits to partition the 116e487d889SAmir Goldstein * overlay st_ino address space. The high bits holds the fsid 117dfe51d47SAmir Goldstein * (upper fsid is 0). The lowest xinobit is reserved for mapping 118f48bbfb2SBhaskar Chowdhury * the non-persistent inode numbers range in case of overflow. 119dfe51d47SAmir Goldstein * This way all overlay inode numbers are unique and use the 120dfe51d47SAmir Goldstein * overlay st_dev. 121e487d889SAmir Goldstein */ 122926e94d7SAmir Goldstein if (likely(!(stat->ino >> xinoshift))) { 123dfe51d47SAmir Goldstein stat->ino |= ((u64)fsid) << (xinoshift + 1); 124e487d889SAmir Goldstein stat->dev = dentry->d_sb->s_dev; 125c68e7ec5Syoungjun return; 126926e94d7SAmir Goldstein } else if (ovl_xino_warn(dentry->d_sb)) { 127926e94d7SAmir Goldstein pr_warn_ratelimited("inode number too big (%pd2, ino=%llu, xinobits=%d)\n", 128926e94d7SAmir Goldstein dentry, stat->ino, xinobits); 129e487d889SAmir Goldstein } 130e487d889SAmir Goldstein } 131e487d889SAmir Goldstein 132e487d889SAmir Goldstein /* The inode could not be mapped to a unified st_ino address space */ 133e487d889SAmir Goldstein if (S_ISDIR(dentry->d_inode->i_mode)) { 134da309e8cSAmir Goldstein /* 135da309e8cSAmir Goldstein * Always use the overlay st_dev for directories, so 'find 136da309e8cSAmir Goldstein * -xdev' will scan the entire overlay mount and won't cross the 137da309e8cSAmir Goldstein * overlay mount boundaries. 138da309e8cSAmir Goldstein * 139da309e8cSAmir Goldstein * If not all layers are on the same fs the pair {real st_ino; 140da309e8cSAmir Goldstein * overlay st_dev} is not unique, so use the non persistent 141da309e8cSAmir Goldstein * overlay st_ino for directories. 142da309e8cSAmir Goldstein */ 143da309e8cSAmir Goldstein stat->dev = dentry->d_sb->s_dev; 144da309e8cSAmir Goldstein stat->ino = dentry->d_inode->i_ino; 145b7bf9908SAmir Goldstein } else { 146da309e8cSAmir Goldstein /* 147da309e8cSAmir Goldstein * For non-samefs setup, if we cannot map all layers st_ino 148da309e8cSAmir Goldstein * to a unified address space, we need to make sure that st_dev 149b7bf9908SAmir Goldstein * is unique per underlying fs, so we use the unique anonymous 150b7bf9908SAmir Goldstein * bdev assigned to the underlying fs. 151da309e8cSAmir Goldstein */ 15207f1e596SAmir Goldstein stat->dev = OVL_FS(dentry->d_sb)->fs[fsid].pseudo_dev; 153da309e8cSAmir Goldstein } 154da309e8cSAmir Goldstein } 155da309e8cSAmir Goldstein 156b74d24f7SChristian Brauner int ovl_getattr(struct mnt_idmap *idmap, const struct path *path, 157549c7297SChristian Brauner struct kstat *stat, u32 request_mask, unsigned int flags) 158e9be9d5eSMiklos Szeredi { 159a528d35eSDavid Howells struct dentry *dentry = path->dentry; 16072b608f0SAmir Goldstein enum ovl_path_type type; 161e9be9d5eSMiklos Szeredi struct path realpath; 1621175b6b8SVivek Goyal const struct cred *old_cred; 163096a218aSAmir Goldstein struct inode *inode = d_inode(dentry); 164096a218aSAmir Goldstein bool is_dir = S_ISDIR(inode->i_mode); 16507f1e596SAmir Goldstein int fsid = 0; 1661175b6b8SVivek Goyal int err; 16767d756c2SVivek Goyal bool metacopy_blocks = false; 16867d756c2SVivek Goyal 16967d756c2SVivek Goyal metacopy_blocks = ovl_is_metacopy_dentry(dentry); 170e9be9d5eSMiklos Szeredi 17172b608f0SAmir Goldstein type = ovl_path_real(dentry, &realpath); 1721175b6b8SVivek Goyal old_cred = ovl_override_creds(dentry->d_sb); 173a528d35eSDavid Howells err = vfs_getattr(&realpath, stat, request_mask, flags); 17472b608f0SAmir Goldstein if (err) 17572b608f0SAmir Goldstein goto out; 17672b608f0SAmir Goldstein 177096a218aSAmir Goldstein /* Report the effective immutable/append-only STATX flags */ 178096a218aSAmir Goldstein generic_fill_statx_attr(inode, stat); 179096a218aSAmir Goldstein 18072b608f0SAmir Goldstein /* 181da309e8cSAmir Goldstein * For non-dir or same fs, we use st_ino of the copy up origin. 182da309e8cSAmir Goldstein * This guaranties constant st_dev/st_ino across copy up. 183e487d889SAmir Goldstein * With xino feature and non-samefs, we use st_ino of the copy up 184e487d889SAmir Goldstein * origin masked with high bits that represent the layer id. 18572b608f0SAmir Goldstein * 186da309e8cSAmir Goldstein * If lower filesystem supports NFS file handles, this also guaranties 18772b608f0SAmir Goldstein * persistent st_ino across mount cycle. 18872b608f0SAmir Goldstein */ 1890f831ec8SAmir Goldstein if (!is_dir || ovl_same_dev(dentry->d_sb)) { 190da309e8cSAmir Goldstein if (!OVL_TYPE_UPPER(type)) { 19107f1e596SAmir Goldstein fsid = ovl_layer_lower(dentry)->fsid; 192da309e8cSAmir Goldstein } else if (OVL_TYPE_ORIGIN(type)) { 19372b608f0SAmir Goldstein struct kstat lowerstat; 19467d756c2SVivek Goyal u32 lowermask = STATX_INO | STATX_BLOCKS | 19567d756c2SVivek Goyal (!is_dir ? STATX_NLINK : 0); 19672b608f0SAmir Goldstein 19772b608f0SAmir Goldstein ovl_path_lower(dentry, &realpath); 19872b608f0SAmir Goldstein err = vfs_getattr(&realpath, &lowerstat, 1995b712091SMiklos Szeredi lowermask, flags); 20072b608f0SAmir Goldstein if (err) 20172b608f0SAmir Goldstein goto out; 20272b608f0SAmir Goldstein 20372b608f0SAmir Goldstein /* 204359f392cSAmir Goldstein * Lower hardlinks may be broken on copy up to different 20572b608f0SAmir Goldstein * upper files, so we cannot use the lower origin st_ino 20672b608f0SAmir Goldstein * for those different files, even for the same fs case. 20786eaa130SAmir Goldstein * 20886eaa130SAmir Goldstein * Similarly, several redirected dirs can point to the 20986eaa130SAmir Goldstein * same dir on a lower layer. With the "verify_lower" 21086eaa130SAmir Goldstein * feature, we do not use the lower origin st_ino, if 21186eaa130SAmir Goldstein * we haven't verified that this redirect is unique. 21286eaa130SAmir Goldstein * 213359f392cSAmir Goldstein * With inodes index enabled, it is safe to use st_ino 21486eaa130SAmir Goldstein * of an indexed origin. The index validates that the 21586eaa130SAmir Goldstein * upper hardlink is not broken and that a redirected 21686eaa130SAmir Goldstein * dir is the only redirect to that origin. 21772b608f0SAmir Goldstein */ 21886eaa130SAmir Goldstein if (ovl_test_flag(OVL_INDEX, d_inode(dentry)) || 21986eaa130SAmir Goldstein (!ovl_verify_lower(dentry->d_sb) && 2209f99e50dSAmir Goldstein (is_dir || lowerstat.nlink == 1))) { 22107f1e596SAmir Goldstein fsid = ovl_layer_lower(dentry)->fsid; 2229c6d8f13SAmir Goldstein stat->ino = lowerstat.ino; 22372b608f0SAmir Goldstein } 22467d756c2SVivek Goyal 22567d756c2SVivek Goyal /* 22667d756c2SVivek Goyal * If we are querying a metacopy dentry and lower 22767d756c2SVivek Goyal * dentry is data dentry, then use the blocks we 22867d756c2SVivek Goyal * queried just now. We don't have to do additional 22967d756c2SVivek Goyal * vfs_getattr(). If lower itself is metacopy, then 23067d756c2SVivek Goyal * additional vfs_getattr() is unavoidable. 23167d756c2SVivek Goyal */ 23267d756c2SVivek Goyal if (metacopy_blocks && 23367d756c2SVivek Goyal realpath.dentry == ovl_dentry_lowerdata(dentry)) { 23467d756c2SVivek Goyal stat->blocks = lowerstat.blocks; 23567d756c2SVivek Goyal metacopy_blocks = false; 23667d756c2SVivek Goyal } 23767d756c2SVivek Goyal } 23867d756c2SVivek Goyal 23967d756c2SVivek Goyal if (metacopy_blocks) { 24067d756c2SVivek Goyal /* 24167d756c2SVivek Goyal * If lower is not same as lowerdata or if there was 24267d756c2SVivek Goyal * no origin on upper, we can end up here. 24367d756c2SVivek Goyal */ 24467d756c2SVivek Goyal struct kstat lowerdatastat; 24567d756c2SVivek Goyal u32 lowermask = STATX_BLOCKS; 24667d756c2SVivek Goyal 24767d756c2SVivek Goyal ovl_path_lowerdata(dentry, &realpath); 24867d756c2SVivek Goyal err = vfs_getattr(&realpath, &lowerdatastat, 24967d756c2SVivek Goyal lowermask, flags); 25067d756c2SVivek Goyal if (err) 25167d756c2SVivek Goyal goto out; 25267d756c2SVivek Goyal stat->blocks = lowerdatastat.blocks; 2539f99e50dSAmir Goldstein } 254a0c5ad30SAmir Goldstein } 255da309e8cSAmir Goldstein 256c68e7ec5Syoungjun ovl_map_dev_ino(dentry, stat, fsid); 2575b712091SMiklos Szeredi 2585b712091SMiklos Szeredi /* 2595b712091SMiklos Szeredi * It's probably not worth it to count subdirs to get the 2605b712091SMiklos Szeredi * correct link count. nlink=1 seems to pacify 'find' and 2615b712091SMiklos Szeredi * other utilities. 2625b712091SMiklos Szeredi */ 2635b712091SMiklos Szeredi if (is_dir && OVL_TYPE_MERGE(type)) 2645b712091SMiklos Szeredi stat->nlink = 1; 2655b712091SMiklos Szeredi 2665f8415d6SAmir Goldstein /* 2675f8415d6SAmir Goldstein * Return the overlay inode nlinks for indexed upper inodes. 2685f8415d6SAmir Goldstein * Overlay inode nlink counts the union of the upper hardlinks 2695f8415d6SAmir Goldstein * and non-covered lower hardlinks. It does not include the upper 2705f8415d6SAmir Goldstein * index hardlink. 2715f8415d6SAmir Goldstein */ 2725f8415d6SAmir Goldstein if (!is_dir && ovl_test_flag(OVL_INDEX, d_inode(dentry))) 2735f8415d6SAmir Goldstein stat->nlink = dentry->d_inode->i_nlink; 2745f8415d6SAmir Goldstein 27572b608f0SAmir Goldstein out: 2761175b6b8SVivek Goyal revert_creds(old_cred); 27772b608f0SAmir Goldstein 2781175b6b8SVivek Goyal return err; 279e9be9d5eSMiklos Szeredi } 280e9be9d5eSMiklos Szeredi 2814609e1f1SChristian Brauner int ovl_permission(struct mnt_idmap *idmap, 282549c7297SChristian Brauner struct inode *inode, int mask) 283e9be9d5eSMiklos Szeredi { 28409d8b586SMiklos Szeredi struct inode *upperinode = ovl_inode_upper(inode); 2854b7791b2SChristian Brauner struct inode *realinode; 2864b7791b2SChristian Brauner struct path realpath; 287c0ca3d70SVivek Goyal const struct cred *old_cred; 288e9be9d5eSMiklos Szeredi int err; 289e9be9d5eSMiklos Szeredi 290e9be9d5eSMiklos Szeredi /* Careful in RCU walk mode */ 2911a73f5b8SZhihao Cheng realinode = ovl_i_path_real(inode, &realpath); 2921a73f5b8SZhihao Cheng if (!realinode) { 293e9be9d5eSMiklos Szeredi WARN_ON(!(mask & MAY_NOT_BLOCK)); 294a999d7e1SMiklos Szeredi return -ECHILD; 295e9be9d5eSMiklos Szeredi } 296e9be9d5eSMiklos Szeredi 297c0ca3d70SVivek Goyal /* 298c0ca3d70SVivek Goyal * Check overlay inode with the creds of task and underlying inode 299c0ca3d70SVivek Goyal * with creds of mounter 300c0ca3d70SVivek Goyal */ 3014609e1f1SChristian Brauner err = generic_permission(&nop_mnt_idmap, inode, mask); 302c0ca3d70SVivek Goyal if (err) 303c0ca3d70SVivek Goyal return err; 304c0ca3d70SVivek Goyal 305ec7ba118SMiklos Szeredi old_cred = ovl_override_creds(inode->i_sb); 306ec7ba118SMiklos Szeredi if (!upperinode && 307ec7ba118SMiklos Szeredi !special_file(realinode->i_mode) && mask & MAY_WRITE) { 308754f8cb7SVivek Goyal mask &= ~(MAY_WRITE | MAY_APPEND); 309ec7ba118SMiklos Szeredi /* Make sure mounter can read file for copy up later */ 310500cac3cSVivek Goyal mask |= MAY_READ; 311500cac3cSVivek Goyal } 3124609e1f1SChristian Brauner err = inode_permission(mnt_idmap(realpath.mnt), realinode, mask); 313c0ca3d70SVivek Goyal revert_creds(old_cred); 314c0ca3d70SVivek Goyal 315c0ca3d70SVivek Goyal return err; 316e9be9d5eSMiklos Szeredi } 317e9be9d5eSMiklos Szeredi 3186b255391SAl Viro static const char *ovl_get_link(struct dentry *dentry, 319fceef393SAl Viro struct inode *inode, 320fceef393SAl Viro struct delayed_call *done) 321e9be9d5eSMiklos Szeredi { 3221175b6b8SVivek Goyal const struct cred *old_cred; 3231175b6b8SVivek Goyal const char *p; 324e9be9d5eSMiklos Szeredi 3256b255391SAl Viro if (!dentry) 3266b255391SAl Viro return ERR_PTR(-ECHILD); 3276b255391SAl Viro 3281175b6b8SVivek Goyal old_cred = ovl_override_creds(dentry->d_sb); 3297764235bSMiklos Szeredi p = vfs_get_link(ovl_dentry_real(dentry), done); 3301175b6b8SVivek Goyal revert_creds(old_cred); 3311175b6b8SVivek Goyal return p; 332e9be9d5eSMiklos Szeredi } 333e9be9d5eSMiklos Szeredi 334610afc0bSMiklos Szeredi bool ovl_is_private_xattr(struct super_block *sb, const char *name) 335e9be9d5eSMiklos Szeredi { 3362d2f2d73SMiklos Szeredi struct ovl_fs *ofs = sb->s_fs_info; 3372d2f2d73SMiklos Szeredi 3382d2f2d73SMiklos Szeredi if (ofs->config.userxattr) 3392d2f2d73SMiklos Szeredi return strncmp(name, OVL_XATTR_USER_PREFIX, 3402d2f2d73SMiklos Szeredi sizeof(OVL_XATTR_USER_PREFIX) - 1) == 0; 3412d2f2d73SMiklos Szeredi else 3422d2f2d73SMiklos Szeredi return strncmp(name, OVL_XATTR_TRUSTED_PREFIX, 3432d2f2d73SMiklos Szeredi sizeof(OVL_XATTR_TRUSTED_PREFIX) - 1) == 0; 344e9be9d5eSMiklos Szeredi } 345e9be9d5eSMiklos Szeredi 3461d88f183SMiklos Szeredi int ovl_xattr_set(struct dentry *dentry, struct inode *inode, const char *name, 3471d88f183SMiklos Szeredi const void *value, size_t size, int flags) 348e9be9d5eSMiklos Szeredi { 349e9be9d5eSMiklos Szeredi int err; 350c914c0e2SAmir Goldstein struct ovl_fs *ofs = OVL_FS(dentry->d_sb); 3511d88f183SMiklos Szeredi struct dentry *upperdentry = ovl_i_dentry_upper(inode); 3521d88f183SMiklos Szeredi struct dentry *realdentry = upperdentry ?: ovl_dentry_lower(dentry); 3538bc0095dSChristian Brauner struct path realpath; 3541175b6b8SVivek Goyal const struct cred *old_cred; 355e9be9d5eSMiklos Szeredi 356e9be9d5eSMiklos Szeredi err = ovl_want_write(dentry); 357e9be9d5eSMiklos Szeredi if (err) 358e9be9d5eSMiklos Szeredi goto out; 359e9be9d5eSMiklos Szeredi 3601d88f183SMiklos Szeredi if (!value && !upperdentry) { 3618bc0095dSChristian Brauner ovl_path_lower(dentry, &realpath); 362554677b9SMiklos Szeredi old_cred = ovl_override_creds(dentry->d_sb); 3634609e1f1SChristian Brauner err = vfs_getxattr(mnt_idmap(realpath.mnt), realdentry, name, NULL, 0); 364554677b9SMiklos Szeredi revert_creds(old_cred); 3650e585cccSAndreas Gruenbacher if (err < 0) 3660e585cccSAndreas Gruenbacher goto out_drop_write; 3670e585cccSAndreas Gruenbacher } 3680e585cccSAndreas Gruenbacher 3691d88f183SMiklos Szeredi if (!upperdentry) { 370e9be9d5eSMiklos Szeredi err = ovl_copy_up(dentry); 371e9be9d5eSMiklos Szeredi if (err) 372e9be9d5eSMiklos Szeredi goto out_drop_write; 373e9be9d5eSMiklos Szeredi 3741d88f183SMiklos Szeredi realdentry = ovl_dentry_upper(dentry); 3751d88f183SMiklos Szeredi } 3760e585cccSAndreas Gruenbacher 3771175b6b8SVivek Goyal old_cred = ovl_override_creds(dentry->d_sb); 378c914c0e2SAmir Goldstein if (value) { 379c914c0e2SAmir Goldstein err = ovl_do_setxattr(ofs, realdentry, name, value, size, 380c7c7a1a1STycho Andersen flags); 381c914c0e2SAmir Goldstein } else { 3820e585cccSAndreas Gruenbacher WARN_ON(flags != XATTR_REPLACE); 383c914c0e2SAmir Goldstein err = ovl_do_removexattr(ofs, realdentry, name); 3840e585cccSAndreas Gruenbacher } 3851175b6b8SVivek Goyal revert_creds(old_cred); 386e9be9d5eSMiklos Szeredi 387d9854c87SMiklos Szeredi /* copy c/mtime */ 3882878dffcSChristian Brauner ovl_copyattr(inode); 389d9854c87SMiklos Szeredi 390e9be9d5eSMiklos Szeredi out_drop_write: 391e9be9d5eSMiklos Szeredi ovl_drop_write(dentry); 392e9be9d5eSMiklos Szeredi out: 393e9be9d5eSMiklos Szeredi return err; 394e9be9d5eSMiklos Szeredi } 395e9be9d5eSMiklos Szeredi 3961d88f183SMiklos Szeredi int ovl_xattr_get(struct dentry *dentry, struct inode *inode, const char *name, 3970eb45fc3SAndreas Gruenbacher void *value, size_t size) 398e9be9d5eSMiklos Szeredi { 3991175b6b8SVivek Goyal ssize_t res; 4001175b6b8SVivek Goyal const struct cred *old_cred; 4018bc0095dSChristian Brauner struct path realpath; 40252148463SMiklos Szeredi 4038bc0095dSChristian Brauner ovl_i_path_real(inode, &realpath); 4041175b6b8SVivek Goyal old_cred = ovl_override_creds(dentry->d_sb); 4054609e1f1SChristian Brauner res = vfs_getxattr(mnt_idmap(realpath.mnt), realpath.dentry, name, value, size); 4061175b6b8SVivek Goyal revert_creds(old_cred); 4071175b6b8SVivek Goyal return res; 408e9be9d5eSMiklos Szeredi } 409e9be9d5eSMiklos Szeredi 410610afc0bSMiklos Szeredi static bool ovl_can_list(struct super_block *sb, const char *s) 411a082c6f6SMiklos Szeredi { 4128f6ee74cSMiklos Szeredi /* Never list private (.overlay) */ 4138f6ee74cSMiklos Szeredi if (ovl_is_private_xattr(sb, s)) 4148f6ee74cSMiklos Szeredi return false; 4158f6ee74cSMiklos Szeredi 416f48bbfb2SBhaskar Chowdhury /* List all non-trusted xattrs */ 417a082c6f6SMiklos Szeredi if (strncmp(s, XATTR_TRUSTED_PREFIX, XATTR_TRUSTED_PREFIX_LEN) != 0) 418a082c6f6SMiklos Szeredi return true; 419a082c6f6SMiklos Szeredi 4208f6ee74cSMiklos Szeredi /* list other trusted for superuser only */ 4218f6ee74cSMiklos Szeredi return ns_capable_noaudit(&init_user_ns, CAP_SYS_ADMIN); 422a082c6f6SMiklos Szeredi } 423a082c6f6SMiklos Szeredi 424e9be9d5eSMiklos Szeredi ssize_t ovl_listxattr(struct dentry *dentry, char *list, size_t size) 425e9be9d5eSMiklos Szeredi { 426b581755bSMiklos Szeredi struct dentry *realdentry = ovl_dentry_real(dentry); 427e9be9d5eSMiklos Szeredi ssize_t res; 4287cb35119SMiklos Szeredi size_t len; 4297cb35119SMiklos Szeredi char *s; 4301175b6b8SVivek Goyal const struct cred *old_cred; 431e9be9d5eSMiklos Szeredi 4321175b6b8SVivek Goyal old_cred = ovl_override_creds(dentry->d_sb); 433b581755bSMiklos Szeredi res = vfs_listxattr(realdentry, list, size); 4341175b6b8SVivek Goyal revert_creds(old_cred); 435e9be9d5eSMiklos Szeredi if (res <= 0 || size == 0) 436e9be9d5eSMiklos Szeredi return res; 437e9be9d5eSMiklos Szeredi 438e9be9d5eSMiklos Szeredi /* filter out private xattrs */ 4397cb35119SMiklos Szeredi for (s = list, len = res; len;) { 4407cb35119SMiklos Szeredi size_t slen = strnlen(s, len) + 1; 441e9be9d5eSMiklos Szeredi 4427cb35119SMiklos Szeredi /* underlying fs providing us with an broken xattr list? */ 4437cb35119SMiklos Szeredi if (WARN_ON(slen > len)) 4447cb35119SMiklos Szeredi return -EIO; 445e9be9d5eSMiklos Szeredi 4467cb35119SMiklos Szeredi len -= slen; 447610afc0bSMiklos Szeredi if (!ovl_can_list(dentry->d_sb, s)) { 448e9be9d5eSMiklos Szeredi res -= slen; 4497cb35119SMiklos Szeredi memmove(s, s + slen, len); 450e9be9d5eSMiklos Szeredi } else { 4517cb35119SMiklos Szeredi s += slen; 452e9be9d5eSMiklos Szeredi } 453e9be9d5eSMiklos Szeredi } 454e9be9d5eSMiklos Szeredi 455e9be9d5eSMiklos Szeredi return res; 456e9be9d5eSMiklos Szeredi } 457e9be9d5eSMiklos Szeredi 458ded53656SYang Xu #ifdef CONFIG_FS_POSIX_ACL 4591aa5fef5SChristian Brauner /* 4601aa5fef5SChristian Brauner * Apply the idmapping of the layer to POSIX ACLs. The caller must pass a clone 4611aa5fef5SChristian Brauner * of the POSIX ACLs retrieved from the lower layer to this function to not 4621aa5fef5SChristian Brauner * alter the POSIX ACLs for the underlying filesystem. 4631aa5fef5SChristian Brauner */ 4646c0a8bfbSChristian Brauner static void ovl_idmap_posix_acl(const struct inode *realinode, 4654d7ca409SChristian Brauner struct mnt_idmap *idmap, 4661aa5fef5SChristian Brauner struct posix_acl *acl) 4671aa5fef5SChristian Brauner { 468abfcf55dSChristian Brauner struct user_namespace *fs_userns = i_user_ns(realinode); 469abfcf55dSChristian Brauner 4701aa5fef5SChristian Brauner for (unsigned int i = 0; i < acl->a_count; i++) { 4711aa5fef5SChristian Brauner vfsuid_t vfsuid; 4721aa5fef5SChristian Brauner vfsgid_t vfsgid; 4731aa5fef5SChristian Brauner 4741aa5fef5SChristian Brauner struct posix_acl_entry *e = &acl->a_entries[i]; 4751aa5fef5SChristian Brauner switch (e->e_tag) { 4761aa5fef5SChristian Brauner case ACL_USER: 4774d7ca409SChristian Brauner vfsuid = make_vfsuid(idmap, fs_userns, e->e_uid); 4781aa5fef5SChristian Brauner e->e_uid = vfsuid_into_kuid(vfsuid); 4791aa5fef5SChristian Brauner break; 4801aa5fef5SChristian Brauner case ACL_GROUP: 4814d7ca409SChristian Brauner vfsgid = make_vfsgid(idmap, fs_userns, e->e_gid); 4821aa5fef5SChristian Brauner e->e_gid = vfsgid_into_kgid(vfsgid); 4831aa5fef5SChristian Brauner break; 4841aa5fef5SChristian Brauner } 4851aa5fef5SChristian Brauner } 4861aa5fef5SChristian Brauner } 4871aa5fef5SChristian Brauner 4881aa5fef5SChristian Brauner /* 4896c0a8bfbSChristian Brauner * The @noperm argument is used to skip permission checking and is a temporary 4906c0a8bfbSChristian Brauner * measure. Quoting Miklos from an earlier discussion: 4916c0a8bfbSChristian Brauner * 4926c0a8bfbSChristian Brauner * > So there are two paths to getting an acl: 4936c0a8bfbSChristian Brauner * > 1) permission checking and 2) retrieving the value via getxattr(2). 4946c0a8bfbSChristian Brauner * > This is a similar situation as reading a symlink vs. following it. 4956c0a8bfbSChristian Brauner * > When following a symlink overlayfs always reads the link on the 4966c0a8bfbSChristian Brauner * > underlying fs just as if it was a readlink(2) call, calling 4976c0a8bfbSChristian Brauner * > security_inode_readlink() instead of security_inode_follow_link(). 4986c0a8bfbSChristian Brauner * > This is logical: we are reading the link from the underlying storage, 4996c0a8bfbSChristian Brauner * > and following it on overlayfs. 5006c0a8bfbSChristian Brauner * > 5016c0a8bfbSChristian Brauner * > Applying the same logic to acl: we do need to call the 5026c0a8bfbSChristian Brauner * > security_inode_getxattr() on the underlying fs, even if just want to 5036c0a8bfbSChristian Brauner * > check permissions on overlay. This is currently not done, which is an 5046c0a8bfbSChristian Brauner * > inconsistency. 5056c0a8bfbSChristian Brauner * > 5066c0a8bfbSChristian Brauner * > Maybe adding the check to ovl_get_acl() is the right way to go, but 5076c0a8bfbSChristian Brauner * > I'm a little afraid of a performance regression. Will look into that. 5086c0a8bfbSChristian Brauner * 5096c0a8bfbSChristian Brauner * Until we have made a decision allow this helper to take the @noperm 5106c0a8bfbSChristian Brauner * argument. We should hopefully be able to remove it soon. 5116c0a8bfbSChristian Brauner */ 51231acceb9SChristian Brauner struct posix_acl *ovl_get_acl_path(const struct path *path, 5136c0a8bfbSChristian Brauner const char *acl_name, bool noperm) 5146c0a8bfbSChristian Brauner { 5156c0a8bfbSChristian Brauner struct posix_acl *real_acl, *clone; 51677435322SChristian Brauner struct mnt_idmap *idmap; 5176c0a8bfbSChristian Brauner struct inode *realinode = d_inode(path->dentry); 5186c0a8bfbSChristian Brauner 51977435322SChristian Brauner idmap = mnt_idmap(path->mnt); 5206c0a8bfbSChristian Brauner 5216c0a8bfbSChristian Brauner if (noperm) 5226c0a8bfbSChristian Brauner real_acl = get_inode_acl(realinode, posix_acl_type(acl_name)); 5236c0a8bfbSChristian Brauner else 52477435322SChristian Brauner real_acl = vfs_get_acl(idmap, path->dentry, acl_name); 5256c0a8bfbSChristian Brauner if (IS_ERR_OR_NULL(real_acl)) 5266c0a8bfbSChristian Brauner return real_acl; 5276c0a8bfbSChristian Brauner 5286c0a8bfbSChristian Brauner if (!is_idmapped_mnt(path->mnt)) 5296c0a8bfbSChristian Brauner return real_acl; 5306c0a8bfbSChristian Brauner 5316c0a8bfbSChristian Brauner /* 5326c0a8bfbSChristian Brauner * We cannot alter the ACLs returned from the relevant layer as that 5336c0a8bfbSChristian Brauner * would alter the cached values filesystem wide for the lower 5346c0a8bfbSChristian Brauner * filesystem. Instead we can clone the ACLs and then apply the 5356c0a8bfbSChristian Brauner * relevant idmapping of the layer. 5366c0a8bfbSChristian Brauner */ 5376c0a8bfbSChristian Brauner clone = posix_acl_clone(real_acl, GFP_KERNEL); 5386c0a8bfbSChristian Brauner posix_acl_release(real_acl); /* release original acl */ 5396c0a8bfbSChristian Brauner if (!clone) 5406c0a8bfbSChristian Brauner return ERR_PTR(-ENOMEM); 5416c0a8bfbSChristian Brauner 5424d7ca409SChristian Brauner ovl_idmap_posix_acl(realinode, idmap, clone); 5436c0a8bfbSChristian Brauner return clone; 5446c0a8bfbSChristian Brauner } 5456c0a8bfbSChristian Brauner 5466c0a8bfbSChristian Brauner /* 5471aa5fef5SChristian Brauner * When the relevant layer is an idmapped mount we need to take the idmapping 5481aa5fef5SChristian Brauner * of the layer into account and translate any ACL_{GROUP,USER} values 5491aa5fef5SChristian Brauner * according to the idmapped mount. 5501aa5fef5SChristian Brauner * 5511aa5fef5SChristian Brauner * We cannot alter the ACLs returned from the relevant layer as that would 5521aa5fef5SChristian Brauner * alter the cached values filesystem wide for the lower filesystem. Instead we 5531aa5fef5SChristian Brauner * can clone the ACLs and then apply the relevant idmapping of the layer. 5541aa5fef5SChristian Brauner * 5551aa5fef5SChristian Brauner * This is obviously only relevant when idmapped layers are used. 5561aa5fef5SChristian Brauner */ 55777435322SChristian Brauner struct posix_acl *do_ovl_get_acl(struct mnt_idmap *idmap, 5586c0a8bfbSChristian Brauner struct inode *inode, int type, 5596c0a8bfbSChristian Brauner bool rcu, bool noperm) 56039a25b2bSVivek Goyal { 561f4e19e59SZhihao Cheng struct inode *realinode; 5626c0a8bfbSChristian Brauner struct posix_acl *acl; 5631aa5fef5SChristian Brauner struct path realpath; 56439a25b2bSVivek Goyal 5651aa5fef5SChristian Brauner /* Careful in RCU walk mode */ 566f4e19e59SZhihao Cheng realinode = ovl_i_path_real(inode, &realpath); 567f4e19e59SZhihao Cheng if (!realinode) { 5681aa5fef5SChristian Brauner WARN_ON(!rcu); 5691aa5fef5SChristian Brauner return ERR_PTR(-ECHILD); 5701aa5fef5SChristian Brauner } 5711aa5fef5SChristian Brauner 572f4e19e59SZhihao Cheng if (!IS_POSIXACL(realinode)) 573f4e19e59SZhihao Cheng return NULL; 574f4e19e59SZhihao Cheng 5751aa5fef5SChristian Brauner if (rcu) { 5766c0a8bfbSChristian Brauner /* 5776c0a8bfbSChristian Brauner * If the layer is idmapped drop out of RCU path walk 5786c0a8bfbSChristian Brauner * so we can clone the ACLs. 5796c0a8bfbSChristian Brauner */ 5806c0a8bfbSChristian Brauner if (is_idmapped_mnt(realpath.mnt)) 5816c0a8bfbSChristian Brauner return ERR_PTR(-ECHILD); 5826c0a8bfbSChristian Brauner 5831aa5fef5SChristian Brauner acl = get_cached_acl_rcu(realinode, type); 5841aa5fef5SChristian Brauner } else { 5851aa5fef5SChristian Brauner const struct cred *old_cred; 586332f606bSMiklos Szeredi 5871175b6b8SVivek Goyal old_cred = ovl_override_creds(inode->i_sb); 5886c0a8bfbSChristian Brauner acl = ovl_get_acl_path(&realpath, posix_acl_xattr_name(type), noperm); 5891175b6b8SVivek Goyal revert_creds(old_cred); 5901aa5fef5SChristian Brauner } 5916c0a8bfbSChristian Brauner 5921175b6b8SVivek Goyal return acl; 59339a25b2bSVivek Goyal } 5940e641857SChristian Brauner 5950e641857SChristian Brauner static int ovl_set_or_remove_acl(struct dentry *dentry, struct inode *inode, 5960e641857SChristian Brauner struct posix_acl *acl, int type) 5970e641857SChristian Brauner { 5980e641857SChristian Brauner int err; 5990e641857SChristian Brauner struct path realpath; 6000e641857SChristian Brauner const char *acl_name; 6010e641857SChristian Brauner const struct cred *old_cred; 6020e641857SChristian Brauner struct ovl_fs *ofs = OVL_FS(dentry->d_sb); 6030e641857SChristian Brauner struct dentry *upperdentry = ovl_dentry_upper(dentry); 6040e641857SChristian Brauner struct dentry *realdentry = upperdentry ?: ovl_dentry_lower(dentry); 6050e641857SChristian Brauner 6060e641857SChristian Brauner err = ovl_want_write(dentry); 6070e641857SChristian Brauner if (err) 6080e641857SChristian Brauner return err; 6090e641857SChristian Brauner 6100e641857SChristian Brauner /* 6110e641857SChristian Brauner * If ACL is to be removed from a lower file, check if it exists in 6120e641857SChristian Brauner * the first place before copying it up. 6130e641857SChristian Brauner */ 6140e641857SChristian Brauner acl_name = posix_acl_xattr_name(type); 6150e641857SChristian Brauner if (!acl && !upperdentry) { 6160e641857SChristian Brauner struct posix_acl *real_acl; 6170e641857SChristian Brauner 6180e641857SChristian Brauner ovl_path_lower(dentry, &realpath); 6190e641857SChristian Brauner old_cred = ovl_override_creds(dentry->d_sb); 62077435322SChristian Brauner real_acl = vfs_get_acl(mnt_idmap(realpath.mnt), realdentry, 6210e641857SChristian Brauner acl_name); 6220e641857SChristian Brauner revert_creds(old_cred); 6230e641857SChristian Brauner if (IS_ERR(real_acl)) { 6240e641857SChristian Brauner err = PTR_ERR(real_acl); 6250e641857SChristian Brauner goto out_drop_write; 6260e641857SChristian Brauner } 6275b52aebeSChristian Brauner posix_acl_release(real_acl); 6280e641857SChristian Brauner } 6290e641857SChristian Brauner 6300e641857SChristian Brauner if (!upperdentry) { 6310e641857SChristian Brauner err = ovl_copy_up(dentry); 6320e641857SChristian Brauner if (err) 6330e641857SChristian Brauner goto out_drop_write; 6340e641857SChristian Brauner 6350e641857SChristian Brauner realdentry = ovl_dentry_upper(dentry); 6360e641857SChristian Brauner } 6370e641857SChristian Brauner 6380e641857SChristian Brauner old_cred = ovl_override_creds(dentry->d_sb); 6390e641857SChristian Brauner if (acl) 6400e641857SChristian Brauner err = ovl_do_set_acl(ofs, realdentry, acl_name, acl); 6410e641857SChristian Brauner else 6420e641857SChristian Brauner err = ovl_do_remove_acl(ofs, realdentry, acl_name); 6430e641857SChristian Brauner revert_creds(old_cred); 6440e641857SChristian Brauner 6450e641857SChristian Brauner /* copy c/mtime */ 6460e641857SChristian Brauner ovl_copyattr(inode); 6470e641857SChristian Brauner 6480e641857SChristian Brauner out_drop_write: 6490e641857SChristian Brauner ovl_drop_write(dentry); 6500e641857SChristian Brauner return err; 6510e641857SChristian Brauner } 6520e641857SChristian Brauner 65313e83a49SChristian Brauner int ovl_set_acl(struct mnt_idmap *idmap, struct dentry *dentry, 6540e641857SChristian Brauner struct posix_acl *acl, int type) 6550e641857SChristian Brauner { 6560e641857SChristian Brauner int err; 6570e641857SChristian Brauner struct inode *inode = d_inode(dentry); 6580e641857SChristian Brauner struct dentry *workdir = ovl_workdir(dentry); 6590e641857SChristian Brauner struct inode *realinode = ovl_inode_real(inode); 6600e641857SChristian Brauner 6610e641857SChristian Brauner if (!IS_POSIXACL(d_inode(workdir))) 6620e641857SChristian Brauner return -EOPNOTSUPP; 6630e641857SChristian Brauner if (!realinode->i_op->set_acl) 6640e641857SChristian Brauner return -EOPNOTSUPP; 6650e641857SChristian Brauner if (type == ACL_TYPE_DEFAULT && !S_ISDIR(inode->i_mode)) 6660e641857SChristian Brauner return acl ? -EACCES : 0; 66701beba79SChristian Brauner if (!inode_owner_or_capable(&nop_mnt_idmap, inode)) 6680e641857SChristian Brauner return -EPERM; 6690e641857SChristian Brauner 6700e641857SChristian Brauner /* 6710e641857SChristian Brauner * Check if sgid bit needs to be cleared (actual setacl operation will 6720e641857SChristian Brauner * be done with mounter's capabilities and so that won't do it for us). 6730e641857SChristian Brauner */ 6740e641857SChristian Brauner if (unlikely(inode->i_mode & S_ISGID) && type == ACL_TYPE_ACCESS && 6750e641857SChristian Brauner !in_group_p(inode->i_gid) && 6769452e93eSChristian Brauner !capable_wrt_inode_uidgid(&nop_mnt_idmap, inode, CAP_FSETID)) { 6770e641857SChristian Brauner struct iattr iattr = { .ia_valid = ATTR_KILL_SGID }; 6780e641857SChristian Brauner 679c1632a0fSChristian Brauner err = ovl_setattr(&nop_mnt_idmap, dentry, &iattr); 6800e641857SChristian Brauner if (err) 6810e641857SChristian Brauner return err; 6820e641857SChristian Brauner } 6830e641857SChristian Brauner 6840e641857SChristian Brauner return ovl_set_or_remove_acl(dentry, inode, acl, type); 6850e641857SChristian Brauner } 686ded53656SYang Xu #endif 68739a25b2bSVivek Goyal 68895582b00SDeepa Dinamani int ovl_update_time(struct inode *inode, struct timespec64 *ts, int flags) 689d719e8f2SMiklos Szeredi { 6908f35cf51SMiklos Szeredi if (flags & S_ATIME) { 6918f35cf51SMiklos Szeredi struct ovl_fs *ofs = inode->i_sb->s_fs_info; 6928f35cf51SMiklos Szeredi struct path upperpath = { 69308f4c7c8SMiklos Szeredi .mnt = ovl_upper_mnt(ofs), 6948f35cf51SMiklos Szeredi .dentry = ovl_upperdentry_dereference(OVL_I(inode)), 6958f35cf51SMiklos Szeredi }; 696d719e8f2SMiklos Szeredi 697d719e8f2SMiklos Szeredi if (upperpath.dentry) { 698d719e8f2SMiklos Szeredi touch_atime(&upperpath); 699d719e8f2SMiklos Szeredi inode->i_atime = d_inode(upperpath.dentry)->i_atime; 700d719e8f2SMiklos Szeredi } 7018f35cf51SMiklos Szeredi } 702d719e8f2SMiklos Szeredi return 0; 703d719e8f2SMiklos Szeredi } 704d719e8f2SMiklos Szeredi 7059e142c41SMiklos Szeredi static int ovl_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, 7069e142c41SMiklos Szeredi u64 start, u64 len) 7079e142c41SMiklos Szeredi { 7089e142c41SMiklos Szeredi int err; 709c11faf32SChengguang Xu struct inode *realinode = ovl_inode_realdata(inode); 7109e142c41SMiklos Szeredi const struct cred *old_cred; 7119e142c41SMiklos Szeredi 7129e142c41SMiklos Szeredi if (!realinode->i_op->fiemap) 7139e142c41SMiklos Szeredi return -EOPNOTSUPP; 7149e142c41SMiklos Szeredi 7159e142c41SMiklos Szeredi old_cred = ovl_override_creds(inode->i_sb); 7169e142c41SMiklos Szeredi err = realinode->i_op->fiemap(realinode, fieinfo, start, len); 7179e142c41SMiklos Szeredi revert_creds(old_cred); 7189e142c41SMiklos Szeredi 7199e142c41SMiklos Szeredi return err; 7209e142c41SMiklos Szeredi } 7219e142c41SMiklos Szeredi 72266dbfabfSMiklos Szeredi /* 72366dbfabfSMiklos Szeredi * Work around the fact that security_file_ioctl() takes a file argument. 72466dbfabfSMiklos Szeredi * Introducing security_inode_fileattr_get/set() hooks would solve this issue 72566dbfabfSMiklos Szeredi * properly. 72666dbfabfSMiklos Szeredi */ 7272d343087SAl Viro static int ovl_security_fileattr(const struct path *realpath, struct fileattr *fa, 72866dbfabfSMiklos Szeredi bool set) 72966dbfabfSMiklos Szeredi { 73066dbfabfSMiklos Szeredi struct file *file; 73166dbfabfSMiklos Szeredi unsigned int cmd; 73266dbfabfSMiklos Szeredi int err; 73366dbfabfSMiklos Szeredi 73472db8211SAmir Goldstein file = dentry_open(realpath, O_RDONLY, current_cred()); 73566dbfabfSMiklos Szeredi if (IS_ERR(file)) 73666dbfabfSMiklos Szeredi return PTR_ERR(file); 73766dbfabfSMiklos Szeredi 73866dbfabfSMiklos Szeredi if (set) 73966dbfabfSMiklos Szeredi cmd = fa->fsx_valid ? FS_IOC_FSSETXATTR : FS_IOC_SETFLAGS; 74066dbfabfSMiklos Szeredi else 74166dbfabfSMiklos Szeredi cmd = fa->fsx_valid ? FS_IOC_FSGETXATTR : FS_IOC_GETFLAGS; 74266dbfabfSMiklos Szeredi 74366dbfabfSMiklos Szeredi err = security_file_ioctl(file, cmd, 0); 74466dbfabfSMiklos Szeredi fput(file); 74566dbfabfSMiklos Szeredi 74666dbfabfSMiklos Szeredi return err; 74766dbfabfSMiklos Szeredi } 74866dbfabfSMiklos Szeredi 7492d343087SAl Viro int ovl_real_fileattr_set(const struct path *realpath, struct fileattr *fa) 75072db8211SAmir Goldstein { 75172db8211SAmir Goldstein int err; 75272db8211SAmir Goldstein 75372db8211SAmir Goldstein err = ovl_security_fileattr(realpath, fa, true); 75472db8211SAmir Goldstein if (err) 75572db8211SAmir Goldstein return err; 75672db8211SAmir Goldstein 7578782a9aeSChristian Brauner return vfs_fileattr_set(mnt_idmap(realpath->mnt), realpath->dentry, fa); 75872db8211SAmir Goldstein } 75972db8211SAmir Goldstein 7608782a9aeSChristian Brauner int ovl_fileattr_set(struct mnt_idmap *idmap, 76166dbfabfSMiklos Szeredi struct dentry *dentry, struct fileattr *fa) 76266dbfabfSMiklos Szeredi { 76366dbfabfSMiklos Szeredi struct inode *inode = d_inode(dentry); 76472db8211SAmir Goldstein struct path upperpath; 76566dbfabfSMiklos Szeredi const struct cred *old_cred; 766096a218aSAmir Goldstein unsigned int flags; 76766dbfabfSMiklos Szeredi int err; 76866dbfabfSMiklos Szeredi 76966dbfabfSMiklos Szeredi err = ovl_want_write(dentry); 77066dbfabfSMiklos Szeredi if (err) 77166dbfabfSMiklos Szeredi goto out; 77266dbfabfSMiklos Szeredi 77366dbfabfSMiklos Szeredi err = ovl_copy_up(dentry); 77466dbfabfSMiklos Szeredi if (!err) { 77572db8211SAmir Goldstein ovl_path_real(dentry, &upperpath); 77666dbfabfSMiklos Szeredi 77766dbfabfSMiklos Szeredi old_cred = ovl_override_creds(inode->i_sb); 778096a218aSAmir Goldstein /* 779096a218aSAmir Goldstein * Store immutable/append-only flags in xattr and clear them 780096a218aSAmir Goldstein * in upper fileattr (in case they were set by older kernel) 781096a218aSAmir Goldstein * so children of "ovl-immutable" directories lower aliases of 782096a218aSAmir Goldstein * "ovl-immutable" hardlinks could be copied up. 783096a218aSAmir Goldstein * Clear xattr when flags are cleared. 784096a218aSAmir Goldstein */ 785096a218aSAmir Goldstein err = ovl_set_protattr(inode, upperpath.dentry, fa); 786096a218aSAmir Goldstein if (!err) 78772db8211SAmir Goldstein err = ovl_real_fileattr_set(&upperpath, fa); 78866dbfabfSMiklos Szeredi revert_creds(old_cred); 789096a218aSAmir Goldstein 790096a218aSAmir Goldstein /* 791096a218aSAmir Goldstein * Merge real inode flags with inode flags read from 792096a218aSAmir Goldstein * overlay.protattr xattr 793096a218aSAmir Goldstein */ 794096a218aSAmir Goldstein flags = ovl_inode_real(inode)->i_flags & OVL_COPY_I_FLAGS_MASK; 795096a218aSAmir Goldstein 796096a218aSAmir Goldstein BUILD_BUG_ON(OVL_PROT_I_FLAGS_MASK & ~OVL_COPY_I_FLAGS_MASK); 797096a218aSAmir Goldstein flags |= inode->i_flags & OVL_PROT_I_FLAGS_MASK; 798096a218aSAmir Goldstein inode_set_flags(inode, flags, OVL_COPY_I_FLAGS_MASK); 799d8991e86SChengguang Xu 800d8991e86SChengguang Xu /* Update ctime */ 8012878dffcSChristian Brauner ovl_copyattr(inode); 80266dbfabfSMiklos Szeredi } 80366dbfabfSMiklos Szeredi ovl_drop_write(dentry); 80466dbfabfSMiklos Szeredi out: 80566dbfabfSMiklos Szeredi return err; 80666dbfabfSMiklos Szeredi } 80766dbfabfSMiklos Szeredi 808096a218aSAmir Goldstein /* Convert inode protection flags to fileattr flags */ 809096a218aSAmir Goldstein static void ovl_fileattr_prot_flags(struct inode *inode, struct fileattr *fa) 810096a218aSAmir Goldstein { 811096a218aSAmir Goldstein BUILD_BUG_ON(OVL_PROT_FS_FLAGS_MASK & ~FS_COMMON_FL); 812096a218aSAmir Goldstein BUILD_BUG_ON(OVL_PROT_FSX_FLAGS_MASK & ~FS_XFLAG_COMMON); 813096a218aSAmir Goldstein 814096a218aSAmir Goldstein if (inode->i_flags & S_APPEND) { 815096a218aSAmir Goldstein fa->flags |= FS_APPEND_FL; 816096a218aSAmir Goldstein fa->fsx_xflags |= FS_XFLAG_APPEND; 817096a218aSAmir Goldstein } 818096a218aSAmir Goldstein if (inode->i_flags & S_IMMUTABLE) { 819096a218aSAmir Goldstein fa->flags |= FS_IMMUTABLE_FL; 820096a218aSAmir Goldstein fa->fsx_xflags |= FS_XFLAG_IMMUTABLE; 821096a218aSAmir Goldstein } 822096a218aSAmir Goldstein } 823096a218aSAmir Goldstein 8242d343087SAl Viro int ovl_real_fileattr_get(const struct path *realpath, struct fileattr *fa) 82572db8211SAmir Goldstein { 82672db8211SAmir Goldstein int err; 82772db8211SAmir Goldstein 82872db8211SAmir Goldstein err = ovl_security_fileattr(realpath, fa, false); 82972db8211SAmir Goldstein if (err) 83072db8211SAmir Goldstein return err; 83172db8211SAmir Goldstein 8325b0a414dSMiklos Szeredi err = vfs_fileattr_get(realpath->dentry, fa); 8335b0a414dSMiklos Szeredi if (err == -ENOIOCTLCMD) 8345b0a414dSMiklos Szeredi err = -ENOTTY; 8355b0a414dSMiklos Szeredi return err; 83672db8211SAmir Goldstein } 83772db8211SAmir Goldstein 83866dbfabfSMiklos Szeredi int ovl_fileattr_get(struct dentry *dentry, struct fileattr *fa) 83966dbfabfSMiklos Szeredi { 84066dbfabfSMiklos Szeredi struct inode *inode = d_inode(dentry); 84172db8211SAmir Goldstein struct path realpath; 84266dbfabfSMiklos Szeredi const struct cred *old_cred; 84366dbfabfSMiklos Szeredi int err; 84466dbfabfSMiklos Szeredi 84572db8211SAmir Goldstein ovl_path_real(dentry, &realpath); 84672db8211SAmir Goldstein 84766dbfabfSMiklos Szeredi old_cred = ovl_override_creds(inode->i_sb); 84872db8211SAmir Goldstein err = ovl_real_fileattr_get(&realpath, fa); 849096a218aSAmir Goldstein ovl_fileattr_prot_flags(inode, fa); 85066dbfabfSMiklos Szeredi revert_creds(old_cred); 85166dbfabfSMiklos Szeredi 85266dbfabfSMiklos Szeredi return err; 85366dbfabfSMiklos Szeredi } 85466dbfabfSMiklos Szeredi 855e9be9d5eSMiklos Szeredi static const struct inode_operations ovl_file_inode_operations = { 856e9be9d5eSMiklos Szeredi .setattr = ovl_setattr, 857e9be9d5eSMiklos Szeredi .permission = ovl_permission, 858e9be9d5eSMiklos Szeredi .getattr = ovl_getattr, 859e9be9d5eSMiklos Szeredi .listxattr = ovl_listxattr, 8606c0a8bfbSChristian Brauner .get_inode_acl = ovl_get_inode_acl, 8616c0a8bfbSChristian Brauner .get_acl = ovl_get_acl, 8620e641857SChristian Brauner .set_acl = ovl_set_acl, 863d719e8f2SMiklos Szeredi .update_time = ovl_update_time, 8649e142c41SMiklos Szeredi .fiemap = ovl_fiemap, 86566dbfabfSMiklos Szeredi .fileattr_get = ovl_fileattr_get, 86666dbfabfSMiklos Szeredi .fileattr_set = ovl_fileattr_set, 867e9be9d5eSMiklos Szeredi }; 868e9be9d5eSMiklos Szeredi 869e9be9d5eSMiklos Szeredi static const struct inode_operations ovl_symlink_inode_operations = { 870e9be9d5eSMiklos Szeredi .setattr = ovl_setattr, 8716b255391SAl Viro .get_link = ovl_get_link, 872e9be9d5eSMiklos Szeredi .getattr = ovl_getattr, 873e9be9d5eSMiklos Szeredi .listxattr = ovl_listxattr, 874d719e8f2SMiklos Szeredi .update_time = ovl_update_time, 875e9be9d5eSMiklos Szeredi }; 876e9be9d5eSMiklos Szeredi 8779e142c41SMiklos Szeredi static const struct inode_operations ovl_special_inode_operations = { 8789e142c41SMiklos Szeredi .setattr = ovl_setattr, 8799e142c41SMiklos Szeredi .permission = ovl_permission, 8809e142c41SMiklos Szeredi .getattr = ovl_getattr, 8819e142c41SMiklos Szeredi .listxattr = ovl_listxattr, 8826c0a8bfbSChristian Brauner .get_inode_acl = ovl_get_inode_acl, 8836c0a8bfbSChristian Brauner .get_acl = ovl_get_acl, 8840e641857SChristian Brauner .set_acl = ovl_set_acl, 8859e142c41SMiklos Szeredi .update_time = ovl_update_time, 8869e142c41SMiklos Szeredi }; 8879e142c41SMiklos Szeredi 88869383c59SWei Yongjun static const struct address_space_operations ovl_aops = { 8895b910bd6SAmir Goldstein /* For O_DIRECT dentry_open() checks f_mapping->a_ops->direct_IO */ 8905b910bd6SAmir Goldstein .direct_IO = noop_direct_IO, 8915b910bd6SAmir Goldstein }; 8925b910bd6SAmir Goldstein 893b1eaa950SAmir Goldstein /* 894b1eaa950SAmir Goldstein * It is possible to stack overlayfs instance on top of another 895a5a84682SChengguang Xu * overlayfs instance as lower layer. We need to annotate the 896b1eaa950SAmir Goldstein * stackable i_mutex locks according to stack level of the super 897b1eaa950SAmir Goldstein * block instance. An overlayfs instance can never be in stack 898b1eaa950SAmir Goldstein * depth 0 (there is always a real fs below it). An overlayfs 899f48bbfb2SBhaskar Chowdhury * inode lock will use the lockdep annotation ovl_i_mutex_key[depth]. 900b1eaa950SAmir Goldstein * 901b1eaa950SAmir Goldstein * For example, here is a snip from /proc/lockdep_chains after 902b1eaa950SAmir Goldstein * dir_iterate of nested overlayfs: 903b1eaa950SAmir Goldstein * 904b1eaa950SAmir Goldstein * [...] &ovl_i_mutex_dir_key[depth] (stack_depth=2) 905b1eaa950SAmir Goldstein * [...] &ovl_i_mutex_dir_key[depth]#2 (stack_depth=1) 906b1eaa950SAmir Goldstein * [...] &type->i_mutex_dir_key (stack_depth=0) 907b1f9d385SAmir Goldstein * 908b1f9d385SAmir Goldstein * Locking order w.r.t ovl_want_write() is important for nested overlayfs. 909b1f9d385SAmir Goldstein * 910b1f9d385SAmir Goldstein * This chain is valid: 911b1f9d385SAmir Goldstein * - inode->i_rwsem (inode_lock[2]) 912b1f9d385SAmir Goldstein * - upper_mnt->mnt_sb->s_writers (ovl_want_write[0]) 913b1f9d385SAmir Goldstein * - OVL_I(inode)->lock (ovl_inode_lock[2]) 914b1f9d385SAmir Goldstein * - OVL_I(lowerinode)->lock (ovl_inode_lock[1]) 915b1f9d385SAmir Goldstein * 916b1f9d385SAmir Goldstein * And this chain is valid: 917b1f9d385SAmir Goldstein * - inode->i_rwsem (inode_lock[2]) 918b1f9d385SAmir Goldstein * - OVL_I(inode)->lock (ovl_inode_lock[2]) 919b1f9d385SAmir Goldstein * - lowerinode->i_rwsem (inode_lock[1]) 920b1f9d385SAmir Goldstein * - OVL_I(lowerinode)->lock (ovl_inode_lock[1]) 921b1f9d385SAmir Goldstein * 922b1f9d385SAmir Goldstein * But lowerinode->i_rwsem SHOULD NOT be acquired while ovl_want_write() is 923b1f9d385SAmir Goldstein * held, because it is in reverse order of the non-nested case using the same 924b1f9d385SAmir Goldstein * upper fs: 925b1f9d385SAmir Goldstein * - inode->i_rwsem (inode_lock[1]) 926b1f9d385SAmir Goldstein * - upper_mnt->mnt_sb->s_writers (ovl_want_write[0]) 927b1f9d385SAmir Goldstein * - OVL_I(inode)->lock (ovl_inode_lock[1]) 928b1eaa950SAmir Goldstein */ 929b1eaa950SAmir Goldstein #define OVL_MAX_NESTING FILESYSTEM_MAX_STACK_DEPTH 930b1eaa950SAmir Goldstein 931b1eaa950SAmir Goldstein static inline void ovl_lockdep_annotate_inode_mutex_key(struct inode *inode) 932b1eaa950SAmir Goldstein { 933b1eaa950SAmir Goldstein #ifdef CONFIG_LOCKDEP 934b1eaa950SAmir Goldstein static struct lock_class_key ovl_i_mutex_key[OVL_MAX_NESTING]; 935b1eaa950SAmir Goldstein static struct lock_class_key ovl_i_mutex_dir_key[OVL_MAX_NESTING]; 9364eae06deSAmir Goldstein static struct lock_class_key ovl_i_lock_key[OVL_MAX_NESTING]; 937b1eaa950SAmir Goldstein 938b1eaa950SAmir Goldstein int depth = inode->i_sb->s_stack_depth - 1; 939b1eaa950SAmir Goldstein 940b1eaa950SAmir Goldstein if (WARN_ON_ONCE(depth < 0 || depth >= OVL_MAX_NESTING)) 941b1eaa950SAmir Goldstein depth = 0; 942b1eaa950SAmir Goldstein 943b1eaa950SAmir Goldstein if (S_ISDIR(inode->i_mode)) 944b1eaa950SAmir Goldstein lockdep_set_class(&inode->i_rwsem, &ovl_i_mutex_dir_key[depth]); 945b1eaa950SAmir Goldstein else 946b1eaa950SAmir Goldstein lockdep_set_class(&inode->i_rwsem, &ovl_i_mutex_key[depth]); 9474eae06deSAmir Goldstein 9484eae06deSAmir Goldstein lockdep_set_class(&OVL_I(inode)->lock, &ovl_i_lock_key[depth]); 949b1eaa950SAmir Goldstein #endif 950b1eaa950SAmir Goldstein } 951b1eaa950SAmir Goldstein 9524d314f78SAmir Goldstein static void ovl_next_ino(struct inode *inode) 9534d314f78SAmir Goldstein { 9544d314f78SAmir Goldstein struct ovl_fs *ofs = inode->i_sb->s_fs_info; 9554d314f78SAmir Goldstein 9564d314f78SAmir Goldstein inode->i_ino = atomic_long_inc_return(&ofs->last_ino); 9574d314f78SAmir Goldstein if (unlikely(!inode->i_ino)) 9584d314f78SAmir Goldstein inode->i_ino = atomic_long_inc_return(&ofs->last_ino); 9594d314f78SAmir Goldstein } 9604d314f78SAmir Goldstein 96162c832edSAmir Goldstein static void ovl_map_ino(struct inode *inode, unsigned long ino, int fsid) 962e9be9d5eSMiklos Szeredi { 96312574a9fSAmir Goldstein int xinobits = ovl_xino_bits(inode->i_sb); 964dfe51d47SAmir Goldstein unsigned int xinoshift = 64 - xinobits; 96512574a9fSAmir Goldstein 966695b46e7SAmir Goldstein /* 9676dde1e42SAmir Goldstein * When d_ino is consistent with st_ino (samefs or i_ino has enough 9686dde1e42SAmir Goldstein * bits to encode layer), set the same value used for st_ino to i_ino, 9696dde1e42SAmir Goldstein * so inode number exposed via /proc/locks and a like will be 9706dde1e42SAmir Goldstein * consistent with d_ino and st_ino values. An i_ino value inconsistent 971735c907dSAmir Goldstein * with d_ino also causes nfsd readdirplus to fail. 972695b46e7SAmir Goldstein */ 973695b46e7SAmir Goldstein inode->i_ino = ino; 974dfe51d47SAmir Goldstein if (ovl_same_fs(inode->i_sb)) { 975dfe51d47SAmir Goldstein return; 976dfe51d47SAmir Goldstein } else if (xinobits && likely(!(ino >> xinoshift))) { 977dfe51d47SAmir Goldstein inode->i_ino |= (unsigned long)fsid << (xinoshift + 1); 978dfe51d47SAmir Goldstein return; 979dfe51d47SAmir Goldstein } 980dfe51d47SAmir Goldstein 981dfe51d47SAmir Goldstein /* 982dfe51d47SAmir Goldstein * For directory inodes on non-samefs with xino disabled or xino 983dfe51d47SAmir Goldstein * overflow, we allocate a non-persistent inode number, to be used for 984dfe51d47SAmir Goldstein * resolving st_ino collisions in ovl_map_dev_ino(). 985dfe51d47SAmir Goldstein * 986dfe51d47SAmir Goldstein * To avoid ino collision with legitimate xino values from upper 987dfe51d47SAmir Goldstein * layer (fsid 0), use the lowest xinobit to map the non 988dfe51d47SAmir Goldstein * persistent inode numbers to the unified st_ino address space. 989dfe51d47SAmir Goldstein */ 990dfe51d47SAmir Goldstein if (S_ISDIR(inode->i_mode)) { 9914d314f78SAmir Goldstein ovl_next_ino(inode); 992dfe51d47SAmir Goldstein if (xinobits) { 993dfe51d47SAmir Goldstein inode->i_ino &= ~0UL >> xinobits; 994dfe51d47SAmir Goldstein inode->i_ino |= 1UL << xinoshift; 995dfe51d47SAmir Goldstein } 99612574a9fSAmir Goldstein } 99762c832edSAmir Goldstein } 99862c832edSAmir Goldstein 99962c832edSAmir Goldstein void ovl_inode_init(struct inode *inode, struct ovl_inode_params *oip, 100062c832edSAmir Goldstein unsigned long ino, int fsid) 100162c832edSAmir Goldstein { 100262c832edSAmir Goldstein struct inode *realinode; 1003ffa5723cSAmir Goldstein struct ovl_inode *oi = OVL_I(inode); 100462c832edSAmir Goldstein 1005ffa5723cSAmir Goldstein oi->__upperdentry = oip->upperdentry; 10060af950f5SAmir Goldstein oi->oe = oip->oe; 10070af950f5SAmir Goldstein oi->redirect = oip->redirect; 1008*2b21da92SAmir Goldstein oi->lowerdata_redirect = oip->lowerdata_redirect; 100962c832edSAmir Goldstein 101062c832edSAmir Goldstein realinode = ovl_inode_real(inode); 10112878dffcSChristian Brauner ovl_copyattr(inode); 101262c832edSAmir Goldstein ovl_copyflags(realinode, inode); 101362c832edSAmir Goldstein ovl_map_ino(inode, ino, fsid); 101462c832edSAmir Goldstein } 101562c832edSAmir Goldstein 101662c832edSAmir Goldstein static void ovl_fill_inode(struct inode *inode, umode_t mode, dev_t rdev) 101762c832edSAmir Goldstein { 1018e9be9d5eSMiklos Szeredi inode->i_mode = mode; 1019d719e8f2SMiklos Szeredi inode->i_flags |= S_NOCMTIME; 10202a3a2a3fSMiklos Szeredi #ifdef CONFIG_FS_POSIX_ACL 10212a3a2a3fSMiklos Szeredi inode->i_acl = inode->i_default_acl = ACL_DONT_CACHE; 10222a3a2a3fSMiklos Szeredi #endif 1023e9be9d5eSMiklos Szeredi 1024b1eaa950SAmir Goldstein ovl_lockdep_annotate_inode_mutex_key(inode); 1025b1eaa950SAmir Goldstein 1026ca4c8a3aSMiklos Szeredi switch (mode & S_IFMT) { 1027ca4c8a3aSMiklos Szeredi case S_IFREG: 1028ca4c8a3aSMiklos Szeredi inode->i_op = &ovl_file_inode_operations; 1029d1d04ef8SMiklos Szeredi inode->i_fop = &ovl_file_operations; 10305b910bd6SAmir Goldstein inode->i_mapping->a_ops = &ovl_aops; 1031ca4c8a3aSMiklos Szeredi break; 1032ca4c8a3aSMiklos Szeredi 1033e9be9d5eSMiklos Szeredi case S_IFDIR: 1034e9be9d5eSMiklos Szeredi inode->i_op = &ovl_dir_inode_operations; 1035e9be9d5eSMiklos Szeredi inode->i_fop = &ovl_dir_operations; 1036e9be9d5eSMiklos Szeredi break; 1037e9be9d5eSMiklos Szeredi 1038e9be9d5eSMiklos Szeredi case S_IFLNK: 1039e9be9d5eSMiklos Szeredi inode->i_op = &ovl_symlink_inode_operations; 1040e9be9d5eSMiklos Szeredi break; 1041e9be9d5eSMiklos Szeredi 104251f7e52dSMiklos Szeredi default: 10439e142c41SMiklos Szeredi inode->i_op = &ovl_special_inode_operations; 1044ca4c8a3aSMiklos Szeredi init_special_inode(inode, mode, rdev); 1045e9be9d5eSMiklos Szeredi break; 104651f7e52dSMiklos Szeredi } 104751f7e52dSMiklos Szeredi } 1048e9be9d5eSMiklos Szeredi 10495f8415d6SAmir Goldstein /* 10505f8415d6SAmir Goldstein * With inodes index enabled, an overlay inode nlink counts the union of upper 10515f8415d6SAmir Goldstein * hardlinks and non-covered lower hardlinks. During the lifetime of a non-pure 10525f8415d6SAmir Goldstein * upper inode, the following nlink modifying operations can happen: 10535f8415d6SAmir Goldstein * 10545f8415d6SAmir Goldstein * 1. Lower hardlink copy up 10555f8415d6SAmir Goldstein * 2. Upper hardlink created, unlinked or renamed over 10565f8415d6SAmir Goldstein * 3. Lower hardlink whiteout or renamed over 10575f8415d6SAmir Goldstein * 10585f8415d6SAmir Goldstein * For the first, copy up case, the union nlink does not change, whether the 10595f8415d6SAmir Goldstein * operation succeeds or fails, but the upper inode nlink may change. 10605f8415d6SAmir Goldstein * Therefore, before copy up, we store the union nlink value relative to the 10612d2f2d73SMiklos Szeredi * lower inode nlink in the index inode xattr .overlay.nlink. 10625f8415d6SAmir Goldstein * 10635f8415d6SAmir Goldstein * For the second, upper hardlink case, the union nlink should be incremented 10645f8415d6SAmir Goldstein * or decremented IFF the operation succeeds, aligned with nlink change of the 10655f8415d6SAmir Goldstein * upper inode. Therefore, before link/unlink/rename, we store the union nlink 10665f8415d6SAmir Goldstein * value relative to the upper inode nlink in the index inode. 10675f8415d6SAmir Goldstein * 10685f8415d6SAmir Goldstein * For the last, lower cover up case, we simplify things by preceding the 10695f8415d6SAmir Goldstein * whiteout or cover up with copy up. This makes sure that there is an index 10705f8415d6SAmir Goldstein * upper inode where the nlink xattr can be stored before the copied up upper 10715f8415d6SAmir Goldstein * entry is unlink. 10725f8415d6SAmir Goldstein */ 10735f8415d6SAmir Goldstein #define OVL_NLINK_ADD_UPPER (1 << 0) 10745f8415d6SAmir Goldstein 10755f8415d6SAmir Goldstein /* 10765f8415d6SAmir Goldstein * On-disk format for indexed nlink: 10775f8415d6SAmir Goldstein * 10785f8415d6SAmir Goldstein * nlink relative to the upper inode - "U[+-]NUM" 10795f8415d6SAmir Goldstein * nlink relative to the lower inode - "L[+-]NUM" 10805f8415d6SAmir Goldstein */ 10815f8415d6SAmir Goldstein 10825f8415d6SAmir Goldstein static int ovl_set_nlink_common(struct dentry *dentry, 10835f8415d6SAmir Goldstein struct dentry *realdentry, const char *format) 10845f8415d6SAmir Goldstein { 10855f8415d6SAmir Goldstein struct inode *inode = d_inode(dentry); 10865f8415d6SAmir Goldstein struct inode *realinode = d_inode(realdentry); 10875f8415d6SAmir Goldstein char buf[13]; 10885f8415d6SAmir Goldstein int len; 10895f8415d6SAmir Goldstein 10905f8415d6SAmir Goldstein len = snprintf(buf, sizeof(buf), format, 10915f8415d6SAmir Goldstein (int) (inode->i_nlink - realinode->i_nlink)); 10925f8415d6SAmir Goldstein 10936787341aSMiklos Szeredi if (WARN_ON(len >= sizeof(buf))) 10946787341aSMiklos Szeredi return -EIO; 10956787341aSMiklos Szeredi 1096c914c0e2SAmir Goldstein return ovl_setxattr(OVL_FS(inode->i_sb), ovl_dentry_upper(dentry), 109726150ab5SMiklos Szeredi OVL_XATTR_NLINK, buf, len); 10985f8415d6SAmir Goldstein } 10995f8415d6SAmir Goldstein 11005f8415d6SAmir Goldstein int ovl_set_nlink_upper(struct dentry *dentry) 11015f8415d6SAmir Goldstein { 11025f8415d6SAmir Goldstein return ovl_set_nlink_common(dentry, ovl_dentry_upper(dentry), "U%+i"); 11035f8415d6SAmir Goldstein } 11045f8415d6SAmir Goldstein 11055f8415d6SAmir Goldstein int ovl_set_nlink_lower(struct dentry *dentry) 11065f8415d6SAmir Goldstein { 11075f8415d6SAmir Goldstein return ovl_set_nlink_common(dentry, ovl_dentry_lower(dentry), "L%+i"); 11085f8415d6SAmir Goldstein } 11095f8415d6SAmir Goldstein 1110610afc0bSMiklos Szeredi unsigned int ovl_get_nlink(struct ovl_fs *ofs, struct dentry *lowerdentry, 11115f8415d6SAmir Goldstein struct dentry *upperdentry, 11125f8415d6SAmir Goldstein unsigned int fallback) 11135f8415d6SAmir Goldstein { 11145f8415d6SAmir Goldstein int nlink_diff; 11155f8415d6SAmir Goldstein int nlink; 11165f8415d6SAmir Goldstein char buf[13]; 11175f8415d6SAmir Goldstein int err; 11185f8415d6SAmir Goldstein 11195f8415d6SAmir Goldstein if (!lowerdentry || !upperdentry || d_inode(lowerdentry)->i_nlink == 1) 11205f8415d6SAmir Goldstein return fallback; 11215f8415d6SAmir Goldstein 1122dad7017aSChristian Brauner err = ovl_getxattr_upper(ofs, upperdentry, OVL_XATTR_NLINK, 1123d5dc7486SMiklos Szeredi &buf, sizeof(buf) - 1); 11245f8415d6SAmir Goldstein if (err < 0) 11255f8415d6SAmir Goldstein goto fail; 11265f8415d6SAmir Goldstein 11275f8415d6SAmir Goldstein buf[err] = '\0'; 11285f8415d6SAmir Goldstein if ((buf[0] != 'L' && buf[0] != 'U') || 11295f8415d6SAmir Goldstein (buf[1] != '+' && buf[1] != '-')) 11305f8415d6SAmir Goldstein goto fail; 11315f8415d6SAmir Goldstein 11325f8415d6SAmir Goldstein err = kstrtoint(buf + 1, 10, &nlink_diff); 11335f8415d6SAmir Goldstein if (err < 0) 11345f8415d6SAmir Goldstein goto fail; 11355f8415d6SAmir Goldstein 11365f8415d6SAmir Goldstein nlink = d_inode(buf[0] == 'L' ? lowerdentry : upperdentry)->i_nlink; 11375f8415d6SAmir Goldstein nlink += nlink_diff; 11385f8415d6SAmir Goldstein 11395f8415d6SAmir Goldstein if (nlink <= 0) 11405f8415d6SAmir Goldstein goto fail; 11415f8415d6SAmir Goldstein 11425f8415d6SAmir Goldstein return nlink; 11435f8415d6SAmir Goldstein 11445f8415d6SAmir Goldstein fail: 11451bd0a3aeSlijiazi pr_warn_ratelimited("failed to get index nlink (%pd2, err=%i)\n", 11465f8415d6SAmir Goldstein upperdentry, err); 11475f8415d6SAmir Goldstein return fallback; 11485f8415d6SAmir Goldstein } 11495f8415d6SAmir Goldstein 1150ca4c8a3aSMiklos Szeredi struct inode *ovl_new_inode(struct super_block *sb, umode_t mode, dev_t rdev) 115151f7e52dSMiklos Szeredi { 115251f7e52dSMiklos Szeredi struct inode *inode; 115351f7e52dSMiklos Szeredi 115451f7e52dSMiklos Szeredi inode = new_inode(sb); 115551f7e52dSMiklos Szeredi if (inode) 115662c832edSAmir Goldstein ovl_fill_inode(inode, mode, rdev); 115751f7e52dSMiklos Szeredi 115851f7e52dSMiklos Szeredi return inode; 115951f7e52dSMiklos Szeredi } 116051f7e52dSMiklos Szeredi 116151f7e52dSMiklos Szeredi static int ovl_inode_test(struct inode *inode, void *data) 116251f7e52dSMiklos Szeredi { 116325b7713aSMiklos Szeredi return inode->i_private == data; 116451f7e52dSMiklos Szeredi } 116551f7e52dSMiklos Szeredi 116651f7e52dSMiklos Szeredi static int ovl_inode_set(struct inode *inode, void *data) 116751f7e52dSMiklos Szeredi { 116825b7713aSMiklos Szeredi inode->i_private = data; 116951f7e52dSMiklos Szeredi return 0; 117051f7e52dSMiklos Szeredi } 117151f7e52dSMiklos Szeredi 1172b9ac5c27SMiklos Szeredi static bool ovl_verify_inode(struct inode *inode, struct dentry *lowerdentry, 11734b91c30aSAmir Goldstein struct dentry *upperdentry, bool strict) 1174b9ac5c27SMiklos Szeredi { 11754b91c30aSAmir Goldstein /* 11764b91c30aSAmir Goldstein * For directories, @strict verify from lookup path performs consistency 11774b91c30aSAmir Goldstein * checks, so NULL lower/upper in dentry must match NULL lower/upper in 11784b91c30aSAmir Goldstein * inode. Non @strict verify from NFS handle decode path passes NULL for 11794b91c30aSAmir Goldstein * 'unknown' lower/upper. 11804b91c30aSAmir Goldstein */ 11814b91c30aSAmir Goldstein if (S_ISDIR(inode->i_mode) && strict) { 118231747edaSAmir Goldstein /* Real lower dir moved to upper layer under us? */ 118331747edaSAmir Goldstein if (!lowerdentry && ovl_inode_lower(inode)) 118431747edaSAmir Goldstein return false; 118531747edaSAmir Goldstein 118631747edaSAmir Goldstein /* Lookup of an uncovered redirect origin? */ 118731747edaSAmir Goldstein if (!upperdentry && ovl_inode_upper(inode)) 118831747edaSAmir Goldstein return false; 118931747edaSAmir Goldstein } 119031747edaSAmir Goldstein 1191939ae4efSAmir Goldstein /* 1192939ae4efSAmir Goldstein * Allow non-NULL lower inode in ovl_inode even if lowerdentry is NULL. 1193939ae4efSAmir Goldstein * This happens when finding a copied up overlay inode for a renamed 1194939ae4efSAmir Goldstein * or hardlinked overlay dentry and lower dentry cannot be followed 1195939ae4efSAmir Goldstein * by origin because lower fs does not support file handles. 1196939ae4efSAmir Goldstein */ 1197939ae4efSAmir Goldstein if (lowerdentry && ovl_inode_lower(inode) != d_inode(lowerdentry)) 1198b9ac5c27SMiklos Szeredi return false; 1199b9ac5c27SMiklos Szeredi 1200b9ac5c27SMiklos Szeredi /* 1201b9ac5c27SMiklos Szeredi * Allow non-NULL __upperdentry in inode even if upperdentry is NULL. 1202b9ac5c27SMiklos Szeredi * This happens when finding a lower alias for a copied up hard link. 1203b9ac5c27SMiklos Szeredi */ 1204b9ac5c27SMiklos Szeredi if (upperdentry && ovl_inode_upper(inode) != d_inode(upperdentry)) 1205b9ac5c27SMiklos Szeredi return false; 1206b9ac5c27SMiklos Szeredi 1207b9ac5c27SMiklos Szeredi return true; 1208b9ac5c27SMiklos Szeredi } 1209b9ac5c27SMiklos Szeredi 12104b91c30aSAmir Goldstein struct inode *ovl_lookup_inode(struct super_block *sb, struct dentry *real, 12114b91c30aSAmir Goldstein bool is_upper) 12129436a1a3SAmir Goldstein { 12134b91c30aSAmir Goldstein struct inode *inode, *key = d_inode(real); 12149436a1a3SAmir Goldstein 12159436a1a3SAmir Goldstein inode = ilookup5(sb, (unsigned long) key, ovl_inode_test, key); 12169436a1a3SAmir Goldstein if (!inode) 12179436a1a3SAmir Goldstein return NULL; 12189436a1a3SAmir Goldstein 12194b91c30aSAmir Goldstein if (!ovl_verify_inode(inode, is_upper ? NULL : real, 12204b91c30aSAmir Goldstein is_upper ? real : NULL, false)) { 12219436a1a3SAmir Goldstein iput(inode); 12229436a1a3SAmir Goldstein return ERR_PTR(-ESTALE); 12239436a1a3SAmir Goldstein } 12249436a1a3SAmir Goldstein 12259436a1a3SAmir Goldstein return inode; 12269436a1a3SAmir Goldstein } 12279436a1a3SAmir Goldstein 1228146d62e5SAmir Goldstein bool ovl_lookup_trap_inode(struct super_block *sb, struct dentry *dir) 1229146d62e5SAmir Goldstein { 1230146d62e5SAmir Goldstein struct inode *key = d_inode(dir); 1231146d62e5SAmir Goldstein struct inode *trap; 1232146d62e5SAmir Goldstein bool res; 1233146d62e5SAmir Goldstein 1234146d62e5SAmir Goldstein trap = ilookup5(sb, (unsigned long) key, ovl_inode_test, key); 1235146d62e5SAmir Goldstein if (!trap) 1236146d62e5SAmir Goldstein return false; 1237146d62e5SAmir Goldstein 1238146d62e5SAmir Goldstein res = IS_DEADDIR(trap) && !ovl_inode_upper(trap) && 1239146d62e5SAmir Goldstein !ovl_inode_lower(trap); 1240146d62e5SAmir Goldstein 1241146d62e5SAmir Goldstein iput(trap); 1242146d62e5SAmir Goldstein return res; 1243146d62e5SAmir Goldstein } 1244146d62e5SAmir Goldstein 1245146d62e5SAmir Goldstein /* 1246146d62e5SAmir Goldstein * Create an inode cache entry for layer root dir, that will intentionally 1247146d62e5SAmir Goldstein * fail ovl_verify_inode(), so any lookup that will find some layer root 1248146d62e5SAmir Goldstein * will fail. 1249146d62e5SAmir Goldstein */ 1250146d62e5SAmir Goldstein struct inode *ovl_get_trap_inode(struct super_block *sb, struct dentry *dir) 1251146d62e5SAmir Goldstein { 1252146d62e5SAmir Goldstein struct inode *key = d_inode(dir); 1253146d62e5SAmir Goldstein struct inode *trap; 1254146d62e5SAmir Goldstein 1255146d62e5SAmir Goldstein if (!d_is_dir(dir)) 1256146d62e5SAmir Goldstein return ERR_PTR(-ENOTDIR); 1257146d62e5SAmir Goldstein 1258146d62e5SAmir Goldstein trap = iget5_locked(sb, (unsigned long) key, ovl_inode_test, 1259146d62e5SAmir Goldstein ovl_inode_set, key); 1260146d62e5SAmir Goldstein if (!trap) 1261146d62e5SAmir Goldstein return ERR_PTR(-ENOMEM); 1262146d62e5SAmir Goldstein 1263146d62e5SAmir Goldstein if (!(trap->i_state & I_NEW)) { 1264146d62e5SAmir Goldstein /* Conflicting layer roots? */ 1265146d62e5SAmir Goldstein iput(trap); 1266146d62e5SAmir Goldstein return ERR_PTR(-ELOOP); 1267146d62e5SAmir Goldstein } 1268146d62e5SAmir Goldstein 1269146d62e5SAmir Goldstein trap->i_mode = S_IFDIR; 1270146d62e5SAmir Goldstein trap->i_flags = S_DEAD; 1271146d62e5SAmir Goldstein unlock_new_inode(trap); 1272146d62e5SAmir Goldstein 1273146d62e5SAmir Goldstein return trap; 1274146d62e5SAmir Goldstein } 1275146d62e5SAmir Goldstein 1276764baba8SAmir Goldstein /* 1277764baba8SAmir Goldstein * Does overlay inode need to be hashed by lower inode? 1278764baba8SAmir Goldstein */ 1279764baba8SAmir Goldstein static bool ovl_hash_bylower(struct super_block *sb, struct dentry *upper, 128074c6e384SMiklos Szeredi struct dentry *lower, bool index) 1281764baba8SAmir Goldstein { 1282764baba8SAmir Goldstein struct ovl_fs *ofs = sb->s_fs_info; 1283764baba8SAmir Goldstein 1284764baba8SAmir Goldstein /* No, if pure upper */ 1285764baba8SAmir Goldstein if (!lower) 1286764baba8SAmir Goldstein return false; 1287764baba8SAmir Goldstein 1288764baba8SAmir Goldstein /* Yes, if already indexed */ 1289764baba8SAmir Goldstein if (index) 1290764baba8SAmir Goldstein return true; 1291764baba8SAmir Goldstein 1292764baba8SAmir Goldstein /* Yes, if won't be copied up */ 129308f4c7c8SMiklos Szeredi if (!ovl_upper_mnt(ofs)) 1294764baba8SAmir Goldstein return true; 1295764baba8SAmir Goldstein 1296764baba8SAmir Goldstein /* No, if lower hardlink is or will be broken on copy up */ 1297764baba8SAmir Goldstein if ((upper || !ovl_indexdir(sb)) && 1298764baba8SAmir Goldstein !d_is_dir(lower) && d_inode(lower)->i_nlink > 1) 1299764baba8SAmir Goldstein return false; 1300764baba8SAmir Goldstein 1301764baba8SAmir Goldstein /* No, if non-indexed upper with NFS export */ 1302764baba8SAmir Goldstein if (sb->s_export_op && upper) 1303764baba8SAmir Goldstein return false; 1304764baba8SAmir Goldstein 1305764baba8SAmir Goldstein /* Otherwise, hash by lower inode for fsnotify */ 1306764baba8SAmir Goldstein return true; 1307764baba8SAmir Goldstein } 1308764baba8SAmir Goldstein 130901b39dccSAmir Goldstein static struct inode *ovl_iget5(struct super_block *sb, struct inode *newinode, 131001b39dccSAmir Goldstein struct inode *key) 131101b39dccSAmir Goldstein { 131201b39dccSAmir Goldstein return newinode ? inode_insert5(newinode, (unsigned long) key, 131301b39dccSAmir Goldstein ovl_inode_test, ovl_inode_set, key) : 131401b39dccSAmir Goldstein iget5_locked(sb, (unsigned long) key, 131501b39dccSAmir Goldstein ovl_inode_test, ovl_inode_set, key); 131601b39dccSAmir Goldstein } 131701b39dccSAmir Goldstein 1318ac6a52ebSVivek Goyal struct inode *ovl_get_inode(struct super_block *sb, 1319ac6a52ebSVivek Goyal struct ovl_inode_params *oip) 132051f7e52dSMiklos Szeredi { 1321610afc0bSMiklos Szeredi struct ovl_fs *ofs = OVL_FS(sb); 1322ac6a52ebSVivek Goyal struct dentry *upperdentry = oip->upperdentry; 1323ac900ed4SAmir Goldstein struct ovl_path *lowerpath = ovl_lowerpath(oip->oe); 132409d8b586SMiklos Szeredi struct inode *realinode = upperdentry ? d_inode(upperdentry) : NULL; 132551f7e52dSMiklos Szeredi struct inode *inode; 132612574a9fSAmir Goldstein struct dentry *lowerdentry = lowerpath ? lowerpath->dentry : NULL; 1327dad7017aSChristian Brauner struct path realpath = { 1328dad7017aSChristian Brauner .dentry = upperdentry ?: lowerdentry, 1329dad7017aSChristian Brauner .mnt = upperdentry ? ovl_upper_mnt(ofs) : lowerpath->layer->mnt, 1330dad7017aSChristian Brauner }; 1331ac6a52ebSVivek Goyal bool bylower = ovl_hash_bylower(sb, upperdentry, lowerdentry, 1332ac6a52ebSVivek Goyal oip->index); 1333300b124fSAmir Goldstein int fsid = bylower ? lowerpath->layer->fsid : 0; 133428166ab3SVivek Goyal bool is_dir; 1335695b46e7SAmir Goldstein unsigned long ino = 0; 1336acf3062aSAmir Goldstein int err = oip->newinode ? -EEXIST : -ENOMEM; 13376eaf0111SAmir Goldstein 133809d8b586SMiklos Szeredi if (!realinode) 133909d8b586SMiklos Szeredi realinode = d_inode(lowerdentry); 134009d8b586SMiklos Szeredi 13416eaf0111SAmir Goldstein /* 1342764baba8SAmir Goldstein * Copy up origin (lower) may exist for non-indexed upper, but we must 1343764baba8SAmir Goldstein * not use lower as hash key if this is a broken hardlink. 13446eaf0111SAmir Goldstein */ 134531747edaSAmir Goldstein is_dir = S_ISDIR(realinode->i_mode); 1346764baba8SAmir Goldstein if (upperdentry || bylower) { 1347764baba8SAmir Goldstein struct inode *key = d_inode(bylower ? lowerdentry : 1348764baba8SAmir Goldstein upperdentry); 134931747edaSAmir Goldstein unsigned int nlink = is_dir ? 1 : realinode->i_nlink; 1350b9ac5c27SMiklos Szeredi 135101b39dccSAmir Goldstein inode = ovl_iget5(sb, oip->newinode, key); 135209d8b586SMiklos Szeredi if (!inode) 1353027065b7SVivek Goyal goto out_err; 135409d8b586SMiklos Szeredi if (!(inode->i_state & I_NEW)) { 1355b9ac5c27SMiklos Szeredi /* 1356b9ac5c27SMiklos Szeredi * Verify that the underlying files stored in the inode 1357b9ac5c27SMiklos Szeredi * match those in the dentry. 1358b9ac5c27SMiklos Szeredi */ 13594b91c30aSAmir Goldstein if (!ovl_verify_inode(inode, lowerdentry, upperdentry, 13604b91c30aSAmir Goldstein true)) { 1361b9ac5c27SMiklos Szeredi iput(inode); 1362027065b7SVivek Goyal err = -ESTALE; 1363027065b7SVivek Goyal goto out_err; 1364b9ac5c27SMiklos Szeredi } 1365b9ac5c27SMiklos Szeredi 136609d8b586SMiklos Szeredi dput(upperdentry); 13670af950f5SAmir Goldstein ovl_free_entry(oip->oe); 13689cec54c8SVivek Goyal kfree(oip->redirect); 1369*2b21da92SAmir Goldstein kfree(oip->lowerdata_redirect); 137009d8b586SMiklos Szeredi goto out; 137109d8b586SMiklos Szeredi } 1372e9be9d5eSMiklos Szeredi 137331747edaSAmir Goldstein /* Recalculate nlink for non-dir due to indexing */ 137431747edaSAmir Goldstein if (!is_dir) 1375610afc0bSMiklos Szeredi nlink = ovl_get_nlink(ofs, lowerdentry, upperdentry, 1376610afc0bSMiklos Szeredi nlink); 13775f8415d6SAmir Goldstein set_nlink(inode, nlink); 1378695b46e7SAmir Goldstein ino = key->i_ino; 1379e6d2ebddSMiklos Szeredi } else { 1380764baba8SAmir Goldstein /* Lower hardlink that will be broken on copy up */ 13810aceb53eSAmir Goldstein inode = new_inode(sb); 1382027065b7SVivek Goyal if (!inode) { 1383027065b7SVivek Goyal err = -ENOMEM; 1384027065b7SVivek Goyal goto out_err; 1385027065b7SVivek Goyal } 1386300b124fSAmir Goldstein ino = realinode->i_ino; 1387300b124fSAmir Goldstein fsid = lowerpath->layer->fsid; 1388e6d2ebddSMiklos Szeredi } 138962c832edSAmir Goldstein ovl_fill_inode(inode, realinode->i_mode, realinode->i_rdev); 139062c832edSAmir Goldstein ovl_inode_init(inode, oip, ino, fsid); 139113c72075SMiklos Szeredi 1392610afc0bSMiklos Szeredi if (upperdentry && ovl_is_impuredir(sb, upperdentry)) 139313c72075SMiklos Szeredi ovl_set_flag(OVL_IMPURE, inode); 139413c72075SMiklos Szeredi 1395ac6a52ebSVivek Goyal if (oip->index) 13960471a9cdSVivek Goyal ovl_set_flag(OVL_INDEX, inode); 13970471a9cdSVivek Goyal 1398a00c2d59SVivek Goyal if (bylower) 1399a00c2d59SVivek Goyal ovl_set_flag(OVL_CONST_INO, inode); 1400a00c2d59SVivek Goyal 1401b79e05aaSAmir Goldstein /* Check for non-merge dir that may have whiteouts */ 140231747edaSAmir Goldstein if (is_dir) { 1403ac900ed4SAmir Goldstein if (((upperdentry && lowerdentry) || ovl_numlower(oip->oe) > 1) || 1404dad7017aSChristian Brauner ovl_path_check_origin_xattr(ofs, &realpath)) { 1405b79e05aaSAmir Goldstein ovl_set_flag(OVL_WHITEOUTS, inode); 1406b79e05aaSAmir Goldstein } 1407b79e05aaSAmir Goldstein } 1408b79e05aaSAmir Goldstein 1409096a218aSAmir Goldstein /* Check for immutable/append-only inode flags in xattr */ 1410096a218aSAmir Goldstein if (upperdentry) 1411096a218aSAmir Goldstein ovl_check_protattr(inode, upperdentry); 1412096a218aSAmir Goldstein 1413e6d2ebddSMiklos Szeredi if (inode->i_state & I_NEW) 1414e6d2ebddSMiklos Szeredi unlock_new_inode(inode); 1415e6d2ebddSMiklos Szeredi out: 1416e9be9d5eSMiklos Szeredi return inode; 1417b9ac5c27SMiklos Szeredi 1418027065b7SVivek Goyal out_err: 14191bd0a3aeSlijiazi pr_warn_ratelimited("failed to get inode (%i)\n", err); 1420027065b7SVivek Goyal inode = ERR_PTR(err); 1421b9ac5c27SMiklos Szeredi goto out; 1422e9be9d5eSMiklos Szeredi } 1423