xref: /openbmc/linux/fs/nfs_common/nfsacl.c (revision 8be98d2f2a0a262f8bf8a0bc1fdf522b3c7aab17)
109c434b8SThomas Gleixner // SPDX-License-Identifier: GPL-2.0-only
2a257cdd0SAndreas Gruenbacher /*
3a257cdd0SAndreas Gruenbacher  * fs/nfs_common/nfsacl.c
4a257cdd0SAndreas Gruenbacher  *
5a257cdd0SAndreas Gruenbacher  *  Copyright (C) 2002-2003 Andreas Gruenbacher <agruen@suse.de>
6a257cdd0SAndreas Gruenbacher  */
7a257cdd0SAndreas Gruenbacher 
8a257cdd0SAndreas Gruenbacher /*
9a257cdd0SAndreas Gruenbacher  * The Solaris nfsacl protocol represents some ACLs slightly differently
10a257cdd0SAndreas Gruenbacher  * than POSIX 1003.1e draft 17 does (and we do):
11a257cdd0SAndreas Gruenbacher  *
12a257cdd0SAndreas Gruenbacher  *  - Minimal ACLs always have an ACL_MASK entry, so they have
13a257cdd0SAndreas Gruenbacher  *    four instead of three entries.
14a257cdd0SAndreas Gruenbacher  *  - The ACL_MASK entry in such minimal ACLs always has the same
15a257cdd0SAndreas Gruenbacher  *    permissions as the ACL_GROUP_OBJ entry. (In extended ACLs
16a257cdd0SAndreas Gruenbacher  *    the ACL_MASK and ACL_GROUP_OBJ entries may differ.)
17a257cdd0SAndreas Gruenbacher  *  - The identifier fields of the ACL_USER_OBJ and ACL_GROUP_OBJ
18a257cdd0SAndreas Gruenbacher  *    entries contain the identifiers of the owner and owning group.
19a257cdd0SAndreas Gruenbacher  *    (In POSIX ACLs we always set them to ACL_UNDEFINED_ID).
20a257cdd0SAndreas Gruenbacher  *  - ACL entries in the kernel are kept sorted in ascending order
21a257cdd0SAndreas Gruenbacher  *    of (e_tag, e_id). Solaris ACLs are unsorted.
22a257cdd0SAndreas Gruenbacher  */
23a257cdd0SAndreas Gruenbacher 
24a257cdd0SAndreas Gruenbacher #include <linux/module.h>
25a257cdd0SAndreas Gruenbacher #include <linux/fs.h>
265a0e3ad6STejun Heo #include <linux/gfp.h>
27a257cdd0SAndreas Gruenbacher #include <linux/sunrpc/xdr.h>
28a257cdd0SAndreas Gruenbacher #include <linux/nfsacl.h>
29a257cdd0SAndreas Gruenbacher #include <linux/nfs3.h>
30a257cdd0SAndreas Gruenbacher #include <linux/sort.h>
31a257cdd0SAndreas Gruenbacher 
32a257cdd0SAndreas Gruenbacher MODULE_LICENSE("GPL");
33a257cdd0SAndreas Gruenbacher 
34a257cdd0SAndreas Gruenbacher struct nfsacl_encode_desc {
35a257cdd0SAndreas Gruenbacher 	struct xdr_array2_desc desc;
36a257cdd0SAndreas Gruenbacher 	unsigned int count;
37a257cdd0SAndreas Gruenbacher 	struct posix_acl *acl;
38a257cdd0SAndreas Gruenbacher 	int typeflag;
39ddca4e17SEric W. Biederman 	kuid_t uid;
40ddca4e17SEric W. Biederman 	kgid_t gid;
41a257cdd0SAndreas Gruenbacher };
42a257cdd0SAndreas Gruenbacher 
43f61f6da0SChuck Lever struct nfsacl_simple_acl {
44f61f6da0SChuck Lever 	struct posix_acl acl;
45f61f6da0SChuck Lever 	struct posix_acl_entry ace[4];
46f61f6da0SChuck Lever };
47f61f6da0SChuck Lever 
48a257cdd0SAndreas Gruenbacher static int
xdr_nfsace_encode(struct xdr_array2_desc * desc,void * elem)49a257cdd0SAndreas Gruenbacher xdr_nfsace_encode(struct xdr_array2_desc *desc, void *elem)
50a257cdd0SAndreas Gruenbacher {
51a257cdd0SAndreas Gruenbacher 	struct nfsacl_encode_desc *nfsacl_desc =
52a257cdd0SAndreas Gruenbacher 		(struct nfsacl_encode_desc *) desc;
5383bbe2efSAl Viro 	__be32 *p = elem;
54a257cdd0SAndreas Gruenbacher 
55a257cdd0SAndreas Gruenbacher 	struct posix_acl_entry *entry =
56a257cdd0SAndreas Gruenbacher 		&nfsacl_desc->acl->a_entries[nfsacl_desc->count++];
57a257cdd0SAndreas Gruenbacher 
58a257cdd0SAndreas Gruenbacher 	*p++ = htonl(entry->e_tag | nfsacl_desc->typeflag);
59a257cdd0SAndreas Gruenbacher 	switch(entry->e_tag) {
60a257cdd0SAndreas Gruenbacher 		case ACL_USER_OBJ:
61ddca4e17SEric W. Biederman 			*p++ = htonl(from_kuid(&init_user_ns, nfsacl_desc->uid));
62a257cdd0SAndreas Gruenbacher 			break;
63a257cdd0SAndreas Gruenbacher 		case ACL_GROUP_OBJ:
64ddca4e17SEric W. Biederman 			*p++ = htonl(from_kgid(&init_user_ns, nfsacl_desc->gid));
65a257cdd0SAndreas Gruenbacher 			break;
66a257cdd0SAndreas Gruenbacher 		case ACL_USER:
67ddca4e17SEric W. Biederman 			*p++ = htonl(from_kuid(&init_user_ns, entry->e_uid));
68ddca4e17SEric W. Biederman 			break;
69a257cdd0SAndreas Gruenbacher 		case ACL_GROUP:
70ddca4e17SEric W. Biederman 			*p++ = htonl(from_kgid(&init_user_ns, entry->e_gid));
71a257cdd0SAndreas Gruenbacher 			break;
72a257cdd0SAndreas Gruenbacher 		default:  /* Solaris depends on that! */
73a257cdd0SAndreas Gruenbacher 			*p++ = 0;
74a257cdd0SAndreas Gruenbacher 			break;
75a257cdd0SAndreas Gruenbacher 	}
76a257cdd0SAndreas Gruenbacher 	*p++ = htonl(entry->e_perm & S_IRWXO);
77a257cdd0SAndreas Gruenbacher 	return 0;
78a257cdd0SAndreas Gruenbacher }
79a257cdd0SAndreas Gruenbacher 
80731f3f48SChuck Lever /**
81731f3f48SChuck Lever  * nfsacl_encode - Encode an NFSv3 ACL
82731f3f48SChuck Lever  *
83731f3f48SChuck Lever  * @buf: destination xdr_buf to contain XDR encoded ACL
84731f3f48SChuck Lever  * @base: byte offset in xdr_buf where XDR'd ACL begins
85731f3f48SChuck Lever  * @inode: inode of file whose ACL this is
86731f3f48SChuck Lever  * @acl: posix_acl to encode
87731f3f48SChuck Lever  * @encode_entries: whether to encode ACEs as well
88731f3f48SChuck Lever  * @typeflag: ACL type: NFS_ACL_DEFAULT or zero
89731f3f48SChuck Lever  *
90731f3f48SChuck Lever  * Returns size of encoded ACL in bytes or a negative errno value.
91731f3f48SChuck Lever  */
nfsacl_encode(struct xdr_buf * buf,unsigned int base,struct inode * inode,struct posix_acl * acl,int encode_entries,int typeflag)92731f3f48SChuck Lever int nfsacl_encode(struct xdr_buf *buf, unsigned int base, struct inode *inode,
93a257cdd0SAndreas Gruenbacher 		  struct posix_acl *acl, int encode_entries, int typeflag)
94a257cdd0SAndreas Gruenbacher {
95a257cdd0SAndreas Gruenbacher 	int entries = (acl && acl->a_count) ? max_t(int, acl->a_count, 4) : 0;
96a257cdd0SAndreas Gruenbacher 	struct nfsacl_encode_desc nfsacl_desc = {
97a257cdd0SAndreas Gruenbacher 		.desc = {
98a257cdd0SAndreas Gruenbacher 			.elem_size = 12,
99a257cdd0SAndreas Gruenbacher 			.array_len = encode_entries ? entries : 0,
100a257cdd0SAndreas Gruenbacher 			.xcode = xdr_nfsace_encode,
101a257cdd0SAndreas Gruenbacher 		},
102a257cdd0SAndreas Gruenbacher 		.acl = acl,
103a257cdd0SAndreas Gruenbacher 		.typeflag = typeflag,
104a257cdd0SAndreas Gruenbacher 		.uid = inode->i_uid,
105a257cdd0SAndreas Gruenbacher 		.gid = inode->i_gid,
106a257cdd0SAndreas Gruenbacher 	};
107f61f6da0SChuck Lever 	struct nfsacl_simple_acl aclbuf;
108a257cdd0SAndreas Gruenbacher 	int err;
109a257cdd0SAndreas Gruenbacher 
110a257cdd0SAndreas Gruenbacher 	if (entries > NFS_ACL_MAX_ENTRIES ||
111a257cdd0SAndreas Gruenbacher 	    xdr_encode_word(buf, base, entries))
112a257cdd0SAndreas Gruenbacher 		return -EINVAL;
11322c1ea44SAndreas Gruenbacher 	if (encode_entries && acl && acl->a_count == 3) {
114f61f6da0SChuck Lever 		struct posix_acl *acl2 = &aclbuf.acl;
115f61f6da0SChuck Lever 
116f61f6da0SChuck Lever 		/* Avoid the use of posix_acl_alloc().  nfsacl_encode() is
117f61f6da0SChuck Lever 		 * invoked in contexts where a memory allocation failure is
118f61f6da0SChuck Lever 		 * fatal.  Fortunately this fake ACL is small enough to
119f61f6da0SChuck Lever 		 * construct on the stack. */
120f61f6da0SChuck Lever 		posix_acl_init(acl2, 4);
121f61f6da0SChuck Lever 
12222c1ea44SAndreas Gruenbacher 		/* Insert entries in canonical order: other orders seem
12322c1ea44SAndreas Gruenbacher 		 to confuse Solaris VxFS. */
12422c1ea44SAndreas Gruenbacher 		acl2->a_entries[0] = acl->a_entries[0];  /* ACL_USER_OBJ */
12522c1ea44SAndreas Gruenbacher 		acl2->a_entries[1] = acl->a_entries[1];  /* ACL_GROUP_OBJ */
12622c1ea44SAndreas Gruenbacher 		acl2->a_entries[2] = acl->a_entries[1];  /* ACL_MASK */
12722c1ea44SAndreas Gruenbacher 		acl2->a_entries[2].e_tag = ACL_MASK;
12822c1ea44SAndreas Gruenbacher 		acl2->a_entries[3] = acl->a_entries[2];  /* ACL_OTHER */
12922c1ea44SAndreas Gruenbacher 		nfsacl_desc.acl = acl2;
13022c1ea44SAndreas Gruenbacher 	}
131a257cdd0SAndreas Gruenbacher 	err = xdr_encode_array2(buf, base + 4, &nfsacl_desc.desc);
132a257cdd0SAndreas Gruenbacher 	if (!err)
133a257cdd0SAndreas Gruenbacher 		err = 8 + nfsacl_desc.desc.elem_size *
134a257cdd0SAndreas Gruenbacher 			  nfsacl_desc.desc.array_len;
135a257cdd0SAndreas Gruenbacher 	return err;
136a257cdd0SAndreas Gruenbacher }
13757b696fbSFabian Frederick EXPORT_SYMBOL_GPL(nfsacl_encode);
138a257cdd0SAndreas Gruenbacher 
139*8edc0648SChuck Lever /**
140*8edc0648SChuck Lever  * nfs_stream_encode_acl - Encode an NFSv3 ACL
141*8edc0648SChuck Lever  *
142*8edc0648SChuck Lever  * @xdr: an xdr_stream positioned to receive an encoded ACL
143*8edc0648SChuck Lever  * @inode: inode of file whose ACL this is
144*8edc0648SChuck Lever  * @acl: posix_acl to encode
145*8edc0648SChuck Lever  * @encode_entries: whether to encode ACEs as well
146*8edc0648SChuck Lever  * @typeflag: ACL type: NFS_ACL_DEFAULT or zero
147*8edc0648SChuck Lever  *
148*8edc0648SChuck Lever  * Return values:
149*8edc0648SChuck Lever  *   %false: The ACL could not be encoded
150*8edc0648SChuck Lever  *   %true: @xdr is advanced to the next available position
151*8edc0648SChuck Lever  */
nfs_stream_encode_acl(struct xdr_stream * xdr,struct inode * inode,struct posix_acl * acl,int encode_entries,int typeflag)152*8edc0648SChuck Lever bool nfs_stream_encode_acl(struct xdr_stream *xdr, struct inode *inode,
153*8edc0648SChuck Lever 			   struct posix_acl *acl, int encode_entries,
154*8edc0648SChuck Lever 			   int typeflag)
155*8edc0648SChuck Lever {
156*8edc0648SChuck Lever 	const size_t elem_size = XDR_UNIT * 3;
157*8edc0648SChuck Lever 	u32 entries = (acl && acl->a_count) ? max_t(int, acl->a_count, 4) : 0;
158*8edc0648SChuck Lever 	struct nfsacl_encode_desc nfsacl_desc = {
159*8edc0648SChuck Lever 		.desc = {
160*8edc0648SChuck Lever 			.elem_size = elem_size,
161*8edc0648SChuck Lever 			.array_len = encode_entries ? entries : 0,
162*8edc0648SChuck Lever 			.xcode = xdr_nfsace_encode,
163*8edc0648SChuck Lever 		},
164*8edc0648SChuck Lever 		.acl = acl,
165*8edc0648SChuck Lever 		.typeflag = typeflag,
166*8edc0648SChuck Lever 		.uid = inode->i_uid,
167*8edc0648SChuck Lever 		.gid = inode->i_gid,
168*8edc0648SChuck Lever 	};
169*8edc0648SChuck Lever 	struct nfsacl_simple_acl aclbuf;
170*8edc0648SChuck Lever 	unsigned int base;
171*8edc0648SChuck Lever 	int err;
172*8edc0648SChuck Lever 
173*8edc0648SChuck Lever 	if (entries > NFS_ACL_MAX_ENTRIES)
174*8edc0648SChuck Lever 		return false;
175*8edc0648SChuck Lever 	if (xdr_stream_encode_u32(xdr, entries) < 0)
176*8edc0648SChuck Lever 		return false;
177*8edc0648SChuck Lever 
178*8edc0648SChuck Lever 	if (encode_entries && acl && acl->a_count == 3) {
179*8edc0648SChuck Lever 		struct posix_acl *acl2 = &aclbuf.acl;
180*8edc0648SChuck Lever 
181*8edc0648SChuck Lever 		/* Avoid the use of posix_acl_alloc().  nfsacl_encode() is
182*8edc0648SChuck Lever 		 * invoked in contexts where a memory allocation failure is
183*8edc0648SChuck Lever 		 * fatal.  Fortunately this fake ACL is small enough to
184*8edc0648SChuck Lever 		 * construct on the stack. */
185*8edc0648SChuck Lever 		posix_acl_init(acl2, 4);
186*8edc0648SChuck Lever 
187*8edc0648SChuck Lever 		/* Insert entries in canonical order: other orders seem
188*8edc0648SChuck Lever 		 to confuse Solaris VxFS. */
189*8edc0648SChuck Lever 		acl2->a_entries[0] = acl->a_entries[0];  /* ACL_USER_OBJ */
190*8edc0648SChuck Lever 		acl2->a_entries[1] = acl->a_entries[1];  /* ACL_GROUP_OBJ */
191*8edc0648SChuck Lever 		acl2->a_entries[2] = acl->a_entries[1];  /* ACL_MASK */
192*8edc0648SChuck Lever 		acl2->a_entries[2].e_tag = ACL_MASK;
193*8edc0648SChuck Lever 		acl2->a_entries[3] = acl->a_entries[2];  /* ACL_OTHER */
194*8edc0648SChuck Lever 		nfsacl_desc.acl = acl2;
195*8edc0648SChuck Lever 	}
196*8edc0648SChuck Lever 
197*8edc0648SChuck Lever 	base = xdr_stream_pos(xdr);
198*8edc0648SChuck Lever 	if (!xdr_reserve_space(xdr, XDR_UNIT +
199*8edc0648SChuck Lever 			       elem_size * nfsacl_desc.desc.array_len))
200*8edc0648SChuck Lever 		return false;
201*8edc0648SChuck Lever 	err = xdr_encode_array2(xdr->buf, base, &nfsacl_desc.desc);
202*8edc0648SChuck Lever 	if (err)
203*8edc0648SChuck Lever 		return false;
204*8edc0648SChuck Lever 
205*8edc0648SChuck Lever 	return true;
206*8edc0648SChuck Lever }
207*8edc0648SChuck Lever EXPORT_SYMBOL_GPL(nfs_stream_encode_acl);
208*8edc0648SChuck Lever 
209*8edc0648SChuck Lever 
210a257cdd0SAndreas Gruenbacher struct nfsacl_decode_desc {
211a257cdd0SAndreas Gruenbacher 	struct xdr_array2_desc desc;
212a257cdd0SAndreas Gruenbacher 	unsigned int count;
213a257cdd0SAndreas Gruenbacher 	struct posix_acl *acl;
214a257cdd0SAndreas Gruenbacher };
215a257cdd0SAndreas Gruenbacher 
216a257cdd0SAndreas Gruenbacher static int
xdr_nfsace_decode(struct xdr_array2_desc * desc,void * elem)217a257cdd0SAndreas Gruenbacher xdr_nfsace_decode(struct xdr_array2_desc *desc, void *elem)
218a257cdd0SAndreas Gruenbacher {
219a257cdd0SAndreas Gruenbacher 	struct nfsacl_decode_desc *nfsacl_desc =
220a257cdd0SAndreas Gruenbacher 		(struct nfsacl_decode_desc *) desc;
22183bbe2efSAl Viro 	__be32 *p = elem;
222a257cdd0SAndreas Gruenbacher 	struct posix_acl_entry *entry;
223ddca4e17SEric W. Biederman 	unsigned int id;
224a257cdd0SAndreas Gruenbacher 
225a257cdd0SAndreas Gruenbacher 	if (!nfsacl_desc->acl) {
226a257cdd0SAndreas Gruenbacher 		if (desc->array_len > NFS_ACL_MAX_ENTRIES)
227a257cdd0SAndreas Gruenbacher 			return -EINVAL;
228a257cdd0SAndreas Gruenbacher 		nfsacl_desc->acl = posix_acl_alloc(desc->array_len, GFP_KERNEL);
229a257cdd0SAndreas Gruenbacher 		if (!nfsacl_desc->acl)
230a257cdd0SAndreas Gruenbacher 			return -ENOMEM;
231a257cdd0SAndreas Gruenbacher 		nfsacl_desc->count = 0;
232a257cdd0SAndreas Gruenbacher 	}
233a257cdd0SAndreas Gruenbacher 
234a257cdd0SAndreas Gruenbacher 	entry = &nfsacl_desc->acl->a_entries[nfsacl_desc->count++];
235a257cdd0SAndreas Gruenbacher 	entry->e_tag = ntohl(*p++) & ~NFS_ACL_DEFAULT;
236ddca4e17SEric W. Biederman 	id = ntohl(*p++);
237a257cdd0SAndreas Gruenbacher 	entry->e_perm = ntohl(*p++);
238a257cdd0SAndreas Gruenbacher 
239a257cdd0SAndreas Gruenbacher 	switch(entry->e_tag) {
240a257cdd0SAndreas Gruenbacher 		case ACL_USER:
241ddca4e17SEric W. Biederman 			entry->e_uid = make_kuid(&init_user_ns, id);
242ddca4e17SEric W. Biederman 			if (!uid_valid(entry->e_uid))
243ddca4e17SEric W. Biederman 				return -EINVAL;
244ddca4e17SEric W. Biederman 			break;
245a257cdd0SAndreas Gruenbacher 		case ACL_GROUP:
246ddca4e17SEric W. Biederman 			entry->e_gid = make_kgid(&init_user_ns, id);
247ddca4e17SEric W. Biederman 			if (!gid_valid(entry->e_gid))
248ddca4e17SEric W. Biederman 				return -EINVAL;
249ddca4e17SEric W. Biederman 			break;
250ddca4e17SEric W. Biederman 		case ACL_USER_OBJ:
251ddca4e17SEric W. Biederman 		case ACL_GROUP_OBJ:
252a257cdd0SAndreas Gruenbacher 		case ACL_OTHER:
253a257cdd0SAndreas Gruenbacher 			if (entry->e_perm & ~S_IRWXO)
254a257cdd0SAndreas Gruenbacher 				return -EINVAL;
255a257cdd0SAndreas Gruenbacher 			break;
256a257cdd0SAndreas Gruenbacher 		case ACL_MASK:
25725985edcSLucas De Marchi 			/* Solaris sometimes sets additional bits in the mask */
258a257cdd0SAndreas Gruenbacher 			entry->e_perm &= S_IRWXO;
259a257cdd0SAndreas Gruenbacher 			break;
260a257cdd0SAndreas Gruenbacher 		default:
261a257cdd0SAndreas Gruenbacher 			return -EINVAL;
262a257cdd0SAndreas Gruenbacher 	}
263a257cdd0SAndreas Gruenbacher 
264a257cdd0SAndreas Gruenbacher 	return 0;
265a257cdd0SAndreas Gruenbacher }
266a257cdd0SAndreas Gruenbacher 
267a257cdd0SAndreas Gruenbacher static int
cmp_acl_entry(const void * x,const void * y)268a257cdd0SAndreas Gruenbacher cmp_acl_entry(const void *x, const void *y)
269a257cdd0SAndreas Gruenbacher {
270a257cdd0SAndreas Gruenbacher 	const struct posix_acl_entry *a = x, *b = y;
271a257cdd0SAndreas Gruenbacher 
272a257cdd0SAndreas Gruenbacher 	if (a->e_tag != b->e_tag)
273a257cdd0SAndreas Gruenbacher 		return a->e_tag - b->e_tag;
274ddca4e17SEric W. Biederman 	else if ((a->e_tag == ACL_USER) && uid_gt(a->e_uid, b->e_uid))
275a257cdd0SAndreas Gruenbacher 		return 1;
276ddca4e17SEric W. Biederman 	else if ((a->e_tag == ACL_USER) && uid_lt(a->e_uid, b->e_uid))
277ddca4e17SEric W. Biederman 		return -1;
278ddca4e17SEric W. Biederman 	else if ((a->e_tag == ACL_GROUP) && gid_gt(a->e_gid, b->e_gid))
279ddca4e17SEric W. Biederman 		return 1;
280ddca4e17SEric W. Biederman 	else if ((a->e_tag == ACL_GROUP) && gid_lt(a->e_gid, b->e_gid))
281a257cdd0SAndreas Gruenbacher 		return -1;
282a257cdd0SAndreas Gruenbacher 	else
283a257cdd0SAndreas Gruenbacher 		return 0;
284a257cdd0SAndreas Gruenbacher }
285a257cdd0SAndreas Gruenbacher 
286a257cdd0SAndreas Gruenbacher /*
287a257cdd0SAndreas Gruenbacher  * Convert from a Solaris ACL to a POSIX 1003.1e draft 17 ACL.
288a257cdd0SAndreas Gruenbacher  */
289a257cdd0SAndreas Gruenbacher static int
posix_acl_from_nfsacl(struct posix_acl * acl)290a257cdd0SAndreas Gruenbacher posix_acl_from_nfsacl(struct posix_acl *acl)
291a257cdd0SAndreas Gruenbacher {
292a257cdd0SAndreas Gruenbacher 	struct posix_acl_entry *pa, *pe,
293a257cdd0SAndreas Gruenbacher 	       *group_obj = NULL, *mask = NULL;
294a257cdd0SAndreas Gruenbacher 
295a257cdd0SAndreas Gruenbacher 	if (!acl)
296a257cdd0SAndreas Gruenbacher 		return 0;
297a257cdd0SAndreas Gruenbacher 
298a257cdd0SAndreas Gruenbacher 	sort(acl->a_entries, acl->a_count, sizeof(struct posix_acl_entry),
299a257cdd0SAndreas Gruenbacher 	     cmp_acl_entry, NULL);
300a257cdd0SAndreas Gruenbacher 
301ddca4e17SEric W. Biederman 	/* Find the ACL_GROUP_OBJ and ACL_MASK entries. */
302a257cdd0SAndreas Gruenbacher 	FOREACH_ACL_ENTRY(pa, acl, pe) {
303a257cdd0SAndreas Gruenbacher 		switch(pa->e_tag) {
304a257cdd0SAndreas Gruenbacher 			case ACL_USER_OBJ:
305a257cdd0SAndreas Gruenbacher 				break;
306a257cdd0SAndreas Gruenbacher 			case ACL_GROUP_OBJ:
307a257cdd0SAndreas Gruenbacher 				group_obj = pa;
308a257cdd0SAndreas Gruenbacher 				break;
309a257cdd0SAndreas Gruenbacher 			case ACL_MASK:
310a257cdd0SAndreas Gruenbacher 				mask = pa;
311df561f66SGustavo A. R. Silva 				fallthrough;
312a257cdd0SAndreas Gruenbacher 			case ACL_OTHER:
313a257cdd0SAndreas Gruenbacher 				break;
314a257cdd0SAndreas Gruenbacher 		}
315a257cdd0SAndreas Gruenbacher 	}
316a257cdd0SAndreas Gruenbacher 	if (acl->a_count == 4 && group_obj && mask &&
317a257cdd0SAndreas Gruenbacher 	    mask->e_perm == group_obj->e_perm) {
318a257cdd0SAndreas Gruenbacher 		/* remove bogus ACL_MASK entry */
319a257cdd0SAndreas Gruenbacher 		memmove(mask, mask+1, (3 - (mask - acl->a_entries)) *
320a257cdd0SAndreas Gruenbacher 				      sizeof(struct posix_acl_entry));
321a257cdd0SAndreas Gruenbacher 		acl->a_count = 3;
322a257cdd0SAndreas Gruenbacher 	}
323a257cdd0SAndreas Gruenbacher 	return 0;
324a257cdd0SAndreas Gruenbacher }
325a257cdd0SAndreas Gruenbacher 
326731f3f48SChuck Lever /**
327731f3f48SChuck Lever  * nfsacl_decode - Decode an NFSv3 ACL
328731f3f48SChuck Lever  *
329731f3f48SChuck Lever  * @buf: xdr_buf containing XDR'd ACL data to decode
330731f3f48SChuck Lever  * @base: byte offset in xdr_buf where XDR'd ACL begins
331731f3f48SChuck Lever  * @aclcnt: count of ACEs in decoded posix_acl
332731f3f48SChuck Lever  * @pacl: buffer in which to place decoded posix_acl
333731f3f48SChuck Lever  *
334731f3f48SChuck Lever  * Returns the length of the decoded ACL in bytes, or a negative errno value.
335731f3f48SChuck Lever  */
nfsacl_decode(struct xdr_buf * buf,unsigned int base,unsigned int * aclcnt,struct posix_acl ** pacl)336731f3f48SChuck Lever int nfsacl_decode(struct xdr_buf *buf, unsigned int base, unsigned int *aclcnt,
337a257cdd0SAndreas Gruenbacher 		  struct posix_acl **pacl)
338a257cdd0SAndreas Gruenbacher {
339a257cdd0SAndreas Gruenbacher 	struct nfsacl_decode_desc nfsacl_desc = {
340a257cdd0SAndreas Gruenbacher 		.desc = {
341a257cdd0SAndreas Gruenbacher 			.elem_size = 12,
342a257cdd0SAndreas Gruenbacher 			.xcode = pacl ? xdr_nfsace_decode : NULL,
343a257cdd0SAndreas Gruenbacher 		},
344a257cdd0SAndreas Gruenbacher 	};
345a257cdd0SAndreas Gruenbacher 	u32 entries;
346a257cdd0SAndreas Gruenbacher 	int err;
347a257cdd0SAndreas Gruenbacher 
348a257cdd0SAndreas Gruenbacher 	if (xdr_decode_word(buf, base, &entries) ||
349a257cdd0SAndreas Gruenbacher 	    entries > NFS_ACL_MAX_ENTRIES)
350a257cdd0SAndreas Gruenbacher 		return -EINVAL;
35158fcb8dfSTrond Myklebust 	nfsacl_desc.desc.array_maxlen = entries;
352a257cdd0SAndreas Gruenbacher 	err = xdr_decode_array2(buf, base + 4, &nfsacl_desc.desc);
353a257cdd0SAndreas Gruenbacher 	if (err)
354a257cdd0SAndreas Gruenbacher 		return err;
355a257cdd0SAndreas Gruenbacher 	if (pacl) {
356a257cdd0SAndreas Gruenbacher 		if (entries != nfsacl_desc.desc.array_len ||
357a257cdd0SAndreas Gruenbacher 		    posix_acl_from_nfsacl(nfsacl_desc.acl) != 0) {
358a257cdd0SAndreas Gruenbacher 			posix_acl_release(nfsacl_desc.acl);
359a257cdd0SAndreas Gruenbacher 			return -EINVAL;
360a257cdd0SAndreas Gruenbacher 		}
361a257cdd0SAndreas Gruenbacher 		*pacl = nfsacl_desc.acl;
362a257cdd0SAndreas Gruenbacher 	}
363a257cdd0SAndreas Gruenbacher 	if (aclcnt)
364a257cdd0SAndreas Gruenbacher 		*aclcnt = entries;
365a257cdd0SAndreas Gruenbacher 	return 8 + nfsacl_desc.desc.elem_size *
366a257cdd0SAndreas Gruenbacher 		   nfsacl_desc.desc.array_len;
367a257cdd0SAndreas Gruenbacher }
36857b696fbSFabian Frederick EXPORT_SYMBOL_GPL(nfsacl_decode);
3696bb844b4SChuck Lever 
3706bb844b4SChuck Lever /**
3716bb844b4SChuck Lever  * nfs_stream_decode_acl - Decode an NFSv3 ACL
3726bb844b4SChuck Lever  *
3736bb844b4SChuck Lever  * @xdr: an xdr_stream positioned at an encoded ACL
3746bb844b4SChuck Lever  * @aclcnt: OUT: count of ACEs in decoded posix_acl
3756bb844b4SChuck Lever  * @pacl: OUT: a dynamically-allocated buffer containing the decoded posix_acl
3766bb844b4SChuck Lever  *
3776bb844b4SChuck Lever  * Return values:
3786bb844b4SChuck Lever  *   %false: The encoded ACL is not valid
3796bb844b4SChuck Lever  *   %true: @pacl contains a decoded ACL, and @xdr is advanced
3806bb844b4SChuck Lever  *
3816bb844b4SChuck Lever  * On a successful return, caller must release *pacl using posix_acl_release().
3826bb844b4SChuck Lever  */
nfs_stream_decode_acl(struct xdr_stream * xdr,unsigned int * aclcnt,struct posix_acl ** pacl)3836bb844b4SChuck Lever bool nfs_stream_decode_acl(struct xdr_stream *xdr, unsigned int *aclcnt,
3846bb844b4SChuck Lever 			   struct posix_acl **pacl)
3856bb844b4SChuck Lever {
3866bb844b4SChuck Lever 	const size_t elem_size = XDR_UNIT * 3;
3876bb844b4SChuck Lever 	struct nfsacl_decode_desc nfsacl_desc = {
3886bb844b4SChuck Lever 		.desc = {
3896bb844b4SChuck Lever 			.elem_size = elem_size,
3906bb844b4SChuck Lever 			.xcode = pacl ? xdr_nfsace_decode : NULL,
3916bb844b4SChuck Lever 		},
3926bb844b4SChuck Lever 	};
3936bb844b4SChuck Lever 	unsigned int base;
3946bb844b4SChuck Lever 	u32 entries;
3956bb844b4SChuck Lever 
3966bb844b4SChuck Lever 	if (xdr_stream_decode_u32(xdr, &entries) < 0)
3976bb844b4SChuck Lever 		return false;
3986bb844b4SChuck Lever 	if (entries > NFS_ACL_MAX_ENTRIES)
3996bb844b4SChuck Lever 		return false;
4006bb844b4SChuck Lever 
4016bb844b4SChuck Lever 	base = xdr_stream_pos(xdr);
4026bb844b4SChuck Lever 	if (!xdr_inline_decode(xdr, XDR_UNIT + elem_size * entries))
4036bb844b4SChuck Lever 		return false;
4046bb844b4SChuck Lever 	nfsacl_desc.desc.array_maxlen = entries;
4056bb844b4SChuck Lever 	if (xdr_decode_array2(xdr->buf, base, &nfsacl_desc.desc))
4066bb844b4SChuck Lever 		return false;
4076bb844b4SChuck Lever 
4086bb844b4SChuck Lever 	if (pacl) {
4096bb844b4SChuck Lever 		if (entries != nfsacl_desc.desc.array_len ||
4106bb844b4SChuck Lever 		    posix_acl_from_nfsacl(nfsacl_desc.acl) != 0) {
4116bb844b4SChuck Lever 			posix_acl_release(nfsacl_desc.acl);
4126bb844b4SChuck Lever 			return false;
4136bb844b4SChuck Lever 		}
4146bb844b4SChuck Lever 		*pacl = nfsacl_desc.acl;
4156bb844b4SChuck Lever 	}
4166bb844b4SChuck Lever 	if (aclcnt)
4176bb844b4SChuck Lever 		*aclcnt = entries;
4186bb844b4SChuck Lever 	return true;
4196bb844b4SChuck Lever }
4206bb844b4SChuck Lever EXPORT_SYMBOL_GPL(nfs_stream_decode_acl);
421