1c1d7c514SDavid Sterba // SPDX-License-Identifier: GPL-2.0 272b28077SLiu Bo /* 372b28077SLiu Bo * Copyright (C) 2017 Oracle. All rights reserved. 472b28077SLiu Bo */ 572b28077SLiu Bo 672b28077SLiu Bo #include <linux/types.h> 772b28077SLiu Bo #include "btrfs-tests.h" 872b28077SLiu Bo #include "../ctree.h" 972b28077SLiu Bo 1072b28077SLiu Bo static void free_extent_map_tree(struct extent_map_tree *em_tree) 1172b28077SLiu Bo { 1272b28077SLiu Bo struct extent_map *em; 1372b28077SLiu Bo struct rb_node *node; 1472b28077SLiu Bo 1507e1ce09SLiu Bo while (!RB_EMPTY_ROOT(&em_tree->map.rb_root)) { 1607e1ce09SLiu Bo node = rb_first_cached(&em_tree->map); 1772b28077SLiu Bo em = rb_entry(node, struct extent_map, rb_node); 1872b28077SLiu Bo remove_extent_mapping(em_tree, em); 1972b28077SLiu Bo 2072b28077SLiu Bo #ifdef CONFIG_BTRFS_DEBUG 2172b28077SLiu Bo if (refcount_read(&em->refs) != 1) { 223c7251f2SDavid Sterba test_err( 233c7251f2SDavid Sterba "em leak: em (start 0x%llx len 0x%llx block_start 0x%llx block_len 0x%llx) refs %d", 2472b28077SLiu Bo em->start, em->len, em->block_start, 2572b28077SLiu Bo em->block_len, refcount_read(&em->refs)); 2672b28077SLiu Bo 2772b28077SLiu Bo refcount_set(&em->refs, 1); 2872b28077SLiu Bo } 2972b28077SLiu Bo #endif 3072b28077SLiu Bo free_extent_map(em); 3172b28077SLiu Bo } 3272b28077SLiu Bo } 3372b28077SLiu Bo 3472b28077SLiu Bo /* 3572b28077SLiu Bo * Test scenario: 3672b28077SLiu Bo * 3772b28077SLiu Bo * Suppose that no extent map has been loaded into memory yet, there is a file 3872b28077SLiu Bo * extent [0, 16K), followed by another file extent [16K, 20K), two dio reads 3972b28077SLiu Bo * are entering btrfs_get_extent() concurrently, t1 is reading [8K, 16K), t2 is 4072b28077SLiu Bo * reading [0, 8K) 4172b28077SLiu Bo * 4272b28077SLiu Bo * t1 t2 4372b28077SLiu Bo * btrfs_get_extent() btrfs_get_extent() 4472b28077SLiu Bo * -> lookup_extent_mapping() ->lookup_extent_mapping() 4572b28077SLiu Bo * -> add_extent_mapping(0, 16K) 4672b28077SLiu Bo * -> return em 4772b28077SLiu Bo * ->add_extent_mapping(0, 16K) 4872b28077SLiu Bo * -> #handle -EEXIST 4972b28077SLiu Bo */ 50488f6730SDavid Sterba static int test_case_1(struct btrfs_fs_info *fs_info, 510e08eb9bSDavid Sterba struct extent_map_tree *em_tree) 5272b28077SLiu Bo { 5372b28077SLiu Bo struct extent_map *em; 5472b28077SLiu Bo u64 start = 0; 5572b28077SLiu Bo u64 len = SZ_8K; 5672b28077SLiu Bo int ret; 5772b28077SLiu Bo 5872b28077SLiu Bo em = alloc_extent_map(); 5972b28077SLiu Bo if (!em) 60488f6730SDavid Sterba return -ENOMEM; 6172b28077SLiu Bo 6272b28077SLiu Bo /* Add [0, 16K) */ 6372b28077SLiu Bo em->start = 0; 6472b28077SLiu Bo em->len = SZ_16K; 6572b28077SLiu Bo em->block_start = 0; 6672b28077SLiu Bo em->block_len = SZ_16K; 6772b28077SLiu Bo ret = add_extent_mapping(em_tree, em, 0); 68*d7de4b08SDavid Sterba if (ret < 0) { 69*d7de4b08SDavid Sterba test_err("cannot add extent range [0, 16K)"); 70*d7de4b08SDavid Sterba goto out; 71*d7de4b08SDavid Sterba } 7272b28077SLiu Bo free_extent_map(em); 7372b28077SLiu Bo 7472b28077SLiu Bo /* Add [16K, 20K) following [0, 16K) */ 7572b28077SLiu Bo em = alloc_extent_map(); 76488f6730SDavid Sterba if (!em) { 77488f6730SDavid Sterba ret = -ENOMEM; 7872b28077SLiu Bo goto out; 79488f6730SDavid Sterba } 8072b28077SLiu Bo 8172b28077SLiu Bo em->start = SZ_16K; 8272b28077SLiu Bo em->len = SZ_4K; 8372b28077SLiu Bo em->block_start = SZ_32K; /* avoid merging */ 8472b28077SLiu Bo em->block_len = SZ_4K; 8572b28077SLiu Bo ret = add_extent_mapping(em_tree, em, 0); 86*d7de4b08SDavid Sterba if (ret < 0) { 87*d7de4b08SDavid Sterba test_err("cannot add extent range [16K, 20K)"); 88*d7de4b08SDavid Sterba goto out; 89*d7de4b08SDavid Sterba } 9072b28077SLiu Bo free_extent_map(em); 9172b28077SLiu Bo 9272b28077SLiu Bo em = alloc_extent_map(); 93488f6730SDavid Sterba if (!em) { 94488f6730SDavid Sterba ret = -ENOMEM; 9572b28077SLiu Bo goto out; 96488f6730SDavid Sterba } 9772b28077SLiu Bo 9872b28077SLiu Bo /* Add [0, 8K), should return [0, 16K) instead. */ 9972b28077SLiu Bo em->start = start; 10072b28077SLiu Bo em->len = len; 10172b28077SLiu Bo em->block_start = start; 10272b28077SLiu Bo em->block_len = len; 103f46b24c9SDavid Sterba ret = btrfs_add_extent_mapping(fs_info, em_tree, &em, em->start, em->len); 104*d7de4b08SDavid Sterba if (ret) { 1053c7251f2SDavid Sterba test_err("case1 [%llu %llu]: ret %d", start, start + len, ret); 106*d7de4b08SDavid Sterba goto out; 107*d7de4b08SDavid Sterba } 10872b28077SLiu Bo if (em && 10972b28077SLiu Bo (em->start != 0 || extent_map_end(em) != SZ_16K || 110*d7de4b08SDavid Sterba em->block_start != 0 || em->block_len != SZ_16K)) { 1113c7251f2SDavid Sterba test_err( 1123c7251f2SDavid Sterba "case1 [%llu %llu]: ret %d return a wrong em (start %llu len %llu block_start %llu block_len %llu", 11372b28077SLiu Bo start, start + len, ret, em->start, em->len, 11472b28077SLiu Bo em->block_start, em->block_len); 115*d7de4b08SDavid Sterba ret = -EINVAL; 116*d7de4b08SDavid Sterba } 11772b28077SLiu Bo free_extent_map(em); 11872b28077SLiu Bo out: 11972b28077SLiu Bo free_extent_map_tree(em_tree); 120488f6730SDavid Sterba 121488f6730SDavid Sterba return ret; 12272b28077SLiu Bo } 12372b28077SLiu Bo 12472b28077SLiu Bo /* 12572b28077SLiu Bo * Test scenario: 12672b28077SLiu Bo * 12772b28077SLiu Bo * Reading the inline ending up with EEXIST, ie. read an inline 12872b28077SLiu Bo * extent and discard page cache and read it again. 12972b28077SLiu Bo */ 130488f6730SDavid Sterba static int test_case_2(struct btrfs_fs_info *fs_info, 1310e08eb9bSDavid Sterba struct extent_map_tree *em_tree) 13272b28077SLiu Bo { 13372b28077SLiu Bo struct extent_map *em; 13472b28077SLiu Bo int ret; 13572b28077SLiu Bo 13672b28077SLiu Bo em = alloc_extent_map(); 13772b28077SLiu Bo if (!em) 138488f6730SDavid Sterba return -ENOMEM; 13972b28077SLiu Bo 14072b28077SLiu Bo /* Add [0, 1K) */ 14172b28077SLiu Bo em->start = 0; 14272b28077SLiu Bo em->len = SZ_1K; 14372b28077SLiu Bo em->block_start = EXTENT_MAP_INLINE; 14472b28077SLiu Bo em->block_len = (u64)-1; 14572b28077SLiu Bo ret = add_extent_mapping(em_tree, em, 0); 14672b28077SLiu Bo ASSERT(ret == 0); 14772b28077SLiu Bo free_extent_map(em); 14872b28077SLiu Bo 14972b28077SLiu Bo /* Add [4K, 4K) following [0, 1K) */ 15072b28077SLiu Bo em = alloc_extent_map(); 151488f6730SDavid Sterba if (!em) { 152488f6730SDavid Sterba ret = -ENOMEM; 15372b28077SLiu Bo goto out; 154488f6730SDavid Sterba } 15572b28077SLiu Bo 15672b28077SLiu Bo em->start = SZ_4K; 15772b28077SLiu Bo em->len = SZ_4K; 15872b28077SLiu Bo em->block_start = SZ_4K; 15972b28077SLiu Bo em->block_len = SZ_4K; 16072b28077SLiu Bo ret = add_extent_mapping(em_tree, em, 0); 16172b28077SLiu Bo ASSERT(ret == 0); 16272b28077SLiu Bo free_extent_map(em); 16372b28077SLiu Bo 16472b28077SLiu Bo em = alloc_extent_map(); 165488f6730SDavid Sterba if (!em) { 166488f6730SDavid Sterba ret = -ENOMEM; 16772b28077SLiu Bo goto out; 168488f6730SDavid Sterba } 16972b28077SLiu Bo 17072b28077SLiu Bo /* Add [0, 1K) */ 17172b28077SLiu Bo em->start = 0; 17272b28077SLiu Bo em->len = SZ_1K; 17372b28077SLiu Bo em->block_start = EXTENT_MAP_INLINE; 17472b28077SLiu Bo em->block_len = (u64)-1; 175f46b24c9SDavid Sterba ret = btrfs_add_extent_mapping(fs_info, em_tree, &em, em->start, em->len); 17672b28077SLiu Bo if (ret) 1773c7251f2SDavid Sterba test_err("case2 [0 1K]: ret %d", ret); 17872b28077SLiu Bo if (em && 17972b28077SLiu Bo (em->start != 0 || extent_map_end(em) != SZ_1K || 18072b28077SLiu Bo em->block_start != EXTENT_MAP_INLINE || em->block_len != (u64)-1)) 1813c7251f2SDavid Sterba test_err( 1823c7251f2SDavid Sterba "case2 [0 1K]: ret %d return a wrong em (start %llu len %llu block_start %llu block_len %llu", 18372b28077SLiu Bo ret, em->start, em->len, em->block_start, 18472b28077SLiu Bo em->block_len); 18572b28077SLiu Bo free_extent_map(em); 186488f6730SDavid Sterba ret = 0; 18772b28077SLiu Bo out: 18872b28077SLiu Bo /* free memory */ 18972b28077SLiu Bo free_extent_map_tree(em_tree); 190488f6730SDavid Sterba 191488f6730SDavid Sterba return ret; 19272b28077SLiu Bo } 19372b28077SLiu Bo 194488f6730SDavid Sterba static int __test_case_3(struct btrfs_fs_info *fs_info, 1950e08eb9bSDavid Sterba struct extent_map_tree *em_tree, u64 start) 196fd87526fSLiu Bo { 197fd87526fSLiu Bo struct extent_map *em; 198fd87526fSLiu Bo u64 len = SZ_4K; 199fd87526fSLiu Bo int ret; 200fd87526fSLiu Bo 201fd87526fSLiu Bo em = alloc_extent_map(); 202fd87526fSLiu Bo if (!em) 203488f6730SDavid Sterba return -ENOMEM; 204fd87526fSLiu Bo 205fd87526fSLiu Bo /* Add [4K, 8K) */ 206fd87526fSLiu Bo em->start = SZ_4K; 207fd87526fSLiu Bo em->len = SZ_4K; 208fd87526fSLiu Bo em->block_start = SZ_4K; 209fd87526fSLiu Bo em->block_len = SZ_4K; 210fd87526fSLiu Bo ret = add_extent_mapping(em_tree, em, 0); 211fd87526fSLiu Bo ASSERT(ret == 0); 212fd87526fSLiu Bo free_extent_map(em); 213fd87526fSLiu Bo 214fd87526fSLiu Bo em = alloc_extent_map(); 215488f6730SDavid Sterba if (!em) { 216488f6730SDavid Sterba ret = -ENOMEM; 217fd87526fSLiu Bo goto out; 218488f6730SDavid Sterba } 219fd87526fSLiu Bo 220fd87526fSLiu Bo /* Add [0, 16K) */ 221fd87526fSLiu Bo em->start = 0; 222fd87526fSLiu Bo em->len = SZ_16K; 223fd87526fSLiu Bo em->block_start = 0; 224fd87526fSLiu Bo em->block_len = SZ_16K; 225f46b24c9SDavid Sterba ret = btrfs_add_extent_mapping(fs_info, em_tree, &em, start, len); 226fd87526fSLiu Bo if (ret) 2273c7251f2SDavid Sterba test_err("case3 [0x%llx 0x%llx): ret %d", 228fd87526fSLiu Bo start, start + len, ret); 229fd87526fSLiu Bo /* 230fd87526fSLiu Bo * Since bytes within em are contiguous, em->block_start is identical to 231fd87526fSLiu Bo * em->start. 232fd87526fSLiu Bo */ 233fd87526fSLiu Bo if (em && 234fd87526fSLiu Bo (start < em->start || start + len > extent_map_end(em) || 235fd87526fSLiu Bo em->start != em->block_start || em->len != em->block_len)) 2363c7251f2SDavid Sterba test_err( 2373c7251f2SDavid Sterba "case3 [0x%llx 0x%llx): ret %d em (start 0x%llx len 0x%llx block_start 0x%llx block_len 0x%llx)", 238fd87526fSLiu Bo start, start + len, ret, em->start, em->len, 239fd87526fSLiu Bo em->block_start, em->block_len); 240fd87526fSLiu Bo free_extent_map(em); 241488f6730SDavid Sterba ret = 0; 242fd87526fSLiu Bo out: 243fd87526fSLiu Bo /* free memory */ 244fd87526fSLiu Bo free_extent_map_tree(em_tree); 245488f6730SDavid Sterba 246488f6730SDavid Sterba return ret; 247fd87526fSLiu Bo } 248fd87526fSLiu Bo 249fd87526fSLiu Bo /* 250fd87526fSLiu Bo * Test scenario: 251fd87526fSLiu Bo * 252fd87526fSLiu Bo * Suppose that no extent map has been loaded into memory yet. 253fd87526fSLiu Bo * There is a file extent [0, 16K), two jobs are running concurrently 254fd87526fSLiu Bo * against it, t1 is buffered writing to [4K, 8K) and t2 is doing dio 255fd87526fSLiu Bo * read from [0, 4K) or [8K, 12K) or [12K, 16K). 256fd87526fSLiu Bo * 257fd87526fSLiu Bo * t1 goes ahead of t2 and adds em [4K, 8K) into tree. 258fd87526fSLiu Bo * 259fd87526fSLiu Bo * t1 t2 260fd87526fSLiu Bo * cow_file_range() btrfs_get_extent() 261fd87526fSLiu Bo * -> lookup_extent_mapping() 262fd87526fSLiu Bo * -> add_extent_mapping() 263fd87526fSLiu Bo * -> add_extent_mapping() 264fd87526fSLiu Bo */ 2650e08eb9bSDavid Sterba static void test_case_3(struct btrfs_fs_info *fs_info, 2660e08eb9bSDavid Sterba struct extent_map_tree *em_tree) 267fd87526fSLiu Bo { 2680e08eb9bSDavid Sterba __test_case_3(fs_info, em_tree, 0); 2690e08eb9bSDavid Sterba __test_case_3(fs_info, em_tree, SZ_8K); 2700e08eb9bSDavid Sterba __test_case_3(fs_info, em_tree, (12 * 1024ULL)); 271fd87526fSLiu Bo } 272fd87526fSLiu Bo 273488f6730SDavid Sterba static int __test_case_4(struct btrfs_fs_info *fs_info, 2740e08eb9bSDavid Sterba struct extent_map_tree *em_tree, u64 start) 275cd77f4f8SLiu Bo { 276cd77f4f8SLiu Bo struct extent_map *em; 277cd77f4f8SLiu Bo u64 len = SZ_4K; 278cd77f4f8SLiu Bo int ret; 279cd77f4f8SLiu Bo 280cd77f4f8SLiu Bo em = alloc_extent_map(); 281cd77f4f8SLiu Bo if (!em) 282488f6730SDavid Sterba return -ENOMEM; 283cd77f4f8SLiu Bo 284cd77f4f8SLiu Bo /* Add [0K, 8K) */ 285cd77f4f8SLiu Bo em->start = 0; 286cd77f4f8SLiu Bo em->len = SZ_8K; 287cd77f4f8SLiu Bo em->block_start = 0; 288cd77f4f8SLiu Bo em->block_len = SZ_8K; 289cd77f4f8SLiu Bo ret = add_extent_mapping(em_tree, em, 0); 290cd77f4f8SLiu Bo ASSERT(ret == 0); 291cd77f4f8SLiu Bo free_extent_map(em); 292cd77f4f8SLiu Bo 293cd77f4f8SLiu Bo em = alloc_extent_map(); 294488f6730SDavid Sterba if (!em) { 295488f6730SDavid Sterba ret = -ENOMEM; 296cd77f4f8SLiu Bo goto out; 297488f6730SDavid Sterba } 298cd77f4f8SLiu Bo 299cd77f4f8SLiu Bo /* Add [8K, 24K) */ 300cd77f4f8SLiu Bo em->start = SZ_8K; 301cd77f4f8SLiu Bo em->len = 24 * 1024ULL; 302cd77f4f8SLiu Bo em->block_start = SZ_16K; /* avoid merging */ 303cd77f4f8SLiu Bo em->block_len = 24 * 1024ULL; 304cd77f4f8SLiu Bo ret = add_extent_mapping(em_tree, em, 0); 305cd77f4f8SLiu Bo ASSERT(ret == 0); 306cd77f4f8SLiu Bo free_extent_map(em); 307cd77f4f8SLiu Bo 308cd77f4f8SLiu Bo em = alloc_extent_map(); 309488f6730SDavid Sterba if (!em) { 310488f6730SDavid Sterba ret = -ENOMEM; 311cd77f4f8SLiu Bo goto out; 312488f6730SDavid Sterba } 313cd77f4f8SLiu Bo /* Add [0K, 32K) */ 314cd77f4f8SLiu Bo em->start = 0; 315cd77f4f8SLiu Bo em->len = SZ_32K; 316cd77f4f8SLiu Bo em->block_start = 0; 317cd77f4f8SLiu Bo em->block_len = SZ_32K; 318f46b24c9SDavid Sterba ret = btrfs_add_extent_mapping(fs_info, em_tree, &em, start, len); 319cd77f4f8SLiu Bo if (ret) 3203c7251f2SDavid Sterba test_err("case4 [0x%llx 0x%llx): ret %d", 321cd77f4f8SLiu Bo start, len, ret); 322cd77f4f8SLiu Bo if (em && 323cd77f4f8SLiu Bo (start < em->start || start + len > extent_map_end(em))) 3243c7251f2SDavid Sterba test_err( 3253c7251f2SDavid Sterba "case4 [0x%llx 0x%llx): ret %d, added wrong em (start 0x%llx len 0x%llx block_start 0x%llx block_len 0x%llx)", 326cd77f4f8SLiu Bo start, len, ret, em->start, em->len, em->block_start, 327cd77f4f8SLiu Bo em->block_len); 328cd77f4f8SLiu Bo free_extent_map(em); 329488f6730SDavid Sterba ret = 0; 330cd77f4f8SLiu Bo out: 331cd77f4f8SLiu Bo /* free memory */ 332cd77f4f8SLiu Bo free_extent_map_tree(em_tree); 333488f6730SDavid Sterba 334488f6730SDavid Sterba return ret; 335cd77f4f8SLiu Bo } 336cd77f4f8SLiu Bo 337cd77f4f8SLiu Bo /* 338cd77f4f8SLiu Bo * Test scenario: 339cd77f4f8SLiu Bo * 340cd77f4f8SLiu Bo * Suppose that no extent map has been loaded into memory yet. 341cd77f4f8SLiu Bo * There is a file extent [0, 32K), two jobs are running concurrently 342cd77f4f8SLiu Bo * against it, t1 is doing dio write to [8K, 32K) and t2 is doing dio 343cd77f4f8SLiu Bo * read from [0, 4K) or [4K, 8K). 344cd77f4f8SLiu Bo * 345cd77f4f8SLiu Bo * t1 goes ahead of t2 and splits em [0, 32K) to em [0K, 8K) and [8K 32K). 346cd77f4f8SLiu Bo * 347cd77f4f8SLiu Bo * t1 t2 348cd77f4f8SLiu Bo * btrfs_get_blocks_direct() btrfs_get_blocks_direct() 349cd77f4f8SLiu Bo * -> btrfs_get_extent() -> btrfs_get_extent() 350cd77f4f8SLiu Bo * -> lookup_extent_mapping() 351cd77f4f8SLiu Bo * -> add_extent_mapping() -> lookup_extent_mapping() 352cd77f4f8SLiu Bo * # load [0, 32K) 353cd77f4f8SLiu Bo * -> btrfs_new_extent_direct() 354cd77f4f8SLiu Bo * -> btrfs_drop_extent_cache() 355cd77f4f8SLiu Bo * # split [0, 32K) 356cd77f4f8SLiu Bo * -> add_extent_mapping() 357cd77f4f8SLiu Bo * # add [8K, 32K) 358cd77f4f8SLiu Bo * -> add_extent_mapping() 359cd77f4f8SLiu Bo * # handle -EEXIST when adding 360cd77f4f8SLiu Bo * # [0, 32K) 361cd77f4f8SLiu Bo */ 3620e08eb9bSDavid Sterba static void test_case_4(struct btrfs_fs_info *fs_info, 3630e08eb9bSDavid Sterba struct extent_map_tree *em_tree) 364cd77f4f8SLiu Bo { 3650e08eb9bSDavid Sterba __test_case_4(fs_info, em_tree, 0); 3660e08eb9bSDavid Sterba __test_case_4(fs_info, em_tree, SZ_4K); 367cd77f4f8SLiu Bo } 368cd77f4f8SLiu Bo 36997dc231eSColin Ian King int btrfs_test_extent_map(void) 37072b28077SLiu Bo { 3710e08eb9bSDavid Sterba struct btrfs_fs_info *fs_info = NULL; 37272b28077SLiu Bo struct extent_map_tree *em_tree; 373488f6730SDavid Sterba int ret = 0; 37472b28077SLiu Bo 375315b76b4SDavid Sterba test_msg("running extent_map tests"); 37672b28077SLiu Bo 3770e08eb9bSDavid Sterba /* 3780e08eb9bSDavid Sterba * Note: the fs_info is not set up completely, we only need 3790e08eb9bSDavid Sterba * fs_info::fsid for the tracepoint. 3800e08eb9bSDavid Sterba */ 3810e08eb9bSDavid Sterba fs_info = btrfs_alloc_dummy_fs_info(PAGE_SIZE, PAGE_SIZE); 3820e08eb9bSDavid Sterba if (!fs_info) { 38337b2a7bcSDavid Sterba test_std_err(TEST_ALLOC_FS_INFO); 3840e08eb9bSDavid Sterba return -ENOMEM; 3850e08eb9bSDavid Sterba } 3860e08eb9bSDavid Sterba 38772b28077SLiu Bo em_tree = kzalloc(sizeof(*em_tree), GFP_KERNEL); 388488f6730SDavid Sterba if (!em_tree) { 389488f6730SDavid Sterba ret = -ENOMEM; 3900e08eb9bSDavid Sterba goto out; 391488f6730SDavid Sterba } 39272b28077SLiu Bo 39372b28077SLiu Bo extent_map_tree_init(em_tree); 39472b28077SLiu Bo 3950e08eb9bSDavid Sterba test_case_1(fs_info, em_tree); 3960e08eb9bSDavid Sterba test_case_2(fs_info, em_tree); 3970e08eb9bSDavid Sterba test_case_3(fs_info, em_tree); 3980e08eb9bSDavid Sterba test_case_4(fs_info, em_tree); 39972b28077SLiu Bo 40072b28077SLiu Bo kfree(em_tree); 4010e08eb9bSDavid Sterba out: 4020e08eb9bSDavid Sterba btrfs_free_dummy_fs_info(fs_info); 4030e08eb9bSDavid Sterba 404488f6730SDavid Sterba return ret; 40572b28077SLiu Bo } 406