xref: /openbmc/linux/fs/afs/addr_list.c (revision 8dd06ef34b6e2f41b29fbf5fc1663780f2524285)
1b4d0d230SThomas Gleixner // SPDX-License-Identifier: GPL-2.0-or-later
28b2a464cSDavid Howells /* Server address list management
38b2a464cSDavid Howells  *
48b2a464cSDavid Howells  * Copyright (C) 2017 Red Hat, Inc. All Rights Reserved.
58b2a464cSDavid Howells  * Written by David Howells (dhowells@redhat.com)
68b2a464cSDavid Howells  */
78b2a464cSDavid Howells 
88b2a464cSDavid Howells #include <linux/slab.h>
98b2a464cSDavid Howells #include <linux/ctype.h>
108b2a464cSDavid Howells #include <linux/dns_resolver.h>
118b2a464cSDavid Howells #include <linux/inet.h>
128b2a464cSDavid Howells #include <keys/rxrpc-type.h>
138b2a464cSDavid Howells #include "internal.h"
148b2a464cSDavid Howells #include "afs_fs.h"
158b2a464cSDavid Howells 
168b2a464cSDavid Howells /*
178b2a464cSDavid Howells  * Release an address list.
188b2a464cSDavid Howells  */
afs_put_addrlist(struct afs_addr_list * alist)198b2a464cSDavid Howells void afs_put_addrlist(struct afs_addr_list *alist)
208b2a464cSDavid Howells {
218b2a464cSDavid Howells 	if (alist && refcount_dec_and_test(&alist->usage))
22*ddd2b85fSJann Horn 		kfree_rcu(alist, rcu);
238b2a464cSDavid Howells }
248b2a464cSDavid Howells 
258b2a464cSDavid Howells /*
268b2a464cSDavid Howells  * Allocate an address list.
278b2a464cSDavid Howells  */
afs_alloc_addrlist(unsigned int nr,unsigned short service,unsigned short port)288b2a464cSDavid Howells struct afs_addr_list *afs_alloc_addrlist(unsigned int nr,
298b2a464cSDavid Howells 					 unsigned short service,
308b2a464cSDavid Howells 					 unsigned short port)
318b2a464cSDavid Howells {
328b2a464cSDavid Howells 	struct afs_addr_list *alist;
338b2a464cSDavid Howells 	unsigned int i;
348b2a464cSDavid Howells 
358b2a464cSDavid Howells 	_enter("%u,%u,%u", nr, service, port);
368b2a464cSDavid Howells 
3768eb64c3SDavid Howells 	if (nr > AFS_MAX_ADDRESSES)
3868eb64c3SDavid Howells 		nr = AFS_MAX_ADDRESSES;
3968eb64c3SDavid Howells 
40acafe7e3SKees Cook 	alist = kzalloc(struct_size(alist, addrs, nr), GFP_KERNEL);
418b2a464cSDavid Howells 	if (!alist)
428b2a464cSDavid Howells 		return NULL;
438b2a464cSDavid Howells 
448b2a464cSDavid Howells 	refcount_set(&alist->usage, 1);
4568eb64c3SDavid Howells 	alist->max_addrs = nr;
468b2a464cSDavid Howells 
478b2a464cSDavid Howells 	for (i = 0; i < nr; i++) {
488b2a464cSDavid Howells 		struct sockaddr_rxrpc *srx = &alist->addrs[i];
498b2a464cSDavid Howells 		srx->srx_family			= AF_RXRPC;
508b2a464cSDavid Howells 		srx->srx_service		= service;
518b2a464cSDavid Howells 		srx->transport_type		= SOCK_DGRAM;
528b2a464cSDavid Howells 		srx->transport_len		= sizeof(srx->transport.sin6);
538b2a464cSDavid Howells 		srx->transport.sin6.sin6_family	= AF_INET6;
548b2a464cSDavid Howells 		srx->transport.sin6.sin6_port	= htons(port);
558b2a464cSDavid Howells 	}
568b2a464cSDavid Howells 
578b2a464cSDavid Howells 	return alist;
588b2a464cSDavid Howells }
598b2a464cSDavid Howells 
608b2a464cSDavid Howells /*
618b2a464cSDavid Howells  * Parse a text string consisting of delimited addresses.
628b2a464cSDavid Howells  */
afs_parse_text_addrs(struct afs_net * net,const char * text,size_t len,char delim,unsigned short service,unsigned short port)630a5143f2SDavid Howells struct afs_vlserver_list *afs_parse_text_addrs(struct afs_net *net,
640a5143f2SDavid Howells 					       const char *text, size_t len,
658b2a464cSDavid Howells 					       char delim,
668b2a464cSDavid Howells 					       unsigned short service,
678b2a464cSDavid Howells 					       unsigned short port)
688b2a464cSDavid Howells {
690a5143f2SDavid Howells 	struct afs_vlserver_list *vllist;
708b2a464cSDavid Howells 	struct afs_addr_list *alist;
718b2a464cSDavid Howells 	const char *p, *end = text + len;
720a5143f2SDavid Howells 	const char *problem;
738b2a464cSDavid Howells 	unsigned int nr = 0;
740a5143f2SDavid Howells 	int ret = -ENOMEM;
758b2a464cSDavid Howells 
768b2a464cSDavid Howells 	_enter("%*.*s,%c", (int)len, (int)len, text, delim);
778b2a464cSDavid Howells 
780a5143f2SDavid Howells 	if (!len) {
790a5143f2SDavid Howells 		_leave(" = -EDESTADDRREQ [empty]");
808b2a464cSDavid Howells 		return ERR_PTR(-EDESTADDRREQ);
810a5143f2SDavid Howells 	}
828b2a464cSDavid Howells 
838b2a464cSDavid Howells 	if (delim == ':' && (memchr(text, ',', len) || !memchr(text, '.', len)))
848b2a464cSDavid Howells 		delim = ',';
858b2a464cSDavid Howells 
868b2a464cSDavid Howells 	/* Count the addresses */
878b2a464cSDavid Howells 	p = text;
888b2a464cSDavid Howells 	do {
890a5143f2SDavid Howells 		if (!*p) {
900a5143f2SDavid Howells 			problem = "nul";
910a5143f2SDavid Howells 			goto inval;
920a5143f2SDavid Howells 		}
938b2a464cSDavid Howells 		if (*p == delim)
948b2a464cSDavid Howells 			continue;
958b2a464cSDavid Howells 		nr++;
968b2a464cSDavid Howells 		if (*p == '[') {
978b2a464cSDavid Howells 			p++;
980a5143f2SDavid Howells 			if (p == end) {
990a5143f2SDavid Howells 				problem = "brace1";
1000a5143f2SDavid Howells 				goto inval;
1010a5143f2SDavid Howells 			}
1028b2a464cSDavid Howells 			p = memchr(p, ']', end - p);
1030a5143f2SDavid Howells 			if (!p) {
1040a5143f2SDavid Howells 				problem = "brace2";
1050a5143f2SDavid Howells 				goto inval;
1060a5143f2SDavid Howells 			}
1078b2a464cSDavid Howells 			p++;
1088b2a464cSDavid Howells 			if (p >= end)
1098b2a464cSDavid Howells 				break;
1108b2a464cSDavid Howells 		}
1118b2a464cSDavid Howells 
1128b2a464cSDavid Howells 		p = memchr(p, delim, end - p);
1138b2a464cSDavid Howells 		if (!p)
1148b2a464cSDavid Howells 			break;
1158b2a464cSDavid Howells 		p++;
1168b2a464cSDavid Howells 	} while (p < end);
1178b2a464cSDavid Howells 
1188b2a464cSDavid Howells 	_debug("%u/%u addresses", nr, AFS_MAX_ADDRESSES);
1198b2a464cSDavid Howells 
1200a5143f2SDavid Howells 	vllist = afs_alloc_vlserver_list(1);
1210a5143f2SDavid Howells 	if (!vllist)
1228b2a464cSDavid Howells 		return ERR_PTR(-ENOMEM);
1238b2a464cSDavid Howells 
1240a5143f2SDavid Howells 	vllist->nr_servers = 1;
1250a5143f2SDavid Howells 	vllist->servers[0].server = afs_alloc_vlserver("<dummy>", 7, AFS_VL_PORT);
1260a5143f2SDavid Howells 	if (!vllist->servers[0].server)
1270a5143f2SDavid Howells 		goto error_vl;
1280a5143f2SDavid Howells 
1290a5143f2SDavid Howells 	alist = afs_alloc_addrlist(nr, service, AFS_VL_PORT);
1300a5143f2SDavid Howells 	if (!alist)
1310a5143f2SDavid Howells 		goto error;
1320a5143f2SDavid Howells 
1338b2a464cSDavid Howells 	/* Extract the addresses */
1348b2a464cSDavid Howells 	p = text;
1358b2a464cSDavid Howells 	do {
13601fd79e6SDavid Howells 		const char *q, *stop;
1374c19bbdcSDavid Howells 		unsigned int xport = port;
1384c19bbdcSDavid Howells 		__be32 x[4];
1394c19bbdcSDavid Howells 		int family;
1408b2a464cSDavid Howells 
1418b2a464cSDavid Howells 		if (*p == delim) {
1428b2a464cSDavid Howells 			p++;
1438b2a464cSDavid Howells 			continue;
1448b2a464cSDavid Howells 		}
1458b2a464cSDavid Howells 
1468b2a464cSDavid Howells 		if (*p == '[') {
1478b2a464cSDavid Howells 			p++;
14801fd79e6SDavid Howells 			q = memchr(p, ']', end - p);
14901fd79e6SDavid Howells 		} else {
15001fd79e6SDavid Howells 			for (q = p; q < end; q++)
15101fd79e6SDavid Howells 				if (*q == '+' || *q == delim)
15201fd79e6SDavid Howells 					break;
1538b2a464cSDavid Howells 		}
1548b2a464cSDavid Howells 
1550a5143f2SDavid Howells 		if (in4_pton(p, q - p, (u8 *)&x[0], -1, &stop)) {
1564c19bbdcSDavid Howells 			family = AF_INET;
1570a5143f2SDavid Howells 		} else if (in6_pton(p, q - p, (u8 *)x, -1, &stop)) {
1584c19bbdcSDavid Howells 			family = AF_INET6;
1590a5143f2SDavid Howells 		} else {
1600a5143f2SDavid Howells 			problem = "family";
1618b2a464cSDavid Howells 			goto bad_address;
1620a5143f2SDavid Howells 		}
16301fd79e6SDavid Howells 
16401fd79e6SDavid Howells 		p = q;
1650a5143f2SDavid Howells 		if (stop != p) {
1660a5143f2SDavid Howells 			problem = "nostop";
1670a5143f2SDavid Howells 			goto bad_address;
1680a5143f2SDavid Howells 		}
1690a5143f2SDavid Howells 
17001fd79e6SDavid Howells 		if (q < end && *q == ']')
1718b2a464cSDavid Howells 			p++;
1728b2a464cSDavid Howells 
1738b2a464cSDavid Howells 		if (p < end) {
1748b2a464cSDavid Howells 			if (*p == '+') {
1758b2a464cSDavid Howells 				/* Port number specification "+1234" */
1764c19bbdcSDavid Howells 				xport = 0;
1778b2a464cSDavid Howells 				p++;
1780a5143f2SDavid Howells 				if (p >= end || !isdigit(*p)) {
1790a5143f2SDavid Howells 					problem = "port";
1808b2a464cSDavid Howells 					goto bad_address;
1810a5143f2SDavid Howells 				}
1828b2a464cSDavid Howells 				do {
1838b2a464cSDavid Howells 					xport *= 10;
1848b2a464cSDavid Howells 					xport += *p - '0';
1850a5143f2SDavid Howells 					if (xport > 65535) {
1860a5143f2SDavid Howells 						problem = "pval";
1878b2a464cSDavid Howells 						goto bad_address;
1880a5143f2SDavid Howells 					}
1898b2a464cSDavid Howells 					p++;
1908b2a464cSDavid Howells 				} while (p < end && isdigit(*p));
1918b2a464cSDavid Howells 			} else if (*p == delim) {
1928b2a464cSDavid Howells 				p++;
1938b2a464cSDavid Howells 			} else {
1940a5143f2SDavid Howells 				problem = "weird";
1958b2a464cSDavid Howells 				goto bad_address;
1968b2a464cSDavid Howells 			}
1978b2a464cSDavid Howells 		}
1988b2a464cSDavid Howells 
1994c19bbdcSDavid Howells 		if (family == AF_INET)
2004c19bbdcSDavid Howells 			afs_merge_fs_addr4(alist, x[0], xport);
2014c19bbdcSDavid Howells 		else
2024c19bbdcSDavid Howells 			afs_merge_fs_addr6(alist, x, xport);
2034c19bbdcSDavid Howells 
2044c19bbdcSDavid Howells 	} while (p < end);
2058b2a464cSDavid Howells 
2060a5143f2SDavid Howells 	rcu_assign_pointer(vllist->servers[0].server->addresses, alist);
2078b2a464cSDavid Howells 	_leave(" = [nr %u]", alist->nr_addrs);
2080a5143f2SDavid Howells 	return vllist;
2098b2a464cSDavid Howells 
2100a5143f2SDavid Howells inval:
2110a5143f2SDavid Howells 	_leave(" = -EINVAL [%s %zu %*.*s]",
2120a5143f2SDavid Howells 	       problem, p - text, (int)len, (int)len, text);
2138b2a464cSDavid Howells 	return ERR_PTR(-EINVAL);
2140a5143f2SDavid Howells bad_address:
2150a5143f2SDavid Howells 	_leave(" = -EINVAL [%s %zu %*.*s]",
2160a5143f2SDavid Howells 	       problem, p - text, (int)len, (int)len, text);
2170a5143f2SDavid Howells 	ret = -EINVAL;
2180a5143f2SDavid Howells error:
2190a5143f2SDavid Howells 	afs_put_addrlist(alist);
2200a5143f2SDavid Howells error_vl:
2210a5143f2SDavid Howells 	afs_put_vlserverlist(net, vllist);
2220a5143f2SDavid Howells 	return ERR_PTR(ret);
2238b2a464cSDavid Howells }
2248b2a464cSDavid Howells 
2258b2a464cSDavid Howells /*
2268b2a464cSDavid Howells  * Compare old and new address lists to see if there's been any change.
2278b2a464cSDavid Howells  * - How to do this in better than O(Nlog(N)) time?
2288b2a464cSDavid Howells  *   - We don't really want to sort the address list, but would rather take the
2298b2a464cSDavid Howells  *     list as we got it so as not to undo record rotation by the DNS server.
2308b2a464cSDavid Howells  */
2318b2a464cSDavid Howells #if 0
2328b2a464cSDavid Howells static int afs_cmp_addr_list(const struct afs_addr_list *a1,
2338b2a464cSDavid Howells 			     const struct afs_addr_list *a2)
2348b2a464cSDavid Howells {
2358b2a464cSDavid Howells }
2368b2a464cSDavid Howells #endif
2378b2a464cSDavid Howells 
2388b2a464cSDavid Howells /*
2398b2a464cSDavid Howells  * Perform a DNS query for VL servers and build a up an address list.
2408b2a464cSDavid Howells  */
afs_dns_query(struct afs_cell * cell,time64_t * _expiry)2410a5143f2SDavid Howells struct afs_vlserver_list *afs_dns_query(struct afs_cell *cell, time64_t *_expiry)
2428b2a464cSDavid Howells {
2430a5143f2SDavid Howells 	struct afs_vlserver_list *vllist;
2440a5143f2SDavid Howells 	char *result = NULL;
2458b2a464cSDavid Howells 	int ret;
2468b2a464cSDavid Howells 
2478b2a464cSDavid Howells 	_enter("%s", cell->name);
2488b2a464cSDavid Howells 
249a58946c1SDavid Howells 	ret = dns_query(cell->net->net, "afsdb", cell->name, cell->name_len,
250a58946c1SDavid Howells 			"srv=1", &result, _expiry, true);
2510a5143f2SDavid Howells 	if (ret < 0) {
2520a5143f2SDavid Howells 		_leave(" = %d [dns]", ret);
2538b2a464cSDavid Howells 		return ERR_PTR(ret);
2548b2a464cSDavid Howells 	}
2558b2a464cSDavid Howells 
2560a5143f2SDavid Howells 	if (*_expiry == 0)
2570a5143f2SDavid Howells 		*_expiry = ktime_get_real_seconds() + 60;
2580a5143f2SDavid Howells 
2590a5143f2SDavid Howells 	if (ret > 1 && result[0] == 0)
2600a5143f2SDavid Howells 		vllist = afs_extract_vlserver_list(cell, result, ret);
2610a5143f2SDavid Howells 	else
2620a5143f2SDavid Howells 		vllist = afs_parse_text_addrs(cell->net, result, ret, ',',
2630a5143f2SDavid Howells 					      VL_SERVICE, AFS_VL_PORT);
2640a5143f2SDavid Howells 	kfree(result);
2650a5143f2SDavid Howells 	if (IS_ERR(vllist) && vllist != ERR_PTR(-ENOMEM))
2660a5143f2SDavid Howells 		pr_err("Failed to parse DNS data %ld\n", PTR_ERR(vllist));
2670a5143f2SDavid Howells 
2680a5143f2SDavid Howells 	return vllist;
2698b2a464cSDavid Howells }
2708b2a464cSDavid Howells 
2718b2a464cSDavid Howells /*
272d2ddc776SDavid Howells  * Merge an IPv4 entry into a fileserver address list.
273d2ddc776SDavid Howells  */
afs_merge_fs_addr4(struct afs_addr_list * alist,__be32 xdr,u16 port)274bf99a53cSDavid Howells void afs_merge_fs_addr4(struct afs_addr_list *alist, __be32 xdr, u16 port)
275d2ddc776SDavid Howells {
27646894a13SDavid Howells 	struct sockaddr_rxrpc *srx;
27766be646bSDavid Howells 	u32 addr = ntohl(xdr);
278d2ddc776SDavid Howells 	int i;
279d2ddc776SDavid Howells 
28068eb64c3SDavid Howells 	if (alist->nr_addrs >= alist->max_addrs)
28168eb64c3SDavid Howells 		return;
28268eb64c3SDavid Howells 
283d2ddc776SDavid Howells 	for (i = 0; i < alist->nr_ipv4; i++) {
28446894a13SDavid Howells 		struct sockaddr_in *a = &alist->addrs[i].transport.sin;
28546894a13SDavid Howells 		u32 a_addr = ntohl(a->sin_addr.s_addr);
28646894a13SDavid Howells 		u16 a_port = ntohs(a->sin_port);
28766be646bSDavid Howells 
28866be646bSDavid Howells 		if (addr == a_addr && port == a_port)
289d2ddc776SDavid Howells 			return;
29066be646bSDavid Howells 		if (addr == a_addr && port < a_port)
291bf99a53cSDavid Howells 			break;
29266be646bSDavid Howells 		if (addr < a_addr)
293d2ddc776SDavid Howells 			break;
294d2ddc776SDavid Howells 	}
295d2ddc776SDavid Howells 
296d2ddc776SDavid Howells 	if (i < alist->nr_addrs)
297d2ddc776SDavid Howells 		memmove(alist->addrs + i + 1,
298d2ddc776SDavid Howells 			alist->addrs + i,
299d2ddc776SDavid Howells 			sizeof(alist->addrs[0]) * (alist->nr_addrs - i));
300d2ddc776SDavid Howells 
30146894a13SDavid Howells 	srx = &alist->addrs[i];
3023bf0fb6fSDavid Howells 	srx->srx_family = AF_RXRPC;
3033bf0fb6fSDavid Howells 	srx->transport_type = SOCK_DGRAM;
30446894a13SDavid Howells 	srx->transport_len = sizeof(srx->transport.sin);
30546894a13SDavid Howells 	srx->transport.sin.sin_family = AF_INET;
30646894a13SDavid Howells 	srx->transport.sin.sin_port = htons(port);
30746894a13SDavid Howells 	srx->transport.sin.sin_addr.s_addr = xdr;
308d2ddc776SDavid Howells 	alist->nr_ipv4++;
309d2ddc776SDavid Howells 	alist->nr_addrs++;
310d2ddc776SDavid Howells }
311d2ddc776SDavid Howells 
312d2ddc776SDavid Howells /*
313bf99a53cSDavid Howells  * Merge an IPv6 entry into a fileserver address list.
314bf99a53cSDavid Howells  */
afs_merge_fs_addr6(struct afs_addr_list * alist,__be32 * xdr,u16 port)315bf99a53cSDavid Howells void afs_merge_fs_addr6(struct afs_addr_list *alist, __be32 *xdr, u16 port)
316bf99a53cSDavid Howells {
31746894a13SDavid Howells 	struct sockaddr_rxrpc *srx;
318bf99a53cSDavid Howells 	int i, diff;
319bf99a53cSDavid Howells 
32068eb64c3SDavid Howells 	if (alist->nr_addrs >= alist->max_addrs)
32168eb64c3SDavid Howells 		return;
32268eb64c3SDavid Howells 
323bf99a53cSDavid Howells 	for (i = alist->nr_ipv4; i < alist->nr_addrs; i++) {
32466be646bSDavid Howells 		struct sockaddr_in6 *a = &alist->addrs[i].transport.sin6;
32566be646bSDavid Howells 		u16 a_port = ntohs(a->sin6_port);
32666be646bSDavid Howells 
327bf99a53cSDavid Howells 		diff = memcmp(xdr, &a->sin6_addr, 16);
32866be646bSDavid Howells 		if (diff == 0 && port == a_port)
329bf99a53cSDavid Howells 			return;
33066be646bSDavid Howells 		if (diff == 0 && port < a_port)
331bf99a53cSDavid Howells 			break;
332bf99a53cSDavid Howells 		if (diff < 0)
333bf99a53cSDavid Howells 			break;
334bf99a53cSDavid Howells 	}
335bf99a53cSDavid Howells 
336bf99a53cSDavid Howells 	if (i < alist->nr_addrs)
337bf99a53cSDavid Howells 		memmove(alist->addrs + i + 1,
338bf99a53cSDavid Howells 			alist->addrs + i,
339bf99a53cSDavid Howells 			sizeof(alist->addrs[0]) * (alist->nr_addrs - i));
340bf99a53cSDavid Howells 
34146894a13SDavid Howells 	srx = &alist->addrs[i];
3423bf0fb6fSDavid Howells 	srx->srx_family = AF_RXRPC;
3433bf0fb6fSDavid Howells 	srx->transport_type = SOCK_DGRAM;
34446894a13SDavid Howells 	srx->transport_len = sizeof(srx->transport.sin6);
34546894a13SDavid Howells 	srx->transport.sin6.sin6_family = AF_INET6;
34646894a13SDavid Howells 	srx->transport.sin6.sin6_port = htons(port);
34746894a13SDavid Howells 	memcpy(&srx->transport.sin6.sin6_addr, xdr, 16);
348bf99a53cSDavid Howells 	alist->nr_addrs++;
349bf99a53cSDavid Howells }
350bf99a53cSDavid Howells 
351bf99a53cSDavid Howells /*
3528b2a464cSDavid Howells  * Get an address to try.
3538b2a464cSDavid Howells  */
afs_iterate_addresses(struct afs_addr_cursor * ac)3548b2a464cSDavid Howells bool afs_iterate_addresses(struct afs_addr_cursor *ac)
3558b2a464cSDavid Howells {
3563bf0fb6fSDavid Howells 	unsigned long set, failed;
3573bf0fb6fSDavid Howells 	int index;
3588b2a464cSDavid Howells 
3598b2a464cSDavid Howells 	if (!ac->alist)
3608b2a464cSDavid Howells 		return false;
3618b2a464cSDavid Howells 
3623bf0fb6fSDavid Howells 	set = ac->alist->responded;
3633bf0fb6fSDavid Howells 	failed = ac->alist->failed;
3643bf0fb6fSDavid Howells 	_enter("%lx-%lx-%lx,%d", set, failed, ac->tried, ac->index);
3653bf0fb6fSDavid Howells 
366744bcd71SDavid Howells 	ac->nr_iterations++;
367744bcd71SDavid Howells 
3683bf0fb6fSDavid Howells 	set &= ~(failed | ac->tried);
3698b2a464cSDavid Howells 
3703bf0fb6fSDavid Howells 	if (!set)
3718b2a464cSDavid Howells 		return false;
3728b2a464cSDavid Howells 
3733bf0fb6fSDavid Howells 	index = READ_ONCE(ac->alist->preferred);
3743bf0fb6fSDavid Howells 	if (test_bit(index, &set))
3753bf0fb6fSDavid Howells 		goto selected;
3763bf0fb6fSDavid Howells 
3773bf0fb6fSDavid Howells 	index = __ffs(set);
3783bf0fb6fSDavid Howells 
3793bf0fb6fSDavid Howells selected:
3803bf0fb6fSDavid Howells 	ac->index = index;
3813bf0fb6fSDavid Howells 	set_bit(index, &ac->tried);
3828b2a464cSDavid Howells 	ac->responded = false;
3838b2a464cSDavid Howells 	return true;
3848b2a464cSDavid Howells }
3858b2a464cSDavid Howells 
3868b2a464cSDavid Howells /*
3878b2a464cSDavid Howells  * Release an address list cursor.
3888b2a464cSDavid Howells  */
afs_end_cursor(struct afs_addr_cursor * ac)3898b2a464cSDavid Howells int afs_end_cursor(struct afs_addr_cursor *ac)
3908b2a464cSDavid Howells {
391fe4d774cSDavid Howells 	struct afs_addr_list *alist;
3928b2a464cSDavid Howells 
393fe4d774cSDavid Howells 	alist = ac->alist;
394fe4d774cSDavid Howells 	if (alist) {
3953bf0fb6fSDavid Howells 		if (ac->responded &&
3963bf0fb6fSDavid Howells 		    ac->index != alist->preferred &&
3973bf0fb6fSDavid Howells 		    test_bit(ac->alist->preferred, &ac->tried))
3983bf0fb6fSDavid Howells 			WRITE_ONCE(alist->preferred, ac->index);
399fe4d774cSDavid Howells 		afs_put_addrlist(alist);
4003bf0fb6fSDavid Howells 		ac->alist = NULL;
401fe4d774cSDavid Howells 	}
402fe4d774cSDavid Howells 
4038b2a464cSDavid Howells 	return ac->error;
4048b2a464cSDavid Howells }
405