xref: /openbmc/linux/drivers/scsi/libsas/sas_ata.c (revision 3dff5721e4f67e6231dfc419d30aaa7563bfffd4)
1338ec570SDarrick J. Wong /*
2338ec570SDarrick J. Wong  * Support for SATA devices on Serial Attached SCSI (SAS) controllers
3338ec570SDarrick J. Wong  *
4338ec570SDarrick J. Wong  * Copyright (C) 2006 IBM Corporation
5338ec570SDarrick J. Wong  *
6338ec570SDarrick J. Wong  * Written by: Darrick J. Wong <djwong@us.ibm.com>, IBM Corporation
7338ec570SDarrick J. Wong  *
8338ec570SDarrick J. Wong  * This program is free software; you can redistribute it and/or
9338ec570SDarrick J. Wong  * modify it under the terms of the GNU General Public License as
10338ec570SDarrick J. Wong  * published by the Free Software Foundation; either version 2 of the
11338ec570SDarrick J. Wong  * License, or (at your option) any later version.
12338ec570SDarrick J. Wong  *
13338ec570SDarrick J. Wong  * This program is distributed in the hope that it will be useful, but
14338ec570SDarrick J. Wong  * WITHOUT ANY WARRANTY; without even the implied warranty of
15338ec570SDarrick J. Wong  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
16338ec570SDarrick J. Wong  * General Public License for more details.
17338ec570SDarrick J. Wong  *
18338ec570SDarrick J. Wong  * You should have received a copy of the GNU General Public License
19338ec570SDarrick J. Wong  * along with this program; if not, write to the Free Software
20338ec570SDarrick J. Wong  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
21338ec570SDarrick J. Wong  * USA
22338ec570SDarrick J. Wong  */
23338ec570SDarrick J. Wong 
24b9142174SJames Bottomley #include <linux/scatterlist.h>
255a0e3ad6STejun Heo #include <linux/slab.h>
26b9142174SJames Bottomley 
27338ec570SDarrick J. Wong #include <scsi/sas_ata.h>
28338ec570SDarrick J. Wong #include "sas_internal.h"
29338ec570SDarrick J. Wong #include <scsi/scsi_host.h>
30338ec570SDarrick J. Wong #include <scsi/scsi_device.h>
31338ec570SDarrick J. Wong #include <scsi/scsi_tcq.h>
32338ec570SDarrick J. Wong #include <scsi/scsi.h>
33338ec570SDarrick J. Wong #include <scsi/scsi_transport.h>
34338ec570SDarrick J. Wong #include <scsi/scsi_transport_sas.h>
35338ec570SDarrick J. Wong #include "../scsi_sas_internal.h"
363a2755afSDarrick J. Wong #include "../scsi_transport_api.h"
373a2755afSDarrick J. Wong #include <scsi/scsi_eh.h>
38338ec570SDarrick J. Wong 
39338ec570SDarrick J. Wong static enum ata_completion_errors sas_to_ata_err(struct task_status_struct *ts)
40338ec570SDarrick J. Wong {
41338ec570SDarrick J. Wong 	/* Cheesy attempt to translate SAS errors into ATA.  Hah! */
42338ec570SDarrick J. Wong 
43338ec570SDarrick J. Wong 	/* transport error */
44338ec570SDarrick J. Wong 	if (ts->resp == SAS_TASK_UNDELIVERED)
45338ec570SDarrick J. Wong 		return AC_ERR_ATA_BUS;
46338ec570SDarrick J. Wong 
47338ec570SDarrick J. Wong 	/* ts->resp == SAS_TASK_COMPLETE */
48338ec570SDarrick J. Wong 	/* task delivered, what happened afterwards? */
49338ec570SDarrick J. Wong 	switch (ts->stat) {
50338ec570SDarrick J. Wong 		case SAS_DEV_NO_RESPONSE:
51338ec570SDarrick J. Wong 			return AC_ERR_TIMEOUT;
52338ec570SDarrick J. Wong 
53338ec570SDarrick J. Wong 		case SAS_INTERRUPTED:
54338ec570SDarrick J. Wong 		case SAS_PHY_DOWN:
55338ec570SDarrick J. Wong 		case SAS_NAK_R_ERR:
56338ec570SDarrick J. Wong 			return AC_ERR_ATA_BUS;
57338ec570SDarrick J. Wong 
58338ec570SDarrick J. Wong 
59338ec570SDarrick J. Wong 		case SAS_DATA_UNDERRUN:
60338ec570SDarrick J. Wong 			/*
61338ec570SDarrick J. Wong 			 * Some programs that use the taskfile interface
62338ec570SDarrick J. Wong 			 * (smartctl in particular) can cause underrun
63338ec570SDarrick J. Wong 			 * problems.  Ignore these errors, perhaps at our
64338ec570SDarrick J. Wong 			 * peril.
65338ec570SDarrick J. Wong 			 */
66338ec570SDarrick J. Wong 			return 0;
67338ec570SDarrick J. Wong 
68338ec570SDarrick J. Wong 		case SAS_DATA_OVERRUN:
69338ec570SDarrick J. Wong 		case SAS_QUEUE_FULL:
70338ec570SDarrick J. Wong 		case SAS_DEVICE_UNKNOWN:
71338ec570SDarrick J. Wong 		case SAS_SG_ERR:
72338ec570SDarrick J. Wong 			return AC_ERR_INVALID;
73338ec570SDarrick J. Wong 
74338ec570SDarrick J. Wong 		case SAS_OPEN_TO:
75338ec570SDarrick J. Wong 		case SAS_OPEN_REJECT:
76338ec570SDarrick J. Wong 			SAS_DPRINTK("%s: Saw error %d.  What to do?\n",
77cadbd4a5SHarvey Harrison 				    __func__, ts->stat);
78338ec570SDarrick J. Wong 			return AC_ERR_OTHER;
79338ec570SDarrick J. Wong 
8075c0b386SJames Bottomley 		case SAM_STAT_CHECK_CONDITION:
81338ec570SDarrick J. Wong 		case SAS_ABORTED_TASK:
82338ec570SDarrick J. Wong 			return AC_ERR_DEV;
83338ec570SDarrick J. Wong 
84338ec570SDarrick J. Wong 		case SAS_PROTO_RESPONSE:
85338ec570SDarrick J. Wong 			/* This means the ending_fis has the error
86338ec570SDarrick J. Wong 			 * value; return 0 here to collect it */
87338ec570SDarrick J. Wong 			return 0;
88338ec570SDarrick J. Wong 		default:
89338ec570SDarrick J. Wong 			return 0;
90338ec570SDarrick J. Wong 	}
91338ec570SDarrick J. Wong }
92338ec570SDarrick J. Wong 
93338ec570SDarrick J. Wong static void sas_ata_task_done(struct sas_task *task)
94338ec570SDarrick J. Wong {
95338ec570SDarrick J. Wong 	struct ata_queued_cmd *qc = task->uldd_task;
961c50dc83SDarrick J. Wong 	struct domain_device *dev;
97338ec570SDarrick J. Wong 	struct task_status_struct *stat = &task->task_status;
98338ec570SDarrick J. Wong 	struct ata_task_resp *resp = (struct ata_task_resp *)stat->buf;
993a2755afSDarrick J. Wong 	struct sas_ha_struct *sas_ha;
100338ec570SDarrick J. Wong 	enum ata_completion_errors ac;
1013eb7a51aSDarrick J. Wong 	unsigned long flags;
102bb650a1bSXiangliang Yu 	struct ata_link *link;
103*3dff5721SDan Williams 	struct ata_port *ap;
104338ec570SDarrick J. Wong 
1051c50dc83SDarrick J. Wong 	if (!qc)
1061c50dc83SDarrick J. Wong 		goto qc_already_gone;
1071c50dc83SDarrick J. Wong 
108*3dff5721SDan Williams 	ap = qc->ap;
109*3dff5721SDan Williams 	dev = ap->private_data;
1103a2755afSDarrick J. Wong 	sas_ha = dev->port->ha;
111*3dff5721SDan Williams 	link = &ap->link;
1121c50dc83SDarrick J. Wong 
113*3dff5721SDan Williams 	spin_lock_irqsave(ap->lock, flags);
114*3dff5721SDan Williams 	/* check if we lost the race with libata/sas_ata_post_internal() */
115*3dff5721SDan Williams 	if (unlikely(ap->pflags & ATA_PFLAG_FROZEN)) {
116*3dff5721SDan Williams 		spin_unlock_irqrestore(ap->lock, flags);
117*3dff5721SDan Williams 		if (qc->scsicmd)
118*3dff5721SDan Williams 			goto qc_already_gone;
119*3dff5721SDan Williams 		else {
120*3dff5721SDan Williams 			/* if eh is not involved and the port is frozen then the
121*3dff5721SDan Williams 			 * ata internal abort process has taken responsibility
122*3dff5721SDan Williams 			 * for this sas_task
123*3dff5721SDan Williams 			 */
124*3dff5721SDan Williams 			return;
125*3dff5721SDan Williams 		}
126*3dff5721SDan Williams 	}
127*3dff5721SDan Williams 
12875c0b386SJames Bottomley 	if (stat->stat == SAS_PROTO_RESPONSE || stat->stat == SAM_STAT_GOOD ||
12975c0b386SJames Bottomley 	    ((stat->stat == SAM_STAT_CHECK_CONDITION &&
13075c0b386SJames Bottomley 	      dev->sata_dev.command_set == ATAPI_COMMAND_SET))) {
131338ec570SDarrick J. Wong 		ata_tf_from_fis(resp->ending_fis, &dev->sata_dev.tf);
132bb650a1bSXiangliang Yu 
133bb650a1bSXiangliang Yu 		if (!link->sactive) {
134338ec570SDarrick J. Wong 			qc->err_mask |= ac_err_mask(dev->sata_dev.tf.command);
135bb650a1bSXiangliang Yu 		} else {
136bb650a1bSXiangliang Yu 			link->eh_info.err_mask |= ac_err_mask(dev->sata_dev.tf.command);
137bb650a1bSXiangliang Yu 			if (unlikely(link->eh_info.err_mask))
138bb650a1bSXiangliang Yu 				qc->flags |= ATA_QCFLAG_FAILED;
139bb650a1bSXiangliang Yu 		}
14075c0b386SJames Bottomley 	} else {
141338ec570SDarrick J. Wong 		ac = sas_to_ata_err(stat);
142338ec570SDarrick J. Wong 		if (ac) {
143cadbd4a5SHarvey Harrison 			SAS_DPRINTK("%s: SAS error %x\n", __func__,
144338ec570SDarrick J. Wong 				    stat->stat);
145338ec570SDarrick J. Wong 			/* We saw a SAS error. Send a vague error. */
146bb650a1bSXiangliang Yu 			if (!link->sactive) {
147338ec570SDarrick J. Wong 				qc->err_mask = ac;
148bb650a1bSXiangliang Yu 			} else {
149bb650a1bSXiangliang Yu 				link->eh_info.err_mask |= AC_ERR_DEV;
150bb650a1bSXiangliang Yu 				qc->flags |= ATA_QCFLAG_FAILED;
151bb650a1bSXiangliang Yu 			}
152bb650a1bSXiangliang Yu 
153338ec570SDarrick J. Wong 			dev->sata_dev.tf.feature = 0x04; /* status err */
154338ec570SDarrick J. Wong 			dev->sata_dev.tf.command = ATA_ERR;
155338ec570SDarrick J. Wong 		}
156338ec570SDarrick J. Wong 	}
157338ec570SDarrick J. Wong 
1581c50dc83SDarrick J. Wong 	qc->lldd_task = NULL;
159fe059f12SDarrick J. Wong 	if (qc->scsicmd)
160fe059f12SDarrick J. Wong 		ASSIGN_SAS_TASK(qc->scsicmd, NULL);
161338ec570SDarrick J. Wong 	ata_qc_complete(qc);
162*3dff5721SDan Williams 	spin_unlock_irqrestore(ap->lock, flags);
1633eb7a51aSDarrick J. Wong 
1641c50dc83SDarrick J. Wong qc_already_gone:
165338ec570SDarrick J. Wong 	list_del_init(&task->list);
166338ec570SDarrick J. Wong 	sas_free_task(task);
167338ec570SDarrick J. Wong }
168338ec570SDarrick J. Wong 
169338ec570SDarrick J. Wong static unsigned int sas_ata_qc_issue(struct ata_queued_cmd *qc)
170338ec570SDarrick J. Wong {
171312d3e56SDan Williams 	unsigned long flags;
172338ec570SDarrick J. Wong 	struct sas_task *task;
173312d3e56SDan Williams 	struct scatterlist *sg;
174312d3e56SDan Williams 	int ret = AC_ERR_SYSTEM;
175312d3e56SDan Williams 	unsigned int si, xfer = 0;
176312d3e56SDan Williams 	struct ata_port *ap = qc->ap;
177312d3e56SDan Williams 	struct domain_device *dev = ap->private_data;
178338ec570SDarrick J. Wong 	struct sas_ha_struct *sas_ha = dev->port->ha;
179338ec570SDarrick J. Wong 	struct Scsi_Host *host = sas_ha->core.shost;
180338ec570SDarrick J. Wong 	struct sas_internal *i = to_sas_internal(host->transportt);
181312d3e56SDan Williams 
182312d3e56SDan Williams 	/* TODO: audit callers to ensure they are ready for qc_issue to
183312d3e56SDan Williams 	 * unconditionally re-enable interrupts
184312d3e56SDan Williams 	 */
185312d3e56SDan Williams 	local_irq_save(flags);
186312d3e56SDan Williams 	spin_unlock(ap->lock);
187338ec570SDarrick J. Wong 
18856dd2c06SDarrick J. Wong 	/* If the device fell off, no sense in issuing commands */
189e139942dSDan Williams 	if (test_bit(SAS_DEV_GONE, &dev->state))
190312d3e56SDan Williams 		goto out;
19156dd2c06SDarrick J. Wong 
192338ec570SDarrick J. Wong 	task = sas_alloc_task(GFP_ATOMIC);
193338ec570SDarrick J. Wong 	if (!task)
194312d3e56SDan Williams 		goto out;
195338ec570SDarrick J. Wong 	task->dev = dev;
196338ec570SDarrick J. Wong 	task->task_proto = SAS_PROTOCOL_STP;
197338ec570SDarrick J. Wong 	task->task_done = sas_ata_task_done;
198338ec570SDarrick J. Wong 
199338ec570SDarrick J. Wong 	if (qc->tf.command == ATA_CMD_FPDMA_WRITE ||
200338ec570SDarrick J. Wong 	    qc->tf.command == ATA_CMD_FPDMA_READ) {
201338ec570SDarrick J. Wong 		/* Need to zero out the tag libata assigned us */
202338ec570SDarrick J. Wong 		qc->tf.nsect = 0;
203338ec570SDarrick J. Wong 	}
204338ec570SDarrick J. Wong 
205110dd8f1SJames Bottomley 	ata_tf_to_fis(&qc->tf, 1, 0, (u8*)&task->ata_task.fis);
206338ec570SDarrick J. Wong 	task->uldd_task = qc;
207405e66b3STejun Heo 	if (ata_is_atapi(qc->tf.protocol)) {
208338ec570SDarrick J. Wong 		memcpy(task->ata_task.atapi_packet, qc->cdb, qc->dev->cdb_len);
209dde20207SJames Bottomley 		task->total_xfer_len = qc->nbytes;
210dde20207SJames Bottomley 		task->num_scatter = qc->n_elem;
211338ec570SDarrick J. Wong 	} else {
212ff2aeb1eSTejun Heo 		for_each_sg(qc->sg, sg, qc->n_elem, si)
213338ec570SDarrick J. Wong 			xfer += sg->length;
214338ec570SDarrick J. Wong 
215338ec570SDarrick J. Wong 		task->total_xfer_len = xfer;
216ff2aeb1eSTejun Heo 		task->num_scatter = si;
217338ec570SDarrick J. Wong 	}
218338ec570SDarrick J. Wong 
219338ec570SDarrick J. Wong 	task->data_dir = qc->dma_dir;
220ff2aeb1eSTejun Heo 	task->scatter = qc->sg;
221338ec570SDarrick J. Wong 	task->ata_task.retry_count = 1;
222338ec570SDarrick J. Wong 	task->task_state_flags = SAS_TASK_STATE_PENDING;
2231c50dc83SDarrick J. Wong 	qc->lldd_task = task;
224338ec570SDarrick J. Wong 
225338ec570SDarrick J. Wong 	switch (qc->tf.protocol) {
226338ec570SDarrick J. Wong 	case ATA_PROT_NCQ:
227338ec570SDarrick J. Wong 		task->ata_task.use_ncq = 1;
228338ec570SDarrick J. Wong 		/* fall through */
2290dc36888STejun Heo 	case ATAPI_PROT_DMA:
230338ec570SDarrick J. Wong 	case ATA_PROT_DMA:
231338ec570SDarrick J. Wong 		task->ata_task.dma_xfer = 1;
232338ec570SDarrick J. Wong 		break;
233338ec570SDarrick J. Wong 	}
234338ec570SDarrick J. Wong 
235fe059f12SDarrick J. Wong 	if (qc->scsicmd)
236fe059f12SDarrick J. Wong 		ASSIGN_SAS_TASK(qc->scsicmd, task);
237fe059f12SDarrick J. Wong 
238338ec570SDarrick J. Wong 	if (sas_ha->lldd_max_execute_num < 2)
239312d3e56SDan Williams 		ret = i->dft->lldd_execute_task(task, 1, GFP_ATOMIC);
240338ec570SDarrick J. Wong 	else
241312d3e56SDan Williams 		ret = sas_queue_up(task);
242338ec570SDarrick J. Wong 
243338ec570SDarrick J. Wong 	/* Examine */
244312d3e56SDan Williams 	if (ret) {
245312d3e56SDan Williams 		SAS_DPRINTK("lldd_execute_task returned: %d\n", ret);
246338ec570SDarrick J. Wong 
247fe059f12SDarrick J. Wong 		if (qc->scsicmd)
248fe059f12SDarrick J. Wong 			ASSIGN_SAS_TASK(qc->scsicmd, NULL);
249338ec570SDarrick J. Wong 		sas_free_task(task);
250312d3e56SDan Williams 		ret = AC_ERR_SYSTEM;
251338ec570SDarrick J. Wong 	}
252338ec570SDarrick J. Wong 
253312d3e56SDan Williams  out:
254312d3e56SDan Williams 	spin_lock(ap->lock);
255312d3e56SDan Williams 	local_irq_restore(flags);
256312d3e56SDan Williams 	return ret;
257338ec570SDarrick J. Wong }
258338ec570SDarrick J. Wong 
2594c9bf4e7STejun Heo static bool sas_ata_qc_fill_rtf(struct ata_queued_cmd *qc)
2604c9bf4e7STejun Heo {
2614c9bf4e7STejun Heo 	struct domain_device *dev = qc->ap->private_data;
2624c9bf4e7STejun Heo 
2634c9bf4e7STejun Heo 	memcpy(&qc->result_tf, &dev->sata_dev.tf, sizeof(qc->result_tf));
2644c9bf4e7STejun Heo 	return true;
2654c9bf4e7STejun Heo }
2664c9bf4e7STejun Heo 
26700dd4998SJames Bottomley static int sas_ata_hard_reset(struct ata_link *link, unsigned int *class,
26800dd4998SJames Bottomley 			       unsigned long deadline)
269338ec570SDarrick J. Wong {
27000dd4998SJames Bottomley 	struct ata_port *ap = link->ap;
271338ec570SDarrick J. Wong 	struct domain_device *dev = ap->private_data;
272338ec570SDarrick J. Wong 	struct sas_internal *i =
273338ec570SDarrick J. Wong 		to_sas_internal(dev->port->ha->core.shost->transportt);
274a29c0515SJames Bottomley 	int res = TMF_RESP_FUNC_FAILED;
27500dd4998SJames Bottomley 	int ret = 0;
276338ec570SDarrick J. Wong 
277338ec570SDarrick J. Wong 	if (i->dft->lldd_I_T_nexus_reset)
278338ec570SDarrick J. Wong 		res = i->dft->lldd_I_T_nexus_reset(dev);
279338ec570SDarrick J. Wong 
28000dd4998SJames Bottomley 	if (res != TMF_RESP_FUNC_COMPLETE) {
281cadbd4a5SHarvey Harrison 		SAS_DPRINTK("%s: Unable to reset I T nexus?\n", __func__);
28200dd4998SJames Bottomley 		ret = -EAGAIN;
28300dd4998SJames Bottomley 	}
284338ec570SDarrick J. Wong 
285338ec570SDarrick J. Wong 	switch (dev->sata_dev.command_set) {
286338ec570SDarrick J. Wong 		case ATA_COMMAND_SET:
287cadbd4a5SHarvey Harrison 			SAS_DPRINTK("%s: Found ATA device.\n", __func__);
28800dd4998SJames Bottomley 			*class = ATA_DEV_ATA;
289338ec570SDarrick J. Wong 			break;
290338ec570SDarrick J. Wong 		case ATAPI_COMMAND_SET:
291cadbd4a5SHarvey Harrison 			SAS_DPRINTK("%s: Found ATAPI device.\n", __func__);
29200dd4998SJames Bottomley 			*class = ATA_DEV_ATAPI;
293338ec570SDarrick J. Wong 			break;
294338ec570SDarrick J. Wong 		default:
295338ec570SDarrick J. Wong 			SAS_DPRINTK("%s: Unknown SATA command set: %d.\n",
296cadbd4a5SHarvey Harrison 				    __func__,
297338ec570SDarrick J. Wong 				    dev->sata_dev.command_set);
29800dd4998SJames Bottomley 			*class = ATA_DEV_UNKNOWN;
299338ec570SDarrick J. Wong 			break;
300338ec570SDarrick J. Wong 	}
301338ec570SDarrick J. Wong 
302338ec570SDarrick J. Wong 	ap->cbl = ATA_CBL_SATA;
30300dd4998SJames Bottomley 	return ret;
304338ec570SDarrick J. Wong }
305338ec570SDarrick J. Wong 
3061ca1e43eSDave Jiang static int sas_ata_soft_reset(struct ata_link *link, unsigned int *class,
3071ca1e43eSDave Jiang 			       unsigned long deadline)
3081ca1e43eSDave Jiang {
3091ca1e43eSDave Jiang 	struct ata_port *ap = link->ap;
3101ca1e43eSDave Jiang 	struct domain_device *dev = ap->private_data;
3111ca1e43eSDave Jiang 	struct sas_internal *i =
3121ca1e43eSDave Jiang 		to_sas_internal(dev->port->ha->core.shost->transportt);
3131ca1e43eSDave Jiang 	int res = TMF_RESP_FUNC_FAILED;
3141ca1e43eSDave Jiang 	int ret = 0;
3151ca1e43eSDave Jiang 
3161ca1e43eSDave Jiang 	if (i->dft->lldd_ata_soft_reset)
3171ca1e43eSDave Jiang 		res = i->dft->lldd_ata_soft_reset(dev);
3181ca1e43eSDave Jiang 
3191ca1e43eSDave Jiang 	if (res != TMF_RESP_FUNC_COMPLETE) {
3201ca1e43eSDave Jiang 		SAS_DPRINTK("%s: Unable to soft reset\n", __func__);
3211ca1e43eSDave Jiang 		ret = -EAGAIN;
3221ca1e43eSDave Jiang 	}
3231ca1e43eSDave Jiang 
3241ca1e43eSDave Jiang 	switch (dev->sata_dev.command_set) {
3251ca1e43eSDave Jiang 	case ATA_COMMAND_SET:
3261ca1e43eSDave Jiang 		SAS_DPRINTK("%s: Found ATA device.\n", __func__);
3271ca1e43eSDave Jiang 		*class = ATA_DEV_ATA;
3281ca1e43eSDave Jiang 		break;
3291ca1e43eSDave Jiang 	case ATAPI_COMMAND_SET:
3301ca1e43eSDave Jiang 		SAS_DPRINTK("%s: Found ATAPI device.\n", __func__);
3311ca1e43eSDave Jiang 		*class = ATA_DEV_ATAPI;
3321ca1e43eSDave Jiang 		break;
3331ca1e43eSDave Jiang 	default:
3341ca1e43eSDave Jiang 		SAS_DPRINTK("%s: Unknown SATA command set: %d.\n",
3351ca1e43eSDave Jiang 			    __func__, dev->sata_dev.command_set);
3361ca1e43eSDave Jiang 		*class = ATA_DEV_UNKNOWN;
3371ca1e43eSDave Jiang 		break;
3381ca1e43eSDave Jiang 	}
3391ca1e43eSDave Jiang 
3401ca1e43eSDave Jiang 	ap->cbl = ATA_CBL_SATA;
3411ca1e43eSDave Jiang 	return ret;
3421ca1e43eSDave Jiang }
3431ca1e43eSDave Jiang 
344*3dff5721SDan Williams /*
345*3dff5721SDan Williams  * notify the lldd to forget the sas_task for this internal ata command
346*3dff5721SDan Williams  * that bypasses scsi-eh
347*3dff5721SDan Williams  */
348*3dff5721SDan Williams static void sas_ata_internal_abort(struct sas_task *task)
349*3dff5721SDan Williams {
350*3dff5721SDan Williams 	struct sas_internal *si =
351*3dff5721SDan Williams 		to_sas_internal(task->dev->port->ha->core.shost->transportt);
352*3dff5721SDan Williams 	unsigned long flags;
353*3dff5721SDan Williams 	int res;
354*3dff5721SDan Williams 
355*3dff5721SDan Williams 	spin_lock_irqsave(&task->task_state_lock, flags);
356*3dff5721SDan Williams 	if (task->task_state_flags & SAS_TASK_STATE_ABORTED ||
357*3dff5721SDan Williams 	    task->task_state_flags & SAS_TASK_STATE_DONE) {
358*3dff5721SDan Williams 		spin_unlock_irqrestore(&task->task_state_lock, flags);
359*3dff5721SDan Williams 		SAS_DPRINTK("%s: Task %p already finished.\n", __func__,
360*3dff5721SDan Williams 			    task);
361*3dff5721SDan Williams 		goto out;
362*3dff5721SDan Williams 	}
363*3dff5721SDan Williams 	task->task_state_flags |= SAS_TASK_STATE_ABORTED;
364*3dff5721SDan Williams 	spin_unlock_irqrestore(&task->task_state_lock, flags);
365*3dff5721SDan Williams 
366*3dff5721SDan Williams 	res = si->dft->lldd_abort_task(task);
367*3dff5721SDan Williams 
368*3dff5721SDan Williams 	spin_lock_irqsave(&task->task_state_lock, flags);
369*3dff5721SDan Williams 	if (task->task_state_flags & SAS_TASK_STATE_DONE ||
370*3dff5721SDan Williams 	    res == TMF_RESP_FUNC_COMPLETE) {
371*3dff5721SDan Williams 		spin_unlock_irqrestore(&task->task_state_lock, flags);
372*3dff5721SDan Williams 		goto out;
373*3dff5721SDan Williams 	}
374*3dff5721SDan Williams 
375*3dff5721SDan Williams 	/* XXX we are not prepared to deal with ->lldd_abort_task()
376*3dff5721SDan Williams 	 * failures.  TODO: lldds need to unconditionally forget about
377*3dff5721SDan Williams 	 * aborted ata tasks, otherwise we (likely) leak the sas task
378*3dff5721SDan Williams 	 * here
379*3dff5721SDan Williams 	 */
380*3dff5721SDan Williams 	SAS_DPRINTK("%s: Task %p leaked.\n", __func__, task);
381*3dff5721SDan Williams 
382*3dff5721SDan Williams 	if (!(task->task_state_flags & SAS_TASK_STATE_DONE))
383*3dff5721SDan Williams 		task->task_state_flags &= ~SAS_TASK_STATE_ABORTED;
384*3dff5721SDan Williams 	spin_unlock_irqrestore(&task->task_state_lock, flags);
385*3dff5721SDan Williams 
386*3dff5721SDan Williams 	return;
387*3dff5721SDan Williams  out:
388*3dff5721SDan Williams 	list_del_init(&task->list);
389*3dff5721SDan Williams 	sas_free_task(task);
390*3dff5721SDan Williams }
391*3dff5721SDan Williams 
392338ec570SDarrick J. Wong static void sas_ata_post_internal(struct ata_queued_cmd *qc)
393338ec570SDarrick J. Wong {
394338ec570SDarrick J. Wong 	if (qc->flags & ATA_QCFLAG_FAILED)
395338ec570SDarrick J. Wong 		qc->err_mask |= AC_ERR_OTHER;
396338ec570SDarrick J. Wong 
3971c50dc83SDarrick J. Wong 	if (qc->err_mask) {
3981c50dc83SDarrick J. Wong 		/*
399*3dff5721SDan Williams 		 * Find the sas_task and kill it.  By this point, libata
400*3dff5721SDan Williams 		 * has decided to kill the qc and has frozen the port.
401*3dff5721SDan Williams 		 * In this state sas_ata_task_done() will no longer free
402*3dff5721SDan Williams 		 * the sas_task, so we need to notify the lldd (via
403*3dff5721SDan Williams 		 * ->lldd_abort_task) that the task is dead and free it
404*3dff5721SDan Williams 		 *  ourselves.
4051c50dc83SDarrick J. Wong 		 */
4061c50dc83SDarrick J. Wong 		struct sas_task *task = qc->lldd_task;
4073a2755afSDarrick J. Wong 		unsigned long flags;
4081c50dc83SDarrick J. Wong 
4091c50dc83SDarrick J. Wong 		qc->lldd_task = NULL;
4101c50dc83SDarrick J. Wong 		if (task) {
4113a2755afSDarrick J. Wong 			/* Should this be a AT(API) device reset? */
4123a2755afSDarrick J. Wong 			spin_lock_irqsave(&task->task_state_lock, flags);
4133a2755afSDarrick J. Wong 			task->task_state_flags |= SAS_TASK_NEED_DEV_RESET;
4143a2755afSDarrick J. Wong 			spin_unlock_irqrestore(&task->task_state_lock, flags);
4153a2755afSDarrick J. Wong 
4161c50dc83SDarrick J. Wong 			task->uldd_task = NULL;
417*3dff5721SDan Williams 			sas_ata_internal_abort(task);
4181c50dc83SDarrick J. Wong 		}
4191c50dc83SDarrick J. Wong 	}
420338ec570SDarrick J. Wong }
421338ec570SDarrick J. Wong 
422b91bb296SDan Williams 
423b91bb296SDan Williams static void sas_ata_set_dmamode(struct ata_port *ap, struct ata_device *ata_dev)
424b91bb296SDan Williams {
425b91bb296SDan Williams 	struct domain_device *dev = ap->private_data;
426b91bb296SDan Williams 	struct sas_internal *i =
427b91bb296SDan Williams 		to_sas_internal(dev->port->ha->core.shost->transportt);
428b91bb296SDan Williams 
429b91bb296SDan Williams 	if (i->dft->lldd_ata_set_dmamode)
430b91bb296SDan Williams 		i->dft->lldd_ata_set_dmamode(dev);
431b91bb296SDan Williams }
432b91bb296SDan Williams 
433338ec570SDarrick J. Wong static struct ata_port_operations sas_sata_ops = {
43400dd4998SJames Bottomley 	.prereset		= ata_std_prereset,
4351ca1e43eSDave Jiang 	.softreset		= sas_ata_soft_reset,
43600dd4998SJames Bottomley 	.hardreset		= sas_ata_hard_reset,
43700dd4998SJames Bottomley 	.postreset		= ata_std_postreset,
43800dd4998SJames Bottomley 	.error_handler		= ata_std_error_handler,
439338ec570SDarrick J. Wong 	.post_internal_cmd	= sas_ata_post_internal,
440f0ad30d3SDavid Milburn 	.qc_defer               = ata_std_qc_defer,
441338ec570SDarrick J. Wong 	.qc_prep		= ata_noop_qc_prep,
442338ec570SDarrick J. Wong 	.qc_issue		= sas_ata_qc_issue,
4434c9bf4e7STejun Heo 	.qc_fill_rtf		= sas_ata_qc_fill_rtf,
444338ec570SDarrick J. Wong 	.port_start		= ata_sas_port_start,
445338ec570SDarrick J. Wong 	.port_stop		= ata_sas_port_stop,
446b91bb296SDan Williams 	.set_dmamode		= sas_ata_set_dmamode,
447338ec570SDarrick J. Wong };
448338ec570SDarrick J. Wong 
449338ec570SDarrick J. Wong static struct ata_port_info sata_port_info = {
4509cbe056fSSergei Shtylyov 	.flags = ATA_FLAG_SATA | ATA_FLAG_PIO_DMA | ATA_FLAG_NCQ,
4510f2e0330SSergei Shtylyov 	.pio_mask = ATA_PIO4,
4520f2e0330SSergei Shtylyov 	.mwdma_mask = ATA_MWDMA2,
453338ec570SDarrick J. Wong 	.udma_mask = ATA_UDMA6,
454338ec570SDarrick J. Wong 	.port_ops = &sas_sata_ops
455338ec570SDarrick J. Wong };
456338ec570SDarrick J. Wong 
457338ec570SDarrick J. Wong int sas_ata_init_host_and_port(struct domain_device *found_dev,
458338ec570SDarrick J. Wong 			       struct scsi_target *starget)
459338ec570SDarrick J. Wong {
460338ec570SDarrick J. Wong 	struct Scsi_Host *shost = dev_to_shost(&starget->dev);
461338ec570SDarrick J. Wong 	struct sas_ha_struct *ha = SHOST_TO_SAS_HA(shost);
462338ec570SDarrick J. Wong 	struct ata_port *ap;
463338ec570SDarrick J. Wong 
464338ec570SDarrick J. Wong 	ata_host_init(&found_dev->sata_dev.ata_host,
4651d1bbee6SJeff Garzik 		      ha->dev,
466338ec570SDarrick J. Wong 		      sata_port_info.flags,
467338ec570SDarrick J. Wong 		      &sas_sata_ops);
468338ec570SDarrick J. Wong 	ap = ata_sas_port_alloc(&found_dev->sata_dev.ata_host,
469338ec570SDarrick J. Wong 				&sata_port_info,
470338ec570SDarrick J. Wong 				shost);
471338ec570SDarrick J. Wong 	if (!ap) {
472338ec570SDarrick J. Wong 		SAS_DPRINTK("ata_sas_port_alloc failed.\n");
473338ec570SDarrick J. Wong 		return -ENODEV;
474338ec570SDarrick J. Wong 	}
475338ec570SDarrick J. Wong 
476338ec570SDarrick J. Wong 	ap->private_data = found_dev;
477338ec570SDarrick J. Wong 	ap->cbl = ATA_CBL_SATA;
478338ec570SDarrick J. Wong 	ap->scsi_host = shost;
479338ec570SDarrick J. Wong 	found_dev->sata_dev.ap = ap;
480338ec570SDarrick J. Wong 
481338ec570SDarrick J. Wong 	return 0;
482338ec570SDarrick J. Wong }
4833a2755afSDarrick J. Wong 
4843a2755afSDarrick J. Wong void sas_ata_task_abort(struct sas_task *task)
4853a2755afSDarrick J. Wong {
4863a2755afSDarrick J. Wong 	struct ata_queued_cmd *qc = task->uldd_task;
4873a2755afSDarrick J. Wong 	struct completion *waiting;
4883a2755afSDarrick J. Wong 
4893a2755afSDarrick J. Wong 	/* Bounce SCSI-initiated commands to the SCSI EH */
4903a2755afSDarrick J. Wong 	if (qc->scsicmd) {
4911b4d0d8eSJames Bottomley 		struct request_queue *q = qc->scsicmd->device->request_queue;
4921b4d0d8eSJames Bottomley 		unsigned long flags;
4931b4d0d8eSJames Bottomley 
49470b25f89STejun Heo 		spin_lock_irqsave(q->queue_lock, flags);
495242f9dcbSJens Axboe 		blk_abort_request(qc->scsicmd->request);
49670b25f89STejun Heo 		spin_unlock_irqrestore(q->queue_lock, flags);
4973a2755afSDarrick J. Wong 		scsi_schedule_eh(qc->scsicmd->device->host);
4983a2755afSDarrick J. Wong 		return;
4993a2755afSDarrick J. Wong 	}
5003a2755afSDarrick J. Wong 
5013a2755afSDarrick J. Wong 	/* Internal command, fake a timeout and complete. */
5023a2755afSDarrick J. Wong 	qc->flags &= ~ATA_QCFLAG_ACTIVE;
5033a2755afSDarrick J. Wong 	qc->flags |= ATA_QCFLAG_FAILED;
5043a2755afSDarrick J. Wong 	qc->err_mask |= AC_ERR_TIMEOUT;
5053a2755afSDarrick J. Wong 	waiting = qc->private_data;
5063a2755afSDarrick J. Wong 	complete(waiting);
5073a2755afSDarrick J. Wong }
508b9142174SJames Bottomley 
509b9142174SJames Bottomley static void sas_get_ata_command_set(struct domain_device *dev)
510b9142174SJames Bottomley {
511b9142174SJames Bottomley 	struct dev_to_host_fis *fis =
512b9142174SJames Bottomley 		(struct dev_to_host_fis *) dev->frame_rcvd;
513b9142174SJames Bottomley 
514b9142174SJames Bottomley 	if ((fis->sector_count == 1 && /* ATA */
515b9142174SJames Bottomley 	     fis->lbal         == 1 &&
516b9142174SJames Bottomley 	     fis->lbam         == 0 &&
517b9142174SJames Bottomley 	     fis->lbah         == 0 &&
518b9142174SJames Bottomley 	     fis->device       == 0)
519b9142174SJames Bottomley 	    ||
520b9142174SJames Bottomley 	    (fis->sector_count == 0 && /* CE-ATA (mATA) */
521b9142174SJames Bottomley 	     fis->lbal         == 0 &&
522b9142174SJames Bottomley 	     fis->lbam         == 0xCE &&
523b9142174SJames Bottomley 	     fis->lbah         == 0xAA &&
524b9142174SJames Bottomley 	     (fis->device & ~0x10) == 0))
525b9142174SJames Bottomley 
526b9142174SJames Bottomley 		dev->sata_dev.command_set = ATA_COMMAND_SET;
527b9142174SJames Bottomley 
528b9142174SJames Bottomley 	else if ((fis->interrupt_reason == 1 &&	/* ATAPI */
529b9142174SJames Bottomley 		  fis->lbal             == 1 &&
530b9142174SJames Bottomley 		  fis->byte_count_low   == 0x14 &&
531b9142174SJames Bottomley 		  fis->byte_count_high  == 0xEB &&
532b9142174SJames Bottomley 		  (fis->device & ~0x10) == 0))
533b9142174SJames Bottomley 
534b9142174SJames Bottomley 		dev->sata_dev.command_set = ATAPI_COMMAND_SET;
535b9142174SJames Bottomley 
536b9142174SJames Bottomley 	else if ((fis->sector_count == 1 && /* SEMB */
537b9142174SJames Bottomley 		  fis->lbal         == 1 &&
538b9142174SJames Bottomley 		  fis->lbam         == 0x3C &&
539b9142174SJames Bottomley 		  fis->lbah         == 0xC3 &&
540b9142174SJames Bottomley 		  fis->device       == 0)
541b9142174SJames Bottomley 		||
542b9142174SJames Bottomley 		 (fis->interrupt_reason == 1 &&	/* SATA PM */
543b9142174SJames Bottomley 		  fis->lbal             == 1 &&
544b9142174SJames Bottomley 		  fis->byte_count_low   == 0x69 &&
545b9142174SJames Bottomley 		  fis->byte_count_high  == 0x96 &&
546b9142174SJames Bottomley 		  (fis->device & ~0x10) == 0))
547b9142174SJames Bottomley 
548b9142174SJames Bottomley 		/* Treat it as a superset? */
549b9142174SJames Bottomley 		dev->sata_dev.command_set = ATAPI_COMMAND_SET;
550b9142174SJames Bottomley }
551b9142174SJames Bottomley 
55287c8331fSDan Williams void sas_probe_sata(struct work_struct *work)
55387c8331fSDan Williams {
55487c8331fSDan Williams 	struct domain_device *dev, *n;
55587c8331fSDan Williams 	struct sas_discovery_event *ev =
55687c8331fSDan Williams 		container_of(work, struct sas_discovery_event, work);
55787c8331fSDan Williams 	struct asd_sas_port *port = ev->port;
55887c8331fSDan Williams 
55987c8331fSDan Williams 	clear_bit(DISCE_PROBE, &port->disc.pending);
56087c8331fSDan Williams 
56187c8331fSDan Williams 	list_for_each_entry_safe(dev, n, &port->disco_list, disco_list_node) {
56287c8331fSDan Williams 		int err;
56387c8331fSDan Williams 
56487c8331fSDan Williams 		spin_lock_irq(&port->dev_list_lock);
56587c8331fSDan Williams 		list_add_tail(&dev->dev_list_node, &port->dev_list);
56687c8331fSDan Williams 		spin_unlock_irq(&port->dev_list_lock);
56787c8331fSDan Williams 
56887c8331fSDan Williams 		err = sas_rphy_add(dev->rphy);
56987c8331fSDan Williams 
57087c8331fSDan Williams 		if (err) {
57187c8331fSDan Williams 			SAS_DPRINTK("%s: for %s device %16llx returned %d\n",
57287c8331fSDan Williams 				    __func__, dev->parent ? "exp-attached" :
57387c8331fSDan Williams 							    "direct-attached",
57487c8331fSDan Williams 				    SAS_ADDR(dev->sas_addr), err);
57587c8331fSDan Williams 			sas_unregister_dev(port, dev);
57687c8331fSDan Williams 		} else
57787c8331fSDan Williams 			list_del_init(&dev->disco_list_node);
57887c8331fSDan Williams 	}
57987c8331fSDan Williams }
58087c8331fSDan Williams 
581b9142174SJames Bottomley /**
582b9142174SJames Bottomley  * sas_discover_sata -- discover an STP/SATA domain device
583b9142174SJames Bottomley  * @dev: pointer to struct domain_device of interest
584b9142174SJames Bottomley  *
585b91bb296SDan Williams  * Devices directly attached to a HA port, have no parents.  All other
586b91bb296SDan Williams  * devices do, and should have their "parent" pointer set appropriately
587b91bb296SDan Williams  * before calling this function.
588b9142174SJames Bottomley  */
589b9142174SJames Bottomley int sas_discover_sata(struct domain_device *dev)
590b9142174SJames Bottomley {
591b9142174SJames Bottomley 	int res;
592b9142174SJames Bottomley 
593b91bb296SDan Williams 	if (dev->dev_type == SATA_PM)
594b91bb296SDan Williams 		return -ENODEV;
595b91bb296SDan Williams 
596b9142174SJames Bottomley 	sas_get_ata_command_set(dev);
597b91bb296SDan Williams 	sas_fill_in_rphy(dev, dev->rphy);
59887c8331fSDan Williams 
59987c8331fSDan Williams 	res = sas_notify_lldd_dev_found(dev);
60087c8331fSDan Williams 	if (res)
60187c8331fSDan Williams 		return res;
60287c8331fSDan Williams 
60387c8331fSDan Williams 	sas_discover_event(dev->port, DISCE_PROBE);
604b91bb296SDan Williams 	return 0;
605b9142174SJames Bottomley }
60600dd4998SJames Bottomley 
60700dd4998SJames Bottomley void sas_ata_strategy_handler(struct Scsi_Host *shost)
60800dd4998SJames Bottomley {
60900dd4998SJames Bottomley 	struct scsi_device *sdev;
61087c8331fSDan Williams 	struct sas_ha_struct *sas_ha = SHOST_TO_SAS_HA(shost);
61187c8331fSDan Williams 
61287c8331fSDan Williams 	/* it's ok to defer revalidation events during ata eh, these
61387c8331fSDan Williams 	 * disks are in one of three states:
61487c8331fSDan Williams 	 * 1/ present for initial domain discovery, and these
61587c8331fSDan Williams 	 *    resets will cause bcn flutters
61687c8331fSDan Williams 	 * 2/ hot removed, we'll discover that after eh fails
61787c8331fSDan Williams 	 * 3/ hot added after initial discovery, lost the race, and need
61887c8331fSDan Williams 	 *    to catch the next train.
61987c8331fSDan Williams 	 */
62087c8331fSDan Williams 	sas_disable_revalidation(sas_ha);
62100dd4998SJames Bottomley 
62200dd4998SJames Bottomley 	shost_for_each_device(sdev, shost) {
62300dd4998SJames Bottomley 		struct domain_device *ddev = sdev_to_domain_dev(sdev);
62400dd4998SJames Bottomley 		struct ata_port *ap = ddev->sata_dev.ap;
62500dd4998SJames Bottomley 
62600dd4998SJames Bottomley 		if (!dev_is_sata(ddev))
62700dd4998SJames Bottomley 			continue;
62800dd4998SJames Bottomley 
62900dd4998SJames Bottomley 		ata_port_printk(ap, KERN_DEBUG, "sas eh calling libata port error handler");
63000dd4998SJames Bottomley 		ata_scsi_port_error_handler(shost, ap);
63100dd4998SJames Bottomley 	}
63287c8331fSDan Williams 
63387c8331fSDan Williams 	sas_enable_revalidation(sas_ha);
63400dd4998SJames Bottomley }
63500dd4998SJames Bottomley 
63600dd4998SJames Bottomley int sas_ata_timed_out(struct scsi_cmnd *cmd, struct sas_task *task,
63700dd4998SJames Bottomley 		      enum blk_eh_timer_return *rtn)
63800dd4998SJames Bottomley {
63900dd4998SJames Bottomley 	struct domain_device *ddev = cmd_to_domain_dev(cmd);
64000dd4998SJames Bottomley 
64100dd4998SJames Bottomley 	if (!dev_is_sata(ddev) || task)
64200dd4998SJames Bottomley 		return 0;
64300dd4998SJames Bottomley 
64400dd4998SJames Bottomley 	/* we're a sata device with no task, so this must be a libata
64500dd4998SJames Bottomley 	 * eh timeout.  Ideally should hook into libata timeout
64600dd4998SJames Bottomley 	 * handling, but there's no point, it just wants to activate
64700dd4998SJames Bottomley 	 * the eh thread */
64800dd4998SJames Bottomley 	*rtn = BLK_EH_NOT_HANDLED;
64900dd4998SJames Bottomley 	return 1;
65000dd4998SJames Bottomley }
65100dd4998SJames Bottomley 
65200dd4998SJames Bottomley int sas_ata_eh(struct Scsi_Host *shost, struct list_head *work_q,
65300dd4998SJames Bottomley 	       struct list_head *done_q)
65400dd4998SJames Bottomley {
65500dd4998SJames Bottomley 	int rtn = 0;
65600dd4998SJames Bottomley 	struct scsi_cmnd *cmd, *n;
65700dd4998SJames Bottomley 	struct ata_port *ap;
65800dd4998SJames Bottomley 
65900dd4998SJames Bottomley 	do {
66000dd4998SJames Bottomley 		LIST_HEAD(sata_q);
66100dd4998SJames Bottomley 
66200dd4998SJames Bottomley 		ap = NULL;
66300dd4998SJames Bottomley 
66400dd4998SJames Bottomley 		list_for_each_entry_safe(cmd, n, work_q, eh_entry) {
66500dd4998SJames Bottomley 			struct domain_device *ddev = cmd_to_domain_dev(cmd);
66600dd4998SJames Bottomley 
66700dd4998SJames Bottomley 			if (!dev_is_sata(ddev) || TO_SAS_TASK(cmd))
66800dd4998SJames Bottomley 				continue;
66900dd4998SJames Bottomley 			if (ap && ap != ddev->sata_dev.ap)
67000dd4998SJames Bottomley 				continue;
67100dd4998SJames Bottomley 			ap = ddev->sata_dev.ap;
67200dd4998SJames Bottomley 			rtn = 1;
67300dd4998SJames Bottomley 			list_move(&cmd->eh_entry, &sata_q);
67400dd4998SJames Bottomley 		}
67500dd4998SJames Bottomley 
67600dd4998SJames Bottomley 		if (!list_empty(&sata_q)) {
67700dd4998SJames Bottomley 			ata_port_printk(ap, KERN_DEBUG, "sas eh calling libata cmd error handler\n");
67800dd4998SJames Bottomley 			ata_scsi_cmd_error_handler(shost, ap, &sata_q);
679a82058a7SJames Bottomley 			/*
680a82058a7SJames Bottomley 			 * ata's error handler may leave the cmd on the list
681a82058a7SJames Bottomley 			 * so make sure they don't remain on a stack list
682a82058a7SJames Bottomley 			 * about to go out of scope.
683a82058a7SJames Bottomley 			 *
684a82058a7SJames Bottomley 			 * This looks strange, since the commands are
685a82058a7SJames Bottomley 			 * now part of no list, but the next error
686a82058a7SJames Bottomley 			 * action will be ata_port_error_handler()
687a82058a7SJames Bottomley 			 * which takes no list and sweeps them up
688a82058a7SJames Bottomley 			 * anyway from the ata tag array.
689a82058a7SJames Bottomley 			 */
690a82058a7SJames Bottomley 			while (!list_empty(&sata_q))
691a82058a7SJames Bottomley 				list_del_init(sata_q.next);
69200dd4998SJames Bottomley 		}
69300dd4998SJames Bottomley 	} while (ap);
69400dd4998SJames Bottomley 
69500dd4998SJames Bottomley 	return rtn;
69600dd4998SJames Bottomley }
697