xref: /openbmc/linux/drivers/regulator/max8649.c (revision a71b797fdc672714bfff1fdc142042a95e97d7ba)
1*a71b797fSHaojian Zhuang /*
2*a71b797fSHaojian Zhuang  * Regulators driver for Maxim max8649
3*a71b797fSHaojian Zhuang  *
4*a71b797fSHaojian Zhuang  * Copyright (C) 2009-2010 Marvell International Ltd.
5*a71b797fSHaojian Zhuang  *      Haojian Zhuang <haojian.zhuang@marvell.com>
6*a71b797fSHaojian Zhuang  *
7*a71b797fSHaojian Zhuang  * This program is free software; you can redistribute it and/or modify
8*a71b797fSHaojian Zhuang  * it under the terms of the GNU General Public License version 2 as
9*a71b797fSHaojian Zhuang  * published by the Free Software Foundation.
10*a71b797fSHaojian Zhuang  */
11*a71b797fSHaojian Zhuang #include <linux/kernel.h>
12*a71b797fSHaojian Zhuang #include <linux/module.h>
13*a71b797fSHaojian Zhuang #include <linux/err.h>
14*a71b797fSHaojian Zhuang #include <linux/i2c.h>
15*a71b797fSHaojian Zhuang #include <linux/platform_device.h>
16*a71b797fSHaojian Zhuang #include <linux/regulator/driver.h>
17*a71b797fSHaojian Zhuang #include <linux/regulator/max8649.h>
18*a71b797fSHaojian Zhuang 
19*a71b797fSHaojian Zhuang #define MAX8649_DCDC_VMIN	750000		/* uV */
20*a71b797fSHaojian Zhuang #define MAX8649_DCDC_VMAX	1380000		/* uV */
21*a71b797fSHaojian Zhuang #define MAX8649_DCDC_STEP	10000		/* uV */
22*a71b797fSHaojian Zhuang #define MAX8649_VOL_MASK	0x3f
23*a71b797fSHaojian Zhuang 
24*a71b797fSHaojian Zhuang /* Registers */
25*a71b797fSHaojian Zhuang #define MAX8649_MODE0		0x00
26*a71b797fSHaojian Zhuang #define MAX8649_MODE1		0x01
27*a71b797fSHaojian Zhuang #define MAX8649_MODE2		0x02
28*a71b797fSHaojian Zhuang #define MAX8649_MODE3		0x03
29*a71b797fSHaojian Zhuang #define MAX8649_CONTROL		0x04
30*a71b797fSHaojian Zhuang #define MAX8649_SYNC		0x05
31*a71b797fSHaojian Zhuang #define MAX8649_RAMP		0x06
32*a71b797fSHaojian Zhuang #define MAX8649_CHIP_ID1	0x08
33*a71b797fSHaojian Zhuang #define MAX8649_CHIP_ID2	0x09
34*a71b797fSHaojian Zhuang 
35*a71b797fSHaojian Zhuang /* Bits */
36*a71b797fSHaojian Zhuang #define MAX8649_EN_PD		(1 << 7)
37*a71b797fSHaojian Zhuang #define MAX8649_VID0_PD		(1 << 6)
38*a71b797fSHaojian Zhuang #define MAX8649_VID1_PD		(1 << 5)
39*a71b797fSHaojian Zhuang #define MAX8649_VID_MASK	(3 << 5)
40*a71b797fSHaojian Zhuang 
41*a71b797fSHaojian Zhuang #define MAX8649_FORCE_PWM	(1 << 7)
42*a71b797fSHaojian Zhuang #define MAX8649_SYNC_EXTCLK	(1 << 6)
43*a71b797fSHaojian Zhuang 
44*a71b797fSHaojian Zhuang #define MAX8649_EXT_MASK	(3 << 6)
45*a71b797fSHaojian Zhuang 
46*a71b797fSHaojian Zhuang #define MAX8649_RAMP_MASK	(7 << 5)
47*a71b797fSHaojian Zhuang #define MAX8649_RAMP_DOWN	(1 << 1)
48*a71b797fSHaojian Zhuang 
49*a71b797fSHaojian Zhuang struct max8649_regulator_info {
50*a71b797fSHaojian Zhuang 	struct regulator_dev	*regulator;
51*a71b797fSHaojian Zhuang 	struct i2c_client	*i2c;
52*a71b797fSHaojian Zhuang 	struct device		*dev;
53*a71b797fSHaojian Zhuang 	struct mutex		io_lock;
54*a71b797fSHaojian Zhuang 
55*a71b797fSHaojian Zhuang 	int		vol_reg;
56*a71b797fSHaojian Zhuang 	unsigned	mode:2;	/* bit[1:0] = VID1, VID0 */
57*a71b797fSHaojian Zhuang 	unsigned	extclk_freq:2;
58*a71b797fSHaojian Zhuang 	unsigned	extclk:1;
59*a71b797fSHaojian Zhuang 	unsigned	ramp_timing:3;
60*a71b797fSHaojian Zhuang 	unsigned	ramp_down:1;
61*a71b797fSHaojian Zhuang };
62*a71b797fSHaojian Zhuang 
63*a71b797fSHaojian Zhuang /* I2C operations */
64*a71b797fSHaojian Zhuang 
65*a71b797fSHaojian Zhuang static inline int max8649_read_device(struct i2c_client *i2c,
66*a71b797fSHaojian Zhuang 				      int reg, int bytes, void *dest)
67*a71b797fSHaojian Zhuang {
68*a71b797fSHaojian Zhuang 	unsigned char data;
69*a71b797fSHaojian Zhuang 	int ret;
70*a71b797fSHaojian Zhuang 
71*a71b797fSHaojian Zhuang 	data = (unsigned char)reg;
72*a71b797fSHaojian Zhuang 	ret = i2c_master_send(i2c, &data, 1);
73*a71b797fSHaojian Zhuang 	if (ret < 0)
74*a71b797fSHaojian Zhuang 		return ret;
75*a71b797fSHaojian Zhuang 	ret = i2c_master_recv(i2c, dest, bytes);
76*a71b797fSHaojian Zhuang 	if (ret < 0)
77*a71b797fSHaojian Zhuang 		return ret;
78*a71b797fSHaojian Zhuang 	return 0;
79*a71b797fSHaojian Zhuang }
80*a71b797fSHaojian Zhuang 
81*a71b797fSHaojian Zhuang static inline int max8649_write_device(struct i2c_client *i2c,
82*a71b797fSHaojian Zhuang 				       int reg, int bytes, void *src)
83*a71b797fSHaojian Zhuang {
84*a71b797fSHaojian Zhuang 	unsigned char buf[bytes + 1];
85*a71b797fSHaojian Zhuang 	int ret;
86*a71b797fSHaojian Zhuang 
87*a71b797fSHaojian Zhuang 	buf[0] = (unsigned char)reg;
88*a71b797fSHaojian Zhuang 	memcpy(&buf[1], src, bytes);
89*a71b797fSHaojian Zhuang 
90*a71b797fSHaojian Zhuang 	ret = i2c_master_send(i2c, buf, bytes + 1);
91*a71b797fSHaojian Zhuang 	if (ret < 0)
92*a71b797fSHaojian Zhuang 		return ret;
93*a71b797fSHaojian Zhuang 	return 0;
94*a71b797fSHaojian Zhuang }
95*a71b797fSHaojian Zhuang 
96*a71b797fSHaojian Zhuang static int max8649_reg_read(struct i2c_client *i2c, int reg)
97*a71b797fSHaojian Zhuang {
98*a71b797fSHaojian Zhuang 	struct max8649_regulator_info *info = i2c_get_clientdata(i2c);
99*a71b797fSHaojian Zhuang 	unsigned char data;
100*a71b797fSHaojian Zhuang 	int ret;
101*a71b797fSHaojian Zhuang 
102*a71b797fSHaojian Zhuang 	mutex_lock(&info->io_lock);
103*a71b797fSHaojian Zhuang 	ret = max8649_read_device(i2c, reg, 1, &data);
104*a71b797fSHaojian Zhuang 	mutex_unlock(&info->io_lock);
105*a71b797fSHaojian Zhuang 
106*a71b797fSHaojian Zhuang 	if (ret < 0)
107*a71b797fSHaojian Zhuang 		return ret;
108*a71b797fSHaojian Zhuang 	return (int)data;
109*a71b797fSHaojian Zhuang }
110*a71b797fSHaojian Zhuang 
111*a71b797fSHaojian Zhuang static int max8649_set_bits(struct i2c_client *i2c, int reg,
112*a71b797fSHaojian Zhuang 			    unsigned char mask, unsigned char data)
113*a71b797fSHaojian Zhuang {
114*a71b797fSHaojian Zhuang 	struct max8649_regulator_info *info = i2c_get_clientdata(i2c);
115*a71b797fSHaojian Zhuang 	unsigned char value;
116*a71b797fSHaojian Zhuang 	int ret;
117*a71b797fSHaojian Zhuang 
118*a71b797fSHaojian Zhuang 	mutex_lock(&info->io_lock);
119*a71b797fSHaojian Zhuang 	ret = max8649_read_device(i2c, reg, 1, &value);
120*a71b797fSHaojian Zhuang 	if (ret < 0)
121*a71b797fSHaojian Zhuang 		goto out;
122*a71b797fSHaojian Zhuang 	value &= ~mask;
123*a71b797fSHaojian Zhuang 	value |= data;
124*a71b797fSHaojian Zhuang 	ret = max8649_write_device(i2c, reg, 1, &value);
125*a71b797fSHaojian Zhuang out:
126*a71b797fSHaojian Zhuang 	mutex_unlock(&info->io_lock);
127*a71b797fSHaojian Zhuang 	return ret;
128*a71b797fSHaojian Zhuang }
129*a71b797fSHaojian Zhuang 
130*a71b797fSHaojian Zhuang static inline int check_range(int min_uV, int max_uV)
131*a71b797fSHaojian Zhuang {
132*a71b797fSHaojian Zhuang 	if ((min_uV < MAX8649_DCDC_VMIN) || (max_uV > MAX8649_DCDC_VMAX)
133*a71b797fSHaojian Zhuang 		|| (min_uV > max_uV))
134*a71b797fSHaojian Zhuang 		return -EINVAL;
135*a71b797fSHaojian Zhuang 	return 0;
136*a71b797fSHaojian Zhuang }
137*a71b797fSHaojian Zhuang 
138*a71b797fSHaojian Zhuang static int max8649_list_voltage(struct regulator_dev *rdev, unsigned index)
139*a71b797fSHaojian Zhuang {
140*a71b797fSHaojian Zhuang 	return (MAX8649_DCDC_VMIN + index * MAX8649_DCDC_STEP);
141*a71b797fSHaojian Zhuang }
142*a71b797fSHaojian Zhuang 
143*a71b797fSHaojian Zhuang static int max8649_get_voltage(struct regulator_dev *rdev)
144*a71b797fSHaojian Zhuang {
145*a71b797fSHaojian Zhuang 	struct max8649_regulator_info *info = rdev_get_drvdata(rdev);
146*a71b797fSHaojian Zhuang 	unsigned char data;
147*a71b797fSHaojian Zhuang 	int ret;
148*a71b797fSHaojian Zhuang 
149*a71b797fSHaojian Zhuang 	ret = max8649_reg_read(info->i2c, info->vol_reg);
150*a71b797fSHaojian Zhuang 	if (ret < 0)
151*a71b797fSHaojian Zhuang 		return ret;
152*a71b797fSHaojian Zhuang 	data = (unsigned char)ret & MAX8649_VOL_MASK;
153*a71b797fSHaojian Zhuang 	return max8649_list_voltage(rdev, data);
154*a71b797fSHaojian Zhuang }
155*a71b797fSHaojian Zhuang 
156*a71b797fSHaojian Zhuang static int max8649_set_voltage(struct regulator_dev *rdev,
157*a71b797fSHaojian Zhuang 			       int min_uV, int max_uV)
158*a71b797fSHaojian Zhuang {
159*a71b797fSHaojian Zhuang 	struct max8649_regulator_info *info = rdev_get_drvdata(rdev);
160*a71b797fSHaojian Zhuang 	unsigned char data, mask;
161*a71b797fSHaojian Zhuang 
162*a71b797fSHaojian Zhuang 	if (check_range(min_uV, max_uV)) {
163*a71b797fSHaojian Zhuang 		dev_err(info->dev, "invalid voltage range (%d, %d) uV\n",
164*a71b797fSHaojian Zhuang 			min_uV, max_uV);
165*a71b797fSHaojian Zhuang 		return -EINVAL;
166*a71b797fSHaojian Zhuang 	}
167*a71b797fSHaojian Zhuang 	data = (min_uV - MAX8649_DCDC_VMIN + MAX8649_DCDC_STEP - 1)
168*a71b797fSHaojian Zhuang 		/ MAX8649_DCDC_STEP;
169*a71b797fSHaojian Zhuang 	mask = MAX8649_VOL_MASK;
170*a71b797fSHaojian Zhuang 
171*a71b797fSHaojian Zhuang 	return max8649_set_bits(info->i2c, info->vol_reg, mask, data);
172*a71b797fSHaojian Zhuang }
173*a71b797fSHaojian Zhuang 
174*a71b797fSHaojian Zhuang /* EN_PD means pulldown on EN input */
175*a71b797fSHaojian Zhuang static int max8649_enable(struct regulator_dev *rdev)
176*a71b797fSHaojian Zhuang {
177*a71b797fSHaojian Zhuang 	struct max8649_regulator_info *info = rdev_get_drvdata(rdev);
178*a71b797fSHaojian Zhuang 	return max8649_set_bits(info->i2c, MAX8649_CONTROL, MAX8649_EN_PD, 0);
179*a71b797fSHaojian Zhuang }
180*a71b797fSHaojian Zhuang 
181*a71b797fSHaojian Zhuang /*
182*a71b797fSHaojian Zhuang  * Applied internal pulldown resistor on EN input pin.
183*a71b797fSHaojian Zhuang  * If pulldown EN pin outside, it would be better.
184*a71b797fSHaojian Zhuang  */
185*a71b797fSHaojian Zhuang static int max8649_disable(struct regulator_dev *rdev)
186*a71b797fSHaojian Zhuang {
187*a71b797fSHaojian Zhuang 	struct max8649_regulator_info *info = rdev_get_drvdata(rdev);
188*a71b797fSHaojian Zhuang 	return max8649_set_bits(info->i2c, MAX8649_CONTROL, MAX8649_EN_PD,
189*a71b797fSHaojian Zhuang 				MAX8649_EN_PD);
190*a71b797fSHaojian Zhuang }
191*a71b797fSHaojian Zhuang 
192*a71b797fSHaojian Zhuang static int max8649_is_enabled(struct regulator_dev *rdev)
193*a71b797fSHaojian Zhuang {
194*a71b797fSHaojian Zhuang 	struct max8649_regulator_info *info = rdev_get_drvdata(rdev);
195*a71b797fSHaojian Zhuang 	int ret;
196*a71b797fSHaojian Zhuang 
197*a71b797fSHaojian Zhuang 	ret = max8649_reg_read(info->i2c, MAX8649_CONTROL);
198*a71b797fSHaojian Zhuang 	if (ret < 0)
199*a71b797fSHaojian Zhuang 		return ret;
200*a71b797fSHaojian Zhuang 	return !((unsigned char)ret & MAX8649_EN_PD);
201*a71b797fSHaojian Zhuang }
202*a71b797fSHaojian Zhuang 
203*a71b797fSHaojian Zhuang static int max8649_enable_time(struct regulator_dev *rdev)
204*a71b797fSHaojian Zhuang {
205*a71b797fSHaojian Zhuang 	struct max8649_regulator_info *info = rdev_get_drvdata(rdev);
206*a71b797fSHaojian Zhuang 	int voltage, rate, ret;
207*a71b797fSHaojian Zhuang 
208*a71b797fSHaojian Zhuang 	/* get voltage */
209*a71b797fSHaojian Zhuang 	ret = max8649_reg_read(info->i2c, info->vol_reg);
210*a71b797fSHaojian Zhuang 	if (ret < 0)
211*a71b797fSHaojian Zhuang 		return ret;
212*a71b797fSHaojian Zhuang 	ret &= MAX8649_VOL_MASK;
213*a71b797fSHaojian Zhuang 	voltage = max8649_list_voltage(rdev, (unsigned char)ret); /* uV */
214*a71b797fSHaojian Zhuang 
215*a71b797fSHaojian Zhuang 	/* get rate */
216*a71b797fSHaojian Zhuang 	ret = max8649_reg_read(info->i2c, MAX8649_RAMP);
217*a71b797fSHaojian Zhuang 	if (ret < 0)
218*a71b797fSHaojian Zhuang 		return ret;
219*a71b797fSHaojian Zhuang 	ret = (ret & MAX8649_RAMP_MASK) >> 5;
220*a71b797fSHaojian Zhuang 	rate = (32 * 1000) >> ret;	/* uV/uS */
221*a71b797fSHaojian Zhuang 
222*a71b797fSHaojian Zhuang 	return (voltage / rate);
223*a71b797fSHaojian Zhuang }
224*a71b797fSHaojian Zhuang 
225*a71b797fSHaojian Zhuang static int max8649_set_mode(struct regulator_dev *rdev, unsigned int mode)
226*a71b797fSHaojian Zhuang {
227*a71b797fSHaojian Zhuang 	struct max8649_regulator_info *info = rdev_get_drvdata(rdev);
228*a71b797fSHaojian Zhuang 
229*a71b797fSHaojian Zhuang 	switch (mode) {
230*a71b797fSHaojian Zhuang 	case REGULATOR_MODE_FAST:
231*a71b797fSHaojian Zhuang 		max8649_set_bits(info->i2c, info->vol_reg, MAX8649_FORCE_PWM,
232*a71b797fSHaojian Zhuang 				 MAX8649_FORCE_PWM);
233*a71b797fSHaojian Zhuang 		break;
234*a71b797fSHaojian Zhuang 	case REGULATOR_MODE_NORMAL:
235*a71b797fSHaojian Zhuang 		max8649_set_bits(info->i2c, info->vol_reg,
236*a71b797fSHaojian Zhuang 				 MAX8649_FORCE_PWM, 0);
237*a71b797fSHaojian Zhuang 		break;
238*a71b797fSHaojian Zhuang 	default:
239*a71b797fSHaojian Zhuang 		return -EINVAL;
240*a71b797fSHaojian Zhuang 	}
241*a71b797fSHaojian Zhuang 	return 0;
242*a71b797fSHaojian Zhuang }
243*a71b797fSHaojian Zhuang 
244*a71b797fSHaojian Zhuang static unsigned int max8649_get_mode(struct regulator_dev *rdev)
245*a71b797fSHaojian Zhuang {
246*a71b797fSHaojian Zhuang 	struct max8649_regulator_info *info = rdev_get_drvdata(rdev);
247*a71b797fSHaojian Zhuang 	int ret;
248*a71b797fSHaojian Zhuang 
249*a71b797fSHaojian Zhuang 	ret = max8649_reg_read(info->i2c, info->vol_reg);
250*a71b797fSHaojian Zhuang 	if (ret & MAX8649_FORCE_PWM)
251*a71b797fSHaojian Zhuang 		return REGULATOR_MODE_FAST;
252*a71b797fSHaojian Zhuang 	return REGULATOR_MODE_NORMAL;
253*a71b797fSHaojian Zhuang }
254*a71b797fSHaojian Zhuang 
255*a71b797fSHaojian Zhuang static struct regulator_ops max8649_dcdc_ops = {
256*a71b797fSHaojian Zhuang 	.set_voltage	= max8649_set_voltage,
257*a71b797fSHaojian Zhuang 	.get_voltage	= max8649_get_voltage,
258*a71b797fSHaojian Zhuang 	.list_voltage	= max8649_list_voltage,
259*a71b797fSHaojian Zhuang 	.enable		= max8649_enable,
260*a71b797fSHaojian Zhuang 	.disable	= max8649_disable,
261*a71b797fSHaojian Zhuang 	.is_enabled	= max8649_is_enabled,
262*a71b797fSHaojian Zhuang 	.enable_time	= max8649_enable_time,
263*a71b797fSHaojian Zhuang 	.set_mode	= max8649_set_mode,
264*a71b797fSHaojian Zhuang 	.get_mode	= max8649_get_mode,
265*a71b797fSHaojian Zhuang 
266*a71b797fSHaojian Zhuang };
267*a71b797fSHaojian Zhuang 
268*a71b797fSHaojian Zhuang static struct regulator_desc dcdc_desc = {
269*a71b797fSHaojian Zhuang 	.name		= "max8649",
270*a71b797fSHaojian Zhuang 	.ops		= &max8649_dcdc_ops,
271*a71b797fSHaojian Zhuang 	.type		= REGULATOR_VOLTAGE,
272*a71b797fSHaojian Zhuang 	.n_voltages	= 1 << 6,
273*a71b797fSHaojian Zhuang 	.owner		= THIS_MODULE,
274*a71b797fSHaojian Zhuang };
275*a71b797fSHaojian Zhuang 
276*a71b797fSHaojian Zhuang static int __devinit max8649_regulator_probe(struct i2c_client *client,
277*a71b797fSHaojian Zhuang 					     const struct i2c_device_id *id)
278*a71b797fSHaojian Zhuang {
279*a71b797fSHaojian Zhuang 	struct max8649_platform_data *pdata = client->dev.platform_data;
280*a71b797fSHaojian Zhuang 	struct max8649_regulator_info *info = NULL;
281*a71b797fSHaojian Zhuang 	unsigned char data;
282*a71b797fSHaojian Zhuang 	int ret;
283*a71b797fSHaojian Zhuang 
284*a71b797fSHaojian Zhuang 	info = kzalloc(sizeof(struct max8649_regulator_info), GFP_KERNEL);
285*a71b797fSHaojian Zhuang 	if (!info) {
286*a71b797fSHaojian Zhuang 		dev_err(&client->dev, "No enough memory\n");
287*a71b797fSHaojian Zhuang 		return -ENOMEM;
288*a71b797fSHaojian Zhuang 	}
289*a71b797fSHaojian Zhuang 
290*a71b797fSHaojian Zhuang 	info->i2c = client;
291*a71b797fSHaojian Zhuang 	info->dev = &client->dev;
292*a71b797fSHaojian Zhuang 	mutex_init(&info->io_lock);
293*a71b797fSHaojian Zhuang 	i2c_set_clientdata(client, info);
294*a71b797fSHaojian Zhuang 
295*a71b797fSHaojian Zhuang 	info->mode = pdata->mode;
296*a71b797fSHaojian Zhuang 	switch (info->mode) {
297*a71b797fSHaojian Zhuang 	case 0:
298*a71b797fSHaojian Zhuang 		info->vol_reg = MAX8649_MODE0;
299*a71b797fSHaojian Zhuang 		break;
300*a71b797fSHaojian Zhuang 	case 1:
301*a71b797fSHaojian Zhuang 		info->vol_reg = MAX8649_MODE1;
302*a71b797fSHaojian Zhuang 		break;
303*a71b797fSHaojian Zhuang 	case 2:
304*a71b797fSHaojian Zhuang 		info->vol_reg = MAX8649_MODE2;
305*a71b797fSHaojian Zhuang 		break;
306*a71b797fSHaojian Zhuang 	case 3:
307*a71b797fSHaojian Zhuang 		info->vol_reg = MAX8649_MODE3;
308*a71b797fSHaojian Zhuang 		break;
309*a71b797fSHaojian Zhuang 	default:
310*a71b797fSHaojian Zhuang 		break;
311*a71b797fSHaojian Zhuang 	}
312*a71b797fSHaojian Zhuang 
313*a71b797fSHaojian Zhuang 	ret = max8649_reg_read(info->i2c, MAX8649_CHIP_ID1);
314*a71b797fSHaojian Zhuang 	if (ret < 0) {
315*a71b797fSHaojian Zhuang 		dev_err(info->dev, "Failed to detect ID of MAX8649:%d\n",
316*a71b797fSHaojian Zhuang 			ret);
317*a71b797fSHaojian Zhuang 		goto out;
318*a71b797fSHaojian Zhuang 	}
319*a71b797fSHaojian Zhuang 	dev_info(info->dev, "Detected MAX8649 (ID:%x)\n", ret);
320*a71b797fSHaojian Zhuang 
321*a71b797fSHaojian Zhuang 	/* enable VID0 & VID1 */
322*a71b797fSHaojian Zhuang 	max8649_set_bits(info->i2c, MAX8649_CONTROL, MAX8649_VID_MASK, 0);
323*a71b797fSHaojian Zhuang 
324*a71b797fSHaojian Zhuang 	/* enable/disable external clock synchronization */
325*a71b797fSHaojian Zhuang 	info->extclk = pdata->extclk;
326*a71b797fSHaojian Zhuang 	data = (info->extclk) ? MAX8649_SYNC_EXTCLK : 0;
327*a71b797fSHaojian Zhuang 	max8649_set_bits(info->i2c, info->vol_reg, MAX8649_SYNC_EXTCLK, data);
328*a71b797fSHaojian Zhuang 	if (info->extclk) {
329*a71b797fSHaojian Zhuang 		/* set external clock frequency */
330*a71b797fSHaojian Zhuang 		info->extclk_freq = pdata->extclk_freq;
331*a71b797fSHaojian Zhuang 		max8649_set_bits(info->i2c, MAX8649_SYNC, MAX8649_EXT_MASK,
332*a71b797fSHaojian Zhuang 				 info->extclk_freq);
333*a71b797fSHaojian Zhuang 	}
334*a71b797fSHaojian Zhuang 
335*a71b797fSHaojian Zhuang 	if (pdata->ramp_timing) {
336*a71b797fSHaojian Zhuang 		info->ramp_timing = pdata->ramp_timing;
337*a71b797fSHaojian Zhuang 		max8649_set_bits(info->i2c, MAX8649_RAMP, MAX8649_RAMP_MASK,
338*a71b797fSHaojian Zhuang 				 info->ramp_timing << 5);
339*a71b797fSHaojian Zhuang 	}
340*a71b797fSHaojian Zhuang 
341*a71b797fSHaojian Zhuang 	info->ramp_down = pdata->ramp_down;
342*a71b797fSHaojian Zhuang 	if (info->ramp_down) {
343*a71b797fSHaojian Zhuang 		max8649_set_bits(info->i2c, MAX8649_RAMP, MAX8649_RAMP_DOWN,
344*a71b797fSHaojian Zhuang 				 MAX8649_RAMP_DOWN);
345*a71b797fSHaojian Zhuang 	}
346*a71b797fSHaojian Zhuang 
347*a71b797fSHaojian Zhuang 	info->regulator = regulator_register(&dcdc_desc, &client->dev,
348*a71b797fSHaojian Zhuang 					     pdata->regulator, info);
349*a71b797fSHaojian Zhuang 	if (IS_ERR(info->regulator)) {
350*a71b797fSHaojian Zhuang 		dev_err(info->dev, "failed to register regulator %s\n",
351*a71b797fSHaojian Zhuang 			dcdc_desc.name);
352*a71b797fSHaojian Zhuang 		ret = PTR_ERR(info->regulator);
353*a71b797fSHaojian Zhuang 		goto out;
354*a71b797fSHaojian Zhuang 	}
355*a71b797fSHaojian Zhuang 
356*a71b797fSHaojian Zhuang 	dev_info(info->dev, "Max8649 regulator device is detected.\n");
357*a71b797fSHaojian Zhuang 	return 0;
358*a71b797fSHaojian Zhuang out:
359*a71b797fSHaojian Zhuang 	kfree(info);
360*a71b797fSHaojian Zhuang 	return ret;
361*a71b797fSHaojian Zhuang }
362*a71b797fSHaojian Zhuang 
363*a71b797fSHaojian Zhuang static int __devexit max8649_regulator_remove(struct i2c_client *client)
364*a71b797fSHaojian Zhuang {
365*a71b797fSHaojian Zhuang 	struct max8649_regulator_info *info = i2c_get_clientdata(client);
366*a71b797fSHaojian Zhuang 
367*a71b797fSHaojian Zhuang 	if (info) {
368*a71b797fSHaojian Zhuang 		if (info->regulator)
369*a71b797fSHaojian Zhuang 			regulator_unregister(info->regulator);
370*a71b797fSHaojian Zhuang 		kfree(info);
371*a71b797fSHaojian Zhuang 	}
372*a71b797fSHaojian Zhuang 	i2c_set_clientdata(client, NULL);
373*a71b797fSHaojian Zhuang 
374*a71b797fSHaojian Zhuang 	return 0;
375*a71b797fSHaojian Zhuang }
376*a71b797fSHaojian Zhuang 
377*a71b797fSHaojian Zhuang static const struct i2c_device_id max8649_id[] = {
378*a71b797fSHaojian Zhuang 	{ "max8649", 0 },
379*a71b797fSHaojian Zhuang 	{ }
380*a71b797fSHaojian Zhuang };
381*a71b797fSHaojian Zhuang MODULE_DEVICE_TABLE(i2c, max8649_id);
382*a71b797fSHaojian Zhuang 
383*a71b797fSHaojian Zhuang static struct i2c_driver max8649_driver = {
384*a71b797fSHaojian Zhuang 	.probe		= max8649_regulator_probe,
385*a71b797fSHaojian Zhuang 	.remove		= __devexit_p(max8649_regulator_remove),
386*a71b797fSHaojian Zhuang 	.driver		= {
387*a71b797fSHaojian Zhuang 		.name	= "max8649",
388*a71b797fSHaojian Zhuang 	},
389*a71b797fSHaojian Zhuang 	.id_table	= max8649_id,
390*a71b797fSHaojian Zhuang };
391*a71b797fSHaojian Zhuang 
392*a71b797fSHaojian Zhuang static int __init max8649_init(void)
393*a71b797fSHaojian Zhuang {
394*a71b797fSHaojian Zhuang 	return i2c_add_driver(&max8649_driver);
395*a71b797fSHaojian Zhuang }
396*a71b797fSHaojian Zhuang subsys_initcall(max8649_init);
397*a71b797fSHaojian Zhuang 
398*a71b797fSHaojian Zhuang static void __exit max8649_exit(void)
399*a71b797fSHaojian Zhuang {
400*a71b797fSHaojian Zhuang 	i2c_del_driver(&max8649_driver);
401*a71b797fSHaojian Zhuang }
402*a71b797fSHaojian Zhuang module_exit(max8649_exit);
403*a71b797fSHaojian Zhuang 
404*a71b797fSHaojian Zhuang /* Module information */
405*a71b797fSHaojian Zhuang MODULE_DESCRIPTION("MAXIM 8649 voltage regulator driver");
406*a71b797fSHaojian Zhuang MODULE_AUTHOR("Haojian Zhuang <haojian.zhuang@marvell.com>");
407*a71b797fSHaojian Zhuang MODULE_LICENSE("GPL");
408*a71b797fSHaojian Zhuang 
409