xref: /openbmc/linux/drivers/regulator/max8649.c (revision 5a0e3ad6af8660be21ca98a971cd00f331318c05)
1a71b797fSHaojian Zhuang /*
2a71b797fSHaojian Zhuang  * Regulators driver for Maxim max8649
3a71b797fSHaojian Zhuang  *
4a71b797fSHaojian Zhuang  * Copyright (C) 2009-2010 Marvell International Ltd.
5a71b797fSHaojian Zhuang  *      Haojian Zhuang <haojian.zhuang@marvell.com>
6a71b797fSHaojian Zhuang  *
7a71b797fSHaojian Zhuang  * This program is free software; you can redistribute it and/or modify
8a71b797fSHaojian Zhuang  * it under the terms of the GNU General Public License version 2 as
9a71b797fSHaojian Zhuang  * published by the Free Software Foundation.
10a71b797fSHaojian Zhuang  */
11a71b797fSHaojian Zhuang #include <linux/kernel.h>
12a71b797fSHaojian Zhuang #include <linux/module.h>
13a71b797fSHaojian Zhuang #include <linux/err.h>
14a71b797fSHaojian Zhuang #include <linux/i2c.h>
15a71b797fSHaojian Zhuang #include <linux/platform_device.h>
16a71b797fSHaojian Zhuang #include <linux/regulator/driver.h>
17*5a0e3ad6STejun Heo #include <linux/slab.h>
18a71b797fSHaojian Zhuang #include <linux/regulator/max8649.h>
19a71b797fSHaojian Zhuang 
20a71b797fSHaojian Zhuang #define MAX8649_DCDC_VMIN	750000		/* uV */
21a71b797fSHaojian Zhuang #define MAX8649_DCDC_VMAX	1380000		/* uV */
22a71b797fSHaojian Zhuang #define MAX8649_DCDC_STEP	10000		/* uV */
23a71b797fSHaojian Zhuang #define MAX8649_VOL_MASK	0x3f
24a71b797fSHaojian Zhuang 
25a71b797fSHaojian Zhuang /* Registers */
26a71b797fSHaojian Zhuang #define MAX8649_MODE0		0x00
27a71b797fSHaojian Zhuang #define MAX8649_MODE1		0x01
28a71b797fSHaojian Zhuang #define MAX8649_MODE2		0x02
29a71b797fSHaojian Zhuang #define MAX8649_MODE3		0x03
30a71b797fSHaojian Zhuang #define MAX8649_CONTROL		0x04
31a71b797fSHaojian Zhuang #define MAX8649_SYNC		0x05
32a71b797fSHaojian Zhuang #define MAX8649_RAMP		0x06
33a71b797fSHaojian Zhuang #define MAX8649_CHIP_ID1	0x08
34a71b797fSHaojian Zhuang #define MAX8649_CHIP_ID2	0x09
35a71b797fSHaojian Zhuang 
36a71b797fSHaojian Zhuang /* Bits */
37a71b797fSHaojian Zhuang #define MAX8649_EN_PD		(1 << 7)
38a71b797fSHaojian Zhuang #define MAX8649_VID0_PD		(1 << 6)
39a71b797fSHaojian Zhuang #define MAX8649_VID1_PD		(1 << 5)
40a71b797fSHaojian Zhuang #define MAX8649_VID_MASK	(3 << 5)
41a71b797fSHaojian Zhuang 
42a71b797fSHaojian Zhuang #define MAX8649_FORCE_PWM	(1 << 7)
43a71b797fSHaojian Zhuang #define MAX8649_SYNC_EXTCLK	(1 << 6)
44a71b797fSHaojian Zhuang 
45a71b797fSHaojian Zhuang #define MAX8649_EXT_MASK	(3 << 6)
46a71b797fSHaojian Zhuang 
47a71b797fSHaojian Zhuang #define MAX8649_RAMP_MASK	(7 << 5)
48a71b797fSHaojian Zhuang #define MAX8649_RAMP_DOWN	(1 << 1)
49a71b797fSHaojian Zhuang 
50a71b797fSHaojian Zhuang struct max8649_regulator_info {
51a71b797fSHaojian Zhuang 	struct regulator_dev	*regulator;
52a71b797fSHaojian Zhuang 	struct i2c_client	*i2c;
53a71b797fSHaojian Zhuang 	struct device		*dev;
54a71b797fSHaojian Zhuang 	struct mutex		io_lock;
55a71b797fSHaojian Zhuang 
56a71b797fSHaojian Zhuang 	int		vol_reg;
57a71b797fSHaojian Zhuang 	unsigned	mode:2;	/* bit[1:0] = VID1, VID0 */
58a71b797fSHaojian Zhuang 	unsigned	extclk_freq:2;
59a71b797fSHaojian Zhuang 	unsigned	extclk:1;
60a71b797fSHaojian Zhuang 	unsigned	ramp_timing:3;
61a71b797fSHaojian Zhuang 	unsigned	ramp_down:1;
62a71b797fSHaojian Zhuang };
63a71b797fSHaojian Zhuang 
64a71b797fSHaojian Zhuang /* I2C operations */
65a71b797fSHaojian Zhuang 
66a71b797fSHaojian Zhuang static inline int max8649_read_device(struct i2c_client *i2c,
67a71b797fSHaojian Zhuang 				      int reg, int bytes, void *dest)
68a71b797fSHaojian Zhuang {
69a71b797fSHaojian Zhuang 	unsigned char data;
70a71b797fSHaojian Zhuang 	int ret;
71a71b797fSHaojian Zhuang 
72a71b797fSHaojian Zhuang 	data = (unsigned char)reg;
73a71b797fSHaojian Zhuang 	ret = i2c_master_send(i2c, &data, 1);
74a71b797fSHaojian Zhuang 	if (ret < 0)
75a71b797fSHaojian Zhuang 		return ret;
76a71b797fSHaojian Zhuang 	ret = i2c_master_recv(i2c, dest, bytes);
77a71b797fSHaojian Zhuang 	if (ret < 0)
78a71b797fSHaojian Zhuang 		return ret;
79a71b797fSHaojian Zhuang 	return 0;
80a71b797fSHaojian Zhuang }
81a71b797fSHaojian Zhuang 
82a71b797fSHaojian Zhuang static inline int max8649_write_device(struct i2c_client *i2c,
83a71b797fSHaojian Zhuang 				       int reg, int bytes, void *src)
84a71b797fSHaojian Zhuang {
85a71b797fSHaojian Zhuang 	unsigned char buf[bytes + 1];
86a71b797fSHaojian Zhuang 	int ret;
87a71b797fSHaojian Zhuang 
88a71b797fSHaojian Zhuang 	buf[0] = (unsigned char)reg;
89a71b797fSHaojian Zhuang 	memcpy(&buf[1], src, bytes);
90a71b797fSHaojian Zhuang 
91a71b797fSHaojian Zhuang 	ret = i2c_master_send(i2c, buf, bytes + 1);
92a71b797fSHaojian Zhuang 	if (ret < 0)
93a71b797fSHaojian Zhuang 		return ret;
94a71b797fSHaojian Zhuang 	return 0;
95a71b797fSHaojian Zhuang }
96a71b797fSHaojian Zhuang 
97a71b797fSHaojian Zhuang static int max8649_reg_read(struct i2c_client *i2c, int reg)
98a71b797fSHaojian Zhuang {
99a71b797fSHaojian Zhuang 	struct max8649_regulator_info *info = i2c_get_clientdata(i2c);
100a71b797fSHaojian Zhuang 	unsigned char data;
101a71b797fSHaojian Zhuang 	int ret;
102a71b797fSHaojian Zhuang 
103a71b797fSHaojian Zhuang 	mutex_lock(&info->io_lock);
104a71b797fSHaojian Zhuang 	ret = max8649_read_device(i2c, reg, 1, &data);
105a71b797fSHaojian Zhuang 	mutex_unlock(&info->io_lock);
106a71b797fSHaojian Zhuang 
107a71b797fSHaojian Zhuang 	if (ret < 0)
108a71b797fSHaojian Zhuang 		return ret;
109a71b797fSHaojian Zhuang 	return (int)data;
110a71b797fSHaojian Zhuang }
111a71b797fSHaojian Zhuang 
112a71b797fSHaojian Zhuang static int max8649_set_bits(struct i2c_client *i2c, int reg,
113a71b797fSHaojian Zhuang 			    unsigned char mask, unsigned char data)
114a71b797fSHaojian Zhuang {
115a71b797fSHaojian Zhuang 	struct max8649_regulator_info *info = i2c_get_clientdata(i2c);
116a71b797fSHaojian Zhuang 	unsigned char value;
117a71b797fSHaojian Zhuang 	int ret;
118a71b797fSHaojian Zhuang 
119a71b797fSHaojian Zhuang 	mutex_lock(&info->io_lock);
120a71b797fSHaojian Zhuang 	ret = max8649_read_device(i2c, reg, 1, &value);
121a71b797fSHaojian Zhuang 	if (ret < 0)
122a71b797fSHaojian Zhuang 		goto out;
123a71b797fSHaojian Zhuang 	value &= ~mask;
124a71b797fSHaojian Zhuang 	value |= data;
125a71b797fSHaojian Zhuang 	ret = max8649_write_device(i2c, reg, 1, &value);
126a71b797fSHaojian Zhuang out:
127a71b797fSHaojian Zhuang 	mutex_unlock(&info->io_lock);
128a71b797fSHaojian Zhuang 	return ret;
129a71b797fSHaojian Zhuang }
130a71b797fSHaojian Zhuang 
131a71b797fSHaojian Zhuang static inline int check_range(int min_uV, int max_uV)
132a71b797fSHaojian Zhuang {
133a71b797fSHaojian Zhuang 	if ((min_uV < MAX8649_DCDC_VMIN) || (max_uV > MAX8649_DCDC_VMAX)
134a71b797fSHaojian Zhuang 		|| (min_uV > max_uV))
135a71b797fSHaojian Zhuang 		return -EINVAL;
136a71b797fSHaojian Zhuang 	return 0;
137a71b797fSHaojian Zhuang }
138a71b797fSHaojian Zhuang 
139a71b797fSHaojian Zhuang static int max8649_list_voltage(struct regulator_dev *rdev, unsigned index)
140a71b797fSHaojian Zhuang {
141a71b797fSHaojian Zhuang 	return (MAX8649_DCDC_VMIN + index * MAX8649_DCDC_STEP);
142a71b797fSHaojian Zhuang }
143a71b797fSHaojian Zhuang 
144a71b797fSHaojian Zhuang static int max8649_get_voltage(struct regulator_dev *rdev)
145a71b797fSHaojian Zhuang {
146a71b797fSHaojian Zhuang 	struct max8649_regulator_info *info = rdev_get_drvdata(rdev);
147a71b797fSHaojian Zhuang 	unsigned char data;
148a71b797fSHaojian Zhuang 	int ret;
149a71b797fSHaojian Zhuang 
150a71b797fSHaojian Zhuang 	ret = max8649_reg_read(info->i2c, info->vol_reg);
151a71b797fSHaojian Zhuang 	if (ret < 0)
152a71b797fSHaojian Zhuang 		return ret;
153a71b797fSHaojian Zhuang 	data = (unsigned char)ret & MAX8649_VOL_MASK;
154a71b797fSHaojian Zhuang 	return max8649_list_voltage(rdev, data);
155a71b797fSHaojian Zhuang }
156a71b797fSHaojian Zhuang 
157a71b797fSHaojian Zhuang static int max8649_set_voltage(struct regulator_dev *rdev,
158a71b797fSHaojian Zhuang 			       int min_uV, int max_uV)
159a71b797fSHaojian Zhuang {
160a71b797fSHaojian Zhuang 	struct max8649_regulator_info *info = rdev_get_drvdata(rdev);
161a71b797fSHaojian Zhuang 	unsigned char data, mask;
162a71b797fSHaojian Zhuang 
163a71b797fSHaojian Zhuang 	if (check_range(min_uV, max_uV)) {
164a71b797fSHaojian Zhuang 		dev_err(info->dev, "invalid voltage range (%d, %d) uV\n",
165a71b797fSHaojian Zhuang 			min_uV, max_uV);
166a71b797fSHaojian Zhuang 		return -EINVAL;
167a71b797fSHaojian Zhuang 	}
168a71b797fSHaojian Zhuang 	data = (min_uV - MAX8649_DCDC_VMIN + MAX8649_DCDC_STEP - 1)
169a71b797fSHaojian Zhuang 		/ MAX8649_DCDC_STEP;
170a71b797fSHaojian Zhuang 	mask = MAX8649_VOL_MASK;
171a71b797fSHaojian Zhuang 
172a71b797fSHaojian Zhuang 	return max8649_set_bits(info->i2c, info->vol_reg, mask, data);
173a71b797fSHaojian Zhuang }
174a71b797fSHaojian Zhuang 
175a71b797fSHaojian Zhuang /* EN_PD means pulldown on EN input */
176a71b797fSHaojian Zhuang static int max8649_enable(struct regulator_dev *rdev)
177a71b797fSHaojian Zhuang {
178a71b797fSHaojian Zhuang 	struct max8649_regulator_info *info = rdev_get_drvdata(rdev);
179a71b797fSHaojian Zhuang 	return max8649_set_bits(info->i2c, MAX8649_CONTROL, MAX8649_EN_PD, 0);
180a71b797fSHaojian Zhuang }
181a71b797fSHaojian Zhuang 
182a71b797fSHaojian Zhuang /*
183a71b797fSHaojian Zhuang  * Applied internal pulldown resistor on EN input pin.
184a71b797fSHaojian Zhuang  * If pulldown EN pin outside, it would be better.
185a71b797fSHaojian Zhuang  */
186a71b797fSHaojian Zhuang static int max8649_disable(struct regulator_dev *rdev)
187a71b797fSHaojian Zhuang {
188a71b797fSHaojian Zhuang 	struct max8649_regulator_info *info = rdev_get_drvdata(rdev);
189a71b797fSHaojian Zhuang 	return max8649_set_bits(info->i2c, MAX8649_CONTROL, MAX8649_EN_PD,
190a71b797fSHaojian Zhuang 				MAX8649_EN_PD);
191a71b797fSHaojian Zhuang }
192a71b797fSHaojian Zhuang 
193a71b797fSHaojian Zhuang static int max8649_is_enabled(struct regulator_dev *rdev)
194a71b797fSHaojian Zhuang {
195a71b797fSHaojian Zhuang 	struct max8649_regulator_info *info = rdev_get_drvdata(rdev);
196a71b797fSHaojian Zhuang 	int ret;
197a71b797fSHaojian Zhuang 
198a71b797fSHaojian Zhuang 	ret = max8649_reg_read(info->i2c, MAX8649_CONTROL);
199a71b797fSHaojian Zhuang 	if (ret < 0)
200a71b797fSHaojian Zhuang 		return ret;
201a71b797fSHaojian Zhuang 	return !((unsigned char)ret & MAX8649_EN_PD);
202a71b797fSHaojian Zhuang }
203a71b797fSHaojian Zhuang 
204a71b797fSHaojian Zhuang static int max8649_enable_time(struct regulator_dev *rdev)
205a71b797fSHaojian Zhuang {
206a71b797fSHaojian Zhuang 	struct max8649_regulator_info *info = rdev_get_drvdata(rdev);
207a71b797fSHaojian Zhuang 	int voltage, rate, ret;
208a71b797fSHaojian Zhuang 
209a71b797fSHaojian Zhuang 	/* get voltage */
210a71b797fSHaojian Zhuang 	ret = max8649_reg_read(info->i2c, info->vol_reg);
211a71b797fSHaojian Zhuang 	if (ret < 0)
212a71b797fSHaojian Zhuang 		return ret;
213a71b797fSHaojian Zhuang 	ret &= MAX8649_VOL_MASK;
214a71b797fSHaojian Zhuang 	voltage = max8649_list_voltage(rdev, (unsigned char)ret); /* uV */
215a71b797fSHaojian Zhuang 
216a71b797fSHaojian Zhuang 	/* get rate */
217a71b797fSHaojian Zhuang 	ret = max8649_reg_read(info->i2c, MAX8649_RAMP);
218a71b797fSHaojian Zhuang 	if (ret < 0)
219a71b797fSHaojian Zhuang 		return ret;
220a71b797fSHaojian Zhuang 	ret = (ret & MAX8649_RAMP_MASK) >> 5;
221a71b797fSHaojian Zhuang 	rate = (32 * 1000) >> ret;	/* uV/uS */
222a71b797fSHaojian Zhuang 
223a71b797fSHaojian Zhuang 	return (voltage / rate);
224a71b797fSHaojian Zhuang }
225a71b797fSHaojian Zhuang 
226a71b797fSHaojian Zhuang static int max8649_set_mode(struct regulator_dev *rdev, unsigned int mode)
227a71b797fSHaojian Zhuang {
228a71b797fSHaojian Zhuang 	struct max8649_regulator_info *info = rdev_get_drvdata(rdev);
229a71b797fSHaojian Zhuang 
230a71b797fSHaojian Zhuang 	switch (mode) {
231a71b797fSHaojian Zhuang 	case REGULATOR_MODE_FAST:
232a71b797fSHaojian Zhuang 		max8649_set_bits(info->i2c, info->vol_reg, MAX8649_FORCE_PWM,
233a71b797fSHaojian Zhuang 				 MAX8649_FORCE_PWM);
234a71b797fSHaojian Zhuang 		break;
235a71b797fSHaojian Zhuang 	case REGULATOR_MODE_NORMAL:
236a71b797fSHaojian Zhuang 		max8649_set_bits(info->i2c, info->vol_reg,
237a71b797fSHaojian Zhuang 				 MAX8649_FORCE_PWM, 0);
238a71b797fSHaojian Zhuang 		break;
239a71b797fSHaojian Zhuang 	default:
240a71b797fSHaojian Zhuang 		return -EINVAL;
241a71b797fSHaojian Zhuang 	}
242a71b797fSHaojian Zhuang 	return 0;
243a71b797fSHaojian Zhuang }
244a71b797fSHaojian Zhuang 
245a71b797fSHaojian Zhuang static unsigned int max8649_get_mode(struct regulator_dev *rdev)
246a71b797fSHaojian Zhuang {
247a71b797fSHaojian Zhuang 	struct max8649_regulator_info *info = rdev_get_drvdata(rdev);
248a71b797fSHaojian Zhuang 	int ret;
249a71b797fSHaojian Zhuang 
250a71b797fSHaojian Zhuang 	ret = max8649_reg_read(info->i2c, info->vol_reg);
251a71b797fSHaojian Zhuang 	if (ret & MAX8649_FORCE_PWM)
252a71b797fSHaojian Zhuang 		return REGULATOR_MODE_FAST;
253a71b797fSHaojian Zhuang 	return REGULATOR_MODE_NORMAL;
254a71b797fSHaojian Zhuang }
255a71b797fSHaojian Zhuang 
256a71b797fSHaojian Zhuang static struct regulator_ops max8649_dcdc_ops = {
257a71b797fSHaojian Zhuang 	.set_voltage	= max8649_set_voltage,
258a71b797fSHaojian Zhuang 	.get_voltage	= max8649_get_voltage,
259a71b797fSHaojian Zhuang 	.list_voltage	= max8649_list_voltage,
260a71b797fSHaojian Zhuang 	.enable		= max8649_enable,
261a71b797fSHaojian Zhuang 	.disable	= max8649_disable,
262a71b797fSHaojian Zhuang 	.is_enabled	= max8649_is_enabled,
263a71b797fSHaojian Zhuang 	.enable_time	= max8649_enable_time,
264a71b797fSHaojian Zhuang 	.set_mode	= max8649_set_mode,
265a71b797fSHaojian Zhuang 	.get_mode	= max8649_get_mode,
266a71b797fSHaojian Zhuang 
267a71b797fSHaojian Zhuang };
268a71b797fSHaojian Zhuang 
269a71b797fSHaojian Zhuang static struct regulator_desc dcdc_desc = {
270a71b797fSHaojian Zhuang 	.name		= "max8649",
271a71b797fSHaojian Zhuang 	.ops		= &max8649_dcdc_ops,
272a71b797fSHaojian Zhuang 	.type		= REGULATOR_VOLTAGE,
273a71b797fSHaojian Zhuang 	.n_voltages	= 1 << 6,
274a71b797fSHaojian Zhuang 	.owner		= THIS_MODULE,
275a71b797fSHaojian Zhuang };
276a71b797fSHaojian Zhuang 
277a71b797fSHaojian Zhuang static int __devinit max8649_regulator_probe(struct i2c_client *client,
278a71b797fSHaojian Zhuang 					     const struct i2c_device_id *id)
279a71b797fSHaojian Zhuang {
280a71b797fSHaojian Zhuang 	struct max8649_platform_data *pdata = client->dev.platform_data;
281a71b797fSHaojian Zhuang 	struct max8649_regulator_info *info = NULL;
282a71b797fSHaojian Zhuang 	unsigned char data;
283a71b797fSHaojian Zhuang 	int ret;
284a71b797fSHaojian Zhuang 
285a71b797fSHaojian Zhuang 	info = kzalloc(sizeof(struct max8649_regulator_info), GFP_KERNEL);
286a71b797fSHaojian Zhuang 	if (!info) {
287a71b797fSHaojian Zhuang 		dev_err(&client->dev, "No enough memory\n");
288a71b797fSHaojian Zhuang 		return -ENOMEM;
289a71b797fSHaojian Zhuang 	}
290a71b797fSHaojian Zhuang 
291a71b797fSHaojian Zhuang 	info->i2c = client;
292a71b797fSHaojian Zhuang 	info->dev = &client->dev;
293a71b797fSHaojian Zhuang 	mutex_init(&info->io_lock);
294a71b797fSHaojian Zhuang 	i2c_set_clientdata(client, info);
295a71b797fSHaojian Zhuang 
296a71b797fSHaojian Zhuang 	info->mode = pdata->mode;
297a71b797fSHaojian Zhuang 	switch (info->mode) {
298a71b797fSHaojian Zhuang 	case 0:
299a71b797fSHaojian Zhuang 		info->vol_reg = MAX8649_MODE0;
300a71b797fSHaojian Zhuang 		break;
301a71b797fSHaojian Zhuang 	case 1:
302a71b797fSHaojian Zhuang 		info->vol_reg = MAX8649_MODE1;
303a71b797fSHaojian Zhuang 		break;
304a71b797fSHaojian Zhuang 	case 2:
305a71b797fSHaojian Zhuang 		info->vol_reg = MAX8649_MODE2;
306a71b797fSHaojian Zhuang 		break;
307a71b797fSHaojian Zhuang 	case 3:
308a71b797fSHaojian Zhuang 		info->vol_reg = MAX8649_MODE3;
309a71b797fSHaojian Zhuang 		break;
310a71b797fSHaojian Zhuang 	default:
311a71b797fSHaojian Zhuang 		break;
312a71b797fSHaojian Zhuang 	}
313a71b797fSHaojian Zhuang 
314a71b797fSHaojian Zhuang 	ret = max8649_reg_read(info->i2c, MAX8649_CHIP_ID1);
315a71b797fSHaojian Zhuang 	if (ret < 0) {
316a71b797fSHaojian Zhuang 		dev_err(info->dev, "Failed to detect ID of MAX8649:%d\n",
317a71b797fSHaojian Zhuang 			ret);
318a71b797fSHaojian Zhuang 		goto out;
319a71b797fSHaojian Zhuang 	}
320a71b797fSHaojian Zhuang 	dev_info(info->dev, "Detected MAX8649 (ID:%x)\n", ret);
321a71b797fSHaojian Zhuang 
322a71b797fSHaojian Zhuang 	/* enable VID0 & VID1 */
323a71b797fSHaojian Zhuang 	max8649_set_bits(info->i2c, MAX8649_CONTROL, MAX8649_VID_MASK, 0);
324a71b797fSHaojian Zhuang 
325a71b797fSHaojian Zhuang 	/* enable/disable external clock synchronization */
326a71b797fSHaojian Zhuang 	info->extclk = pdata->extclk;
327a71b797fSHaojian Zhuang 	data = (info->extclk) ? MAX8649_SYNC_EXTCLK : 0;
328a71b797fSHaojian Zhuang 	max8649_set_bits(info->i2c, info->vol_reg, MAX8649_SYNC_EXTCLK, data);
329a71b797fSHaojian Zhuang 	if (info->extclk) {
330a71b797fSHaojian Zhuang 		/* set external clock frequency */
331a71b797fSHaojian Zhuang 		info->extclk_freq = pdata->extclk_freq;
332a71b797fSHaojian Zhuang 		max8649_set_bits(info->i2c, MAX8649_SYNC, MAX8649_EXT_MASK,
333a71b797fSHaojian Zhuang 				 info->extclk_freq);
334a71b797fSHaojian Zhuang 	}
335a71b797fSHaojian Zhuang 
336a71b797fSHaojian Zhuang 	if (pdata->ramp_timing) {
337a71b797fSHaojian Zhuang 		info->ramp_timing = pdata->ramp_timing;
338a71b797fSHaojian Zhuang 		max8649_set_bits(info->i2c, MAX8649_RAMP, MAX8649_RAMP_MASK,
339a71b797fSHaojian Zhuang 				 info->ramp_timing << 5);
340a71b797fSHaojian Zhuang 	}
341a71b797fSHaojian Zhuang 
342a71b797fSHaojian Zhuang 	info->ramp_down = pdata->ramp_down;
343a71b797fSHaojian Zhuang 	if (info->ramp_down) {
344a71b797fSHaojian Zhuang 		max8649_set_bits(info->i2c, MAX8649_RAMP, MAX8649_RAMP_DOWN,
345a71b797fSHaojian Zhuang 				 MAX8649_RAMP_DOWN);
346a71b797fSHaojian Zhuang 	}
347a71b797fSHaojian Zhuang 
348a71b797fSHaojian Zhuang 	info->regulator = regulator_register(&dcdc_desc, &client->dev,
349a71b797fSHaojian Zhuang 					     pdata->regulator, info);
350a71b797fSHaojian Zhuang 	if (IS_ERR(info->regulator)) {
351a71b797fSHaojian Zhuang 		dev_err(info->dev, "failed to register regulator %s\n",
352a71b797fSHaojian Zhuang 			dcdc_desc.name);
353a71b797fSHaojian Zhuang 		ret = PTR_ERR(info->regulator);
354a71b797fSHaojian Zhuang 		goto out;
355a71b797fSHaojian Zhuang 	}
356a71b797fSHaojian Zhuang 
357a71b797fSHaojian Zhuang 	dev_info(info->dev, "Max8649 regulator device is detected.\n");
358a71b797fSHaojian Zhuang 	return 0;
359a71b797fSHaojian Zhuang out:
3608b4709ecSWolfram Sang 	i2c_set_clientdata(client, NULL);
361a71b797fSHaojian Zhuang 	kfree(info);
362a71b797fSHaojian Zhuang 	return ret;
363a71b797fSHaojian Zhuang }
364a71b797fSHaojian Zhuang 
365a71b797fSHaojian Zhuang static int __devexit max8649_regulator_remove(struct i2c_client *client)
366a71b797fSHaojian Zhuang {
367a71b797fSHaojian Zhuang 	struct max8649_regulator_info *info = i2c_get_clientdata(client);
368a71b797fSHaojian Zhuang 
369a71b797fSHaojian Zhuang 	if (info) {
370a71b797fSHaojian Zhuang 		if (info->regulator)
371a71b797fSHaojian Zhuang 			regulator_unregister(info->regulator);
3728b4709ecSWolfram Sang 		i2c_set_clientdata(client, NULL);
373a71b797fSHaojian Zhuang 		kfree(info);
374a71b797fSHaojian Zhuang 	}
375a71b797fSHaojian Zhuang 
376a71b797fSHaojian Zhuang 	return 0;
377a71b797fSHaojian Zhuang }
378a71b797fSHaojian Zhuang 
379a71b797fSHaojian Zhuang static const struct i2c_device_id max8649_id[] = {
380a71b797fSHaojian Zhuang 	{ "max8649", 0 },
381a71b797fSHaojian Zhuang 	{ }
382a71b797fSHaojian Zhuang };
383a71b797fSHaojian Zhuang MODULE_DEVICE_TABLE(i2c, max8649_id);
384a71b797fSHaojian Zhuang 
385a71b797fSHaojian Zhuang static struct i2c_driver max8649_driver = {
386a71b797fSHaojian Zhuang 	.probe		= max8649_regulator_probe,
387a71b797fSHaojian Zhuang 	.remove		= __devexit_p(max8649_regulator_remove),
388a71b797fSHaojian Zhuang 	.driver		= {
389a71b797fSHaojian Zhuang 		.name	= "max8649",
390a71b797fSHaojian Zhuang 	},
391a71b797fSHaojian Zhuang 	.id_table	= max8649_id,
392a71b797fSHaojian Zhuang };
393a71b797fSHaojian Zhuang 
394a71b797fSHaojian Zhuang static int __init max8649_init(void)
395a71b797fSHaojian Zhuang {
396a71b797fSHaojian Zhuang 	return i2c_add_driver(&max8649_driver);
397a71b797fSHaojian Zhuang }
398a71b797fSHaojian Zhuang subsys_initcall(max8649_init);
399a71b797fSHaojian Zhuang 
400a71b797fSHaojian Zhuang static void __exit max8649_exit(void)
401a71b797fSHaojian Zhuang {
402a71b797fSHaojian Zhuang 	i2c_del_driver(&max8649_driver);
403a71b797fSHaojian Zhuang }
404a71b797fSHaojian Zhuang module_exit(max8649_exit);
405a71b797fSHaojian Zhuang 
406a71b797fSHaojian Zhuang /* Module information */
407a71b797fSHaojian Zhuang MODULE_DESCRIPTION("MAXIM 8649 voltage regulator driver");
408a71b797fSHaojian Zhuang MODULE_AUTHOR("Haojian Zhuang <haojian.zhuang@marvell.com>");
409a71b797fSHaojian Zhuang MODULE_LICENSE("GPL");
410a71b797fSHaojian Zhuang 
411