xref: /openbmc/linux/drivers/net/wireless/ti/wl12xx/cmd.c (revision 75bf465f0bc33e9b776a46d6a1b9b990f5fb7c37)
1*2b27bdccSThomas Gleixner // SPDX-License-Identifier: GPL-2.0-only
29d68d1eeSLuciano Coelho /*
39d68d1eeSLuciano Coelho  * This file is part of wl12xx
49d68d1eeSLuciano Coelho  *
59d68d1eeSLuciano Coelho  * Copyright (C) 2009-2010 Nokia Corporation
69d68d1eeSLuciano Coelho  * Copyright (C) 2011 Texas Instruments Inc.
79d68d1eeSLuciano Coelho  */
89d68d1eeSLuciano Coelho 
99d68d1eeSLuciano Coelho #include "../wlcore/cmd.h"
109d68d1eeSLuciano Coelho #include "../wlcore/debug.h"
119d68d1eeSLuciano Coelho 
12166b2136SLuciano Coelho #include "wl12xx.h"
139d68d1eeSLuciano Coelho #include "cmd.h"
149d68d1eeSLuciano Coelho 
wl1271_cmd_ext_radio_parms(struct wl1271 * wl)159d68d1eeSLuciano Coelho int wl1271_cmd_ext_radio_parms(struct wl1271 *wl)
169d68d1eeSLuciano Coelho {
179d68d1eeSLuciano Coelho 	struct wl1271_ext_radio_parms_cmd *ext_radio_parms;
18166b2136SLuciano Coelho 	struct wl12xx_priv *priv = wl->priv;
19166b2136SLuciano Coelho 	struct wl12xx_conf_rf *rf = &priv->conf.rf;
209d68d1eeSLuciano Coelho 	int ret;
219d68d1eeSLuciano Coelho 
229d68d1eeSLuciano Coelho 	if (!wl->nvs)
239d68d1eeSLuciano Coelho 		return -ENODEV;
249d68d1eeSLuciano Coelho 
259d68d1eeSLuciano Coelho 	ext_radio_parms = kzalloc(sizeof(*ext_radio_parms), GFP_KERNEL);
269d68d1eeSLuciano Coelho 	if (!ext_radio_parms)
279d68d1eeSLuciano Coelho 		return -ENOMEM;
289d68d1eeSLuciano Coelho 
299d68d1eeSLuciano Coelho 	ext_radio_parms->test.id = TEST_CMD_INI_FILE_RF_EXTENDED_PARAM;
309d68d1eeSLuciano Coelho 
319d68d1eeSLuciano Coelho 	memcpy(ext_radio_parms->tx_per_channel_power_compensation_2,
329d68d1eeSLuciano Coelho 	       rf->tx_per_channel_power_compensation_2,
339d68d1eeSLuciano Coelho 	       CONF_TX_PWR_COMPENSATION_LEN_2);
349d68d1eeSLuciano Coelho 	memcpy(ext_radio_parms->tx_per_channel_power_compensation_5,
359d68d1eeSLuciano Coelho 	       rf->tx_per_channel_power_compensation_5,
369d68d1eeSLuciano Coelho 	       CONF_TX_PWR_COMPENSATION_LEN_5);
379d68d1eeSLuciano Coelho 
389d68d1eeSLuciano Coelho 	wl1271_dump(DEBUG_CMD, "TEST_CMD_INI_FILE_EXT_RADIO_PARAM: ",
399d68d1eeSLuciano Coelho 		    ext_radio_parms, sizeof(*ext_radio_parms));
409d68d1eeSLuciano Coelho 
419d68d1eeSLuciano Coelho 	ret = wl1271_cmd_test(wl, ext_radio_parms, sizeof(*ext_radio_parms), 0);
429d68d1eeSLuciano Coelho 	if (ret < 0)
439d68d1eeSLuciano Coelho 		wl1271_warning("TEST_CMD_INI_FILE_RF_EXTENDED_PARAM failed");
449d68d1eeSLuciano Coelho 
459d68d1eeSLuciano Coelho 	kfree(ext_radio_parms);
469d68d1eeSLuciano Coelho 	return ret;
479d68d1eeSLuciano Coelho }
489d68d1eeSLuciano Coelho 
wl1271_cmd_general_parms(struct wl1271 * wl)499d68d1eeSLuciano Coelho int wl1271_cmd_general_parms(struct wl1271 *wl)
509d68d1eeSLuciano Coelho {
519d68d1eeSLuciano Coelho 	struct wl1271_general_parms_cmd *gen_parms;
529d68d1eeSLuciano Coelho 	struct wl1271_ini_general_params *gp =
539d68d1eeSLuciano Coelho 		&((struct wl1271_nvs_file *)wl->nvs)->general_params;
54a5d751bbSLuciano Coelho 	struct wl12xx_priv *priv = wl->priv;
559d68d1eeSLuciano Coelho 	bool answer = false;
569d68d1eeSLuciano Coelho 	int ret;
579d68d1eeSLuciano Coelho 
589d68d1eeSLuciano Coelho 	if (!wl->nvs)
599d68d1eeSLuciano Coelho 		return -ENODEV;
609d68d1eeSLuciano Coelho 
619d68d1eeSLuciano Coelho 	if (gp->tx_bip_fem_manufacturer >= WL1271_INI_FEM_MODULE_COUNT) {
629d68d1eeSLuciano Coelho 		wl1271_warning("FEM index from INI out of bounds");
639d68d1eeSLuciano Coelho 		return -EINVAL;
649d68d1eeSLuciano Coelho 	}
659d68d1eeSLuciano Coelho 
669d68d1eeSLuciano Coelho 	gen_parms = kzalloc(sizeof(*gen_parms), GFP_KERNEL);
679d68d1eeSLuciano Coelho 	if (!gen_parms)
689d68d1eeSLuciano Coelho 		return -ENOMEM;
699d68d1eeSLuciano Coelho 
709d68d1eeSLuciano Coelho 	gen_parms->test.id = TEST_CMD_INI_FILE_GENERAL_PARAM;
719d68d1eeSLuciano Coelho 
729d68d1eeSLuciano Coelho 	memcpy(&gen_parms->general_params, gp, sizeof(*gp));
739d68d1eeSLuciano Coelho 
74ff324317SYair Shapira 	/* If we started in PLT FEM_DETECT mode, force auto detect */
75ff324317SYair Shapira 	if (wl->plt_mode == PLT_FEM_DETECT)
76ff324317SYair Shapira 		gen_parms->general_params.tx_bip_fem_auto_detect = true;
77ff324317SYair Shapira 
78ff324317SYair Shapira 	if (gen_parms->general_params.tx_bip_fem_auto_detect)
799d68d1eeSLuciano Coelho 		answer = true;
809d68d1eeSLuciano Coelho 
819d68d1eeSLuciano Coelho 	/* Override the REF CLK from the NVS with the one from platform data */
82a5d751bbSLuciano Coelho 	gen_parms->general_params.ref_clock = priv->ref_clock;
839d68d1eeSLuciano Coelho 
849d68d1eeSLuciano Coelho 	ret = wl1271_cmd_test(wl, gen_parms, sizeof(*gen_parms), answer);
859d68d1eeSLuciano Coelho 	if (ret < 0) {
869d68d1eeSLuciano Coelho 		wl1271_warning("CMD_INI_FILE_GENERAL_PARAM failed");
879d68d1eeSLuciano Coelho 		goto out;
889d68d1eeSLuciano Coelho 	}
899d68d1eeSLuciano Coelho 
909d68d1eeSLuciano Coelho 	gp->tx_bip_fem_manufacturer =
919d68d1eeSLuciano Coelho 		gen_parms->general_params.tx_bip_fem_manufacturer;
929d68d1eeSLuciano Coelho 
939d68d1eeSLuciano Coelho 	if (gp->tx_bip_fem_manufacturer >= WL1271_INI_FEM_MODULE_COUNT) {
949d68d1eeSLuciano Coelho 		wl1271_warning("FEM index from FW out of bounds");
959d68d1eeSLuciano Coelho 		ret = -EINVAL;
969d68d1eeSLuciano Coelho 		goto out;
979d68d1eeSLuciano Coelho 	}
989d68d1eeSLuciano Coelho 
99ff324317SYair Shapira 	/* If we are in calibrator based fem auto detect - save fem nr */
100ff324317SYair Shapira 	if (wl->plt_mode == PLT_FEM_DETECT)
101ff324317SYair Shapira 		wl->fem_manuf = gp->tx_bip_fem_manufacturer;
102ff324317SYair Shapira 
1039d68d1eeSLuciano Coelho 	wl1271_debug(DEBUG_CMD, "FEM autodetect: %s, manufacturer: %d\n",
104ff324317SYair Shapira 		answer == false ?
105ff324317SYair Shapira 			"manual" :
106ff324317SYair Shapira 		wl->plt_mode == PLT_FEM_DETECT ?
107ff324317SYair Shapira 			"calibrator_fem_detect" :
108ff324317SYair Shapira 			"auto",
109ff324317SYair Shapira 		gp->tx_bip_fem_manufacturer);
1109d68d1eeSLuciano Coelho 
1119d68d1eeSLuciano Coelho out:
1129d68d1eeSLuciano Coelho 	kfree(gen_parms);
1139d68d1eeSLuciano Coelho 	return ret;
1149d68d1eeSLuciano Coelho }
1159d68d1eeSLuciano Coelho 
wl128x_cmd_general_parms(struct wl1271 * wl)1169d68d1eeSLuciano Coelho int wl128x_cmd_general_parms(struct wl1271 *wl)
1179d68d1eeSLuciano Coelho {
1189d68d1eeSLuciano Coelho 	struct wl128x_general_parms_cmd *gen_parms;
1199d68d1eeSLuciano Coelho 	struct wl128x_ini_general_params *gp =
1209d68d1eeSLuciano Coelho 		&((struct wl128x_nvs_file *)wl->nvs)->general_params;
121a5d751bbSLuciano Coelho 	struct wl12xx_priv *priv = wl->priv;
1229d68d1eeSLuciano Coelho 	bool answer = false;
1239d68d1eeSLuciano Coelho 	int ret;
1249d68d1eeSLuciano Coelho 
1259d68d1eeSLuciano Coelho 	if (!wl->nvs)
1269d68d1eeSLuciano Coelho 		return -ENODEV;
1279d68d1eeSLuciano Coelho 
1289d68d1eeSLuciano Coelho 	if (gp->tx_bip_fem_manufacturer >= WL1271_INI_FEM_MODULE_COUNT) {
1299d68d1eeSLuciano Coelho 		wl1271_warning("FEM index from ini out of bounds");
1309d68d1eeSLuciano Coelho 		return -EINVAL;
1319d68d1eeSLuciano Coelho 	}
1329d68d1eeSLuciano Coelho 
1339d68d1eeSLuciano Coelho 	gen_parms = kzalloc(sizeof(*gen_parms), GFP_KERNEL);
1349d68d1eeSLuciano Coelho 	if (!gen_parms)
1359d68d1eeSLuciano Coelho 		return -ENOMEM;
1369d68d1eeSLuciano Coelho 
1379d68d1eeSLuciano Coelho 	gen_parms->test.id = TEST_CMD_INI_FILE_GENERAL_PARAM;
1389d68d1eeSLuciano Coelho 
1399d68d1eeSLuciano Coelho 	memcpy(&gen_parms->general_params, gp, sizeof(*gp));
1409d68d1eeSLuciano Coelho 
141ff324317SYair Shapira 	/* If we started in PLT FEM_DETECT mode, force auto detect */
142ff324317SYair Shapira 	if (wl->plt_mode == PLT_FEM_DETECT)
143ff324317SYair Shapira 		gen_parms->general_params.tx_bip_fem_auto_detect = true;
144ff324317SYair Shapira 
145ff324317SYair Shapira 	if (gen_parms->general_params.tx_bip_fem_auto_detect)
1469d68d1eeSLuciano Coelho 		answer = true;
1479d68d1eeSLuciano Coelho 
1489d68d1eeSLuciano Coelho 	/* Replace REF and TCXO CLKs with the ones from platform data */
149a5d751bbSLuciano Coelho 	gen_parms->general_params.ref_clock = priv->ref_clock;
150a5d751bbSLuciano Coelho 	gen_parms->general_params.tcxo_ref_clock = priv->tcxo_clock;
1519d68d1eeSLuciano Coelho 
1529d68d1eeSLuciano Coelho 	ret = wl1271_cmd_test(wl, gen_parms, sizeof(*gen_parms), answer);
1539d68d1eeSLuciano Coelho 	if (ret < 0) {
1549d68d1eeSLuciano Coelho 		wl1271_warning("CMD_INI_FILE_GENERAL_PARAM failed");
1559d68d1eeSLuciano Coelho 		goto out;
1569d68d1eeSLuciano Coelho 	}
1579d68d1eeSLuciano Coelho 
1589d68d1eeSLuciano Coelho 	gp->tx_bip_fem_manufacturer =
1599d68d1eeSLuciano Coelho 		gen_parms->general_params.tx_bip_fem_manufacturer;
1609d68d1eeSLuciano Coelho 
1619d68d1eeSLuciano Coelho 	if (gp->tx_bip_fem_manufacturer >= WL1271_INI_FEM_MODULE_COUNT) {
1629d68d1eeSLuciano Coelho 		wl1271_warning("FEM index from FW out of bounds");
1639d68d1eeSLuciano Coelho 		ret = -EINVAL;
1649d68d1eeSLuciano Coelho 		goto out;
1659d68d1eeSLuciano Coelho 	}
1669d68d1eeSLuciano Coelho 
167ff324317SYair Shapira 	/* If we are in calibrator based fem auto detect - save fem nr */
168ff324317SYair Shapira 	if (wl->plt_mode == PLT_FEM_DETECT)
169ff324317SYair Shapira 		wl->fem_manuf = gp->tx_bip_fem_manufacturer;
170ff324317SYair Shapira 
1719d68d1eeSLuciano Coelho 	wl1271_debug(DEBUG_CMD, "FEM autodetect: %s, manufacturer: %d\n",
172ff324317SYair Shapira 		answer == false ?
173ff324317SYair Shapira 			"manual" :
174ff324317SYair Shapira 		wl->plt_mode == PLT_FEM_DETECT ?
175ff324317SYair Shapira 			"calibrator_fem_detect" :
176ff324317SYair Shapira 			"auto",
177ff324317SYair Shapira 		gp->tx_bip_fem_manufacturer);
1789d68d1eeSLuciano Coelho 
1799d68d1eeSLuciano Coelho out:
1809d68d1eeSLuciano Coelho 	kfree(gen_parms);
1819d68d1eeSLuciano Coelho 	return ret;
1829d68d1eeSLuciano Coelho }
1839d68d1eeSLuciano Coelho 
wl1271_cmd_radio_parms(struct wl1271 * wl)1849d68d1eeSLuciano Coelho int wl1271_cmd_radio_parms(struct wl1271 *wl)
1859d68d1eeSLuciano Coelho {
1869d68d1eeSLuciano Coelho 	struct wl1271_nvs_file *nvs = (struct wl1271_nvs_file *)wl->nvs;
1879d68d1eeSLuciano Coelho 	struct wl1271_radio_parms_cmd *radio_parms;
1889d68d1eeSLuciano Coelho 	struct wl1271_ini_general_params *gp = &nvs->general_params;
18905f48d45SYair Shapira 	int ret, fem_idx;
1909d68d1eeSLuciano Coelho 
1919d68d1eeSLuciano Coelho 	if (!wl->nvs)
1929d68d1eeSLuciano Coelho 		return -ENODEV;
1939d68d1eeSLuciano Coelho 
1949d68d1eeSLuciano Coelho 	radio_parms = kzalloc(sizeof(*radio_parms), GFP_KERNEL);
1959d68d1eeSLuciano Coelho 	if (!radio_parms)
1969d68d1eeSLuciano Coelho 		return -ENOMEM;
1979d68d1eeSLuciano Coelho 
1989d68d1eeSLuciano Coelho 	radio_parms->test.id = TEST_CMD_INI_FILE_RADIO_PARAM;
1999d68d1eeSLuciano Coelho 
20005f48d45SYair Shapira 	fem_idx = WL12XX_FEM_TO_NVS_ENTRY(gp->tx_bip_fem_manufacturer);
20105f48d45SYair Shapira 
2029d68d1eeSLuciano Coelho 	/* 2.4GHz parameters */
2039d68d1eeSLuciano Coelho 	memcpy(&radio_parms->static_params_2, &nvs->stat_radio_params_2,
2049d68d1eeSLuciano Coelho 	       sizeof(struct wl1271_ini_band_params_2));
2059d68d1eeSLuciano Coelho 	memcpy(&radio_parms->dyn_params_2,
20605f48d45SYair Shapira 	       &nvs->dyn_radio_params_2[fem_idx].params,
2079d68d1eeSLuciano Coelho 	       sizeof(struct wl1271_ini_fem_params_2));
2089d68d1eeSLuciano Coelho 
2099d68d1eeSLuciano Coelho 	/* 5GHz parameters */
2109d68d1eeSLuciano Coelho 	memcpy(&radio_parms->static_params_5,
2119d68d1eeSLuciano Coelho 	       &nvs->stat_radio_params_5,
2129d68d1eeSLuciano Coelho 	       sizeof(struct wl1271_ini_band_params_5));
2139d68d1eeSLuciano Coelho 	memcpy(&radio_parms->dyn_params_5,
21405f48d45SYair Shapira 	       &nvs->dyn_radio_params_5[fem_idx].params,
2159d68d1eeSLuciano Coelho 	       sizeof(struct wl1271_ini_fem_params_5));
2169d68d1eeSLuciano Coelho 
2179d68d1eeSLuciano Coelho 	wl1271_dump(DEBUG_CMD, "TEST_CMD_INI_FILE_RADIO_PARAM: ",
2189d68d1eeSLuciano Coelho 		    radio_parms, sizeof(*radio_parms));
2199d68d1eeSLuciano Coelho 
2209d68d1eeSLuciano Coelho 	ret = wl1271_cmd_test(wl, radio_parms, sizeof(*radio_parms), 0);
2219d68d1eeSLuciano Coelho 	if (ret < 0)
2229d68d1eeSLuciano Coelho 		wl1271_warning("CMD_INI_FILE_RADIO_PARAM failed");
2239d68d1eeSLuciano Coelho 
2249d68d1eeSLuciano Coelho 	kfree(radio_parms);
2259d68d1eeSLuciano Coelho 	return ret;
2269d68d1eeSLuciano Coelho }
2279d68d1eeSLuciano Coelho 
wl128x_cmd_radio_parms(struct wl1271 * wl)2289d68d1eeSLuciano Coelho int wl128x_cmd_radio_parms(struct wl1271 *wl)
2299d68d1eeSLuciano Coelho {
2309d68d1eeSLuciano Coelho 	struct wl128x_nvs_file *nvs = (struct wl128x_nvs_file *)wl->nvs;
2319d68d1eeSLuciano Coelho 	struct wl128x_radio_parms_cmd *radio_parms;
2329d68d1eeSLuciano Coelho 	struct wl128x_ini_general_params *gp = &nvs->general_params;
23305f48d45SYair Shapira 	int ret, fem_idx;
2349d68d1eeSLuciano Coelho 
2359d68d1eeSLuciano Coelho 	if (!wl->nvs)
2369d68d1eeSLuciano Coelho 		return -ENODEV;
2379d68d1eeSLuciano Coelho 
2389d68d1eeSLuciano Coelho 	radio_parms = kzalloc(sizeof(*radio_parms), GFP_KERNEL);
2399d68d1eeSLuciano Coelho 	if (!radio_parms)
2409d68d1eeSLuciano Coelho 		return -ENOMEM;
2419d68d1eeSLuciano Coelho 
2429d68d1eeSLuciano Coelho 	radio_parms->test.id = TEST_CMD_INI_FILE_RADIO_PARAM;
2439d68d1eeSLuciano Coelho 
24405f48d45SYair Shapira 	fem_idx = WL12XX_FEM_TO_NVS_ENTRY(gp->tx_bip_fem_manufacturer);
24505f48d45SYair Shapira 
2469d68d1eeSLuciano Coelho 	/* 2.4GHz parameters */
2479d68d1eeSLuciano Coelho 	memcpy(&radio_parms->static_params_2, &nvs->stat_radio_params_2,
2489d68d1eeSLuciano Coelho 	       sizeof(struct wl128x_ini_band_params_2));
2499d68d1eeSLuciano Coelho 	memcpy(&radio_parms->dyn_params_2,
25005f48d45SYair Shapira 	       &nvs->dyn_radio_params_2[fem_idx].params,
2519d68d1eeSLuciano Coelho 	       sizeof(struct wl128x_ini_fem_params_2));
2529d68d1eeSLuciano Coelho 
2539d68d1eeSLuciano Coelho 	/* 5GHz parameters */
2549d68d1eeSLuciano Coelho 	memcpy(&radio_parms->static_params_5,
2559d68d1eeSLuciano Coelho 	       &nvs->stat_radio_params_5,
2569d68d1eeSLuciano Coelho 	       sizeof(struct wl128x_ini_band_params_5));
2579d68d1eeSLuciano Coelho 	memcpy(&radio_parms->dyn_params_5,
25805f48d45SYair Shapira 	       &nvs->dyn_radio_params_5[fem_idx].params,
2599d68d1eeSLuciano Coelho 	       sizeof(struct wl128x_ini_fem_params_5));
2609d68d1eeSLuciano Coelho 
2619d68d1eeSLuciano Coelho 	radio_parms->fem_vendor_and_options = nvs->fem_vendor_and_options;
2629d68d1eeSLuciano Coelho 
2639d68d1eeSLuciano Coelho 	wl1271_dump(DEBUG_CMD, "TEST_CMD_INI_FILE_RADIO_PARAM: ",
2649d68d1eeSLuciano Coelho 		    radio_parms, sizeof(*radio_parms));
2659d68d1eeSLuciano Coelho 
2669d68d1eeSLuciano Coelho 	ret = wl1271_cmd_test(wl, radio_parms, sizeof(*radio_parms), 0);
2679d68d1eeSLuciano Coelho 	if (ret < 0)
2689d68d1eeSLuciano Coelho 		wl1271_warning("CMD_INI_FILE_RADIO_PARAM failed");
2699d68d1eeSLuciano Coelho 
2709d68d1eeSLuciano Coelho 	kfree(radio_parms);
2719d68d1eeSLuciano Coelho 	return ret;
2729d68d1eeSLuciano Coelho }
273fcab1890SEliad Peller 
wl12xx_cmd_channel_switch(struct wl1271 * wl,struct wl12xx_vif * wlvif,struct ieee80211_channel_switch * ch_switch)274fcab1890SEliad Peller int wl12xx_cmd_channel_switch(struct wl1271 *wl,
275fcab1890SEliad Peller 			      struct wl12xx_vif *wlvif,
276fcab1890SEliad Peller 			      struct ieee80211_channel_switch *ch_switch)
277fcab1890SEliad Peller {
278fcab1890SEliad Peller 	struct wl12xx_cmd_channel_switch *cmd;
279fcab1890SEliad Peller 	int ret;
280fcab1890SEliad Peller 
281fcab1890SEliad Peller 	wl1271_debug(DEBUG_ACX, "cmd channel switch");
282fcab1890SEliad Peller 
283fcab1890SEliad Peller 	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
284fcab1890SEliad Peller 	if (!cmd) {
285fcab1890SEliad Peller 		ret = -ENOMEM;
286fcab1890SEliad Peller 		goto out;
287fcab1890SEliad Peller 	}
288fcab1890SEliad Peller 
289fcab1890SEliad Peller 	cmd->role_id = wlvif->role_id;
29085220d71SJohannes Berg 	cmd->channel = ch_switch->chandef.chan->hw_value;
291fcab1890SEliad Peller 	cmd->switch_time = ch_switch->count;
292fcab1890SEliad Peller 	cmd->stop_tx = ch_switch->block_tx;
293fcab1890SEliad Peller 
294fcab1890SEliad Peller 	/* FIXME: control from mac80211 in the future */
295fcab1890SEliad Peller 	/* Enable TX on the target channel */
296fcab1890SEliad Peller 	cmd->post_switch_tx_disable = 0;
297fcab1890SEliad Peller 
298fcab1890SEliad Peller 	ret = wl1271_cmd_send(wl, CMD_CHANNEL_SWITCH, cmd, sizeof(*cmd), 0);
299fcab1890SEliad Peller 	if (ret < 0) {
300fcab1890SEliad Peller 		wl1271_error("failed to send channel switch command");
301fcab1890SEliad Peller 		goto out_free;
302fcab1890SEliad Peller 	}
303fcab1890SEliad Peller 
304fcab1890SEliad Peller out_free:
305fcab1890SEliad Peller 	kfree(cmd);
306fcab1890SEliad Peller 
307fcab1890SEliad Peller out:
308fcab1890SEliad Peller 	return ret;
309fcab1890SEliad Peller }
310