xref: /openbmc/linux/drivers/gpu/drm/tegra/rgb.c (revision 4aa3df7149a00cb061d2ba74e2136cd14a6d885a)
1dee8268fSThierry Reding /*
2dee8268fSThierry Reding  * Copyright (C) 2012 Avionic Design GmbH
3dee8268fSThierry Reding  * Copyright (C) 2012 NVIDIA CORPORATION.  All rights reserved.
4dee8268fSThierry Reding  *
5dee8268fSThierry Reding  * This program is free software; you can redistribute it and/or modify
6dee8268fSThierry Reding  * it under the terms of the GNU General Public License version 2 as
7dee8268fSThierry Reding  * published by the Free Software Foundation.
8dee8268fSThierry Reding  */
9dee8268fSThierry Reding 
10dee8268fSThierry Reding #include <linux/clk.h>
11dee8268fSThierry Reding 
12*4aa3df71SThierry Reding #include <drm/drm_atomic_helper.h>
133b0e5855SThierry Reding #include <drm/drm_panel.h>
143b0e5855SThierry Reding 
15dee8268fSThierry Reding #include "drm.h"
16dee8268fSThierry Reding #include "dc.h"
17dee8268fSThierry Reding 
18dee8268fSThierry Reding struct tegra_rgb {
19dee8268fSThierry Reding 	struct tegra_output output;
207602fa1dSThierry Reding 	struct tegra_dc *dc;
21b1891537SDmitry Osipenko 	bool enabled;
227602fa1dSThierry Reding 
23dee8268fSThierry Reding 	struct clk *clk_parent;
24dee8268fSThierry Reding 	struct clk *clk;
25dee8268fSThierry Reding };
26dee8268fSThierry Reding 
27dee8268fSThierry Reding static inline struct tegra_rgb *to_rgb(struct tegra_output *output)
28dee8268fSThierry Reding {
29dee8268fSThierry Reding 	return container_of(output, struct tegra_rgb, output);
30dee8268fSThierry Reding }
31dee8268fSThierry Reding 
32dee8268fSThierry Reding struct reg_entry {
33dee8268fSThierry Reding 	unsigned long offset;
34dee8268fSThierry Reding 	unsigned long value;
35dee8268fSThierry Reding };
36dee8268fSThierry Reding 
37dee8268fSThierry Reding static const struct reg_entry rgb_enable[] = {
38dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_ENABLE(0),   0x00000000 },
39dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_ENABLE(1),   0x00000000 },
40dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_ENABLE(2),   0x00000000 },
41dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_ENABLE(3),   0x00000000 },
42dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_POLARITY(0), 0x00000000 },
43dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_POLARITY(1), 0x01000000 },
44dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_POLARITY(2), 0x00000000 },
45dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_POLARITY(3), 0x00000000 },
46dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_DATA(0),     0x00000000 },
47dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_DATA(1),     0x00000000 },
48dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_DATA(2),     0x00000000 },
49dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_DATA(3),     0x00000000 },
50dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(0),   0x00000000 },
51dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(1),   0x00000000 },
52dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(2),   0x00000000 },
53dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(3),   0x00000000 },
54dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(4),   0x00210222 },
55dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(5),   0x00002200 },
56dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(6),   0x00020000 },
57dee8268fSThierry Reding };
58dee8268fSThierry Reding 
59dee8268fSThierry Reding static const struct reg_entry rgb_disable[] = {
60dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(6),   0x00000000 },
61dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(5),   0x00000000 },
62dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(4),   0x00000000 },
63dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(3),   0x00000000 },
64dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(2),   0x00000000 },
65dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(1),   0x00000000 },
66dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(0),   0x00000000 },
67dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_DATA(3),     0xaaaaaaaa },
68dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_DATA(2),     0xaaaaaaaa },
69dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_DATA(1),     0xaaaaaaaa },
70dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_DATA(0),     0xaaaaaaaa },
71dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_POLARITY(3), 0x00000000 },
72dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_POLARITY(2), 0x00000000 },
73dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_POLARITY(1), 0x00000000 },
74dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_POLARITY(0), 0x00000000 },
75dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_ENABLE(3),   0x55555555 },
76dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_ENABLE(2),   0x55555555 },
77dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_ENABLE(1),   0x55150005 },
78dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_ENABLE(0),   0x55555555 },
79dee8268fSThierry Reding };
80dee8268fSThierry Reding 
81dee8268fSThierry Reding static void tegra_dc_write_regs(struct tegra_dc *dc,
82dee8268fSThierry Reding 				const struct reg_entry *table,
83dee8268fSThierry Reding 				unsigned int num)
84dee8268fSThierry Reding {
85dee8268fSThierry Reding 	unsigned int i;
86dee8268fSThierry Reding 
87dee8268fSThierry Reding 	for (i = 0; i < num; i++)
88dee8268fSThierry Reding 		tegra_dc_writel(dc, table[i].value, table[i].offset);
89dee8268fSThierry Reding }
90dee8268fSThierry Reding 
913b0e5855SThierry Reding static void tegra_rgb_connector_dpms(struct drm_connector *connector,
923b0e5855SThierry Reding 				     int mode)
93dee8268fSThierry Reding {
943b0e5855SThierry Reding }
95dee8268fSThierry Reding 
963b0e5855SThierry Reding static const struct drm_connector_funcs tegra_rgb_connector_funcs = {
973b0e5855SThierry Reding 	.dpms = tegra_rgb_connector_dpms,
983b0e5855SThierry Reding 	.detect = tegra_output_connector_detect,
993b0e5855SThierry Reding 	.fill_modes = drm_helper_probe_single_connector_modes,
1003b0e5855SThierry Reding 	.destroy = tegra_output_connector_destroy,
101*4aa3df71SThierry Reding 	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
1023b0e5855SThierry Reding };
1033b0e5855SThierry Reding 
1043b0e5855SThierry Reding static enum drm_mode_status
1053b0e5855SThierry Reding tegra_rgb_connector_mode_valid(struct drm_connector *connector,
1063b0e5855SThierry Reding 			       struct drm_display_mode *mode)
1073b0e5855SThierry Reding {
1083b0e5855SThierry Reding 	/*
1093b0e5855SThierry Reding 	 * FIXME: For now, always assume that the mode is okay. There are
1103b0e5855SThierry Reding 	 * unresolved issues with clk_round_rate(), which doesn't always
1113b0e5855SThierry Reding 	 * reliably report whether a frequency can be set or not.
1123b0e5855SThierry Reding 	 */
1133b0e5855SThierry Reding 	return MODE_OK;
1143b0e5855SThierry Reding }
1153b0e5855SThierry Reding 
1163b0e5855SThierry Reding static const struct drm_connector_helper_funcs tegra_rgb_connector_helper_funcs = {
1173b0e5855SThierry Reding 	.get_modes = tegra_output_connector_get_modes,
1183b0e5855SThierry Reding 	.mode_valid = tegra_rgb_connector_mode_valid,
1193b0e5855SThierry Reding 	.best_encoder = tegra_output_connector_best_encoder,
1203b0e5855SThierry Reding };
1213b0e5855SThierry Reding 
1223b0e5855SThierry Reding static const struct drm_encoder_funcs tegra_rgb_encoder_funcs = {
1233b0e5855SThierry Reding 	.destroy = tegra_output_encoder_destroy,
1243b0e5855SThierry Reding };
1253b0e5855SThierry Reding 
1263b0e5855SThierry Reding static void tegra_rgb_encoder_dpms(struct drm_encoder *encoder, int mode)
1273b0e5855SThierry Reding {
1283b0e5855SThierry Reding }
1293b0e5855SThierry Reding 
1303b0e5855SThierry Reding static bool tegra_rgb_encoder_mode_fixup(struct drm_encoder *encoder,
1313b0e5855SThierry Reding 					 const struct drm_display_mode *mode,
1323b0e5855SThierry Reding 					 struct drm_display_mode *adjusted)
1333b0e5855SThierry Reding {
1343b0e5855SThierry Reding 	struct tegra_output *output = encoder_to_output(encoder);
1353b0e5855SThierry Reding 	unsigned long pclk = mode->clock * 1000;
1363b0e5855SThierry Reding 	struct tegra_rgb *rgb = to_rgb(output);
1373b0e5855SThierry Reding 	unsigned int div;
1383b0e5855SThierry Reding 	int err;
1393b0e5855SThierry Reding 
1403b0e5855SThierry Reding 	/*
1413b0e5855SThierry Reding 	 * We may not want to change the frequency of the parent clock, since
1423b0e5855SThierry Reding 	 * it may be a parent for other peripherals. This is due to the fact
1433b0e5855SThierry Reding 	 * that on Tegra20 there's only a single clock dedicated to display
1443b0e5855SThierry Reding 	 * (pll_d_out0), whereas later generations have a second one that can
1453b0e5855SThierry Reding 	 * be used to independently drive a second output (pll_d2_out0).
1463b0e5855SThierry Reding 	 *
1473b0e5855SThierry Reding 	 * As a way to support multiple outputs on Tegra20 as well, pll_p is
1483b0e5855SThierry Reding 	 * typically used as the parent clock for the display controllers.
1493b0e5855SThierry Reding 	 * But this comes at a cost: pll_p is the parent of several other
1503b0e5855SThierry Reding 	 * peripherals, so its frequency shouldn't change out of the blue.
1513b0e5855SThierry Reding 	 *
1523b0e5855SThierry Reding 	 * The best we can do at this point is to use the shift clock divider
1533b0e5855SThierry Reding 	 * and hope that the desired frequency can be matched (or at least
1543b0e5855SThierry Reding 	 * matched sufficiently close that the panel will still work).
1553b0e5855SThierry Reding 	 */
1563b0e5855SThierry Reding 	div = ((clk_get_rate(rgb->clk) * 2) / pclk) - 2;
1573b0e5855SThierry Reding 
1583b0e5855SThierry Reding 	err = tegra_dc_setup_clock(rgb->dc, rgb->clk_parent, pclk, div);
1593b0e5855SThierry Reding 	if (err < 0) {
1603b0e5855SThierry Reding 		dev_err(output->dev, "failed to setup DC clock: %d\n", err);
1613b0e5855SThierry Reding 		return false;
1623b0e5855SThierry Reding 	}
1633b0e5855SThierry Reding 
1643b0e5855SThierry Reding 	return true;
1653b0e5855SThierry Reding }
1663b0e5855SThierry Reding 
1673b0e5855SThierry Reding static void tegra_rgb_encoder_prepare(struct drm_encoder *encoder)
1683b0e5855SThierry Reding {
1693b0e5855SThierry Reding }
1703b0e5855SThierry Reding 
1713b0e5855SThierry Reding static void tegra_rgb_encoder_commit(struct drm_encoder *encoder)
1723b0e5855SThierry Reding {
1733b0e5855SThierry Reding }
1743b0e5855SThierry Reding 
1753b0e5855SThierry Reding static void tegra_rgb_encoder_mode_set(struct drm_encoder *encoder,
1763b0e5855SThierry Reding 				       struct drm_display_mode *mode,
1773b0e5855SThierry Reding 				       struct drm_display_mode *adjusted)
1783b0e5855SThierry Reding {
1793b0e5855SThierry Reding 	struct tegra_output *output = encoder_to_output(encoder);
1803b0e5855SThierry Reding 	struct tegra_rgb *rgb = to_rgb(output);
1813b0e5855SThierry Reding 	u32 value;
1823b0e5855SThierry Reding 
1833b0e5855SThierry Reding 	if (output->panel)
1843b0e5855SThierry Reding 		drm_panel_prepare(output->panel);
185b1891537SDmitry Osipenko 
1867602fa1dSThierry Reding 	tegra_dc_write_regs(rgb->dc, rgb_enable, ARRAY_SIZE(rgb_enable));
187dee8268fSThierry Reding 
18872d30286SThierry Reding 	value = DE_SELECT_ACTIVE | DE_CONTROL_NORMAL;
18972d30286SThierry Reding 	tegra_dc_writel(rgb->dc, value, DC_DISP_DATA_ENABLE_OPTIONS);
19072d30286SThierry Reding 
19172d30286SThierry Reding 	/* XXX: parameterize? */
19272d30286SThierry Reding 	value = tegra_dc_readl(rgb->dc, DC_COM_PIN_OUTPUT_POLARITY(1));
19372d30286SThierry Reding 	value &= ~LVS_OUTPUT_POLARITY_LOW;
19472d30286SThierry Reding 	value &= ~LHS_OUTPUT_POLARITY_LOW;
19572d30286SThierry Reding 	tegra_dc_writel(rgb->dc, value, DC_COM_PIN_OUTPUT_POLARITY(1));
19672d30286SThierry Reding 
19772d30286SThierry Reding 	/* XXX: parameterize? */
19872d30286SThierry Reding 	value = DISP_DATA_FORMAT_DF1P1C | DISP_ALIGNMENT_MSB |
19972d30286SThierry Reding 		DISP_ORDER_RED_BLUE;
20072d30286SThierry Reding 	tegra_dc_writel(rgb->dc, value, DC_DISP_DISP_INTERFACE_CONTROL);
20172d30286SThierry Reding 
20272d30286SThierry Reding 	/* XXX: parameterize? */
20372d30286SThierry Reding 	value = SC0_H_QUALIFIER_NONE | SC1_H_QUALIFIER_NONE;
20472d30286SThierry Reding 	tegra_dc_writel(rgb->dc, value, DC_DISP_SHIFT_CLOCK_OPTIONS);
20572d30286SThierry Reding 
20672d30286SThierry Reding 	value = tegra_dc_readl(rgb->dc, DC_CMD_DISPLAY_COMMAND);
20772d30286SThierry Reding 	value &= ~DISP_CTRL_MODE_MASK;
20872d30286SThierry Reding 	value |= DISP_CTRL_MODE_C_DISPLAY;
20972d30286SThierry Reding 	tegra_dc_writel(rgb->dc, value, DC_CMD_DISPLAY_COMMAND);
21072d30286SThierry Reding 
21172d30286SThierry Reding 	value = tegra_dc_readl(rgb->dc, DC_CMD_DISPLAY_POWER_CONTROL);
21272d30286SThierry Reding 	value |= PW0_ENABLE | PW1_ENABLE | PW2_ENABLE | PW3_ENABLE |
21372d30286SThierry Reding 		 PW4_ENABLE | PM0_ENABLE | PM1_ENABLE;
21472d30286SThierry Reding 	tegra_dc_writel(rgb->dc, value, DC_CMD_DISPLAY_POWER_CONTROL);
21572d30286SThierry Reding 
21662b9e063SThierry Reding 	tegra_dc_commit(rgb->dc);
21772d30286SThierry Reding 
2183b0e5855SThierry Reding 	if (output->panel)
2193b0e5855SThierry Reding 		drm_panel_enable(output->panel);
220dee8268fSThierry Reding }
221dee8268fSThierry Reding 
2223b0e5855SThierry Reding static void tegra_rgb_encoder_disable(struct drm_encoder *encoder)
223dee8268fSThierry Reding {
2243b0e5855SThierry Reding 	struct tegra_output *output = encoder_to_output(encoder);
2257602fa1dSThierry Reding 	struct tegra_rgb *rgb = to_rgb(output);
22672d30286SThierry Reding 
2273b0e5855SThierry Reding 	if (output->panel)
2283b0e5855SThierry Reding 		drm_panel_disable(output->panel);
22972d30286SThierry Reding 
2307602fa1dSThierry Reding 	tegra_dc_write_regs(rgb->dc, rgb_disable, ARRAY_SIZE(rgb_disable));
231dee8268fSThierry Reding 
2323b0e5855SThierry Reding 	if (output->panel)
2333b0e5855SThierry Reding 		drm_panel_unprepare(output->panel);
234dee8268fSThierry Reding }
235dee8268fSThierry Reding 
2363b0e5855SThierry Reding static const struct drm_encoder_helper_funcs tegra_rgb_encoder_helper_funcs = {
2373b0e5855SThierry Reding 	.dpms = tegra_rgb_encoder_dpms,
2383b0e5855SThierry Reding 	.mode_fixup = tegra_rgb_encoder_mode_fixup,
2393b0e5855SThierry Reding 	.prepare = tegra_rgb_encoder_prepare,
2403b0e5855SThierry Reding 	.commit = tegra_rgb_encoder_commit,
2413b0e5855SThierry Reding 	.mode_set = tegra_rgb_encoder_mode_set,
2423b0e5855SThierry Reding 	.disable = tegra_rgb_encoder_disable,
243dee8268fSThierry Reding };
244dee8268fSThierry Reding 
245dee8268fSThierry Reding int tegra_dc_rgb_probe(struct tegra_dc *dc)
246dee8268fSThierry Reding {
247dee8268fSThierry Reding 	struct device_node *np;
248dee8268fSThierry Reding 	struct tegra_rgb *rgb;
249dee8268fSThierry Reding 	int err;
250dee8268fSThierry Reding 
251dee8268fSThierry Reding 	np = of_get_child_by_name(dc->dev->of_node, "rgb");
252dee8268fSThierry Reding 	if (!np || !of_device_is_available(np))
253dee8268fSThierry Reding 		return -ENODEV;
254dee8268fSThierry Reding 
255dee8268fSThierry Reding 	rgb = devm_kzalloc(dc->dev, sizeof(*rgb), GFP_KERNEL);
256dee8268fSThierry Reding 	if (!rgb)
257dee8268fSThierry Reding 		return -ENOMEM;
258dee8268fSThierry Reding 
259dee8268fSThierry Reding 	rgb->output.dev = dc->dev;
260dee8268fSThierry Reding 	rgb->output.of_node = np;
2617602fa1dSThierry Reding 	rgb->dc = dc;
262dee8268fSThierry Reding 
26359d29c0eSThierry Reding 	err = tegra_output_probe(&rgb->output);
264dee8268fSThierry Reding 	if (err < 0)
265dee8268fSThierry Reding 		return err;
266dee8268fSThierry Reding 
267dee8268fSThierry Reding 	rgb->clk = devm_clk_get(dc->dev, NULL);
268dee8268fSThierry Reding 	if (IS_ERR(rgb->clk)) {
269dee8268fSThierry Reding 		dev_err(dc->dev, "failed to get clock\n");
270dee8268fSThierry Reding 		return PTR_ERR(rgb->clk);
271dee8268fSThierry Reding 	}
272dee8268fSThierry Reding 
273dee8268fSThierry Reding 	rgb->clk_parent = devm_clk_get(dc->dev, "parent");
274dee8268fSThierry Reding 	if (IS_ERR(rgb->clk_parent)) {
275dee8268fSThierry Reding 		dev_err(dc->dev, "failed to get parent clock\n");
276dee8268fSThierry Reding 		return PTR_ERR(rgb->clk_parent);
277dee8268fSThierry Reding 	}
278dee8268fSThierry Reding 
279dee8268fSThierry Reding 	err = clk_set_parent(rgb->clk, rgb->clk_parent);
280dee8268fSThierry Reding 	if (err < 0) {
281dee8268fSThierry Reding 		dev_err(dc->dev, "failed to set parent clock: %d\n", err);
282dee8268fSThierry Reding 		return err;
283dee8268fSThierry Reding 	}
284dee8268fSThierry Reding 
285dee8268fSThierry Reding 	dc->rgb = &rgb->output;
286dee8268fSThierry Reding 
287dee8268fSThierry Reding 	return 0;
288dee8268fSThierry Reding }
289dee8268fSThierry Reding 
29059d29c0eSThierry Reding int tegra_dc_rgb_remove(struct tegra_dc *dc)
29159d29c0eSThierry Reding {
29259d29c0eSThierry Reding 	if (!dc->rgb)
29359d29c0eSThierry Reding 		return 0;
29459d29c0eSThierry Reding 
295328ec69eSThierry Reding 	tegra_output_remove(dc->rgb);
2963b0e5855SThierry Reding 	dc->rgb = NULL;
2973b0e5855SThierry Reding 
29859d29c0eSThierry Reding 	return 0;
29959d29c0eSThierry Reding }
30059d29c0eSThierry Reding 
301dee8268fSThierry Reding int tegra_dc_rgb_init(struct drm_device *drm, struct tegra_dc *dc)
302dee8268fSThierry Reding {
3033b0e5855SThierry Reding 	struct tegra_output *output = dc->rgb;
304dee8268fSThierry Reding 	int err;
305dee8268fSThierry Reding 
306dee8268fSThierry Reding 	if (!dc->rgb)
307dee8268fSThierry Reding 		return -ENODEV;
308dee8268fSThierry Reding 
3093b0e5855SThierry Reding 	drm_connector_init(drm, &output->connector, &tegra_rgb_connector_funcs,
3103b0e5855SThierry Reding 			   DRM_MODE_CONNECTOR_LVDS);
3113b0e5855SThierry Reding 	drm_connector_helper_add(&output->connector,
3123b0e5855SThierry Reding 				 &tegra_rgb_connector_helper_funcs);
3133b0e5855SThierry Reding 	output->connector.dpms = DRM_MODE_DPMS_OFF;
314dee8268fSThierry Reding 
3153b0e5855SThierry Reding 	drm_encoder_init(drm, &output->encoder, &tegra_rgb_encoder_funcs,
3163b0e5855SThierry Reding 			 DRM_MODE_ENCODER_LVDS);
3173b0e5855SThierry Reding 	drm_encoder_helper_add(&output->encoder,
3183b0e5855SThierry Reding 			       &tegra_rgb_encoder_helper_funcs);
3193b0e5855SThierry Reding 
3203b0e5855SThierry Reding 	drm_mode_connector_attach_encoder(&output->connector,
3213b0e5855SThierry Reding 					  &output->encoder);
3223b0e5855SThierry Reding 	drm_connector_register(&output->connector);
3233b0e5855SThierry Reding 
324ea130b24SThierry Reding 	err = tegra_output_init(drm, output);
325ea130b24SThierry Reding 	if (err < 0) {
326ea130b24SThierry Reding 		dev_err(output->dev, "failed to initialize output: %d\n", err);
327ea130b24SThierry Reding 		return err;
328ea130b24SThierry Reding 	}
329ea130b24SThierry Reding 
330dee8268fSThierry Reding 	/*
3313b0e5855SThierry Reding 	 * Other outputs can be attached to either display controller. The RGB
3323b0e5855SThierry Reding 	 * outputs are an exception and work only with their parent display
3333b0e5855SThierry Reding 	 * controller.
334dee8268fSThierry Reding 	 */
3353b0e5855SThierry Reding 	output->encoder.possible_crtcs = drm_crtc_mask(&dc->base);
336dee8268fSThierry Reding 
337dee8268fSThierry Reding 	return 0;
338dee8268fSThierry Reding }
339dee8268fSThierry Reding 
340dee8268fSThierry Reding int tegra_dc_rgb_exit(struct tegra_dc *dc)
341dee8268fSThierry Reding {
342328ec69eSThierry Reding 	if (dc->rgb)
343328ec69eSThierry Reding 		tegra_output_exit(dc->rgb);
3443b0e5855SThierry Reding 
345328ec69eSThierry Reding 	return 0;
346dee8268fSThierry Reding }
347