xref: /openbmc/linux/drivers/gpu/drm/tegra/rgb.c (revision 3cebae6737b100323baca21de6bce6647249e778)
1dee8268fSThierry Reding /*
2dee8268fSThierry Reding  * Copyright (C) 2012 Avionic Design GmbH
3dee8268fSThierry Reding  * Copyright (C) 2012 NVIDIA CORPORATION.  All rights reserved.
4dee8268fSThierry Reding  *
5dee8268fSThierry Reding  * This program is free software; you can redistribute it and/or modify
6dee8268fSThierry Reding  * it under the terms of the GNU General Public License version 2 as
7dee8268fSThierry Reding  * published by the Free Software Foundation.
8dee8268fSThierry Reding  */
9dee8268fSThierry Reding 
10dee8268fSThierry Reding #include <linux/clk.h>
11dee8268fSThierry Reding 
124aa3df71SThierry Reding #include <drm/drm_atomic_helper.h>
133b0e5855SThierry Reding #include <drm/drm_panel.h>
143b0e5855SThierry Reding 
15dee8268fSThierry Reding #include "drm.h"
16dee8268fSThierry Reding #include "dc.h"
17dee8268fSThierry Reding 
18dee8268fSThierry Reding struct tegra_rgb {
19dee8268fSThierry Reding 	struct tegra_output output;
207602fa1dSThierry Reding 	struct tegra_dc *dc;
21b1891537SDmitry Osipenko 	bool enabled;
227602fa1dSThierry Reding 
23dee8268fSThierry Reding 	struct clk *clk_parent;
24dee8268fSThierry Reding 	struct clk *clk;
25dee8268fSThierry Reding };
26dee8268fSThierry Reding 
27dee8268fSThierry Reding static inline struct tegra_rgb *to_rgb(struct tegra_output *output)
28dee8268fSThierry Reding {
29dee8268fSThierry Reding 	return container_of(output, struct tegra_rgb, output);
30dee8268fSThierry Reding }
31dee8268fSThierry Reding 
32dee8268fSThierry Reding struct reg_entry {
33dee8268fSThierry Reding 	unsigned long offset;
34dee8268fSThierry Reding 	unsigned long value;
35dee8268fSThierry Reding };
36dee8268fSThierry Reding 
37dee8268fSThierry Reding static const struct reg_entry rgb_enable[] = {
38dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_ENABLE(0),   0x00000000 },
39dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_ENABLE(1),   0x00000000 },
40dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_ENABLE(2),   0x00000000 },
41dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_ENABLE(3),   0x00000000 },
42dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_POLARITY(0), 0x00000000 },
43dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_POLARITY(1), 0x01000000 },
44dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_POLARITY(2), 0x00000000 },
45dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_POLARITY(3), 0x00000000 },
46dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_DATA(0),     0x00000000 },
47dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_DATA(1),     0x00000000 },
48dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_DATA(2),     0x00000000 },
49dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_DATA(3),     0x00000000 },
50dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(0),   0x00000000 },
51dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(1),   0x00000000 },
52dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(2),   0x00000000 },
53dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(3),   0x00000000 },
54dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(4),   0x00210222 },
55dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(5),   0x00002200 },
56dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(6),   0x00020000 },
57dee8268fSThierry Reding };
58dee8268fSThierry Reding 
59dee8268fSThierry Reding static const struct reg_entry rgb_disable[] = {
60dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(6),   0x00000000 },
61dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(5),   0x00000000 },
62dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(4),   0x00000000 },
63dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(3),   0x00000000 },
64dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(2),   0x00000000 },
65dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(1),   0x00000000 },
66dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(0),   0x00000000 },
67dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_DATA(3),     0xaaaaaaaa },
68dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_DATA(2),     0xaaaaaaaa },
69dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_DATA(1),     0xaaaaaaaa },
70dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_DATA(0),     0xaaaaaaaa },
71dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_POLARITY(3), 0x00000000 },
72dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_POLARITY(2), 0x00000000 },
73dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_POLARITY(1), 0x00000000 },
74dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_POLARITY(0), 0x00000000 },
75dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_ENABLE(3),   0x55555555 },
76dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_ENABLE(2),   0x55555555 },
77dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_ENABLE(1),   0x55150005 },
78dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_ENABLE(0),   0x55555555 },
79dee8268fSThierry Reding };
80dee8268fSThierry Reding 
81dee8268fSThierry Reding static void tegra_dc_write_regs(struct tegra_dc *dc,
82dee8268fSThierry Reding 				const struct reg_entry *table,
83dee8268fSThierry Reding 				unsigned int num)
84dee8268fSThierry Reding {
85dee8268fSThierry Reding 	unsigned int i;
86dee8268fSThierry Reding 
87dee8268fSThierry Reding 	for (i = 0; i < num; i++)
88dee8268fSThierry Reding 		tegra_dc_writel(dc, table[i].value, table[i].offset);
89dee8268fSThierry Reding }
90dee8268fSThierry Reding 
913b0e5855SThierry Reding static void tegra_rgb_connector_dpms(struct drm_connector *connector,
923b0e5855SThierry Reding 				     int mode)
93dee8268fSThierry Reding {
943b0e5855SThierry Reding }
95dee8268fSThierry Reding 
963b0e5855SThierry Reding static const struct drm_connector_funcs tegra_rgb_connector_funcs = {
973b0e5855SThierry Reding 	.dpms = tegra_rgb_connector_dpms,
989d44189fSThierry Reding 	.reset = drm_atomic_helper_connector_reset,
993b0e5855SThierry Reding 	.detect = tegra_output_connector_detect,
1003b0e5855SThierry Reding 	.fill_modes = drm_helper_probe_single_connector_modes,
1013b0e5855SThierry Reding 	.destroy = tegra_output_connector_destroy,
1029d44189fSThierry Reding 	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
1034aa3df71SThierry Reding 	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
1043b0e5855SThierry Reding };
1053b0e5855SThierry Reding 
1063b0e5855SThierry Reding static enum drm_mode_status
1073b0e5855SThierry Reding tegra_rgb_connector_mode_valid(struct drm_connector *connector,
1083b0e5855SThierry Reding 			       struct drm_display_mode *mode)
1093b0e5855SThierry Reding {
1103b0e5855SThierry Reding 	/*
1113b0e5855SThierry Reding 	 * FIXME: For now, always assume that the mode is okay. There are
1123b0e5855SThierry Reding 	 * unresolved issues with clk_round_rate(), which doesn't always
1133b0e5855SThierry Reding 	 * reliably report whether a frequency can be set or not.
1143b0e5855SThierry Reding 	 */
1153b0e5855SThierry Reding 	return MODE_OK;
1163b0e5855SThierry Reding }
1173b0e5855SThierry Reding 
1183b0e5855SThierry Reding static const struct drm_connector_helper_funcs tegra_rgb_connector_helper_funcs = {
1193b0e5855SThierry Reding 	.get_modes = tegra_output_connector_get_modes,
1203b0e5855SThierry Reding 	.mode_valid = tegra_rgb_connector_mode_valid,
1213b0e5855SThierry Reding 	.best_encoder = tegra_output_connector_best_encoder,
1223b0e5855SThierry Reding };
1233b0e5855SThierry Reding 
1243b0e5855SThierry Reding static const struct drm_encoder_funcs tegra_rgb_encoder_funcs = {
1253b0e5855SThierry Reding 	.destroy = tegra_output_encoder_destroy,
1263b0e5855SThierry Reding };
1273b0e5855SThierry Reding 
1283b0e5855SThierry Reding static void tegra_rgb_encoder_dpms(struct drm_encoder *encoder, int mode)
1293b0e5855SThierry Reding {
1303b0e5855SThierry Reding }
1313b0e5855SThierry Reding 
1323b0e5855SThierry Reding static bool tegra_rgb_encoder_mode_fixup(struct drm_encoder *encoder,
1333b0e5855SThierry Reding 					 const struct drm_display_mode *mode,
1343b0e5855SThierry Reding 					 struct drm_display_mode *adjusted)
1353b0e5855SThierry Reding {
1363b0e5855SThierry Reding 	struct tegra_output *output = encoder_to_output(encoder);
1373b0e5855SThierry Reding 	unsigned long pclk = mode->clock * 1000;
1383b0e5855SThierry Reding 	struct tegra_rgb *rgb = to_rgb(output);
1393b0e5855SThierry Reding 	unsigned int div;
1403b0e5855SThierry Reding 	int err;
1413b0e5855SThierry Reding 
1423b0e5855SThierry Reding 	/*
1433b0e5855SThierry Reding 	 * We may not want to change the frequency of the parent clock, since
1443b0e5855SThierry Reding 	 * it may be a parent for other peripherals. This is due to the fact
1453b0e5855SThierry Reding 	 * that on Tegra20 there's only a single clock dedicated to display
1463b0e5855SThierry Reding 	 * (pll_d_out0), whereas later generations have a second one that can
1473b0e5855SThierry Reding 	 * be used to independently drive a second output (pll_d2_out0).
1483b0e5855SThierry Reding 	 *
1493b0e5855SThierry Reding 	 * As a way to support multiple outputs on Tegra20 as well, pll_p is
1503b0e5855SThierry Reding 	 * typically used as the parent clock for the display controllers.
1513b0e5855SThierry Reding 	 * But this comes at a cost: pll_p is the parent of several other
1523b0e5855SThierry Reding 	 * peripherals, so its frequency shouldn't change out of the blue.
1533b0e5855SThierry Reding 	 *
1543b0e5855SThierry Reding 	 * The best we can do at this point is to use the shift clock divider
1553b0e5855SThierry Reding 	 * and hope that the desired frequency can be matched (or at least
1563b0e5855SThierry Reding 	 * matched sufficiently close that the panel will still work).
1573b0e5855SThierry Reding 	 */
1583b0e5855SThierry Reding 	div = ((clk_get_rate(rgb->clk) * 2) / pclk) - 2;
1593b0e5855SThierry Reding 
1603b0e5855SThierry Reding 	err = tegra_dc_setup_clock(rgb->dc, rgb->clk_parent, pclk, div);
1613b0e5855SThierry Reding 	if (err < 0) {
1623b0e5855SThierry Reding 		dev_err(output->dev, "failed to setup DC clock: %d\n", err);
1633b0e5855SThierry Reding 		return false;
1643b0e5855SThierry Reding 	}
1653b0e5855SThierry Reding 
1663b0e5855SThierry Reding 	return true;
1673b0e5855SThierry Reding }
1683b0e5855SThierry Reding 
1693b0e5855SThierry Reding static void tegra_rgb_encoder_prepare(struct drm_encoder *encoder)
1703b0e5855SThierry Reding {
1713b0e5855SThierry Reding }
1723b0e5855SThierry Reding 
1733b0e5855SThierry Reding static void tegra_rgb_encoder_commit(struct drm_encoder *encoder)
1743b0e5855SThierry Reding {
1753b0e5855SThierry Reding }
1763b0e5855SThierry Reding 
1773b0e5855SThierry Reding static void tegra_rgb_encoder_mode_set(struct drm_encoder *encoder,
1783b0e5855SThierry Reding 				       struct drm_display_mode *mode,
1793b0e5855SThierry Reding 				       struct drm_display_mode *adjusted)
1803b0e5855SThierry Reding {
1813b0e5855SThierry Reding 	struct tegra_output *output = encoder_to_output(encoder);
1823b0e5855SThierry Reding 	struct tegra_rgb *rgb = to_rgb(output);
1833b0e5855SThierry Reding 	u32 value;
1843b0e5855SThierry Reding 
1853b0e5855SThierry Reding 	if (output->panel)
1863b0e5855SThierry Reding 		drm_panel_prepare(output->panel);
187b1891537SDmitry Osipenko 
1887602fa1dSThierry Reding 	tegra_dc_write_regs(rgb->dc, rgb_enable, ARRAY_SIZE(rgb_enable));
189dee8268fSThierry Reding 
19072d30286SThierry Reding 	value = DE_SELECT_ACTIVE | DE_CONTROL_NORMAL;
19172d30286SThierry Reding 	tegra_dc_writel(rgb->dc, value, DC_DISP_DATA_ENABLE_OPTIONS);
19272d30286SThierry Reding 
19372d30286SThierry Reding 	/* XXX: parameterize? */
19472d30286SThierry Reding 	value = tegra_dc_readl(rgb->dc, DC_COM_PIN_OUTPUT_POLARITY(1));
19572d30286SThierry Reding 	value &= ~LVS_OUTPUT_POLARITY_LOW;
19672d30286SThierry Reding 	value &= ~LHS_OUTPUT_POLARITY_LOW;
19772d30286SThierry Reding 	tegra_dc_writel(rgb->dc, value, DC_COM_PIN_OUTPUT_POLARITY(1));
19872d30286SThierry Reding 
19972d30286SThierry Reding 	/* XXX: parameterize? */
20072d30286SThierry Reding 	value = DISP_DATA_FORMAT_DF1P1C | DISP_ALIGNMENT_MSB |
20172d30286SThierry Reding 		DISP_ORDER_RED_BLUE;
20272d30286SThierry Reding 	tegra_dc_writel(rgb->dc, value, DC_DISP_DISP_INTERFACE_CONTROL);
20372d30286SThierry Reding 
20472d30286SThierry Reding 	/* XXX: parameterize? */
20572d30286SThierry Reding 	value = SC0_H_QUALIFIER_NONE | SC1_H_QUALIFIER_NONE;
20672d30286SThierry Reding 	tegra_dc_writel(rgb->dc, value, DC_DISP_SHIFT_CLOCK_OPTIONS);
20772d30286SThierry Reding 
20872d30286SThierry Reding 	value = tegra_dc_readl(rgb->dc, DC_CMD_DISPLAY_COMMAND);
20972d30286SThierry Reding 	value &= ~DISP_CTRL_MODE_MASK;
21072d30286SThierry Reding 	value |= DISP_CTRL_MODE_C_DISPLAY;
21172d30286SThierry Reding 	tegra_dc_writel(rgb->dc, value, DC_CMD_DISPLAY_COMMAND);
21272d30286SThierry Reding 
21372d30286SThierry Reding 	value = tegra_dc_readl(rgb->dc, DC_CMD_DISPLAY_POWER_CONTROL);
21472d30286SThierry Reding 	value |= PW0_ENABLE | PW1_ENABLE | PW2_ENABLE | PW3_ENABLE |
21572d30286SThierry Reding 		 PW4_ENABLE | PM0_ENABLE | PM1_ENABLE;
21672d30286SThierry Reding 	tegra_dc_writel(rgb->dc, value, DC_CMD_DISPLAY_POWER_CONTROL);
21772d30286SThierry Reding 
21862b9e063SThierry Reding 	tegra_dc_commit(rgb->dc);
21972d30286SThierry Reding 
2203b0e5855SThierry Reding 	if (output->panel)
2213b0e5855SThierry Reding 		drm_panel_enable(output->panel);
222dee8268fSThierry Reding }
223dee8268fSThierry Reding 
2243b0e5855SThierry Reding static void tegra_rgb_encoder_disable(struct drm_encoder *encoder)
225dee8268fSThierry Reding {
2263b0e5855SThierry Reding 	struct tegra_output *output = encoder_to_output(encoder);
2277602fa1dSThierry Reding 	struct tegra_rgb *rgb = to_rgb(output);
22872d30286SThierry Reding 
2293b0e5855SThierry Reding 	if (output->panel)
2303b0e5855SThierry Reding 		drm_panel_disable(output->panel);
23172d30286SThierry Reding 
2327602fa1dSThierry Reding 	tegra_dc_write_regs(rgb->dc, rgb_disable, ARRAY_SIZE(rgb_disable));
233dee8268fSThierry Reding 
2343b0e5855SThierry Reding 	if (output->panel)
2353b0e5855SThierry Reding 		drm_panel_unprepare(output->panel);
236dee8268fSThierry Reding }
237dee8268fSThierry Reding 
238*3cebae67SThierry Reding static int
239*3cebae67SThierry Reding tegra_rgb_encoder_atomic_check(struct drm_encoder *encoder,
240*3cebae67SThierry Reding 			       struct drm_crtc_state *crtc_state,
241*3cebae67SThierry Reding 			       struct drm_connector_state *conn_state)
242*3cebae67SThierry Reding {
243*3cebae67SThierry Reding 	struct tegra_output *output = encoder_to_output(encoder);
244*3cebae67SThierry Reding 	struct tegra_dc *dc = to_tegra_dc(conn_state->crtc);
245*3cebae67SThierry Reding 	unsigned long pclk = crtc_state->mode.clock * 1000;
246*3cebae67SThierry Reding 	struct tegra_rgb *rgb = to_rgb(output);
247*3cebae67SThierry Reding 	unsigned int div;
248*3cebae67SThierry Reding 	int err;
249*3cebae67SThierry Reding 
250*3cebae67SThierry Reding 	/*
251*3cebae67SThierry Reding 	 * We may not want to change the frequency of the parent clock, since
252*3cebae67SThierry Reding 	 * it may be a parent for other peripherals. This is due to the fact
253*3cebae67SThierry Reding 	 * that on Tegra20 there's only a single clock dedicated to display
254*3cebae67SThierry Reding 	 * (pll_d_out0), whereas later generations have a second one that can
255*3cebae67SThierry Reding 	 * be used to independently drive a second output (pll_d2_out0).
256*3cebae67SThierry Reding 	 *
257*3cebae67SThierry Reding 	 * As a way to support multiple outputs on Tegra20 as well, pll_p is
258*3cebae67SThierry Reding 	 * typically used as the parent clock for the display controllers.
259*3cebae67SThierry Reding 	 * But this comes at a cost: pll_p is the parent of several other
260*3cebae67SThierry Reding 	 * peripherals, so its frequency shouldn't change out of the blue.
261*3cebae67SThierry Reding 	 *
262*3cebae67SThierry Reding 	 * The best we can do at this point is to use the shift clock divider
263*3cebae67SThierry Reding 	 * and hope that the desired frequency can be matched (or at least
264*3cebae67SThierry Reding 	 * matched sufficiently close that the panel will still work).
265*3cebae67SThierry Reding 	 */
266*3cebae67SThierry Reding 	div = ((clk_get_rate(rgb->clk) * 2) / pclk) - 2;
267*3cebae67SThierry Reding 	pclk = 0;
268*3cebae67SThierry Reding 
269*3cebae67SThierry Reding 	err = tegra_dc_state_setup_clock(dc, crtc_state, rgb->clk_parent,
270*3cebae67SThierry Reding 					 pclk, div);
271*3cebae67SThierry Reding 	if (err < 0) {
272*3cebae67SThierry Reding 		dev_err(output->dev, "failed to setup CRTC state: %d\n", err);
273*3cebae67SThierry Reding 		return err;
274*3cebae67SThierry Reding 	}
275*3cebae67SThierry Reding 
276*3cebae67SThierry Reding 	return err;
277*3cebae67SThierry Reding }
278*3cebae67SThierry Reding 
2793b0e5855SThierry Reding static const struct drm_encoder_helper_funcs tegra_rgb_encoder_helper_funcs = {
2803b0e5855SThierry Reding 	.dpms = tegra_rgb_encoder_dpms,
2813b0e5855SThierry Reding 	.mode_fixup = tegra_rgb_encoder_mode_fixup,
2823b0e5855SThierry Reding 	.prepare = tegra_rgb_encoder_prepare,
2833b0e5855SThierry Reding 	.commit = tegra_rgb_encoder_commit,
2843b0e5855SThierry Reding 	.mode_set = tegra_rgb_encoder_mode_set,
2853b0e5855SThierry Reding 	.disable = tegra_rgb_encoder_disable,
286*3cebae67SThierry Reding 	.atomic_check = tegra_rgb_encoder_atomic_check,
287dee8268fSThierry Reding };
288dee8268fSThierry Reding 
289dee8268fSThierry Reding int tegra_dc_rgb_probe(struct tegra_dc *dc)
290dee8268fSThierry Reding {
291dee8268fSThierry Reding 	struct device_node *np;
292dee8268fSThierry Reding 	struct tegra_rgb *rgb;
293dee8268fSThierry Reding 	int err;
294dee8268fSThierry Reding 
295dee8268fSThierry Reding 	np = of_get_child_by_name(dc->dev->of_node, "rgb");
296dee8268fSThierry Reding 	if (!np || !of_device_is_available(np))
297dee8268fSThierry Reding 		return -ENODEV;
298dee8268fSThierry Reding 
299dee8268fSThierry Reding 	rgb = devm_kzalloc(dc->dev, sizeof(*rgb), GFP_KERNEL);
300dee8268fSThierry Reding 	if (!rgb)
301dee8268fSThierry Reding 		return -ENOMEM;
302dee8268fSThierry Reding 
303dee8268fSThierry Reding 	rgb->output.dev = dc->dev;
304dee8268fSThierry Reding 	rgb->output.of_node = np;
3057602fa1dSThierry Reding 	rgb->dc = dc;
306dee8268fSThierry Reding 
30759d29c0eSThierry Reding 	err = tegra_output_probe(&rgb->output);
308dee8268fSThierry Reding 	if (err < 0)
309dee8268fSThierry Reding 		return err;
310dee8268fSThierry Reding 
311dee8268fSThierry Reding 	rgb->clk = devm_clk_get(dc->dev, NULL);
312dee8268fSThierry Reding 	if (IS_ERR(rgb->clk)) {
313dee8268fSThierry Reding 		dev_err(dc->dev, "failed to get clock\n");
314dee8268fSThierry Reding 		return PTR_ERR(rgb->clk);
315dee8268fSThierry Reding 	}
316dee8268fSThierry Reding 
317dee8268fSThierry Reding 	rgb->clk_parent = devm_clk_get(dc->dev, "parent");
318dee8268fSThierry Reding 	if (IS_ERR(rgb->clk_parent)) {
319dee8268fSThierry Reding 		dev_err(dc->dev, "failed to get parent clock\n");
320dee8268fSThierry Reding 		return PTR_ERR(rgb->clk_parent);
321dee8268fSThierry Reding 	}
322dee8268fSThierry Reding 
323dee8268fSThierry Reding 	err = clk_set_parent(rgb->clk, rgb->clk_parent);
324dee8268fSThierry Reding 	if (err < 0) {
325dee8268fSThierry Reding 		dev_err(dc->dev, "failed to set parent clock: %d\n", err);
326dee8268fSThierry Reding 		return err;
327dee8268fSThierry Reding 	}
328dee8268fSThierry Reding 
329dee8268fSThierry Reding 	dc->rgb = &rgb->output;
330dee8268fSThierry Reding 
331dee8268fSThierry Reding 	return 0;
332dee8268fSThierry Reding }
333dee8268fSThierry Reding 
33459d29c0eSThierry Reding int tegra_dc_rgb_remove(struct tegra_dc *dc)
33559d29c0eSThierry Reding {
33659d29c0eSThierry Reding 	if (!dc->rgb)
33759d29c0eSThierry Reding 		return 0;
33859d29c0eSThierry Reding 
339328ec69eSThierry Reding 	tegra_output_remove(dc->rgb);
3403b0e5855SThierry Reding 	dc->rgb = NULL;
3413b0e5855SThierry Reding 
34259d29c0eSThierry Reding 	return 0;
34359d29c0eSThierry Reding }
34459d29c0eSThierry Reding 
345dee8268fSThierry Reding int tegra_dc_rgb_init(struct drm_device *drm, struct tegra_dc *dc)
346dee8268fSThierry Reding {
3473b0e5855SThierry Reding 	struct tegra_output *output = dc->rgb;
348dee8268fSThierry Reding 	int err;
349dee8268fSThierry Reding 
350dee8268fSThierry Reding 	if (!dc->rgb)
351dee8268fSThierry Reding 		return -ENODEV;
352dee8268fSThierry Reding 
3533b0e5855SThierry Reding 	drm_connector_init(drm, &output->connector, &tegra_rgb_connector_funcs,
3543b0e5855SThierry Reding 			   DRM_MODE_CONNECTOR_LVDS);
3553b0e5855SThierry Reding 	drm_connector_helper_add(&output->connector,
3563b0e5855SThierry Reding 				 &tegra_rgb_connector_helper_funcs);
3573b0e5855SThierry Reding 	output->connector.dpms = DRM_MODE_DPMS_OFF;
358dee8268fSThierry Reding 
3593b0e5855SThierry Reding 	drm_encoder_init(drm, &output->encoder, &tegra_rgb_encoder_funcs,
3603b0e5855SThierry Reding 			 DRM_MODE_ENCODER_LVDS);
3613b0e5855SThierry Reding 	drm_encoder_helper_add(&output->encoder,
3623b0e5855SThierry Reding 			       &tegra_rgb_encoder_helper_funcs);
3633b0e5855SThierry Reding 
3643b0e5855SThierry Reding 	drm_mode_connector_attach_encoder(&output->connector,
3653b0e5855SThierry Reding 					  &output->encoder);
3663b0e5855SThierry Reding 	drm_connector_register(&output->connector);
3673b0e5855SThierry Reding 
368ea130b24SThierry Reding 	err = tegra_output_init(drm, output);
369ea130b24SThierry Reding 	if (err < 0) {
370ea130b24SThierry Reding 		dev_err(output->dev, "failed to initialize output: %d\n", err);
371ea130b24SThierry Reding 		return err;
372ea130b24SThierry Reding 	}
373ea130b24SThierry Reding 
374dee8268fSThierry Reding 	/*
3753b0e5855SThierry Reding 	 * Other outputs can be attached to either display controller. The RGB
3763b0e5855SThierry Reding 	 * outputs are an exception and work only with their parent display
3773b0e5855SThierry Reding 	 * controller.
378dee8268fSThierry Reding 	 */
3793b0e5855SThierry Reding 	output->encoder.possible_crtcs = drm_crtc_mask(&dc->base);
380dee8268fSThierry Reding 
381dee8268fSThierry Reding 	return 0;
382dee8268fSThierry Reding }
383dee8268fSThierry Reding 
384dee8268fSThierry Reding int tegra_dc_rgb_exit(struct tegra_dc *dc)
385dee8268fSThierry Reding {
386328ec69eSThierry Reding 	if (dc->rgb)
387328ec69eSThierry Reding 		tegra_output_exit(dc->rgb);
3883b0e5855SThierry Reding 
389328ec69eSThierry Reding 	return 0;
390dee8268fSThierry Reding }
391