xref: /openbmc/linux/drivers/gpu/drm/tegra/rgb.c (revision 29efdc2902027e6cc19f665441a3de87a674282a)
1d2912cb1SThomas Gleixner // SPDX-License-Identifier: GPL-2.0-only
2dee8268fSThierry Reding /*
3dee8268fSThierry Reding  * Copyright (C) 2012 Avionic Design GmbH
4dee8268fSThierry Reding  * Copyright (C) 2012 NVIDIA CORPORATION.  All rights reserved.
5dee8268fSThierry Reding  */
6dee8268fSThierry Reding 
7dee8268fSThierry Reding #include <linux/clk.h>
8dee8268fSThierry Reding 
94aa3df71SThierry Reding #include <drm/drm_atomic_helper.h>
10*29efdc29SDmitry Osipenko #include <drm/drm_bridge_connector.h>
113b0e5855SThierry Reding #include <drm/drm_panel.h>
124d0e95e0SThomas Zimmermann #include <drm/drm_simple_kms_helper.h>
133b0e5855SThierry Reding 
14dee8268fSThierry Reding #include "drm.h"
15dee8268fSThierry Reding #include "dc.h"
16dee8268fSThierry Reding 
17dee8268fSThierry Reding struct tegra_rgb {
18dee8268fSThierry Reding 	struct tegra_output output;
197602fa1dSThierry Reding 	struct tegra_dc *dc;
207602fa1dSThierry Reding 
21dee8268fSThierry Reding 	struct clk *clk_parent;
22dee8268fSThierry Reding 	struct clk *clk;
23dee8268fSThierry Reding };
24dee8268fSThierry Reding 
25dee8268fSThierry Reding static inline struct tegra_rgb *to_rgb(struct tegra_output *output)
26dee8268fSThierry Reding {
27dee8268fSThierry Reding 	return container_of(output, struct tegra_rgb, output);
28dee8268fSThierry Reding }
29dee8268fSThierry Reding 
30dee8268fSThierry Reding struct reg_entry {
31dee8268fSThierry Reding 	unsigned long offset;
32dee8268fSThierry Reding 	unsigned long value;
33dee8268fSThierry Reding };
34dee8268fSThierry Reding 
35dee8268fSThierry Reding static const struct reg_entry rgb_enable[] = {
36dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_ENABLE(0),   0x00000000 },
37dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_ENABLE(1),   0x00000000 },
38dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_ENABLE(2),   0x00000000 },
39dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_ENABLE(3),   0x00000000 },
40dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_POLARITY(0), 0x00000000 },
41dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_POLARITY(1), 0x01000000 },
42dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_POLARITY(2), 0x00000000 },
43dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_POLARITY(3), 0x00000000 },
44dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_DATA(0),     0x00000000 },
45dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_DATA(1),     0x00000000 },
46dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_DATA(2),     0x00000000 },
47dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_DATA(3),     0x00000000 },
48dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(0),   0x00000000 },
49dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(1),   0x00000000 },
50dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(2),   0x00000000 },
51dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(3),   0x00000000 },
52dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(4),   0x00210222 },
53dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(5),   0x00002200 },
54dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(6),   0x00020000 },
55dee8268fSThierry Reding };
56dee8268fSThierry Reding 
57dee8268fSThierry Reding static const struct reg_entry rgb_disable[] = {
58dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(6),   0x00000000 },
59dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(5),   0x00000000 },
60dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(4),   0x00000000 },
61dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(3),   0x00000000 },
62dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(2),   0x00000000 },
63dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(1),   0x00000000 },
64dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_SELECT(0),   0x00000000 },
65dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_DATA(3),     0xaaaaaaaa },
66dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_DATA(2),     0xaaaaaaaa },
67dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_DATA(1),     0xaaaaaaaa },
68dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_DATA(0),     0xaaaaaaaa },
69dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_POLARITY(3), 0x00000000 },
70dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_POLARITY(2), 0x00000000 },
71dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_POLARITY(1), 0x00000000 },
72dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_POLARITY(0), 0x00000000 },
73dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_ENABLE(3),   0x55555555 },
74dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_ENABLE(2),   0x55555555 },
75dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_ENABLE(1),   0x55150005 },
76dee8268fSThierry Reding 	{ DC_COM_PIN_OUTPUT_ENABLE(0),   0x55555555 },
77dee8268fSThierry Reding };
78dee8268fSThierry Reding 
79dee8268fSThierry Reding static void tegra_dc_write_regs(struct tegra_dc *dc,
80dee8268fSThierry Reding 				const struct reg_entry *table,
81dee8268fSThierry Reding 				unsigned int num)
82dee8268fSThierry Reding {
83dee8268fSThierry Reding 	unsigned int i;
84dee8268fSThierry Reding 
85dee8268fSThierry Reding 	for (i = 0; i < num; i++)
86dee8268fSThierry Reding 		tegra_dc_writel(dc, table[i].value, table[i].offset);
87dee8268fSThierry Reding }
88dee8268fSThierry Reding 
893b0e5855SThierry Reding static const struct drm_connector_funcs tegra_rgb_connector_funcs = {
909d44189fSThierry Reding 	.reset = drm_atomic_helper_connector_reset,
913b0e5855SThierry Reding 	.detect = tegra_output_connector_detect,
923b0e5855SThierry Reding 	.fill_modes = drm_helper_probe_single_connector_modes,
933b0e5855SThierry Reding 	.destroy = tegra_output_connector_destroy,
949d44189fSThierry Reding 	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
954aa3df71SThierry Reding 	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
963b0e5855SThierry Reding };
973b0e5855SThierry Reding 
983b0e5855SThierry Reding static enum drm_mode_status
993b0e5855SThierry Reding tegra_rgb_connector_mode_valid(struct drm_connector *connector,
1003b0e5855SThierry Reding 			       struct drm_display_mode *mode)
1013b0e5855SThierry Reding {
1023b0e5855SThierry Reding 	/*
1033b0e5855SThierry Reding 	 * FIXME: For now, always assume that the mode is okay. There are
1043b0e5855SThierry Reding 	 * unresolved issues with clk_round_rate(), which doesn't always
1053b0e5855SThierry Reding 	 * reliably report whether a frequency can be set or not.
1063b0e5855SThierry Reding 	 */
1073b0e5855SThierry Reding 	return MODE_OK;
1083b0e5855SThierry Reding }
1093b0e5855SThierry Reding 
1103b0e5855SThierry Reding static const struct drm_connector_helper_funcs tegra_rgb_connector_helper_funcs = {
1113b0e5855SThierry Reding 	.get_modes = tegra_output_connector_get_modes,
1123b0e5855SThierry Reding 	.mode_valid = tegra_rgb_connector_mode_valid,
1133b0e5855SThierry Reding };
1143b0e5855SThierry Reding 
11532c3dee1SThierry Reding static void tegra_rgb_encoder_disable(struct drm_encoder *encoder)
1163b0e5855SThierry Reding {
11732c3dee1SThierry Reding 	struct tegra_output *output = encoder_to_output(encoder);
11832c3dee1SThierry Reding 	struct tegra_rgb *rgb = to_rgb(output);
11932c3dee1SThierry Reding 
12032c3dee1SThierry Reding 	if (output->panel)
12132c3dee1SThierry Reding 		drm_panel_disable(output->panel);
12232c3dee1SThierry Reding 
12332c3dee1SThierry Reding 	tegra_dc_write_regs(rgb->dc, rgb_disable, ARRAY_SIZE(rgb_disable));
12432c3dee1SThierry Reding 	tegra_dc_commit(rgb->dc);
12532c3dee1SThierry Reding 
12632c3dee1SThierry Reding 	if (output->panel)
12732c3dee1SThierry Reding 		drm_panel_unprepare(output->panel);
1283b0e5855SThierry Reding }
1293b0e5855SThierry Reding 
13032c3dee1SThierry Reding static void tegra_rgb_encoder_enable(struct drm_encoder *encoder)
1313b0e5855SThierry Reding {
1323b0e5855SThierry Reding 	struct tegra_output *output = encoder_to_output(encoder);
1333b0e5855SThierry Reding 	struct tegra_rgb *rgb = to_rgb(output);
1343b0e5855SThierry Reding 	u32 value;
1353b0e5855SThierry Reding 
1363b0e5855SThierry Reding 	if (output->panel)
1373b0e5855SThierry Reding 		drm_panel_prepare(output->panel);
138b1891537SDmitry Osipenko 
1397602fa1dSThierry Reding 	tegra_dc_write_regs(rgb->dc, rgb_enable, ARRAY_SIZE(rgb_enable));
140dee8268fSThierry Reding 
14172d30286SThierry Reding 	value = DE_SELECT_ACTIVE | DE_CONTROL_NORMAL;
14272d30286SThierry Reding 	tegra_dc_writel(rgb->dc, value, DC_DISP_DATA_ENABLE_OPTIONS);
14372d30286SThierry Reding 
14472d30286SThierry Reding 	/* XXX: parameterize? */
14572d30286SThierry Reding 	value = tegra_dc_readl(rgb->dc, DC_COM_PIN_OUTPUT_POLARITY(1));
14672d30286SThierry Reding 	value &= ~LVS_OUTPUT_POLARITY_LOW;
14772d30286SThierry Reding 	value &= ~LHS_OUTPUT_POLARITY_LOW;
14872d30286SThierry Reding 	tegra_dc_writel(rgb->dc, value, DC_COM_PIN_OUTPUT_POLARITY(1));
14972d30286SThierry Reding 
15072d30286SThierry Reding 	/* XXX: parameterize? */
15172d30286SThierry Reding 	value = DISP_DATA_FORMAT_DF1P1C | DISP_ALIGNMENT_MSB |
15272d30286SThierry Reding 		DISP_ORDER_RED_BLUE;
15372d30286SThierry Reding 	tegra_dc_writel(rgb->dc, value, DC_DISP_DISP_INTERFACE_CONTROL);
15472d30286SThierry Reding 
15572d30286SThierry Reding 	/* XXX: parameterize? */
15672d30286SThierry Reding 	value = SC0_H_QUALIFIER_NONE | SC1_H_QUALIFIER_NONE;
15772d30286SThierry Reding 	tegra_dc_writel(rgb->dc, value, DC_DISP_SHIFT_CLOCK_OPTIONS);
15872d30286SThierry Reding 
15962b9e063SThierry Reding 	tegra_dc_commit(rgb->dc);
16072d30286SThierry Reding 
1613b0e5855SThierry Reding 	if (output->panel)
1623b0e5855SThierry Reding 		drm_panel_enable(output->panel);
163dee8268fSThierry Reding }
164dee8268fSThierry Reding 
1653cebae67SThierry Reding static int
1663cebae67SThierry Reding tegra_rgb_encoder_atomic_check(struct drm_encoder *encoder,
1673cebae67SThierry Reding 			       struct drm_crtc_state *crtc_state,
1683cebae67SThierry Reding 			       struct drm_connector_state *conn_state)
1693cebae67SThierry Reding {
1703cebae67SThierry Reding 	struct tegra_output *output = encoder_to_output(encoder);
1713cebae67SThierry Reding 	struct tegra_dc *dc = to_tegra_dc(conn_state->crtc);
1723cebae67SThierry Reding 	unsigned long pclk = crtc_state->mode.clock * 1000;
1733cebae67SThierry Reding 	struct tegra_rgb *rgb = to_rgb(output);
1743cebae67SThierry Reding 	unsigned int div;
1753cebae67SThierry Reding 	int err;
1763cebae67SThierry Reding 
1773cebae67SThierry Reding 	/*
1783cebae67SThierry Reding 	 * We may not want to change the frequency of the parent clock, since
1793cebae67SThierry Reding 	 * it may be a parent for other peripherals. This is due to the fact
1803cebae67SThierry Reding 	 * that on Tegra20 there's only a single clock dedicated to display
1813cebae67SThierry Reding 	 * (pll_d_out0), whereas later generations have a second one that can
1823cebae67SThierry Reding 	 * be used to independently drive a second output (pll_d2_out0).
1833cebae67SThierry Reding 	 *
1843cebae67SThierry Reding 	 * As a way to support multiple outputs on Tegra20 as well, pll_p is
1853cebae67SThierry Reding 	 * typically used as the parent clock for the display controllers.
1863cebae67SThierry Reding 	 * But this comes at a cost: pll_p is the parent of several other
1873cebae67SThierry Reding 	 * peripherals, so its frequency shouldn't change out of the blue.
1883cebae67SThierry Reding 	 *
1893cebae67SThierry Reding 	 * The best we can do at this point is to use the shift clock divider
1903cebae67SThierry Reding 	 * and hope that the desired frequency can be matched (or at least
1913cebae67SThierry Reding 	 * matched sufficiently close that the panel will still work).
1923cebae67SThierry Reding 	 */
1933cebae67SThierry Reding 	div = ((clk_get_rate(rgb->clk) * 2) / pclk) - 2;
1943cebae67SThierry Reding 	pclk = 0;
1953cebae67SThierry Reding 
1963cebae67SThierry Reding 	err = tegra_dc_state_setup_clock(dc, crtc_state, rgb->clk_parent,
1973cebae67SThierry Reding 					 pclk, div);
1983cebae67SThierry Reding 	if (err < 0) {
1993cebae67SThierry Reding 		dev_err(output->dev, "failed to setup CRTC state: %d\n", err);
2003cebae67SThierry Reding 		return err;
2013cebae67SThierry Reding 	}
2023cebae67SThierry Reding 
2033cebae67SThierry Reding 	return err;
2043cebae67SThierry Reding }
2053cebae67SThierry Reding 
2063b0e5855SThierry Reding static const struct drm_encoder_helper_funcs tegra_rgb_encoder_helper_funcs = {
2073b0e5855SThierry Reding 	.disable = tegra_rgb_encoder_disable,
20832c3dee1SThierry Reding 	.enable = tegra_rgb_encoder_enable,
2093cebae67SThierry Reding 	.atomic_check = tegra_rgb_encoder_atomic_check,
210dee8268fSThierry Reding };
211dee8268fSThierry Reding 
212dee8268fSThierry Reding int tegra_dc_rgb_probe(struct tegra_dc *dc)
213dee8268fSThierry Reding {
214dee8268fSThierry Reding 	struct device_node *np;
215dee8268fSThierry Reding 	struct tegra_rgb *rgb;
216dee8268fSThierry Reding 	int err;
217dee8268fSThierry Reding 
218dee8268fSThierry Reding 	np = of_get_child_by_name(dc->dev->of_node, "rgb");
219dee8268fSThierry Reding 	if (!np || !of_device_is_available(np))
220dee8268fSThierry Reding 		return -ENODEV;
221dee8268fSThierry Reding 
222dee8268fSThierry Reding 	rgb = devm_kzalloc(dc->dev, sizeof(*rgb), GFP_KERNEL);
223dee8268fSThierry Reding 	if (!rgb)
224dee8268fSThierry Reding 		return -ENOMEM;
225dee8268fSThierry Reding 
226dee8268fSThierry Reding 	rgb->output.dev = dc->dev;
227dee8268fSThierry Reding 	rgb->output.of_node = np;
2287602fa1dSThierry Reding 	rgb->dc = dc;
229dee8268fSThierry Reding 
23059d29c0eSThierry Reding 	err = tegra_output_probe(&rgb->output);
231dee8268fSThierry Reding 	if (err < 0)
232dee8268fSThierry Reding 		return err;
233dee8268fSThierry Reding 
234dee8268fSThierry Reding 	rgb->clk = devm_clk_get(dc->dev, NULL);
235dee8268fSThierry Reding 	if (IS_ERR(rgb->clk)) {
236dee8268fSThierry Reding 		dev_err(dc->dev, "failed to get clock\n");
237dee8268fSThierry Reding 		return PTR_ERR(rgb->clk);
238dee8268fSThierry Reding 	}
239dee8268fSThierry Reding 
240dee8268fSThierry Reding 	rgb->clk_parent = devm_clk_get(dc->dev, "parent");
241dee8268fSThierry Reding 	if (IS_ERR(rgb->clk_parent)) {
242dee8268fSThierry Reding 		dev_err(dc->dev, "failed to get parent clock\n");
243dee8268fSThierry Reding 		return PTR_ERR(rgb->clk_parent);
244dee8268fSThierry Reding 	}
245dee8268fSThierry Reding 
246dee8268fSThierry Reding 	err = clk_set_parent(rgb->clk, rgb->clk_parent);
247dee8268fSThierry Reding 	if (err < 0) {
248dee8268fSThierry Reding 		dev_err(dc->dev, "failed to set parent clock: %d\n", err);
249dee8268fSThierry Reding 		return err;
250dee8268fSThierry Reding 	}
251dee8268fSThierry Reding 
252dee8268fSThierry Reding 	dc->rgb = &rgb->output;
253dee8268fSThierry Reding 
254dee8268fSThierry Reding 	return 0;
255dee8268fSThierry Reding }
256dee8268fSThierry Reding 
25759d29c0eSThierry Reding int tegra_dc_rgb_remove(struct tegra_dc *dc)
25859d29c0eSThierry Reding {
25959d29c0eSThierry Reding 	if (!dc->rgb)
26059d29c0eSThierry Reding 		return 0;
26159d29c0eSThierry Reding 
262328ec69eSThierry Reding 	tegra_output_remove(dc->rgb);
2633b0e5855SThierry Reding 	dc->rgb = NULL;
2643b0e5855SThierry Reding 
26559d29c0eSThierry Reding 	return 0;
26659d29c0eSThierry Reding }
26759d29c0eSThierry Reding 
268dee8268fSThierry Reding int tegra_dc_rgb_init(struct drm_device *drm, struct tegra_dc *dc)
269dee8268fSThierry Reding {
2703b0e5855SThierry Reding 	struct tegra_output *output = dc->rgb;
271*29efdc29SDmitry Osipenko 	struct drm_connector *connector;
272dee8268fSThierry Reding 	int err;
273dee8268fSThierry Reding 
274dee8268fSThierry Reding 	if (!dc->rgb)
275dee8268fSThierry Reding 		return -ENODEV;
276dee8268fSThierry Reding 
277*29efdc29SDmitry Osipenko 	drm_simple_encoder_init(drm, &output->encoder, DRM_MODE_ENCODER_LVDS);
278*29efdc29SDmitry Osipenko 	drm_encoder_helper_add(&output->encoder,
279*29efdc29SDmitry Osipenko 			       &tegra_rgb_encoder_helper_funcs);
280*29efdc29SDmitry Osipenko 
281*29efdc29SDmitry Osipenko 	/*
282*29efdc29SDmitry Osipenko 	 * Tegra devices that have LVDS panel utilize LVDS encoder bridge
283*29efdc29SDmitry Osipenko 	 * for converting up to 28 LCD LVTTL lanes into 5/4 LVDS lanes that
284*29efdc29SDmitry Osipenko 	 * go to display panel's receiver.
285*29efdc29SDmitry Osipenko 	 *
286*29efdc29SDmitry Osipenko 	 * Encoder usually have a power-down control which needs to be enabled
287*29efdc29SDmitry Osipenko 	 * in order to transmit data to the panel.  Historically devices that
288*29efdc29SDmitry Osipenko 	 * use an older device-tree version didn't model the bridge, assuming
289*29efdc29SDmitry Osipenko 	 * that encoder is turned ON by default, while today's DRM allows us
290*29efdc29SDmitry Osipenko 	 * to model LVDS encoder properly.
291*29efdc29SDmitry Osipenko 	 *
292*29efdc29SDmitry Osipenko 	 * Newer device-trees utilize LVDS encoder bridge, which provides
293*29efdc29SDmitry Osipenko 	 * us with a connector and handles the display panel.
294*29efdc29SDmitry Osipenko 	 *
295*29efdc29SDmitry Osipenko 	 * For older device-trees we fall back to our own connector and use
296*29efdc29SDmitry Osipenko 	 * nvidia,panel phandle.
297*29efdc29SDmitry Osipenko 	 */
298*29efdc29SDmitry Osipenko 	if (output->bridge) {
299*29efdc29SDmitry Osipenko 		err = drm_bridge_attach(&output->encoder, output->bridge,
300*29efdc29SDmitry Osipenko 					NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR);
301*29efdc29SDmitry Osipenko 		if (err) {
302*29efdc29SDmitry Osipenko 			dev_err(output->dev, "failed to attach bridge: %d\n",
303*29efdc29SDmitry Osipenko 				err);
304*29efdc29SDmitry Osipenko 			return err;
305*29efdc29SDmitry Osipenko 		}
306*29efdc29SDmitry Osipenko 
307*29efdc29SDmitry Osipenko 		connector = drm_bridge_connector_init(drm, &output->encoder);
308*29efdc29SDmitry Osipenko 		if (IS_ERR(connector)) {
309*29efdc29SDmitry Osipenko 			dev_err(output->dev,
310*29efdc29SDmitry Osipenko 				"failed to initialize bridge connector: %pe\n",
311*29efdc29SDmitry Osipenko 				connector);
312*29efdc29SDmitry Osipenko 			return PTR_ERR(connector);
313*29efdc29SDmitry Osipenko 		}
314*29efdc29SDmitry Osipenko 
315*29efdc29SDmitry Osipenko 		drm_connector_attach_encoder(connector, &output->encoder);
316*29efdc29SDmitry Osipenko 	} else {
317*29efdc29SDmitry Osipenko 		drm_connector_init(drm, &output->connector,
318*29efdc29SDmitry Osipenko 				   &tegra_rgb_connector_funcs,
3193b0e5855SThierry Reding 				   DRM_MODE_CONNECTOR_LVDS);
3203b0e5855SThierry Reding 		drm_connector_helper_add(&output->connector,
3213b0e5855SThierry Reding 					 &tegra_rgb_connector_helper_funcs);
3223b0e5855SThierry Reding 		output->connector.dpms = DRM_MODE_DPMS_OFF;
323dee8268fSThierry Reding 
324cde4c44dSDaniel Vetter 		drm_connector_attach_encoder(&output->connector,
3253b0e5855SThierry Reding 					     &output->encoder);
3263b0e5855SThierry Reding 		drm_connector_register(&output->connector);
327*29efdc29SDmitry Osipenko 	}
3283b0e5855SThierry Reding 
329ea130b24SThierry Reding 	err = tegra_output_init(drm, output);
330ea130b24SThierry Reding 	if (err < 0) {
331ea130b24SThierry Reding 		dev_err(output->dev, "failed to initialize output: %d\n", err);
332ea130b24SThierry Reding 		return err;
333ea130b24SThierry Reding 	}
334ea130b24SThierry Reding 
335dee8268fSThierry Reding 	/*
3363b0e5855SThierry Reding 	 * Other outputs can be attached to either display controller. The RGB
3373b0e5855SThierry Reding 	 * outputs are an exception and work only with their parent display
3383b0e5855SThierry Reding 	 * controller.
339dee8268fSThierry Reding 	 */
3403b0e5855SThierry Reding 	output->encoder.possible_crtcs = drm_crtc_mask(&dc->base);
341dee8268fSThierry Reding 
342dee8268fSThierry Reding 	return 0;
343dee8268fSThierry Reding }
344dee8268fSThierry Reding 
345dee8268fSThierry Reding int tegra_dc_rgb_exit(struct tegra_dc *dc)
346dee8268fSThierry Reding {
347328ec69eSThierry Reding 	if (dc->rgb)
348328ec69eSThierry Reding 		tegra_output_exit(dc->rgb);
3493b0e5855SThierry Reding 
350328ec69eSThierry Reding 	return 0;
351dee8268fSThierry Reding }
352