xref: /openbmc/linux/drivers/gpu/drm/qxl/qxl_display.c (revision 0edabdfe89581669609eaac5f6a8d0ae6fe95e7f)
1 /*
2  * Copyright 2013 Red Hat Inc.
3  *
4  * Permission is hereby granted, free of charge, to any person obtaining a
5  * copy of this software and associated documentation files (the "Software"),
6  * to deal in the Software without restriction, including without limitation
7  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
8  * and/or sell copies of the Software, and to permit persons to whom the
9  * Software is furnished to do so, subject to the following conditions:
10  *
11  * The above copyright notice and this permission notice shall be included in
12  * all copies or substantial portions of the Software.
13  *
14  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
15  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
16  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
17  * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
18  * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
19  * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
20  * OTHER DEALINGS IN THE SOFTWARE.
21  *
22  * Authors: Dave Airlie
23  *          Alon Levy
24  */
25 
26 #include <linux/crc32.h>
27 #include <linux/delay.h>
28 #include <linux/dma-buf-map.h>
29 
30 #include <drm/drm_drv.h>
31 #include <drm/drm_atomic.h>
32 #include <drm/drm_atomic_helper.h>
33 #include <drm/drm_gem_framebuffer_helper.h>
34 #include <drm/drm_plane_helper.h>
35 #include <drm/drm_probe_helper.h>
36 #include <drm/drm_simple_kms_helper.h>
37 
38 #include "qxl_drv.h"
39 #include "qxl_object.h"
40 
41 static bool qxl_head_enabled(struct qxl_head *head)
42 {
43 	return head->width && head->height;
44 }
45 
46 static int qxl_alloc_client_monitors_config(struct qxl_device *qdev,
47 		unsigned int count)
48 {
49 	if (qdev->client_monitors_config &&
50 	    count > qdev->client_monitors_config->count) {
51 		kfree(qdev->client_monitors_config);
52 		qdev->client_monitors_config = NULL;
53 	}
54 	if (!qdev->client_monitors_config) {
55 		qdev->client_monitors_config = kzalloc(
56 				struct_size(qdev->client_monitors_config,
57 				heads, count), GFP_KERNEL);
58 		if (!qdev->client_monitors_config)
59 			return -ENOMEM;
60 	}
61 	qdev->client_monitors_config->count = count;
62 	return 0;
63 }
64 
65 enum {
66 	MONITORS_CONFIG_MODIFIED,
67 	MONITORS_CONFIG_UNCHANGED,
68 	MONITORS_CONFIG_BAD_CRC,
69 	MONITORS_CONFIG_ERROR,
70 };
71 
72 static int qxl_display_copy_rom_client_monitors_config(struct qxl_device *qdev)
73 {
74 	int i;
75 	int num_monitors;
76 	uint32_t crc;
77 	int status = MONITORS_CONFIG_UNCHANGED;
78 
79 	num_monitors = qdev->rom->client_monitors_config.count;
80 	crc = crc32(0, (const uint8_t *)&qdev->rom->client_monitors_config,
81 		  sizeof(qdev->rom->client_monitors_config));
82 	if (crc != qdev->rom->client_monitors_config_crc)
83 		return MONITORS_CONFIG_BAD_CRC;
84 	if (!num_monitors) {
85 		DRM_DEBUG_KMS("no client monitors configured\n");
86 		return status;
87 	}
88 	if (num_monitors > qxl_num_crtc) {
89 		DRM_DEBUG_KMS("client monitors list will be truncated: %d < %d\n",
90 			      qxl_num_crtc, num_monitors);
91 		num_monitors = qxl_num_crtc;
92 	} else {
93 		num_monitors = qdev->rom->client_monitors_config.count;
94 	}
95 	if (qdev->client_monitors_config
96 	      && (num_monitors != qdev->client_monitors_config->count)) {
97 		status = MONITORS_CONFIG_MODIFIED;
98 	}
99 	if (qxl_alloc_client_monitors_config(qdev, num_monitors)) {
100 		status = MONITORS_CONFIG_ERROR;
101 		return status;
102 	}
103 	/* we copy max from the client but it isn't used */
104 	qdev->client_monitors_config->max_allowed = qxl_num_crtc;
105 	for (i = 0 ; i < qdev->client_monitors_config->count ; ++i) {
106 		struct qxl_urect *c_rect =
107 			&qdev->rom->client_monitors_config.heads[i];
108 		struct qxl_head *client_head =
109 			&qdev->client_monitors_config->heads[i];
110 		if (client_head->x != c_rect->left) {
111 			client_head->x = c_rect->left;
112 			status = MONITORS_CONFIG_MODIFIED;
113 		}
114 		if (client_head->y != c_rect->top) {
115 			client_head->y = c_rect->top;
116 			status = MONITORS_CONFIG_MODIFIED;
117 		}
118 		if (client_head->width != c_rect->right - c_rect->left) {
119 			client_head->width = c_rect->right - c_rect->left;
120 			status = MONITORS_CONFIG_MODIFIED;
121 		}
122 		if (client_head->height != c_rect->bottom - c_rect->top) {
123 			client_head->height = c_rect->bottom - c_rect->top;
124 			status = MONITORS_CONFIG_MODIFIED;
125 		}
126 		if (client_head->surface_id != 0) {
127 			client_head->surface_id = 0;
128 			status = MONITORS_CONFIG_MODIFIED;
129 		}
130 		if (client_head->id != i) {
131 			client_head->id = i;
132 			status = MONITORS_CONFIG_MODIFIED;
133 		}
134 		if (client_head->flags != 0) {
135 			client_head->flags = 0;
136 			status = MONITORS_CONFIG_MODIFIED;
137 		}
138 		DRM_DEBUG_KMS("read %dx%d+%d+%d\n", client_head->width, client_head->height,
139 			  client_head->x, client_head->y);
140 	}
141 
142 	return status;
143 }
144 
145 static void qxl_update_offset_props(struct qxl_device *qdev)
146 {
147 	struct drm_device *dev = &qdev->ddev;
148 	struct drm_connector *connector;
149 	struct qxl_output *output;
150 	struct qxl_head *head;
151 
152 	list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
153 		output = drm_connector_to_qxl_output(connector);
154 
155 		head = &qdev->client_monitors_config->heads[output->index];
156 
157 		drm_object_property_set_value(&connector->base,
158 			dev->mode_config.suggested_x_property, head->x);
159 		drm_object_property_set_value(&connector->base,
160 			dev->mode_config.suggested_y_property, head->y);
161 	}
162 }
163 
164 void qxl_display_read_client_monitors_config(struct qxl_device *qdev)
165 {
166 	struct drm_device *dev = &qdev->ddev;
167 	struct drm_modeset_acquire_ctx ctx;
168 	int status, retries, ret;
169 
170 	for (retries = 0; retries < 10; retries++) {
171 		status = qxl_display_copy_rom_client_monitors_config(qdev);
172 		if (status != MONITORS_CONFIG_BAD_CRC)
173 			break;
174 		udelay(5);
175 	}
176 	if (status == MONITORS_CONFIG_ERROR) {
177 		DRM_DEBUG_KMS("ignoring client monitors config: error");
178 		return;
179 	}
180 	if (status == MONITORS_CONFIG_BAD_CRC) {
181 		DRM_DEBUG_KMS("ignoring client monitors config: bad crc");
182 		return;
183 	}
184 	if (status == MONITORS_CONFIG_UNCHANGED) {
185 		DRM_DEBUG_KMS("ignoring client monitors config: unchanged");
186 		return;
187 	}
188 
189 	DRM_MODESET_LOCK_ALL_BEGIN(dev, ctx, DRM_MODESET_ACQUIRE_INTERRUPTIBLE, ret);
190 	qxl_update_offset_props(qdev);
191 	DRM_MODESET_LOCK_ALL_END(dev, ctx, ret);
192 	if (!drm_helper_hpd_irq_event(dev)) {
193 		/* notify that the monitor configuration changed, to
194 		   adjust at the arbitrary resolution */
195 		drm_kms_helper_hotplug_event(dev);
196 	}
197 }
198 
199 static int qxl_check_mode(struct qxl_device *qdev,
200 			  unsigned int width,
201 			  unsigned int height)
202 {
203 	unsigned int stride;
204 	unsigned int size;
205 
206 	if (check_mul_overflow(width, 4u, &stride))
207 		return -EINVAL;
208 	if (check_mul_overflow(stride, height, &size))
209 		return -EINVAL;
210 	if (size > qdev->vram_size)
211 		return -ENOMEM;
212 	return 0;
213 }
214 
215 static int qxl_check_framebuffer(struct qxl_device *qdev,
216 				 struct qxl_bo *bo)
217 {
218 	return qxl_check_mode(qdev, bo->surf.width, bo->surf.height);
219 }
220 
221 static int qxl_add_mode(struct drm_connector *connector,
222 			unsigned int width,
223 			unsigned int height,
224 			bool preferred)
225 {
226 	struct drm_device *dev = connector->dev;
227 	struct qxl_device *qdev = to_qxl(dev);
228 	struct drm_display_mode *mode = NULL;
229 	int rc;
230 
231 	rc = qxl_check_mode(qdev, width, height);
232 	if (rc != 0)
233 		return 0;
234 
235 	mode = drm_cvt_mode(dev, width, height, 60, false, false, false);
236 	if (preferred)
237 		mode->type |= DRM_MODE_TYPE_PREFERRED;
238 	mode->hdisplay = width;
239 	mode->vdisplay = height;
240 	drm_mode_set_name(mode);
241 	drm_mode_probed_add(connector, mode);
242 	return 1;
243 }
244 
245 static int qxl_add_monitors_config_modes(struct drm_connector *connector)
246 {
247 	struct drm_device *dev = connector->dev;
248 	struct qxl_device *qdev = to_qxl(dev);
249 	struct qxl_output *output = drm_connector_to_qxl_output(connector);
250 	int h = output->index;
251 	struct qxl_head *head;
252 
253 	if (!qdev->monitors_config)
254 		return 0;
255 	if (h >= qxl_num_crtc)
256 		return 0;
257 	if (!qdev->client_monitors_config)
258 		return 0;
259 	if (h >= qdev->client_monitors_config->count)
260 		return 0;
261 
262 	head = &qdev->client_monitors_config->heads[h];
263 	DRM_DEBUG_KMS("head %d is %dx%d\n", h, head->width, head->height);
264 
265 	return qxl_add_mode(connector, head->width, head->height, true);
266 }
267 
268 static struct mode_size {
269 	int w;
270 	int h;
271 } extra_modes[] = {
272 	{ 720,  480},
273 	{1152,  768},
274 	{1280,  854},
275 };
276 
277 static int qxl_add_extra_modes(struct drm_connector *connector)
278 {
279 	int i, ret = 0;
280 
281 	for (i = 0; i < ARRAY_SIZE(extra_modes); i++)
282 		ret += qxl_add_mode(connector,
283 				    extra_modes[i].w,
284 				    extra_modes[i].h,
285 				    false);
286 	return ret;
287 }
288 
289 static void qxl_send_monitors_config(struct qxl_device *qdev)
290 {
291 	int i;
292 
293 	BUG_ON(!qdev->ram_header->monitors_config);
294 
295 	if (qdev->monitors_config->count == 0)
296 		return;
297 
298 	for (i = 0 ; i < qdev->monitors_config->count ; ++i) {
299 		struct qxl_head *head = &qdev->monitors_config->heads[i];
300 
301 		if (head->y > 8192 || head->x > 8192 ||
302 		    head->width > 8192 || head->height > 8192) {
303 			DRM_ERROR("head %d wrong: %dx%d+%d+%d\n",
304 				  i, head->width, head->height,
305 				  head->x, head->y);
306 			return;
307 		}
308 	}
309 	qxl_io_monitors_config(qdev);
310 }
311 
312 static void qxl_crtc_update_monitors_config(struct drm_crtc *crtc,
313 					    const char *reason)
314 {
315 	struct drm_device *dev = crtc->dev;
316 	struct qxl_device *qdev = to_qxl(dev);
317 	struct qxl_crtc *qcrtc = to_qxl_crtc(crtc);
318 	struct qxl_head head;
319 	int oldcount, i = qcrtc->index;
320 
321 	if (!qdev->primary_bo) {
322 		DRM_DEBUG_KMS("no primary surface, skip (%s)\n", reason);
323 		return;
324 	}
325 
326 	if (!qdev->monitors_config || qxl_num_crtc <= i)
327 		return;
328 
329 	head.id = i;
330 	head.flags = 0;
331 	head.surface_id = 0;
332 	oldcount = qdev->monitors_config->count;
333 	if (crtc->state->active) {
334 		struct drm_display_mode *mode = &crtc->mode;
335 
336 		head.width = mode->hdisplay;
337 		head.height = mode->vdisplay;
338 		head.x = crtc->x;
339 		head.y = crtc->y;
340 		if (qdev->monitors_config->count < i + 1)
341 			qdev->monitors_config->count = i + 1;
342 		if (qdev->primary_bo == qdev->dumb_shadow_bo)
343 			head.x += qdev->dumb_heads[i].x;
344 	} else if (i > 0) {
345 		head.width = 0;
346 		head.height = 0;
347 		head.x = 0;
348 		head.y = 0;
349 		if (qdev->monitors_config->count == i + 1)
350 			qdev->monitors_config->count = i;
351 	} else {
352 		DRM_DEBUG_KMS("inactive head 0, skip (%s)\n", reason);
353 		return;
354 	}
355 
356 	if (head.width  == qdev->monitors_config->heads[i].width  &&
357 	    head.height == qdev->monitors_config->heads[i].height &&
358 	    head.x      == qdev->monitors_config->heads[i].x      &&
359 	    head.y      == qdev->monitors_config->heads[i].y      &&
360 	    oldcount    == qdev->monitors_config->count)
361 		return;
362 
363 	DRM_DEBUG_KMS("head %d, %dx%d, at +%d+%d, %s (%s)\n",
364 		      i, head.width, head.height, head.x, head.y,
365 		      crtc->state->active ? "on" : "off", reason);
366 	if (oldcount != qdev->monitors_config->count)
367 		DRM_DEBUG_KMS("active heads %d -> %d (%d total)\n",
368 			      oldcount, qdev->monitors_config->count,
369 			      qxl_num_crtc);
370 
371 	qdev->monitors_config->heads[i] = head;
372 	qdev->monitors_config->max_allowed = qxl_num_crtc;
373 	qxl_send_monitors_config(qdev);
374 }
375 
376 static void qxl_crtc_atomic_flush(struct drm_crtc *crtc,
377 				  struct drm_atomic_state *state)
378 {
379 	qxl_crtc_update_monitors_config(crtc, "flush");
380 }
381 
382 static void qxl_crtc_destroy(struct drm_crtc *crtc)
383 {
384 	struct qxl_crtc *qxl_crtc = to_qxl_crtc(crtc);
385 
386 	qxl_bo_unref(&qxl_crtc->cursor_bo);
387 	drm_crtc_cleanup(crtc);
388 	kfree(qxl_crtc);
389 }
390 
391 static const struct drm_crtc_funcs qxl_crtc_funcs = {
392 	.set_config = drm_atomic_helper_set_config,
393 	.destroy = qxl_crtc_destroy,
394 	.page_flip = drm_atomic_helper_page_flip,
395 	.reset = drm_atomic_helper_crtc_reset,
396 	.atomic_duplicate_state = drm_atomic_helper_crtc_duplicate_state,
397 	.atomic_destroy_state = drm_atomic_helper_crtc_destroy_state,
398 };
399 
400 static int qxl_framebuffer_surface_dirty(struct drm_framebuffer *fb,
401 					 struct drm_file *file_priv,
402 					 unsigned int flags, unsigned int color,
403 					 struct drm_clip_rect *clips,
404 					 unsigned int num_clips)
405 {
406 	/* TODO: vmwgfx where this was cribbed from had locking. Why? */
407 	struct qxl_device *qdev = to_qxl(fb->dev);
408 	struct drm_clip_rect norect;
409 	struct qxl_bo *qobj;
410 	struct drm_modeset_acquire_ctx ctx;
411 	bool is_primary;
412 	int inc = 1, ret;
413 
414 	DRM_MODESET_LOCK_ALL_BEGIN(fb->dev, ctx, DRM_MODESET_ACQUIRE_INTERRUPTIBLE, ret);
415 
416 	qobj = gem_to_qxl_bo(fb->obj[0]);
417 	/* if we aren't primary surface ignore this */
418 	is_primary = qobj->shadow ? qobj->shadow->is_primary : qobj->is_primary;
419 	if (!is_primary)
420 		goto out_lock_end;
421 
422 	if (!num_clips) {
423 		num_clips = 1;
424 		clips = &norect;
425 		norect.x1 = norect.y1 = 0;
426 		norect.x2 = fb->width;
427 		norect.y2 = fb->height;
428 	} else if (flags & DRM_MODE_FB_DIRTY_ANNOTATE_COPY) {
429 		num_clips /= 2;
430 		inc = 2; /* skip source rects */
431 	}
432 
433 	qxl_draw_dirty_fb(qdev, fb, qobj, flags, color,
434 			  clips, num_clips, inc, 0);
435 
436 out_lock_end:
437 	DRM_MODESET_LOCK_ALL_END(fb->dev, ctx, ret);
438 
439 	return 0;
440 }
441 
442 static const struct drm_framebuffer_funcs qxl_fb_funcs = {
443 	.destroy = drm_gem_fb_destroy,
444 	.dirty = qxl_framebuffer_surface_dirty,
445 	.create_handle = drm_gem_fb_create_handle,
446 };
447 
448 static void qxl_crtc_atomic_enable(struct drm_crtc *crtc,
449 				   struct drm_atomic_state *state)
450 {
451 	qxl_crtc_update_monitors_config(crtc, "enable");
452 }
453 
454 static void qxl_crtc_atomic_disable(struct drm_crtc *crtc,
455 				    struct drm_atomic_state *state)
456 {
457 	qxl_crtc_update_monitors_config(crtc, "disable");
458 }
459 
460 static const struct drm_crtc_helper_funcs qxl_crtc_helper_funcs = {
461 	.atomic_flush = qxl_crtc_atomic_flush,
462 	.atomic_enable = qxl_crtc_atomic_enable,
463 	.atomic_disable = qxl_crtc_atomic_disable,
464 };
465 
466 static int qxl_primary_atomic_check(struct drm_plane *plane,
467 				    struct drm_plane_state *state)
468 {
469 	struct qxl_device *qdev = to_qxl(plane->dev);
470 	struct qxl_bo *bo;
471 
472 	if (!state->crtc || !state->fb)
473 		return 0;
474 
475 	bo = gem_to_qxl_bo(state->fb->obj[0]);
476 
477 	return qxl_check_framebuffer(qdev, bo);
478 }
479 
480 static int qxl_primary_apply_cursor(struct drm_plane *plane)
481 {
482 	struct drm_device *dev = plane->dev;
483 	struct qxl_device *qdev = to_qxl(dev);
484 	struct drm_framebuffer *fb = plane->state->fb;
485 	struct qxl_crtc *qcrtc = to_qxl_crtc(plane->state->crtc);
486 	struct qxl_cursor_cmd *cmd;
487 	struct qxl_release *release;
488 	int ret = 0;
489 
490 	if (!qcrtc->cursor_bo)
491 		return 0;
492 
493 	ret = qxl_alloc_release_reserved(qdev, sizeof(*cmd),
494 					 QXL_RELEASE_CURSOR_CMD,
495 					 &release, NULL);
496 	if (ret)
497 		return ret;
498 
499 	ret = qxl_release_list_add(release, qcrtc->cursor_bo);
500 	if (ret)
501 		goto out_free_release;
502 
503 	ret = qxl_release_reserve_list(release, false);
504 	if (ret)
505 		goto out_free_release;
506 
507 	cmd = (struct qxl_cursor_cmd *)qxl_release_map(qdev, release);
508 	cmd->type = QXL_CURSOR_SET;
509 	cmd->u.set.position.x = plane->state->crtc_x + fb->hot_x;
510 	cmd->u.set.position.y = plane->state->crtc_y + fb->hot_y;
511 
512 	cmd->u.set.shape = qxl_bo_physical_address(qdev, qcrtc->cursor_bo, 0);
513 
514 	cmd->u.set.visible = 1;
515 	qxl_release_unmap(qdev, release, &cmd->release_info);
516 
517 	qxl_release_fence_buffer_objects(release);
518 	qxl_push_cursor_ring_release(qdev, release, QXL_CMD_CURSOR, false);
519 
520 	return ret;
521 
522 out_free_release:
523 	qxl_release_free(qdev, release);
524 	return ret;
525 }
526 
527 static void qxl_primary_atomic_update(struct drm_plane *plane,
528 				      struct drm_plane_state *old_state)
529 {
530 	struct qxl_device *qdev = to_qxl(plane->dev);
531 	struct qxl_bo *bo = gem_to_qxl_bo(plane->state->fb->obj[0]);
532 	struct qxl_bo *primary;
533 	struct drm_clip_rect norect = {
534 	    .x1 = 0,
535 	    .y1 = 0,
536 	    .x2 = plane->state->fb->width,
537 	    .y2 = plane->state->fb->height
538 	};
539 	uint32_t dumb_shadow_offset = 0;
540 
541 	primary = bo->shadow ? bo->shadow : bo;
542 
543 	if (!primary->is_primary) {
544 		if (qdev->primary_bo)
545 			qxl_io_destroy_primary(qdev);
546 		qxl_io_create_primary(qdev, primary);
547 		qxl_primary_apply_cursor(plane);
548 	}
549 
550 	if (bo->is_dumb)
551 		dumb_shadow_offset =
552 			qdev->dumb_heads[plane->state->crtc->index].x;
553 
554 	qxl_draw_dirty_fb(qdev, plane->state->fb, bo, 0, 0, &norect, 1, 1,
555 			  dumb_shadow_offset);
556 }
557 
558 static void qxl_primary_atomic_disable(struct drm_plane *plane,
559 				       struct drm_plane_state *old_state)
560 {
561 	struct qxl_device *qdev = to_qxl(plane->dev);
562 
563 	if (old_state->fb) {
564 		struct qxl_bo *bo = gem_to_qxl_bo(old_state->fb->obj[0]);
565 
566 		if (bo->is_primary) {
567 			qxl_io_destroy_primary(qdev);
568 			bo->is_primary = false;
569 		}
570 	}
571 }
572 
573 static void qxl_cursor_atomic_update(struct drm_plane *plane,
574 				     struct drm_plane_state *old_state)
575 {
576 	struct drm_device *dev = plane->dev;
577 	struct qxl_device *qdev = to_qxl(dev);
578 	struct drm_framebuffer *fb = plane->state->fb;
579 	struct qxl_crtc *qcrtc = to_qxl_crtc(plane->state->crtc);
580 	struct qxl_release *release;
581 	struct qxl_cursor_cmd *cmd;
582 	struct qxl_cursor *cursor;
583 	struct drm_gem_object *obj;
584 	struct qxl_bo *cursor_bo = NULL, *user_bo = NULL, *old_cursor_bo = NULL;
585 	int ret;
586 	struct dma_buf_map user_map;
587 	struct dma_buf_map cursor_map;
588 	void *user_ptr;
589 	int size = 64*64*4;
590 
591 	ret = qxl_alloc_release_reserved(qdev, sizeof(*cmd),
592 					 QXL_RELEASE_CURSOR_CMD,
593 					 &release, NULL);
594 	if (ret)
595 		return;
596 
597 	if (fb != old_state->fb) {
598 		obj = fb->obj[0];
599 		user_bo = gem_to_qxl_bo(obj);
600 
601 		/* pinning is done in the prepare/cleanup framevbuffer */
602 		ret = qxl_bo_kmap(user_bo, &user_map);
603 		if (ret)
604 			goto out_free_release;
605 		user_ptr = user_map.vaddr; /* TODO: Use mapping abstraction properly */
606 
607 		ret = qxl_alloc_bo_reserved(qdev, release,
608 					    sizeof(struct qxl_cursor) + size,
609 					    &cursor_bo);
610 		if (ret)
611 			goto out_kunmap;
612 
613 		ret = qxl_bo_pin(cursor_bo);
614 		if (ret)
615 			goto out_free_bo;
616 
617 		ret = qxl_release_reserve_list(release, true);
618 		if (ret)
619 			goto out_unpin;
620 
621 		ret = qxl_bo_kmap(cursor_bo, &cursor_map);
622 		if (ret)
623 			goto out_backoff;
624 		if (cursor_map.is_iomem) /* TODO: Use mapping abstraction properly */
625 			cursor = (struct qxl_cursor __force *)cursor_map.vaddr_iomem;
626 		else
627 			cursor = (struct qxl_cursor *)cursor_map.vaddr;
628 
629 		cursor->header.unique = 0;
630 		cursor->header.type = SPICE_CURSOR_TYPE_ALPHA;
631 		cursor->header.width = 64;
632 		cursor->header.height = 64;
633 		cursor->header.hot_spot_x = fb->hot_x;
634 		cursor->header.hot_spot_y = fb->hot_y;
635 		cursor->data_size = size;
636 		cursor->chunk.next_chunk = 0;
637 		cursor->chunk.prev_chunk = 0;
638 		cursor->chunk.data_size = size;
639 		memcpy(cursor->chunk.data, user_ptr, size);
640 		qxl_bo_kunmap(cursor_bo);
641 		qxl_bo_kunmap(user_bo);
642 
643 		cmd = (struct qxl_cursor_cmd *) qxl_release_map(qdev, release);
644 		cmd->u.set.visible = 1;
645 		cmd->u.set.shape = qxl_bo_physical_address(qdev,
646 							   cursor_bo, 0);
647 		cmd->type = QXL_CURSOR_SET;
648 
649 		old_cursor_bo = qcrtc->cursor_bo;
650 		qcrtc->cursor_bo = cursor_bo;
651 		cursor_bo = NULL;
652 	} else {
653 
654 		ret = qxl_release_reserve_list(release, true);
655 		if (ret)
656 			goto out_free_release;
657 
658 		cmd = (struct qxl_cursor_cmd *) qxl_release_map(qdev, release);
659 		cmd->type = QXL_CURSOR_MOVE;
660 	}
661 
662 	cmd->u.position.x = plane->state->crtc_x + fb->hot_x;
663 	cmd->u.position.y = plane->state->crtc_y + fb->hot_y;
664 
665 	qxl_release_unmap(qdev, release, &cmd->release_info);
666 	qxl_release_fence_buffer_objects(release);
667 	qxl_push_cursor_ring_release(qdev, release, QXL_CMD_CURSOR, false);
668 
669 	if (old_cursor_bo != NULL)
670 		qxl_bo_unpin(old_cursor_bo);
671 	qxl_bo_unref(&old_cursor_bo);
672 	qxl_bo_unref(&cursor_bo);
673 
674 	return;
675 
676 out_backoff:
677 	qxl_release_backoff_reserve_list(release);
678 out_unpin:
679 	qxl_bo_unpin(cursor_bo);
680 out_free_bo:
681 	qxl_bo_unref(&cursor_bo);
682 out_kunmap:
683 	qxl_bo_kunmap(user_bo);
684 out_free_release:
685 	qxl_release_free(qdev, release);
686 	return;
687 
688 }
689 
690 static void qxl_cursor_atomic_disable(struct drm_plane *plane,
691 				      struct drm_plane_state *old_state)
692 {
693 	struct qxl_device *qdev = to_qxl(plane->dev);
694 	struct qxl_release *release;
695 	struct qxl_cursor_cmd *cmd;
696 	int ret;
697 
698 	ret = qxl_alloc_release_reserved(qdev, sizeof(*cmd),
699 					 QXL_RELEASE_CURSOR_CMD,
700 					 &release, NULL);
701 	if (ret)
702 		return;
703 
704 	ret = qxl_release_reserve_list(release, true);
705 	if (ret) {
706 		qxl_release_free(qdev, release);
707 		return;
708 	}
709 
710 	cmd = (struct qxl_cursor_cmd *)qxl_release_map(qdev, release);
711 	cmd->type = QXL_CURSOR_HIDE;
712 	qxl_release_unmap(qdev, release, &cmd->release_info);
713 
714 	qxl_release_fence_buffer_objects(release);
715 	qxl_push_cursor_ring_release(qdev, release, QXL_CMD_CURSOR, false);
716 }
717 
718 static void qxl_update_dumb_head(struct qxl_device *qdev,
719 				 int index, struct qxl_bo *bo)
720 {
721 	uint32_t width, height;
722 
723 	if (index >= qdev->monitors_config->max_allowed)
724 		return;
725 
726 	if (bo && bo->is_dumb) {
727 		width = bo->surf.width;
728 		height = bo->surf.height;
729 	} else {
730 		width = 0;
731 		height = 0;
732 	}
733 
734 	if (qdev->dumb_heads[index].width == width &&
735 	    qdev->dumb_heads[index].height == height)
736 		return;
737 
738 	DRM_DEBUG("#%d: %dx%d -> %dx%d\n", index,
739 		  qdev->dumb_heads[index].width,
740 		  qdev->dumb_heads[index].height,
741 		  width, height);
742 	qdev->dumb_heads[index].width = width;
743 	qdev->dumb_heads[index].height = height;
744 }
745 
746 static void qxl_calc_dumb_shadow(struct qxl_device *qdev,
747 				 struct qxl_surface *surf)
748 {
749 	struct qxl_head *head;
750 	int i;
751 
752 	memset(surf, 0, sizeof(*surf));
753 	for (i = 0; i < qdev->monitors_config->max_allowed; i++) {
754 		head = qdev->dumb_heads + i;
755 		head->x = surf->width;
756 		surf->width += head->width;
757 		if (surf->height < head->height)
758 			surf->height = head->height;
759 	}
760 	if (surf->width < 64)
761 		surf->width = 64;
762 	if (surf->height < 64)
763 		surf->height = 64;
764 	surf->format = SPICE_SURFACE_FMT_32_xRGB;
765 	surf->stride = surf->width * 4;
766 
767 	if (!qdev->dumb_shadow_bo ||
768 	    qdev->dumb_shadow_bo->surf.width != surf->width ||
769 	    qdev->dumb_shadow_bo->surf.height != surf->height)
770 		DRM_DEBUG("%dx%d\n", surf->width, surf->height);
771 }
772 
773 static int qxl_plane_prepare_fb(struct drm_plane *plane,
774 				struct drm_plane_state *new_state)
775 {
776 	struct qxl_device *qdev = to_qxl(plane->dev);
777 	struct drm_gem_object *obj;
778 	struct qxl_bo *user_bo;
779 	struct qxl_surface surf;
780 
781 	if (!new_state->fb)
782 		return 0;
783 
784 	obj = new_state->fb->obj[0];
785 	user_bo = gem_to_qxl_bo(obj);
786 
787 	if (plane->type == DRM_PLANE_TYPE_PRIMARY &&
788 	    user_bo->is_dumb) {
789 		qxl_update_dumb_head(qdev, new_state->crtc->index,
790 				     user_bo);
791 		qxl_calc_dumb_shadow(qdev, &surf);
792 		if (!qdev->dumb_shadow_bo ||
793 		    qdev->dumb_shadow_bo->surf.width  != surf.width ||
794 		    qdev->dumb_shadow_bo->surf.height != surf.height) {
795 			if (qdev->dumb_shadow_bo) {
796 				drm_gem_object_put
797 					(&qdev->dumb_shadow_bo->tbo.base);
798 				qdev->dumb_shadow_bo = NULL;
799 			}
800 			qxl_bo_create(qdev, surf.height * surf.stride,
801 				      true, true, QXL_GEM_DOMAIN_SURFACE, &surf,
802 				      &qdev->dumb_shadow_bo);
803 		}
804 		if (user_bo->shadow != qdev->dumb_shadow_bo) {
805 			if (user_bo->shadow) {
806 				drm_gem_object_put
807 					(&user_bo->shadow->tbo.base);
808 				user_bo->shadow = NULL;
809 			}
810 			drm_gem_object_get(&qdev->dumb_shadow_bo->tbo.base);
811 			user_bo->shadow = qdev->dumb_shadow_bo;
812 		}
813 	}
814 
815 	return qxl_bo_pin(user_bo);
816 }
817 
818 static void qxl_plane_cleanup_fb(struct drm_plane *plane,
819 				 struct drm_plane_state *old_state)
820 {
821 	struct drm_gem_object *obj;
822 	struct qxl_bo *user_bo;
823 
824 	if (!old_state->fb) {
825 		/*
826 		 * we never executed prepare_fb, so there's nothing to
827 		 * unpin.
828 		 */
829 		return;
830 	}
831 
832 	obj = old_state->fb->obj[0];
833 	user_bo = gem_to_qxl_bo(obj);
834 	qxl_bo_unpin(user_bo);
835 
836 	if (old_state->fb != plane->state->fb && user_bo->shadow) {
837 		drm_gem_object_put(&user_bo->shadow->tbo.base);
838 		user_bo->shadow = NULL;
839 	}
840 }
841 
842 static const uint32_t qxl_cursor_plane_formats[] = {
843 	DRM_FORMAT_ARGB8888,
844 };
845 
846 static const struct drm_plane_helper_funcs qxl_cursor_helper_funcs = {
847 	.atomic_update = qxl_cursor_atomic_update,
848 	.atomic_disable = qxl_cursor_atomic_disable,
849 	.prepare_fb = qxl_plane_prepare_fb,
850 	.cleanup_fb = qxl_plane_cleanup_fb,
851 };
852 
853 static const struct drm_plane_funcs qxl_cursor_plane_funcs = {
854 	.update_plane	= drm_atomic_helper_update_plane,
855 	.disable_plane	= drm_atomic_helper_disable_plane,
856 	.destroy	= drm_primary_helper_destroy,
857 	.reset		= drm_atomic_helper_plane_reset,
858 	.atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state,
859 	.atomic_destroy_state = drm_atomic_helper_plane_destroy_state,
860 };
861 
862 static const uint32_t qxl_primary_plane_formats[] = {
863 	DRM_FORMAT_XRGB8888,
864 	DRM_FORMAT_ARGB8888,
865 };
866 
867 static const struct drm_plane_helper_funcs primary_helper_funcs = {
868 	.atomic_check = qxl_primary_atomic_check,
869 	.atomic_update = qxl_primary_atomic_update,
870 	.atomic_disable = qxl_primary_atomic_disable,
871 	.prepare_fb = qxl_plane_prepare_fb,
872 	.cleanup_fb = qxl_plane_cleanup_fb,
873 };
874 
875 static const struct drm_plane_funcs qxl_primary_plane_funcs = {
876 	.update_plane	= drm_atomic_helper_update_plane,
877 	.disable_plane	= drm_atomic_helper_disable_plane,
878 	.destroy	= drm_primary_helper_destroy,
879 	.reset		= drm_atomic_helper_plane_reset,
880 	.atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state,
881 	.atomic_destroy_state = drm_atomic_helper_plane_destroy_state,
882 };
883 
884 static struct drm_plane *qxl_create_plane(struct qxl_device *qdev,
885 					  unsigned int possible_crtcs,
886 					  enum drm_plane_type type)
887 {
888 	const struct drm_plane_helper_funcs *helper_funcs = NULL;
889 	struct drm_plane *plane;
890 	const struct drm_plane_funcs *funcs;
891 	const uint32_t *formats;
892 	int num_formats;
893 	int err;
894 
895 	if (type == DRM_PLANE_TYPE_PRIMARY) {
896 		funcs = &qxl_primary_plane_funcs;
897 		formats = qxl_primary_plane_formats;
898 		num_formats = ARRAY_SIZE(qxl_primary_plane_formats);
899 		helper_funcs = &primary_helper_funcs;
900 	} else if (type == DRM_PLANE_TYPE_CURSOR) {
901 		funcs = &qxl_cursor_plane_funcs;
902 		formats = qxl_cursor_plane_formats;
903 		helper_funcs = &qxl_cursor_helper_funcs;
904 		num_formats = ARRAY_SIZE(qxl_cursor_plane_formats);
905 	} else {
906 		return ERR_PTR(-EINVAL);
907 	}
908 
909 	plane = kzalloc(sizeof(*plane), GFP_KERNEL);
910 	if (!plane)
911 		return ERR_PTR(-ENOMEM);
912 
913 	err = drm_universal_plane_init(&qdev->ddev, plane, possible_crtcs,
914 				       funcs, formats, num_formats,
915 				       NULL, type, NULL);
916 	if (err)
917 		goto free_plane;
918 
919 	drm_plane_helper_add(plane, helper_funcs);
920 
921 	return plane;
922 
923 free_plane:
924 	kfree(plane);
925 	return ERR_PTR(-EINVAL);
926 }
927 
928 static int qdev_crtc_init(struct drm_device *dev, int crtc_id)
929 {
930 	struct qxl_crtc *qxl_crtc;
931 	struct drm_plane *primary, *cursor;
932 	struct qxl_device *qdev = to_qxl(dev);
933 	int r;
934 
935 	qxl_crtc = kzalloc(sizeof(struct qxl_crtc), GFP_KERNEL);
936 	if (!qxl_crtc)
937 		return -ENOMEM;
938 
939 	primary = qxl_create_plane(qdev, 1 << crtc_id, DRM_PLANE_TYPE_PRIMARY);
940 	if (IS_ERR(primary)) {
941 		r = -ENOMEM;
942 		goto free_mem;
943 	}
944 
945 	cursor = qxl_create_plane(qdev, 1 << crtc_id, DRM_PLANE_TYPE_CURSOR);
946 	if (IS_ERR(cursor)) {
947 		r = -ENOMEM;
948 		goto clean_primary;
949 	}
950 
951 	r = drm_crtc_init_with_planes(dev, &qxl_crtc->base, primary, cursor,
952 				      &qxl_crtc_funcs, NULL);
953 	if (r)
954 		goto clean_cursor;
955 
956 	qxl_crtc->index = crtc_id;
957 	drm_crtc_helper_add(&qxl_crtc->base, &qxl_crtc_helper_funcs);
958 	return 0;
959 
960 clean_cursor:
961 	drm_plane_cleanup(cursor);
962 	kfree(cursor);
963 clean_primary:
964 	drm_plane_cleanup(primary);
965 	kfree(primary);
966 free_mem:
967 	kfree(qxl_crtc);
968 	return r;
969 }
970 
971 static int qxl_conn_get_modes(struct drm_connector *connector)
972 {
973 	struct drm_device *dev = connector->dev;
974 	struct qxl_device *qdev = to_qxl(dev);
975 	struct qxl_output *output = drm_connector_to_qxl_output(connector);
976 	unsigned int pwidth = 1024;
977 	unsigned int pheight = 768;
978 	int ret = 0;
979 
980 	if (qdev->client_monitors_config) {
981 		struct qxl_head *head;
982 		head = &qdev->client_monitors_config->heads[output->index];
983 		if (head->width)
984 			pwidth = head->width;
985 		if (head->height)
986 			pheight = head->height;
987 	}
988 
989 	ret += drm_add_modes_noedid(connector, 8192, 8192);
990 	ret += qxl_add_extra_modes(connector);
991 	ret += qxl_add_monitors_config_modes(connector);
992 	drm_set_preferred_mode(connector, pwidth, pheight);
993 	return ret;
994 }
995 
996 static enum drm_mode_status qxl_conn_mode_valid(struct drm_connector *connector,
997 			       struct drm_display_mode *mode)
998 {
999 	struct drm_device *ddev = connector->dev;
1000 	struct qxl_device *qdev = to_qxl(ddev);
1001 
1002 	if (qxl_check_mode(qdev, mode->hdisplay, mode->vdisplay) != 0)
1003 		return MODE_BAD;
1004 
1005 	return MODE_OK;
1006 }
1007 
1008 static struct drm_encoder *qxl_best_encoder(struct drm_connector *connector)
1009 {
1010 	struct qxl_output *qxl_output =
1011 		drm_connector_to_qxl_output(connector);
1012 
1013 	DRM_DEBUG("\n");
1014 	return &qxl_output->enc;
1015 }
1016 
1017 static const struct drm_connector_helper_funcs qxl_connector_helper_funcs = {
1018 	.get_modes = qxl_conn_get_modes,
1019 	.mode_valid = qxl_conn_mode_valid,
1020 	.best_encoder = qxl_best_encoder,
1021 };
1022 
1023 static enum drm_connector_status qxl_conn_detect(
1024 			struct drm_connector *connector,
1025 			bool force)
1026 {
1027 	struct qxl_output *output =
1028 		drm_connector_to_qxl_output(connector);
1029 	struct drm_device *ddev = connector->dev;
1030 	struct qxl_device *qdev = to_qxl(ddev);
1031 	bool connected = false;
1032 
1033 	/* The first monitor is always connected */
1034 	if (!qdev->client_monitors_config) {
1035 		if (output->index == 0)
1036 			connected = true;
1037 	} else
1038 		connected = qdev->client_monitors_config->count > output->index &&
1039 		     qxl_head_enabled(&qdev->client_monitors_config->heads[output->index]);
1040 
1041 	DRM_DEBUG("#%d connected: %d\n", output->index, connected);
1042 
1043 	return connected ? connector_status_connected
1044 			 : connector_status_disconnected;
1045 }
1046 
1047 static void qxl_conn_destroy(struct drm_connector *connector)
1048 {
1049 	struct qxl_output *qxl_output =
1050 		drm_connector_to_qxl_output(connector);
1051 
1052 	drm_connector_unregister(connector);
1053 	drm_connector_cleanup(connector);
1054 	kfree(qxl_output);
1055 }
1056 
1057 static const struct drm_connector_funcs qxl_connector_funcs = {
1058 	.detect = qxl_conn_detect,
1059 	.fill_modes = drm_helper_probe_single_connector_modes,
1060 	.destroy = qxl_conn_destroy,
1061 	.reset = drm_atomic_helper_connector_reset,
1062 	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
1063 	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
1064 };
1065 
1066 static int qxl_mode_create_hotplug_mode_update_property(struct qxl_device *qdev)
1067 {
1068 	if (qdev->hotplug_mode_update_property)
1069 		return 0;
1070 
1071 	qdev->hotplug_mode_update_property =
1072 		drm_property_create_range(&qdev->ddev, DRM_MODE_PROP_IMMUTABLE,
1073 					  "hotplug_mode_update", 0, 1);
1074 
1075 	return 0;
1076 }
1077 
1078 static int qdev_output_init(struct drm_device *dev, int num_output)
1079 {
1080 	struct qxl_device *qdev = to_qxl(dev);
1081 	struct qxl_output *qxl_output;
1082 	struct drm_connector *connector;
1083 	struct drm_encoder *encoder;
1084 	int ret;
1085 
1086 	qxl_output = kzalloc(sizeof(struct qxl_output), GFP_KERNEL);
1087 	if (!qxl_output)
1088 		return -ENOMEM;
1089 
1090 	qxl_output->index = num_output;
1091 
1092 	connector = &qxl_output->base;
1093 	encoder = &qxl_output->enc;
1094 	drm_connector_init(dev, &qxl_output->base,
1095 			   &qxl_connector_funcs, DRM_MODE_CONNECTOR_VIRTUAL);
1096 
1097 	ret = drm_simple_encoder_init(dev, &qxl_output->enc,
1098 				      DRM_MODE_ENCODER_VIRTUAL);
1099 	if (ret) {
1100 		drm_err(dev, "drm_simple_encoder_init() failed, error %d\n",
1101 			ret);
1102 		goto err_drm_connector_cleanup;
1103 	}
1104 
1105 	/* we get HPD via client monitors config */
1106 	connector->polled = DRM_CONNECTOR_POLL_HPD;
1107 	encoder->possible_crtcs = 1 << num_output;
1108 	drm_connector_attach_encoder(&qxl_output->base,
1109 					  &qxl_output->enc);
1110 	drm_connector_helper_add(connector, &qxl_connector_helper_funcs);
1111 
1112 	drm_object_attach_property(&connector->base,
1113 				   qdev->hotplug_mode_update_property, 0);
1114 	drm_object_attach_property(&connector->base,
1115 				   dev->mode_config.suggested_x_property, 0);
1116 	drm_object_attach_property(&connector->base,
1117 				   dev->mode_config.suggested_y_property, 0);
1118 	return 0;
1119 
1120 err_drm_connector_cleanup:
1121 	drm_connector_cleanup(&qxl_output->base);
1122 	kfree(qxl_output);
1123 	return ret;
1124 }
1125 
1126 static struct drm_framebuffer *
1127 qxl_user_framebuffer_create(struct drm_device *dev,
1128 			    struct drm_file *file_priv,
1129 			    const struct drm_mode_fb_cmd2 *mode_cmd)
1130 {
1131 	return drm_gem_fb_create_with_funcs(dev, file_priv, mode_cmd,
1132 					    &qxl_fb_funcs);
1133 }
1134 
1135 static const struct drm_mode_config_funcs qxl_mode_funcs = {
1136 	.fb_create = qxl_user_framebuffer_create,
1137 	.atomic_check = drm_atomic_helper_check,
1138 	.atomic_commit = drm_atomic_helper_commit,
1139 };
1140 
1141 int qxl_create_monitors_object(struct qxl_device *qdev)
1142 {
1143 	int ret;
1144 	struct drm_gem_object *gobj;
1145 	struct dma_buf_map map;
1146 	int monitors_config_size = sizeof(struct qxl_monitors_config) +
1147 		qxl_num_crtc * sizeof(struct qxl_head);
1148 
1149 	ret = qxl_gem_object_create(qdev, monitors_config_size, 0,
1150 				    QXL_GEM_DOMAIN_VRAM,
1151 				    false, false, NULL, &gobj);
1152 	if (ret) {
1153 		DRM_ERROR("%s: failed to create gem ret=%d\n", __func__, ret);
1154 		return -ENOMEM;
1155 	}
1156 	qdev->monitors_config_bo = gem_to_qxl_bo(gobj);
1157 
1158 	ret = qxl_bo_pin(qdev->monitors_config_bo);
1159 	if (ret)
1160 		return ret;
1161 
1162 	qxl_bo_kmap(qdev->monitors_config_bo, &map);
1163 
1164 	qdev->monitors_config = qdev->monitors_config_bo->kptr;
1165 	qdev->ram_header->monitors_config =
1166 		qxl_bo_physical_address(qdev, qdev->monitors_config_bo, 0);
1167 
1168 	memset(qdev->monitors_config, 0, monitors_config_size);
1169 	qdev->dumb_heads = kcalloc(qxl_num_crtc, sizeof(qdev->dumb_heads[0]),
1170 				   GFP_KERNEL);
1171 	if (!qdev->dumb_heads) {
1172 		qxl_destroy_monitors_object(qdev);
1173 		return -ENOMEM;
1174 	}
1175 	return 0;
1176 }
1177 
1178 int qxl_destroy_monitors_object(struct qxl_device *qdev)
1179 {
1180 	int ret;
1181 
1182 	qdev->monitors_config = NULL;
1183 	qdev->ram_header->monitors_config = 0;
1184 
1185 	qxl_bo_kunmap(qdev->monitors_config_bo);
1186 	ret = qxl_bo_unpin(qdev->monitors_config_bo);
1187 	if (ret)
1188 		return ret;
1189 
1190 	qxl_bo_unref(&qdev->monitors_config_bo);
1191 	return 0;
1192 }
1193 
1194 int qxl_modeset_init(struct qxl_device *qdev)
1195 {
1196 	int i;
1197 	int ret;
1198 
1199 	drm_mode_config_init(&qdev->ddev);
1200 
1201 	ret = qxl_create_monitors_object(qdev);
1202 	if (ret)
1203 		return ret;
1204 
1205 	qdev->ddev.mode_config.funcs = (void *)&qxl_mode_funcs;
1206 
1207 	/* modes will be validated against the framebuffer size */
1208 	qdev->ddev.mode_config.min_width = 0;
1209 	qdev->ddev.mode_config.min_height = 0;
1210 	qdev->ddev.mode_config.max_width = 8192;
1211 	qdev->ddev.mode_config.max_height = 8192;
1212 
1213 	qdev->ddev.mode_config.fb_base = qdev->vram_base;
1214 
1215 	drm_mode_create_suggested_offset_properties(&qdev->ddev);
1216 	qxl_mode_create_hotplug_mode_update_property(qdev);
1217 
1218 	for (i = 0 ; i < qxl_num_crtc; ++i) {
1219 		qdev_crtc_init(&qdev->ddev, i);
1220 		qdev_output_init(&qdev->ddev, i);
1221 	}
1222 
1223 	qxl_display_read_client_monitors_config(qdev);
1224 
1225 	drm_mode_config_reset(&qdev->ddev);
1226 	return 0;
1227 }
1228 
1229 void qxl_modeset_fini(struct qxl_device *qdev)
1230 {
1231 	qxl_destroy_monitors_object(qdev);
1232 	drm_mode_config_cleanup(&qdev->ddev);
1233 }
1234