xref: /openbmc/linux/drivers/gpu/drm/msm/msm_atomic.c (revision aef9dbb8f779ae0ffb46313b07700cac72b58ff4)
1cf3a7e4cSRob Clark /*
2cf3a7e4cSRob Clark  * Copyright (C) 2014 Red Hat
3cf3a7e4cSRob Clark  * Author: Rob Clark <robdclark@gmail.com>
4cf3a7e4cSRob Clark  *
5cf3a7e4cSRob Clark  * This program is free software; you can redistribute it and/or modify it
6cf3a7e4cSRob Clark  * under the terms of the GNU General Public License version 2 as published by
7cf3a7e4cSRob Clark  * the Free Software Foundation.
8cf3a7e4cSRob Clark  *
9cf3a7e4cSRob Clark  * This program is distributed in the hope that it will be useful, but WITHOUT
10cf3a7e4cSRob Clark  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11cf3a7e4cSRob Clark  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
12cf3a7e4cSRob Clark  * more details.
13cf3a7e4cSRob Clark  *
14cf3a7e4cSRob Clark  * You should have received a copy of the GNU General Public License along with
15cf3a7e4cSRob Clark  * this program.  If not, see <http://www.gnu.org/licenses/>.
16cf3a7e4cSRob Clark  */
17cf3a7e4cSRob Clark 
18cf3a7e4cSRob Clark #include "msm_drv.h"
19cf3a7e4cSRob Clark #include "msm_kms.h"
20cf3a7e4cSRob Clark #include "msm_gem.h"
21cf3a7e4cSRob Clark 
22cf3a7e4cSRob Clark struct msm_commit {
230b776d45SRob Clark 	struct drm_device *dev;
24cf3a7e4cSRob Clark 	struct drm_atomic_state *state;
25cf3a7e4cSRob Clark 	uint32_t fence;
26cf3a7e4cSRob Clark 	struct msm_fence_cb fence_cb;
27f86afecfSRob Clark 	uint32_t crtc_mask;
28cf3a7e4cSRob Clark };
29cf3a7e4cSRob Clark 
30cf3a7e4cSRob Clark static void fence_cb(struct msm_fence_cb *cb);
31cf3a7e4cSRob Clark 
32f86afecfSRob Clark /* block until specified crtcs are no longer pending update, and
33f86afecfSRob Clark  * atomically mark them as pending update
34f86afecfSRob Clark  */
35f86afecfSRob Clark static int start_atomic(struct msm_drm_private *priv, uint32_t crtc_mask)
36f86afecfSRob Clark {
37f86afecfSRob Clark 	int ret;
38f86afecfSRob Clark 
39f86afecfSRob Clark 	spin_lock(&priv->pending_crtcs_event.lock);
40f86afecfSRob Clark 	ret = wait_event_interruptible_locked(priv->pending_crtcs_event,
41f86afecfSRob Clark 			!(priv->pending_crtcs & crtc_mask));
42f86afecfSRob Clark 	if (ret == 0) {
43f86afecfSRob Clark 		DBG("start: %08x", crtc_mask);
44f86afecfSRob Clark 		priv->pending_crtcs |= crtc_mask;
45f86afecfSRob Clark 	}
46f86afecfSRob Clark 	spin_unlock(&priv->pending_crtcs_event.lock);
47f86afecfSRob Clark 
48f86afecfSRob Clark 	return ret;
49f86afecfSRob Clark }
50f86afecfSRob Clark 
51f86afecfSRob Clark /* clear specified crtcs (no longer pending update)
52f86afecfSRob Clark  */
53f86afecfSRob Clark static void end_atomic(struct msm_drm_private *priv, uint32_t crtc_mask)
54f86afecfSRob Clark {
55f86afecfSRob Clark 	spin_lock(&priv->pending_crtcs_event.lock);
56f86afecfSRob Clark 	DBG("end: %08x", crtc_mask);
57f86afecfSRob Clark 	priv->pending_crtcs &= ~crtc_mask;
58f86afecfSRob Clark 	wake_up_all_locked(&priv->pending_crtcs_event);
59f86afecfSRob Clark 	spin_unlock(&priv->pending_crtcs_event.lock);
60f86afecfSRob Clark }
61f86afecfSRob Clark 
620b776d45SRob Clark static struct msm_commit *commit_init(struct drm_atomic_state *state)
63cf3a7e4cSRob Clark {
64cf3a7e4cSRob Clark 	struct msm_commit *c = kzalloc(sizeof(*c), GFP_KERNEL);
65cf3a7e4cSRob Clark 
66cf3a7e4cSRob Clark 	if (!c)
67cf3a7e4cSRob Clark 		return NULL;
68cf3a7e4cSRob Clark 
690b776d45SRob Clark 	c->dev = state->dev;
70cf3a7e4cSRob Clark 	c->state = state;
710b776d45SRob Clark 
72cf3a7e4cSRob Clark 	/* TODO we might need a way to indicate to run the cb on a
73cf3a7e4cSRob Clark 	 * different wq so wait_for_vblanks() doesn't block retiring
74cf3a7e4cSRob Clark 	 * bo's..
75cf3a7e4cSRob Clark 	 */
76cf3a7e4cSRob Clark 	INIT_FENCE_CB(&c->fence_cb, fence_cb);
77cf3a7e4cSRob Clark 
78cf3a7e4cSRob Clark 	return c;
79cf3a7e4cSRob Clark }
80cf3a7e4cSRob Clark 
810b776d45SRob Clark static void commit_destroy(struct msm_commit *c)
820b776d45SRob Clark {
830b776d45SRob Clark 	end_atomic(c->dev->dev_private, c->crtc_mask);
840b776d45SRob Clark 	kfree(c);
850b776d45SRob Clark }
860b776d45SRob Clark 
870a5c9aadSHai Li static void msm_atomic_wait_for_commit_done(struct drm_device *dev,
880a5c9aadSHai Li 		struct drm_atomic_state *old_state)
890a5c9aadSHai Li {
900a5c9aadSHai Li 	struct drm_crtc *crtc;
910a5c9aadSHai Li 	struct msm_drm_private *priv = old_state->dev->dev_private;
920a5c9aadSHai Li 	struct msm_kms *kms = priv->kms;
930a5c9aadSHai Li 	int ncrtcs = old_state->dev->mode_config.num_crtc;
940a5c9aadSHai Li 	int i;
950a5c9aadSHai Li 
960a5c9aadSHai Li 	for (i = 0; i < ncrtcs; i++) {
970a5c9aadSHai Li 		crtc = old_state->crtcs[i];
980a5c9aadSHai Li 
990a5c9aadSHai Li 		if (!crtc)
1000a5c9aadSHai Li 			continue;
1010a5c9aadSHai Li 
1020a5c9aadSHai Li 		if (!crtc->state->enable)
1030a5c9aadSHai Li 			continue;
1040a5c9aadSHai Li 
1050a5c9aadSHai Li 		/* Legacy cursor ioctls are completely unsynced, and userspace
1060a5c9aadSHai Li 		 * relies on that (by doing tons of cursor updates). */
1070a5c9aadSHai Li 		if (old_state->legacy_cursor_update)
1080a5c9aadSHai Li 			continue;
1090a5c9aadSHai Li 
1100a5c9aadSHai Li 		kms->funcs->wait_for_crtc_commit_done(kms, crtc);
1110a5c9aadSHai Li 	}
1120a5c9aadSHai Li }
1130a5c9aadSHai Li 
114cf3a7e4cSRob Clark /* The (potentially) asynchronous part of the commit.  At this point
115cf3a7e4cSRob Clark  * nothing can fail short of armageddon.
116cf3a7e4cSRob Clark  */
117cf3a7e4cSRob Clark static void complete_commit(struct msm_commit *c)
118cf3a7e4cSRob Clark {
119cf3a7e4cSRob Clark 	struct drm_atomic_state *state = c->state;
120cf3a7e4cSRob Clark 	struct drm_device *dev = state->dev;
1210b776d45SRob Clark 	struct msm_drm_private *priv = dev->dev_private;
1220b776d45SRob Clark 	struct msm_kms *kms = priv->kms;
1230b776d45SRob Clark 
1240b776d45SRob Clark 	kms->funcs->prepare_commit(kms, state);
125cf3a7e4cSRob Clark 
1261af434a9SDaniel Vetter 	drm_atomic_helper_commit_modeset_disables(dev, state);
127cf3a7e4cSRob Clark 
128*aef9dbb8SDaniel Vetter 	drm_atomic_helper_commit_planes(dev, state, false);
129cf3a7e4cSRob Clark 
1301af434a9SDaniel Vetter 	drm_atomic_helper_commit_modeset_enables(dev, state);
131cf3a7e4cSRob Clark 
132f86afecfSRob Clark 	/* NOTE: _wait_for_vblanks() only waits for vblank on
133f86afecfSRob Clark 	 * enabled CRTCs.  So we end up faulting when disabling
134f86afecfSRob Clark 	 * due to (potentially) unref'ing the outgoing fb's
135f86afecfSRob Clark 	 * before the vblank when the disable has latched.
136f86afecfSRob Clark 	 *
137f86afecfSRob Clark 	 * But if it did wait on disabled (or newly disabled)
138f86afecfSRob Clark 	 * CRTCs, that would be racy (ie. we could have missed
139f86afecfSRob Clark 	 * the irq.  We need some way to poll for pipe shut
140f86afecfSRob Clark 	 * down.  Or just live with occasionally hitting the
141f86afecfSRob Clark 	 * timeout in the CRTC disable path (which really should
142f86afecfSRob Clark 	 * not be critical path)
143f86afecfSRob Clark 	 */
144f86afecfSRob Clark 
1450a5c9aadSHai Li 	msm_atomic_wait_for_commit_done(dev, state);
146cf3a7e4cSRob Clark 
147cf3a7e4cSRob Clark 	drm_atomic_helper_cleanup_planes(dev, state);
148cf3a7e4cSRob Clark 
1490b776d45SRob Clark 	kms->funcs->complete_commit(kms, state);
1500b776d45SRob Clark 
151cf3a7e4cSRob Clark 	drm_atomic_state_free(state);
152cf3a7e4cSRob Clark 
1530b776d45SRob Clark 	commit_destroy(c);
154cf3a7e4cSRob Clark }
155cf3a7e4cSRob Clark 
156cf3a7e4cSRob Clark static void fence_cb(struct msm_fence_cb *cb)
157cf3a7e4cSRob Clark {
158cf3a7e4cSRob Clark 	struct msm_commit *c =
159cf3a7e4cSRob Clark 			container_of(cb, struct msm_commit, fence_cb);
160cf3a7e4cSRob Clark 	complete_commit(c);
161cf3a7e4cSRob Clark }
162cf3a7e4cSRob Clark 
163cf3a7e4cSRob Clark static void add_fb(struct msm_commit *c, struct drm_framebuffer *fb)
164cf3a7e4cSRob Clark {
165cf3a7e4cSRob Clark 	struct drm_gem_object *obj = msm_framebuffer_bo(fb, 0);
166cf3a7e4cSRob Clark 	c->fence = max(c->fence, msm_gem_fence(to_msm_bo(obj), MSM_PREP_READ));
167cf3a7e4cSRob Clark }
168cf3a7e4cSRob Clark 
169b4274fbeSDaniel Vetter int msm_atomic_check(struct drm_device *dev,
170b4274fbeSDaniel Vetter 		     struct drm_atomic_state *state)
171b4274fbeSDaniel Vetter {
172b4274fbeSDaniel Vetter 	int ret;
173b4274fbeSDaniel Vetter 
174b4274fbeSDaniel Vetter 	/*
175b4274fbeSDaniel Vetter 	 * msm ->atomic_check can update ->mode_changed for pixel format
176b4274fbeSDaniel Vetter 	 * changes, hence must be run before we check the modeset changes.
177b4274fbeSDaniel Vetter 	 */
178b4274fbeSDaniel Vetter 	ret = drm_atomic_helper_check_planes(dev, state);
179b4274fbeSDaniel Vetter 	if (ret)
180b4274fbeSDaniel Vetter 		return ret;
181b4274fbeSDaniel Vetter 
182b4274fbeSDaniel Vetter 	ret = drm_atomic_helper_check_modeset(dev, state);
183b4274fbeSDaniel Vetter 	if (ret)
184b4274fbeSDaniel Vetter 		return ret;
185b4274fbeSDaniel Vetter 
186b4274fbeSDaniel Vetter 	return ret;
187b4274fbeSDaniel Vetter }
188b4274fbeSDaniel Vetter 
189cf3a7e4cSRob Clark /**
190cf3a7e4cSRob Clark  * drm_atomic_helper_commit - commit validated state object
191cf3a7e4cSRob Clark  * @dev: DRM device
192cf3a7e4cSRob Clark  * @state: the driver state object
193cf3a7e4cSRob Clark  * @async: asynchronous commit
194cf3a7e4cSRob Clark  *
195cf3a7e4cSRob Clark  * This function commits a with drm_atomic_helper_check() pre-validated state
196cf3a7e4cSRob Clark  * object. This can still fail when e.g. the framebuffer reservation fails. For
197cf3a7e4cSRob Clark  * now this doesn't implement asynchronous commits.
198cf3a7e4cSRob Clark  *
199cf3a7e4cSRob Clark  * RETURNS
200cf3a7e4cSRob Clark  * Zero for success or -errno.
201cf3a7e4cSRob Clark  */
202cf3a7e4cSRob Clark int msm_atomic_commit(struct drm_device *dev,
203cf3a7e4cSRob Clark 		struct drm_atomic_state *state, bool async)
204cf3a7e4cSRob Clark {
205cf3a7e4cSRob Clark 	int nplanes = dev->mode_config.num_total_plane;
206f86afecfSRob Clark 	int ncrtcs = dev->mode_config.num_crtc;
20756c2da83SRob Clark 	ktime_t timeout;
208f86afecfSRob Clark 	struct msm_commit *c;
209cf3a7e4cSRob Clark 	int i, ret;
210cf3a7e4cSRob Clark 
211cf3a7e4cSRob Clark 	ret = drm_atomic_helper_prepare_planes(dev, state);
212cf3a7e4cSRob Clark 	if (ret)
213cf3a7e4cSRob Clark 		return ret;
214cf3a7e4cSRob Clark 
2150b776d45SRob Clark 	c = commit_init(state);
216f65c18c0SLaurent Pinchart 	if (!c) {
217f65c18c0SLaurent Pinchart 		ret = -ENOMEM;
218f65c18c0SLaurent Pinchart 		goto error;
219f65c18c0SLaurent Pinchart 	}
220f86afecfSRob Clark 
221f86afecfSRob Clark 	/*
222f86afecfSRob Clark 	 * Figure out what crtcs we have:
223f86afecfSRob Clark 	 */
224f86afecfSRob Clark 	for (i = 0; i < ncrtcs; i++) {
225f86afecfSRob Clark 		struct drm_crtc *crtc = state->crtcs[i];
226f86afecfSRob Clark 		if (!crtc)
227f86afecfSRob Clark 			continue;
228f86afecfSRob Clark 		c->crtc_mask |= (1 << drm_crtc_index(crtc));
229f86afecfSRob Clark 	}
230cf3a7e4cSRob Clark 
231cf3a7e4cSRob Clark 	/*
232cf3a7e4cSRob Clark 	 * Figure out what fence to wait for:
233cf3a7e4cSRob Clark 	 */
234cf3a7e4cSRob Clark 	for (i = 0; i < nplanes; i++) {
235cf3a7e4cSRob Clark 		struct drm_plane *plane = state->planes[i];
236cf3a7e4cSRob Clark 		struct drm_plane_state *new_state = state->plane_states[i];
237cf3a7e4cSRob Clark 
238cf3a7e4cSRob Clark 		if (!plane)
239cf3a7e4cSRob Clark 			continue;
240cf3a7e4cSRob Clark 
2413e2f29e4SRob Clark 		if ((plane->state->fb != new_state->fb) && new_state->fb)
242cf3a7e4cSRob Clark 			add_fb(c, new_state->fb);
243cf3a7e4cSRob Clark 	}
244cf3a7e4cSRob Clark 
245cf3a7e4cSRob Clark 	/*
246f86afecfSRob Clark 	 * Wait for pending updates on any of the same crtc's and then
247f86afecfSRob Clark 	 * mark our set of crtc's as busy:
248f86afecfSRob Clark 	 */
249f86afecfSRob Clark 	ret = start_atomic(dev->dev_private, c->crtc_mask);
2505b2e2b6cSLaurent Pinchart 	if (ret) {
2515b2e2b6cSLaurent Pinchart 		kfree(c);
252f65c18c0SLaurent Pinchart 		goto error;
2535b2e2b6cSLaurent Pinchart 	}
254f86afecfSRob Clark 
255f86afecfSRob Clark 	/*
256cf3a7e4cSRob Clark 	 * This is the point of no return - everything below never fails except
257cf3a7e4cSRob Clark 	 * when the hw goes bonghits. Which means we can commit the new state on
258cf3a7e4cSRob Clark 	 * the software side now.
259cf3a7e4cSRob Clark 	 */
260cf3a7e4cSRob Clark 
261cf3a7e4cSRob Clark 	drm_atomic_helper_swap_state(dev, state);
262cf3a7e4cSRob Clark 
263cf3a7e4cSRob Clark 	/*
264cf3a7e4cSRob Clark 	 * Everything below can be run asynchronously without the need to grab
265cf3a7e4cSRob Clark 	 * any modeset locks at all under one conditions: It must be guaranteed
266cf3a7e4cSRob Clark 	 * that the asynchronous work has either been cancelled (if the driver
267cf3a7e4cSRob Clark 	 * supports it, which at least requires that the framebuffers get
268cf3a7e4cSRob Clark 	 * cleaned up with drm_atomic_helper_cleanup_planes()) or completed
269cf3a7e4cSRob Clark 	 * before the new state gets committed on the software side with
270cf3a7e4cSRob Clark 	 * drm_atomic_helper_swap_state().
271cf3a7e4cSRob Clark 	 *
272cf3a7e4cSRob Clark 	 * This scheme allows new atomic state updates to be prepared and
273cf3a7e4cSRob Clark 	 * checked in parallel to the asynchronous completion of the previous
274cf3a7e4cSRob Clark 	 * update. Which is important since compositors need to figure out the
275cf3a7e4cSRob Clark 	 * composition of the next frame right after having submitted the
276cf3a7e4cSRob Clark 	 * current layout.
277cf3a7e4cSRob Clark 	 */
278cf3a7e4cSRob Clark 
279cf3a7e4cSRob Clark 	if (async) {
280cf3a7e4cSRob Clark 		msm_queue_fence_cb(dev, &c->fence_cb, c->fence);
281cf3a7e4cSRob Clark 		return 0;
282cf3a7e4cSRob Clark 	}
283cf3a7e4cSRob Clark 
28456c2da83SRob Clark 	timeout = ktime_add_ms(ktime_get(), 1000);
285be7a7b89SRob Clark 
28699fc1bc4SWentao Xu 	/* uninterruptible wait */
28799fc1bc4SWentao Xu 	msm_wait_fence(dev, c->fence, &timeout, false);
288cf3a7e4cSRob Clark 
289cf3a7e4cSRob Clark 	complete_commit(c);
290cf3a7e4cSRob Clark 
291cf3a7e4cSRob Clark 	return 0;
292f65c18c0SLaurent Pinchart 
293f65c18c0SLaurent Pinchart error:
294f65c18c0SLaurent Pinchart 	drm_atomic_helper_cleanup_planes(dev, state);
295f65c18c0SLaurent Pinchart 	return ret;
296cf3a7e4cSRob Clark }
297