1cf3a7e4cSRob Clark /* 2cf3a7e4cSRob Clark * Copyright (C) 2014 Red Hat 3cf3a7e4cSRob Clark * Author: Rob Clark <robdclark@gmail.com> 4cf3a7e4cSRob Clark * 5cf3a7e4cSRob Clark * This program is free software; you can redistribute it and/or modify it 6cf3a7e4cSRob Clark * under the terms of the GNU General Public License version 2 as published by 7cf3a7e4cSRob Clark * the Free Software Foundation. 8cf3a7e4cSRob Clark * 9cf3a7e4cSRob Clark * This program is distributed in the hope that it will be useful, but WITHOUT 10cf3a7e4cSRob Clark * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or 11cf3a7e4cSRob Clark * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for 12cf3a7e4cSRob Clark * more details. 13cf3a7e4cSRob Clark * 14cf3a7e4cSRob Clark * You should have received a copy of the GNU General Public License along with 15cf3a7e4cSRob Clark * this program. If not, see <http://www.gnu.org/licenses/>. 16cf3a7e4cSRob Clark */ 17cf3a7e4cSRob Clark 18cf3a7e4cSRob Clark #include "msm_drv.h" 19cf3a7e4cSRob Clark #include "msm_kms.h" 20cf3a7e4cSRob Clark #include "msm_gem.h" 21fde5de6cSRob Clark #include "msm_fence.h" 22cf3a7e4cSRob Clark 23cf3a7e4cSRob Clark struct msm_commit { 240b776d45SRob Clark struct drm_device *dev; 25cf3a7e4cSRob Clark struct drm_atomic_state *state; 26ba00c3f2SRob Clark struct work_struct work; 27f86afecfSRob Clark uint32_t crtc_mask; 28cf3a7e4cSRob Clark }; 29cf3a7e4cSRob Clark 30ba00c3f2SRob Clark static void commit_worker(struct work_struct *work); 31cf3a7e4cSRob Clark 32f86afecfSRob Clark /* block until specified crtcs are no longer pending update, and 33f86afecfSRob Clark * atomically mark them as pending update 34f86afecfSRob Clark */ 35f86afecfSRob Clark static int start_atomic(struct msm_drm_private *priv, uint32_t crtc_mask) 36f86afecfSRob Clark { 37f86afecfSRob Clark int ret; 38f86afecfSRob Clark 39f86afecfSRob Clark spin_lock(&priv->pending_crtcs_event.lock); 40f86afecfSRob Clark ret = wait_event_interruptible_locked(priv->pending_crtcs_event, 41f86afecfSRob Clark !(priv->pending_crtcs & crtc_mask)); 42f86afecfSRob Clark if (ret == 0) { 43f86afecfSRob Clark DBG("start: %08x", crtc_mask); 44f86afecfSRob Clark priv->pending_crtcs |= crtc_mask; 45f86afecfSRob Clark } 46f86afecfSRob Clark spin_unlock(&priv->pending_crtcs_event.lock); 47f86afecfSRob Clark 48f86afecfSRob Clark return ret; 49f86afecfSRob Clark } 50f86afecfSRob Clark 51f86afecfSRob Clark /* clear specified crtcs (no longer pending update) 52f86afecfSRob Clark */ 53f86afecfSRob Clark static void end_atomic(struct msm_drm_private *priv, uint32_t crtc_mask) 54f86afecfSRob Clark { 55f86afecfSRob Clark spin_lock(&priv->pending_crtcs_event.lock); 56f86afecfSRob Clark DBG("end: %08x", crtc_mask); 57f86afecfSRob Clark priv->pending_crtcs &= ~crtc_mask; 58f86afecfSRob Clark wake_up_all_locked(&priv->pending_crtcs_event); 59f86afecfSRob Clark spin_unlock(&priv->pending_crtcs_event.lock); 60f86afecfSRob Clark } 61f86afecfSRob Clark 620b776d45SRob Clark static struct msm_commit *commit_init(struct drm_atomic_state *state) 63cf3a7e4cSRob Clark { 64cf3a7e4cSRob Clark struct msm_commit *c = kzalloc(sizeof(*c), GFP_KERNEL); 65cf3a7e4cSRob Clark 66cf3a7e4cSRob Clark if (!c) 67cf3a7e4cSRob Clark return NULL; 68cf3a7e4cSRob Clark 690b776d45SRob Clark c->dev = state->dev; 70cf3a7e4cSRob Clark c->state = state; 710b776d45SRob Clark 72ba00c3f2SRob Clark INIT_WORK(&c->work, commit_worker); 73cf3a7e4cSRob Clark 74cf3a7e4cSRob Clark return c; 75cf3a7e4cSRob Clark } 76cf3a7e4cSRob Clark 770b776d45SRob Clark static void commit_destroy(struct msm_commit *c) 780b776d45SRob Clark { 790b776d45SRob Clark end_atomic(c->dev->dev_private, c->crtc_mask); 800b776d45SRob Clark kfree(c); 810b776d45SRob Clark } 820b776d45SRob Clark 830a5c9aadSHai Li static void msm_atomic_wait_for_commit_done(struct drm_device *dev, 840a5c9aadSHai Li struct drm_atomic_state *old_state) 850a5c9aadSHai Li { 860a5c9aadSHai Li struct drm_crtc *crtc; 878d76b79fSDaniel Vetter struct drm_crtc_state *crtc_state; 880a5c9aadSHai Li struct msm_drm_private *priv = old_state->dev->dev_private; 890a5c9aadSHai Li struct msm_kms *kms = priv->kms; 900a5c9aadSHai Li int i; 910a5c9aadSHai Li 928d76b79fSDaniel Vetter for_each_crtc_in_state(old_state, crtc, crtc_state, i) { 930a5c9aadSHai Li if (!crtc->state->enable) 940a5c9aadSHai Li continue; 950a5c9aadSHai Li 960a5c9aadSHai Li /* Legacy cursor ioctls are completely unsynced, and userspace 970a5c9aadSHai Li * relies on that (by doing tons of cursor updates). */ 980a5c9aadSHai Li if (old_state->legacy_cursor_update) 990a5c9aadSHai Li continue; 1000a5c9aadSHai Li 1010a5c9aadSHai Li kms->funcs->wait_for_crtc_commit_done(kms, crtc); 1020a5c9aadSHai Li } 1030a5c9aadSHai Li } 1040a5c9aadSHai Li 105cf3a7e4cSRob Clark /* The (potentially) asynchronous part of the commit. At this point 106cf3a7e4cSRob Clark * nothing can fail short of armageddon. 107cf3a7e4cSRob Clark */ 108ba00c3f2SRob Clark static void complete_commit(struct msm_commit *c, bool async) 109cf3a7e4cSRob Clark { 110cf3a7e4cSRob Clark struct drm_atomic_state *state = c->state; 111cf3a7e4cSRob Clark struct drm_device *dev = state->dev; 1120b776d45SRob Clark struct msm_drm_private *priv = dev->dev_private; 1130b776d45SRob Clark struct msm_kms *kms = priv->kms; 1140b776d45SRob Clark 115b6295f9aSRob Clark drm_atomic_helper_wait_for_fences(dev, state); 116ba00c3f2SRob Clark 1170b776d45SRob Clark kms->funcs->prepare_commit(kms, state); 118cf3a7e4cSRob Clark 1191af434a9SDaniel Vetter drm_atomic_helper_commit_modeset_disables(dev, state); 120cf3a7e4cSRob Clark 121*2b58e98dSLiu Ying drm_atomic_helper_commit_planes(dev, state, 0); 122cf3a7e4cSRob Clark 1231af434a9SDaniel Vetter drm_atomic_helper_commit_modeset_enables(dev, state); 124cf3a7e4cSRob Clark 125f86afecfSRob Clark /* NOTE: _wait_for_vblanks() only waits for vblank on 126f86afecfSRob Clark * enabled CRTCs. So we end up faulting when disabling 127f86afecfSRob Clark * due to (potentially) unref'ing the outgoing fb's 128f86afecfSRob Clark * before the vblank when the disable has latched. 129f86afecfSRob Clark * 130f86afecfSRob Clark * But if it did wait on disabled (or newly disabled) 131f86afecfSRob Clark * CRTCs, that would be racy (ie. we could have missed 132f86afecfSRob Clark * the irq. We need some way to poll for pipe shut 133f86afecfSRob Clark * down. Or just live with occasionally hitting the 134f86afecfSRob Clark * timeout in the CRTC disable path (which really should 135f86afecfSRob Clark * not be critical path) 136f86afecfSRob Clark */ 137f86afecfSRob Clark 1380a5c9aadSHai Li msm_atomic_wait_for_commit_done(dev, state); 139cf3a7e4cSRob Clark 140cf3a7e4cSRob Clark drm_atomic_helper_cleanup_planes(dev, state); 141cf3a7e4cSRob Clark 1420b776d45SRob Clark kms->funcs->complete_commit(kms, state); 1430b776d45SRob Clark 144cf3a7e4cSRob Clark drm_atomic_state_free(state); 145cf3a7e4cSRob Clark 1460b776d45SRob Clark commit_destroy(c); 147cf3a7e4cSRob Clark } 148cf3a7e4cSRob Clark 149ba00c3f2SRob Clark static void commit_worker(struct work_struct *work) 150cf3a7e4cSRob Clark { 151ba00c3f2SRob Clark complete_commit(container_of(work, struct msm_commit, work), true); 152cf3a7e4cSRob Clark } 153cf3a7e4cSRob Clark 154b4274fbeSDaniel Vetter int msm_atomic_check(struct drm_device *dev, 155b4274fbeSDaniel Vetter struct drm_atomic_state *state) 156b4274fbeSDaniel Vetter { 157b4274fbeSDaniel Vetter int ret; 158b4274fbeSDaniel Vetter 159b4274fbeSDaniel Vetter /* 160b4274fbeSDaniel Vetter * msm ->atomic_check can update ->mode_changed for pixel format 161b4274fbeSDaniel Vetter * changes, hence must be run before we check the modeset changes. 162b4274fbeSDaniel Vetter */ 163b4274fbeSDaniel Vetter ret = drm_atomic_helper_check_planes(dev, state); 164b4274fbeSDaniel Vetter if (ret) 165b4274fbeSDaniel Vetter return ret; 166b4274fbeSDaniel Vetter 167b4274fbeSDaniel Vetter ret = drm_atomic_helper_check_modeset(dev, state); 168b4274fbeSDaniel Vetter if (ret) 169b4274fbeSDaniel Vetter return ret; 170b4274fbeSDaniel Vetter 171b4274fbeSDaniel Vetter return ret; 172b4274fbeSDaniel Vetter } 173b4274fbeSDaniel Vetter 174cf3a7e4cSRob Clark /** 175cf3a7e4cSRob Clark * drm_atomic_helper_commit - commit validated state object 176cf3a7e4cSRob Clark * @dev: DRM device 177cf3a7e4cSRob Clark * @state: the driver state object 178a3ccfb9fSMaarten Lankhorst * @nonblock: nonblocking commit 179cf3a7e4cSRob Clark * 180cf3a7e4cSRob Clark * This function commits a with drm_atomic_helper_check() pre-validated state 181a3ccfb9fSMaarten Lankhorst * object. This can still fail when e.g. the framebuffer reservation fails. 182cf3a7e4cSRob Clark * 183cf3a7e4cSRob Clark * RETURNS 184cf3a7e4cSRob Clark * Zero for success or -errno. 185cf3a7e4cSRob Clark */ 186cf3a7e4cSRob Clark int msm_atomic_commit(struct drm_device *dev, 187a3ccfb9fSMaarten Lankhorst struct drm_atomic_state *state, bool nonblock) 188cf3a7e4cSRob Clark { 189ca762a8aSRob Clark struct msm_drm_private *priv = dev->dev_private; 190f86afecfSRob Clark struct msm_commit *c; 1918d76b79fSDaniel Vetter struct drm_crtc *crtc; 1928d76b79fSDaniel Vetter struct drm_crtc_state *crtc_state; 1938d76b79fSDaniel Vetter struct drm_plane *plane; 1948d76b79fSDaniel Vetter struct drm_plane_state *plane_state; 195cf3a7e4cSRob Clark int i, ret; 196cf3a7e4cSRob Clark 197cf3a7e4cSRob Clark ret = drm_atomic_helper_prepare_planes(dev, state); 198cf3a7e4cSRob Clark if (ret) 199cf3a7e4cSRob Clark return ret; 200cf3a7e4cSRob Clark 2010b776d45SRob Clark c = commit_init(state); 202f65c18c0SLaurent Pinchart if (!c) { 203f65c18c0SLaurent Pinchart ret = -ENOMEM; 204f65c18c0SLaurent Pinchart goto error; 205f65c18c0SLaurent Pinchart } 206f86afecfSRob Clark 207f86afecfSRob Clark /* 208f86afecfSRob Clark * Figure out what crtcs we have: 209f86afecfSRob Clark */ 2108d76b79fSDaniel Vetter for_each_crtc_in_state(state, crtc, crtc_state, i) 2118d76b79fSDaniel Vetter c->crtc_mask |= drm_crtc_mask(crtc); 212cf3a7e4cSRob Clark 213cf3a7e4cSRob Clark /* 214b6295f9aSRob Clark * Figure out what fence to wait for: 215b6295f9aSRob Clark */ 2168d76b79fSDaniel Vetter for_each_plane_in_state(state, plane, plane_state, i) { 2178d76b79fSDaniel Vetter if ((plane->state->fb != plane_state->fb) && plane_state->fb) { 2188d76b79fSDaniel Vetter struct drm_gem_object *obj = msm_framebuffer_bo(plane_state->fb, 0); 219b6295f9aSRob Clark struct msm_gem_object *msm_obj = to_msm_bo(obj); 220b6295f9aSRob Clark 2218d76b79fSDaniel Vetter plane_state->fence = reservation_object_get_excl_rcu(msm_obj->resv); 222b6295f9aSRob Clark } 223b6295f9aSRob Clark } 224b6295f9aSRob Clark 225b6295f9aSRob Clark /* 226f86afecfSRob Clark * Wait for pending updates on any of the same crtc's and then 227f86afecfSRob Clark * mark our set of crtc's as busy: 228f86afecfSRob Clark */ 229f86afecfSRob Clark ret = start_atomic(dev->dev_private, c->crtc_mask); 2305b2e2b6cSLaurent Pinchart if (ret) { 2315b2e2b6cSLaurent Pinchart kfree(c); 232f65c18c0SLaurent Pinchart goto error; 2335b2e2b6cSLaurent Pinchart } 234f86afecfSRob Clark 235f86afecfSRob Clark /* 236cf3a7e4cSRob Clark * This is the point of no return - everything below never fails except 237cf3a7e4cSRob Clark * when the hw goes bonghits. Which means we can commit the new state on 238cf3a7e4cSRob Clark * the software side now. 239cf3a7e4cSRob Clark */ 240cf3a7e4cSRob Clark 2415e84c269SDaniel Vetter drm_atomic_helper_swap_state(state, true); 242cf3a7e4cSRob Clark 243cf3a7e4cSRob Clark /* 244cf3a7e4cSRob Clark * Everything below can be run asynchronously without the need to grab 245cf3a7e4cSRob Clark * any modeset locks at all under one conditions: It must be guaranteed 246cf3a7e4cSRob Clark * that the asynchronous work has either been cancelled (if the driver 247cf3a7e4cSRob Clark * supports it, which at least requires that the framebuffers get 248cf3a7e4cSRob Clark * cleaned up with drm_atomic_helper_cleanup_planes()) or completed 249cf3a7e4cSRob Clark * before the new state gets committed on the software side with 250cf3a7e4cSRob Clark * drm_atomic_helper_swap_state(). 251cf3a7e4cSRob Clark * 252cf3a7e4cSRob Clark * This scheme allows new atomic state updates to be prepared and 253cf3a7e4cSRob Clark * checked in parallel to the asynchronous completion of the previous 254cf3a7e4cSRob Clark * update. Which is important since compositors need to figure out the 255cf3a7e4cSRob Clark * composition of the next frame right after having submitted the 256cf3a7e4cSRob Clark * current layout. 257cf3a7e4cSRob Clark */ 258cf3a7e4cSRob Clark 259ba00c3f2SRob Clark if (nonblock) { 260ba00c3f2SRob Clark queue_work(priv->atomic_wq, &c->work); 261cf3a7e4cSRob Clark return 0; 262cf3a7e4cSRob Clark } 263cf3a7e4cSRob Clark 264ba00c3f2SRob Clark complete_commit(c, false); 265cf3a7e4cSRob Clark 266cf3a7e4cSRob Clark return 0; 267f65c18c0SLaurent Pinchart 268f65c18c0SLaurent Pinchart error: 269f65c18c0SLaurent Pinchart drm_atomic_helper_cleanup_planes(dev, state); 270f65c18c0SLaurent Pinchart return ret; 271cf3a7e4cSRob Clark } 272