xref: /openbmc/linux/arch/powerpc/kernel/rtas_pci.c (revision 68a64357d15ae4f596e92715719071952006e83c)
1d3d2176aSDavid Gibson /*
2d3d2176aSDavid Gibson  * Copyright (C) 2001 Dave Engebretsen, IBM Corporation
3d3d2176aSDavid Gibson  * Copyright (C) 2003 Anton Blanchard <anton@au.ibm.com>, IBM
4d3d2176aSDavid Gibson  *
5d3d2176aSDavid Gibson  * RTAS specific routines for PCI.
6d3d2176aSDavid Gibson  *
7d3d2176aSDavid Gibson  * Based on code from pci.c, chrp_pci.c and pSeries_pci.c
8d3d2176aSDavid Gibson  *
9d3d2176aSDavid Gibson  * This program is free software; you can redistribute it and/or modify
10d3d2176aSDavid Gibson  * it under the terms of the GNU General Public License as published by
11d3d2176aSDavid Gibson  * the Free Software Foundation; either version 2 of the License, or
12d3d2176aSDavid Gibson  * (at your option) any later version.
13d3d2176aSDavid Gibson  *
14d3d2176aSDavid Gibson  * This program is distributed in the hope that it will be useful,
15d3d2176aSDavid Gibson  * but WITHOUT ANY WARRANTY; without even the implied warranty of
16d3d2176aSDavid Gibson  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
17d3d2176aSDavid Gibson  * GNU General Public License for more details.
18d3d2176aSDavid Gibson  *
19d3d2176aSDavid Gibson  * You should have received a copy of the GNU General Public License
20d3d2176aSDavid Gibson  * along with this program; if not, write to the Free Software
21d3d2176aSDavid Gibson  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA
22d3d2176aSDavid Gibson  */
23d3d2176aSDavid Gibson 
24d3d2176aSDavid Gibson #include <linux/kernel.h>
25d3d2176aSDavid Gibson #include <linux/threads.h>
26d3d2176aSDavid Gibson #include <linux/pci.h>
27d3d2176aSDavid Gibson #include <linux/string.h>
28d3d2176aSDavid Gibson #include <linux/init.h>
29d3d2176aSDavid Gibson #include <linux/bootmem.h>
30d3d2176aSDavid Gibson 
31d3d2176aSDavid Gibson #include <asm/io.h>
32d3d2176aSDavid Gibson #include <asm/pgtable.h>
33d3d2176aSDavid Gibson #include <asm/irq.h>
34d3d2176aSDavid Gibson #include <asm/prom.h>
35d3d2176aSDavid Gibson #include <asm/machdep.h>
36d3d2176aSDavid Gibson #include <asm/pci-bridge.h>
37d3d2176aSDavid Gibson #include <asm/iommu.h>
38d3d2176aSDavid Gibson #include <asm/rtas.h>
39d3d2176aSDavid Gibson #include <asm/mpic.h>
40d3d2176aSDavid Gibson #include <asm/ppc-pci.h>
41*68a64357SBenjamin Herrenschmidt #include <asm/eeh.h>
42d3d2176aSDavid Gibson 
43d3d2176aSDavid Gibson /* RTAS tokens */
44d3d2176aSDavid Gibson static int read_pci_config;
45d3d2176aSDavid Gibson static int write_pci_config;
46d3d2176aSDavid Gibson static int ibm_read_pci_config;
47d3d2176aSDavid Gibson static int ibm_write_pci_config;
48d3d2176aSDavid Gibson 
49d3d2176aSDavid Gibson static inline int config_access_valid(struct pci_dn *dn, int where)
50d3d2176aSDavid Gibson {
51d3d2176aSDavid Gibson 	if (where < 256)
52d3d2176aSDavid Gibson 		return 1;
53d3d2176aSDavid Gibson 	if (where < 4096 && dn->pci_ext_config_space)
54d3d2176aSDavid Gibson 		return 1;
55d3d2176aSDavid Gibson 
56d3d2176aSDavid Gibson 	return 0;
57d3d2176aSDavid Gibson }
58d3d2176aSDavid Gibson 
59d3d2176aSDavid Gibson static int of_device_available(struct device_node * dn)
60d3d2176aSDavid Gibson {
61a7f67bdfSJeremy Kerr         const char *status;
62d3d2176aSDavid Gibson 
63d3d2176aSDavid Gibson         status = get_property(dn, "status", NULL);
64d3d2176aSDavid Gibson 
65d3d2176aSDavid Gibson         if (!status)
66d3d2176aSDavid Gibson                 return 1;
67d3d2176aSDavid Gibson 
68d3d2176aSDavid Gibson         if (!strcmp(status, "okay"))
69d3d2176aSDavid Gibson                 return 1;
70d3d2176aSDavid Gibson 
71d3d2176aSDavid Gibson         return 0;
72d3d2176aSDavid Gibson }
73d3d2176aSDavid Gibson 
747684b40cSLinas Vepstas int rtas_read_config(struct pci_dn *pdn, int where, int size, u32 *val)
75d3d2176aSDavid Gibson {
76d3d2176aSDavid Gibson 	int returnval = -1;
77d3d2176aSDavid Gibson 	unsigned long buid, addr;
78d3d2176aSDavid Gibson 	int ret;
79d3d2176aSDavid Gibson 
80d3d2176aSDavid Gibson 	if (!pdn)
81d3d2176aSDavid Gibson 		return PCIBIOS_DEVICE_NOT_FOUND;
82d3d2176aSDavid Gibson 	if (!config_access_valid(pdn, where))
83d3d2176aSDavid Gibson 		return PCIBIOS_BAD_REGISTER_NUMBER;
84d3d2176aSDavid Gibson 
856f3d5d3cSMichael Ellerman 	addr = rtas_config_addr(pdn->busno, pdn->devfn, where);
86d3d2176aSDavid Gibson 	buid = pdn->phb->buid;
87d3d2176aSDavid Gibson 	if (buid) {
88d3d2176aSDavid Gibson 		ret = rtas_call(ibm_read_pci_config, 4, 2, &returnval,
89d3d2176aSDavid Gibson 				addr, BUID_HI(buid), BUID_LO(buid), size);
90d3d2176aSDavid Gibson 	} else {
91d3d2176aSDavid Gibson 		ret = rtas_call(read_pci_config, 2, 2, &returnval, addr, size);
92d3d2176aSDavid Gibson 	}
93d3d2176aSDavid Gibson 	*val = returnval;
94d3d2176aSDavid Gibson 
95d3d2176aSDavid Gibson 	if (ret)
96d3d2176aSDavid Gibson 		return PCIBIOS_DEVICE_NOT_FOUND;
97d3d2176aSDavid Gibson 
98d3d2176aSDavid Gibson 	if (returnval == EEH_IO_ERROR_VALUE(size) &&
99d3d2176aSDavid Gibson 	    eeh_dn_check_failure (pdn->node, NULL))
100d3d2176aSDavid Gibson 		return PCIBIOS_DEVICE_NOT_FOUND;
101d3d2176aSDavid Gibson 
102d3d2176aSDavid Gibson 	return PCIBIOS_SUCCESSFUL;
103d3d2176aSDavid Gibson }
104d3d2176aSDavid Gibson 
105d3d2176aSDavid Gibson static int rtas_pci_read_config(struct pci_bus *bus,
106d3d2176aSDavid Gibson 				unsigned int devfn,
107d3d2176aSDavid Gibson 				int where, int size, u32 *val)
108d3d2176aSDavid Gibson {
109d3d2176aSDavid Gibson 	struct device_node *busdn, *dn;
110d3d2176aSDavid Gibson 
111d3d2176aSDavid Gibson 	if (bus->self)
112d3d2176aSDavid Gibson 		busdn = pci_device_to_OF_node(bus->self);
113d3d2176aSDavid Gibson 	else
114d3d2176aSDavid Gibson 		busdn = bus->sysdata;	/* must be a phb */
115d3d2176aSDavid Gibson 
116d3d2176aSDavid Gibson 	/* Search only direct children of the bus */
117d3d2176aSDavid Gibson 	for (dn = busdn->child; dn; dn = dn->sibling) {
118d3d2176aSDavid Gibson 		struct pci_dn *pdn = PCI_DN(dn);
119d3d2176aSDavid Gibson 		if (pdn && pdn->devfn == devfn
120d3d2176aSDavid Gibson 		    && of_device_available(dn))
121d3d2176aSDavid Gibson 			return rtas_read_config(pdn, where, size, val);
122d3d2176aSDavid Gibson 	}
123d3d2176aSDavid Gibson 
124d3d2176aSDavid Gibson 	return PCIBIOS_DEVICE_NOT_FOUND;
125d3d2176aSDavid Gibson }
126d3d2176aSDavid Gibson 
127d3d2176aSDavid Gibson int rtas_write_config(struct pci_dn *pdn, int where, int size, u32 val)
128d3d2176aSDavid Gibson {
129d3d2176aSDavid Gibson 	unsigned long buid, addr;
130d3d2176aSDavid Gibson 	int ret;
131d3d2176aSDavid Gibson 
132d3d2176aSDavid Gibson 	if (!pdn)
133d3d2176aSDavid Gibson 		return PCIBIOS_DEVICE_NOT_FOUND;
134d3d2176aSDavid Gibson 	if (!config_access_valid(pdn, where))
135d3d2176aSDavid Gibson 		return PCIBIOS_BAD_REGISTER_NUMBER;
136d3d2176aSDavid Gibson 
1376f3d5d3cSMichael Ellerman 	addr = rtas_config_addr(pdn->busno, pdn->devfn, where);
138d3d2176aSDavid Gibson 	buid = pdn->phb->buid;
139d3d2176aSDavid Gibson 	if (buid) {
140d3d2176aSDavid Gibson 		ret = rtas_call(ibm_write_pci_config, 5, 1, NULL, addr,
141d3d2176aSDavid Gibson 			BUID_HI(buid), BUID_LO(buid), size, (ulong) val);
142d3d2176aSDavid Gibson 	} else {
143d3d2176aSDavid Gibson 		ret = rtas_call(write_pci_config, 3, 1, NULL, addr, size, (ulong)val);
144d3d2176aSDavid Gibson 	}
145d3d2176aSDavid Gibson 
146d3d2176aSDavid Gibson 	if (ret)
147d3d2176aSDavid Gibson 		return PCIBIOS_DEVICE_NOT_FOUND;
148d3d2176aSDavid Gibson 
149d3d2176aSDavid Gibson 	return PCIBIOS_SUCCESSFUL;
150d3d2176aSDavid Gibson }
151d3d2176aSDavid Gibson 
152d3d2176aSDavid Gibson static int rtas_pci_write_config(struct pci_bus *bus,
153d3d2176aSDavid Gibson 				 unsigned int devfn,
154d3d2176aSDavid Gibson 				 int where, int size, u32 val)
155d3d2176aSDavid Gibson {
156d3d2176aSDavid Gibson 	struct device_node *busdn, *dn;
157d3d2176aSDavid Gibson 
158d3d2176aSDavid Gibson 	if (bus->self)
159d3d2176aSDavid Gibson 		busdn = pci_device_to_OF_node(bus->self);
160d3d2176aSDavid Gibson 	else
161d3d2176aSDavid Gibson 		busdn = bus->sysdata;	/* must be a phb */
162d3d2176aSDavid Gibson 
163d3d2176aSDavid Gibson 	/* Search only direct children of the bus */
164d3d2176aSDavid Gibson 	for (dn = busdn->child; dn; dn = dn->sibling) {
165d3d2176aSDavid Gibson 		struct pci_dn *pdn = PCI_DN(dn);
166d3d2176aSDavid Gibson 		if (pdn && pdn->devfn == devfn
167d3d2176aSDavid Gibson 		    && of_device_available(dn))
168d3d2176aSDavid Gibson 			return rtas_write_config(pdn, where, size, val);
169d3d2176aSDavid Gibson 	}
170d3d2176aSDavid Gibson 	return PCIBIOS_DEVICE_NOT_FOUND;
171d3d2176aSDavid Gibson }
172d3d2176aSDavid Gibson 
173d3d2176aSDavid Gibson struct pci_ops rtas_pci_ops = {
174d3d2176aSDavid Gibson 	rtas_pci_read_config,
175d3d2176aSDavid Gibson 	rtas_pci_write_config
176d3d2176aSDavid Gibson };
177d3d2176aSDavid Gibson 
178d3d2176aSDavid Gibson int is_python(struct device_node *dev)
179d3d2176aSDavid Gibson {
180a7f67bdfSJeremy Kerr 	const char *model = get_property(dev, "model", NULL);
181d3d2176aSDavid Gibson 
182d3d2176aSDavid Gibson 	if (model && strstr(model, "Python"))
183d3d2176aSDavid Gibson 		return 1;
184d3d2176aSDavid Gibson 
185d3d2176aSDavid Gibson 	return 0;
186d3d2176aSDavid Gibson }
187d3d2176aSDavid Gibson 
188cc5d0189SBenjamin Herrenschmidt static void python_countermeasures(struct device_node *dev)
189d3d2176aSDavid Gibson {
190cc5d0189SBenjamin Herrenschmidt 	struct resource registers;
191d3d2176aSDavid Gibson 	void __iomem *chip_regs;
192d3d2176aSDavid Gibson 	volatile u32 val;
193d3d2176aSDavid Gibson 
194cc5d0189SBenjamin Herrenschmidt 	if (of_address_to_resource(dev, 0, &registers)) {
195cc5d0189SBenjamin Herrenschmidt 		printk(KERN_ERR "Can't get address for Python workarounds !\n");
196d3d2176aSDavid Gibson 		return;
197cc5d0189SBenjamin Herrenschmidt 	}
198d3d2176aSDavid Gibson 
199d3d2176aSDavid Gibson 	/* Python's register file is 1 MB in size. */
200cc5d0189SBenjamin Herrenschmidt 	chip_regs = ioremap(registers.start & ~(0xfffffUL), 0x100000);
201d3d2176aSDavid Gibson 
202d3d2176aSDavid Gibson 	/*
203d3d2176aSDavid Gibson 	 * Firmware doesn't always clear this bit which is critical
204d3d2176aSDavid Gibson 	 * for good performance - Anton
205d3d2176aSDavid Gibson 	 */
206d3d2176aSDavid Gibson 
207d3d2176aSDavid Gibson #define PRG_CL_RESET_VALID 0x00010000
208d3d2176aSDavid Gibson 
209d3d2176aSDavid Gibson 	val = in_be32(chip_regs + 0xf6030);
210d3d2176aSDavid Gibson 	if (val & PRG_CL_RESET_VALID) {
211d3d2176aSDavid Gibson 		printk(KERN_INFO "Python workaround: ");
212d3d2176aSDavid Gibson 		val &= ~PRG_CL_RESET_VALID;
213d3d2176aSDavid Gibson 		out_be32(chip_regs + 0xf6030, val);
214d3d2176aSDavid Gibson 		/*
215d3d2176aSDavid Gibson 		 * We must read it back for changes to
216d3d2176aSDavid Gibson 		 * take effect
217d3d2176aSDavid Gibson 		 */
218d3d2176aSDavid Gibson 		val = in_be32(chip_regs + 0xf6030);
219d3d2176aSDavid Gibson 		printk("reg0: %x\n", val);
220d3d2176aSDavid Gibson 	}
221d3d2176aSDavid Gibson 
222d3d2176aSDavid Gibson 	iounmap(chip_regs);
223d3d2176aSDavid Gibson }
224d3d2176aSDavid Gibson 
225d3d2176aSDavid Gibson void __init init_pci_config_tokens (void)
226d3d2176aSDavid Gibson {
227d3d2176aSDavid Gibson 	read_pci_config = rtas_token("read-pci-config");
228d3d2176aSDavid Gibson 	write_pci_config = rtas_token("write-pci-config");
229d3d2176aSDavid Gibson 	ibm_read_pci_config = rtas_token("ibm,read-pci-config");
230d3d2176aSDavid Gibson 	ibm_write_pci_config = rtas_token("ibm,write-pci-config");
231d3d2176aSDavid Gibson }
232d3d2176aSDavid Gibson 
233d3d2176aSDavid Gibson unsigned long __devinit get_phb_buid (struct device_node *phb)
234d3d2176aSDavid Gibson {
2356506e710SBenjamin Herrenschmidt 	struct resource r;
236d3d2176aSDavid Gibson 
2376506e710SBenjamin Herrenschmidt 	if (ibm_read_pci_config == -1)
238d3d2176aSDavid Gibson 		return 0;
2396506e710SBenjamin Herrenschmidt 	if (of_address_to_resource(phb, 0, &r))
240d3d2176aSDavid Gibson 		return 0;
2416506e710SBenjamin Herrenschmidt 	return r.start;
242d3d2176aSDavid Gibson }
243d3d2176aSDavid Gibson 
244d3d2176aSDavid Gibson static int phb_set_bus_ranges(struct device_node *dev,
245d3d2176aSDavid Gibson 			      struct pci_controller *phb)
246d3d2176aSDavid Gibson {
247a7f67bdfSJeremy Kerr 	const int *bus_range;
248d3d2176aSDavid Gibson 	unsigned int len;
249d3d2176aSDavid Gibson 
250a7f67bdfSJeremy Kerr 	bus_range = get_property(dev, "bus-range", &len);
251d3d2176aSDavid Gibson 	if (bus_range == NULL || len < 2 * sizeof(int)) {
252d3d2176aSDavid Gibson 		return 1;
253d3d2176aSDavid Gibson  	}
254d3d2176aSDavid Gibson 
255d3d2176aSDavid Gibson 	phb->first_busno =  bus_range[0];
256d3d2176aSDavid Gibson 	phb->last_busno  =  bus_range[1];
257d3d2176aSDavid Gibson 
258d3d2176aSDavid Gibson 	return 0;
259d3d2176aSDavid Gibson }
260d3d2176aSDavid Gibson 
2614c9d2800SBenjamin Herrenschmidt int __devinit rtas_setup_phb(struct pci_controller *phb)
262d3d2176aSDavid Gibson {
2634c9d2800SBenjamin Herrenschmidt 	struct device_node *dev = phb->arch_data;
2644c9d2800SBenjamin Herrenschmidt 
265d3d2176aSDavid Gibson 	if (is_python(dev))
266cc5d0189SBenjamin Herrenschmidt 		python_countermeasures(dev);
267d3d2176aSDavid Gibson 
268d3d2176aSDavid Gibson 	if (phb_set_bus_ranges(dev, phb))
269d3d2176aSDavid Gibson 		return 1;
270d3d2176aSDavid Gibson 
271d3d2176aSDavid Gibson 	phb->ops = &rtas_pci_ops;
272d3d2176aSDavid Gibson 	phb->buid = get_phb_buid(dev);
273d3d2176aSDavid Gibson 
274d3d2176aSDavid Gibson 	return 0;
275d3d2176aSDavid Gibson }
276d3d2176aSDavid Gibson 
277d3d2176aSDavid Gibson unsigned long __init find_and_init_phbs(void)
278d3d2176aSDavid Gibson {
279d3d2176aSDavid Gibson 	struct device_node *node;
280d3d2176aSDavid Gibson 	struct pci_controller *phb;
281d3d2176aSDavid Gibson 	unsigned int index;
282d3d2176aSDavid Gibson 	struct device_node *root = of_find_node_by_path("/");
283d3d2176aSDavid Gibson 
284d3d2176aSDavid Gibson 	index = 0;
285d3d2176aSDavid Gibson 	for (node = of_get_next_child(root, NULL);
286d3d2176aSDavid Gibson 	     node != NULL;
287d3d2176aSDavid Gibson 	     node = of_get_next_child(root, node)) {
288bb53bb3dSJake Moilanen 
289bb53bb3dSJake Moilanen 		if (node->type == NULL || (strcmp(node->type, "pci") != 0 &&
290bb53bb3dSJake Moilanen 					   strcmp(node->type, "pciex") != 0))
291d3d2176aSDavid Gibson 			continue;
292d3d2176aSDavid Gibson 
293b5166cc2SBenjamin Herrenschmidt 		phb = pcibios_alloc_controller(node);
294d3d2176aSDavid Gibson 		if (!phb)
295d3d2176aSDavid Gibson 			continue;
2964c9d2800SBenjamin Herrenschmidt 		rtas_setup_phb(phb);
297d3d2176aSDavid Gibson 		pci_process_bridge_OF_ranges(phb, node, 0);
298d3d2176aSDavid Gibson 		pci_setup_phb_io(phb, index == 0);
299d3d2176aSDavid Gibson 		index++;
300d3d2176aSDavid Gibson 	}
301d3d2176aSDavid Gibson 
302d3d2176aSDavid Gibson 	of_node_put(root);
303d3d2176aSDavid Gibson 	pci_devs_phb_init();
304d3d2176aSDavid Gibson 
305d3d2176aSDavid Gibson 	/*
306d3d2176aSDavid Gibson 	 * pci_probe_only and pci_assign_all_buses can be set via properties
307d3d2176aSDavid Gibson 	 * in chosen.
308d3d2176aSDavid Gibson 	 */
309d3d2176aSDavid Gibson 	if (of_chosen) {
310a7f67bdfSJeremy Kerr 		const int *prop;
311d3d2176aSDavid Gibson 
312a7f67bdfSJeremy Kerr 		prop = get_property(of_chosen,
313a7f67bdfSJeremy Kerr 				"linux,pci-probe-only", NULL);
314d3d2176aSDavid Gibson 		if (prop)
315d3d2176aSDavid Gibson 			pci_probe_only = *prop;
316d3d2176aSDavid Gibson 
317a7f67bdfSJeremy Kerr 		prop = get_property(of_chosen,
318d3d2176aSDavid Gibson 				"linux,pci-assign-all-buses", NULL);
319d3d2176aSDavid Gibson 		if (prop)
320d3d2176aSDavid Gibson 			pci_assign_all_buses = *prop;
321d3d2176aSDavid Gibson 	}
322d3d2176aSDavid Gibson 
323d3d2176aSDavid Gibson 	return 0;
324d3d2176aSDavid Gibson }
325d3d2176aSDavid Gibson 
326d3d2176aSDavid Gibson /* RPA-specific bits for removing PHBs */
327d3d2176aSDavid Gibson int pcibios_remove_root_bus(struct pci_controller *phb)
328d3d2176aSDavid Gibson {
329d3d2176aSDavid Gibson 	struct pci_bus *b = phb->bus;
330d3d2176aSDavid Gibson 	struct resource *res;
331d3d2176aSDavid Gibson 	int rc, i;
332d3d2176aSDavid Gibson 
333d3d2176aSDavid Gibson 	res = b->resource[0];
334d3d2176aSDavid Gibson 	if (!res->flags) {
335d3d2176aSDavid Gibson 		printk(KERN_ERR "%s: no IO resource for PHB %s\n", __FUNCTION__,
336d3d2176aSDavid Gibson 				b->name);
337d3d2176aSDavid Gibson 		return 1;
338d3d2176aSDavid Gibson 	}
339d3d2176aSDavid Gibson 
340d3d2176aSDavid Gibson 	rc = unmap_bus_range(b);
341d3d2176aSDavid Gibson 	if (rc) {
342d3d2176aSDavid Gibson 		printk(KERN_ERR "%s: failed to unmap IO on bus %s\n",
343d3d2176aSDavid Gibson 			__FUNCTION__, b->name);
344d3d2176aSDavid Gibson 		return 1;
345d3d2176aSDavid Gibson 	}
346d3d2176aSDavid Gibson 
347d3d2176aSDavid Gibson 	if (release_resource(res)) {
348d3d2176aSDavid Gibson 		printk(KERN_ERR "%s: failed to release IO on bus %s\n",
349d3d2176aSDavid Gibson 				__FUNCTION__, b->name);
350d3d2176aSDavid Gibson 		return 1;
351d3d2176aSDavid Gibson 	}
352d3d2176aSDavid Gibson 
353d3d2176aSDavid Gibson 	for (i = 1; i < 3; ++i) {
354d3d2176aSDavid Gibson 		res = b->resource[i];
355d3d2176aSDavid Gibson 		if (!res->flags && i == 0) {
356d3d2176aSDavid Gibson 			printk(KERN_ERR "%s: no MEM resource for PHB %s\n",
357d3d2176aSDavid Gibson 				__FUNCTION__, b->name);
358d3d2176aSDavid Gibson 			return 1;
359d3d2176aSDavid Gibson 		}
360d3d2176aSDavid Gibson 		if (res->flags && release_resource(res)) {
361d3d2176aSDavid Gibson 			printk(KERN_ERR
362d3d2176aSDavid Gibson 			       "%s: failed to release IO %d on bus %s\n",
363d3d2176aSDavid Gibson 				__FUNCTION__, i, b->name);
364d3d2176aSDavid Gibson 			return 1;
365d3d2176aSDavid Gibson 		}
366d3d2176aSDavid Gibson 	}
367d3d2176aSDavid Gibson 
368b5166cc2SBenjamin Herrenschmidt 	pcibios_free_controller(phb);
369d3d2176aSDavid Gibson 
370d3d2176aSDavid Gibson 	return 0;
371d3d2176aSDavid Gibson }
372d3d2176aSDavid Gibson EXPORT_SYMBOL(pcibios_remove_root_bus);
373