16fd81a51SAndrew Jeffery# Changelog 26fd81a51SAndrew Jeffery 36fd81a51SAndrew JefferyAll notable changes to this project will be documented in this file. 46fd81a51SAndrew Jeffery 56fd81a51SAndrew JefferyThe format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), 66fd81a51SAndrew Jefferyand this project adheres to 76fd81a51SAndrew Jeffery[Semantic Versioning](https://semver.org/spec/v2.0.0.html). 86fd81a51SAndrew Jeffery 96fd81a51SAndrew JefferyChange categories: 106fd81a51SAndrew Jeffery 116fd81a51SAndrew Jeffery- Added 126fd81a51SAndrew Jeffery- Changed 136fd81a51SAndrew Jeffery- Deprecated 146fd81a51SAndrew Jeffery- Removed 156fd81a51SAndrew Jeffery- Fixed 166fd81a51SAndrew Jeffery- Security 176fd81a51SAndrew Jeffery 186fd81a51SAndrew Jeffery## [Unreleased] 1939f88325SRashmica Gupta 20044ee19aSAndrew Jeffery### Added 21044ee19aSAndrew Jeffery 22044ee19aSAndrew Jeffery1. bios_table: Introduce pldm_bios_table_append_pad_checksum_check() 237cd16ff8SAndrew Jeffery2. fru: Introduce get_fru_record_by_option_check() 24044ee19aSAndrew Jeffery 25986df2a1SAndrew Jeffery### Changed 26986df2a1SAndrew Jeffery 27986df2a1SAndrew Jeffery1. requester: Mark pldm_close() as LIBPLDM_ABI_TESTING 285fb9680bSAndrew Jeffery2. requester: Expose pldm_close() in header 29a873eca0SAndrew Jeffery3. bios_table: pldm_bios_table_string_entry_encode_check(): Handle overflow 30757e81a1SAndrew Jeffery4. bios_table: pldm_bios_table_iter_create(): Return NULL on failed alloc 3173d9176aSAndrew Jeffery5. bios_table: pldm_bios_table_iter_next(): Invalid entry halts iteration 32a8bb22edSAndrew Jeffery6. pdr: pldm_pdr_init(): Return NULL on allocation failure 33fca1b60fSAndrew Jeffery7. pdr: pldm_pdr_destroy(): Exit early if repo is NULL 34*5565fcdeSAndrew Jeffery8. pdr: Document preconditions for trivial accessor functions 35*5565fcdeSAndrew Jeffery 36*5565fcdeSAndrew Jeffery A trivial accessor function is one that exposes properties of an object in a 37*5565fcdeSAndrew Jeffery way can't result in an error, beyond passing an invalid argument to the 38*5565fcdeSAndrew Jeffery function. For APIs meeting this definition we define a precondition that 39*5565fcdeSAndrew Jeffery struct pointers must point to valid objects to avoid polluting the function 40*5565fcdeSAndrew Jeffery prototypes. The following APIs now have this precondition explicitly defined: 41*5565fcdeSAndrew Jeffery 42*5565fcdeSAndrew Jeffery - pldm_entity_extract() 43*5565fcdeSAndrew Jeffery - pldm_entity_get_parent() 44*5565fcdeSAndrew Jeffery - pldm_entity_is_exist_parent() 45*5565fcdeSAndrew Jeffery - pldm_entity_is_node_parent() 46*5565fcdeSAndrew Jeffery - pldm_is_current_parent_child 47*5565fcdeSAndrew Jeffery - pldm_is_empty_entity_assoc_tree() 48*5565fcdeSAndrew Jeffery - pldm_pdr_get_record_count() 49*5565fcdeSAndrew Jeffery - pldm_pdr_get_record_handle() 50*5565fcdeSAndrew Jeffery - pldm_pdr_get_repo_size() 51*5565fcdeSAndrew Jeffery - pldm_pdr_record_is_remote() 52986df2a1SAndrew Jeffery 53fe0f01d8SAndrew Jeffery### Deprecated 54fe0f01d8SAndrew Jeffery 55fe0f01d8SAndrew Jeffery1. pldm_bios_table_attr_entry_integer_encode() 56fe0f01d8SAndrew Jeffery 57fe0f01d8SAndrew Jeffery Migrate to pldm_bios_table_attr_entry_integer_encode_check() 58fe0f01d8SAndrew Jeffery 597aeb7edbSAndrew Jeffery2. bios_table: Deprecate pldm_bios_table_attr_value_entry_encode_enum() 607aeb7edbSAndrew Jeffery 617aeb7edbSAndrew Jeffery Migrate to pldm_bios_table_attr_value_entry_encode_enum_check() 627aeb7edbSAndrew Jeffery 632d66393fSAndrew Jeffery3. bios_table: Deprecate pldm_bios_table_attr_value_entry_encode_string() 642d66393fSAndrew Jeffery 652d66393fSAndrew Jeffery Migrate to pldm_bios_table_attr_value_entry_encode_string_check() 662d66393fSAndrew Jeffery 670088a6aeSAndrew Jeffery4. bios_table: Deprecate pldm_bios_table_attr_value_entry_encode_integer() 680088a6aeSAndrew Jeffery 690088a6aeSAndrew Jeffery Migrate to pldm_bios_table_attr_value_entry_encode_integer_check() 700088a6aeSAndrew Jeffery 716409c8a0SAndrew Jeffery### Removed 726409c8a0SAndrew Jeffery 736409c8a0SAndrew Jeffery1. bios_table: Remove deprecated APIs sanitized by assert(): 746409c8a0SAndrew Jeffery 756409c8a0SAndrew Jeffery - pldm_bios_table_string_entry_encode() 766409c8a0SAndrew Jeffery - pldm_bios_table_string_entry_decode_string() 776409c8a0SAndrew Jeffery - pldm_bios_table_attr_entry_enum_encode() 786409c8a0SAndrew Jeffery - pldm_bios_table_attr_entry_enum_decode_pv_num() 796409c8a0SAndrew Jeffery - pldm_bios_table_attr_entry_enum_decode_def_num() 806409c8a0SAndrew Jeffery - pldm_bios_table_attr_entry_enum_decode_pv_hdls() 816409c8a0SAndrew Jeffery - pldm_bios_table_attr_entry_string_encode() 826409c8a0SAndrew Jeffery - pldm_bios_table_attr_entry_string_decode_def_string_length() 836409c8a0SAndrew Jeffery 8409778a82SAndrew Jeffery### Fixed 85ffd5342cSPavithra Barithaya 86ffd5342cSPavithra Barithaya1. pdr: Return success for pldm_pdr_find_child_container_id_range_exclude() API 878cf70456SPavithra Barithaya2. pdr: Rework pldm_pdr_find_container_id_range_exclude() API 88a4da6858SAndrew Jeffery3. transport: mctp-demux: Don't test socket for non-zero value 894e1ba8a7SAndrew Jeffery4. requester: Return PLDM_REQUESTER_OPEN_FAIL from pldm_open() on error 90ffd5342cSPavithra Barithaya 91291da195SAndrew Jeffery## [0.3.0] - 2023-06-23 92291da195SAndrew Jeffery 937c250340SDung Cao### Added 947c250340SDung Cao 957c250340SDung Cao1. Add encode/decode pldmMessagePollEvent data 9683841fb5SAndrew Jeffery2. README: Add a section on working with libpldm 9739bd2ea5SArchanaKakani3. pdr: Introduce remote_container_id and associated APIs 989947f9d6SPavithra Barithaya4. pdr: Add APIs for creating and locating remote PDRs 994d694346SPavithra Barithaya5. pdr: Add pldm_pdr_find_last_in_range() 10025ddbccfSPavithra Barithaya6. pdr: Add pldm_entity_association_pdr_add_from_node_with_record_handle() 1015dc02571SPavithra Barithaya7. pdr: Add pldm_pdr_find_container_id_range_exclude() 1027c250340SDung Cao 103b443b487SRashmica Gupta### Changed 104b443b487SRashmica Gupta 105b443b487SRashmica Gupta1. include: Move installed transport.h under libpldm/ 10683841fb5SAndrew Jeffery2. libpldm: Explicit deprecated, stable and testing ABI classes 1078de8e1ecSAndrew Jeffery3. meson: Reduce strength of oem-ibm requirements from enabled to allowed 1088de8e1ecSAndrew Jeffery 1098de8e1ecSAndrew Jeffery The `oem-ibm` feature is now enabled by the default meson configuration, for 1108de8e1ecSAndrew Jeffery CI purposes. `oem-ibm` is still disabled by default in the `libpldm` bitbake 1118de8e1ecSAndrew Jeffery recipe: 1128de8e1ecSAndrew Jeffery 1138de8e1ecSAndrew Jeffery https://github.com/openbmc/openbmc/blob/master/meta-phosphor/recipes-phosphor/libpldm/libpldm_git.bb#L10 1148de8e1ecSAndrew Jeffery 1158de8e1ecSAndrew Jeffery To disable `oem-ibm` in your development builds, pass `-Doem-ibm=disabled` 1168de8e1ecSAndrew Jeffery when invoking `meson setup` 117b443b487SRashmica Gupta 11898c1e69dSAndrew Jeffery4. bios_table: Relax pldm_bios_table_string_entry_decode_string_check() 1190c9f5a8aSAndrew Jeffery5. bios_table: Relax pldm_bios_table_attr_entry_enum_decode_pv_hdls_check() 12098c1e69dSAndrew Jeffery 121d47e8ab8SAndrew Jeffery### Deprecated 122d47e8ab8SAndrew Jeffery 123d47e8ab8SAndrew Jeffery1. bios_table: Deprecate APIs with arguments sanitized using assert() 124d47e8ab8SAndrew Jeffery 125d47e8ab8SAndrew Jeffery C provides enough foot-guns without us encoding them into library APIs. 126d47e8ab8SAndrew Jeffery Specifically, deprecate the following in favour of their `*_check()` variants 127d47e8ab8SAndrew Jeffery which ensure assertions won't fail or otherwise invoke UB: 128d47e8ab8SAndrew Jeffery 129d47e8ab8SAndrew Jeffery - pldm_bios_table_string_entry_encode() 130d47e8ab8SAndrew Jeffery - pldm_bios_table_string_entry_decode_string() 131d47e8ab8SAndrew Jeffery - pldm_bios_table_attr_entry_enum_encode() 132d47e8ab8SAndrew Jeffery - pldm_bios_table_attr_entry_enum_decode_pv_num() 133d47e8ab8SAndrew Jeffery - pldm_bios_table_attr_entry_enum_decode_def_num() 134d47e8ab8SAndrew Jeffery - pldm_bios_table_attr_entry_enum_decode_pv_hdls() 135d47e8ab8SAndrew Jeffery - pldm_bios_table_attr_entry_string_encode() 136d47e8ab8SAndrew Jeffery - pldm_bios_table_attr_entry_string_decode_def_string_length() 137d47e8ab8SAndrew Jeffery 1384b4603b3SAndrew Jeffery### Removed 1394b4603b3SAndrew Jeffery 1404b4603b3SAndrew Jeffery1. libpldm: Remove the requester-api option 1414b4603b3SAndrew Jeffery 14239f88325SRashmica Gupta### Fixed 14339f88325SRashmica Gupta 14439f88325SRashmica Gupta1. requester: Make pldm_open() return existing fd 145abaf61f4SDung Cao2. transport: Prevent sticking in waiting for response 146b01fb1ccSThu Nguyen3. transport: Match on response in pldm_transport_send_recv_msg() 147a3035938SRashmica Gupta4. requester: Add check before accessing hdr in pldm_recv() 148df02e360SAndrew Jeffery5. bios_table: pldm_bios_table_attr_entry_string_info_check() NULL deref 149