xref: /openbmc/docs/maintainer-workflow.md (revision 438793f3fd5ecf2f51e6a230662e88778fc3d44f)
1ac95da4aSBrad Bishop# OpenBMC Maintainer/CLA Workflow
2ac95da4aSBrad BishopOpenBMC contributors are required to execute an OpenBMC CLA (Contributor
3ac95da4aSBrad BishopLicense Agreement) before their contributions can be accepted.  This page is a
4ac95da4aSBrad Bishopchecklist for sub-project maintainers to follow before approving patches.
5ac95da4aSBrad Bishop
6ac95da4aSBrad Bishop* Manually verify the contributor has signed the ICLA (individual) or is
7ac95da4aSBrad Bishoplisted on an existing CCLA (corporate).
8563414d9SGunnar Mills  * Executed CLAs can be found [in the CLA repository][1].
9ac95da4aSBrad Bishop  * If you were not added to the appropriate CLA repository ACL send an
10ac95da4aSBrad Bishopemail to openbmc@lists.ozlabs.org with a request to be added.
11ac95da4aSBrad Bishop  * If a CLA for the contributor is found, accept the patch(1).
12ac95da4aSBrad Bishop* If a CLA is not found, request that the contributor execute one and send it
13effb5a28SMilton Millerto manager@lfprojects.org.
14ac95da4aSBrad Bishop  * Do not accept the patch(1) until a signed CLA (individual _or_
15ac95da4aSBrad Bishopcorporate) has been uploaded to the CLA repository.
16563414d9SGunnar Mills  * The CCLA form can be found [here][2].
17563414d9SGunnar Mills  * The ICLA form can be found [here][3].
18ac95da4aSBrad Bishop
1994b94e50SJoseph ReynoldsAn executed OpenBMC CLA is _not_ required to accept contributions to
2094b94e50SJoseph ReynoldsOpenBMC forks of upstream projects, like the Linux kernel or U-Boot.
2194b94e50SJoseph Reynolds
2294b94e50SJoseph ReynoldsReview the maintainers' responsibilities in the [contributing
2394b94e50SJoseph Reynoldsguidelines](./CONTRIBUTING.md).  Maintainers are ultimately
2494b94e50SJoseph Reynoldsresponsible for sorting out open source license issues, issues with
2594b94e50SJoseph Reynoldsusing code copied from the web, and maintaining the quality of the
2694b94e50SJoseph Reynoldscode.
2794b94e50SJoseph Reynolds
2894b94e50SJoseph ReynoldsRepository maintainers ought to have the following traits as
2994b94e50SJoseph Reynoldsrecognized by a consensus of their peers:
3094b94e50SJoseph Reynolds - responsible: have a continuing desire to ensure only high-quality
3194b94e50SJoseph Reynolds   code goes into the repo
32563414d9SGunnar Mills - leadership: foster open-source aware practices such as [FOSS][4]
3394b94e50SJoseph Reynolds - expertise: typically demonstrated by significant contributions to
3494b94e50SJoseph Reynolds   the code or code reviews
3594b94e50SJoseph Reynolds
36ac95da4aSBrad Bishop(1) The semantics of accepting a patch depend on the sub-project contribution
37ac95da4aSBrad Bishopprocess.
38ac95da4aSBrad Bishop
392b66c9e2SGunnar Mills* GitHub pull requests - Merging the pull request.
40ac95da4aSBrad Bishop* Gerrit - +2.
41ac95da4aSBrad Bishop* email - Merging the patch.
42ac95da4aSBrad Bishop
4394b94e50SJoseph ReynoldsEnsure that accepted changes actually merge into OpenBMC repositories.
44563414d9SGunnar Mills
45563414d9SGunnar Mills[1]: https://drive.google.com/drive/folders/1Ooi0RdTcaOWF1DWFJUAJDdN7tRKde7Nl
46*438793f3SBrad Bishop[2]: https://drive.google.com/file/d/1d-2M8ng_Dl2j1odsvZ8o1QHAdHB-pNSH
47*438793f3SBrad Bishop[3]: https://drive.google.com/file/d/1k3fc7JPgzKdItEfyIoLxMCVbPUhTwooY
48563414d9SGunnar Mills[4]: https://en.wikipedia.org/wiki/Free_and_open-source_software
49