xref: /openbmc/docs/maintainer-workflow.md (revision f4febd002df578bad816239b70950f84ea4567e8)
1ac95da4aSBrad Bishop# OpenBMC Maintainer/CLA Workflow
2ac95da4aSBrad Bishop
3*f4febd00SPatrick WilliamsOpenBMC contributors are required to execute an OpenBMC CLA (Contributor License
4*f4febd00SPatrick WilliamsAgreement) before their contributions can be accepted. This page is a checklist
5*f4febd00SPatrick Williamsfor sub-project maintainers to follow before approving patches.
6ac95da4aSBrad Bishop
7*f4febd00SPatrick Williams- Manually verify the contributor has signed the ICLA (individual) or is listed
8*f4febd00SPatrick Williams  on an existing CCLA (corporate).
9*f4febd00SPatrick Williams  - Executed CLAs can be found [in the CLA repository][1].
10*f4febd00SPatrick Williams  - If you were not added to the appropriate CLA repository ACL send an email to
11*f4febd00SPatrick Williams    openbmc@lists.ozlabs.org with a request to be added.
12*f4febd00SPatrick Williams  - If a CLA for the contributor is found, accept the patch(1).
13*f4febd00SPatrick Williams- If a CLA is not found, request that the contributor execute one and send it to
14*f4febd00SPatrick Williams  manager@lfprojects.org.
15*f4febd00SPatrick Williams  - Do not accept the patch(1) until a signed CLA (individual _or_ corporate)
16*f4febd00SPatrick Williams    has been uploaded to the CLA repository.
17*f4febd00SPatrick Williams  - The CCLA form can be found [here][2].
18*f4febd00SPatrick Williams  - The ICLA form can be found [here][3].
1994b94e50SJoseph Reynolds
20*f4febd00SPatrick WilliamsAn executed OpenBMC CLA is _not_ required to accept contributions to OpenBMC
21*f4febd00SPatrick Williamsforks of upstream projects, like the Linux kernel or U-Boot.
2294b94e50SJoseph Reynolds
23*f4febd00SPatrick WilliamsReview the maintainers' responsibilities in the
24*f4febd00SPatrick Williams[contributing guidelines](./CONTRIBUTING.md). Maintainers are ultimately
25*f4febd00SPatrick Williamsresponsible for sorting out open source license issues, issues with using code
26*f4febd00SPatrick Williamscopied from the web, and maintaining the quality of the code.
27*f4febd00SPatrick Williams
28*f4febd00SPatrick WilliamsRepository maintainers ought to have the following traits as recognized by a
29*f4febd00SPatrick Williamsconsensus of their peers:
30*f4febd00SPatrick Williams
31*f4febd00SPatrick Williams- responsible: have a continuing desire to ensure only high-quality code goes
32*f4febd00SPatrick Williams  into the repo
33563414d9SGunnar Mills- leadership: foster open-source aware practices such as [FOSS][4]
34*f4febd00SPatrick Williams- expertise: typically demonstrated by significant contributions to the code or
35*f4febd00SPatrick Williams  code reviews
3694b94e50SJoseph Reynolds
37ac95da4aSBrad Bishop(1) The semantics of accepting a patch depend on the sub-project contribution
38ac95da4aSBrad Bishopprocess.
39ac95da4aSBrad Bishop
40*f4febd00SPatrick Williams- GitHub pull requests - Merging the pull request.
41*f4febd00SPatrick Williams- Gerrit - +2.
42*f4febd00SPatrick Williams- email - Merging the patch.
43ac95da4aSBrad Bishop
4494b94e50SJoseph ReynoldsEnsure that accepted changes actually merge into OpenBMC repositories.
45563414d9SGunnar Mills
46563414d9SGunnar Mills[1]: https://drive.google.com/drive/folders/1Ooi0RdTcaOWF1DWFJUAJDdN7tRKde7Nl
47438793f3SBrad Bishop[2]: https://drive.google.com/file/d/1d-2M8ng_Dl2j1odsvZ8o1QHAdHB-pNSH
48438793f3SBrad Bishop[3]: https://drive.google.com/file/d/1k3fc7JPgzKdItEfyIoLxMCVbPUhTwooY
49563414d9SGunnar Mills[4]: https://en.wikipedia.org/wiki/Free_and_open-source_software
50